Commit Graph

6140 Commits

Author SHA1 Message Date
Ayangade Adeoluwa
7f04f32ac2
fixes undefined error coming from datasource rest api form values (#9952) 2021-12-23 18:09:11 +01:00
Leo Thomas
69c76c299f
fix: Incorrect error handling when incorrect sheet name is used in Google Sheets query (#9771)
* fix/9463-Incorrect error handling when incorrect sheet name is used in Google Sheets query

* Code review changes v1
2021-12-23 21:25:02 +05:30
Vicky Bansal
d40226e937
fix: Default date to remain empty value when binding value is empty (#9823) 2021-12-23 21:21:28 +05:30
Paul Li
e789b1293b
fix: Audio recorder widget - group styling properties (#7643)
* Fix: Audio recorder widget styling property needs to be categorized under Styles not General

-- Group style related properties

* Fix: Audio recorder widget styling property needs to be categorized under Styles not General

-- Move styles section to the bottom of the layout
2021-12-23 14:17:47 +00:00
Hetu Nandu
39b0a4e5a6
feat: Native promises support in Appsmith (#8988)
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-12-23 14:17:20 +00:00
Bhavin K
244b089771
fix: added support for timePrecision (#9423) 2021-12-23 14:17:08 +00:00
Sumit Kumar
4b75f77caa
feat: add support for projection, sort and pagination. (#9712)
* Add API server support for UQI's Projection, Sorting and Pagination feature.
2021-12-23 14:16:49 +00:00
Nidhi
9af1f4c9f4
fix: Switched reference from package name to plugin name (#9916) 2021-12-23 14:16:30 +00:00
Nidhi
b2855ccf77
fix: Do not return JS actions when fetching page actions (#9960) 2021-12-23 14:16:16 +00:00
Shrikant Sharat Kandula
20cfc44b02
Fix toast message on reset password (#9957) 2021-12-23 14:16:09 +00:00
Sumit Kumar
cdcb657229
add query params from datasource to URI (#9963)
Add query params from datasource to final URI used for REST API query.
2021-12-23 14:15:54 +00:00
balajisoundar
8d3e3fd88b
fix: remove allowed filetype restriction in filepickerwidget (#9921) 2021-12-23 18:46:57 +05:30
Sumit Kumar
4a075628d7
fix: add work around to handle bad data in Firestore UQI migration (#9966)
* add another migration for those Firestore actions that could not be migrated.
* handle ClassCastException via try catch and assigning default empty value.
2021-12-23 15:59:53 +05:30
Abhijeet
0e0b4d0d1e
Check for layoutOnLoadAction during clone application (#9947) 2021-12-22 21:40:19 +05:30
haojin111
8567d67ef9
fix: disconnect git and repo connect error UI modal (#9833) 2021-12-22 01:26:32 +05:30
Rishabh Saxena
f91e457db9
chore: show only ssh key in the deploy key UI section and remove the label (#9882) 2021-12-21 21:27:26 +05:30
Anand Srinivasan
3a4658c8f5
fix: unexpected return error (#9432)
* assign undefined for empty scripts during evaluation

* add unit tests

* handle anonymous_function when undefined

* update unit tests

* remove unwanted assignments in evaluation scripts

* update unit tests

* Update app/client/src/workers/evaluate.test.ts

* fix lint cypress tests

* remove semicolon

* fix API_bugs_spec

* undo anonymous function change

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* add comment

* return back when JS is empty

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-21 20:00:19 +05:30
Anagh Hegde
4f4d0fd7df
fix: Clear the cache - git limit number of repos (#9874)
* Error handling for git limit

* clear cahe of git limit on connect api

* update per review

* check the repo is public before checking for the limit

* changes per review

* check if the repo is public or private during connect flow
2021-12-21 14:17:26 +00:00
Nikhil Nandagopal
0b0b978245
chore: Updated Template for CRUD DB template (#9913) 2021-12-21 19:34:37 +05:30
Rishabh Saxena
5ec308ce90
fix: git config updates (#9818) 2021-12-21 19:16:37 +05:30
Sumit Kumar
c858edf726
fix Mongo smart substitution for quotes around ObjectId (#9856)
- fix Mongo plugin's smart substitution feature to handle quotes around ObjectId in array. e.g. Initial replacement value: ["ObjectId(xyz)"] , final replacement value: [ObjectId(xyz)]
- unrelated: added version number to lombok dependency to stop build failures in IntelliJ.
2021-12-21 18:47:19 +05:30
Shrikant Sharat Kandula
2dec964e21
Add migration for new MongoDB mock endpoint (#9909)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-21 18:04:12 +05:30
Abhijeet
20649ccb0a
fix: Fixes issues related to git profile and use appsmith user profile as a fallback value (#9891)
* Fixes related to git profile

* Added a TC for connect application with empty git profile and null default git profile
2021-12-21 16:45:56 +05:30
Arpit Mohan
bbe7267b6e
ci: Adding Vercel integration because of issues with Netlify (#9903)
Netlify builds are failing because of seemingly memory constraints. Also they are taking twice as long as Vercel. 

This is an experiment to see if we can switch to Vercel for our deploy preview needs.
2021-12-21 15:33:12 +05:30
Keyur Paralkar
848bc13bc3
fix: corrected Index cond. for conditional formatting in table widget (#9735)
* fix: corrected Index cond. for conditional formatting in table widget

* test: added integration test for checking condtional formating post sorting

* refactor: enhanced the originalIndex condition with nullish coalescing op
2021-12-21 15:25:12 +05:30
Aishwarya-U-R
13f24cbce8
test: Automated tests for Rest Api, S3 Bugs and flakiness fixes (#9695) 2021-12-21 15:07:30 +05:30
NandanAnantharamu
d8e41b4b5c
test: updated org test (#9868) 2021-12-21 13:38:10 +05:30
Sumit Kumar
b8cfc18f7f
fix: fix firestore pagination cyclic dependency error (#9892)
* fix firestore pagination cyclic dependency error
fix firestore UQI migration error

* fix TC
2021-12-21 11:27:05 +05:30
Abhijeet
95869517f6
fix: Replace default IDs for forked application with destination resource IDs (#9886) 2021-12-21 11:19:00 +05:30
akash-codemonk
48267bf239
Fix mock Postgres database endpoint (#9593) 2021-12-21 11:13:19 +05:30
Parthvi12
293ddc3ea1
adding test cases for undo/redo (#9742) 2021-12-21 10:44:58 +05:30
Leo Thomas
77433cf62b
feat: Add support to send arbitrary form values to oAuth server during Datasource authentication (#9660)
* feat:9389  Add support to send arbitrary form values to oAuth server during Datasource authentication

* Changes related to Code Review Comments of PR 9650

* Changes implemented to set custom Key Value pairs

* Resolved Code Review comments

* Resolved Code Review comments
2021-12-21 10:12:26 +05:30
Nayan
a447c6ee5d
Hide updated date when application was not updated manually (#9493)
We should last updated date of an application in the home page. If an application was updated internally e.g. a new user was added to the application, the updated date was set and it was displayed in the home page. This PR fixes that problem.
2021-12-20 22:54:02 +00:00
Arpit Mohan
96677ef673
fix: Updating log4j to 2.17.0 to prevent JNDI lookups (#9863)
Also making minor edit to not show "Application name updated" toast message. This is a counter-productive toast that is distracting the user
2021-12-20 16:01:08 +05:30
balajisoundar
2796bf0baf
fix: handle undefined filterdata props in table widget (#9832) 2021-12-20 15:41:33 +05:30
Anagh Hegde
8a75928c2f
fix: Fix the wrong CS url for private repo limit check (#9865) 2021-12-20 15:16:57 +05:30
arunvjn
99a12be018
feat: add option to delete org (#9287)
Co-authored-by: Nayan <nayan@appsmith.com>
2021-12-20 05:58:01 +00:00
Rishabh Saxena
29d90166af
chore: update font for the user settings title (#9854) 2021-12-20 11:19:17 +05:30
Ankita Kinger
aa190fb434
fix: Excluded hyphen substitution in branch name validation (#9842)
* added exception for hyphen in branch name validation

* created jest test case for branchlist removeSpecialChars function
2021-12-20 10:22:28 +05:30
Anagh Hegde
1b30c58617
feat: Limit private git repos which can be connected within organization (#9803)
* Added check for private repos

* WIP limit repos

* Get the git connected apps from git

* Call CS to get the limit for the git connected apps

* Update comment

* Changes per review

* Add check for limiting the repo

* Cache the results from cloud service

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2021-12-18 17:40:46 +00:00
Leo Thomas
03afb6df22
fix: Handled a possible null key from headers - NullPointerException in sentry (#9810) 2021-12-18 22:42:00 +05:30
imgbot[bot]
387aed75e1
chore: [ImgBot] Optimize images (#9855)
*Total -- 311.31kb -> 173.82kb (44.16%)

/deploy/digital_ocean/images/edit-app.png -- 309.70kb -> 172.23kb (44.39%)
/app/client/src/assets/icons/widget/switch-group.svg -- 1.60kb -> 1.59kb (0.61%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-12-18 22:40:28 +05:30
Abhijeet
5e6e6caedb
fix: Use Appsmith user profile as a fallback git profile (#9821)
* Added appsmith profile as a fallback value

* Modified TC for userData to include git profile TCs

* Added check for null value when user want to use repo level profile and provide empty author name or email

* Refactor method names
2021-12-18 21:36:25 +05:30
Nayan
68a9584fd9
fix: removed sentry reposrting when application not found (#9839) 2021-12-17 20:16:49 +05:30
Abhijeet
4bc86a906f
chore: Update default local git repo path as per docker-volume requirements (#9804)
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-17 14:30:54 +00:00
Ayangade Adeoluwa
b763fa03d3
fix: fixes inability to rename other widgets, jsactions, pages (#9848)
* fixes inability to rename other widgets, jsactions, pages

* adds edge case to handle renaming non action based entities

* fix if check
2021-12-17 19:21:06 +05:30
Nidhi
ab4add4b83
fix: Install plugin to existing organizations after approval (#9840) 2021-12-17 12:35:19 +05:30
Tolulope Adetula
831c0cb685
fix: chart validation (#9718) 2021-12-16 22:19:44 -08:00
Shrikant Sharat Kandula
9202c0bf67 Fix Docker buildx images
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-17 10:27:56 +05:30
Shrikant Sharat Kandula
31da3ea9ef Load Docker buildx images for testing
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-17 10:26:30 +05:30
Leo Thomas
ec755d261c
fix: Google sheets Bulk insert of empty array returns an error (#9725)
* fix/8924-Bulk Insert throwing error on empty data in google sheets new1

* fix/8924 Error in bulk insert empty data

* fix/8924 Code review fix for Google Sheet Bulk insert error

* fix/8924 Code review fix for Google Sheet Bulk insert error

* Fixed code review comments

* Methodconfig data changes since only empty Mono is being tested
2021-12-17 10:13:08 +05:30
Shrikant Sharat Kandula
8a336d3caa Fix OOM in insertDefaultResources migration
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-16 22:39:48 +05:30
Shrikant Sharat Kandula
1247864893
Fix migration OOM in firestore action migration (#9830)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-12-16 21:03:35 +05:30
Ayangade Adeoluwa
bdad41f323
Fix merge problems (#9829) 2021-12-16 20:43:00 +05:30
Paul Li
f62c8a62a4
fix: checkbox group feedback (#6959)
* FIX-6783 : Checkbox group widget - Feedback

-- Add default border for a checkbox icon and color for a label
-- Align the option to the center if its options count is one or inline
-- Set isInline to true by default in widget config

* FIX-6783 : Checkbox Group Widget Feedback

-- Add a migration for isInline property

* Feat: Checkbox Groupd Widget Feedback

-- Add vertical margin between options

* Fix: Checkbox Group Widget

-- Increase default rows value to 1.5 in widget configuration

* Fix: Checkbox Group Widget

-- Change the migration version number

* Fix: Checkbox Group Widget

-- Change migration version number

* Fix: Checkbox Groupd Widget Feedback

-- Delete redundant WidgetConfigResponse file

* Fix: Checkbox Group Widget Feedback

-- Change the config values of rows, columns
-- Refactor migration file

* Fix: Checkbox Group Widget

-- Refactor migration file

* fix: Checkbox Group Widget Feedback

-- Fix on the wrong dsl version

* fix: Checkbox Group Widget Feedback

-- Remove a unnecessary comment
-- Update the version of the widget in its config and migration

* fix: checkbox group feedback

-- Rewrite a migration for isInline property

* fix: checkbox group feedback

-- Follow the figma design on disabled state

* fix: Checkbox Group Widget feedback

-- Apply appropriate migration

* fix: Checkbox group widget - Feedback

-- Apply theme changes

* fix: Checkbox Group Widget - Feedback

-- Change the border color of an unchecked checkbox to DARK_GRAY

* fix: Checkbox Group Widget - Feedback

-- Remove inset box shadow from the checkbox indicators

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 22:24:23 +08:00
balajisoundar
3c1edbeb3a
feat: Admin settings page to tinker with env variables (#9687) 2021-12-16 19:47:16 +05:30
Ayangade Adeoluwa
e6bc975889
fix: Fixes inability to use duplicate names across multiple actions in different pages (#9360)
* Fixes inability to use duplicate names across multiple actions in different pages

* adds comments for better understanding and readability

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:53 +05:30
Ayangade Adeoluwa
7af727651d
fix: Assigns query Params in Datasource and Api query editor (#9184)
* adds option to assign query params in datasource and see those params in apieditor

* fix flaky cypress tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:38 +05:30
Ayangade Adeoluwa
a6796daaa9
fix: deleted actions display error messages when navigated to (#9507)
* deleted actions display error messages when navigated to

* adding custom type for goBackFn

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:14 +05:30
Ayangade Adeoluwa
c36d8f1b49
fixes query editor duplication (#9761) 2021-12-16 18:10:02 +05:30
Nidhi
508865f1dc
fix: Added handling for refactor of default list elements (#9774) 2021-12-16 11:33:40 +00:00
Nidhi
e48a51c166
fix: Ignore form data elements with null keys (#9769)
* fix: Ignore form data elements with null keys

* Added reference to constant instead of using a String
2021-12-16 09:54:38 +00:00
NandanAnantharamu
4fa39d924d
test: TableWidget bugs (#9795)
* Added tests for Table widget bugs

* typo in test corrected

* Updated a flaky test
2021-12-16 14:52:14 +05:30
Abhijeet
52782c6088
fix: Resolve issues related to disconnect git repo flow (#9760)
* Fixed issues related to git disconnect

* Update TC
2021-12-16 08:50:11 +00:00
Abhijeet
c51c0036af
fix: Fix action collection not being deleted when the deleted collection in edit mode is published (#9785) 2021-12-16 13:48:14 +05:30
Sumit Kumar
7909ae8680
feat: port Firestore plugin to UQI (#9393)
* Port Firestore plugin to UQI schema
* This PR implements a non-functional requirement i.e. from an end user perspective there is no change in the features that the plugin provides. However, the underlying DSL to render and interpret the query interface has been updated.
* It also involves a migration change to port existing Firestore plugin actions to the new UQI schema.
2021-12-16 13:31:09 +05:30
Nidhi
8d53c16e25
fix: Added check for self references in layout (#9756) 2021-12-16 13:30:19 +05:30
Tolulope Adetula
7e3529f60b
fix: selected option value from select widget (#9796)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

* fix: selectedOptionValue

* revert : test case

* fix: tests

* fix: add test cases

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 08:36:26 +01:00
Aswath K
66b9f69426
fix: Issue with deleting page (#9784)
Old page id was getting cached caused failure in deleting pages

Fixes #9717
2021-12-16 12:28:30 +05:30
Trisha Anand
11603e0d24
chore: Backend code split (#9610)
* Server comes up

* Instead of extracting ee, we extract the ce to get the mongo repo to work

* ActionRepo migrated

* ApiTemplateRepo migrated

* Application repo migrated

* Asset Repo migrated

* Collection repo migrated

* Comment repo migrated

* Comment thread repo migrated

* Config repo migrated

* datasource repo migrated

* group repo migrated

* Invite user repo migrated

* layout repo migrated

* New action repo migratd

* .

* Migrated rest of the repos.

* Migrated the repo impl as well between ce and common

* acl package partially migrated

* Authentication migration done!

* Controllers migrated

* AppsmithPermission enum migrated to class and split

* Unnecessary change removed

* Appsmith role enum converted to class

* Revert

* Reverting enum to class conversion after failing at implementing

* All services migrated

* server.solutions package completed

* Fixed solutions failing test cases

* Code compiling! Woohoo!
2021-12-15 22:59:46 +05:30
Ayangade Adeoluwa
763bb8f287
restricts datasource name character length (#9471) 2021-12-15 18:02:11 +01:00
Keyur Paralkar
3a1c2b0799
fix: removed -1 and 2d array population error in the selectedRowIndices (#9606)
* fix: removed -1 and 2d array population error in the selectedRowIndices

* test: init integration test for bug fix

* test: completed the integration tests for bug fixes

* test: added unit test for edge case in propertyUtils

* refactor: removed unused import

* feat: added selectedRowIndices as an option in the autocomplete

* fix: fixed table widget test cases
2021-12-15 17:44:50 +05:30
Aman Agarwal
0c74e7273e
fix(handle-enter-confirm-popup): added key action to confirm popup wi… (#8980)
* fix(handle-enter-confirm-popup): added key action to confirm popup with class functions

* fix(handle-enter-confirm-popup): removed isModalOpen in keyUp not required check
2021-12-15 17:21:57 +05:30
Ayush Pahwa
d52a28dd2e
Added handling for non JSON response on executeAction (#8907)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-15 17:10:03 +05:30
Favour Ohanekwu
79b45c60df
fix: Update replaceAll function for browser support (#9776)
Update replaceAll function for browser support
2021-12-15 11:42:25 +01:00
Nayan
f0a2cbd73f
chore: Added DB migration to flush redis (#9772) 2021-12-15 13:54:27 +05:30
rahulramesha
ddedf985b5
entity name rerender fix (#9703) 2021-12-15 08:23:24 +00:00
Favour Ohanekwu
84a627aaeb
fix: properly lint triggerfields (#9773)
Properly lint trigger fields
2021-12-15 06:18:45 +01:00
Rishabh Saxena
2821ac2d75
fix: git sync updates (#9623)
Co-authored-by: haojin111 <haojin828@outlook.com>
2021-12-15 00:30:59 +08:00
Anagh Hegde
e216dad15b
feat: Refactor APIs to include branch name in the request header (#9679)
* refactor api's to include branchName for git

* Check for updating Ids for move action

* Added check for global profile

* Fix bad merge

Co-authored-by: Abhijeet <abhijeet@appsmith.com>
2021-12-14 15:09:30 +00:00
Aman Agarwal
2c61de6525
fix: Correcting the duplication of headers from datasource to newer APIs (#9157) 2021-12-14 12:39:05 +00:00
Aman Agarwal
d05b2d5b56
fix: Correcting the run button loading state on cancel in API pane (#9094)
* fix(run-button-loading): the run button loading state changed on cancel

* fix(run-button-loading): added test case for run button loading status
2021-12-14 12:37:42 +00:00
Nidhi
b0900d1c22
fix: Added collection id and clientsideexecution to layout on page load DTO (#9683) 2021-12-14 16:34:45 +05:30
Ayangade Adeoluwa
cac0df71aa
fixes duplication of where clause AND-condition fields (#9745) 2021-12-14 11:42:21 +01:00
Nayan
28c181b59c
feat: [Feature] Upgrade spring boot version to 2.5.5 (#8932)
Upgrades spring boot version to 2.5.5
2021-12-14 16:22:37 +06:00
Nayan
c126786e98
fix: application is added to recent list if duplicated (#9549)
When user duplicates an application, the source application is also being marked as recently accessed application. As a result both the duplicated application and the source application are shown in the beginning of the list of applications.
2021-12-14 16:21:50 +06:00
Hetu Nandu
4c54ea21fb
feat: Add support for custom 'this' and 'global' variables during evaluation (#9651) 2021-12-14 14:00:43 +05:30
Nidhi
861ee2c46e
fix: Added handling for action collections during duplicate app flow (#9637) 2021-12-14 13:40:25 +05:30
Ayangade Adeoluwa
e9cd435c96
feat: UQI Pagination Component implementation (#9446)
* pagination component implementation with files for testing(to be removed)

* UQI Pagination component created.

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-14 09:02:06 +01:00
Aswath K
c9e1a73db7
fix: Regex to detect function args (#9634)
* fix: Regex to detect function args

* Add Tests for argString to Array

* fix: failed condition

* fix: bug with arrow function regex
2021-12-14 13:28:09 +05:30
Bhavin K
f7e2e079a9
fix: 8336 updated isLoading property in all widgets (#9409) 2021-12-14 07:55:58 +00:00
Bhavin K
406255fcf6
fix : updated alignments (#9602) 2021-12-14 07:55:30 +00:00
Aswath K
a2902b5235
fix: table color picker issue (#9681)
* fix: deleting color in color picker causes default color to set automatically

* Set default color property for newly added columns

* Add cypress tests

* fix issue for Label color

* fix: test issue
2021-12-14 07:55:05 +00:00
Apeksha Bhosale
9a7a5e06af
fix: changed conditions for variables as variables were undefined (#9748) 2021-12-14 13:01:40 +05:30
Rishabh Rathod
4838b7e73e
Revert "fix: Select widget Value (#9444)" (#9744)
This reverts commit af08547529.
2021-12-14 11:19:54 +05:30
Rishabh Saxena
d9bdde0904
chore: remove plausible to improve page performance (#9713) 2021-12-13 12:13:39 +05:30
NandanAnantharamu
990ec76c4b
test: Added test for select Widget (#9600)
* Added test for select Widget

* updated common locators
2021-12-13 11:14:01 +05:30
Parthiv Makwana
c2d549cb37
chore: Duplicate case labels found in switch case in Icon.tsx (#8640) 2021-12-12 19:20:14 +05:30
Shrikant Sharat Kandula
a26c14e2cd
fix: Load pages from GitBook sequentially (#8519)
Loading them in parallel is causing us to breach some rate limiting restrictions sporadically and the whole process fails. So this reverts to loading pages sequentially instead.
2021-12-12 19:11:07 +05:30
Abhijeet
e6c323a2ec
fix: Update crud template for failing S3 list file action (#9691)
* Updated Template

* Update TC

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-12-12 18:23:59 +05:30