Commit Graph

1279 Commits

Author SHA1 Message Date
Paul Li
a92b7595db
BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)
-- Add a overlaid div for iframe
2021-08-09 15:21:33 +05:30
arunvjn
83249275a7
Omnibar redesign (#6288)
Omni bar would now have the categories navigation and documentation.
2021-08-09 11:52:37 +05:30
Pawan Kumar
8546b24839
Fix: List Widget issues (#6226)
* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-08-09 11:05:01 +05:30
rahulramesha
e3b141fbef
Prevent Entire Editor Header from re rendering (#6415)
* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-06 16:14:38 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature (#5505) 2021-08-06 14:47:02 +05:30
akash-codemonk
c0364d747b
Fix: Set a default option in select widget while adding from suggested widgets (#6236) 2021-08-05 20:27:08 +05:30
albinAppsmith
c1b815ff45
Welcome tour GIF and Close button fixes (#6309)
* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants
2021-08-05 13:48:51 +00:00
Rishabh Saxena
a21375e104
Skip btn comment onboarding (#6331) 2021-08-05 17:36:29 +05:30
Tolulope Adetula
4252af1b20
fix: Font size fixed for consistency between select and multi-select widget (#6400) 2021-08-05 17:29:54 +05:30
Paul Li
4f6a62fa53
Icon Button Widget (#5723)
Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.
2021-08-05 16:46:26 +05:30
Tolulope Adetula
330cd4a918
fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403) 2021-08-05 16:26:32 +05:30
Paul Li
862e9f412e
iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)
* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component
2021-08-05 10:50:02 +05:30
haojin111
eda00479d5
open link inside text component in a new tab (#6205) 2021-08-04 19:04:44 +05:30
haojin111
96e494e38f
changed border radius of multiselect widget to 0px (#6349) 2021-08-04 19:03:32 +05:30
akash-codemonk
f413924fd4
Fix: Keep inspect entity in sync with the widget selection in the entity explorer 2021-08-04 15:36:13 +05:30
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
akash-codemonk
63dc8123bb
Fix: Update debugger placeholder text for non-mac (#6142) 2021-08-04 10:20:27 +05:30
Yash Vibhandik
31f8a708ae
FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)
reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished
2021-08-03 19:06:03 +05:30
Tolulope Adetula
24b78d1e2b
Multiselect Widget (#5228)
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30
Satish Gandham
88c92fd2f5
Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)
* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-08-02 21:36:33 +05:30
rahulramesha
7252975201
more conditions for run check (#6255)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 19:25:43 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget (#6041) 2021-08-02 12:07:55 +00:00
rahulramesha
2587d78404
Sentry typeError fix, with checks (#6256)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:46:50 +05:30
rahulramesha
a3152c450c
fix stop Rich text Editor from crashing on Modal (#6077)
* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:45:51 +05:30
Rishabh Saxena
6ee28950be
Minor comments feature fixes (#6245) 2021-08-02 12:57:20 +05:30
Pranav Kanade
44374f5641
[Fix] Small UI improvements to suggested widgets section (#6190)
* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment
2021-07-30 11:25:11 +05:30
akash-codemonk
7e0ebdd6b0
Add missed new nav analytics for connections (#6233)
* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks
2021-07-30 11:23:24 +05:30
Rishabh Rathod
fbf6d9ad2d
Add Skip tour button in welcome onboarding (#6158)
This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.
2021-07-29 18:37:26 +05:30
Rishabh Rathod
76dfcd0163
[Feature] Generate template page from datasource (#5513)
- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-29 13:43:10 +05:30
akash-codemonk
1fc6a21898
Fix overflowing text in toasts on safari (#6200) 2021-07-29 13:42:07 +05:30
Rishabh Saxena
f4018f450e
Comments feature related fixes (#6156) 2021-07-28 12:32:11 +05:30
Pranav Kanade
e84b28e825
added another regex to support short youtube video link format (#6192) 2021-07-28 12:06:46 +05:30
Rishabh Saxena
8638b6951a
[Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:35:33 +05:30
Satish Gandham
ee3890b4b4
[Perf] Increase the code editor debounce time from 300 to 600ms (#5914)
* - Increase the code editor debounce time from 300 to 1000ms

* Decrease the debounce time from 1000 to 600ms

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-07-27 10:46:02 +05:30
balajisoundar
f6ae3b2d84
Fix #6084: Fix alignment issue with multiselection checkbox when there are (#6123)
no rows present in the table
2021-07-27 10:33:13 +05:30
Pranav Kanade
3547976dc7
[Feature] new nav sniping mode (#5746)
* added sniping mode toggle option to header

* added cover to components on hover in sniping mode

* fixed the transition time

* using filled icon

* Show dependencies in action pane

* Added a wrapper to make a widget snipeable

* removed older parts of sniping from Positioned Container

* removed onclick action from snipeable wrapper

* Showing widget name in different color

* Added a mechanism to send user to sniping mode from successful API screen

* created new property pane saga to bind the data

* Fix datasource list width issue

* Fix sidebar going out of view when the response is a table

* Minor refactor

* Show add widgets section on the sidebar

* Stop showing autocomplete option after adding a widget

* fetching pageId, appId from store

* Get suggested widget from response

* Fix table data not getting evaluated after adding binding

* Fix property pane going below the entity explorer while navigating from query/api pane

* Fix width of sidepane shifting for apis

* Fix vertical margins of connections

* Fix api pane suggested widget showing up for errors

* Fix margins

* can show select in canvas btn in sidebar

* can get the action object at the end to bind the data

* updated saga and action names

* can bind data to table

* Use themes

* Use new image url for Table widget

* Added conditional mapping for sniping mode binding.

* updated the widget name tags and seq of calls to open property pane

* pushed all sniping mode decoration to header

* moved setting sniping mode logic to editor reducer

* Added keyboard short cut to get out of sniping mode

* updated reset sniping mechanism

* removed a divider line

* if there are no relationships, will not show the complete section

* Connect Data will automatically show relevant tab in integrations

* Update list and dropdown image urls

* Remove create table button

* no wrapping bind to text

* minor review considerations

* showing the widget name to left in sniping mode

* can set data to datepicker

* will not show snipe btn if there are no widgets in canvas

* Changes for multiple suggested widgets

* removed dependency of sniping from suggested widgets

* Added analytics events for sniping mode

* logic for binding data to a widget, moved to snipeable component

* changed binding widget func from capture to onClick and took care of sniping from widget wrapper too.

* added tests to check sniping mode for table

* updated test spec

* minor fix

* Fix copy changes

* Update test to use table widget from suggested widget list

* if fails to bind will generate warning and keep user in sniping mode

* in sniping mode will only show name plate if it is under focus

* fixed the test case

* added a comment

* minor fix to capture on click event in sniping mode

* updated text

* Hide connections UI when there are no connections

* Increase width to 90%

* Show placeholder text and back button in sidepane

* Show tooltip on hover

* Add analyitcs events for suggested widgets and connections

* Update label based on whether widgets are there or not

* binding related changes

* renamed the saga file containing sinping mode sagas

* Changes for inspect entity

* Revert "binding related changes" temporarily

This reverts commit 54ae9667fecf24bc3cf9912a5356d06600b25c84.

* Update suggested widgets url

* Update table url

* Fix chart data field not getting evaluated

* a minor fix to show proper tool tip when user hovers on widget name

* Show sidepane when there is output

* Update locators

* Use constants for messages

* Update file name to ApiRightPane

* Remove delay

* Revert "Revert "binding related changes" temporarily"

This reverts commit ee7f75e83218137250b4b9a28fcf63080c185150.

* Fix width

* Fix overlap

Co-authored-by: Akash N <akash@codemonk.in>
2021-07-26 22:14:10 +05:30
akash-codemonk
56e29d22f5
Add new nav related analytics (#6125)
Analytics events for the following have been added

- Create new datasource CTA on the property pane
- Run button at the response tab for actions
- Click on associated entity dropdown from the property pane
- Select an associated entity from the associated entity dropdown at the property pane
2021-07-26 16:29:15 +05:30
Vicky Bansal
0e6ff2bebe
Fix-Keep date picker open when selecting time, month, year in Table widget filters (#5991)
Keep date-picker open when selecting time or changing month, year in Table filters, The user before this could not select or change time. We have fixed this by closing the date-picker popover onClick of outside overlay/canvas.
2021-07-26 12:29:53 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
Rishabh Saxena
5f342cf042
[Fix] Minor omnibar updates (#6097) 2021-07-23 16:53:36 +05:30
arunvjn
3618b85595
Fixed slash button positioning (#6085) 2021-07-23 16:12:48 +05:30
Tolulope Adetula
fa76a9a6e9
fix: File picker disabled state (#5972)
The filepicker in the disable sate was still able to upload the file. Fixed the issue here.
2021-07-23 14:42:51 +05:30
rahulramesha
f5e079f040
[Perf] prevent un-necessry re-renders of resizable Component on property control keyPress (#5885)
prevent un-necessry re-renders of resizable Component on property control keyPress
2021-07-23 12:10:39 +05:30
Yash Vibhandik
a0c9ecb2a5
FIX #3229 : added new props shortcuts and closeOnSelection for smooth interactions (#5276)
In the date picker widget we now have an option to let the date picker popup remain open until the a positive feedback is given by clicking outside the popup or another widget. In other words the date-picker popup will not close where a date is selected with `closeOnSelection` disabled. 

We have also added an option to show date-picker shortcuts to the end user.
2021-07-22 18:16:41 +05:30
Bhavin K
c23925c0c9
handle image download error (#5951)
Fixed an issue where because of the CORS issue the image was not able to download, To fix this we now open the image in a new tab where an error is received.
2021-07-22 14:15:45 +05:30
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
Bhavin K
bd05ab5dc7
fix when component update (#5931)
The custom chart onDataPointClick did not function well in the editor and view more, This is now fixed
2021-07-22 14:11:18 +05:30
akash-codemonk
f1e829fe4a
Feature: Show error state in property pane connections if associated connection has errors (#5877) 2021-07-21 18:10:46 +05:30
Hetu Nandu
ba06d797de
Improve autocomplete sorting (#5798) 2021-07-20 15:32:56 +05:30
Vicky Bansal
6f91c1afd8
Feature/draggable filters in table widget (#5886)
The filter pane in the table widget was fixed to top which would hinder the viewport for the end user. We have now changed the filter pane to a draggable component such that the user can place it anywhere on the canvas while they apply filters to see data change in realtime.

* FEATURE #4088 : added draggable filterpane for table widget

* FEATURE #4088 : update icons, editMode prop and added renderDragBlock support in popper

* FIX #5329: added close button for close filter pane

* FIX #5332 : updated zindex for table filter pane

* fix list widget test

* Fix drag icon position and cypress failing tests

* Fix endsWidth comparator function
2021-07-20 10:48:58 +05:30