Commit Graph

2824 Commits

Author SHA1 Message Date
Paul Li
53fe96b5cf FEATURE-2111 : Show/Hide Table Controls
-- Use isHeaderVisible variable for conditional rendering
2021-06-03 03:43:08 -04:00
somangshu
90d4d3a71a Merge branch 'release' into feature/datepicker-max-date 2021-06-03 11:56:51 +05:30
somangshu
d794cbbef9 Merge branch 'release' into fix/dropdown-overlap-modal 2021-06-03 11:53:31 +05:30
Kaushik Varanasi
3a6da2d797
Feature/import applications (#4483)
* Added export option to app menu. TODO: call api to download app file

* Added checkbox component and removed unused code

* Added import app without filepicker. Opens modal

* added ability to fetch the exported app

* can download exported application as a json file

* Updated the file picker component to accept other file formats

* WIP import app

* Added functionality to import application json file

* minor fixes

* Made the file type prop mandatory for file picker

* added a test suite for export app

* Test added to check if on import application click, it open a modal

* added a dummy application file for cypress testing

* Added end to end integration test suite
to verify import app feature

* added test to verify the export api status and download file.

* added a linked btn to carry exporting.
- according to latest BE changes

* Removed old redux and saga mechanism for app export

* updated cypress test to validate new flow

* fixed minor linting errors

* updated test case title

* updated the test cases for import/export app feat

* review changes

* added prop to facilitate delayed upload

* added new application file to fixtures. Minor fix to take care of loading state.

* Removed export app modal. Added one click action, to download the file.

* Updated File picker to work with all other files acc to the design.

* Updated the import modal

* updated the import application test

* Added remove upload tooltip

* updated the icons for import/export actions

* removed unused logs

* added hard coded feature flag to hide/show import export feature

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-06-03 11:48:08 +05:30
vicky.bansal@primathon.in
40debe9e42 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/default-table-scrolls 2021-06-03 11:32:16 +05:30
arunvjn
4952207fc2
UI improvements to API Editor (#4845)
* Change CTA to apply datasource on datasource card click
* Fix for Request method button's alignment issue.
* Hide save/edit datasource button when url field is empty
* Added edit icons to navigate to datasource form
2021-06-03 10:29:41 +05:30
arunvjn
a31adce20d
Bug/api editor datasources (#4780)
* Fixed datasource urls' disappearance when the saved datasource has a trailing slash

* Refactored query params parser to a seperate function.
Added unit tests for the new function
2021-06-03 10:28:18 +05:30
Hetu Nandu
8c84dcfdec
Fix multiline js issues (#4816) 2021-06-02 18:27:27 +05:30
Yash
3d18a9b36a FIX #4731: update condition for selectedRowIndices when table widget drag and drop 2021-06-02 15:31:52 +05:30
Nayan
78915301e3
[Issue #4572]-Allow users to leave an organization (#4634)
* [Issue #4572]-Added API to leave organisation by any user

[Issue #4572]-Add option for organization admins to leave an organization

* -add option to leave organization in frontend for non-admin users

* -updated the leave org endpoint path and HTTP method as per PR review

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/UserOrganizationServiceImpl.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/UserOrganizationServiceImpl.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* -add cypress test and some minor changes as per PR comment

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-06-02 15:56:22 +06:00
imgbot[bot]
a11e732b61
[ImgBot] Optimize images (#4707)
*Total -- 3,752.13kb -> 3,526.66kb (6.01%)

/static/images/users.png -- 15.03kb -> 6.11kb (59.37%)
/static/images/integrations.png -- 14.43kb -> 9.37kb (35.05%)
/static/images/build-tool.png -- 27.04kb -> 21.86kb (19.15%)
/app/client/src/assets/icons/ads/commentIcon.png -- 0.90kb -> 0.77kb (14.67%)
/static/images/git-banner.jpg -- 779.36kb -> 666.22kb (14.52%)
/static/images/git-banner-left.png -- 72.13kb -> 65.42kb (9.29%)
/app/client/src/assets/icons/comments/context-menu.svg -- 0.43kb -> 0.40kb (5.92%)
/app/client/src/assets/icons/comments/commentCursor.png -- 1.41kb -> 1.34kb (4.72%)
/app/client/src/assets/images/comments-onboarding/step-4.png -- 14.90kb -> 14.26kb (4.3%)
/static/images/animations/video-preview.gif -- 1,300.08kb -> 1,247.97kb (4.01%)
/static/images/animations/writing-js.gif -- 264.13kb -> 254.80kb (3.53%)
/static/images/git-banner-right.png -- 654.13kb -> 633.46kb (3.16%)
/static/images/animations/running-api.gif -- 38.67kb -> 37.59kb (2.8%)
/app/client/src/assets/icons/ads/open.svg -- 0.32kb -> 0.32kb (1.81%)
/app/client/src/assets/icons/ads/cross.svg -- 0.22kb -> 0.21kb (1.81%)
/app/client/src/assets/icons/control/back.svg -- 0.26kb -> 0.26kb (1.49%)
/app/client/src/assets/icons/ads/app-icons/draghandler.svg -- 0.53kb -> 0.52kb (1.48%)
/app/client/src/assets/icons/comments/comment-mode-unread-indicator.svg -- 0.40kb -> 0.39kb (1.46%)
/app/client/src/assets/icons/comments/send-button.svg -- 0.21kb -> 0.21kb (1.41%)
/app/client/src/assets/icons/comments/read-pin.svg -- 0.29kb -> 0.29kb (1.34%)
/app/client/src/assets/icons/comments/unread-pin.svg -- 0.29kb -> 0.29kb (1.34%)
/app/client/src/assets/icons/comments/check-oval.svg -- 0.30kb -> 0.30kb (1.28%)
/app/client/src/assets/icons/comments/emoji.svg -- 0.40kb -> 0.40kb (1.22%)
/app/client/src/assets/icons/comments/reaction-2.svg -- 1.19kb -> 1.17kb (1.15%)
/app/client/src/assets/icons/control/open-new-tab.svg -- 1.09kb -> 1.08kb (1.08%)
/app/client/src/assets/icons/comments/trash.svg -- 0.32kb -> 0.32kb (0.91%)
/app/client/src/assets/icons/comments/chat.svg -- 0.34kb -> 0.33kb (0.87%)
/app/client/src/assets/icons/comments/pin_3.svg -- 0.39kb -> 0.39kb (0.75%)
/app/client/src/assets/images/profile-placeholder.svg -- 0.54kb -> 0.54kb (0.72%)
/app/client/src/assets/icons/comments/reaction.svg -- 0.83kb -> 0.82kb (0.71%)
/app/client/src/assets/icons/comments/pen.svg -- 0.42kb -> 0.41kb (0.7%)
/app/client/src/assets/icons/comments/edit-mode.svg -- 0.42kb -> 0.42kb (0.7%)
/app/client/src/assets/icons/comments/link.svg -- 0.65kb -> 0.64kb (0.6%)
/app/client/src/assets/icons/comments/unpin.svg -- 0.51kb -> 0.51kb (0.57%)
/app/client/src/assets/icons/comments/toggle-comment-mode.svg -- 0.51kb -> 0.51kb (0.57%)
/app/client/src/assets/icons/ads/cancel.svg -- 0.52kb -> 0.51kb (0.57%)
/static/images/animations/selections.gif -- 119.85kb -> 119.23kb (0.52%)
/app/client/src/assets/icons/control/download-data-icon.svg -- 0.62kb -> 0.61kb (0.48%)
/app/client/src/assets/icons/comments/pin.svg -- 0.63kb -> 0.63kb (0.47%)
/app/client/src/assets/icons/comments/pin_2.svg -- 0.87kb -> 0.87kb (0.45%)
/static/images/animations/move-around.gif -- 229.66kb -> 228.69kb (0.43%)
/app/client/src/assets/icons/ads/bug.svg -- 0.70kb -> 0.70kb (0.42%)
/static/images/animations/drag-drop.gif -- 159.38kb -> 158.73kb (0.41%)
/app/client/src/assets/icons/ads/wand.svg -- 2.79kb -> 2.77kb (0.39%)
/app/client/src/assets/icons/ads/warning-triangle.svg -- 1.08kb -> 1.07kb (0.36%)
/app/client/src/assets/icons/control/filter-icon.svg -- 0.91kb -> 0.91kb (0.32%)
/app/client/src/assets/icons/ads/card-context-menu.svg -- 1.12kb -> 1.12kb (0.26%)
/app/client/src/assets/icons/widget/list.svg -- 1.65kb -> 1.65kb (0.24%)
/app/client/src/assets/images/comments-onboarding/step-3.png -- 39.31kb -> 39.29kb (0.05%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-06-02 07:51:52 +05:30
Satish Gandham
899b7f2f24 Merge branch 'release' into perf/ui/optimize-editableText-component 2021-06-01 22:54:56 +05:30
Yash
23bfcc706d FIX #3899 : added supported custom chart types list, validate chart type and fix type error by fusioncharts 2021-06-01 20:27:58 +05:30
Nidhi
26ce58e9e3
Changes to client credentials form (#4836) 2021-06-01 17:41:48 +05:30
Satish Gandham
6e8338089e - Change useEffect hook to use deep cehck for modifiers instead of refernece equality
- Moemoize getThemeDetails
2021-06-01 17:37:16 +05:30
Somangshu Goswami
771cf4a34f
Merge pull request #4805 from appsmithorg/fix/table-pagesize-migrations
Fix for pageSize calculation in table widget
2021-06-01 16:44:23 +05:30
bhavin
a889153714 fixing docs and expectation strings on custom chart 2021-06-01 16:01:32 +05:30
bhavin
53598e8027 added onclose property and handlers on ModalWidget 2021-06-01 14:50:13 +05:30
Tolulope Adetula
59738c5019 Merge branch 'release' into fix/dropdown-overlap-modal 2021-06-01 07:11:52 +01:00
Hetu Nandu
ae28731947
Enable smart substitution for widgets (#4801) 2021-06-01 10:29:45 +05:30
bhavin
2b9cc622cc replaced string check with array check 2021-06-01 09:36:47 +05:30
arunvjn
9e8e432a1f
Feature/cmd enter to execute actions (#4774)
Added new global hotkey to trigger Run on cmd+enter

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-05-31 21:10:21 +05:30
Somangshu Goswami
5e72910be5
Merge pull request #4525 from appsmithorg/bug/model-reset-children-meta-onclose
updated closeModal saga to stop reseting children meta properties.
2021-05-31 20:09:17 +05:30
Somangshu Goswami
d770b360b0
Merge pull request #4350 from appsmithorg/fix/dropdown-default-value
fix: set default format in table date type cell
2021-05-31 20:08:49 +05:30
Somangshu Goswami
de4af915b3
Merge pull request #4766 from appsmithorg/bug/chart-onDataPointClick
added click event config for customChart
2021-05-31 20:08:28 +05:30
Somangshu Goswami
fd7db3356e
Merge pull request #4433 from appsmithorg/fix/-filePicker-widget-property-cleanup
fix: remove uploadedFileUrls property from FilePicker
2021-05-31 20:07:16 +05:30
Somangshu Goswami
ceabb7a50f
Merge pull request #4693 from appsmithorg/FIX/4603-truncate-long-column-names
FIX #4603 : updated css to truncate long column name
2021-05-31 20:06:55 +05:30
vicky.bansal@primathon.in
3182d2fe15 Fix unused variable issue 2021-05-31 17:27:00 +05:30
vicky.bansal@primathon.in
5ea2d961db Added migration to update parentRowSpace property of table widget 2021-05-31 17:09:06 +05:30
Ashok Kumar M
2052a8e545
Fix: Positioning widgets without left right column towards the end of the page. (#4777) 2021-05-28 22:25:10 +05:30
Yash
ad427c86b2 FIX #3648 : updated css to display toast message properly on deleting RTE 2021-05-28 21:42:47 +05:30
arunvjn
a133a320cf
Added replacer in stringfy method to optionally use toString method for big ints. (#4745) 2021-05-28 21:30:21 +05:30
akash-codemonk
cbca6bedd4
Clear debugger errors on page switch (#4672) 2021-05-28 19:44:44 +05:30
arunvjn
f6a33fafbf
Text overflow bug in datasource tab in API Editor(#4776) 2021-05-28 17:46:09 +05:30
Yash
9de9b1eb30 FIX #4573 : added sample custom fusion chart config and updated data shape to override default message 2021-05-28 14:49:36 +05:30
Tolulope Adetula
664ba6ab22
Update File-picker widget property 2021-05-28 01:45:37 -07:00
bhavin
cfded6d99e added click event config for customChart 2021-05-28 11:46:11 +05:30
Satish Gandham
b75dcc384d
Merge pull request #4563 from appsmithorg/perf/ui/optimize-binding-prompt/4555
[Perf] Remove code causing expensive style recalculation from binding prompt
2021-05-28 11:17:43 +05:30
Satish Gandham
83b44b30b6
Merge pull request #4680 from appsmithorg/ui/perf/optimize-expensive-style-calc-evalauatedValuePopup/4679
Memoize the evaluate popup placement value
2021-05-28 11:16:21 +05:30
Ashok Kumar M
575d7fe7f9
Fix: Adding missing widget properties when a new tab is created. (#4733)
* dip

* dip

* dip

* Revert "dip"

This reverts commit f0eeaa4a2dc9845509945c2af9376f1573baafdf.

* dip

* removing unwanted iteration.

* Adding and fixing specs.
2021-05-28 08:28:02 +05:30
Nidhi
5ddd58cdfd
Added optional audience and resource fields for oauth2 datasources (#4678)
* Added optional audience and resource fields for oauth2

* Review changes

* Don't show audience and resource fields by default
2021-05-27 21:53:59 +05:30
abhishek nayak
02e52d019f
Merge pull request #4414 from appsmithorg/areyabhishek-patch-4
[FIX] Update Dropdown Widget default value placeholder
2021-05-27 19:23:03 +05:30
bhavin
c014485268 added string check on options prop 2021-05-27 16:27:10 +05:30
Apeksha Bhosale
47969d708c
show pre-filled values for autocomplete (#4400)
* dot added after selection of an option

* added all options to autocomplete list

* small css change

* css changes

* small function change

* removed commented code

* data type match with autocomplete

* added headers and changes cursor activity for autocomplete

* removed wrong value

* removed type from server added to showhint

* modified and added test case

* small modification for test cypress case
2021-05-27 15:31:26 +05:30
somangshu
ee4fa8307f Merge branch 'release' into areyabhishek-patch-4 2021-05-27 12:38:32 +05:30
Pawan Kumar
0d41797a26
Fix: List Widget crashes on null empty object in data (#4349)
* filter null values in property pane autocomplete

* add hover states for list items

* add loading state in list

* fix loading state of list widget

* open list widget property on click of container

* fix isVisible bug in list widget children

* remove unused import

* add cusor pointer

* add focused state for first item in list widget

* fix empty state

* fix test case

* fix visiblity bug

* fix test case

* fixes for review comments

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-05-27 12:11:38 +05:30
Rishabh Saxena
9f76218306
Trigger invite flow via comments (#4602) 2021-05-27 11:51:36 +05:30
arunvjn
5c45217f3d
Feature/datasource list in api editor (#4587)
Show datasource list in API editor
2021-05-27 08:35:05 +05:30
Tolulope Adetula
b78c6204b9 fix: Add zIndex Layers of Dropdown and Modal 2021-05-26 14:56:40 +01:00
Tolulope Adetula
f54d4c618e Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-26 13:56:48 +01:00
Apeksha Bhosale
4825ce2a2a
Show JS eval errors in evaluated value pane and debugger (#4463)
Co-authored-by: jsartisan <pawankumar2901@gmail.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-05-26 18:02:43 +05:30
Yash
a24623da94 FIX #4603 : updated css to truncate long column name 2021-05-26 17:51:09 +05:30
Yash
218ad04553 FIX #4524 : revert added check in else block and add handle boolean validation in validator 2021-05-26 17:43:25 +05:30
vicky.bansal@primathon.in
bd5ca7011c Removed unused import 2021-05-26 16:57:01 +05:30
akash-codemonk
8bd6ed3a70
Feature: Show current value in the debugger when widget property has an error (#4592) 2021-05-26 13:47:52 +05:30
vicky.bansal@primathon.in
312ea00138 Increase width of default table widget so that scrollbars are not required by default 2021-05-26 10:22:08 +05:30
vicky.bansal@primathon.in
042ee3fa46 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/text-parsing 2021-05-26 08:57:40 +05:30
vicky.bansal@primathon.in
dcebd1103e Fix for email parse 2021-05-26 08:47:46 +05:30
Satish Gandham
bfc8b6a46f Memoize the evaluate popup placement value 2021-05-25 22:07:38 +05:30
Nikhil Nandagopal
50b03302e4 fixed validation messages 2021-05-25 19:18:35 +05:30
Satish Gandham
ad3997ecde Merge branch 'release' into perf/ui/optimize-binding-prompt/4555 2021-05-25 11:14:28 +05:30
Yash
e34a156f18 FIX #4573 : added custom fusion chart config to override default message 2021-05-24 18:27:50 +05:30
Tolulope Adetula
4ac85a7fd9 fix: add Layers to the dropdown 2021-05-24 10:09:43 +01:00
Tolulope Adetula
b95ff2001e Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-24 08:21:30 +01:00
Yash
591f9395f6 [ISSUE#4524]Fix: Added a check in else block too and assigned default config 2021-05-24 12:27:33 +05:30
Tolulope Adetula
b2a86d7e11 fix: failing modal test 2021-05-24 06:52:49 +01:00
Nikhil Nandagopal
750e3808f2 Merge branch 'release' into fix/validation-messages 2021-05-24 11:01:24 +05:30
Satish Gandham
7ef5f70596 Merge branch 'release' into perf/ui/optimize-editableText-component 2021-05-24 06:53:35 +05:30
Satish Gandham
b01c615056
Merge pull request #4554 from appsmithorg/perf/ui/optimize-resizable-component
Optimize resizable component
2021-05-21 19:33:51 +05:30
Satish Gandham
516aa0f40c
Merge pull request #4397 from appsmithorg/perf/ui/reduce-json-view-data
[Performance] Collapse all but the first two records in react-json-view
2021-05-21 19:32:52 +05:30
Paul Li
5701e2ac3e Merge branch 'release' into fix/2358-dropdown-multi-select-too-much-space 2021-05-21 05:39:47 -04:00
Paul Li
0966536638 FIX-2358 : Too much spacing between option on multi selection option in Dropdown Widget
-- Adjust space between tag items along a flexbox's cross-axis
2021-05-21 05:32:28 -04:00
Nikhil Nandagopal
4ed203d4af Merge branch 'release' into fix/validation-messages 2021-05-21 14:19:25 +05:30
Nikhil Nandagopal
ecb85efe7c updated validation messages 2021-05-21 14:18:59 +05:30
Rishabh Saxena
220c8d9d25
Remove isFromSignup param to prevent duplicate analytics hits (#4480) 2021-05-21 13:20:27 +05:30
Tolulope Adetula
3c1f4bca9b Merge branch 'release' into fix/-filePicker-widget-property-cleanup 2021-05-21 08:05:17 +01:00
Tolulope Adetula
f4e693f4f8 Merge branch 'release' into fix--color-picker-in-form-widget 2021-05-21 06:42:26 +01:00
Tolulope Adetula
6381f5d2ec Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-21 06:41:06 +01:00
Paul Li
5ae2d1a04a Merge branch 'release' into fix/4362-recaptcha-field-unexpected-data-types 2021-05-20 15:30:29 -04:00
Paul Li
4d9aa2bd00 FIX-4362 : Unexpected data types in the Recaptcha field for buttons breaks the widget
-- Add a guard for invalid googleRecaptcha key
2021-05-20 15:28:02 -04:00
Satish Gandham
ee7d9f2498 Merge branch 'release' into perf/ui/optimize-resizable-component 2021-05-20 18:45:59 +05:30
Satish Gandham
041ee6a479 Merge branch 'release' into perf/ui/reduce-json-view-data 2021-05-20 18:45:31 +05:30
Rishabh Saxena
8964aea9df
[Feature] Comments feature updates (#4579) 2021-05-20 17:33:08 +05:30
arunvjn
63db439183
Fixed r.match bug (#4593) 2021-05-20 16:51:10 +05:30
somangshu
29579a71fa Merge branch 'release' into areyabhishek-patch-4 2021-05-20 15:21:25 +05:30
bhavin
4e559b4228 remove no selection option 2021-05-20 13:54:26 +05:30
Tolulope Adetula
0372e47e14 Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-20 08:33:49 +01:00
Hetu Nandu
aac5fcb6c7
Use the Function constructor for user script eval (#4446)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-05-20 12:31:10 +05:30
Tolulope Adetula
afcf7d793a fix: PR comments 2021-05-20 06:04:52 +01:00
Paul Li
c1557c187a FEATURE-2111 : Show/Hide Table Controls
-- Adjust pageSize
-- Change column header height
-- Restore the logic for renderEmptyRow
2021-05-19 07:02:07 -04:00
Satish Gandham
3886386b4d Merge branch 'release' into perf/ui/reduce-json-view-data 2021-05-19 16:21:43 +05:30
Paul Li
c906b0e447 FEATURE-2111 : Show/Hide table controls
-- Apply some cleanup
2021-05-19 05:36:30 -04:00
Paul Li
9e0ec2304a Revert "FEATURE-2111 : Show/Hide Table Controls"
This reverts commit 1d3c2da455d0a58beb4189898464baf5096c1aee.
2021-05-19 05:36:30 -04:00
Paul Li
7cf12ed031 FEATURE-2111 : Show/Hide Table Controls
-- Remove extra space when the header options is all hidden
2021-05-19 05:36:30 -04:00
Paul Li
35e28dcb08 FEATURE-2111 : Show/Hide Table Controls
-- PositionedContainer : Add padding-bottom: 42px in case of Table widget
2021-05-19 05:33:45 -04:00
Paul Li
f943d0b330 FEATURE-2111 : Show/Hide Table Controls
-- Remove JS convertible
-- Set isBindProperty and isTriggerProperty to false
2021-05-19 05:31:53 -04:00
Paul Li
c76ef9e3d7 FEATURE-2111 : Show/Hide Table Controls
-- Add the header options section for the visibility setting
-- Render conditionally the header part based on the setting
2021-05-19 05:31:53 -04:00
Tolulope Adetula
4c3834828a fix: remove console statement 2021-05-19 08:21:25 +01:00
Tolulope Adetula
4e890dce86 fix: remove unnecessary className 2021-05-19 08:21:00 +01:00
Tolulope Adetula
523972e191 Fix: modal and Dropdown 2021-05-19 08:20:00 +01:00
Satish Gandham
f266ca3793 Merge branch 'release' into perf/ui/optimize-resizable-component 2021-05-19 11:37:41 +05:30
Trisha Anand
d5e5be5d6a
[Feature] Mongo Form (#4378) 2021-05-19 11:05:24 +05:30
Arpit Mohan
b1d7258dcb
Adding support for multipart form data (#4547)
* Handling multipart form data in the CURL import flow

* Adding Cypress test for curl import with multipart/form-data

* Also fixing minor bug where the form values need not always be double-quoted
2021-05-19 10:48:51 +05:30
Tolulope Adetula
18e5dde01d Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-18 22:24:33 +01:00
Ashok Kumar M
8c8141650a
Feature: Widget grouping Phase I (Multi select and Bulk Delete) + Canvas Enhancements. (#4219)
* Feature: Canvas layer enhancements(DIP)

* feedback fixes

* fixing build

* dip

* dip

* dip

* fixing build

* dip

* dev fixes

* dip

* Fixing top bottom resize handles

* dip

* reposition widget name on top edges.

* dip

* dip

* dip

* dip

* renaming selectedWidget to lastSelectedWidget

* code clean up

* Fixing list widget as per grid scale.

* Fixing existing specs.

* Adding migration test cases.

* dip

* FIxing proppane in modal.

* fixing modal z-indedx.

* fix for modal name.

* dip

* dip

* dip

* adding test cases for hotkeys.

* dip

* dip

* fixing build

* Trying some performance improvements for jests.

* 17 mins with runinband lets try without it.

* minor bug fixes.

* code clean up

* save migrated app on fetch.

* fixing few cypress tests

* fixing cypress tests

* fixing cypress tests.

* fixing cypress

* updated DSL

* Addressing code review comments.

* test fails

* dip

* eslint fixes.

* fixing debugger cypress tests.

* updating latest page version.

* updating migration changes to cypress dsl's.

* updating chart data fixes for cypress tests.

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-18 23:59:39 +05:30
arunvjn
b14f043172
Fix/datasource request headers in api (#4481)
* Show datasource headers when used in an API
2021-05-18 21:40:53 +05:30
Somangshu Goswami
41419e0406
Merge pull request #4199 from appsmithorg/feature/table-excel-export
Allow table data to download as Excel
2021-05-18 20:17:16 +05:30
Somangshu Goswami
01aa8ed36d
Merge pull request #4316 from appsmithorg/fix/server-side-search
Disable client side search when server side search is enabled in table widget
2021-05-18 20:16:30 +05:30
Somangshu Goswami
52da3e7030
Merge pull request #3791 from aswathkk/issue/3321
Allow removing filter on Dropdown Widget
2021-05-18 20:15:42 +05:30
Somangshu Goswami
559555f175
Merge pull request #4485 from appsmithorg/bug/select-optionmenu-scroll
fix: select disabled option popover overflow
2021-05-18 20:01:06 +05:30
Somangshu Goswami
c233dc1273
Merge pull request #4313 from appsmithorg/fix/datepickerwidget-popover
fix: datepicker popover adjust height and width.
2021-05-18 20:00:04 +05:30
akash-codemonk
9e082a6156
Feature: Show widget error state (#4558) 2021-05-18 19:24:40 +05:30
Satish Gandham
faeac974ca - Remove code casuing expensive style recalculation 2021-05-18 17:48:29 +05:30
akash-codemonk
51b98eed2f
Fix: Debugger shows errors for evaluations done on page load (#4552) 2021-05-18 17:21:32 +05:30
arunvjn
4733edfccd
Fixed query params parsing in API pane (#4482)
* Fixed query params parsing when there are mulitple "="s.

* Added cypress tests to validate query params parsing
2021-05-18 17:17:43 +05:30
arunvjn
08966499be
Remove request/response data from copies of an executed API (#4521) 2021-05-18 17:17:22 +05:30
Shrikant Sharat Kandula
1e052a9462
Fix redirectUrl not being encoded (#4546) 2021-05-18 11:22:54 +05:30
Satish Gandham
bbecba125e - Wrap the methods passed to editableText component with useCallback
- Use destructing for props
2021-05-18 00:42:06 +05:30
akash-codemonk
cbace9d5d7
Fix: Debugger showing previous application logs (#4455) 2021-05-17 15:31:22 +05:30
Satish Gandham
6bf7903570
Merge pull request #4470 from appsmithorg/ui/eslint/sort-destructured-props
Add eslint rule to sort destructured props and auto fix the issues.
2021-05-17 14:52:59 +05:30
Satish Gandham
bed4b39561
Merge pull request #4292 from appsmithorg/perf/optimize-table-widget
Optimize table widget
2021-05-17 14:52:49 +05:30
bhavin
b323c75d1d updated closeModal saga to stop reseting children meta properties on a modal 2021-05-17 14:04:56 +05:30
Apeksha Bhosale
e4ee2b07c9
r.match on API pane error (#4497)
* r.match on API pane error

* Pr comment fixed
2021-05-17 12:51:48 +05:30
arunvjn
67e292cc2a
Fixed handleSubmit bug in API form editor (pagination buttons) (#4477) 2021-05-15 00:13:08 +05:30
bhavin
cab7f4a099 fix: select disabled option popover overflow 2021-05-14 14:53:22 +05:30
arunvjn
341a4d62af
Bug/paste widget append copy to name (#4399)
* Changes to retain widget/Action names on copy when there is no clash.

* Updated tests

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-14 14:35:55 +05:30
arunvjn
068e4065d7
Expose response headers for API/DB actions (#4336)
* Expose response headers for API/DB actions

* Added responseMeta to actions datatree

* Modified cypress test to account for responseMeta

* Modify cypress test case

* More test changes

* Modified tests
2021-05-14 12:21:09 +05:30
Trisha Anand
377629955d Revert "Init minor comment"
This reverts commit 2b7212da8c.
2021-05-13 20:01:37 +05:30
Trisha Anand
2b7212da8c Init minor comment 2021-05-13 19:52:54 +05:30
Satish Gandham
8ecac87ec7 Change the cell renderer function from class property to inline and use JSON.stringify to do the comparision. 2021-05-13 17:38:15 +05:30
Satish Gandham
8ad7eecdeb - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
Apeksha Bhosale
66c7a0b252
Revert "Separating js error and validation error for debugger (#4361)" (#4447)
This reverts commit c6a8f81d60.
2021-05-13 09:50:30 +05:30
bhavin
0015d72122 updated max year for datepicker to +100, same as property pane datepicker 2021-05-12 21:01:17 +05:30
Tolulope Adetula
285f7faf41 fix: add color picker to form component 2021-05-12 11:03:34 +01:00
Pawan Kumar
cc36bdc051
Fix: TypeError: t.match is not a function (#4445)
* add is number check before setting widget property

* use toString of lodash

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-12 13:27:28 +05:30
Apeksha Bhosale
c6a8f81d60
Separating js error and validation error for debugger (#4361)
* separate js error and validation error

* PR comments fixed and added error for pageload action

* reverted to jsError message property

* small check for empty errors

* small changes for Test to pass

* space was missing for test case

* removed console statement
2021-05-12 12:10:32 +05:30
Tolulope Adetula
0b1db5689f Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-12 02:22:07 +01:00
Tolulope Adetula
f6c7036d5c fix: remove uploadedFileUrls ppty from FilePicker 2021-05-11 16:53:02 +01:00
Ashok Kumar M
3eeaf86097
Fix: Resize doesn't react as intended for top/bottom handles. (#4321) 2021-05-11 20:09:33 +05:30
Satish Gandham
8bd947671d Move the expensive getBoundingReactangle call to isColliding function to avoid unnecessary calls. 2021-05-11 20:09:09 +05:30
bhavin
ca7594ac3f fixed : deafult and min/max is allow same date 2021-05-11 13:07:16 +05:30
Satish Gandham
68c258ab3a - Remove unncessary anonymous funciton
- Use destructured imports
2021-05-11 12:25:42 +05:30
vicky-primathon.in
56f0ba716b Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-05-11 12:10:26 +05:30
vicky-primathon.in
78bad85e24 Used useCallBack hook and remove inline arrow function 2021-05-11 12:10:13 +05:30
Satish Gandham
812e893eee - Add name to memoized resizableComponent 2021-05-11 12:03:07 +05:30
Satish Gandham
8763f9518b - Memoize EditorContext value
- Change mapDispatchToProps to object form
2021-05-11 12:02:24 +05:30
akash-codemonk
d6de913949
Revert "Feature: Show widget error state (#4202)" (#4406)
This reverts commit bf7a8b91a4.
2021-05-11 09:40:43 +05:30
abhishek nayak
1276edf517
Update DropdownWidget.tsx
Updated the default value to something that doesn't fail.
2021-05-11 03:19:03 +05:30
Tolulope Adetula
8c484798de fix: overlay covering widget explorer 2021-05-10 20:59:16 +01:00
Apeksha Bhosale
2138c9059b
match is not a function (#4409) 2021-05-10 19:40:22 +05:30
arunvjn
1b98c2e520
Revert Gsheets warning modal (#4405) 2021-05-10 19:39:26 +05:30
Tolulope Adetula
23367fe3be Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-10 14:43:38 +01:00
Tolulope Adetula
579085a88b Merge branch 'fix/Datasource-dropdown-stacking-issue' into fix/dropdown-overlap-modal 2021-05-10 14:42:40 +01:00
Tolulope Adetula
57a621978d Merge branch 'release' into pr/3791 2021-05-10 14:33:01 +01:00
arunvjn
3b61af395e
Fix/text overflow json viewer (#4367)
CSS fix to wrap long urls/text in json viewer. GSheets to occupy full width
2021-05-10 18:58:38 +05:30
vicky-primathon.in
f14ca6b6c3 Hide sub icon 2021-05-10 17:04:17 +05:30
vicky-primathon.in
97178ea899 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-header-styles 2021-05-10 16:56:37 +05:30
vicky-primathon.in
9ab8da4671 Table header style changes 2021-05-10 16:54:50 +05:30
Pawan Kumar
fc10625d41
Fix: Cannot read property 'label' of undefined & Cannot read property 'length' of undefined (#4389)
* fix for label of undefined

* add check for data type

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-10 15:22:17 +05:30
vicky-primathon.in
aa5beddf4a Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-05-10 15:08:48 +05:30
vicky-primathon.in
30510c56b4 Fix download dropdown UI 2021-05-10 15:08:23 +05:30
bhavin
4c824a1214 fix: datepicker popover adjust height and width. 2021-05-10 13:14:29 +05:30
akash-codemonk
359d104f5f
Show debug button in toast only for some particular errors (#4311) 2021-05-10 13:13:12 +05:30
akash-codemonk
78ccfadb61
Fix: Make contents of tab selectable (#4390) 2021-05-10 13:08:39 +05:30
Somangshu Goswami
d4e3de6330
Merge pull request #4359 from appsmithorg/fix/dropdown-rename-select
Refactor: Rename Dropdown to Select
2021-05-10 11:25:24 +05:30
Somangshu Goswami
1864166fdc
Merge pull request #4285 from appsmithorg/fix/date-time-picker-bug
change data-time format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss'
2021-05-10 11:21:42 +05:30
akash-codemonk
bf7a8b91a4
Feature: Show widget error state (#4202) 2021-05-07 20:03:20 +05:30
bhavin
c3960a7a4d fix :extended maxDate and minDate limits to 100 years from now. 2021-05-07 18:38:43 +05:30
Nidhi
4a288439f0
Added basic authentication type to REST APIs (#4040)
* Added basic authentication type to REST APIs

* Spacing for prefix

* Tests and json ignore for password

* Client side form changes

* Review comments
2021-05-07 17:24:05 +05:30
Satish Gandham
c86390ebfe - Collapse all but the first two records in react-json-view 2021-05-07 15:22:53 +05:30
arunvjn
45aa3c57f1
Added null check against datasource url (#4352) 2021-05-07 13:24:58 +05:30
Tolulope Adetula
ff4dbfde74 Merge branch 'release' into fix/Datasource-dropdown-stacking-issue 2021-05-07 08:41:34 +01:00
Tolulope Adetula
00669d9b8e fix: move dropdown options to portal 2021-05-07 08:35:00 +01:00
Nidhi
51aee58c54 Bearer prefix without space 2021-05-07 12:35:34 +05:30
bhavin
47a7128a06 Refactor: rename Dropdown to Select 2021-05-07 10:56:36 +05:30
Tolulope Adetula
213d7e0c58 Merge branch 'release' into pr/3791 2021-05-06 19:04:14 +01:00
Paul Li
a2faae4216 Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-06 10:32:06 -04:00
Paul Li
8ea4638d00 FEATURE-4135 : Table URL columns pretty link
-- Change controlType for display text to COMPUTE_VALUE
2021-05-06 10:29:09 -04:00
bhavin
9b91a09c73 fix: set default format in table date type cell 2021-05-06 19:36:41 +05:30
arunvjn
65d33c2614
Fixed query params parsing in API pane when dynamic bindings are present in the URL (#4205) 2021-05-06 18:45:05 +05:30
Trisha Anand
ee14571ffc
[Bug Fix] : Removal of cyclical dependencies due to action relationships being added to dependency map (#4342) 2021-05-06 18:28:06 +05:30
vicky-primathon.in
a5dbb5261b Added test case to validate onSearchTextChange function if configured in table widget 2021-05-06 13:54:18 +05:30
Tolulope Adetula
829742b239 fix: reduced portal zindex 2021-05-06 08:18:39 +01:00
Satish Gandham
f193ff4a21 - Remove the accidental recursive funciton call in tablewidget 2021-05-06 12:01:39 +05:30
Satish Gandham
9fc5770d72 - Refactor the Cell render function and change it into a class property.
- Remove unsed hook.
2021-05-05 18:31:11 +05:30
Satish Gandham
abf7277d20
Merge pull request #4240 from appsmithorg/perf/optimize_react-json-viewer
Memoize CurrentValueViewer to prevent expensive rerenders of react JSON viewer
2021-05-05 18:18:05 +05:30
Trisha Anand
218ac82e7f
During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path. (#4315)
* During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path.

* To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist.

* Revert "To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist."

This reverts commit c494932289e33287074c56844fbf76c8418875af.

* Disabling cypress test which asserts cyclical errors when depending on yourself
2021-05-05 17:55:39 +05:30
Rishabh Saxena
95f3cb8a9a
Log an analytics event for cyclical dependency errors (#4323) 2021-05-05 16:51:15 +05:30
Trisha Anand
6cf3b8a901
In case the chart series data id starts with a number, it was incorrectly identified as a number instead of a string which led to incorrect path computed to check in binding paths (#4322) 2021-05-05 16:50:59 +05:30
Paul Li
ee47510fac Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-05 05:29:46 -04:00
Paul Li
4be80b665a FEATURE-4135 : Table URL columns pretty link
-- Remove the anchor tag wrapping display text
-- Make display text case-sensitive
2021-05-05 05:26:57 -04:00
Kaushik Varanasi
984119e9cb
Feature: auto create organisation Fixes #2720 (#3922)
* added basic function structure for creating organization

* added functionality for automatically creating an organization with 'Untitled organization 1' like applications. Need to add tests.

* added test for creating organizations with default names

* added tests for creating org with default name

* updated jest tests to not fill in the organization form

* remove unused imports

* deleted unnused files

* added more test to check invite users to application and check that the create application is visible

* updated share application tests according to the new workflow

* fix failing tests. TODO: fix tests with renameRandomOrg to rename specific org

* remove rename random org and rename specific orgs

* remove blocking code so the element can be scrolled into view

* fix tests

* try to fix flaky tests

* remove unused

* remove create organization tests as we are testing these components elsewhere

* fix failing tests by stubbing create org response

* update tests according to new workflow
2021-05-05 12:40:35 +05:30
vicky-primathon.in
e96fa63f6d Disable client side search when server side search is enabled in table widget 2021-05-05 12:39:15 +05:30
Somangshu Goswami
fd6709b29a
Merge pull request #4119 from appsmithorg/fix/date-input-edit
Fix date string parsing for date from input field
2021-05-05 12:08:16 +05:30
Somangshu Goswami
0a0d9794dd
Merge pull request #4099 from appsmithorg/fix/#3860-input-widget-validation
[Bug] : Input widget validation issues#3860
2021-05-05 12:06:59 +05:30
Somangshu Goswami
6d41a4eb27
Merge pull request #4211 from appsmithorg/fix/4134-table-filter-case-insensitive
Fix/4134 table filter case insensitive
2021-05-05 12:02:27 +05:30
bhavin
a29b20eca5 fix: set date picker calendar popover position to bottom 2021-05-05 11:53:59 +05:30
vicky-primathon.in
53b99c1a34 Fix email parsing issue in text widget 2021-05-05 10:59:49 +05:30
abhishek nayak
10b8cdc32a
Update WidgetConfigResponse.tsx
Edited default table column size to remove scrollbar
2021-05-05 03:36:21 +05:30
Paul Li
e1be6ad940 Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-04 15:53:24 -04:00
Paul Li
a5a0e0d85d FEATURE-4135 : Table URL columns pretty link
-- Add displayText field into property pane
-- Display urls based on displayText
-- Fix url alignment issue
2021-05-04 15:48:40 -04:00
Abhinav Jha
b508e37387
Fix DEFAULT_OPTION_VALUE validations which were breaking evaluations (#4295) 2021-05-04 22:42:15 +05:30
akash-codemonk
6ad40de1e5
Fix undefined error in debugger sagas (#4291)
Use correct types and check if validationMessages exists as it could be undefined
2021-05-04 20:12:42 +05:30
Apeksha Bhosale
8473226382
app crashes when moving from google to rest api (#4282)
* app crashes when moving from google to rest api

* wrong url for test
2021-05-04 18:38:20 +05:30
bhavin
5f9497a627 date format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss' 2021-05-04 16:39:05 +05:30
Satish Gandham
adb5f7bc7a - Memoize ReactTableComponent 2021-05-04 16:30:57 +05:30
Satish Gandham
30b33331a2
Fix cyclic dependency making the table widhget crash the app. #4209 (#4214)
- Check if sanitizedTableData is array

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-05-04 13:04:35 +05:30
Kaushik Varanasi
7af0faa32e
Feature: Fork apps across orgs : fixes #3089 (#4121)
* create basic button for forking

* added menu item for fork, opens a basic modal. TODO: Add functionality to fork

* clicking fork app enables organization select and forks across applications

* added close modal functionality. TODO: add tests, optimise code, remove duplicate and use exportswhere possible

* removed unused code

* Added cypress tests to check that fork app creates an app with same dsl. Tests Failing, needs fixing

* tests fixed, but needs unexpected login from cy

* Resolved bug with login by using correct cypress selectors

* Added tests to check that dsls match, added documentation and removed unused code

* remove unused fork function and directly dispatch from modal

* refactor code

* revert

* removed unused code and refactored tests

* feature/fork-apps-across-orgs-refactor

* make code prettier

* renamed components correctly

* refactored modal code into single file. TODO: fix warnings, test and remove unused code

* pass setModalClose to dialog component to maintain global modal state

* Added types for fork modal props

* update tests and remove unused code

* Removed isDeployedApp and instead passed trigger as a prop

* remove console logs and revert imports to small case

* rename files as components

* minor changes

* cleanup

* mock dispatch for jest

* move jest mocks to component tests
2021-05-04 11:34:23 +05:30
arunvjn
da0abfb2bf
CSS fix to wrap long urls/text in json viewer (#4269) 2021-05-04 11:17:09 +05:30
Satish Gandham
2a3d0fd28e - Destructure TableComponent props 2021-05-04 00:12:21 +05:30
abhishek nayak
edfe965cf7
Merge pull request #4248 from appsmithorg/areyabhishek-patch-2
Update WidgetConfigResponse.tsx
2021-05-03 20:28:44 +05:30
arunvjn
2956953955
Feature/gsheet warning modal (#4258)
Added modal to inform the users about google sheet warnings and events to monitors sheets usage.
2021-05-03 17:43:37 +05:30
Satish Gandham
e3b361a8d4 Change inline functions in jsx to class properties 2021-05-03 14:33:03 +05:30
akash-codemonk
c36b1ffa04
Update debugger analytics events (#4186)
- Send analytic event for tab change in api and query pane

- Also update debugger text

- Send open debugger analytic event while opening from shortcut
2021-05-03 13:38:49 +05:30
Ashok Kumar M
4350da7da3
Fix: Updating help text for tabs widget after refactor. 2021-05-03 13:12:57 +05:30
Rishabh Saxena
81a2bfa067
Fix storybook build (#4087) 2021-05-03 11:19:12 +05:30
Pawan Kumar
923cbcd595
Fix: Validation on grid gap + handle delete child on list widget (#4247)
* handle delete case for list widget

* add check for grid grap validation

* update test

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-03 10:31:47 +05:30
abhishek nayak
782afcc6b0
Create WidgetConfigResponse.tsx 2021-05-01 04:57:16 +05:30
abhishek nayak
7623b99830
Update WidgetConfigResponse.tsx
1. Changed default text of dropdown widget, and radio button
2. Changed the font size of title of form widget to heading1 from paragraph
3. Changed default location of Google maps widget
2021-05-01 04:25:37 +05:30
Satish Gandham
449ea505fe Memoize CurrentValueViewer to prevent expensive rerenders of react json viewer #4239 2021-04-30 15:06:28 +05:30
Nikhil Nandagopal
9650dfe638
Merge pull request #4236 from appsmithorg/fix/table-data
fixed the column sizes
2021-04-30 14:55:19 +05:30
Nikhil Nandagopal
529114f57f fixed the column sizes 2021-04-30 13:49:13 +05:30
Abhinav Jha
d8c9d16575
Fix #1805 base64 encoded images (#4020)
Co-authored-by: Navdeep Singh <navdeep.er@gmail.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-04-30 12:30:13 +05:30
Somangshu Goswami
9caf953b41
Merge pull request #4128 from appsmithorg/fix/#4023-datepicker-incorrect-placeholder
[Bug-4023] : Incorrect placeholder in the datepicker widget
2021-04-29 21:21:36 +05:30
vicky-primathon.in
3d79900290 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-04-29 19:56:21 +05:30
Somangshu Goswami
64961dde16
Merge pull request #4006 from appsmithorg/fix/native-scrollbars-experience
Fix-Native scrollbar UX with custom scrollbars
2021-04-29 16:27:14 +05:30
Rishabh Saxena
a0d2e8533d
Initialise comments (#3328)
* Initial scaffolding for comments CRUD APIs

* add actions

* add assets

* state management for existing comments and creating new

* add ui components

* add overlay comments wrapper to baseWidget

* add toggle comment mode button at editor header

* trigger tests

* Disallow commenting as someone else

* Add applicationId for comments

* lint

* Add overlay blacklist to prevent component interaction while adding comments

* Comment thread style updates

* Placeholder comment context menu

* Controlled comment thread visibility for making new comments visible by default

* Update comment type description

* Reset input on save

* Resolve comment thread button ui

* fix close on esc key, dont create new comment on outside click

* Submit on enter

* add emoji picker

* Attempt at adding a websocket server in Java

* CRUD APIs for comment threads

* Add API for getting all threads in application

* Move types to a separate file

* Initial commit for real time server (RTS)

* Add script to start RTS

* Fix position property

* Use create comment thread API

* Use add comment to thread API

* Add custom cursor

* Dispatch logout init on 401 errors

* Allow CORS for real time connection

* Add more logs to RTS

* Fix construction of MongoClient

* WIP: Real time comments

* Enable comments

* Minor updates

* Read backend API base URL from environment

* Escape to reset comments mode

* Set popover position as auto and boundary as scroll parent

* Disable warning

* Added permissions for comment threads

* Add resolved API for comment threads

* Migration to set commenting permission on existing apps

* Fix updates bringing the RTS down

* Show view latest button, scroll to bottom on creating a new comment

* Cleanup comment reducer

* Move to typescript for RTS

* Add missing server.ts and tsconfig files

* Resolve / unresolve comment

* Scaffold app comments

* Minor fixes: comment on top of all widgets, add toggle button at viewer header

* Reconnect socket on creating a new app, set connected status in store

* Retry socket connection flow

* Integration tests for comments with api mocks using msw

* Fix circular depependency

* rm file

* Minor cleanup and comments

* Minor refactors: move isScrolledToBottom to common hooks, decouple prevent interactions overlay from comments wrapper

* Use policies when pushing updates in RTS

* ENV var to set if comments are enabled

* Fix: check if editor/viewer is initialised before waiting for init action

* Add tests for comments reducer

* Revert "ENV var to set if comments are enabled"

This reverts commit 988efeaa69d378d943a387e1e73510334958adc5.

* Enable comments for users with appsmith email

* lint

* fix

* Try running a socket.io server inside backend

* Update comment reducer tests

* Init mentions within comments

* Fix comment thread updates with email rooms

* Minor fixes

* Refactors / review suggestions

* lint

* increase cache limit for builds

* Comment out tests for feature that's under development

* Add Dockerfile for RTS

* Fix policies missing for first comment in threads

* Use draftJS for comments input with mentions support

* fix fixtures

* Use thread's policies when querying for threads

* Update socket.io to v4

* Add support for richer body with mentions

* Update comment body type to RawDraftContentState

* fix stale method

* Fix mentions search

* Minor cleanups

* Comment context menu and thread UI updates

* revert: Scaffold app comments

* Yarn dependencies

* Delete comment using id api added

* Init app comments

* Add test for creating thread

* Api for delete comment with id

* Test comment creation response and policies

* Copy comment links

* Fix reset editor state

* Delete valid comment testcase added

* Delete comment TC : code refactor

* Don't allow creating comments with an empty body

* Pin comments WIP[]

* Ignore dependency-reduced-pom.xml files from VCS

* Cleanup of some dev-only files, for review

* Delete comment

* Update socket.io to v4 in RTS

* Pin and resolve comment thread object added in commentThread

* Pin and resolve comment thread object added in commentThread

* Update comment thread API

* Added creationTime and updationTime in comment thread response

* Added creationTime and updationTime in comment thread response

* Added human readable id to comment threads, fallback to username for null name in user document

* Refactor

* lint

* fix test, rm duplicate selector

* comment out saga used for dev

* CommentThread viewed status, username fallback for getName=null, username field added in pin & resolve status

* lint

* trigger tests

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com>
2021-04-29 16:03:51 +05:30
Paul Li
6d9d7d94bf Merge branch 'release' into fix/4134-table-filter-case-insensitive 2021-04-29 06:04:05 -04:00
vicky-primathon.in
9469571a0c Fix type issue 2021-04-29 15:33:40 +05:30
Paul Li
aedac74d3a Merge branch 'release' into fix/#4023-datepicker-incorrect-placeholder 2021-04-29 05:54:24 -04:00
Paul Li
2344af3b59 BUG-4134 : Table filter search shouldn't be case sensitive
-- Lowercase and then apply filters
2021-04-29 05:41:16 -04:00
vicky-primathon.in
92764c8f5c Used zipcelx instaed of xlsx lib to download table data as excel 2021-04-29 14:50:43 +05:30
Apeksha Bhosale
82a330bebb
show invalid datasource but in different color (#4198) 2021-04-29 13:25:20 +05:30
arunvjn
5867375090
Code changes to show records count for db queries/APIs/GSheets. (#4185) 2021-04-29 11:29:38 +05:30
vicky-primathon.in
fcc4ad18f6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-29 01:42:47 +05:30
Somangshu Goswami
3c144a1fe5
Merge pull request #3962 from appsmithorg/fix/multi-select-values-reset
Fix-Multi select dropdown values does not get reset inside a form
2021-04-28 20:58:23 +05:30
Somangshu Goswami
6eec8236b6
Merge pull request #4192 from appsmithorg/fix/dropdown-default-value
Fix-Dropdown default value not trimming special characters
2021-04-28 20:52:36 +05:30
Somangshu Goswami
8e5f6ec271
Merge pull request #4045 from appsmithorg/fix/table-image-cell-align
Fix- Image alignment in table widget cells
2021-04-28 20:48:31 +05:30
Somangshu Goswami
0c5e73f9fa
Merge pull request #4065 from appsmithorg/fix/table-filter-selection-background
Removed background from selected dropdown item in table widget filters
2021-04-28 20:46:41 +05:30
Somangshu Goswami
201436b84d
Merge pull request #4187 from appsmithorg/fix/bug-1610-cropped-text-in-text-widget
BUG-1610 : Text gets cropped in the text widget even when there is go…
2021-04-28 20:08:16 +05:30
vicky-primathon.in
e78b4db3b2 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-04-28 18:54:26 +05:30
vicky-primathon.in
398fe551cc Handle table data download as excel 2021-04-28 18:37:35 +05:30
Satish Gandham
7f7f6f666b
Development: Add eslint rules for code consistency (#4083)
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-04-28 15:58:39 +05:30
Paul Li
2e61174890 BUG-1610 : Text gets cropped in the text widget even when there is good amount of space
-- Change css line-height property into 1.2
2021-04-28 01:43:03 -04:00
Hetu Nandu
c8bce7344b
Set derived values as undefined if cyclic dependency (#4159) 2021-04-27 19:09:52 +05:30
Paul Li
17dd8d525e Merge branch 'release' into fix/#3860-input-widget-validation 2021-04-27 09:19:50 -04:00
Nikhil Nandagopal
a931c372be
Merge pull request #4179 from appsmithorg/fix/logs
[Fix] fire events locally to debug analytics
2021-04-27 18:31:47 +05:30
Nikhil Nandagopal
73cb703962 fire event locally to debug analytics 2021-04-27 18:23:08 +05:30
arunvjn
cbb619a266
Show server error message when mongo auth is invalid. (#4110) 2021-04-27 18:22:26 +05:30
Nikhil Nandagopal
217b55697b
Merge pull request #4089 from appsmithorg/fix/table-data
Updated the default table data to guide users to connect a datasource
2021-04-27 14:14:23 +05:30
Ashok Kumar M
8f7cc87801
Fix: Tabs widget refactor with new nested property validation (#4014)
* dip

* test cases first commit

* Adding Tabs migrator.

* fixing tests.

* bug fix.

* selected tab fix

* missed commit

* fixing bugs

* Fixing tab name bugs.

* close property pane when dragging or resizing

* migration changes.

* release rebase changes.

* adding List factory

* remove dynamic bindings on deleting tabs.

* Adding validation messages for nested properties as well

* fixing validation issue.

* tabs visibility validation.

* missed commit

* Fixing broken cypress tests.

* Fixing broken tests.
2021-04-27 12:46:54 +05:30
vicky-primathon.in
72d5ec5b64 Fix dropdown default value not trimmed before using for value selection 2021-04-27 11:29:52 +05:30
Apeksha Bhosale
0b2bd452df
Query pane size adjusted as API pane field (#4162) 2021-04-27 11:04:09 +05:30
abhishek nayak
c1bc9ed9f2
Update ContainerWidget.tsx
Updated the color field in the property pane to color picker instead of 'Input_text'
2021-04-27 05:07:11 +05:30
Kaushik Varanasi
9752631103
Bugfix: omnibar issues : fixes #3742 (#3998)
* Added reducers and sagas for cleaning up ui.pageWidgets on creating new application

* Add border and scale to omnibar helpbar on hover

* Added analytics event for omnibar fire on clicking help button

* Linked documentation buttons in API pane and DB query pane to Omnibar

* Added tests to make sure Omnibar has correct styles

* Added margin to make sure border is visible

* Added cypress tests to check that api pane documentation opens the omnibar modal

* Added tests for page widgets reducer reset widget state action

* Added cypress tests to check db documentation opens in global search modal

* remove scale transform

* update recent widgets on selecting widget from omnibar and also clear search when done

* added some documentation links for specific db queries

* added more documentation links, added analytics for omnibar open, set query on opening omnibar from navigation

* remove slicing of 1st option in recent entities, revert previous code and remove console log

* make query syntax better

* add transparent border to remove side effects

* ensure that query is empty upon opening omnibar

* add omnibar documentation helpers to constants

* remove unused files

* added omnibar open and search to readmore button in new query pane

* added analytics event, cleanup and documentation

* removed unused set queries

* Fixed failing cypress tests according to new workflow. Removed invalid comments
2021-04-26 22:15:03 +05:30
somangshu goswami
02fed75899 Merge branch 'release' into fix/table-filter-selection-background 2021-04-26 20:24:03 +05:30
Somangshu Goswami
978bec7866
Merge pull request #3987 from appsmithorg/fix/filepicker-clear-files
Fix-Selected file deletion not working in File Picker widget
2021-04-26 20:17:45 +05:30
vicky-primathon.in
c88e0724e1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-26 19:46:02 +05:30
Nikhil Nandagopal
c3ef0b1bc5 Merge branch 'release' of github.com:appsmithorg/appsmith into fix/table-data 2021-04-26 19:19:41 +05:30
Hetu Nandu
12bb6dd715
Fix datasource invalids check (#4164) 2021-04-26 19:18:13 +05:30
Nikhil Nandagopal
edac5344d2 Merge branch 'release' of github.com:appsmithorg/appsmith into fix/table-data 2021-04-26 19:00:09 +05:30
Nikhil Nandagopal
165c7cdc78 removed unused imports 2021-04-26 18:59:53 +05:30
Nikhil Nandagopal
54fd4c5832 updated action as a primary col 2021-04-26 18:16:56 +05:30
Apeksha Bhosale
be15d0d44b
Show warning when connecting to localhost (#4017) 2021-04-26 17:47:38 +05:30
Apeksha Bhosale
5dac939534
Show hint message for identical column (#4033) 2021-04-26 17:46:48 +05:30
Pawan Kumar
d814e780ed
Fix: Update chart from array to object (#3907)
* update structure of chart data

* update chart data

* update chart data structure

* remove array like validator

* remove log

* remove log

* widget utils + update tests for chart data validations

* update utils test

* add migrations

* remove unnecessary helper function

* remove unnecessary helper function

* update validation test cases

* WIP

* WIP 2

* Remove validationConfigMap from widget and add to properties

* Update data tree validator to get validation from the correct place

* Minor reference fixes

* Fix test mocks

* fix for bad setting of nested property path

* add test for migration for chart widget function

* fix test for widget utils

* remove unused import;

* remove unsued import

* update migration version

* remove console and add check if data is array

* fix custom fusion chart + validation not working issue

* move custom fusion chart config to chart data section

* remove console and unused import

* fix test

* fix property config test

* fix dynamicbinding path list in migration

* remove old chart validation

* remove old validation test

* fix widget prop utils test

* remove array codepath for widget utils

* fix utils test

* fix utils test

* fix prettier issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-26 16:05:59 +05:30
Rishabh Saxena
46b67577dd
Check if localstorage is supported (#3974) 2021-04-26 14:48:39 +05:30
Hetu Nandu
c92eb0e5a4
Introduce different evaluation types for different binding fields (#3834) 2021-04-26 11:11:32 +05:30
akash-codemonk
36532cbcc8
[Feature] Debugger logs (#3633) 2021-04-23 19:20:55 +05:30
Paul Li
37b8a054e8 [Bug-4023] : Incorrect placeholder in the datepicker widget
-- Change date format to `YYYY-MM-DD HH:mm`
2021-04-23 08:08:37 -04:00
Hetu Nandu
11e9276964
Fix set evaluated tree performance tracking 2021-04-23 17:04:33 +05:30
Pawan Kumar
ce4ae70377
add check for root existence (#4120)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-04-23 14:45:19 +05:30
vicky-primathon.in
2cd932ce80 Fix date string parsing for date from input field 2021-04-23 13:34:37 +05:30
Pawan Kumar
1717b0e392
[Feature] Grid Widget (#2389)
* Updated test

* updated assertions

* Resizing image to take full width of table cell

* updated assertion

* Stop updating dynamicBindingPathList directly from widget

* Fix selectedRow and selectedRows computations

* Fix primaryColumns computations

* Updated test for derived column

* Added tests for computed value

* Added check clear data

* Reordering of test

* updated common method

* Made image size as 100% of table cell size

* add templating logic

* Updated flow and dsl

* Clear old primary columns

* Updated testname

* updated assertion

* use evaluated values for children

* Fix primary columns update on component mount and component update

* add isArray check

* remove property pane enhancement reducer

* add property pane enhancement reducer

* disable items other than template + fix running property enchancment on drop of list widget

* disbled drag, resize, settingsControl, drag for items other than template

* add grid options

* uncomment the widget operation for add child for grid children

* handle delete scenario for child widget in list widget

* WIP: Use the new delete and update property features

* add listdsl.json for testcases

* add test cases for correct no. of items being rendered

* add test cases currentItem binding in list widget

* change dragEnabled to dragDisabled

* change resizeEnabled to resizeDisabled

* change settingsControlEnabled to settingsControlDisabled

* change dropEnabled to dropDisabled

* update settingsControlDisabled default value

* Use deleteProperties in propertyControls

* Fix unsetting of array indices when deleting widget properties

* remove old TableWidget.tsx file

* Fix derived column property update on primary column property update

* Handle undefined primary columns

* Fix filepicker immutable prop issue

* Fix object.freeze issue when adding ids to the property pane configuration

* fix widget issue in grid

* Fix column actions dynamicBindingPathList inclusion issue

* remove consoles + fix typo around batch update

* Remove redundant tests

* js binding test for date picker

* hydate enhancement map on copy list widget

* check for dynamicleaf

* fixes

* improve check

* fix getNextWidgetName

* update template in list widget when copying

* updating template copy logic when copying widget

* update dynamicBindingPathList in copied widget

* Add path parameter to hidden functions in property pane configs

* fix copy bug when copying list widget

* add computed list property control

* Remove time column type

Fix editor prompt for currentRow

Fix undefined derivedColumns scenario

Remove validations for primaryColums and derivedColumns

Fix section toggle for video, image and button column types

* Fix table widget actions and custom column migrations

* Add logs for cyclical dependency map ♻️

* Process array differences

* add property control for list widget

* Fix onClick migrations

* Property pane config parity

* binding and trigger paths from the property pane config (#2920)

* try react virtualized library

* Fix unit test

* Fix unit test 

* Fix minor issues in table widget

* Add default meta props to binding paths to ensure eval and validation

* Dummy commit 🎉

* Remove unnecessary datepicker test

Fix chart data as string issue

* Achieve table column sorting and resizing parity with release

* handle scenario where last column isn't available to access

* Fix for panel config path not existing in the widget

* Fix bindings in currentRow (default)

Add dummy property pane config for canvas widget

* Update canvas widgets with dynamicPathLists on delete of property paths

* Add all diffs to change paths and trim later

* Add back default properties 🚶🏻‍♂️

* Use object based paths instead of arrays for primaryColumns and derivedColumns

* Fix issue in reordered columns

* Fix inccorect update order

* add virtualized list

* Fix failing property pane tests

* minor change

* minor list widget change

* Remove .vscode from git

* Rename ads to alloy

Fix isVisible in list widget

* move grid component to widget folder

* fix import in widget registry

* add sticky row in virtualized list

* add sticky container

* Fix Height of grid widget items container

* fix dragging of items in children other than template children

* update list widget

* update list widget

* Fix padding in list widget

* hide scrollbar in list widget list

* fix copy bug in list widget

* regenrate enhancement map on undo delete widget

* Use enhancementmap for autocomplete in list widget

Basic styles for list widget scrollbar

* add custom control in widget config

* minor commit

* update scrollbar styles

* remove unused variable

* fix typo in custom control

* comment out test cases

* remove unused imports

* remove unused imports

* add JSON stringify in interweave

* add noPad styling in dragLayer for noPad prop

* implement grid gap

* add list item background color prop

* add white color in color picker control

* fix gap in last list item

* remove onBeforeParse in textcomponent

* remove virtualization in grid widget

* allow overflow-y

* add onListItemClick action

* add beta label

* add pagination

* fix actions in pagination in list widget

* add list widget icon

* add list background color default value

* remove extra div

* fix pagination issue

* fix list widget crashing on perpage change

* extract child operation function to widgetblueprint saga

* refactor enhancements

* add enhancement hook

* refactor propertyUpdate hook enhancment

* remove enhacement map

* revert renaming ads to alloy

* add autopagination

* Cleanup unused vars

Re-write loop using map

Fix binding with external input widget

* update default background color

* remove unnessary scrol + fix pagination per page

* remove console.log

* use grid gap in pixel instead of snap

* fix list widget tests for binding

* add tests for on click action and pagination

* remove unnecessary imports

* remove overflow hidden in list component

* Add feature to enable template actions

* update property pane help text for list widget

* disable pagination in editor view

* update property pane options

* add test case for action

* uncomment tests

* fix grid gap validation

* update test cases

* fix property pane opening issue for list tempalte

* Disable form widgets in list widget

* fix template issue for actions

* add validation tests for list data

* update starting template

* add selectedRow + enable pagination in edit mode

* remove extra padding in list widget + popper fix on settingDisabled

* add stop propagation for button click

* fix click event in edit mode

* disallow filepicker widget for list widget

* add test for list widget entity definition for selectItem

* remove unused imports

* fix test

* remove evaluated value for list child widgets

* add comment

* remove log

* fix copying bug in list widget

* add check for not allowing template to copy

* fix test

* add test for property pane actions

* remove unused import

* add draglayercomponent test

* add test for draggable component

* add test for evaluatedvalue popup

* add test for messages.ts

* add test for widgeticons

* add test for property pane selector

* add test for widget config response

* start testing widget configresponse

* add test for enhancements in widget config

* add test for codeeditor

* add test for base widget + list widget

* add test for executeWidgetBlueprintChildOperations

* remove unused import

* add test for widget operation utils

* remove unused import

* add test for handleSpecificCasesWhilePasting

* remove unused function

* remove unused import

* add empty list styling

* resolve all review comments

* fix message test

* add test for widget operation utils

* fix merge conflicts

* move validations in property config

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-04-23 11:13:13 +05:30
Paul Li
d099a3954e [Bug] : Input widget validation issues#3860
-- Rewrite the validation for number type
2021-04-22 04:32:23 -04:00
vicky-primathon.in
3abd6416e9 Created Scrollbar thumb components and used useMemo for optimizatized rendering of table header component 2021-04-22 10:13:54 +05:30
Nidhi
6b31aa333b
Introducing Google Sheets Plugin (#3517)
* cherry pick -make new

* revert to enable fix from release

* attempt to hook into existing datasource editor

* gSheets plugin skeleton from Rest API

* Changes for database migration

* fix for auth code

* separate it out

* action page loads!

* add to explorer

* create action from datasource

* Editor JSON WIP

* working query form

* Editor JSON WIP

* import to

* fix toast message

* redirect from datasource and editor pages

* fix onboarding

* fix imports and constants

* refactor form out

* refactor queryForm

* Merge branch 'release' into feature/google-sheets

* Merge branch 'release' into feature/google-sheets

* initial values from settings, editor and form

* Check

* remove dangling code around lightTheme

* Safety net

* remove class

* try mouseover solve

* force click

* changes from review

* fix action form name on import

* Merge branch 'release' into feature/google-sheets

* minor cleanup

* Merge branch 'release' into feature/google-sheets

* WIP

* Google sheets changes

* Merge conflicts

* Merging and fixes, needs refactoring

* Check

* Merge branch 'release' into feature/google-sheets

* Fixed tests

* Add cloud services env variable

* Clean up saga

* Clean up

* Refactoring

* Deleted svg file

* Minor fixes

* Modified design to allow behaviour in google sheets methods (#3486)

* Modified design to allow behaviour in google sheets methods

* Review changes

* Removed sysout

* Added handling of edge cases with table data

* Merge branch 'release' into feature/google-sheets

* Fixes

* Fixes

* Added validations

* Improved tests

* Removed extraneous injected bean

* Review changes

* Fixed bug with method

* Changes to Google sheets plugin's request and response structures (#3692)

* Method changes

* Removed logging

* Renaming options

* Reverting pom version

* Modified type of collection variables, fixed errors

* Converted row offset field to one that supports dynamic bindings

* Review changes

* List SAAS plugin type actions under lightning menu apis (#3820)

* list saas plugin type actions under lightning menu apis

* combine saas plugin type actions in the other sub menu of lightning menu

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* Fix merge issues

* Prettified query editor and a few fixes w/ ux

* Test fixes

* Reformatting request

* code for REST added (#3876)


Co-authored-by: hetunandu <hetu@appsmith.com>

* Renamed body to row object

* Renamed placeholder for range

* Renamed range heading

* Modifications to handle range semantics

* Use spreadsheet Url instead of id

* Ordering of methods

* Removed logging

* Add tests for Dynamic text controls

* Add tests for url helpers

* Fix coverage config

* Nevermind

* Interface changes

* There is no body here

* Yay to hints

* Delete row field is separately handled as row index

* placeholder support (#4001)

* Fixed tests, typos and creating new sheets with random rows

* Switched to using 'rowIndex' throughout

* binding path added for query input field (#4016)

* - Fixed QA bugs (#4032)

- Split delete sheet into two
- Removed dynamic query input types from hidden keys

* Proper exceptions

* Removed extra logging

* Throw exception if update method does not match any of the columns

* Same for bulk update

* Zero-indexed delete row

* I'm a space bound rocket ship

* Logic to register installations with cs (#4062)

* Logic to register installations with cs

* Clean up

* Casting to string

* Checking to see if this makes the test pass

* Added an extra null check

Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-04-22 09:00:09 +05:30
vicky-primathon.in
1474aa01e3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-21 21:27:55 +05:30
vicky-primathon.in
e9055a6521 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/multi-select-values-reset 2021-04-21 21:26:19 +05:30
vicky-primathon.in
eea0472a72 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/filepicker-clear-files 2021-04-21 21:25:47 +05:30
vicky-primathon.in
c42839180e Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-21 21:25:19 +05:30
Hetu Nandu
4d73e7e0b3
Widget validation for nested property paths (#3947) 2021-04-21 20:04:25 +05:30
Nikhil Nandagopal
a13fe4369e updated the default table data to guide users to connect a datasource 2021-04-21 16:10:45 +05:30
Satish Gandham
f7794495d7
Fix Map Widget crash #3843 (#4031)
* Fix map method being called on undefined varaible in MapComponent #3843
Sentry Issue: APPSMITH-N5

* Add type to marker property #3843

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-04-21 14:55:35 +05:30
Hetu Nandu
6c681ef98c
Fix initial value check for action form config (#4080) 2021-04-21 13:18:24 +05:30
Vicky Bansal
318cb78464
Escape line break characters when exporting table data to CSV (#3757) 2021-04-20 16:17:06 +05:30
Trisha Anand
eeaa26a7cc
Type migration from String to Object for plugin specified templates to preserve boolean and any other future data types (#4053)
* WIP : Type migration from String to Object for value

* Migrating config from string to boolean for prepared statement.
Handled error for already stored actions where PS config is stored as String and not Boolean.
2021-04-20 16:09:48 +05:30
Apeksha Bhosale
333c4169eb
name can't be read from empty object (#3958) 2021-04-20 12:26:30 +05:30
Apeksha Bhosale
568269e8e1
size change for raw and editor in API editor (#3984)
* size change for raw and editor in API editor

* removed from global css file

* removed classes
2021-04-20 11:13:26 +05:30
Apeksha Bhosale
f509f1b50b
datasource edit should be always enabled (#3979) 2021-04-20 11:12:25 +05:30
vicky-primathon.in
385011daa0 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-19 22:17:20 +05:30
Hetu Nandu
59ad172d81
Hot fix redirection race in oAuth autorisation flow (#4052) 2021-04-19 18:47:27 +05:30
vicky-primathon.in
faaf2e3345 Scroll should not be required for header in default table 2021-04-19 17:02:31 +05:30
vicky-primathon.in
934563a154 Removed background from selected dropdown item in table widget filters 2021-04-19 13:32:23 +05:30
Trisha Anand
eaa24ca894
[Bug Fix] : Fetch actions by id during refactor action name to solve IncorrectResultSizeDataAccessException for pages where duplicate action names exist (#4030)
* New dto for refactoring action name which includes actionId as well

* Refactor action name now also takes actionId as payload and fetches the action from db by id instead of name to solve for the scenario where the action names could be duplicated.

* Adding actionId to QP of action refactor API.

* WIP : test for asserting the bug fix

* WIP test

* Fixed the test case asserting refactoring works for an action when there are duplicate action names in the page.

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-04-19 12:35:10 +05:30
vicky-primathon.in
2b8ab8dc8f Align page number text in table pagination 2021-04-19 11:12:18 +05:30
vicky-primathon.in
7a9dfb2066 Fixed table image cell alignment
Added cypress test to validate image cell alingment
2021-04-19 10:31:17 +05:30
vicky-primathon.in
15521fef06 Fix horizontal scrollbar 2021-04-19 09:02:47 +05:30
vicky-primathon.in
89af3501aa Removed vertical scroll bar from table header 2021-04-15 16:37:54 +05:30
Trisha Anand
9b49308abe
Adding dependency relationship to plugins (#3997)
* Added dependencies to be added to dependencyMap on client to Postgres, MSSQL, MySQL and Mongo plugins

* Added Dependency config for API

* Fixed the test case
2021-04-15 11:36:41 +05:30