Commit Graph

47 Commits

Author SHA1 Message Date
Rishabh Saxena
25a6fd2240
Fixes related to the comments feature (#5904) 2021-07-19 20:58:41 +05:30
Hetu Nandu
c2a1c1feb4
Don't log debug level logs in prod (#5527) 2021-07-05 11:19:43 +05:30
Pranav Kanade
dd9f8b362d
[Feature #3379] Added recaptcha for signup (#4701)
* temp commit

* using onsubmit to continue using action on form

* added recaptcha site key to env example file

* moved the recaptcha lib loading logic to signup page

* removed unnecessary edit

* handle the case where the recaptcha token is not provided as env var

* added proper env var config for client

* recaptcha config for ansible

* recaptcha config for heroku

* recaptcha config for k8s

* updated app.json

* fixed the typos

* added more description for env vars

* removed api key

* minor typo fix
2021-06-08 11:10:11 +05:30
Rishabh Saxena
d9758f7755
Onboarding form (#4910) 2021-06-04 13:18:17 +05:30
Rishabh Saxena
a0d2e8533d
Initialise comments (#3328)
* Initial scaffolding for comments CRUD APIs

* add actions

* add assets

* state management for existing comments and creating new

* add ui components

* add overlay comments wrapper to baseWidget

* add toggle comment mode button at editor header

* trigger tests

* Disallow commenting as someone else

* Add applicationId for comments

* lint

* Add overlay blacklist to prevent component interaction while adding comments

* Comment thread style updates

* Placeholder comment context menu

* Controlled comment thread visibility for making new comments visible by default

* Update comment type description

* Reset input on save

* Resolve comment thread button ui

* fix close on esc key, dont create new comment on outside click

* Submit on enter

* add emoji picker

* Attempt at adding a websocket server in Java

* CRUD APIs for comment threads

* Add API for getting all threads in application

* Move types to a separate file

* Initial commit for real time server (RTS)

* Add script to start RTS

* Fix position property

* Use create comment thread API

* Use add comment to thread API

* Add custom cursor

* Dispatch logout init on 401 errors

* Allow CORS for real time connection

* Add more logs to RTS

* Fix construction of MongoClient

* WIP: Real time comments

* Enable comments

* Minor updates

* Read backend API base URL from environment

* Escape to reset comments mode

* Set popover position as auto and boundary as scroll parent

* Disable warning

* Added permissions for comment threads

* Add resolved API for comment threads

* Migration to set commenting permission on existing apps

* Fix updates bringing the RTS down

* Show view latest button, scroll to bottom on creating a new comment

* Cleanup comment reducer

* Move to typescript for RTS

* Add missing server.ts and tsconfig files

* Resolve / unresolve comment

* Scaffold app comments

* Minor fixes: comment on top of all widgets, add toggle button at viewer header

* Reconnect socket on creating a new app, set connected status in store

* Retry socket connection flow

* Integration tests for comments with api mocks using msw

* Fix circular depependency

* rm file

* Minor cleanup and comments

* Minor refactors: move isScrolledToBottom to common hooks, decouple prevent interactions overlay from comments wrapper

* Use policies when pushing updates in RTS

* ENV var to set if comments are enabled

* Fix: check if editor/viewer is initialised before waiting for init action

* Add tests for comments reducer

* Revert "ENV var to set if comments are enabled"

This reverts commit 988efeaa69d378d943a387e1e73510334958adc5.

* Enable comments for users with appsmith email

* lint

* fix

* Try running a socket.io server inside backend

* Update comment reducer tests

* Init mentions within comments

* Fix comment thread updates with email rooms

* Minor fixes

* Refactors / review suggestions

* lint

* increase cache limit for builds

* Comment out tests for feature that's under development

* Add Dockerfile for RTS

* Fix policies missing for first comment in threads

* Use draftJS for comments input with mentions support

* fix fixtures

* Use thread's policies when querying for threads

* Update socket.io to v4

* Add support for richer body with mentions

* Update comment body type to RawDraftContentState

* fix stale method

* Fix mentions search

* Minor cleanups

* Comment context menu and thread UI updates

* revert: Scaffold app comments

* Yarn dependencies

* Delete comment using id api added

* Init app comments

* Add test for creating thread

* Api for delete comment with id

* Test comment creation response and policies

* Copy comment links

* Fix reset editor state

* Delete valid comment testcase added

* Delete comment TC : code refactor

* Don't allow creating comments with an empty body

* Pin comments WIP[]

* Ignore dependency-reduced-pom.xml files from VCS

* Cleanup of some dev-only files, for review

* Delete comment

* Update socket.io to v4 in RTS

* Pin and resolve comment thread object added in commentThread

* Pin and resolve comment thread object added in commentThread

* Update comment thread API

* Added creationTime and updationTime in comment thread response

* Added creationTime and updationTime in comment thread response

* Added human readable id to comment threads, fallback to username for null name in user document

* Refactor

* lint

* fix test, rm duplicate selector

* comment out saga used for dev

* CommentThread viewed status, username fallback for getName=null, username field added in pin & resolve status

* lint

* trigger tests

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com>
2021-04-29 16:03:51 +05:30
Nidhi
6b31aa333b
Introducing Google Sheets Plugin (#3517)
* cherry pick -make new

* revert to enable fix from release

* attempt to hook into existing datasource editor

* gSheets plugin skeleton from Rest API

* Changes for database migration

* fix for auth code

* separate it out

* action page loads!

* add to explorer

* create action from datasource

* Editor JSON WIP

* working query form

* Editor JSON WIP

* import to

* fix toast message

* redirect from datasource and editor pages

* fix onboarding

* fix imports and constants

* refactor form out

* refactor queryForm

* Merge branch 'release' into feature/google-sheets

* Merge branch 'release' into feature/google-sheets

* initial values from settings, editor and form

* Check

* remove dangling code around lightTheme

* Safety net

* remove class

* try mouseover solve

* force click

* changes from review

* fix action form name on import

* Merge branch 'release' into feature/google-sheets

* minor cleanup

* Merge branch 'release' into feature/google-sheets

* WIP

* Google sheets changes

* Merge conflicts

* Merging and fixes, needs refactoring

* Check

* Merge branch 'release' into feature/google-sheets

* Fixed tests

* Add cloud services env variable

* Clean up saga

* Clean up

* Refactoring

* Deleted svg file

* Minor fixes

* Modified design to allow behaviour in google sheets methods (#3486)

* Modified design to allow behaviour in google sheets methods

* Review changes

* Removed sysout

* Added handling of edge cases with table data

* Merge branch 'release' into feature/google-sheets

* Fixes

* Fixes

* Added validations

* Improved tests

* Removed extraneous injected bean

* Review changes

* Fixed bug with method

* Changes to Google sheets plugin's request and response structures (#3692)

* Method changes

* Removed logging

* Renaming options

* Reverting pom version

* Modified type of collection variables, fixed errors

* Converted row offset field to one that supports dynamic bindings

* Review changes

* List SAAS plugin type actions under lightning menu apis (#3820)

* list saas plugin type actions under lightning menu apis

* combine saas plugin type actions in the other sub menu of lightning menu

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* Fix merge issues

* Prettified query editor and a few fixes w/ ux

* Test fixes

* Reformatting request

* code for REST added (#3876)


Co-authored-by: hetunandu <hetu@appsmith.com>

* Renamed body to row object

* Renamed placeholder for range

* Renamed range heading

* Modifications to handle range semantics

* Use spreadsheet Url instead of id

* Ordering of methods

* Removed logging

* Add tests for Dynamic text controls

* Add tests for url helpers

* Fix coverage config

* Nevermind

* Interface changes

* There is no body here

* Yay to hints

* Delete row field is separately handled as row index

* placeholder support (#4001)

* Fixed tests, typos and creating new sheets with random rows

* Switched to using 'rowIndex' throughout

* binding path added for query input field (#4016)

* - Fixed QA bugs (#4032)

- Split delete sheet into two
- Removed dynamic query input types from hidden keys

* Proper exceptions

* Removed extra logging

* Throw exception if update method does not match any of the columns

* Same for bulk update

* Zero-indexed delete row

* I'm a space bound rocket ship

* Logic to register installations with cs (#4062)

* Logic to register installations with cs

* Clean up

* Casting to string

* Checking to see if this makes the test pass

* Added an extra null check

Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-04-22 09:00:09 +05:30
Rishabh Saxena
244930dd69
Add support of component unit testing (#3828)
Update jest config, add msw hooks
2021-04-02 15:17:16 +05:30
Hetu Nandu
0c77051944
Improve performance monitoring (#3790) 2021-03-31 13:10:59 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
Piyush Mishra
1521f7445c
Fix eslint warnings (#2510) 2021-01-12 06:52:31 +05:30
Nikhil Nandagopal
7d70a71d70 added code to prune payloads from sentry actions and reduce depth of actions reported 2020-12-09 14:42:12 +05:30
Nikhil Nandagopal
0c1d914c38
Merge pull request #2064 from appsmithorg/fix/sentry-errors
[Fix] reduced depth of information shared via sentry to prevent 413 errors
2020-12-07 20:01:25 +05:30
Nikhil Nandagopal
03053d40c3 reduced depth of information shared to allow error sharing 2020-12-07 19:54:51 +05:30
Pawan Kumar
066e20d0a2
Fix: Remove Fusioncharts Watermark (#1978)
* Fusion charts watermark can be removed by adding the `APPSMITH_FUSIONCHARTS_LICENSE_KEY` env variable.

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-02 16:12:51 +05:30
Arpit Mohan
955f80925f
Fixing the telemetry on self-hosted instances (#1714) 2020-11-12 19:01:40 +05:30
Arpit Mohan
073555ee8a
Moving all telemetry check to the configs class (#1700)
Now we enable/disable all analytics in a central location in the configs class. This ensures that each analytics function can simply check it's own value and not worry about checking for the disableTelemetry flag
2020-11-12 11:56:09 +05:30
Nikhil Nandagopal
e411df0a64
Added check so that existing installs don't get telemetry (#1698)
* Adding the segment key to the tagged release
* Also opting out of telemetry data in CI builds

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-11-11 23:54:19 +05:30
Nikhil Nandagopal
a1d6b0232b enabled perf for sentry 2020-11-11 18:07:40 +05:30
Arpit Mohan
b3eabf68ea Moving the segment CE key to a build time variable instead of hard coding it 2020-11-05 10:54:30 +05:30
Arpit Mohan
1413203251 Adding the check for disabling telemetry if the environment variable is set 2020-11-04 17:50:14 +05:30
Nikhil Nandagopal
e963b3a2f5
disable sentry perf (#1399) 2020-10-26 16:46:24 +05:30
Nikhil Nandagopal
3fdd0a246a
Feature/instrumentation (#744)
* bumped sentry version
modified performance monitor to use a queue internally to make synchronous logging easy
added logging for api pane close / open and various different methods

* added use effect to stop tracking on mount of entity properties

* removed open api tracking

* fixed stop tracking to pop from the end instead of the beginning
added tracking for editor mount and sidebar mount

* added tracking for entity explorer

* moved from app route to sentry app route because passing JSX to app route causes re-renders

* Fixing theme and route change issues.

* added performance tracking for API / Query execution and Page Load actions

* added isntrumentation to open / close actions

* added instrumentation for apis & actions

* reduced sample rate
added async tracking

* added tracking for property pane

* Remove tracking from reducer

* added option to attach async operations to parent transactions

* Fix typo

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-28 10:42:23 +05:30
Arpit Mohan
20d85d8949
Giving higher preference to window variables instead of build variables in configuration. (#644)
This is because window configurations have been set by the user while the build configurations have been set by the build script.
2020-09-21 18:20:19 +05:30
Nikhil Nandagopal
28f70e911f moved sentry plugin to the end so sourcemaps are generated correctly 2020-09-03 01:17:49 +05:30
Nikhil Nandagopal
750e48977d removed sentry cli again
increased redux depth
2020-09-02 22:15:42 +05:30
Nikhil Nandagopal
0b22fc67b3
Updated sentry sdk (#461)
Integrated react router for better performance reporting
Added Sentry Profiler for editor, appviewer and widgets

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-08-28 22:53:07 +05:30
Nikhil Nandagopal
4ab6632fdc fixed sentry performance monitoring 2020-08-28 19:41:16 +05:30
Nikhil Nandagopal
bdbc73658e
Feature/sentry (#452)
* updated sentry and added performance monitoring

* identify users on sentry

* removed sentry browser

* added the environment for sentry

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-08-28 14:04:01 +05:30
Hetu Nandu
0b430d0324
Completely replace hotjar with smartlook (#447)
* Replace hotjar with smartlook

* Remove duplicate event declaration
2020-08-27 18:24:03 +05:30
Hetu Nandu
f744f3aacd
add support for smart look (#431) 2020-08-26 14:54:44 +05:30
Hetu Nandu
f70c55c681
Show warning when mail client is not enabled on an instance (#333)
* Adds the `APPSMITH_MAIL_ENABLED` flag on client
* Shows warning if email service not configured for inviting users in an org
* Shows warning if email service not configured for password reset
2020-08-20 10:43:20 +05:30
Hetu Nandu
7f8befc365
Update support menu (#259)
Add a default help menu with
* Report a Github issues link
* Documentation link
* Github discussions link
* Intercom link support
* App version id support
2020-08-14 15:17:47 +05:30
Abhinav Jha
1ced3aa67a
Add sentry release and environment configurations (#277)
* Add sentry release and environment configurations

* Fixing nginx config issue

Co-authored-by: Satbir Singh <satbir121@gmail.com>
2020-08-13 10:16:06 +05:30
akash-codemonk
0b91612710
Add environment variable APPSMITH_CLOUD_HOSTING (#145) 2020-07-23 11:02:00 +05:30
Abhinav Jha
94b28311c6
Use injected configuration from Nginx at runtime instead of build time (#30)
* Use envsubst and nginx templates to generate nginx configs which can substitute environment variables and inject into the index.html file

* Fix path in dockerfile. Add .gitignore and .env.example files. Fix nginx-linux template.

* Add all environment variables. Add prefix to all environment variables. Update scripts to attempt to substitute all environment variables with the prefix

* Setup dockerfile to execute a bash script. use env.example for fetching environment variables in development

* Toggle features based on injected configs. Fix nginx template substitution script.

* Update env.example file

* Remove debug code from start-nginx.sh

* Fix nginx config templates by adding quotes by default. Fix sed regex to include numerals. Toggle social login buttons on Login page based on the config.

* Update rapid api environment variable name. Toggle oauth buttons based on config in SignUp page. Update .env.example to be a union of server and client environment variables

* Adding a Map disabled message on Map widget

* Adding links to Privacy policy and TNC

* Use REACT_APP_ env variables with higher priority over injected config variables for toggling features

* Update netlify.toml by commenting out the build environment variables

* Remove env variables not required by the client

* Remove start-storybook entry from package.json

* Fix netlify.toml. Fallback algolia configs

* Add contexts to netlify.toml for successful deploys. Swith to using APPSMITH_MARKETPLACE_URL as the toggle for RapidAPI feature on the client. Remove comments in nginx config templates. Fix template used in dockerfile.

Co-authored-by: Satbir Singh <apple@apples-MacBook-Pro.local>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
2020-07-07 15:52:17 +05:30
Satbir Singh
bb4004fce0 ApiPaneV2 DocsV2 QueryV2 DatasourceV2 flag removed 2020-06-15 12:21:46 +05:30
Abhinav Jha
1f5284bb67 Adding feature flag configuration for lightning menu. (UNUSED) 2020-05-29 23:59:03 +05:30
Satbir Singh
b7b74ffd02 Feature/help 2020-05-28 18:10:26 +00:00
Satbir Singh
834d9c8e7b Disabling mixpanel logs on automation by adding "Automation" environment 2020-05-22 03:06:39 +00:00
Hetu Nandu
e258e2cd00 add new pane feature flags in prod config 2020-05-18 13:47:19 +05:30
Arpit Mohan
aefcf68c80 Adding the docker image for Cypress + Nginx container.
Also modifying the Gitlab CI to use local Nginx for proxying to API backend while running Cypress tests.
2020-05-12 19:59:36 +00:00
Hetu Nandu
11dd49b98e Env dependent feature flag 2020-05-05 06:46:54 +00:00
Hetu Nandu
80db9eb030 Performance instrumentation 2020-03-23 12:40:17 +00:00
Satbir Singh
4c392c9c92 Separating segment for production and staging. 2020-03-06 08:14:59 +00:00
Abhinav Jha
de5fead89b Hotfix/baseurl env 2020-01-22 12:26:25 +00:00
Abhinav Jha
ed2ecadbc4 User Auth Flow 2019-12-16 08:49:10 +00:00
Abhinav Jha
144ea65ca3 Update API Environment URLs based on environment variables 2019-11-25 12:22:05 +00:00