Commit Graph

5217 Commits

Author SHA1 Message Date
akash-codemonk
a6df3a6deb
chore: add analytics for page creation ctas (#18676) 2022-12-12 10:12:17 +05:30
ankurrsinghal
432e513678
fix: modal deselect issue auto height (#18750)
modal deselect issue fixed when dynamicHeight property is changed
2022-12-11 20:51:46 +05:30
Aswath K
ce2925cafc
feat: Property pane search (#18164) 2022-12-11 20:12:32 +05:30
Ankita Kinger
9899eaa0c3
fix: Left panel not scrollable on Admin settings page when the list is too long (#18845) 2022-12-11 18:21:52 +05:30
rahulramesha
a1973b81a3
Fix: Context switching UX issues (#18828)
* fix Property panel jitters on focus

* open widget entity on widget selection

* Remove retaining Datasources url on page change

* fix param string while restoring URLs

* add cypress test
2022-12-10 23:59:36 +05:30
f0c1s
2ce9665b61
chore: add some more audit logs analytics (#18738) 2022-12-10 14:56:29 +05:30
Ankita Kinger
d9f20e33ad
chore: splitting the role name to avoid showing workspace name next to it (#18830)
* splitting the role name to avoid showing workspace name next to it

* fixing cypress tests failures
2022-12-10 14:00:28 +05:30
Ayangade Adeoluwa
aec6296e2c
fix: query command value from being reset to an empty state (#18559)
* Fixes query command value from being reset to an empty state

* Fix merge issues
2022-12-09 16:58:36 +00:00
Pawan Kumar
d7e2c491e0
feat: Branding (#18717)
* add branding for ce

* add ce changes

* update colorpicker ux

* remove unsued flag

* Add new email templates

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* add local appsmith logo

* code review feedback fixes + qa fixes

* remove forward slash in url of favicon

* fix message

* Fix tests

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* update messages

* Fix tests (again)

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* update messages

* fix cypress tests

* skipping app layout test cases

* fix cypress tests

* remove it.only

* try moving test

* use stable DS version

* remove __diff

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-09 20:13:47 +05:30
Sangeeth Sivan
ab00c3dda4
fix: hide workspace menu options trigger when there are no permissions (#18742)
* fix: variable mismatch fix

* fix: updated to use the right boolean flag

* fix: workspace menu order
2022-12-09 15:46:00 +05:30
sneha122
c460154c43
fix: datasource discard popup issue fixed (#18761)
* datasource discard popup issue fixed

* cypress code review changes

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-09 15:29:35 +05:30
Souma Ghosh
0395457e51
feat: Add Series Colour property for default charts (#18229)
* Adds functionality for Series Color property

* fix an issue where chart was breaking when color property is not provided

* Changes Series Color field to Color Picker type input
Default color set as primary theme color

* Under development
- Some bug fixes to the series colour feature

* Fix issue with second series color not being applied correctly
New property placeholderText for ColorPickerComponentV2
Disable series color feature for Pie Chart
Code clean up
2022-12-09 12:47:21 +05:30
Anand Srinivasan
84426b9c41
chore: update smartlook client (#18784)
update smartlook client
2022-12-09 11:45:14 +05:30
Ankita Kinger
df8add5e0c
chore: Updating the text from enterprise to business to maintain consistency (#18787)
* updating the text from enterprise to business to maintain consistency

* minor change

* Omnibar fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-09 00:08:42 +05:30
Aman Agarwal
1bcb321ec3
fix: gs quick wizard table header index (#18242)
* fix: gs quick wizard table header index

* fix: disable generate button if error

* Omni spex fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-08 22:20:51 +05:30
Hetu Nandu
3b98c8f7fe
feat: Command click navigation via code (#18326) 2022-12-08 17:46:41 +05:30
rahulramesha
3bb9e96e39
feat: [Context Switching] Complex widgets and other Phase 2 items (#17046)
This PR contains changes to retain context on the following items,
Leaving and then returning to a page should maintain what api/query was open
Entity explorer should stay as you left it when you left the page (collapse levels)
Widget/explorer tab
Width - Should be the same across all pages of an app
Property Pane width
Complex widgets, multi tier property panes

Co-authored-by: hetunandu <hetunandu@gmail.com>
Co-authored-by: Akash N <akash@codemonk.in>
Co-authored-by: Hetu Nandu <hetu@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-08 12:51:58 +05:30
Ankita Kinger
10bdbed0e3
refactor: Updating upgrade flows to start using upgrade hook for better code reusability (#18735)
* updated upgrade flow for authentication page to start using upgrade hook

* using the upgrade hook on upgrade pages as well

* adding RBAC feature flag
2022-12-08 10:48:03 +05:30
Ankita Kinger
a0211f5eed
fix: fetching the plugin form config for queries if datasource is not viewable (#18749)
fetching the plugin form config for queries if datasource is not viewable
2022-12-08 09:06:35 +05:30
Rishabh Kashyap
2213a61357
fix: resetting audio and video widget (#18126)
* bug for audio and video widget fixed

* cypress test for audio widget

* audio and video updated cypress tests

* cypress test cases updated

* writing logic for video widget

* working on video widget

* intermediate logic

* inbetween logic

* updateWidgetMetaProperty removed from onEnded event

* this.props.playing logic in onPlay & onPause events

* test code

* test code

* Add comment

* audio widget updated; comments for audio and video widget

* cypress changes

* removed cypress credentials

* comments updated

* change in comments and cypress test cases

* feedback incorporated

* comments added to audio and video spec files

* video spec updated

* video spec updated

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-12-07 20:40:28 +05:30
Tanvi Bhakta
9931d3cdc5
feat: update button states (#18335)
* fix: Form message component link issue

* removed the inverted flag for testing

* use updated design system

* category.tertiary -> category.secondary

* fix: Made changes to pass action link element to design system component - formMessage

* chore: update design-system version to access new tertiary button styles

* chore: update design-system version to use blacks instead of grays

* chore: bump design-system version to use buttons with explicit background color

* Remove rules that mess with border, background, text color on StyledPropertyPaneButton

* chore: update design-system version to use updated button categories across all ads components

Co-authored-by: Albin <albin@appsmith.com>
2022-12-07 11:44:30 +00:00
Souma Ghosh
b2f67e12bc
feat: update property name automatically when custom column name is changed (#18048) 2022-12-07 16:20:29 +05:30
Favour Ohanekwu
e37f7419b9
fix: Aggregate calls to add and remove Appsmith errors (#18285)
* Aggregate calls to add and remove Appsmith errors

* fix switch type

* Fix entity deletion errors

* Code clean up

* fix cypress tests

* Return early for empty errors in Appsmith debugger

* Remove redundant identifier

* Retain order of debugger logs

* Use push instead of unshift for perf reasons

* redundant commit to retrigger CI
2022-12-07 11:28:29 +01:00
Sangeeth Sivan
c0a7574772
fix: workspace context menu is not permission driven (#18642)
* fix: workspace context menu is now permission driven

* fix: remove action operation on global search if there are no file operations

* fix: hide more options when there are no options and refactor

* refactor: revert settings title changes in this PR

* fix: use manage permission for delete on CE

* fix: move delete workspace permission to EE

* fix: change in permissions

* Remove redundant share CTA from org menu

* fix: change of permissions for members and import/create new app

* Remove redundant invite users dialog

* Remove unused variables

Co-authored-by: hetunandu <hetunandu@gmail.com>
2022-12-07 11:07:59 +05:30
balajisoundar
be997b240a
fix: show filter & show download properties should not control add new row link visibility in table widget (#18348) 2022-12-07 09:52:18 +05:30
balajisoundar
b8aa7b3a67
fix: table widget header links should have pointer cursor when hovered (#18262) 2022-12-07 09:50:18 +05:30
Rishabh Kashyap
2afc10387f
fix: add js for icon property in button group (#18524)
made icon js convertible
2022-12-06 23:02:43 +05:30
Hetu Nandu
473501c761
fix: Remove redundant share CTA from org menu (#18718) 2022-12-06 12:50:41 +00:00
Arsalan Yaldram
ad55928fc3
chore: Fix dropdown font family (#18693)
## Description

- Fix dropdown font family. 

Fixes  #18677 



## Type of change

> Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-06 13:31:58 +05:30
sneha122
93fe30674f
fix: datasource autosave git issue fixed (#18690)
* datasource autosave git issue fixed

* Added appropriate comments

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-05 20:39:19 +05:30
Abhinav Jha
836af41be1
fix: Auto height breaks for fixed modal's children (#18691)
Fix issue where auto height was throwing an error when a fixed modal widget's children were changing height automatically
2022-12-05 20:24:45 +05:30
akash-codemonk
3eab587368
feat: [Context Switching] Maintain datasource collapse state (#17616) 2022-12-05 11:28:17 +05:30
Arsalan Yaldram
8b06621601
fix: Added support for country code flags on windows devices (#18203)
* fix: add pollyfill and use font family.

* fix: use latest version design system.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-05 10:43:21 +05:30
Sangeeth Sivan
6c498bcbf5
fix: datasource title not editable and ctas disabled on create (#18645)
fix: datasource title not editable on create flow, delete save ctas disabled on rest/graphql form
2022-12-04 20:49:01 +05:30
Ankita Kinger
b7d00d2498
feat: Adding an upgrade page for Access control (#18554)
* updated content for access control upgrade page

* added feature flag and moved content to message constants

* adding feature flag for RBAC

* updated some styles

* added a missing comma

* removed width on trigger details container

* updated some styles
2022-12-04 20:12:35 +05:30
Arsalan Yaldram
b41606e2b7
fix: center align select widgets and RTE widget labels. (#18378)
* fix: center align select and RTE labels.

* feat: added label tooltips to select widgets.

* fix: added center label alignment to datepicker.
2022-12-03 17:28:02 +05:30
Ayangade Adeoluwa
cb82b299b1
fix: datasource switching issue for Google sheets (#18397)
* Fix datasource switching issue for Goole sheets

* Fix failing vercel deployments
2022-12-03 15:25:42 +05:30
Rishabh Rathod
c440343586
chore: perf data tree shrink (#18361)
trimming dataTree object size by removing configs to make evaluation faster.
2022-12-02 18:15:11 +05:30
Sangeeth Sivan
85db5cc965
fix: update permission driven ctas to handle auto save update changes (#18609) 2022-12-02 18:05:18 +05:30
Anand Srinivasan
c01ed28189
feat: New settings pane (#16361) 2022-12-02 11:19:51 +05:30
Apeksha Bhosale
42900c022f
fix: Reduces cloning by not adding platform functions (#18433)
reduces cloning
2022-12-02 11:13:39 +05:30
akash-codemonk
89bf555727
feat: [ Context Switching ] Maintain datasource edit mode (#17521) 2022-12-02 08:36:22 +05:30
Sangeeth Sivan
3e8414b4e0
fix: page list item icons aren't permission driven on first load (#18586)
* fix: page list ctas permission driven fix

* fix: page list and page context menu , datasource action pane create permission driven

* fix: check manage permission on page aswell for cloning

* fix: duplicate & fork app permission driven

* fix: onclick triggers on disabled icons
2022-12-02 02:56:21 +05:30
Tolulope Adetula
058500704e
fix: multiselect crashing (#18577) 2022-12-02 00:36:49 +05:30
Ankita Kinger
6ea8e2549f
feat: Handle permission driven views for auto-saving pages and action… (#16950)
Co-authored-by: Ankita Kinger <ankita@appsmith.com>
Co-authored-by: Sangeeth Sivan <74818788+berzerkeer@users.noreply.github.com>
Co-authored-by: Sangeeth Sivan <sangeeth@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-01 12:00:50 +05:30
balajisoundar
c0ce62f6b9
fix: miscellaneous issues in table widgets (#18127)
- Retain filter in table widget when table data changes but schema remain same
- Cursor jumps to start while editing a cell in Table Widget
- Save/Discard option should not be in the filter dropdown list.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-01 10:54:48 +05:30
Dhruvik Neharia
1a7b4c6725
feat: Dynamic Menu Items - Menu Button Widget (#17652)
* faet: Add menu items source for menu widget

* feat: Add configuration panel for dynamic menu items

* feat: Pass down items from sourceData to menu items widget

* feat: Take menu items config from property pane for dynamic menu items

* fix: Change all onMenuItemClick to onClick for dynamic menu items

* feat: Create MenuComputeValue property control to add support for {{currentItem}} binding in menu widget

* feat: Add JS toggles for style properties for menu widget

* feat: onClick now supports currentItem for menu button widget

* feat: Add currentItem autocomplete, move property pane config to separate files for menu button widget

* feat: WIP - Add Dynamic Menu Items for Table Widget

* Revert "feat: WIP - Add Dynamic Menu Items for Table Widget"

This reverts commit 271f96211c8612bc6f073a1aab7467993b9d7e36.

* fix: remove current item label by default for dynamic menu items in menu button

* feat: Add source data max length 10 validation for dynamic menu items in menu button

* feat: Add migrations for Dynamic Menu Items for Menu Button Widget

* feat: Add cypress test for dynamic menu items for menu button

* test: Update DSLMigration test with menu button widget tests

* fix: Update MenuButtonWidget migration

* fix: DSL migrations for menu button dynmaic items

* fix: Style validations for menu widget

* feat: Add more descriptive help text for configure menu items in menu button widget

* feat: Change menu items source property type from dropdown to icon tabs

* fix: Cy test for menu button widget to select menu items source from button tabs instead of dropdown

* feat: Make ConfigureMenuItemsControl a Generic/reusable OpenNextPanelWithButtonControl

* refactor: Change MenuComputeValue to MenuButtonDynamicItemsControl

* refactor: Merge TABLE_PROPERTY and MENU_PROPERTY into one ARRAY_AND_ANY_PROPERTY

* fix: Don't polute Menu Button DSL with properties for dynamic menu items until the source is static

* style: Change color of curly braces hint in currentItem autocomplete to make it more readable

* fix: remove unused import

* refactor: Move child config panels to a different file, style: Change help text and placeholder for a few properties for Dynamic menu items - menu button

* refactor: Change event autocomplete function name, use fast equal

* refactor: Change source data validation function name and use camelCase throughout

* refactor: Validation function for source data

* refactor: Create different type for menuItems and configureMenuItems and reuse them property config

* feat: refactor: move get items to widget instead of component

* pref: Visible items to be calculated when menu button is clicked

* refactor: replace !("menuItemsSource" in child) with in migration

* refactor: Change controlType name from OPEN_NEXT_PANEL_WITH_BUTTON to OPEN_CONFIG_PANEL, use generic names inside OpenNextPanelWithButtonControl.tsx

* refactor: Minor cleanup at MenuButtonDynamicItemsControl.tsx

* refactor: Minor cleanup at MenuButtonDynamicItemsControl.tsx

* fix: Change constant used in migration to a static value

* test: Add tests for validations and helper for menu button

* test: Add more Cypress tests for dynamic-menu-items

* fix: Minor refactor at onclick handler and MenuButtonDynamicItemsControl

* refactor: Rename ARRAY_AND_ANY_PROPERTY to ARRAY_TYPE_OR_TYPE

* feat: Move initial source data and keys generation inside an update hook

* refactor: Rename ARRAY_TYPE_OR_TYPE to ARRAY_OF_TYPE_OR_TYPE

* refactor: Minor code refactor in MenuButtonWidget/widget/index.tsx

* refactor: Change OpenNextPanelWithButtonControl with OpenConfigPanelControl

* feat: Use traverseDSLAndMigrate for dynamic menu items migration

* style: Minor code hygiene changes here and there for dynamic menu items

* style: Minor code hygiene changes here and there for dynamic menu items

* style: remove any type for visible items inside dynamic menu items

* refactor: Change type MenuItems to MenuItem

* feat: Add support for dynamic menu items (menu button) inside list widget

* fix: updateMenuItemsSource hook not working when changing from DYNAMIC to STATIC menu items source

* fix: Avoid empty icon name from rendering inside button and menu item

* style: Fix a couple of code callouts

* fix: Update import from TernServer to CodemirrorTernService

* style: fix minor code callouts here and there

* fix: Add check for configureMenuItems.config

* fix: Add wait time after addOption click for DynamicHeight_Auto_Height_spec.js

* fix: Increase the wait time for DynamicHeight_Auto_Height_spec.js to 200ms

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-12-01 10:25:57 +05:30
arunvjn
1f1840aeff
feat: Enable fetch API (#17832) 2022-12-01 03:28:58 +05:30
Ankita Kinger
3c546db6dd
chore: Adding additional optional props to editable text component (#18542)
adding additional optional props to editable text component
2022-11-30 18:11:34 +05:30
Ravi Kumar Prasad
ca2e8f8e23
fix: geolocation api callbacks are not called (#18235)
* fix: geolocation api callbacks are not called

The success and error callbacks are not being called. The code was absent.

fixes #11147

* Add comment

* Fix error callback not being called when location is turned off

* Fixes #9852 incorrect error handling on watchPosition

* Fix unit test

* fix unit tests
2022-11-30 16:08:15 +05:30