Commit Graph

210 Commits

Author SHA1 Message Date
NandanAnantharamu
27171765e2
Added delay after typing in Cypress test (#4168)
* added delay after typing

* updated method

* updated type in test

* updated common method

* Added wait between CreationOfUniqueAPIcheck()

Added delay between CreationOfUniqueAPIcheck() to prevent the stale exception.

* Updated API name

* Upated spec to handle retry

Co-authored-by: arslanhaiderbuttar <arslan@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-06-29 17:01:53 +05:30
arslanhaiderbuttar
950257f8f2
Chart UI test cases (#5370)
* Chart UI Test Cases

Added UI Test cases for Chart Widget.
- All Chart Types
- JS Scenarios
- onClick Scenarios
- Copy
- Delete

* Fixed Chart displaying issue.

Fixed Chart displaying issue.
2021-06-24 19:28:20 +05:00
NandanAnantharamu
3fb00b6c7a
Added Cypress tests for tab widget (#4345)
* Added tests for tab widget

* Added another test

* Commone method updated

* commented test
2021-06-22 23:26:45 +05:30
Hetu Nandu
441f42c72f
Generate linting errors via JSHint (#5034) 2021-06-21 16:39:51 +05:30
arslanhaiderbuttar
005c8077eb
Add commands in Command.js
Add commands in Command.js 
copyWidget, deleteWidget
2021-06-17 18:47:54 +05:00
arslanhaiderbuttar
1c1f7391d7 Merge branch 'release' into buttonUITestCases 2021-06-17 18:32:21 +05:00
Ashok Kumar M
a76b8cad9b
Feature: Widget Grouping Phase II (#4825)
* dip

* dip

* Cleaning up grid density positioning.

* dip

* dip

* dip

* dip

* code clean up

* dip

* dip(restructuring widget selection)

* Deselect parents and children of a widget when user multi selects.

* dip

* dip

* dip

* dip

* dip

* fixing a bad merge

* fixing tests

* adding jest tests.

* common util

* dip

* dip

* fixes

* restrict in deploy mode.

* fixing dynamic layout.

* fixing tests.

* on paste fix.

* fixing specs.

* addressing code review comments

* dip

* dip

* dip

* fixing specs.
2021-06-17 18:56:54 +05:30
arslanhaiderbuttar
988cc39b7c
Merge branch 'release' into buttonUITestCases 2021-06-16 17:27:46 +05:00
arslanhaiderbuttar
a45405917f JS Scenario 2021-06-15 17:24:25 +05:00
arslanhaiderbuttar
e355d342bf Button UI Test Cases.
Automated following UI test cases
for button regarding the property pane:
Button Style Validation
Button Copy and paste
Button Delete
Create api, and then call it upon clicking the button widget.
Create query, and then call it upon clicking the button widget.
All above using JS
2021-06-15 15:19:30 +05:00
NandanAnantharamu
861ab7ec81
Updated fork/duplicate test (#4923)
* Updated test to handle version

* updated test

* added a small wait

* Assertion updated

* formatted code

* fork test updated

* dsl file added

* Updated test

* Try waiting in the addDsl step

* Other fixes

Co-authored-by: hetunandu <hetu@appsmith.com>
2021-06-14 19:29:13 +05:30
Pranav Kanade
b04b7ddf02
[Fixed #4520] - Remove Entity Explorer Search (#4600)
* Added a prop to hide the entity explorer search

* Updated the cypress tests to accomodate invisible entity explorer search bar

* Removed cmd + f key mapping for entity search.
Although, keeping it for widget search

* blocking default `cmd+f` event only if widget search is present

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>

* removed a test case dependent on entity search.

* Revert "removed a test case dependent on entity search."

This reverts commit d5595d1856bbbb6ae472f26cb125b86787197b48.

* fixed test cases for table widget to force em to use table's search functionality

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
2021-06-09 17:50:15 +05:30
Pranav Kanade
8290dd5a25
Fix/update cypress command delete user from org (#4930)
* added the isOpen and onClose pros to context menu component

* added a warning shown before letting a user leave org

* added confirmation modal for removing members from table

* Added warning modal to be showing on member deletion

* updated cypress tests

* fixed typo

* removed log

* updated deleteUserFromOrg cypress command
2021-06-05 11:01:18 +05:30
Kaushik Varanasi
3a6da2d797
Feature/import applications (#4483)
* Added export option to app menu. TODO: call api to download app file

* Added checkbox component and removed unused code

* Added import app without filepicker. Opens modal

* added ability to fetch the exported app

* can download exported application as a json file

* Updated the file picker component to accept other file formats

* WIP import app

* Added functionality to import application json file

* minor fixes

* Made the file type prop mandatory for file picker

* added a test suite for export app

* Test added to check if on import application click, it open a modal

* added a dummy application file for cypress testing

* Added end to end integration test suite
to verify import app feature

* added test to verify the export api status and download file.

* added a linked btn to carry exporting.
- according to latest BE changes

* Removed old redux and saga mechanism for app export

* updated cypress test to validate new flow

* fixed minor linting errors

* updated test case title

* updated the test cases for import/export app feat

* review changes

* added prop to facilitate delayed upload

* added new application file to fixtures. Minor fix to take care of loading state.

* Removed export app modal. Added one click action, to download the file.

* Updated File picker to work with all other files acc to the design.

* Updated the import modal

* updated the import application test

* Added remove upload tooltip

* updated the icons for import/export actions

* removed unused logs

* added hard coded feature flag to hide/show import export feature

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-06-03 11:48:08 +05:30
NandanAnantharamu
03b2e7b042
updated locator (#4871) 2021-06-02 21:23:30 +05:30
Nayan
78915301e3
[Issue #4572]-Allow users to leave an organization (#4634)
* [Issue #4572]-Added API to leave organisation by any user

[Issue #4572]-Add option for organization admins to leave an organization

* -add option to leave organization in frontend for non-admin users

* -updated the leave org endpoint path and HTTP method as per PR review

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/UserOrganizationServiceImpl.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/UserOrganizationServiceImpl.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* -add cypress test and some minor changes as per PR comment

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-06-02 15:56:22 +06:00
Rishabh Saxena
8964aea9df
[Feature] Comments feature updates (#4579) 2021-05-20 17:33:08 +05:30
Ashok Kumar M
8c8141650a
Feature: Widget grouping Phase I (Multi select and Bulk Delete) + Canvas Enhancements. (#4219)
* Feature: Canvas layer enhancements(DIP)

* feedback fixes

* fixing build

* dip

* dip

* dip

* fixing build

* dip

* dev fixes

* dip

* Fixing top bottom resize handles

* dip

* reposition widget name on top edges.

* dip

* dip

* dip

* dip

* renaming selectedWidget to lastSelectedWidget

* code clean up

* Fixing list widget as per grid scale.

* Fixing existing specs.

* Adding migration test cases.

* dip

* FIxing proppane in modal.

* fixing modal z-indedx.

* fix for modal name.

* dip

* dip

* dip

* adding test cases for hotkeys.

* dip

* dip

* fixing build

* Trying some performance improvements for jests.

* 17 mins with runinband lets try without it.

* minor bug fixes.

* code clean up

* save migrated app on fetch.

* fixing few cypress tests

* fixing cypress tests

* fixing cypress tests.

* fixing cypress

* updated DSL

* Addressing code review comments.

* test fails

* dip

* eslint fixes.

* fixing debugger cypress tests.

* updating latest page version.

* updating migration changes to cypress dsl's.

* updating chart data fixes for cypress tests.

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-18 23:59:39 +05:30
akash-codemonk
9e082a6156
Feature: Show widget error state (#4558) 2021-05-18 19:24:40 +05:30
arunvjn
4733edfccd
Fixed query params parsing in API pane (#4482)
* Fixed query params parsing when there are mulitple "="s.

* Added cypress tests to validate query params parsing
2021-05-18 17:17:43 +05:30
NandanAnantharamu
fb8b6d1995
updated method to print response (#4473) 2021-05-13 21:27:19 +05:30
akash-codemonk
d6de913949
Revert "Feature: Show widget error state (#4202)" (#4406)
This reverts commit bf7a8b91a4.
2021-05-11 09:40:43 +05:30
NandanAnantharamu
408517de39
Datasource test with basic profile added (#4374) 2021-05-10 17:27:54 +05:30
akash-codemonk
bf7a8b91a4
Feature: Show widget error state (#4202) 2021-05-07 20:03:20 +05:30
Kaushik Varanasi
984119e9cb
Feature: auto create organisation Fixes #2720 (#3922)
* added basic function structure for creating organization

* added functionality for automatically creating an organization with 'Untitled organization 1' like applications. Need to add tests.

* added test for creating organizations with default names

* added tests for creating org with default name

* updated jest tests to not fill in the organization form

* remove unused imports

* deleted unnused files

* added more test to check invite users to application and check that the create application is visible

* updated share application tests according to the new workflow

* fix failing tests. TODO: fix tests with renameRandomOrg to rename specific org

* remove rename random org and rename specific orgs

* remove blocking code so the element can be scrolled into view

* fix tests

* try to fix flaky tests

* remove unused

* remove create organization tests as we are testing these components elsewhere

* fix failing tests by stubbing create org response

* update tests according to new workflow
2021-05-05 12:40:35 +05:30
Kaushik Varanasi
7af0faa32e
Feature: Fork apps across orgs : fixes #3089 (#4121)
* create basic button for forking

* added menu item for fork, opens a basic modal. TODO: Add functionality to fork

* clicking fork app enables organization select and forks across applications

* added close modal functionality. TODO: add tests, optimise code, remove duplicate and use exportswhere possible

* removed unused code

* Added cypress tests to check that fork app creates an app with same dsl. Tests Failing, needs fixing

* tests fixed, but needs unexpected login from cy

* Resolved bug with login by using correct cypress selectors

* Added tests to check that dsls match, added documentation and removed unused code

* remove unused fork function and directly dispatch from modal

* refactor code

* revert

* removed unused code and refactored tests

* feature/fork-apps-across-orgs-refactor

* make code prettier

* renamed components correctly

* refactored modal code into single file. TODO: fix warnings, test and remove unused code

* pass setModalClose to dialog component to maintain global modal state

* Added types for fork modal props

* update tests and remove unused code

* Removed isDeployedApp and instead passed trigger as a prop

* remove console logs and revert imports to small case

* rename files as components

* minor changes

* cleanup

* mock dispatch for jest

* move jest mocks to component tests
2021-05-04 11:34:23 +05:30
akash-codemonk
36532cbcc8
[Feature] Debugger logs (#3633) 2021-04-23 19:20:55 +05:30
Nidhi
6b31aa333b
Introducing Google Sheets Plugin (#3517)
* cherry pick -make new

* revert to enable fix from release

* attempt to hook into existing datasource editor

* gSheets plugin skeleton from Rest API

* Changes for database migration

* fix for auth code

* separate it out

* action page loads!

* add to explorer

* create action from datasource

* Editor JSON WIP

* working query form

* Editor JSON WIP

* import to

* fix toast message

* redirect from datasource and editor pages

* fix onboarding

* fix imports and constants

* refactor form out

* refactor queryForm

* Merge branch 'release' into feature/google-sheets

* Merge branch 'release' into feature/google-sheets

* initial values from settings, editor and form

* Check

* remove dangling code around lightTheme

* Safety net

* remove class

* try mouseover solve

* force click

* changes from review

* fix action form name on import

* Merge branch 'release' into feature/google-sheets

* minor cleanup

* Merge branch 'release' into feature/google-sheets

* WIP

* Google sheets changes

* Merge conflicts

* Merging and fixes, needs refactoring

* Check

* Merge branch 'release' into feature/google-sheets

* Fixed tests

* Add cloud services env variable

* Clean up saga

* Clean up

* Refactoring

* Deleted svg file

* Minor fixes

* Modified design to allow behaviour in google sheets methods (#3486)

* Modified design to allow behaviour in google sheets methods

* Review changes

* Removed sysout

* Added handling of edge cases with table data

* Merge branch 'release' into feature/google-sheets

* Fixes

* Fixes

* Added validations

* Improved tests

* Removed extraneous injected bean

* Review changes

* Fixed bug with method

* Changes to Google sheets plugin's request and response structures (#3692)

* Method changes

* Removed logging

* Renaming options

* Reverting pom version

* Modified type of collection variables, fixed errors

* Converted row offset field to one that supports dynamic bindings

* Review changes

* List SAAS plugin type actions under lightning menu apis (#3820)

* list saas plugin type actions under lightning menu apis

* combine saas plugin type actions in the other sub menu of lightning menu

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* Fix merge issues

* Prettified query editor and a few fixes w/ ux

* Test fixes

* Reformatting request

* code for REST added (#3876)


Co-authored-by: hetunandu <hetu@appsmith.com>

* Renamed body to row object

* Renamed placeholder for range

* Renamed range heading

* Modifications to handle range semantics

* Use spreadsheet Url instead of id

* Ordering of methods

* Removed logging

* Add tests for Dynamic text controls

* Add tests for url helpers

* Fix coverage config

* Nevermind

* Interface changes

* There is no body here

* Yay to hints

* Delete row field is separately handled as row index

* placeholder support (#4001)

* Fixed tests, typos and creating new sheets with random rows

* Switched to using 'rowIndex' throughout

* binding path added for query input field (#4016)

* - Fixed QA bugs (#4032)

- Split delete sheet into two
- Removed dynamic query input types from hidden keys

* Proper exceptions

* Removed extra logging

* Throw exception if update method does not match any of the columns

* Same for bulk update

* Zero-indexed delete row

* I'm a space bound rocket ship

* Logic to register installations with cs (#4062)

* Logic to register installations with cs

* Clean up

* Casting to string

* Checking to see if this makes the test pass

* Added an extra null check

Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-04-22 09:00:09 +05:30
NandanAnantharamu
302181bf48
WIP: Added new test for Text widget (#3953)
* Added new test for Text widget

* Added tests for text widget property panes

* updated tests
2021-04-20 14:29:52 +05:30
NandanAnantharamu
547a9a7ee0
Added tests for Oauth and Stubbed tests (#3463)
* Added tests for Oauth and Stubbed tests

* updated tests

* test updated

* updated DS tests

* review comments incorporated

* flag removed

* postinvite stubbed

* intercept req added and chromewebsecurity flag added

* Update app/client/cypress/support/commands.js

* updated header request

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-06 18:59:27 +05:30
NandanAnantharamu
8cd6c95e70
updated table property pane test (#3837)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-05 17:25:27 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties (#3167) 2021-04-01 14:00:33 +05:30
Rishabh Saxena
7ffc0d3786
Ignore cypress/no-unnecessary-waiting (#3794) 2021-03-31 14:05:19 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) (#3748)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 21:17:22 +05:30
hetunandu
b0580e9ee0 Revert "Feature: Property Pane improvements (#3561)"
This reverts commit 3437c16ef0.
2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements (#3561)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 15:28:52 +05:30
NandanAnantharamu
378330815b
Added test for tableWidget bug (#3528)
* Added test for tableWidget bug

* updated test

* review comment incorporated

* updated collapse pane test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-25 16:31:51 +05:30
NandanAnantharamu
a82c789c1a
udpated tests (#3617)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-19 11:19:54 +05:30
Kaushik Varanasi
55c17a66aa
Fix success message for single user invite and multiple user invite (#3591)
* Fixed error message for single user invite

* updated success message for single user invite and created tests

* use state to detect and update the number of users invited

* removing unnecessary lines

* typo
2021-03-18 19:20:33 +05:30
Rishabh Saxena
0e3901953b
Fix specs (#3577) 2021-03-17 15:06:08 +05:30
ram-primathon
3b0fb539d5
Property Pane re design (#3057)
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-15 17:47:56 +05:30
Dwayne Forde
2dfc8ebf8a
Adds support for base64 image strings to image cells (#2769) 2021-03-06 01:07:49 +05:30
Dwayne Forde
b074a035b5
Updates json input from typing to value setting (#2805) 2021-03-03 10:34:52 +05:30
NandanAnantharamu
21eecb1fe6
WIP : Added test for chart datapoint validation (#3176)
* Added test for chart datapoint validation

* updated test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-25 12:49:23 +05:30
akash-codemonk
791d92af94
Add validation to check if widget exists (#3140)
* Check if widget is present incase it got deleted etc.

* Update test
2021-02-24 11:30:22 +05:30
NandanAnantharamu
6c80f23201
Feature: DatePicker V2 (#2889)
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-23 18:05:09 +05:30
NandanAnantharamu
d20d013d69
Cypress test for Tab rename from entity explorer (#2780)
* Bug automation

* Test flow completed

* Another bug automation

* Updated tests

* uncommented delete tab test

* Uncommented a test

* updated tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-23 15:08:31 +05:30
akash-codemonk
92d1c381f1
Allow searching for page names in explorer and other improvements (#3038) 2021-02-22 19:31:46 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
devrk96
ac23629647
Feature: API Pane Redesign (#2218)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 18:24:00 +05:30