Commit Graph

5620 Commits

Author SHA1 Message Date
Abhijeet
168000be92
[skip_changelog] Feature/directory structure for version control (#6757)
* Insert git application metadata to application object, for git sync/version control feature there is a need to save the application in the structured format

* Added changelog to index application collection with git branch and remoteurl

* Rehydrate and dehydrate applications among different instances

* Added serailisation purpose while exporting the application to make distinction between version control and regular import-export flow 

* Git file operations moved to appsmith-git module

* Delete json reference from directory for deleted resource in DB

* Added git authentication in application metadata

* Replace String with Path to handle file path in git file structure
2021-09-06 18:18:18 +05:30
Rishabh Saxena
685aa3b98c
feat: make comments publicly available (#7143) 2021-09-06 18:04:40 +05:30
Bhavin K
74cba639ae
feat: on chart widget set adaptive y-axis based on data (#6310)
* enhancement on chart props

* updates as required

* changed data for chart widget

* fixed build issue

* improve code

* update text

* Update propertyConfig.ts

* changed helpText

Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
2021-09-06 17:45:58 +05:30
Shrikant Sharat Kandula
6a52931b64
Update lockfile with current dependencies (#7117)
The yarn.lock file is currently out-of-sync with the dependencies we are using. So, running yarn install --frozen-lockfile fails with the following error:

    yarn install v1.22.10
    [1/5] 🔍  Validating package.json...
    [2/5] 🔍  Resolving packages...
    error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.
    info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

This commit gets it back in shape.
2021-09-06 17:31:48 +05:30
Pawan Kumar
e3fe687a29
change data validation rule to array (#7091)
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-09-06 15:47:52 +05:30
Nayan
c4a7c1fb01
feat: add last edit information to application (#6948)
Adds the last edit time and editor username to the application when there is a change in the application.
2021-09-06 16:17:02 +06:00
Shrikant Sharat Kandula
7a0ec72304
fix: Treat missing server proxy endpoing as a warning (#7094)
Currently, in the editor Docker image, if the APPSMITH_SERVER_PROXY_PASS env variable is missing or set to empty, then the service will notify the user and refuses to start. This PR will change this behaviour to use a default value for this variable and attempt to start.
2021-09-06 15:30:45 +05:30
Bhavin K
9143ada0f3
fix: Validation property change in input widget (#6854)
Fixing challenge with the valid property as below:
1. Change the valid prop to an input control like regex
2. the valid field prop should be able to accept undefined apart from boolean
3. Change helper text to > ability to control input validity based on a JS expression.
2021-09-06 15:16:22 +05:30
Rishabh Saxena
a2b38c86eb
feat: init bottom bar skeleton, add feature flag for git (#7105) 2021-09-06 14:59:35 +05:30
albinAppsmith
3d85575979
style: Removed dark/light. theme switcher and made light theme default (#6979)
* Removed Theme switcher

* Changed default theme to light

* Auth screen dark theme changes

* auth screen ui ix

* Theme change Ui test removed

* bug fix
2021-09-06 14:37:52 +05:30
Pranav Kanade
b1a399b64a
fix: comment pins related issues (#7081)
* fix: the thread with the latest comment will be at the top.

* fixed the z index of unpublished pin

* making the layout control absolute

* removed comments

* reversed the ids order

* made sorting logic generic to work with list of ids

* minor refactor

* putting layout controller on top of canvas
2021-09-06 14:27:47 +05:30
Rishabh Saxena
cc0ff7fcc6
fix: account tabs for thread height in published mode (#7140) 2021-09-06 14:17:14 +05:30
Tolulope Adetula
db88ef86f4
fix: underline style for text (#6865)
* fix: underline style for text

* fix: add expected structure example

* Revert "fix: add expected structure example"

This reverts commit efd56886a26f87bb18cf6edc53bd246bfeb8e0f1.

* fix: test failing

* fix: widget crashing (#6980)

* fix: update omnibar search string for documentation for actions (#6722)

* [Mongo] Added default values for query for Find, Count and Distinct commands (#6960)

* Added smart defaults for query in Count, Distinct & Find commands

* Added test cases for smart inputs for query and limit for find, and query for count and distinct

* Distinct command output now results a JSON object instead of an array of strings (#6964)

* Fix: Break word when text widget content is long (#6211)

fixes #5319

* fix: widget crashing

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: balajisoundar <sbalaji1192@gmail.com>

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: balajisoundar <sbalaji1192@gmail.com>
2021-09-06 00:06:15 -07:00
Tolulope Adetula
742f0cf1ec
feat: compact mode in property pane (#6637)
* fix: compact mode

* fix: test

* fix: remove row height visibility

* fix: options label for compactMode

* feat: Add test

* Fix: failing test

* fix: test

* fix: test case.

* fix failing test

* fix: move position of rowHeight prop in property pane
2021-09-06 00:05:51 -07:00
Shrikant Sharat Kandula
0a08f9b807
fix: Rename user company to user's useCase (#7093)
We're not going to be collecting the company name for the self-hosted installation, but instead we'll be collecting the use-case that is being solved with Appsmith.
2021-09-06 12:28:47 +05:30
Shrikant Sharat Kandula
3adfaa5872
Include a default value for server proxy pass (#7042)
The env variable APPSMITH_SERVER_PROXY_PASS is missing a default value, and the start script in client image requires this. But since this env variable is not set on any _existing_ installations, they will break. So to fix that, we are adding an initial value to this variable to a sensible default.
2021-09-06 12:25:31 +05:30
rashmi rai
590b33a370
css fix primary and secondary box in FieldArrayControl (#7116)
Co-authored-by: rashmi rai <rashmirai@appsmith.com>
2021-09-06 11:23:46 +05:30
rashmi rai
c0748e5d5a
fixed missing toast (#7124)
Co-authored-by: rashmi rai <rashmirai@appsmith.com>
2021-09-06 11:23:21 +05:30
Pranav Kanade
228990e9a5
changing the order of connect widget and suggested widgets (#7129) 2021-09-06 10:56:28 +05:30
haojin111
0cec3f461f
fix: Making only the back link clickable instead of the whole row (#6287)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-09-05 21:55:34 +00:00
Snyk bot
b7e149958e
fix: app/client/package.json & app/client/yarn.lock to reduce vulnerabilities (#7044)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-IMMER-1540542
2021-09-06 02:47:11 +05:30
arunvjn
5fe83b6716
feat: Omnibar redesign and added snippets analytics (#7053) 2021-09-05 23:40:38 +05:30
Trisha Anand
7526129a3a
feat: Adding APPSMITH_PLUGIN_MAX_RESPONSE_SIZE which can be configured as an environment variable to increase plugin response size (currently only supported for Postgres Plugin) (#7126)
* Adding `APPSMITH_PLUGIN_MAX_RESPONSE_SIZE` which can be configured as an environment variable to increase plugin response size (currently only supported for Postgres Plugin)

* Updated error message + added the environment variable to the template docker env files for new installations
2021-09-05 15:38:36 +00:00
Anagh Hegde
a4434872b0
Classify the Plugin errors to Action and Datasource configuration issues (#7095) 2021-09-04 02:54:23 +05:30
Rishabh Rathod
93ce03c765
feat: git-connections-tab-ui (#7099)
update git connection UI
2021-09-03 23:27:22 +05:30
Rishabh Rathod
b020ad72a4
feat: Add horizontal tabs in gitSync Modal (#7048)
Add horizontal tabs in gitSync Modal
2021-09-03 11:56:09 +00:00
arunvjn
53b389d348
fix: Filter empty key value pairs from form data, headers and query params. (#7019) 2021-09-03 11:43:11 +00:00
Aswath K
fbb8af1c3b
fix: reorder IconButtonWidget properties (#7088) 2021-09-03 16:35:15 +05:30
Hetu Nandu
f95f550721
fix: Promise action backwards compatibility (#7052) 2021-09-03 16:32:28 +05:30
Bhavin K
3d967e2df3
feat: statbox widget (#6556)
Introducing a new widget: Statbox / Statistic box Widget; This is a composite widget which has text and icon in a certain layout that can be easily changed.
2021-09-03 15:45:04 +05:30
Nayan
b5529310d1
feat: Removed check on template organization ID when creating the default organization and application after signup (#7084) 2021-09-03 15:32:53 +06:00
Rishabh Saxena
3859cb8438
fix: listen to page id url param at the parent editor component (#7009) 2021-09-03 13:39:39 +05:30
Anagh Hegde
d4ee07ab58
Remove list widget from suggested widget on action execution (#7038) 2021-09-03 11:52:27 +05:30
Yash Vibhandik
cc606b2fe9
test: added jest test cases for null or undefined value in table data (#7010) 2021-09-03 10:24:32 +05:30
ashit-rath
2cb57156f9
fix: Firefox input widget text selection (#6832)
* fix - firefox input widget selection

* minor change

* dragDisabled - updateWidgetProperty -> updateWidgetMetaProperty
2021-09-03 10:19:07 +05:30
Rishabh Saxena
8b63b2029e
fix: bottom padding at the api editor (#7074) 2021-09-02 23:56:30 +05:30
Trisha Anand
cbf7dc2745
feat: New Mongo UQI Plugin with new datastructures (with old UI) (#6666) 2021-09-02 14:00:18 +00:00
Trisha Anand
5139be6be9
feat: Generating plugin framework using plop (#6956)
* WIP First commit

* Generating different files from different templates

* Adding file to edit for adding database changelogs

* Tested the modify file step as well.

* Completed the plugin generation for today's plugins

* Tested with all the files getting generated property

* Not tracking node_modules

* Removes node_modules

* Incorporated review comments
2021-09-02 19:22:17 +05:30
Bhavin K
b8c1f0d672
Fix for D&D on input on canvas: changed defaultText to empty string (#7018) 2021-09-02 18:31:09 +05:30
Tolulope Adetula
682526c5ee
fix: multiselect animation changed for consistency (#6618) 2021-09-02 18:28:08 +05:30
Trisha Anand
f6df16bde4
fix: Json smart substitution breaks when evaluated value contains the character '?' (#7031)
* Minor refactoring

* Partial code change to replace question mark with appsmith placeholder

* Working version

* Removing unnecessary code

* Added test case to assert that when evaluated value contains a "?", the replacements are still correct

* Added test case in Mongo Plugin as well for the same scenario

* Minor change in the language of the comment
2021-09-02 12:30:04 +00:00
Paul Li
d71253ee94
fix: Iframe onUrlChanged Prevented from being triggered on initial mount (#6961) 2021-09-02 17:43:01 +05:30
Yash Vibhandik
164a574935
fix: the colour picker select was not working in some cases, resolved the issue here (#7026) 2021-09-02 16:57:03 +05:30
ashit-rath
4a8f65d30d
add mod + s hotkey to suppress default page save and show toast message (#6917) 2021-09-02 14:07:27 +05:30
arunvjn
21f04166e3
fix: form data overflow (#7029) 2021-09-02 14:03:10 +05:30
Nayan
b98f646642
feat: Redirect after signup (#6962)
* WIP

* -redirect to newly created application after signup

* feat: create default application if no redirect url exists. also add a param to indicate first time user experience

* -updated function comment as per PR review

* -updated the create application using existing function

* -added check whether application is null when creating application page url

* -removed unnecessary refactoring

* -removed unused parameter from method
2021-09-02 12:25:39 +06:00
Arpit Mohan
c078976616
chore: Minor refactoring changes for RTS (#7011)
* Checking for anonymousUser when performing session check

* Using the custom path /rts instead of the default /socket.io. This makes the endpoint more readable & scalable for future websocket endpoints as well.
2021-09-02 08:47:42 +05:30
Snyk bot
4972e197ea
fix: [Snyk] Security upgrade nginx from 1.19-alpine to 1.20-alpine (#7040)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-ALPINE313-APKTOOLS-1533754
- https://snyk.io/vuln/SNYK-ALPINE313-OPENSSL-1569446
- https://snyk.io/vuln/SNYK-ALPINE313-OPENSSL-1569446
- https://snyk.io/vuln/SNYK-ALPINE313-OPENSSL-1569448
- https://snyk.io/vuln/SNYK-ALPINE313-OPENSSL-1569448
2021-09-02 02:26:40 +00:00
Rishabh Saxena
d990554290
fix: center align emoji for non-retina displays (#7023) 2021-09-01 20:28:23 +05:30
Favour Ohanekwu
69be9e7e18
closed hint menu when space/semicolon is entered (#7022) 2021-09-01 15:41:08 +01:00
Shrikant Sharat Kandula
250508bccc
Fix editor container fails to run with vanilla config (#6361) 2021-09-01 17:05:33 +05:30
arunvjn
558e333526 Revert "Adjust tab containers height"
This reverts commit 65e223fe84.
2021-09-01 16:42:12 +05:30
arunvjn
6e35b1a9bc Revert "Open dropdown on top when there is no space at the bottom"
This reverts commit b8a31691e0.
2021-09-01 16:41:53 +05:30
arunvjn
5b615215a2 Revert "set overflow to auto"
This reverts commit d6164a1dfc.
2021-09-01 16:40:59 +05:30
arunvjn
d6164a1dfc set overflow to auto 2021-09-01 16:27:48 +05:30
arunvjn
b8a31691e0 Open dropdown on top when there is no space at the bottom 2021-09-01 16:27:26 +05:30
arunvjn
65e223fe84 Adjust tab containers height 2021-09-01 16:26:53 +05:30
akash-codemonk
9de37f7fc5
fix: Fix missed out errorType field for debugger error analytics (#7017) 2021-09-01 15:45:45 +05:30
Tolulope Adetula
45fad5e094
Feat: Table Widget: icon button as a new column type (#6598)
* feat: add icon button properties to property pane
* feat: add icon button styles to property pane
2021-09-01 15:20:23 +05:30
arunvjn
277cb7fcca
fix: Ghseets scroll bug(#6634) 2021-09-01 14:41:51 +05:30
Rishabh Saxena
8c8afd8c32
fix: caret color light theme (#6973) 2021-09-01 14:24:41 +05:30
Rishabh Saxena
47df5dbb34
fix: minor spacing issue reaction bubble (#7015) 2021-09-01 14:24:32 +05:30
imgbot[bot]
b96b90e634
[ImgBot] Optimize images (#7014)
*Total -- 456.38kb -> 360.25kb (21.06%)

/contributions/images/intellij_config_2.png -- 51.42kb -> 27.41kb (46.7%)
/contributions/images/intellij_config_1.png -- 43.47kb -> 25.29kb (41.83%)
/deploy/fat_container/images/appsmith_supervisord_ui.png -- 169.18kb -> 117.24kb (30.71%)
/app/client/src/assets/icons/comments/commentCursor.svg -- 0.87kb -> 0.65kb (25.92%)
/app/client/src/assets/icons/menu/function.svg -- 0.21kb -> 0.18kb (11.9%)
/app/client/src/assets/icons/control/border-radius-sharp.svg -- 0.16kb -> 0.15kb (4.91%)
/app/client/src/assets/icons/control/border-radius-circle.svg -- 0.17kb -> 0.16kb (4.68%)
/app/client/src/assets/icons/control/box-shadow-variant4.svg -- 0.80kb -> 0.76kb (4.28%)
/app/client/src/assets/icons/control/box-shadow-variant5.svg -- 0.80kb -> 0.77kb (4.15%)
/app/client/src/assets/icons/control/border-radius-rounded.svg -- 0.17kb -> 0.16kb (4.14%)
/app/client/src/assets/icons/control/arrow_forward.svg -- 0.32kb -> 0.31kb (3.95%)
/app/client/src/assets/icons/control/box-shadow-variant3.svg -- 0.83kb -> 0.79kb (3.79%)
/app/client/src/assets/icons/control/box-shadow-variant2.svg -- 0.83kb -> 0.80kb (3.53%)
/app/client/src/assets/icons/control/box-shadow-variant1.svg -- 0.90kb -> 0.87kb (3.25%)
/app/client/src/assets/images/comments-onboarding/thumbnails/step-2.jpg -- 18.17kb -> 17.63kb (2.97%)
/app/client/src/assets/icons/control/divider_cap_right.svg -- 0.20kb -> 0.19kb (2.5%)
/app/client/src/assets/images/comments-onboarding/thumbnails/step-1.jpg -- 18.53kb -> 18.10kb (2.32%)
/app/client/src/assets/icons/widget/menu-button.svg -- 0.24kb -> 0.23kb (2.07%)
/app/client/src/assets/icons/widget/menu.svg -- 0.31kb -> 0.31kb (1.86%)
/app/client/src/assets/icons/control/add-circle.svg -- 0.28kb -> 0.27kb (1.75%)
/app/client/src/assets/icons/control/line_dashed.svg -- 0.22kb -> 0.22kb (1.75%)
/app/client/src/assets/icons/ads/chevron-down.svg -- 0.18kb -> 0.18kb (1.61%)
/app/client/src/assets/icons/control/divider_cap_left.svg -- 0.21kb -> 0.21kb (1.39%)
/app/client/src/assets/icons/ads/column.svg -- 0.21kb -> 0.21kb (1.37%)
/app/client/src/assets/images/long-arrow-right.svg -- 0.66kb -> 0.65kb (1.33%)
/app/client/src/assets/icons/widget/checkbox-group.svg -- 0.55kb -> 0.54kb (1.25%)
/app/client/src/assets/icons/ads/arrow-left-1.svg -- 0.24kb -> 0.24kb (1.23%)
/app/client/src/assets/icons/widget/icon-button.svg -- 0.32kb -> 0.32kb (1.22%)
/app/client/src/assets/icons/ads/check.svg -- 0.24kb -> 0.24kb (1.22%)
/app/client/src/assets/icons/ads/link_2.svg -- 0.65kb -> 0.65kb (1.19%)
/app/client/src/assets/icons/control/copy2.svg -- 0.25kb -> 0.25kb (1.16%)
/app/client/src/assets/icons/control/cap_solid.svg -- 0.35kb -> 0.35kb (1.11%)
/app/client/src/assets/icons/menu/filter.svg -- 0.28kb -> 0.28kb (1.05%)
/app/client/src/assets/icons/ads/trending-flat.svg -- 0.29kb -> 0.29kb (1.01%)
/app/client/src/assets/icons/control/align_left.svg -- 0.31kb -> 0.31kb (0.95%)
/app/client/src/assets/icons/ads/tables.svg -- 0.35kb -> 0.34kb (0.85%)
/app/client/src/assets/icons/control/align_right.svg -- 0.37kb -> 0.37kb (0.79%)
/app/client/src/assets/images/Plus-logo.svg -- 0.54kb -> 0.53kb (0.73%)
/app/client/src/assets/icons/control/close-circle.svg -- 0.42kb -> 0.42kb (0.7%)
/app/client/src/assets/icons/menu/new-plus.svg -- 0.59kb -> 0.59kb (0.5%)
/app/client/src/assets/images/long-arrow-bottom.svg -- 0.61kb -> 0.60kb (0.48%)
/app/client/src/assets/icons/control/group.svg -- 0.65kb -> 0.64kb (0.45%)
/app/client/src/assets/icons/help/close_blue.svg -- 0.66kb -> 0.66kb (0.45%)
/app/client/src/assets/icons/ads/warning-triangle.svg -- 1.11kb -> 1.10kb (0.44%)
/app/client/src/assets/icons/menu/close-filter.svg -- 0.67kb -> 0.67kb (0.44%)
/app/client/src/assets/icons/control/box-shadow-none.svg -- 0.72kb -> 0.71kb (0.41%)
/app/client/src/assets/icons/ads/expand-more.svg -- 0.73kb -> 0.72kb (0.4%)
/app/client/src/assets/icons/widget/rating.svg -- 0.51kb -> 0.51kb (0.38%)
/app/client/src/assets/icons/ads/book-open-line.svg -- 0.79kb -> 0.79kb (0.37%)
/static/how-it-works.svg -- 121.37kb -> 120.94kb (0.35%)
/app/client/src/assets/icons/menu/play-snippet.svg -- 0.83kb -> 0.83kb (0.35%)
/app/client/src/assets/icons/menu/binding.svg -- 1.13kb -> 1.12kb (0.35%)
/app/client/src/assets/icons/menu/copy-snippet.svg -- 0.91kb -> 0.91kb (0.32%)
/app/client/src/assets/icons/control/cut.svg -- 1.86kb -> 1.86kb (0.16%)
/app/client/src/assets/icons/menu/link.svg -- 2.79kb -> 2.78kb (0.14%)
/app/client/src/assets/icons/ads/git-merge.svg -- 2.43kb -> 2.43kb (0.12%)
/app/client/src/assets/images/Curl-logo.svg -- 3.56kb -> 3.56kb (0.11%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-09-01 07:20:48 +00:00
Arpit Mohan
94eba4b4b2
chore: Removing redundant toast message in action creation & deletion flow (#6998)
Also minor refactoring to simplify code flow making it easier to understand

Since we squash-merge all PRs, having the title conform to semantic PR guidelines is sufficient. We don't need to check the commits as well.
2021-09-01 03:40:44 +00:00
deepsource-autofix[bot]
ceeb1ad16b
chore: Remove the unreachable code block (#7000) 2021-09-01 08:42:24 +05:30
Pranav Kanade
7ba60bdaff
fix: link for resolved comment does not show a comment thread (#7001)
* minor fix to show empty app banner in the middle of the screen

* enforce the resolved comments filter, when user tries to open resolved comment directly through shared link

* minor fix: changed var name

* small fix to properly show the comment card action btns

* fix: if thread not present will show a warning
2021-08-31 19:56:43 +05:30
arunvjn
0104c8940c
fix: Fixes mouse click for slash commands (#7012) 2021-08-31 19:35:27 +05:30
Rishabh Rathod
f12dbd9dea
fix: label text casing (#6984)
Fix label text casing and add string literals to constants messages.ts file
2021-08-31 19:32:17 +05:30
Abhijeet
3414195b69
[skip_changelog] Update error message for sign-in source capitalization issue for OAuth (#7004) 2021-08-31 16:13:21 +05:30
Tolulope Adetula
5dd083665c
fix: update @blueprintjs/datetime package (#6719) 2021-08-31 15:11:37 +05:30
Abhinav Jha
13c740a931
fix: DSL versions during client migrations (#6995)
* Fix DSL versions during client migrations:

* fix: DSL migrations
2021-08-31 08:59:26 +00:00
Abhijeet
85323b2de3
[skip_changelog] Show table schema alongwith table name for the generated CRUD page (#6992) 2021-08-31 13:59:02 +05:30
Pranav Kanade
197d491047
can show comments on blank canvas in deployed version (#6988) 2021-08-31 13:27:22 +05:30
Arpit Mohan
a539316e78 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2021-08-31 12:42:14 +05:30
Arpit Mohan
2186802889 Minor changes to the Google Sheets form labels 2021-08-31 12:30:39 +05:30
Shrikant Sharat Kandula
a9e46f950b
fix: Error out when server endpoint ends with a slash (#6981) 2021-08-31 11:46:29 +05:30
NandanAnantharamu
49b3a78a0a
test: Custom chart spec (#6939)
* test : Custom chart spec

* updated title
2021-08-31 11:21:09 +05:30
Shrikant Sharat Kandula
0458b304e9
Upgrade socket.io-adapter to fix race condition (#6950)
Fix potential race condition error that's killing RTS, when multiple several users leave a room at the same time, which isn't uncommon for our use case.

This is done by upgrading socket.io-adapter dependency to version 2.3.2, which includes fix from PR socketio/socket.io-adapter#74.
2021-08-31 09:21:22 +05:30
Rishabh Rathod
4a688fd11d
feat: Add fillOptions prop to dropdown (#6908)
* feat: Add fillOptions prop to dropdown
- this will make width of dropdown popup same as width the selector

* Use dropdown width for option if fillOptions true

* Use dropdown width for option if fillOptions true

* hotfix: use optionWidth when fillOptions is false

* Add 260px as default width of DropdownOptions

* fix types

* hotfix typescript issue

* fix horizontal scrollbar visible

* hotfix type issue
2021-08-31 09:07:40 +05:30
Rishabh Saxena
4938371566
feat: env flag to disable intercom (#6937) 2021-08-30 22:11:55 +05:30
Rishabh Saxena
1add6c905c
fix: anonymize user info intercom (#6936) 2021-08-30 20:38:07 +05:30
balajisoundar
681f2a11f8
Fix: Break word when text widget content is long (#6211)
fixes #5319
2021-08-30 18:54:58 +05:30
Trisha Anand
104fd168de
Distinct command output now results a JSON object instead of an array of strings (#6964) 2021-08-30 12:37:13 +00:00
Trisha Anand
23ce13ce98
[Mongo] Added default values for query for Find, Count and Distinct commands (#6960)
* Added smart defaults for query in Count, Distinct & Find commands

* Added test cases for smart inputs for query and limit for find, and query for count and distinct
2021-08-30 11:02:48 +00:00
Rishabh Saxena
8dc0c81488
fix: update omnibar search string for documentation for actions (#6722) 2021-08-30 16:26:13 +05:30
Pranav Kanade
6de7e05ca6
will show dependency connections as soon as user makes the connection with a widget, regardless of if they've run the query/api or not (#6955) 2021-08-30 15:14:43 +05:30
Tolulope Adetula
deb84d0cb3
fix: table widget - cell wrapper property condition changed to remove effect from non related places (#6940) 2021-08-30 14:59:58 +05:30
Vicky Bansal
dbc3ca6bdf
feat: Table widget - Configure table data rows count (#5552)
Introduced a new field called as total record count which can be used to disable the pagination controls while having server side pagination. If this value is undefined the conditions will be ignored. The total record count is `total count / page size`, all the parameters need to be bound to the query/API for the functionality to work properly
2021-08-30 14:54:59 +05:30
Pranav Kanade
47344bbd73
added tooltips for all the btns in comment card (#6952) 2021-08-30 13:34:26 +05:30
haojin111
1021c18dd5
added cell background of empty rows (#6353)
* added cell background of empty rows
2021-08-30 13:18:10 +05:30
Bhavin K
b892712685
Table widget: default selected row, 0th (#5930) 2021-08-30 12:28:45 +05:30
akash-codemonk
d4dfda99b9
fix: Wrap JSON.stringify for text widget binding(suggested widgets) (#6651) 2021-08-30 11:04:34 +05:30
Sumit Kumar
96144d5103
remove outermost quotes (#6938)
* This method removes the outermost quotes - single or double quotes - so that end users don't have to do it via javascript inside widget fields where they are meant to be bound.
2021-08-30 08:11:32 +05:30
arunvjn
d119737de9
feat: Introducing JS Snippets (#6453)
Users should be able to look up relevant snippets based on where they trigger snippets from, narrow down the filter results based on entities, customize the snippet with custom data, evaluate and see its real time value.
2021-08-29 09:20:16 +05:30
Abhijeet
ea8116863e
revert: "Add version check from import-export flow (#6552)" (#6935) 2021-08-27 18:46:13 +05:30
yatinappsmith
b8d9e68106
test: Added stub tests for MySQL, MsSQL, ArangoDB and Redshift (#6868)
* Added stub testcases for MySQL, MsSQL, ArangoDB and Redshift

* Removed intercept for saveDatasource
2021-08-27 17:24:03 +05:30
Abhijeet
e57755e426
Revert "[skip_changelog] Update error message for import flow (#6779)" (#6927)
This reverts commit bc55021994.
2021-08-27 17:04:31 +05:30
Hetu Nandu
3380227cbb
feat: Enable Promises in Appsmith (#6253) 2021-08-27 14:55:28 +05:30
Pranav Kanade
a1ba69adfc
feat: draggable comment pins (#6742)
* made inline comment pins draggable and added wrapper around overlay comments wrapper

* moved drag hook to pin

* can drag on canvas

* Properly updating the thread to be able to properly move the pin

* always passing the ref to container

* updating BE to save the new pins position

* minor fix

* changed a file name

* minor improvement to fix unit test

* fix, updated dragging reducer function to not expect appId

* removing unrelated change

* added drag and drop for comment pins without react dnd

* updated unit tests

* minor fix

* added a grab pointer and minor offset when user moves the pin

* removed unnecessary store states

* moved drop from onDragEnd to onDrop to reset everything.

* using state selector and dispatch hook

* removed use of anchor widget

* removed pointer change from comments wrapper

* verifying if current pin is being dragged

* updated action creator name

* moved dragging in comments reducer.

* using dragging thread id from store itself

* using relative positioning of pointer to predict the location of pin

* unit test cases fixed

* minor fix

* removed the dependency of off set from callback
2021-08-27 14:27:18 +05:30
Anagh Hegde
078ad25613
feat: Create interface for git service and add all the required classes (#6903)
* Create interface for git service and add all the requireq classes

* Fix name of the service class

* Fix name of the service class as per review
2021-08-27 14:17:35 +05:30
Rishabh Rathod
1d63add091
feat: Add Option to export app in Navigation Menu (#6913)
Now the user will be able to export applications inside the editor also. Added Option in Navigation Header.
2021-08-27 12:49:21 +05:30
Rishabh Rathod
1109ecb37f
fix: fill dropdown option avoiding text shrink (#6910)
Fix text shirking of the dropdown selector
2021-08-27 11:53:25 +05:30
arslanhaiderbuttar
c90d844b63
test: Form widget UI test (#6884)
* Form widget test cases

* Form widget Test Cases

- Form widget fixes

* Form widget Test Cases

Defult Form text,  Reset and Close button Validation
Add Multiple widgets in Form
Form_Widget Minimize and maximize General Validation
Rename Form widget from Entity Explorer
Toggle JS - Form-Unckeck Visible field Validationpassed
Toggle JS - Form-Check Visible field Validationpassed
Copy Paste Validation
Form Delete Validation

* Form_test_cases_Fix

* Form test cases fix
2021-08-26 20:24:37 +05:00
Vicky Bansal
2f45db2008
Input widget: New data type supported - Phone number with ISD codes (#5256) 2021-08-26 16:22:45 +05:30
ashit-rath
1c5fb48b1d
Enhancement - chart widget x-axis label orientation (#6708)
* Chart widget - x-axis label orientation selector

* added test cases

* minor typing fix

* renamed CustomChartConstants -> ChartConstants, moved ChartComponents constants to ChartConstants
2021-08-26 15:28:43 +05:30
Ashok Kumar M
739f999bb5
fix: Fix canvas in bigger containers. (#6849) 2021-08-26 15:27:12 +05:30
Ayush Pahwa
2e20d9b480
feat: Update the conditional for section components for UQI (#6896) 2021-08-26 15:17:08 +05:30
Yash Siddharth Bhange
92c52083a3
fix: flashing cursor not shown on inputbox when sign-in details are picked from saved credentials (#6776) 2021-08-26 14:30:44 +05:30
Rishabh Saxena
2993829d37
fix: null check for current application while handling create new thread event (#6881) 2021-08-26 14:17:25 +05:30
Rishabh Rathod
0fa7f33bfe
fix: Show button when fetching columns (#6891)
Improve UX when entering `Table Header Index` value

BEFORE: Generate Template Button was hidden when the new column header is getting fetched. There was no loader for a user to understand that data is being fetched.

NOW: Generate Template Button is always visible and goes in a loading state when user data is being fetched.
2021-08-26 07:52:57 +00:00
Rishabh Rathod
dc86c9b82b
feat: Show Crud Info Modal data from backend (#6882)
CRUD Info modal which pops up on successful CRUD generation, will now have dynamic data for each CRUD template.

Modal success `message` and `Image` to explain the working of the CRUD template is fetched from the backend.

Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM>
2021-08-26 12:53:39 +05:30
Snyk bot
058055331a
chore: Deleting redundant Dockerfile for Cypress (#5683)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-08-26 07:10:53 +00:00
Pranav Kanade
f65ef8ddf3
feat: add multiplayer feature flag (#6888)
* updated feature flag to type

* added feature flag dependency for pointer sharing and editor listing features
2021-08-26 12:26:13 +05:30
Shrikant Sharat Kandula
aea43006db
ci: Fix large documents breaking upload to Algolia (#6815)
When uploading docs to Algolia, if the document's JSON representation is larger than 10KB (roughly), then Algolia API will reject it.
2021-08-26 11:34:39 +05:30
Ayush Pahwa
5d30cb3537
feat: Changing evaluations for UQI from hidden type to js objects (#6792)
* Added a new type of UIComponent for DB editor forms

* Added a new state for UQI evals and connected it to the rendering form

* Added sagas to init and run the UQI eval

* Exporting fetch function as a selector

* Moved selector code to the formSelector file

* Added type to state config holder, removed custom diff function and fixed imports

* Fixed path, added the type for plugin in selector

* Created new enum, abstracted function for render and fixed var names

Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-08-26 11:07:07 +05:30
Vinod
9f3a24fbb0
feat: show lint errors in code editor (#6265) 2021-08-26 10:15:17 +05:30
akash-codemonk
80b288cecf
fix: Do not mark property pane field as an error when the field is empty. 2021-08-26 09:38:39 +05:30
Shrikant Sharat Kandula
e0273ecc03
Add form data support for superuser signup API (#6844)
The superuser signup api available at /users/super currently only supports JSON payload. This PR adds support for form-data payload at the same endpoint, and makes it consistent with the normal user's signup API endpoint.
2021-08-26 06:35:32 +05:30
Anagh Hegde
58fad5f3fb
feat: Add maven module for the git operations (#6825)
* Add appsmith-git maven module for all the git related operations
2021-08-25 21:30:29 +05:30
ashit-rath
aca4457a32
Fix: RTE crash on defaultText change (#6789) 2021-08-25 19:41:15 +05:30
Yash Vibhandik
8099a50832
FIX: table widget updated page count on enter key press in pagination input (#6196) 2021-08-25 19:40:13 +05:30
Tolulope Adetula
d5f91c5495
Fix/select widget placeholder (#6677)
* fix: add placeholder to select widget
* fix: consistency between select / multi-select widgets
2021-08-25 19:37:01 +05:30
NandanAnantharamu
530735e13f
test: CypressNewVersion (#6116)
* Upgrade Cypress Version

* Upgrade to 7.6

* update moment library with Dayjs

* updated a test

* Added tests for copy to clipboard

* Added a missing dsl
2021-08-25 19:31:04 +05:30
Vicky Bansal
cb1604905e
Table sort column APIs (#6068)
User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event
2021-08-25 18:50:06 +05:30
Rishabh Rathod
0ff5ea543d
fix: Restrict e as valid number input (#6866)
Restrict e for table header index value and allow only whole numbers
2021-08-25 18:42:03 +05:30
Nayan
b1885358cb
feat: add feature flag for multiplayer feature (#6878) 2021-08-25 13:03:35 +00:00
Favour Ohanekwu
3d03dd3504
fix: improving multipart form data body (#6755)
* improved multipart form data body
2021-08-25 11:48:17 +01:00
Rishabh Saxena
ea0f5e888d
feat: add merge page ui (#6836) 2021-08-25 16:15:09 +05:30
Rishabh Saxena
be6fca279e
fix: tab component styles for the dark theme (#6833) 2021-08-25 16:13:45 +05:30
arslanhaiderbuttar
8380299958
fix: chart widget fix (#6867)
Custom fusion chart was loading with some delay and cypress test cases were getting previous element to verify the x axis data. Added one more check to wait till the chart data is loaded before verifying.
2021-08-25 15:42:41 +05:00
Favour Ohanekwu
aca5bd78b1
fix: inclusion of authorization error for Google sheets (#6674)
* Added authorisation status to Google sheet datasource form
2021-08-25 11:36:55 +01:00
Sumit Kumar
42273043da
- change action editor field label (#6845)
* The input box label in the Firestore plugin action editor reads Document / Collection Path which is misleading since a document is nested inside a collection and not the other way round. Hence changing it to Collection / Document Path
2021-08-25 16:04:51 +05:30
Pawan Kumar
596edce2e0
fix: List Item de-selection and empty state on deploy mode (#6871)
* revert deselection

* fix empty list state page mode

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-08-25 15:56:45 +05:30
Nayan
2f473fbd66
-improved logging in RTS (#6846) 2021-08-25 15:52:58 +06:00
Ashok Kumar M
f4210e4601
fix: load main container without waiting for evaluations to complete. (#6669)
* Fix: load main container without waiting for evaluations to complete.
2021-08-25 14:39:50 +05:30
Rishabh Rathod
08917a0592
fix: Generate Page using Empty Table error (#6834)
- Do not allow to generate CRUD app when selected table of datasource is empty (has no columns)
- Fix #6824: When the Dropdown is empty (has no options) do not show the dropdown option (popup) UI.
2021-08-25 10:55:33 +05:30
Pawan Kumar
960159eef3
Grouping widgets into container (#5704)
* Cut copy paste first cut

* removed different parent groups logic

* mouseup on the outer canvas removes selections.

* bug fix

* remove unwanted dead code.

* Adding tests

* build fix

* min height fixes

* fixing specs.

* fixing specs.

* fix merge conflcits

* fix border positioning

* fix canvas widgets incorrect bouding box

* fix bounding box position issue

* fix bounding box position issue

* fix

* border issue fix

* update test case

* add colors in theme

* use layers + use click capture on actions

* add icon for grouping

* fix overflow issue in contextmenu in containers

* fix context menu display issue

* update position of context menu

* fix container box-shadow issue

* fix container box-shadow issue

* revert container box shadow

* stop opening of property pane on shift clicking a widget

* remove console.log

* fix multiselect box issue

* add container on copy

* add analytics middleware

* refactor paste widget saga

* change flash element to accept array + revert refactor

* add logic to create containers from selected widgets

* update positions of grouped widgets

* fix comments + remove console

* update flashElementbyId to flashElementsById

* remove analytics middleware + remove unecessary imports

* add shorcut for grouping

* fix position issue when pasting

* allow grouping only when multi widgets are selected

* fix ux issues with widget grouping

* fix help text for grouping actions

* filter out the modal widget when calculting next row

* fix delete issue when grouping

* persist positin when grouping if there is no collision

* fix typo for new position

* changes for review comments

* changes for review comments

* fix position issue when pasting

* fix new container position issue

* move utils function to utils

* fix import issue

* fix the composite widget grouping issue

* fix table name bug

* remove repeated code

* move copied groups existence check;

* fix copied group check

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-08-25 10:30:31 +05:30
akash-codemonk
daed3716c6
fix: Fix omnibar redirecting to invalid url when there are no results (#6696) 2021-08-25 10:28:58 +05:30
akash-codemonk
95c60bafeb
fix: Hide debugger errors until onPageLoadActions are run (#6786) 2021-08-25 10:04:42 +05:30
arunvjn
0b1e42691b
fix: Api pane url input height and datasource mouse click. (#6818) 2021-08-24 20:44:32 +05:30
Paul Li
cb4242e7e5
Feat: Style customisation in the button widget (#6052)
Added multiple style props to the button widget:
- Button styles
- The background colour can change with a hex code
- elevation (box-shadow & colour)
- There are button variant contained (solid button), outlined (only borders), text (text buttons)
- Button can have an end icon or start icon
2021-08-24 19:23:15 +05:30
Sumit Kumar
163192d851
Feature flags snippet and linting features. (#6828)
* Introduce feature flags for snippets feature and linting feature.
2021-08-24 18:50:50 +05:30
Ashok Kumar M
de73e847ae
[Enhancement] Adding Webpack bundle analyser for CRA, removing source map explorer for better visualisation. (#6793)
* Enhancement: Adding better build visualiser(Webpack build analyser)
2021-08-24 17:44:23 +05:30
Ashok Kumar M
698b9d5b82
Fix: show property pane only when respective widget is present on the dom. (#6670) 2021-08-24 17:43:49 +05:30
Hetu Nandu
f012fd9d69
fix: Revert redux update perf improvements (#6808) 2021-08-24 17:40:25 +05:30
Ashok Kumar M
83147afdc5
feat: Widget grouping Extended Features (#6538)
- [x] Draw to select from outside of the editor.
- [x] Cmd + A to select child widgets inside containers, forms, list, tabs, and modals.

Fixes #5995
Fixes #6102
2021-08-24 17:08:20 +05:30
Yash Vibhandik
05d733cfe8
FIX #6193 : bind enter and tab key on color picker input to close color board (#6305)
This is done to improve the keyboard navigation on the property pane
2021-08-24 16:55:45 +05:30
arunvjn
1082cb9ca3
fix: Sentry type error in DB form (#6817) 2021-08-24 16:30:55 +05:30
yatinappsmith
aa869f21ab
test: Added Support for MySQL (#6795)
* Added Support for MySQL

* Update setup-test.sh

fixed sql file

* Update setup-test.sh

Fixed path
2021-08-24 14:16:52 +05:30
Paul Li
b170a014c6
menu style customization (#6237)
- Menu widget needs to show transparent background
- Make background none if user choose no background colour
- Adopt button style options(menu style, variant, box shadow, border radius)
2021-08-24 11:07:16 +05:30
Satish Gandham
da1af9cac7
Filepicker v2 - Don't store large files in the dataStore (#6692)
* - Create a clone of the existing filepicker widget

* - If a file is larges than 5MB, don't put it in the dataTree.

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-08-24 09:08:57 +05:30
Ashok Kumar M
971cc35e7f
[Feature] Click on widget will no longer open property pane (#6219)
* [Feature] Click on widget will no longer open property pane

* fixing test cases

* coverage fixes

* fixing imports.

* fixing build failure.

* fixing new specs

* clear property pane state for any new selection.
2021-08-23 19:42:17 +05:30
akash-codemonk
bb1c5ab9a3
Send errorType as part of analytics payload for action execution errors (#6754) 2021-08-23 19:17:17 +05:30
Trisha Anand
81fb86261d
Adding support for JSON object fields in Postgres for Prepared Statement (#6761) 2021-08-23 19:03:20 +05:30
Rishabh Saxena
7b23de64d9
Analytics events for the comments onboarding (#6763) 2021-08-23 14:55:16 +05:30
Pranav Kanade
6782bf6b85
fixes in import/export feature cypress tests. Will also show a prompt to be able to choose the download location (#6767) 2021-08-23 14:46:25 +05:30
Rishabh Saxena
aee2d19b8e
Commit page ui (#6772) 2021-08-23 14:15:54 +05:30
NandanAnantharamu
0e5816d413
Fix/chart spec (#6774)
* updated Chart spec with a wait for route

* updated Chart spec with a wait for route
2021-08-23 14:02:53 +05:30
Abhijeet
bc55021994
[skip_changelog] Update error message for import flow (#6779)
* Modified the error message for import version check, to make it more humane and actionable

* Update TC
2021-08-23 13:54:43 +05:30
Ayush Pahwa
b1d003fdba
Added new type to the ActionConfig, fixed some typos (#6748) 2021-08-23 13:04:44 +05:30
Yash Vibhandik
a5fe7c391e
fixed the filter issue in table widget (#6739)
The filters did not get reset where the data in the table widget changes in the edit mode. This is now fixed
2021-08-23 12:59:14 +05:30
akash-codemonk
25c6bd8c0f
Fix two skip tour options shown in onboarding (#6729) 2021-08-23 12:40:26 +05:30
akash-codemonk
a42938c139
Expand all debugger errors by default (#6676) 2021-08-23 11:57:23 +05:30
Pranav Kanade
7b587a8d43
Fix: Style for documentation link in query pane (#6716)
* updated styling for documentation link in query pane

* added message constants
2021-08-23 11:47:28 +05:30
Nayan
843666f1fc
[Feature] - Add lastDeployedAt date to application object (#6753)
* -add lastDeployedAt date to application object

* -skip setting published date when application is forked
2021-08-23 11:33:13 +06:00
Nayan
a5ec0add23
-allow login with case insensitive emails (#6712) 2021-08-22 18:48:53 +06:00
arslanhaiderbuttar
01e5d8d839
Table UI test cases (#5910)
* TableUITestCases

Commit

* Table-widget-testcases

On Search Text Change Action
Default array data
On Row Selected Action
Explore Widget related documents Verification
On Page Change Action
Default search text
Default selected row
Delete Table Widget
Changing Column data type to "Image"
Changing Column data type to "URL"
Table Widget Functionality To Verify Row Height Functionality
Drage and Drop Table widget and verify default data
Table Widget Functionality To Filter The Data using 'Empty
Table Widget Functionality To Filter The Data using 'Not Empty'

* Discarded changes in cypress.json

Discarded changes in cypress.json

* Updated the test cases

* Undo changes to Cypress.json

Undo changes to Cypress.json

* Added new dsl json file

* Merge branch 'release' into SelectUITestCases

* table test cases fix

Co-authored-by: arslan <>
2021-08-21 12:34:23 +05:00
Rishabh Rathod
652950d239
Add Gsheets support for generate CRUD page (#6301)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Fix issues related to dropdown

* Add hooks to fetch sheets and spreadsheets

* Resolve warnings

* complete gheets basic support

* Add UI changes for Gsheet column names
- Fix Page Scroll issue

* Add debounce to avoid to many API calls

* Add request object formation via plugin config

* Resolve comments & remove executingDatasourceQuery

* Send sheetName in the tableName key.

* Add loader and Column name UI Fix

* Add Column Headers Label

* Fix logic to show comma separator btn column names
- Make "Column Header Fetched" text Bold

* Add tooltip info for searchable column

* Add value prop to TextInput
- Fix Table header Index Invalid Input issue

* Hotfix validator logic
2021-08-20 15:25:59 +05:30
Abhijeet
163c7cde71
Update template application file to fix failing cypruss TC (#6758) 2021-08-20 14:51:17 +05:30
Rishabh Saxena
add2127dad
Remove onboarding typeform (#6752) 2021-08-20 13:00:36 +05:30
Rishabh Rathod
12e7ee0c94
Add s3 support for generate CRUD (#6264)
* Add s3 support for generate CRUD
- Dropdown enhancement to open options on initial load
- Hide column selection option for s3

* Refactor the prop name

* Add useS3BucketList hook WIP

* Dropdown enchancement & Fix small issues

* Add fetch all sheets query

* Add Query to get all S3 buckets

* Fix dropdown open issue

* Remove defaultIsOpen prop from dropdown

* Resolve comments
- Remove debugger
- mockSheetUrl -> getSheetUrl

* Add S3 cypress test

* Fix cypress test yml config

* Fix generate page cypress test
2021-08-20 12:27:01 +05:30
Shrikant Sharat Kandula
094b77832f
Accept richer inputs from welcome signup form (#6650)
* Accept richer inputs from welcome signup form

* Send subscribe event when user has approved it
2021-08-20 10:10:04 +05:30
Hetu Nandu
17edf11d00
Add eslint rule to disallow console.log (#6717) 2021-08-20 09:43:16 +05:30
Sumit Kumar
6061206970
Feature: s3 plugin: add option to get un-signed url (#6697)
* add option to fetch un-signed url when doing list action.
* this url never expires and is generally useful when sharing access to public objects.
2021-08-20 05:48:48 +05:30
Rishabh Saxena
d89bf5c487
Default deploy section state (#6740) 2021-08-19 21:04:43 +05:30
Anagh Hegde
e08c5b83e4
Add errorType to Categorise Debugger Errors (#6413)
* Add errorType to response

* Fix Test Failures

* group the errors

* Add errorType to categorise the issue/error

* remove the helper class

* update changes as per review

* Update the logical groupings of errors

* Fix formatting issues

* Updated the error types

* Update error classification
2021-08-19 19:59:25 +05:30
Yash Vibhandik
2ba63fb5b1
Removed isCellVisible flag (#6731)
We have reverted a code which is coming in from #4819, which caused a bug in the table filter input element to hide, We will log this issue to be fixed in the release env separately, We will cherry pick this commit to RC to resolve the current build error
2021-08-19 19:49:02 +05:30
hetunandu
9941c253f7 Revert "Hotfix for logging and debugging redux updates (#6728)"
This reverts commit 4b5ca10e0d.
2021-08-19 18:31:37 +05:30
Anagh Hegde
e76d8c2c15
Change the name of the mock datasource (#6498)
* Change the name of the mock datasource

* Remove the hardcoded value for Cloud services

* Handle index out of exception

* Add check if the response contains necessary credentials for mockdb

* Change as per review comments

* Fix cypress test failures

* minor changes to fix cypress test for mock data according to new changes

* updated mock data locator

* Update the mockdata source name

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-08-19 17:53:30 +05:30
Nidhi
8be0580c77
Fixed template queries for PG, MySQL and Snowflake (#6698)
* Fixed template queries

* Fixed tests
2021-08-19 16:35:32 +05:30
Hetu Nandu
4b5ca10e0d
Hotfix for logging and debugging redux updates (#6728) 2021-08-19 16:35:16 +05:30
Hetu Nandu
77ea24ba85
Fix debugger trying to render objects (#6720) 2021-08-19 14:23:03 +05:30
Rishabh Rathod
ab3fdd4ece
Add User Profile Section (#6705)
- Replace AuthTypeSelector with OptionSelector for general use.
- Fix Scroll issue in GitSyncModal
2021-08-19 12:09:19 +05:30
Abhijeet
9677a4fb8f
[Skip_changelog] Enable S3 and GSheet from backend for generate CRUD page (#6706)
* Update appsmithVersion for static json file used in import application cypruss test
2021-08-19 12:04:14 +05:30
Pranav Kanade
ca0b08e482
Fix: background rect width of usernames, of other realtime users (pointer sharing) (#6703)
* updated collab event names

* added a canvas to record the mouse movement

* can show pointers

* temp

* can draw multiple pointers using canvas, moved multiplayer canvas to artboard level

* using constants to draw the cursors on canvas

* can show pointers with different colors

* showing proper username

* added constants for collab events and namespace

* updated the page socket var name

* defined a id constant, and resizing the canvas if needed on window resizing, and then clearing it

* minor refactor

* hide pointer of users leaving the page

* moved our the share pointer func

* defined separate types

* added minor comment

* using requestAnimationFrame to improve performance.

* added connection checks before emitting events. Added mechanism to try to reconnect manually

* using ref to keep animation step id

* updated the way using requestAnimationFrame

* passing pageId as prop to canvas and pointer canvas

* emitting events only if there are more than one realtime editors

* added pageId dependency

* removed unnecessary prop and using reactive state

* remove explicit connection event

* maintaining connection state of page level socket

* fixed the multipointer text background width
2021-08-19 11:13:53 +05:30
Nidhi
0cc738122a
Enable JS editor by email (#6701) 2021-08-19 09:43:32 +05:30
Rishabh Saxena
6c7a045916
Git connection page ui components (#6667) 2021-08-18 17:18:24 +05:30
Abhijeet
7b98079ee8
Updated Template (#6688)
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-08-18 16:59:45 +05:30
Nidhi
f5895872d4
Allow extra fields in multipart file data (#6689)
* Allow extra fields in multipart file data

* Remove extra annotation

* Reuse object mapper

* Reuse object mapper
2021-08-18 16:55:33 +05:30
Rishabh Saxena
eda5b05faa
Fix redirection to auth page when trying an app without having access (#6682) 2021-08-18 16:31:50 +05:30
Yash Vibhandik
158a71acab
FIX #3123 : added custom csvSeparator property in table widget for csv download (#6291) 2021-08-18 16:03:26 +05:30
Yash Vibhandik
05bcad89ff
FIX #6615 : added check for open filter pane and close if before property pane open (#6662)
Hotfix for the RC blocker
2021-08-18 16:01:38 +05:30
Pranav Kanade
7a75d400ab
Feature: Sharing pointers of concurrent editors (#6540)
* updated collab event names

* added a canvas to record the mouse movement

* can show pointers

* temp

* can draw multiple pointers using canvas, moved multiplayer canvas to artboard level

* using constants to draw the cursors on canvas

* can show pointers with different colors

* showing proper username

* added constants for collab events and namespace

* updated the page socket var name

* defined a id constant, and resizing the canvas if needed on window resizing, and then clearing it

* minor refactor

* hide pointer of users leaving the page

* moved our the share pointer func

* defined separate types

* added minor comment

* using requestAnimationFrame to improve performance.

* added connection checks before emitting events. Added mechanism to try to reconnect manually

* using ref to keep animation step id

* updated the way using requestAnimationFrame

* passing pageId as prop to canvas and pointer canvas

* emitting events only if there are more than one realtime editors

* added pageId dependency

* removed unnecessary prop and using reactive state

* remove explicit connection event

* maintaining connection state of page level socket
2021-08-18 15:59:52 +05:30
Rishabh Saxena
74bff938b5
Init git sync modal (#6641) 2021-08-18 15:10:31 +05:30
Rishabh Saxena
a1daa7e3f8
Handle deletion for comments and threads in realtime (#6605) 2021-08-18 12:51:21 +05:30
Yash Vibhandik
ffb348bc82
FIX #6463 : updated condition to handle undefined values in tableUtility (#6588) 2021-08-18 12:44:56 +05:30
Bhavin K
3741bc160e
Added series title (internal property) to the chart widget selectedDataPoint (#6104) 2021-08-18 12:41:07 +05:30
Rishabh Saxena
1a654379bf
Minor git sync related ui components (#6640) 2021-08-18 11:35:42 +05:30
Nayan
cf2ebe585c
[Feature] - Add api for concurrent page editors (#6542)
* -added socket io namespace and events to broadcast start and edit page

* -broadcast mouse pointers from rts
-add a mouse pointer simulator to show the events in action

* -removed sample file
2021-08-18 05:37:01 +00:00
Nidhi
a65bcb74b3
Fixed ds form not functional because of eval supported fields (#6665) 2021-08-18 08:16:56 +05:30
Sumit Kumar
9faa22ad58
Fix: Dynamodb Plugin: remove data type info keys from raw values. (#6652)
* A fix had been introduced earlier (I had introduced it a few months back) to remove data type info keys from the raw response. However, the transformation was not getting applied to the Query action as the transformation was explicitly limited to few actions. This PR removes that check and allows the transformation for all actions as there does not seem to be any reason to withhold this transformation for other actions.
* The earlier fix also restricted this transformation to results that had specific keys. This PR removes this check as well as it does not seem to be required and further may lead to similar issues if any particular key gets missed.
* Some other redundant checks have been removed from the flow as the transformation function itself takes care of it as edge/base case.
2021-08-17 19:18:25 +05:30
ashit-rath
2bd2565580
FIX #6127 - Entity explorer - cloned page widget highlight (#6441)
* Fix 6123 - Entity explorer - cloned page widget highlight

* on page clone, clear widget selection
2021-08-17 13:23:11 +00:00
Tolulope Adetula
b6f9aef70a
feat: Add isDisabled to Button column and isVisible to all Table widget Column settings (#4819) 2021-08-17 18:24:43 +05:30
Nayan
919a420aa7
[Improvement]- Improve the password reset feature (#6545)
* -limit the rate for sending password reset requests

* -used encrypted token in password reset

* -add unit tests for the password reset issue

* -improved formatting

* -updated PR as per review comments

* -hanled IllegalStateException instead of Exception when parsing the encrypted token
2021-08-17 12:35:00 +00:00
Favour Ohanekwu
a80c92694b
fix button color style bug (#6660) 2021-08-17 13:24:49 +01:00
ashit-rath
f904e4bffe
Fix: Widget: 'value' of null errors (#6535)
* validations: array - fixed default value, array object - fixed object index error message computation

* improved validation config

* minor test case additions
2021-08-17 11:35:51 +00:00
Bhavin K
1876403c4f
Added tooltip message on hover in the button widget (#6105) 2021-08-17 16:56:05 +05:30
Bhavin K
3270d6c7ba
Input widget enhancements (#5670)
Many new input widget enhancement added. The widget now has the capability to have its own label and tooltip as helper. The user can now add Icons inside the input widget and align them as well, The user can allow choose the max allowed length of the input. We have also added the isValid property in tandem to the regex property for additional validations using JS expressions
2021-08-17 16:38:04 +05:30
rahulramesha
478a2a3147
adding check for base64 (#6532) 2021-08-17 16:24:46 +05:30
Nidhi
92f4d878ab
Adding form data for uqi consumption (#6655) 2021-08-17 15:34:45 +05:30
arunvjn
00045ddfc3
Fix/debugger width bug (#6623)
* Overflow wrap for long text in debugger and set width of api pane to 100%
2021-08-17 15:25:00 +05:30
Paul Li
532e8f2a74
Feature : Checkbox Group widget (#6199)
Introducing a new widget: `Checkbox Group`, Users can now create a group of checkboxes and have an action trigger and also be able to refer the selected values from the internal API.
2021-08-17 14:41:38 +05:30
Sumit Kumar
fc30554cb5
Fix: Redis plugin: extract cmd and args based on regex (#6648)
* Earlier split method was used to segregate cmd and args which failed when multiple words inside a quoted string formed one argument. e.g. set key "my value" would produce set, key, "my, value" as the tokens when split method is used, which is not correct. This change introduces a regex that would create the following tokens: set, key, "my value"
2021-08-17 13:41:41 +05:30
Rishabh Saxena
378ecde4c8
Refactor tabs to accept tab item component and create a new variant (#6597) 2021-08-17 13:22:05 +05:30
akash-codemonk
27081e58aa
Fix: Validation error messages shown in debugger (#6572) 2021-08-17 13:02:07 +05:30
Rishabh Rathod
63ef562edb
Add Generate CRUD page Info Modal (#6557)
* Add Info Modal (WIP)
- Added modal skeleton without content

* Add generate CRUD Info Modal

* Add dialog heading to messages constants
2021-08-16 23:34:54 +05:30
Nidhi
f8e6854434
Correction in auth type value for OAuth2 in view mode of datasource (#6639)
* Correction in auth type value for OAuth2
2021-08-16 22:06:02 +05:30
Abhijeet
c3f7bea904
Add version check for import-export flow (#6552)
* Added version check

* Added error message for version check while importing the file

* Added TC to check version in exported file

* Added version in FE assets for cypruss test
2021-08-16 21:32:51 +05:30
Vicky Bansal
82722e5a38
Fix table date type column sorting (#6134) 2021-08-16 19:07:30 +05:30
Hetu Nandu
25a6590b47
Catch Data Tree update error and better sentry logging (#6627) 2021-08-16 18:12:15 +05:30
Nayan
22e477da8f
- add page name in comment notification emails (#6608) 2021-08-16 18:40:31 +06:00
Favour Ohanekwu
f0c7ce0e89
Feature/option to upload file or text in multipart form (#6534)
* added option to multipart form data for file or text upload

* updated styles for the dynamic-text-field-with-dropdown styled component

* added cypress tests for multipart body type

* code refactor: moved constants to ApiEditorConstants.ts

* updated multipart dropdown styles

* minor bug fix
2021-08-16 13:00:11 +01:00
Favour Ohanekwu
30c11e4a74
fix cypress mockdatasource flaky test (#6624) 2021-08-16 12:24:17 +01:00
Nidhi
a0462a5697
Added user email to logging context (#6619) 2021-08-16 16:36:03 +05:30
akash-codemonk
8e08e778d4
Update debugger error message CTA's (#6416) 2021-08-16 16:33:27 +05:30
Nidhi
f05e32a97e
Throw a stale connection exception when authentication token expires in Snowflake (#6612)
* Throw a stale connection on authentication token expired

* Added JUnit test
2021-08-16 10:33:39 +00:00
Ashok Kumar M
b2ade8e17e
Fix: disable widget selections when widget dragging is in progress. (#6573)
* Fix: disable widget selections when widget dragging is in progress.

* new widget select

* fixing jest tests.
2021-08-16 14:54:42 +05:30
Tolulope Adetula
f4e0e8adb0
Feat/server side filtering multiselect (#5737)
The multi-select and select now has the capability to handle server side filtering, i.e. an Appsmith dev can now choose to call an api on search or options using the onFilterUpdate action
2021-08-16 12:26:09 +05:30
Shrikant Sharat Kandula
e20d616c33
Env Manager API and super user signup API (#6473)
* Add API for env management and super user

* Add missing files

* Add API for signing up for super user

* Fix types in client code

* Add docs for env manager API

* Minor refactoring

* Remove unused updates to app startup

* Better error logging when unable to write file

Co-authored-by: Nidhi <nidhi@appsmith.com>

* Don't cache the user count (duh!)

Co-authored-by: Nidhi <nidhi@appsmith.com>
2021-08-14 07:01:54 +05:30
Shrikant Sharat Kandula
0f41886ce7
Fix NPE when Referer header is missing (#6601) 2021-08-13 22:49:09 +05:30
Nidhi
dc8673c22c
Changes to props (#6574) 2021-08-13 19:32:00 +05:30
Rishabh Saxena
0a6f0d9c1e
Close button for the comments onboarding (#6570) 2021-08-13 17:53:59 +05:30
Pawan Kumar
946ca3afb9
[Feature] Page Properties (#4989)
* disable delete icon for default

* page properties style updates

* minor style updates

* remove uneccessary imports

* update draggable list api

* style updates

* remove unused variable

* style updates

* update edit icon

* integrate sorting page api

* fix colors

* remove console.log

* add link to switch page in page list item

* remove unused import

* revert draggable list code

* remove console.log

* fix draggablelist component reorder issue

* remove draggablepagelist

* fix rerender of draggablelist

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-08-13 17:08:26 +05:30
Nidhi
f2cba9a601
Escaped inputs for bson substitution (#6565) 2021-08-13 14:44:51 +05:30
Favour Ohanekwu
11385092ca
Hotfix/trailing white spaces in mysql datasource configuration (#6227)
* trimmed white spaces in datasource configuration

* Added cypress tests for MySQLdatasource

* fixed trailing whitespaces bug in mysql datasource configuration

* Fix overflowing text in toasts on safari (#6200)

* [Feature] Generate template page from datasource  (#5513)

- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Fix xss redirectURL (#6229)

* Update msg

* Revert "Update msg"

This reverts commit 0ac70ea7e9.

* Fix JS error message showing callstack in firefox (#6234)

* Adding expiry of 30 days to session cookies (#6224)

Fixes #5872

Adding an expiry of 30 days to the cookie to ensure that browsers don't delete the cookie when the browser session is closed.

* Removing release-drafter github action (#6248)

* Add Skip tour button in welcome onboarding (#6158)

This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.

* Fix - #6221 new nav analytics improvements (#6223)

* fixed redirection on connect data click. and updated analytics

* Added generic analytics for all datasource cards

* Add missed new nav analytics for connections (#6233)

* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks

* [Fix] Small UI improvements to suggested widgets section (#6190)

* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment

* Fix NPE when Segment key not available correctly (#6244)

* Using local Postgres database instead of remote (#6241)

* Using local Postgres database instead of remote

* Added createdb and usedb at the top

* FEATURE-5852 : make the iframe widget message property accessible (#5897)

-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.

* Disable tern in view mode (#6203)

* Fixed ExecutionParams (#6284)

* Fix test by mocking the response (#6273)

* added cypress tests for users mock datasource

* Fix: Mark comment threads as viewed when they are resolved (#6251)

* -log widget type in analytics service when new thread created
-set viewed=true for resolved threads

* fixed typo

* fix the test case when there is not widget type

* Add analytics event for mock-data creation (#6136)

* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Missing validations (#6281)

* Fix validations for certain scenarios which were missed earlier

* Minor comments feature fixes (#6245)

* Fix comment card click: set visible thread (#6166)

* Fixing bug where the comment feature flag was disabled for all users

* [Fix] Refresh sidebar comments list when a thread is unresolved (#6326)

* fix stop Rich text Editor from crashing on Modal (#6077)

* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Sentry typeError fix, with checks (#6256)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Supporting all ASCII characters in table widget (#6041)

* Updated labels Mock data to Sample data (#6330)

* [perf] propertyControl re-rendering (#5941)

* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Snowflake get structure error resolved for columns query (#6316)

* Table name reference copied from templates body to avoid misconfiguration in action body

* more conditions for run check (#6255)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Fix comment card click at the view mode (#6332)

* Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)

* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>

* Multiselect Widget (#5228)

We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.

* Added instance Id in analytics datapoint (#6252)

* Enable Autocomplete for Static Objects (#6302)

* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action

* updated cypress tests to account for testing trailing spaces in db name and host address

* removed unparsed token

* Commenting test (#6354)

* Add list buckets API to S3 (#6334)

* Add list buckets action method to S3

* Added TC for list bucket method

* FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)

 reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished

* Added null check to verify empty layout in generate CRUD page flow (#6359)

* Fix authentication issue while creating mockdata (#6294)

* Re set password to avoid double encryption while creating suffix datasource

* Add test to query on mockdata source

* Check the Authentication type before setting the password

* updated cypress tests for mock datasource

* fixed cypress failing datasources tests

* Fix: Update debugger placeholder text for non-mac (#6142)

* Added logic to show form data requests in debugger (#6350)

* Added logic to show form data requests in debugger

* Tests and comments

* Tests

* Tern server performance fix and Best match fix (#6338)

* Uncomment Gen CRUD page Test (#6371)

* Reorganised test steps to utilise retry action (#6208)

* updated spec with assertion values (#6323)

* updated spec with assert

* updated test

* updated test

* updated dsl

* Improvement: Add limit on password length in user signup (#6312)

* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login

* Fix binding query for the nested data responses (#6372)

* Fix binding query for the nested data responses

* Fix formatting issues and add comments

* Updated comments

* remove code duplications

* Fix: Keep inspect entity in sync with the widget selection in the entity explorer

* docs: Updates event archive

* Navigation Dropdown feedback Changes (#6119)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Feature: Add API to set and get concurrent app editors (#6292)

* -add an API in RTS to store and retrieve currently online users of an application

* -handled the case when edit app event received before user is authenticated

* -updated authentication API in rts

* close modal on cancel btn click (#6383)

The cancel button in the modal will now by default have the close action configured.

* Button and chart fixes (#6373)

* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget

* changed border radius of multiselect widget to 0px (#6349)

* open link inside text component in a new tab (#6205)

* Fix loading test data for Cypress tests in CodeBuild

* Change dropdown widget to select widget in Github labels for automation to work properly (#6386)

* Updating k8s README to point to docs.appsmith.com

* iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)

* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component

* BUG : Iframe widget: wrong placeholder `Title` (#6053)

Rectified the wrong placeholder in the iframe widget title property.

* Use feature flag api to enable/disable comments (#6322)

* Check if comments are enabled for comment intro modal (#6395)

* Fix ts error release (#6396)

* updated common method (#6397)

* Fix #5740 - Api actions are treated as queries (#6381)

* updated active datasources pane carry proper cta to create new action

* properly creating action names in either api/query context

* added a new separate new api/query btn component

* moved empty datasources warning to messages

* fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403)

* Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360)

* Icon Button Widget (#5723)

Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.

* [Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407)

* fix: Font size fixed for consistency between select and multi-select widget (#6400)

* Skip btn comment onboarding (#6331)

* [Fix] Reset comment mode hotkey (#6401)

* Welcome tour GIF and Close button fixes (#6309)

* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants

* Fix: Set a default option in select widget while adding from suggested widgets (#6236)

* Fix jest test for comments by overriding isCommentMode selector (#6027)

* Fix download with URL issue  (#6179)

* Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392)

Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update CRUD template For S3 page (#6426)

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>

* Cypress tests for commenting feature (#5505)

* Minor fixes for comments on the modal widget (#6368)

* Update permission check for determining a user with dev access for comments intro (#6431)

* Prevent Entire Editor Header from re rendering (#6415)

* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* [Fix] Focus the comment thread when opened after dismissing (#6437)

* Dont fetch feature flags if not logged in (#6444)

* Update README.md

Fixed a spelling mistake

* Fix: Parse api body to be shown as an object in debugger if possible (#6249)

* Fix: List Widget issues (#6226)

* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>

* [Bugfix] Empty object creation in published pages for application object fixed

* Omnibar redesign (#6288)

Omni bar would now have the categories navigation and documentation.

* [skip_changelog] Form login disabled after user uses OAuth login method (#6425)

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* changed default image to old value loading from cloudinary (#6467)

* Feature: Show a list of realtime app editors (#6286)

* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list

* Enable auto-start after VM restart (#6428)

* BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)

-- Add a overlaid div for iframe

* Added fix for cmd + enter not running google sheets actions (#6446)

* Fix-Catch invalid google recaptcha v3 key error (#6034)

* Handle invalid google recaptcha v3 key

* changed default divider color to light grey (#6335)

* fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380)

* Add null check for the nested data structure (#6479)

* Add null check for the nested data structure

* Add unit test for the null nested data

* Adding a max size of approximately 1 MB of data fetched using appsmith (#6491)

* WIP Restrict fetch size

* Adding a cut off of approximately 1 MB of data fetched in postgres plugin

* Code cleanup

* Minor cleanup

* [Fix] Minor comments feature fixes (#6490)

* Fix skip btn

* update sorting for mentions list

* Show server logs when create cypress user fails

* [Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477)

* Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)

This reverts commit 3ae1bd6d95.

* Updated flaky test (#6486)

* Updated flaky test

* updated another test

* Store MongoDB creds in separate file from install.sh (#6499)

* Store MongoDB creds in separate file from install.sh

* Move MongoDB credentials to docker.env

* Add Analytics to Generate CRUD template feat (#6503)

* Add Analytics to Generate CRUD template feat

* Add analytics event on datasource click

* Send pluginName instead of plugin obj in analytics

* Fix: Adding checks before we check for disallowCopy (#6214)

* Fix: Adding checks to before we check for disallowCopy

* Adding checks for undo logic when a child delete is undone but the parent is already deleted.

* restore widgets if they have their parent available.

* reported bugs.

* undo only when parent exists.

* Hotfix Table Widget crashes when there is a cyclical dependency (#6505)

* FIX #5254 : dropdown height fixed and made scrollable (#6170)

* will widget pane if user moves away from canvas (#6516)

* Fix: intercom triggers are not working properly (#6512)

* initializing the intercom as soon as the help components are mounted.

* removed log

* Fix: Undo-Delete of Containers fix (#6510)

* Encrypt attributes (#6508)

* encrypt attributes

* updated references to DOM targets for accessing the Mock User datasource

* Fix/omnibar landing bug (#6513)

* hide certificate string using dots on UI (#6533)

* replace actual certificate string with '*' like it is done for hiding password on the UI.

* Updated Template

* fixed failing cypress tests

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Pranav Kanade <pranav@appsmith.com>
Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: rahulramesha <71900764+rahulramesha@users.noreply.github.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Confidence Okoghenun <cokoghenun@gmail.com>
Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com>
Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: abhishek nayak <nayak.abhishek@gmail.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com>
Co-authored-by: Nipun Agarwal <31271538+nipun1999@users.noreply.github.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2021-08-13 09:42:29 +01:00
Trisha Anand
b4b1706946
BSON documents for aggregate pipelines are not valid JSON. Using BSON parse instead of JSON parse to ensure valid Mongo commands don't throw an error (#6583) 2021-08-13 08:00:34 +00:00
Rishabh Saxena
632325bffa
Remove comments discovery tooltip (#6571) 2021-08-13 12:59:14 +05:30
rahulramesha
2e884bd7eb
minor shortcut change to match existing hotkey (#6580) 2021-08-13 12:03:39 +05:30
Abhijeet
a1398ad9b4
[skip_changelog] Check datasource validity before creating a CRUD page (#6562)
* Added check for valid datasource before generating a page

* Sanitise column names for binding in widgets

* Refactor

* Update TC
2021-08-13 11:19:06 +05:30
Nayan
c3b44aa3b3
Bugfix: Create notification when comment added, deleted and thread resolved, deleted (#6495)
* bugfix: notification not created if user is mentioned in the first comment of a thread

* -add notification event type in comment notifications
-show different message for create thread and create comment in UI

* -send notification when comment is deleted

* -send notification when comment thread is deleted
2021-08-13 10:58:42 +06:00
Rishabh Rathod
75152eb8a6
Add back button in generate page form (#6559) 2021-08-13 01:22:48 +05:30
arslanhaiderbuttar
273b2d902f
Update Button_spec.js (#6474)
* Update Button_spec.js

Button widget issue has been fixed.

* Change the method to write text in property pane
2021-08-12 22:37:30 +05:00
Abhijeet
1d0f5011ec
Update CRUD template
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-08-12 19:17:20 +05:30
Sumit Kumar
8f9963515b
Fix: Mysql plugin: add timeout to validation check to avoid connection block. (#6555)
* add timeout to validation check to avoid connection block.
2021-08-12 17:32:29 +05:30
Ashok Kumar M
f19ebbafe9
[Feature] Widget grouping - Allow Drag and Drop of multiple widgets. (#5389)
* dip

* dip

* scroll

* fixes

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* solve for canvas glitches

* dip

* dip

* dip

* adjust scroll speed

* dip

* dip(code clean up)

* dip

* dip

* ---dip

* dip

* dip

* dip

* middle ware for dropping multiple widgets.

* adding scroll to drag for canvas selection.

* fixing drag disabled and modal widget(detach from layout) drops

* firefox and safari fixes

* rebase conflicts.

* fixing broken specs.

* fixing specs and adding jest tests.

* show border and disable resize when multiple widgets are selected.

* selection box grab cursor

* merge conflicts.

* code clean up

* fixing specs.

* fixed a bug and failed specs.

* fixing rerenders.

* code clean up

* code review comments

* always have the drag point inside the widget.

* fetching snap spaces instead of calculating.

* remove widget_move action

* fixing bugs with add widget parent height updation.

* fixing specs.

* List widget conflict fixes.

* fixing canvas drop persistence.

* Adding click to drag for modals and fixing few issues.
2021-08-12 11:15:38 +05:30
NandanAnantharamu
3a41ab1f17
Added test for Navigate To feature (#6531)
* Added test for Navigate To feature

* updated test title
2021-08-12 11:01:20 +05:30
Arpit Mohan
be675fbc6b
Adding the email rollout strategy to feature flag (#6541)
This PR adds the email based rollout strategy to features. We can now define a list of domain names in the init-flags.yml file and define the domains for which the feature will be active.

Also added tests to assert the functionality for this flag flipping strategy.
2021-08-12 04:57:45 +00:00
DevSnap
45cfb0b0f1
replaced subPage with page (#6438)
On mass select operation in table widget, Now all rows are selected.
2021-08-11 19:36:26 +05:30
Tolulope Adetula
38e1d660ef
fix: table column order and isVisible (#6521)
Hot-fixes:
- Table column order reset on page / data refresh
- Table column visible property reset on page / data refresh
2021-08-11 19:32:14 +05:30
Nikhil Nandagopal
d6e5c0d19e Updated Template 2021-08-11 17:20:22 +05:30
Sumit Kumar
21e7dea190
hide certificate string using dots on UI (#6533)
* replace actual certificate string with '*' like it is done for hiding password on the UI.
2021-08-11 16:42:53 +05:30
arunvjn
6402cd4add
Fix/omnibar landing bug (#6513) 2021-08-11 12:18:57 +05:30
Sumit Kumar
15061765da
Encrypt attributes (#6508)
* encrypt attributes
2021-08-11 11:43:57 +05:30
Ashok Kumar M
b45d24da9b
Fix: Undo-Delete of Containers fix (#6510) 2021-08-11 11:36:49 +05:30
Pranav Kanade
a14730a453
Fix: intercom triggers are not working properly (#6512)
* initializing the intercom as soon as the help components are mounted.

* removed log
2021-08-11 11:03:11 +05:30
Pranav Kanade
700ed39d33
will widget pane if user moves away from canvas (#6516) 2021-08-10 20:26:56 +05:30
Yash Vibhandik
fddf2aece0
FIX #5254 : dropdown height fixed and made scrollable (#6170) 2021-08-10 18:10:21 +05:30
Hetu Nandu
eba88cdc85
Hotfix Table Widget crashes when there is a cyclical dependency (#6505) 2021-08-10 15:51:27 +05:30
Ashok Kumar M
1e05150ffd
Fix: Adding checks before we check for disallowCopy (#6214)
* Fix: Adding checks to before we check for disallowCopy

* Adding checks for undo logic when a child delete is undone but the parent is already deleted.

* restore widgets if they have their parent available.

* reported bugs.

* undo only when parent exists.
2021-08-10 15:42:47 +05:30
Rishabh Rathod
18272550c6
Add Analytics to Generate CRUD template feat (#6503)
* Add Analytics to Generate CRUD template feat

* Add analytics event on datasource click

* Send pluginName instead of plugin obj in analytics
2021-08-10 09:49:39 +00:00
NandanAnantharamu
11c70353d9
Updated flaky test (#6486)
* Updated flaky test

* updated another test
2021-08-10 13:29:05 +05:30
rahulramesha
8a71fb68b2
Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)
This reverts commit 3ae1bd6d95.
2021-08-10 13:27:29 +05:30
Rishabh Saxena
481ed86837
[Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477) 2021-08-10 12:21:46 +05:30
Rishabh Saxena
1f1e70f473
[Fix] Minor comments feature fixes (#6490)
* Fix skip btn

* update sorting for mentions list
2021-08-10 12:05:08 +06:00
Trisha Anand
9251312cf1
Adding a max size of approximately 1 MB of data fetched using appsmith (#6491)
* WIP Restrict fetch size

* Adding a cut off of approximately 1 MB of data fetched in postgres plugin

* Code cleanup

* Minor cleanup
2021-08-10 11:02:19 +05:30
Anagh Hegde
e2284e4199
Add null check for the nested data structure (#6479)
* Add null check for the nested data structure

* Add unit test for the null nested data
2021-08-09 19:24:19 +05:30
haojin111
f4d4199183
fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380) 2021-08-09 18:21:13 +05:30
Bhavin K
ee33a556d3
changed default divider color to light grey (#6335) 2021-08-09 17:52:17 +05:30
Vicky Bansal
a8871770c1
Fix-Catch invalid google recaptcha v3 key error (#6034)
* Handle invalid google recaptcha v3 key
2021-08-09 17:48:58 +05:30
Nipun Agarwal
22f30d09b0
Added fix for cmd + enter not running google sheets actions (#6446) 2021-08-09 15:47:35 +05:30
Paul Li
a92b7595db
BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)
-- Add a overlaid div for iframe
2021-08-09 15:21:33 +05:30
Pranav Kanade
2ae0c8c836
Feature: Show a list of realtime app editors (#6286)
* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list
2021-08-09 14:34:24 +05:30
Bhavin K
805026176c
changed default image to old value loading from cloudinary (#6467) 2021-08-09 13:44:26 +05:30
Abhijeet
eb7dd49457
[skip_changelog] Form login disabled after user uses OAuth login method (#6425)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-08-09 12:50:06 +05:30
arunvjn
83249275a7
Omnibar redesign (#6288)
Omni bar would now have the categories navigation and documentation.
2021-08-09 11:52:37 +05:30
Abhijeet
87beed34d6
[Bugfix] Empty object creation in published pages for application object fixed 2021-08-09 11:43:51 +05:30
Pawan Kumar
8546b24839
Fix: List Widget issues (#6226)
* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-08-09 11:05:01 +05:30
akash-codemonk
48d389fe69
Fix: Parse api body to be shown as an object in debugger if possible (#6249) 2021-08-09 10:57:58 +05:30
Rishabh Saxena
cee509011b
Dont fetch feature flags if not logged in (#6444) 2021-08-07 09:40:06 +05:30
Rishabh Saxena
61820cc180
[Fix] Focus the comment thread when opened after dismissing (#6437) 2021-08-06 12:18:58 +00:00
rahulramesha
e3b141fbef
Prevent Entire Editor Header from re rendering (#6415)
* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-06 16:14:38 +05:30
Rishabh Saxena
d6c10b75f8
Update permission check for determining a user with dev access for comments intro (#6431) 2021-08-06 15:23:05 +05:30
Rishabh Saxena
e4255f6773
Minor fixes for comments on the modal widget (#6368) 2021-08-06 14:47:56 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature (#5505) 2021-08-06 14:47:02 +05:30
Abhijeet
786f7f8ec9
Update CRUD template For S3 page (#6426)
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-08-06 12:50:42 +05:30
dependabot[bot]
e1550477b8
Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392)
Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-06 12:46:47 +05:30
Favour Ohanekwu
dd0a413f1f
Fix download with URL issue (#6179) 2021-08-06 10:56:28 +05:30
Rishabh Saxena
eb55385bc6
Fix jest test for comments by overriding isCommentMode selector (#6027) 2021-08-05 22:16:38 +05:30
akash-codemonk
c0364d747b
Fix: Set a default option in select widget while adding from suggested widgets (#6236) 2021-08-05 20:27:08 +05:30
albinAppsmith
c1b815ff45
Welcome tour GIF and Close button fixes (#6309)
* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants
2021-08-05 13:48:51 +00:00
Rishabh Saxena
4bd1ffb324
[Fix] Reset comment mode hotkey (#6401) 2021-08-05 18:57:48 +05:30
Rishabh Saxena
a21375e104
Skip btn comment onboarding (#6331) 2021-08-05 17:36:29 +05:30
Tolulope Adetula
4252af1b20
fix: Font size fixed for consistency between select and multi-select widget (#6400) 2021-08-05 17:29:54 +05:30
Rishabh Saxena
3d9bf77505
[Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407) 2021-08-05 17:23:03 +05:30
Paul Li
4f6a62fa53
Icon Button Widget (#5723)
Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.
2021-08-05 16:46:26 +05:30
Yash Vibhandik
418851fc2a
Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360) 2021-08-05 16:36:04 +05:30
Tolulope Adetula
330cd4a918
fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403) 2021-08-05 16:26:32 +05:30
Pranav Kanade
09c2dfaab1
Fix #5740 - Api actions are treated as queries (#6381)
* updated active datasources pane carry proper cta to create new action

* properly creating action names in either api/query context

* added a new separate new api/query btn component

* moved empty datasources warning to messages
2021-08-05 16:24:24 +05:30
NandanAnantharamu
9a4e1aed64
updated common method (#6397) 2021-08-05 15:40:52 +05:30
Rishabh Saxena
114140a64c
Fix ts error release (#6396) 2021-08-05 12:57:33 +05:30
Rishabh Saxena
333408f7b0
Check if comments are enabled for comment intro modal (#6395) 2021-08-05 06:26:27 +00:00
Rishabh Saxena
f0bf799b67
Use feature flag api to enable/disable comments (#6322) 2021-08-05 11:40:19 +05:30
Paul Li
7afb3034bf
BUG : Iframe widget: wrong placeholder Title (#6053)
Rectified the wrong placeholder in the iframe widget title property.
2021-08-05 10:52:27 +05:30
Paul Li
862e9f412e
iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)
* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component
2021-08-05 10:50:02 +05:30
haojin111
eda00479d5
open link inside text component in a new tab (#6205) 2021-08-04 19:04:44 +05:30
haojin111
96e494e38f
changed border radius of multiselect widget to 0px (#6349) 2021-08-04 19:03:32 +05:30
arslanhaiderbuttar
159ad60dc6
Button and chart fixes (#6373)
* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget
2021-08-04 12:50:40 +00:00
Bhavin K
9b6817e97d
close modal on cancel btn click (#6383)
The cancel button in the modal will now by default have the close action configured.
2021-08-04 18:07:46 +05:30
Nayan
5d8b7a961f
Feature: Add API to set and get concurrent app editors (#6292)
* -add an API in RTS to store and retrieve currently online users of an application

* -handled the case when edit app event received before user is authenticated

* -updated authentication API in rts
2021-08-04 12:28:01 +00:00
rahulramesha
60c4887432
Navigation Dropdown feedback Changes (#6119)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-04 16:23:04 +05:30
akash-codemonk
f413924fd4
Fix: Keep inspect entity in sync with the widget selection in the entity explorer 2021-08-04 15:36:13 +05:30
Anagh Hegde
42c2d1f708
Fix binding query for the nested data responses (#6372)
* Fix binding query for the nested data responses

* Fix formatting issues and add comments

* Updated comments

* remove code duplications
2021-08-04 15:23:33 +05:30
Nayan
0d106a5c9d
Improvement: Add limit on password length in user signup (#6312)
* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login
2021-08-04 15:33:33 +06:00
NandanAnantharamu
f5dd307357
updated spec with assertion values (#6323)
* updated spec with assert

* updated test

* updated test

* updated dsl
2021-08-04 14:41:59 +05:30
NandanAnantharamu
4b5dc15944
Reorganised test steps to utilise retry action (#6208) 2021-08-04 12:19:20 +05:30
Rishabh Rathod
8f91d9e80a
Uncomment Gen CRUD page Test (#6371) 2021-08-04 11:05:16 +05:30
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
Nidhi
57436bb2d1
Added logic to show form data requests in debugger (#6350)
* Added logic to show form data requests in debugger

* Tests and comments

* Tests
2021-08-04 10:47:41 +05:30
akash-codemonk
63dc8123bb
Fix: Update debugger placeholder text for non-mac (#6142) 2021-08-04 10:20:27 +05:30
Anagh Hegde
528716cc7a
Fix authentication issue while creating mockdata (#6294)
* Re set password to avoid double encryption while creating suffix datasource

* Add test to query on mockdata source

* Check the Authentication type before setting the password
2021-08-03 21:17:58 +05:30
Abhijeet
365c6e3f39
Added null check to verify empty layout in generate CRUD page flow (#6359) 2021-08-03 19:28:36 +05:30
Yash Vibhandik
31f8a708ae
FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)
reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished
2021-08-03 19:06:03 +05:30
Abhijeet
60cbaad9bd
Add list buckets API to S3 (#6334)
* Add list buckets action method to S3

* Added TC for list bucket method
2021-08-03 18:04:47 +05:30
NandanAnantharamu
cd72098b0d
Commenting test (#6354) 2021-08-03 16:19:45 +05:30
Rishabh Rathod
a9f16d75bd
Enable Autocomplete for Static Objects (#6302)
* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action
2021-08-03 13:36:48 +05:30
Abhijeet
7052e97547
Added instance Id in analytics datapoint (#6252) 2021-08-03 12:24:21 +05:30
Tolulope Adetula
24b78d1e2b
Multiselect Widget (#5228)
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30
Satish Gandham
88c92fd2f5
Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)
* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-08-02 21:36:33 +05:30
Rishabh Saxena
ce6f42683e
Fix comment card click at the view mode (#6332) 2021-08-02 21:15:19 +05:30
rahulramesha
7252975201
more conditions for run check (#6255)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 19:25:43 +05:30
Abhijeet
70cf1e39b8
Snowflake get structure error resolved for columns query (#6316)
* Table name reference copied from templates body to avoid misconfiguration in action body
2021-08-02 19:03:28 +05:30
rahulramesha
f7095296e7
[perf] propertyControl re-rendering (#5941)
* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 18:36:22 +05:30
Pranav Kanade
2ca224d444
Updated labels Mock data to Sample data (#6330) 2021-08-02 18:14:56 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget (#6041) 2021-08-02 12:07:55 +00:00
rahulramesha
2587d78404
Sentry typeError fix, with checks (#6256)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:46:50 +05:30
rahulramesha
a3152c450c
fix stop Rich text Editor from crashing on Modal (#6077)
* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:45:51 +05:30
Rishabh Saxena
5d6d9f75f4
[Fix] Refresh sidebar comments list when a thread is unresolved (#6326) 2021-08-02 16:05:58 +05:30
Arpit Mohan
538fe8ea00 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2021-08-02 14:42:58 +05:30
Arpit Mohan
c466056223 Fixing bug where the comment feature flag was disabled for all users 2021-08-02 14:42:43 +05:30
Rishabh Saxena
4b79291a7f
Fix comment card click: set visible thread (#6166) 2021-08-02 13:55:35 +05:30
Rishabh Saxena
6ee28950be
Minor comments feature fixes (#6245) 2021-08-02 12:57:20 +05:30
Abhinav Jha
cd8407152c
Missing validations (#6281)
* Fix validations for certain scenarios which were missed earlier
2021-08-02 12:53:46 +05:30
Anagh Hegde
9dbb16747e
Add analytics event for mock-data creation (#6136)
* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-08-02 08:30:56 +05:30
Nayan
183cc97b50
Fix: Mark comment threads as viewed when they are resolved (#6251)
* -log widget type in analytics service when new thread created
-set viewed=true for resolved threads

* fixed typo

* fix the test case when there is not widget type
2021-08-02 00:12:41 +06:00
akash-codemonk
bafab2f254
Fix test by mocking the response (#6273) 2021-07-30 18:33:57 +05:30
yatinappsmith
de1088f84a
Fixed ExecutionParams (#6284) 2021-07-30 18:33:34 +05:30
Abhinav Jha
607012388e
Disable tern in view mode (#6203) 2021-07-30 15:54:22 +05:30
Paul Li
334c092fe4
FEATURE-5852 : make the iframe widget message property accessible (#5897)
-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.
2021-07-30 12:06:00 +05:30
yatinappsmith
a665b943c0
Using local Postgres database instead of remote (#6241)
* Using local Postgres database instead of remote

* Added createdb and usedb at the top
2021-07-30 11:41:14 +05:30
Shrikant Sharat Kandula
1c70a104a6
Fix NPE when Segment key not available correctly (#6244) 2021-07-30 11:36:42 +05:30