Commit Graph

5620 Commits

Author SHA1 Message Date
Sumit Kumar
9faa22ad58
Fix: Dynamodb Plugin: remove data type info keys from raw values. (#6652)
* A fix had been introduced earlier (I had introduced it a few months back) to remove data type info keys from the raw response. However, the transformation was not getting applied to the Query action as the transformation was explicitly limited to few actions. This PR removes that check and allows the transformation for all actions as there does not seem to be any reason to withhold this transformation for other actions.
* The earlier fix also restricted this transformation to results that had specific keys. This PR removes this check as well as it does not seem to be required and further may lead to similar issues if any particular key gets missed.
* Some other redundant checks have been removed from the flow as the transformation function itself takes care of it as edge/base case.
2021-08-17 19:18:25 +05:30
ashit-rath
2bd2565580
FIX #6127 - Entity explorer - cloned page widget highlight (#6441)
* Fix 6123 - Entity explorer - cloned page widget highlight

* on page clone, clear widget selection
2021-08-17 13:23:11 +00:00
Tolulope Adetula
b6f9aef70a
feat: Add isDisabled to Button column and isVisible to all Table widget Column settings (#4819) 2021-08-17 18:24:43 +05:30
Nayan
919a420aa7
[Improvement]- Improve the password reset feature (#6545)
* -limit the rate for sending password reset requests

* -used encrypted token in password reset

* -add unit tests for the password reset issue

* -improved formatting

* -updated PR as per review comments

* -hanled IllegalStateException instead of Exception when parsing the encrypted token
2021-08-17 12:35:00 +00:00
Favour Ohanekwu
a80c92694b
fix button color style bug (#6660) 2021-08-17 13:24:49 +01:00
ashit-rath
f904e4bffe
Fix: Widget: 'value' of null errors (#6535)
* validations: array - fixed default value, array object - fixed object index error message computation

* improved validation config

* minor test case additions
2021-08-17 11:35:51 +00:00
Bhavin K
1876403c4f
Added tooltip message on hover in the button widget (#6105) 2021-08-17 16:56:05 +05:30
Bhavin K
3270d6c7ba
Input widget enhancements (#5670)
Many new input widget enhancement added. The widget now has the capability to have its own label and tooltip as helper. The user can now add Icons inside the input widget and align them as well, The user can allow choose the max allowed length of the input. We have also added the isValid property in tandem to the regex property for additional validations using JS expressions
2021-08-17 16:38:04 +05:30
rahulramesha
478a2a3147
adding check for base64 (#6532) 2021-08-17 16:24:46 +05:30
Nidhi
92f4d878ab
Adding form data for uqi consumption (#6655) 2021-08-17 15:34:45 +05:30
arunvjn
00045ddfc3
Fix/debugger width bug (#6623)
* Overflow wrap for long text in debugger and set width of api pane to 100%
2021-08-17 15:25:00 +05:30
Paul Li
532e8f2a74
Feature : Checkbox Group widget (#6199)
Introducing a new widget: `Checkbox Group`, Users can now create a group of checkboxes and have an action trigger and also be able to refer the selected values from the internal API.
2021-08-17 14:41:38 +05:30
Sumit Kumar
fc30554cb5
Fix: Redis plugin: extract cmd and args based on regex (#6648)
* Earlier split method was used to segregate cmd and args which failed when multiple words inside a quoted string formed one argument. e.g. set key "my value" would produce set, key, "my, value" as the tokens when split method is used, which is not correct. This change introduces a regex that would create the following tokens: set, key, "my value"
2021-08-17 13:41:41 +05:30
Rishabh Saxena
378ecde4c8
Refactor tabs to accept tab item component and create a new variant (#6597) 2021-08-17 13:22:05 +05:30
akash-codemonk
27081e58aa
Fix: Validation error messages shown in debugger (#6572) 2021-08-17 13:02:07 +05:30
Rishabh Rathod
63ef562edb
Add Generate CRUD page Info Modal (#6557)
* Add Info Modal (WIP)
- Added modal skeleton without content

* Add generate CRUD Info Modal

* Add dialog heading to messages constants
2021-08-16 23:34:54 +05:30
Nidhi
f8e6854434
Correction in auth type value for OAuth2 in view mode of datasource (#6639)
* Correction in auth type value for OAuth2
2021-08-16 22:06:02 +05:30
Abhijeet
c3f7bea904
Add version check for import-export flow (#6552)
* Added version check

* Added error message for version check while importing the file

* Added TC to check version in exported file

* Added version in FE assets for cypruss test
2021-08-16 21:32:51 +05:30
Vicky Bansal
82722e5a38
Fix table date type column sorting (#6134) 2021-08-16 19:07:30 +05:30
Hetu Nandu
25a6590b47
Catch Data Tree update error and better sentry logging (#6627) 2021-08-16 18:12:15 +05:30
Nayan
22e477da8f
- add page name in comment notification emails (#6608) 2021-08-16 18:40:31 +06:00
Favour Ohanekwu
f0c7ce0e89
Feature/option to upload file or text in multipart form (#6534)
* added option to multipart form data for file or text upload

* updated styles for the dynamic-text-field-with-dropdown styled component

* added cypress tests for multipart body type

* code refactor: moved constants to ApiEditorConstants.ts

* updated multipart dropdown styles

* minor bug fix
2021-08-16 13:00:11 +01:00
Favour Ohanekwu
30c11e4a74
fix cypress mockdatasource flaky test (#6624) 2021-08-16 12:24:17 +01:00
Nidhi
a0462a5697
Added user email to logging context (#6619) 2021-08-16 16:36:03 +05:30
akash-codemonk
8e08e778d4
Update debugger error message CTA's (#6416) 2021-08-16 16:33:27 +05:30
Nidhi
f05e32a97e
Throw a stale connection exception when authentication token expires in Snowflake (#6612)
* Throw a stale connection on authentication token expired

* Added JUnit test
2021-08-16 10:33:39 +00:00
Ashok Kumar M
b2ade8e17e
Fix: disable widget selections when widget dragging is in progress. (#6573)
* Fix: disable widget selections when widget dragging is in progress.

* new widget select

* fixing jest tests.
2021-08-16 14:54:42 +05:30
Tolulope Adetula
f4e0e8adb0
Feat/server side filtering multiselect (#5737)
The multi-select and select now has the capability to handle server side filtering, i.e. an Appsmith dev can now choose to call an api on search or options using the onFilterUpdate action
2021-08-16 12:26:09 +05:30
Shrikant Sharat Kandula
e20d616c33
Env Manager API and super user signup API (#6473)
* Add API for env management and super user

* Add missing files

* Add API for signing up for super user

* Fix types in client code

* Add docs for env manager API

* Minor refactoring

* Remove unused updates to app startup

* Better error logging when unable to write file

Co-authored-by: Nidhi <nidhi@appsmith.com>

* Don't cache the user count (duh!)

Co-authored-by: Nidhi <nidhi@appsmith.com>
2021-08-14 07:01:54 +05:30
Shrikant Sharat Kandula
0f41886ce7
Fix NPE when Referer header is missing (#6601) 2021-08-13 22:49:09 +05:30
Nidhi
dc8673c22c
Changes to props (#6574) 2021-08-13 19:32:00 +05:30
Rishabh Saxena
0a6f0d9c1e
Close button for the comments onboarding (#6570) 2021-08-13 17:53:59 +05:30
Pawan Kumar
946ca3afb9
[Feature] Page Properties (#4989)
* disable delete icon for default

* page properties style updates

* minor style updates

* remove uneccessary imports

* update draggable list api

* style updates

* remove unused variable

* style updates

* update edit icon

* integrate sorting page api

* fix colors

* remove console.log

* add link to switch page in page list item

* remove unused import

* revert draggable list code

* remove console.log

* fix draggablelist component reorder issue

* remove draggablepagelist

* fix rerender of draggablelist

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-08-13 17:08:26 +05:30
Nidhi
f2cba9a601
Escaped inputs for bson substitution (#6565) 2021-08-13 14:44:51 +05:30
Favour Ohanekwu
11385092ca
Hotfix/trailing white spaces in mysql datasource configuration (#6227)
* trimmed white spaces in datasource configuration

* Added cypress tests for MySQLdatasource

* fixed trailing whitespaces bug in mysql datasource configuration

* Fix overflowing text in toasts on safari (#6200)

* [Feature] Generate template page from datasource  (#5513)

- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Fix xss redirectURL (#6229)

* Update msg

* Revert "Update msg"

This reverts commit 0ac70ea7e9.

* Fix JS error message showing callstack in firefox (#6234)

* Adding expiry of 30 days to session cookies (#6224)

Fixes #5872

Adding an expiry of 30 days to the cookie to ensure that browsers don't delete the cookie when the browser session is closed.

* Removing release-drafter github action (#6248)

* Add Skip tour button in welcome onboarding (#6158)

This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.

* Fix - #6221 new nav analytics improvements (#6223)

* fixed redirection on connect data click. and updated analytics

* Added generic analytics for all datasource cards

* Add missed new nav analytics for connections (#6233)

* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks

* [Fix] Small UI improvements to suggested widgets section (#6190)

* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment

* Fix NPE when Segment key not available correctly (#6244)

* Using local Postgres database instead of remote (#6241)

* Using local Postgres database instead of remote

* Added createdb and usedb at the top

* FEATURE-5852 : make the iframe widget message property accessible (#5897)

-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.

* Disable tern in view mode (#6203)

* Fixed ExecutionParams (#6284)

* Fix test by mocking the response (#6273)

* added cypress tests for users mock datasource

* Fix: Mark comment threads as viewed when they are resolved (#6251)

* -log widget type in analytics service when new thread created
-set viewed=true for resolved threads

* fixed typo

* fix the test case when there is not widget type

* Add analytics event for mock-data creation (#6136)

* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>

* Missing validations (#6281)

* Fix validations for certain scenarios which were missed earlier

* Minor comments feature fixes (#6245)

* Fix comment card click: set visible thread (#6166)

* Fixing bug where the comment feature flag was disabled for all users

* [Fix] Refresh sidebar comments list when a thread is unresolved (#6326)

* fix stop Rich text Editor from crashing on Modal (#6077)

* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Sentry typeError fix, with checks (#6256)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Supporting all ASCII characters in table widget (#6041)

* Updated labels Mock data to Sample data (#6330)

* [perf] propertyControl re-rendering (#5941)

* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Snowflake get structure error resolved for columns query (#6316)

* Table name reference copied from templates body to avoid misconfiguration in action body

* more conditions for run check (#6255)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Fix comment card click at the view mode (#6332)

* Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)

* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>

* Multiselect Widget (#5228)

We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.

* Added instance Id in analytics datapoint (#6252)

* Enable Autocomplete for Static Objects (#6302)

* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action

* updated cypress tests to account for testing trailing spaces in db name and host address

* removed unparsed token

* Commenting test (#6354)

* Add list buckets API to S3 (#6334)

* Add list buckets action method to S3

* Added TC for list bucket method

* FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)

 reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished

* Added null check to verify empty layout in generate CRUD page flow (#6359)

* Fix authentication issue while creating mockdata (#6294)

* Re set password to avoid double encryption while creating suffix datasource

* Add test to query on mockdata source

* Check the Authentication type before setting the password

* updated cypress tests for mock datasource

* fixed cypress failing datasources tests

* Fix: Update debugger placeholder text for non-mac (#6142)

* Added logic to show form data requests in debugger (#6350)

* Added logic to show form data requests in debugger

* Tests and comments

* Tests

* Tern server performance fix and Best match fix (#6338)

* Uncomment Gen CRUD page Test (#6371)

* Reorganised test steps to utilise retry action (#6208)

* updated spec with assertion values (#6323)

* updated spec with assert

* updated test

* updated test

* updated dsl

* Improvement: Add limit on password length in user signup (#6312)

* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login

* Fix binding query for the nested data responses (#6372)

* Fix binding query for the nested data responses

* Fix formatting issues and add comments

* Updated comments

* remove code duplications

* Fix: Keep inspect entity in sync with the widget selection in the entity explorer

* docs: Updates event archive

* Navigation Dropdown feedback Changes (#6119)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* Feature: Add API to set and get concurrent app editors (#6292)

* -add an API in RTS to store and retrieve currently online users of an application

* -handled the case when edit app event received before user is authenticated

* -updated authentication API in rts

* close modal on cancel btn click (#6383)

The cancel button in the modal will now by default have the close action configured.

* Button and chart fixes (#6373)

* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget

* changed border radius of multiselect widget to 0px (#6349)

* open link inside text component in a new tab (#6205)

* Fix loading test data for Cypress tests in CodeBuild

* Change dropdown widget to select widget in Github labels for automation to work properly (#6386)

* Updating k8s README to point to docs.appsmith.com

* iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)

* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component

* BUG : Iframe widget: wrong placeholder `Title` (#6053)

Rectified the wrong placeholder in the iframe widget title property.

* Use feature flag api to enable/disable comments (#6322)

* Check if comments are enabled for comment intro modal (#6395)

* Fix ts error release (#6396)

* updated common method (#6397)

* Fix #5740 - Api actions are treated as queries (#6381)

* updated active datasources pane carry proper cta to create new action

* properly creating action names in either api/query context

* added a new separate new api/query btn component

* moved empty datasources warning to messages

* fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403)

* Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360)

* Icon Button Widget (#5723)

Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.

* [Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407)

* fix: Font size fixed for consistency between select and multi-select widget (#6400)

* Skip btn comment onboarding (#6331)

* [Fix] Reset comment mode hotkey (#6401)

* Welcome tour GIF and Close button fixes (#6309)

* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants

* Fix: Set a default option in select widget while adding from suggested widgets (#6236)

* Fix jest test for comments by overriding isCommentMode selector (#6027)

* Fix download with URL issue  (#6179)

* Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392)

Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update CRUD template For S3 page (#6426)

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>

* Cypress tests for commenting feature (#5505)

* Minor fixes for comments on the modal widget (#6368)

* Update permission check for determining a user with dev access for comments intro (#6431)

* Prevent Entire Editor Header from re rendering (#6415)

* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* [Fix] Focus the comment thread when opened after dismissing (#6437)

* Dont fetch feature flags if not logged in (#6444)

* Update README.md

Fixed a spelling mistake

* Fix: Parse api body to be shown as an object in debugger if possible (#6249)

* Fix: List Widget issues (#6226)

* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>

* [Bugfix] Empty object creation in published pages for application object fixed

* Omnibar redesign (#6288)

Omni bar would now have the categories navigation and documentation.

* [skip_changelog] Form login disabled after user uses OAuth login method (#6425)

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* changed default image to old value loading from cloudinary (#6467)

* Feature: Show a list of realtime app editors (#6286)

* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list

* Enable auto-start after VM restart (#6428)

* BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)

-- Add a overlaid div for iframe

* Added fix for cmd + enter not running google sheets actions (#6446)

* Fix-Catch invalid google recaptcha v3 key error (#6034)

* Handle invalid google recaptcha v3 key

* changed default divider color to light grey (#6335)

* fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380)

* Add null check for the nested data structure (#6479)

* Add null check for the nested data structure

* Add unit test for the null nested data

* Adding a max size of approximately 1 MB of data fetched using appsmith (#6491)

* WIP Restrict fetch size

* Adding a cut off of approximately 1 MB of data fetched in postgres plugin

* Code cleanup

* Minor cleanup

* [Fix] Minor comments feature fixes (#6490)

* Fix skip btn

* update sorting for mentions list

* Show server logs when create cypress user fails

* [Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477)

* Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)

This reverts commit 3ae1bd6d95.

* Updated flaky test (#6486)

* Updated flaky test

* updated another test

* Store MongoDB creds in separate file from install.sh (#6499)

* Store MongoDB creds in separate file from install.sh

* Move MongoDB credentials to docker.env

* Add Analytics to Generate CRUD template feat (#6503)

* Add Analytics to Generate CRUD template feat

* Add analytics event on datasource click

* Send pluginName instead of plugin obj in analytics

* Fix: Adding checks before we check for disallowCopy (#6214)

* Fix: Adding checks to before we check for disallowCopy

* Adding checks for undo logic when a child delete is undone but the parent is already deleted.

* restore widgets if they have their parent available.

* reported bugs.

* undo only when parent exists.

* Hotfix Table Widget crashes when there is a cyclical dependency (#6505)

* FIX #5254 : dropdown height fixed and made scrollable (#6170)

* will widget pane if user moves away from canvas (#6516)

* Fix: intercom triggers are not working properly (#6512)

* initializing the intercom as soon as the help components are mounted.

* removed log

* Fix: Undo-Delete of Containers fix (#6510)

* Encrypt attributes (#6508)

* encrypt attributes

* updated references to DOM targets for accessing the Mock User datasource

* Fix/omnibar landing bug (#6513)

* hide certificate string using dots on UI (#6533)

* replace actual certificate string with '*' like it is done for hiding password on the UI.

* Updated Template

* fixed failing cypress tests

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Pranav Kanade <pranav@appsmith.com>
Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: rahulramesha <71900764+rahulramesha@users.noreply.github.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Satish Gandham <satish.iitg@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Confidence Okoghenun <cokoghenun@gmail.com>
Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com>
Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: abhishek nayak <nayak.abhishek@gmail.com>
Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com>
Co-authored-by: Nipun Agarwal <31271538+nipun1999@users.noreply.github.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2021-08-13 09:42:29 +01:00
Trisha Anand
b4b1706946
BSON documents for aggregate pipelines are not valid JSON. Using BSON parse instead of JSON parse to ensure valid Mongo commands don't throw an error (#6583) 2021-08-13 08:00:34 +00:00
Rishabh Saxena
632325bffa
Remove comments discovery tooltip (#6571) 2021-08-13 12:59:14 +05:30
rahulramesha
2e884bd7eb
minor shortcut change to match existing hotkey (#6580) 2021-08-13 12:03:39 +05:30
Abhijeet
a1398ad9b4
[skip_changelog] Check datasource validity before creating a CRUD page (#6562)
* Added check for valid datasource before generating a page

* Sanitise column names for binding in widgets

* Refactor

* Update TC
2021-08-13 11:19:06 +05:30
Nayan
c3b44aa3b3
Bugfix: Create notification when comment added, deleted and thread resolved, deleted (#6495)
* bugfix: notification not created if user is mentioned in the first comment of a thread

* -add notification event type in comment notifications
-show different message for create thread and create comment in UI

* -send notification when comment is deleted

* -send notification when comment thread is deleted
2021-08-13 10:58:42 +06:00
Rishabh Rathod
75152eb8a6
Add back button in generate page form (#6559) 2021-08-13 01:22:48 +05:30
arslanhaiderbuttar
273b2d902f
Update Button_spec.js (#6474)
* Update Button_spec.js

Button widget issue has been fixed.

* Change the method to write text in property pane
2021-08-12 22:37:30 +05:00
Abhijeet
1d0f5011ec
Update CRUD template
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-08-12 19:17:20 +05:30
Sumit Kumar
8f9963515b
Fix: Mysql plugin: add timeout to validation check to avoid connection block. (#6555)
* add timeout to validation check to avoid connection block.
2021-08-12 17:32:29 +05:30
Ashok Kumar M
f19ebbafe9
[Feature] Widget grouping - Allow Drag and Drop of multiple widgets. (#5389)
* dip

* dip

* scroll

* fixes

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* dip

* solve for canvas glitches

* dip

* dip

* dip

* adjust scroll speed

* dip

* dip(code clean up)

* dip

* dip

* ---dip

* dip

* dip

* dip

* middle ware for dropping multiple widgets.

* adding scroll to drag for canvas selection.

* fixing drag disabled and modal widget(detach from layout) drops

* firefox and safari fixes

* rebase conflicts.

* fixing broken specs.

* fixing specs and adding jest tests.

* show border and disable resize when multiple widgets are selected.

* selection box grab cursor

* merge conflicts.

* code clean up

* fixing specs.

* fixed a bug and failed specs.

* fixing rerenders.

* code clean up

* code review comments

* always have the drag point inside the widget.

* fetching snap spaces instead of calculating.

* remove widget_move action

* fixing bugs with add widget parent height updation.

* fixing specs.

* List widget conflict fixes.

* fixing canvas drop persistence.

* Adding click to drag for modals and fixing few issues.
2021-08-12 11:15:38 +05:30
NandanAnantharamu
3a41ab1f17
Added test for Navigate To feature (#6531)
* Added test for Navigate To feature

* updated test title
2021-08-12 11:01:20 +05:30
Arpit Mohan
be675fbc6b
Adding the email rollout strategy to feature flag (#6541)
This PR adds the email based rollout strategy to features. We can now define a list of domain names in the init-flags.yml file and define the domains for which the feature will be active.

Also added tests to assert the functionality for this flag flipping strategy.
2021-08-12 04:57:45 +00:00
DevSnap
45cfb0b0f1
replaced subPage with page (#6438)
On mass select operation in table widget, Now all rows are selected.
2021-08-11 19:36:26 +05:30
Tolulope Adetula
38e1d660ef
fix: table column order and isVisible (#6521)
Hot-fixes:
- Table column order reset on page / data refresh
- Table column visible property reset on page / data refresh
2021-08-11 19:32:14 +05:30
Nikhil Nandagopal
d6e5c0d19e Updated Template 2021-08-11 17:20:22 +05:30
Sumit Kumar
21e7dea190
hide certificate string using dots on UI (#6533)
* replace actual certificate string with '*' like it is done for hiding password on the UI.
2021-08-11 16:42:53 +05:30
arunvjn
6402cd4add
Fix/omnibar landing bug (#6513) 2021-08-11 12:18:57 +05:30
Sumit Kumar
15061765da
Encrypt attributes (#6508)
* encrypt attributes
2021-08-11 11:43:57 +05:30
Ashok Kumar M
b45d24da9b
Fix: Undo-Delete of Containers fix (#6510) 2021-08-11 11:36:49 +05:30
Pranav Kanade
a14730a453
Fix: intercom triggers are not working properly (#6512)
* initializing the intercom as soon as the help components are mounted.

* removed log
2021-08-11 11:03:11 +05:30
Pranav Kanade
700ed39d33
will widget pane if user moves away from canvas (#6516) 2021-08-10 20:26:56 +05:30
Yash Vibhandik
fddf2aece0
FIX #5254 : dropdown height fixed and made scrollable (#6170) 2021-08-10 18:10:21 +05:30
Hetu Nandu
eba88cdc85
Hotfix Table Widget crashes when there is a cyclical dependency (#6505) 2021-08-10 15:51:27 +05:30
Ashok Kumar M
1e05150ffd
Fix: Adding checks before we check for disallowCopy (#6214)
* Fix: Adding checks to before we check for disallowCopy

* Adding checks for undo logic when a child delete is undone but the parent is already deleted.

* restore widgets if they have their parent available.

* reported bugs.

* undo only when parent exists.
2021-08-10 15:42:47 +05:30
Rishabh Rathod
18272550c6
Add Analytics to Generate CRUD template feat (#6503)
* Add Analytics to Generate CRUD template feat

* Add analytics event on datasource click

* Send pluginName instead of plugin obj in analytics
2021-08-10 09:49:39 +00:00
NandanAnantharamu
11c70353d9
Updated flaky test (#6486)
* Updated flaky test

* updated another test
2021-08-10 13:29:05 +05:30
rahulramesha
8a71fb68b2
Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)
This reverts commit 3ae1bd6d95.
2021-08-10 13:27:29 +05:30
Rishabh Saxena
481ed86837
[Fix test spec]Create a new org for the comments test so existing user roles don't exist (#6477) 2021-08-10 12:21:46 +05:30
Rishabh Saxena
1f1e70f473
[Fix] Minor comments feature fixes (#6490)
* Fix skip btn

* update sorting for mentions list
2021-08-10 12:05:08 +06:00
Trisha Anand
9251312cf1
Adding a max size of approximately 1 MB of data fetched using appsmith (#6491)
* WIP Restrict fetch size

* Adding a cut off of approximately 1 MB of data fetched in postgres plugin

* Code cleanup

* Minor cleanup
2021-08-10 11:02:19 +05:30
Anagh Hegde
e2284e4199
Add null check for the nested data structure (#6479)
* Add null check for the nested data structure

* Add unit test for the null nested data
2021-08-09 19:24:19 +05:30
haojin111
f4d4199183
fixed issue where the resize cursor did not appear on the left hand side of the widget (#6380) 2021-08-09 18:21:13 +05:30
Bhavin K
ee33a556d3
changed default divider color to light grey (#6335) 2021-08-09 17:52:17 +05:30
Vicky Bansal
a8871770c1
Fix-Catch invalid google recaptcha v3 key error (#6034)
* Handle invalid google recaptcha v3 key
2021-08-09 17:48:58 +05:30
Nipun Agarwal
22f30d09b0
Added fix for cmd + enter not running google sheets actions (#6446) 2021-08-09 15:47:35 +05:30
Paul Li
a92b7595db
BUG-6029 : Property pane for iFrame widget does not appear on clicking on widget (#6260)
-- Add a overlaid div for iframe
2021-08-09 15:21:33 +05:30
Pranav Kanade
2ae0c8c836
Feature: Show a list of realtime app editors (#6286)
* Added support for showing realtime app editors

* emitting an event only when socket is connected

* added a tooltip to show username/email

* using proper selector

* using theme

* created the separate component for listing editors

* created a separate hook for app collab events

* moved collab user type to /entities

* moved user visible strings to message constants

* Revert "moved user visible strings to message constants"

This reverts commit 04ac18a188b0117dd364ad764a4e0103bfd28ef6.

* made provision to reset the concurrent editors list
2021-08-09 14:34:24 +05:30
Bhavin K
805026176c
changed default image to old value loading from cloudinary (#6467) 2021-08-09 13:44:26 +05:30
Abhijeet
eb7dd49457
[skip_changelog] Form login disabled after user uses OAuth login method (#6425)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-08-09 12:50:06 +05:30
arunvjn
83249275a7
Omnibar redesign (#6288)
Omni bar would now have the categories navigation and documentation.
2021-08-09 11:52:37 +05:30
Abhijeet
87beed34d6
[Bugfix] Empty object creation in published pages for application object fixed 2021-08-09 11:43:51 +05:30
Pawan Kumar
8546b24839
Fix: List Widget issues (#6226)
* fix binding

* fix multiple binding not working issue

* use box shadow inset + fix gap issue

* fix container z index issue

* fix resize ux issue

* update container height

* allow selecting list widget only when the property pane is not visible

* fix resize handle overflow issue

* fix dot issue in current item structure + fix resize issue for template

* fix select widget not workign inside list widget issue

* remove unused keys

* fix jest test

* fix derived.js test

* add undefiend check

* add currentIndex for autocomplete

* revert white color to transparent for list container

* fix pagination wrong calculation

* remove beta tag

* fix issue with cypress test failing

* fix issue with dropdown widget

* fix the boolean value issue

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-08-09 11:05:01 +05:30
akash-codemonk
48d389fe69
Fix: Parse api body to be shown as an object in debugger if possible (#6249) 2021-08-09 10:57:58 +05:30
Rishabh Saxena
cee509011b
Dont fetch feature flags if not logged in (#6444) 2021-08-07 09:40:06 +05:30
Rishabh Saxena
61820cc180
[Fix] Focus the comment thread when opened after dismissing (#6437) 2021-08-06 12:18:58 +00:00
rahulramesha
e3b141fbef
Prevent Entire Editor Header from re rendering (#6415)
* Seperate save indicator without rerendering entire Editor Header

* stop unnecessary update to Saved message every second

* moving raw strings to messages

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-06 16:14:38 +05:30
Rishabh Saxena
d6c10b75f8
Update permission check for determining a user with dev access for comments intro (#6431) 2021-08-06 15:23:05 +05:30
Rishabh Saxena
e4255f6773
Minor fixes for comments on the modal widget (#6368) 2021-08-06 14:47:56 +05:30
Rishabh Saxena
ea5603920e
Cypress tests for commenting feature (#5505) 2021-08-06 14:47:02 +05:30
Abhijeet
786f7f8ec9
Update CRUD template For S3 page (#6426)
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-08-06 12:50:42 +05:30
dependabot[bot]
e1550477b8
Bump tar from 6.0.5 to 6.1.6 in /app/client (#6392)
Bumps [tar](https://github.com/npm/node-tar) from 6.0.5 to 6.1.6.
- [Release notes](https://github.com/npm/node-tar/releases)
- [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/npm/node-tar/compare/v6.0.5...v6.1.6)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-08-06 12:46:47 +05:30
Favour Ohanekwu
dd0a413f1f
Fix download with URL issue (#6179) 2021-08-06 10:56:28 +05:30
Rishabh Saxena
eb55385bc6
Fix jest test for comments by overriding isCommentMode selector (#6027) 2021-08-05 22:16:38 +05:30
akash-codemonk
c0364d747b
Fix: Set a default option in select widget while adding from suggested widgets (#6236) 2021-08-05 20:27:08 +05:30
albinAppsmith
c1b815ff45
Welcome tour GIF and Close button fixes (#6309)
* * Chaged New Query GIF
* Added close button for welcome tour final page

* Changed Run GIF

* Sticky sidebar z-index change

* Added testcases

* Replaced hardcoded colors and text with constants
2021-08-05 13:48:51 +00:00
Rishabh Saxena
4bd1ffb324
[Fix] Reset comment mode hotkey (#6401) 2021-08-05 18:57:48 +05:30
Rishabh Saxena
a21375e104
Skip btn comment onboarding (#6331) 2021-08-05 17:36:29 +05:30
Tolulope Adetula
4252af1b20
fix: Font size fixed for consistency between select and multi-select widget (#6400) 2021-08-05 17:29:54 +05:30
Rishabh Saxena
3d9bf77505
[Fix] Mark resolved threads as read in real time, refresh list when thread resolved status is updated (#6407) 2021-08-05 17:23:03 +05:30
Paul Li
4f6a62fa53
Icon Button Widget (#5723)
Introducing the **Floating action button / Icon button**. Now you can use this to show small actions as icons. We have added a bunch of styling customisation to this as well. You can bind an onClick action to this and easily trigger an even. The component also automatically resizes within the widget as you scale it while maintaining the right aspect ratio.
2021-08-05 16:46:26 +05:30
Yash Vibhandik
418851fc2a
Fix #6160 Updated Text binding for row and removed variable evaluation - Default table data (#6360) 2021-08-05 16:36:04 +05:30
Tolulope Adetula
330cd4a918
fix: wrap overflow option in multiselect such that all option checkboxes are available(#6403) 2021-08-05 16:26:32 +05:30
Pranav Kanade
09c2dfaab1
Fix #5740 - Api actions are treated as queries (#6381)
* updated active datasources pane carry proper cta to create new action

* properly creating action names in either api/query context

* added a new separate new api/query btn component

* moved empty datasources warning to messages
2021-08-05 16:24:24 +05:30
NandanAnantharamu
9a4e1aed64
updated common method (#6397) 2021-08-05 15:40:52 +05:30
Rishabh Saxena
114140a64c
Fix ts error release (#6396) 2021-08-05 12:57:33 +05:30
Rishabh Saxena
333408f7b0
Check if comments are enabled for comment intro modal (#6395) 2021-08-05 06:26:27 +00:00
Rishabh Saxena
f0bf799b67
Use feature flag api to enable/disable comments (#6322) 2021-08-05 11:40:19 +05:30
Paul Li
7afb3034bf
BUG : Iframe widget: wrong placeholder Title (#6053)
Rectified the wrong placeholder in the iframe widget title property.
2021-08-05 10:52:27 +05:30
Paul Li
862e9f412e
iFrame - When the source url is removed message should be displayed in iframe similar to other widgets (#6295)
* FIX-5414 : iFrame - When the source url is removed message is be displayed within the component
2021-08-05 10:50:02 +05:30
haojin111
eda00479d5
open link inside text component in a new tab (#6205) 2021-08-04 19:04:44 +05:30
haojin111
96e494e38f
changed border radius of multiselect widget to 0px (#6349) 2021-08-04 19:03:32 +05:30
arslanhaiderbuttar
159ad60dc6
Button and chart fixes (#6373)
* Added new file button file and fixed the bugs in chart and button

Added new file button file and fixed the bugs in chart and button

* Fixed JS toggle for Button widget
2021-08-04 12:50:40 +00:00
Bhavin K
9b6817e97d
close modal on cancel btn click (#6383)
The cancel button in the modal will now by default have the close action configured.
2021-08-04 18:07:46 +05:30
Nayan
5d8b7a961f
Feature: Add API to set and get concurrent app editors (#6292)
* -add an API in RTS to store and retrieve currently online users of an application

* -handled the case when edit app event received before user is authenticated

* -updated authentication API in rts
2021-08-04 12:28:01 +00:00
rahulramesha
60c4887432
Navigation Dropdown feedback Changes (#6119)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-04 16:23:04 +05:30
akash-codemonk
f413924fd4
Fix: Keep inspect entity in sync with the widget selection in the entity explorer 2021-08-04 15:36:13 +05:30
Anagh Hegde
42c2d1f708
Fix binding query for the nested data responses (#6372)
* Fix binding query for the nested data responses

* Fix formatting issues and add comments

* Updated comments

* remove code duplications
2021-08-04 15:23:33 +05:30
Nayan
0d106a5c9d
Improvement: Add limit on password length in user signup (#6312)
* -add max password validation in FE and password validation in BE for signup

* -added unit test for password length limit

* - set max password length to 48
- add password length check in reset password

* -removed password limit check from login
2021-08-04 15:33:33 +06:00
NandanAnantharamu
f5dd307357
updated spec with assertion values (#6323)
* updated spec with assert

* updated test

* updated test

* updated dsl
2021-08-04 14:41:59 +05:30
NandanAnantharamu
4b5dc15944
Reorganised test steps to utilise retry action (#6208) 2021-08-04 12:19:20 +05:30
Rishabh Rathod
8f91d9e80a
Uncomment Gen CRUD page Test (#6371) 2021-08-04 11:05:16 +05:30
Hetu Nandu
1f16c2d1ee
Tern server performance fix and Best match fix (#6338) 2021-08-04 11:04:44 +05:30
Nidhi
57436bb2d1
Added logic to show form data requests in debugger (#6350)
* Added logic to show form data requests in debugger

* Tests and comments

* Tests
2021-08-04 10:47:41 +05:30
akash-codemonk
63dc8123bb
Fix: Update debugger placeholder text for non-mac (#6142) 2021-08-04 10:20:27 +05:30
Anagh Hegde
528716cc7a
Fix authentication issue while creating mockdata (#6294)
* Re set password to avoid double encryption while creating suffix datasource

* Add test to query on mockdata source

* Check the Authentication type before setting the password
2021-08-03 21:17:58 +05:30
Abhijeet
365c6e3f39
Added null check to verify empty layout in generate CRUD page flow (#6359) 2021-08-03 19:28:36 +05:30
Yash Vibhandik
31f8a708ae
FIX #6324 : reset recaptcha token on click and handled button loading explicitly (#6337)
reset re-captcha token on click and handled button loading explicitly such that the user know that the api call has not finished
2021-08-03 19:06:03 +05:30
Abhijeet
60cbaad9bd
Add list buckets API to S3 (#6334)
* Add list buckets action method to S3

* Added TC for list bucket method
2021-08-03 18:04:47 +05:30
NandanAnantharamu
cd72098b0d
Commenting test (#6354) 2021-08-03 16:19:45 +05:30
Rishabh Rathod
a9f16d75bd
Enable Autocomplete for Static Objects (#6302)
* Remove type from COLORS constant

* Remove type from InputTypes in InputWidget

* Remove type from ReduxActionTypes

* Remove type from ReduxErrorActionTypes

* Remove type from SocialLoginTypes

* Fix widget actions issues

* Remove OPEN_SUB_PANE commented redux action
2021-08-03 13:36:48 +05:30
Abhijeet
7052e97547
Added instance Id in analytics datapoint (#6252) 2021-08-03 12:24:21 +05:30
Tolulope Adetula
24b78d1e2b
Multiselect Widget (#5228)
We have now separated the multi-select from the select widget, This has simplified the implementation and helped us resolve any issues we where facing because of the complexity bought by both under the same hood and has  also increased the discoverability of the widget for our end users. We have also simultaneously taken up multiple enhancements related to the select and multi-select widget.
2021-08-03 12:08:01 +05:30
Satish Gandham
88c92fd2f5
Fix unnecessary renders of ActionCreator, EntityName, CodeEditor and ActionEntityContextMenu (#6242)
* Fix action creator unnecessary render issue
- Optimize the selectors and hooks to return new values only when something has changed.

* Fix ActionEntityContextMenu re-renders issue

* Prevent rerenders of EntityName component

* Fix CodeEditor re-renders

* Use createSelector instead of memoization.

* Cleanup

* - Remove whyDidYouRender

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-08-02 21:36:33 +05:30
Rishabh Saxena
ce6f42683e
Fix comment card click at the view mode (#6332) 2021-08-02 21:15:19 +05:30
rahulramesha
7252975201
more conditions for run check (#6255)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 19:25:43 +05:30
Abhijeet
70cf1e39b8
Snowflake get structure error resolved for columns query (#6316)
* Table name reference copied from templates body to avoid misconfiguration in action body
2021-08-02 19:03:28 +05:30
rahulramesha
f7095296e7
[perf] propertyControl re-rendering (#5941)
* prevent unnecessry re-renders on property control keyPress

* Changes to memoize with useSelector

* propertyControl re-rendering initial commit

* Optimized and Generalized PropertyControl

* Updating Property Dependencies

* removing useCallback and replacing WidgetEnhancementHelpers with selector

* nested property path changes

* reverting name Change

* tests fixes and adding dependencies for validation structure

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 18:36:22 +05:30
Pranav Kanade
2ca224d444
Updated labels Mock data to Sample data (#6330) 2021-08-02 18:14:56 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget (#6041) 2021-08-02 12:07:55 +00:00
rahulramesha
2587d78404
Sentry typeError fix, with checks (#6256)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:46:50 +05:30
rahulramesha
a3152c450c
fix stop Rich text Editor from crashing on Modal (#6077)
* changed RTE removal mechanism

* modified changes to remove just before initializing

* tinyMCE patch for firefox

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-08-02 16:45:51 +05:30
Rishabh Saxena
5d6d9f75f4
[Fix] Refresh sidebar comments list when a thread is unresolved (#6326) 2021-08-02 16:05:58 +05:30
Arpit Mohan
538fe8ea00 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2021-08-02 14:42:58 +05:30
Arpit Mohan
c466056223 Fixing bug where the comment feature flag was disabled for all users 2021-08-02 14:42:43 +05:30
Rishabh Saxena
4b79291a7f
Fix comment card click: set visible thread (#6166) 2021-08-02 13:55:35 +05:30
Rishabh Saxena
6ee28950be
Minor comments feature fixes (#6245) 2021-08-02 12:57:20 +05:30
Abhinav Jha
cd8407152c
Missing validations (#6281)
* Fix validations for certain scenarios which were missed earlier
2021-08-02 12:53:46 +05:30
Anagh Hegde
9dbb16747e
Add analytics event for mock-data creation (#6136)
* Add analytics event for mockdata creation

* Use the correct name for the mockdatasource

* Added FE analytics for mock datasource

* Changes per review

* Remove the method call

* Fix indentation issue

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-08-02 08:30:56 +05:30
Nayan
183cc97b50
Fix: Mark comment threads as viewed when they are resolved (#6251)
* -log widget type in analytics service when new thread created
-set viewed=true for resolved threads

* fixed typo

* fix the test case when there is not widget type
2021-08-02 00:12:41 +06:00
akash-codemonk
bafab2f254
Fix test by mocking the response (#6273) 2021-07-30 18:33:57 +05:30
yatinappsmith
de1088f84a
Fixed ExecutionParams (#6284) 2021-07-30 18:33:34 +05:30
Abhinav Jha
607012388e
Disable tern in view mode (#6203) 2021-07-30 15:54:22 +05:30
Paul Li
334c092fe4
FEATURE-5852 : make the iframe widget message property accessible (#5897)
-- Add a new meta property for receiving the message from an iframe. Now the user can simply refer to {{iframe.message}} to access the data they receive in an API or widget.
2021-07-30 12:06:00 +05:30
yatinappsmith
a665b943c0
Using local Postgres database instead of remote (#6241)
* Using local Postgres database instead of remote

* Added createdb and usedb at the top
2021-07-30 11:41:14 +05:30
Shrikant Sharat Kandula
1c70a104a6
Fix NPE when Segment key not available correctly (#6244) 2021-07-30 11:36:42 +05:30
Pranav Kanade
44374f5641
[Fix] Small UI improvements to suggested widgets section (#6190)
* added slight transition to suggested widgets. Adjusted the height of arrows in relationship.

* minor fixes to back btn style in suggested widgets panel

* fixed the size of collapsible icon

* removed a comment
2021-07-30 11:25:11 +05:30
akash-codemonk
7e0ebdd6b0
Add missed new nav analytics for connections (#6233)
* Log event when property pane connected entity is clicked

- Also update screen to source

* Add missed analytic event when user navigates to entity from property pane connection

- Also add entity type info to event
- Refactor to make this happen by moving useGetEntityInfo hook to debugger hooks
2021-07-30 11:23:24 +05:30
Pranav Kanade
e08b748b02
Fix - #6221 new nav analytics improvements (#6223)
* fixed redirection on connect data click. and updated analytics

* Added generic analytics for all datasource cards
2021-07-30 11:17:38 +05:30
Rishabh Rathod
fbf6d9ad2d
Add Skip tour button in welcome onboarding (#6158)
This allows users to skip the welcome tour, there is an End tour button already present but wasn't easily accessible.
2021-07-29 18:37:26 +05:30
Arpit Mohan
8dd41ab947
Adding expiry of 30 days to session cookies (#6224)
Fixes #5872

Adding an expiry of 30 days to the cookie to ensure that browsers don't delete the cookie when the browser session is closed.
2021-07-29 18:13:22 +05:30
Hetu Nandu
8789c4f897
Fix JS error message showing callstack in firefox (#6234) 2021-07-29 17:06:49 +05:30
Rishabh Saxena
7409982674 Revert "Update msg"
This reverts commit 0ac70ea7e9.
2021-07-29 16:28:47 +05:30
Rishabh Saxena
0ac70ea7e9 Update msg 2021-07-29 16:26:33 +05:30
Rishabh Saxena
96615e11b6
Fix xss redirectURL (#6229) 2021-07-29 08:49:46 +00:00
Rishabh Rathod
76dfcd0163
[Feature] Generate template page from datasource (#5513)
- Add Generate CRUD page feature
- Modify the Datasource card UI in the `INTEGRATION.ACTIVE` tab to directly delete and edit.
- Add `renderOption` , `errorMsg`, `isLoading` props in Dropdown component.
If `renderOption` prop is not defined, it will show default option UI.
- Add getDatasourcesStructure [new entity Selector]
( This will provide all fetched structure of datasources)

> Commit Messages ⬇️

* Show disabled GenPage Button for unsupported DS

* Add Icon in Select Table and Column dropdown

* Add Error message when datasource config has error

* Fix the continous loading state issue

* Add Not supported datasource in select Table

* Add ignoreCache when fetching DS struct

* Go to generate page if initiator=generate-page

* Fix connect new datasource button disabled

* Modify error message for invalid datasource struct

* Add snowflake to supported plugin for template

* Fix Show More option width

* Fix incorrect error msg for valid dS config

* Generate page UI improvements

* Refactor navigation

* Fix Datasource Card UX

* Remove semi-colon from Icon loader

* Refactor contants

* Add executeDatasourceQuery & fetchPluginForm API
- WIP google sheet form UI and functionality
- Implemented fetch all spreadsheet with mock data

* disable S3 and google sheet for generate page

* Update yarn.lock

* Resolve review comments
- Add Messages to `constants/messages`
- Add default value for `fetchActionsForPage` 2nd param
- Add comment
- Remove `onFinishCallback` from `handleFetchedPage`

* move string literal to constants/messages

* Remove hardcoded pluginId implementation

* Refactor getGenerateCRUDEnabledPluginMap selector

* Fix CreateAppInFirstListedOrg test command

* Add getIsGeneratePageInitiator helper func

* Fix Entity explorer Edit option test

* Fix CreateAppForOrg test command
- Add click on build from scratch in generatePage

* Fix deleteDatasource command test
- Click on Datasource Name to Edit, Datasource Card handles the click

* Fix DynamicLayout spec test issue

* Fix pageLoadSpec test

* Disable google plugin & Refactor
- Add useDatasourceOptions hook

* Add datasourceCardMenu in DatasourceEditor.json

* Fix issues
- Add Icon hover clickable control
- Auth API click handler

* Fix Createpage test command

* Add cypress test for generate page flow

* Fix cypress test

* Add Analytics

* Add comments in CloseEditor

* Rename initiator to isGeneratePageMode

* Disable S3 for generate CRUD page

* Fix generate page from existing datasource issue

* Enhance test to verify if data is fetched properly

* Wait for get Actions before execute actions

* Change the cypress route for excute api

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-29 13:43:10 +05:30
akash-codemonk
1fc6a21898
Fix overflowing text in toasts on safari (#6200) 2021-07-29 13:42:07 +05:30
Abhijeet
c8928d34ed
Remove autogenerate column from insert query for generate CRUD page from DB table (#6183)
* Removed autogenerated column reference from InsertQuery

* Disable page generation flow for layout with widgets

* Updated Template

* TCs modify for updated template application

* Allow column with only String datatype as a search column in SelectQuery

* Remove AtomicRef as not needed

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-07-28 13:14:04 +05:30
Rishabh Saxena
2b60519b7c Merge branch 'release-frozen' into release 2021-07-28 13:11:43 +05:30
Rishabh Saxena
8b4e9af1f0
[hotfix][release-frozen] Fix xss iframe source url (#6212) 2021-07-28 13:03:10 +05:30
Arpit Mohan
4d5b366c43
Merge branch 'master' into release-frozen 2021-07-28 12:59:51 +05:30
Rishabh Saxena
f4018f450e
Comments feature related fixes (#6156) 2021-07-28 12:32:11 +05:30
Abhijeet
8aebeb50dd
Add analytics event for self-hosted instances (#6198)
* Enable analytics event to get triggered for self-hosted instances

* Add conditional logic for analyticsRunner method
2021-07-28 12:15:48 +05:30
Pranav Kanade
e84b28e825
added another regex to support short youtube video link format (#6192) 2021-07-28 12:06:46 +05:30
Rishabh Saxena
bec7acdcfc
Fix iframe url xss (#6209) 2021-07-28 11:31:09 +05:30
Nidhi
2cb1aa3de1
Added validation for refactor name (#6165) 2021-07-28 11:19:23 +05:30
Nidhi
337e6b7682
Minor fixes on the Google Sheets plugin (#6188)
* Delete method messages #5302

* Delete method case sensitivity #5293
2021-07-27 16:43:34 +05:30
Nidhi
8d341a40a6
Setting ActionExecutionRequest in response from executed API call (#6147)
* Setting ActionExecutionRequest in response from executed API call

* Added logic during error state
2021-07-27 15:45:28 +05:30
Rishabh Saxena
8f4db40b0f [Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:44:54 +05:30
Rishabh Saxena
7fa2f7e038 [Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:39:45 +05:30
Rishabh Saxena
8638b6951a
[Bug] Update link to fetch tutorial doc (#6174) 2021-07-27 15:35:33 +05:30
Nidhi
4927f64262
Updated multipart dto (#6157) 2021-07-27 12:23:57 +05:30
Favour Ohanekwu
b3de24e3e1
changed texts on datasources page (#6130) 2021-07-27 07:15:49 +01:00
rahulramesha
10ff97b3dc
fix for tabelwidget filter bug (#6001)
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-27 10:48:52 +05:30
Satish Gandham
ee3890b4b4
[Perf] Increase the code editor debounce time from 300 to 600ms (#5914)
* - Increase the code editor debounce time from 300 to 1000ms

* Decrease the debounce time from 1000 to 600ms

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-07-27 10:46:02 +05:30
balajisoundar
f6ae3b2d84
Fix #6084: Fix alignment issue with multiselection checkbox when there are (#6123)
no rows present in the table
2021-07-27 10:33:13 +05:30
Nayan
8b1c5f486d
[Feature] Add filter in get comment threads (#6122)
* -added filter by resolved state in get comment thread API

* -add aggregation and lookup to fetch comment threads

* -added unit test for the repository aggregation method

* -reverted the aggregation lookup

* -add unit test for get all thread

* -removed unused method

* -resolved merge conflicts

* -skip hardcoded property value in query
2021-07-26 17:14:47 +00:00
Pranav Kanade
3547976dc7
[Feature] new nav sniping mode (#5746)
* added sniping mode toggle option to header

* added cover to components on hover in sniping mode

* fixed the transition time

* using filled icon

* Show dependencies in action pane

* Added a wrapper to make a widget snipeable

* removed older parts of sniping from Positioned Container

* removed onclick action from snipeable wrapper

* Showing widget name in different color

* Added a mechanism to send user to sniping mode from successful API screen

* created new property pane saga to bind the data

* Fix datasource list width issue

* Fix sidebar going out of view when the response is a table

* Minor refactor

* Show add widgets section on the sidebar

* Stop showing autocomplete option after adding a widget

* fetching pageId, appId from store

* Get suggested widget from response

* Fix table data not getting evaluated after adding binding

* Fix property pane going below the entity explorer while navigating from query/api pane

* Fix width of sidepane shifting for apis

* Fix vertical margins of connections

* Fix api pane suggested widget showing up for errors

* Fix margins

* can show select in canvas btn in sidebar

* can get the action object at the end to bind the data

* updated saga and action names

* can bind data to table

* Use themes

* Use new image url for Table widget

* Added conditional mapping for sniping mode binding.

* updated the widget name tags and seq of calls to open property pane

* pushed all sniping mode decoration to header

* moved setting sniping mode logic to editor reducer

* Added keyboard short cut to get out of sniping mode

* updated reset sniping mechanism

* removed a divider line

* if there are no relationships, will not show the complete section

* Connect Data will automatically show relevant tab in integrations

* Update list and dropdown image urls

* Remove create table button

* no wrapping bind to text

* minor review considerations

* showing the widget name to left in sniping mode

* can set data to datepicker

* will not show snipe btn if there are no widgets in canvas

* Changes for multiple suggested widgets

* removed dependency of sniping from suggested widgets

* Added analytics events for sniping mode

* logic for binding data to a widget, moved to snipeable component

* changed binding widget func from capture to onClick and took care of sniping from widget wrapper too.

* added tests to check sniping mode for table

* updated test spec

* minor fix

* Fix copy changes

* Update test to use table widget from suggested widget list

* if fails to bind will generate warning and keep user in sniping mode

* in sniping mode will only show name plate if it is under focus

* fixed the test case

* added a comment

* minor fix to capture on click event in sniping mode

* updated text

* Hide connections UI when there are no connections

* Increase width to 90%

* Show placeholder text and back button in sidepane

* Show tooltip on hover

* Add analyitcs events for suggested widgets and connections

* Update label based on whether widgets are there or not

* binding related changes

* renamed the saga file containing sinping mode sagas

* Changes for inspect entity

* Revert "binding related changes" temporarily

This reverts commit 54ae9667fecf24bc3cf9912a5356d06600b25c84.

* Update suggested widgets url

* Update table url

* Fix chart data field not getting evaluated

* a minor fix to show proper tool tip when user hovers on widget name

* Show sidepane when there is output

* Update locators

* Use constants for messages

* Update file name to ApiRightPane

* Remove delay

* Revert "Revert "binding related changes" temporarily"

This reverts commit ee7f75e83218137250b4b9a28fcf63080c185150.

* Fix width

* Fix overlap

Co-authored-by: Akash N <akash@codemonk.in>
2021-07-26 22:14:10 +05:30
NandanAnantharamu
10f37da2f0
Updated image spec (#6135) 2021-07-26 20:19:42 +05:30
yatinappsmith
54e81e4e33
Add tests for Propertypane drag and drop (#6131) 2021-07-26 19:20:17 +05:30
Pranav Kanade
109039c342
[Feature] Keep the scroll position into a widget when user switches to comment mode (#6132)
* updated the comment overlay to avoid widget re-rendering when user switches to comment mode

* removed duplicate code.
2021-07-26 18:43:20 +05:30
akash-codemonk
56e29d22f5
Add new nav related analytics (#6125)
Analytics events for the following have been added

- Create new datasource CTA on the property pane
- Run button at the response tab for actions
- Click on associated entity dropdown from the property pane
- Select an associated entity from the associated entity dropdown at the property pane
2021-07-26 16:29:15 +05:30
Nayan
667179d5a1
Stop creating bot comment thread when user is app viewer (#6111)
* -stop creating bot comment thread when user is app viewer

* -added comments to the method
2021-07-26 15:28:49 +06:00
Snyk bot
decd171b8f
fix: app/server/appsmith-server/pom.xml to reduce vulnerabilities (#5163)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-1015415
- https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1009832
- https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1296829
- https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORKSECURITY-1290497

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-07-26 08:39:13 +00:00
Snyk bot
652ad3506a
fix: app/server/appsmith-plugins/firestorePlugin/pom.xml to reduce vulnerabilities (#5864)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-IONETTY-1317097
2021-07-26 08:26:40 +00:00
Snyk bot
8428990cee
fix: app/server/appsmith-interfaces/pom.xml to reduce vulnerabilities (#6063)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-1015415
- https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-32236
2021-07-26 13:30:27 +05:30
Arpit Mohan
a99bb17c1a
Feature flags on the server (#5926) 2021-07-26 12:31:26 +05:30
Vicky Bansal
0e6ff2bebe
Fix-Keep date picker open when selecting time, month, year in Table widget filters (#5991)
Keep date-picker open when selecting time or changing month, year in Table filters, The user before this could not select or change time. We have fixed this by closing the date-picker popover onClick of outside overlay/canvas.
2021-07-26 12:29:53 +05:30
Abhinav Jha
1391b55bae
Widget Property Validation structure (#5270) 2021-07-26 11:20:46 +05:30
yatinappsmith
7573bbe661
Added mvn failure check (#6107) 2021-07-26 05:37:10 +05:30
Abhijeet
102e36ce95
Bugfix for generate page from db table, Analytics event after the successful CRUD page creation (#6087)
* Analytics datapoint after the successful page generation

* S3 bucket referenced from plugin specified template
2021-07-23 20:09:02 +05:30
Nayan
2c437a41e6
[Bugfix] Mark a comment thread as unread when there is a new comment in the thread (#6100)
* -mark thread as unread and unresolved when new comments added

* -added test
2021-07-23 19:30:36 +06:00
Sumit Kumar
f486be1979
fix data type appearing with data value for un-indentified types. (#6099)
* fix data type appearing with data value for types that JDBC does not internally map.
2021-07-23 17:07:25 +05:30
Rishabh Saxena
5f342cf042
[Fix] Minor omnibar updates (#6097) 2021-07-23 16:53:36 +05:30
arunvjn
3618b85595
Fixed slash button positioning (#6085) 2021-07-23 16:12:48 +05:30
Trisha Anand
f49e92f3dd Adding e.printStackTrace to errors in redshift as a hotfix (#6094) 2021-07-23 14:46:38 +05:30
Tolulope Adetula
fa76a9a6e9
fix: File picker disabled state (#5972)
The filepicker in the disable sate was still able to upload the file. Fixed the issue here.
2021-07-23 14:42:51 +05:30
Trisha Anand
a8df4ee010
Adding e.printStackTrace to errors in redshift as a hotfix (#6094) 2021-07-23 14:39:48 +05:30
Anagh Hegde
cef530e835
Add binding query to the suggested widget to improve the experience (#6016)
* Add binding query to the suggested widget to improve the experience

* Fix test failures

* Add comments and change as per review

* Move the query template to enum class

* Change Test cases as per review

* Remove unused methods from the test class

* Remove commented code

* Use proper attributes in binding query

* Refactor suggestWidget method to support node

* Add unit tests
2021-07-23 14:29:27 +05:30
Anagh Hegde
c82c518f60
[Bug] - Add check for duplicate name issue while creating mock data set (#6039)
* Add check for duplicate name issue while creating mock data set

* Fix Test failures
2021-07-23 13:34:03 +05:30
balajisoundar
0bd9753fef
Fix #5075 Retain search keyword and search results when user navigates (#6091)
away from homepage and comes back.
2021-07-23 13:01:16 +05:30
rahulramesha
f5e079f040
[Perf] prevent un-necessry re-renders of resizable Component on property control keyPress (#5885)
prevent un-necessry re-renders of resizable Component on property control keyPress
2021-07-23 12:10:39 +05:30
Abhijeet
9633d1e1c3
Add autogenerate field in datasource structure for each column (#6018)
* Added field to autogenerate values in DB column

* Added comment and refactor

* Autogenerate field update according to names instead of type for ArangoDB
2021-07-23 09:00:32 +05:30
Snyk bot
d8dcdb8323
fix: app/server/appsmith-server/pom.xml to reduce vulnerabilities (#6062)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-1015415
2021-07-22 23:23:45 +05:30
NandanAnantharamu
3d88ebf490 updated spec to wait for postexecute (#6042) 2021-07-22 20:14:01 +05:30
Abhijeet
a6c357ac16
Removed support for S3 and GSheets for generate CRUD page (#6076)
* Removed support for S3 and GSheets for now as FE code does not have support for these plugins yet

* Commented TCs for S3 and GSheets
2021-07-22 19:12:32 +05:30
Yash Vibhandik
a0c9ecb2a5
FIX #3229 : added new props shortcuts and closeOnSelection for smooth interactions (#5276)
In the date picker widget we now have an option to let the date picker popup remain open until the a positive feedback is given by clicking outside the popup or another widget. In other words the date-picker popup will not close where a date is selected with `closeOnSelection` disabled. 

We have also added an option to show date-picker shortcuts to the end user.
2021-07-22 18:16:41 +05:30
Hetu Nandu
6ed618306b Fix action binary transformation (#6075) 2021-07-22 17:34:24 +05:30
Hetu Nandu
9f89b0d42c
Fix action binary transformation (#6075) 2021-07-22 17:33:04 +05:30
Arpit Mohan
d7b258f474 Fixing duplicate enum in ActionExecutionSaga which may have been caused due to a bad merge 2021-07-22 16:20:05 +05:30
Apeksha Bhosale
8d844e3961
changed the logic for tern server def creation (#6071) 2021-07-22 16:19:41 +05:30
Nikhil Nandagopal
ee1c624426 Updated Template 2021-07-22 15:24:05 +05:30
Nikhil Nandagopal
fe71345768 Updated Template 2021-07-22 15:21:54 +05:30
Arpit Mohan
634092586b
Merge branch 'master' into release-frozen 2021-07-22 15:21:08 +05:30
Nikhil Nandagopal
5cc21dbe1d Updated Template 2021-07-22 15:19:39 +05:30
Abhijeet
886ed672ca
Extend backend support for S3 and Google Sheets plugin for generating page from DB table feature (#5997)
* Comments update

* S3 plugin support added

* Support for GSheet

* GSheet and S3 support, TCs update

* TC added for MongoDB datasource

* ilike opertor for SQL fixed

* Resolve merge conflicts

* Seperate template page for postgresql and other SQL datasources as there are minor changes in action bodies

* Added ListFiles query as on page load action, Insert all the columns from user's table in SelectWidget

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-07-22 14:24:22 +05:30
Bhavin K
c23925c0c9
handle image download error (#5951)
Fixed an issue where because of the CORS issue the image was not able to download, To fix this we now open the image in a new tab where an error is received.
2021-07-22 14:15:45 +05:30
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
Bhavin K
bd05ab5dc7
fix when component update (#5931)
The custom chart onDataPointClick did not function well in the editor and view more, This is now fixed
2021-07-22 14:11:18 +05:30
Pranav Kanade
22bec1fce7
[Feature] Authenticated API datasource creation (#6017)
* added an oauth datasource tab

* added a comment

* removed warnings

* updated authenticated datasource name

* added a test case to verify new authenticated api card

* can create a simple rest api datasource

* enabled the use of view mode for rest api datasources

* minor fix for centered icons

* added analytics event
2021-07-22 13:25:13 +05:30
akash-codemonk
f1e829fe4a
Feature: Show error state in property pane connections if associated connection has errors (#5877) 2021-07-21 18:10:46 +05:30
Abhijeet
597a53c4d5
[Bug] Fix for immutable map in analytics service (#6051)
* Updates are made on local Map to avoid ImmutableCollection issue in analytics service
2021-07-21 17:39:53 +05:30
NandanAnantharamu
2477c1f5ac
updated spec to wait for postexecute (#6042) 2021-07-21 16:02:40 +05:30
Nayan
5970d06164
[Improvement] Update the positioning parameters for bot threads (#6036)
* -updated the position field for comment threads

* -use default origin header when origin header not present in comment email
2021-07-21 15:24:39 +06:00
akash-codemonk
89000efffd
Fix: Fix horizontal scroll on overflow in property pane (#5909) 2021-07-21 13:23:14 +05:30
Nayan
5261f782df
Fixed comment missing issue when user role is changed (#5898)
* -fixed comment missing issue when user role is changed

* WIP: add test for policy utils

* -added test for policy utils comment permission when users are added or removed

* -removed unused code

* -removed public access modifier for an internal function

* -add test to verify comment thread policy updated when user role changed in organization

* -add tests for add user and remove user from organization to test comment thread policies
2021-07-21 12:30:34 +06:00
Rishabh Saxena
cf1e5dda19 Fixes related to the comments feature (#5904) 2021-07-21 11:34:57 +05:30
Hetu Nandu
7063ee9d2d
Improve information for cyclic dependency error (#5949) 2021-07-20 16:20:22 +05:30
Rishabh Saxena
745927ffef
Set focused comment based on url and visible thread id (#5992) 2021-07-20 15:44:35 +05:30
Hetu Nandu
ba06d797de
Improve autocomplete sorting (#5798) 2021-07-20 15:32:56 +05:30
Arpit Mohan
16c509d9bd Locking mongo Docker container to 4.4.6 (#5950)
Mongo v5 has some issues with seeding data. Refer:  https://stackoverflow.com/questions/68392064/error-when-running-mongo-image-docker-entrypoint-sh-line-381
Hence, locking the mongo version to a known working tag till we have more information on the problem.
2021-07-20 12:56:30 +05:30
Satish Gandham
93c675ba92
Provent property pane title from re-rendering on every state change #5867 (#5876)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-07-20 12:14:15 +05:30
Tolulope Adetula
32c746d6fe
fix: Menu button truncating (#5970)
The widget tag of menu button widget was broken and overflowing, We fixed that here
2021-07-20 12:09:17 +05:30
Arpit Mohan
9f29dd028d
Improving error message for invalid entities (#5977)
Also removing the toast message for successful action runs. With the debugger, this is no longer required.
2021-07-20 11:07:20 +05:30
Vicky Bansal
6f91c1afd8
Feature/draggable filters in table widget (#5886)
The filter pane in the table widget was fixed to top which would hinder the viewport for the end user. We have now changed the filter pane to a draggable component such that the user can place it anywhere on the canvas while they apply filters to see data change in realtime.

* FEATURE #4088 : added draggable filterpane for table widget

* FEATURE #4088 : update icons, editMode prop and added renderDragBlock support in popper

* FIX #5329: added close button for close filter pane

* FIX #5332 : updated zindex for table filter pane

* fix list widget test

* Fix drag icon position and cypress failing tests

* Fix endsWidth comparator function
2021-07-20 10:48:58 +05:30
Satish Gandham
fb78233973
[perf] Update redux store with only the values that changed (#5594)
* Pass evaluation order along with dataTree and update only evaluated values in the store.

* - Update the entire changed entitiy

* Make the updates in a way the top level tree reference is changed.

* Clean up.

* - Revert back to using evaluation order and removedPaths as JSON.stringify is expensive

* yarn.lock changes

* Only send eval updates across the worker thread

* - Update the tree with only the updates sent from the worker. (40% improvement)

* Fix evaluation tests

* Remove console.log

Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-07-20 10:34:12 +05:30
akash-codemonk
8657a52f09
Fix: Fix create new query in onsubmit not creating a query for onboarding (#5918) 2021-07-20 09:44:32 +05:30
Anagh Hegde
ed7e4457fe
Bug - Fix page order sorting (#5971)
* Use the order from Application object

* Fix the bug in test cases
2021-07-20 09:09:20 +05:30
Nayan
6efe78479f
[Enhancement] Add link to unsubscribe from email notification for a comment thread (#5769)
* -added API to and template for unsubscribe  comment thread

* -changed public API url to make it sepratate from client public pages
-included the unsubscribe link to email body

* -made unsubscribe email notification API to private

* -added unsubscribe page

* -removed unused code

* Update app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Comments/UnsubscribeEmail_spec.js

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/client/src/pages/common/UnsubscribeEmail.tsx

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/client/src/pages/common/UnsubscribeEmail.tsx

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/BaseAppsmithRepositoryImpl.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* -updated text as per lint error

* -updated text as per lint error

* -moved unsubscribe screen texts to messages.ts

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-07-20 00:14:38 +06:00
Ayush Pahwa
9560df8492 Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 21:07:44 +05:30
Trisha Anand
f5c8f643a7 [Bug Fix : Rest Api] Base64 encode binary response before sending it out to client (#5958)
* 1. For binary data in the response, base64 encoding the same before sending it out on the wire (instead of default conversion to string)
2. Added a new header which sets the data type of the response body.

* Minor code reformatting

* Fixed failing test cases

* The new header created should send the values in an array instead of a single value
2021-07-19 21:07:36 +05:30
Ayush Pahwa
2cee1b5a7c Added axios call to the special use case of downloading zip files (#5927)
* Added axios call to the special use case of downloading zip files

* Removed console logs, added comments, fixed error handling

* Removed url check from getType, exported a fn to check tif string is a URL

* Changed filter from only zip to binary
2021-07-19 21:07:21 +05:30
Ayush Pahwa
5f950c4080 Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 21:03:49 +05:30
Trisha Anand
13bd8776ce [Bug Fix : Rest Api] Base64 encode binary response before sending it out to client (#5958)
* 1. For binary data in the response, base64 encoding the same before sending it out on the wire (instead of default conversion to string)
2. Added a new header which sets the data type of the response body.

* Minor code reformatting

* Fixed failing test cases

* The new header created should send the values in an array instead of a single value
2021-07-19 21:02:26 +05:30
Rishabh Saxena
25a6fd2240
Fixes related to the comments feature (#5904) 2021-07-19 20:58:41 +05:30
Nayan
5185a0af5c
Log analytics event when comment created (#5953)
* -log analytics event when comment created

* -mocked analytics for comment tests

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/services/CommentServiceImpl.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-07-19 20:45:37 +06:00
Ayush Pahwa
cab6c12471
Added filter for new header and doing atob on the response (#5974)
* Added filter for new header and doing atob on the response

* Added check for status code 200

* Added const vars, added condition of 200 and action type API

* Added comments, NPE check for headers
2021-07-19 20:13:37 +05:30
Trisha Anand
1dfc624a13
[Bug Fix : Rest Api] Base64 encode binary response before sending it out to client (#5958)
* 1. For binary data in the response, base64 encoding the same before sending it out on the wire (instead of default conversion to string)
2. Added a new header which sets the data type of the response body.

* Minor code reformatting

* Fixed failing test cases

* The new header created should send the values in an array instead of a single value
2021-07-19 19:29:19 +05:30
Rishabh Saxena
488e7e20df [Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 19:02:40 +05:30
Rishabh Saxena
7f95e4d268 Enable intercom for self hosted instances (#5871) 2021-07-19 19:02:06 +05:30
Rishabh Saxena
dff61da5ac [Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 18:56:08 +05:30
Rishabh Saxena
6947f4b7a0
[Fix] Fix mouse click for the autocomplete at the api pane (#5929)
* Set editor height in compact mode when not in focus
2021-07-19 17:36:04 +05:30
Rishabh Saxena
dc012be1de
Enable intercom for self hosted instances (#5871) 2021-07-19 15:34:15 +05:30
NandanAnantharamu
d80bb7a31b
Fix checkbox spec Cypress test (#5952) 2021-07-19 15:28:34 +05:30
Anagh Hegde
d5d6c3fa9c
Feature/page order API refactor (#5799)
* Refactor Page order API - Instead of the order filed use the Order persistency in Array offered by Mongo

* Add migration script to remove the order filed from the Application Pages

* Change unit tests as per the new implementation

* Fix indentation issues

* Compute pages based on the view mode

* Removed order field in response and changed the page order API response to List of pages instead of the application object

* Remove the Order filed from the Response class

* Use the $push instead of $addToSet to maintain order of pages in array
2021-07-19 15:12:29 +05:30
Arpit Mohan
9a4b9c27cd
Locking mongo Docker container to 4.4.6 (#5950)
Mongo v5 has some issues with seeding data. Refer:  https://stackoverflow.com/questions/68392064/error-when-running-mongo-image-docker-entrypoint-sh-line-381
Hence, locking the mongo version to a known working tag till we have more information on the problem.
2021-07-19 13:39:37 +05:30
Abhijeet
db0445c64a
Fix failing server testcases (#5948)
* Add constructor in AnalyticsService
2021-07-19 13:04:59 +05:30
Abhijeet
bf9257d543
Refactor analytics events to encrypt or remove sensitive information (#5920)
* Applied encryption for self-hosted instances username field, removed sensitive fields from request

* Request field added for Appsmith cloud instance

* Config variables moved to a central file
2021-07-18 15:18:11 +05:30
Ayush Pahwa
4a06a57cda
Added axios call to the special use case of downloading zip files (#5927)
* Added axios call to the special use case of downloading zip files

* Removed console logs, added comments, fixed error handling

* Removed url check from getType, exported a fn to check tif string is a URL

* Changed filter from only zip to binary
2021-07-17 20:26:06 +05:30
Nayan
ac654d754f
Fix datetime parsing error in notifications (#5893)
* -fix datetime parser exception in comment thread notifications

* -resolved merge conflicts
2021-07-17 16:26:30 +06:00
Trisha Anand
5232e1faee Merge branch 'master' of https://github.com/appsmithorg/appsmith 2021-07-16 20:29:52 +05:30
Trisha Anand
189f4a9069 Adding timeout on execution of postgres and ms sql actions (#5922) 2021-07-16 20:29:16 +05:30
Trisha Anand
ede0df21bc
Adding timeout on execution of postgres and ms sql actions (#5922) 2021-07-16 20:24:18 +05:30
Pranav Kanade
3f34ce08e3
[Fix] Hide binding prompt if auto complete is open (#5911)
* temp

* hiding binding prompt if auto suggestion box is open

* slash btn click works in api pane

* removed unnecessary code
2021-07-16 18:02:48 +05:30
Tolulope Adetula
82d887338a
fix: update JS options (#4475)
Add JS options to widget properties, please check the issue for more details
2021-07-16 17:59:53 +05:30
Paul Li
b6703ebe11
BUG-4058 : Inconsistence in the meta properties fallbacks in widgets (#4167)
Datepicker selected data and formatted date will not be empty on clear and not fallback to default date. This is consistent with other widget behaviour
2021-07-16 17:56:39 +05:30
Abhijeet
c5a909ddc8
Google sheet APIs for getting all the spreadsheet, getting all sheets within spreadsheet and column headers (#5875)
* API to run DB query using plugin specified templates

* Included get spreadsheet metadata in get info method

* Added TCs for checking Spreadsheet info response

* Added error message for invalid datasources

* Authentication check for datasource modified to AuthenticationStatus field
2021-07-16 16:15:29 +05:30
Anagh Hegde
3a4de769ee
Call the WidgetSuggestion method before processing data types. (#5907) 2021-07-16 15:40:27 +05:30
Trisha Anand
bfaf856c16
Merge branch 'master' into release-frozen 2021-07-16 14:41:33 +05:30
Rishabh Saxena
8f7165b5fe
Update comments onboarding tour (#5903) 2021-07-16 14:01:26 +05:30
Bhavin K
374e8aec4a
datepicker 2 migration 27 added, default response udpated (#5393)
Default Min and Max Date were showing errors, We have fixed it now. This was specific to safari
2021-07-16 12:34:11 +05:30
akash-codemonk
4ddc430411
Fix: Hide connect data cta for certain widgets (#5690) 2021-07-16 09:40:17 +05:30
akash-codemonk
57903ec88c
Fix: Increase initial height for bottom tabs in action screen (#5894) 2021-07-16 09:39:51 +05:30
Nayan
8fcbb6e4c1
Add a bot thread when someone adds first comment or tags someone is the comment for the first time (#5521)
* resolved conflicts

* -fixed some issues in PR

* -used sequence in generating thread number

* -refactored the create thread method

* -refactored comment service

* -add bot reply to the first comment thread of an user

* -added a new bot thread when user resolves the first bot thread

* -handle the case when user data can be absent

* -add organization id and widget type to comment and comment threads

* -resolved conflicts

* -mark appsmith bot username as a tagged user in the bot comment

* -turn a private thread to a public thread when someone is tagged in it

* -updated as per the review comments

* -fixed compile error in unit test

* -updated as per PR review comments

* -removed commented code
2021-07-15 23:45:08 +06:00
Pranav Kanade
56caba8f55
[Fix] Support Videos in omnibar (#5873)
* replacing gitbook video embeddings with iframes for youtube videos

* changed func names

* using single regex to select video id and remove embedding
2021-07-15 22:50:21 +05:30
Hetu Nandu
7efc96efd2 Fix code editor width issue (#5895) 2021-07-15 21:18:03 +05:30
Hetu Nandu
855acc4e37
Fix code editor width issue (#5895) 2021-07-15 21:10:26 +05:30
arunvjn
c2ecfa94b3 Fix for slash commands blocker issues
(cherry picked from commit 6c0da9a380)
2021-07-15 20:10:48 +05:30
arunvjn
6c0da9a380
Fix for slash commands blocker issues 2021-07-15 20:08:31 +05:30
Trisha Anand
b8eb2f1aa5
Adding support for explicit data type casting in postgres prepared statement (#5842)
* Adding support for explicit data type casting in postgres prepared statement

* Added text and int psql data types for support in explicit typecasting

* Documenting the code
2021-07-15 19:33:32 +05:30
Vicky Bansal
fad7874613
Currency datatype in Input Widget (#5049)
Added currency type input to input widget
2021-07-15 18:20:01 +05:30
Rishabh Saxena
cb91221276
Fix globalsearch test: wait for page load (#5883) 2021-07-15 17:10:54 +05:30
yatinappsmith
d8e2488a9b
Disabled maven Tests (#5882) 2021-07-15 16:45:53 +05:30
rahulramesha
3042adbdea
Task/5463 Navigation Bar menu Dropdown (#5575)
* Feature/ Navigation Bar menu

* Cypress test fixes and minor style changes

* Changed some more integration test files and fixed some styling post feedback

* Updated failing tests

* Minor Cypress test change

* requested design changes and Analytics

* resolving conflicts

* minor style fix

* current deploy verbage change

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>

* addressing review comments

* Updating discord link with permanent invite

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-15 16:26:18 +05:30
Anagh Hegde
f169c8c5a0
Add login mode to track for analytics purpose (#5870) 2021-07-15 14:36:57 +05:30
Ashok Kumar M
ccf017be12 Fix: Stop page DSL updates in view mode. (#5843) 2021-07-15 13:03:54 +05:30
akash-codemonk
794ef1bbd6
Fix: Fix bugs related to debugger errors (#5824) 2021-07-15 12:44:42 +05:30
Hetu Nandu
fd612829a2 Revert back to old way of eval (#5851)
This change was introduced in #4446 and #5034
2021-07-15 12:11:18 +05:30
Hetu Nandu
da67128e80 Only add appsmith functions in global scope during trigger evaluation (#5760) 2021-07-15 12:11:01 +05:30
hetunandu
3cc145cd55 Revert "Revert back to old way of eval (#5851)"
This reverts commit a24e0b180a.
2021-07-15 12:04:46 +05:30
hetunandu
e751313b14 Merge branch 'release-frozen' of https://github.com/appsmithorg/appsmith into release-frozen 2021-07-15 11:40:39 +05:30
lifeneedspassion
95d5557749
Add UTF-8 encoding in the RestApiPlugin for all invocations
The default charset is determined during virtual-machine startup and typically depends upon the locale and charset of the underlying operating system (#5788)

Co-authored-by: 王昆 <quincy@cloudtogo.cn>
2021-07-15 11:36:18 +05:30
Anagh Hegde
3d7c0c0017 Suggest List of possible widgets and add exception handling (#5800)
* Add try catch block to handle the data conversion exception

* Suggest widget only in edit mode

* Add JsonNodeType to the widget suggestion logic

* Use ClassCastException instead of generic exception

* add tests for the array data type

* Suggest list of possible widgets instead of one

* Use constant in if condition to avoid possible NPE
Fix typo

(cherry picked from commit 99a06728d4)
2021-07-15 11:34:58 +05:30
Hetu Nandu
a24e0b180a Revert back to old way of eval (#5851)
This change was introduced in #4446 and #5034
2021-07-15 11:30:45 +05:30
Pranav Kanade
8f2e913bc9
[Fix] Query editor fields get appended when switching between Mongo and other SQL Datasource queries. (#5863)
* added a unique key to field wrapper for query editor

* removed a log
2021-07-15 11:02:11 +05:30
Hetu Nandu
a5187aadd5
Revert back to old way of eval (#5851)
This change was introduced in #4446 and #5034
2021-07-15 10:29:04 +05:30
Sumit Kumar
50ae200350
Fix: fix read only option for postgres connection (#5848)
* fix read only option for Postgres connection.
2021-07-15 09:55:35 +05:30
Ayush Pahwa
d54f5b01ca
Updating the URL object in appsmith global object when the pageid is same as the previous one (#5796) 2021-07-14 23:48:21 +05:30
Anagh Hegde
99a06728d4
Suggest List of possible widgets and add exception handling (#5800)
* Add try catch block to handle the data conversion exception

* Suggest widget only in edit mode

* Add JsonNodeType to the widget suggestion logic

* Use ClassCastException instead of generic exception

* add tests for the array data type

* Suggest list of possible widgets instead of one

* Use constant in if condition to avoid possible NPE
Fix typo
2021-07-14 22:25:13 +05:30
Ashok Kumar M
1ed8c4f587
Fix: Stop page DSL updates in view mode. (#5843) 2021-07-14 22:00:10 +05:30
Nikhil Nandagopal
ce38354b41 Updated Template 2021-07-14 17:40:45 +05:30
rahulramesha
9ff4ad7e8a
Fix/5077,5079,5739,5879 video widget name fix (#5823)
remove overriding of shouldComponentUpdate

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
2021-07-14 16:50:22 +05:30
yatinappsmith
5edd9d0fdb
Wait for server to start before Cypress tests (#5846) 2021-07-14 16:40:48 +05:30
hetunandu
dcfb8f6e48 Revert "Revert back to old way of eval"
This reverts commit ca54f9f21b.
2021-07-14 16:19:01 +05:30
hetunandu
ca54f9f21b Revert back to old way of eval 2021-07-14 16:18:28 +05:30
Nidhi
597033e623
Modified error message and code for authentication failure (#5810) 2021-07-14 11:36:25 +05:30
Nidhi
4f42c29f95
Ignore comments while preparing executable statement in MySQL plugin (#5838)
* Ignore comments while preparing executable statement in MySQL plugin

* Added tests
2021-07-14 11:36:10 +05:30
akash-codemonk
092622e26f
Fix: Reduce initial height of bottom tabs in api/query (#5836) 2021-07-13 19:07:54 +05:30
Hetu Nandu
52311e8944
Only add appsmith functions in global scope during trigger evaluation (#5760) 2021-07-13 18:27:59 +05:30
Hetu Nandu
f0a7a5ab02 Fix top level parallel runs (#5613) 2021-07-13 17:10:10 +05:30
akash-codemonk
41aeaf448d
Fix: Update incorrect type to handle undefined sentry error (#5694) 2021-07-13 15:23:02 +05:30
Sumit Kumar
9c2ac9f26a
Feature: add support in Redis plugin to select database when creating db connection. (#5807)
* add support in Redis plugin to select database when creating db connection.
* refactor code to use URI string instead of constructor call, because of lack of appropriate constructor.
* add TCs.
* fix validate datasource.
2021-07-13 15:22:08 +05:30
Paul Li
560db4d4df
Menu button widget (#5334)
* FEATURE-3261 : Menu Widget

-- Perform initial onboarding of the widget, not completed

* FEATURE-3261 : Menu Widget

-- Create a menuItemsControl
-- Create the first MVP of IconSelectControl

* FEATURE-3261 : Add Menu Widget

-- Align add menu item button to the center
-- Build icon select control with a grid popup

* FEATURE-3261 : Menu Widget

-- Create a icon alignment control
-- Complete the property pane of the widget

* FEATURE-3261 : Add Menu Widget

-- Implement the body of the widget
-- Bind into the properties from property pane

* FEATURE-3261 : Menu Widget

-- Fix the issues from the first feedback

* FEATURE-3261 : Menu Widget

-- Fix on the 2nd feedback

* FEATURE-3261 : Menu Widget

-- Fix on issues from IconSelectControl, IconAlignControl

* FEATURE-3261 : Menu Button Widget

-- Rename Menu to MenuButton, accordingly refactoring the relevant codes
-- Change some help content
-- Change styles for icon select control, adding padding for search box

* FEATURE-3261 : Menu Button Widget

-- Bind isDisabled property into the UI
-- Prevent input text of menu item from overflowing
-- Add tooltip feature for icon select control
-- Set the height of the popover content dynamically

* FEATURE-3261 : Menu Button Widget

-- Use POPOVER2_TARGET class name for styling
2021-07-13 13:35:09 +05:30
Rishabh Saxena
bb14742051
[GlobalSearch Results] Update sorting order based on the index of the query (#5543) 2021-07-12 21:14:40 +05:30
Ayush Pahwa
d5a2285c9f
Fix: Value of API's data is different in widgets and entity explorer. Showing curly brackets when empty data is received (#5646)
* Showing curly brackets when empty data is received

* Added type protection for the statement
2021-07-12 17:01:02 +05:30
Ayush Pahwa
06de06c11f
Improved label, updating navigateTo default prams when action type is changed to navigateTo in JS actions (#5532)
* Updating navigateTo default prams when action type is changed to navigateTo

* Gave default value to url, made the query params defaault to empty object rather than the empty curly braces with single quotes
2021-07-12 13:22:27 +05:30
Nikhil Nandagopal
2dba1558e6
removed chat with us for self hosting since we killed github discussions (#5767) 2021-07-10 15:31:53 +05:30
Rishabh Saxena
91e5a5a911
Dont enable comment mode if deactivated (#5766) 2021-07-10 12:50:28 +05:30
Sumit Kumar
727f4aa4b3
Feature: return hint message to user if the expected content type is json but the api response is not a valid json. (#5666)
* return hint message to user if the expected content type is json but the api response is not a valid json.

Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-07-09 22:31:50 +05:30
Yash Vibhandik
c7577a23f0
FIX #4676 : added onclick handler and update property pane config to table widget for column type image
added onclick handler and update property pane config to table widget for column type image

* added default value for onclick and remove extra check

* updated TableUtilities test case

* updated cypress test Table_spec
2021-07-09 17:51:51 +05:30
Vicky Bansal
195d3deea7 Support for Google reCaptcha v2 in Button Widget (#5638)
* Handle google recaptcha v2 in button component

* Use same code for recaptcha v2 and v3

* Updated error handling comments

* Added toggle to use google recaptcha v2 with button

* Create separate components for Google recaptcha v2 and v3

* Extract click function from google recaptch v3 component

* Hide recaptcha error badge and show invalid site key error on button key

* Fix isInvalidKey name

(cherry picked from commit 718c257286)
2021-07-09 15:56:31 +05:30
Confidence Okoghenun
f5f73b47c6
Adds YT Setup Videos to Docs (#5744) 2021-07-09 15:54:34 +05:30
Nidhi
193f20ad7a
Redirecting to view mode of datasource after authorization (#5758)
* view mode true

* removed new query btn from view mode for google sheet datasource

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-09 15:13:54 +05:30
Nayan
45198c7d68
Increased maximum image size to be uploaded as profile picture (#5641)
* -increased max image size to upload as profile picture

* -removed unnecessary changes

* -show message on maximum allowed file size
2021-07-09 15:38:14 +06:00
Somangshu Goswami
ad840bb8b4
Change the default object fit property of image widget to contain (#5696)
* Change the default object fit property of image widget to `contain`
2021-07-09 13:35:14 +05:30
NandanAnantharamu
763f9ac77c
Fixing Flaky tests (#5578)
* Fix flaky Org tests

* updated log spec

* Removed unwanted calls
2021-07-09 12:41:07 +05:30
akash-codemonk
0f96469e03 Add try/catch (#5731) 2021-07-09 12:30:53 +05:30
akash-codemonk
45276c9e56 Analytics for debugger errors (#5660) 2021-07-09 12:30:45 +05:30
Hetu Nandu
0f32cf10b6 Handle exception where prepared statements viewer does not get a value (#5531) 2021-07-09 12:17:46 +05:30
NandanAnantharamu
eea53bc1e0
Fix image widget spec for property pane click changes (#5707) 2021-07-09 10:22:57 +05:30
Pranav Kanade
8e3c630c20 on google sheet deletion success, redirecting user to active datasources (#5748)
(cherry picked from commit 75eff29b03)
2021-07-09 10:14:00 +05:30
Pranav Kanade
75eff29b03
on google sheet deletion success, redirecting user to active datasources (#5748) 2021-07-09 09:43:18 +05:30
akash-codemonk
5e39c75d9b
Add try/catch (#5731) 2021-07-08 18:14:31 +05:30
dependabot[bot]
aafefe8ce9
Bump hibernate-validator in /app/server/appsmith-interfaces (#4937)
Bumps [hibernate-validator](https://github.com/hibernate/hibernate-validator) from 6.0.18.Final to 6.0.20.Final.
- [Release notes](https://github.com/hibernate/hibernate-validator/releases)
- [Changelog](https://github.com/hibernate/hibernate-validator/blob/6.0.20.Final/changelog.txt)
- [Commits](https://github.com/hibernate/hibernate-validator/compare/6.0.18.Final...6.0.20.Final)

---
updated-dependencies:
- dependency-name: org.hibernate.validator:hibernate-validator
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-07-08 18:12:58 +05:30
Vicky Bansal
718c257286
Support for Google reCaptcha v2 in Button Widget (#5638)
* Handle google recaptcha v2 in button component

* Use same code for recaptcha v2 and v3

* Updated error handling comments

* Added toggle to use google recaptcha v2 with button

* Create separate components for Google recaptcha v2 and v3

* Extract click function from google recaptch v3 component

* Hide recaptcha error badge and show invalid site key error on button key

* Fix isInvalidKey name
2021-07-08 17:32:08 +05:30
Nikhil Nandagopal
4ffeca4a56 Updated Template 2021-07-08 17:26:49 +05:30
Rishabh Saxena
0a0cbec488 Filter out undefined values from the recent entities array (#5724) 2021-07-08 16:13:58 +05:30
Bhavin K
f471a269b1
Feature/image rotation (#4674)
Developers now have the control to allow users to rotate or download image. These settings are available in the property pane.
2021-07-08 16:10:22 +05:30
Rishabh Rathod
c27974b2a2
Replace pluginName with packageName in mockDB creation (#5720)
* replace pluginName with packageName in mockDB creation

* Replace pluginName with packageName

Co-authored-by: Anagh Hegde <anagh@appsmith.com>
2021-07-08 16:03:41 +05:30
Rishabh Saxena
499fe6fe9b
Filter out undefined values from the recent entities array (#5724) 2021-07-08 15:59:59 +05:30
Tolulope Adetula
814823aab8
fix: filterable default value (#4657)
The enable filter switch in the select widget property pane shows up as false but the widget component shows it. Fixed.
2021-07-08 15:53:12 +05:30
Rishabh Saxena
525367fdb0 Add null checks for recent entities (#5722) 2021-07-08 15:43:36 +05:30
Rishabh Saxena
c4d3160fd6
Add null checks for recent entities (#5722) 2021-07-08 15:21:28 +05:30
Nikhil Nandagopal
6bcb7c2f62 Updated Template 2021-07-08 14:40:50 +05:30
Shrikant Sharat Kandula
37db1ef376
Fix new user event being fired on every login (#5675) 2021-07-08 13:51:00 +05:30
Pranav Kanade
f28b9bd20b
[Fix] create new api not working from saved google sheet state (#5681)
* fix show proper icons for queries

* Using query creation action creator for google sheet

* Properly setting up action config, if data source is of type api

* minor loading state fixed

* fixed warnings

* Handling the action for apis as well

* Re introduced the new query btn for google sheets
2021-07-08 12:47:56 +05:30
Pawan Kumar
b0a6cc87dd
Widget Context Menu (#5698)
* Cut copy paste first cut

* removed different parent groups logic

* mouseup on the outer canvas removes selections.

* bug fix

* remove unwanted dead code.

* Adding tests

* build fix

* min height fixes

* fixing specs.

* fixing specs.

* fix merge conflcits

* fix border positioning

* fix canvas widgets incorrect bouding box

* fix bounding box position issue

* fix bounding box position issue

* fix

* border issue fix

* update test case

* add colors in theme

* use layers + use click capture on actions

* fix overflow issue in contextmenu in containers

* fix context menu display issue

* update position of context menu

* fix container box-shadow issue

* fix container box-shadow issue

* revert container box shadow

* stop opening of property pane on shift clicking a widget

* remove console.log

* fix multiselect box issue

* fix list widget overflow issue

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-07-08 12:38:42 +05:30
Hetu Nandu
0c0e165ee0
Improve Codemirror mount performance (#5497) 2021-07-08 12:34:47 +05:30
Nikhil Nandagopal
3ad73cd2c7 Updated Template 2021-07-08 12:01:12 +05:30
Pawan Kumar
f19102d997
Widget Grouping Context Menu (#5284)
* Cut copy paste first cut

* removed different parent groups logic

* mouseup on the outer canvas removes selections.

* bug fix

* remove unwanted dead code.

* Adding tests

* build fix

* min height fixes

* fixing specs.

* fixing specs.

* fix merge conflcits

* fix border positioning

* fix canvas widgets incorrect bouding box

* fix bounding box position issue

* fix bounding box position issue

* fix

* border issue fix

* update test case

* add colors in theme

* use layers + use click capture on actions

* fix overflow issue in contextmenu in containers

* fix context menu display issue

* update position of context menu

* fix container box-shadow issue

* fix container box-shadow issue

* revert container box shadow

* stop opening of property pane on shift clicking a widget

* remove console.log

* fix multiselect box issue

* fix list widget overflow issue

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-07-08 12:00:19 +05:30
Nikhil Nandagopal
fb35594bf2 Updated Template 2021-07-08 11:59:20 +05:30
Anagh Hegde
0154017836
Refactor Get mock-data set API (#5620)
* Call cloud services to fetch mock datasets

* Call cloud services to fetch mock datasets

* Change the MockData Config,

* Remove unused import statements and fix small indentation issues

* 1. Moved the mock data creation and fetching to a separate class
2. Added plugin type to mockdata class
3. Used pluginName to identify the db type
4. Removed the block call mock data creating method
5. Added unit tests for the mockdata

* 1. Removed unused field from contract and
2. Updated the url to cloud service

* 1. renamed the field of mockdata contract
2. Updated the test cases

* using new mock datasources apis

* 1. Added the Cloud Service release end point to env variable

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-07-08 11:29:11 +05:30
Trisha Anand
18fa47e2b4
Taking Smart Substitution for Mongo out of Beta (#5650) 2021-07-08 11:25:53 +05:30
akash-codemonk
1265105970
Analytics for debugger errors (#5660) 2021-07-08 11:01:08 +05:30
Abhijeet
07944f214b
Provide API for MongoDB datasource to generate page from DB table feature (#5590)
* Template application updated to include separate page for MongoDB as a datasource

* Support for mongoDB as datasource added

* Added comments

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
2021-07-08 07:18:23 +05:30
Rishabh Saxena
93ec3c17c3
Init and update unread comment threads count and show indicator (#5674) 2021-07-07 20:43:44 +05:30
Nayan
500efb0dd7
Updated plugin logos from png to svg (#5671)
* -updated svg logo for plugins

* -added svg logo for ArangoDB plugin
-used MongockTemplate instead of MongoTemplate in the db migration
2021-07-07 20:02:59 +06:00
Pranav Kanade
f2325b6436
[Bug] Slash command in query pane (#5665)
* For query/api pane `/` command will be triggered only if user manually types `/`

* muting the / command for params inputs

* on button click the auto suggestion has to open

* removed a log
2021-07-07 19:01:40 +05:30
Aswath K
2c6e8a388e
Shows 'last saved' time on hovering over the 'saved' icon (#5092) 2021-07-07 18:17:01 +05:30
Abhijeet
de511e47f6
Bugfix OAuth2.0 datasource authentication for import export application feature (#5658) 2021-07-07 17:49:16 +05:30
Vicky Bansal
c9b7a8646c
Fix widgetName when copy/paste table widget (#5607)
Column definition truncate issue on copying table is fixed
2021-07-07 17:41:09 +05:30
Vicky Bansal
c95f18b0d2
Add required option to Rich Text Editor for validations when used with Form widget (#5330)
* Added support to make rich text editor as require field

* Add default value of isRequired property for Rich Text Editor widget

* change isValid derived property to iffee functions value

* Converted isValid computation to use simple ternary operator
2021-07-07 17:39:15 +05:30
Pranav Kanade
24b954649b
[Fix] New nav UI improvements (#5659)
* removed access space between tab icons and text

* added more space around new datasource cards

* fixed spacing issues around the new data sources sections

* removed logs

* updated the contrast of show more

* added + btn to all add new

* fixing height of the editor components to accommodate back btn
2021-07-07 15:52:42 +05:30
Hetu Nandu
83af4d372d
Fix top level parallel runs (#5613) 2021-07-07 15:29:44 +05:30
Bhavin K
4b932089a5
Feature: Line separator widget (#4954)
* basic line widget setup

* rename to divider, added icon

* completed divider functionalities

* minor textual updates

* cypress test for divider widget

* tested on local cypress run

* Divider widget jest tests

* basic logic implemented

* arrow head better alignment

* added required svg icons

* divider widget props update

* fix on propertypane dropdown iconSize

* fix capside icon width in property panel

* updated cypress dsl and tests

* minor updates

* cap arrow new implementation

* remove hover animation from divider icon

* updates and optimizations

* moved test class to component
2021-07-07 15:00:06 +05:30
Nayan
eb557035b2
Added new API to get unread comment thread count (#5429)
* -added new API to get unread comment thread count

* -changed query to get unread comments so that it only searches where user has permission

* -added unit test for unread comment thread count

* -improved formatting

* -updated as per PR review
2021-07-07 13:00:33 +06:00
Bhavin K
16e7297021
Feature/table multi select (#5074)
We have added checkboxes against table rows when multi selection is enabled. The end user can also select all rows now in click of a button. The related design has also been refreshed.
2021-07-07 11:22:10 +05:30
Yash Vibhandik
3f9a3d92d7
FIX #5335 : updated custom charttype list (#5504)
* updated custom charttype list with radar chart
* Updated test cases
2021-07-07 10:45:15 +05:30
Yash Vibhandik
43bf1ef72b
FIX #1983 : Updated Css to move disabled button smoothly (#4744)
- conditionally updated css to move disabled button smoothly
- omit disabled property of button and mange disable by className
- update cypress CheckBox_spec test
2021-07-07 10:44:18 +05:30
Pranav Kanade
f414285201
[Feature] Unified New Nav (#5558)
* temp commit

* using onsubmit to continue using action on form

* added recaptcha site key to env example file

* moved the recaptcha lib loading logic to signup page

* removed unnecessary edit

* handle the case where the recaptcha token is not provided as env var

* added proper env var config for client

* recaptcha config for ansible

* recaptcha config for heroku

* recaptcha config for k8s

* updated app.json

* fixed the typos

* added more description for env vars

* removed api key

* minor typo fix

* added new integration button

* updated the add int default link

* added active and create new tabs

* added the empty components to tabs. will control the section manually.

* added proper grid for integrations page

* added vertical tabs

* Added secondary tabs to integrations page

* added separate page for new apis

* classname changes

* added new components for active queries, new queries etc.

* added a separate component for data source list

* adding screen component conditionally, to be showing upon user's choice

* 1. Added grid styling to datasource home
2. Added connect buttons to em

* fixed data source security banner

* updated the styling for new api page

* added tertiary menu for active integrations

* updated styling for active connections

* updated collapse component to work properly

* added show more option to active data sources

* Slash commands feature init commit

* Added more commands

* Introduced JSX to render custom commands

* Merge conflict fix

* Spacing changes

* removed apis/db tabs and replaced em with integrations tab

* removed the unnecessary + integrations btn

* Added slash commands button

* Adjust styles for better ui

* Ordered the action entries under integrations

* Added new datasource command

* updated the getURL with proper params

* updated the link of create datasource btn

* updated the back btn link from data source editor

* Show connect data cta in property pane

* Styling fixes

* Fix margin

* added scrollable content to create new

* added on click scroll to create new page

* fixed a bug, creating new datasource twice

* added new action creator for integrations.

* Minor changes to add new bindings command.
Changed ui behaviour of / button

* UI style change

* updated the query editor to match the over all theme

* updated the query editor tabs

* Added the run btn to empty response screens

* minor fix

* updated the bg color of api type drop down

* updated the url being visited after delete api/query

* removed log

* Insert binding command UI change

* More UI changes

* removed unnecessary junk from integrations editor index

* clean up, removed unnecessary files

* removed useless routes

* for debugger only checking if integrations editor

* Removed all the links for api/query home pages

* Move command actions to a saga
Added support to binding the data back to the widget when are new API is created from widget

* Added reverse binding for DB queries

* Show / button only on hover

* not routing to integrations on create query/api

* Hide actions from suggestions in action pages

* removed the query/datasource/api home pages

* Changes widget.data to widget in slash commands

* Show dependencies in property pane

* Fix warning

* fixed scrolling issue

* will show a list of queries and apis for action picker

* showing icons for each action under integrations

* Fix dropdown not showing up

* Minor refactoring.
Changed commands

* added a way to list data sources in action creators

* Update query page url

* cam show icons for datasources

* Removed unused code

* Feature/slash commands (#5002)

* Slash commands feature init commit

* Added more commands

* Introduced JSX to render custom commands

* Merge conflict fix

* Spacing changes

* Added slash commands button

* Adjust styles for better ui

* Added new datasource command

* Minor changes to add new bindings command.
Changed ui behaviour of / button

* UI style change

* Insert binding command UI change

* More UI changes

* Move command actions to a saga
Added support to binding the data back to the widget when are new API is created from widget

* Added reverse binding for DB queries

* Show / button only on hover

* Hide actions from suggestions in action pages

* Changes widget.data to widget in slash commands

* Minor refactoring.
Changed commands

* Removed unused code

* remove more unusued code

* Added support to generate new api from a datasource in quick commands

* Code correction to use types

* Refactored commands code

* Minor bug fixes

* Remove new integrations command for actions.
Fixed autocomplete not showing up

* Changes to prevent autocomplete trigger for navigation commands

* Prevent hinter execution when show hint is open already.

* Show hinter on focus

* Update text to be called in the omnibar

* updated the copy for empty active datasources

* Update url

* Fix text decoration

* updated the redirection for back btns

* Use themes

* Add cypress test

* fixed back btn nav

* fetching form configs for datasources

* a callback fixed

* Fix slash command not executed on click (#5540)

* Replace the value if not a string else append

* Log commands menu events

* updated mock data base navigation

* updated mock data base navigation

* updated the close editors and back buttons

* All back btns from editors will go back to data sources and back from data source will go back to canvas

* fixed bg colors

* minor styled updates

* removed margin from header of generic datasource

* warnings fixes

* If user is already on the location not redirecting em

* when editing, will check if the coming from data source and redirect accordingly

* updated redirection for newly created api/queries

* updated back btn for newly created datasources

* back for new curl goes to data sources

* Revert "[Fix] revert new nav (#5533)"

This reverts commit 1647815d

* remaining original reverted chagnes

* fixed the width of incoming/outgoing entity bar in property pane

* removing residue from resolved merge conflicts

* Fix widget icons not visible in dropdown menu

* minor fix to use proper integration URL

* updated the URLs for unified datasources

* converted back and close to btns from banners

* on accessing data source from sidebar, it'll always go to view mode

* updated the edit path for saas editors

* Added saved state for google sheet

* on google sheet delete redirecting to create new

* minor fix

* fixed the redirection call on saving a datasource

* removed save and test cmd as it wasn't needed

* Removing test cases to be fixed by Arun

* commenting more tests to be fixed by Arun

* updated call api cy command

* Fix extra margin issue

* fixed the update datasource saga

* fixed video spec

* Revert "commenting more tests to be fixed by Arun"

This reverts commit 42087a95ad77107401a1619e4c2d4c541a81d6c3.

* Revert "Removing test cases to be fixed by Arun"

This reverts commit f6fad67e558d22045114a90409428ef9b737478f.

* fixed the entity explorer query datasource spec

* cautious fix

* update widget locators

* fixed leave org test

* fixes for FormWidgets

* updated the image spec

* Use memo

* Fix debugger url checks

* for copy and delete widget pointing directly to svgs

* Fix entity text

* Fix styling and show tooltip for property pane dependencies

* removed the unnecessary callback

* added a separate saga to to redirect to new integrations using onSuccess

* Bug Fixes - New nav (#5629)

* will show scrollbar only on hover

* made mock data cards clickable

* fixed the grid view

* fixed the cursor position when clicking on / btn

* updated the hint for `/` command

* binding prompt will close on focus change

* hiding / command for api body

* hiding / command for query pane

* Added 2 new icons

* Fix cursor position on selecting a binding and clicking on the slash menu button

* trying out fix to copyWidget cy command

* removing zero width space characters from the property pane text

Co-authored-by: arunvjn <arun@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com>
Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
2021-07-07 09:16:16 +05:30
Abhijeet
17006ffe0e
Minimise DB calls to throw duplicate app name error message (#5625)
* Minimise DB calls to throw duplicate error message for updating application name
2021-07-06 22:20:47 +05:30
Trisha Anand
d1ef21dce3
Reliable change application access from public to private & vice versa (#5530)
* Changing application public/private view can no longer be cancelled (for example by client timeout, etc.)

* Update test to only read the datasource used in the application

* Incorporated review comment

* Comment update
2021-07-06 21:49:35 +05:30
Arpit Mohan
ca087e7e76 Setting string response if the JSON is not valid (#5642) 2021-07-06 18:58:26 +05:30
Bhavin K
6c7f7baeda Bug/tablewidget image url spliting (#5627)
Fixing #5480 where the app became unusable because of a regex introduced in the build

(cherry picked from commit 46844053cf)
2021-07-06 18:53:45 +05:30
Bhavin K
46844053cf
Bug/tablewidget image url spliting (#5627)
Fixing #5480 where the app became unusable because of a regex introduced in the build
2021-07-06 18:43:26 +05:30
Sumit Kumar
d68ca405a8
Feature: integrate ArangoDB plugin (#5518)
* integrate arangoDB plugin.

Co-authored-by: Ming Fang <mingfang@mac.com>
Co-authored-by: Automated Github Action <automated@github.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2021-07-06 18:40:19 +05:30
Anagh Hegde
027603697a
Suggest widget after executing Action (#5574)
* Add widget suggestion to query execution flow

* Change the logic for Chart widget suggestion

* Add tests for the all the suggested widgets

* Added enum class to store widget types
2021-07-06 18:15:48 +05:30
Arpit Mohan
28284b7207
Setting string response if the JSON is not valid (#5642) 2021-07-06 18:07:08 +05:30
akash-codemonk
6d83d8d7c5
Fix: Fix case when a derived property changes the dependent properties are not logged in the debugger (#5442) 2021-07-06 16:13:01 +05:30
Satish Gandham
6098241403
Add performance tracker for resizable component (#5573)
* Add types for wdyr manually

* Add performance tracker for resizable component. Represent the hover performance.

* Pass down widget details to resizable component

* Remove debugging code.

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-07-06 14:51:46 +05:30
Pawan Kumar
df4cfb99ab Fix: App crash on list widget after copy/paste (#5605)
* fix list widget in list widget bug when pasting

* remove console.log

* add test

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
(cherry picked from commit fa4e42f4c6)
2021-07-06 12:30:07 +05:30
Pawan Kumar
fa4e42f4c6
Fix: App crash on list widget after copy/paste (#5605)
* fix list widget in list widget bug when pasting

* remove console.log

* add test

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-07-06 12:24:34 +05:30
Yash Vibhandik
ca87b692bd
FIX #4802 : Color picker inconsistency (#4822)
* convert green rgb to hex code
* update Container_spec cypress test
2021-07-06 12:07:19 +05:30
Tolulope Adetula
6d32e868ce
feat: HTML Render option (#5566)
* Text widget now has an option to render the HTML code as it is. Once the user enables `render as html` the text widget will not parse HTML
2021-07-06 10:34:54 +05:30
Nidhi
7da59a4afe
Content length for multipart (#5556) 2021-07-05 19:28:45 +05:30
Paul Li
d658d64961
FEATURE-1726 : Iframe Widget (#5588)
-- Change border style to solid instead of inset
2021-07-05 18:57:33 +05:30
Tolulope Adetula
f864f689cd
fix: Add Appname to title (#5488)
The appname will be displayed on the browser tab instead of `appsmith | editor / viewer`
2021-07-05 18:56:56 +05:30
Hetu Nandu
be05a1bc26 Add node-forge crypto libraries (#5597) 2021-07-05 17:16:21 +05:30
Hetu Nandu
d4f3d49681
Add node-forge crypto libraries (#5597) 2021-07-05 17:15:21 +05:30
Hetu Nandu
75c439f66d
Handle exception where prepared statements viewer does not get a value (#5531) 2021-07-05 16:29:48 +05:30
Rishabh Saxena
3391ead510
Minor fixes related to the comments feature (#5551) 2021-07-05 12:42:02 +05:30
Ayush Pahwa
fac59c75bb
Updating state on componentDidUpdate (#5476)
* Updating state on componentDidUpdate

* Removed console logs, replaced text with enum

* Removed the unnecessary return statements
2021-07-05 11:51:29 +05:30
Hetu Nandu
c2a1c1feb4
Don't log debug level logs in prod (#5527) 2021-07-05 11:19:43 +05:30
Yash Vibhandik
8ef7c62bb6
FIX #4376 : update default config response to render proper data for … (#4778)
- update default config response to render proper data for table widget drop on canvas
- clone data for primaryColumns
2021-07-05 11:01:47 +05:30
Yash Vibhandik
02384eed36
updated isLoading state when event action completed in Filepicker widget (#5407) 2021-07-05 10:58:47 +05:30
Yash Vibhandik
54c3cfc028
FIX #4813 : display filter count and highlighted filter button (#4916)
- add condition for display filter count and highlighted filter button
- update boolean prop to color string to handled highlight filtered text
2021-07-05 10:56:50 +05:30
akash-codemonk
234ba480f8
Fix flaky debugger test (#5555) 2021-07-05 10:53:57 +05:30
Vicky Bansal
b6e205e5b2
Fix-Rename compact mode property in Table Widget to Row Height (#5496)
* Change compact mode title to Row height in property pane configurations
2021-07-02 16:57:20 +05:30
Vicky Bansal
fb9925cdc3
Fix-Input widget with text area expands over boundaries (#5114)
* Fix input widget resize issue due to textarea resizable

Added cypress test to validate textarea cannot be resized

* Removed cypress test and added jest test for input textarea css testing
2021-07-02 16:53:38 +05:30
Paul Li
38ffe86290
Rate widget (#4891)
* FEATURE-3357 : Rate Widget

-- Create the first MVP of rate widget

* FEATURE-3357 : Rate Widget

-- Change the widget name into rating
-- Change the widget icon
-- Fix the overflow issue in case max count is big
-- Fix the issue in case default rate is zero
-- Add validations for maxCount and defaultRate

* FEATURE-3357 : Rate Widget

-- Fix an issue : Stars is cut off if maxCount is greater than 20
-- Add test cases for two validation types, RATE_DEFAULT_RATE and RATE_MAX_COUNT

* FEATURE-3357 : Rate Widget

-- Add expected data type for tooltip field

* FEATURE-3357 : Rate Widget

-- Expose maxCount

* FEATURE-3357 : Rate Widget

-- Change contents of isAllowHalf property
-- Adjust alignment of stars dynamically
-- Decrease default widget width

* FEATURE-3357 : Rate Widget

-- Remove a unnecessary comment block
2021-07-02 15:25:50 +05:30
Yash Vibhandik
6102f5b119
Added text color JS convertible support in text widget
added text color js convertible support in text widget, added COLOR_PICKER_TEXT validation and updated test case (#5409)
2021-07-02 12:39:17 +05:30
Rishabh Saxena
cf7fe8d6a8
Collab minor fixes (#5457) 2021-07-02 11:34:36 +05:30
akash-codemonk
7d57311290
Fix: Remove property from dependency map when binding is removed (#5538) 2021-07-01 18:48:46 +05:30
Pranav Kanade
1647815d24
[Fix] revert new nav (#5533)
* Revert "[Bug] Mock data section is missing (#5517)"

This reverts commit be48f2f5

* Revert "[Feature #4542] : simple nav unify api/datasource (#4987)"

This reverts commit 8d8b9ed2
2021-07-01 18:14:41 +05:30
Trisha Anand
9dfe66d45c
[Bug] Mongo Plugin : Handle socket exception when the connection is dropped by Mongo database (#5499) 2021-07-01 17:23:24 +05:30
Nidhi
def5cb5c1d
Content type and filename for multipart form data parts (#5509)
* Content type and filename for multipart form data parts

* Handling empty json

* Handling empty json
2021-07-01 15:53:53 +05:30
Bhavin K
96c6b3b80f
moved table property pane config (#5478)
In the table widget, The header options are not re-ordered below the Actions
2021-07-01 12:23:21 +05:30
Pranav Kanade
be48f2f50f
[Bug] Mock data section is missing (#5517)
* updated the condition to show mock databases

* removed log
2021-07-01 11:21:54 +05:30
Pranav Kanade
8d8b9ed203
[Feature #4542] : simple nav unify api/datasource (#4987)
* temp commit

* using onsubmit to continue using action on form

* added recaptcha site key to env example file

* moved the recaptcha lib loading logic to signup page

* removed unnecessary edit

* handle the case where the recaptcha token is not provided as env var

* added proper env var config for client

* recaptcha config for ansible

* recaptcha config for heroku

* recaptcha config for k8s

* updated app.json

* fixed the typos

* added more description for env vars

* removed api key

* minor typo fix

* added new integration button

* updated the add int default link

* added active and create new tabs

* added the empty components to tabs. will control the section manually.

* added proper grid for integrations page

* added vertical tabs

* Added secondary tabs to integrations page

* added separate page for new apis

* classname changes

* added new components for active queries, new queries etc.

* added a separate component for data source list

* adding screen component conditionally, to be showing upon user's choice

* 1. Added grid styling to datasource home
2. Added connect buttons to em

* fixed data source security banner

* updated the styling for new api page

* added tertiary menu for active integrations

* updated styling for active connections

* updated collapse component to work properly

* added show more option to active data sources

* removed apis/db tabs and replaced em with integrations tab

* removed the unnecessary + integrations btn

* Ordered the action entries under integrations

* updated the getURL with proper params

* updated the link of create datasource btn

* updated the back btn link from data source editor

* added scrollable content to create new

* added on click scroll to create new page

* fixed a bug, creating new datasource twice

* added new action creator for integrations.

* updated the query editor to match the over all theme

* updated the query editor tabs

* Added the run btn to empty response screens

* minor fix

* updated the bg color of api type drop down

* updated the url being visited after delete api/query

* removed log

* removed unnecessary junk from integrations editor index

* clean up, removed unnecessary files

* removed useless routes

* for debugger only checking if integrations editor

* Removed all the links for api/query home pages

* not routing to integrations on create query/api

* removed the query/datasource/api home pages

* fixed scrolling issue

* will show a list of queries and apis for action picker

* showing icons for each action under integrations

* added a way to list data sources in action creators

* cam show icons for datasources

* linked integration tab movement to URL

* fixed the create new query bug

* removed search

* added the auto redirection mode

* added new mode to support showing mock data bases

* on click show more works properly

* removed extra padding

* removed height

* showing all the data sources on active tab

* fixed the creation of google sheet

* updated the proper routing for curl

* fixed page height

* removed loader

* added a spinner for creating a new api

* will be showing edit/add query permanantly

* updated the redirection on save and delete datasource

* fixed the redirection logic on delete

* will not show security banner

* added empty state for active data sources

* updated the hover state

* minor fix to redirect on delete from entity pane

* fixed a cy command to create new api

* fixed a command to select api/query from lightning menu

* updated the navigate to data source editor

* removed add btns for new int creation

* updated the testSaveDeleteDatasource command

* fixed bind table text pagination spec

* more test case fixes for deleting a query using context menu

* update curl test

* updated curl post import spec

* fixed click from apis to integrations

* updated execute db query command + updated delete query mech

* updated CreationOfUniqueAPIcheck command

* updated query datasource spec

* fixed an action creator bug.

* fixed curl api creation bug

* removed irrelavent part of the test

* fixed the button colors

* updated back link from datasource page

* Revert url validation changes for the debugger since this is used to check whether we are on a query or an api and show its dependencies

* updated a test case to open integrations option in action selectors

* Update app/client/src/pages/Editor/IntegrationEditor/DatasourceCard.tsx

Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>

* separated msg

* styling fixes for collapse component

* renamed a file

* declared a new const in theme

* updated border

* removed a faint line from collapse card

* removed unnecessary condition

* updated component name

* log removed

* split action creator file

* updated the icon usage in action creators

* can properly fetch mock data sources

* can show mock databases in create new

* can use mock db sources

* fixed the scrollbars

* updated the api icon for both global search + action creator

* updated integrations name in datasources

* added a back to canvas ribbon

* updated query and api editor to show back to canvas ribbon

* added a ribbon to go back

* updated button styles

* updated the action creator and test commands/classes

* updates to show the proper mock databases

* added proper type for mock datasources

* removed unnecessary log

* updated a test case to work with new nav

* minor updates for tests

* updated a command to properly delete a datasource

* minor redirection fix

* made the mock db api call unblocking

* fixed scroll bars all over

* fixed bg colors for back ribbons

* declared a constant for thin scrollbar

* removed unnecessary action.

Co-authored-by: Akash N <akash@codemonk.in>
Co-authored-by: Rishabh Saxena  <rishabh.robben@gmail.com>
2021-06-30 23:51:52 +05:30
Nayan
13fec4e30e
Update email notification template when there is comment (#5392)
* WIP: updated the email template

* -updated the comment link in email as per the user role

* -rebased from release

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/EmailEventHandler.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* -updated the template as per review comment

* -removed unused email template file

* -fixed compile error

* -checked application policy instead of role when sending email for comment

* -minor changes as per PR review comment

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2021-06-30 20:46:56 +06:00
Rishabh Saxena
5681468752
Show page entities on top within global search results (#5494) 2021-06-30 17:15:48 +05:30
Ayush Pahwa
56bf480f0a
Added a variable to props to display the placeholder text (#5082)
The default text shown when the error tab or logs tab is empty in the debugger is the same. This fix changes that text by adding a variable in the props of the BlankState component.
2021-06-30 16:33:35 +05:30
Aswath K
ad9319980f
Fix page load actions not triggering when switching pages in edit mode (#5430) 2021-06-30 12:49:43 +05:30
Nikhil Nandagopal
ed40980f2d
Update CRUD-DB-Table-Template-Application.json 2021-06-30 11:24:37 +05:30
Anagh Hegde
40d147d5b5
Feature/editor simplify - API to work with mock data sets (#5421)
* Added an API to get list of mock datsets
Removed the flow of

* Removed the auto populate of mock datasets flow when the user sign up first time

* Fixed indentation issues

* Instead of sending empty datasource, change template value to empty

* Add only the configs to response instead of entire mongo doc

* Add API to create mock data set
2021-06-29 20:17:00 +05:30
Hetu Nandu
7876967b34
Fix invalid quotes breaking evaluation (#5413) 2021-06-29 20:00:39 +05:30
Tolulope Adetula
132abdaa54
feat: add object fit control (#4986)
* Added attribute to image widget to change cover properties
2021-06-29 19:00:14 +05:30
Bhavin K
140d6c8dda
fix: comma-separated splitting of image url in table col of type image (#4427)
* fix for comma separated splitting of image url in table col of type image
2021-06-29 18:59:19 +05:30
Nikhil Nandagopal
1112c20f7c Updated Template 2021-06-29 17:20:53 +05:30
somangshu
a42e89a8a2 Merge branch 'release-frozen' into release 2021-06-29 17:07:31 +05:30
NandanAnantharamu
27171765e2
Added delay after typing in Cypress test (#4168)
* added delay after typing

* updated method

* updated type in test

* updated common method

* Added wait between CreationOfUniqueAPIcheck()

Added delay between CreationOfUniqueAPIcheck() to prevent the stale exception.

* Updated API name

* Upated spec to handle retry

Co-authored-by: arslanhaiderbuttar <arslan@appsmith.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-06-29 17:01:53 +05:30
Nikhil Nandagopal
95b41f36d3 Updated Template 2021-06-29 16:19:46 +05:30
dependabot[bot]
f5cb70e06c
Bump prismjs from 1.23.0 to 1.24.0 in /app/client (#5458)
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.23.0 to 1.24.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PrismJS/prism/compare/v1.23.0...v1.24.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-06-29 15:32:18 +05:30
Somangshu Goswami
9b1dbeb9dc
Revert "Enable total number of rows and page size for server side pagination in table widget (#4863)" (#5469)
This reverts commit related to #2230 & #1578. We will revisit this problem again and implement the solution based on the discussion in the thread.
2021-06-29 15:01:41 +05:30
Hetu Nandu
da8740f141
Update form label changes (#5468) 2021-06-29 14:26:15 +05:30
imgbot[bot]
0ed6a018ca
[ImgBot] Optimize images (#5467)
*Total -- 1,409.96kb -> 1,370.42kb (2.8%)

/static/animations/invite.gif -- 778.42kb -> 751.72kb (3.43%)
/static/animations/login-google.gif -- 625.10kb -> 612.35kb (2.04%)
/app/client/src/assets/icons/comments/chat.svg -- 0.44kb -> 0.43kb (1.79%)
/app/client/src/assets/icons/comments/comment-mode-unread-indicator.svg -- 0.58kb -> 0.57kb (1.69%)
/app/client/src/assets/icons/comments/notifications-empty-state.svg -- 4.78kb -> 4.71kb (1.39%)
/app/client/src/assets/icons/widget/embed.svg -- 0.64kb -> 0.64kb (0.46%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-06-29 14:10:56 +05:30
Nikhil Nandagopal
8c2f5f50ce Updated Template 2021-06-29 13:10:04 +05:30
Nikhil Nandagopal
82fbf1c95d Updated Template 2021-06-29 12:18:38 +05:30
Nikhil Nandagopal
4c3f63305d Updated Template 2021-06-29 12:16:11 +05:30
Trisha Anand
02e5445731
[Mongo Plugin] Raw is now a command option instead of Form vs Raw (#5446)
* Raw is now a command option instead of Form vs Raw

* Added database migration for migration raw input type to be of raw command type

* Fixed test case failure

* Minor cleanup
2021-06-29 11:13:17 +05:30
NandanAnantharamu
b11f0d8d7f
Removed Reload action (#5450)
* removed Reload action

* count assertion removed
2021-06-28 20:43:44 +05:30
Yash Vibhandik
c5e56662a1
FIX #4627: updated css to change button widget height when deployed (#5439)
This fixes the difference in the height of a button widget between edit mode and deploy mode.
2021-06-28 18:56:11 +05:30
YogeshJayaseelan
2e96701ff3
Manual test Ideas for GoogleSheets and Mongo DB Form Input (#4857) 2021-06-28 15:41:20 +05:30
Nayan
36c399ac4f
Fix the comment missing issue when new users added to organization (#5314)
* -Add the newly added user to existing comment threads

* -update PR as per review comment

* -updated the PR as per review
2021-06-28 14:50:39 +06:00
NandanAnantharamu
2370331628
Test updated as it was flaky (#5441) 2021-06-28 14:05:06 +05:30
Rishabh Saxena
5fe13f5da4
Onboarding typeform related fixes (#5416) 2021-06-28 13:08:44 +05:30
Ashok Kumar M
cf19b8e44d
[Feature] Widget Grouping Phase - 3 (Cut Copy Paste) (#5083)
* Cut copy paste first cut

* removed different parent groups logic

* mouseup on the outer canvas removes selections.

* bug fix

* remove unwanted dead code.

* Adding tests

* build fix

* min height fixes

* fixing specs.

* fixing specs.
2021-06-28 12:41:47 +05:30
akash-codemonk
d4dfa836b1
Changes to show multiple messages for a log in the debugger (#5144) 2021-06-28 09:44:06 +05:30
Snyk bot
9ab1113763
Security upgrade node-sass from 4.14.1 to 6.0.1
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-TRIMNEWLINES-1298042
2021-06-28 01:04:39 +05:30
Nikhil Nandagopal
e8ba1bee7f
removed quotes from sql templates because of prepared statements being on (#5404)
removed comments from sql templates confusing users with errors because of linting
2021-06-25 14:39:39 +05:30
Sumit Kumar
b2d4454492
Feature: add api key based and bearer token based authentication options to REST API datasource (#5367)
* add api key based and bearer token based authentication options to REST API datasource
* this change is ported to release from Feature: datasource changes for api key auth, bearer token auth, combine config. #4683
2021-06-25 12:15:48 +05:30
arslanhaiderbuttar
950257f8f2
Chart UI test cases (#5370)
* Chart UI Test Cases

Added UI Test cases for Chart Widget.
- All Chart Types
- JS Scenarios
- onClick Scenarios
- Copy
- Delete

* Fixed Chart displaying issue.

Fixed Chart displaying issue.
2021-06-24 19:28:20 +05:00
Rishabh Saxena
6640a64fe4
Make the whole window scrollable instead of the main container (#5369) 2021-06-24 16:41:56 +05:30
Abhijeet
6ec6f9578c
API for generating a page with UI based on the structure of a given database table (#5269)
* Keymapping, Clone actions from template application, Used exported application JSON file as template app

* Delete references of widgets from action config if extra widgets not required

* Separate API added when pageId is not present with the client

* Added TCs

* Update in regex, enable reqArgsConstructor, separate DTO for CRUD page
2021-06-24 14:58:57 +05:30
akash-codemonk
7f478482d1
Fix: Fixes a bug in onboarding flow step 1 (#5363) 2021-06-24 14:42:12 +05:30
Rishabh Saxena
b24dd8f8b2
Minor collab fixes (#5271) 2021-06-24 14:34:27 +05:30
Nayan
9a247f3e78
Fix bug where some fields are missing for notifications from the API (#5336)
* -set createdAt and type fields in notification
-add threadId in response for comment

* -fixed bug with unread notification count
2021-06-24 14:35:30 +06:00
Rishabh Saxena
29a6136380
Set mode for comments (#5372) 2021-06-24 12:51:01 +05:30
Rishabh Saxena
a61b802039
Update comments onboarding carousel images (#5373) 2021-06-24 12:50:35 +05:30
Pranav Kanade
599996fbfa
bug/duplicate application name error will be handled (#5316)
* will show last saved app name if save app name action results in error

* handled duplicate appname update for editing cards

* fixed the app icon update bug

* updated list widget dsl
2021-06-24 12:02:09 +05:30
akash-codemonk
3747d41c30
Show the associated page name subtly in the omnibar (#5120) 2021-06-24 11:14:36 +05:30
Rishabh Saxena
c351643f57
Notification updates (#5239) 2021-06-23 21:12:07 +05:30
Vicky Bansal
fe700a8049
Fixed empty area issue when columns are hidden in published mode (#5162) 2021-06-23 19:09:04 +05:30
Hetu Nandu
dce3a80e40
Minor fixes for errors (#5361) 2021-06-23 18:55:18 +05:30
Vicky Bansal
6b7aef8dc8
Enable total number of rows and page size for server side pagination in table widget (#4863)
* Add defaultPageSize and totalRecordsCount properties in table widget

* Changing next button disable

* Added checks for properties change

* Handle defaultPageSize change

* Updated util.test to handle new table properties

* Configure for cypress test for page size and total records count properties

* Added cypress test for default page size and total records count validation

* Fix test cases

* Handle empty space for page size is less than availabe space in table widget
2021-06-23 18:53:24 +05:30
Nayan
e52680fb1f
Feature/implement comment thread subscriber (#5261)
* -send email to users who are subscribed to a thread only

* -fixed null pointer exception while set subscriber in create thread

* -updated as per PR comments and review
2021-06-23 17:24:57 +06:00
Abhijeet
7fc04f043f
Error message when updating duplicate application name modified to give more contextual information (#5341) 2021-06-23 13:08:12 +05:30
Satish Gandham
47bc5aa032
Merge pull request #5026 from appsmithorg/feature/1726-iframe-widget
Adding iframe widget
2021-06-23 13:01:40 +05:30
Hetu Nandu
eae2e46b9d
Fix cyclical dependency issue when Api returns an error (#5333)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2021-06-23 12:59:36 +05:30
Anagh Hegde
a1defb9544
Remove the unnecessary comments 2021-06-23 11:16:15 +05:30
Anagh Hegde
0d57f3c132
Merge branch 'release' into feature/page-order-api 2021-06-23 10:54:17 +05:30
Anagh Hegde
fa9a1bc488 Set the order to published pages 2021-06-23 10:51:25 +05:30
NandanAnantharamu
3fb00b6c7a
Added Cypress tests for tab widget (#4345)
* Added tests for tab widget

* Added another test

* Commone method updated

* commented test
2021-06-22 23:26:45 +05:30
rahulramesha
b12cea84a6
Merge pull request #5167 from appsmithorg/FIX/5073-File-Picker-close-button-tool-tip-content-change
FIX/5073 for File Picker close button tool tip content change
2021-06-22 16:52:19 +05:30
Somangshu Goswami
3c8944cc1c
Merge pull request #4341 from appsmithorg/fix/dropdown-overlap-modal
fix: Dropdown option gets overlapped on the ModalComponent
2021-06-22 15:37:44 +05:30
dependabot[bot]
d20dec6cf6
Bump ws from 6.2.1 to 6.2.2 in /app/client (#4941)
Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/commits)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-06-22 13:49:38 +05:30
arunvjn
f4b1daa459
Use loadash get function to add fall back value to datasource url (#5285) 2021-06-22 11:56:18 +05:30
Shrikant Sharat Kandula
c4acc05d27
Remove unused configurations in Netlify 2021-06-22 10:45:54 +05:30
arunvjn
469d7f0e14
Fix to enable scroll in sql query results. (#5091)
* Dynamically adjust table virtualizer's height according to resizer
2021-06-22 09:23:53 +05:30
arunvjn
655918f741
Removed intermediate navigation to datasource list page. (#5304) 2021-06-21 21:28:00 +05:30
Sumit Kumar
7787a0ddac
Bug Fix: Fix dynamic binding substitution failure with Firestore where condition input boxes. (#5280)
Modify dynamic binding substitution method to handle list and map types containing generic type values.
2021-06-21 19:36:06 +05:30
Trisha Anand
a89990e157
Mongo For Update Migrations (#5291)
* Commenting out migration for quick fix to bring up release

* Added null checks for the incomplete configured update single and update many queries
2021-06-21 18:37:33 +05:30
Hetu Nandu
441f42c72f
Generate linting errors via JSHint (#5034) 2021-06-21 16:39:51 +05:30
Paul Li
9bc1cd4899 Merge branch 'release' into feature/1726-iframe-widget 2021-06-21 06:54:20 -04:00
Paul Li
96c273cc22 FEATURE-1726 : Iframe Widget
-- Set default source url to wikipedia.org
-- Fix typo on the tooltip of onURLChanged, url to URL
-- Fix the issue which is related to reduced iframe in its deploy mode
-- Fix the issue which is related to the inclusion of nearby widgets in deploy mode
-- Add Expected Data Type fields with regard to borderOpacity and borderWidth
2021-06-21 06:48:00 -04:00
rahulramesha
c17588f2f8 Merge branch 'release' of github.com:appsmithorg/appsmith into FIX/5073-File-Picker-close-button-tool-tip-content-change 2021-06-21 15:17:10 +05:30
imgbot[bot]
4117aba204
[ImgBot] Optimize images (#5277)
*Total -- 3,594.44kb -> 3,429.78kb (4.58%)

/static/animations/widgets.gif -- 1,349.47kb -> 1,261.08kb (6.55%)
/static/animations/javascript.gif -- 2,244.10kb -> 2,167.84kb (3.4%)
/app/client/src/assets/icons/comments/filter.svg -- 0.86kb -> 0.86kb (0.34%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-06-21 14:55:06 +05:30
Somangshu Goswami
82a62cf4a7
Merge pull request #4864 from appsmithorg/FIX/4731-dragging-and-dropping-table-widget-error-in-debugger
FIX #4731: update condition for selectedRowIndices when table widget drag and drop
2021-06-21 14:39:10 +05:30
arslanhaiderbuttar
a9961f06ef
Merge pull request #5170 from appsmithorg/buttonUITestCases
Button UI test cases
2021-06-21 13:23:30 +05:00
akash-codemonk
e7f6598231
Fix: Log dependent property values in debugger when a property is updated (#4865) 2021-06-21 13:50:25 +05:30
Yash
26a70870f0 Merge remote-tracking branch 'origin/release' into FIX/4731-dragging-and-dropping-table-widget-error-in-debugger 2021-06-21 13:15:07 +05:30
imgbot[bot]
6358062dd7
[ImgBot] Optimize images (#5260)
*Total -- 1,360.99kb -> 1,333.59kb (2.01%)

/static/animations/running-api.gif -- 1,353.80kb -> 1,326.48kb (2.02%)
/app/client/src/assets/images/InspectElement.svg -- 4.50kb -> 4.43kb (1.46%)
/app/client/src/assets/icons/comments/down-arrow.svg -- 0.32kb -> 0.32kb (1.21%)
/app/client/src/assets/icons/ads/bell.svg -- 0.38kb -> 0.37kb (0.78%)
/app/client/src/assets/icons/ads/upload_success.svg -- 0.48kb -> 0.48kb (0.61%)
/app/client/src/assets/icons/ads/download.svg -- 0.60kb -> 0.60kb (0.49%)
/app/client/src/assets/icons/comments/eye.svg -- 0.91kb -> 0.91kb (0.32%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-06-21 11:28:32 +05:30
Abhijeet
598a48cea7
Migration for createdAt and updatedAt field for userCollection if not present (#5249) 2021-06-19 18:03:23 +05:30
Anagh Hegde
32ecffbf8f Merge remote-tracking branch 'origin/feature/page-order-api' into feature/page-order-api 2021-06-18 22:40:43 +05:30
Anagh Hegde
9ad742e97e Change the test method name to more meaningful,.equals for boolean comparision, fix indentation 2021-06-18 22:40:16 +05:30
abhishek nayak
37708a4128
Merge pull request #5231 from appsmithorg/snyk-fix-45d4107a9d315a1ce1ee74338cb35c92
[Snyk] Fix for 26 vulnerabilities
2021-06-18 20:42:01 +05:30
arslanhaiderbuttar
ef39ae8c68
Updated Widgets_form_input_table_default_validation.js
Updated Widgets_form_input_table_default_validation.js
2021-06-18 17:08:57 +05:00
Abhinav Jha
2c3b457b47
Fix Table Widget Filter issue (#3975)
* Fix issue where non-string empty values are not correctly filtered

* Add unit test for fix
2021-06-18 17:34:34 +05:30
Anagh Hegde
82a1289f45
Merge branch 'release' into feature/page-order-api 2021-06-18 15:15:48 +05:30
Anagh Hegde
e02e572df7 Change the logic to have check for the order of all the pages 2021-06-18 14:53:33 +05:30
Shrikant Sharat Kandula
040d3b0cc4 Fix publish application event not being sent 2021-06-18 13:27:31 +05:30
Pawan Kumar
91bf527bea
List Widget Phase 2 (#4189)
* update  meta properties + default properties map

* update widget registery

* update get meta property

* update metahoc + widgetfactory + data tree evaluator

* try sending function as string to worker

* revert data tree evaluator update

* pass default props map from dataTreeWidget file

* wip

* save child meta properties

* remove console.log

* save meta and default map in list

* update listwidget

* remove console.log + unused variables

* revert getMetaPropertiesMap function

* fix data tree test

* fix list widget test

* fix entity definition test

* fix overriting of item in updatedItems

* remove todo comments

* fix meta prop issue

* revert making meta properties from undefiend to "" & fix filepicker bug

* fix test case

* change items to listData and updatedItems to items

* remove console.log

* fix test

* extract derived properties to dervied.js

* disabled top, left, right resize handler list widget container

* add test for dervied js

* add test for selectedItem

* fix background color bug on hover

* remove console.log

* fix chart widget inside list widget

* fix checkbox issue + points raised by yogesh

* revert the createImmerReducer usage

* fix parse derived properties

* remove internal props object that fails the test

* fix import typo

* allow bottom resize handler

* fix template height check

* fix template height check

* update template size check

* fix the is visible invalid prop issue

* fix migration of list widget phase 2

* fix migration

* remove unused import

* fix migration

* fix migration

* remove console.log

* hide delete option for container in entity explorer

* fix testcases

* remove unused import

* fix switch widget meta prop

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-06-18 13:12:57 +05:30
Trisha Anand
ee4429b973
Commenting out migration for quick fix to bring up release (#5248) 2021-06-18 12:10:15 +05:30
Tolulope Adetula
2e896e1ddd Merge branch 'release' into fix/dropdown-overlap-modal 2021-06-18 07:09:34 +01:00
Satish Gandham
295ac586ba
Merge pull request #5222 from appsmithorg/ui/perf/add-widget-type-id-to-property-pane-tracker
Add widget type and id to property pane tracker
2021-06-18 11:37:55 +05:30
Tolulope Adetula
9b39cdbb45 Merge branch 'release' into fix/dropdown-overlap-modal 2021-06-18 07:07:35 +01:00
Nidhi
57adbd7777
Schema info in templates query (#5244) 2021-06-18 11:31:17 +05:30
Shrikant Sharat Kandula
7d08187677
Merge pull request #5233 from appsmithorg/fix/send-publish-event-only-on-client-publish
Fix app publish event sent at wrong times
2021-06-18 11:19:36 +05:30
Trisha Anand
388418cec5
Merge the two update commands into a single update command in Mongo Form (#5171)
* Update commands have been merged into a single update command for both single and multi updates

* Added migrations to migrate any update one mongo form command to new update command

* Incorporated review comments
2021-06-18 11:04:39 +05:30
Snyk bot
5c17d962a0
[Snyk] Security upgrade net.minidev:json-smart from 2.3 to 2.4.7 (#5225)
* fix: app/server/appsmith-interfaces/pom.xml to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-NETMINIDEV-1078499
- https://snyk.io/vuln/SNYK-JAVA-NETMINIDEV-1298655

* Updating the json-smart dependency to the latest one

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-06-18 10:54:34 +05:30
Shrikant Sharat Kandula
6c67c20576 Another typo 🤦🏻‍♂️ 2021-06-18 10:48:58 +05:30
rahulramesha
b4519b9dae Merge branch 'release' of github.com:appsmithorg/appsmith into FIX/5073-File-Picker-close-button-tool-tip-content-change 2021-06-18 10:46:27 +05:30
Shrikant Sharat Kandula
45b062b83b Typo 2021-06-18 10:43:10 +05:30
Anagh Hegde
bd3369dd03 Remove * import statements 2021-06-18 10:25:36 +05:30
Abhijeet
b87825523e
Support for orphan API without any datasource added for import-export functionality (#5232) 2021-06-18 07:20:28 +05:30
Rishabh Saxena
75481e93d2
Fix redirect URL on 401s (#5230) 2021-06-17 22:50:32 +05:30
Shrikant Sharat Kandula
11218c2b19 Fix app publish event sent at wrong times 2021-06-17 19:28:50 +05:30
arslanhaiderbuttar
005c8077eb
Add commands in Command.js
Add commands in Command.js 
copyWidget, deleteWidget
2021-06-17 18:47:54 +05:00
arslanhaiderbuttar
7d901c25a6
Fixed and updated Button Specs.
Fixed "Button-Call-Query Validation" test case in Button Spec and updated Copy, delete widget test cases.
2021-06-17 18:43:43 +05:00
arslanhaiderbuttar
1c1f7391d7 Merge branch 'release' into buttonUITestCases 2021-06-17 18:32:21 +05:00
akash-codemonk
11342651db
Fix: Show error callout in api pane when there is an error (#4827) 2021-06-17 18:57:46 +05:30
snyk-bot
e8d731a21a
fix: app/server/appsmith-interfaces/pom.xml & app/server/appsmith-server/pom.xml to reduce vulnerabilities
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1052449
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1052450
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1054588
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056414
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056416
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056417
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056418
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056419
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056420
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056421
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056424
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056425
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056426
- https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056427
- https://snyk.io/vuln/SNYK-JAVA-COMMONSBEANUTILS-460111
- https://snyk.io/vuln/SNYK-JAVA-IONETTY-1020439
- https://snyk.io/vuln/SNYK-JAVA-IONETTY-1070799
- https://snyk.io/vuln/SNYK-JAVA-IONETTY-1082238
- https://snyk.io/vuln/SNYK-JAVA-IONETTY-1083991
- https://snyk.io/vuln/SNYK-JAVA-IONETTY-1089809
- https://snyk.io/vuln/SNYK-JAVA-IOPROJECTREACTORNETTY-559154
- https://snyk.io/vuln/SNYK-JAVA-IOPROJECTREACTORNETTY-559155
- https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1009832
- https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORK-1296829
- https://snyk.io/vuln/SNYK-JAVA-ORGSPRINGFRAMEWORKSECURITY-1290497
- https://snyk.io/vuln/SNYK-JAVA-ORGYAML-537645
2021-06-17 13:27:03 +00:00
Ashok Kumar M
a76b8cad9b
Feature: Widget Grouping Phase II (#4825)
* dip

* dip

* Cleaning up grid density positioning.

* dip

* dip

* dip

* dip

* code clean up

* dip

* dip(restructuring widget selection)

* Deselect parents and children of a widget when user multi selects.

* dip

* dip

* dip

* dip

* dip

* fixing a bad merge

* fixing tests

* adding jest tests.

* common util

* dip

* dip

* fixes

* restrict in deploy mode.

* fixing dynamic layout.

* fixing tests.

* on paste fix.

* fixing specs.

* addressing code review comments

* dip

* dip

* dip

* fixing specs.
2021-06-17 18:56:54 +05:30
arslanhaiderbuttar
95382420df Merge branch 'release' into buttonUITestCases 2021-06-17 17:04:42 +05:00
NandanAnantharamu
7d8b57cb7a
removed unwanted wait (#5206) 2021-06-17 16:27:54 +05:30
Satish Gandham
76ad932682 Add widget ID, widget type to property pane open perforamnce tracker. 2021-06-17 15:04:18 +05:30
Nidhi
884636f33f
Snowflake integration (#5176)
* POC for snowflake integration with Appsmith

This is just a rough version to see if the functionality works. Needs to be cleaned up & enhanced for production usage.

* Plugin with connection, monos, ds testing, validation, templates, structure and forms

* Better comments

* Default schema to public

* Changed logging destination, populated request in result and used thread group for datasource creation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-06-17 15:03:18 +05:30
Rishabh Saxena
9c99f36bd6
Comments feature fixes (view mode) (#5081) 2021-06-17 13:07:27 +05:30
akash-codemonk
6001e69de4
Highlight the second item in in the omnibar search results (#4611) 2021-06-17 12:24:55 +05:30
Sumit Kumar
26cd46ea53
Fix: parse json/jsonb data type values as json for postgres plugin (#5135)
* parse json/jsonb data type values as json
* add support for json (non binary, earlier support for jsonb was added)
2021-06-17 11:31:34 +05:30
Satish Gandham
68ba1acb58
Merge pull request #5148 from appsmithorg/ui/perf/add-tags-option-to-performance-tracker
Add an option to set tags on sentry performance transactions #5147
2021-06-17 11:13:23 +05:30
Rishabh Saxena
1b2f01ed2a
Profile image updates (#4783) 2021-06-17 00:06:34 +05:30
Satish Gandham
2ffd43bcd0 - Remove the is_array check 2021-06-16 23:22:10 +05:30
Nayan
a1a4f0ef3f
Fature/add pagination in notifications (#5096)
* -added pagination to notifications API

* -add unit tests for notification pagination

* -added unread count in get notifications API

* -moved notification creations to notification service from comment service

* -add repository method to mark a notification as read

* -added repository to update isRead by for username

* -add API to mark notification as read

* -addd application id and application name in notification

* -save application id and name in notification when creating notification for comment and comment threads

* -added page id, from user information in notifications

* -fixed failing unit test due to dependency error

* -removed unused imports

* -extended base controller in notification controller

* - introduced pagination based on before created data instead of offset based pagination

* -moved application id, name and page id inside comment from notification

* -moved author information from notification to comment thread

* -return data from notification service instead of the response object in the mark read or unread API
2021-06-16 23:24:03 +06:00
Rishabh Saxena
f7405f9004
Reset the user in store on 401s (#5153) 2021-06-16 22:39:25 +05:30
Rishabh Saxena
10b3f7e790
Feature/signup success url (#5124) 2021-06-16 21:21:18 +05:30
Anagh Hegde
e119bd716c Ignore the order of the page while checking the published and edited pages test 2021-06-16 21:12:18 +05:30
arslanhaiderbuttar
988cc39b7c
Merge branch 'release' into buttonUITestCases 2021-06-16 17:27:46 +05:00
arslanhaiderbuttar
ba4450aa57 Resolved Conflict in QueryEditor.json file
Resolved Conflict in QueryEditor.json file
2021-06-16 17:02:15 +05:00
Ashok Kumar M
e8152ce198
Fix: updating basic dsl for fork and duplicate feature cypress specs (#5152)
* dip

* dip
2021-06-16 17:21:00 +05:30
rahulramesha
9ce7e906a0 fix for #5073 2021-06-16 15:14:09 +05:30
Yash
2e0f307794 Merge remote-tracking branch 'origin/release' into FIX/4731-dragging-and-dropping-table-widget-error-in-debugger 2021-06-16 14:57:09 +05:30
Anagh Hegde
8296f416cc Merge remote-tracking branch 'origin/feature/page-order-api' into feature/page-order-api 2021-06-16 14:29:37 +05:30
Anagh Hegde
2ccc1ef1f2 Change the test scenario 2021-06-16 14:29:03 +05:30
arslanhaiderbuttar
49788e5c93
Deleted Hard Waits.
Deleted Hard Waits.
2021-06-16 13:55:05 +05:00
arslanhaiderbuttar
9b86a4c6e1 Cypress.json update 2021-06-16 13:27:19 +05:00
Anagh Hegde
e748623e57
Merge branch 'release' into feature/page-order-api 2021-06-16 13:56:52 +05:30
Anagh Hegde
1b36f79a4e Fix merge conficts 2021-06-16 13:44:46 +05:30
Trisha Anand
77e965523c
[Feature] Smart Substitution for JSON fields in Mongo Form (#5136)
* Reduced verbosity of the command names for Insert, Find and Delete

* WIP : Smart substitution untested changes for mongo form

* Tested code for smart substitution working for mongo form fields

* Added test case for assert for smart substitution
2021-06-16 13:31:00 +05:30
Anagh Hegde
5a8ac3fd33 1. Fix failing unit tests for the page reorder 2021-06-16 11:21:19 +05:30
Satish Gandham
172bf61648 - Fix typo in type definitions 2021-06-16 10:42:41 +05:30
Satish Gandham
f15eba445c - Set the default perfTags value to [] 2021-06-16 10:15:40 +05:30
Anagh Hegde
3e1702b4f9 1. Add migration logic
2. Add order while creating pages
2021-06-16 09:12:53 +05:30
Satish Gandham
5c1a9b512a Add an option to set tags on transactions #5147 2021-06-15 20:53:48 +05:30
Abhijeet
7c430303aa
Allow only organization admins to export application (#5085)
* Added permission export:applications for admin role

* Only admins are allowed to export applications

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2021-06-15 18:18:21 +05:30
arslanhaiderbuttar
a45405917f JS Scenario 2021-06-15 17:24:25 +05:00