Commit Graph

4011 Commits

Author SHA1 Message Date
Pawan Kumar
0d41797a26
Fix: List Widget crashes on null empty object in data (#4349)
* filter null values in property pane autocomplete

* add hover states for list items

* add loading state in list

* fix loading state of list widget

* open list widget property on click of container

* fix isVisible bug in list widget children

* remove unused import

* add cusor pointer

* add focused state for first item in list widget

* fix empty state

* fix test case

* fix visiblity bug

* fix test case

* fixes for review comments

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-05-27 12:11:38 +05:30
Rishabh Saxena
9f76218306
Trigger invite flow via comments (#4602) 2021-05-27 11:51:36 +05:30
arunvjn
5c45217f3d
Feature/datasource list in api editor (#4587)
Show datasource list in API editor
2021-05-27 08:35:05 +05:30
Tolulope Adetula
b78c6204b9 fix: Add zIndex Layers of Dropdown and Modal 2021-05-26 14:56:40 +01:00
Tolulope Adetula
f54d4c618e Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-26 13:56:48 +01:00
Apeksha Bhosale
4825ce2a2a
Show JS eval errors in evaluated value pane and debugger (#4463)
Co-authored-by: jsartisan <pawankumar2901@gmail.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-05-26 18:02:43 +05:30
Yash
a24623da94 FIX #4603 : updated css to truncate long column name 2021-05-26 17:51:09 +05:30
Yash
218ad04553 FIX #4524 : revert added check in else block and add handle boolean validation in validator 2021-05-26 17:43:25 +05:30
vicky.bansal@primathon.in
bd5ca7011c Removed unused import 2021-05-26 16:57:01 +05:30
akash-codemonk
8bd6ed3a70
Feature: Show current value in the debugger when widget property has an error (#4592) 2021-05-26 13:47:52 +05:30
vicky.bansal@primathon.in
312ea00138 Increase width of default table widget so that scrollbars are not required by default 2021-05-26 10:22:08 +05:30
vicky.bansal@primathon.in
7d7dad4b87 Updated yarn 2021-05-26 09:04:11 +05:30
vicky.bansal@primathon.in
042ee3fa46 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/text-parsing 2021-05-26 08:57:40 +05:30
vicky.bansal@primathon.in
dcebd1103e Fix for email parse 2021-05-26 08:47:46 +05:30
Satish Gandham
bfc8b6a46f Memoize the evaluate popup placement value 2021-05-25 22:07:38 +05:30
Nikhil Nandagopal
50b03302e4 fixed validation messages 2021-05-25 19:18:35 +05:30
Satish Gandham
ad3997ecde Merge branch 'release' into perf/ui/optimize-binding-prompt/4555 2021-05-25 11:14:28 +05:30
Yash
e34a156f18 FIX #4573 : added custom fusion chart config to override default message 2021-05-24 18:27:50 +05:30
Tolulope Adetula
4ac85a7fd9 fix: add Layers to the dropdown 2021-05-24 10:09:43 +01:00
Tolulope Adetula
b95ff2001e Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-24 08:21:30 +01:00
Yash
591f9395f6 [ISSUE#4524]Fix: Added a check in else block too and assigned default config 2021-05-24 12:27:33 +05:30
Tolulope Adetula
b2a86d7e11 fix: failing modal test 2021-05-24 06:52:49 +01:00
Nikhil Nandagopal
750e3808f2 Merge branch 'release' into fix/validation-messages 2021-05-24 11:01:24 +05:30
Satish Gandham
7ef5f70596 Merge branch 'release' into perf/ui/optimize-editableText-component 2021-05-24 06:53:35 +05:30
Satish Gandham
b01c615056
Merge pull request #4554 from appsmithorg/perf/ui/optimize-resizable-component
Optimize resizable component
2021-05-21 19:33:51 +05:30
Satish Gandham
516aa0f40c
Merge pull request #4397 from appsmithorg/perf/ui/reduce-json-view-data
[Performance] Collapse all but the first two records in react-json-view
2021-05-21 19:32:52 +05:30
Paul Li
5701e2ac3e Merge branch 'release' into fix/2358-dropdown-multi-select-too-much-space 2021-05-21 05:39:47 -04:00
Paul Li
0966536638 FIX-2358 : Too much spacing between option on multi selection option in Dropdown Widget
-- Adjust space between tag items along a flexbox's cross-axis
2021-05-21 05:32:28 -04:00
Nikhil Nandagopal
4ed203d4af Merge branch 'release' into fix/validation-messages 2021-05-21 14:19:25 +05:30
Nikhil Nandagopal
ecb85efe7c updated validation messages 2021-05-21 14:18:59 +05:30
Rishabh Saxena
220c8d9d25
Remove isFromSignup param to prevent duplicate analytics hits (#4480) 2021-05-21 13:20:27 +05:30
Tolulope Adetula
3c1f4bca9b Merge branch 'release' into fix/-filePicker-widget-property-cleanup 2021-05-21 08:05:17 +01:00
Tolulope Adetula
f4e693f4f8 Merge branch 'release' into fix--color-picker-in-form-widget 2021-05-21 06:42:26 +01:00
Tolulope Adetula
6381f5d2ec Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-21 06:41:06 +01:00
Paul Li
5ae2d1a04a Merge branch 'release' into fix/4362-recaptcha-field-unexpected-data-types 2021-05-20 15:30:29 -04:00
Paul Li
4d9aa2bd00 FIX-4362 : Unexpected data types in the Recaptcha field for buttons breaks the widget
-- Add a guard for invalid googleRecaptcha key
2021-05-20 15:28:02 -04:00
Satish Gandham
c5133fca87 - Patch the blueprint core module with the editabletext performance optimization 2021-05-21 00:55:05 +05:30
Satish Gandham
ee7d9f2498 Merge branch 'release' into perf/ui/optimize-resizable-component 2021-05-20 18:45:59 +05:30
Satish Gandham
041ee6a479 Merge branch 'release' into perf/ui/reduce-json-view-data 2021-05-20 18:45:31 +05:30
Rishabh Saxena
8964aea9df
[Feature] Comments feature updates (#4579) 2021-05-20 17:33:08 +05:30
arunvjn
63db439183
Fixed r.match bug (#4593) 2021-05-20 16:51:10 +05:30
somangshu
29579a71fa Merge branch 'release' into areyabhishek-patch-4 2021-05-20 15:21:25 +05:30
bhavin
4e559b4228 remove no selection option 2021-05-20 13:54:26 +05:30
Tolulope Adetula
0372e47e14 Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-20 08:33:49 +01:00
Hetu Nandu
aac5fcb6c7
Use the Function constructor for user script eval (#4446)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-05-20 12:31:10 +05:30
NandanAnantharamu
7f2b0c6b30
Fix: Mongo datasource and query Cypress test (#4578)
* fix for MongoQuery Test

* Fixed cypress test

* removed unwanted code

* updated another test

* Commented Query part for stub test
2021-05-20 12:22:50 +05:30
NandanAnantharamu
7c587f0288
binding list widget with Api (#4229) 2021-05-20 11:15:48 +05:30
Tolulope Adetula
afcf7d793a fix: PR comments 2021-05-20 06:04:52 +01:00
prapullac
81f3ccd163
Manual test ideas for List Widget (#4090) 2021-05-19 19:27:26 +05:30
Paul Li
c1557c187a FEATURE-2111 : Show/Hide Table Controls
-- Adjust pageSize
-- Change column header height
-- Restore the logic for renderEmptyRow
2021-05-19 07:02:07 -04:00
Satish Gandham
3886386b4d Merge branch 'release' into perf/ui/reduce-json-view-data 2021-05-19 16:21:43 +05:30
Paul Li
c906b0e447 FEATURE-2111 : Show/Hide table controls
-- Apply some cleanup
2021-05-19 05:36:30 -04:00
Paul Li
9e0ec2304a Revert "FEATURE-2111 : Show/Hide Table Controls"
This reverts commit 1d3c2da455d0a58beb4189898464baf5096c1aee.
2021-05-19 05:36:30 -04:00
Paul Li
7cf12ed031 FEATURE-2111 : Show/Hide Table Controls
-- Remove extra space when the header options is all hidden
2021-05-19 05:36:30 -04:00
Paul Li
35e28dcb08 FEATURE-2111 : Show/Hide Table Controls
-- PositionedContainer : Add padding-bottom: 42px in case of Table widget
2021-05-19 05:33:45 -04:00
Paul Li
f943d0b330 FEATURE-2111 : Show/Hide Table Controls
-- Remove JS convertible
-- Set isBindProperty and isTriggerProperty to false
2021-05-19 05:31:53 -04:00
Paul Li
c76ef9e3d7 FEATURE-2111 : Show/Hide Table Controls
-- Add the header options section for the visibility setting
-- Render conditionally the header part based on the setting
2021-05-19 05:31:53 -04:00
Tolulope Adetula
4c3834828a fix: remove console statement 2021-05-19 08:21:25 +01:00
Tolulope Adetula
4e890dce86 fix: remove unnecessary className 2021-05-19 08:21:00 +01:00
Tolulope Adetula
523972e191 Fix: modal and Dropdown 2021-05-19 08:20:00 +01:00
prapullac
3073bbc5c8
Adding manual test ideas for Text Widget (#3910) 2021-05-19 11:46:12 +05:30
Satish Gandham
f266ca3793 Merge branch 'release' into perf/ui/optimize-resizable-component 2021-05-19 11:37:41 +05:30
Trisha Anand
d5e5be5d6a
[Feature] Mongo Form (#4378) 2021-05-19 11:05:24 +05:30
Arpit Mohan
b1d7258dcb
Adding support for multipart form data (#4547)
* Handling multipart form data in the CURL import flow

* Adding Cypress test for curl import with multipart/form-data

* Also fixing minor bug where the form values need not always be double-quoted
2021-05-19 10:48:51 +05:30
Tolulope Adetula
18e5dde01d Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-18 22:24:33 +01:00
Ashok Kumar M
8c8141650a
Feature: Widget grouping Phase I (Multi select and Bulk Delete) + Canvas Enhancements. (#4219)
* Feature: Canvas layer enhancements(DIP)

* feedback fixes

* fixing build

* dip

* dip

* dip

* fixing build

* dip

* dev fixes

* dip

* Fixing top bottom resize handles

* dip

* reposition widget name on top edges.

* dip

* dip

* dip

* dip

* renaming selectedWidget to lastSelectedWidget

* code clean up

* Fixing list widget as per grid scale.

* Fixing existing specs.

* Adding migration test cases.

* dip

* FIxing proppane in modal.

* fixing modal z-indedx.

* fix for modal name.

* dip

* dip

* dip

* adding test cases for hotkeys.

* dip

* dip

* fixing build

* Trying some performance improvements for jests.

* 17 mins with runinband lets try without it.

* minor bug fixes.

* code clean up

* save migrated app on fetch.

* fixing few cypress tests

* fixing cypress tests

* fixing cypress tests.

* fixing cypress

* updated DSL

* Addressing code review comments.

* test fails

* dip

* eslint fixes.

* fixing debugger cypress tests.

* updating latest page version.

* updating migration changes to cypress dsl's.

* updating chart data fixes for cypress tests.

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-18 23:59:39 +05:30
arunvjn
b14f043172
Fix/datasource request headers in api (#4481)
* Show datasource headers when used in an API
2021-05-18 21:40:53 +05:30
Somangshu Goswami
41419e0406
Merge pull request #4199 from appsmithorg/feature/table-excel-export
Allow table data to download as Excel
2021-05-18 20:17:16 +05:30
Somangshu Goswami
01aa8ed36d
Merge pull request #4316 from appsmithorg/fix/server-side-search
Disable client side search when server side search is enabled in table widget
2021-05-18 20:16:30 +05:30
Somangshu Goswami
52da3e7030
Merge pull request #3791 from aswathkk/issue/3321
Allow removing filter on Dropdown Widget
2021-05-18 20:15:42 +05:30
Somangshu Goswami
559555f175
Merge pull request #4485 from appsmithorg/bug/select-optionmenu-scroll
fix: select disabled option popover overflow
2021-05-18 20:01:06 +05:30
Somangshu Goswami
c233dc1273
Merge pull request #4313 from appsmithorg/fix/datepickerwidget-popover
fix: datepicker popover adjust height and width.
2021-05-18 20:00:04 +05:30
akash-codemonk
9e082a6156
Feature: Show widget error state (#4558) 2021-05-18 19:24:40 +05:30
Satish Gandham
faeac974ca - Remove code casuing expensive style recalculation 2021-05-18 17:48:29 +05:30
akash-codemonk
51b98eed2f
Fix: Debugger shows errors for evaluations done on page load (#4552) 2021-05-18 17:21:32 +05:30
arunvjn
4733edfccd
Fixed query params parsing in API pane (#4482)
* Fixed query params parsing when there are mulitple "="s.

* Added cypress tests to validate query params parsing
2021-05-18 17:17:43 +05:30
arunvjn
08966499be
Remove request/response data from copies of an executed API (#4521) 2021-05-18 17:17:22 +05:30
Shrikant Sharat Kandula
1e052a9462
Fix redirectUrl not being encoded (#4546) 2021-05-18 11:22:54 +05:30
Satish Gandham
bbecba125e - Wrap the methods passed to editableText component with useCallback
- Use destructing for props
2021-05-18 00:42:06 +05:30
Apple
5abd651e25 updated test 2021-05-17 21:36:46 +05:30
akash-codemonk
cbace9d5d7
Fix: Debugger showing previous application logs (#4455) 2021-05-17 15:31:22 +05:30
Satish Gandham
6bf7903570
Merge pull request #4470 from appsmithorg/ui/eslint/sort-destructured-props
Add eslint rule to sort destructured props and auto fix the issues.
2021-05-17 14:52:59 +05:30
Satish Gandham
bed4b39561
Merge pull request #4292 from appsmithorg/perf/optimize-table-widget
Optimize table widget
2021-05-17 14:52:49 +05:30
bhavin
b323c75d1d updated closeModal saga to stop reseting children meta properties on a modal 2021-05-17 14:04:56 +05:30
Apeksha Bhosale
e4ee2b07c9
r.match on API pane error (#4497)
* r.match on API pane error

* Pr comment fixed
2021-05-17 12:51:48 +05:30
arunvjn
67e292cc2a
Fixed handleSubmit bug in API form editor (pagination buttons) (#4477) 2021-05-15 00:13:08 +05:30
bhavin
cab7f4a099 fix: select disabled option popover overflow 2021-05-14 14:53:22 +05:30
arunvjn
341a4d62af
Bug/paste widget append copy to name (#4399)
* Changes to retain widget/Action names on copy when there is no clash.

* Updated tests

Co-authored-by: Apple <nandan@thinkify.io>
2021-05-14 14:35:55 +05:30
NandanAnantharamu
b66692ba57
Test commented (#4476) 2021-05-14 12:32:25 +05:30
arunvjn
068e4065d7
Expose response headers for API/DB actions (#4336)
* Expose response headers for API/DB actions

* Added responseMeta to actions datatree

* Modified cypress test to account for responseMeta

* Modify cypress test case

* More test changes

* Modified tests
2021-05-14 12:21:09 +05:30
NandanAnantharamu
fb8b6d1995
updated method to print response (#4473) 2021-05-13 21:27:19 +05:30
Trisha Anand
377629955d Revert "Init minor comment"
This reverts commit 2b7212da8c.
2021-05-13 20:01:37 +05:30
Trisha Anand
2b7212da8c Init minor comment 2021-05-13 19:52:54 +05:30
Tolulope Adetula
e7cd7148fa update: fix test 2021-05-13 14:08:07 +01:00
Tolulope Adetula
083efdcdbe fix: Form widget random color test 2021-05-13 13:31:46 +01:00
Satish Gandham
d27dcca678 - Remove jsx-no-bind and noshadow eslint rules 2021-05-13 17:50:04 +05:30
Satish Gandham
8ecac87ec7 Change the cell renderer function from class property to inline and use JSON.stringify to do the comparision. 2021-05-13 17:38:15 +05:30
Satish Gandham
8ad7eecdeb - Auto fix sort ddestructured props rule 2021-05-13 14:05:39 +05:30
Nidhi
ea451ef061
Add default configs for prod and tests (#4464)
* Added default cs config for prod and tests

* Env variable for new installations

* K8s defaults
2021-05-13 13:30:23 +05:30
Satish Gandham
8f1cc88b7d Merge branch 'release' into add-more-eslint-rules 2021-05-13 12:47:50 +05:30
Satish Gandham
f2d228c346 - Add no shadow eslint rule 2021-05-13 12:41:11 +05:30
Apeksha Bhosale
66c7a0b252
Revert "Separating js error and validation error for debugger (#4361)" (#4447)
This reverts commit c6a8f81d60.
2021-05-13 09:50:30 +05:30
bhavin
0015d72122 updated max year for datepicker to +100, same as property pane datepicker 2021-05-12 21:01:17 +05:30
NandanAnantharamu
fb7db810da
Updated Cypress locator for product updates test (#4454) 2021-05-12 17:43:11 +05:30
Tolulope Adetula
285f7faf41 fix: add color picker to form component 2021-05-12 11:03:34 +01:00
Pawan Kumar
cc36bdc051
Fix: TypeError: t.match is not a function (#4445)
* add is number check before setting widget property

* use toString of lodash

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-12 13:27:28 +05:30
Apeksha Bhosale
c6a8f81d60
Separating js error and validation error for debugger (#4361)
* separate js error and validation error

* PR comments fixed and added error for pageload action

* reverted to jsError message property

* small check for empty errors

* small changes for Test to pass

* space was missing for test case

* removed console statement
2021-05-12 12:10:32 +05:30
Tolulope Adetula
0b1db5689f Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-12 02:22:07 +01:00
Tolulope Adetula
f6c7036d5c fix: remove uploadedFileUrls ppty from FilePicker 2021-05-11 16:53:02 +01:00
Ashok Kumar M
3eeaf86097
Fix: Resize doesn't react as intended for top/bottom handles. (#4321) 2021-05-11 20:09:33 +05:30
Satish Gandham
8bd947671d Move the expensive getBoundingReactangle call to isColliding function to avoid unnecessary calls. 2021-05-11 20:09:09 +05:30
bhavin
ca7594ac3f fixed : deafult and min/max is allow same date 2021-05-11 13:07:16 +05:30
Satish Gandham
68c258ab3a - Remove unncessary anonymous funciton
- Use destructured imports
2021-05-11 12:25:42 +05:30
vicky-primathon.in
56f0ba716b Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-05-11 12:10:26 +05:30
vicky-primathon.in
78bad85e24 Used useCallBack hook and remove inline arrow function 2021-05-11 12:10:13 +05:30
Satish Gandham
812e893eee - Add name to memoized resizableComponent 2021-05-11 12:03:07 +05:30
Satish Gandham
8763f9518b - Memoize EditorContext value
- Change mapDispatchToProps to object form
2021-05-11 12:02:24 +05:30
akash-codemonk
d6de913949
Revert "Feature: Show widget error state (#4202)" (#4406)
This reverts commit bf7a8b91a4.
2021-05-11 09:40:43 +05:30
abhishek nayak
1276edf517
Update DropdownWidget.tsx
Updated the default value to something that doesn't fail.
2021-05-11 03:19:03 +05:30
Tolulope Adetula
8c484798de fix: overlay covering widget explorer 2021-05-10 20:59:16 +01:00
Apeksha Bhosale
2138c9059b
match is not a function (#4409) 2021-05-10 19:40:22 +05:30
arunvjn
1b98c2e520
Revert Gsheets warning modal (#4405) 2021-05-10 19:39:26 +05:30
Tolulope Adetula
23367fe3be Merge branch 'release' into fix/dropdown-overlap-modal 2021-05-10 14:43:38 +01:00
Tolulope Adetula
579085a88b Merge branch 'fix/Datasource-dropdown-stacking-issue' into fix/dropdown-overlap-modal 2021-05-10 14:42:40 +01:00
Tolulope Adetula
57a621978d Merge branch 'release' into pr/3791 2021-05-10 14:33:01 +01:00
arunvjn
3b61af395e
Fix/text overflow json viewer (#4367)
CSS fix to wrap long urls/text in json viewer. GSheets to occupy full width
2021-05-10 18:58:38 +05:30
NandanAnantharamu
408517de39
Datasource test with basic profile added (#4374) 2021-05-10 17:27:54 +05:30
vicky-primathon.in
f14ca6b6c3 Hide sub icon 2021-05-10 17:04:17 +05:30
vicky-primathon.in
97178ea899 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-header-styles 2021-05-10 16:56:37 +05:30
vicky-primathon.in
9ab8da4671 Table header style changes 2021-05-10 16:54:50 +05:30
Pawan Kumar
fc10625d41
Fix: Cannot read property 'label' of undefined & Cannot read property 'length' of undefined (#4389)
* fix for label of undefined

* add check for data type

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-10 15:22:17 +05:30
vicky-primathon.in
aa5beddf4a Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-05-10 15:08:48 +05:30
vicky-primathon.in
30510c56b4 Fix download dropdown UI 2021-05-10 15:08:23 +05:30
bhavin
4c824a1214 fix: datepicker popover adjust height and width. 2021-05-10 13:14:29 +05:30
akash-codemonk
359d104f5f
Show debug button in toast only for some particular errors (#4311) 2021-05-10 13:13:12 +05:30
akash-codemonk
78ccfadb61
Fix: Make contents of tab selectable (#4390) 2021-05-10 13:08:39 +05:30
Somangshu Goswami
d4e3de6330
Merge pull request #4359 from appsmithorg/fix/dropdown-rename-select
Refactor: Rename Dropdown to Select
2021-05-10 11:25:24 +05:30
Somangshu Goswami
1864166fdc
Merge pull request #4285 from appsmithorg/fix/date-time-picker-bug
change data-time format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss'
2021-05-10 11:21:42 +05:30
snyk-bot
02d1231d60
fix: upgrade flow-bin from 0.91.0 to 0.148.0
Snyk has created this PR to upgrade flow-bin from 0.91.0 to 0.148.0.

See this package in npm:


See this project in Snyk:
https://app.snyk.io/org/nikhil-nu4/project/d17f040d-321b-4afe-b115-70b9f45067b1?utm_source=github&utm_medium=upgrade-pr
2021-05-09 04:59:13 +00:00
akash-codemonk
bf7a8b91a4
Feature: Show widget error state (#4202) 2021-05-07 20:03:20 +05:30
bhavin
c3960a7a4d fix :extended maxDate and minDate limits to 100 years from now. 2021-05-07 18:38:43 +05:30
Nidhi
4a288439f0
Added basic authentication type to REST APIs (#4040)
* Added basic authentication type to REST APIs

* Spacing for prefix

* Tests and json ignore for password

* Client side form changes

* Review comments
2021-05-07 17:24:05 +05:30
Satish Gandham
c86390ebfe - Collapse all but the first two records in react-json-view 2021-05-07 15:22:53 +05:30
arunvjn
45aa3c57f1
Added null check against datasource url (#4352) 2021-05-07 13:24:58 +05:30
Tolulope Adetula
ff4dbfde74 Merge branch 'release' into fix/Datasource-dropdown-stacking-issue 2021-05-07 08:41:34 +01:00
Tolulope Adetula
00669d9b8e fix: move dropdown options to portal 2021-05-07 08:35:00 +01:00
Nidhi
51aee58c54 Bearer prefix without space 2021-05-07 12:35:34 +05:30
bhavin
47a7128a06 Refactor: rename Dropdown to Select 2021-05-07 10:56:36 +05:30
Tolulope Adetula
213d7e0c58 Merge branch 'release' into pr/3791 2021-05-06 19:04:14 +01:00
Paul Li
a2faae4216 Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-06 10:32:06 -04:00
Paul Li
8ea4638d00 FEATURE-4135 : Table URL columns pretty link
-- Change controlType for display text to COMPUTE_VALUE
2021-05-06 10:29:09 -04:00
bhavin
9b91a09c73 fix: set default format in table date type cell 2021-05-06 19:36:41 +05:30
arunvjn
65d33c2614
Fixed query params parsing in API pane when dynamic bindings are present in the URL (#4205) 2021-05-06 18:45:05 +05:30
Trisha Anand
ee14571ffc
[Bug Fix] : Removal of cyclical dependencies due to action relationships being added to dependency map (#4342) 2021-05-06 18:28:06 +05:30
vicky-primathon.in
a5dbb5261b Added test case to validate onSearchTextChange function if configured in table widget 2021-05-06 13:54:18 +05:30
Tolulope Adetula
829742b239 fix: reduced portal zindex 2021-05-06 08:18:39 +01:00
Satish Gandham
f193ff4a21 - Remove the accidental recursive funciton call in tablewidget 2021-05-06 12:01:39 +05:30
Satish Gandham
9fc5770d72 - Refactor the Cell render function and change it into a class property.
- Remove unsed hook.
2021-05-05 18:31:11 +05:30
Satish Gandham
abf7277d20
Merge pull request #4240 from appsmithorg/perf/optimize_react-json-viewer
Memoize CurrentValueViewer to prevent expensive rerenders of react JSON viewer
2021-05-05 18:18:05 +05:30
Trisha Anand
218ac82e7f
During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path. (#4315)
* During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path.

* To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist.

* Revert "To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist."

This reverts commit c494932289e33287074c56844fbf76c8418875af.

* Disabling cypress test which asserts cyclical errors when depending on yourself
2021-05-05 17:55:39 +05:30
Rishabh Saxena
95f3cb8a9a
Log an analytics event for cyclical dependency errors (#4323) 2021-05-05 16:51:15 +05:30
Trisha Anand
6cf3b8a901
In case the chart series data id starts with a number, it was incorrectly identified as a number instead of a string which led to incorrect path computed to check in binding paths (#4322) 2021-05-05 16:50:59 +05:30
Paul Li
ee47510fac Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-05 05:29:46 -04:00
Paul Li
4be80b665a FEATURE-4135 : Table URL columns pretty link
-- Remove the anchor tag wrapping display text
-- Make display text case-sensitive
2021-05-05 05:26:57 -04:00
Kaushik Varanasi
984119e9cb
Feature: auto create organisation Fixes #2720 (#3922)
* added basic function structure for creating organization

* added functionality for automatically creating an organization with 'Untitled organization 1' like applications. Need to add tests.

* added test for creating organizations with default names

* added tests for creating org with default name

* updated jest tests to not fill in the organization form

* remove unused imports

* deleted unnused files

* added more test to check invite users to application and check that the create application is visible

* updated share application tests according to the new workflow

* fix failing tests. TODO: fix tests with renameRandomOrg to rename specific org

* remove rename random org and rename specific orgs

* remove blocking code so the element can be scrolled into view

* fix tests

* try to fix flaky tests

* remove unused

* remove create organization tests as we are testing these components elsewhere

* fix failing tests by stubbing create org response

* update tests according to new workflow
2021-05-05 12:40:35 +05:30
vicky-primathon.in
e96fa63f6d Disable client side search when server side search is enabled in table widget 2021-05-05 12:39:15 +05:30
Somangshu Goswami
fd6709b29a
Merge pull request #4119 from appsmithorg/fix/date-input-edit
Fix date string parsing for date from input field
2021-05-05 12:08:16 +05:30
Somangshu Goswami
0a0d9794dd
Merge pull request #4099 from appsmithorg/fix/#3860-input-widget-validation
[Bug] : Input widget validation issues#3860
2021-05-05 12:06:59 +05:30
Somangshu Goswami
6d41a4eb27
Merge pull request #4211 from appsmithorg/fix/4134-table-filter-case-insensitive
Fix/4134 table filter case insensitive
2021-05-05 12:02:27 +05:30
bhavin
a29b20eca5 fix: set date picker calendar popover position to bottom 2021-05-05 11:53:59 +05:30
Satish Gandham
4543bcc39e Add eslint rule to warn against inline functions in jsx 2021-05-05 11:37:12 +05:30
vicky-primathon.in
ba2d9e1ed2 Added cypress test to validate email parsing 2021-05-05 11:30:33 +05:30
vicky-primathon.in
53b99c1a34 Fix email parsing issue in text widget 2021-05-05 10:59:49 +05:30
abhishek nayak
10b8cdc32a
Update WidgetConfigResponse.tsx
Edited default table column size to remove scrollbar
2021-05-05 03:36:21 +05:30
Paul Li
e1be6ad940 Merge branch 'release' into feature/4135-table-url-column-pretty-link 2021-05-04 15:53:24 -04:00
Paul Li
a5a0e0d85d FEATURE-4135 : Table URL columns pretty link
-- Add displayText field into property pane
-- Display urls based on displayText
-- Fix url alignment issue
2021-05-04 15:48:40 -04:00
Abhinav Jha
b508e37387
Fix DEFAULT_OPTION_VALUE validations which were breaking evaluations (#4295) 2021-05-04 22:42:15 +05:30
akash-codemonk
6ad40de1e5
Fix undefined error in debugger sagas (#4291)
Use correct types and check if validationMessages exists as it could be undefined
2021-05-04 20:12:42 +05:30
Satish Gandham
611a07af75 Add eslint rule to sort destructure keys 2021-05-04 19:45:29 +05:30
Apeksha Bhosale
8473226382
app crashes when moving from google to rest api (#4282)
* app crashes when moving from google to rest api

* wrong url for test
2021-05-04 18:38:20 +05:30
bhavin
5f9497a627 date format 'YYYY-MM-DD hh:mm:ss A' to 'YYYY-MM-DD hh:mm:ss' 2021-05-04 16:39:05 +05:30
Satish Gandham
adb5f7bc7a - Memoize ReactTableComponent 2021-05-04 16:30:57 +05:30
Rishabh Saxena
99c302e018
Fix update application test (#4281) 2021-05-04 14:31:19 +05:30
Satish Gandham
30b33331a2
Fix cyclic dependency making the table widhget crash the app. #4209 (#4214)
- Check if sanitizedTableData is array

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-05-04 13:04:35 +05:30
Kaushik Varanasi
7af0faa32e
Feature: Fork apps across orgs : fixes #3089 (#4121)
* create basic button for forking

* added menu item for fork, opens a basic modal. TODO: Add functionality to fork

* clicking fork app enables organization select and forks across applications

* added close modal functionality. TODO: add tests, optimise code, remove duplicate and use exportswhere possible

* removed unused code

* Added cypress tests to check that fork app creates an app with same dsl. Tests Failing, needs fixing

* tests fixed, but needs unexpected login from cy

* Resolved bug with login by using correct cypress selectors

* Added tests to check that dsls match, added documentation and removed unused code

* remove unused fork function and directly dispatch from modal

* refactor code

* revert

* removed unused code and refactored tests

* feature/fork-apps-across-orgs-refactor

* make code prettier

* renamed components correctly

* refactored modal code into single file. TODO: fix warnings, test and remove unused code

* pass setModalClose to dialog component to maintain global modal state

* Added types for fork modal props

* update tests and remove unused code

* Removed isDeployedApp and instead passed trigger as a prop

* remove console logs and revert imports to small case

* rename files as components

* minor changes

* cleanup

* mock dispatch for jest

* move jest mocks to component tests
2021-05-04 11:34:23 +05:30
arunvjn
da0abfb2bf
CSS fix to wrap long urls/text in json viewer (#4269) 2021-05-04 11:17:09 +05:30
Satish Gandham
2a3d0fd28e - Destructure TableComponent props 2021-05-04 00:12:21 +05:30
Nidhi
8596f51921
New privacy policy (#4267)
* New policy

* Minor styling
2021-05-03 22:54:03 +05:30
abhishek nayak
edfe965cf7
Merge pull request #4248 from appsmithorg/areyabhishek-patch-2
Update WidgetConfigResponse.tsx
2021-05-03 20:28:44 +05:30
arunvjn
2956953955
Feature/gsheet warning modal (#4258)
Added modal to inform the users about google sheet warnings and events to monitors sheets usage.
2021-05-03 17:43:37 +05:30
Nidhi
446220515f
Added limited use disclosure (#4261)
* Added limited use disclosure
2021-05-03 16:28:51 +05:30
Satish Gandham
e3b361a8d4 Change inline functions in jsx to class properties 2021-05-03 14:33:03 +05:30
akash-codemonk
c36b1ffa04
Update debugger analytics events (#4186)
- Send analytic event for tab change in api and query pane

- Also update debugger text

- Send open debugger analytic event while opening from shortcut
2021-05-03 13:38:49 +05:30
Ashok Kumar M
4350da7da3
Fix: Updating help text for tabs widget after refactor. 2021-05-03 13:12:57 +05:30
Rishabh Saxena
81a2bfa067
Fix storybook build (#4087) 2021-05-03 11:19:12 +05:30
Pawan Kumar
923cbcd595
Fix: Validation on grid gap + handle delete child on list widget (#4247)
* handle delete case for list widget

* add check for grid grap validation

* update test

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-05-03 10:31:47 +05:30
abhishek nayak
782afcc6b0
Create WidgetConfigResponse.tsx 2021-05-01 04:57:16 +05:30
abhishek nayak
7623b99830
Update WidgetConfigResponse.tsx
1. Changed default text of dropdown widget, and radio button
2. Changed the font size of title of form widget to heading1 from paragraph
3. Changed default location of Google maps widget
2021-05-01 04:25:37 +05:30
Satish Gandham
449ea505fe Memoize CurrentValueViewer to prevent expensive rerenders of react json viewer #4239 2021-04-30 15:06:28 +05:30
Nikhil Nandagopal
9650dfe638
Merge pull request #4236 from appsmithorg/fix/table-data
fixed the column sizes
2021-04-30 14:55:19 +05:30
Nikhil Nandagopal
529114f57f fixed the column sizes 2021-04-30 13:49:13 +05:30
Abhinav Jha
d8c9d16575
Fix #1805 base64 encoded images (#4020)
Co-authored-by: Navdeep Singh <navdeep.er@gmail.com>
Co-authored-by: Apple <nandan@thinkify.io>
2021-04-30 12:30:13 +05:30
Somangshu Goswami
9caf953b41
Merge pull request #4128 from appsmithorg/fix/#4023-datepicker-incorrect-placeholder
[Bug-4023] : Incorrect placeholder in the datepicker widget
2021-04-29 21:21:36 +05:30
vicky-primathon.in
3d79900290 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-04-29 19:56:21 +05:30
Somangshu Goswami
64961dde16
Merge pull request #4006 from appsmithorg/fix/native-scrollbars-experience
Fix-Native scrollbar UX with custom scrollbars
2021-04-29 16:27:14 +05:30
Rishabh Saxena
a0d2e8533d
Initialise comments (#3328)
* Initial scaffolding for comments CRUD APIs

* add actions

* add assets

* state management for existing comments and creating new

* add ui components

* add overlay comments wrapper to baseWidget

* add toggle comment mode button at editor header

* trigger tests

* Disallow commenting as someone else

* Add applicationId for comments

* lint

* Add overlay blacklist to prevent component interaction while adding comments

* Comment thread style updates

* Placeholder comment context menu

* Controlled comment thread visibility for making new comments visible by default

* Update comment type description

* Reset input on save

* Resolve comment thread button ui

* fix close on esc key, dont create new comment on outside click

* Submit on enter

* add emoji picker

* Attempt at adding a websocket server in Java

* CRUD APIs for comment threads

* Add API for getting all threads in application

* Move types to a separate file

* Initial commit for real time server (RTS)

* Add script to start RTS

* Fix position property

* Use create comment thread API

* Use add comment to thread API

* Add custom cursor

* Dispatch logout init on 401 errors

* Allow CORS for real time connection

* Add more logs to RTS

* Fix construction of MongoClient

* WIP: Real time comments

* Enable comments

* Minor updates

* Read backend API base URL from environment

* Escape to reset comments mode

* Set popover position as auto and boundary as scroll parent

* Disable warning

* Added permissions for comment threads

* Add resolved API for comment threads

* Migration to set commenting permission on existing apps

* Fix updates bringing the RTS down

* Show view latest button, scroll to bottom on creating a new comment

* Cleanup comment reducer

* Move to typescript for RTS

* Add missing server.ts and tsconfig files

* Resolve / unresolve comment

* Scaffold app comments

* Minor fixes: comment on top of all widgets, add toggle button at viewer header

* Reconnect socket on creating a new app, set connected status in store

* Retry socket connection flow

* Integration tests for comments with api mocks using msw

* Fix circular depependency

* rm file

* Minor cleanup and comments

* Minor refactors: move isScrolledToBottom to common hooks, decouple prevent interactions overlay from comments wrapper

* Use policies when pushing updates in RTS

* ENV var to set if comments are enabled

* Fix: check if editor/viewer is initialised before waiting for init action

* Add tests for comments reducer

* Revert "ENV var to set if comments are enabled"

This reverts commit 988efeaa69d378d943a387e1e73510334958adc5.

* Enable comments for users with appsmith email

* lint

* fix

* Try running a socket.io server inside backend

* Update comment reducer tests

* Init mentions within comments

* Fix comment thread updates with email rooms

* Minor fixes

* Refactors / review suggestions

* lint

* increase cache limit for builds

* Comment out tests for feature that's under development

* Add Dockerfile for RTS

* Fix policies missing for first comment in threads

* Use draftJS for comments input with mentions support

* fix fixtures

* Use thread's policies when querying for threads

* Update socket.io to v4

* Add support for richer body with mentions

* Update comment body type to RawDraftContentState

* fix stale method

* Fix mentions search

* Minor cleanups

* Comment context menu and thread UI updates

* revert: Scaffold app comments

* Yarn dependencies

* Delete comment using id api added

* Init app comments

* Add test for creating thread

* Api for delete comment with id

* Test comment creation response and policies

* Copy comment links

* Fix reset editor state

* Delete valid comment testcase added

* Delete comment TC : code refactor

* Don't allow creating comments with an empty body

* Pin comments WIP[]

* Ignore dependency-reduced-pom.xml files from VCS

* Cleanup of some dev-only files, for review

* Delete comment

* Update socket.io to v4 in RTS

* Pin and resolve comment thread object added in commentThread

* Pin and resolve comment thread object added in commentThread

* Update comment thread API

* Added creationTime and updationTime in comment thread response

* Added creationTime and updationTime in comment thread response

* Added human readable id to comment threads, fallback to username for null name in user document

* Refactor

* lint

* fix test, rm duplicate selector

* comment out saga used for dev

* CommentThread viewed status, username fallback for getName=null, username field added in pin & resolve status

* lint

* trigger tests

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com>
2021-04-29 16:03:51 +05:30
Paul Li
6d9d7d94bf Merge branch 'release' into fix/4134-table-filter-case-insensitive 2021-04-29 06:04:05 -04:00
vicky-primathon.in
9469571a0c Fix type issue 2021-04-29 15:33:40 +05:30
Paul Li
aedac74d3a Merge branch 'release' into fix/#4023-datepicker-incorrect-placeholder 2021-04-29 05:54:24 -04:00
Paul Li
2344af3b59 BUG-4134 : Table filter search shouldn't be case sensitive
-- Lowercase and then apply filters
2021-04-29 05:41:16 -04:00
vicky-primathon.in
92764c8f5c Used zipcelx instaed of xlsx lib to download table data as excel 2021-04-29 14:50:43 +05:30
Apeksha Bhosale
82a330bebb
show invalid datasource but in different color (#4198) 2021-04-29 13:25:20 +05:30
arunvjn
5867375090
Code changes to show records count for db queries/APIs/GSheets. (#4185) 2021-04-29 11:29:38 +05:30
vicky-primathon.in
fcc4ad18f6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-29 01:42:47 +05:30
Somangshu Goswami
3c144a1fe5
Merge pull request #3962 from appsmithorg/fix/multi-select-values-reset
Fix-Multi select dropdown values does not get reset inside a form
2021-04-28 20:58:23 +05:30
Somangshu Goswami
6eec8236b6
Merge pull request #4192 from appsmithorg/fix/dropdown-default-value
Fix-Dropdown default value not trimming special characters
2021-04-28 20:52:36 +05:30
Somangshu Goswami
8e5f6ec271
Merge pull request #4045 from appsmithorg/fix/table-image-cell-align
Fix- Image alignment in table widget cells
2021-04-28 20:48:31 +05:30
Somangshu Goswami
0c5e73f9fa
Merge pull request #4065 from appsmithorg/fix/table-filter-selection-background
Removed background from selected dropdown item in table widget filters
2021-04-28 20:46:41 +05:30
Somangshu Goswami
201436b84d
Merge pull request #4187 from appsmithorg/fix/bug-1610-cropped-text-in-text-widget
BUG-1610 : Text gets cropped in the text widget even when there is go…
2021-04-28 20:08:16 +05:30
vicky-primathon.in
e78b4db3b2 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/table-excel-export 2021-04-28 18:54:26 +05:30
vicky-primathon.in
398fe551cc Handle table data download as excel 2021-04-28 18:37:35 +05:30
Satish Gandham
7f7f6f666b
Development: Add eslint rules for code consistency (#4083)
Co-authored-by: Satish Gandham <satish@appsmith.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-04-28 15:58:39 +05:30
Nidhi
706fd06e15
Including services and their role (#4193)
* Including services and their role

* Explicitly mention Google tokens
2021-04-28 15:07:55 +05:30
vicky-primathon.in
4909a83c00 Fix date input test case 2021-04-28 14:08:09 +05:30
vicky-primathon.in
6d5269fa3b Added cypress test to validate default value with enter works 2021-04-28 12:43:08 +05:30
vicky-primathon.in
d4e636b519 Updated cypress test 2021-04-28 12:12:16 +05:30
Paul Li
2e61174890 BUG-1610 : Text gets cropped in the text widget even when there is good amount of space
-- Change css line-height property into 1.2
2021-04-28 01:43:03 -04:00
Hetu Nandu
c8bce7344b
Set derived values as undefined if cyclic dependency (#4159) 2021-04-27 19:09:52 +05:30
Paul Li
17dd8d525e Merge branch 'release' into fix/#3860-input-widget-validation 2021-04-27 09:19:50 -04:00
Nikhil Nandagopal
a931c372be
Merge pull request #4179 from appsmithorg/fix/logs
[Fix] fire events locally to debug analytics
2021-04-27 18:31:47 +05:30
Nikhil Nandagopal
73cb703962 fire event locally to debug analytics 2021-04-27 18:23:08 +05:30
arunvjn
cbb619a266
Show server error message when mongo auth is invalid. (#4110) 2021-04-27 18:22:26 +05:30
Pawan Kumar
6cd9f39b7f
fix cypress test for chart-text binding (#4177)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-04-27 17:13:36 +05:30
Nikhil Nandagopal
217b55697b
Merge pull request #4089 from appsmithorg/fix/table-data
Updated the default table data to guide users to connect a datasource
2021-04-27 14:14:23 +05:30
Ashok Kumar M
8f7cc87801
Fix: Tabs widget refactor with new nested property validation (#4014)
* dip

* test cases first commit

* Adding Tabs migrator.

* fixing tests.

* bug fix.

* selected tab fix

* missed commit

* fixing bugs

* Fixing tab name bugs.

* close property pane when dragging or resizing

* migration changes.

* release rebase changes.

* adding List factory

* remove dynamic bindings on deleting tabs.

* Adding validation messages for nested properties as well

* fixing validation issue.

* tabs visibility validation.

* missed commit

* Fixing broken cypress tests.

* Fixing broken tests.
2021-04-27 12:46:54 +05:30
vicky-primathon.in
72d5ec5b64 Fix dropdown default value not trimmed before using for value selection 2021-04-27 11:29:52 +05:30
vicky-primathon.in
15ae304da4 Added cypress test to validate issue fix 2021-04-27 11:21:08 +05:30
Apeksha Bhosale
0b2bd452df
Query pane size adjusted as API pane field (#4162) 2021-04-27 11:04:09 +05:30
abhishek nayak
c1bc9ed9f2
Update ContainerWidget.tsx
Updated the color field in the property pane to color picker instead of 'Input_text'
2021-04-27 05:07:11 +05:30
Kaushik Varanasi
9752631103
Bugfix: omnibar issues : fixes #3742 (#3998)
* Added reducers and sagas for cleaning up ui.pageWidgets on creating new application

* Add border and scale to omnibar helpbar on hover

* Added analytics event for omnibar fire on clicking help button

* Linked documentation buttons in API pane and DB query pane to Omnibar

* Added tests to make sure Omnibar has correct styles

* Added margin to make sure border is visible

* Added cypress tests to check that api pane documentation opens the omnibar modal

* Added tests for page widgets reducer reset widget state action

* Added cypress tests to check db documentation opens in global search modal

* remove scale transform

* update recent widgets on selecting widget from omnibar and also clear search when done

* added some documentation links for specific db queries

* added more documentation links, added analytics for omnibar open, set query on opening omnibar from navigation

* remove slicing of 1st option in recent entities, revert previous code and remove console log

* make query syntax better

* add transparent border to remove side effects

* ensure that query is empty upon opening omnibar

* add omnibar documentation helpers to constants

* remove unused files

* added omnibar open and search to readmore button in new query pane

* added analytics event, cleanup and documentation

* removed unused set queries

* Fixed failing cypress tests according to new workflow. Removed invalid comments
2021-04-26 22:15:03 +05:30
somangshu goswami
02fed75899 Merge branch 'release' into fix/table-filter-selection-background 2021-04-26 20:24:03 +05:30
Somangshu Goswami
978bec7866
Merge pull request #3987 from appsmithorg/fix/filepicker-clear-files
Fix-Selected file deletion not working in File Picker widget
2021-04-26 20:17:45 +05:30
vicky-primathon.in
c88e0724e1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-26 19:46:02 +05:30
vicky-primathon.in
f50b1508ba Cypress test to validate issue fix 2021-04-26 19:45:46 +05:30
Nikhil Nandagopal
c3ef0b1bc5 Merge branch 'release' of github.com:appsmithorg/appsmith into fix/table-data 2021-04-26 19:19:41 +05:30
Hetu Nandu
12bb6dd715
Fix datasource invalids check (#4164) 2021-04-26 19:18:13 +05:30
Nikhil Nandagopal
edac5344d2 Merge branch 'release' of github.com:appsmithorg/appsmith into fix/table-data 2021-04-26 19:00:09 +05:30
Nikhil Nandagopal
165c7cdc78 removed unused imports 2021-04-26 18:59:53 +05:30
Nikhil Nandagopal
54fd4c5832 updated action as a primary col 2021-04-26 18:16:56 +05:30
Apeksha Bhosale
be15d0d44b
Show warning when connecting to localhost (#4017) 2021-04-26 17:47:38 +05:30
Apeksha Bhosale
5dac939534
Show hint message for identical column (#4033) 2021-04-26 17:46:48 +05:30
Hetu Nandu
74a292ffda
Add better code coverage comments (#4140) 2021-04-26 16:21:52 +05:30
Pawan Kumar
d814e780ed
Fix: Update chart from array to object (#3907)
* update structure of chart data

* update chart data

* update chart data structure

* remove array like validator

* remove log

* remove log

* widget utils + update tests for chart data validations

* update utils test

* add migrations

* remove unnecessary helper function

* remove unnecessary helper function

* update validation test cases

* WIP

* WIP 2

* Remove validationConfigMap from widget and add to properties

* Update data tree validator to get validation from the correct place

* Minor reference fixes

* Fix test mocks

* fix for bad setting of nested property path

* add test for migration for chart widget function

* fix test for widget utils

* remove unused import;

* remove unsued import

* update migration version

* remove console and add check if data is array

* fix custom fusion chart + validation not working issue

* move custom fusion chart config to chart data section

* remove console and unused import

* fix test

* fix property config test

* fix dynamicbinding path list in migration

* remove old chart validation

* remove old validation test

* fix widget prop utils test

* remove array codepath for widget utils

* fix utils test

* fix utils test

* fix prettier issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-26 16:05:59 +05:30
Rishabh Saxena
46b67577dd
Check if localstorage is supported (#3974) 2021-04-26 14:48:39 +05:30
vicky-primathon.in
e0130336eb added lib for excel export 2021-04-26 12:40:24 +05:30
Hetu Nandu
c92eb0e5a4
Introduce different evaluation types for different binding fields (#3834) 2021-04-26 11:11:32 +05:30
Hetu Nandu
05e935b0a0
Fix flaky tests (#4133) 2021-04-23 20:54:42 +05:30
akash-codemonk
7291ce70e6
Revert ExecutionParams test change (#4132) 2021-04-23 19:53:26 +05:30
akash-codemonk
36532cbcc8
[Feature] Debugger logs (#3633) 2021-04-23 19:20:55 +05:30
Paul Li
37b8a054e8 [Bug-4023] : Incorrect placeholder in the datepicker widget
-- Change date format to `YYYY-MM-DD HH:mm`
2021-04-23 08:08:37 -04:00
Hetu Nandu
11e9276964
Fix set evaluated tree performance tracking 2021-04-23 17:04:33 +05:30
Pawan Kumar
ce4ae70377
add check for root existence (#4120)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-04-23 14:45:19 +05:30
vicky-primathon.in
2cd932ce80 Fix date string parsing for date from input field 2021-04-23 13:34:37 +05:30
Pawan Kumar
1717b0e392
[Feature] Grid Widget (#2389)
* Updated test

* updated assertions

* Resizing image to take full width of table cell

* updated assertion

* Stop updating dynamicBindingPathList directly from widget

* Fix selectedRow and selectedRows computations

* Fix primaryColumns computations

* Updated test for derived column

* Added tests for computed value

* Added check clear data

* Reordering of test

* updated common method

* Made image size as 100% of table cell size

* add templating logic

* Updated flow and dsl

* Clear old primary columns

* Updated testname

* updated assertion

* use evaluated values for children

* Fix primary columns update on component mount and component update

* add isArray check

* remove property pane enhancement reducer

* add property pane enhancement reducer

* disable items other than template + fix running property enchancment on drop of list widget

* disbled drag, resize, settingsControl, drag for items other than template

* add grid options

* uncomment the widget operation for add child for grid children

* handle delete scenario for child widget in list widget

* WIP: Use the new delete and update property features

* add listdsl.json for testcases

* add test cases for correct no. of items being rendered

* add test cases currentItem binding in list widget

* change dragEnabled to dragDisabled

* change resizeEnabled to resizeDisabled

* change settingsControlEnabled to settingsControlDisabled

* change dropEnabled to dropDisabled

* update settingsControlDisabled default value

* Use deleteProperties in propertyControls

* Fix unsetting of array indices when deleting widget properties

* remove old TableWidget.tsx file

* Fix derived column property update on primary column property update

* Handle undefined primary columns

* Fix filepicker immutable prop issue

* Fix object.freeze issue when adding ids to the property pane configuration

* fix widget issue in grid

* Fix column actions dynamicBindingPathList inclusion issue

* remove consoles + fix typo around batch update

* Remove redundant tests

* js binding test for date picker

* hydate enhancement map on copy list widget

* check for dynamicleaf

* fixes

* improve check

* fix getNextWidgetName

* update template in list widget when copying

* updating template copy logic when copying widget

* update dynamicBindingPathList in copied widget

* Add path parameter to hidden functions in property pane configs

* fix copy bug when copying list widget

* add computed list property control

* Remove time column type

Fix editor prompt for currentRow

Fix undefined derivedColumns scenario

Remove validations for primaryColums and derivedColumns

Fix section toggle for video, image and button column types

* Fix table widget actions and custom column migrations

* Add logs for cyclical dependency map ♻️

* Process array differences

* add property control for list widget

* Fix onClick migrations

* Property pane config parity

* binding and trigger paths from the property pane config (#2920)

* try react virtualized library

* Fix unit test

* Fix unit test 

* Fix minor issues in table widget

* Add default meta props to binding paths to ensure eval and validation

* Dummy commit 🎉

* Remove unnecessary datepicker test

Fix chart data as string issue

* Achieve table column sorting and resizing parity with release

* handle scenario where last column isn't available to access

* Fix for panel config path not existing in the widget

* Fix bindings in currentRow (default)

Add dummy property pane config for canvas widget

* Update canvas widgets with dynamicPathLists on delete of property paths

* Add all diffs to change paths and trim later

* Add back default properties 🚶🏻‍♂️

* Use object based paths instead of arrays for primaryColumns and derivedColumns

* Fix issue in reordered columns

* Fix inccorect update order

* add virtualized list

* Fix failing property pane tests

* minor change

* minor list widget change

* Remove .vscode from git

* Rename ads to alloy

Fix isVisible in list widget

* move grid component to widget folder

* fix import in widget registry

* add sticky row in virtualized list

* add sticky container

* Fix Height of grid widget items container

* fix dragging of items in children other than template children

* update list widget

* update list widget

* Fix padding in list widget

* hide scrollbar in list widget list

* fix copy bug in list widget

* regenrate enhancement map on undo delete widget

* Use enhancementmap for autocomplete in list widget

Basic styles for list widget scrollbar

* add custom control in widget config

* minor commit

* update scrollbar styles

* remove unused variable

* fix typo in custom control

* comment out test cases

* remove unused imports

* remove unused imports

* add JSON stringify in interweave

* add noPad styling in dragLayer for noPad prop

* implement grid gap

* add list item background color prop

* add white color in color picker control

* fix gap in last list item

* remove onBeforeParse in textcomponent

* remove virtualization in grid widget

* allow overflow-y

* add onListItemClick action

* add beta label

* add pagination

* fix actions in pagination in list widget

* add list widget icon

* add list background color default value

* remove extra div

* fix pagination issue

* fix list widget crashing on perpage change

* extract child operation function to widgetblueprint saga

* refactor enhancements

* add enhancement hook

* refactor propertyUpdate hook enhancment

* remove enhacement map

* revert renaming ads to alloy

* add autopagination

* Cleanup unused vars

Re-write loop using map

Fix binding with external input widget

* update default background color

* remove unnessary scrol + fix pagination per page

* remove console.log

* use grid gap in pixel instead of snap

* fix list widget tests for binding

* add tests for on click action and pagination

* remove unnecessary imports

* remove overflow hidden in list component

* Add feature to enable template actions

* update property pane help text for list widget

* disable pagination in editor view

* update property pane options

* add test case for action

* uncomment tests

* fix grid gap validation

* update test cases

* fix property pane opening issue for list tempalte

* Disable form widgets in list widget

* fix template issue for actions

* add validation tests for list data

* update starting template

* add selectedRow + enable pagination in edit mode

* remove extra padding in list widget + popper fix on settingDisabled

* add stop propagation for button click

* fix click event in edit mode

* disallow filepicker widget for list widget

* add test for list widget entity definition for selectItem

* remove unused imports

* fix test

* remove evaluated value for list child widgets

* add comment

* remove log

* fix copying bug in list widget

* add check for not allowing template to copy

* fix test

* add test for property pane actions

* remove unused import

* add draglayercomponent test

* add test for draggable component

* add test for evaluatedvalue popup

* add test for messages.ts

* add test for widgeticons

* add test for property pane selector

* add test for widget config response

* start testing widget configresponse

* add test for enhancements in widget config

* add test for codeeditor

* add test for base widget + list widget

* add test for executeWidgetBlueprintChildOperations

* remove unused import

* add test for widget operation utils

* remove unused import

* add test for handleSpecificCasesWhilePasting

* remove unused function

* remove unused import

* add empty list styling

* resolve all review comments

* fix message test

* add test for widget operation utils

* fix merge conflicts

* move validations in property config

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-04-23 11:13:13 +05:30
Paul Li
d099a3954e [Bug] : Input widget validation issues#3860
-- Rewrite the validation for number type
2021-04-22 04:32:23 -04:00
vicky-primathon.in
3abd6416e9 Created Scrollbar thumb components and used useMemo for optimizatized rendering of table header component 2021-04-22 10:13:54 +05:30
Nidhi
6b31aa333b
Introducing Google Sheets Plugin (#3517)
* cherry pick -make new

* revert to enable fix from release

* attempt to hook into existing datasource editor

* gSheets plugin skeleton from Rest API

* Changes for database migration

* fix for auth code

* separate it out

* action page loads!

* add to explorer

* create action from datasource

* Editor JSON WIP

* working query form

* Editor JSON WIP

* import to

* fix toast message

* redirect from datasource and editor pages

* fix onboarding

* fix imports and constants

* refactor form out

* refactor queryForm

* Merge branch 'release' into feature/google-sheets

* Merge branch 'release' into feature/google-sheets

* initial values from settings, editor and form

* Check

* remove dangling code around lightTheme

* Safety net

* remove class

* try mouseover solve

* force click

* changes from review

* fix action form name on import

* Merge branch 'release' into feature/google-sheets

* minor cleanup

* Merge branch 'release' into feature/google-sheets

* WIP

* Google sheets changes

* Merge conflicts

* Merging and fixes, needs refactoring

* Check

* Merge branch 'release' into feature/google-sheets

* Fixed tests

* Add cloud services env variable

* Clean up saga

* Clean up

* Refactoring

* Deleted svg file

* Minor fixes

* Modified design to allow behaviour in google sheets methods (#3486)

* Modified design to allow behaviour in google sheets methods

* Review changes

* Removed sysout

* Added handling of edge cases with table data

* Merge branch 'release' into feature/google-sheets

* Fixes

* Fixes

* Added validations

* Improved tests

* Removed extraneous injected bean

* Review changes

* Fixed bug with method

* Changes to Google sheets plugin's request and response structures (#3692)

* Method changes

* Removed logging

* Renaming options

* Reverting pom version

* Modified type of collection variables, fixed errors

* Converted row offset field to one that supports dynamic bindings

* Review changes

* List SAAS plugin type actions under lightning menu apis (#3820)

* list saas plugin type actions under lightning menu apis

* combine saas plugin type actions in the other sub menu of lightning menu

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* Fix merge issues

* Prettified query editor and a few fixes w/ ux

* Test fixes

* Reformatting request

* code for REST added (#3876)


Co-authored-by: hetunandu <hetu@appsmith.com>

* Renamed body to row object

* Renamed placeholder for range

* Renamed range heading

* Modifications to handle range semantics

* Use spreadsheet Url instead of id

* Ordering of methods

* Removed logging

* Add tests for Dynamic text controls

* Add tests for url helpers

* Fix coverage config

* Nevermind

* Interface changes

* There is no body here

* Yay to hints

* Delete row field is separately handled as row index

* placeholder support (#4001)

* Fixed tests, typos and creating new sheets with random rows

* Switched to using 'rowIndex' throughout

* binding path added for query input field (#4016)

* - Fixed QA bugs (#4032)

- Split delete sheet into two
- Removed dynamic query input types from hidden keys

* Proper exceptions

* Removed extra logging

* Throw exception if update method does not match any of the columns

* Same for bulk update

* Zero-indexed delete row

* I'm a space bound rocket ship

* Logic to register installations with cs (#4062)

* Logic to register installations with cs

* Clean up

* Casting to string

* Checking to see if this makes the test pass

* Added an extra null check

Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-04-22 09:00:09 +05:30
vicky-primathon.in
1474aa01e3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-21 21:27:55 +05:30
vicky-primathon.in
e9055a6521 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/multi-select-values-reset 2021-04-21 21:26:19 +05:30
vicky-primathon.in
eea0472a72 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/filepicker-clear-files 2021-04-21 21:25:47 +05:30
vicky-primathon.in
c42839180e Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-21 21:25:19 +05:30
Hetu Nandu
4d73e7e0b3
Widget validation for nested property paths (#3947) 2021-04-21 20:04:25 +05:30
Nikhil Nandagopal
a13fe4369e updated the default table data to guide users to connect a datasource 2021-04-21 16:10:45 +05:30
Satish Gandham
f7794495d7
Fix Map Widget crash #3843 (#4031)
* Fix map method being called on undefined varaible in MapComponent #3843
Sentry Issue: APPSMITH-N5

* Add type to marker property #3843

Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-04-21 14:55:35 +05:30
Hetu Nandu
6c681ef98c
Fix initial value check for action form config (#4080) 2021-04-21 13:18:24 +05:30
Vicky Bansal
318cb78464
Escape line break characters when exporting table data to CSV (#3757) 2021-04-20 16:17:06 +05:30
Trisha Anand
eeaa26a7cc
Type migration from String to Object for plugin specified templates to preserve boolean and any other future data types (#4053)
* WIP : Type migration from String to Object for value

* Migrating config from string to boolean for prepared statement.
Handled error for already stored actions where PS config is stored as String and not Boolean.
2021-04-20 16:09:48 +05:30
dependabot[bot]
ff3c5cf37f
Bump ssri from 6.0.1 to 6.0.2 in /app/client (#4060)
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](https://github.com/npm/ssri/compare/v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-20 15:59:30 +05:30
NandanAnantharamu
302181bf48
WIP: Added new test for Text widget (#3953)
* Added new test for Text widget

* Added tests for text widget property panes

* updated tests
2021-04-20 14:29:52 +05:30
Apeksha Bhosale
333c4169eb
name can't be read from empty object (#3958) 2021-04-20 12:26:30 +05:30
NandanAnantharamu
256f64aefc
Removed test for collapse/open Property pane (#4059) 2021-04-20 11:28:30 +05:30
Apeksha Bhosale
568269e8e1
size change for raw and editor in API editor (#3984)
* size change for raw and editor in API editor

* removed from global css file

* removed classes
2021-04-20 11:13:26 +05:30
Apeksha Bhosale
f509f1b50b
datasource edit should be always enabled (#3979) 2021-04-20 11:12:25 +05:30
vicky-primathon.in
385011daa0 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-image-cell-align 2021-04-19 22:17:20 +05:30
Hetu Nandu
59ad172d81
Hot fix redirection race in oAuth autorisation flow (#4052) 2021-04-19 18:47:27 +05:30
vicky-primathon.in
faaf2e3345 Scroll should not be required for header in default table 2021-04-19 17:02:31 +05:30
vicky-primathon.in
934563a154 Removed background from selected dropdown item in table widget filters 2021-04-19 13:32:23 +05:30
NandanAnantharamu
1c10279945
Updated profile tests (#4002) 2021-04-19 13:31:05 +05:30
Trisha Anand
eaa24ca894
[Bug Fix] : Fetch actions by id during refactor action name to solve IncorrectResultSizeDataAccessException for pages where duplicate action names exist (#4030)
* New dto for refactoring action name which includes actionId as well

* Refactor action name now also takes actionId as payload and fetches the action from db by id instead of name to solve for the scenario where the action names could be duplicated.

* Adding actionId to QP of action refactor API.

* WIP : test for asserting the bug fix

* WIP test

* Fixed the test case asserting refactoring works for an action when there are duplicate action names in the page.

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-04-19 12:35:10 +05:30
vicky-primathon.in
2b8ab8dc8f Align page number text in table pagination 2021-04-19 11:12:18 +05:30
vicky-primathon.in
7a9dfb2066 Fixed table image cell alignment
Added cypress test to validate image cell alingment
2021-04-19 10:31:17 +05:30
vicky-primathon.in
15521fef06 Fix horizontal scrollbar 2021-04-19 09:02:47 +05:30
NandanAnantharamu
812e73a881
Basic DS test scenarios (#4026) 2021-04-16 16:08:41 +05:30
vicky-primathon.in
89af3501aa Removed vertical scroll bar from table header 2021-04-15 16:37:54 +05:30
Trisha Anand
9b49308abe
Adding dependency relationship to plugins (#3997)
* Added dependencies to be added to dependencyMap on client to Postgres, MSSQL, MySQL and Mongo plugins

* Added Dependency config for API

* Fixed the test case
2021-04-15 11:36:41 +05:30
vicky-primathon.in
c8c0ca929e fix 2021-04-15 11:12:45 +05:30
vicky-primathon.in
a3d74c692a removed unnecessary tests 2021-04-15 11:06:03 +05:30
vicky-primathon.in
f46beeb4c6 Reverted changes to ScrollIndicator file name 2021-04-15 11:03:09 +05:30
vicky-primathon.in
99ea7db01b Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/native-scrollbars-experience 2021-04-15 10:44:46 +05:30
vicky-primathon.in
d224f2921d Fix scrollbars 2021-04-15 10:31:06 +05:30
NandanAnantharamu
3a52f51af0
WIP : Updated test for page spec (#3749)
* Updated test for page spec

* Updated test for pages with widget

* updated test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-04-14 13:44:06 +05:30
vicky-primathon.in
1e6a0e8e92 Fix filepicker widget delete file not working
Added cypress test case to test selected file deletion works
2021-04-13 16:55:50 +05:30
Vicky Bansal
4778b0a450
Fix Table column names allowed to have spaces when editing in property pane panel titles (#3869)
Added cypress test to validate name formatting
2021-04-13 16:33:13 +05:30
vicky-primathon.in
3dc6e0884d Added cypress test case to test multi selected dropdown options are cleared in form reset 2021-04-12 13:07:05 +05:30
Vicky Bansal
d6399c2e48
Disable pagination controls when the table has a single page (#3895)
* Disable input number field when there are no pages to navigate to

* Added cypress test to validate table pagination is disabled
2021-04-09 16:06:50 +05:30
Vicky Bansal
791e8195b1
Align column headers when aligning columns (#3885)
* Align table column header title with table columns

* Added cypress test to validate column header text alignment
2021-04-09 16:04:01 +05:30
Vicky Bansal
43720123d8
Fix: Select Table Widget when a row is selected (#3871) 2021-04-09 16:03:22 +05:30
vicky-primathon.in
53d1333530 use derivedProperty selectedIndexArr instead of computing selectedIndexes 2021-04-09 15:50:48 +05:30
vicky-primathon.in
1db50eb527 Custom scrollbar changes 2021-04-09 12:34:31 +05:30
Rishabh Saxena
d8f2211b70
Fix edit and fork buttons visible simultaneously on the viewer header (#3723) 2021-04-08 14:12:13 +05:30
Kaushik Varanasi
c37adc0a4d
Fix spacing of fields in org settings: fixes (#3612) (#3681)
* add row colums styling to organisation settings fields

* add tests to make sure the grid layout is rendered

* added margin to make spacing look similar to before

* remove negative margin and reduce width

* added jest tests to make sure component mounts and that it has correct styles

* revert unnecessary changes related to cypress tests

* added strict checking for null to avoid ts errors

* use early returns on file empty

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* use early returns on file empty

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* fixed typo

* added findbytext for sync call

* removed unused imports

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-08 11:20:26 +05:30
Trisha Anand
df993efcde
Updated the DSL to change primary columns for an array to a map structure in the DSL (#3905) 2021-04-07 18:22:52 +05:30
Hetu Nandu
28995e5b53
Fix PS and smart substitute true false value (#3896) 2021-04-07 16:06:17 +05:30
Abhinav Jha
f5b97e3863
Fix column ordering in table widget (#3755) 2021-04-07 06:33:30 +05:30
NandanAnantharamu
547a9a7ee0
Added tests for Oauth and Stubbed tests (#3463)
* Added tests for Oauth and Stubbed tests

* updated tests

* test updated

* updated DS tests

* review comments incorporated

* flag removed

* postinvite stubbed

* intercept req added and chromewebsecurity flag added

* Update app/client/cypress/support/commands.js

* updated header request

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-06 18:59:27 +05:30
vicky-primathon.in
b2ab89c2c5 add react custom scrollbar types 2021-04-06 17:01:52 +05:30
Hetu Nandu
8bdc491a81
Hot fix for plugin form not downloaded for onboarding (#3879) 2021-04-06 15:47:25 +05:30
Rishabh Saxena
d13f755ba8
Update GTM script (#3711) 2021-04-05 20:54:22 +05:30
NandanAnantharamu
8cd6c95e70
updated table property pane test (#3837)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-04-05 17:25:27 +05:30
Apeksha Bhosale
48790ce6ca
Array support hidden field (#3809) 2021-04-05 15:41:04 +05:30
vicky-primathon.in
a24f8ae6ae Added react-custom-scrollbars 2021-04-05 14:52:55 +05:30
Kaushik Varanasi
8f8b7b281f
Fixes error on failed github docs fetch (#3665)
fixes #3551
2021-04-05 14:07:04 +05:30
Vicky Bansal
6b26e400a8
Bug fix for table crash #3645 (#3849) 2021-04-04 01:10:12 +05:30
Hetu Nandu
af5f6544ea
Always guarantee to fetch Api plugin forms (#3847) 2021-04-02 15:17:37 +05:30
Rishabh Saxena
244930dd69
Add support of component unit testing (#3828)
Update jest config, add msw hooks
2021-04-02 15:17:16 +05:30
Abhinav Jha
28921e0324
Fix table width on drag (#3839) 2021-04-02 13:48:30 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties (#3167) 2021-04-01 14:00:33 +05:30
Arpit Mohan
91a7acea49
Adding table plugin in the Rich text editor (#3799)
* Add Table button in RTE Toolbar

Co-authored-by: Aswath K <aswath.sana@gmail.com>
2021-04-01 13:54:42 +05:30
dependabot[bot]
68e405a746
Bump y18n from 4.0.0 to 4.0.1 in /app/client (#3817)
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-01 10:39:29 +05:30
Apeksha Bhosale
1f216167c4
removing new lines while showing url path field (#3717)
* added 2 states for path field

* added logic for compact only

* added small condition for no compact

* PR comments fixed

* removed redundant code

* added unit test for code editor functions

* Update app/client/src/components/editorComponents/CodeEditor/index.tsx

* setting cursor

setValue is resetting cursor position to the front.  so will update at the end

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-03-31 17:58:29 +05:30
Apeksha Bhosale
834fc3caf7
showing save datasource option all time (#3695)
* showing datasource

Exposing 'save as datasource' with empty path but in disable state till value is entered

* sending flag instead of value

* removed classname

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-31 16:09:13 +05:30
Rishabh Saxena
7ffc0d3786
Ignore cypress/no-unnecessary-waiting (#3794) 2021-03-31 14:05:19 +05:30
Hetu Nandu
0c77051944
Improve performance monitoring (#3790) 2021-03-31 13:10:59 +05:30
Ashok Kumar M
3bce03173a
Fix: Property pane improvements and bug fixes (#3766)
* Fix: Propane improvements bug fixes

* Adding plus indicator for New modal action.
2021-03-31 11:21:24 +05:30
vicky-primathon.in
b30ced453f Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-31 11:03:34 +05:30
Aswath K
a6afa8ce4d Makes isFilterable true by default for DropdownWidget 2021-03-31 08:42:27 +05:30
Aswath K
b447aa8345 Allow removing filter on Dropdown Widget 2021-03-31 00:35:17 +05:30
Abhinav Jha
10159fc442
Fix #3752 DatePicker tries to auto parse the defaultDate (#3753) 2021-03-30 14:32:25 +05:30
Hetu Nandu
aec7e613ad
Update dropdown font size and shadow (#3680) 2021-03-30 14:18:14 +05:30
Ashok Kumar M
984fbecac5
Fix: Adding debounce for renaming tabs. (#3758) 2021-03-30 13:44:25 +05:30
Pawan Kumar
d8b9b8e918
Fix: TypeError: e.widgetName is undefined and TypeError: Cannot read property 'toUpperCase' of undefined (#3694)
* call toUpperCase() only when widgetName exists

* use lodash instead of string class functions

Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
2021-03-30 11:20:00 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
dependabot[bot]
b4b903278c
Bump lodash-es from 4.17.11 to 4.17.14 in /app/client (#3738)
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-30 10:38:34 +05:30
Ashok Kumar M
bf21c15ba9
Feature: Property pane enhancements(Bug fixes + Draggable popper) (#3748)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 21:17:22 +05:30
Rishabh Saxena
3f55e16b35
Fix onboarding test spec: check res instead of req to verify if the datasource was created successfully (#3747) 2021-03-29 19:51:50 +05:30
hetunandu
b0580e9ee0 Revert "Feature: Property Pane improvements (#3561)"
This reverts commit 3437c16ef0.
2021-03-29 16:58:22 +05:30
Ashok Kumar M
3437c16ef0
Feature: Property Pane improvements (#3561)
* Fix: On renaming a widget via entity explorer the canvas gets resized

* Fix: Close prop pane on resize start of unselected widget.

* Fix: Match all - corejs polyfill

* Fix: Proppane not updated properly when same type widgets are selected.

* Feature: Draggable Proppane.

* Bug fixes for draggable popup.

* Fix: Property pane editor when selecting another widget.

* resolve rebase bad merges.

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fix

* cytest fixes

* cytest fix

* fixing draggable components inside porp pane.

* Adding cypress test.

* refactored Draggable list POC version

* reverting unwanted changes.

* prop pane bug fix

* unwanted dependencies.

* double click to open prop pane.

* Fixing bugs in draggable prop pane.

* one click prop pane open.

* ignore drag/resize click captures

* make prop pane draggable only via drag handler.

* Fixed property pane title.

* converting layer to hook and adding it to top most layer.

* removing irrelevant comments.

* close panel when widget changes.

* fixing cytests.

* bug fix

* fixing cytest

* Addressing code review comments.

* bug fix
2021-03-29 15:28:52 +05:30
Apeksha Bhosale
8983940a30
Merge pull request #3659 from appsmithorg/fix/new-field-POST-change
Added index check to add content type in existing field
2021-03-29 15:26:03 +05:30
Hetu Nandu
55f65a9fe5
fix default override same value (#3691)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2021-03-29 12:44:16 +05:30
vicky-primathon.in
b153a0e78a Show header scrollbar always if needed 2021-03-27 11:36:42 +05:30
Nidhi
683176fc48
Increased default limit for webclient payload (#3718)
* Increased default limit for webclient payload
2021-03-26 21:34:10 +05:30
prapullac
d9417dc043
Adding test ideas for Switch widget (#3490)
* adding test ideas for Switch widget

* reset  widget for date change
2021-03-26 14:08:10 +05:30
Apeksha Bhosale
84ebd4324f
Updated link for datasource whitelist url (#3679) 2021-03-26 13:41:15 +05:30
prapullac
cee1b86f32
Adding test ideas for Edit profile (#3700) 2021-03-26 12:51:46 +05:30
Rishabh Saxena
973a70a624
Fix editor help menu background color and icon size (#3686) 2021-03-26 12:18:15 +05:30
Apeksha Bhosale
eab1f8372a Merge branch 'release' into fix/new-field-POST-change 2021-03-26 09:33:52 +05:30
abhishek nayak
5114ca75c4
Merge pull request #3706 from appsmithorg/fix/filteredData-columnProperties
Fix #3381: Table column properties now map correctly when filtering, sorting or searching
2021-03-26 01:30:03 +05:30
Abhinav Jha
5b3547c104 Fix filter condition functions
Fix issue where column properties don't update based on filters and sorting and search
2021-03-26 01:18:40 +05:30
vicky-primathon.in
ea701de662 Added unit tests 2021-03-25 23:58:09 +05:30
vicky-primathon.in
45d7a5fe0b Added unit tests 2021-03-25 23:46:56 +05:30
vicky-primathon.in
b6f21b00e0 Added unit tests 2021-03-25 23:28:51 +05:30
vicky-primathon.in
b6d47a078d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-25 23:20:35 +05:30
vicky-primathon.in
e79f6c8806 Fix horizontal and vertical table scrollbars
Hide scrollbars during resize
2021-03-25 21:46:22 +05:30
NandanAnantharamu
424a1cbf69
SwitchWidget within FormWidget tests (#3501)
* added test with switch widget within farm widget

* Added another usecase with Switch

* added wait

* updated locators

* minor update

* add locators for switch widget spec

* removed waits and replaced with suitable assertions

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-25 21:38:16 +05:30
NandanAnantharamu
378330815b
Added test for tableWidget bug (#3528)
* Added test for tableWidget bug

* updated test

* review comment incorporated

* updated collapse pane test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-25 16:31:51 +05:30
Rishabh Saxena
f2160d61e1
Fix onboarding Cypress test (#3678) 2021-03-25 13:23:56 +05:30
Apeksha Bhosale
4c464787a1
code folding in response and request (#3658) 2021-03-25 10:57:00 +05:30
Abhinav Jha
1ccece69e1
Custom FusionCharts Config (#2670)
* Property pane enhancements

- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.

* Add chart type: "Custom FusionChart" (#2996)

Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
2021-03-25 03:35:04 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display (#3607) 2021-03-25 00:55:38 +05:30
Vicky Bansal
f2e0ed29c5
Update: DatePicker validates data as ISO 8601 string (#3397) 2021-03-24 17:42:24 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type (#3569) 2021-03-24 16:54:10 +05:30
Vicky Bansal
5ba4cc4400
Table Widget: Show null values as empty cells (#3522)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-24 14:33:48 +05:30
Vicky Bansal
06231e0f5f
Fix crash on Tabs property bindings (#3640) 2021-03-24 14:28:00 +05:30
Vicky Bansal
eb2c551def
DatePicker Widget: Additional date formats (#3162)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-24 14:23:39 +05:30
Hetu Nandu
9a4c317f20
Store value improvements (#3663) 2021-03-24 10:39:47 +05:30
abhishek nayak
2e53c79464
Update ForkApplicationModal.tsx 2021-03-24 00:35:46 +05:30
vicky-primathon.in
f4d25f6b2e Renamed ScrollIndicator to VerticalScrollIndicator
Common css moved to DefaultTheme
2021-03-23 20:51:13 +05:30
prapullac
9da0d7abf6
Added test ideas for Table and Hide feature of the page (#3594) 2021-03-23 17:56:31 +05:30
Apeksha Bhosale
28a4b4a6d6 test case fixed
it was checking 3rd key:value pair for content type but with changes it will added to first empty field (0th)
2021-03-23 16:55:21 +05:30
Apeksha Bhosale
5d71e86f43 Test case and refactor code 2021-03-23 15:14:44 +05:30
Hetu Nandu
2dd1791810
Refactor and add unit tests to API interceptors (#3647) 2021-03-22 14:52:24 +05:30
Hetu Nandu
f345619f40
Fix code coverage generation file (#3655) 2021-03-21 12:02:47 +05:30
Hetu Nandu
f1cb2a35b7
Add jest coverage diff reporting action (#3651) 2021-03-20 19:28:10 +05:30
Hetu Nandu
52c7f5331a
Trigger client integration only on approved PRs (#3632)
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
2021-03-19 14:21:14 +05:30
Hetu Nandu
64116583e3
Fix container widget dynamicBindingPathList correction (#3619) 2021-03-19 11:39:35 +05:30
NandanAnantharamu
a82c789c1a
udpated tests (#3617)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-19 11:19:54 +05:30
Nikhil Nandagopal
6b7fcc4c5d
Merge pull request #3615 from appsmithorg/minor-globalsearch-fixes
Minor globalsearch fixes
2021-03-19 11:17:00 +05:30
vicky-primathon.in
5fa3f3abd9 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-19 00:39:24 +05:30
vicky-primathon.in
bb77794125 handle scrollbar changes 2021-03-19 00:39:13 +05:30
Kaushik Varanasi
55c17a66aa
Fix success message for single user invite and multiple user invite (#3591)
* Fixed error message for single user invite

* updated success message for single user invite and created tests

* use state to detect and update the number of users invited

* removing unnecessary lines

* typo
2021-03-18 19:20:33 +05:30
hetunandu
12aba25a00 Remove page save event from frontend 2021-03-18 19:15:57 +05:30
Pawan Kumar
80895b876b
Enhancement: Virtualized Query Editor Table (#3496)
* add react-window on react-table

* remove .vscode launch.json

* add cellwrapper

* fix height issue in virtualized table

* useBlockLayout in Table

* add border-right on table row

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-18 18:40:57 +05:30
Rishabh Saxena
8acb365201 Fix placeholder 2021-03-18 18:19:05 +05:30
Rishabh Saxena
660b00b4d5 update title 2021-03-18 18:17:09 +05:30
Rishabh Saxena
82cd1b33ba fix document icon styles 2021-03-18 18:14:37 +05:30
vicky-primathon.in
354405d975 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-18 13:01:36 +05:30
Kaushik Varanasi
5f80e2561e
Merge pull request #3572 from appsmithorg/bugfix/trunncate-org-name-settings
add ellipsis to org name in settings
2021-03-18 12:39:52 +05:30
vicky-primathon.in
fb7cea6ec6 Resolved conflicts 2021-03-18 11:07:16 +05:30
ram-primathon
8b21dd30fd
add icon and subText in ads dropdown (#3598) 2021-03-18 02:06:26 +05:30
Hetu Nandu
441bb368d2
Reduce flakiness by adding waits (#3605) 2021-03-18 02:02:16 +05:30
Hetu Nandu
0debe37637
Add arbitary wait on onboarding test (#3604)
We recently changed the test to make sure we wait for the client to create an onboarding data source if it did not exist. This kind of check was also happening on the source code, and the complexity was not getting translated properly in the tests.

To improve the reliability of the test, I added an arbitrary wait time before we start the building
2021-03-17 23:59:40 +05:30
vicky-primathon.in
5f2d994fda Fix double imports 2021-03-17 18:00:16 +05:30
Vicky Bansal
1195a0b694
Reset selected row(s) when table data is changed (#3576)
* Fixed selected row resets when table data is changed

Added cypress test case to test selected row resets when table data changes

* Fixed cypress test case
2021-03-17 17:27:38 +05:30
vicky-primathon.in
f92a8d7fa6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:22:26 +05:30
vicky-primathon.in
9e65136a75 Merge branch 'fix/table-scrollbar' of https://github.com/appsmithorg/appsmith into fix/table-scrollbars 2021-03-17 17:21:37 +05:30
vicky-primathon.in
212cd423b5 Added horizontal scrollbar component
Add horizontal and vertical scrollbars in table widget
2021-03-17 17:15:49 +05:30
Nidhi
084faf8d54
Typo ¯\_(ツ)_/¯ (#3595) 2021-03-17 17:04:53 +05:30
Hetu Nandu
b32cdfc8cb
Remove property pane custom scrollbar for cypress (#3592) 2021-03-17 15:56:34 +05:30
Rishabh Saxena
0e3901953b
Fix specs (#3577) 2021-03-17 15:06:08 +05:30
Kaushik Varanasi
8fd0509bcb Merge branch 'release' into bugfix/trunncate-org-name-settings 2021-03-17 12:45:13 +05:30
NandanAnantharamu
8aca378028
updated flaky test (#3584)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-17 10:38:00 +05:30
Kaushik Varanasi
f9d2318e5a reconciling with current release 2021-03-17 00:22:01 +05:30
Kaushik Varanasi
dfa23a6944 added tests, documentation and better naming convention 2021-03-17 00:18:36 +05:30
Apeksha Bhosale
3dc04901c8 added index check to add content type in existing field 2021-03-16 19:57:21 +05:30
Kaushik Varanasi
2dcecfbf79 add ellipsis to org name in settings 2021-03-16 13:22:25 +05:30
hetunandu
eed140f945 stringify page save analytics 2021-03-16 11:01:48 +05:30
Ashok Kumar M
fc34901be8
Fix: Dynamic Canvas Height based on bottom most widget. (#3398)
* Fix: Dynamic Canvas Height based on bottom most widget.

* Checking cytest failure reason.

* Revert "Checking cytest failure reason."

This reverts commit 2e3aaa882b282e10e1cf491633101293b72ffa89.

* Using UPDATE_CANVAS_LAYOUT to update the layout.

* Remove unwanted declarations.

* Adding comments.
2021-03-16 10:31:37 +05:30
ram-primathon
3b0fb539d5
Property Pane re design (#3057)
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-15 17:47:56 +05:30
Vicky Bansal
03be391fa3
Wrap evaluated data in computed value field (#3520) 2021-03-15 15:27:43 +05:30
Vicky Bansal
7c994da6e9
Allow null/empty values in Dropdown widget options (#3533) 2021-03-15 15:25:37 +05:30
Vicky Bansal
5acf2c3238
Fully display Table Widget filter conditionals (AND|OR) (#3521) 2021-03-15 14:39:10 +05:30
Vicky Bansal
812344c439
Persist Table Widget cell height to use as default in deployed app view (#3537) 2021-03-15 14:34:33 +05:30
Vicky Bansal
030269f684
Display the date column output correctly in table when using JS toggle for Display date format 2021-03-15 10:59:01 +05:30
Vicky Bansal
7f43705e7f
Fixed undefined poperty error when columnOrder is undefined (#3511) 2021-03-15 10:57:34 +05:30
Rishabh Saxena
3a47e085e3
Minor global search updates (#3502)
* Update editor header help button styles

* Dont show the current entity in the recents, to keep the previous on top
2021-03-13 23:31:47 +05:30
Arpit Mohan
660c194009
Moving all toast messages to messages.ts file (#2798)
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-03-13 19:54:45 +05:30
Hetu Nandu
89effdd2fb
Refactor evaluate function and add tests (#3536) 2021-03-13 19:42:21 +05:30
Rishabh Saxena
7bd1e9587c
Use replace instead of replaceAll (#3538) 2021-03-13 16:15:51 +05:30
ram-primathon
191dde0b18
Fix API pane header and params count (#3494) 2021-03-13 13:53:46 +05:30
vicky-primathon.in
c952e9b10d Remove unnecessary scrollbar from inside table widget 2021-03-13 12:06:02 +05:30
Nikhil Nandagopal
3b2072eeb9
Merge pull request #3055 from appsmithorg/fix/rte-newline
Added defaultText and defaultHTML properties in RTE
2021-03-12 17:38:58 +05:30
Nikhil Nandagopal
261dfc308c
Merge pull request #3514 from appsmithorg/fix/file-picker
[Fix] Made bade 64 encoding the default type for S3
2021-03-12 16:29:05 +05:30
vicky-primathon.in
3da86b33fe Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-03-12 15:24:51 +05:30
Nikhil Nandagopal
6bdd39c4b8 minor fixes 2021-03-12 14:47:42 +05:30
Nikhil Nandagopal
dbb16775de updated type to enum 2021-03-12 14:43:47 +05:30
Nikhil Nandagopal
82b65e12d1 Removed the property pane 2021-03-12 14:37:24 +05:30
Nikhil Nandagopal
11c8d4f34b made files a derived prop to change based on the file data type
added file type
2021-03-12 14:34:05 +05:30
Nikhil Nandagopal
d7a5f36fea Made bade 64 encoding the default type for S3
Added a data field for file pickers that is filled based on the property pane value
2021-03-12 13:44:32 +05:30
akash-codemonk
4995288801
Show fork modal while returning back to forking after signing in (#3509)
- Show loaders where required and other styling fixes
2021-03-12 13:14:16 +05:30
Abhinav Jha
246f7de444
Preserve Table Column properties when evaluations fail (#3495)
* When there is a cyclic depenency, the table data is processed as s string, leading to incorrect column computations and a render loop. Fixed this by bailing out when table data is a string, as further computations are moot
2021-03-12 12:00:38 +05:30
Arpit Mohan
f11cd45886
Correcting the github condition to start the API server (#3506) 2021-03-12 11:06:54 +05:30
ram-primathon
5b2832f380
Fix api settings page not getting updated (#3489) 2021-03-11 17:33:23 +05:30
Trisha Anand
9f63bfafd2
Adding JSON intelligent substitution for Rest Api plugin (#3474)
* POC : null value getting handled correctly

* Refactor code. Tested with and without quotes. This is working! Woohoo!

* Added support for mustache binding to include json objects and arrays

* Added test for smart substitution.

* Added setting to turn on/off smart substitutions in Rest API plugin

* Handling turning on smart json substitution

* Added error handling

* Added config to turn on smart substitution in JSON to make the tests pass now

* Adding a beta tag to the API setting.

* Spelling error resolved.

* Incorporated review comments.

* Catching JSON Parse exception in http call.
2021-03-11 14:10:00 +05:30
Pawan Kumar
385baaddcb
Enhancement: Virtualized Query Editor Table (#3460)
* add react-window on react-table

* remove .vscode launch.json

* add cellwrapper

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-11 10:25:37 +05:30
Hetu Nandu
bc646ab9b2
Fix: Delete tabs from the entity explorer (#3405)
Co-authored-by: Akash N <akash@codemonk.in>
2021-03-11 09:48:46 +05:30
Abhinav Jha
0172430489
Fix unreachable code reported by deepsourcelabs (#3483) 2021-03-11 08:46:50 +05:30
Shrikant Sharat Kandula
65568a4e13
Add more devices in AppLayout options (#3451)
* Remove width and introduce more AppLayout type enums

* Fix: Adding min width to layout options.

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-03-11 07:51:48 +05:30
dependabot[bot]
27bc73482a
Bump elliptic from 6.5.3 to 6.5.4 in /app/client (#3480)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-11 06:40:35 +05:30
akash-codemonk
1be56a8512
Applications marked as forkable can be forked (#3453) 2021-03-10 12:38:20 +05:30
Hetu Nandu
4e4c6b76a8
Improve cylical dependency error (#3471) 2021-03-10 12:28:52 +05:30
Rishabh Saxena
08ebbe410b
Fix chat with us button at the editor help menu (#3465) 2021-03-10 11:27:17 +05:30
Sumit Kumar
b6961ce7a4
Add timeout failure for mongo plugin test datasource (#3431)
- Mongo plugin client driver does not return with exception upon first failure - instead it keeps retrying. Hence, adding timeout error to report failure before the client thread cancels due to delay in response.
- It seems that the mongdb connection string cannot be directly used for ping test, hence skipping it.
2021-03-10 11:11:14 +05:30
akash-codemonk
4fb55b4fd0
Fix: Incorrect validation of gif source in onboarding (#3448) 2021-03-10 09:44:43 +05:30
Hetu Nandu
a885fc8d3b
Fix chart data migration issues (#3458) 2021-03-09 20:05:42 +05:30
Hetu Nandu
6f4f2bb26c
Render placeholder text in the Key Value form input (#3452) 2021-03-09 17:35:29 +05:30
Ashok Kumar M
4781f1096c
Fix: Modal Size gets cut in smaller screens. (#3441) 2021-03-09 11:27:44 +05:30
Abhinav Jha
0a7bf6d0d3
Deprecate UPDATE_WIDGET_PROPERTY action (#3392)
* Deprecate UPDATE_WIDGET_PROPERTY action

* Handle JS property toggle independently
2021-03-09 11:00:57 +05:30
Hetu Nandu
9bf78a06c0
Add analytical events on page save (#3434) 2021-03-08 15:58:20 +05:30
Hetu Nandu
6898a0bbd5
Fix for Table onPageSizeChange trigger executing when not defined (#3422) 2021-03-08 14:34:00 +05:30
imgbot[bot]
243082e568
[ImgBot] Optimize images (#3435)
*Total -- 1,191.78kb -> 1,073.90kb (9.89%)

/app/client/src/assets/gifs/deploy_orange.gif -- 20.75kb -> 12.27kb (40.88%)
/app/client/src/assets/images/no_search_data.png -- 2.59kb -> 1.63kb (37%)
/app/client/src/assets/gifs/input_drag.gif -- 25.10kb -> 16.16kb (35.63%)
/app/client/src/assets/gifs/table_drag.gif -- 28.84kb -> 20.42kb (29.2%)
/app/client/src/assets/gifs/handwave.gif -- 25.54kb -> 20.12kb (21.25%)
/app/client/src/assets/images/preview.png -- 100.21kb -> 79.48kb (20.69%)
/app/client/src/assets/gifs/onsubmit.gif -- 110.27kb -> 97.65kb (11.44%)
/app/client/src/assets/gifs/super_hero.gif -- 870.27kb -> 818.03kb (6%)
/app/client/src/assets/icons/ads/link.svg -- 0.32kb -> 0.31kb (2.45%)
/app/client/src/assets/icons/ads/fluid.svg -- 0.57kb -> 0.56kb (1.37%)
/app/client/src/assets/icons/ads/entities.svg -- 0.22kb -> 0.22kb (1.32%)
/app/client/src/assets/icons/ads/tablet.svg -- 0.58kb -> 0.57kb (1.01%)
/app/client/src/assets/icons/ads/recent.svg -- 0.59kb -> 0.59kb (0.66%)
/app/client/src/assets/icons/ads/docs.svg -- 2.24kb -> 2.22kb (0.57%)
/app/client/src/assets/icons/ads/desktop.svg -- 0.73kb -> 0.73kb (0.4%)
/app/client/src/assets/icons/ads/mobile.svg -- 0.79kb -> 0.79kb (0.37%)
/app/client/src/assets/images/tick.svg -- 0.58kb -> 0.58kb (0.17%)
/app/client/src/assets/icons/ads/shine.svg -- 0.71kb -> 0.71kb (0.14%)
/app/client/src/assets/icons/ads/book.svg -- 0.85kb -> 0.85kb (0.12%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-03-08 14:32:48 +05:30
Rishabh Saxena
99b3fa6bb8
Omnibar global search (#2903) 2021-03-08 13:54:12 +05:30
Dwayne Forde
2dfc8ebf8a
Adds support for base64 image strings to image cells (#2769) 2021-03-06 01:07:49 +05:30
prapullac
d452c78453
Adding manual test cases for Table (#3325) 2021-03-05 14:02:54 +05:30
akash-codemonk
e012ea54aa
Fix: Action name being appended with a 1 when moved to another page even when there is no duplicate (#3352) 2021-03-05 13:05:15 +05:30
hetunandu
8574b86926 Merge branch 'master' into release 2021-03-05 12:06:14 +05:30
Pawan Kumar
220b28df3e
Fix: TypeError: e is undefined (#3337)
* add conditional operator

* check for widget before calling the function

* check for widget exisitence

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-05 10:04:35 +05:30
NandanAnantharamu
71f4a4b0a9
grouping another set of tests (#3404)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-03-05 00:35:41 +05:30
Hetu Nandu
2b2cee6bd6
fix chart validation (#3400) 2021-03-05 00:28:43 +05:30
Hetu Nandu
dc154b94b0
Fix widget updates not working properly (#3403)
* Fix widget updates not working properly

* Revert "Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218)"

This reverts commit 39e4990a7f.
2021-03-05 00:05:41 +05:30
Vicky Bansal
c4d6405981
Fix: RTE Error (#3385)
* Added defaultText property for text type validations to fix invalid data type beings passed to RichTextEditor component

* removed text and defaultValue properties from widget property validation map
2021-03-04 16:21:58 +05:30
akash-codemonk
39e4990a7f
Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218) 2021-03-04 15:24:01 +05:30
akash-codemonk
1e4878f983
Support editing user's name field (#3306) 2021-03-04 15:07:02 +05:30
Hetu Nandu
c81495e2cb
Fix chart data validation (#3389) 2021-03-04 13:40:22 +05:30
Rishabh Saxena
013c4230e2
Wrap ads button text within span for resilience for DOM mutations (#3292) 2021-03-04 11:34:36 +05:30
Hetu Nandu
3237950d97
End to cyclical dependency woes (#3380)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-04 10:54:47 +05:30
Ashok Kumar M
af6b3dfdbb
Fix: Drop overlay widgets anywhere and add them as main container child (#3332)
* Fix: Drop overlay widgets anywhere and add them as main container child

* Using detachFromLayout config.
2021-03-04 10:26:00 +05:30
Vicky Bansal
d3c2c02745
Fix: Tabs Widget crashes when data is invalid (#3235)
* Fixed tabs data validation and added check to ensure tab property is accessible when tabs array is not empty

* added isVisible property in validations
2021-03-03 11:29:02 +05:30
Ashok Kumar M
a7e0990cf8
Feature: Canvas Layout Options(max width config) (#3141)
* Feature: Canvas Layout Options(max width config)

* Fixing css issues.

* Changing Default Device option to Desktop.

* Changed Implementation to maintain resize updates within the client.

* Addressing code review changes.

* Updating device resolutions.

* updating cytests

* Fixing resize bug.
2021-03-03 10:56:47 +05:30
Dwayne Forde
b074a035b5
Updates json input from typing to value setting (#2805) 2021-03-03 10:34:52 +05:30
Piyush
462379721d
Reset widget global function (#3181) 2021-03-02 18:19:36 +05:30
Arpit Mohan
bf16b45f2b
Merge pull request #3309 from appsmithorg/release
Release v1.4.1
2021-03-02 13:41:51 +05:30
Rishabh Saxena
7204e87ea5
fix help modal overlapping with close button (#3289) 2021-03-02 11:26:02 +05:30
Rishabh Saxena
d48e00422e
Minor code cleanups (#3165) 2021-03-02 11:25:45 +05:30
Young Yoo
d61a900011
Fix #2712 - Duplicate Property For Map Widget (#3174)
After a Map Widget created, the text field in the Text Widget can bind the map properties. Inside the map properties, "Map center" and "Center" are duplicate value. The "MapCenter" is deleted for the adjustment.

Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-03-02 10:45:39 +05:30
imgbot[bot]
13b4d61b8f
[ImgBot] Optimize images (#3303)
*Total -- 114.50kb -> 96.16kb (16.02%)

/app/client/src/assets/images/no_data.png -- 103.98kb -> 85.71kb (17.58%)
/app/client/src/assets/icons/control/vertical_align_top.svg -- 0.17kb -> 0.17kb (2.3%)
/app/client/src/assets/icons/control/vertical_align_bottom.svg -- 0.18kb -> 0.17kb (1.67%)
/app/client/src/assets/icons/control/heading_1.svg -- 0.32kb -> 0.31kb (1.54%)
/app/client/src/assets/icons/control/vertical_align_center.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/control/back.svg -- 0.26kb -> 0.26kb (1.12%)
/app/client/src/assets/images/secure.svg -- 1.08kb -> 1.07kb (0.91%)
/app/client/src/assets/icons/control/paragraph.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/control/delete-column.svg -- 0.49kb -> 0.49kb (0.6%)
/app/client/src/assets/icons/control/hide-column.svg -- 0.52kb -> 0.52kb (0.56%)
/app/client/src/assets/icons/control/heading_2.svg -- 1.08kb -> 1.08kb (0.45%)
/app/client/src/assets/icons/control/checkmark.svg -- 0.96kb -> 0.95kb (0.41%)
/app/client/src/assets/icons/control/paragraph_2.svg -- 1.49kb -> 1.49kb (0.33%)
/app/client/src/assets/icons/control/bullets.svg -- 1.52kb -> 1.52kb (0.32%)
/app/client/src/assets/icons/control/heading_3.svg -- 1.52kb -> 1.52kb (0.32%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-03-02 10:24:47 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222)
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-02 08:43:43 +05:30
dependabot[bot]
d7b7cb26fa
Bump prismjs from 1.22.0 to 1.23.0 in /app/client (#3300)
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PrismJS/prism/compare/v1.22.0...v1.23.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-02 08:20:31 +05:30
Sumit Kumar
7d2effae18
Modify hint statement for 'import from curl' form (#3285)
- Move to hint statement out of query box and put if above it - between the label and the query box - so that user's don't confuse it as a typed in statement.

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-03-01 23:28:07 +05:30
Hetu Nandu
0b08edf5cc
Fix further cyclical dependencies in actions (#3259) 2021-03-01 20:27:15 +05:30
Hetu Nandu
df2d353fbe
Add sync meta property update function (#3293) 2021-03-01 20:26:47 +05:30
akash-codemonk
beb6eb8241
Add validation to check if organization exists during onboarding (#3243) 2021-03-01 15:21:23 +05:30
Abhinav Jha
728bebb617
Add feature to simultaneously modify and remove property paths in a widget (#3227) 2021-03-01 15:15:54 +05:30
hetunandu
557618a2bb Revert "Add sync meta property update function"
This reverts commit 54f158694f.
2021-03-01 14:53:21 +05:30
hetunandu
54f158694f Add sync meta property update function 2021-03-01 14:51:55 +05:30
RIshabh Saxena
2a868c89a6 Revert "Wrap text with span for resilience for DOM mutations by google translate"
This reverts commit e87ef2452e.
2021-03-01 13:25:05 +05:30
RIshabh Saxena
e87ef2452e Wrap text with span for resilience for DOM mutations by google translate 2021-03-01 13:24:36 +05:30
vicky-primathon.in
950c7b93bb Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-26 16:35:12 +05:30
Hetu Nandu
1f7fc9c0ed
Api form on submit (#3225) 2021-02-26 14:52:11 +05:30
akash-codemonk
0682a92d87
Update useEffect dependency (#3239) 2021-02-26 14:13:24 +05:30
Piyush
21a2a2bdf4
Redirect URL for oAuth Auth code flow (#3232) 2021-02-26 12:28:47 +05:30
Piyush
c38e58b3bc
Fix race between action reducer and handleQueryCreatedSaga (#3236) 2021-02-26 12:28:03 +05:30
Vicky Bansal
5e8805b40a
Feature: selectedOptionLabel and selectedOptionLabels in Dropdown widget (#3205) 2021-02-26 11:54:25 +05:30
Vicky Bansal
118467c5bb
Feature: Show/Hide Tabs in Tabs Widget (#3192)
* Added functionality to show/hide a tab from tab property pane controls

* Added isVisible property in tabs widget default value

* Passing visible tabs to component from widget. Added missing widgetId
2021-02-26 11:47:21 +05:30
akash-codemonk
05b2cd6d29
Fix renaming action goes to the action page (#3201) 2021-02-26 11:15:27 +05:30
Pawan Kumar
7185536c67
Fix: Cannot read property 'length' of undefined (#3207)
* update

* fix chart component on empty dataset

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-26 10:58:31 +05:30
akash-codemonk
7daeadd447
Fix current page not changing while switching to an action of another page (#3214) 2021-02-26 10:34:14 +05:30
NandanAnantharamu
4bed88d7e1
Added test for table data sorting (#2257)
* Added test for table data sorting

* commented tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-26 10:18:27 +05:30
hetunandu
3cc1fbfefd Merge branch 'release' 2021-02-25 22:36:20 +05:30
Hetu Nandu
a8889d6985
Capture cyclical dependency on sentry (#3226) 2021-02-25 22:29:00 +05:30
Abhinav Jha
3e7d2bb720 Merge branch 'release' of github.com:appsmithorg/appsmith 2021-02-25 21:39:02 +05:30
Abhinav Jha
a1bda002c0 Fix issue where renaming table data keys did not delete the previous key 2021-02-25 21:36:27 +05:30
Arpit Mohan
73d47413ff Merge branch 'release' 2021-02-25 20:43:04 +05:30
Hetu Nandu
ffeb297a1a
Fix dynamic path duplicate issue (#3223) 2021-02-25 20:42:29 +05:30
Arpit Mohan
4f16b23352 Merge branch 'release' 2021-02-25 19:34:22 +05:30
Hetu Nandu
c2646a8863
Use property config for trigger properties (#3217)
* Use triggerPaths and remove isDynamicTrigger argument

* Remove triggerMaps from widgets

* Fix property updates
2021-02-25 19:30:02 +05:30
Abhinav Jha
bdc2d46192
Add min max values to datepicker control (#3215) 2021-02-25 17:47:13 +05:30
Arpit Mohan
d420518cad Fixing merge conflicts 2021-02-25 17:29:49 +05:30
Hetu Nandu
4a557309ca
Fix eval error logging (#3206)
* Update app/client/src/utils/WidgetFactory.tsx
2021-02-25 17:23:06 +05:30
Abhinav Jha
647151e527
Internal Fix: Migration issues with Table widget (#3212)
* Fix hidden columns migration

Fix issue where column ids have spaces in them leading to a crash

* Quick fix unit tests

* Remove tableData dependencies from selectedRow and selectedRows
2021-02-25 17:21:54 +05:30
NandanAnantharamu
21eecb1fe6
WIP : Added test for chart datapoint validation (#3176)
* Added test for chart datapoint validation

* updated test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-25 12:49:23 +05:30
Rishabh Saxena
6b13347157
Fix navigation to modal widget's children from the entity explorer (#3067) 2021-02-25 12:39:33 +05:30
Piyush
8383d79c91
Remove client side validation on save for OAuth Datasource (#3131) 2021-02-25 12:01:21 +05:30
Hetu Nandu
3944d7e43e
Sort order fix if property path gets updated via multiple start nodes (#3194) 2021-02-24 21:56:00 +05:30
Abhinav Jha
e197d13399
Fix issue when searching for certain places does not return a valid list from a google maps control (#3197) 2021-02-24 20:59:12 +05:30
akash-codemonk
7fa5e3b1af
Hide pages in publish mode (#3106) 2021-02-24 19:17:37 +05:30
Abhinav Jha
868f29eaeb
Fix selected row issue in view mode (#3186)
* Fix selected row issue in view mode

* Remove un-select feature
2021-02-24 15:59:19 +05:30
akash-codemonk
791d92af94
Add validation to check if widget exists (#3140)
* Check if widget is present incase it got deleted etc.

* Update test
2021-02-24 11:30:22 +05:30
Rishabh Saxena
c0222db163
Fix editor header popovers (#3173) 2021-02-24 10:42:12 +05:30
vicky-primathon.in
b474442ec7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-23 18:11:14 +05:30
NandanAnantharamu
6c80f23201
Feature: DatePicker V2 (#2889)
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-23 18:05:09 +05:30
Hetu Nandu
17dd5345a8
Fix code editor theme colours on the property pane (#3168) 2021-02-23 16:25:22 +05:30
Hetu Nandu
3a5e0b30bb
Force light theme on the whole editor except the header (#3143) 2021-02-23 15:37:13 +05:30
NandanAnantharamu
d20d013d69
Cypress test for Tab rename from entity explorer (#2780)
* Bug automation

* Test flow completed

* Another bug automation

* Updated tests

* uncommented delete tab test

* Uncommented a test

* updated tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-23 15:08:31 +05:30
Piyush
faea2f36ff
Add support for setting.json for pluginType DB (#3156) 2021-02-23 13:57:37 +05:30
vicky-primathon.in
8b334c3064 Removed passing formatType to component as html is default output 2021-02-23 12:10:19 +05:30
Young Yoo
e5e5af204d
Fix #2342 Un-select row feature (#3074)
Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-02-23 10:19:14 +05:30
NandanAnantharamu
725043fde3
Replace test api with mockApi in Cypress tests (#2975)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-23 09:56:02 +05:30
Ashok Kumar M
d1822a9dee
Feature: Modal Widget (#3092)
* Feature: Modal Widget(DIP)

* Adding cypress tests.
2021-02-23 09:48:23 +05:30
vicky-primathon.in
3d5d51fbde Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-22 22:20:36 +05:30
Vicky Bansal
0eab1993f8
Feature: onDataPointClick trigger in Chart Widget (#2953) 2021-02-22 22:01:13 +05:30
akash-codemonk
92d1c381f1
Allow searching for page names in explorer and other improvements (#3038) 2021-02-22 19:31:46 +05:30
Hetu Nandu
6f7ce24a2f
Fix action subtree evaluation (#3142) 2021-02-22 16:44:08 +05:30
Rishabh Saxena
1d76f391da
Fix styles for the primary logo within viewer for safari (#3133) 2021-02-22 13:32:38 +05:30
Piyush Mishra
90fba15630
Fix/datasource name conflict issue (#3134) 2021-02-22 12:57:05 +05:30
Hetu Nandu
447f458656
Minor Api pane design and logic fixes (#3091) 2021-02-22 11:45:02 +05:30
Rishabh Saxena
0dab943be2
Fix app title widths for both viewer and editor (#3094) 2021-02-22 11:02:19 +05:30
Hetu Nandu
88c86fa881
Add toast for trigger errors (#3100) 2021-02-22 10:30:16 +05:30
NandanAnantharamu
03eba7ed27
Categorise tests between client and server (#2856)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-22 10:18:30 +05:30
vicky-primathon.in
c5a689b560 Added support for markdown type in RTE 2021-02-19 16:57:54 +05:30
Rishabh Saxena
a8aa41b652
Handle false (type: string) as falsy for the switch control (internal forms) 2021-02-19 16:30:07 +05:30
Abhinav Jha
4b01e7b3d6 Fix RTE text input parsing.
Fix default input type
2021-02-19 11:19:30 +05:30
Abhinav Jha
4ae81bb74e Fix text newline and html parsing 2021-02-19 11:18:16 +05:30
akash-codemonk
f0be4341f3
Fix execute action error message (#3077) 2021-02-19 11:16:54 +05:30
Abhinav Jha
59f56c8052
Internal Fix: When tables are migrated, the computedValue for the columns do not have currenRow (#3066) 2021-02-19 10:21:52 +05:30
Abhinav Jha
419d724096
Internal Fix: Issue where the property panel isn't scrolled to top when opening it (#3065) 2021-02-19 10:21:01 +05:30
Abhinav Jha
47145b7ff7
Internal Fix: migration of dynamicTriggerPathList in Table Widget(#3064) 2021-02-19 10:19:54 +05:30
imgbot[bot]
3ff938712c
[ImgBot] Optimize images (#2978)
*Total -- 1,442.90kb -> 1,261.25kb (12.59%)

/app/client/src/assets/icons/gifs/lightmode_thumbnail.png -- 13.33kb -> 4.62kb (65.34%)
/app/client/src/assets/gifs/deploy_orange.gif -- 20.75kb -> 12.27kb (40.88%)
/app/client/src/assets/gifs/input_drag.gif -- 25.10kb -> 16.16kb (35.63%)
/app/client/src/assets/images/invalid-page.png -- 3.20kb -> 2.22kb (30.49%)
/app/client/src/assets/gifs/table_drag.gif -- 28.84kb -> 20.42kb (29.2%)
/app/client/src/assets/images/appsmith_logo_square.png -- 17.63kb -> 12.84kb (27.16%)
/app/client/src/assets/icons/gifs/config_pagination_lightmode.gif -- 110.67kb -> 81.84kb (26.05%)
/app/client/src/assets/gifs/handwave.gif -- 25.54kb -> 20.12kb (21.25%)
/app/client/src/assets/images/preview.png -- 100.21kb -> 79.48kb (20.69%)
/app/client/src/assets/icons/gifs/config_pagination_darkmode.gif -- 101.19kb -> 80.38kb (20.57%)
/app/client/src/assets/gifs/onsubmit.gif -- 110.27kb -> 97.65kb (11.44%)
/app/client/src/assets/icons/gifs/darkmode_thumbnail.png -- 4.87kb -> 4.34kb (10.88%)
/app/client/src/assets/gifs/super_hero.gif -- 870.27kb -> 818.03kb (6%)
/app/client/src/assets/icons/ads/view-less.svg -- 0.25kb -> 0.24kb (3.53%)
/app/client/src/assets/icons/ads/add-more.svg -- 0.50kb -> 0.49kb (2.53%)
/app/client/src/assets/icons/ads/play.svg -- 0.23kb -> 0.22kb (2.16%)
/app/client/src/assets/icons/ads/no-response.svg -- 3.84kb -> 3.76kb (1.88%)
/app/client/src/assets/icons/ads/close-modal.svg -- 0.28kb -> 0.27kb (1.75%)
/app/client/src/assets/icons/ads/chevron_left.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/chevron_right.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/right-arrow.svg -- 0.27kb -> 0.27kb (1.44%)
/app/client/src/assets/icons/ads/fork.svg -- 0.45kb -> 0.44kb (1.31%)
/app/client/src/assets/icons/ads/lightning.svg -- 0.22kb -> 0.22kb (1.3%)
/app/client/src/assets/icons/ads/arrow-left.svg -- 0.55kb -> 0.54kb (0.71%)
/app/client/src/assets/images/tick.svg -- 0.58kb -> 0.58kb (0.67%)
/app/client/src/assets/icons/ads/shine.svg -- 0.72kb -> 0.71kb (0.41%)
/app/client/src/assets/icons/ads/book.svg -- 0.85kb -> 0.85kb (0.34%)
/app/client/src/assets/icons/ads/datasource.svg -- 0.87kb -> 0.87kb (0.34%)
/app/client/src/assets/icons/help/updates.svg -- 1.01kb -> 1.01kb (0.29%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-02-18 18:08:13 +05:30
vicky-primathon.in
2636c70410 Handled commont property for default text input type 2021-02-18 15:56:40 +05:30
vicky-primathon.in
517fe592f1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-18 15:42:45 +05:30
Hetu Nandu
e1d43992b2
Fix default value reset issue (#2861) 2021-02-17 20:32:36 +05:30
prapullac
743791a95d
Manual negative test ideas for user invite flow (#2481)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-17 20:27:18 +05:30
prapullac
8cd3a981b9
Manual test ideas for datasource query (#2763)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-17 20:22:16 +05:30
akash-codemonk
5c80e2e3e2
Update the message on the widget sidebar (#3056) 2021-02-17 11:05:24 +05:30
Pawan Kumar
503a8ae3fe
remove negative margin (#3037)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-17 10:54:56 +05:30
Piyush Mishra
74b013d909
Encode params toggle (#3006)
* Makes client side changes to support actionConfiguration.encodeParamsToggle setting.
* Add migration code.

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-16 20:31:35 +05:30
Nidhi
afc329fd7b
Added grant type Authorization code to OAuth2 (#2992)
Co-authored-by: Piyush <piyush@codeitout.com>
2021-02-16 17:58:03 +05:30
akash-codemonk
86725baf61 Update onboarding indicator animation for widget menu (#3018)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2021-02-16 17:52:15 +05:30
akash-codemonk
e604357643 Go back to application list instead of deleting app (#2981) 2021-02-16 17:52:04 +05:30
akash-codemonk
9c20ac5306 New onboarding flow (#2686)
Co-authored-by: a <rishabh.robben@gmail.com>
2021-02-16 17:51:46 +05:30
Ashok Kumar M
a55c10a8ed
Feature Switch Widget (#2999)
* Feature Switch Widget

* Center switch widget

* Adding Cypress tests and changing some nomenclature.

* Adding doc reference

* Swap label for checkbox widget.

* Addressing code review comments.

* remove swap label as exposed property

* Align widget even when label isn't present.

* Changing swapLabel property to Alignment property.

* Fixing test cases.

* Adding default alignment for checkbox.

* Switch documentation link correction

* Removing Ids and adding bind and trigger properties as per new config.

* Changing  default state to bindable property.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-16 17:45:17 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
Ashok Kumar M
24c5357f9d
Fix: Shrink Entity explorer by 20% (#3005) 2021-02-16 15:56:09 +05:30
Piyush Mishra
7e84c93282
Add QUERY_DYNAMIC_INPUT_TEXT control (#2983) 2021-02-16 11:51:19 +05:30
Rishabh Saxena
2e72be0f8a
Handle quota exceeded and running low on disk space errors while saving a key in localStorage (#2947) 2021-02-16 11:47:23 +05:30
Arpit Mohan
a973d779fd
Correcting the display message for query actions based on isExecutionSuccess flag (#3045)
Also improving the mongo error response string. Now we only send the error message instead of the entire stack trace back to the client
2021-02-15 22:10:04 +05:30
Hetu Nandu
ebd61efcca
Show a toast when action executeOnLoad status updates (#3042) 2021-02-15 21:43:44 +05:30
Piyush Mishra
56170b0cdf
Null check in getConfigInitialValues (#3043) 2021-02-15 21:43:20 +05:30
vicky-primathon.in
6ca247219c Added defaultText and defaultHTML properties in RTE to change newline only in case of default text value
Added migrations to handle the same
2021-02-15 17:19:33 +05:30
Abhinav Jha
342bad8909
Fix #2829 Crash when resetting form widget (#2942) 2021-02-15 11:03:30 +05:30
akash-codemonk
c7a5b8f6d5
Update onboarding indicator animation for widget menu (#3018)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2021-02-15 10:44:42 +05:30
Rishabh Saxena
051156da29
Follow the same sequence while displaying oauth options for Signup & Login (#3009) 2021-02-12 16:12:53 +05:30
Pawan Kumar
5b23cbf6f1
fix margin/padding issue in container in publish view (#2446)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-12 10:37:03 +05:30
abhishek nayak
14d17dfad5
Update JSDependencies.tsx
Updated 'Dependencies' to 'JS libraries you can use'
2021-02-12 01:38:52 +05:30
Arpit Mohan
01ca53899e
Fixing the organization share Cypress test cases (#2993) 2021-02-11 23:50:49 +05:30
devrk96
ac23629647
Feature: API Pane Redesign (#2218)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 18:24:00 +05:30
Nidhi
8823f9d407
Added client credentials grant type for OAuth2 (#2649)
* Added client credentials grant type for OAuth2

Co-authored-by: Piyush <piyush@codeitout.com>
2021-02-11 17:58:06 +05:30
Rishabh Saxena
1a593e1981
add default values to payload while creating a new action (#2976)
Fix default values not sent as payload while creating a new action
2021-02-11 17:17:21 +05:30
akash-codemonk
8aa39eae7b
Go back to application list instead of deleting app (#2981) 2021-02-11 16:55:47 +05:30
akash-codemonk
c1b3f311e3
New onboarding flow (#2686)
Co-authored-by: a <rishabh.robben@gmail.com>
2021-02-11 12:06:07 +05:30
Pawan Kumar
234b6983e9
Fix: border-radius of modal and bug where children of modal were not resetting on close of modal. (#2963)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

* update border radius of modal

* reset modal children on close

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-11 11:55:11 +05:30
Pawan Kumar
3b28653395
update rich text editor version + add check for string in editor value (#2966)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 11:55:00 +05:30
Vicky Bansal
e2349c53ab
Fix - Table column resize and reorder interaction (#2580) 2021-02-11 11:30:36 +05:30
Ashok Kumar M
0da3421dc2
Fix Local setup changes to accommodate M1 chip Macbooks. (#2959)
* Fix Local setup changes to accommodate M1 chip Macbooks.

* escaping quotes.

* formatting start-https.sh
2021-02-10 16:12:01 +05:30
Rishabh Saxena
8c72e901ee
Fix input's onSubmit action being triggered if its validation is failing (#2960) 2021-02-10 13:13:41 +05:30
Abhinav Jha
4becc50005
Fix issue where the parentRowSpace of the new widget generated from the query was incorrect. Resulting in incorrect pageSize calculations (#2944) 2021-02-10 12:34:11 +05:30
Shrikant Sharat Kandula
c5df149ba8
Add IN operator support for forms' hidden fields (#2939) 2021-02-10 11:27:21 +05:30
Pawan Kumar
c78a578247
Fix: Cannot read property 'closeModal' of null (#2911)
* update filepicker uppy implementation

* update uppy implementation

* fix uppy implementation

* remove typo

* remove consoles

* remove unused variable

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-10 10:29:47 +05:30
Abhinav Jha
eafadb8988
Update nvmrc to match the node version in package.json (#2943) 2021-02-09 20:53:05 +05:30
Hetu Nandu
8439affd67
Update node to latest LTS version (#2931) 2021-02-09 19:14:50 +05:30
abhishek nayak
785c81df23
Update messages.ts 2021-02-09 17:38:43 +05:30
Shubhendra Singh Chauhan
ac49a5aa87
Remove true from boolean attribute (#2892)
Added .deepsource.toml file
2021-02-09 11:38:54 +05:30
Rishabh Saxena
36021f9aba
fix viewer tabs arrow btns on mobile (#2910) 2021-02-09 11:05:06 +05:30
Piyush Mishra
0a6040c1cd
Hotfix redux-form getting destroyed (#2908) 2021-02-08 16:24:49 +05:30
NandanAnantharamu
3d43d04658
Remove unwanted step in Cypress Map widget test (#2902)
* updated test

* removed the commented line

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-08 16:20:28 +05:30
NandanAnantharamu
1aa879d8c2
updated flaky test (#2899)
* updated flaky test

* review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-08 15:50:03 +05:30
Pawan Kumar
3e53df8b64
Update Default styles of Widgets (#2823)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-08 13:00:01 +05:30
Rishabh Saxena
a473ed23b0
fix navbar bottom border when tabs arent rendered (#2883) 2021-02-08 10:50:52 +05:30
Nikhil Nandagopal
d9bc97cf39 Merge branch 'release' into fix/filepicker 2021-02-04 19:25:33 +05:30
Piyush Mishra
a2d8061aa2
Prep for a separate RestAPIDatasource (#2874) 2021-02-04 17:50:24 +05:30
Hetu Nandu
5d514849b4
Fix org creation and app creation tests (#2878) 2021-02-04 17:01:32 +05:30
Nikhil Nandagopal
6f779b215c added a text property for the file as well 2021-02-04 16:45:00 +05:30
Sumit Kumar
e6b77a1299
Stop logging some AppsmithPluginException to Sentry (#2351)
1. Move package  appsmith-interfaces/src/main/java/com/appsmith/external/pluginExceptions-> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions
2. Move enum AppsmithErrorAction from appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithError.java -> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/AppsmithErrorAction.java, so that both plugin exceptions and server exceptions could use the same enum.
3. Log exception based on the error action defined for each exception.
2021-02-04 15:24:30 +05:30
Hetu Nandu
0332c15d56
Better handling of action error response (#2839) 2021-02-04 15:08:25 +05:30
Rishabh Saxena
32b641c118
Implement new designs for the editor and viewer's navbar (#2750) 2021-02-04 12:32:36 +05:30
Rishabh Saxena
c72833b53b
Add an option to set reset the input widget's value on submit (#2837) 2021-02-04 11:21:16 +05:30
Nikhil Nandagopal
8c5213b6fd
Merge pull request #2851 from appsmithorg/fix/docs-link
Fix/docs link
2021-02-03 21:31:33 +05:30
Nikhil Nandagopal
486a9da8dd updated all doc links 2021-02-03 20:45:16 +05:30
Piyush Mishra
0ca5563b83
Chronological system events for developer user (#2530) 2021-02-03 18:46:48 +05:30
NandanAnantharamu
b3a75de6d3
split the test (#2799)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-03 18:08:27 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-03 17:00:19 +05:30
Nikhil Nandagopal
d27865e4c9
Merge pull request #2843 from appsmithorg/fix/filepicker-name
added file name to file picker and fixed a crash
2021-02-03 15:10:44 +05:30
Rishabh Saxena
5da3b0165e
Prevent input component cursor getting reset using asyncControlledInput (#2802) 2021-02-03 14:52:19 +05:30
Rishabh Saxena
63c028159c
Fix manage users link not visible in the share modal when triggered from the editor or viewer (#2653) 2021-02-03 14:51:49 +05:30
Nikhil Nandagopal
f2045b5435 added file name to file picker and fixed a crash 2021-02-03 14:46:44 +05:30
Rishabh Saxena
8ae86c34e0
Fix: redirect to applications page from auth pages when the user is logged in (#2771) 2021-02-03 13:29:00 +05:30
NandanAnantharamu
7a9ec45901
Added test for invalid binding (#2777)
* Added test for invalid binding

* Updated review comments

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-03 11:56:46 +05:30
Piyush Mishra
311fb5ad47
Fail client build if anything fails (#2820) 2021-02-03 11:02:00 +05:30
Hetu Nandu
bda90b4bf3
Wrap words in a toast message (#2832) 2021-02-03 10:43:55 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789)
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
2021-02-02 20:12:49 +05:30
Rishabh Saxena
9d97645b3c
minor style fixes: page context menu background color (#2479) 2021-02-02 17:47:18 +05:30
prapullac
66eb08413c
Test Ideas for "Copy to Clipboard" (#2585)
* Test Ideas for copy to Clipboard

* Adding test ideas for App viewer and admin flow

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-02 14:11:34 +05:30
Hetu Nandu
4505e41369
Migrate renamed canvas widgets to the correct name (#2782) 2021-02-01 20:03:13 +05:30
Abhinav Jha
3a9b328dcc
Fix: New widget and action name conflicts (#2778) 2021-02-01 20:02:43 +05:30
Abhinav Jha
51696b7220
Tab names can now be updated from the entity explorer (#2779) 2021-02-01 18:47:55 +05:30
Hetu Nandu
86cb8cac67
Allow for navigateTo urls to be of mailto or tel url schemes t (#2781) 2021-02-01 13:47:31 +05:30
Hetu Nandu
22afbe8971
Fix Array paths (#2775) 2021-01-29 09:59:23 -08:00
Piyush Mishra
164de6fb7e
Avoid double validation (#2687) 2021-01-29 11:34:28 +05:30
Dwayne Forde
f8974f1911
Fixes a small syntax issue with ./start-https.sh (#2767) 2021-01-29 09:55:51 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
prapullac
4ccdba9e85
Adding manual test ideas for Home page and Login scenarios (#2627)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-01-28 14:42:22 +05:30
Piyush Mishra
c3740709d0
Do not show sections that are supposed to be hidden (#2746) 2021-01-28 14:26:29 +05:30
Rishabh Saxena
ca052e7515
minor updates for auth pages: polish UI, hide empty email error message (#2743) 2021-01-28 12:50:09 +05:30
Dwayne Forde
51ccd19081
Use IPv4 on WSL machines (#2729)
WSL has issues when handling IPv6 ips. In order to resolve this, on dev machines, we now check if it's a WSL environment. If yes, we default to using IPv4 instead of IPv6.
2021-01-28 12:08:44 +05:30
Rishabh Saxena
4c393f0f1f
fix: action not a plain object for widget entity name action creater (#2638) 2021-01-27 23:38:08 +05:30
Rishabh Saxena
19c4559c95
fix: datasource bound value preview in the explorer showing entire response (#2480) 2021-01-27 23:35:32 +05:30
NandanAnantharamu
8358709f56
Added usecase for orgNaming convention (#2521)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-27 18:44:44 +05:30
Pawan Kumar
35e66360e2
Fix: Hover highlight in entity explorer should be edge-to-edge (#2478)
* fix merge conflicts of sumanthyedoti:fix/entity-items-hover

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-27 17:08:21 +05:30
NandanAnantharamu
704b787435
updated action on file selected (#2691)
* updated action on file selected

* updated common method

* Review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-27 14:37:33 +05:30
Abhinav Jha
0fa245a985
Fix issue where users could undo delete long after the timeout has expired (#2741) 2021-01-27 13:51:47 +05:30
Vicky Bansal
aa71f2ae7b
Handle invalid entity ids (#2547) 2021-01-27 12:26:19 +05:30
Vicky Bansal
5406cbee9e
Fix: Update map initial location after creating a new marker (#2736) 2021-01-27 12:25:43 +05:30
Hetu Nandu
43322413c6
Support for navigateTo function to open in new window (#2706)
* Support target for navigate function

* Add docs and action creator field
2021-01-27 11:58:23 +05:30
Rishabh Saxena
aea3b3d4db
Revamping UI on the Login/Signup page (#2696) 2021-01-27 11:42:32 +05:30
Vicky Bansal
e34a98833c
Trigger onPageSizeChange action when table page size changes (#2737) 2021-01-27 11:10:53 +05:30
Tim Dillon
c9b3059498
Disable sort by Delete column in Members page (#2722) 2021-01-27 00:24:50 +05:30
Piyush Mishra
9490ba4eca
Remove SSL related clicks from fillMongoDatasourceForm cypress command (#2726) 2021-01-27 00:04:19 +05:30
Hetu Nandu
40e42b296d
Fix for timeout being sent in a different location (#2708) 2021-01-26 08:42:52 +05:30
Hetu Nandu
3f2e60dc0d
Sanitise any other possible place which could send functions (#2704) 2021-01-25 16:49:31 +05:30
Hetu Nandu
5dc01c677d
Batching widget property updates (#2685)
- Changed the updateWidgetProperty redux action to use an object of updates instead of single update
- Added the new batchUpdateWidgetProperty action
> This action will calculate dynamicPath changes for all the updates and update them together
- Added the new deleteWidgetProperty action
>This action will delete a property and any dynamicPaths/child dynamicPaths that exist
2021-01-25 14:27:26 +05:30
devrk96
3be4828d63
Fix: App name UI in edit and deploy mode (#2216) 2021-01-25 12:51:54 +05:30
Pawan Kumar
4f1fd68052
add check if widget is available in data tree (#2681)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-25 11:01:44 +05:30
NandanAnantharamu
536a222e1c
Uncommented few tests (#2695)
* Uncommented few tests

* updated dsl

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-25 10:39:16 +05:30
Rishabh Saxena
e8a01c456d
product updates modal test (#2677) 2021-01-23 13:46:50 +05:30
vicky-primathon
63e286a469
Show row cursor as pointer when onRowSelected property is set in table widget (#2604) 2021-01-22 15:42:34 +05:30
vicky-primathon
c9cee45f51
Fix - Wrap contents of the table cell tooltip (#2629) 2021-01-22 15:19:02 +05:30
vicky-primathon
a309107623
Fix - Remove delete icon when there are no filters in table widget (#2605) 2021-01-22 15:17:14 +05:30
vicky-primathon
a9e0b5b678
Fix - selectedRow autocomplete suggestions when no row is selected (#2603) 2021-01-22 15:15:14 +05:30
vicky-primathon
ae276a93f8
Fix - Boolean values comparison in Table widget filters(#2586)
- Display filter label instead of value
2021-01-22 15:14:03 +05:30
vicky-primathon
154a4d30c9
Persist column sizes on resize in app viewer for the duration of the session (#2578) 2021-01-22 15:08:48 +05:30
vicky-primathon
64a0a44446
Remove table row alternating colors (#2552) 2021-01-22 15:07:43 +05:30
Hetu Nandu
d4be9b9404
Remove any functions from Eval Action bindings task before returning from the worker (#2679) 2021-01-22 13:40:00 +05:30
Rishabh Saxena
5ab2e194f7
update release modal styles (#2668) 2021-01-22 11:31:41 +05:30
Rishabh Saxena
57f6219d75
update styles for new updates count (#2646) 2021-01-22 11:04:37 +05:30
Rishabh Saxena
64a90a6767
enable immer autofreeze only in development (#2669) 2021-01-22 10:50:55 +05:30
dependabot[bot]
41690e2d61
Bump immer from 7.0.9 to 8.0.1 in /app/client (#2659)
Bumps [immer](https://github.com/immerjs/immer) from 7.0.9 to 8.0.1.
- [Release notes](https://github.com/immerjs/immer/releases)
- [Commits](https://github.com/immerjs/immer/compare/v7.0.9...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-21 19:00:44 +05:30
Pawan Kumar
f059e40484
Fix - RichTextEditor test by increasing wait time (#2666)
* remove default action function in messages file

* revert getErrorMessageFromActionType comment

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-21 16:38:18 +05:30
Arpit Mohan
8ba4db6a96 Commenting out the test for RTE because it's failing even though the widget is operating properly
The test needs to be fixed
2021-01-21 14:58:00 +05:30
Hetu Nandu
4021b210b1
Never show the redux action type in toast errors (#2635) 2021-01-21 12:12:53 +05:30
Rishabh Saxena
628ac6953f
Scroll to created org (#2477) 2021-01-21 11:49:06 +05:30
hetunandu
7f713b3def uncomment RTE tests 2021-01-20 16:53:58 +05:30
hetunandu
a478fcb149 Temporary comment RTE tests 2021-01-20 16:48:02 +05:30
Rishabh Saxena
d2dfd75a0c
use editor init event intead of setup to check if initialised (#2622) 2021-01-20 11:00:53 +05:30
Shrikant Sharat Kandula
d4990683c6
Fix UI for documentation modal (#2631) 2021-01-19 22:01:35 +05:30
Rishabh Saxena
cf2e5ce9d1
fix: use popover for ads dropdown options (#2628) 2021-01-19 19:42:00 +05:30
Rishabh Saxena
20d315b527
check for empty releases (#2619) 2021-01-19 14:48:32 +05:30
Rishabh Saxena
3aa268174d
use script loader for tinymce (#2620) 2021-01-19 14:24:50 +05:30
NandanAnantharamu
4d556754e5
Fixes for Filepicker test flakiness (#2616)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-19 14:21:16 +05:30
Rishabh Saxena
8e459a0c6b
validate map center and markers (#2488) 2021-01-19 12:59:15 +05:30
Rishabh Saxena
969b6fd0d2
Product updates modal (#2453) 2021-01-19 11:47:15 +05:30
abhishek nayak
4048b81b2e
Update ChartDataControl.tsx 2021-01-18 18:47:50 +05:30
akash-codemonk
6b8e3d7dd5
Onboarding changes (#2549)
- Reduce the delay for the deploy modal to 1s.
- Separate ONBOARDING_ADD_WIDGET from ONBOARDING_ADD_WIDGET_CLICK event
- Add step metadata for skip onboarding event
- Improve the contrast for the add widget button
2021-01-15 14:49:15 +05:30
Hetu Nandu
11766c0e4a
Action onPageLoad test fix (#2581) 2021-01-15 11:08:53 +05:30
Hetu Nandu
2b8bae158c
Batch action evaluation calls (#2561) 2021-01-14 20:07:21 +05:30
Hetu Nandu
8cff9bd9b9
Avoid evaluation for unnecesarry batch success calls (#2579) 2021-01-14 16:45:25 +05:30
NandanAnantharamu
9f2fbf13c8
Cypress upgrade to 6.2.1 (#2535)
* Cypress upgrade to 6.2.1

* Replaced route and server and assertions

* Removed intercept as it involves changes with alias

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-14 11:14:07 +05:30
NandanAnantharamu
d1d70b8b5c
Updated mongodatasource tests (#2567)
* Updated mongodatasource tests

* Commented assertion for test datasource and updated query test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-13 21:34:23 +05:30
Hetu Nandu
5310908cea
Handle action failure of on page load actions (#2554) 2021-01-13 17:17:41 +05:30
Hetu Nandu
42aa83a729
Selectively add paths to dependency map and evaluation order (#2537) 2021-01-13 16:22:03 +05:30
Hetu Nandu
c184fd3d3c
Remove deleted paths from evaluation order (#2517) 2021-01-13 16:21:46 +05:30
Arpit Mohan
36a47631ba Merge branch 'release' of github.com:appsmithorg/appsmith into release 2021-01-13 15:41:52 +05:30
Arpit Mohan
5860b1b2ab Adding the init dump SQL file for PostgreSQL database
This is used when running the Cypress tests
2021-01-13 15:41:39 +05:30
Hetu Nandu
d3e517ecb2
Fix for tabs widget getting the same name (#2538)
Co-authored-by: Piyush <piyush@codeitout.com>
2021-01-13 15:40:28 +05:30
Arpit Mohan
2135a4a0e8 Dummy commit to trigger the build 2021-01-13 13:39:24 +05:30
Rishabh Saxena
a2528286a3
bump blueprint core to 3.36 for using async control prop (#2491) 2021-01-13 10:53:16 +05:30
Shrikant Sharat Kandula
c6c128270c
Include version information when building Docker images for server and client (#2200)
* Include version information in backend builds

* Enable manual trigger of server workflow

* Add a dummy input field for manual trigger

* Fix secret checking in github actions

* Disable cron scheduling of sync job

* Build docker image on pushing a version tag

* Fix duplicated id and invalid id in release workflow

* Don't try to login to Docker

* Avoid download progress outputs from Maven

* Add version information for building client

* Calculate version number only once

* Enable push to DockerHub after building images

* Use Docker username from GitHub secrets

* Fix Docker username in tags when building image

* Use different secret for org name

* Minor refactoring in server workflow

* Update client build workflow to use version

* Enable manual triggering of client workflow

* Set snapshot version for server builds

* Push to docker for all branches (temp)

* Undo temp change to push all branches to DockerHub

* Use Docker org from secrets in client.yml

* Fix missing version reference in client.yml

* Remove debug command in dockerfile

* Save release notes in a resource file in Docker image

* Fix query serialization to get release notes

* Get releases of current repo instead of hard-coded repo

* Fix variable quoting for repo variables

* Exclude draft and prerelease nodes from image

* Fix call to any in release notes processor

* Fix syntax error in release notes script

* Implement API to get new release count and info

* Add missing ReleaseNotes component

* Have the release workflow run after a release is created

* Build server after generating release notes

* Change release trigger to "released"

* Change release trigger to "published"

* Change release trigger to released, edited and deleted

* Use JS script to get release notes, take 1

* Filter drafts and prereleases in script

* Fix syntax error in ES6

* Write release notes to file

* Create parent directory before writing release notes

* Log cwd in release notes script

* Log pwd along with release-notes content

* Handle case where working directory is incorrect

* Remove shell based release notes generator

* Don't show error when Sentry config is missing

* Check for sentry auth token to enable Sentry

* Carry build's exit code over to CI

* Mark out build result and add a note about it

* Add a small test to verify new versions computation

* Remove incorrect test assertion

* Remove generation of release notes file

* Connect to cloud services to fetch release notes data

* Fix missing runner for test class

* Handle missing cloud_services base URL

* Fix test failures due to missing mocks

* Enable sync-ee cron job

* Revert build.sh as there's no real change

* Add API to update release notes viewed version for users

* Fix prettier line-length errors

* Create UserData model for info unrelated to auth

* Fix field name calls

* Ensure we have a userId before setting userData

* Add tests for setting version number in UserData

* Include instanceId when fetching release notes
2021-01-12 18:15:15 +05:30
Hetu Nandu
f53af44316
Make first eval after page change happen with new layout first (#2516) 2021-01-12 14:34:34 +05:30
Hetu Nandu
94cae231c1
Make sure Table selected row is not set to undefined on mount (#2518) 2021-01-12 11:45:08 +05:30
Piyush Mishra
148497a1bc
Refactor datasources and actions for stronger type checking (#2167) 2021-01-12 09:47:28 +05:30
Piyush Mishra
1521f7445c
Fix eslint warnings (#2510) 2021-01-12 06:52:31 +05:30
Trisha Anand
6704e05ad0
Sub tree fixes for issues found on Jarvis (#2482) 2021-01-11 13:26:17 +05:30
Rishabh Saxena
c36b6b640f
auto focus create org input field (#2493) 2021-01-11 11:14:54 +05:30
Pawan Kumar
fcac402789
Fix - 502 in save layout is abruptly taking me to an error screen (#2475)
* remove crash:true in api + add error icon on page save

* remove crash true in api

* add crash on user init request fail

* dispatch safe crash action on user init call error

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-11 10:58:10 +05:30
akash-codemonk
d82d8965e4
Onboarding deploy tooltip fix (#2490) 2021-01-11 09:46:59 +05:30
Nikhil Nandagopal
4666f40a21
Merge pull request #2489 from appsmithorg/fix/analytics
added appmode analytics to the execute action
2021-01-08 14:53:04 +05:30
NandanAnantharamu
06ecc106d6
Using Cypress wait instead of postExecute for Table binding test (#2249)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-08 14:11:23 +05:30
Nikhil Nandagopal
a435133bdf added appmode analytics to the execute action 2021-01-08 13:06:22 +05:30
akash-codemonk
bad63f9e68
Onboarding fixes (#2458) 2021-01-08 11:36:09 +05:30
imgbot[bot]
ec115967f5
[ImgBot] Optimize images (#2384)
*Total -- 1,492.69kb -> 1,218.88kb (18.34%)

/static/form.png -- 651.09kb -> 517.01kb (20.59%)
/static/editor.png -- 694.01kb -> 555.61kb (19.94%)
/static/appsmith_logo_white.png -- 4.91kb -> 4.31kb (12.23%)
/app/client/src/assets/icons/ads/app-icons/bar-graph.svg -- 0.54kb -> 0.51kb (4.18%)
/app/client/src/assets/icons/ads/app-icons/team.svg -- 1.03kb -> 1.00kb (3.12%)
/app/client/src/assets/icons/ads/app-icons/line-chart.svg -- 0.88kb -> 0.86kb (2.77%)
/app/client/src/assets/icons/ads/app-icons/email.svg -- 0.25kb -> 0.24kb (2.73%)
/app/client/src/assets/icons/ads/app-icons/single-person.svg -- 0.69kb -> 0.68kb (1.97%)
/app/client/src/assets/icons/ads/app-icons/airplane.svg -- 1.18kb -> 1.16kb (1.82%)
/app/client/src/assets/icons/ads/app-icons/family.svg -- 1.52kb -> 1.49kb (1.8%)
/app/client/src/assets/icons/ads/app-icons/hospital.svg -- 0.41kb -> 0.41kb (1.65%)
/app/client/src/assets/icons/ads/app-icons/pants.svg -- 0.45kb -> 0.44kb (1.52%)
/app/client/src/assets/icons/ads/app-icons/call.svg -- 0.67kb -> 0.66kb (1.46%)
/app/client/src/assets/icons/ads/app-icons/lotus.svg -- 1.35kb -> 1.33kb (1.3%)
/app/client/src/assets/icons/ads/app-icons/lightning.svg -- 0.78kb -> 0.77kb (1.25%)
/app/client/src/assets/icons/ads/app-icons/hat.svg -- 0.55kb -> 0.54kb (1.24%)
/app/client/src/assets/icons/ads/app-icons/couples.svg -- 1.50kb -> 1.48kb (1.23%)
/app/client/src/assets/icons/ads/app-icons/mug.svg -- 0.56kb -> 0.55kb (1.23%)
/app/client/src/assets/icons/ads/app-icons/sunflower.svg -- 1.15kb -> 1.13kb (1.19%)
/app/client/src/assets/icons/ads/app-icons/website.svg -- 1.83kb -> 1.81kb (1.12%)
/app/client/src/assets/icons/ads/app-icons/diamond.svg -- 0.63kb -> 0.62kb (1.09%)
/app/client/src/assets/icons/ads/app-icons/money.svg -- 1.18kb -> 1.17kb (1.07%)
/app/client/src/assets/icons/ads/app-icons/headphones.svg -- 0.84kb -> 0.83kb (1.04%)
/app/client/src/assets/icons/ads/app-icons/bus.svg -- 2.09kb -> 2.07kb (1.03%)
/app/client/src/assets/icons/ads/app-icons/pie-chart.svg -- 0.96kb -> 0.95kb (1.02%)
/app/client/src/assets/icons/ads/app-icons/shirt.svg -- 0.67kb -> 0.67kb (1.02%)
/app/client/src/assets/icons/ads/app-icons/smartphone.svg -- 0.68kb -> 0.68kb (1%)
/app/client/cypress/fixtures/appsmithlogo.png -- 1.97kb -> 1.96kb (0.99%)
/app/client/src/assets/icons/ads/app-icons/music.svg -- 0.74kb -> 0.73kb (0.93%)
/app/client/src/assets/icons/ads/app-icons/rocket.svg -- 1.55kb -> 1.54kb (0.88%)
/app/client/src/assets/icons/ads/app-icons/medical.svg -- 0.57kb -> 0.56kb (0.86%)
/app/client/src/assets/icons/ads/app-icons/plant.svg -- 1.06kb -> 1.05kb (0.83%)
/app/client/src/assets/icons/ads/app-icons/love.svg -- 0.83kb -> 0.82kb (0.82%)
/app/client/src/assets/icons/ads/app-icons/repeat.svg -- 0.76kb -> 0.75kb (0.78%)
/app/client/src/assets/icons/ads/app-icons/bird.svg -- 1.15kb -> 1.14kb (0.77%)
/app/client/src/assets/icons/ads/app-icons/car.svg -- 1.79kb -> 1.78kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/coding.svg -- 0.51kb -> 0.51kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/rose.svg -- 1.29kb -> 1.28kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/system.svg -- 1.03kb -> 1.02kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/tree.svg -- 0.95kb -> 0.94kb (0.72%)
/app/client/src/assets/icons/ads/app-icons/card.svg -- 1.22kb -> 1.21kb (0.72%)
/app/client/src/assets/icons/ads/app-icons/cricket.svg -- 0.96kb -> 0.95kb (0.71%)
/app/client/src/assets/icons/ads/app-icons/yen.svg -- 0.99kb -> 0.99kb (0.69%)
/app/client/src/assets/icons/ads/app-icons/location.svg -- 1.00kb -> 1.00kb (0.68%)
/app/client/src/assets/icons/ads/app-icons/laptop.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/ads/app-icons/rupee.svg -- 1.04kb -> 1.04kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/medal.svg -- 1.05kb -> 1.04kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/shop.svg -- 1.96kb -> 1.94kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/cat.svg -- 1.60kb -> 1.59kb (0.61%)
/app/client/src/assets/icons/ads/app-icons/dog.svg -- 2.11kb -> 2.09kb (0.6%)
/app/client/src/assets/icons/ads/app-icons/bicycle.svg -- 1.46kb -> 1.46kb (0.6%)
/app/client/src/assets/icons/ads/app-icons/basketball.svg -- 1.52kb -> 1.51kb (0.58%)
/app/client/src/assets/icons/ads/app-icons/flag.svg -- 1.22kb -> 1.22kb (0.56%)
/app/client/src/assets/icons/ads/app-icons/euros.svg -- 1.24kb -> 1.23kb (0.55%)
/app/client/src/assets/icons/ads/app-icons/stars.svg -- 1.20kb -> 1.19kb (0.49%)
/app/client/src/assets/icons/ads/app-icons/chat.svg -- 1.49kb -> 1.49kb (0.46%)
/app/client/src/assets/icons/ads/app-icons/restaurant.svg -- 1.52kb -> 1.52kb (0.45%)
/app/client/src/assets/icons/ads/app-icons/saturn.svg -- 1.59kb -> 1.58kb (0.43%)
/app/client/src/assets/icons/ads/app-icons/moon.svg -- 1.65kb -> 1.65kb (0.41%)
/app/client/src/assets/icons/ads/app-icons/chinese-remnibi.svg -- 1.69kb -> 1.68kb (0.4%)
/app/client/src/assets/icons/ads/app-icons/burger.svg -- 2.77kb -> 2.76kb (0.39%)
/app/client/src/assets/icons/ads/app-icons/earth.svg -- 1.87kb -> 1.86kb (0.37%)
/app/client/src/assets/icons/ads/app-icons/joystick.svg -- 1.98kb -> 1.97kb (0.35%)
/app/client/src/assets/icons/ads/app-icons/steam-bowl.svg -- 2.95kb -> 2.94kb (0.33%)
/app/client/src/assets/icons/ads/app-icons/alien.svg -- 1.27kb -> 1.27kb (0.31%)
/app/client/src/assets/icons/ads/app-icons/uk-pounds.svg -- 2.33kb -> 2.32kb (0.29%)
/app/client/src/assets/icons/ads/app-icons/dollar.svg -- 2.59kb -> 2.58kb (0.26%)
/app/client/src/assets/icons/ads/app-icons/pizza.svg -- 1.86kb -> 1.86kb (0.26%)
/app/client/src/assets/icons/ads/app-icons/bitcoin.svg -- 2.75kb -> 2.74kb (0.25%)
/app/client/src/assets/icons/ads/app-icons/rainy-weather.svg -- 8.28kb -> 8.27kb (0.15%)
/app/client/src/assets/icons/ads/app-icons/shake-hands.svg -- 4.62kb -> 4.61kb (0.15%)
/app/client/src/assets/icons/ads/app-icons/football.svg -- 4.93kb -> 4.92kb (0.14%)
/app/client/src/assets/icons/ads/app-icons/snowy-weather.svg -- 8.34kb -> 8.33kb (0.12%)
/app/client/src/assets/icons/ads/app-icons/server.svg -- 9.10kb -> 9.10kb (0.08%)
/app/client/src/assets/icons/ads/app-icons/cloud.svg -- 23.21kb -> 23.20kb (0.03%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-01-07 11:23:35 +05:30
NandanAnantharamu
523e3ec397
flaky test updated (#2468)
* flaky test updated

* updated another flaky test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-07 10:37:17 +05:30
Hetu Nandu
cb2dd3c9da
Handle for scenarios scrollTo is not available in browser (#2456) 2021-01-07 10:36:25 +05:30
prapullac
7309e91153
Added test for Datasource associated with API (#2336)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2021-01-07 10:32:26 +05:30
Hetu Nandu
2943f7f782
Copy Text trigger function (#2394) 2021-01-07 10:14:30 +05:30
Pawan Kumar
6fa31e6388
Fix - Lodash import typo (#2466)
* add redirect issue

* add check for crash code

* redirect anonymous user to login page

* remove unused selector

* move redirection logic to error saga level

* update action type name

* replace occurance of redirectTo to redirectUrl

* remove unused selector in PagenoutFound + change saga name

* fix improt typo

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-06 17:31:04 +05:30
Pawan Kumar
563c32d203
[Fix] - Authentication after 404 not redirecting back to the original page (#2423)
* add redirect issue

* add check for crash code

* redirect anonymous user to login page

* remove unused selector

* move redirection logic to error saga level

* update action type name

* replace occurance of redirectTo to redirectUrl

* remove unused selector in PagenoutFound + change saga name

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-06 16:54:16 +05:30
Rishabh Saxena
affb68ee52
Fix widths for pagination test and modal confirm btns (#2445) 2021-01-06 16:39:08 +05:30
Hetu Nandu
eb1f9e7ec8
Update axios package (#2454) 2021-01-06 13:58:49 +05:30
Pawan Kumar
51076eaead
Fix: Show appropriate error message when an onPageLoad action fails (#2355)
* show action in toast error message on pageload error

* add test case

* add error body in toast

* fix test case

* fix test case

* update test case

* uncomment test case

* remove the console log

* remove unused console

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-06 10:55:47 +05:30
akash-codemonk
8d303d3d9f
Open the already opened tab if it exists when clicking on deploy (#2448) 2021-01-06 09:38:46 +05:30
akash-codemonk
f5e696a4f4
Hide other header elements while showing the deploy button 2021-01-06 09:38:18 +05:30
Hetu Nandu
1598899dd6
Fix invalid toast message for evaluation error (#2443)
Fixes #2432
Fixes: #2429


Co-authored-by: Piyush Mishra <piyush@codeitout.com>
2021-01-05 17:15:37 +05:30
Rishabh Saxena
2629ead4b7
fix: check for undefined error action payload (#2428) 2021-01-05 12:12:04 +05:30
akash-codemonk
69cd988c01
Fix onboarding test failure causing other tests to fail (#2417) 2021-01-04 15:52:22 +05:30
Hetu Nandu
4387200262
Sub tree evaluation (#1841)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Piyush Mishra <piyush@codeitout.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
2021-01-04 15:46:08 +05:30
NandanAnantharamu
4c5387f707
updated assertion (#2419)
* updated assertion

* review comment incoirporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-04 12:59:21 +05:30
Pawan Kumar
9d0c6d5359
fix datetimepicker max date issue (#2407)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-31 17:54:50 +05:30
Piyush Mishra
3d7242d716
Cleanup cancelled requests (#2387) 2020-12-30 18:56:44 +05:30
Rishabh Saxena
611186c4b2
set min pageSize for table widget (#2362) 2020-12-30 18:32:46 +05:30
Rishabh Saxena
c344377a9d
only autofocus widget search (#2400) 2020-12-30 18:32:11 +05:30
Hetu Nandu
31d8c8c4eb
[Worker] Fix critical issues (#2393) 2020-12-30 18:28:57 +05:30
Rishabh Saxena
6dd97a6f09
fix stacking order of popover and app header (#2338) 2020-12-30 14:36:24 +05:30
Rishabh Saxena
f1f9441cc6
auto focus search input (#2360) 2020-12-30 14:33:24 +05:30
akash-codemonk
1a35bb1e75
Onboarding flow (#2311) 2020-12-30 13:01:20 +05:30
Piyush Mishra
5ae2da1578
Send clean validated tree back (#2376) 2020-12-29 23:57:07 +05:30
Rishabh Saxena
37d0314c2a
default error code (#2363) 2020-12-29 22:22:31 +05:30
Rishabh Saxena
14effe6db1
fix del hotkey (#2349) 2020-12-29 22:21:57 +05:30
Rishabh Saxena
ccd9371820
update tooltip test (#2392) 2020-12-29 19:50:14 +05:30
Rishabh Saxena
13fae1a5c1
fix test (#2390) 2020-12-29 17:45:15 +05:30
Rishabh Saxena
e526f5cca5
minox css fixes (#2375) 2020-12-29 16:17:32 +05:30
Hetu Nandu
b5e8673921
Properly log data tree instrumentation (#2228) 2020-12-29 14:55:56 +05:30
Piyush Mishra
988ebe975b
RPC-like layer with graceful startup and shutdown around a webworker (#2252) 2020-12-28 14:12:43 +05:30
dependabot[bot]
45497ba5ac
Bump node-notifier from 8.0.0 to 8.0.1 in /app/client (#2316)
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-28 10:55:39 +05:30
Piyush Mishra
ebcffadca1
Prettier fixes (#2366) 2020-12-28 09:47:50 +05:30
Piyush Mishra
8ef8bfd2ac
Prettier fix. (#2353) 2020-12-24 19:01:09 +05:30
akash-codemonk
466d0cfde1
Fix explorer entity icon alignment (#1413) 2020-12-24 15:41:02 +05:30
Rishabh Saxena
83349e2996
fix modal entity not renamed through property pane when closed by clicking on the overlay (#2185) 2020-12-24 11:43:01 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Piyush Mishra
3930c4c63c
Hotfix circularJSON (#2214) 2020-12-23 19:48:46 +05:30
Rishabh Saxena
4e802d2c5a
reset query on select, don't jump to active item (#2237) 2020-12-23 17:45:14 +05:30
Rishabh Saxena
396b12b024
reorder widgets alphabetically, autofocus search input (#2325) 2020-12-23 17:02:30 +05:30
Rishabh Saxena
fb7ae53002
set the first tab as selected when the selected tab is not found (#2231) 2020-12-23 16:59:34 +05:30
Rishabh Saxena
778b82f9ae
enable hotkeys only when a widget is selected (#2262) 2020-12-23 16:58:29 +05:30
Rishabh Saxena
77801b10ff
fix undo delete tab, create copy of tabs array (#2315) 2020-12-23 16:55:52 +05:30
Rishabh Saxena
9417335176
render column submenu popover inline (#2329) 2020-12-23 16:55:25 +05:30
a
61e12235b2 Revert "reorder widget locale wise, autofocus search input"
This reverts commit 0bcc8872eb.
2020-12-23 11:08:52 +05:30
a
0bcc8872eb reorder widget locale wise, autofocus search input 2020-12-23 11:01:00 +05:30
vicky-primathon
6b6e302ee1
Fix Table data validation issues (#2297) 2020-12-23 09:47:13 +05:30
vicky-primathon
bf5693f907
Reset table selected row when table data changes (#2307) 2020-12-23 09:28:23 +05:30
prapullac
91125ebc26
Manual test Ideas for home page (#2208) 2020-12-22 14:06:52 +05:30
Arpit Mohan
a942dc198e Revert "Onboarding flow (#1960)"
This reverts commit e84699e7ba.

Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
2020-12-22 13:02:02 +05:30
vicky-primathon
567f3a16fb
Fixed accessing length property of undefined selectedRowIndices (#2293)
* Fixed accessing length property of undefined selectedRowIndices

* Added getting selectedRowIndices when multiRowSelection is true
2020-12-22 08:27:57 +05:30
Rishabh Saxena
42173e9249
fix tooltip boundary, don't show on target focus (#2250) 2020-12-21 15:22:58 +05:30
devrk96
851ae51c3a
Auto scroll to specific section on homepage when reloading with same url (#2115) 2020-12-21 14:35:58 +05:30
Piyush Mishra
9f0cc2f4bb
Wrap Query Table in ErrorBoundary (#2274) 2020-12-21 11:44:50 +05:30
Piyush Mishra
5408806bf1
Do not add objects to the DataTree (#2275)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-12-21 11:44:20 +05:30
akash-codemonk
e84699e7ba
Onboarding flow (#1960)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-12-18 18:48:47 +05:30
vicky-primathon
a6f602c33e
Fixed conversation of Unix timestamp in milliseconds (#2251) 2020-12-18 12:52:49 +05:30
Piyush Mishra
a3ed1515d5
Add headers null check (#2223)
* @hetunandu for president
2020-12-17 20:13:01 +05:30
Hetu Nandu
4b3a0ca9de
Fix table text pagination test (#2253) 2020-12-17 18:52:19 +05:30
Piyush Mishra
29de447411
Upgrade fusioncharts npm package (#2241) 2020-12-17 17:43:33 +05:30
NandanAnantharamu
db89dddbad
Organization test split into 2 parts (#2247)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-17 14:16:54 +05:30
Hetu Nandu
4f92ea99ed
Remove functions for action evals (#2242) 2020-12-17 13:36:16 +05:30
Pawan Kumar
e63f0a9d2a
Fix: 404 error page shows server unavailable (#2195)
* mount error wise route

* remove log

* add test case

* fix wrong error page

* fix typescript error + remove unused variable

* remove 404 + 500 routes

* remove unused imports

* fix typo in test case

* remove history replace in utils

* remove unused variable

* add error codes for safe crash

* remove unused variables

* add error codes in all api rejects + update error reducer code type

* update error codes in init saga

* add selectors for error safe crash + take error logic out of app router

* remove unused variables

* remove extra line

* add header in error pag

* refactor page header on error page

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-17 12:33:59 +05:30
NandanAnantharamu
4914e0a3f2
Updated tests from the functional tests (#2234)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-17 11:40:50 +05:30
Piyush Mishra
0ccc80127a
move null check out (#2221) 2020-12-16 14:52:34 +05:30
Rishabh Saxena
2f152bf5b1
fix prev widget hidden when dragging new (#2211) 2020-12-16 14:51:57 +05:30
Rishabh Saxena
17ded71de3
fix actions/queries not fetched after cloning a page (#2196)
* fix actions/queries not fetched after cloning a page

* cf fix

* update type

* update test to check if api is cloned

* trigger tests
2020-12-16 14:51:31 +05:30
Ashwani Sindhu
15a00f4982
Set document title as app name (#2203) 2020-12-15 16:54:44 +05:30
Rishabh Saxena
5c905ac0d8
Update styles for date time headers in a table (#2197) 2020-12-15 16:54:15 +05:30
Hetu Nandu
df902440f5
Add xml2json and json2xml functions (#2022) 2020-12-15 14:16:33 +05:30
Pawan Kumar
1cafbca767
Fix: The search in the multi select is not showing + Multi select dropdown stops functioning if default value is undefined (#2057)
* fix dropdown input ghost width

* add fix when default option is undefined

* update test cases for dropdown undefined default value

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-15 10:34:51 +05:30
Pawan Kumar
ffc6c91150
Fix: Input Widget Regex validation not working as expected (#2165)
* add check for custom regex when input is number

* add test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-15 10:34:30 +05:30
Hetu Nandu
5bd2cc1ea4
Execution params in actions (#2128) 2020-12-15 00:18:13 +05:30
Piyush Mishra
7826cee7c3
Null check on actionObj before using it (#2190) 2020-12-14 21:52:45 +05:30
Rishabh Saxena
20d15188fd
br instead of p on enter within rte (#2188) 2020-12-14 14:50:45 +05:30
Rishabh Saxena
29d87a88f0
unmount during drag (#2168) 2020-12-14 12:38:00 +05:30
NandanAnantharamu
095e7d3a8c
Added test for Org logo update and delete (#2177)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-14 11:50:44 +05:30
vicky-primathon
b917f71678
Added undefined check on selectedRowIndices property before checking its length (#2163) 2020-12-14 11:49:39 +05:30
dependabot[bot]
17e8725a84
Bump ini from 1.3.5 to 1.3.8 in /app/client (#2176)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-13 11:10:46 +05:30
Arpit Mohan
7ae4959c29 Correcting the if clause for environment variable 2020-12-12 22:03:03 +05:30
Arpit Mohan
372774e728 Checking if the new run command works in Github Action 2020-12-12 20:48:21 +05:30
Piyush Mishra
22aa9756c1
Resize canvas on delete widget (#1958) 2020-12-11 19:18:01 +05:30
Piyush Mishra
2a05df86c7
Hotfix crash on navigate to API page after widget rename (#2134) 2020-12-11 18:04:06 +05:30
Arpit Mohan
75b3f18a92 Correcting github actions yaml.
Really need a validator for this
2020-12-11 17:41:39 +05:30
Arpit Mohan
7fbd14228d Correcting the node_modules cache for Cypress tests 2020-12-11 17:39:10 +05:30
prapullac
b27a32940e
Manual Test Ideas (#2129) 2020-12-11 17:25:54 +05:30
Arpit Mohan
51757072de Ignoring manual cypress tests during build
Also correcting the node_modules cache during yarn install
2020-12-11 17:10:05 +05:30
Arpit Mohan
b517639bd0 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-12-11 13:11:11 +05:30
Arpit Mohan
2951c609ec Correcting the APP_HOST in netlify for deploy previews 2020-12-11 13:10:55 +05:30
devrk96
7475aa643a
Fix: Org logo upload redux state (#2068) 2020-12-11 12:31:13 +05:30
Arpit Mohan
85d958c2c0
[CodeFactor] Apply automated fixes (#2131)
Co-authored-by: codefactor-io <support@codefactor.io>
2020-12-10 18:44:31 +05:30
Arpit Mohan
c1de6ce8f7 Fixing prettier errors in DynamicBindingUtils 2020-12-10 17:22:18 +05:30
Piyush Mishra
580c261e5d
copy tab data before mutating (#2084) 2020-12-10 14:21:54 +05:30
Hetu Nandu
f312320940
Remove unsafe functions from eval (#2076) 2020-12-10 14:00:49 +05:30
Pawan Kumar
5553da02e8
Fix: Page crashes on cloning the API (#2087)
* fixed the page crashig on cloning the api

* adding test cases

* comment out the drag and drop test case in input spec

* update test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-10 13:52:40 +05:30
devrk96
8ef7405421
Fix: User icon numbers on home page (#2070) 2020-12-10 13:37:48 +05:30
devrk96
2995410d27
Fixing text overflow word-break property fixed. (#2116) 2020-12-10 13:36:13 +05:30
Rishabh Saxena
d7dea9aff4
fix toast message on widget cut (#2059)
* fix toast message on widget cut

* show msg when widget not selected during cut/copy
2020-12-10 13:03:43 +05:30
Piyush Mishra
0e47c0a4c0
Fix brackets mismatch (#2019) 2020-12-10 11:48:59 +05:30
Nikhil Nandagopal
9b51bf9af2
Merge pull request #2109 from appsmithorg/fix/boolean-validation
Fix for false evaluated value showing as null
2020-12-10 11:27:52 +05:30
Piyush Mishra
2b4e25b04a
default to empty array on usage (#2074) 2020-12-10 11:25:12 +05:30
NandanAnantharamu
9fb99c1145
Added tests for Table binding with Input Widget (#1955)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-12-10 10:52:19 +05:30
Hetu Nandu
74f8b51db3 Fix for false evaluated value showing as null 2020-12-09 22:25:59 +05:30
Nikhil Nandagopal
8864a1eca2
Merge pull request #2101 from appsmithorg/fix/sentry-errors
added code to prune payloads from sentry actions and reduce depth of …
2020-12-09 19:11:34 +05:30
Nikhil Nandagopal
d228f6d117 fix for undefined access to crash field 2020-12-09 18:22:36 +05:30
Nikhil Nandagopal
7d70a71d70 added code to prune payloads from sentry actions and reduce depth of actions reported 2020-12-09 14:42:12 +05:30
Nikhil Nandagopal
854d514359
Merge pull request #2094 from appsmithorg/fix/sentry-errors
Prune expensive redux actions and console logs from sentry
2020-12-09 13:06:54 +05:30
devrk96
fba79f960b
App icon and color name change issue resolved (#2089) 2020-12-09 12:36:02 +05:30
Nikhil Nandagopal
67fc762968 Merge branch 'release' into fix/sentry-errors
# Conflicts:
#	app/client/src/sagas/ErrorSagas.tsx
2020-12-09 12:34:08 +05:30
Nikhil Nandagopal
0fc5817caa added a check for errors without payloads 2020-12-09 12:32:27 +05:30
Nikhil Nandagopal
e0ac6e9850 Allowed console errors to still be logged 2020-12-09 11:59:40 +05:30
Nikhil Nandagopal
cfa020c063 pruned expensive redux actions and console logs from sentry 2020-12-09 11:50:39 +05:30
Rishabh Saxena
6a3b3c7cb8
treat false str as falsy for env vars (#2055)
* check boolean env values against  string

* refactor parseConfig

* consistent bools

* return true/false for those strings
2020-12-09 11:22:50 +05:30
Hetu Nandu
04e963c599
Fix for 502 errors from the server (#1949) 2020-12-09 00:43:48 +05:30
NandanAnantharamu
ec7149f9d8
Test case for creating multiple apps (#1871)
* Added test for #1716

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-08 23:47:34 +05:30
Pawan Kumar
f8fd19d026
fix alignment of api editor response view (#2002)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-08 14:54:36 +05:30
Pawan Kumar
c67ada9a24
Fix/updating datasources does not update sidebar (#2018)
* add check for datasources in memo equality check

* add test cases

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-08 14:54:02 +05:30
vicky-primathon
19d6ad695e
Table column max width limit removed (#2077) 2020-12-08 12:25:30 +05:30
Nikhil Nandagopal
0c1d914c38
Merge pull request #2064 from appsmithorg/fix/sentry-errors
[Fix] reduced depth of information shared via sentry to prevent 413 errors
2020-12-07 20:01:25 +05:30
Nikhil Nandagopal
03053d40c3 reduced depth of information shared to allow error sharing 2020-12-07 19:54:51 +05:30
Pawan Kumar
e4b28172a7
add ellipsis in button (#2031)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-07 12:48:53 +05:30
devrk96
6cd44a5b84
Fix: Application name update checks (#1710) 2020-12-07 12:22:49 +05:30
devrk96
b7d77e15f1
Feature: New app icons and color palette (#2026) 2020-12-07 12:21:13 +05:30
Piyush Mishra
9ec030e101
null check for errors forEach(#2030) 2020-12-07 11:15:14 +05:30
Pawan Kumar
91127ed719
Fix: FilePicker widget was not setting loading state to true on calling action (#1985)
* set loading state on calling action in file picker

* add test cases for file picker loading state

* add tests cases

* add isLoading state in state instead meta

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-03 11:02:50 +05:30
Hetu Nandu
6a7403d88e
Store tabs name data as array instead of string (#1676) 2020-12-02 18:23:51 +05:30
Arpit Mohan
a900b48712
Improving the text we see in the API and query settings pages (#1997) 2020-12-02 16:27:57 +05:30
vicky-primathon
6c19af7c24
Fix: Columns flicker when columns are resized or reordered (#1940)
* Fixed flickering issue on column reorder and resize

* Disable sort when resizing column to stop flicker issue
2020-12-02 16:14:56 +05:30
Pawan Kumar
066e20d0a2
Fix: Remove Fusioncharts Watermark (#1978)
* Fusion charts watermark can be removed by adding the `APPSMITH_FUSIONCHARTS_LICENSE_KEY` env variable.

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-02 16:12:51 +05:30
akash-codemonk
afa81d9eaf
Datasource form bug fixes (#1986)
* Datasource form fixes #1967 and fixes #1966
* Add tests for scenarios in #1967 and #1966
2020-12-02 16:06:35 +05:30
Piyush Mishra
1eddc0c7d1
Faster recompile with cached eslint (#1987) 2020-12-02 11:57:56 +05:30
imgbot[bot]
4fa2fd4ba6
[ImgBot] Optimize images (#1993)
*Total -- 307.73kb -> 177.70kb (42.25%)

/deploy/heroku/images/app-settings.png -- 215.56kb -> 118.43kb (45.06%)
/deploy/heroku/images/finish.png -- 33.21kb -> 19.53kb (41.19%)
/deploy/heroku/images/add-domain-form.png -- 29.12kb -> 18.04kb (38.06%)
/deploy/heroku/images/add-domain-button.png -- 29.37kb -> 21.23kb (27.71%)
/app/client/src/assets/icons/ads/upload.svg -- 0.47kb -> 0.47kb (0.62%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-12-02 11:50:10 +05:30
satbir121
8afa900044
Filepicker component and logo upload for org (#250) 2020-12-02 03:31:27 +05:30
devrk96
5d820c7203
Fix: Organization rename and toast issues (#1954)
* Toast message removed when renaming an organization
2020-12-02 03:30:29 +05:30
Hetu Nandu
29d0c49962
Wait for eval before executing the next evaluation (#1959) 2020-12-01 16:09:55 +05:30
Pawan Kumar
43f821fddc
Fix: test cases for datepicker (#1977)
* clear cache values on delete

* added test cases

* add reload in test case

* fix test cases for datepicker spec

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-01 12:10:31 +05:30
Pawan Kumar
1aea90c404
Fix: Persist of default values even after delete of widget (#1929)
* clear cache values on delete

* added test cases

* add reload in test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-01 10:56:35 +05:30
Piyush Mishra
400fd8007f
Make sure google is available before loading components that rely on it (#1934) 2020-11-30 12:53:05 +05:30
Hetu Nandu
f248304720
Using --no-cache option for jest tests 2020-11-28 10:37:10 +05:30
Piyush Mishra
b199c539be
Fix setup for local linux server (#1948) 2020-11-27 14:49:09 +05:30
Abhinav Jha
55ef8a0084
Loop sagas to respawn when they crash (#1880)
* Added Sentry logging

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-11-27 14:21:08 +05:30
Pawan Kumar
9997f2cb9f
Feature: Min and Max date inputs to restrict range in Datepicker Widget (#1865)
* add daterange property control

* fix typescript errors

* update daterangepicker control

* remove daterangepicker control

* add toasts for invalid dates + add test cases

* update test cases

* update test cases

* update test cases + change validation type name + few refactor

* merge release + update toast usage in datepicker control

* update test cases

* update form dsl for test cases

* update test cases

* update setDate command in test cases

* update test cases

* update test case dsl for datepicker widget

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-27 14:18:38 +05:30
akash-codemonk
49026d9b3c
Sava api with datasource without having to click on save datasource (#1930) 2020-11-27 11:06:16 +05:30
Nikhil Nandagopal
9c29b83d07
Fixed Action selector function arg splitting regex to include arrays and objects (#1893)
- Also added navigateTo params field
2020-11-27 10:30:53 +05:30
imgbot[bot]
f073698fcc
[ImgBot] Optimize images (#1928)
*Total -- 316.18kb -> 175.10kb (44.62%)

/deploy/aws_ami/images/system-log.png -- 136.77kb -> 73.60kb (46.19%)
/deploy/aws_ami/images/select-system-log.png -- 178.91kb -> 101.01kb (43.54%)
/app/client/src/assets/icons/ads/warning.svg -- 0.49kb -> 0.49kb (0.6%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-11-26 18:43:05 +05:30
Pawan Kumar
7a7fb4547f
Fix: isRequired validation of checkbox widget (#1884)
* fix checkbox required issue

* add test case

* update error styling for checkbox

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-26 16:51:23 +05:30
NandanAnantharamu
a64069b9f2
Added test for Tab and input widget binding (#1912)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-11-26 15:15:03 +05:30
NandanAnantharamu
7a73763aea
Feature/pageload usecase (#1750)
* Usecase for pageload Api and input widget

* Updated test name

* updated tests

* Updated assertion

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-11-25 21:40:31 +05:30
Piyush Mishra
d9e7baea45
Fix infinite loop crash on widget drag (#1916) 2020-11-25 21:32:54 +05:30
devrk96
461b662c7a
Feature: Rename organization in homepage (#1201) 2020-11-25 17:54:14 +05:30
Nikhil Nandagopal
8109b3b001
Merge pull request #1836 from vvkpd/show-number-of-records
show number of the records
2020-11-25 12:31:46 +05:30
Nikhil Nandagopal
25e9516315
Update TableHeader.tsx 2020-11-25 12:06:27 +05:30
Nikhil Nandagopal
610ea6c1f7 minor fix for user ids being sent 2020-11-24 21:10:50 +05:30
Vivek Pandey
1bdefc0094 removes show label from header 2020-11-24 20:05:34 +05:30
Nikhil Nandagopal
c77c43cfee
Merge pull request #1892 from appsmithorg/fix/tabs-selectedTab
Fix selectedTab binding issue
2020-11-24 19:06:10 +05:30
Piyush Mishra
dbf947a1a6
Hotfix for mac start-https.sh script (#1891) 2020-11-24 18:58:05 +05:30
Abhinav Jha
bddc79aee8 Fix selectedTab binding issue 2020-11-24 18:20:08 +05:30
Piyush Mishra
e7c465eaae
Add support for WSL local dev (#1756)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2020-11-24 16:45:33 +05:30
Piyush Mishra
7376ada1b1
[Documentation] Use env variables in Cypress tests (#1887) 2020-11-24 16:44:38 +05:30
Piyush Mishra
03f97c0323
Fix: Maps widget crash on wrong initial location datatype (#1854) 2020-11-24 14:13:45 +05:30
devrk96
fee1a4518f
Feature: Toast component (#476) 2020-11-24 12:31:37 +05:30
Nikhil Nandagopal
9cc5a20190 added source to user object 2020-11-23 18:47:12 +05:30
Pawan Kumar
ad52842e1c
Fix/entity name coincide issue 1396 (#1781)
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* add check if name is conflicting with internal fn

* use already existing selector

* add conflicting names checks on api/queries/widget names

* add test cases for invalid widget/api/query names

* refactor

* change array to map

* remove getDataTreeKeys selector

* refactor

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-23 14:57:00 +05:30
Piyush Mishra
5efcb47486
Improve test automation docs (#1838)
* improve docs with link to client setup and change cypress.env.json instead of editing cypress.json file

* fix link to client setup

* improve ordering

* rearrange

* fix quotes

* remove unlinkable link

* fake push
2020-11-23 13:58:26 +05:30
akash-codemonk
294348e1f9
Query pane plugin form should be initializable (#1802) 2020-11-23 11:58:15 +05:30
Vivek Pandey
0a35ecdcaf show number of the records 2020-11-22 20:16:27 +05:30
Nikhil Nandagopal
6487508e0c
Merge pull request #1823 from appsmithorg/fix/rte-linebreaks
Fix RTE line break issue
2020-11-20 17:27:51 +05:30
Abhinav Jha
3064a1865a Fix RTE line break issue
Fix issue where empty defaultValue wasn't getting updated
2020-11-20 17:08:51 +05:30
Hetu Nandu
ff541c3efa
Patch object order issue (#1819) 2020-11-20 15:00:50 +05:30
Hetu Nandu
9ef9d184ff
Pass execution params to action callback (#1814) 2020-11-20 13:57:46 +05:30
vicky-primathon
3b85cc8222
Added defaultSelectedRow property in table widget so that users can configure default selected row(s) (#1684)
* Added defaultSelectedRow property in table widget so that users can configure default selected rows

* Cypress test cases added to test default row selection in table widget

* Fix defualtSelectedRow property's evaluation type

* Fix default select row type

* Set default selected row when resetting user selected rows

* Use defaultSelectedRow when no user selected row in table
2020-11-20 13:13:39 +05:30
devrk96
0da8c84ae1
Fix: App card boundaries UI (#1798)
* Hover ui fixed on all sides of app card
2020-11-20 12:45:48 +05:30
devrk96
879258b74f
Theme flag stored in localStorage cleared when logging out (#1796) 2020-11-20 12:45:04 +05:30
akash-codemonk
26e793a86a
Show api datasource list on focus (#1668) 2020-11-19 17:11:06 +05:30
akash-codemonk
2ded99f9ac
Fix store as datasource (#1772) 2020-11-19 17:00:22 +05:30
Pawan Kumar
5f1b398d34
Fix/truncated page name in appviewer issue 1597 (#1770)
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* show popover on truncated page name in appviewer

* move testcases to Pages_spec.js

* fix ref issue + test cases

* fix test case

* update test case

* fix test case

* fix merge conflict typo

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-19 16:08:09 +05:30
akash-codemonk
acb3c42d66
Highlight matching brackets in editor (#1613) 2020-11-19 13:24:21 +05:30
akash-codemonk
6dc7e42ce9
Remove api datasource from add datasource page (#1639)
* Show only db datasources in the create datasource page

* Remove invalid test
2020-11-19 13:22:44 +05:30
akash-codemonk
32482d4826
Fix datasource name getting focused after save while creating new datasource (#1793) 2020-11-19 13:04:19 +05:30
akash-codemonk
732dc632cd
Show callout only for db datasources (#1792) 2020-11-19 10:49:36 +05:30
akash-codemonk
c3c7b9b7d7
Add new property to conditionally hide form fields in datasource and editor (#1682)
* Create a form control component which handles the hidden logic

* Add tests
2020-11-19 09:02:58 +05:30
Piyush Mishra
5b684b857e
Add placeholders on curl import and API create form (#1738)
* adds placeholder on curl import form

* add placeholder to api creation form as well
2020-11-19 05:48:54 +05:30
Abhinav Jha
93ac625135 Hide appviewer header if queryparams has embed 2020-11-18 18:55:25 +05:30
Vivek Pandey
de435ed009
Show number of records instead of pages in the table widget (#1734) 2020-11-18 18:20:04 +05:30
Hetu Nandu
2538444e20
Remove old derived value bindings from test DSLs (#1757) 2020-11-18 18:18:07 +05:30
Pawan Kumar
6e4c6824ef
Fix/truncated page name in appviewer issue 1597 (#1742)
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* show popover on truncated page name in appviewer

* move testcases to Pages_spec.js

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-17 12:03:10 +05:30
Piyush Mishra
49c24c7654
Force redirect https on development nginx server (#1733) 2020-11-16 19:01:33 +05:30
Arpit Mohan
955f80925f
Fixing the telemetry on self-hosted instances (#1714) 2020-11-12 19:01:40 +05:30
Abhinav Jha
0f4269891f
Fix issue where creating a new application twice does not work (#1713) 2020-11-12 18:58:12 +05:30
akash-codemonk
86a419d42a
Add the error style to bindings (#1711) 2020-11-12 18:53:49 +05:30
Pawan Kumar
fc29a31cd4
Fix/show two whitelist ips issue 1632 (#1705)
* add second whitelist ip for create datasource page

* revert the cloudhosting check on help button

* update name of util function

* remove unused key

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-12 17:35:19 +05:30
NandanAnantharamu
da9ef2cb2d
Added a check for zoom feature test (#1703)
* Added a check for zoom feature test

* Added another click for zoom-in check

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-11-12 17:34:44 +05:30
Pawan Kumar
7bc4697545
Fix/help modal fab button toggle issue 1681 (#1692)
* change icon to close on opening help modal

* fix help modal icon bug

* add test cases for the fab buttont toggle issue

* fix padding + closing lag issue of help modal

* pass isOpen true all the time

* fix help modal button hover issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-12 16:56:54 +05:30
Hetu Nandu
37c2246e22
[Enhancement] Update DSL structures to allow for nested dynamic paths (#1625)
Implements #1575
2020-11-12 16:53:32 +05:30
akash-codemonk
1510c21a7d
Add a back button to the datasources page (#1702) 2020-11-12 15:36:13 +05:30
Rohit Kumawat
175d43aad3 limit added for showing user icons in an organization 2020-11-12 15:01:51 +05:30
Arpit Mohan
073555ee8a
Moving all telemetry check to the configs class (#1700)
Now we enable/disable all analytics in a central location in the configs class. This ensures that each analytics function can simply check it's own value and not worry about checking for the disableTelemetry flag
2020-11-12 11:56:09 +05:30
Nikhil Nandagopal
e411df0a64
Added check so that existing installs don't get telemetry (#1698)
* Adding the segment key to the tagged release
* Also opting out of telemetry data in CI builds

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-11-11 23:54:19 +05:30
Arpit Mohan
cb4b3b2753 Dummy commit to trigger CI build 2020-11-11 19:43:25 +05:30
Hetu Nandu
a51082fb54 Merge branch 'master' into release 2020-11-11 18:51:03 +05:30
devrk96
73869eee69
Feature: Show org user icons on homepage (#1685)
* Displaying org user icons feature is implemented

* using username if name not found in user details

* Share user icon cypress test implemented
2020-11-11 18:42:05 +05:30
Abhinav Jha
a4f652ce70
Add client-max-body-size directive to nginx https proxy (#1695) 2020-11-11 18:23:48 +05:30
Nikhil Nandagopal
5a903a6976 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-11 18:07:57 +05:30
Nikhil Nandagopal
a1d6b0232b enabled perf for sentry 2020-11-11 18:07:40 +05:30
akash-codemonk
aefafd33dc
Fix switching datasource in the query pane (#1636) 2020-11-11 17:59:26 +05:30
Hetu Nandu
b1c8008c3d Add null check for evaluated value in Chart Data Control (#1675)
Fixes: #1672, #1666
2020-11-11 17:28:26 +05:30
Hetu Nandu
3a84af82ed
Fix critical issues (#1686)
Fixes #1683
Fix for dropdowns with option not being an object crashes dropdown and stops eval
Fixes #1656 #1657
Fix issue where updateWidgetProperty would get called without a widgetId
2020-11-11 17:02:14 +05:30
Pawan Kumar
392de2b840
Fix/on date selected call issue 987 (#1691)
* fix onSelectedDate call on deselection of date

* add test cases for deselecting the datepicker widget issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-11 16:59:45 +05:30
Arpit Mohan
166ee73c9f
Moving the intercom initialization to the body in index.html (#1690)
This is to allow us to enable/disable Intercom chat based on the APPSMITH_INTERCOM_APP_ID and APPSMITH_CLOUD_HOSTED environment variables.
2020-11-11 15:49:21 +05:30
NandanAnantharamu
d5ce1dfa52
Added tests for dependencies (#1679)
* Added tests for dependencies

* updated review comments

* moved files to binding folder

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-11-11 15:44:01 +05:30
Nikhil Nandagopal
3c37645d12
Merge pull request #1674 from appsmithorg/fix/switch-content-type
Fix incorrect bodyFormData values being sent
2020-11-10 19:20:11 +05:30
Pawan Kumar
dace2a6a55
Merge pull request #1671 from appsmithorg/pawan/issue-720
Fix long app names not visible issue
2020-11-10 17:26:41 +05:30
Pawan Kumar
42fe5f4543 update test cases for the issue + typo fix 2020-11-10 16:59:34 +05:30
Akash N
06d330ef3a actionConfiguration.body shouldn't be reset 2020-11-10 16:42:31 +05:30
Pawan Kumar
8b7e7d2993 incorporate code reviews feedbacks 2020-11-10 15:58:21 +05:30
Akash N
6c0d0e228c Add test 2020-11-10 15:11:05 +05:30
Pawan Kumar
426bb0b8df clear search input in test cases 2020-11-10 15:08:47 +05:30
Akash N
3fbcf667b6 Do not reset the bodyFormData value 2020-11-10 14:58:14 +05:30
Nikhil Nandagopal
5e17450e2f
added check for no matches (#1673) 2020-11-10 14:52:35 +05:30
Pawan Kumar
3a708497dd add a max-width on tooltip component 2020-11-10 14:16:57 +05:30
Hetu Nandu
a52c5df987 Fix form widget eval loops for arrays 2020-11-10 13:23:18 +05:30
Pawan Kumar
ec49c358c4 Fix app name too long issue 2020-11-09 17:00:34 +05:30
Hetu Nandu
977405a720
Create app crash boundary (#1629) 2020-11-09 14:53:20 +05:30
Hetu Nandu
9f0363812e
Default page id fixes (#1628)
* Fix App invite form not getting the correct page id

* localise confusing getDefaultPageId function

* Remove old fetch application workflow action
2020-11-09 14:22:44 +05:30
vicky-primathon
fd12e907af
Map not resetting to location selected fix. Location map to search location. (#1619) 2020-11-06 20:39:35 +05:30
Abhinav Jha
b549978fdf
Fix issue where clicking on widget add button redirects to the homepage (#1620) 2020-11-06 20:38:11 +05:30
vicky-primathon
e82b0c42e3
Fix distortion due to table scrollbar (#1608) 2020-11-06 16:48:04 +05:30
vicky-primathon
54a6ca0850
Fix/table widget pagination changes (#1298) 2020-11-06 16:45:47 +05:30
Nikhil Nandagopal
6121e6938e
Merge pull request #1576 from appsmithorg/fix/button-ui-invite-modal
Fix: Invite modal cancel button UI
2020-11-06 15:04:10 +05:30
Hetu Nandu
2820413b7d
Fix bad fix for show alert issue #1583 (#1614) 2020-11-06 14:57:10 +05:30
Hetu Nandu
f0862652c3 Fix for btoa / atob functions 2020-11-06 14:50:07 +05:30