* Expose response headers for API/DB actions
* Added responseMeta to actions datatree
* Modified cypress test to account for responseMeta
* Modify cypress test case
* More test changes
* Modified tests
* During updateDependencyMap, when dependencies are getting added for a path, only add if the dependency is not a parent of the path.
* To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist.
* Revert "To avoid catching all cyclical dependencies, only handling catching incorrect action dependencies when the dependency paths dont yet exist."
This reverts commit c494932289e33287074c56844fbf76c8418875af.
* Disabling cypress test which asserts cyclical errors when depending on yourself
* added basic function structure for creating organization
* added functionality for automatically creating an organization with 'Untitled organization 1' like applications. Need to add tests.
* added test for creating organizations with default names
* added tests for creating org with default name
* updated jest tests to not fill in the organization form
* remove unused imports
* deleted unnused files
* added more test to check invite users to application and check that the create application is visible
* updated share application tests according to the new workflow
* fix failing tests. TODO: fix tests with renameRandomOrg to rename specific org
* remove rename random org and rename specific orgs
* remove blocking code so the element can be scrolled into view
* fix tests
* try to fix flaky tests
* remove unused
* remove create organization tests as we are testing these components elsewhere
* fix failing tests by stubbing create org response
* update tests according to new workflow
* create basic button for forking
* added menu item for fork, opens a basic modal. TODO: Add functionality to fork
* clicking fork app enables organization select and forks across applications
* added close modal functionality. TODO: add tests, optimise code, remove duplicate and use exportswhere possible
* removed unused code
* Added cypress tests to check that fork app creates an app with same dsl. Tests Failing, needs fixing
* tests fixed, but needs unexpected login from cy
* Resolved bug with login by using correct cypress selectors
* Added tests to check that dsls match, added documentation and removed unused code
* remove unused fork function and directly dispatch from modal
* refactor code
* revert
* removed unused code and refactored tests
* feature/fork-apps-across-orgs-refactor
* make code prettier
* renamed components correctly
* refactored modal code into single file. TODO: fix warnings, test and remove unused code
* pass setModalClose to dialog component to maintain global modal state
* Added types for fork modal props
* update tests and remove unused code
* Removed isDeployedApp and instead passed trigger as a prop
* remove console logs and revert imports to small case
* rename files as components
* minor changes
* cleanup
* mock dispatch for jest
* move jest mocks to component tests
* Added reducers and sagas for cleaning up ui.pageWidgets on creating new application
* Add border and scale to omnibar helpbar on hover
* Added analytics event for omnibar fire on clicking help button
* Linked documentation buttons in API pane and DB query pane to Omnibar
* Added tests to make sure Omnibar has correct styles
* Added margin to make sure border is visible
* Added cypress tests to check that api pane documentation opens the omnibar modal
* Added tests for page widgets reducer reset widget state action
* Added cypress tests to check db documentation opens in global search modal
* remove scale transform
* update recent widgets on selecting widget from omnibar and also clear search when done
* added some documentation links for specific db queries
* added more documentation links, added analytics for omnibar open, set query on opening omnibar from navigation
* remove slicing of 1st option in recent entities, revert previous code and remove console log
* make query syntax better
* add transparent border to remove side effects
* ensure that query is empty upon opening omnibar
* add omnibar documentation helpers to constants
* remove unused files
* added omnibar open and search to readmore button in new query pane
* added analytics event, cleanup and documentation
* removed unused set queries
* Fixed failing cypress tests according to new workflow. Removed invalid comments
* Updated test
* updated assertions
* Resizing image to take full width of table cell
* updated assertion
* Stop updating dynamicBindingPathList directly from widget
* Fix selectedRow and selectedRows computations
* Fix primaryColumns computations
* Updated test for derived column
* Added tests for computed value
* Added check clear data
* Reordering of test
* updated common method
* Made image size as 100% of table cell size
* add templating logic
* Updated flow and dsl
* Clear old primary columns
* Updated testname
* updated assertion
* use evaluated values for children
* Fix primary columns update on component mount and component update
* add isArray check
* remove property pane enhancement reducer
* add property pane enhancement reducer
* disable items other than template + fix running property enchancment on drop of list widget
* disbled drag, resize, settingsControl, drag for items other than template
* add grid options
* uncomment the widget operation for add child for grid children
* handle delete scenario for child widget in list widget
* WIP: Use the new delete and update property features
* add listdsl.json for testcases
* add test cases for correct no. of items being rendered
* add test cases currentItem binding in list widget
* change dragEnabled to dragDisabled
* change resizeEnabled to resizeDisabled
* change settingsControlEnabled to settingsControlDisabled
* change dropEnabled to dropDisabled
* update settingsControlDisabled default value
* Use deleteProperties in propertyControls
* Fix unsetting of array indices when deleting widget properties
* remove old TableWidget.tsx file
* Fix derived column property update on primary column property update
* Handle undefined primary columns
* Fix filepicker immutable prop issue
* Fix object.freeze issue when adding ids to the property pane configuration
* fix widget issue in grid
* Fix column actions dynamicBindingPathList inclusion issue
* remove consoles + fix typo around batch update
* Remove redundant tests
* js binding test for date picker
* hydate enhancement map on copy list widget
* check for dynamicleaf
* fixes
* improve check
* fix getNextWidgetName
* update template in list widget when copying
* updating template copy logic when copying widget
* update dynamicBindingPathList in copied widget
* Add path parameter to hidden functions in property pane configs
* fix copy bug when copying list widget
* add computed list property control
* Remove time column type
Fix editor prompt for currentRow
Fix undefined derivedColumns scenario
Remove validations for primaryColums and derivedColumns
Fix section toggle for video, image and button column types
* Fix table widget actions and custom column migrations
* Add logs for cyclical dependency map ♻️
* Process array differences
* add property control for list widget
* Fix onClick migrations
* Property pane config parity
* binding and trigger paths from the property pane config (#2920)
* try react virtualized library
* Fix unit test
* Fix unit test ✅
* Fix minor issues in table widget
* Add default meta props to binding paths to ensure eval and validation
* Dummy commit 🎉
* Remove unnecessary datepicker test
Fix chart data as string issue
* Achieve table column sorting and resizing parity with release
* handle scenario where last column isn't available to access
* Fix for panel config path not existing in the widget
* Fix bindings in currentRow (default)
Add dummy property pane config for canvas widget
* Update canvas widgets with dynamicPathLists on delete of property paths
* Add all diffs to change paths and trim later
* Add back default properties 🚶🏻♂️
* Use object based paths instead of arrays for primaryColumns and derivedColumns
* Fix issue in reordered columns
* Fix inccorect update order
* add virtualized list
* Fix failing property pane tests
* minor change
* minor list widget change
* Remove .vscode from git
* Rename ads to alloy
Fix isVisible in list widget
* move grid component to widget folder
* fix import in widget registry
* add sticky row in virtualized list
* add sticky container
* Fix Height of grid widget items container
* fix dragging of items in children other than template children
* update list widget
* update list widget
* Fix padding in list widget
* hide scrollbar in list widget list
* fix copy bug in list widget
* regenrate enhancement map on undo delete widget
* Use enhancementmap for autocomplete in list widget
Basic styles for list widget scrollbar
* add custom control in widget config
* minor commit
* update scrollbar styles
* remove unused variable
* fix typo in custom control
* comment out test cases
* remove unused imports
* remove unused imports
* add JSON stringify in interweave
* add noPad styling in dragLayer for noPad prop
* implement grid gap
* add list item background color prop
* add white color in color picker control
* fix gap in last list item
* remove onBeforeParse in textcomponent
* remove virtualization in grid widget
* allow overflow-y
* add onListItemClick action
* add beta label
* add pagination
* fix actions in pagination in list widget
* add list widget icon
* add list background color default value
* remove extra div
* fix pagination issue
* fix list widget crashing on perpage change
* extract child operation function to widgetblueprint saga
* refactor enhancements
* add enhancement hook
* refactor propertyUpdate hook enhancment
* remove enhacement map
* revert renaming ads to alloy
* add autopagination
* Cleanup unused vars
Re-write loop using map
Fix binding with external input widget
* update default background color
* remove unnessary scrol + fix pagination per page
* remove console.log
* use grid gap in pixel instead of snap
* fix list widget tests for binding
* add tests for on click action and pagination
* remove unnecessary imports
* remove overflow hidden in list component
* Add feature to enable template actions
* update property pane help text for list widget
* disable pagination in editor view
* update property pane options
* add test case for action
* uncomment tests
* fix grid gap validation
* update test cases
* fix property pane opening issue for list tempalte
* Disable form widgets in list widget
* fix template issue for actions
* add validation tests for list data
* update starting template
* add selectedRow + enable pagination in edit mode
* remove extra padding in list widget + popper fix on settingDisabled
* add stop propagation for button click
* fix click event in edit mode
* disallow filepicker widget for list widget
* add test for list widget entity definition for selectItem
* remove unused imports
* fix test
* remove evaluated value for list child widgets
* add comment
* remove log
* fix copying bug in list widget
* add check for not allowing template to copy
* fix test
* add test for property pane actions
* remove unused import
* add draglayercomponent test
* add test for draggable component
* add test for evaluatedvalue popup
* add test for messages.ts
* add test for widgeticons
* add test for property pane selector
* add test for widget config response
* start testing widget configresponse
* add test for enhancements in widget config
* add test for codeeditor
* add test for base widget + list widget
* add test for executeWidgetBlueprintChildOperations
* remove unused import
* add test for widget operation utils
* remove unused import
* add test for handleSpecificCasesWhilePasting
* remove unused function
* remove unused import
* add empty list styling
* resolve all review comments
* fix message test
* add test for widget operation utils
* fix merge conflicts
* move validations in property config
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
* cherry pick -make new
* revert to enable fix from release
* attempt to hook into existing datasource editor
* gSheets plugin skeleton from Rest API
* Changes for database migration
* fix for auth code
* separate it out
* action page loads!
* add to explorer
* create action from datasource
* Editor JSON WIP
* working query form
* Editor JSON WIP
* import to
* fix toast message
* redirect from datasource and editor pages
* fix onboarding
* fix imports and constants
* refactor form out
* refactor queryForm
* Merge branch 'release' into feature/google-sheets
* Merge branch 'release' into feature/google-sheets
* initial values from settings, editor and form
* Check
* remove dangling code around lightTheme
* Safety net
* remove class
* try mouseover solve
* force click
* changes from review
* fix action form name on import
* Merge branch 'release' into feature/google-sheets
* minor cleanup
* Merge branch 'release' into feature/google-sheets
* WIP
* Google sheets changes
* Merge conflicts
* Merging and fixes, needs refactoring
* Check
* Merge branch 'release' into feature/google-sheets
* Fixed tests
* Add cloud services env variable
* Clean up saga
* Clean up
* Refactoring
* Deleted svg file
* Minor fixes
* Modified design to allow behaviour in google sheets methods (#3486)
* Modified design to allow behaviour in google sheets methods
* Review changes
* Removed sysout
* Added handling of edge cases with table data
* Merge branch 'release' into feature/google-sheets
* Fixes
* Fixes
* Added validations
* Improved tests
* Removed extraneous injected bean
* Review changes
* Fixed bug with method
* Changes to Google sheets plugin's request and response structures (#3692)
* Method changes
* Removed logging
* Renaming options
* Reverting pom version
* Modified type of collection variables, fixed errors
* Converted row offset field to one that supports dynamic bindings
* Review changes
* List SAAS plugin type actions under lightning menu apis (#3820)
* list saas plugin type actions under lightning menu apis
* combine saas plugin type actions in the other sub menu of lightning menu
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
* Fix merge issues
* Prettified query editor and a few fixes w/ ux
* Test fixes
* Reformatting request
* code for REST added (#3876)
Co-authored-by: hetunandu <hetu@appsmith.com>
* Renamed body to row object
* Renamed placeholder for range
* Renamed range heading
* Modifications to handle range semantics
* Use spreadsheet Url instead of id
* Ordering of methods
* Removed logging
* Add tests for Dynamic text controls
* Add tests for url helpers
* Fix coverage config
* Nevermind
* Interface changes
* There is no body here
* Yay to hints
* Delete row field is separately handled as row index
* placeholder support (#4001)
* Fixed tests, typos and creating new sheets with random rows
* Switched to using 'rowIndex' throughout
* binding path added for query input field (#4016)
* - Fixed QA bugs (#4032)
- Split delete sheet into two
- Removed dynamic query input types from hidden keys
* Proper exceptions
* Removed extra logging
* Throw exception if update method does not match any of the columns
* Same for bulk update
* Zero-indexed delete row
* I'm a space bound rocket ship
* Logic to register installations with cs (#4062)
* Logic to register installations with cs
* Clean up
* Casting to string
* Checking to see if this makes the test pass
* Added an extra null check
Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
* Updated test for page spec
* Updated test for pages with widget
* updated test
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
* Property pane enhancements
- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.
* Add chart type: "Custom FusionChart" (#2996)
Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
* Fixed error message for single user invite
* updated success message for single user invite and created tests
* use state to detect and update the number of users invited
* removing unnecessary lines
* typo
We recently changed the test to make sure we wait for the client to create an onboarding data source if it did not exist. This kind of check was also happening on the source code, and the complexity was not getting translated properly in the tests.
To improve the reliability of the test, I added an arbitrary wait time before we start the building
* Fixed selected row resets when table data is changed
Added cypress test case to test selected row resets when table data changes
* Fixed cypress test case
* Remove width and introduce more AppLayout type enums
* Fix: Adding min width to layout options.
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
- Mongo plugin client driver does not return with exception upon first failure - instead it keeps retrying. Hence, adding timeout error to report failure before the client thread cancels due to delay in response.
- It seems that the mongdb connection string cannot be directly used for ping test, hence skipping it.
* update green shade and set border-radius 0 for table buttons
* updated color code for assertion
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
- Move to hint statement out of query box and put if above it - between the label and the query box - so that user's don't confuse it as a typed in statement.
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* Added functionality to show/hide a tab from tab property pane controls
* Added isVisible property in tabs widget default value
* Passing visible tabs to component from widget. Added missing widgetId
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
1. Move package appsmith-interfaces/src/main/java/com/appsmith/external/pluginExceptions-> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions
2. Move enum AppsmithErrorAction from appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithError.java -> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/AppsmithErrorAction.java, so that both plugin exceptions and server exceptions could use the same enum.
3. Log exception based on the error action defined for each exception.
* Date picker validation fixed
* Added date value check to remove unncessary validations
Commented defaultDate validation test as invalid date cannot be saved in date control
* Fixed date selection on user change
Fixed min and max date parsing for date picker control default date
* Added validation for min and max date in validations to handle validations when field is converted to JS
* Cypress upgrade to 6.2.1
* Replaced route and server and assertions
* Removed intercept as it involves changes with alias
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
* Updated mongodatasource tests
* Commented assertion for test datasource and updated query test
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
* show action in toast error message on pageload error
* add test case
* add error body in toast
* fix test case
* fix test case
* update test case
* uncomment test case
* remove the console log
* remove unused console
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
This reverts commit e84699e7ba.
Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
* fixed the page crashig on cloning the api
* adding test cases
* comment out the drag and drop test case in input spec
* update test case
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
* set loading state on calling action in file picker
* add test cases for file picker loading state
* add tests cases
* add isLoading state in state instead meta
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
* clear cache values on delete
* added test cases
* add reload in test case
* fix test cases for datepicker spec
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
* add daterange property control
* fix typescript errors
* update daterangepicker control
* remove daterangepicker control
* add toasts for invalid dates + add test cases
* update test cases
* update test cases
* update test cases + change validation type name + few refactor
* merge release + update toast usage in datepicker control
* update test cases
* update form dsl for test cases
* update test cases
* update setDate command in test cases
* update test cases
* update test case dsl for datepicker widget
* update test cases
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
* Usecase for pageload Api and input widget
* Updated test name
* updated tests
* Updated assertion
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
* Fixing the telemetry on self-hosted instances (#1714)
* Fix issue where creating a new application twice does not work (#1713)
* add check if name is conflicting with internal fn
* use already existing selector
* add conflicting names checks on api/queries/widget names
* add test cases for invalid widget/api/query names
* refactor
* change array to map
* remove getDataTreeKeys selector
* refactor
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
* Added defaultSelectedRow property in table widget so that users can configure default selected rows
* Cypress test cases added to test default row selection in table widget
* Fix defualtSelectedRow property's evaluation type
* Fix default select row type
* Set default selected row when resetting user selected rows
* Use defaultSelectedRow when no user selected row in table
* Fixing the telemetry on self-hosted instances (#1714)
* Fix issue where creating a new application twice does not work (#1713)
* show popover on truncated page name in appviewer
* move testcases to Pages_spec.js
* fix ref issue + test cases
* fix test case
* update test case
* fix test case
* fix merge conflict typo
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
* Fixing the telemetry on self-hosted instances (#1714)
* Fix issue where creating a new application twice does not work (#1713)
* show popover on truncated page name in appviewer
* move testcases to Pages_spec.js
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
* change icon to close on opening help modal
* fix help modal icon bug
* add test cases for the fab buttont toggle issue
* fix padding + closing lag issue of help modal
* pass isOpen true all the time
* fix help modal button hover issue
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Now we enable/disable all analytics in a central location in the configs class. This ensures that each analytics function can simply check it's own value and not worry about checking for the disableTelemetry flag
* fix onSelectedDate call on deselection of date
* add test cases for deselecting the datepicker widget issue
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
