rahulramesha
a2688bb4da
feat: Add deprecation warning badge to deprecated widgets ( #13381 )
...
This Change also introduces, isDeprecated flag to widget config, when true will add the warning to the widget's propertyPane.
2022-05-25 09:38:32 +00:00
ashit-rath
76536124f8
fix: JSONForm modify source data object to null causes crash ( #13966 )
2022-05-20 13:46:45 +05:30
Maulik
7ccc541fbf
fix: update placeholder for phone input widget ( #13635 )
2022-05-20 10:41:58 +05:30
ashit-rath
f6d726b2a1
task: JSONForm footer should always stick to bottom when fixed footer enabled ( #13904 )
2022-05-19 13:07:59 +05:30
Bhavin K
33d8347193
fix: handle selectedValues value ( #13887 )
2022-05-19 12:41:54 +05:30
Satish Gandham
8dc9c0b017
feat: Optimize create uneval tree via memoization ( #13476 )
...
* - Memoize the expeinsive parts of createUnevalTree
* - Split the generateDataTreeWidget and memoize the expensize part
- Remove stary console statement in MultiSelectWidget
* - Some debugging code, needs to be removed.
* Debugging in progress
* Still debugging
* Still debugging
* Working??
* Jest tests passing, and fast enough
* remove unused imports
* One failing jest test, testing luck with cypress
* Remcoe console statment from jest test
* - Sync with release.
- Comment failing jest test
* Disable a test
* - Clean up
* Final cleanup and documentation
* - Make function and variable names accurate and easy to understand
* Update code comments
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-05-18 10:51:53 +05:30
Bhavin K
94b93a657b
fix: remove cell background from empty rows ( #13257 )
2022-05-18 04:46:25 +00:00
Tolulope Adetula
a956ff6d71
Merge pull request #13793 from appsmithorg/fix/select-widget-filtering
...
fix: Select widget filtering
2022-05-16 05:17:43 +01:00
ashit-rath
e44aecfe85
fix: JSONForm missing theming accent color property and few JS enabled controls not access sourceData/formData properties ( #13817 )
...
* fix: JSONForm missing theming accent color property and few JS enabled inaccessible sourceData/formData properties
* reverted adding of customJSControl JSON_FORM_COMPUTE_VALUE for exisiting properties
* minor revert
* minor fix
2022-05-13 19:53:23 +05:30
Bhavin K
dabca5aac5
fix : prevent dragging when resizing ( #13600 )
2022-05-13 11:26:09 +05:30
ashit-rath
c60f102e45
fix: JSONForm - hidden field value reflects in formData ( #13739 )
...
* fix: JSONForm - hidden field value reflects in formData
* shifted update form code from useController to FieldRenderer
* review changes
2022-05-12 17:52:44 +05:30
Tolulope Adetula
379ce6cf5c
fix: Select widget filtering
2022-05-12 12:31:45 +01:00
Pawan Kumar
2dacdec880
fix: Not able to see all the options of Font property as it is not scrollable + Canvas scroll to top when I drop Tab widget on the canvas ( #13608 )
...
* fix tab widget scrolling + text widget font control overflowing issue
* revert text widget changes
* tab widget scroll issue
* remove border radius and box shadow from v1 widgets
2022-05-11 10:23:13 +05:30
Tolulope Adetula
10aca0297f
Merge pull request #13275 from appsmithorg/fix/disable-cancel-button-on-a-disabled-select-widget
...
fix: disable cancel button on a disabled select widget
2022-05-11 03:55:52 +01:00
ashit-rath
47a31a8412
feature: JSONForm - disable add new and remove buttons when array is disabled ( #13520 )
2022-05-09 17:34:49 +05:30
Keyur Paralkar
1c1135d639
refactor: removed the duplicate style properties for the list widget ( #13605 )
...
* refactor: removed the duplicate style properties for the list widget
* test: fixed list_spec cypress failures
2022-05-09 15:41:36 +05:30
ashit-rath
a715c0eefa
fix: JSONForm Phone number field required validation ( #13525 )
...
* fix: JSONForm Phone number field required validation
* PR review suggestion change
2022-05-09 14:59:53 +05:30
Tolulope Adetula
de8aebfe00
Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget
2022-05-09 03:15:51 +01:00
ashit-rath
ddc95fae53
fix: JSONForm fix events/actions controls JS mode produces additional binding strings ( #13509 )
...
* fix: JSONForm fix events controls js mode additional binding strings
* fixed globalContext value for fieldState update and fix FilterText spec
2022-05-06 15:29:56 +05:30
ashit-rath
910427788e
fix: JSONForm currency and phone input dropdown not working in Array Field ( #13564 )
2022-05-06 15:19:36 +05:30
Aswath K
ca3f159f66
fix: set max-height for Dropdown component ( #13105 )
...
* fix: set max-height for Dropdown component
* changes style for date format dropdown
* Combines MultiSelectControl into DropdonwControl
* fix: max height set via props
* fix: popover double scrollbar issue
* fix: styles for chips
* Delete MultiSelectControl
* fix: error when pressing Enter twice
* add tests for multi select & fix some warnings
* removes unwanted test file
* fix: country filtering issue
* address review comments
* fix dropdown for primary columns dropdown
* fix: issue with position
* Adds scrollIntoView when using arrow key for navigation
* fixes issue with scrollbar
* fix: jest tests
* fix: jest test
* fix: flaky cypress test
* fix: height & align issue in Date format selection
* smoothens the scroll
2022-05-06 10:34:17 +05:30
ashit-rath
f0952b8082
fix: JSONForm RadioGroupField - support numeric values in the options ( #13365 )
...
* fix: JSONForm RadioGroupField accept numeric values in the options
* cypress test - clear options before adding
* update code editor clear
2022-05-05 11:10:52 +05:30
Pawan Kumar
809a633306
feat: App Theming ( #9714 )
...
* fix style bugs
* fix select styles
* test: fix font size issue for cypress tests
* incorporate ashit feedback
* test: addresed review comments for cypress tests
* add analytics events
* height issue in view mode
* incorporate code review feedbacks
* incorporate code review feedbacks
* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations
* feat: Makes shadow and radius controls keyboard accessible (#11547 )
* makes shadow and radius controls keyboard accessible
* removes unused imports
* moves options out of render method
* fix: changed the misnomer background property name to the relevant property name
* fix: border radius issue for the map widget
* address qa bugs
* address qa bugs
* fix ux of theming pane when widget is selected
* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget
* fix: added delete icon in the delete theme modal
* address qa bugs
* change checkbox column size in config
* add js convertible to button color
* remove unused imports
* test: fixed jest tests
* fix primary color typo
* fix: migrations for the theming
* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.
* test: updated Dsl migration UT
* address qa bugs
* address qa bugs
* fix: address qa comments
* address qa bugs
* fix:
* migration issue;
* unit test cases;
* fix rating widget scroll issue
* fix youtube video border radius bug
* fix select widget
* fix select widgets styles
* address qa bugs
* merge conflicts
* makes the reset button keyboard accessible (#12134 )
* -resolved merge conflicts
* address qa bugs
* fix: labelTextSize migration fixes
* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests
* fix button group widget
* remove unused imports
* fix: fixed the text size migration for the table widget
* refactor: addressed review comments for the table widget theming migration
* fix button group widget
* add init calls for view mode
* json form init theme changes
* fix: added migration for boxShadow, borderRadius and textSizes for table widget
* fix broken fields
* test: fixed unit tests
* wip
* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration
* feat: init json form migration theming
* json form primaryColor -> accentColor
* update table widget
* update table widget
* object field label styling
* fix: migration related to the JSON form
* fix: fixed labelTextSize migration for JSON form nested widgets
* property control nested stylesheet lookup
* JSONForm label styles form array items
* show label for checkbox field array item
* fix button group widget
* wip
* refactor: addressed table widget review comments
* refactor: addressed ashit review comments;
* added childStylesheet for widgets
* feat: Keyboard navigable Color Picker control (#11797 )
* Makes ColorPicker keyboard accessible
* seperate out keyboard and mouse interactions
* fix issue with not focusing back to input
* Adds test for Color picker
* chore: added comment for the boxShadow property
* fix:
* added unit test cases for the widget and property utils
* resolved warning messages
* wip
* theme config update
* fix merge conflicts
* refactor: moved theming migration inside the migrations folder
* fix qa bugs
* fix jest test
* fix: unit test cases
* fix table column creation logic
* refactor: addressed review comments for migrations
* fix: Overriding margin and padding for custom render in the dropdown component (#12875 )
* * fix for custom render padding and margin in ADS dropdown
* * fix for removing padding from normal render options
* refactor: moved the boxShadow condition to the variable
* fix qa bugs
* fix: migration QA callouts for audio recorder widget
* refactor: added updated comments for boxShadow migration for table widget
* fix theme binfings for JSONForm fields under Object
* fix table widget theming bug
* fix: addressed code review comments
* fix: unit test cases
* fix: qa migration callouts
* fix table widget theming bug
* fix JSONForm currency input dropdown not submit form
* Added new tests - AppThemingSpec
* fix qa bugs
* fix unit test
* fix JSONForm cellBorderWidth to have default value post migration
* fix unit test
* fix qa bugs
* remove unused imports
* fix qa bugs
* fix JSONForm input height issue
* fix qa bugs
* Updating Theming spec
* * dropdown color fixes (#13249 )
* fix caching issue
;
* Fixed Theming tests
* fix tests
* fix tab widget tests
* fix: json form children level migration issue
* fix table widget tests
* Updated test
* updated tests
* updated test
* updated tests
* updated tests
* updated pageload
* fix cypress tests
* remove cypress created files
* fix color picker issues
* Failure fixes
* Fixed some more tests
* fix: cypress test failures
* fix tests
* remove consoles
* fix table tests
* fix qa bugs
* updating snapshots for AppPageLayout_spec as per new UI
* fix rating widget bug
* fix qa bugs
* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports
* update constract check algo
* fix color contrast issue
* fix: cypress failure test cases
* update font sizes labels
* fix regression bugs
* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow
* fix: default labelTextSize issue for the Input and Select families
* fix regression bugs
* fix regression bugs
* PassingParams spec - added wait time
* fix: font family default value issue on JS toggle
* fix js toggle issue in text widget
* fix tests
* fix tests
* fix tests
* fix cypress tests
* fix regression bugs
* fix regression bugs
* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget
* fix: failing unit test cases
* fix theming spec
* fix cypress tests
* test: fixed failed cypress test
* incorporate ashit feedback
* fix cypress tests
* fix: addressed review comments
* comment out table cypress test
* fix merge conflicts
* comment out color picker tests
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values ( #13318 )
...
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
rahulramesha
e128b2daf3
feat: new Widget Copy paste experience ( #12906 )
...
* copy paste commit
* class name generator changes
* modal widget fixes change
* addressing review comments
* bug fix for after deleting a widget by undoing action
* additional fix for modal widget
* additional tests for fixes
2022-05-04 13:28:57 +05:30
ashit-rath
7dbe9ccf26
fix: JSONForm placed in modal does not update default value from source data ( #13453 )
2022-05-04 12:53:48 +05:30
ashit-rath
06168ecb60
fix: submit button not disabled in invalid json form on first load ( #13415 )
...
* fix: submit button not disabled in invalid json form on first load
* reset fixes
2022-05-04 10:45:27 +05:30
Rimil Dey
c55718f9f1
fix: don't run onClick event handler when button is disabled ( #12333 )
2022-05-03 07:25:31 +02:00
Preet Sidhu
c6f3f356e6
Merge pull request #12964 from appsmithorg/fix-10379
...
fix: 10379 disable html parsing for long texts
2022-04-29 12:29:36 -04:00
Rishabh Rathod
3b1fbfa989
fix: replace klon/full with klona default ( #13457 )
...
- when manipulating props, react state (immutable values)
2022-04-29 15:14:17 +00:00
Preet
2ee727bd84
Merge branch 'release' into fix-10379
2022-04-29 06:34:47 -04:00
Paul Li
297b6141c0
fix: feedbacks on label feature ( #13123 )
...
* fix: Fix on feedbacks on Label feature
-- Eliminate CSS restriction for horizontal scrolling
* fix: feedbacks on label feature
-- Eliminates CSS rules for overflow-x: hidden
2022-04-29 17:21:08 +08:00
Maulik
59e8ad12e1
fix: allow camera & mic access for page in iframe widget
2022-04-29 11:49:44 +05:30
Tolulope Adetula
fa48a026ad
Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget
2022-04-29 06:12:19 +01:00
Tolulope Adetula
16724bdc04
Merge pull request #13074 from appsmithorg/fix/table-mutiselect-checkbox-alignment
...
fix: table Widget Multiselect Row checkbox alignment
2022-04-28 21:51:38 -07:00
Tolulope Adetula
5749a4461b
Merge branch 'release' into feat/show-page-count-when-total-records-exist
2022-04-29 02:37:59 +01:00
Tolulope Adetula
2d57840938
fix: add new line
2022-04-27 12:30:43 +01:00
Tolulope Adetula
7f8bf5c4fe
fix: PR reviews
2022-04-27 12:29:31 +01:00
ashit-rath
fc36a3af94
feat: Analytics to log source data limit exceed ( #13339 )
...
* feat: Analytics to log source data limit exceed
* minor change
2022-04-27 14:04:15 +05:30
Tolulope Adetula
faea2712fe
fix: disable cancel button on a disabled select widget
2022-04-25 13:36:36 +01:00
Bhavin K
20aa7196d2
fix: handle editor value update ( #12726 )
2022-04-25 12:32:55 +05:30
ashit-rath
1acf242600
feat: JSONFrom add isValid form level property to represent overall form validity ( #13083 )
2022-04-22 17:20:51 +05:30
Bhavin K
78600bd2ed
fix: handle dropdown flickers ( #12979 )
2022-04-22 15:56:48 +05:30
Abhinav Jha
60503bb9a6
feat: Dynamic Height widget config ( #13143 )
...
* Add platform feature which adds dynamic height property controls and default properties based on widget config
* Move features to the top, so that defaults can override them if necessary
* - Add unit tests to verify that the property controls show up for dynamic height
- Add unit test to verify that the hidden hook in the dynamic height controls work
- Fix console warning for react key unavailable in Generator.tsx
- Move constants and types to their respective files
* Remove dynamic height config from Container Widget
* Add comments in hard to understand areas
* Add function which converts fn validation params to fnString
2022-04-22 15:14:22 +05:30
ashit-rath
07757c7e7b
fix: Replace "klona/full" -> "klona" in JSONForm to avoid cloning of non-enumerable properties ( #13193 )
...
- non-enumerable like `writable`, `configurable`, `enumerable` were getting cloned with `klona/full` and it wasn't needed.
2022-04-22 14:15:45 +05:30
Bhavin K
7e3d873d20
feat: added searched address into map center data ( #12962 )
2022-04-22 11:44:42 +05:30
Bhavin K
958233f4f5
fix: added dataFormat into file data ( #12807 )
2022-04-21 16:09:24 +05:30
Preet
19172bf2b6
reduce line break limits to 1000
2022-04-20 13:22:45 -04:00
Preet
eb4eaf849a
Merge remote-tracking branch 'origin/release' into fix-10379
2022-04-20 13:20:22 -04:00
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field ( #13073 )
2022-04-20 14:47:34 +05:30