Commit Graph

5478 Commits

Author SHA1 Message Date
vicky-primathon.in
e79f6c8806 Fix horizontal and vertical table scrollbars
Hide scrollbars during resize
2021-03-25 21:46:22 +05:30
NandanAnantharamu
424a1cbf69
SwitchWidget within FormWidget tests (#3501)
* added test with switch widget within farm widget

* Added another usecase with Switch

* added wait

* updated locators

* minor update

* add locators for switch widget spec

* removed waits and replaced with suitable assertions

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-03-25 21:38:16 +05:30
Trisha Anand
bf6cdbe305 [Bug fix] A lax search for presence of binding during save page to match client algorithm to reduce page save error (#3698)
* Lax mustache binding check added to match the client side check when client recognizes a field to have a dynamic binding. This would reduce/remove bad bindings from throwing a 400 during save page.

* Added a test to assert that update layout does not fail in case the binding is technically incorrect because part of the mustache's lie inside quotes. Since client has a lax way of finding a dynamic path, server also follows suite.
2021-03-25 19:21:14 +05:30
Arpit Mohan
e9f80f3312 Adding the path limitations to run the client test only when client code changes 2021-03-25 19:21:14 +05:30
Hetu Nandu
25d7fe2369 Run cypress tests on push to release and master (#3697)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-25 19:21:14 +05:30
Trisha Anand
044a0c40f6 Stringifying the binding name before setting in the error to ensure client can parse it correctly (#3689) 2021-03-25 19:21:13 +05:30
Hetu Nandu
73f7ea3791 Trigger client integration only on approved PRs (#3632)
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
2021-03-25 19:20:30 +05:30
Trisha Anand
ed1a0b4045
Refactor the smart substitution code to extract common code at plugin interface level. (#3497) 2021-03-25 19:10:42 +05:30
NandanAnantharamu
378330815b
Added test for tableWidget bug (#3528)
* Added test for tableWidget bug

* updated test

* review comment incorporated

* updated collapse pane test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-25 16:31:51 +05:30
Trisha Anand
c6e4f91ffb
[Bug fix] A lax search for presence of binding during save page to match client algorithm to reduce page save error (#3698)
* Lax mustache binding check added to match the client side check when client recognizes a field to have a dynamic binding. This would reduce/remove bad bindings from throwing a 400 during save page.

* Added a test to assert that update layout does not fail in case the binding is technically incorrect because part of the mustache's lie inside quotes. Since client has a lax way of finding a dynamic path, server also follows suite.
2021-03-25 16:00:45 +05:30
Rishabh Saxena
f2160d61e1
Fix onboarding Cypress test (#3678) 2021-03-25 13:23:56 +05:30
Arpit Mohan
a0182818f1 Adding the path limitations to run the client test only when client code changes 2021-03-25 13:10:47 +05:30
Hetu Nandu
e975104866
Run cypress tests on push to release and master (#3697)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-03-25 13:08:45 +05:30
Trisha Anand
1a9a410c5e
Stringifying the binding name before setting in the error to ensure client can parse it correctly (#3689) 2021-03-25 12:36:56 +05:30
Apeksha Bhosale
4c464787a1
code folding in response and request (#3658) 2021-03-25 10:57:00 +05:30
Abhinav Jha
1ccece69e1
Custom FusionCharts Config (#2670)
* Property pane enhancements

- Property pane sections are collapsible
- Property pane controls can be hidden conditionally
- Property pane configurations now come from the widget instead of a global config file
- Property pane property updates can be hooked with other related updates
- Property pane control and section ids are generated dynamically now.

* Add chart type: "Custom FusionChart" (#2996)

Co-authored-by: Zeger Hoogeboom <zegerhoogeboom@users.noreply.github.com>
Co-authored-by: zeger <zeger@equinoxai.com>
2021-03-25 03:35:04 +05:30
Abhinav Jha
4a05b5d320
Fix #3335 - New method of computing table data to display (#3607) 2021-03-25 00:55:38 +05:30
Vicky Bansal
f2e0ed29c5
Update: DatePicker validates data as ISO 8601 string (#3397) 2021-03-24 17:42:24 +05:30
Vicky Bansal
97b9a32b32
Feature: Table Widget: URL column type (#3569) 2021-03-24 16:54:10 +05:30
Sumit Kumar
cb9df80694
change default value of s3 file data type on create file action (#3685)
- modify default value for s3 on file create to Yes.
- change dropdown option names to base64, text from yes, no.
2021-03-24 15:02:13 +05:30
Vicky Bansal
5ba4cc4400
Table Widget: Show null values as empty cells (#3522)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-24 14:33:48 +05:30
Vicky Bansal
06231e0f5f
Fix crash on Tabs property bindings (#3640) 2021-03-24 14:28:00 +05:30
Vicky Bansal
eb2c551def
DatePicker Widget: Additional date formats (#3162)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-03-24 14:23:39 +05:30
Hetu Nandu
9a4c317f20
Store value improvements (#3663) 2021-03-24 10:39:47 +05:30
Sumit Kumar
56f22edbe8
Return hint message on identical columns (#3656)
- Return hint message if identical column names are found in SQL query for postgres, MySQL, mssql, redshift plugin.
- Add a PluginUtils class to hold general utility functions for plugins.
2021-03-24 08:22:49 +05:30
Nidhi
992da806bf
Added dummy instances to UI matrix (#3683) 2021-03-24 08:18:19 +05:30
abhishek nayak
2e53c79464
Update ForkApplicationModal.tsx 2021-03-24 00:35:46 +05:30
vicky-primathon.in
f4d25f6b2e Renamed ScrollIndicator to VerticalScrollIndicator
Common css moved to DefaultTheme
2021-03-23 20:51:13 +05:30
prapullac
9da0d7abf6
Added test ideas for Table and Hide feature of the page (#3594) 2021-03-23 17:56:31 +05:30
Shri
a18e569f7d
Fix data serialization in analytics (#3677)
* Serialize object fields before sending to analytics

* Push event when application is published
2021-03-23 17:13:02 +05:30
Apeksha Bhosale
28a4b4a6d6 test case fixed
it was checking 3rd key:value pair for content type but with changes it will added to first empty field (0th)
2021-03-23 16:55:21 +05:30
Confidence Okoghenun
93fd946505
chore: Add summary for Mar 18 office hours (#3642) 2021-03-23 15:49:10 +05:30
Apeksha Bhosale
5d71e86f43 Test case and refactor code 2021-03-23 15:14:44 +05:30
Shri
cc39259053
Increase client body size limit to 100M from 10M (#3553) 2021-03-22 17:20:38 +05:30
Hetu Nandu
2dd1791810
Refactor and add unit tests to API interceptors (#3647) 2021-03-22 14:52:24 +05:30
Hetu Nandu
f345619f40
Fix code coverage generation file (#3655) 2021-03-21 12:02:47 +05:30
hetunandu
6b5c46e117 Only do jest coverage when it is a pull request 2021-03-21 11:34:08 +05:30
Nidhi
4b3e0e8056
One time run for artifacts (#3653)
* Switched to 20 minutes since job was timing out

* One time sweep for all tags
2021-03-20 22:29:34 +05:30
Nidhi
57bec09b79
Switched to 20 minutes since job was timing out (#3652) 2021-03-20 20:27:15 +05:30
Hetu Nandu
f1cb2a35b7
Add jest coverage diff reporting action (#3651) 2021-03-20 19:28:10 +05:30
hetunandu
f5c8eaeb64 valid json for coverage report 2021-03-20 17:47:18 +05:30
hetunandu
775f77e110 add empty coverage summary 2021-03-20 17:40:22 +05:30
Nidhi
b760582d14
Workflow to delete artifacts older than a day (#3646)
* delete after 2 weeks

* Added cron for nightly deletion

* Skipping tagged artifacts

* Reset
2021-03-20 15:09:07 +05:30
Sumit Kumar
38c5639542
Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins. (#3518)
- Provide non client certificate based SSL support for Mysql, Mongo, Postgres plugins.
- Added a new option default, apart from the the SSL mode types supported by the driver. Default means that go with whatever default configuration driver provides.
2021-03-19 15:03:56 +05:30
Hetu Nandu
52c7f5331a
Trigger client integration only on approved PRs (#3632)
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
2021-03-19 14:21:14 +05:30
Nidhi
7316b84cc4 Back merge branch 'master' into release 2021-03-19 14:07:03 +05:30
Nidhi
45b3959983 Revert "Patch Release 1.4.4 (#3620)"
This reverts commit 2f62b8079f.
2021-03-19 13:43:14 +05:30
Pawan Kumar
2f62b8079f
Patch Release 1.4.4 (#3620)
* add ellipsis to org name in settings

* added tests, documentation and better naming convention

* fix document icon styles

* update title

* Fix placeholder

* Enhancement: Virtualized Query Editor Table (#3496)

* add react-window on react-table

* remove .vscode launch.json

* add cellwrapper

* fix height issue in virtualized table

* useBlockLayout in Table

* add border-right on table row

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>

* Remove page save event from frontend

* Fix success message for single user invite and multiple user invite (#3591)

* Fixed error message for single user invite

* updated success message for single user invite and created tests

* use state to detect and update the number of users invited

* removing unnecessary lines

* typo

* Clear OAuth tokens for forked datasources (#3609)

* Clear OAuth tokens for forked datasources

* Fix datasource duplicate finder in light of oAuth tokens

* Fix potential NPE

* Added logs and analytics (#3622)

* Added logs and analytics

* Fix in error string

Co-authored-by: Shri <shrikant@appsmith.com>

* Review fixes :)

Co-authored-by: Shri <shrikant@appsmith.com>

Co-authored-by: Shri <shrikant@appsmith.com>

* udpated tests (#3617)

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>

* Fix container widget dynamicBindingPathList correction (#3619)

* Create .deepsource.toml (#3593)

Co-authored-by: Automated Github Action <automated@github.com>

Co-authored-by: Kaushik Varanasi <kaushik.varanasi1@gmail.com>
Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Shri <shrikant@appsmith.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Moulik Aggarwal <68378241+moulik-deepsource@users.noreply.github.com>
Co-authored-by: Automated Github Action <automated@github.com>
2021-03-19 13:29:38 +05:30
Moulik Aggarwal
97cd41e659
Create .deepsource.toml (#3593)
Co-authored-by: Automated Github Action <automated@github.com>
2021-03-19 11:40:59 +05:30
Hetu Nandu
64116583e3
Fix container widget dynamicBindingPathList correction (#3619) 2021-03-19 11:39:35 +05:30