Commit Graph

8251 Commits

Author SHA1 Message Date
Souma Ghosh
5f0df66b91
fix: URL column in table widget not working correctly (#16425)
* fix: URL column in table widget not working correctly

* Adds cypress tests for URL column issue
2022-09-21 16:22:28 +05:30
Aman Agarwal
6d5fc58d71
fix: updated message changes for auth tab, capital texts (#16832)
* fix: updated message changes for auth tab, capital texts

* fix: updated icon color to text color
2022-09-21 15:48:43 +05:30
subratadeypappu
2751af6810
fix: Fix NPE in execute API (#16722) (#16888)
* Fix NPE in execute API (#16722)

* Add unit tests with usual and unusual ordering of the parts (#16722)
2022-09-21 15:36:09 +05:30
Nidhi
2c2025dfea
fix: Make projection fields refresh when table heading row index selection is updated (#16883) 2022-09-21 15:11:56 +05:30
Dhruvik Neharia
fdbab9c15b
feat: Image Widget Reskinning (#16787)
* feat: Image Widget Reskin
- Update rotate and download control icons
- Add border radius and box shadow to control wrapper
- Multiple CSS fixes to follow the designs

* feat: Move rotate and download icons for image widget to separate files

* feat: change default object fit to cover for image widget

* style: use color variables from wds themes instead of constants/colors for image widget

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-21 15:11:04 +05:30
sneha122
44e08b096d
fix: fixes right body type not selected after curl import (#16549)
* fixes rght body type not selected after curlimport

* added apiContentType key in ActionConfiguration formData property

This commit fixes the bug https://github.com/appsmithorg/appsmith/issues/13978 and changes two files:
		* appsmith-server/src/test/java/com/appsmith/server/services/CurlImporterServiceTest.java
		* appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java

additionaly this commit fixes the Body type detection for REST APIs with GET method  when imported from cURL.

* Made changes to the casing of Header key 'content-type', now it is  HTTPHeader.CONTENT_TYPE standard -> 'Content-Type'. changed test cases accordingly.

* Made header-key check in assertHeader functions case insensitive in CurlImporterServiceTest.java

* removed wildcard imports and changed some comments

* changes according to PR review comments

* updated imports for APIPaneUtils

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Co-authored-by: manish kumar <manish@appsmith.com>
2022-09-21 09:40:36 +00:00
Trisha Anand
e3a100d67b
chore: Shutting down get applications endpoint (#16902)
Shutting down get applications endpoint
2022-09-20 17:20:47 +05:30
Keyur Paralkar
d3225b475d
fix: added a condition to check for accentColor (#16910) 2022-09-20 17:20:09 +05:30
Anagh Hegde
c2d7b0c2c1
chore: Add support for limit - queryAll method of base repo (#16710)
## Description

> The `queryAll` method of AppsmithBaseRepository does not support the mongodb limit. This PR adds the support for the same. 

## How Has This Been Tested?

- locally

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes

Co-authored-by: Trisha Anand <trisha@appsmith.com>
2022-09-20 15:54:27 +05:30
Aman Agarwal
60782d1bce
fix: build error due to fn name change, copy node_modules on mac error (#16874) 2022-09-20 13:57:48 +05:30
balajisoundar
79073d82b7
fix: Migration to convert old defaultOptionValue expression to new one in Select & multi select widget(#16836) 2022-09-19 17:53:07 +05:30
Shrikant Sharat Kandula
769719ccfe
fix: Better support for disallowed hosts (#16842) 2022-09-19 12:41:57 +05:30
Ayush Pahwa
e3f90db341
feat: grouping in console logs (#16698)
* fix: updated skip functionality

* update: type of logs to add occurence count

* update: reducer function to merge the new logs

* update: added dependance on last log's occurence count

* add: UI to show the occurence badge

* fix: added null check for dependency array

* update: omit occurence from compare fn

* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array

* fix: replaced forEach with reduce

* test: added functions for console log grouping

* feat: updated warning grouping color

* update: moved function to reducer file for jest tests
2022-09-19 06:29:04 +00:00
Rishabh Rathod
9a1fa98416
fix: Autocomplete now works with multiple bindings (#16314)
Fixes #16288
Fixes #16158
Fixes #16188
Fixes #15859
2022-09-19 11:02:06 +05:30
Shrikant Sharat Kandula
98776e9e94
Fix h2 version mismatch (#16845) 2022-09-19 08:04:30 +05:30
Favour Ohanekwu
d6fbdb15b9
feat: Linting in entity properties and methods (#16171)
* Initial commit

* Remove arrow function params from identifiers

* Remove invalid identifiers from extracted identifiers

* Remove invalid identifiers which are derived from function params and variable declarations

* Fix typo error

* Correctly remove invalid identifiers

* Remove invalid names from identifier list

* fix build failure

* Add Promise to list of unacceptable entity name

* Keep track of unreferenced identifiers in bindings

* Add Global scope object names as unusable entity names

* Keep track of unreferenced identifiers

* Prevent traversal of data tree for addition of new paths and entities

* Sync linting in trigger fields

* Support linting of invalid properties

* Fix linting reactivity bug in trigger field

* Remove unused objects

* Fix conflict in merging

* Lint jsobject body for function change

* Remove unused map from tests

* Code cleanup

* Modify jest tests

* Update jest tests

* Fix cypress tests

* Code cleanup

* Support  linting of multiple bindings

* Set squiggle line as long as invalid property length

* Add jest tests

* Minor code refactor

* Move ast to shared repo

* Rename confusing identifiers

* Improve naming of functions and their return values

* move shared widget validation utils and constants to shared folder

* Add jest test for invalid entity names

* Add cypress tests

* Modify test comment

* Extend list of dedicated worker scope identifiers

* Resolve code review comments

* Resolve review comments

* Annonate code where necessary

* Code refactor

* Improve worker global scope object

* Code refactor

* Fix merge conflict

* Code refactor

* Minor bug fix

* Redundant commit to retrigger vercel build

* Add null checks to dependecy chain
2022-09-17 18:40:28 +01:00
Arsalan Yaldram
5e9cb1e447
feat: added WIDGET_DRAG event. (#16591)
* feat: added WIDGET_DRAG event.

* feat: add source and destination widget name.

* feat: add container types to source and destination.
2022-09-17 12:21:42 +05:30
Arsalan Yaldram
34e7eb12b7
feat: added theme values for slider widget. (#16462) 2022-09-17 12:11:16 +05:30
Ankita Kinger
db32d520d1
fix: Optimize reflows on the applications list page (#16812)
* optimized the reflows

* removed unneccessary changes

* fixing a cypress test

* updated a cypress test
2022-09-17 11:38:28 +05:30
Vishnu Gp
75bac52626
Added users name to sessionUser (#16825) 2022-09-17 07:55:13 +05:30
Ayush Pahwa
cc20cb2c20
fix: batching console log save calls in redux store (#16793)
* update: changed function call to store logs array directly

* update: moved from saving logs one by one to array
2022-09-16 19:18:54 +00:00
subratadeypappu
e791d7f0d9
fix: Class cast exception during file upload in S3 bucket (#15832) (#16746) 2022-09-16 21:14:27 +06:00
Keyur Paralkar
cb84bc68c5
fix: chart widget color fontfamily (#16750)
* fix: re-run chart widget reskinning migration

* fix: addressed review comments

* fix: added a new check for versions

* fix: moved the originalDSL to the testDSLs

* chore: removed console statement

* fix: addressed review comments
2022-09-16 19:50:29 +05:30
subratadeypappu
cf2ef37527
feat: Add a service layer to get AppsmithType from client-type (#16508) (#16619)
* feat: Add a service layer to get AppsmithType from client-type (#16508)

This commit takes care of the following things
- It creates a service layer to get the target AppsmithType from the client-side data type and the evaluated value
- This service layer is currently not consumed by any plugins
- A full JUnit test suit for MySQL-specific types

* feat: Remove FloatType and add comments for better understanding (#16508)

* feat: Add FallbackType and covert the DataTypeService to a util class (#16508)

This commit takes care of these
- Introduce FallbackType as a separate type
- Convert the DataTypeService to a util class
- Add java doc around the methods in DataTypeService class

* feat: Rename DataTypeService to DataTypeServiceUtils (#16508)
2022-09-16 17:40:28 +06:00
Shrikant Sharat Kandula
fc983fc65e
Fix hard-coded mime.types location (#16826) 2022-09-16 16:37:23 +05:30
Shrikant Sharat Kandula
8d2ac7ec87
fix: Fix NGINX in start-https clashing with system conf (#16803) 2022-09-16 16:08:32 +05:30
Aman Agarwal
9dda476efa
fix: updated design for save as datasource button (#16700)
* fix: updated design for save as ds btn

* fix: updated the name for save/edit function
2022-09-16 15:57:35 +05:30
Shrikant Sharat Kandula
c3ac06c639
chore: Allow env API for frame ancestors variable (#16765) 2022-09-16 13:07:16 +05:30
ChandanBalajiBP
2b70914f31
test: mysql datatypes cypress test cases (#16696)
* test: mysql datatypes cypress test cases

* test: cypress added comments with cleaner code

* updates w.r.t review comments

* fix 10th cases failure

* fix for test failing on CI

* fix for test failing on CI another way

* fix: address review comments
2022-09-16 11:51:25 +05:30
Dhruvik Neharia
88637de7aa
feat: Code Scanner Widget (#15990)
* feat: Add QR Scanner Widget Folder

* feat: Add QR Code Scanner in the Modal

* feat: Add viewfinder and close button

* QR generator

* feat: Change deafult camera in QR Scanner to back camera

* feat: remove qr generator widget from the registry

* feat: update qr scanner icon

* style: qr code scanner modal and video container, remove futile code

* feat: add camera switch control panel to qr scanner

* fix: update input devices list when the menu opens in qr scanner

* fix: viewfinder in qr scanner responsive on mobile

* feat: Add onCodeDetected event to the QR Scanner widget

* feat: Add QR Scanner to autocomplete's entity definitions

* feat: Add tooltip to QR Scanner

* fix: isDisabled for QR Scanner

* feat: Add icon and related properties to QR Scanner

* feat: Add QR Scanner search tags, remove futile styles

* feat: Add QR Scanner to themes, regex for button color

* test: Add one cy test for qr scanner

* revert: Remove qr scanner from system themes, will be merged in a seperate PR

* fix: typo 'disable' to 'disabled' in qr scanner widget

* test: add disabled and visibility cy tests for qr scanner

* test: add open and close qr scanner modal test

* feat: remove qr scanner image for tests

* feat: add TODO item for solving performance issues for QR Generator widget

* feat: shift from react-qr-reader to react-qr-barcode-scanner to enable barcode and QR scanning both

* feat: Update QR Scanner Widget to Code Scanner Widget

* test: update tests from qr scanner to code scanner widget

* refactor: move code scanner's property pane config to individual files

* fix: code scanner error message on permission denied

* feat: remove Modal.setAppElement from code scanner

* fix: hide code scanner scan animation overflow

* feat: code scanner modal close on escape and overlay click

* fix: code scanner video border radius on mobile

* test: scan qr test for code scanner

* feat: Add Modal.setAppElement for code scanner modal accessibility

* fix: typo in search tags of code scanner

* feat: update property pane content helper texts of code scanner

* feat: hide code scanner widget from explorer

* fix: code scanner events not working

* feat: hide code scanner widget from explorer

* feat: Show Code Scanner widget in Explorer

* fix: remove code scanner scan cypress test

* feat: Add barcode reader to search tags and put Modal.setAppElement inside a block in code scanner

Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:25:32 +05:30
Favour Ohanekwu
b28d7df7c6
fix: prevent duplicated fields in debugger logs (#16761)
* Improve dependency chain generation

* Update jest test
2022-09-16 05:42:20 +01:00
Keyur Paralkar
fff5c16f89
feat: table widget switch column type (#16262)
* feat: added checkbox column type

* fix: addressed review changes

* feat: added filter for checkbox column type

* fix: checkbox alignment

* fix: horizontal alignement property added for checkbox column type

* test: added cypress test and addressed feedback changes

* fix: add new property cellComponentHorizontalAlignment

* fix: addressed review comments

* fix: changed column type order to alphabetical order

* refactor: removed unused imports

* fix: typings for the dynamic label

* fix: addressed review comments

* feat: added switch column type to table widget

* fix: removed unused imports

* fix: disabled cursor flicker issue

* fix: inline editing for checkbox column type

* fix: addressed QA callouts

* fix: addressed qa callouts

* fix: addressed review callouts

* fix: horizontal alignment issue

* fix: added unsaved marker and cypress test

* fix: alginment issues for the tooltipped wrapped switches

* fix:
* rebase new property pane changes
* cypress test fixes
* added support to dynamically change the section name with the help of function

* fix:
* cypress tests
* rebased new property pane changes for switch column type

* fix: merge conflicts on property section

* fix: address code review callouts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:04:11 +05:30
Rimil Dey
903aaa7a14
feat: Change navigate to UI (#14856)
* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Initial work to change navigate to UI

* Remove console.logs

* Adjust default parameters and getters/setters for page dropdown field

* change url field getter so page names are not showm

* Remove ../ from the imports
Remove unnecessary todo

* Add check for undefined fields

* Add validations for url/page name, add error message

* Make height auto to accommodate the flexible size of query param text box

* Update dropdown list of pages when page names are updated

* Set tab to url when a url has been entered, else default to page

* Add feature tests

* Add check on null value in isValueValidURL to ensure it does not crash the app

* Remove unused ref

* Fix bug when switch is selected and a new page addition let to page crash

* Fix types and imports

* Update the tests

* Add ref back to the code

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-16 10:00:16 +05:30
Sumit Kumar
ecec0e1975
fix: re-install graphql plugin in workspaces (#16764)
* re-install graphql plugin in workspaces
2022-09-15 21:09:01 +05:30
balajisoundar
c37a8a4cfe
fix: table widget issue where editableCell is undefined (#16729) 2022-09-15 13:17:15 +05:30
Satish Gandham
12f9a005ae
chore: Refactor getSelectedWidget selector (#16647)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Rename getSelectedWidget to getLastSelectedWidget in selectors/ui

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-15 05:44:11 +00:00
Chris Maeda
0351b0e9a3
fix: Deserialize java.time.Instant objects that are represented as JSON objects (#16321)
Deserialize java.time.Instant objects that are represented as JSON objects; e.g {"nano": 790000000,"epochSecond": 1641498664}
2022-09-15 09:41:23 +05:30
Satbir Singh
193dacfeca
chore: Adding JS Object Events (#16472)
* Event for creating new JS Object

* Adding tracking event for function execution

* Removing unwanted comment

* Events for adding new functions added

* Handling optional properties

* Changing event names

* Renaming Event Sources to JS_OBJECT
2022-09-14 21:04:10 +05:30
Shrikant Sharat Kandula
2a55633416
Change worker_connections to 1024 2022-09-14 19:53:03 +05:30
Arpit Mohan
7580eb9990
ci: Fixing the RTS build workflow (#16748)
## Description

The problem with the RTS workflow after the induction of AST parsing was that while copying the `node_modules`, Ubuntu doesn't follow the symlink and copy the content. It simply copies the symlink as is. This causes issues for RTS service to start.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Personal repository

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-09-14 14:24:20 +05:30
Favour Ohanekwu
16b04f33a6
fix: incorrect lint error position (#16526)
* perform string search using original binding

* Add jest test

* Improve code for better readability
2022-09-14 09:35:29 +01:00
Satish Gandham
a706ad3160
perf: Widget layer optimization (#16502)
* Widget layer optimization
Fix positioned and snipeable component wasted renders

* Some cleanup

* - Few more rough optimization

* Remove console logs

* Clean imports

* Prevent wasted renders of draggable component.

* Add new selector

* - Some code reorganization
- Reduce wasted renders of resizable component

* Clean up positioned container

* Final clean up

* Remove unused import

* Some cleanup based on review comments

* Some code refactoring

* Reduce wasted renderes when dragging and resizing

* Remove stray imports

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-09-14 12:25:08 +05:30
Shrikant Sharat Kandula
d1110fc774
Restore nginx-app.conf.template 2022-09-14 11:16:00 +05:30
albinAppsmith
3beea62e44
feat: Updates modal new design changes (#16553)
* feat: Updates modal new design changes

* Title and Subtitle font changes

* test cases fixed for product updates modal
2022-09-14 10:40:48 +05:30
Shrikant Sharat Kandula
7ab3b4fbab
feat: Support running NGINX for development without Docker (#16667) 2022-09-14 09:58:31 +05:30
NandanAnantharamu
642cdb886b
test: updated locator with wait for flaky test (#16734)
updated locator with wait
2022-09-14 08:39:09 +05:30
Shrikant Sharat Kandula
89620d3cbf
Fix unused reactive publisher (#16732) 2022-09-13 18:08:35 +05:30
Shrikant Sharat Kandula
83fc89f1a1
fix: No-op Asserts (#16690) 2022-09-13 13:55:33 +05:30
Trisha Anand
becd778fe1
chore: Added username to error logs when signup is disabled (#16720) 2022-09-13 13:07:12 +05:30
Parthvi
ca64ceb4fb
test: update cypress test fork_template_spec (#16719)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-09-13 12:50:09 +05:30
balajisoundar
87774a64ac
chore: fix table widget migration merge conflict (#16711) 2022-09-13 12:01:40 +05:30
NandanAnantharamu
6f45430395
test: updated test and dsl (#16656)
updated test and dsl
2022-09-13 11:56:37 +05:30
balajisoundar
afb9aa93c1
feat: Table widget V2 Inline editing validation for plain text & number column (#15954) 2022-09-13 11:11:59 +05:30
balajisoundar
9bc5a5e076
chore: Expose widget configuration to define properties that can set … (#16573) 2022-09-13 11:10:08 +05:30
Hetu Nandu
0970389143
chore: Delete service worker cache (#16668) 2022-09-13 10:38:45 +05:30
Ayangade Adeoluwa
342c5cc673
fix: Fix Api url path issue (#16628)
* Fix Api url path issue

* Modify test cases
2022-09-13 05:02:59 +00:00
Ayangade Adeoluwa
b3c4f7c392
feat: AST apis for parsing script and returning identifiers (#16252)
* rts configurations for ast

* update shared dependencies.json for shared ast module

* feat: api for script to identifiers

* fix: typo for identifiers

* feat: api for multiple scripts to get identifiers

* fix: rts config, apis for ast

* fix: removed unnecessary changes for ast modules

* fix: docker image for rts including ast shared module, rts file alias ref

* fix: added comments in build.sh file

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-09-12 14:45:47 +05:30
Dhruvik Neharia
be6107b715
feat: Divider Reskinning (#16643)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-12 14:15:56 +05:30
Aishwarya-U-R
bdadb827e3
test: Script updates for flaky tests (#16631)
* CreateNewApp spec flaky fix

* fix

* Moved RepoLimit to commented files

* Inline spec failure fix - case 19

* Table FIlter specs V1/V2 split

* Binding/Table_Property_ToggleJs spec - V1/V2 fix

* Spec name update

* Wait increase

* DS - duplicate error capture fix

* revert

* Recaptcha spec fix

* Jsfun exe flaky fix - unskipped case

* jsfunc exec spec fix

* jsfunex spec fix

* Api bugs spec fix

* Api bugs spec fix

* Chartdata point spec flaky fix

* Theme_multiselect brown type fix

* Jsfunc exe spec fix

* Inline spec fix

* Inline spec fix

* Inline spec fix

* Theme multiselect spec fix

* Promises spec fix

* JSFun Exe spec fix

* Api_all verb methods update

* List1 spec 4th case fix

* Jsfun exe skipping 10th case

* jsunf exe 10th case trial fix

* firestore stub error capture

* jsonload failng spec skip

* JSonload spec fix

* json load spec fix

* Git repo moved back
2022-09-12 09:48:44 +05:30
Parthvi
ee8259d311
test: Fix flaky git tests (#16675)
* fix flaky git tests

* undo skip for git import tests
2022-09-12 08:59:06 +05:30
Trisha Anand
aa45f851eb
chore: Minor code refactor + Deleting PermissionGroupServiceTest from CE (#16680)
Minor code refactor + Deleting PermissionGroupServiceTest from CE
2022-09-11 20:53:12 +05:30
Parthvi
e3ba513e2a
fix: Update AppsmithError.java (#16676)
Update AppsmithError.java
2022-09-11 00:06:26 +05:30
AS Laguna
65890a1ebf
fix: Table widget default selected row should display value "0" instead of a watermark (#16626)
* Changed placeholderText to defaultValue

To resolve this issue I swapped out two properties of this object, placeholderText and defaultValue, to change the placeholder zero for an actual 0 character.

* Changed defaultValue from a string to an int

It seems there was an issue being caused by having the default value being a string where typing a zero still resulted in a value of -1. Changing it to an int seems to have resolved this issue.
2022-09-09 14:40:17 -04:00
arunvjn
7d0dae89d8
fix: Better autocomplete for fast-xml-parser (#16452) 2022-09-09 22:07:33 +05:30
Sumit Kumar
0cbe81dfde
feat: merge GraphQL plugin to release (#16554)
* merge GraphQL plugin to release
2022-09-09 21:29:47 +05:30
Tolulope Adetula
b4b4284a56
fix:allow clear button in tree select widget (#16542)
* Fix: tree select allowClear button

* fix: import duplication

* Fix: add tests for bug

* fix: Add Placeholder fix

* fix: test case

* fix: remove comments
2022-09-09 04:55:31 -07:00
Vishnu Gp
43ee8b2089
chore: Changes in user invited analytics event (#16611) 2022-09-09 10:31:18 +05:30
Aswath K
a7ff6cb739
chore: Fix Jest test Flakiness (#16596) 2022-09-09 10:06:45 +05:30
Arpit Mohan
697bdecaa5
ci: Modularizing the Github actions workflow for maintainability (#16505) 2022-09-09 01:08:55 +05:30
Anagh Hegde
4d609a5b4d
feat: Add non-configured datasource to merge template to an existing app API response (#15918)
Add unconfigured datasource to merge template to app API
2022-09-08 22:55:47 +05:30
NandanAnantharamu
14140c10b7
test: fix for flaky test (#16534)
* updated test

* updated test

* uncommented the working tests

* updated test to avoid flakiness
2022-09-08 18:41:20 +05:30
Pawan Kumar
291dfadfb3
feat: Rating reskinning (#16527)
* update rating widget

* fix initial value
2022-09-08 16:43:09 +05:30
Pawan Kumar
0a770c84fe
feat: Datepicker reskinning (#16587)
* update datepicker

* fix colors
2022-09-08 16:42:50 +05:30
Keyur Paralkar
e7209f06fd
feat: Table widget checkbox column type (#15933)
* feat: added checkbox column type

* fix: addressed review changes

* feat: added filter for checkbox column type

* fix: checkbox alignment

* fix: horizontal alignement property added for checkbox column type

* test: added cypress test and addressed feedback changes

* fix: add new property cellComponentHorizontalAlignment

* fix: addressed review comments

* fix: changed column type order to alphabetical order

* refactor: removed unused imports

* fix: typings for the dynamic label

* fix: addressed review comments

* fix: disabled cursor flicker issue

* fix: inline editing for checkbox column type

* fix: addressed QA callouts

* fix: addressed qa callouts

* fix: addressed review callouts

* fix: horizontal alignment issue

* fix:
* rebase new property pane changes
* cypress test fixes
* added support to dynamically change the section name with the help of function

* fix: type casting issue for sectionName

* fix: addressed review comments

* chore: removed unused imports

* fix: added prop.hidden comparision in the memoized PropertySection component

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-08 16:35:59 +05:30
Dhruvik Neharia
c87fd20b02
feat: Update QR Scanner Themes to Code Scanner Themes (#16595)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-08 15:04:12 +05:30
rahulramesha
aec2843a60
fix: fix debugger logs for performance (#16451)
This Change includes two parts,

In Debugger Saga, Action is being triggered in a loop, that action is in turn updating Redux State in a loop, This is bad for performance as they end up notifying the all the subscribers of the state. Changed it to update state once rather than doing it individually.
In the Reducer, changed it to ImmerReducer so that only particular object of the local state changes on update rather than updating reference of the entire state.
2022-09-08 08:16:28 +00:00
Ayangade Adeoluwa
c7ceba6680
fix: Fix border bottom highlight issue (#16541)
Fix border bottom highlight issue
2022-09-08 08:16:07 +00:00
Trisha Anand
96435ac235
chore: Using single permission group for all public viewable objects (#16620) 2022-09-08 11:37:12 +05:30
Arpit Mohan
8590308945 ci: Commenting out the test for git repo limit check
This test needs to be improved to hit TED instead of the Github API
2022-09-08 02:35:06 +05:30
Arpit Mohan
15ddca66c8
ci: Removing the git repo limit test as this test will fail in EE. (#16622)
We need to organize the Cypress test suite in a way that we have different checks running in CE vs EE.
2022-09-08 00:41:48 +05:30
Aishwarya-U-R
bf232dbb7e
test: Script updates for flaky tests (#16558) 2022-09-07 23:55:55 +05:30
Trisha Anand
245a09ae21
fix: Duplicate default workspaces for first login using SSO (#16606) 2022-09-07 14:11:04 +05:30
Ayush Pahwa
e53045de5a
fix: updating trigger meta to get the source of console logs (#16520)
For nested functions, the trigger meta is not available for subsequent functions. So in cases where the dynamic trigger has the relevant info, we can use that to update the trigger meta and then use that meta to display the source of the logs.

Fixes #16515
Fixes #16483
Fixes #16514

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-07 11:53:47 +05:30
Anagh Hegde
274205196f
test: refactor git test (#16550)
* Refactor tests

* Use Mock.Spy to mock the method of the testing class

* Add the mock for new workspaceId in the test class

Co-authored-by: Trisha Anand <trisha@appsmith.com>
2022-09-07 10:21:09 +05:30
Shrikant Sharat Kandula
06c8210a3a
fix: Fix LinkageError with macOS DNSResolver class (#16581)
On macOS, when running a MySQL query, we see the following error:

```
java.lang.ClassCastException: class io.netty.channel.kqueue.KQueueEventLoopGroup cannot be cast to class io.netty.channel.EventLoopGroup
```

This is because of a `LinkageError`, caused because these classes exist both in the parent `server` module classpath, as well as in this plugin's classpath separately. To fix this, we removed this dependency from the server module.

But then, this caused a problem with how the `DNSResolver` class was being, well, resolved by the application class loader, vs the plugin class loader. This is a macOS specific problem, and doesn't affect other operating systems.

For this, we add just this package as a dependency to the MySQL plugin.
2022-09-06 22:00:53 +05:30
Trisha Anand
70bb40d5c5
fix: Creating default workspace for SSO signed up users before creating first application (#16579) 2022-09-06 12:55:07 +00:00
Rishabh Rathod
ee35760097
Add remove def when updating def (#16580) 2022-09-06 17:21:15 +05:30
Shrikant Sharat Kandula
9dbc648e4c
Fix LinkageError in Saas & GSheets plugins (#16565) 2022-09-06 13:23:04 +05:30
Aishwarya-U-R
353e007e78
test: Script updates for flaky tests (#16533)
* Autosave trial fix

* json form field flaky fix

* js fun exe spec flaky fix
2022-09-06 08:59:39 +05:30
Trisha Anand
9cf3714d36
chore: Code Split for Policy Generator (#16538) 2022-09-05 20:40:52 +05:30
Aishwarya-U-R
06cd7542f5
test: Script updates for flaky tests (#16455)
* UUID table load time increase

* Autocomplete js api failiure fix

* mysql crud fix

* MySQL, Postgres CRUD updates

* flaky fix

* flaky fix

* Upgrade Appsmith spec - moved

* MySQL CRUD spec split

* fix

* fix

* fix

* fix

* Postgres CRUD spec split

* Postgres CRUD spec split

* fix

* EE names update

* fix

* fix
2022-09-05 15:24:56 +05:30
Tanvi Bhakta
a308d564f7
chore: bump ds version (#16488)
* update to v1.0.12

* bump ds version

* bump ds version (again)
2022-09-05 15:24:00 +05:30
Vishnu Gp
75a9858397
chore: Added some changes in authentication analytics events (#16432)
* chore: Added some changes in authentication analytics events

* Review Changes
2022-09-05 10:46:59 +05:30
Rishabh Rathod
731bbc9428
fix: update property pane code editor autocomplete def on focus (#16263) 2022-09-05 10:23:39 +05:30
Aswath K
8b297e4da1
chore: Property pane design changes (#16112) 2022-09-05 10:22:39 +05:30
Hetu Nandu
09be15ce3f
fix: Never cache index.html via Service Worker (#16490) 2022-09-05 08:54:44 +05:30
Trisha Anand
97a651c6a5
chore: update-bad-theme migration should only run once. (#16507)
Update bad theme migration should only run once.
2022-09-04 21:04:20 +05:30
Ayush Pahwa
7d621de978
feat: console log implementation in appsmith (#16286)
* feat: capture console from across the app (#15676)

* create: console override file

- Adds methods to override the given console functionality to capture the console statements written by the user

* update: evaluate function to extract console op

- Added logs extraction for both sync and async functions
- Adding them to the return object of the evaluations

* update: timestamp field to log addition method

- Added optional argument to function definition for inputting the timestamp of the log
- This is done to maintain timings of the execution of the log

* update: interface for log objects

* update: post function execution logic

- Added logic to push the logs generated by the evaluation to the logs store

* update: added handling for sending nested fns

- While console logging functions or objects that had functions was causing an error
- Added a check for removing functions and replacing them with name of the functions instead

* chore: added types and comments

* fix: updated evaluation tests

* fix: added check for log in returned obj

* update: added the source data in the trigger logs

- Removed on js execute logs from showing up here since they are already handled. If they are not removed, they will show up on the first page load twice

* add: ellipsis function for log title string

- This is to keep big object contained in the first line only

* update: made logs reset function public

* update: resetting logs before new eval

- Logs object has to be cleared before next eval can happen to make sure there are no roll overs from last evals

* chore: added comments

* add: extracting logs after eval of functions

* add: storing logs to redux after eval

* refactor: updated types

* add: func to store logs w/ severity as arg

* refactor: updating func call for user logs

* chore: fixed elipsis logic

* chore: removed unused type

* chore: updated preview text logic

* add: type for transfer object post eval

* update: aded new userLogs obj to dataTreeEvaluator

* update: passing logs from object to saga

* update: parsing received userlogs

* refactor: used predefined fns

* refactor: moved resetlogs to common func

* chore: updated comments

* feat: update redux store and UI for system + user logs (#15936)

* update: updated types for the redux store

- Added category and data fields in the log object

* update: types of log redux store

* update: calls for the console log store function

* update: icon fetch func for log item UI

* update: syncing UI with the new designs (WIP)

* chore: fixed lint error

* update: filters for logs

* update: icon for clearing log filters

* update: filtering function

- Added checks against category and severity

* update: logitem UI

- updated type of the UI object
- added css based ellipsis
- added toggle for console logs
- added array of json views for objects/arrays
- css tweaks

* update: debugger cta

- Removed copy option
- Updated UI

* update: logic for expanding user logs

- Removed debugger CTA
- Fixed position for the expand/collapse icon
- Added joining char for when the log is expanded

* update: assets for new UI

- updated colors
- Added new icon

* hotfix: ternserver code

* add: search across the text of log

* update: icons for the app

* update: click to expand/collapse of logs

* fix: search keyword update on change within JSObjects

* fix: alignment of log items in both states

* update: jest tests for debugger errors and filter

* fix: drop down options color issue

- the icon used was not the standard one
- We have a lot of duplicates of the same icon

* fix: synced with ADS changes on release

* fix: remove dependency from old icon

* add: cypress selectors for automation testing

* fix: replaced static messages with variables

* fix: updated the dependency map for filter

* fix: height of the filter drop down

* fix: chaining logic for search filter

* fix: syncing the padding values to ADS

* fix: help icon visibility issue

* fix: width of filter dropdown

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>

* add: e2e tests for console statements using IIFE

* test: added test for console logs in jsobjects

* fix: functionality of expanding context menu on msg click

* fix: added try catch and handling for numbers

* hotfix: handling unwanted toasts

* fix: alignment and clickable cursor

* fix: alignment of expanded span in console logs

* add: analytics event on new console log created

* fix: added handling for boolean and undefined

* fix: removed log reset from common func

- Whenever we are creating global DTO, the logs were being reset. This caused logs to reset whenever a promise was encountered in the logs.

* fix: combined JS log saving to widget process

* add: new analytics event on filter changed

* update: added handling for empty value

* update: removed comma between multiple logs

* update: synced test changes with release

* update: removed unused wait timings

* Logs spec script update

* update: ts methods in log spec e2e test

* logs spec update

* update: removed body clicks from test script

* Logs spec update

* update: removed ask from google option

* refactor: ui fixes

* fix: text selection of logs

* fix: updated dropdown width management

* update: made the flushlogs function async

* update: added handling for promises

* update: added test with promises fail and pass

* fix: added sync variant to work for sync objects

* refactor: commented out unused tests

* update: exceptions in the name of log entity

* fix: pagination of logs to handle dynamic data stream

* fix: removed unused async function

* fix: moved logs handling to separate saga

* fix: color for context menu text

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-09-04 17:28:05 +05:30
Arpit Mohan
763261716b
chore: Fixing lint errors in the Cypress code base (#16504) 2022-09-03 23:57:41 +05:30
Trisha Anand
918c018049
fix: Performance improvement of /new API by updating the api used for fetching apps. Eliminating public applications from the result (#16497) 2022-09-03 22:33:29 +05:30