Commit Graph

7 Commits

Author SHA1 Message Date
Rajat Agrawal
9ca49b88a5
ci: Add a pre-push hook to check for only ce changes (#34992)
## Description
This PR checks for file changes when pushing in CE repo and passes if
the changes are present only in CE folder. To override the check,
developers can use --no-verify check when pushing the changes. This PR
is an extension of https://github.com/appsmithorg/appsmith/pull/32791


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Implemented a pre-push Git hook to check for specific file changes and
provide feedback before pushing to a remote repository.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-07-18 10:18:34 +05:30
Valera Melnikov
2f973d2e98
fix:lint staged (#27992)
## Description

1. Optimise `lint-staged` scripts so that they are not executed twice.
For some patterns, I removed the `prettier` checks since they are
executed by`eslint` checks as well.
2. Add caching for all scripts.
3. Optimisation of the `git secrets`, now we check only staged files.
Earlier we checked all the files that `git ls-files` returns. [Here more
about this.](https://github.com/awslabs/git-secrets#options-for-scan).
2023-10-12 20:35:54 +03:00
Ankita Kinger
70388f3180
chore: Updating pre-commit hook for staged files to not run spotless check if its a merge commit (#27170) 2023-09-15 19:33:25 +05:30
Valera Melnikov
a14df58239
fix: pre-commit logic (#25324)
## Description
Hot fix for pre-commit logic

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-12 12:37:05 +03:00
Valera Melnikov
2b59f40a0b
fix: fixes for running checks on pre-commit for BE and FE separately (#25319)
## Description
Fixes for running checks on pre-commit for BE and FE separately

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-12 10:12:28 +03:00
Nidhi
fca545a115
ci: Added pre-commit hook to check for Spotless formatting (#25228) 2023-07-10 11:18:52 +05:30
Valera Melnikov
96c42d75d4
chore: improve husky and lint-staged checks (#21679)
## Description

1. Update husky, prettier and lint-staged then move them to
devDependencies
2. Configure husky and lint-staged
3. Impriove rules for the lint commands
4.  Fix errors of eslint and prettier. 
5. Remove redundant files

## Type of change


- Chore (housekeeping or task changes that don't impact user perception)


Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-03-23 17:02:18 +05:30