9c99f36bd6
4 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Rishabh Saxena
|
9c99f36bd6
|
Comments feature fixes (view mode) (#5081) | ||
|
imgbot[bot]
|
a11e732b61
|
[ImgBot] Optimize images (#4707)
*Total -- 3,752.13kb -> 3,526.66kb (6.01%) /static/images/users.png -- 15.03kb -> 6.11kb (59.37%) /static/images/integrations.png -- 14.43kb -> 9.37kb (35.05%) /static/images/build-tool.png -- 27.04kb -> 21.86kb (19.15%) /app/client/src/assets/icons/ads/commentIcon.png -- 0.90kb -> 0.77kb (14.67%) /static/images/git-banner.jpg -- 779.36kb -> 666.22kb (14.52%) /static/images/git-banner-left.png -- 72.13kb -> 65.42kb (9.29%) /app/client/src/assets/icons/comments/context-menu.svg -- 0.43kb -> 0.40kb (5.92%) /app/client/src/assets/icons/comments/commentCursor.png -- 1.41kb -> 1.34kb (4.72%) /app/client/src/assets/images/comments-onboarding/step-4.png -- 14.90kb -> 14.26kb (4.3%) /static/images/animations/video-preview.gif -- 1,300.08kb -> 1,247.97kb (4.01%) /static/images/animations/writing-js.gif -- 264.13kb -> 254.80kb (3.53%) /static/images/git-banner-right.png -- 654.13kb -> 633.46kb (3.16%) /static/images/animations/running-api.gif -- 38.67kb -> 37.59kb (2.8%) /app/client/src/assets/icons/ads/open.svg -- 0.32kb -> 0.32kb (1.81%) /app/client/src/assets/icons/ads/cross.svg -- 0.22kb -> 0.21kb (1.81%) /app/client/src/assets/icons/control/back.svg -- 0.26kb -> 0.26kb (1.49%) /app/client/src/assets/icons/ads/app-icons/draghandler.svg -- 0.53kb -> 0.52kb (1.48%) /app/client/src/assets/icons/comments/comment-mode-unread-indicator.svg -- 0.40kb -> 0.39kb (1.46%) /app/client/src/assets/icons/comments/send-button.svg -- 0.21kb -> 0.21kb (1.41%) /app/client/src/assets/icons/comments/read-pin.svg -- 0.29kb -> 0.29kb (1.34%) /app/client/src/assets/icons/comments/unread-pin.svg -- 0.29kb -> 0.29kb (1.34%) /app/client/src/assets/icons/comments/check-oval.svg -- 0.30kb -> 0.30kb (1.28%) /app/client/src/assets/icons/comments/emoji.svg -- 0.40kb -> 0.40kb (1.22%) /app/client/src/assets/icons/comments/reaction-2.svg -- 1.19kb -> 1.17kb (1.15%) /app/client/src/assets/icons/control/open-new-tab.svg -- 1.09kb -> 1.08kb (1.08%) /app/client/src/assets/icons/comments/trash.svg -- 0.32kb -> 0.32kb (0.91%) /app/client/src/assets/icons/comments/chat.svg -- 0.34kb -> 0.33kb (0.87%) /app/client/src/assets/icons/comments/pin_3.svg -- 0.39kb -> 0.39kb (0.75%) /app/client/src/assets/images/profile-placeholder.svg -- 0.54kb -> 0.54kb (0.72%) /app/client/src/assets/icons/comments/reaction.svg -- 0.83kb -> 0.82kb (0.71%) /app/client/src/assets/icons/comments/pen.svg -- 0.42kb -> 0.41kb (0.7%) /app/client/src/assets/icons/comments/edit-mode.svg -- 0.42kb -> 0.42kb (0.7%) /app/client/src/assets/icons/comments/link.svg -- 0.65kb -> 0.64kb (0.6%) /app/client/src/assets/icons/comments/unpin.svg -- 0.51kb -> 0.51kb (0.57%) /app/client/src/assets/icons/comments/toggle-comment-mode.svg -- 0.51kb -> 0.51kb (0.57%) /app/client/src/assets/icons/ads/cancel.svg -- 0.52kb -> 0.51kb (0.57%) /static/images/animations/selections.gif -- 119.85kb -> 119.23kb (0.52%) /app/client/src/assets/icons/control/download-data-icon.svg -- 0.62kb -> 0.61kb (0.48%) /app/client/src/assets/icons/comments/pin.svg -- 0.63kb -> 0.63kb (0.47%) /app/client/src/assets/icons/comments/pin_2.svg -- 0.87kb -> 0.87kb (0.45%) /static/images/animations/move-around.gif -- 229.66kb -> 228.69kb (0.43%) /app/client/src/assets/icons/ads/bug.svg -- 0.70kb -> 0.70kb (0.42%) /static/images/animations/drag-drop.gif -- 159.38kb -> 158.73kb (0.41%) /app/client/src/assets/icons/ads/wand.svg -- 2.79kb -> 2.77kb (0.39%) /app/client/src/assets/icons/ads/warning-triangle.svg -- 1.08kb -> 1.07kb (0.36%) /app/client/src/assets/icons/control/filter-icon.svg -- 0.91kb -> 0.91kb (0.32%) /app/client/src/assets/icons/ads/card-context-menu.svg -- 1.12kb -> 1.12kb (0.26%) /app/client/src/assets/icons/widget/list.svg -- 1.65kb -> 1.65kb (0.24%) /app/client/src/assets/images/comments-onboarding/step-3.png -- 39.31kb -> 39.29kb (0.05%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> |
||
|
Rishabh Saxena
|
8964aea9df
|
[Feature] Comments feature updates (#4579) | ||
|
Rishabh Saxena
|
a0d2e8533d
|
Initialise comments (#3328)
* Initial scaffolding for comments CRUD APIs * add actions * add assets * state management for existing comments and creating new * add ui components * add overlay comments wrapper to baseWidget * add toggle comment mode button at editor header * trigger tests * Disallow commenting as someone else * Add applicationId for comments * lint * Add overlay blacklist to prevent component interaction while adding comments * Comment thread style updates * Placeholder comment context menu * Controlled comment thread visibility for making new comments visible by default * Update comment type description * Reset input on save * Resolve comment thread button ui * fix close on esc key, dont create new comment on outside click * Submit on enter * add emoji picker * Attempt at adding a websocket server in Java * CRUD APIs for comment threads * Add API for getting all threads in application * Move types to a separate file * Initial commit for real time server (RTS) * Add script to start RTS * Fix position property * Use create comment thread API * Use add comment to thread API * Add custom cursor * Dispatch logout init on 401 errors * Allow CORS for real time connection * Add more logs to RTS * Fix construction of MongoClient * WIP: Real time comments * Enable comments * Minor updates * Read backend API base URL from environment * Escape to reset comments mode * Set popover position as auto and boundary as scroll parent * Disable warning * Added permissions for comment threads * Add resolved API for comment threads * Migration to set commenting permission on existing apps * Fix updates bringing the RTS down * Show view latest button, scroll to bottom on creating a new comment * Cleanup comment reducer * Move to typescript for RTS * Add missing server.ts and tsconfig files * Resolve / unresolve comment * Scaffold app comments * Minor fixes: comment on top of all widgets, add toggle button at viewer header * Reconnect socket on creating a new app, set connected status in store * Retry socket connection flow * Integration tests for comments with api mocks using msw * Fix circular depependency * rm file * Minor cleanup and comments * Minor refactors: move isScrolledToBottom to common hooks, decouple prevent interactions overlay from comments wrapper * Use policies when pushing updates in RTS * ENV var to set if comments are enabled * Fix: check if editor/viewer is initialised before waiting for init action * Add tests for comments reducer * Revert "ENV var to set if comments are enabled" This reverts commit 988efeaa69d378d943a387e1e73510334958adc5. * Enable comments for users with appsmith email * lint * fix * Try running a socket.io server inside backend * Update comment reducer tests * Init mentions within comments * Fix comment thread updates with email rooms * Minor fixes * Refactors / review suggestions * lint * increase cache limit for builds * Comment out tests for feature that's under development * Add Dockerfile for RTS * Fix policies missing for first comment in threads * Use draftJS for comments input with mentions support * fix fixtures * Use thread's policies when querying for threads * Update socket.io to v4 * Add support for richer body with mentions * Update comment body type to RawDraftContentState * fix stale method * Fix mentions search * Minor cleanups * Comment context menu and thread UI updates * revert: Scaffold app comments * Yarn dependencies * Delete comment using id api added * Init app comments * Add test for creating thread * Api for delete comment with id * Test comment creation response and policies * Copy comment links * Fix reset editor state * Delete valid comment testcase added * Delete comment TC : code refactor * Don't allow creating comments with an empty body * Pin comments WIP[] * Ignore dependency-reduced-pom.xml files from VCS * Cleanup of some dev-only files, for review * Delete comment * Update socket.io to v4 in RTS * Pin and resolve comment thread object added in commentThread * Pin and resolve comment thread object added in commentThread * Update comment thread API * Added creationTime and updationTime in comment thread response * Added creationTime and updationTime in comment thread response * Added human readable id to comment threads, fallback to username for null name in user document * Refactor * lint * fix test, rm duplicate selector * comment out saga used for dev * CommentThread viewed status, username fallback for getName=null, username field added in pin & resolve status * lint * trigger tests Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com> |