Commit Graph

25 Commits

Author SHA1 Message Date
balajisoundar
c9f65d080a
fix: skip bad table migration thats breaking computed columns we di… (#10897) 2022-02-04 23:07:22 +05:30
Bhavin K
cd02572374
fix: table column name migration update (#10383)
* fix: table column name migration update

* test: added test case for migration

* fix: migration version update

* fix: update latest version logic

* fix: cypress updated

* fix: updated test case

* fix: delay added

* fix: test case update

* fix/ one more custom column added
2022-01-25 13:54:13 +00:00
Bhavin K
e995865b28
fix: updated columns names (#9715) 2021-12-29 17:12:07 +05:30
Paul Li
3f87f4959e
fix: Table Widget Icon Button should be having a default variant (#8664)
* fix: Table Widget Icon Button should be having a default variant

-- Add update logic for button variant property

* fix: Table Widget Icon Button should have default variant

-- Revert old solution
-- Set default button variant to PRIMARY both in getTableColumns and in propertyConfig

* fix: Table Widget Icon Button should have default variant

-- Change comments for updateIconAlignment utility function
-- Create a migration for button variant

* fix: Table Widget Icon Button should have default variant

-- Remove unused index parameter from forEach statement

* fix: Table Widget Icon Button should have default button variant

-- Fix on misuse of forEach on primaryColumns object

* fix: Table Widget Icon Button should have default variant

-- Change buttonVariant to TERTIARY instead of PRIMARY
2021-11-23 22:10:13 +08:00
Tolulope Adetula
79c5042e34
fix: null check in Table widget (#8979)
* fix: null check in Table widget

* fix: null checks

* fix: add tests

* fix: make migrateTableSanitizeColumnKeys readable
2021-11-12 01:33:47 -08:00
Tolulope Adetula
dbbb7b84b2
fix: disable sorting in view mode (#7387)
* fix: disable sorting in view mode

* fix: add sortable to property pane

* fix: fix failing tests

* fix: Add cypress test

* fix: remove unneccesary useMemo

* fix: sortable columns

* fix: default switch value

* fix: revert switch control and add migrations

* fix: migration
2021-11-08 21:08:39 -08:00
Aswath K
20c1b56932
fix: table button migration issues (#7825) 2021-09-27 10:45:51 +05:30
Vicky Bansal
609cdc05e4
feat: Table selected row and action trigger UX improvement (#7310) 2021-09-23 17:16:47 +05:30
ashit-rath
6d7ebf81b1
fix: New table widget migration to sanitize primaryColumn, columnOrder and binding paths (#7037)
* Table widget migration to sanitize keys and binding paths

* added new test case

* modified the logic to sanitize dynamicBindingPathList

* fix calling migrateTableSanitizeColumnKeys on child and fix updating dsl version
2021-09-13 17:33:39 +05:30
Abhinav Jha
b49f5097c6
refactor: Widget Development API (#6405) 2021-09-09 20:40:22 +05:30
Tolulope Adetula
742f0cf1ec
feat: compact mode in property pane (#6637)
* fix: compact mode

* fix: test

* fix: remove row height visibility

* fix: options label for compactMode

* feat: Add test

* Fix: failing test

* fix: test

* fix: test case.

* fix failing test

* fix: move position of rowHeight prop in property pane
2021-09-06 00:05:51 -07:00
Yash Vibhandik
158a71acab
FIX #3123 : added custom csvSeparator property in table widget for csv download (#6291) 2021-08-18 16:03:26 +05:30
Tolulope Adetula
b6f9aef70a
feat: Add isDisabled to Button column and isVisible to all Table widget Column settings (#4819) 2021-08-17 18:24:43 +05:30
rahulramesha
8a71fb68b2
Revert "Supporting all ASCII characters in table widget (#6041)" (#6429)
This reverts commit 3ae1bd6d95.
2021-08-10 13:27:29 +05:30
Bhavin K
3ae1bd6d95
Supporting all ASCII characters in table widget (#6041) 2021-08-02 12:07:55 +00:00
Bhavin K
7259d1e908
Bug/mustache binding extra space (#5587)
Table data was not populating when extra space inside the mustache binding, This is now fixed for list and table widget

* removed return statements from computed values

* list widget responce update

* table data handled return, added migration

* removed unused function

* updatetd rowBinding string generator

* fix failing cypress test

* fix cypress tests
2021-07-22 14:13:58 +05:30
Paul Li
8cef35cecf FEATURE-2111 : Show/Hide Table Controls
-- Add a migration for the header options visibilities
2021-06-09 06:16:48 -04:00
vicky.bansal@primathon.in
5ea2d961db Added migration to update parentRowSpace property of table widget 2021-05-31 17:09:06 +05:30
Vicky Bansal
bdf31dbf37
Text Widget new styling properties (#3167) 2021-04-01 14:00:33 +05:30
Pawan Kumar
d2a0980ec7
Fix: Table Actions button border radius and green shade color (#3222)
* update green shade and set border-radius 0 for table buttons

* updated color code for assertion

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-03-02 08:43:43 +05:30
Abhinav Jha
647151e527
Internal Fix: Migration issues with Table widget (#3212)
* Fix hidden columns migration

Fix issue where column ids have spaces in them leading to a crash

* Quick fix unit tests

* Remove tableData dependencies from selectedRow and selectedRows
2021-02-25 17:21:54 +05:30
Abhinav Jha
868f29eaeb
Fix selected row issue in view mode (#3186)
* Fix selected row issue in view mode

* Remove un-select feature
2021-02-24 15:59:19 +05:30
Abhinav Jha
59f56c8052
Internal Fix: When tables are migrated, the computedValue for the columns do not have currenRow (#3066) 2021-02-19 10:21:52 +05:30
Abhinav Jha
47145b7ff7
Internal Fix: migration of dynamicTriggerPathList in Table Widget(#3064) 2021-02-19 10:19:54 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30