Commit Graph

1030 Commits

Author SHA1 Message Date
yatinappsmith
2e783f1f62
CI: fixed token (#29782)
fixed token
2023-12-21 15:35:00 +05:30
yatinappsmith
c902d1977a
CI: fix server build added missing quotes (#29780)
fix server build added missing quotes

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Improved the handling of user information in the automated server
build process to ensure compatibility with values containing spaces.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-21 15:23:44 +05:30
yatinappsmith
33b073dd30
CI: Added Cache for Server Build (#29775)
## Description
Added cache for server
#### PR fixes following issue(s)

#### Media

#### Type of change

- New feature (non-breaking change which adds functionality)

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [x] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Implemented caching for release builds to enhance efficiency and speed
up the deployment process.

- **Chores**
  - Updated build workflow with additional steps for caching operations.

- **Documentation**
- Confirmed no changes to public API documentation are needed as this
update does not alter exported entities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-21 14:57:05 +05:30
Shrikant Sharat Kandula
fa4388da81
ci: Remove unused APPSMITH_IS_SELF_HOSTED 2023-12-21 07:13:42 +05:30
Saroj
e2ec25bc7c
ci: Skip TBD for every push on release branch (#29732)
## Description
- Skipping TBD for every push on release branch
- TBD will run once a day on the scheduled cron
- People can still run TBD on-demand

#### Type of change
- Workflow Change

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated the CI/CD workflow to trigger Docker image builds on pushes to
the "master" branch instead of the "release" branch.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-19 18:49:39 +05:30
sharanya-appsmith
8d5b389f38
ci: added event_name schedule in client-build, rts-build, ci-test-custom-script to run them in scheduled run as well (#29724)
## Description
> added event_name schedule in client-build and rts-build to run them in
scheduled run as well

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
>
>
## Testing
> running TBP workflow to ensure nothing is impacted. 

#### How Has This Been Tested?
- [x] TBP Run


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Updated build workflows to trigger on scheduled events.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-19 16:10:06 +05:30
Saroj
cf53dbfb23
ci: Allow static split of cypress specs (#29653)
## Description
- Allowing static split of cypress specs in CI runs.
- Optimised the spec allocation by considering the duration history for
each spec.
- Updated the affecting workflows to utilise the static split

#### Type of change
- Workflows
- Cypress-split pugin
## Testing
- Workflow run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new environment variable to optimize test resource
allocation during CI/CD processes.
- Enhanced Cypress testing with dynamic and static test splitting
strategies.

- **Refactor**
- Refactored Cypress plugin configuration to support conditional test
splitting based on the environment variable.

- **Chores**
- Updated GitHub Actions workflows to include new environment variables
for test runs.

- **Documentation**
- Updated internal documentation to reflect changes in test setup and
execution strategies.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-18 17:10:11 +05:30
sharanya-appsmith
3495346965
ci: Added cron at 6 am ist on tbp ce workflow (#29643)
## Description
> Added a cron job for the TBP workflow to run at 6 am on weekdays-
Daily Promotion analysis purpose

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
- To check if the workflow is triggered as expected 

#### How Has This Been Tested?
- [x] Manual


## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-12-15 19:04:15 +05:30
Goutham Pratapa
e21583e8fa
skip running TBD for release (#29244) 2023-12-15 15:25:43 +05:30
Saroj
25508563fb
ci: Fix for the junit run-result cache saving issue (#29529)
## Description
Currently, when we run the server build without tests, we still try to
check the cache for run-result, but as the cache is not present during
the first run, where we just build the server, and on the success of the
workflow, actions/cache create the cache with the specified key,

Which is creating an issue while we try to save the actual run-result
cache when we run the tests in server-unit-tests.

Solution : 
- Added a condition to check the cache present only while running tests

#### Type of change
- Workflow changes (server-build.yml)
## Testing
- Workflow run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated the server build process to conditionally skip certain steps
based on user input.

- **Chores**
  - Improved automation in the build workflow to enhance efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-12 14:05:34 +05:30
Saroj
d9698faa25
ci: Allow rerun of only failed tests in Junit (#29469)
## Description
- Added the required logic to rerun only the failed tests in JUnit in
server-build.yml
- Separated the build and test steps to accommodate our requirements

#### Type of change
- Workflow changes (server-build.yml)
## Testing
- [x] [Workflow
run](https://github.com/appsmithorg/appsmith/actions/runs/7164444771?pr=29469)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Documentation**
- Enhanced comments for clarity in test methods related to application
creation, duplication, and cloning.
- Updated comments to reflect changes in test assertions for application
visibility and user anonymity.

- **Tests**
- Modified assertions in `ActionServiceCE_Test` to align with expected
behavior in view mode.
- Added new assertions and comments in `ApplicationServiceCETest` to
improve test coverage and documentation.

- **Chores**
- Improved the server build workflow with better caching and error
handling mechanisms.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-11 18:30:11 +05:30
Arpit Mohan
5c5a99a7dd
ci: Adding a listener for failed Junit tests using TestWatcher (#29451)
Also modifying server-build to store the failed builds as an artifact that can be used later



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Implemented a new step in the build process to upload reports for
failed tests, enhancing visibility into test failures during continuous
integration.

- **Bug Fixes**
- Adjusted test assertions in `AnalyticsServiceCEImplTest` to correctly
reflect the expected behavior.
- Modified the assertion logic in `ApplicationServiceCETest` to ensure
the test aligns with the intended application validation process.

- **Documentation**
  - No user-facing documentation changes in this release.

- **Refactor**
- Introduced `TestResultLoggerExtension` to improve test failure logging
and reporting.

- **Tests**
- Enabled auto-detection of JUnit Jupiter extensions to streamline the
testing framework setup.

- **Chores**
  - No significant chores affecting end-users in this release.

- **Revert**
  - No reverts in this release.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-08 11:55:38 +05:30
sharanya-appsmith
a1fb4ba197
test: Cypress - Added cypress grep library (#29259)
Leveraging the library

[cypress-grep](https://github.com/cypress-io/cypress/tree/develop/npm/grep).
Using this we can tag testcases with relevant tags and use it to run
specific testcases.

**Command to run in local:** 
`CYPRESS_grepTags=@tag.Binding,@tag.Git npx cypress run
`
Pass the tags to CYPRESS_grepTags argument and only the test cases which
has the
tags passed will be picked to run. ex `@tag.Binding and @tag.Git` are
the tag names here.

**Tags can be added in the description on the test case like** 
`{ tags: ["@tag.Datasource"] }` for a single tag
`{ tags: ["@tag.Datasource", "@tag.Git"] }` for multiple tags 

**How to run In CI**
Single Tag - `/ok-to-test tags=@tag.Binding`
Multiple tag - `/ok-to-test tags=@tag.Binding,@tag.Git`


**TODOs in the next release:** 
- [ ] Add tags.ts file with all needed tags
- [ ] Add tags to remaining spec files. 
- [ ] Fail the PR run if tags added are not from tag.ts and post the
message on the same

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update

#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [x] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Added a search functionality to the app.

- **Enhancements**
- Integrated search bar at the top of the `Hero` component and a
`Search` component to the `App` component.
  - Added styles for the search bar.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2023-12-07 18:23:27 +05:30
Saroj
f2261b36f3
ci: Cache the docker image (#29369)
## Description
- Now saving the docker image in cache instead of uploading it as an
artefact to save time

#### Type of change
- Workflow changes
## Testing
- Workflow run

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated CI workflows to use GitHub Actions cache for Docker images
instead of uploading to artifacts.
- Removed `restore-keys` from Yarn dependency caching for a more
streamlined caching process.
- Improved conditions for Docker image caching to enhance CI efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-07 16:59:32 +05:30
Arpit Mohan
e96cbd30cd
ci: Adding fetch-depth 0 to chromatic Github workflow (#29371)
Full git history is required by the chromatic plugin to work properly &
publish the site. Hence adding `fetch-depth: 0` back into the Chromatic
workflow



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflows to fetch the full Git history for
more accurate CI/CD operations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-06 14:07:28 +05:30
Aishwarya-U-R
7f4bbf848c
ci: Run server/client tests parallel to cypress in TestBuildPush (#29320)
## Description
- This PR makes changes to run the Client & Server unit tests in
parallel to Cypress for TBP workflow
- Removes invalid input restore-keys, adding cache-hit
- Remove save cache from /workflows/client-unit-tests.yml
- Making ci-test, client-unit-tests, server-unit-tests mandatory for
ci-test-result

#### Type of change
- Yml file update (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- TBP workflow run

## Checklist:
#### QA activity:
- [ ] Added `Test Plan Approved` label after workflow run & tests were
identified to run parallel to cypress


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Updated GitHub Actions workflows to use the latest version of
`actions/checkout`.
- Improved CI/CD pipeline by adding conditional job definitions for
server and client unit tests.
- Enhanced workflow logic to differentiate between pull request and
branch push triggers for more accurate code checkouts.
- Streamlined caching strategy by removing `restore-keys` configuration
for better dependency management during builds.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-06 13:13:04 +05:30
Shrikant Sharat Kandula
b41cbe86b8
ci: Disable extra logging during tests 2023-12-06 06:00:46 +05:30
Shrikant Sharat Kandula
1965fec54b
ci: Disable pipefail in version calculation for client-build 2023-12-05 20:32:14 +05:30
Shrikant Sharat Kandula
c03bfc1c64
ci: Add xtrace to client-build's version calc step 2023-12-05 20:12:56 +05:30
Shrikant Sharat Kandula
6a2d529d95
ci: Remove RTS' computation of snapshot version (#29333)
RTS is already getting the version from `info.json`.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the build process by removing unnecessary versioning
steps.
- **Refactor**
  - Simplified the Docker image tagging process during builds.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-05 19:46:41 +05:30
Shrikant Sharat Kandula
160871bd31
ci: Fix version calculation in workflows (#29331)
This code is duplicated from generate_info_json.sh script, but that's
temporary. We'll be moving towards not having the version computation in
the workflows at all, and all components getting version information
from `info.json` alone. Essentially treating `info.json` as the source
of truth for this.
2023-12-05 18:50:50 +05:30
Trisha Anand
c1a7afe688
fix: Fixing client-build yaml file for yaml syntax error (#29315)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Add a TL;DR when description is extra long (helps content team)
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Adjusted indentation in the build workflow for improved readability
and consistency.

- **Documentation**
  - No alterations to exported entities' declarations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2023-12-05 15:01:29 +05:30
Arpit Mohan
2650ea161d
ci: Updating actions/checkout to v4 and defaulting to fetch-depth 1 instead of 0 (#29281)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated GitHub Actions workflows to use `actions/checkout@v4` for
improved performance and reliability.
- Removed `fetch-depth` parameter to simplify checkout steps across
various workflows.
  - Standardized quote usage for consistency in workflow files.

- **Documentation**
- Adjusted formatting and descriptions in workflow files for better
clarity and readability.

- **Refactor**
- Aligned multiple workflow files to follow a consistent structure and
naming convention.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

fetch-depth 0 causes the Github workflow to checkout the entire Git
history. This is not required. We only need to check out the head of the
commit. By default, actions/checkout has fetch-depth=1, hence removing
it from the workflow completely for simplicity.
2023-12-05 13:44:43 +05:30
Arpit Mohan
8c132c780f
ci: Cleaning up CI workflows from warnings and unnecessary logs (#29280)
## Summary by CodeRabbit

- **Chores**
- Updated `umani/changed-files` action to v4.1.0 across various workflow
files.
- Updated `peter-evans/create-or-update-comment` action to v3 in
multiple workflow files.
  - Minor adjustments to workflow syntax for consistency and accuracy.

- **Documentation**
  - Corrected URLs in Slack notification messages to ensure accuracy.

- **Refactor**
- Removed redundant job configurations and steps related to caching and
storing run results.
- Streamlined environment variable usage by sourcing values from
secrets.

- **Style**
- Standardized quote usage in workflow files for file matching patterns.

- **Bug Fixes**
- Fixed URLs in echo statements within `test-build-docker-image.yml` to
point to the correct "cypress-dashboard" path segment.
- Updated `slack_color` and `slack_icon` values to better reflect
success and failure states in notifications.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2023-12-03 14:53:15 +05:30
Arpit Mohan
58c62e0bbc
ci: Removing set-output in CI workflows as it's a deprecated command. (#29279)
Using GITHUB_OUTPUT to save environment variables instead. This is to
remove lots of warnings in the CI run and make it easier to read the
summary.
2023-12-03 12:46:56 +05:30
Arpit Mohan
08f625e754
ci: Modifying the CI workflows for ok-to-test to leverage Cypress tags (#28944)
## Description
If the user types `ok-to-test tags=Git`, Cypress should only run the
specs marked with the Git tag

Related to #28943

#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing

#### How Has This Been Tested?
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress

#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-12-01 23:13:15 +05:30
Goutham Pratapa
32b56423e1
revert gh runner to selfhosted runner (#29224) 2023-11-30 10:18:10 +05:30
Shrikant Sharat Kandula
a958a3823f
ci: Revert RTS build to default runner again 2023-11-28 14:12:45 +05:30
Goutham Pratapa
21e1117dba
Move rts build to selfhosted github actions (#29126) 2023-11-27 12:25:30 +05:30
Goutham Pratapa
e5429a8327
Update rts-build-selfhost.yml 2023-11-27 12:16:56 +05:30
Goutham Pratapa
b2af42a293
Update rts-build-selfhost.yml (#29125) 2023-11-27 12:15:17 +05:30
Goutham Pratapa
1317da164e
Update rts-build-selfhost.yml 2023-11-27 12:10:04 +05:30
Goutham Pratapa
8c6a781f64
Update rts-build-selfhost.yml (#29124) 2023-11-27 12:08:33 +05:30
Goutham Pratapa
d1bd880261
Update rts-build-selfhost.yml (#29122) 2023-11-27 11:54:47 +05:30
Goutham Pratapa
9d5f393ea5
Update rts-build-selfhost.yml 2023-11-27 11:52:41 +05:30
Goutham Pratapa
b0b8ef4667
Create rts-build-selfhost.yml (#29120) 2023-11-27 11:48:37 +05:30
Shrikant Sharat Kandula
1920d4c24c
ci: Revert RTS build to use GitHub runner 2023-11-27 09:17:44 +05:30
Shrikant Sharat Kandula
38ffbedb3a
ci: Don't overwrite RTS version, if using info.json 2023-11-26 13:21:11 +05:30
Goutham Pratapa
52a954acea
move rts build from github to self-host runners (#29099) 2023-11-24 16:56:24 +05:30
yatinappsmith
59023009d7
ci: Add retry for JUnit failures in the CI workflow (#29048)
## Checklist:
#### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-11-23 16:44:57 +05:30
Aishwarya-U-R
84314baaf3
ci: Remove all extra slash commands yml (#29016)
## Description
- This PR removes extra slash ymls

#### Type of change
- Yml file update fix (non-breaking change which fixes an issue)

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-11-22 15:29:59 +05:30
Goutham Pratapa
dba56223f1
feat: skip-tests for rts (#29014) 2023-11-21 19:57:50 +05:30
Saroj
41cd80411f
ci: Skip flaky tests on demand (#28984)
## Description
- Skip flaky tests on demand

#### Type of change
- Dime defenders changes to accommodate the flaky spec skip on demand
- Workflow changes to control the skip flaky functionality
2023-11-21 19:08:28 +05:30
Goutham Pratapa
13134975e8
Update rts-build-self-host.yml (#28992) 2023-11-21 12:31:32 +05:30
Goutham Pratapa
5241a24eb9
test: self-hosted github runner (#28976)
Self-hosted runners:


![image](https://github.com/pratapaprasanna/appsmith/assets/15846947/5e10d428-8d4e-4d4a-819d-2b687596e8fd)
2023-11-21 12:21:01 +05:30
Abhijeet
67d7e773b9
chore: Add LaunchDarkly configs in CI run to mock feature flags (#28761)
Note: We have to create `LAUNCHDARKLY_BUSINESS_FLAGS_SERVER_KEY` secret
before merging this PR.
2023-11-16 13:00:56 +05:30
Saroj
8dab2c84e6
test: Cypress - Map chart automation (#28512)
## Description
- Map Chart Automation
#### PR fixes following issue(s)
- Added tests for Map Chart Widget
#### Type of change
- Cypress
## Testing
>
#### How Has This Been Tested?
- [x] Cypress
>
>

## Checklist:
#### QA activity:
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-11-03 16:59:22 +05:30
Aishwarya-U-R
f2f35bca4c
test: Cypress | SetWidget property validations + CI Stabilize (#28456)
## Description
- This PR includes [SetWidget property
validation](https://github.com/appsmithorg/TestSmith/issues/2409) script
- Identified flaky test path updation to point to Cypress dashboard
flaky test list

**Flaky fixes for below:**
- Api URL enter - added some settling time
- ClientSide/BugTests/AbortAction_Spec.ts - with new url
- ClientSide/Binding/Button_Text_WithRecaptcha_spec.js
- Updated from agHelper.SelectDropdownList to
propPane.SelectPropertiesDropDown
- /ClientSide/Widgets/Datepicker/DatePicker3_spec.ts
- /ClientSide/Widgets/ListV2/DataIdentifierProperty_spec.ts - split
- ServerSide/Postgres_DataTypes/Array_Spec.ts
- Radio/Radio2_spec.ts 
- ListV2/DataIdentifier_spec.ts 
- Postgres_DataTypes/UUID_Spec.ts
- Widgets/Multiselect/Multi_Select_Tree_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs


## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-11-03 12:27:24 +05:30
Satish Gandham
f497a4d7f8
ci: Disable perf tests on CI (#28514)
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-10-31 19:36:04 +05:30
Goutham Pratapa
6fc7686fc6
fix: update github-release.yml (#28521) 2023-10-31 16:13:55 +05:30
Goutham Pratapa
597c91da26
fix: failing github-release pipeline (#28515)
Add Build arguements to github-release build and push pipeline
2023-10-31 15:13:34 +05:30
Shrikant Sharat Kandula
9ede02df28
ci: Remove pulling unused cache image 2023-10-19 11:08:21 +05:30
Shrikant Sharat Kandula
62018fff9d
ci: Build base image when Dockerfile changes 2023-10-19 07:15:01 +05:30
Shrikant Sharat Kandula
fe6ea46024
chore: Use Docker base images to build (#28198)
This will use the Appsmith base image which contains all the downloads
needed, so the image build in daily CI should be much more reliable, and
quite likely much faster.

All workflows have already been updated to use the BASE build argument
to set the base image.

Once this is merged, building the Docker image will fail if `BASE` build
argument is not passed. This is that the base is set explicitly
everywhere to not cause any confusion.

The deleted content has been moved to
8d34a2ac28/deploy/docker/base.dockerfile,
which builds the `base-*:*` images.
2023-10-19 06:58:16 +05:30
Shrikant Sharat Kandula
be63e1b404 ci: Add BASE build argument to all workflows 2023-10-18 19:20:55 +05:30
Aishwarya-U-R
f0f8a58140
ci: Removal of env's from Setting Cypress step (#28192)
## Description
- This PR removes the env's from Setting up Cypress step

#### Type of change
- Yml update (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI limited runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-10-18 18:31:35 +05:30
Shrikant Sharat Kandula
988f60e7ff
ci: Add BASE build argument for DP builds 2023-10-18 17:31:30 +05:30
Aishwarya UR
2fbe0574b9 undo typo syntax 2023-10-18 16:12:51 +05:30
Aishwarya UR
94a903b40c undo typo change 2023-10-18 16:12:06 +05:30
Aishwarya UR
23c5a976ea trial env's rmeoval from setting up Cypress step 2023-10-18 16:08:36 +05:30
Shrikant Sharat Kandula
deb55d8b21
ci: Create separate base image so daily CI can cache better and run faster (#28182)
The layers in the Dockerfile that depend on downloading large files from
external sources, doesn't have to run every day, or at every PR. We
tried using Docker's caching configuration, but it's not as reliable as
we'd have liked.

A separate base image lends us much more control over the how long we
cache the downloaded files and how often we redo this.

This PR only _adds_ the base image. It doesn't change anything in the
build of the existing Docker image. That'll happen once we have the base
images for `release` and `master` already present on DockerHub.
2023-10-18 14:17:38 +05:30
Aishwarya-U-R
885c951066
test: Cypress | CI Stabilize (#27818)
## Description
- This PR adds tests for validating the set properties for widget across
all objects
- Covers only some scenarios from [Test
#2409](https://github.com/appsmithorg/TestSmith/issues/2409)
- Adds the failure cypress dashboard link directly in case of CI run
failures
- Flaky fix - Sanity/Datasources/SMTPDatasource_spec.js
- Cypress.on - exception & fail handling updated
- InvokeDispatchOnStore() created for logout/login Internal server
errors - trial fix for RBACFunctionalTests/OthersTabPermission_spec.js
- EditAppFromAppHover() improved to take app name also - trial fix
PropertyPane_Connections_Error_spec.js
- Flaky fix - TableV2_Property_ToggleJs_With_Binding_spec.js
- Flaky fix - Radio2_spec.ts
- Flaky fix - API_TestExecuteWithDynamicBindingInUrl_spec.ts
- Flaky fix - Button_with_API_spec.js
- AssertTableInVirtuosoList() improved to handle the DS name not present
in EE scenario also
- Flaky fix - Button_with_API_spec.js
- Flaky fix - Table_Style_ToggleJS_spec.js
- Flaky fix - Tablev2_Style_ToggleJS_spec


#### Type of change
- Script update (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-10-17 20:26:24 +05:30
Satish Gandham
4ee6d20020
ci: Add perf v2 job to perf test command (#28095)
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-10-16 09:48:30 +05:30
Abhijeet
1cda053bf3
feat: Add signature verification for tenant feature flags (#28053)
## Description
PR to add the signature verification for tenant feature flags. With this
PR we will make sure feature flags those are getting reported from CS
can't be mocked.

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/cloud-services/issues/1394

#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing
#### How Has This Been Tested?
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>


## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-10-14 15:14:17 +05:30
Satish Gandham
538e557160
ci: Run perf tests in parallel (#28050)
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-10-13 16:25:47 +05:30
Saroj
48a3f15ab1
test: Bump cypress version to 13.3.1 (#27987)
## Description
 - Bumped cypress version
 - Updated workflow files to use latest cypress GitHub-action 

#### Type of change
- Workflow files
- Package.json
- yarn.lock
## Testing
>
#### How Has This Been Tested?
- [x] Cypress

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-10-13 10:49:56 +05:30
Saroj
b865ea3a57
test: Map widget automation (#27901)
## Description
- Map widget automation

#### Type of change
- Added spec to verify the map widget with all the possible settings
- Updated the workflows to include map widget spec for hosted runs and
not run for normal runs
## Testing
>
#### How Has This Been Tested?
- [x] Cypress
>
>
## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-10-11 13:04:06 +05:30
Satish Gandham
d8501f82ad
ci: Run perf infra v2 in /perf-test command (#27934)
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-10-11 11:10:43 +05:30
albinAppsmith
65178eaf7e
feat: Added custom hex colors for testing workflow (#27568)
## Description

Added workflow to check if there is any custom colors or hex codes is
being used. This workflow will be checking for the anomalies in the
entire file that has been changed by the developer.

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/27839

#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Saroj <saroj@appsmith.com>
2023-10-10 17:16:17 +05:30
Shrikant Sharat Kandula
517f7a8eba
ci: Fix caching for PR CI runs 2023-10-06 15:48:07 +05:30
akash-codemonk
3dc1241468
chore: get browser logs from failed cypress tests (#27724)
Fixes https://github.com/appsmithorg/appsmith/issues/26006

Get browser console logs for failed tests. This will help with easier
debugging of flaky tests.

Sample artifact for a test
https://github.com/appsmithorg/appsmith/suites/16856147292/artifacts/962768313
Latest test run of the change:
https://github.com/appsmithorg/appsmith/actions/runs/6405413689

Trimming down the files to a max of 10 files, since the artifact size
can go upto a GB when there are a 1000 or more tests failing.

---------

Co-authored-by: Aishwarya-U-R <91450662+Aishwarya-U-R@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-10-05 14:42:30 +05:30
Shrikant Sharat Kandula
5db1516e8d
ci: Remove unused setup-depot step on RTS workflow 2023-10-05 11:52:03 +05:30
Saroj
20c5290c57
ci: Fix ci-test workflows (#27583)
## Description
- Fix ci-test workflows

#### Type of change
- Workflow files
## Testing
- CI run
2023-10-05 10:38:48 +05:30
Aishwarya-U-R
c3d546d434
test: Cypress | App level Import test (non-Gsheet) + CI Stabilize (#27683)
## Description
- This PR includes script for App level import for ds - MySql (non
Gsheet)
- Fixes flaky Replay_Editor_spec.js

#### Type of change
- Script update (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-28 17:45:21 +05:30
Saroj
6f7dd7254b
ci: Fix ci test limit pr comment (#27603)
## Description
- Fix ci test limit pr comment

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-09-26 04:56:27 +00:00
Saroj
50dc649977
ci: Fix failed spec pr comment (#27587)
## Description
- Fix failed spec pr comment

#### Type of change
- Workflow changes
## Testing
- Workflow run
2023-09-25 13:30:11 +05:30
Saroj
9895ee217e
ci: Split spec improvements for cypress ci runs (#26774)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Add a TL;DR when description is extra long (helps content team)
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-09-25 09:49:21 +05:30
Saroj
d6641877ad
test: Fix gsheet tests (#27389)
## Description
-  Fixing the browser issue for gsheet tests

#### Type of change
- Workflow file changes
- plugin/index.js changes
## Testing
>
#### How Has This Been Tested?
- [x] [Cypress
](https://github.com/appsmithorg/appsmith/actions/runs/6248887548)
2023-09-21 10:44:23 +05:30
Aishwarya-U-R
a8c50cfb37
test: Cypess | Oracle DS validations added (Part 5) + CI Stabilize (#27440)
## Description
- This PR adds below:
- Oracle - Delete table data validation
- Deploy App & verify the deleted data
- Bind query to already existing table widget, deploy, Filter table &
verify
- Improved AssertPopoverTooltip - to handle both tooltip elements
- Oracle - Copy, Move query validated [Tc #
2363](https://github.com/appsmithorg/TestSmith/issues/2363)
- Oracle - Query settings page validation covered [Tc #
2365](https://github.com/appsmithorg/TestSmith/issues/2365)
- Oracle - Widgets (Select, DatePicker) to Insert query binding [Tc #
2366](https://github.com/appsmithorg/TestSmith/issues/2366)
- Updated ToggleConfirmBeforeRunning() to run for Api & Queries
- Enabling limited-workflow re-run

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-20 00:56:11 +05:30
Aishwarya-U-R
8c1db6576d
ci: Push workflow notification - Generate slack message fix (#27439)
## Description
- This PR updates the Generate slack message step to display PR title in
Slack notification for better readibility
2023-09-19 14:30:42 +05:30
Aishwarya-U-R
7279f9f09f
test: Cypess | Oracle DS validations added (Part 4) + CI Stabilize (#27348)
## Description
- This PR adds below:
- Oracle - Update query validation
- Deploy App & verify the updated data
- EmbedSettings/EmbedSettings_spec.js - trial fix
- Sanity/Datasources/SMTPDatasource_spec.js - toast message validation
fix
- Apps/CommunityIssues_Spec.ts - flaky fix
- Push workflow slack title update to PR title - trial
- Excluding `7. Verify Airtable documentation opens` for Airgap runs

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed

---------

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2023-09-19 14:17:30 +05:30
Aishwarya UR
9b46e7e127 Slack push sucess icon 2023-09-16 13:02:37 +05:30
Aishwarya-U-R
74f67fbfdf
test: Cypess | Oracle DS validations added (Part 3) + CI Stabilize (#27326)
## Description
- This PR does below:
- Oracle - Create new table, insert data & select. tc #
[2358](https://github.com/appsmithorg/TestSmith/issues/2358) tc #
[2360](https://github.com/appsmithorg/TestSmith/issues/2358)
- Oracle - Alter the new table for 2 new columns, insert multiple rows
into table
- Oracle - Select * from table & select with condition tc #
[2359](https://github.com/appsmithorg/TestSmith/issues/2359)
- Oracle - Add table widget from Suggested widget section, Deploy the
app & verify table data load
- Oracle - Back to Editor, Delete all queries, Delete DS
- Failure fix - ClientSide/Git/GitSync/Connection_spec.js fo CI runs

#### Type of change
- Script fix + update (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-15 14:06:23 +05:30
Shrikant Sharat Kandula
30ed8fa276
ci: Fix syntax error 2023-09-15 12:56:39 +05:30
Aishwarya UR
6f815de9a0 Slack footer & icon update 2023-09-15 08:06:30 +05:30
Aishwarya-U-R
f11a343f29
ci: Cypress Push Slack notification fixes (#27325)
## Description
- This PR updates the slack emojies for Push workflow statuses
2023-09-14 21:52:03 +05:30
Aishwarya-U-R
366662499c
ci: Cypress Push Slack notification fixes (#27311)
## Description
- This PR does below:
- Reverting hosted run slack notif since no new_failed_spec is set (to
set & then fix this)
- Push notif slack msg trial fix

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-14 20:42:49 +05:30
Aishwarya-U-R
6fcf9b48c4
test: Cypess | Oracle DS validations added (Part 2) + CI Stabilize (#27282)
## Description
- This PR adds Oracle validations
- 'Add more' validated from Oracle Ds page
- Tc's automated Tc
[#2204](https://github.com/appsmithorg/TestSmith/issues/2204)
- Added a bit of sleep for keyboard actions (Enter, Escape, Delete)
- Added default param for datasources._host
- Oracle documentation verification added
- get cypress url dashboard url - step commented in ymls, as its no more
used
- Updating Slack message to also display the failing specs in notif
- ElasticSearch spec - update to check hosted run
- ServerSide/GenerateCRUD/MySQL2_Spec.ts - EntityExplore ds name miss
fix
- Update waitForServerRestart() timeout

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-14 16:53:42 +05:30
Abhijeet Mishra
29ad5725c4
feat: add template upload auth env var to server-build (#27252)
## Description
Add environment variable for community template upload for the
server-build workflow
2023-09-14 13:39:13 +05:30
Aishwarya-U-R
7985a551f6
test: Cypess | Oracle DS validations added (Part 1) + CI Stabilize (#27161)
## Description
- Adds validations for Oracle Ds to run in Hosted instance
- Trial fix for EmbedSettings/EmbedSettings_spec.js (checking the
Appsmith is starting page goes away on its own)
- Block_Execution.ts - updated to use Oracle mock data
- Oracle tests [TC
#2354](https://github.com/appsmithorg/TestSmith/issues/2354), [TC
#2355](https://github.com/appsmithorg/TestSmith/issues/2355), [TC
#2356](https://github.com/appsmithorg/TestSmith/issues/2356), [TC
#2357](https://github.com/appsmithorg/TestSmith/issues/2357) Automated
- Set Commit Message update for Hosted runs since now Airtable,
ElasticSearch are also part along with GSheet cases
- SMTP added verification on mail details (from, to, status, msg body
etc)
- Widgets/WidgetPropertySetters_spec.ts - Lint error case flaky fix

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-13 22:33:14 +05:30
Aishwarya-U-R
2cd4555259
ci: Set Commit Message update (#27247)
## Description
- This PR fixes the PR runs where single quotes can be present in PR
desc

---------

Co-authored-by: Saroj <43822041+sarojsarab@users.noreply.github.com>
2023-09-13 13:25:52 +05:30
Aishwarya-U-R
cc00c77685
ci: Cypress Push Slack notification fixes (#27241)
## Description
- Since ci-hosted run has no build failures - that is removed
- For push flow, step id is added for correct status capture
2023-09-13 11:55:31 +05:30
Aishwarya-U-R
d50edbca7d
ci: Cypress Push Slack notification handling build failures (#27234)
## Description
- This PR updates the slack notification link from Cypress dashboard to
Build failures Git actions link incase of any build failure
2023-09-12 21:22:06 +05:30
Ankita Kinger
7bb99aff90
chore: Adding slack notification for promotion TBP workflow failure (#27213) 2023-09-12 19:58:31 +05:30
Aishwarya-U-R
d463b0a7c1
ci: Cypress Push Slack notification update (#27190)
## Description
- This PR updates the slack notification for Push workflows for
debugging flaky tests(internal purpose)
2023-09-12 13:32:25 +05:30
Saroj
5312ee11f3
test: Fix gsheet tests (#27146)
## Description
- Fix gsheet tests
- Fix workflows to not upload the result file in case of success

#### Type of change
- spec file changes
- Workflow file changes

## Testing
>
#### How Has This Been Tested?
- [x] Cypress


## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-09-11 18:37:02 +05:30
Shrikant Sharat Kandula
6a1dc289d1
ci: Remove installs of packages already available (#27123)
We're installing quite a few pieces of software, although they're
already availble in the CI environments. See
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md.

This has led to one failure where it failed to download Helm (because of
a sporadiv 403), where `helm` was already installed and this step wasn't
even needed.

This PR does this:

1. Print the versions of the tools we need.
2. Install MongoSH v6.
3. Install Kubectl pinned to v1.23, since the one that comes by default
is 1.28, which is too new.

References:

[As seen in this
run](https://github.com/appsmithorg/appsmith/actions/runs/6121523768/job/16617184408).
<img width="562" alt="shot-2023-09-09-00-53-35@2x"
src="https://github.com/appsmithorg/appsmith/assets/120119/cfe95a40-28cd-4a13-8071-58438e94ba69">

[MongoDB v6
installation](https://www.mongodb.com/docs/v6.0/tutorial/install-mongodb-on-ubuntu/#install-mongodb-community-edition).
2023-09-11 17:38:20 +05:30
Goutham Pratapa
6250411d1e
update scripts to deploy dps with EFS (#26993)
Fixes: [322](https://github.com/appsmithorg/cloud-deployment/issues/322)
2023-09-11 16:24:17 +05:30
Shrikant Sharat Kandula
c594699eac
chore: Use single COPY command in Dockerfile for constant/static files (#27127)
Move the files that are copied into the Docker image, into an `fs`
folder, that reflects the folder structure of that in the image. This
means two things right away:

1. A single `COPY` instruction in `Dockerfile` is enough to copy all the
files to their places.
2. The structure of files in the repo reflects that in the Docker image.
This makes working with the files/folders and troubleshooting with them
much easier.

 Note: **There's actually only 3 files changed, rest are just moved.**
2023-09-11 08:43:09 +05:30
Aishwarya UR
5a9e36604f fix Set Commit Message 2023-09-09 20:03:58 +05:30
Aishwarya UR
5ee798bf26 fix Set Commit Message 2023-09-09 20:01:23 +05:30
Aishwarya UR
c6c25c609c fix Set Commit Message 2023-09-09 19:58:00 +05:30
Aishwarya-U-R
1d442ed42b
ci: Set Commit Message fix (#27130)
## Description
- This PR fixes the Set Commit Message step for workflow runs
2023-09-09 19:52:04 +05:30
Aishwarya-U-R
e6742014b8
ci: Set Commit Message fix (#27128)
## Description
- This PR fixes the Set Commit Message for workflows runs in CI
2023-09-09 18:55:04 +05:30
Aishwarya-U-R
5e2a4b6afa
test: Cypress | Update ci-test-limit to use Mock Flagsmith (#27120)
## Description
- This PR updates the name of datasource method from 'AssertDSActive' to
'AssertDSInActiveList'
- Updated ci-test-limit.yml to include the flagsmith params
- Updates Postgress staging db name/creds
2023-09-09 00:37:23 +05:30
Aishwarya-U-R
53ceefe9cc
test: Cypress | (DI) SMTP & Airtable validations + CI Stabilize (#26991)
## Description
- This PR fixes the flakyness with error message in
ConnectionErrors_spec
- This PR adds validations for SMTP plugin (added documentation
verification + email sent successfully)
- Updating the Cypress Dashboard for new links
- Improve Widgets/Image/Image2_Spec.ts
- Flaky fix BugTests/Bug26716_Spec.ts
- ShowAllDatasources() added for direct navigation to Action DS list
- Fix ServerSide/GenerateCRUD/Postgres2_Spec.ts
- DeleteDatasouceFromActiveTab() improved
- Airtable - added documentation verification
- Airtable - Added widget binding & deploy App verification of Api
records data
- Datasources/MongoDatasource_spec.js - js to ts definition
- /EmbedSettings/EmbedSettings_spec.js - server restart timeout
increased

#### Type of change
- Script update (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-09-08 14:42:27 +05:30
Saroj
1a81caf568
ci: Fix for ci-test-limited rerun (#27094)
## Description
- Fix for ci-test-limited rerun

#### Type of change
- Workflow changes
## Testing
- Workflow run
2023-09-08 12:45:12 +05:30
Saroj
d1fea6ba47
ci: Cypress rerun improvements (#27072)
## Description
- Cypress parallel run improvements
#### Type of change
- Workflow changes
## Testing
- Workflow run
2023-09-07 17:00:39 +05:30
Saroj
ba9ebf1d6e
ci: Migrate pending workflows to dime defenders (#26968)
## Description
- Updated the logic to use DimeDefenders spec split
- Updated ci-test-hosted, ci-test-limited and ci-test-custom-script
- Changes to handle when there is no spec to run in CI

#### Type of change
- DimeDefender script
- Workflows
## Testing
- Workflow run
2023-09-06 14:40:13 +05:30
Manish Kumar
f24f5d4304
chore: url changes of mocking flagsmith (#26804)
## Description
> TL;DR Complimentary changes utlising
`APPSMITH_CLOUD_SERVICES_SIGNATURE_BASE_URL` when mocking flagsmith on
cloud services

fetching the remote flags from cloud server, the the cacheableHelper
function retrieves base url for cloud services.
when running CI tests this base url is set to ted rather than the cloud
services. In order to get the docker hosted CS url which is provided by
this varialbe: `APPSMITH_CLOUD_SERVICES_SIGNATURE_BASE_URL` , we have to
use another method `getBaseUrlWithSignatureVerification` to get the
docker hosted CS url instead of `getBaseUrl` which gives TED url
#### PR fixes following issue(s)
Fixes #25787 

#### Type of change
- Chore: this may break EE sync

>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-09-04 18:37:28 +05:30
Sumesh Pradhan
ab35feb5bd
Ci/cypress on doc db (#26840) 2023-08-31 18:44:16 +05:30
Sumesh Pradhan
bf33d6c1d2
ci: typo fix cypress on doc db (#26837) 2023-08-31 17:46:02 +05:30
Sumesh Pradhan
a60f4b4f1c
ci: fix cypress on doc db (#26825)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Add a TL;DR when description is extra long (helps content team)
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-31 16:02:12 +05:30
Sumesh Pradhan
75c5d6d8fb
ci: fix cypress on doc db with new cypress db (#26823) 2023-08-31 13:55:08 +05:30
Sumesh Pradhan
a375ccf7b4
ci: cypress on doc name fix (#26819) 2023-08-31 12:06:01 +05:30
Sumesh Pradhan
0e9ce2ad24
ci : cypress on documentDB with self hosted cypressDB (#26817) 2023-08-31 10:53:37 +05:30
Saroj
7b9ed8021e
ci: Fix non-duplicate specs rerun (#26796)
## Description
- Fix single spec rerun
#### PR fixes following issue(s)

#### Type of change
- Workflow change
#### How Has This Been Tested?
- CI runs
2023-08-30 18:21:48 +05:30
Sumesh Pradhan
366e8fb6ad
ci: fixed documentDB snapshot restore (#26761) 2023-08-30 10:47:25 +05:30
yatinappsmith
8d4d369384
ci : Migrate PR workflow to Dime defenders (#26763)
## Description
Migrate PR workflow to Dime defenders
2023-08-30 10:26:26 +05:30
Saroj
d3f68b223f
ci: Fix internal db connection issue (#26731)
## Description
 - Fix internal db connection issue

#### Type of change
- cypress_hooks.js 
- Workflow changes
## Testing
- CI run
2023-08-29 16:45:49 +05:30
Sumesh Pradhan
adedf0c159
ci: cypress on documentDB init db from backup archive (#26710)
Restoring db of each run from a mongo archive with initial migrations
already applied to speed up the tests.
2023-08-28 18:06:07 +05:30
Aishwarya UR
968eb9950b ci-test-limit fix 2023-08-28 17:50:10 +05:30
Saroj
2ec612c7aa
ci: Update ci-custom-script to unblock push workflows (#26699)
## Description
- Update ci-custom-script to unblock push workflows

#### Type of change
- Workflow changes
#### How Has This Been Tested?
- Workflow run
2023-08-28 17:12:32 +05:30
Saroj
cc3301bae2
ci: Debug ci failure (#26698)
## Description
- Debug ci failure (Changes to not run internal dashboard script)

#### Type of change
- Workflow changes
## Testing
Workflow run
2023-08-28 15:37:15 +05:30
Sumesh Pradhan
207681bd18
ci: cypress on doc db (#26660) 2023-08-25 17:27:17 +05:30
Sumesh Pradhan
1f5223c01d
ci: docDB int test wait for appsmith health before cypress (#26655) 2023-08-25 15:27:48 +05:30
Saroj
193f4849a7
ci: Add env variables to ci test limit and hosted workflow to use internal cypress db (#26656)
## Description
- Add env variables to ci test limit and hosted workflow to use internal
cypress db
#### PR fixes following issue(s)

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
 - CI Run
2023-08-25 15:06:19 +05:30
Saroj
301852dcd7
test: Fix cypress local run (#26652)
## Description
 - Fix cypress local run
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-25 15:06:05 +05:30
Sumesh Pradhan
97d3c03b7e
Ci/cypress on doc db fix (#26645) 2023-08-25 12:15:15 +05:30
Saroj
edbbefd979
chore: Changes to enable internal cypress dashboard (#26626)
> Pull Request Template
>
> Use this template to quickly create a well written pull request.
Delete all quotes before creating the pull request.
>
## Description
> Add a TL;DR when description is extra long (helps content team)
>
> Please include a summary of the changes and which issue has been
fixed. Please also include relevant motivation
> and context. List any dependencies that are required for this change
>
> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-25 10:21:12 +05:30
Sumesh Pradhan
8640c27d37
ci: cypress on doc db fix (#26637) 2023-08-25 10:15:05 +05:30
Sumesh Pradhan
5f79a6e638
ci: cypress and perf tests on documentDB (#26616)
Runs cypress and perf tests on an Appsmith instance with an existing
DocumentDB backend instead of MongoDB.

Comment to trigger the run on a PR:
`/ok-to-test-with-documentdb`
2023-08-24 18:07:33 +05:30
Shrikant Sharat Kandula
56c6aa0f1d
ci: Include info.json for all workflows (#26429) 2023-08-22 10:34:23 +05:30
Saroj
132a0c2e25
ci: Update ce push workflow to use dime defenders (#26527)
## Description
- Update ce push workflow to use dime defenders
#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- [ ] Workflow run
>
>
2023-08-21 17:23:20 +05:30
Valera Melnikov
826d58f813
chore:update node version to v18 (#26358)
## Description
Update node version

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-15 18:56:04 +05:30
codesee-maps[bot]
c108a31a38
chore: Install the CodeSee workflow. (#26315)
This pull request adds the CodeSee workflow to your repository.
This workflow runs a code analysis on each time:

  - a new PR is opened
  - a new commit is pushed to an existing PR
- a PR is merged or a new commit is pushed directly to the default
branch

The analysis enables [code
visibility](https://www.codesee.io/what-is-code-visibility) for your
codebase: generating maps of your codebase, keeping existing maps
up-to-date, and automating code workflows.

Access the CodeSee web app at https://app.codesee.io/ or learn more at
https://docs.codesee.io. If you have any questions, please reach out to
support@codesee.io and we'll be happy to help.

Co-authored-by: codesee-maps[bot] <86324825+codesee-maps[bot]@users.noreply.github.com>
2023-08-14 12:43:25 +05:30
Sumesh Pradhan
d15bb78d13
ci: workflow run id context var fix (#26244)
Updated github context variable for the workflow id.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-08-11 10:39:28 +05:30
Sumesh Pradhan
87b8aa58ce
ci: Secret typo (#26192)
Typo fixed for secret token key.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-08-09 10:49:15 +05:30
Shrikant Sharat Kandula
75eea5b87d
ci: Make info json script optional 2023-08-07 14:23:50 +05:30
Sumesh Pradhan
be9c935732
ci: Deploy preview from branch (#25846)
Updated ad-hoc dp workflow to update the db with progress.
- This workflow should only be called via internal ops api.
- This workflow uses the internal ops api to patch data with the updates
on the workflow statuses.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-08-07 10:59:42 +05:30
Valera Melnikov
65a662ee48
chore: clean up switch stories (#26057)
## Description
Clean up switch stories

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-04 21:56:45 +03:00
Goutham Pratapa
c6d9357f88
chore: add deployment dp params (#26002) 2023-08-04 10:40:25 +05:30
Goutham Pratapa
bc24d03dbd
Revert "update: migrate dp from sts to deployments (#25615)" (#25996)
This reverts commit 6762d2ce90.
2023-08-03 23:40:06 +05:30
Pawan Kumar
57cf92e68d
chore: Split Chromatic and Storybook stories (#25877)
Fixes #25427
2023-08-03 21:00:17 +03:00
Goutham Pratapa
6762d2ce90
update: migrate dp from sts to deployments (#25615) 2023-08-03 19:02:17 +05:30
Saroj
495b35358f
ci: Fix slack notification for ci-test-hosted (#25960)
## Description
- Fix slack notification for ci-test-hosted
#### Type of change
- Workflow changes
## Testing
- Workflow run
2023-08-03 10:59:06 +05:30
Saroj
f89e5b8612
test: Cypress - fix for selected gsheet (#25940)
## Description
- Fix for selected gsheet failure
- Added steps in ci-test-hosted to notify on slack
- Updated config to run the Airtable_basic_spec on the hosted instance
and skip it in regular runs

#### Type of change
- Cypress changes
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- [x] Cypress

## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-02 18:58:04 +05:30
Shrikant Sharat Kandula
e8c3cc19a2
chore: Add info.json to Docker images (#25948)
This adds a `/opt/appsmith/info.json` file to Docker images, with the
following sample content:

```json
{
  "commitSha": "0521ba2c0d7a62cef3d4def66fc15b59cc34ceef",
  "commitUrl": "0521ba2c0d",
  "branch": "release",
  "date": "2023-08-02T12:52:53+00:00",
  "isCI": false
}
```

We're enabling this only for images built for DPs currently, and will
then extend to other workflows as well.

Notice that we copy `info.*json` instead of `info.json`. The reason is
so that the Docker build doesn't fail, even if the `info.json` file
doesn't exist. This lets us publish this to each workflow in turn,
slowly and carefully.

[Relevant Slack
conversation](https://theappsmith.slack.com/archives/C02MUD8DNUR/p1686197957141419).
2023-08-02 18:36:59 +05:30
Shrikant Sharat Kandula
e0962f3a1c
ci: Use vars.EDITION instead of hard-coded edition to avoid conflicts with EE sync (#25870)
Note: Please review/approve only, do not merge. This PR is expected to
cause conflicts and so I'd like to be around when this is merged.
2023-08-02 14:35:08 +05:30
Aman Agarwal
2603107afa
fix: remove shared-modules workflow file (#25932) 2023-08-02 12:47:45 +05:30
Saroj
fe88895020
ci: Fix cypress dashboard url for rerun (#25933)
## Description
- Fix cypress dashboard url for rerun for Git messages that comes in PR
runs

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- workflow run
2023-08-02 12:45:13 +05:30
Shrikant Sharat Kandula
24a12d55d3
ci: Update docker/build-push-action to v4 (#25906)
The currently used `v1` is deprecated, and not recommended anymore. The
`v4` changes a few things. Some details are in the following pages:

1. https://github.com/docker/build-push-action/blob/v2/UPGRADE.md
2.
4fad532b9f/README.md (customizing)

Essentially, in the current code, `build-args` isn't working. This
should fix that.
2023-08-02 10:43:37 +05:30
Saroj
1b534cdd79
test: Additional regression scenarios for gsheet (#25844)
## Description
- Added following  regression scenarios for gsheet
   1. Create query from active ds tab
   2. Create query from ds details page
   3. Generate CRUD page from active ds
   4. Generate CRUD page from entity explorer
   5. Added test to add query from global search

#### Type of change
- Cypress
## Testing
>
#### How Has This Been Tested?
- [ ] Cypress
## Checklist:
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-01 16:42:44 +05:30
Goutham Pratapa
c2b6b92e73
ci: vercel dp comments (#25898) 2023-08-01 15:46:36 +05:30
Aishwarya-U-R
af415f4f30
test: Cypress | Automated tests for MySQL + Flaky fixes (#25867)
## Description
- This PR fixes the below flaky fixes
- GitSyncedApps_spec.js
- Improves coverage for MySQl - adding suggested widget binding
- TableV2/Date_column_editing_1_spec.ts fix
- WaitUntilEleAppear improved
- DeployApp() updated
- QueryPane/Mongo_Spec.js - adding wait time
- AssertIfPropertyIsNotVisible() replaced
- fat-migration.yml deleted
- cypress-real-events - update
- /Filepicker/FilePicker2_spec.js
- /Autocomplete/Autocomplete_setters_spec.ts

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-08-01 15:04:15 +05:30
Shrikant Sharat Kandula
818d997d5d
ci: Default to release CS unless building for prod (#25856)
When running Appsmith release image, it's currently using production CS,
which is causing a lot of incompatibility related errors since `release`
moves much faster than prod.

This changes this. Note that for `:latest` and `:nightly` images, we do
NOT change this default. There's no change for Docker images with those
tags. We _only_ want change `:release` image, DP images, and images
built for Cypress runs.
2023-08-01 07:35:01 +05:30
Valera Melnikov
e5209aa7cd
fix: bump storybook version and move stories to storybook package (#25821)
## Description
- bump storybook version
- move stories to storybook package
- add dimensions for testing viewports
- improve some stories and types for argTable

#### PR fixes following issue(s)
Fixes #25534

#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-31 19:15:50 +03:00
Goutham Pratapa
3f8db42522
fix: failing-vercel-dps (#25851)
Fixes:
https://github.com/appsmithorg/appsmith/actions/runs/5713787930/job/15479827656#step:9:30

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-07-31 20:51:35 +05:30
Saroj
e88eb26bdd
ci: Fix for comments in case ci-test failure due to other steps (#25850)
## Description
- Fix for comments in case ci-test failure due to other steps
- Fixed the ci-test-result issue in ci-test-limited
#### Type of change
- Workflow file
## Testing
- Workflow run
2023-07-31 17:56:55 +05:30
Sumesh Pradhan
18b26a4ec5
ci: Ad-hoc DP | Build Push Deploy from branch (#25357)
Workflow and script to build from branch and deploy to uat-cluster.

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-07-31 13:27:47 +05:30
Shrikant Sharat Kandula
0d69fb5472
ci: Use cache from release image to build faster (#25829)
This should enable using unchanged layers from the `release` image, as a
cache, and build PR images faster. We only do this for images built for
PRs and not for direct `release` or `master` branches.
2023-07-31 10:30:46 +05:30
Shrikant Sharat Kandula
5a9abe0075
ci: Add a note about Vercel DPs with env=release (#25211)
Non-impacting change, only adds some more content to the DP URL comment.

More context around this at
https://notion.so/031b87bce3404e3a95240d4c14c82e46.
2023-07-31 10:19:20 +05:30
Abhijeet
2f36589171
chore: Update CI test to add CS release image instead of mocking CS response (#25400)
https://theappsmith.slack.com/archives/C0134BAVDB4/p1687775438002889

EE PR: https://github.com/appsmithorg/appsmith-ee/pull/1908
2023-07-27 18:03:10 +05:30
Saroj
18bc8a33ad
ci: Fix for ci-test-limit comment issue on test failure (#25782)
## Description
- Fix for ci-test-limit comment issue on test failure
#### PR fixes following issue(s)

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-07-27 16:08:16 +05:30
Saroj
2cb8959bcf
ci: Fix workflow commit message for scheduled hosted workflow (#25772)
## Description
-  Fix workflow commit message for scheduled hosted workflow
#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-07-27 12:59:02 +05:30
Saroj
985436a853
ci: Workflow fix for scheduled run for gsheet tests (#25770)
## Description
- Workflow fix for scheduled run for gsheet tests

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-07-27 12:14:03 +05:30
Saroj
d27078b54e
test: Gsheet Automation (#25255)
## Description
- Automated below queries for gsheet

1. Fetch Details
2. Insert one
3. Insert many
4. Update one
5. Update many
6. Fetch many
7. Delete One

- Added workflow to schedule run for gsheet automated tests on the
hosted instance
- Added a new cypress config file which will be used to run the gsheet
tests
- Added tests for folowing permission/scope options `All access`,
`selected access`, `Read/write | All google sheets` and `Read | All
google sheets`
- Added negative scenarios
- Added tests to verify widget binding for both suggested widget and
drag n drop widget for both selected and all access permission/scope
#### Type of change
- Cypress
## Testing
>
#### How Has This Been Tested?
- [x] Cypress
>
>
## Checklist:

#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-26 18:56:24 +05:30
Nidhi
bc5168db2b
ci: Modified cypress check (#25698) 2023-07-25 19:01:52 +05:30
Nidhi
a3efa3cffd
ci: Moved QC around, removed unit tests running with ok to test (#25667) 2023-07-25 14:56:58 +05:30
Saroj
370748a2e5
ci: Fix to use cypress dashboard for ci test (#25618)
## Description
- Fix to use cypress dashboard for ci test

#### Type of change
- Workflow file changes
## Testing
>
#### How Has This Been Tested?
- workflow run
2023-07-24 10:56:01 +05:30
Shrikant Sharat Kandula
29eb9ab2f2
chore: Stop building slim images (#25219)
Fix #23481.
2023-07-22 15:58:52 +05:30
Saroj
53e3890066
ci: Fix for artifact name to download (#25599)
## Description
- Fix for artifact name to download
#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-07-21 18:19:28 +05:30
Saroj
83f0f8fd96
ci: Upload results for every attempt separately (#25596)
## Description
- Upload results for every attempt separately
#### Type of change
- Workflow changes
#### How Has This Been Tested?
- Workflow run
2023-07-21 18:05:54 +05:30
Saroj
cf7883e398
ci: Fix comment issue in PR for failed specs (#25584)
## Description
- Fix comment issue in PR for failed specs

#### Type of change
- Workflow file changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-07-21 16:37:14 +05:30
Nidhi
a0aeb320f1
ci: Added common CI check for server and client formatting (#25515)
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-07-21 08:55:36 +05:30
Saroj
557fbff4cb
ci: Fix the failed spec artefact name (#25524)
## Description
- Fix the failed spec artefact name

#### Type of change
- Workflow changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-07-20 15:49:35 +05:30
Satish Gandham
ab60be793d
ci: Disable perf-tests-v2 (#25317)
Disable perf-tests-v2.

Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-07-19 17:56:37 +05:30
Saroj
07dc6ee9ad
ci: Changes to enable rerun with custom script (#25480)
## Description
- Changes to enable rerun with custom script
#### Type of change
- Workflow file changes
## Testing
>
#### How Has This Been Tested?
 - Workflow run
## Checklist:
#### Dev activity
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-19 17:02:24 +05:30
Saroj
f064d01f84
ci: Remove cypress env values for custom script run (#25475)
## Description
- Remove cypress env values for custom script run
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-19 13:28:22 +05:30
Saroj
81a114642f
ci: Split specs and run Cypress without Cypress Dashboard (#25347)
- Hackathon
2023-07-19 12:12:36 +05:30
Rajat Agrawal
058c0261e2
chore: Fix changeset workflow to run on external contributor PR (#25227)
Fixes #25260
2023-07-12 10:40:19 +05:30
Aishwarya-U-R
7846907416
test: Cypress | Flaky fix (#25179)
## Description
- This PR fixes the below flaky tests
     - BugTests/AllWidgets_Reset_Spec.ts
     - BugTests/InputTruncateCheck_Spec.ts
- BugTests/CatchBlock_Spec.ts (external api replace with TED
v1/mock-http-codes/404 api)
     - Datasources/Airtable_Basic_Spec.ts
     - Onboarding/FirstTimeUserOnboarding_spec.js
     - Autocomplete/JS_AC_spec.ts - split!
     - GenerateCRUD specs - added assertion
     - ci-test-limit - comit message update for workflow & comment run

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-07 23:28:16 +05:30
Saroj
188976376a
ci: Fix to skip the commented lines from limited-tests.txt (#25197)
## Description
- Fix to skip the commented lines from limited-tests.txt

#### Type of change
- Workflow file chnage
## Testing
>
#### How Has This Been Tested?
- Manual workflow run
2023-07-07 14:57:29 +05:30
Saroj
c8fb7e685d
ci: Fix the result job name fir limited test workflow (#25192)
## Description
- Fix the result job name fir limited test workflow
-  It has below improvements

  -- it will skip lines starting with # or // in limited-test.txt
-- Dynamically assign the matrix count, run through command it will take
5 runners and manual workflw run will take 60 runners
  -- Cypress dashboard heading
  -- Some other small improvements

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-07 14:13:40 +05:30
Saroj
50240fc74b
ci: Add command to run ci-test-limited (#25180)
## Description
- Add command to run ci-test-limited
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-07 12:26:55 +05:30
Saroj
026daccc46
ci: add ts check in ci-test-limited (#25137)
## Description
- Added ts file check in limited workflow

#### Type of change
- Workflow file
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-07-05 22:11:02 +05:30
Pawan Kumar
3821eb405c
chore: Update chromatic Worfklow (#24976)
On WDS PR's merge, we need to create a build for the release branch too
so that chromatic baselines is updated.
This PR updates the workflow to start a build on merge too.
Also, we can now remove build-storybook workflow as that is not needed
anymore since we will be building chroamtic on release also. We can use
`https://release--5f1e6db0ad879d0022744996.chromatic.com` to see the
storybook for release branch.
2023-07-03 10:26:09 +03:00
Aishwarya-U-R
21a76752a5
ci: Cypress-only-fixes label workflow remove (#24985)
## Description
- This PR removed the Add Cypress-Only-Fixes Label on PR Merge workflow
to run from PR merge until fixed
2023-07-01 01:00:23 +05:30
Aishwarya-U-R
6182de6d2b
ci: Cypress-only-fixes label workflow fix-V (#24984)
## Description
- This PR fixes the Add Cypress-Only-Fixes Label on PR Merge workflow
2023-07-01 00:57:14 +05:30
Aishwarya-U-R
70b3f62ae7
ci: Cypress-only-fixes label workflow fix-IV (#24983)
## Description
- This PR fixes the Add Cypress-Only-Fixes Label on PR Merge workflow
2023-07-01 00:50:22 +05:30
Aishwarya-U-R
7b840f0c86
ci: Cypress-only-fixes label workflow fix-III (#24982)
## Description
- This PR fixes the Add Cypress-Only-Fixes Label on PR Merge workflow
2023-07-01 00:38:22 +05:30
Aishwarya-U-R
8e6eaf826c
ci: Cypress-only-fixes label workflow fix-II (#24981)
## Description
- This PR fixes the Add Cypress-Only-Fixes Label on PR Merge workflow
2023-07-01 00:31:23 +05:30
Aishwarya-U-R
106410d7ea
ci: Cypress-only-fixes label workflow fix (#24980)
## Description
- This PR fixes the Add Cypress-Only-Fixes Label on PR Merge workflow
2023-07-01 00:24:59 +05:30
Aishwarya-U-R
63eae07346
test: Cypress | Flaky fixes (#24925)
## Description
This PR upgrades Cypress from 12.14 to Cy 12.16 along with below flaky
fixes:
- This PR fixes the below flakyness in Cypress suite:
- ConversionAlgorithm_AutoLayout_Valid.js
- ButtonGroup_MenuButton_Width_spec.js
- columntypes/select_spec - method update
- Date_column_editing_1_spec.js
- Omnibar_spec.js - 6th case
- TableV2_Widget_API_Pagination_spec.js
- TableV2_Widget_API_Derived_Column_spec.js
- TableV2TextPagination_spec.js
- Table_Widget_API_Pagination_spec.js
- TableTextPagination_spec.js
- Table_Derived_Column_Data_validation_spec.js
- LoginTests/LoginFailure_spec.js
- cy.visit - timeouts handled
- CreateQueryAfterDSSaved for Mock DB's
- TableV2Filter1_2_Spec
- InputTruncateCheck_Spec
- DSDocs_Spec - for assertNewtab open
- TableV2_DisplayText_spec
- MultiSelect3_spec
- PropertyPaneSuggestion_spec
- Others/Video_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes tests were reviewed
2023-07-01 00:16:57 +05:30
Saroj
9edd00050d
ci: Fix cypress dashboard link in pr comment (#24904)
## Description
- Fix cypress dashboard link in pr comment

#### Type of change
- Workflow file changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-06-28 15:56:32 +05:30
Saroj
a781a6d150
ci: Fix extracting the cypress dashboard url in ci-test-result (#24890)
## Description
- Fix extracting the cypress dashboard url in ci-test-result 
#### Type of change
- Workflow file changes
## Testing
>
#### How Has This Been Tested?
- Workflow file changes
2023-06-28 11:19:19 +05:30
Saroj
45ae5a2995
ci: Get the newly added files from the PR branch for ts check (#24825)
## Description
- Get the newly added files from the PR branch instead of commits for ts
check
- CI improvements, now added cypress dashboard link with the comments in
PR
- CI improvements removed the steps which saves un-necessary cache

#### Type of change
- Workflow file changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-06-27 22:25:44 +05:30
Pawan Kumar
91c17ffbd4
chore: add chromatic workflow (#24749)
This PR adds the integration for chromatic which will help us catch
visual bugs in the WDS components.
The way it works is, the PR won't allowed to merge till reviewers
reviews all the changes in the components.
One thing to note is the workflow only works when there is a change in
design system files.

Fixes #21923
2023-06-27 10:05:41 +03:00
Saroj
23c8d0385b
ci: commenting out file check steps in client-build.yml (#24762)
## Description
- Commented out the file check steps in client-build to unblock other
pr's and rework
#### Type of change
- Workflow file changes
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-06-22 22:06:04 +05:30
Saroj
e43f540770
ci: Skipping the ts file checks if not required (#24761)
## Description
- Skipping the ts check for test files if not required, introduced a
input variable for the client build to control this
#### Type of change
- Workflow file
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-06-22 21:33:58 +05:30