Commit Graph

8685 Commits

Author SHA1 Message Date
Aman Agarwal
4a381607eb
fix: google sheet ui issues, removed redundant code (#18785)
Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2022-12-20 20:40:18 +05:30
f0c1s
ff9db224f8
Revert "chore: remove telemetry option" (#19067)
Revert "chore: remove telemetry option (#19052)"

This reverts commit 059fcd5c58.
2022-12-20 15:19:09 +05:30
Ankita Kinger
980f6f5827
chore: Addressing changes requested by the design team during design QA (#19041)
* addressing design QA change requested

* updating the props
2022-12-20 12:19:57 +05:30
f0c1s
059fcd5c58
chore: remove telemetry option (#19052) 2022-12-20 11:52:36 +05:30
NandanAnantharamu
99ba866761
test: added test for modal widget (#18729) 2022-12-20 11:44:33 +05:30
Ayush Pahwa
8d09ab297b
chore: CE EE split of routes for manage env pages (#18449)
update: routes for CE EE split env editing
2022-12-19 19:10:49 +07:00
yatinappsmith
876cd428f9
ci: Comment failing tests to PR (#18450)
## Description

Comment failing tests to PR

Fixes # 



## Type of change

- New feature (non-breaking change which adds functionality)


## How Has This Been Tested?
Code review. Tested in local fork

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [X] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [X] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-19 16:23:39 +05:30
Aswath K
f9e17f670f
fix: All property control renders when JS toggle button is clicked (#18905)
Fix the performance issue that happens when we click the JS toggle button in property pane.
2022-12-19 15:45:50 +05:30
Shrikant Sharat Kandula
467a1f65eb
chore: Fix inconsistency in behaviour when re-marking public (#19031)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-12-19 15:29:58 +05:30
f0c1s
0f56f054e0
chore: restrict when /usage-pulse can be fired (#19029) 2022-12-19 14:39:27 +05:30
rahulramesha
6636e8ae82
fix: Remove auto-height from list widget's children (#18755)
* remove auto height from list widget's children

* avoid large diffs

* disable auto height in list widget, review commit

* fix children object for list widget during migration

* reposition comment

* fix blueprint message when multiple widgets are added

* remove comment

* List widget test for Dynamic height updated

* fix propertyPane config

* fix property pane search for hidden dynamic height values

Co-authored-by: Apple <nandan@thinkify.io>
2022-12-18 01:33:35 +05:30
Trisha Anand
760738a430
chore: [GAC] Using correct permissions to fetch the application object using view mode (#19007) 2022-12-17 16:48:31 +05:30
akash-codemonk
bedcd7cade
fix: set soft focus for property pane inputs (#19009) 2022-12-16 22:52:47 +05:30
Sumit Kumar
803043c12e
feat: add endpoints for custom JS library add / remove / get (#18904) 2022-12-16 18:00:50 +05:30
Ankita Kinger
424e3b24e4
fix: updating the redirection of admin settings to fix failing tests (#18971) 2022-12-16 17:14:44 +05:30
Rishabh Rathod
c4c873953b
chore: Remove evalError & values from dataTree (#18649)
## Description

Appsmith internally maintains the data of all the entities as a collection called dataTree. This data tree stores evaluated values and errors ( evaluated props ) in entity object with key `__evaluation__`. 

In this PR, we move the evaluated props out of the dataTree for worker code to make `deepCloning` and dataTree sanitization i.e., `JSON.parse(JSON.stringify(dataTree))` faster. 

TL;DR

Trimming dataTree object size by evaluatedProps to make evaluation faster.

Fixes #14710 

## Type of change

Performance change


## How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
> Please also list any relevant details for your test configuration.
> Delete anything that is not important

- Manual
- [ ] https://github.com/appsmithorg/TestSmith/issues/2124

- Jest
- Cypress

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [x] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-16 14:17:54 +05:30
Anagh Hegde
82489a3ecd
fix: Add error message for protected branch (#18737)
* Add error message for protected branch

* Added Junit Test cases

* Add error message for protected branch

* Added Junit Test cases

* chore: push failed warning

* Add reset command

* Fix test failures

Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-12-16 12:07:40 +05:30
Dhruvik Neharia
f2709d6de7
fix: Button Group Menu Item Label Misaligned (#18951)
## Description

This PR fixes a minor bug that caused the label of new menu items inside the button group widget to be misaligned.

Fixes #18867

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?
- Manual

### Test Plan
> Add Testsmith test cases links that relate to this PR

### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)


## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-16 12:06:55 +05:30
Parthvi
a30fbf2c77
test: add common test methods for RBAC (#18968) 2022-12-16 10:45:25 +05:30
balajisoundar
f49db2a90e
feat: Provide currentRow access in the table widget select column typ… (#18180) 2022-12-16 10:05:51 +05:30
Trisha Anand
27b579fa68
chore: Refactor sign up flow to support create workspace to be permission driven (#18981) 2022-12-15 23:47:36 +05:30
Trisha Anand
69bc3c06dc
fix: [GAC] editing js objects should use read permission for creating actions (#18977)
* chore: For Js action, only using read permission while creation. For non Js actions, using create page permission to fetch the page

* fixing ci test case failure
2022-12-15 23:45:02 +05:30
akash-codemonk
17dbe63ed3
feat: [Context Switching] maintain focus of code editor fields (#18240) 2022-12-15 19:45:46 +05:30
Aswath K
c72f865962
chore: Property pane search input focus (#18858) 2022-12-15 16:25:52 +05:30
Ankita Kinger
a83bfc8acd
chore: Updating the version of the design system dependency (#18965)
updating the version of design system dependency
2022-12-15 15:34:21 +05:30
Pawan Kumar
86f86f0298
chore: Update Logo/Favicon url + remove EE cypress code for Branding + Update screenshots tests (#18872)
* add new screenshot of apppagelayout + update logo url + remove ee code in spec

* fix error message for logo

* revert profile snap

* remove brand colors in ce

* fix auth page layout issue

* revert some snap images

* fix visual tests

* fix cypress tests

* fix cypress tests
2022-12-15 14:59:26 +05:30
Manish Kumar
2445a3c625
chore: method signature changed for getCachedDatasourceForActtionExecution (#18950)
## Description

> To accommodate for datasource context adaption for environments, Some datasourceService methods needs to be aware of `environment name` in order to evaluate the `datasource configuration` for the given environment
> TL; DR : This Pr changes method signature for fetching  datasource by actionId

Fixes #18760  
Ref #18762 

## Type of change
 > Chore

## How Has This Been Tested?
- Manual
- Jest



## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
2022-12-15 14:47:03 +05:30
Anagh Hegde
051444f221
fix: App deleted when the user creates branch in few scenarios (#18964)
## Description

> Continuing from the PR - https://github.com/appsmithorg/appsmith/pull/18034. The app getting deleted bug was introduced when creating branch was introduced in the linked PR. 
Current PR adds a check to ensure that none of the git flow is affected. 

Fixes - https://app.frontapp.com/inboxes/teams/folders/15585868/unassigned/66043703436

## Type of change

- Bug fix (non-breaking change which fixes an issue)


## How Has This Been Tested?

- Manual

## Checklist:
### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or manual QA
- [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2022-12-15 14:44:16 +05:30
Favour Ohanekwu
8ed9d20547
feat: reset meta widgets (#18809)
* Initial commit

* reset meta widgets

* Annotate code

* Rehydrate meta values for meta widgets when dirty

* Undo rehydration logic
2022-12-15 09:23:09 +01:00
Arsalan Yaldram
a2c878e8c7
chore: updated supertest package. (#18909)
* chore: updated supertest package.

* chore: dependencies list upgraded.
2022-12-15 12:18:27 +05:30
Ankita Kinger
e618c73205
chore: Adding adminSettingsVisible variable in User type (#18961)
adding adminSettingsVisible variable in User type
2022-12-15 11:42:46 +05:30
sidhantgoel
f2d7f54c29
chore: Splitted import export service code for V2 (#18927) 2022-12-15 11:23:25 +05:30
Sumit Kumar
8bc1c77a96
fix: replace Appsmith's mock server endpoint with MockWebServer (#18943) 2022-12-15 05:17:43 +01:00
Hetu Nandu
6112e79bac
chore: Navigation analytics (#18781) 2022-12-15 09:36:13 +05:30
ankurrsinghal
b62a96868e
fix: modal widget close on new widget drop (#18953) 2022-12-15 08:02:03 +05:30
Sangeeth Sivan
c8d396fa32
fix: update delete workspace permission and condition case (#18930)
handles delete option edgecase: when user has the delete permission but workspace has applications, user should not be able to delete the workspace.

This commit hides the option.
2022-12-14 23:38:58 +05:30
dependabot[bot]
91f81484b4
chore: bump tinymce from 5.10.2 to 5.10.7 in /app/client (#18792) 2022-12-14 21:16:13 +05:30
Ankita Kinger
faffba78a6
fix: Updating page permissions in view mode to solve error message for updating the page (#18946) 2022-12-14 20:32:13 +05:30
Trisha Anand
94e21d58df
chore: Adding variable to track admin settings visibility in user profile (#18956) 2022-12-14 18:28:20 +05:30
Ankita Kinger
9537c282ac
chore: Updating UI for the left panel on Admin settings page by adding separators (#18895) 2022-12-14 17:37:55 +05:30
akash-codemonk
11dba7b4f8
chore: use updated table widget in onboarding (#18705) 2022-12-14 16:02:34 +05:30
Manish Kumar
654f94a94c
chore: decomposing action execution flow methods into smaller methods (#18762) 2022-12-14 15:43:14 +05:30
Rishabh Kashyap
4877acf1eb
fix: show more modal of a truncated text widget is flickering (#18888)
class for updated z-index added
2022-12-14 13:43:43 +05:30
Trisha Anand
122b5388ac
chore: use read permission to fetch pages in edit mode (#18944) 2022-12-14 13:02:17 +05:30
Aman Agarwal
cb1b0b5aa3
fix: removed old key_val_input, updated keyval_array, show ds info (#18626)
fix: removed old key_val_input, updated keyval_array, show ds info
2022-12-13 20:09:16 +05:30
Ayangade Adeoluwa
2cc64183c8
fix: Error handling for undefined datasource in API Authentication (#18881) 2022-12-13 17:16:56 +05:30
Ankit Srivastava
9f84298dcf
fix: Login password length upper limit changed from 48 to 256 characters (#18176)
* fix - login password length upper limit removed

* removed unused variables

* password max limit of 256 characters

Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-12-13 16:40:47 +05:30
Rishabh Kashyap
26c01b35e9
feat: add tooltip property to select widgets (#18480) 2022-12-13 16:05:08 +05:30
Ankit Srivastava
236214f182
fix: treat empty valued env variables as false | FE (#18428)
* converting empty env values to boolean before storing in store

* triming and checking empty values

* Empty commit for test

Co-authored-by: Anubhav <anubhav@appsmith.com>
2022-12-13 15:38:37 +05:30
Hetu Nandu
c5ae0521ec
fix: Modal opening or closing type error (#18913)
fix for sometimes widget not available
2022-12-13 15:34:32 +05:30