9a9e97c53e
5 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Valera Melnikov
|
9e214c2c3c
|
chore: add appsmith icon package (#32927)
## Description - Add `appsmith-icons` package. Icons are automatically imported from Figma, optimized, and then React components are created based on them. Please read the [README](https://github.com/appsmithorg/appsmith/pull/32927/files#diff-163e187687a9784dfda13faf90276b1137ba6e85db21bd550c6a3ba486178e5e) for more information. - Replace Icons for Anvil widgets. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8847468194> > Commit: a2036daedef0a08b7c973e04ac11a224fb40c9c1 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8847468194&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
Pawan Kumar
|
fb275ec9cb
|
chore: Update defaults (#32736)
Fixes #32616 Fixes #32617 Fixes #32618 Fixes #32619 Fixes #32620 Fixes #32621 Fixes #32622 Fixes #32623 Fixes #32624 Fixes #32625 Fixes #32638 Fixes #32639 Fixes #32642 Fixes #32643 Fixes #32644 Fixes #32644 Fixes #32645 Fixes #32646 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added static label "Menu Item" for new menu items. - Introduced clearer placeholder texts across various widget configurations for enhanced user guidance. - Updated default button text to "Do something" and removed default click disable. - Included "RED" in default selections for Checkbox Group Widget. - New "Current Price" label in Currency Input Widget. - Changed default currency details to United States Dollar in Currency Input Widget. - Updated default labels and placeholders across multiple widgets for clarity and relevance. - **Bug Fixes** - Fixed inconsistencies in placeholder texts and default values across widgets to improve user experience. - **Documentation** - Updated placeholder and label texts in property configurations to reflect more accurate descriptions. - **Style** - Modified button variants from "filled" to "ghost" in Toolbar Buttons Widget. - **Refactor** - Removed unnecessary imports and updated method implementations to enhance performance and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
Valera Melnikov
|
10a98f9563
|
fix: use wds tokens in sections and zones (#30479)
## Description - Added tokens to the anvil config - Removed redundant functions for calculating widget sizes - I cleaned the widget configs - Added a zero-state to the input component - Optimised the responsiveness of the action group component https://github.com/appsmithorg/appsmith/assets/11555074/e9e0513a-cf3f-42ef-b960-820bb4980858 #### PR fixes following issue(s) Fixes #29507 #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced `MenuItem` display with additional text attribute for better accessibility. - Improved user interaction with `TextArea` and `TextInput` components through more effective handling of default and read-only states. - Extended `Flex` component to include click event handling capabilities. - Refined `ActionGroup` styling and dynamic sizing for a more polished UI experience. - **Enhancements** - Updated `Button` styling to ensure consistency across different screen sizes. - Optimized layout and styling of `Menu` items for improved visual hierarchy and responsiveness. - **Refactor** - Simplified `WidgetProvider` and `AnvilEditorWidget` configurations for more streamlined layout management. - Refined `ZoneColumn` rendering for better alignment with layout system principles. - **Bug Fixes** - Fixed minimum width calculation in `useZoneMinWidth` hook to ensure correct layout behavior. - Corrected `AnvilDSLTransformer` padding value for consistent widget spacing. - **Documentation** - Removed redundant Storybook addon to streamline developer experience. - **Style** - Adjusted CSS for various components to align with updated design system standards. - **Tests** - Updated widget property pane configuration tests for better coverage and reliability. - **Chores** - Cleaned up unused imports and methods across multiple widget components for improved code maintenance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Pawan Kumar
|
302ecb6a1c
|
feat: Tabler Icons (#30248)
Fixes #28443 Fixes #27866 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced `IconSelectControlV2` for enhanced icon selection with keyboard navigation and state updates. - Added new `iconStyle` theme property for users to define icon styles globally. - Implemented dynamic icon loading with fallback options, improving icon management. - **Enhancements** - Simplified icon usage across various components like `Button`, `IconButton`, `Menu`, `ModalHeader`, `TextInput`, and more by directly using icon names. - Enhanced `Tag` component to use a generic `Icon` component for the remove action. - **Style Updates** - Added CSS classes for resizing, boundary display, and pointer event handling. - Updated icon size definitions using CSS custom properties. - **Bug Fixes** - Fixed icon-related issues in `Button`, `ActionGroup`, `Menu`, and `TextInput` components to ensure proper icon display. - **Documentation** - Updated storybook and test cases to reflect new icon selection and usage. - **Refactor** - Refactored theme and token management to include `iconStyle` for consistent icon theming. - Refined the `ButtonGroupWidget` and `MenuButtonWidget` to use the new icon selection mechanism. - **Chores** - Cleaned up unused icon imports and components across the codebase to streamline the icon system. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Dhruvik Neharia
|
b1d754ca2b
|
feat: Integrate WDS Menu Button Widget (#29113)
## Description Adds WDS Menu Button Widget. #### PR fixes following issue(s) Fixes #28864 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new `Menu` component with customizable color options for items. - Added dynamic styling for menu items based on color attributes. - Implemented a new `WDSMenuButtonWidget` with configurable properties and styles. - Expanded the property pane with new configurations for menu items and buttons. - **Enhancements** - Improved menu placement options and handling of colors within the Menu component. - Enhanced the `MenuButtonWidget` with additional properties for better customization. - **Bug Fixes** - Fixed incorrect component naming for `MenuList` to ensure consistency. - **Documentation** - Updated Menu component stories to reflect new color handling features. - **Refactor** - Streamlined export statements for Menu components to simplify imports. - Organized property pane configurations into separate modules for clarity. - **Style** - Added new styles for the search bar and menu items for a more polished UI. - **Tests** - No visible changes to end-users. - **Chores** - No visible changes to end-users. - **Revert** - No visible changes to end-users. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Valera Melnikov <valera@appsmith.com> |