Commit Graph

1157 Commits

Author SHA1 Message Date
Aishwarya-U-R
3622bf924e
Automated tests for Postgres Datatype - Datetime (#14607) 2022-06-17 11:42:18 +05:30
Aswath K
478ae29b34
feat: Disable js toggle button if field is not empty (#12754)
* feat: Disable js toggle button if field is not empty and on non-default value

* allows certain values based on control type

* adds handling for more control types

* Change disabled message

* feat: makes option control delete button keyboard accessible

* adds support for theme values

* Adds support for border radius & box shadow controls

* message change and refactor

* minor correction in the message

* Add proper condition for Datepicker control

* fix one cypress test

* updated tests

* add checks for OptionControl

* Updated table binding test

Co-authored-by: apple <nandan@thinkify.io>
2022-06-16 15:17:35 +05:30
Aishwarya-U-R
d7eb5c58fc
Automated tests for Postgres Datatype - Numeric, Character (#14481) 2022-06-16 12:20:02 +05:30
ChandanBalajiBP
24d1ac1018 added test cases with requireed changes 2022-06-16 11:48:44 +05:30
Ankita Kinger
9b7944e7ee
feat: migrate organisation to workspace (#13863)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* migrated a few missed out org to workspace

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* fixed AppsmithRole

* mongodb version update

* fixed compile error

* fixed compile issue

* fixed some tests

* simplified embedded mongodb config

* updated a cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-06-15 21:07:41 +05:30
Favour Ohanekwu
6c45270def
fix: order async functions in settings tab alphabetically (#13731)
* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* sort js actions alphabetically in settings tab

* add cypress tests

* update cypress tests

* add onPageLoad settings locator

* Update cypress tests

* update cypress tests

* update cypress tests

* update cypress tests

* fix merge conflict

* JSFunctionnExe spec flow fix

* update cypress tests

* update cypress tests

* add test case for cloning page

* Datatypes - Numeric spec addition

* failure fixes

* JSfun failure fix

* Postgres failure fix

* JSFuncExecutions failure fix

* MySQL failure point fix

* COmmunity issues wait time fix

* Fixing toast mesg validation point

* Reverting all fixes

* Revertion

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:46:53 +05:30
Pawan Kumar
89bf40e3d7
fix: Toast shows wrong theme name when changing themes (#14488)
* fix typo in toast when changing theme

* fix cypress test

* Added wait time!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-15 12:21:37 +05:30
Ayush Pahwa
d220ed428a
Skipping parse of empty array response (#14502)
- When we get a response from API, the data can be either null, undefined, not an array and an array but with no data
- We had handled for everything else except the case of empty array
- This commit fixes that

- We run a query which will return an empty array as response
- We check if application is crashing because of this
2022-06-15 10:59:57 +05:30
Aishwarya-U-R
ad606ad3e2
Script fixes for flaky tests (#14494) 2022-06-14 11:02:37 +05:30
Rishabh Rathod
35aa6536d9
fix: mutliple onPageLoad api call (#14484)
* fix: mutliple onPageLoad api call
* fix postgres spec
2022-06-13 19:26:06 +05:30
Aishwarya-U-R
43cba21013
test: Automated tests for improved CRUD with JSONFrom - Postgres Ds (#14271)
* Postgres CRUD

* MySQL CI run fix

* Added wait time to DeployApp()

* Helpers Enhancements

* ChangeTheme CRUD

* Postgres CRUD

* Postgres CRUD updated

* Postgres CRUD updates

* Postgres CRUD fix

* Postgres CRUD update

* postgres CRUD update

* Postgress CRUD fix

* setting cypress video false

* ExecuteAction spec fixed

* Postgres case #13 fix

* postgres CRUD fix

* Postgres CRUD fixes

* cypress video - true, reattempt - 1

* failure fixes

* Bug 11529 script added

* Bug 11529 scripted + failure fixes

* JSOnLoad_spec failure fix

* OnLoadActions failure fix

* Failure fixes

* ReadTable increased timeout

* JSFunctionExecution_spec failure fix

* Removed duplicate cases

* Mongo failure fixes + applying theme

* Mongo Spec - Added Deletion of DS also

* Deleting initial page

* Deleting DS Validation added

* tc desc updated

* failure point fixes
2022-06-10 19:00:59 +05:30
rahulramesha
c1da8a6866
fix: paste widgets on a new page (#14295)
* paste widget on generate Page

* adding cypress tests
2022-06-09 17:17:47 +05:30
rahulramesha
abf5821d32
fix: select Modal Widget on clicking on settings badge (#14195) 2022-06-09 16:30:15 +05:30
Aishwarya-U-R
949b657103
Updating Mongo DB name to match Mongo TED database name (#14389) 2022-06-09 12:21:46 +05:30
akash-codemonk
50b93894d2
fix: Update the widget from drop down to select widget in suggested widget list (#14059) 2022-06-09 11:01:52 +05:30
balajisoundar
265ed0dc25
fix: Improve cell overflow check logic when switching between table page (#14095)
* fix: Improve cell overflow check logic when switching between table page.

* Table locators update

* Migration spec - locators update

* Migration spec locators update

* MongoDBShoppingCart spec locators update

* POstgress Spec locator fix

* Adding wait!

* Mongo DBcart spec fix

* EchoApiCMS_spec locator update

* Table locators update

* updated locators

* Added delay

* Hidden column fix trial

* Adding refresh page

* Adding time

* Fix cypress xpaths

Co-authored-by: bhavin <techbhavin@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
2022-06-08 21:59:31 -07:00
RakshaKShetty
221d9c0a7c
test: git delete branch tests (#14047)
* gitdeletebranchtests
2022-06-08 17:14:15 +05:30
NandanAnantharamu
eff7dd5a4e
test:JsonForm test for multi source data (#14153)
* JsonForm test for multisource data

* Added tests for jsonForm widget

* moved locators to seperate file

* Added some more tests

* Updated tests
2022-06-08 16:21:53 +05:30
Favour Ohanekwu
d5da24e51e
fix: cyclic dependency in renaming js objects (#13914)
* keep localunevaltree update in sync with unevaltree

* undo tree check

* identify .data difference for js objects

* empty line

* unit test

* unit test name change

* comment

Co-authored-by: Anand Srinivasan <anand.a.srinivasan@outlook.com>
2022-06-08 08:47:59 +01:00
Parthvi12
38f14bb5ac
test: Add regenerate SSH key tests (#14325)
* Add regenerate SSH key tests

* fix flaky tests

* fix flaky tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-06-08 13:07:00 +05:30
Aishwarya-U-R
98c06e2817
Automated tests for improved CRUD with JSONFrom - Mongo Ds (#14191) 2022-06-06 11:29:15 +05:30
Aman Agarwal
3bcb1daf73
fix: onPageLoad false failure issue (#14141)
1. Fixed on page load actions getting called multiple times.
2. Now Evaluation only happens once we complete the fetching of the page's all entities including js objects and actions, this avoids cases where actions are not defined when ran.

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2022-06-06 09:26:14 +05:30
Pawan Kumar
78e6bcf7ad
fix: Theming UX Changes (#13741)
* update color control ux

* add reset theme option

* remove the console

* update theme card

* update icons + text for reset

* update button size

* fix cypress tests

* fix cypress tests

* fix flaky git tests

* incorporate ashit feedback

* fix cypress tests

* fix color button in theme panel

* fix reset theme logic + jest tests

* fix button styles reset issue in json form

* add cypress test for theming reset

* incorporate ashit feedback

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-06-03 15:55:38 +05:30
Anagh Hegde
4c6c109edf
fix: Update the widget from drop down to select widget in suggested widget list (#13944)
* Update the widget from drop down to select widget
2022-06-03 07:49:56 +00:00
Bhavin K
1a3eafb182
fix: update error highlight border in RTE widget 2022-06-01 17:41:25 +05:30
Aman Agarwal
7aeaf75c90
fix: removed default value for API DS, updated conditions for headers and apiformattype (#14107)
* fix: removed default value for API DS, updated conditions for headers and apiformattype

* fix: added test cases for content type changes on changing method types

* fix: imported isEmpty directly with loading full lodash module
2022-06-01 10:29:58 +00:00
Bhavin K
95e6b4fb98
fix: switch group added check for inline width (#14190)
* fix: switch group added check for inline width

* SwitchGroup inline cypress test added

* New snaps to match CI run

* Adding right images for CI run

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-01 00:13:32 +05:30
Aishwarya-U-R
6c1c5581e7
Automated tests for improved CRUD with JSONFrom - MySQL Ds (#14014) 2022-05-31 11:03:59 +05:30
Parthvi12
da195a6ca0
remove third party api in cypress test (#14154) 2022-05-30 12:38:16 +05:30
haojin111
3c1b1a3628
Merge pull request #13864 from appsmithorg/feat/13412-improve-import-app-flow-ui
feat: 13412 - improve import app with progress bar
2022-05-26 16:49:47 +08:00
NandanAnantharamu
6359bfcfbe
test: List testcases (#14009) 2022-05-26 13:25:08 +05:30
Ankita Kinger
fa45282b0a
fix: alignment of the image seen on no search results on application page (#13950)
* fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)

* add debounce to search and remove state var

* increase debounce time

* fix: updated the condition to show expiry key (#13092)

* Add index for git (#13133)

* fix: Fixed compile time errors

* fix: Unable to see apps in home page after git connect fails (#13387)

* Fix Redis installation in Dockerfile (#13428) (#13430)

Conflicts:
	Dockerfile

* fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)

* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections

(cherry picked from commit 7261834fe5)

* fix: NPE check when datasource createdAt is null

(cherry picked from commit beafb371b24180dce2e351f1dea6d9d34db2a204)

* fixed image alignment for no search results on applications page

* deleted duplicate file

* reload to Refresh script update

* Adding sleep - script fix

Co-authored-by: Preet Sidhu <preetsidhu.bits@gmail.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: Rimil Dey <rimildeyjsr@gmail.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-26 10:05:35 +05:30
Abhijeet
845d5b2ad4
chore: Update CRUD page template to include JSONFormWidget (#12662)
* Updated Template

* Fix testcases

* Try removing autogenerated field entry from insert modal

* Update mongo testcase
2022-05-26 09:19:33 +05:30
Favour Ohanekwu
7bbd109f62
fix: improve jseditor linting performance (#14001) 2022-05-25 18:08:35 +02:00
Bhavin K
1760e8150c
fix: checkbox, switch property fields update, migration added (#13997) 2022-05-25 17:03:33 +05:30
Aswath K
c8e79eca95
feat: Focus widget name or first property when opening property pane (#13513)
* feat: intial investigation.

* Completed focusing of Property title

* removes unused import

* fix issue with inability to focus Dropdown

* checks if PP opened not because of focusing on input elements in widget

* Adds two level of focus for LocationSearch

* adds multi state to KeyValue component

* Adds multi state to Draggable List as well

* Adds multi state to DatePickerControl

* fix: style issue with draggableList & KeyValue comp

* avoids auto focusing on Panel

* remove commentedout code

* fix: cypress tests

* change ActionConstant name

Co-authored-by: Arsalan <arsalanyaldram0211@outlook.com>
2022-05-25 15:35:53 +05:30
Rishabh Rathod
cbce8f8b8e
fix: trigger consuming previous evaluated values (#13084)
We are changing how we maintain meta values in our architecture,

Earlier metaHOC component state was used to store meta values that were debounced and pushed in batch to metaReducer and trigger evaluation.
We remove the metaHOC state and directly update values to metaReducer and trigger evaluation separately via a debouched function.
2022-05-25 15:16:14 +05:30
akash-codemonk
77cee950b1
fix: inconsistency in naming actions from omnibar (#13898) 2022-05-25 15:10:06 +05:30
rahulramesha
a2688bb4da
feat: Add deprecation warning badge to deprecated widgets (#13381)
This Change also introduces, isDeprecated flag to widget config, when true will add the warning to the widget's propertyPane.
2022-05-25 09:38:32 +00:00
haojin111
7e5332ceb7 Merge branch 'release' into feat/13412-improve-import-app-flow-ui 2022-05-23 13:31:28 +08:00
Aishwarya-U-R
d0fed6bfe7
Automation script update to fix Community issues failure (#13968) 2022-05-23 10:50:27 +05:30
rahulramesha
f2c02ab931
fix: Grouped widgets moving to the bottom most row, even when widgets are not overlapping with the multi select box (#13658) 2022-05-20 15:57:12 +02:00
haojin111
82dcfeff21
Merge branch 'release' into feat/13412-improve-import-app-flow-ui 2022-05-20 04:17:18 +08:00
Favour Ohanekwu
2748ed0e64
fix: prioritize parse errors in debugger callout (#13765)
Prioritize parse errors over lint errors in debugger callout
2022-05-19 11:57:49 +01:00
ashit-rath
f6d726b2a1
task: JSONForm footer should always stick to bottom when fixed footer enabled (#13904) 2022-05-19 13:07:59 +05:30
Ayangade Adeoluwa
f7107a4a0a
Fix response tab overflow issue (#13839)
This commit fixes three things

- It prevents the tab headers from being scrolled up when on the RAW/JSON tabs.
- It prevents the Table component from pushing the API right pane away when its contents are too wide.
- It also prevents the table and JSON component from clipping the data displayed within them by adding margins/paddings between them and the parent container.
2022-05-19 08:32:43 +05:30
Ayangade Adeoluwa
1ee494b9ca
fix: Fix validation check that is blocking input from changing (#13943)
* Fix validation check that is blocking input from changing

* Add testcases for Elastic search datasource

* Adds header value to test case

* Fix validation logic
2022-05-18 17:35:03 +00:00
Aishwarya-U-R
04a8c3b037
Tests for JSObjects-onPageLoad (#13712)
Automated tests to improve coverage for JSObjects-onPageLoad
2022-05-18 16:09:42 +05:30
Bhavin K
94b93a657b
fix: remove cell background from empty rows (#13257) 2022-05-18 04:46:25 +00:00
Parthvi12
32bcd94e54
Add tests for git discard changes (#13866) 2022-05-18 04:45:32 +00:00
haojin111
27ebbfabe3 update full changes 2022-05-17 14:56:34 +08:00
ashit-rath
25d24688a6
fix: Property pane - Hidden sections icon select popover not opening properly (#13881) 2022-05-17 12:25:25 +05:30
haojin111
89990c2114 unstaging coverage-summary.json 2022-05-17 14:28:00 +08:00
haojin111
a3be2498e3 added import application progress bar when importing from json 2022-05-16 18:09:23 +08:00
Tolulope Adetula
a956ff6d71
Merge pull request #13793 from appsmithorg/fix/select-widget-filtering
fix: Select widget filtering
2022-05-16 05:17:43 +01:00
ashit-rath
c60f102e45
fix: JSONForm - hidden field value reflects in formData (#13739)
* fix: JSONForm - hidden field value reflects in formData

* shifted update form code from useController to FieldRenderer

* review changes
2022-05-12 17:52:44 +05:30
Tolulope Adetula
379ce6cf5c fix: Select widget filtering 2022-05-12 12:31:45 +01:00
Parthvi12
72e24b9a2a
test: update cypress tests as per added test data in TED (#13761)
* update data table
2022-05-11 17:50:12 +00:00
arunvjn
ae22baaa36
fix: persists query param in redirect urls (#13738) 2022-05-11 20:42:07 +05:30
Favour Ohanekwu
876d1a17e7
fix: prevent lint warnings from blocking execution in js objects (#13700) 2022-05-11 11:20:33 +01:00
rahulramesha
27d5ae8b77
fix: Avoid pasting list widget inside another list widget (#13719)
* fix for stopping list widget from copying onto itself

* remove duplicate comment

* verify selected widgets are not inside list widget if list widget is to be pasted
2022-05-11 14:46:22 +05:30
NandanAnantharamu
7199a329a9
test: Theme related tests (#12740)
* Removed unwanted waits

* Updated test for fonts

* Updated tests with Font and Theme usecases

* updated tests

* Added new tests and common locators

* Added default/update theme tests

* grouped tests

* Updated Theme tests

* updated multiwidget test

* updated theme tests

* Updated tests

* Reordered tests
2022-05-11 11:43:28 +05:30
Aishwarya-U-R
f5cc98644f
Automated tests to TableFilterSpec for Bug #13334 + failure fixes (#13662) 2022-05-10 10:40:46 +05:30
akash-codemonk
2b5d5dd89f
fix: triggering omnibar shortcuts toggles visibility when visible (#11601) 2022-05-09 19:43:57 +05:30
ashit-rath
47a31a8412
feature: JSONForm - disable add new and remove buttons when array is disabled (#13520) 2022-05-09 17:34:49 +05:30
Keyur Paralkar
1c1135d639
refactor: removed the duplicate style properties for the list widget (#13605)
* refactor: removed the duplicate style properties for the list widget

* test: fixed list_spec cypress failures
2022-05-09 15:41:36 +05:30
Favour Ohanekwu
3ab904d83d
fix:only show js successful execution toast message in edit mode (#13590)
* only show js successful execution toast message in edit mode
2022-05-07 17:03:03 +01:00
rashmi rai
c0f98ad4d7
fix:change default value in rest api json and placeholder (#13261) 2022-05-06 19:13:10 +01:00
haojin111
b6d2f971c0
feat: 12594 - added cypress test of form login on admin setting page (#13178)
* added cypress test of form login on admin setting page

* resotre setting after checked

* added a check if signup form is enabled for all users

* minor fix

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-05-06 20:21:08 +05:30
Arpit Mohan
4934fc9066
Merge pull request #13644 from appsmithorg/fix-12164 2022-05-06 16:17:37 +02:00
rahulramesha
7a501ecd9c
fix: stopping list widget from copying onto another list widget (#13621)
* fix for stopping list widget from copying onto itself

* remove duplicate comment
2022-05-06 19:41:09 +05:30
ashit-rath
ddc95fae53
fix: JSONForm fix events/actions controls JS mode produces additional binding strings (#13509)
* fix: JSONForm fix events controls js mode additional binding strings

* fixed globalContext value for fieldState update and fix FilterText spec
2022-05-06 15:29:56 +05:30
Anubhav
03684fce97 fix: disable revoke button after first click 2022-05-06 15:21:33 +05:30
ashit-rath
910427788e
fix: JSONForm currency and phone input dropdown not working in Array Field (#13564) 2022-05-06 15:19:36 +05:30
Aishwarya-U-R
e8c9d1da3e
test: Automated tests to improve coverage for JSObjects-onPageLoad + Flaky fixes (#12904)
* Adding theming spec

* Removed theming spec

* Reverted cypress.json changes

* Adding more JSOnPage load validations

* Added Theming - comment spec

* Theming - new cases

* JSOnload fix

* JSOnPage load cases update

* Bind_tabWidget fix

* Name update to CommunityIssues

* Flaky fixes

* Flaky fix

* Reverting postgress index addition

* Failure fixes
2022-05-06 11:10:10 +05:30
f0c1s
7a3985f962
feat: git discard changes (#11835)
* feat: git discard changes
* fixed cypress test in git connection
* feat: add discardDocUrl and update casing
* chore: update tests
* chore: fix review comment

Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-06 10:14:24 +05:30
ashit-rath
f0952b8082
fix: JSONForm RadioGroupField - support numeric values in the options (#13365)
* fix: JSONForm RadioGroupField accept numeric values in the options

* cypress test - clear options before adding

* update code editor clear
2022-05-05 11:10:52 +05:30
Parthvi12
b84f827ef2
test: fix Tab widget related cypress tests (#13571)
* fix Bind_TabWidget_Input_spec and Tab_new_scenario_spec
2022-05-05 09:05:36 +05:30
ankurrsinghal
ef79f6450d
Merge pull request #12190 from appsmithorg/feature/pp-datepicker
feat: added keyboard interaction for datepicker
2022-05-04 18:10:27 +05:30
Pawan Kumar
809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values (#13318)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
Favour Ohanekwu
7261834fe5
fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)
* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections
2022-05-04 09:43:26 +01:00
rahulramesha
e128b2daf3
feat: new Widget Copy paste experience (#12906)
* copy paste commit

* class name generator changes

* modal widget fixes change

* addressing review comments

* bug fix for after deleting a widget by undoing action

* additional fix for modal widget

* additional tests for fixes
2022-05-04 13:28:57 +05:30
ashit-rath
7dbe9ccf26
fix: JSONForm placed in modal does not update default value from source data (#13453) 2022-05-04 12:53:48 +05:30
Abhijeet
9fc9f7a774
chore: Commit application files during the connect flow (#12288)
* Commit application files during the connect flow

* Refactor detach remote method name

* updating connectToGitRepo method

* fix git tests

* Update default dsl to remove uncommitted changes for bottomRow and pathlist

* updating git cypress tests

* fixed git bug spec cypress test

* enabled other test case

* with store test

* fixed comment

* closing git sync modal

* updated test logic

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
Co-authored-by: Parthvi12 <80334441+Parthvi12@users.noreply.github.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-04 12:27:07 +05:30
ashit-rath
06168ecb60
fix: submit button not disabled in invalid json form on first load (#13415)
* fix: submit button not disabled in invalid json form on first load

* reset fixes
2022-05-04 10:45:27 +05:30
Ankur Singhal
3b63f59a16 added the force true to single-select action selector 2022-05-02 15:47:25 +05:30
Parthvi12
2f4ca6aa98
test: Add tests for git sync app and git bugs (#13394)
* Add tests for gitSync

* add test for git import bug#12749

* modified importAppfromGit method

* add test for bug #13385

* updated tests

* fixed test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-02 09:59:03 +05:30
akash-codemonk
9b9048fdc4
chore: add analytics event for similar templates click (#13177) 2022-04-29 15:39:16 +05:30
Tolulope Adetula
5749a4461b Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-29 02:37:59 +01:00
Favour Ohanekwu
942547287c
feat: js object v1 run and settings redesign (#11456) 2022-04-28 17:51:02 +01:00
Favour Ohanekwu
02d4af3ed7
prevent multiple execution of pageload actions when generating a template (#13361) 2022-04-27 19:28:52 +01:00
Maulik
0eef3b0bfd
fix: code hidden issue for JS Enabled fields (#13241)
* fix code hidden issue for JS Enabled fields

* test for code hidden fix
2022-04-27 12:37:33 +05:30
haojin111
7b09976f52
feat: 12457 - added application import success modal (#12739)
* added application import success modal

* updated logic and added cypress test

* fixed cypress test

* added local storage for refresh

* fixed issue - 11721 git import issue

* fixed cypress test with new designd modal

* fixed cypress test failed issue
2022-04-27 12:07:04 +05:30
Aishwarya-U-R
8c8a3b0695
Adding wait to fix flake failures (#13226) 2022-04-22 19:46:03 +05:30
ashit-rath
1acf242600
feat: JSONFrom add isValid form level property to represent overall form validity (#13083) 2022-04-22 17:20:51 +05:30
Ankita Kinger
6f311944be
fix: add edition check on cypress to avoid merge conflicts on EE (#13188)
* added edition check on cypress to avoid merge conflicts on EE

* minor change
2022-04-21 19:04:03 +05:30
Ankita Kinger
9ed26a92b0
chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
Aishwarya-U-R
ade7b05adb
test: Automation script update to fix PromisesSpec failure (#13148)
* Promises spec fix for validating EitherOr

* Sipping LayoutValidationForLoginPage failure case
2022-04-20 22:00:22 +05:30
arunvjn
c925bf2efd
fix: scroll to active entity in explorer on route change (#13085)
* Scroll to active entity in explorer on route change

* Removes scroll animation

* Open modal via entity explorer

* Try tonavigate to canvas only in edit mode

* Added cypress to assert modals' presence when triggered from the API page.
2022-04-20 21:55:55 +05:30
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field (#13073) 2022-04-20 14:47:34 +05:30
Anagh Hegde
ecb08a4918
Add logic to change default branch for git connected application (#11549)
We are opening the appsmith default application when the user clicks on edit. But when the app is connected to git we should always bring up the default application of the default branch.
2022-04-19 19:43:23 +05:30
Bhavin K
b6b253a636
fix: update custom chart data and type only (#12574) 2022-04-15 16:28:13 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar (#12890) 2022-04-15 11:10:56 +05:30
akash-codemonk
90fa2d7912
fix: onboarding deploy step getting redirected to edit view (#12830) 2022-04-14 16:58:51 +05:30
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
Parthvi12
0766f83cf0
test: Add tests for git bugs and git import (#12751)
* add tests for git bugs and git import

* add dsl file

* added test for git bug and commented git sync test for apps

* updated tests

* removed wait

* updated messages.test.ts

* updated git import tests

* added fix for onboarding_spec
2022-04-14 08:32:57 +05:30
Aishwarya-U-R
8f4756c1d1
test: Automated tests for AForce Migration scenarios + Improved TableFilter spec script coverage (#12534)
* Aforce spec- DefaultSearchText added

* Bug 12228 scripted

* Remove text added

* Aforce - Client Side Search added

* Aforce - adding new issue from modal

* Aforce spec - add new issue fixed

* Aforce spec - update/Delete issue added

* Aforce - multi widget selection fix

* aforce spec - multi select fix

* Aforce - multi select fix

* Aforce - multi select fix

* Removing Table_Filter_spec from ignore files

* MemberRoles locator fix

* member roles locator update

* Tablefilter spec fix

* Aforce spec type fix

* Aforce - search spec

* TableFilter spec fix

* Chartdatapoint fixed

* desc update

* Aforce - skipping table search again

* Removed duplicate spec

* GetNClick improved

* BindTable_api spec fix

* AForce spec fix

* CHartdatapoint spec fixed

* JSObjToListwidget spec fix

* OnPageLoad spec fix

* updates

* TableFilter.ts added

* TableFilter added more scenarios

* TableFilter added more scenarios

* Table_spec failure fix

* TableFilter spec - scenarios added

* AForce Filter case added

* AForce fix

* Aforce filter fix

* Aforce fix

* SelectFromMultiSelect added fix

* Picking msg from message.ts file

* Aforce spec - Added wait

* Aforce - filter spec fix

* JSONload messages update
2022-04-12 15:31:22 +05:30
Tolulope Adetula
52a51b882c
fix: select widget virtualization not rendering first top items (#12768)
* fix: select widget virtualization

* fix: use max height of renderMenuItem

* fix: make height a constant

* fix: variable name

* fixed spec

Co-authored-by: Ashit Rath <ashit@appsmith.com>
2022-04-11 18:20:01 +05:30
haojin111
6e63290477
fix: 12338 - postgres datasource default configure on reconnect modal (#12503)
* updated logic of form initialization on reconnect datasource modal

* fixed cypress test

* fixed cypress test
2022-04-11 16:53:52 +05:30
akash-codemonk
d100cac0ec
fix: fork app button not opening the fork modal for non-signed in users (#12479) 2022-04-11 10:44:50 +05:30
NandanAnantharamu
db2310bef7
test: Commands file organised (#12533)
* Commands file seggregated

* updated support file

* updated common method

* updated the support files

* Updated imports
2022-04-11 09:00:37 +05:30
balajisoundar
6cdef28afa
fix: Phone and currency widget's dialCode and currencyCode should … (#12720) 2022-04-08 19:39:05 +02:00
ashit-rath
6a33b4da5a
fix: JSONForm select not working in nested fields - Array/Object (#12635)
* fix: JSONForm select not working in nested fields - Array/Object

* fixed merge-conflict missing import
2022-04-08 22:54:08 +05:30
arunvjn
7f4a190657
chore: Added analytics for manual upgrade and adds redirection (#12707) 2022-04-08 20:27:19 +05:30
Paul Li
9219545879
fix: Form widget should include the following widgets in data property when added in form (#12529)
* fix: Form widget should include the following widgets in data property when added in form

-- Add value props to the widgets, including CheckboxGroupWidget, MultiSelectTreeWidget, MultiSelectWidgetV2, SingleSelectTreeWidget, SwitchGroupWidget
-- Add the corresponding Cypress test case

* fix: Form widget should include the following widgets in data property when added in form

-- Set the value meta propperty for PhoneInputWidget to empty string by default

* fix: Form widget should include the following widgets in data property when added in form

-- Include PhoneInputWidget for test

* fix: Form widget should include the following widgets in data property when added in form

-- Add InputWidgetV2 and CurrencyInputWidget

* fix: Form widget should include the following widgets in data property when added in form

-- Add SelectWidget for assertion

* fix: Form widget should include the following widgets in data property when added in form

-- Wait for @updateLayout

Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
2022-04-08 21:07:10 +08:00
Paul Li
115a119003
fix: Auto-suggestion is not working for progress widget while binding (#12675)
* fix: Auto-suggestion is not working for progress widget while binding

-- Add a Cypress test case for demonstrating auto suggestion

* added fix for buttonspec's test

Co-authored-by: Somangshu Goswami <somangshu.goswami1508@gmail.com>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-04-08 20:11:01 +08:00
Tolulope Adetula
08246e7783
Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-08 09:02:06 +01:00
ashit-rath
99ec9e82e3
fix: JSONForm select/multiselect filterText value synchronous update with onFilterUpdate action (#12578)
* fix: JSONForm select/multiselect filterText synchronous update with onFilterUpdate action

* removed unused dep from useMemo
2022-04-08 11:39:23 +05:30
Tolulope Adetula
99a5b8ca69
Merge pull request #12356 from appsmithorg/fix/table-widget-scroll-issue
fix: remove unnecessary horizontal scroll when table columns fit within table widget width and prevent unnecessary re-renders
2022-04-07 19:46:43 +01:00
Arsalan Yaldram
461f35380b
Merge pull request #12546 from appsmithorg/fix/10319-select-api-response
fix: Disable CTRL+A to select all widgets on Api / Datasource Pane.
2022-04-07 21:51:10 +05:30
Yash Vibhandik
7736daf0a5
fix: 8385 added button variant support in table column type button (#9164) 2022-04-07 16:19:51 +00:00
f0c1s
0ad66f27bd
fix: introduce new regexp for remote url validation (#12004)
* fix: introduce new regexp for remote url validation
* chore: add tests and refactor
* fix: failing cypress test
2022-04-07 16:19:28 +00:00
Bhavin K
d22ae809cb
fix: handle duplicate tab name in tab widget (#12411) 2022-04-07 16:19:12 +00:00
arunvjn
03b46483dc
fix: 404 on apps with names that start with api, login or oauth (#12619) 2022-04-07 07:39:15 +02:00
Tolulope Adetula
86ce80abc3 feat: add total records and pageCount to table header 2022-04-06 12:48:55 +01:00
arunvjn
f18d3b8dc4
fix: update url while switching between git branches (#12586) 2022-04-06 11:46:37 +02:00
Apeksha Bhosale
e7d4bdba6e
fix: removed promisification of confirmation (#12553)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 12:52:18 +05:30
Bhavin K
787df868bb
Revert "fix: #6518 Implemented responsive table header controls (#10971)" (#12583)
This reverts commit 88ad2bcbd1.

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 11:07:13 +05:30
Ankita Kinger
253b90e595
chore: Add some cypress tests for Admin settings page (#12542)
* added few cypress tests for admin settings page

* uncommented some cypress tests

* updated PR based on suggestions in comments
2022-04-05 18:00:57 +05:30
Arsalan
e88c76d691 fix: Test case for Canvas_scrolling_spec 2022-04-05 14:55:48 +05:30
Arsalan
f5057c544e Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-04-05 14:47:39 +05:30
Arsalan
aa025143c3 Merge branch 'release' into fix/10319-select-api-response 2022-04-05 14:43:29 +05:30
Arsalan
589bdfc074 fix: Fixed jest test case and added cypress case 2022-04-05 14:42:41 +05:30
Tolulope Adetula
6b5a6ff8bf
Merge pull request #12459 from appsmithorg/fix/Multiselect-style-specificity
fix: Multi-select dropdown not closing properly
2022-04-05 09:07:54 +01:00
Tolulope Adetula
e05e75758d
Merge pull request #11383 from appsmithorg/feat/4182-form-detect-changes
feat: Internal property to detect changes in a form
2022-04-05 06:35:20 +01:00
Arsalan
b3843e7aa9 fix: Fixed failing test cases 2022-04-04 19:19:51 +05:30
Arsalan
1bf80bd8b8 fix: undo spec test changes. 2022-04-04 19:17:48 +05:30
Arsalan
197554917d fix: undo spec test changes. 2022-04-04 19:17:02 +05:30
Arsalan
b995983adf fix: Test cases fixed for button widget. 2022-04-04 19:07:09 +05:30
Yash Vibhandik
88ad2bcbd1
fix: #6518 Implemented responsive table header controls (#10971) 2022-04-04 18:47:45 +05:30
arunvjn
1af6ef2be8
fix: 404 on renaming new pages in apps with legacy URLs (#12547) 2022-04-04 13:11:52 +02:00
Arsalan
2e2c0d977e Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-04-04 16:06:09 +05:30
Parthvi12
6653adc30e
test: add tests for git import flow (#12427)
* adding basic test for git import

* add git import test
2022-04-04 13:27:34 +05:30
Tolulope Adetula
2bce6d090e fix: failing tests 2022-04-04 07:08:40 +01:00
Paul Li
dfd3662bd1 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-04 13:27:03 +08:00
Tolulope Adetula
3fb3eff92e
Merge pull request #12324 from appsmithorg/fix/default-value-for-select-widget
fix: default value consistency issues in select widget
2022-04-04 06:20:01 +01:00
Tolulope Adetula
880cb75b3c fix: select dropdown 2022-04-04 06:12:33 +01:00
Aishwarya-U-R
7a7169e8c3
test: Cypress tests to include Deploy mode verifications + few flaky fixes (#12444) 2022-04-03 18:43:20 +02:00
Paul Li
bbf7f12e4b Merge branch 'release' into feat/4182-form-detect-changes 2022-04-02 23:35:10 +08:00
Paul Li
842e330db3 feat: Internal property to detect changes in a form
-- Change updateCodeInput command to testJsontext
2022-04-02 23:33:14 +08:00
Arsalan
abe304152c Merge branch 'release' into fix/button-group-undo 2022-04-02 18:07:58 +05:30
Paul Li
cc9db789b2 feat: Internal property to detect changes in a form
-- Fix a Cypress test case in Entity_Explorer_DragAndDropWidget_spec.js
2022-04-02 08:13:17 +08:00
Paul Li
9590e0fc7a Merge branch 'release' into feat/4182-form-detect-changes 2022-04-02 00:13:16 +08:00
Paul Li
e25b5da732 feat: Internal property to detect changes in a form
-- Fix on failed test cases in Entity_Explorer_Widgets_Copy_Delete_Undo_spec and Entity_Explorer_Widgets_Copy_Paste_Delete_Undo_Keyboard_Event_spec
2022-04-02 00:11:54 +08:00
Paul Li
78e452634e
feat: Progress bar widget enhancements (#12053)
* feat: Progress bar widget enhancements

-- Scaffold the widget for the first time

* feat: Progress bar widget enhancements

-- Change widget icon

* feat: Progress bar widget enhancements

-- Build property pane

* feat: Progress bar widget enhancements

-- Add a missing property, counterClockwise
-- Rename some properties

* feat: Progress bar widget enhancements

-- Build the first MVP of the widget

* feat: Progress bar widget enhancements

-- Reset rows to 4

* feat: Progress bar widget enhancements

-- Add Cypress test cases

* feat: Progress bar widget enhancements

-- Limit value by ranging from  0 to 100

* feat: Progress bar widget enhancements

-- Make isIndeterminate property not to be JS convertible
-- Hide progress bar and circular progress widget icon from entity explorer

* feat: Progress bar widget enhancements

-- Place indeterminate circular progress to be 100% fit into the container

* feat: Progress bar widget enhancements

-- Show result without rounding for the circular type

* feat: Progress bar widget enhancements

-- Comment out ProgressBar_spec.js

* feat: Progress bar widget enhancements

-- Remove circular progress and progressbar widgets from allowed list for list widget

* feat: Progress bar widget enhancements

-- Move ProgressBar_spec into CommentedScriptFiles directory
2022-04-02 00:02:19 +08:00
f0c1s
e69e6e0670
test: Fix failing git sync tests (#12488) 2022-04-01 16:55:56 +05:30
Paul Li
2b00f1cdf9 feat: Internal property to detect changes in a form
-- Fix on typo add missing assertion for hasChanges on the spec files
2022-04-01 18:38:35 +08:00
Arsalan
9ccdde3b1b Merge branch 'release' into fix/button-group-undo 2022-04-01 14:28:01 +05:30
Paul Li
afb7b40a44 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-01 15:44:55 +08:00
Paul Li
0a8b0dfe9a feat: Internal property to detect changes in a form
-- Fix on failed test cases because of newly added hasChanges meta property
2022-04-01 15:42:05 +08:00
Bhavin K
5124ae0322
fix: onclick handler update in ButtonGroup Widget (#12442) 2022-04-01 11:28:51 +05:30
Paul Li
6d744859c6 Merge branch 'release' into feat/4182-form-detect-changes 2022-04-01 04:14:05 +08:00
Paul Li
5bb926d6ed feat: Internal property to detect changes in form
-- Fix on the wrong widget name in RichTextEditor_spec.js
-- Replace selectors so that Cypress can interact with UI in Select_spec.js
2022-04-01 04:07:22 +08:00
Paul Li
3d5e443eb0 fix: Disabled button widget tooltips stay open
-- Fix on the wrong selector on deploy
2022-04-01 00:16:12 +08:00
Paul Li
4940d197b5 Merge branch 'release' into fix/7554-disabled-button-enable-tooltip 2022-03-31 20:24:50 +08:00
NandanAnantharamu
015c455603
test: enhancement tests for captcha (#12245)
* Enhancement tests for captcha

* Added few more usecases
2022-03-31 17:49:39 +05:30
Aishwarya-U-R
9bbd671b3f
test: Automated few tests for AForce Migration scenarios + Flaky fixes (#12231) 2022-03-31 17:21:08 +05:30
Paul Li
c582ad22da Merge branch 'release' into feat/4182-form-detect-changes 2022-03-31 17:53:50 +08:00
Tolulope Adetula
a44e7b3f24 Merge branch 'release' into fix/default-value-for-select-widget 2022-03-31 09:31:47 +01:00
Bhavin K
2b47e00a71
fix: add overflow property in text-widget (#12160) 2022-03-31 10:18:51 +05:30
balajisoundar
ffc0f0e72f
fix: Currency input widget rounding off value if there is a trailing zero a… (#12325) 2022-03-31 08:31:04 +05:30
Paul Li
93ae266672 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-30 21:45:40 +08:00
Parthvi12
633d8674ee
test: update visual regression tests (#12165)
* updating screenshots as per new entity explorer

* commenting after hook of git_spec

* fix tests

* updating GOOGLE_SIGNUP_SETUP_DOC and GITHUB_SIGNUP_SETUP_DOC urls
2022-03-30 15:27:09 +02:00
Preet Sidhu
c9069bedce
Merge pull request #11673 from appsmithorg/fix-11468_dropdown_performance
fix: 11468 select widget performance on a large data set.
2022-03-30 18:41:59 +05:30
akash-codemonk
9cbabfb028
chore: Remove limit update step in guided tour (#11475) 2022-03-30 18:41:41 +05:30
Bhavin K
9f246f7d7a
fix: updated internal selectedDate condition (#12268)
* fix: updated internal selectedDate condition

* fix: updated cypress test case
2022-03-30 13:11:10 +00:00
Paul Li
076c542f64 fix: Disabled button widget tooltips stay open
-- Change the existing test case so as to be tested on deploy
2022-03-30 18:10:51 +08:00
Tolulope Adetula
e89c454ce5 fix: add cypress tests 2022-03-29 08:39:34 +01:00
arunvjn
23c12f4afc
fix: URL slugs in duplicate, import and export operations. (#12283)
* Persists modal to show info when update is in progress
2022-03-28 18:30:05 +00:00
Arsalan
d18ee573cb fix: Merge conflicts Resolved. 2022-03-28 18:21:06 +05:30
Preet
8734ae04f3 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-28 15:25:05 +05:30
Paul Li
35b1546f78
fix: Button group widget's pop-over/drop-down enlarged along the width of the parent (#11804)
* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Implement dynamic width calculation

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add corresponding Cypress test cases

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add min-width CSS property for popover

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Add a comment for minPopoverWidth

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Remove the comment for minPopoverWidth

* feat: Button group widget's pop-over/drop-down enlarged along the width

-- update the state variable, itemWidths inside setTimeout to access the updated DOM

* fix: Button gruop widget's pop-over/drop-down enlarged along the width

-- Refine update logic

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Make code DRY by creating createMenuButtonRefs and getMenuButtonWidths methods

* fix: Button group widget's popover/dropdown enlarged along the width

-- Make every popover class name unique

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Rewrite Cypress test

* fix: Button group widget's pop-over/drop-down enlarged along the width

-- Eliminate unnecessary test case from ButtonGroup_spec
2022-03-28 12:44:40 +05:30
Preet
d456df8cf6 Merge branch 'release' into fix-11468_dropdown_performance 2022-03-28 12:01:15 +05:30
Parthvi12
794c0f2299
test: add test for git sync bug #10773 (#12267)
* added test for git sync bug and fixed flaky tests

* updating git test
2022-03-28 10:40:07 +05:30
Mojtaba
5cac8cb3b9
feat: Add Array type to MultipartFormDataType variants for REST api (#11386)
* feat: Add Array type to MultipartFormDataType variants
 and handle every item in list as a part in multipart request

* fix: add array options

* fix: rename file to  array value

* fix: parse Array from json text

* fix: reformat the code and remove `System.out.println`

* fix: testParseMultipartArrayDataWorks is more accurate now

Co-authored-by: Segun Daniel Oluwadare <dodanieloluwadare@gmail.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-26 20:08:55 +01:00
Abhijeet
b13cf320f0
chore: Add manual and auto update fields within application object to distinguish between the migration related changes (#12099) 2022-03-26 10:40:59 +05:30
Preet Sidhu
74def3bb98
Merge branch 'release' into fix-11468_dropdown_performance 2022-03-25 16:45:14 +05:30
Preet
16bea463e7 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:34:40 +05:30
arunvjn
69c09c03aa
feat: adding slug names in urls (#10957)
* Init commit clean urls

* Changes to builder route

* Refactored URLs

* Remove default params from url builder functions.

* Fixed more urls

* Changed selector name

* Minor url correction

* Type fixes

* Jest fixes

* Fixed routing for old published apps

* Fixed url slug replace

* page-1 -> page1 as default page slug name

* Remove application id from init editor calls

* Use default page slug

* Added comments and placeholder values for slug names

* variable rename

* Removed redirection and added back the old routes

* Prevent page slug name recompute

* Fixed home page load in view mode

* Added null checks

* Fixed jest test

* Fixed jest test

* Update URL slugs when app/page name changes

* Added unit tests and updates types

* Removed unused code

* * Removed duplication fetch page call.
* Fixes #11354
* Fixed sign up flow

* Refactored initializeEditorSaga

* Fixed warnings

* Fixed integrations screen URL bugs

* Cypress fixes

* Fixed slug names in copy/move operations and pages screen

* Minor refactor

* Fixed page highlight bug in published apps

* Added new url factory and middleware to store url params

* Changed store to default export and fix unit tests

* Fixed slugs unit test

* Minor fixes

* Fixes #11379

* Fixed set as home page feature

* Updated types

* app id adjustments for cypress

* Fixed bad merge

* Refactored routes to functional component

* * Fixed EE active entity highlight.
* Remove unused code in editor router.

* jest fix

* Mock history to prevent security errors

* constant rename

* Removed console logs

* Fixed page id regex

* Do not check for /pages in url

* Fixed missing pageId on quick edit/deploy clicks

* Missed files from previous commit

* Fixed warnings

* Fixed jest test

* New api integration

* feat: Add applicationVersion property to Application (#11626)

Added a new property to Application object - applicationVersion. This property can be used to identity when there is a breaking change and can not be solved with migration. FE will use this property to detect such conditions. Another API is added to migrate the applicationVersion to latest version when user migrates the breaking changes.

* Added manual upgrade modal.

* Test fix

* Fixed jest test

* function rename

* Fix deploy error

* Added null check

* Changes to persist URL search params when redirecting

* Added updates tooltip

* More unit test cases

* Fixed git url redirection

* Fix warning

* Fixed evaluation on upgrade

* Fixed warnings

* File rename

* Added cypress for clean urls

* Fixed import/export/fork cypress

* Cypress api server fixes

* Fixed mongo spec

* Fixed replay spec

* Fixed comments spec

* More cypress fixes

* Fixed tooltip in update btn

* Text size changes

* Minor fixes

* Jest test fix

* Fixed type error

* Fixed warnings

* Fixed todo comments

* Moved description to constants file

* Fixed cypress CI run crash

* Fixes git cypress failures

* Import/Export cypress test fixes

* Import export fork cypress fixes

* Explorer test fix

* Switch branch test fix

* Added applicationVersion in export app json

* Calls plugin forms in parallel

* Fixed warnings

* Fixed warning

* Import export CI fixes

* Reverts previous changes

* Fixes import export

* Fixed import export cypress URL verification

* Pass applicationVersion when duplicating application

* Cypress fix

* Dummy commit

Co-authored-by: Nayan <nayan@appsmith.com>
2022-03-25 16:13:26 +05:30
Preet
6902255b72 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:06:37 +05:30
Paul Li
d001aa81c5 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-25 17:29:04 +08:00
Aishwarya-U-R
f68bdaa453
test: Skip Git flaky test to unblock CI (#12238)
* Commenting git flaky

* BindApiWIthlistWidget validaton fix

* BindApiWIthlistWidget validaton fix

* SwitchGroup spec fix

* command.js change
2022-03-25 12:04:23 +05:30
Aishwarya-U-R
761e697da8
test: Automated tests improvements for Mongo CRUD cases + few flaky fix (#11985)
* Adding AForceMigration spec

* Merge from release

* Mongo CRUD data load check added

* Added bug id & adding to skip to checkin

* Unskipping MySQL_Spec to test TED

* Api-bugs spec fix

* Adding back MySQL_Spec to ignore

* EE_CopyQuery_RenameDatasource_spec revert to fix

* Skipping Git_sync flaky test

* Removing mySQl from ignore

* Unskipping Mongo cases as Bug12162 fixed

* Empty files moved due to Mocha update
2022-03-25 01:04:28 +05:30
Sumit Kumar
40f4e3c755
fix: S3 plugin: provide support for MinIO (#11766)
* update option label

* add minIO as a separate datasource option
add datasource connection changes to support minIO without SSL and when using CA signed certificates

* fix cypress tests
2022-03-24 18:28:00 +05:30
Yash Vibhandik
08f5347b72
fix: #8911 auto complete property updated (#10679)
* fix: #8911 auto complete property updated

* test: updated cypress test

* fix : update cypress

Co-authored-by: bhavin <techbhavin@gmail.com>
2022-03-24 17:42:22 +05:30
Arsalan
543240017d fix: Merge Conflicts Resloved. 2022-03-24 15:32:21 +05:30
NandanAnantharamu
c7f3b86d8a
test: added test for recaptcha (#11805)
* Added test for Recaptcha

* updated test
2022-03-24 14:59:29 +05:30
arunvjn
6c3116b0aa
fix: unneccessary ellipsis for page names in view mode (#12032) 2022-03-24 13:14:53 +05:30
Tolulope Adetula
8b26bfc0c7
Merge pull request #12089 from appsmithorg/fix/MultiSelect-Default-Label-incorrectly-displayed
fix: multiselect default label issue
2022-03-24 08:37:15 +01:00