Commit Graph

5214 Commits

Author SHA1 Message Date
Bhavin K
958233f4f5
fix: added dataFormat into file data (#12807) 2022-04-21 16:09:24 +05:30
Satish Gandham
f6b29d3b71
Fix perf infra data collection (#13158)
Only last run data was being saved to supabase since we were changing the value in the same object.
2022-04-21 15:30:07 +05:30
albinAppsmith
978f1d3cd1
chore: Added margin bottom for sign posting checklist footer (#12884) 2022-04-21 11:44:34 +05:30
Ankita Kinger
9ed26a92b0
chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
Aishwarya-U-R
ade7b05adb
test: Automation script update to fix PromisesSpec failure (#13148)
* Promises spec fix for validating EitherOr

* Sipping LayoutValidationForLoginPage failure case
2022-04-20 22:00:22 +05:30
arunvjn
c925bf2efd
fix: scroll to active entity in explorer on route change (#13085)
* Scroll to active entity in explorer on route change

* Removes scroll animation

* Open modal via entity explorer

* Try tonavigate to canvas only in edit mode

* Added cypress to assert modals' presence when triggered from the API page.
2022-04-20 21:55:55 +05:30
rahulramesha
98f6a3fede
move reflow out of beta (#12746) 2022-04-20 18:33:30 +05:30
Aman Agarwal
356cdfffab
fix: changed prop drilled fn to class fn, avoided array prop (#12788) 2022-04-20 15:56:27 +05:30
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field (#13073) 2022-04-20 14:47:34 +05:30
rahulramesha
27b54f22e8
Reflow overlapping fix on canvas edges (#12745) 2022-04-20 12:56:35 +05:30
haojin111
923efa9696
fixed issue of deleting original default branch (#13062) 2022-04-20 05:50:54 +05:30
Anagh Hegde
ecb08a4918
Add logic to change default branch for git connected application (#11549)
We are opening the appsmith default application when the user clicks on edit. But when the app is connected to git we should always bring up the default application of the default branch.
2022-04-19 19:43:23 +05:30
rashmi rai
bb5d7159c6
Always show advanced settings in rest api editor (#12927) 2022-04-19 12:03:27 +05:30
Ankita Kinger
5b4628a9d4
Add common code for SAML (#12976)
Added new form field component in ads. Also, updated copy URL form component.
2022-04-18 17:47:29 +05:30
Rishabh Rathod
8df17fd56c
chore: remove minifying in dev to ease debugging (#12940) 2022-04-18 13:51:36 +05:30
Bhavin K
3575a03005
fix: updated cursor style in actionWrapper (#12850) 2022-04-18 11:39:11 +05:30
Bhavin K
b6b253a636
fix: update custom chart data and type only (#12574) 2022-04-15 16:28:13 +05:30
akash-codemonk
71591ff75f
chore: remove frontend template feature flag (#12937) 2022-04-15 14:58:27 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar (#12890) 2022-04-15 11:10:56 +05:30
Aswath K
25afe65cb7
Merge pull request #12923 from appsmithorg/fix/delete-button-kdb
feat: makes option control delete button keyboard accessible
2022-04-14 19:57:06 +05:30
Rishabh Rathod
846ba223ea
fix: replace rfdc with klona (#12568)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-14 14:19:13 +00:00
akash-codemonk
90fa2d7912
fix: onboarding deploy step getting redirected to edit view (#12830) 2022-04-14 16:58:51 +05:30
Aswath K
6a4b632338 Merge branch 'release' into fix/delete-button-kdb 2022-04-14 16:24:52 +05:30
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
Aswath K
1bf959d177 feat: makes option control delete button keyboard accessible 2022-04-14 13:23:41 +05:30
Ayangade Adeoluwa
a4d22b3d13
Handle stringified json response and fix alignment issue (#12886) 2022-04-14 12:53:07 +05:30
Rishabh Rathod
ee76cabb96
chore: fix Key missing error in Boxed component (#12912) 2022-04-14 06:31:50 +00:00
arunvjn
b7aff3c38b
chore: Parallellise fetch page call with actions, jsObject and plugins (#12537) 2022-04-14 10:16:17 +05:30
rahulramesha
cfba555fe8
chore: Should not persist DSL for mainContainer layout changes (#12351)
* Moving out non persistent state out of DSL

* replacing canvas width seector

* converting to immerReducer

* adding TODO and more immer reducer changes
2022-04-14 10:06:20 +05:30
Parthvi12
0766f83cf0
test: Add tests for git bugs and git import (#12751)
* add tests for git bugs and git import

* add dsl file

* added test for git bug and commented git sync test for apps

* updated tests

* removed wait

* updated messages.test.ts

* updated git import tests

* added fix for onboarding_spec
2022-04-14 08:32:57 +05:30
rahulramesha
faaf977728
feat: Container Jump Improvements and Code for tracking Container Jumps (#12686)
* conatiner Jump Optimization and tracking

* Round of mouse positions ans add negative jest test cases

* addressing review comments
2022-04-13 20:27:44 +05:30
akash-codemonk
2abb7bb822
fix: welcome form getting submitted on pressing enter key (#12613) 2022-04-13 15:37:11 +05:30
f0c1s
736c2e024e
feat: git delete branch (#12681) 2022-04-13 15:33:23 +05:30
akash-codemonk
73482000a6
chore: search for templates with a given datasource or widgets (#12434) 2022-04-13 14:18:40 +05:30
f0c1s
f5796bfa30
fix: git merge tab issues (#12576) 2022-04-13 08:47:33 +00:00
CommanderRoot
a778a98016
chore: replace deprecated String.prototype.substr() (#11928)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-04-13 12:30:38 +05:30
Favour Ohanekwu
b102d32761
fix: show loading state in JS Editor (#12820) 2022-04-13 11:47:56 +05:30
Anand Srinivasan
8420f6c5fa
fix: Js object - set async tag after all objects are parsed (#12684)
* set isAsync after all parsing is done

* clean up
2022-04-13 11:07:46 +05:30
Preet Sidhu
19d0db30b0
fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)
* add debounce to search and remove state var

* increase debounce time
2022-04-12 16:31:51 +00:00
akash-codemonk
d292075243
fix: template fork button style on safari (#12202) 2022-04-12 19:23:57 +05:30
Rishabh Rathod
136308fd7c
fix: table search text dependency deletion (#11608)
* Replace BindingPaths with ReactivePaths and remove non-bindable property path from bindingPaths to reduce confusion.
2022-04-12 13:09:26 +00:00
arunvjn
68bca33a55
fix: broken checklist onboarding flow (#12822) 2022-04-12 17:03:35 +05:30
Aman Agarwal
21eb88f847
fix: updated default content-type and default body format type (#11878)
* fix: updated default content-type and default body format type

* fix: updated the cypress test because the default content-type is changed

* fix: update content type on change of http method and update body format type too

* fix: changed cypress test back to previous
2022-04-12 16:43:11 +05:30
Ankita Kinger
c1e48f7486
feat: Refactor code for SAML integration (#12700)
* Implemented code splitting of some files for SAML integration

* Implemented code splitting of some more files for SAML integration

* updated redirect url component

* fixed an import statement

* fixed a unit test

* updated restart banner tooltip logic

* updated an import statement
2022-04-12 16:20:01 +05:30
Rishabh Rathod
7626d75ccf
fix: remove "Error when determining async func" (#12683)
- Add logs for debugging
2022-04-12 10:02:02 +00:00
Satish Gandham
76d9f2b9fc
chore: use postgres as datasource for performance tests (#12689)
* Use postgres as datasource for the golden app

* - Update DB name

* Remove fake API data source from DSL

* Change the app base url

* Update postgress DB details in DSL

* User dev.appsmith.com for testing instead of localhost

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-04-12 10:01:41 +00:00
Aishwarya-U-R
8f4756c1d1
test: Automated tests for AForce Migration scenarios + Improved TableFilter spec script coverage (#12534)
* Aforce spec- DefaultSearchText added

* Bug 12228 scripted

* Remove text added

* Aforce - Client Side Search added

* Aforce - adding new issue from modal

* Aforce spec - add new issue fixed

* Aforce spec - update/Delete issue added

* Aforce - multi widget selection fix

* aforce spec - multi select fix

* Aforce - multi select fix

* Aforce - multi select fix

* Removing Table_Filter_spec from ignore files

* MemberRoles locator fix

* member roles locator update

* Tablefilter spec fix

* Aforce spec type fix

* Aforce - search spec

* TableFilter spec fix

* Chartdatapoint fixed

* desc update

* Aforce - skipping table search again

* Removed duplicate spec

* GetNClick improved

* BindTable_api spec fix

* AForce spec fix

* CHartdatapoint spec fixed

* JSObjToListwidget spec fix

* OnPageLoad spec fix

* updates

* TableFilter.ts added

* TableFilter added more scenarios

* TableFilter added more scenarios

* Table_spec failure fix

* TableFilter spec - scenarios added

* AForce Filter case added

* AForce fix

* Aforce filter fix

* Aforce fix

* SelectFromMultiSelect added fix

* Picking msg from message.ts file

* Aforce spec - Added wait

* Aforce - filter spec fix

* JSONload messages update
2022-04-12 15:31:22 +05:30
Tolulope Adetula
89fcc414e3
fix: remove internalKeys from Selected row and Triggered row (#12655) 2022-04-12 10:01:03 +00:00
Trisha Anand
85ebed6d5e
Merge branch 'master' into release 2022-04-12 14:06:53 +05:30
haojin111
c32ca69a91
fix: 12456, 12420, 12422 on reconnect modal issues (#12569)
* fixed-12456 gsheet auth issue

* fixed - 12420 save button functionality failed

* fixed - 12422 datasource selection issue

* fixed issue of gsheet authentication

* fixed comments point

* fixed 12511: typo issue

* fixed cypress test import and export
2022-04-11 23:00:29 +05:30