Commit Graph

18414 Commits

Author SHA1 Message Date
Anagh Hegde
95537e0470
ci: add configs for release to pg sync (#35914)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Workflow Improvements**
- Enhanced GitHub Actions workflow for syncing releases, improving Git
operations and conflict management.
- Introduced a step to set Git configuration for better commit
attribution.
- Added a new step to specify the Node.js version for consistent
environment setup.
- Simplified the merging process with a new `git merge` command that
accommodates unrelated histories.
- Adjusted conflict handling strategy, emphasizing manual intervention
when conflicts occur.
	- Updated Slack notification message formatting for clarity.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Tests have not run on the HEAD
f30933c3d2da9b90ed631f89fc270834505a3873 yet
> <hr>Tue, 03 Sep 2024 04:18:19 UTC
<!-- end of auto-generated comment: Cypress test results  -->
2024-09-04 11:23:58 +05:30
Nidhi
5bed1fcf83
chore: Enable netty metrics (#36104) 2024-09-04 09:59:19 +05:30
Ayush Pahwa
72d18157d2
feat: disable create js object option in workflows editor (#36094)
## Description

Workflows is not currently supporting multiple js objects. Hence, we
need to disable the option for the workflows editor.

EE branch: https://github.com/appsmithorg/appsmith-ee/pull/5027

Fixes #32239 

## Automation

/test js

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10686636668>
> Commit: 5cb101fca88fad7d8ddba64ccec99b76fd49674b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10686636668&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Tue, 03 Sep 2024 16:45:16 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced logic for creating new JavaScript objects, preventing
unnecessary additions in the workflow editor.
- Introduced a function to determine if creating a new JavaScript object
is allowed, improving user experience in the workflow editor.
- Improved responsiveness of the Files component based on the parent
entity type, allowing for context-sensitive behavior.

- **Bug Fixes**
- Addressed limitations in workflow runner support for multiple
JavaScript objects.

- **Refactor**
- Simplified the `onCreate` function's dependencies for improved clarity
and functionality.
  
- **Tests**
- Added new test cases to validate the behavior of JavaScript object
creation options based on user settings.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-04 09:07:09 +05:30
Sagar Khalasi
6ad6a114c3
chore: Added pg branch (#36086)
## Description
Run the CI test limit in PG branch


Fixes #`36085`  


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10683137823>
> Commit: 288bb1aa7f920c67ccb7755bdea8292c8bc17fbc
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10683137823&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 03 Sep 2024 13:03:06 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new output variable `is-pg-build` to enhance build
handling based on pull request base branches.
- Improved workflow logic to conditionally manage builds depending on
the pull request context.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-03 18:39:47 +05:30
pewpewXD
f02b448ded
fix: width of tooltip box is larger than text on the property panel (#35734) 2024-09-03 12:28:06 +05:30
Nilansh Bansal
4516129908
fix: postgres plugin blocking call (#36046)
## Description
This PR resolves the blockhound callout `Blocking call!
java.io.FileInputStream#readBytes` in the /v1/actions/execute (POST) API
call when used with Postgres Plugin.
This blocking call was present in the PostgresPlugin.java

Fixes #36008   

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/10666128697>
> Commit: 9224297c20722ebd5b2891e9e2f306f75e78ed1b
> Workflow: `PR Automation test suite`
> Tags: `@tag.Sanity`
> Spec: ``
> <hr>Mon, 02 Sep 2024 11:19:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Chores**
- Improved the readability and conciseness of the connection pool
creation logic in the Postgres plugin, enhancing maintainability without
affecting functionality.
- Updated logging level from debug to info for better clarity on log
messages.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-09-02 11:45:28 +00:00
Ilia
bd8c0de7b9
feat: add select widget (#35849)
## Description


https://github.com/user-attachments/assets/7516bcd8-7746-485a-a49d-bd19b22833d0




Fixes #35824

> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10663955895>
> Commit: 58d40f7826f125778734f5fda93499e3b78dfcfa
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10663955895&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 02 Sep 2024 10:15:26 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced the `WDSSelectWidget`, enhancing widget options within the
application.
- Added configuration files to support autocomplete, validation, and
property management for the new select widget.
- Added new icons and thumbnails for input fields, improving UI
component availability.

- **Improvements**
  - Streamlined the `Select` component for better usability and clarity.
- Enhanced type definitions for better type safety and clarity in widget
configuration.
- Improved SVG structures for icons and thumbnails, enhancing visual
representation.
- Adjusted styles for the `Select` component, ensuring consistent sizing
and improved icon alignment.

- **Documentation**
- Added central export for configuration modules, simplifying access to
widget settings.
- Updated stories to include new icons and thumbnails, enriching
documentation resources.

- **Bug Fixes**
- Improved validation logic for default options and custom options to
ensure data integrity.

- **Chores**
- Reorganized import statements for better readability and
maintainability across widget files.
  - Updated TypeScript configuration for improved module handling.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: vadim <vadim@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-09-02 12:30:23 +02:00
Manish Kumar
e5014139e2
chore: Added threads to logging (#36042) 2024-09-02 12:31:11 +05:30
sneha122
7c932f9ca0
chore: reconnect ds detached from datasource editor part 1 (#35907)
## Description
Datasource modularisation - Take out reconnect datasource dependencies
out of DatasourceEditor (part 1)


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10577633946>
> Commit: 2f06f3462ae073440b62c9cc7f7ab14a0fc0d1c2
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10577633946&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Tue, 27 Aug 2024 12:38:08 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2024-09-02 11:26:34 +05:30
Sagar Khalasi
b3c79f04ec
test: Fix mockdb flaky test case (#35959)
## Description
Fix the flaky test case with latest update.

**Problem :** Whenever the Mock DBs are getting corrupted, we see flaky
behaviours.
As per the solution, we are running reset script every day. We can not
increase the frequency as in a day time lot of testing pipelines are
running it. Most of the time we see failure at two places,
1. Query from Mock Mongo DB
2. Failure in afterEach run.

**Solution:** We need to remove flaky test cases part.
1. For mongo DB case, test till here so we can test connection at least
as mentioned by one of developer.
`dataSources.ValidateNSelectDropdown("Command", "Find document(s)");`.
2. Remove afterEach code as it is actually no required as we use new
setup for each new run.

**Relevant threads:**
1.
https://theappsmith.slack.com/archives/C0134BAVDB4/p1724317643564089?thread_ts=1724216243.067959&cid=C0134BAVDB4
2.
https://theappsmith.slack.com/archives/C02GAUE9P5H/p1712038530288709?thread_ts=1712020398.128169&cid=C02GAUE9P5H

Fixes #`35136`  


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10633737589>
> Commit: 660b710bde7ca5c2d3998d86ce15753ac7c4c2bf
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10633737589&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 30 Aug 2024 14:07:14 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Streamlined test cases for mock database validations, improving
performance and efficiency.
- Removed unnecessary cleanup operations post-test execution,
simplifying the testing process.

- **Chores**
- Updated the test specification path to prioritize sanity testing of
mock databases over regression testing.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 22:26:30 +05:30
NandanAnantharamu
bdeeea5c77
test: fix inline editing spec (#35986)
RCA:
Toggle state of the property was going to wrong state, hence with retry
test was passing as it would bring back the application to required
statee.

Solution:
Updated toggle state in the flaky test to avoid this issue

EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4997

/ok-to-test tags="@tag.Sanity"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10633979760>
> Commit: b63e5716203e0865ad493b1bc0ab8e952aaa7301
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10633979760&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 30 Aug 2024 14:27:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced inline editing functionality for table widgets, improving
interaction and validation in tests.

- **Bug Fixes**
- Updated limited tests configuration to prioritize inline editing tests
over previous specifications.

- **Tests**
- Improved test coverage for inline editing by adding interactions with
dropdowns and property state toggling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 20:05:41 +05:30
Abhijeet
bf5d73a020
chore: Add admin email for installation complete event even if the user opt out of product updates (#35980)
## Description
PR to add admin email and domain hash if the user opts out of product
updates and track subscription in a separate variable.

Fixes https://github.com/appsmithorg/appsmith/issues/35658

/test Sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10613084027>
> Commit: 08ad5157d76f8ced94cc40fdf65f1a94c1697300
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10613084027&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 29 Aug 2024 10:33:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved handling of user information during the newsletter sign-up
process, ensuring that user email and name are always captured for
analytics.
- **Bug Fixes**
- Removed conditional logic that previously set user email and name to
empty strings if the newsletter was not opted into, enhancing data
accuracy.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 18:54:19 +05:30
Hetu Nandu
e69ca8915e
fix: Intercom setting anonymous user a common user id (#36017)
## Description

Avoids setting the `user_id` field in intercom when the user is not
logged in

Fixes https://github.com/appsmithorg/appsmith-ee/issues/5003


## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/10631847104>
> Commit: 1eaad316f8da84f0e99b92842f1dddc177d252c5
> Workflow: `PR Automation test suite`
> Tags: `@tag.Sanity`
> Spec: ``
> <hr>Fri, 30 Aug 2024 11:26:34 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced user information handling for improved privacy in the
application.
- Anonymous users will no longer have their usernames processed,
ensuring greater data protection.

- **Bug Fixes**
- Refined logic for extracting user information to prevent exposure of
sensitive data.

- **Documentation**
- Updated comments and documentation to reflect changes in user data
handling and privacy measures.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 11:52:07 +00:00
albinAppsmith
a9ca63c225
fix: Action redesign/remove container query (#36014)
## Description

PR addresses below issues,
1. Query was not scrollable when code editor field dynamically increase
height. This was caused by the container property in Section. Container
will ignore absolute positioned elements dynamic heights.
2. Fixed code editor field min-width while resizing
3. Fixed ads select feild min-width while resizing.

Fixes #36000
Fixes #35901

## Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10631460963>
> Commit: 9d9fe7691113f36ecf4172972ae31a69c059a8f4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10631460963&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.IDE`
> Spec:
> <hr>Fri, 30 Aug 2024 11:24:13 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced styling for the dynamic text field control, improving visual
consistency.
- Introduced a flexible grid layout for better responsiveness across
different screen sizes.

- **Bug Fixes**
- Addressed layout issues with minimum width adjustments for dynamic
text fields and advertisement selectors.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 17:06:30 +05:30
Ashit Rath
827f22e487
perf: JSONForm infinite re-rendering when field validation is set (#35994)
## Description
The setError function updates the state and the effect is also dependant
on the state which triggers re-render. This is a classic case of
re-rendering due to self state dependency and is fixed with a check if
the error is present for a particular field then it doesn't need to set
again

Fixes https://github.com/appsmithorg/appsmith/issues/35995

## Automation

/ok-to-test tags="@tag.JSONForm"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10627924838>
> Commit: 1d5dec675abd788931aab462832455fbce250df3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10627924838&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JSONForm`
> Spec:
> <hr>Fri, 30 Aug 2024 06:50:40 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced error handling logic in the form validation process to
improve efficiency and correctness.
  
- **Tests**
- Added a new test case to validate the behavior of the form validation
hook when encountering invalid field states.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 16:44:55 +05:30
Jacques Ikot
826a33aa9c
fix: Prevent Errors in Debugger When Deleting List Widget (#35820)
## Description
**Problem**
When deleting a List widget in the EE environment, the widget is
successfully removed, but errors are displayed in the in-app debugger.
These errors disappear upon refreshing the page, leaving users confused
as to why the errors appeared in the first place, despite the widget
being deleted correctly.

**Root Cause**
- The issue arises from the sequence in which widgets and their
associated meta widgets are deleted.

- When deleting a widget with meta widgets (e.g., a List widget):

  - The main widget is removed first via the deleteWidget saga.

- Meta widgets are then deleted later during the componentWillUnmount
lifecycle method.

- The lint evaluation runs between these two processes, detecting meta
widgets still present in the state without a parent widget.

- This mismatch triggers errors in the in-app debugger, which disappear
once the page is refreshed, as the meta widgets have already been
deleted by then.

**Solution**
- We have modified the deletion process to ensure that both the main
widget and its associated meta widgets are removed within the same
action.

- Instead of handling meta widget deletion in the general deleteSaga:

- We now check for widgets with the hasMetaWidgets flag within the
deleteWidget saga.

- If such widgets are found, their meta widgets are deleted before the
main widget is removed from the layout.

- This adjustment ensures that the lint evaluation occurs after both the
main widget and its meta widgets have been removed, preventing errors in
the debugger.


Fixes #35628

## Automation

/ok-to-test tags="@tag.Widget, @tag.List, @tag.IDE, @tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10629216245>
> Commit: 56a4c85076d574cc2ebfef12d3b9f998ee1a4ece
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10629216245&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.List, @tag.IDE, @tag.Sanity`
> Spec:
> <hr>Fri, 30 Aug 2024 09:25:02 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced testing for the list widget to include verification of the
drag, drop, and delete functionalities.
- Improved widget deletion process by ensuring related meta widgets are
also addressed during deletion.
- Updated test descriptions for better clarity and scope, specifically
focusing on deletion functionality.
- Introduced a factory for creating instances of version 2 list widgets,
streamlining widget generation.

- **Bug Fixes**
- Expanded test coverage for potential issues in widget behavior,
particularly concerning deletion.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 10:38:19 +01:00
Manish Kumar
4b89c1c7a7
chore: stability pr for changes (#35911)
## Description
- Changes to put blocking calls on the bounded elastic thread.
- This Pr has changes to test.
- commit
- Status
- branch
- delete branch
- List branch 
- checkout
- checkout remote
- merge status
- merge

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved performance and responsiveness when saving applications to
Git repositories by optimizing the execution flow.
- Enhanced clarity and control in the application push process to Git,
ensuring better maintainability.

- **Bug Fixes**
- Addressed potential threading issues by ensuring operations run on the
appropriate scheduler.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 07:29:15 +00:00
Nilansh Bansal
abce472fdf
chore: removed value from actionExecutionRequestParamsValueMap (#35989)
## Description
> This PR removes the `value` data from the
`actionExecutionRequestParamsValueMap` field as it contains user data.
It also adds the `actionExecutionRequestParamsValueMap` now for all
types of users since the private data is not captured.
Fixes #35904

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10620985550>
> Commit: 92640e13cd5f3486131ea34754ce5634ca5b8fc0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10620985550&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 29 Aug 2024 19:17:16 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced data privacy by consistently redacting sensitive
user-submitted data in analytics events.
- **Bug Fixes**
- Removed conditional logic that previously limited parameter inclusion
based on hosting environment, ensuring all necessary data is sent
without sensitive information.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-30 11:25:30 +05:30
NandanAnantharamu
67de8c1a19
test: updated tests for checkboxgroup (#35945)
RCA:
Test was failing after removing retry, the issue was it was clicking on
a checkbox which was not required.
the retry actually was bringing back the system to right state by
clicking again.

Solution:
We removed the step that was unnecessary in this case which resolved the
issue
EE: https://github.com/appsmithorg/appsmith-ee/pull/4992

/ok-to-test tags="@tag.Sanity"

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10616697878>
> Commit: e599c6d0149814c38049aaba7828465361d8f43b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10616697878&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 29 Aug 2024 14:33:59 UTC
<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: karthik <thinkify@karthiks-MacBook-Pro.local>
2024-08-29 22:55:33 +05:30
subratadeypappu
83326ef10d
chore: optimise pages API in view mode (#35915)
## Description
This PR addresses issue
https://github.com/appsmithorg/appsmith/issues/35881 by optimizing the
pages API specifically for view mode. The primary goal is to enhance the
performance and efficiency of the API, ensuring a smoother and faster
user experience when viewing pages. The changes involve refactoring
existing methods, introducing new ones, and updating test cases to align
with the new functionality.

TL;DR
It includes the following changes
- Addition of projection for the query that fetches pages by
applicationId in view mode
- Removal of sorting workspaces and their resources in view mode




Fixes https://github.com/appsmithorg/appsmith/issues/35881

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10610633615>
> Commit: 696b7787c0f72cc756122ee18620b0e14bfc6f4c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10610633615&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 29 Aug 2024 08:52:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced a method to retrieve new pages by application ID with
customizable field inclusion.
- Enhanced data retrieval capabilities with more granular control over
returned fields.
  - Added project-specific data handling in page retrieval logic.

- **Bug Fixes**
- Improved logic for handling view mode in page retrieval based on
application mode.

- **Documentation**
- Updated tests to reflect changes in published page visibility,
ensuring accurate assertions.

- **Refactor**
- Streamlined methods for creating application pages and improved
control flow for data retrieval.

- **Tests**
- Enhanced asynchronous behavior in test methods for better execution
control.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-29 16:13:21 +06:00
Anna Hariprasad
f3374bd5fd
feat: Added SSH Tunnel for Postgres (#35449)
@appsmithorg/contributor-support

Hi @rohan-arthur 

Fixes #30792 

[**Video
Demonstration**](https://drive.google.com/file/d/1IOGlTsPVgeBNOpq3vydO01lrcN10S8ZS/view?usp=sharing)

**What's in this pr :**

- Added connection mode option for SSH Tunnel.
- Added SSH Host, Port, SSH Username and SSH key fields.
- Added Validation logic for SSH fields.
- Added SSH connection logic.
- Added three test cases for SSH connection.

**Screenshots :**

![image](https://github.com/user-attachments/assets/8332a0f7-f184-401d-acea-b46aa07fe759)

![image](https://github.com/user-attachments/assets/37f8b372-5532-4133-8e3e-f41d5ad6e91f)

![image](https://github.com/user-attachments/assets/eee5a119-70e5-4ddb-bf13-8316ab9b160b)

![image](https://github.com/user-attachments/assets/a3cb0d12-9255-4b2e-b2c8-00c98227ca39)

![image](https://github.com/user-attachments/assets/6acd9b7f-f16e-48e4-8dfc-996ef62d2262)

Please review this pr. Let me know if any changes required.





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced SSH tunneling support for PostgreSQL connections, allowing
users to configure SSH settings for enhanced security.
- Added a new "Connection method" option in the configuration, enabling
selection between "Standard" and "SSH tunnel" connections, with relevant
fields for SSH details.

- **Bug Fixes**
- Improved error handling by adding specific error messages for missing
SSH configuration parameters, providing clearer feedback to users.
- Updated error messages for authentication issues to include missing
passwords.

- **Tests**
- Enhanced test coverage with new unit tests for validating the
configuration of PostgreSQL data sources, particularly for SSH
connections.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-29 11:09:08 +01:00
Naveen Goud
ff0c6138d5
feat: added the code to sort the collection in the proper order. (#35413)
**Description:**
The collection dropdown in MongoDB query editor isn't sorted, typing to
filter doesn't work, and hitting a key like u doesn't scroll to the next
item starting with you.

fixes: [28190](https://github.com/appsmithorg/appsmith/issues/28190)

**Updated in PR:**
1.Added the sort code to the collection after Api trgger.
2.Added the test case for this scenario.

**snap shots:**
![Screenshot from 2024-08-05
16-07-18](https://github.com/user-attachments/assets/8c75866f-c843-455e-80e0-1cb6d4e893ce)
![Screenshot from 2024-08-05
16-22-29](https://github.com/user-attachments/assets/4452f99d-2b6e-42aa-82b3-38bc256af216)




<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced the output structure of the datasource trigger, providing a
clearer representation of entities with labels and values.
- Implemented case-insensitive sorting for the returned collections,
improving data usability.

- **Tests**
- Added a new test to validate the ordering of collections returned by
the datasource trigger, ensuring data integrity and expected behavior.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-29 11:04:58 +01:00
Manish Kumar
a36b45de60
chore: complimentary pr for CD migration changes (#35876)
## Description

> CE changes for CD migration on EE pr:
https://github.com/appsmithorg/appsmith-ee/pull/4927

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10599263403>
> Commit: ef94bff3b0d12db1a5003a78ce8ddfeabbb3c87d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10599263403&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Wed, 28 Aug 2024 15:23:46 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a new field for tracking the continuous deployment
migration version in application metadata.
- Enhanced Git artifact management with additional metadata for improved
deployment processes.

- **Bug Fixes**
- Resolved issues related to application versioning and deployment
tracking.

- **Refactor**
- Substantial restructuring of the Application class for improved
maintainability and extensibility.
- Simplified structure of GitArtifactMetadata, enhancing functionality
and clarity.
  
- **Tests**
- Expanded equality tests for new entities related to the Application
class, ensuring proper validation of equality logic.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-29 15:01:51 +05:30
Zachary Zondlo
db3f35691d
Add a diagnostic script to assist in the debugging of issues with appsmith implementation (#35640)
## Description
A script to gather logs and system info into a tarball which can be
extracted and analyzed by appsmith engineers.


Fixes #35639 #32971

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Tests have not run on the HEAD
4f8e27cd8bcef9233786f268f95e0b3e981c13d6 yet
> <hr>Tue, 27 Aug 2024 14:01:33 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced a new diagnostic tool to gather system and application
metrics for improved troubleshooting and performance monitoring in the
Appsmith environment.
- The tool collects logs, configuration files, JVM properties, and
system-level information, compressing the data for easier transport.

- **Chores**
- Added a script for efficient collection and organization of diagnostic
data, enhancing operational capabilities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-29 14:06:30 +05:30
Vemparala Surya Vamsi
7cdee526c9
chore: adding telemetry for klona (#35918)
## Description
Klona operations are generally expensive, for that reason we will be
tracking the performance of all klonas in the main thread.

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10608431935>
> Commit: cab2716f74f3747d3df64342f4d7f4972358a3e6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10608431935&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 29 Aug 2024 06:26:43 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **New Features**
- Introduced telemetry tracking for cloning operations across various
components, enhancing performance monitoring and debugging capabilities.

- **Bug Fixes**
- Improved observability of cloning operations, aiding in identifying
potential performance bottlenecks.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-29 12:35:48 +05:30
Rahul Barwal
3526696494
test: fix flaky binary spec (#35861)
## Description
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4954

This spec relied on retries and was asserting on wrong table cols

Fixes #35877  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10594838499>
> Commit: 93d0502c49b6e6b714236b8ea693f5ade0eacdb5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10594838499&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 28 Aug 2024 10:48:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Removed a previously skipped test for inserting binary type records to
ensure accurate functionality checks.
  
- **Refactor**
- Improved readability and maintainability of test cases by replacing
hardcoded row indices with dynamic variables.
- Cleaned up the test suite by removing commented-out code and adjusting
sleep durations.

- **Documentation**
- Updated assertions to reflect changes in expected values and the
sequence of operations in the tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-29 10:08:45 +05:30
Aman Agarwal
09f608d14b
fix: mysql2 spec flakiness (#35950) 2024-08-28 19:16:12 +05:30
Aman Agarwal
d79bad4e27
fix: API multipart spec flakiness (#35927) 2024-08-28 17:47:44 +05:30
Anna Hariprasad
5ddf6e6977
feat: remove-clear-option-for-required-select-widget (#35060)
Hi @rohan-arthur, @somangshu , @contributor-support 

**Fixes** #34262 

**What's in this pr :**

- Added isRequired prop for select widget components to control the
logic for the remove button.
- Added two test cases to verify clear button rendering when isRequired
is set to true and false.

**Screenshots :**

![image](https://github.com/user-attachments/assets/4c276add-f28e-4060-8f44-a957dc48f673)

![image](https://github.com/user-attachments/assets/02138d93-e4c1-4e67-97df-0703398c440b)

![image](https://github.com/user-attachments/assets/8eb8ec6f-9124-4a61-9df4-448338086714)

Please let me know if any changes are required.

Thank you.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced an `isRequired` property to the `SelectButton`,
`SelectComponent`, and `SelectWidget`, allowing users to indicate
whether a selection is mandatory.
- Enhanced rendering logic in the `SelectButton` to conditionally
display the cancel button based on the `isRequired` state.
- Improved styling and behavior options in `SelectComponent` for better
integration into forms.

- **Tests**
- Added new test cases for the `SelectButton` to ensure correct
rendering behavior of the cancel button based on the `isRequired` prop.
- Streamlined Cypress tests to focus on the non-existence of the clear
button, reflecting updated component behavior.
- Updated locator configurations to improve test coverage for user
interactions involving clearing selections.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-28 16:03:16 +05:30
Sagar Khalasi
4885337fd9
ci: Only command name update (#35926)
## Description
Only command name update


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10592127455>
> Commit: 1e1fb070a89908cd6bf78d0ba966d04305632f51
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10592127455&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 28 Aug 2024 07:44:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Improvements**
- Updated the CI workflow to utilize an enhanced version of Cypress for
running tests, potentially offering improved functionality and
performance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-28 13:14:58 +05:30
Sagar Khalasi
d0e5085e2d
ci: Added code for PR comment results with repeat command (#35921)
## Description
**Challenge**: In our existing process, when users performed a limited
run with a specified count, the results were recorded solely in the
logs. This approach introduced an additional step, requiring users to
manually navigate through each workflow to check the results, which was
both time-consuming and prone to oversight.

**Solution**: To address this inefficiency, I took the initiative to
develop a custom npm library specifically designed to enhance the user
experience. This library automates the generation of a summary file that
consolidates the run data into a single, easily accessible document.
Furthermore, I integrated this solution into our existing workflow by
updating the process to automatically post the contents of this summary
file as a comment on the relevant PR upon completion of the run.

This improvement not only streamlines the workflow by eliminating the
need for users to manually sift through logs, but it also ensures that
critical information is immediately available at a glance. By
centralizing the results in the PR comments, we’ve enhanced transparency
and efficiency, allowing for quicker decision-making and more effective
collaboration. This solution is a step forward in optimizing our
processes and reducing the manual effort required to track and assess
test outcomes.

**Looks like this:**

<img width="993" alt="Screenshot 2024-08-28 at 11 06 37 AM"
src="https://github.com/user-attachments/assets/91a5966e-fef6-47b8-9fd8-9186012f2ab3">


Fixes #`35920`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10590991034>
> Commit: ef6ef69fb812ba43abba5d9d273623a914569c81
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10590991034&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 28 Aug 2024 06:19:47 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a summary of Cypress test results in pull request comments
for improved visibility.
- Added functionality to upload Cypress summary logs, ensuring
availability regardless of previous test outcomes.

- **Dependency Updates**
- Updated the testing package from `cypress-repeat-updated` to
`cypress-repeat-pro`, potentially enhancing testing capabilities.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-28 11:52:37 +05:30
NandanAnantharamu
eec7b74c35
test: common code change for Workflow tests (#35886)
/ok-to-test tags="@tag.All"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10589609542>
> Commit: 27a55649d9f3cb398053fd68bfcecbbc96f6a694
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10589609542&attempt=3"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Wed, 28 Aug 2024 05:53:34 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced user interface functionality by ensuring the application
waits for the button spinner to disappear before proceeding with
visibility assertions and onboarding.
  
- **Improvements**
- Improved user experience by reducing potential inconsistencies or
errors during the onboarding process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: NandanAnantharamu <nandan@normalyze.ai>
2024-08-28 11:40:24 +05:30
yatinappsmith
c567b13e64
Merge pull request #35909 from appsmithorg/conflict/ads/editor-text
fix: text editor sub component conflict
2024-08-28 10:37:45 +05:30
sneha122
9da8c4962f
chore: removed sanitise action functionality from actions span (#35884)
## Description
This PR improves performance of actions in consolidated view API by:
1. Removing `sanitiseAction` method that was getting called after
fetching actions from DB
2. Moving the publishedAction filtering to the DB layer

Reasoning:
`sanitiseAction` was added earlier in the
[PR](https://github.com/appsmithorg/appsmith/pull/13263/files) because
of the [issue](https://github.com/appsmithorg/appsmith/issues/11927).
The issue mentioned for some reason JSObject actions were getting
corrupted and causing it to lose pluginId and pluginType values, since
we did not know as to why the JsObject actions were going in bad state,
we added a bandaid fix which would add pluginId and pluginType if these
actions did not have them.

RCA for above issue can be found here:
https://www.notion.so/appsmith/Data-inconsistencies-w-r-t-JS-Objects-c58f124fe20e4415b5c0e180b423b0be

For our consolidated view api -> actions span, we do not need JSObject
actions, we only need DB actions and APIs. Since we are not fetching
JSObject actions from DB, sanitisation won't be required.

As for the second part, where filtering is moved to DB layer. Earlier we
used to fetch all actions from DB and on server we would check if the
viewMode is true, then filter out published actions. This filtering has
now been moved to DB layer to avoid any further operations on service
layer.


Fixes #35857 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10573445222>
> Commit: 2e4f36d7d6cd829584ed41b279a0399810a59228
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10573445222&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Tue, 27 Aug 2024 10:26:49 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced action retrieval to focus exclusively on published actions,
improving clarity and performance.

- **Bug Fixes**
- Removed unnecessary filtering conditions, broadening the set of
actions available in view mode.

- **Refactor**
- Renamed methods for better alignment with their purpose, specifically
around fetching published actions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2024-08-27 19:26:03 +05:30
albinAppsmith
9d9524c5bc Merge branch 'master' of https://github.com/appsmithorg/appsmith into conflict/ads/editor-text 2024-08-27 17:47:32 +05:30
Naveen Goud
cbd7ccc4ec
fix: updated the regex expression to correctly identify the table nam… (#35361)
**Description**

When the user tries to add a postgres datasource and add any query, if
the table name has hyphens in it, then quotes get assigned to first word
after the schema and the dot. For example, public."counter"-with-db
The quotes should be applied to the whole table name. For example:
public."counter-with-db"

Fixes https://github.com/appsmithorg/appsmith/issues/10631
Fixes https://github.com/appsmithorg/appsmith/issues/30692

**changes in PR:**

1.updated the regec expression to idetify the table name properly with
table name consists of hypens.

2.added a test case for this scenario.

**snapshots:**
before:

![Screenshot from 2024-07-30
17-15-27](https://github.com/user-attachments/assets/98f969da-4cf1-4367-be29-1f3465179a9d)

After:

![Screenshot from 2024-08-01
10-46-53](https://github.com/user-attachments/assets/29411eb7-77af-4a10-9988-a0c076043945)


Hi @ajinkyakulkarni @rohan-arthur @Nikhil-Nandagopal ,Please review this
PR.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Enhanced handling of table names in the Postgres plugin to support a
wider variety of characters, including hyphens and special characters.
- Introduced multiple new database tables for improved testing coverage.

- **Bug Fixes**
- Adjusted table name processing to correctly format names containing a
broader range of characters.

- **Tests**
- Added new tests to verify the structure and integrity of tables with
various naming conventions.
	- Expanded existing tests to accommodate additional table structures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 16:21:12 +05:30
Anagh Hegde
7053632d74
ci: merge release to pg (#35905) 2024-08-27 16:05:12 +05:30
Anagh Hegde
84fbdde5c1
ci: use git merge for syncing changes from release (#35902)
## Description
git merge over cherry-pick with loop by comparing head. 

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Tests have not run on the HEAD
087dfe23f63ea4e4dc472c1c048009086976f3d1 yet
> <hr>Tue, 27 Aug 2024 10:22:10 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Streamlined workflow for synchronizing releases to the `pg` branch,
enhancing efficiency.
- Directly merges the `release` branch into the `pg` branch, simplifying
the process.
- **Bug Fixes**
- Improved handling of merge conflicts with clearer notifications and
tracking.
- **Chores**
- Refined the conditions for pushing changes, ensuring operations only
occur on successful merges.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 15:53:29 +05:30
Ankita Kinger
5aef087000
Revert "feat: Action redesign: Updating Mongo plugin form config" (#35903)
Reverts appsmithorg/appsmith#35883

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced user-friendly configurations for various MongoDB
operations, including "AGGREGATE," "COUNT," "DELETE," "DISTINCT,"
"FIND," "INSERT," "RAW," and "UPDATE."
- Enhanced dynamic dropdowns for selecting collections and streamlined
input sections for constructing queries.

- **Bug Fixes**
- Simplified the structure of the input text controls for better
usability and responsiveness in UI design.

- **Refactor**
- Cleaned up unnecessary elements in the codebase to improve
maintainability and performance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 15:48:46 +05:30
yatinappsmith
cfab57f5be
ci: Enable Cypress run for master based branches (#35897)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Expanded automation capabilities by allowing the CI/CD workflow to
trigger on pull requests targeting the `master` branch, in addition to
the existing `release` and `pg` branches.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 13:19:19 +05:30
Anagh Hegde
74685e359c
ci: update logic for handling the merge commits (#35898)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2024-08-27 13:11:50 +05:30
Sagar Khalasi
5b33768e4c
ci: Updated server logs in CI (#35896)
## Description
Adding server logs


Fixes #`35895`  

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced CI workflow with new steps for collecting and uploading
Docker logs to improve debugging capabilities during failures.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 12:33:20 +05:30
Jacques Ikot
9f387d5763
fix: Correct Select Widget Mapping for Dynamic Label and Value Keys (#35862)
## Description
**Problem**
When the Select widget's labelKey or valueKey properties are switched to
JS mode, passing a function that returns a string as the key causes the
dropdown options to break. Instead of correctly mapping the labels and
values, the options are incorrectly returned as an array of the key
itself.

**Root Cause**
The issue lies in the `getOptions` function in derived.js. The logic
that computes the select options based on the labelKey and valueKey was
not handling cases where these properties are functions that return
arrays. Instead of mapping through the source data and returning the
corresponding values for each key, the function was mistakenly returning
the entire array.

**Solution**
The `getOptions` function in derived.js has been updated to correctly
handle cases where labelKey or valueKey are arrays. The function now
maps through the sourceData and computes the correct labels and values
based on the provided properties, ensuring that the dropdown options are
displayed as expected.



Fixes #35269

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Select, @tag.Widget, @tag.Binding"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10560970428>
> Commit: 118badee07c47fe72f727f8ab248c29685f6f7a1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10560970428&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Select, @tag.Widget, @tag.Binding`
> Spec:
> <hr>Mon, 26 Aug 2024 15:24:26 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced test coverage for the Select widget by adding new test cases
to validate the correct functioning of JavaScript functions in the label
and value keys.
- Improved processing of `optionLabel` and `optionValue` properties for
the Select widget, ensuring accurate mapping to `sourceData`.
- Introduced a new helper function to streamline the validation of label
and value keys in the Select widget tests.

- **Bug Fixes**
- Corrected the handling of multiple options in the Select widget to
enhance data mapping accuracy and functionality.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 07:54:44 +01:00
Anagh Hegde
55330df6d6
ci: sync release changes to pg (#35893)
## Description
Change the boolean flag for the ci job to capture success or failure

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10572876956>
> Commit: 4f3986f053850edb0298934b6f59c398a8708416
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10572876956&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 27 Aug 2024 06:45:49 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced notification system for GitHub Actions to alert on any job
failures, improving awareness of issues during workflows.
- **Refactor**
- Modified conditions in the workflow to broaden the criteria for
triggering notifications, ensuring timely alerts for various failure
scenarios.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 12:18:33 +05:30
Pawan Kumar
68e1bcf9fa
chore: Input morphing (#35845)
/ok-to-test tags="@tag.Widget"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
	- Added new input widgets: Email, Password, Number, and Multiline.
	- Enhanced configuration options for phone and currency inputs.

- **Bug Fixes**
- Improved type handling for input properties, ensuring better
validation and reliability.

- **Documentation**
- Updated widget exports for better modularity and usage across the
application.

- **Chores**
- Introduced new constants to support the latest input widget types in
the application.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10572140876>
> Commit: a5c4b41eb615a6c655439f977fc0442cf0e0a237
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10572140876&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget`
> Spec:
> <hr>Tue, 27 Aug 2024 06:28:05 UTC
<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-08-27 12:15:45 +05:30
Anagh Hegde
c79b62e536
ci: sync release to pg branch (#35888)
## Description
This CI job is responsible for syncing changes from the release branch
to the pg branch. This happens for every commit merged to release
branch, similar to `Sync Community Workflow`

Fixes #`Issue Number`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10571814611>
> Commit: 9bc44fc0cc762d52854da3b4e2f8c3e995909ccd
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10571814611&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 27 Aug 2024 05:00:52 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced an automated workflow for merging changes from the release
branch to the pg branch, enhancing integration and development
efficiency.
- Added notifications for merge conflicts to improve communication and
resolution tracking.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 11:27:04 +05:30
Ankita Kinger
0a3492ff96
feat: Action redesign: Updating Mongo plugin form config (#35883)
## Description

This PR updates the form config for Mongo plugin to accommodate new
SECTION_V2, SINGLE_COLUMN_ZONE, and DOUBLE_COLUMN_ZONE.

Fixes [#35495](https://github.com/appsmithorg/appsmith/issues/35495)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10561281548>
> Commit: b9a3f0f5da3cb2f985a90644356a20f4b3191259
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10561281548&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 26 Aug 2024 15:08:27 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced styling for the dynamic input text control, allowing for
improved appearance and responsiveness.
- Introduced a more versatile layout for the MongoDB plugin editor,
including new control types and expanded command selection options for
database operations.

- **Bug Fixes**
- Adjusted CSS properties for flexible sizing of the dynamic input text
control.

- **Documentation**
- Updated JSON configuration for the MongoDB plugin to reflect new
features and control types for better user guidance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 09:27:03 +05:30
albinAppsmith
81a710ac3f
fix: Pencil icon appearing in application name (#35885)
## Description

PR address below issues
1. Edit icon appearing next to application name
2. No cursor pointer for edit icon

Fixes #35878

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10562542656>
> Commit: 31ab617cdc5c37fa1fce7ecadd08a4250e9d373a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10562542656&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 26 Aug 2024 19:15:19 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the `EditableTextSubComponent` by making the icon interactive
with a cursor pointer style.
- Introduced an optional `hideEditIcon` property for the
`EditableAppNameProps`, allowing for conditional visibility of the edit
icon.
- Updated the `EditorName` component to accept the new `hideEditIcon`
prop for improved customization.

- **Improvements**
- Improved user interface flexibility and customization options for
editing components.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-27 00:45:31 +05:30
Nidhi
64ebe15236
Merge pull request #35879 from appsmithorg/hotfix/edit-icon 2024-08-26 15:05:56 +05:30
Ashit Rath
eda63fe688
chore: JSONform - useRegisterFieldValidity remove unused dependency in useEffect (#35869)
## Description
Removes unused dependency in `useRegisterFieldValidity` of JSONForm

Introduced in https://github.com/appsmithorg/appsmith/pull/35717

## Automation

/ok-to-test tags="@tag.JSONForm"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10554659505>
> Commit: e59355e8484e4dd0707d6c0b7a13b0b96b2b3507
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10554659505&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JSONForm`
> Spec:
> <hr>Mon, 26 Aug 2024 06:45:22 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Performance Improvements**
- Optimized the `useRegisterFieldValidity` function by reducing the
number of dependencies in its `useEffect` hook, potentially enhancing
performance by minimizing unnecessary updates.

- **Bug Fixes**
- Streamlined control flow for error handling within the
`useRegisterFieldValidity` function to ensure consistent behavior when
validating fields and managing errors.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-08-26 14:52:58 +05:30