Commit Graph

8867 Commits

Author SHA1 Message Date
Trisha Anand
12e97835bf
Where clause is also visible now for command Fetch sheet rows for both Query range as well as Query rows sub methods (#7655) 2021-09-21 13:48:30 +05:30
rahulramesha
6cefc6dbea
feat: Undo/Redo (#6654)
* Scaffolding for undo-redo

* undo redo working Poc commit

* memory performance improvements by diffing

* dont run update on undo/redo"

* merging widget postion update and canvas bottom row update into one dsl update.

* fix tabs widget

* Visible updates per undo redo action (#6838)

Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>

* resize atomic operation

* fix switch control state issue

* disallow undo/redo for snipping and comment mode

* disallow undo/redo for snipping and comment mode

* fix color picker issue in undo/redo

* add test for replayDSL

* option control fix, adding logs

* minor position change undo redo updates

* add test cases for replayHelpers

* property Upade visual change

* remove unused code

* global hot key jest test for undo redo

* Fixing batch updates on property change..

* add tests for toggle control in property pane

* unwanted utils.

* add tests for text control

* add tests for deletion

* add tests for dropping a new widget

* adding jest test for replayUtils

* add move widget tests

* add tests for color picker control

* add analytics for undo/redo

* add analytics for undo/redo

* tab addition atomic

* cypress tests for propertyPane, toasts and radiowidget optionControl

* replayDSL end of redo stack fix

* property update changes

* menu option control debounce input

* color picker empty undo fix

* fix cypress tests

* widget add/remove atomic

* revert alternative approach to handle atomic operations

* update replayDSL test

* add some comments

* addressing review comments

* flash color for property pane controls

* Fixing adding of tabs widget as well.

* code review comments.

* merging widget postion update and canvas bottom row update into one dsl update.

* fix ordering of tabs property control

* meta property update canvas min height.

* fixing failed specs.

* Fixing entity explorer update on deleting tab from entity explorer.

* address review comments and minor property update changes

* fixing failing tests

* merge conflicts

* changes to cater widget api.

* fix suggested widget table issue

* draggable list for undo redo

* fix widget name focus

* excluding canvas updates.

* fixing codeEditor update on propertySection collapse

* fixed failing test case

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Rahul R <rahulramesha@Rahuls-MacBook-Pro.local>
Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain>
Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-09-21 13:25:56 +05:30
Shrikant Sharat Kandula
ca30a9cb0b
Fix incorrect tag variable name (#7659) 2021-09-21 13:04:26 +05:30
Apeksha Bhosale
386e788e28
fix: pushing and removing errors from debugger for js object (#7465)
* pushing and removing errors from debugger for js object

* added message part of messages

* changes for linting and errors showing

* added try catch for executing function

* PR comments fixed

* PR comment fixed
2021-09-21 11:32:45 +05:30
Apeksha Bhosale
ffe00cd1a2
fix: widget refactor actions fetch change (#7574)
* widget refactor actions fetch change

* Added test for binding Button with API

Co-authored-by: Apple <nandan@thinkify.io>
2021-09-21 11:32:30 +05:30
Tolulope Adetula
834507866a
fix: tabindex and a11y (#7125)
* fix: Datepicker Keypress and Focus State

* fix: Dropdown Select Focus and Tabbale
2021-09-21 06:49:13 +01:00
Satish Gandham
1423b55f55
Add array and object_array to list widget validation check (#7572)
Co-authored-by: Satish Gandham <satish@appsmith.com>
2021-09-21 10:40:16 +05:30
Shrikant Sharat Kandula
c6c5e4fef3
ci: Add CI workflow for building fat container (#7385)
This commit changes the client test workflow into building the fat container's image, and so builds server and RTS as well, in order to achieve that.
2021-09-21 08:33:22 +05:30
rahulramesha
0b37812b56
feat: resizable modal (#7312)
* dip

* resizable modal full working commit

* resizable modal minor fixes

* code restructuring

* fix canvas small size bugs and add migration to remove modal type

* moving resize modal to modal sagas

* layoutResize and last column width

* fix warning

* setResizible if resizing

* fix incorrect import

* fixing cypress tests

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-09-20 22:36:13 +05:30
Nikhil Nandagopal
b9b5d54745
fix: Property pane updates (#7631)
* Renamed TreeSelect Widget
2021-09-20 20:48:10 +05:30
Aswath K
1cca96c032
fix: Currency input text overlap (#7477)
* Change currency input layout to flex

* fix: styles for normal input

* Increase space b/w icon and text. Add focus color

visual modifications as suggested by Momcilo

* fix: alignment for ISDCodeDropdown

* fix: background color for disabled

* change dropdown focus color as suggested by Momcilo

* remove unwanted conditional height

* makes disabled Numeric input consistent to disabled input
2021-09-20 14:20:46 +00:00
Hetu Nandu
4315e92cf7
Reset widget children by default (#7505) 2021-09-20 18:40:03 +05:30
Nidhi
0fadf83c86
Default type of where conditions converted to array (#7637) 2021-09-20 12:30:31 +00:00
akash-codemonk
9877fe4b05
fix: Switch to the debugger error tab when clicked on the debug button in toast (#7455) 2021-09-20 16:50:22 +05:30
Pranav Kanade
a555ed7a88
fixed the pointer for omnibar (#7629) 2021-09-20 16:24:05 +05:30
Nikhil Nandagopal
87b13eca2d
fix: Widget Property Pane Updates (#7467)
* reverted previous revert

* standardised widget sizes

* Text changes

* changed default input label style to match default text style

* more messaging tweaks

* minor fix

* Removed dot from the text

* minor fix for form widget

* fixed tests

* minor fixes
2021-09-20 16:13:44 +05:30
Trisha Anand
6f1fe51afe fix: Datasource structure command failure for Google Sheets (#7595) 2021-09-20 15:14:58 +05:30
balajisoundar
2dddd07f92
chore: Fix unnecessary scrollbar in entity explorer during onboarding (#7613)
Fixes: #7425
2021-09-20 14:55:37 +05:30
Nayan
1296faef8e
feat: [Feature] Use photo asset id instead of email address for profile picture in comments (#7434)
* -set user photo id when adding a new comment thread

* -update user data when users remove their profile photo

* -updated photo id in comments when user changes or set a profile photo

* -remove photoid from thread, kept it in comment only

* -resized uploaded profile image

* -added test for delete profile photo

* -add test for the comment set user photo

* -check user change event handler is called in delete user photo

* -add test for checking user photo change event is triggered after upload photo

* -fixed tests due to changes

* -make profile pictures thumbnail only

* - used get photo by asset id API to show user photo in comment card
- set cache control header in get asset by id API

* - stop using email address to show user photo
2021-09-20 15:03:39 +06:00
akash-codemonk
1fef96666a
fix: Hide generate page button in integration home screen during onboarding (#7521) 2021-09-20 14:30:36 +05:30
Trisha Anand
0ef0b3c3da
fix: Adding handling for columns with multiple words in name for filtering data in filtering library (#7602)
* Adding handling for columns with multiple words in name

* Maintaining the order of columns by using LinkedHashMap instead of Map

* Incorporating review comments

* Migrating the test from Set to List to assert the order of the columns as well in the response
2021-09-20 08:36:28 +00:00
Tolulope Adetula
3c4ef11df2
fix: radio group widget options (#7313)
* Update RadioGroupComponent.tsx

* fix: radio widget validation

* fix: add test for default param
2021-09-20 00:13:37 -07:00
Shrikant Sharat Kandula
fae8de553d
Add retries when getting page from GitBook (#7611)
GitBook API occasionally throws a 500 when trying to get a page. This makes our whole sync Lambda fail.

This commit adds a retry step, that will wait a second and retry the GitBook API, with retries capped to three, so the Lambda is a little more resilient to random 500s from GitBook API.
2021-09-20 12:34:04 +05:30
balajisoundar
4288b44f2c
chore: Invite user to org form input tab issue (#7603)
Fixes: #6785
2021-09-20 12:19:50 +05:30
balajisoundar
5e88255feb
chore: Miscellaneous signposting issues (#7569)
Fixes: #7223
Fixes: #7225
Fixes: #7228
2021-09-20 12:17:04 +05:30
Nikhil Nandagopal
6ad603a40d
Update config.json 2021-09-20 11:56:03 +05:30
akash-codemonk
a4bfb1b7c0
chore: minor styling fixes for debugger (#7584) 2021-09-20 11:10:59 +05:30
Pranav Kanade
4fa741c06c
fixed alignment for import btn (#7562) 2021-09-20 11:06:54 +05:30
Trisha Anand
240816e01c
feat: Adding "where" clause support for Google Sheets Plugin (#7597)
* Adding UI changes for inputting where conditions

* Working version of filtering! Woot woot!
2021-09-19 17:53:19 +00:00
Trisha Anand
17baadfb84
Adding input type to BSON fields to ensure future client side validations can be added to these fields (#7596) 2021-09-19 15:34:28 +00:00
Trisha Anand
659d7c3866
feat: Where condition helper library using H2 in memory database (#7592) 2021-09-19 20:33:47 +05:30
Trisha Anand
eaa9d783df
fix: Datasource structure command failure for Google Sheets (#7595) 2021-09-19 07:15:08 +00:00
Trisha Anand
98fd6205ff
Fixing NPE error (#7588) 2021-09-18 12:34:57 +05:30
Rishabh Rathod
373f64c9ca
feat: git sync ui update (#7486)
- fix commit & push functionality
- Add Link to docs
- Add user settings toggle

Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com>
2021-09-17 22:28:04 +05:30
Trisha Anand
936f014b3e
feat: Add UQI infrastructure to Mongo Plugin (#7238) 2021-09-17 12:22:22 +00:00
Ayush Pahwa
fdc1510236
feat: JSON view for query & datasource form components (#7534)
* Removed unused var

* Added new type and extra props to enable JSON editing experience
2021-09-17 12:14:04 +00:00
Nayan
624a8d1e9c
fix: on page load actions are disabled after fork app (#7490)
* fix: on page load actions are disabled after fork app
* -fix: change permission check during fetch application in fork app
2021-09-17 17:42:06 +06:00
Tolulope Adetula
582f4a568f
fix: multiselect loading state (#7418) 2021-09-17 04:14:48 -07:00
Tolulope Adetula
f472ec996d
fix: multiselect selectAll design (#7424) 2021-09-17 04:13:09 -07:00
Nayan
28adc4e928
feat: set modified by during create, clone, fork, import app (#7452) 2021-09-17 17:10:08 +06:00
Vinod
0ef0da041b
feat: add copy button to evaluated value (#7159)
* add copy function for evaluated value
2021-09-17 16:32:16 +05:30
Rishabh Saxena
819f0c2753
feat: add git config to user profile settings (#7538) 2021-09-17 16:18:38 +05:30
Vinod
2bd324a5aa
feat: address few bug with linting and improve highlighting (#7287)
* show lint errors as warnings

* add initial code

* adjust editor positions

* update pr comments

* mark jshint errors

* reset changes

* remove unused prop

* fix test errors

* remove unused imports

* dont show warning in the error counter

* show yellow if warning

* remove active error functionality

* update linter to use async functionality

* update linter messages

* update binding positions

* fix evaluate tests

* dont show undefined errors in debugger

* move lint code to separate file

* update testes

* remove unused import

* update tests

* address pr comments

* add comment to explain why

* replace proper regex

* fix undefined message error

* Update styling for warnings

* address position issue in the linter

* Fix failing tests

* Merge 'release' on to  'Feature/linting-errors'

* add console as global object

* address lint issues

* fix requested linting erros for release

* fix breaking issue

* remove unwanted code

* revert unrelated changes

* remove unnecessary file

* add extra libraries to jshint data

* import lodash functions that are used

* update jshint settings

* Fix failing test

* don't show lint errors if there is a parsing issue

* update jshint to latest version
2021-09-17 16:01:45 +05:30
balajisoundar
6baa5c8489
chore: Fix misc minor welcome page issues (#7504)
Fixes: #7503
2021-09-17 15:31:42 +05:30
Tolulope Adetula
15b26f823e
feat: Tree Select widget (#6271)
* feat: Tree Select

* feat: styling multiselect

* fix: selected values

* fix: remove console statement

* fix: popup position

* fix: selection types

* fix: Form validation using TreeSelect

* feat: Add Label to TreeSelect

* fix: styling

* fix: Dropdown search

* fix: Add Entity Definitions

* fix: Entity Definition

* Feat: Add clear icon

* fix: validation

* fix: options validation

* fix: Styling issues

* fix: build error

* Fix: Separate Tree Select widget

* fix: issues and add validation

* fix: Options Validation

* fix: issues with build

* fix: yarn

* fix: changes

* fix

* Fix: select component

* fix: PR issues

* fix: merge conflicts

* fix: issues

* fix: all issues

* test: added test

* fix: failing test
2021-09-17 02:08:35 -07:00
Sumit Kumar
146f536190
fix: fix mysql prepared statement integer and boolean type handling (#6987)
* fix mysql prepared statement integer and boolean type handling
2021-09-17 08:56:12 +00:00
Aswath K
49551987fc
fix: Transparent menu on MenuButton widget (#7268) 2021-09-17 08:55:47 +00:00
Trisha Anand
d33ad461c8 Merge branch 'release'
# Conflicts:
#	app/client/src/sagas/ActionExecution/PromiseActionSaga.ts
2021-09-17 13:58:27 +05:30
Hetu Nandu
01b00198e4
fix: merge conflict (#7567)
* fix: Make js editor get call in view mode accessible to anonymous users

* fix: Fixing the previous page pagination for Firestore (#7374)

The problem was that the pagination was designed & tested with only 2 pages. Firestore has a different function `limitToLast` which solves for previous page pagination commands.

* Fix action error callback crash (#7377)

* fix: allow multiple draggable popper to co-exist (#7323)

* fix: allow multiple draggable popper to co-exist

* added custom data-cy for popper drag handler to fix failing cypress tests

* always assume onSuccess, onError, .then, .catch to be callbacks (#7402)

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
Co-authored-by: ashit-rath <88306433+ashit-rath@users.noreply.github.com>
2021-09-17 13:53:32 +05:30
Pranav Kanade
73b795cb71
fix: layout control not working (#7502)
* fixed layout control problem.

* removed extra padding for multi pointer canvas
2021-09-17 11:07:09 +05:30