Commit Graph

4662 Commits

Author SHA1 Message Date
Keyur Paralkar
22605a341a
fix: added empty stack in sppThemingReducer (#13837) 2022-05-16 13:16:35 +05:30
albinAppsmith
7f241cb98e
feat: Entity explorer pages section resize (#13576)
* * Page container resize changes

* * changed inline style to styled component

* * Added preserve height functionality
2022-05-16 12:09:32 +05:30
Tolulope Adetula
a956ff6d71
Merge pull request #13793 from appsmithorg/fix/select-widget-filtering
fix: Select widget filtering
2022-05-16 05:17:43 +01:00
rahulramesha
6738c969bf
chore: changes to render complete property pane post dragging or resizing (#13141)
* changes to render complete property pane post dragging or resizing

* rework to compensate for expensive render of theming properties
2022-05-15 18:42:07 +05:30
ashit-rath
e44aecfe85
fix: JSONForm missing theming accent color property and few JS enabled controls not access sourceData/formData properties (#13817)
* fix: JSONForm missing theming accent color property and few JS enabled inaccessible sourceData/formData properties

* reverted adding of customJSControl JSON_FORM_COMPUTE_VALUE for exisiting properties

* minor revert

* minor fix
2022-05-13 19:53:23 +05:30
akash-codemonk
e1045b1bc3
chore: add autofocus prop to TagInputComponent (#13578) 2022-05-13 17:34:08 +05:30
Keyur Paralkar
a5f426d02b
fix: theme property pane reset on hover over the widget (#13716) 2022-05-13 16:10:09 +05:30
Bhavin K
dabca5aac5
fix : prevent dragging when resizing (#13600) 2022-05-13 11:26:09 +05:30
arunvjn
9381eeaea7
Trigger submenu instead of omni-bar when "Add Query/JS" button in the explorer is clicked. (#13774) 2022-05-13 10:31:08 +05:30
ashit-rath
c60f102e45
fix: JSONForm - hidden field value reflects in formData (#13739)
* fix: JSONForm - hidden field value reflects in formData

* shifted update form code from useController to FieldRenderer

* review changes
2022-05-12 17:52:44 +05:30
Tolulope Adetula
83a2237a3a Merge branch 'release' into fix/select-widget-filtering 2022-05-12 12:41:32 +01:00
Tolulope Adetula
379ce6cf5c fix: Select widget filtering 2022-05-12 12:31:45 +01:00
Arsalan
b0e4f099bc fix: return undefiend when propertiesToUpdate is empty array. 2022-05-12 14:15:50 +05:30
f0c1s
84be23c490
chore: refactor git code (#13724) 2022-05-12 14:02:56 +05:30
Arsalan
8fa294ae49 Merge branch 'release' into fix/table-bindingPathList 2022-05-12 11:40:52 +05:30
Maulik
7856d8234e
chore: update error message for no schema available for a datasource (#13467) 2022-05-11 19:15:06 +02:00
arunvjn
ae22baaa36
fix: persists query param in redirect urls (#13738) 2022-05-11 20:42:07 +05:30
arunvjn
8084744e98
chore: safe crash application on theme APIs failure (#13743) 2022-05-11 16:01:04 +05:30
Favour Ohanekwu
876d1a17e7
fix: prevent lint warnings from blocking execution in js objects (#13700) 2022-05-11 11:20:33 +01:00
ChandanBalajiBP
43758f6e7e
Merge pull request #13725 from appsmithorg/Fix/Hover-state-of-renaming-titles
fix: Hover state of renaming titles
2022-05-11 14:59:26 +05:30
rahulramesha
27d5ae8b77
fix: Avoid pasting list widget inside another list widget (#13719)
* fix for stopping list widget from copying onto itself

* remove duplicate comment

* verify selected widgets are not inside list widget if list widget is to be pasted
2022-05-11 14:46:22 +05:30
Rishabh Rathod
89c4bbeeec
chore: remove only for jest test (#13668) 2022-05-11 09:12:59 +00:00
rahulramesha
3923204dcc
The page order doesn't work as expected in page setting page (#13448) 2022-05-11 13:28:07 +05:30
arunvjn
0571f9c36b
Delay on page load actions till all actions are retrieved (#13657)
As a quick fix to prevent the on-page load actions from firing before the actions are even fetched, we had reverted the changes to make fetch page DSL call parallel in 13587. Unfortunately, theming PR brought back parallelisation and the issue along with it.

This PR ensures that the on-page-load actions are only made after actions are fetched while preserving parallelisation.
2022-05-11 12:36:25 +05:30
Pawan Kumar
2dacdec880
fix: Not able to see all the options of Font property as it is not scrollable + Canvas scroll to top when I drop Tab widget on the canvas (#13608)
* fix tab widget scrolling + text widget font control overflowing issue

* revert text widget changes

* tab widget scroll issue

* remove border radius and box shadow from v1 widgets
2022-05-11 10:23:13 +05:30
Tolulope Adetula
10aca0297f
Merge pull request #13275 from appsmithorg/fix/disable-cancel-button-on-a-disabled-select-widget
fix: disable cancel button on a disabled select widget
2022-05-11 03:55:52 +01:00
Tolulope Adetula
2f8c178dda fix: Failing Tests 2022-05-11 02:36:54 +01:00
Ayangade Adeoluwa
49a4e47b95
Add functionality to close modal when back overlay is clicked. (#13669) 2022-05-10 12:39:03 +00:00
Chandan Balaji
01604bb25a hover state of renaming titles 2022-05-10 17:38:08 +05:30
akash-codemonk
c0f7c4534d
fix: signing up with a redirect url which has a query param goes to a 400 page (#13548) 2022-05-10 13:32:25 +05:30
Arpit Mohan
cf27bbdfec
Merge pull request #13653 from appsmithorg/fix-13652 2022-05-10 05:25:44 +02:00
akash-codemonk
2b5d5dd89f
fix: triggering omnibar shortcuts toggles visibility when visible (#11601) 2022-05-09 19:43:57 +05:30
ashit-rath
47a31a8412
feature: JSONForm - disable add new and remove buttons when array is disabled (#13520) 2022-05-09 17:34:49 +05:30
Sangeeth Sivan
897d3818b9
fix: Handle login form password error message on blur (#13568)
* gitignore

* don't show password field errorMessage onBlur

* remove unused import of usestore
2022-05-09 15:53:41 +05:30
Sangeeth Sivan
d5845e972a
fix: Use unique id instead of indices as keys for DraggableList (#13553)
* gitignore

* fix: Use unique id instead of indices as keys for DraggableList(#9991).

* removed duplicate 'stacks' from gitignore

* revert change to cypress selector for draggable list

* use 'id' ad key name for consistency and that it doesn't break in other places
2022-05-09 15:52:37 +05:30
Keyur Paralkar
1c1135d639
refactor: removed the duplicate style properties for the list widget (#13605)
* refactor: removed the duplicate style properties for the list widget

* test: fixed list_spec cypress failures
2022-05-09 15:41:36 +05:30
ashit-rath
a715c0eefa
fix: JSONForm Phone number field required validation (#13525)
* fix: JSONForm Phone number field required validation

* PR review suggestion change
2022-05-09 14:59:53 +05:30
Aishwarya UR
fdc3143c21 Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-05-09 13:58:37 +05:30
Arsalan
f6f5125018 Merge branch 'release' into fix/table-bindingPathList 2022-05-09 11:11:04 +05:30
Sangeeth Sivan
ab557b1443
fix: Lowercase 'first' on the welcome page. (#13559)
* gitignore

* fix: Lowercase 'first' on the welcome page.(#8876)

* removed duplicate 'stacks' from gitignore
2022-05-09 10:54:48 +05:30
Tolulope Adetula
de8aebfe00 Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-05-09 03:15:51 +01:00
Favour Ohanekwu
3ab904d83d
fix:only show js successful execution toast message in edit mode (#13590)
* only show js successful execution toast message in edit mode
2022-05-07 17:03:03 +01:00
Anubhav
e35f8dc897 fix: use modified instead of updated 2022-05-07 08:10:34 +05:30
rashmi rai
c0f98ad4d7
fix:change default value in rest api json and placeholder (#13261) 2022-05-06 19:13:10 +01:00
haojin111
b6d2f971c0
feat: 12594 - added cypress test of form login on admin setting page (#13178)
* added cypress test of form login on admin setting page

* resotre setting after checked

* added a check if signup form is enabled for all users

* minor fix

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-05-06 20:21:08 +05:30
Arpit Mohan
4934fc9066
Merge pull request #13644 from appsmithorg/fix-12164 2022-05-06 16:17:37 +02:00
rahulramesha
7a501ecd9c
fix: stopping list widget from copying onto another list widget (#13621)
* fix for stopping list widget from copying onto itself

* remove duplicate comment
2022-05-06 19:41:09 +05:30
arunvjn
c7305d4114
Makes bindings popover consistent with the other popovers (#13579) 2022-05-06 11:40:51 +00:00
Aswath K
be6946773e
fix: Broken keyboard nav with BorderRadius & BoxShadow (#13636) 2022-05-06 11:24:33 +00:00
f0c1s
1de19956e3
fix: add visual cue to SSH key regeneration (#13625) 2022-05-06 15:30:48 +05:30
ashit-rath
ddc95fae53
fix: JSONForm fix events/actions controls JS mode produces additional binding strings (#13509)
* fix: JSONForm fix events controls js mode additional binding strings

* fixed globalContext value for fieldState update and fix FilterText spec
2022-05-06 15:29:56 +05:30
Anubhav
03684fce97 fix: disable revoke button after first click 2022-05-06 15:21:33 +05:30
ashit-rath
910427788e
fix: JSONForm currency and phone input dropdown not working in Array Field (#13564) 2022-05-06 15:19:36 +05:30
rahulramesha
abe62f294c
Skip copying logic while grouping (#13573)
Adding check to skip pasting logic while grouping widgets
2022-05-06 13:52:20 +05:30
balajisoundar
08a882be24
chore: Update property from property pane to use improved get strategy & BATCH_UPDATE_WIDGET_PROPERTY to be processed serially (#12544) 2022-05-06 11:12:35 +05:30
Aswath K
ca3f159f66
fix: set max-height for Dropdown component (#13105)
* fix: set max-height for Dropdown component

* changes style for date format dropdown

* Combines MultiSelectControl into DropdonwControl

* fix: max height set via props

* fix: popover double scrollbar issue

* fix: styles for chips

* Delete MultiSelectControl

* fix: error when pressing Enter twice

* add tests for multi select & fix some warnings

* removes unwanted test file

* fix: country filtering issue

* address review comments

* fix dropdown for primary columns dropdown

* fix: issue with position

* Adds scrollIntoView when using arrow key for navigation

* fixes issue with scrollbar

* fix: jest tests

* fix: jest test

* fix: flaky cypress test

* fix: height & align issue in Date format selection

* smoothens the scroll
2022-05-06 10:34:17 +05:30
f0c1s
7a3985f962
feat: git discard changes (#11835)
* feat: git discard changes
* fixed cypress test in git connection
* feat: add discardDocUrl and update casing
* chore: update tests
* chore: fix review comment

Co-authored-by: haojin111 <haojin828@outlook.com>
2022-05-06 10:14:24 +05:30
Ayangade Adeoluwa
ec3a1acc4b
Fix text/plain not showing up when api is run in api response viewer (#13575) 2022-05-05 19:54:24 +00:00
Aswath K
f3eb7f6ed9 Merge branch 'release' into fix/colorpicker-tests 2022-05-05 19:51:34 +05:30
Aman Agarwal
ff510cba0e
fix: undefined check added for plugin (#13595) 2022-05-05 18:48:56 +05:30
rashmi rai
0b6ea8dc7e
fix: moving refreshTokenClientCredentialsLocation from oAuth2Common to AuthoCode (#13551) 2022-05-05 17:24:14 +05:30
arunvjn
d7d4386e1e
feat: entity explorer submenu (#13425) 2022-05-05 15:44:10 +05:30
Arsalan
69fb17eae0 fix: moved test to WidgetOperationSaga.test.tsx 2022-05-05 14:03:18 +05:30
Arsalan
a02aee83f4 fix: propertyUtils return propertiesToUpdate. 2022-05-05 12:46:57 +05:30
Arsalan
d340242ef8 fix: table derived bindingList error. 2022-05-05 12:08:27 +05:30
ashit-rath
f0952b8082
fix: JSONForm RadioGroupField - support numeric values in the options (#13365)
* fix: JSONForm RadioGroupField accept numeric values in the options

* cypress test - clear options before adding

* update code editor clear
2022-05-05 11:10:52 +05:30
Ankita Kinger
8522692bac
Code split for RBAC features (#13557) 2022-05-05 11:07:50 +05:30
arunvjn
7f243c505a
Fixes missing applicationId in fetch comments API by delaying the component mount. (#13519) 2022-05-05 10:52:32 +05:30
Paul Li
58dfb48023 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-05-04 21:46:14 +08:00
arunvjn
3c57ac1764
fix: update JS libs version numbers in entity explorer (#13526) 2022-05-04 19:06:10 +05:30
ankurrsinghal
ef79f6450d
Merge pull request #12190 from appsmithorg/feature/pp-datepicker
feat: added keyboard interaction for datepicker
2022-05-04 18:10:27 +05:30
f0c1s
9cc0cdd404
fix: remove horizontal scrollbar in git sync modal (#13514) 2022-05-04 17:10:32 +05:30
Aswath K
c03cc6e1d3 fix: package issue with focus-trap causing jest test failure 2022-05-04 16:32:04 +05:30
Favour Ohanekwu
59710de95b
chore: highlight name input field for newly created js objects (#13212) 2022-05-04 10:47:41 +01:00
Pawan Kumar
809a633306
feat: App Theming (#9714)
* fix style bugs

* fix select styles

* test: fix font size issue for cypress tests

* incorporate ashit feedback

* test: addresed review comments for cypress tests

* add analytics events

* height issue in view mode

* incorporate code review feedbacks

* incorporate code review feedbacks

* refactor: addressed review comments; removed border radius and box shadow for text widget; Updated migrations

* feat: Makes shadow and radius controls keyboard accessible (#11547)

* makes shadow and radius controls keyboard accessible

* removes unused imports

* moves options out of render method

* fix: changed the misnomer background property name to the relevant property name

* fix: border radius issue for the map widget

* address qa bugs

* address qa bugs

* fix ux of theming pane when widget is selected

* fix:
* added backgroundColor to the video widget
* restricted pop-over border radius to 0.375rem
* added box shadow for the input group for select widget

* fix: added delete icon in the delete theme modal

* address qa bugs

* change checkbox column size in config

* add js convertible to button color

* remove unused imports

* test: fixed jest tests

* fix primary color typo

* fix: migrations for the theming

* fix:
* Removed background color from MultiTreeSelect and TreeSelect component.
* grouped button's menu button pop over border radius restricting to 0.375rem.

* test: updated Dsl migration UT

* address qa bugs

* address qa bugs

* fix: address qa comments

* address qa bugs

* fix:
* migration issue;
* unit test cases;

* fix rating widget scroll issue

* fix youtube video border radius bug

* fix select widget

* fix select widgets styles

* address qa bugs

* merge conflicts

* makes the reset button keyboard accessible (#12134)

* -resolved merge conflicts

* address qa bugs

* fix: labelTextSize migration fixes

* refactor:
* made changes to the fontSizeUtils function
* fixed the issue related to unit tests

* fix button group widget

* remove unused imports

* fix: fixed the text size migration for the table widget

* refactor: addressed review comments for the table widget theming migration

* fix button group widget

* add init calls for view mode

* json form init theme changes

* fix: added migration for boxShadow, borderRadius and textSizes for table widget

* fix broken fields

* test: fixed unit tests

* wip

* inconsistancy fixes and schemaItem update in updateHook/fieldConfiguration

* feat: init json form migration theming

* json form primaryColor -> accentColor

* update table widget

* update table widget

* object field label styling

* fix: migration related to the JSON form

* fix: fixed labelTextSize migration for JSON form nested widgets

* property control nested stylesheet lookup

* JSONForm label styles form array items

* show label for checkbox field array item

* fix button group widget

* wip

* refactor: addressed table widget review comments

* refactor: addressed ashit review comments;
* added childStylesheet for widgets

* feat: Keyboard navigable Color Picker control (#11797)

* Makes ColorPicker keyboard accessible

* seperate out keyboard and mouse interactions

* fix issue with not focusing back to input

* Adds test for Color picker

* chore: added comment for the boxShadow property

* fix:
* added unit test cases for the widget and property utils
* resolved warning messages

* wip

* theme config update

* fix merge conflicts

* refactor: moved theming migration inside the migrations folder

* fix qa bugs

* fix jest test

* fix: unit test cases

* fix table column creation logic

* refactor: addressed review comments for migrations

* fix: Overriding margin and padding for custom render in the dropdown component (#12875)

* * fix for custom render padding and margin in ADS dropdown

* * fix for removing padding from normal render options

* refactor: moved the boxShadow condition to the variable

* fix qa bugs

* fix: migration QA callouts for audio recorder widget

* refactor: added updated comments for boxShadow migration for table widget

* fix theme binfings for JSONForm fields under Object

* fix table widget theming bug

* fix: addressed code review comments

* fix: unit test cases

* fix: qa migration callouts

* fix table widget theming bug

* fix JSONForm currency input dropdown not submit form

* Added new tests - AppThemingSpec

* fix qa bugs

* fix unit test

* fix JSONForm cellBorderWidth to have default value post migration

* fix unit test

* fix qa bugs

* remove unused imports

* fix qa bugs

* fix JSONForm input height issue

* fix qa bugs

* Updating Theming spec

* * dropdown color fixes (#13249)

* fix caching issue
;

* Fixed Theming tests

* fix tests

* fix tab widget tests

* fix: json form children level migration issue

* fix table widget tests

* Updated test

* updated tests

* updated test

* updated tests

* updated tests

* updated pageload

* fix cypress tests

* remove cypress created files

* fix color picker issues

* Failure fixes

* Fixed some more tests

* fix: cypress test failures

* fix tests

* remove consoles

* fix table tests

* fix qa bugs

* updating snapshots for AppPageLayout_spec as per new UI

* fix rating widget bug

* fix qa bugs

* fix:
* cypress failing tests
* Migration QA callouts
* Removed unused imports

* update constract check algo

* fix color contrast issue

* fix: cypress failure test cases

* update font sizes labels

* fix regression bugs

* fix:
* JSON form labelTextSize issue fix
* Updated comment for the fontSizeUtility function
* migrations issues related to table widget borderRadius and boxShadow

* fix: default labelTextSize issue for the Input and Select families

* fix regression bugs

* fix regression bugs

* PassingParams spec - added wait time

* fix: font family default value issue on JS toggle

* fix js toggle issue in text widget

* fix tests

* fix tests

* fix tests

* fix cypress tests

* fix regression bugs

* fix regression bugs

* fix:
* refactored table widget migration function as per review comments,
* added default value to the widget

* fix: failing unit test cases

* fix theming spec

* fix cypress tests

* test: fixed failed cypress test

* incorporate ashit feedback

* fix cypress tests

* fix: addressed review comments

* comment out table cypress test

* fix merge conflicts

* comment out color picker tests

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aswath K <aswath@appsmith.com>
Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Ashit Rath <ashit@appsmith.com>
Co-authored-by: balajisoundar <balaji@appsmith.com>
Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-05-04 15:15:57 +05:30
balajisoundar
8163becacc
fix: DisplayText in table url column should be processed properly for empty values (#13318)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-05-04 14:59:42 +05:30
Favour Ohanekwu
7261834fe5
fix: only execute pageload actions after successfully fetching actions and jscollections in view mode (#13521)
* prevent execution of onPageLoad actions before sucessful actions fetch

* Perform url update before fetching actions and jscollections
2022-05-04 09:43:26 +01:00
akash-codemonk
05fdfd540b
fix: welcome form shown for a while after signup (#13304) 2022-05-04 14:13:02 +05:30
rahulramesha
e128b2daf3
feat: new Widget Copy paste experience (#12906)
* copy paste commit

* class name generator changes

* modal widget fixes change

* addressing review comments

* bug fix for after deleting a widget by undoing action

* additional fix for modal widget

* additional tests for fixes
2022-05-04 13:28:57 +05:30
ashit-rath
7dbe9ccf26
fix: JSONForm placed in modal does not update default value from source data (#13453) 2022-05-04 12:53:48 +05:30
ashit-rath
06168ecb60
fix: submit button not disabled in invalid json form on first load (#13415)
* fix: submit button not disabled in invalid json form on first load

* reset fixes
2022-05-04 10:45:27 +05:30
Favour Ohanekwu
3efb3588d2
chore: Add JS editor test cases 2022-05-03 15:22:45 +01:00
haojin111
0414c8823d
fix: 12456 - oauth redirection issue (#13511)
* fixed issue of gsheet authorization
* hidden cloudhost ip info on reconnect modal
2022-05-03 14:22:48 +05:30
Rimil Dey
c55718f9f1
fix: don't run onClick event handler when button is disabled (#12333) 2022-05-03 07:25:31 +02:00
Favour Ohanekwu
395fd30335
add overflow to js editor settings (#13488) 2022-05-02 20:34:55 +02:00
Ankur Singhal
0d0f5d4c2c Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-05-02 13:23:59 +05:30
haojin111
ca33d68532 fixed uppercase of url 2022-05-02 12:50:49 +08:00
haojin111
ecffa88684 updated label text of remote url 2022-04-30 21:18:53 +08:00
rashmi rai
4596a12bfd
added fixActionPayloadForMongoQuery (#13465) 2022-04-30 08:27:15 +05:30
Preet Sidhu
c6f3f356e6
Merge pull request #12964 from appsmithorg/fix-10379
fix: 10379 disable html parsing for long texts
2022-04-29 12:29:36 -04:00
Rishabh Rathod
3b1fbfa989
fix: replace klon/full with klona default (#13457)
- when manipulating props, react state (immutable values)
2022-04-29 15:14:17 +00:00
Ankita Kinger
63479dbb3e
chore: update subtext copies for Google & Github (#13451)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
2022-04-29 17:52:27 +05:30
Preet
2ee727bd84 Merge branch 'release' into fix-10379 2022-04-29 06:34:47 -04:00
akash-codemonk
9b9048fdc4
chore: add analytics event for similar templates click (#13177) 2022-04-29 15:39:16 +05:30
Paul Li
297b6141c0
fix: feedbacks on label feature (#13123)
* fix: Fix on feedbacks on Label feature

-- Eliminate CSS restriction for horizontal scrolling

* fix: feedbacks on label feature

-- Eliminates CSS rules for overflow-x: hidden
2022-04-29 17:21:08 +08:00
Ankur Singhal
e29a879ff7 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-04-29 14:14:37 +05:30
Maulik
59e8ad12e1
fix: allow camera & mic access for page in iframe widget 2022-04-29 11:49:44 +05:30
Tolulope Adetula
fa48a026ad Merge branch 'release' into fix/disable-cancel-button-on-a-disabled-select-widget 2022-04-29 06:12:19 +01:00
Tolulope Adetula
16724bdc04
Merge pull request #13074 from appsmithorg/fix/table-mutiselect-checkbox-alignment
fix: table Widget Multiselect Row checkbox alignment
2022-04-28 21:51:38 -07:00
akash-codemonk
cc3de11bfa
fix: dropdown showing an empty row when the options list is empty (#13364) 2022-04-29 10:09:44 +05:30
Tolulope Adetula
14e1b20464
Merge pull request #12626 from appsmithorg/feat/show-page-count-when-total-records-exist
feat: show total records and pageCount in table header
2022-04-28 19:30:51 -07:00
Tolulope Adetula
5749a4461b Merge branch 'release' into feat/show-page-count-when-total-records-exist 2022-04-29 02:37:59 +01:00
Tolulope Adetula
302644473c
Merge pull request #13164 from appsmithorg/fix/Primary-column-control-visibility-icon-out-of-sync
fix: Primary column control visibility icon out of sync
2022-04-28 18:35:11 -07:00
Tolulope Adetula
76b2e219f6 fix: build issue 2022-04-29 02:22:28 +01:00
Favour Ohanekwu
942547287c
feat: js object v1 run and settings redesign (#11456) 2022-04-28 17:51:02 +01:00
Tolulope Adetula
70c475f049
Update Icon.tsx 2022-04-28 04:59:14 -07:00
Tolulope Adetula
359d3706fe Merge branch 'release' into fix/Primary-column-control-visibility-icon-out-of-sync 2022-04-28 12:42:04 +01:00
Tolulope Adetula
47398e20d9 fix: PR reviews 2022-04-28 12:25:14 +01:00
Ankur Singhal
f2cabb8eec Merge branch 'release' of https://github.com/appsmithorg/appsmith into feature/pp-datepicker 2022-04-28 16:51:19 +05:30
Ankur Singhal
47d219cc90 removed day click and clear click which was crfeating the ambiguity 2022-04-28 16:36:18 +05:30
Ankita Kinger
3835e81105
chore: Add analytic event for the Reset button click on the Admin settings page. (#13408) 2022-04-28 14:46:38 +05:30
Favour Ohanekwu
02d4af3ed7
prevent multiple execution of pageload actions when generating a template (#13361) 2022-04-27 19:28:52 +01:00
Ankita Kinger
251ad6097b
chore: Add analytic events on Authentication page (#13384)
* added analytic events for Authentication page on Admin settings

* updated event names
2022-04-27 23:16:24 +05:30
rahulramesha
727889434c
fix: calculating the canvas container height to be exact to not scroll on scrollIntoView() call (#13096)
* canvas container Fix

* add comments
2022-04-27 15:43:29 +00:00
Ayangade Adeoluwa
5a126bfda2
Add space to both sides of response run button (#13368) 2022-04-27 12:42:29 +01:00
Tolulope Adetula
2d57840938 fix: add new line 2022-04-27 12:30:43 +01:00
Tolulope Adetula
7f8bf5c4fe fix: PR reviews 2022-04-27 12:29:31 +01:00
ashit-rath
fc36a3af94
feat: Analytics to log source data limit exceed (#13339)
* feat: Analytics to log source data limit exceed

* minor change
2022-04-27 14:04:15 +05:30
Maulik
0eef3b0bfd
fix: code hidden issue for JS Enabled fields (#13241)
* fix code hidden issue for JS Enabled fields

* test for code hidden fix
2022-04-27 12:37:33 +05:30
haojin111
7b09976f52
feat: 12457 - added application import success modal (#12739)
* added application import success modal

* updated logic and added cypress test

* fixed cypress test

* added local storage for refresh

* fixed issue - 11721 git import issue

* fixed cypress test with new designd modal

* fixed cypress test failed issue
2022-04-27 12:07:04 +05:30
Ayangade Adeoluwa
c264e1cd89
Add fallback for responseType, in case it does not exist (#13324) 2022-04-26 20:40:59 +05:30
Arsalan Yaldram
4dabbd8f13
fix: onSucess & onError action selector () => {} (#12753) 2022-04-26 20:01:23 +05:30
Ankita Kinger
cd84b63373
added check for disconenct button clicked once (#13272) 2022-04-26 19:51:06 +05:30
albinAppsmith
1d019d1376
fix: Modal padding and color fixes (#12189)
* * share modal fixes

* * modal ui fixes
2022-04-26 19:26:07 +05:30
Tolulope Adetula
faea2712fe fix: disable cancel button on a disabled select widget 2022-04-25 13:36:36 +01:00
Bhavin K
20aa7196d2
fix: handle editor value update (#12726) 2022-04-25 12:32:55 +05:30
f0c1s
d428262bf9
fix: Azure SSH url was not accepted for git connection (#12896) 2022-04-23 18:01:43 +05:30
haojin111
08bbd55020
Merge pull request #13207 from appsmithorg/fix/13184-master-branch-issue
fix: 13183, 13184 - fixed issue of correct branch name on edit mode
2022-04-23 05:03:44 +08:00
ashit-rath
1acf242600
feat: JSONFrom add isValid form level property to represent overall form validity (#13083) 2022-04-22 17:20:51 +05:30
Ayangade Adeoluwa
a896467e69
fix: Change response tab name (#12930)
* Change response tab name

* Fix response tab name
2022-04-22 12:10:00 +01:00
Aman Agarwal
9a022a668f
fix: datasource ui style issues resolved (#13175) 2022-04-22 16:23:00 +05:30
Bhavin K
78600bd2ed
fix: handle dropdown flickers (#12979) 2022-04-22 15:56:48 +05:30
Abhinav Jha
60503bb9a6
feat: Dynamic Height widget config (#13143)
* Add platform feature which adds dynamic height property controls and default properties based on widget config

* Move features to the top, so that defaults can override them if necessary

* - Add unit tests to verify that the property controls show up for dynamic height
- Add unit test to verify that the hidden hook in the dynamic height controls work
- Fix console warning for react key unavailable in Generator.tsx
- Move constants and types to their respective files

* Remove dynamic height config from Container Widget

* Add comments in hard to understand areas

* Add function which converts fn validation params to fnString
2022-04-22 15:14:22 +05:30
ashit-rath
07757c7e7b
fix: Replace "klona/full" -> "klona" in JSONForm to avoid cloning of non-enumerable properties (#13193)
- non-enumerable like `writable`, `configurable`, `enumerable` were getting cloned with `klona/full` and it wasn't needed.
2022-04-22 14:15:45 +05:30
haojin111
498b9a6f7e fixed issue of correct branch name on edit mode 2022-04-22 14:36:49 +08:00
Bhavin K
7e3d873d20
feat: added searched address into map center data (#12962) 2022-04-22 11:44:42 +05:30
akash-codemonk
7d646bf11c
chore: redirect to home page at the end of onboarding (#12961) 2022-04-21 19:28:26 +05:30
arunvjn
bdcc99b53b
chore: Hides update button when there are no pending updates. (#13152) 2022-04-21 18:44:10 +05:30
Bhavin K
958233f4f5
fix: added dataFormat into file data (#12807) 2022-04-21 16:09:24 +05:30
albinAppsmith
978f1d3cd1
chore: Added margin bottom for sign posting checklist footer (#12884) 2022-04-21 11:44:34 +05:30
Ankita Kinger
9ed26a92b0
chore: update a cypress test (#13036) 2022-04-21 11:44:02 +05:30
Preet
19172bf2b6 reduce line break limits to 1000 2022-04-20 13:22:45 -04:00
Preet
eb4eaf849a Merge remote-tracking branch 'origin/release' into fix-10379 2022-04-20 13:20:22 -04:00
arunvjn
c925bf2efd
fix: scroll to active entity in explorer on route change (#13085)
* Scroll to active entity in explorer on route change

* Removes scroll animation

* Open modal via entity explorer

* Try tonavigate to canvas only in edit mode

* Added cypress to assert modals' presence when triggered from the API page.
2022-04-20 21:55:55 +05:30
Tolulope Adetula
04ac78ba15 fix: Primary column control visibility icon out of sync 2022-04-20 14:56:01 +01:00
rahulramesha
98f6a3fede
move reflow out of beta (#12746) 2022-04-20 18:33:30 +05:30
Paul Li
0771f23294 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Rename getDropdownPosition to getCloesetCanvas
2022-04-20 20:40:53 +08:00
Paul Li
ef56d732a8 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-04-20 20:36:53 +08:00
Paul Li
b2c1ebf736 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Makes getDropdownPosition as a widget utility function
2022-04-20 20:35:35 +08:00
Aman Agarwal
356cdfffab
fix: changed prop drilled fn to class fn, avoided array prop (#12788) 2022-04-20 15:56:27 +05:30
ashit-rath
5b3f29a6bc
fix: onOptionChange event not triggering in JSON Form radio group field (#13073) 2022-04-20 14:47:34 +05:30
Paul Li
43ca423b48 Merge branch 'release' into fix/12161-multiselects-broken-in-modal 2022-04-20 17:04:24 +08:00
Paul Li
9301bf9637 fix: Popover in Multi select widget inside modals breaks away from the widget
-- Sets popover container to the closest canvas
2022-04-20 17:02:57 +08:00
rahulramesha
27b54f22e8
Reflow overlapping fix on canvas edges (#12745) 2022-04-20 12:56:35 +05:30
haojin111
923efa9696
fixed issue of deleting original default branch (#13062) 2022-04-20 05:50:54 +05:30
Tolulope Adetula
a892aa678d fix: Table Multiselect checkbox alignment 2022-04-19 09:40:42 +01:00
rashmi rai
bb5d7159c6
Always show advanced settings in rest api editor (#12927) 2022-04-19 12:03:27 +05:30
Ankita Kinger
5b4628a9d4
Add common code for SAML (#12976)
Added new form field component in ads. Also, updated copy URL form component.
2022-04-18 17:47:29 +05:30
Bhavin K
3575a03005
fix: updated cursor style in actionWrapper (#12850) 2022-04-18 11:39:11 +05:30
Preet Sidhu
820a99e5d1 disable html parsing for long texts 2022-04-15 10:03:38 -04:00
Bhavin K
b6b253a636
fix: update custom chart data and type only (#12574) 2022-04-15 16:28:13 +05:30
akash-codemonk
71591ff75f
chore: remove frontend template feature flag (#12937) 2022-04-15 14:58:27 +05:30
arunvjn
b69b1191cf
fix: widgets from other apps shown in omnibar (#12890) 2022-04-15 11:10:56 +05:30
Aswath K
25afe65cb7
Merge pull request #12923 from appsmithorg/fix/delete-button-kdb
feat: makes option control delete button keyboard accessible
2022-04-14 19:57:06 +05:30
Rishabh Rathod
846ba223ea
fix: replace rfdc with klona (#12568)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-14 14:19:13 +00:00
Aswath K
6a4b632338 Merge branch 'release' into fix/delete-button-kdb 2022-04-14 16:24:52 +05:30
Paul Li
eb37416a2a
feat: Controls for labels in widgets to align the widgets in forms and other places (#10600)
* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Create a new property control for a label position
-- Create a new property control for a label alignment
-- Prototype a label section for Input widget

* feat: When there are multiple input widgets with different label lengths then the input box looks misaligned

-- Add a property, labelWidth in the property pane

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Input widget: Implement all the requirements in case its type is Text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adapt the functionalty on other types of the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into DropdownWidget
-- Clean up for the input widget and DRY

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectWidget
-- Eliminate unnecessary component prop, columns

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalties into Tree Select widget
-- Add styles for alignment between lable and input control over the widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add label functionalities into MultiSelectTreeWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Introduce label functionalities into DatePickerWidget2
-- Use width instead of columns prop in InputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RichTextEditorWidget
-- Eliminate compactMode from StyledLabel

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into CheckboxGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement switch group for the correct meaning of right alignment

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply label functionalities into RadioGroupWidget
-- Add new properties, alignment and inline for consistency

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Adjust cols and rows for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused StyledRadioProps

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete first MVP of enhanced SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Complete the first MVP of enhanced RadioGroupWidget
-- Eliminate unused StyledSwitch component for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add min-height, align-self rules for LabelContainer

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Use original label property for RadioGroupWidget
-- Add a migration for adding isInline and alignment properties for RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Update version to latest one in DSLMigrationsUtils.test.ts

* fix failing jest test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement label functionalities on BaseInputWidget, InputWidgetV2, CurrencyInputWidget, PhoneInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DSLMigrationsUtils

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the label related test case which is failed in Input_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places
-- Fix on #10119: The label text truncates on resizing the input widget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix scroll issue when shrink with MultiSelectWidget and MultiSelectTreeWidget

* fix: Widget Popup test

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement width and alginment features on the level of label element
-- Prevent actual inputs from DropdownWidget, MultiSelectWidget, SingleSelectTreeWidget, MultiSelectTreeWidget from overflow when resizing
-- Enable label feature on a RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set label container's default width to 33% when width is not set

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix crash issue when labelWidth is filled by non-numeric value, eliminating passing NaN as its value

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set flex-grow to zero on input types other than TEXT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label features on newly created MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate LabelPositionTypes, directly using enum LabelPosition
-- Add a comment for a constant LABEL_MAX_WIDTH_RATE
-- Directly import React for LabelAlignmentOptionsControl
-- Remove unnecessary constructor for LabelAlignmentOptionsControl
-- Define handleAlign instance method as a higher-order function
-- Only migrate alignment property for RadioGroupWidget
-- Use Object.hasOwnProperty instead of in operator

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Migrate alignment property of RadioGroupWidget in case of currentDSL.version is 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Revert currentDSL.version to 52

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a Jest test case for RadioGroupWidget's alignment property migration

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Replace all nested ternary operators with if statements

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Implement label feature on new version of SelectWidget
-- Add Cypress tests for widgets' label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor code for BaseInputWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change CSS selector for step buttons for Numeric BaseInputWidget
-- Directly use migrateRadioGroupAlignmentProperty migration function without using transformDSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on typo about migrateRadioGroupAlignmentProperty

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add data-testid attributes for Cypress selectors

* feat: Deprecate form button widget

-- Assert flex-direction to row in CheckboxGroup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add a missing data-testid for SelectWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on failed test cases: CheckboxGroup_spec, DatePicker_2_spec, MultiSelectWidgetV2

* fix: Select popup DSL

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new property control, NumericInputControl
-- Replace all the label properties with the newly created controls

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Create a new Cypress command, checkLabelWidth and apply to all related test cases
-- Increase width in checkboxgroupDsl.json
-- Rename className for label in MultiSelectWidgetV2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Reimplement the tooltip feature for labels
-- Add missing props for labels in DateField, MultiSelectField, RadioGroupField, SelectField fields for JSONFormWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor property controls, including LabelPositionOptionsControl, LabelAlignmentOptionsControl, NumericInputControl to keep consistency
-- Apply default values into label section

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract the label related parts from the various widgets as an independent component

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate TypeScript any type from BaseInputComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change labelPosition property type to DROP_DOWN
-- Modify LabelAlignmentOptionsControl to use ButtonTabComponent

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Define getLabelWidth method into BaseWidget
-- Extract the common CSS rules for the widget containers
-- Revert rows and columns for SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed test case in DSLMigrationsUtils.test.ts

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on overflow issue on CheckboxGroupWidget
-- Create a distinctive spec file for label feature
-- Eliminate the redundant label specs with the relevant widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Delete unnecessary files, including Select_spec.js, LabelButton.tsx and LabelPositionOptionsControl.tsx
-- Revise wrong comment for checkLabelForWidget Cypress command

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Do not set the label width only if its value is 0
-- Clean up the component for DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused imports in DatePickerWidget2

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Make RadioGroupWidget's layout flexible in all modes

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on Cypress test case for RadioGroupWidget in Widgets_Labels_spec
-- Change Cypress commands, including addAction, addSuccessMessage, enterActionValue to accept parentSelector

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Change getLabelWidth method to not have any argument
-- Define some constants for label numbers
-- Extract the common styles for SwitchGroupWidget and RadioGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Refactor some constants

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate unused width prop from RadioGroupWidget
-- Get labelWidth from getLabelWidth

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Eliminate the min-height restriction on a label
-- Eliminate the scroll on the earlier InputWidgetV2 which was not in compact mode

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add one more condition checking if the current input type is text

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Extract common code base for MultiSelectTreeWidget and MultiSelectWidgetV2
-- Apply a few CSS fixes on the scrollbar issue select related widgets

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Apply some tweaks for earlier widgets with labels so as not to be broken UX

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Fix on the failed Cypress test case in Widget_Popup_spec.js

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Add constants, LABEL_DEFAULT_WIDTH_RATE, SELECT_DEFAULT_HEIGHT, LABEL_MARGIN_OLD_SELECT

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Increase the widths of CheckboxGroupWidget and SwitchGroupWidget

* feat: Controls for labels in widgets to align the widgets in forms and other places

-- Set the font size to 14px for NumericInputControl

Co-authored-by: ohansFavour <fohanekwu@gmail.com>
Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-04-14 16:47:25 +08:00
Aswath K
1bf959d177 feat: makes option control delete button keyboard accessible 2022-04-14 13:23:41 +05:30
Ayangade Adeoluwa
a4d22b3d13
Handle stringified json response and fix alignment issue (#12886) 2022-04-14 12:53:07 +05:30
Rishabh Rathod
ee76cabb96
chore: fix Key missing error in Boxed component (#12912) 2022-04-14 06:31:50 +00:00
arunvjn
b7aff3c38b
chore: Parallellise fetch page call with actions, jsObject and plugins (#12537) 2022-04-14 10:16:17 +05:30
rahulramesha
cfba555fe8
chore: Should not persist DSL for mainContainer layout changes (#12351)
* Moving out non persistent state out of DSL

* replacing canvas width seector

* converting to immerReducer

* adding TODO and more immer reducer changes
2022-04-14 10:06:20 +05:30
Parthvi12
0766f83cf0
test: Add tests for git bugs and git import (#12751)
* add tests for git bugs and git import

* add dsl file

* added test for git bug and commented git sync test for apps

* updated tests

* removed wait

* updated messages.test.ts

* updated git import tests

* added fix for onboarding_spec
2022-04-14 08:32:57 +05:30
rahulramesha
faaf977728
feat: Container Jump Improvements and Code for tracking Container Jumps (#12686)
* conatiner Jump Optimization and tracking

* Round of mouse positions ans add negative jest test cases

* addressing review comments
2022-04-13 20:27:44 +05:30
akash-codemonk
2abb7bb822
fix: welcome form getting submitted on pressing enter key (#12613) 2022-04-13 15:37:11 +05:30
f0c1s
736c2e024e
feat: git delete branch (#12681) 2022-04-13 15:33:23 +05:30
akash-codemonk
73482000a6
chore: search for templates with a given datasource or widgets (#12434) 2022-04-13 14:18:40 +05:30
f0c1s
f5796bfa30
fix: git merge tab issues (#12576) 2022-04-13 08:47:33 +00:00
CommanderRoot
a778a98016
chore: replace deprecated String.prototype.substr() (#11928)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-04-13 12:30:38 +05:30
Favour Ohanekwu
b102d32761
fix: show loading state in JS Editor (#12820) 2022-04-13 11:47:56 +05:30
Anand Srinivasan
8420f6c5fa
fix: Js object - set async tag after all objects are parsed (#12684)
* set isAsync after all parsing is done

* clean up
2022-04-13 11:07:46 +05:30
Preet Sidhu
19d0db30b0
fix: 12861 trim unnecessary re-render in select widget in server side rendering (#12865)
* add debounce to search and remove state var

* increase debounce time
2022-04-12 16:31:51 +00:00
akash-codemonk
d292075243
fix: template fork button style on safari (#12202) 2022-04-12 19:23:57 +05:30
Rishabh Rathod
136308fd7c
fix: table search text dependency deletion (#11608)
* Replace BindingPaths with ReactivePaths and remove non-bindable property path from bindingPaths to reduce confusion.
2022-04-12 13:09:26 +00:00
arunvjn
68bca33a55
fix: broken checklist onboarding flow (#12822) 2022-04-12 17:03:35 +05:30
Aman Agarwal
21eb88f847
fix: updated default content-type and default body format type (#11878)
* fix: updated default content-type and default body format type

* fix: updated the cypress test because the default content-type is changed

* fix: update content type on change of http method and update body format type too

* fix: changed cypress test back to previous
2022-04-12 16:43:11 +05:30
Ankita Kinger
c1e48f7486
feat: Refactor code for SAML integration (#12700)
* Implemented code splitting of some files for SAML integration

* Implemented code splitting of some more files for SAML integration

* updated redirect url component

* fixed an import statement

* fixed a unit test

* updated restart banner tooltip logic

* updated an import statement
2022-04-12 16:20:01 +05:30
Rishabh Rathod
7626d75ccf
fix: remove "Error when determining async func" (#12683)
- Add logs for debugging
2022-04-12 10:02:02 +00:00
Tolulope Adetula
89fcc414e3
fix: remove internalKeys from Selected row and Triggered row (#12655) 2022-04-12 10:01:03 +00:00
Trisha Anand
85ebed6d5e
Merge branch 'master' into release 2022-04-12 14:06:53 +05:30
haojin111
c32ca69a91
fix: 12456, 12420, 12422 on reconnect modal issues (#12569)
* fixed-12456 gsheet auth issue

* fixed - 12420 save button functionality failed

* fixed - 12422 datasource selection issue

* fixed issue of gsheet authentication

* fixed comments point

* fixed 12511: typo issue

* fixed cypress test import and export
2022-04-11 23:00:29 +05:30
Ayangade Adeoluwa
5bc414082a
fix: Fix app crash on arrow down in where clause (#12801)
* Fix app crash on arrow down in where clause

* Makes sure first index is not omitted
2022-04-11 17:02:56 +00:00
Ayangade Adeoluwa
8bdcbec9f1
fix: Fix google sheets datasource options (#12773) 2022-04-11 20:29:13 +05:30
Tolulope Adetula
52a51b882c
fix: select widget virtualization not rendering first top items (#12768)
* fix: select widget virtualization

* fix: use max height of renderMenuItem

* fix: make height a constant

* fix: variable name

* fixed spec

Co-authored-by: Ashit Rath <ashit@appsmith.com>
2022-04-11 18:20:01 +05:30
haojin111
6e63290477
fix: 12338 - postgres datasource default configure on reconnect modal (#12503)
* updated logic of form initialization on reconnect datasource modal

* fixed cypress test

* fixed cypress test
2022-04-11 16:53:52 +05:30
Ankita Kinger
65ffb56f34
chore: Improve the UI for restart banner on admin settings page (#12580)
* improved the UI for restart banner on admin settings page

* implemented suggestions from PR

* retrying to restart server on button click

* updated colors getting used

* implemented PR suggestions

* fixed cypress test failure
2022-04-11 14:12:06 +05:30
akash-codemonk
d100cac0ec
fix: fork app button not opening the fork modal for non-signed in users (#12479) 2022-04-11 10:44:50 +05:30
Aswath K
7aba7772e2
fix: invisible icon in panel (#12610) 2022-04-10 00:01:37 +05:30
Favour Ohanekwu
b3e30725dc
properly handle translated diffs when change is between undefined and an Array (#12577) 2022-04-09 14:55:41 +01:00
balajisoundar
a11ae569e1 Fixing merge conflicts 2022-04-08 19:48:47 +02:00