Commit Graph

131 Commits

Author SHA1 Message Date
Hetu Nandu
c92eb0e5a4
Introduce different evaluation types for different binding fields (#3834) 2021-04-26 11:11:32 +05:30
akash-codemonk
36532cbcc8
[Feature] Debugger logs (#3633) 2021-04-23 19:20:55 +05:30
Nidhi
6b31aa333b
Introducing Google Sheets Plugin (#3517)
* cherry pick -make new

* revert to enable fix from release

* attempt to hook into existing datasource editor

* gSheets plugin skeleton from Rest API

* Changes for database migration

* fix for auth code

* separate it out

* action page loads!

* add to explorer

* create action from datasource

* Editor JSON WIP

* working query form

* Editor JSON WIP

* import to

* fix toast message

* redirect from datasource and editor pages

* fix onboarding

* fix imports and constants

* refactor form out

* refactor queryForm

* Merge branch 'release' into feature/google-sheets

* Merge branch 'release' into feature/google-sheets

* initial values from settings, editor and form

* Check

* remove dangling code around lightTheme

* Safety net

* remove class

* try mouseover solve

* force click

* changes from review

* fix action form name on import

* Merge branch 'release' into feature/google-sheets

* minor cleanup

* Merge branch 'release' into feature/google-sheets

* WIP

* Google sheets changes

* Merge conflicts

* Merging and fixes, needs refactoring

* Check

* Merge branch 'release' into feature/google-sheets

* Fixed tests

* Add cloud services env variable

* Clean up saga

* Clean up

* Refactoring

* Deleted svg file

* Minor fixes

* Modified design to allow behaviour in google sheets methods (#3486)

* Modified design to allow behaviour in google sheets methods

* Review changes

* Removed sysout

* Added handling of edge cases with table data

* Merge branch 'release' into feature/google-sheets

* Fixes

* Fixes

* Added validations

* Improved tests

* Removed extraneous injected bean

* Review changes

* Fixed bug with method

* Changes to Google sheets plugin's request and response structures (#3692)

* Method changes

* Removed logging

* Renaming options

* Reverting pom version

* Modified type of collection variables, fixed errors

* Converted row offset field to one that supports dynamic bindings

* Review changes

* List SAAS plugin type actions under lightning menu apis (#3820)

* list saas plugin type actions under lightning menu apis

* combine saas plugin type actions in the other sub menu of lightning menu

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* Fix merge issues

* Prettified query editor and a few fixes w/ ux

* Test fixes

* Reformatting request

* code for REST added (#3876)


Co-authored-by: hetunandu <hetu@appsmith.com>

* Renamed body to row object

* Renamed placeholder for range

* Renamed range heading

* Modifications to handle range semantics

* Use spreadsheet Url instead of id

* Ordering of methods

* Removed logging

* Add tests for Dynamic text controls

* Add tests for url helpers

* Fix coverage config

* Nevermind

* Interface changes

* There is no body here

* Yay to hints

* Delete row field is separately handled as row index

* placeholder support (#4001)

* Fixed tests, typos and creating new sheets with random rows

* Switched to using 'rowIndex' throughout

* binding path added for query input field (#4016)

* - Fixed QA bugs (#4032)

- Split delete sheet into two
- Removed dynamic query input types from hidden keys

* Proper exceptions

* Removed extra logging

* Throw exception if update method does not match any of the columns

* Same for bulk update

* Zero-indexed delete row

* I'm a space bound rocket ship

* Logic to register installations with cs (#4062)

* Logic to register installations with cs

* Clean up

* Casting to string

* Checking to see if this makes the test pass

* Added an extra null check

Co-authored-by: Piyush <piyush@codeitout.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-04-22 09:00:09 +05:30
Hetu Nandu
6c681ef98c
Fix initial value check for action form config (#4080) 2021-04-21 13:18:24 +05:30
Trisha Anand
eaa24ca894
[Bug Fix] : Fetch actions by id during refactor action name to solve IncorrectResultSizeDataAccessException for pages where duplicate action names exist (#4030)
* New dto for refactoring action name which includes actionId as well

* Refactor action name now also takes actionId as payload and fetches the action from db by id instead of name to solve for the scenario where the action names could be duplicated.

* Adding actionId to QP of action refactor API.

* WIP : test for asserting the bug fix

* WIP test

* Fixed the test case asserting refactoring works for an action when there are duplicate action names in the page.

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2021-04-19 12:35:10 +05:30
Hetu Nandu
363bee8ec9
Fix action field evaluation for editor (#3701) 2021-03-30 10:59:03 +05:30
Arpit Mohan
660c194009
Moving all toast messages to messages.ts file (#2798)
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-03-13 19:54:45 +05:30
Hetu Nandu
0b08edf5cc
Fix further cyclical dependencies in actions (#3259) 2021-03-01 20:27:15 +05:30
Piyush
faea2f36ff
Add support for setting.json for pluginType DB (#3156) 2021-02-23 13:57:37 +05:30
Piyush Mishra
56170b0cdf
Null check in getConfigInitialValues (#3043) 2021-02-15 21:43:20 +05:30
Rishabh Saxena
1a593e1981
add default values to payload while creating a new action (#2976)
Fix default values not sent as payload while creating a new action
2021-02-11 17:17:21 +05:30
Hetu Nandu
40e42b296d
Fix for timeout being sent in a different location (#2708) 2021-01-26 08:42:52 +05:30
Piyush Mishra
148497a1bc
Refactor datasources and actions for stronger type checking (#2167) 2021-01-12 09:47:28 +05:30
akash-codemonk
1a35bb1e75
Onboarding flow (#2311) 2020-12-30 13:01:20 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Arpit Mohan
a942dc198e Revert "Onboarding flow (#1960)"
This reverts commit e84699e7ba.

Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
2020-12-22 13:02:02 +05:30
akash-codemonk
e84699e7ba
Onboarding flow (#1960)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-12-18 18:48:47 +05:30
Pawan Kumar
5553da02e8
Fix: Page crashes on cloning the API (#2087)
* fixed the page crashig on cloning the api

* adding test cases

* comment out the drag and drop test case in input spec

* update test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-10 13:52:40 +05:30
devrk96
fee1a4518f
Feature: Toast component (#476) 2020-11-24 12:31:37 +05:30
akash-codemonk
d652c1485d
Update the action config with the datasource info (#1451) 2020-10-30 11:54:15 +05:30
Nikhil Nandagopal
fcb6c4c43c
added data source name to query creation (#1068) 2020-10-07 19:40:08 +05:30
Nikhil Nandagopal
194f27aabb
Feature/analytics (#1022)
* added appname to PAGE_LOAD data and fixed getCurrentApplication method

* Fixed analytics to save and test datasources

* fixed analytics for create action

* added event for action execution

* added a type for event location
2020-10-06 20:40:21 +05:30
Nikhil Nandagopal
3fdd0a246a
Feature/instrumentation (#744)
* bumped sentry version
modified performance monitor to use a queue internally to make synchronous logging easy
added logging for api pane close / open and various different methods

* added use effect to stop tracking on mount of entity properties

* removed open api tracking

* fixed stop tracking to pop from the end instead of the beginning
added tracking for editor mount and sidebar mount

* added tracking for entity explorer

* moved from app route to sentry app route because passing JSX to app route causes re-renders

* Fixing theme and route change issues.

* added performance tracking for API / Query execution and Page Load actions

* added isntrumentation to open / close actions

* added instrumentation for apis & actions

* reduced sample rate
added async tracking

* added tracking for property pane

* Remove tracking from reducer

* added option to attach async operations to parent transactions

* Fix typo

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-09-28 10:42:23 +05:30
akash-codemonk
dbfd986d0e
Add action settings tab to api and query pane (#434)
* Add action settings tab to api and query pane

- Ask for confirmation before running an action

* Update  property of actions basedon the updateLayout response

Prevent confirmation dialog for Action run, until  property of action is true

Send an API Request when the user toggles the  property of an Action

* update http method to toggle executeOnLoad for an action to PUT

* Fix save layout response type

* Remove console.log

* If updating executeOnLoad, avoid calling update action API

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2020-08-27 21:09:16 +05:30
Abhinav Jha
76072dcb04
Fix Entity Names (#439)
- Fix Page name restrictions to allow for spaces
- Keep new names of entities until failure
2020-08-27 16:05:15 +05:30
Abhinav Jha
613db73b15
Fix: Action move & copy issues (#381)
* Fix: When copying a query, the app tries to open the API page with the queryID

* Fix: When moving a query, the query input box is empty
2020-08-21 11:33:04 +05:30
satbir121
51ce6b320c
Fixing Application crashes when query is moved. (#350) 2020-08-19 11:17:54 +05:30
Abhinav Jha
e22a9c6dc6
Entity Explorer Fixes (#305)
* Fix: modal widget closes when navigating to the widgets pane from explorer

* Fix: Align API input tab with the headers

Fix: align delete and run buttons to the right in queries pane

* Fix: while dragging, the cursor must be 'grabbing'

* Set new widget name in editing mode

* Fix: While property pane is open, changing the widget name in entity explorer does not update the name in the property pane

* Fix: The expanded entity property value popup should not have a label, as its function is only to show the full version of truncated data

* Feature: Edit datasource name from entity explorer

* Fix: Allow users to navigate from the placeholder text

* Fix: When moving or copying apis, navigate to the moved or copied api
2020-08-14 12:48:30 +05:30
NandanAnantharamu
05f190c102
Feature/entity browse (#220)
# New Feature: Entity Explorer
- Entities are actions (apis and queries), datasources, pages, and widgets
- With this new feature, all entities in the application will be available
  to view in the new entity explorer sidebar
- All existing application features from the api sidebar, query sidebar, datasource sidebar and pages sidebar
  now are avialable on the entity explorer sidebar
- Users are now able to quickly switch to any entity in the application from the entity explorer sidebar.
- Users can also search all entities in the application from the new sidebar. Use cmd + f or ctrl + f to focus on the search input
- Users can rename entities from the new sidebar
- Users can also perform contextual actions on these entities like set a page as home page, copy/move actions, delete entity, etc from the context menu available alongside the entities in the sidebar
- Users can view the properties of the entities in the sidebar, as well as copy bindings to use in the application.
2020-08-10 14:22:45 +05:30
Hetu Nandu
01a3d4682f
Fix action batching issue (#181) 2020-07-28 16:11:51 +05:30
Hetu Nandu
fe43680abc
Action test fixes (#130)
* Fixes for tests
* remove marketplace tests
* fix some other tests
* Simplify update datasource
* Add cypress env variables
2020-07-21 19:31:51 +05:30
Hetu Nandu
70955de703
Create fetch actions workflow for view mode (#102)
* Create fetch actions workflow for view mode

* Remove config from autocomplete results
2020-07-15 18:31:35 +05:30
Hetu Nandu
0b86b503aa
Fix move/copy success/failure workflow (#47) 2020-07-07 13:37:37 +05:30
Hetu Nandu
13e173fa77
Action save fixes (#33)
- Increased timeout for move action
- Table header typescript fix
- Fix data tree selectors for better performance
- Debounce update action saga by 500 ms
- Query delete fix
- Query save fix
2020-07-06 19:05:31 +05:30
satbir121
86ea0e8cf2
Fixing api name reseting issue. (#34)
Co-authored-by: Satbir Singh <apple@apples-MacBook-Pro.local>
2020-07-06 09:49:49 +05:30
Hetu Nandu
4a6717889c
Streamline action save with widgets (#10)
- Remove drafts from actions
- Direct update action from forms
- Debounced saving of actions
- Add org id in default datasource
- Merge query and api run saga
2020-07-03 14:28:58 +05:30
Nikhil Nandagopal
faddd04cb3 updated query templates
added error message for all APIs
2020-06-29 18:18:21 +05:30
Satbir Singh
d640c03386 Query editor auto save. 2020-06-29 08:23:10 +00:00
Satbir Singh
84da0a63fb Fixing api name not getting saved. 2020-06-26 16:52:54 +05:30
Hetu Nandu
fb65b204a8 JSON stringify fixes 2020-06-25 10:04:57 +00:00
Akash N
b153c86f9c Fix query name not updating
- For queries take the payload as it is.
2020-06-23 16:40:26 +05:30
Satbir Singh
bf0c0d737f Changing response request structure. 2020-06-19 21:57:12 +05:30
Hetu Nandu
2d956644df Hot fixes 2020-06-19 13:06:45 +00:00
Hetu Nandu
ded1a130e3 Action draft fixes 2020-06-18 14:16:49 +00:00
Satbir Singh
fd3f4c2028 Fixing performance issue in apiName 2020-06-18 07:46:53 +00:00
Satbir Singh
98f65405a7 Handling api name change error. 2020-06-17 13:16:14 +00:00
Satbir Singh
7e3df81302 Api name editable. 2020-06-16 10:23:19 +00:00
Satbir Singh
13422048e4 Save api on edit. 2020-06-10 17:42:51 +00:00
Hetu Nandu
cb2867069f Action creator evaluated value fixes 2020-06-10 12:16:50 +00:00
Hetu Nandu
d9540f8927 Evaluated value popup 2020-06-04 13:49:22 +00:00