PromucFlow_constructor

Author	SHA1	Message	Date
Rudraprasad Das	8a9f486b8a	revert: multi env switcher view mode changes (#32360 ) Reverts changes for multienv switcher on view mode ## Automation /ok-to-test tags="@tag.MultiEnv" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8535416309> > Commit: `973e392a00cc68e0dbf1e99e06ca2b8b1ebc0474` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8535416309&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Simplified the handling of view modes and conditional rendering in the `BottomBar` component. - Removed and streamlined the `showBottomBar` logic and UI adjustments in `AppViewer`. - Introduced `isCombinedPreviewMode` for enhanced preview functionality in the Editor's `IDE` component. - Simplified the structure of `EditorWrapperContainer` by removing unnecessary props and logic. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-03 15:50:58 +05:30
Vemparala Surya Vamsi	4b27a59b1c	chore: remove feature flag code of consolidated api (#32248 ) Removed feature flag related code to consolidated api, also corrections in feature flags are made here. Fixes #31100 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/8490467344> > Commit: `fce48b210983689994152b7ae77c773cfdca854a` > Workflow: `PR Automation test suite` > Tags: `` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced new feature flags to enhance user interface and default settings. - Refactor - Simplified page loading logic for better performance. - Enhanced error handling and reporting for a smoother user experience. - Chores - Cleaned up unused imports and code for better maintainability. - Bug Fixes - Removed redundant checks and updated functionality to include new feature flags. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-01 17:45:09 +05:30
Aman Agarwal	af184f3cb0	feat: add edit option in suggested queries in hint commands (#32076 ) ## Description This PR introduces a new way to edit the queries directly from slash hint commands that edit button appears on hover of the hint. This also introduces an event `EDIT_ACTION_CLICK` as emitted from different other places of our application with all the similar properties except the `from` : `SlashCommandHint` <img width="566" alt="Screenshot 2024-03-27 at 12 45 09 AM" src="https://github.com/appsmithorg/appsmith/assets/7565635/34f0e226-d45a-482b-8484-7e1fdc672a04"> Fixes #32075 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8465758601> > Commit: `cff14b0006441274e182d17ff66603219971ddbd` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8465758601&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the code editor with improved command suggestions and quick command generation, including URL and event parameter handling. - Introduced new styling for command suggestions in the code editor. - Refactor - Updated functions and components for better handling and mapping of plugins within the code editor. - Chores - Added necessary imports and updated the usage of various components and utilities to support new features and improvements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-03-28 19:24:33 +05:30
Rudraprasad Das	30a995844e	fix: reinstating multienv switcher for view mode (#31699 ) ## Description Adds multiple env switcher to the bottom bar Fixes #31266 ## Automation /ok-to-test tags="@tag.MultiEnv" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8440725278> > Commit: `eae7d87a07c270a460049f124fe90277f997cd58` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8440725278&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a `BottomBar` component in the `AppViewer` for enhanced navigation and quick actions, conditionally displayed based on multiple environments and specific feature flags. - Added a custom React hook `useShowEnvSwitcher` to determine the visibility of the environment switcher based on various conditions. - Refactor - Improved visibility of the `SwitchEnvironment` component and `QuickGitActions` by adjusting their rendering logic, ensuring they are always visible when `viewMode` is false. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-28 12:09:13 +05:30
Ankita Kinger	cc57e4cf1b	fix: Updating the height of inputs form on the right pane of modules editor (#32127 ) ## Description Updating the height of inputs form on the right pane of modules editor. Fixes [#31955](https://github.com/appsmithorg/appsmith/issues/31955) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8459420351> > Commit: `86cf19080a9460b5464cacb319a7b33ef255ef12` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8459420351&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Style - Updated the `ActionSidebar` component to have a full height, enhancing its appearance and usability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-28 10:39:23 +05:30
Rishabh Rathod	5d47001dba	chore: Prepared statement description changes (#32042 ) ## Description Fixes https://github.com/appsmithorg/appsmith/issues/32045 ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8432564141> > Commit: `120b0d79d5c4139a92bba228bdcb476cf1f7710c` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8432564141&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Documentation - Updated information text related to using Prepared Statements in queries, emphasizing the prevention of SQL injections and highlighting limitations on dynamic bindings. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-26 14:09:35 +05:30
albinAppsmith	19d5d49dd0	chore: Added test for useGroupedAddJsOperations (#32003 ) ## Description This PR adds unit test for useGroupedAddJsOperations hook. Fixes #31875 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8419327183> > Commit: `5b4c16f5e718a0c6e2c5f056f4fc22c3eac27144` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8419327183&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Introduced tests for the `useGroupedAddJsOperations` hook to ensure it groups operations correctly. - New Features - Added tooltip functionality to operations in the Global Search feature. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-26 09:22:48 +05:30
sneha122	bd8850a48d	feat: show slash command prompt on focus in property pane (#31920 ) ## Description This PR adds builds on top of existing slash command menu feature. Today when we enter JS mode for any of the properties and type in `/` command, we are able to see the following menu. <img width="290" alt="Screenshot 2024-03-21 at 1 31 26 PM" src="https://github.com/appsmithorg/appsmith/assets/30018882/319d5be1-33f7-49e3-9b8d-fd8aa5fa9aed"> With the changes in this PR, now whenever we switch to JS mode for data property of Table and JSON form widgets, if we focus on the input box, we should be able to see the menu with options showing up as shown below: https://github.com/appsmithorg/appsmith/assets/30018882/30496f3c-615a-4a70-ba05-e0151c6bcdd5 Limitations: - This feature is only implemented for Table and JSON form widgets data property, based on mixpanel results we can further decide to include it for all or not. Fixes #31900 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8386142777> > Commit: `90bea1f91b3d864c984548b11ec4d3a5bd70b3f7` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8386142777&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> ## Summary by CodeRabbit - New Features - Enhanced the code editor to dynamically show a slash command menu for certain widgets, improving the user editing experience. - Introduced logic to selectively enable slash command functionality for table and JSON widgets, specifically for the `data` property. - Enhancements - Updated the code editor hint system to support additional context, including datasource information and feature flags, enriching the autocomplete and suggestion capabilities. - Bug Fixes - Fixed an issue where unnecessary bindings were applied to widgets, ensuring cleaner and more relevant code generation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced `CodeEditor` with advanced properties to support diverse functionalities including AI assistance and plugin integrations. - Introduced a function to determine the visibility of the slash command menu based on widget types. - Added specific widget properties for table and JSON widgets to enable focused functionalities. - Implemented a new feature flag to toggle learnability and ease of initial use improvements. - Tests - Added tests for Property Pane Suggestions functionality to ensure reliable autocomplete features. - Chores - Improved `PropertyPane` interaction by adding a method for focusing and asserting auto-save in text fields. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-03-22 15:14:08 +05:30
Ankita Kinger	2f738ed360	chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862 ) ## Description - Make edit launch buttons as links for better user experience - Add upgrade ramps for session timeout setting Fixes [#29829](https://github.com/appsmithorg/appsmith/issues/29829) [#31724](https://github.com/appsmithorg/appsmith/issues/31724) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8370510386> > Commit: `b45ae17a5f28fe4706a69cc0dd141e5bb5e8b225` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8370510386&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a session timeout setting for user sessions, enhancing security and compliance. - Improved admin settings interface with additional configuration options for session management. - Enhancements - Streamlined navigation within the application by removing reliance on default page IDs. - Enhanced input fields in admin settings with support for default values and custom formats. - Style Updates - Updated styling for labels, icons, and text inputs in the admin settings for better user experience. - Tests - Expanded Cypress test coverage for admin settings, including checks for business and enterprise settings, authentication, branding, and navigation. - Refactor - Simplified code by renaming constants and updating component properties for clarity and maintainability. - Chores - Updated Cypress configuration and support files for improved test automation practices. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-21 15:37:13 +05:30
balajisoundar	55191cb372	fix: [custom widget] remove stale keys from dynamicTriggerPathList (#31586 ) ## Description 1. Improve string pattern used to determine whether to show onReady function missing warning 2. Remove stale keys from dynamicTriggerPathList when user changes the event names 3. Clean up events when a custom widget unselected in editor Fixes https://github.com/appsmithorg/appsmith/issues/31682 Fixes https://github.com/appsmithorg/appsmith/issues/30276 Fixes https://github.com/appsmithorg/appsmith/issues/30204 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8337490694> > Commit: `4fcb4cab6960c9a4a459a2b97261a112363901e2` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8337490694&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new route for `CustomWidgetBuilderLoader` component, enhancing navigation and accessibility. - Enhanced the Custom Widget Builder with improved event handling and dynamic trigger path support. - Added a new styled `Container` for the Custom Widget component for better layout management. - Refactor - Improved configuration settings readability and consistency for New Relic integration. - Refactored `CustomWidgetBuilderService` for clearer modularity and enhanced message handling. - Optimized property editing and update logic within the Property Pane of the Editor. - Bug Fixes - Adjusted connection timeout in the Custom Widget Builder for a more responsive user experience. - Updated button sizes in the ConfirmationModal for consistency. - Tests - Added comprehensive test cases for `CustomWidgetBuilderService` and `Builder` classes. - Chores - Removed deprecated `UPDATE_SRCDOC_ACK` event, streamlining Custom Widget Builder events. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-20 14:31:03 +05:30
Nilansh Bansal	6763fa5abc	fix: Table and JSON Widgets columns max height adjusted (#31882 ) ## Description > This PR adjusts the maximum number of columns to be shown in Table and JSON Widgets to 4. <img width="842" alt="image" src="https://github.com/appsmithorg/appsmith/assets/25542733/55f85f98-2fc9-4fa1-960b-fc685d74b0d8"> Fixes #31833 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8355362590> > Commit: `576e01175a9427bbe8e2a463ad31881fc2875123` > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8355362590&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/EmbedSettings/EmbedSettings_spec.js > <li>cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts > <li>cypress/e2e/Regression/ClientSide/Widgets/Select/RTL_support.ts </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new property to enhance the layout consistency of draggable list controls. - Refactor - Updated the layout configuration for improved user interface consistency in list controls. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-20 08:50:46 +00:00
Rishabh Rathod	e96eac489a	feat: add support for sectionStyles in datasource editor form (#31817 ) ## Description In this PR, we add support for section styles in the datasource editor form. This gives the ability to configure input in different layouts like flex or block as required using CSS. Fixes https://github.com/appsmithorg/appsmith/issues/31321 ### Example #### DB config ``` const DBConfig = [ { sectionName: "Connection", id: 1, children: [ { children: [ { label: "Host address", configProperty: "datasourceConfiguration.endpoints[].host", controlType: "KEYVALUE_ARRAY", validationMessage: "Please enter a valid host", validationRegex: "^((?![/:]).)$", placeholderText: "myapp.abcde.arango.net", }, { label: "Port", configProperty: "datasourceConfiguration.endpoints[].port", dataType: "NUMBER", controlType: "KEYVALUE_ARRAY", placeholderText: "8529", }, ], }, { label: "Database name", configProperty: "datasourceConfiguration.authentication.databaseName", controlType: "INPUT_TEXT", placeholderText: "Database name", initialValue: "_system", }, ], }, { sectionName: "Authentication", id: 2, children: [ { children: [ { label: "Username", configProperty: "datasourceConfiguration.authentication.username", controlType: "INPUT_TEXT", placeholderText: "Username", }, { label: "Password", configProperty: "datasourceConfiguration.authentication.password", dataType: "PASSWORD", controlType: "INPUT_TEXT", placeholderText: "Password", encrypted: true, }, ], }, ], }, { id: 3, sectionName: "SSL (optional)", children: [ { label: "SSL mode", configProperty: "datasourceConfiguration.connection.ssl.authType", controlType: "DROP_DOWN", initialValue: "DEFAULT", options: [ { label: "Default", value: "DEFAULT", }, { label: "Enabled", value: "ENABLED", }, { label: "Disabled", value: "DISABLED", }, ], }, { sectionStyles: { display: "flex" }, children: [ { sectionStyles: { flex: 1 }, children: [ { label: "Use Client CA Certificate", configProperty: "datasourceConfiguration.connection.ssl.caCertificateType", controlType: "DROP_DOWN", initialValue: "NONE", options: [ { label: "Disabled", value: "NONE", }, { label: "Upload File", value: "FILE", }, { label: "Base64 String", value: "BASE64_STRING", }, ], hidden: { path: "datasourceConfiguration.connection.ssl.authType", comparison: "NOT_EQUALS", value: "ENABLED", }, }, { label: "Client CA Certificate File", configProperty: "datasourceConfiguration.connection.ssl.caCertificateFile", controlType: "FILE_PICKER", encrypted: true, hidden: { path: "datasourceConfiguration.connection.ssl.caCertificateType", comparison: "NOT_EQUALS", value: "FILE", }, }, { label: "Base64 Encoded Client CA Certificate String", configProperty: "datasourceConfiguration.connection.ssl.caCertificateFile.base64Content", controlType: "INPUT_TEXT", dataType: "PASSWORD", encrypted: true, hidden: { path: "datasourceConfiguration.connection.ssl.caCertificateType", comparison: "NOT_EQUALS", value: "BASE64_STRING", }, }, ], }, { sectionStyles: { flex: 1 , marginLeft: "20px"}, children: [ { label: "Use Server CA Certificate", configProperty: "datasourceConfiguration.connection.ssl.caServerCertificateType", controlType: "DROP_DOWN", initialValue: "NONE", options: [ { label: "Disabled", value: "NONE", }, { label: "Upload File", value: "FILE", }, { label: "Base64 String", value: "BASE64_STRING", }, ], hidden: { path: "datasourceConfiguration.connection.ssl.authType", comparison: "NOT_EQUALS", value: "ENABLED", }, }, { label: "Client CA Certificate File", configProperty: "datasourceConfiguration.connection.ssl.caServerCertificateFile", controlType: "FILE_PICKER", encrypted: true, hidden: { path: "datasourceConfiguration.connection.ssl.caServerCertificateType", comparison: "NOT_EQUALS", value: "FILE", }, }, { label: "Base64 Encoded Client CA Certificate String", configProperty: "datasourceConfiguration.connection.ssl.caServerCertificateFile.Base64Content", controlType: "INPUT_TEXT", dataType: "PASSWORD", encrypted: true, hidden: { path: "datasourceConfiguration.connection.ssl.caServerCertificateType", comparison: "NOT_EQUALS", value: "BASE64_STRING", }, }, ], }, { sectionStyles: { flex: 1 }, children: [], }, ], }, ], }, ]; ``` #### Screenshot ![image](https://github.com/appsmithorg/appsmith/assets/23132741/efd1c5d6-a9ed-4343-a6d4-c6358eed8369) ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8287804061> > Commit: `a501af69f04c4fe995aaa8120315668bef070cc5` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8287804061&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features* - Enhanced visual presentation of forms generated from JSON data with customizable section styles. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-18 16:02:02 +05:30
Aman Agarwal	c302c724d8	chore: removed onboarding flags ab_create_new_apps_enabled , ab_start_with_data_default_enabled (#31384 )	2024-03-15 11:13:14 +05:30
Hetu Nandu	3c59066b89	fix: Query Sorting control width	2024-03-14 15:21:54 +05:30
Ankita Kinger	7b19b3d351	fix: Refactoring fetching of icon for module instances (#31765 )	2024-03-14 14:31:44 +05:30
Hetu Nandu	d9b20e8c2b	feat: Rollout Side by Side (#31686 )	2024-03-13 13:12:08 +05:30
ashit-rath	eb828bba1d	fix: api module inputs pane width (#31708 ) ## Description Fix Action right pane width which affects the inputs section in modules Fixes https://github.com/appsmithorg/appsmith/issues/31592 ## Automation /ok-to-test tags="@tag.IDE, @tag.Datasource,@tag.Sanity,@tag.Visual,@tag.Datasource, @tag.GSheet" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8251966797> > Commit: `69515d9cc1d1eba61a92e998a57c121d3a051272` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8251966797&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved structure and styling of the sidebar component in the editor for better usability. - Reorganized editor form components for a more intuitive layout and navigation. - Simplified the editor's JSON to form conversion process for enhanced performance and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-13 11:36:11 +05:30
Ankita Kinger	be9b751539	chore: Refactoring code to show plugin based icons for module instances on EE (#31713 ) ## Description Refactoring code to show plugin based icons for module instances on EE Fixes [#30163](https://github.com/appsmithorg/appsmith/issues/30163) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8256707865> > Commit: `897cc28f1c8d15efb7789788aba89687b85a4916` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8256707865&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new interface for module metadata, including properties like module and plugin identifiers. - Added a new type property to the Module interface to distinguish module types. - Enhanced resource list loading with unique identifiers for each resource. - Implemented functionality to dynamically resolve and display icons based on module or plugin properties. - Enhancements - Updated the applications page to support workspaces more effectively, including active workspace identification. - Improved module selection and display across the application, allowing for a more integrated module management experience. - Refactor - Removed unused functions and components related to module icon resolution. - Streamlined the logic for fetching and displaying module-related information, including in action selectors and query editors. - Bug Fixes - Fixed an issue with resource object identification by introducing unique `id` fields. - Style - Added new class selector for module instance name editing, enhancing the styling options. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-13 11:11:36 +05:30
Ankita Kinger	99639d446e	fix: Homepage error message with no workspaces & Github changes message (#31691 ) ## Description - Fixing error message on homepage when there are no workspaces - Fixing leave workspace leading to no workspaces message - Fixing github changes list message on the git modal with modules & module instances - Adding doc link for packages Fixes [#30748](https://github.com/appsmithorg/appsmith/issues/30748) [#31472](https://github.com/appsmithorg/appsmith/issues/31472) [#30214](https://github.com/appsmithorg/appsmith/issues/30214) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8247923955> > Commit: `6cd2ef6f4cfb2f12f251d6a4ad26e48fe88e78f8` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8247923955&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added new categories (`PACKAGES`, `MODULES`, `MODULE_INSTANCES`) to track changes in Git Sync more effectively. - Introduced a new constant for accessing the packages overview documentation. - Enhancements - Improved icon determination logic for queries based on their configuration. - Enhanced user experience by redirecting to "/applications" after leaving a workspace. - Refactor - Optimized the `leaveWS` function for better performance. - Updated selectors and reducers to handle new Git Sync tracking categories. - Tests - Expanded test coverage to include tracking of modified packages, modules, and module instances. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-12 18:14:05 +05:30
Ayush Pahwa	d2c64344f9	chore: workflow ds icon update and beta card updates (#31681 ) ## Description - Bumped version for for ds packages - Added `isBeta` flag to action operations to add BetaCard for EE repo Fixes #31357 ## Automation /ok-to-test tags="@tag.Sanity @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8245228575> > Commit: `8cdee76bccace3a148077e983793475b75751592` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8245228575&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the query list to include descriptions for beta features, improving user guidance and understanding of new functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-12 14:00:42 +05:30
balajisoundar	cf6ba4c8fd	chore: Remove FEATURE_FLAG release_custom_widgets_enabled (#31577 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description > Add a TL;DR when description is extra long (helps content team) > > Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation > and context. List any dependencies that are required for this change > > Links to Notion, Figma or any other documents that might be relevant to the PR > > #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Removed feature flag checks and related functionality across the application, impacting widget visibility and behavior. - Tests - Updated test setups and cases to align with the removal of feature flag dependencies. - Chores - Cleaned up unused code and constants related to the now-removed feature flags. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-08 11:50:35 +05:30
Apeksha Bhosale	047134d7ce	fix: missing js arguments so making it optional (#31550 )	2024-03-06 14:53:44 +05:30
Ayush Pahwa	0a5255c5dd	feat: workflow queries/actions rename code split (#31300 ) ## Description This PR is code split PR for allowing rename of queries, actions and apis for workflows editor. This PR introduces update in the type of the query rename payload API. #### PR fixes following issue(s) Fixes #30963 #### Type of change - Bug fix (non-breaking change which fixes an issue)	2024-03-05 10:28:34 +05:30
Ayush Pahwa	5fdc0a1ef9	feat: workflows assign request on browser (#31159 ) ## Description We are allowing users to have write workflows assign request queries in the JS object editor for the workflows editor. This means, users should get autocomplete for `appsmith.workflows.assignRequest` and the arguments required should be shown in the autocomplete also. To enable this, following changes have been made 1) Add empty workflows object to the appsmith function type in store and and add ee only type definitions to the `EntityDefinitions` for appsmith namespace. 2) Replace entityFunctions as static variable and use a function which appends EE entity functions. 3) Added types for ee only functions 4) Retain the `isMainJsObject` flag for the js file when updates happen. #### PR fixes following issue(s) Fixes # (issue number) #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced new autocomplete definitions for enhanced code editor suggestions. - Added support for categorizing entities in the Explorer panel using `GROUP_TYPES` for improved organization and navigation. - Refactor - Updated the action helpers and reducers to support new properties and ensure state consistency. - Improved the structure for autocomplete helper functions, facilitating easier extension and maintenance. - Chores - Established foundational code for future development with empty enums and placeholder functions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-04 19:56:47 +05:30
Pawan Kumar	8db4cd3872	chore: create inline buttons widget (#31318 ) Fixes #30438 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new `ButtonGroup` component that manages groups of buttons with customizable properties like color, size, and orientation. - Added a `ButtonGroupItem` component for rendering buttons within the `ButtonGroup`. - Launched an "Inline Buttons" widget allowing users to configure a group of buttons inline with various properties such as labels, visibility, and icons. - Enhanced icon loading with fallback styles for better spacing and appearance. - Refactor - Updated various components (ActionGroup, Button, Menu) to use new `ButtonGroupProps` and `ButtonGroupItemProps`, aligning with the new `ButtonGroup` component structure. - Renamed widget names and updated configurations to improve clarity and consistency across the application. - Bug Fixes - Fixed feature flag checks to directly return `true` for specific flags, ensuring feature availability checks are more efficient. - Documentation - Added comprehensive story and documentation for the `ButtonGroup` component, showcasing its usage with different options. - Chores - Enhanced internal codebase by optimizing the `Icon` component performance through memoization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-03-04 10:28:11 +03:00
Hetu Nandu	1d4198048c	chore: Debugger Split states (#31043 ) ## Description Creates local states for the debugger for Query Pane, Api Pane and JS Pane and separates it from the main Canvas Debugger state. This is done so that in Split pane, the states of Action Pane debugger can be different from the Canvas Debugger state. To keep handling the Fullscreen Debugger experience, a new hook `useDebuggerTriggerClick` is introduced which opens the correct debugger based on the IDE state. Also removes the Error and Logs from the Query / Api / JS Debuggers when in split screen mode for a cleaner debugging experience ##### This change removes the expectation of having a common debugger state that follows around as the user navigates in the IDE. Instead it create a new debugger state per entity item. The tests have been updated to reflect this #### PR fixes following issue(s) Fixes #30836 Fixes #30342 #### Media #### Type of change - Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Testing #### How Has This Been Tested? - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed	2024-02-29 11:53:57 +05:30
albinAppsmith	0640b5ed93	fix: Run button hiding issue (#31323 ) ## Description Run button in queries and js page was getting squeezed when file name is longer. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/31298 #### Media Before https://github.com/appsmithorg/appsmith/assets/87797149/5948c7ad-1c29-489a-8857-004876261c6c After https://github.com/appsmithorg/appsmith/assets/87797149/758b2cec-1e05-4ebf-903c-9fa16f3b6489 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Style - Enhanced styling and layout control across various editor components for improved user experience. - Adjusted widths and overflow properties for cleaner, more consistent visual presentation. - Introduced new layout properties to components for better alignment and spacing, ensuring a more intuitive interface. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-28 14:25:22 +05:30
albinAppsmith	32955bcab8	feat: Added modal for action creator new query option (#31210 ) ## Description Before, when use clicks on new query from action selector, omnibar used to show to create a new query. This PR removed showing omnibar and instead will start showing a modal with similar content as add pane. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/31217 #### Media Before https://github.com/appsmithorg/appsmith/assets/87797149/641a1409-bc9c-42be-907f-02157faf901e After https://github.com/appsmithorg/appsmith/assets/87797149/c1ee3d29-1fef-4de2-8c34-3e2bedc4081f #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new modal for creating items, enhancing user interaction and productivity. - Added omnibar trigger sources to refine search functionalities based on the context of use. - Implemented a function to dynamically generate messages for creating new items, improving user guidance. - Enhancements - Enhanced the global search by including additional trigger sources, allowing for more precise search operations. - Improved the property pane with a toggle for a new creation modal, streamlining the process of adding new items. - Refactor - Optimized query list item creation and management within the editor, ensuring a smoother user experience. - Refined action dispatch mechanisms to better support side-by-side editing modes. - UI Improvements - Updated the UI to include a new create new modal, making it easier for users to add queries and other items. - Enhanced search results handling to better accommodate different trigger sources and editor modes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-27 11:58:20 +05:30
Aman Agarwal	acf51cc91b	feat: js enabled by default for 1 click binding (#31162 )	2024-02-26 14:03:36 +05:30
Vemparala Surya Vamsi	5b18d35a52	chore: decouple evaluatedValues from evaluated window popup (#31127 ) ## Description Decouple evaluatedValues from the evaluated window popup, All property pane evaluations will be decoupled from __evaluations_.evaluatedValues segment of the dataTree. #### PR fixes following issue(s) Fixes #31129 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Refactor - Enhanced the efficiency of value retrieval in the `CodeEditor`, `PrimaryColumnsControl`, and `PrimaryColumnsControlV2` components by simplifying the path retrieval process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-16 17:37:56 +05:30
Hetu Nandu	596f84934c	fix: Debugger shows up with no tab selected (#31126 ) fixes: #31124 Updates the debugger showing logic for Schema tab <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Updated the debugger to not render certain tabs (response, header, or schema) when selected in the bottom bar, enhancing the interface's usability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-15 11:47:56 +05:30
Apeksha Bhosale	c655aea15c	chore: Import debugger fixes (#31080 ) ## Description To add debugger error for import path for module instance on EE, this PR enables code to be extended on EE #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated import paths and references for `ENTITY_TYPE` to `EntityTypeValue` across various components and utilities for improved code consistency. - Reorganized import statements related to `AppsmithConsole` utilities and constants to enhance code maintainability. - Adjusted usage of enums and types, specifically for entity and platform error handling, to align with updated import paths. - New Features - Introduced utility functions for handling entity types and platform errors in AppsmithConsole, including new constants and error retrieval functions. - Added a new enum value `MISSING_MODULE` to better categorize log types in debugging scenarios. - Bug Fixes - Implemented changes to error logging and handling mechanisms, including the addition of new case handling for `LOG_TYPE.MISSING_MODULE` in debugger logs, to improve the debugging experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-14 12:00:18 +05:30
albinAppsmith	ac0f67797e	fix: UI fixes pages section (#31098 )	2024-02-14 10:03:52 +05:30
sneha122	3b3b3b4476	fix: disabled feature walkthroughs behind a flag (#31007 ) ## Description This PR removes the feature walkthroughs that were added as part of one of the activation experiments in Q3. Although these walkthroughs were useful in guiding users, they were appearing in untimely and incorrect fashion. #### PR fixes following issue(s) Fixes #30339 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a feature flag to toggle the feature walkthrough on or off. - Added the ability to force display the feature walkthrough regardless of the feature flag setting. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-02-13 16:44:59 +05:30
Hetu Nandu	fb0472d241	chore: show suggested widgets in response (#31008 ) ## Description Show the Suggested widgets panel in the response pane in the bottom instead of the right side. This will greatly simplify the Query and Api screens. - Removes functionality of suggested widgets from the right pane context - Only renders the right pane if `additionalSections` is passed - Adds a new Bind Data button in the Response Pane - OnClick of button, a menu with suggested widget bindings show up #### PR fixes following issue(s) Fixes #30968 #### Media https://github.com/appsmithorg/appsmith/assets/12022471/20e239ad-dea4-4755-b199-4f0920ae1d46 #### Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Introduced a new `BindDataButton` component for easier data binding to widgets in the visual editor. - Updated UI elements and interactions in the API and Query editors for improved usability. - Added an import statement for `Widgets` from the `DataSources` module. - Changed the method call from clicking on a suggested table widget to adding a suggested widget of type `Table`. - Refactor - Simplified and streamlined the `ActionRightPane` component by removing outdated functionalities. - Adjusted UI components and layouts across various editor components for better consistency and usability. - Bug Fixes - Fixed text inconsistency in the `CONNECT_EXISTING_WIDGET_LABEL` constant. - Removed unnecessary `useEffect` hook in the `EntityBottomTabs` component to improve performance. - Chores - Removed deprecated code and unused imports across several files to clean up the codebase. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-13 13:52:04 +05:30
Valera Melnikov	d7cd02a45d	fix: add testing library eslint rules (#31028 ) Added recommended rules for testing library <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added `data-testid` attributes across various components for improved test identification. - Tests - Enhanced test cases with asynchronous handling (`async`/`await`) for more reliable user interaction simulations. - Transitioned to using `getByTestId` instead of `queryByTestId` for better assertion reliability in tests. - Added `await` before the `userEvent.click(el)` statement in the ChartWidget test file. - Updated the destructured variable names from `queryByTestId` to `getByTestId` in the DividerWidget test file for improved clarity. - Added an import for `screen` from "@testing-library/react" and updated element querying in the TabsWidget test file. - Chores - Updated ESLint configurations to include testing-library plugins and rules, improving code quality and consistency in test files. - Removed unnecessary `cleanup` function calls after tests, following best practices for test cleanup. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-12 18:59:10 +03:00
balajisoundar	b30af2144e	feat: [Custom widget] JS editor error highlight on the builder (#30990 ) #### PR fixes following issue(s) Fixes #30988 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the Code Editor with the ability to display custom errors alongside lint errors, improving the feedback loop for developers. - Refactor - Improved error handling logic in the Code Editor and Custom Widget Builder for a more accurate and user-friendly debugging experience. - Bug Fixes - Fixed an issue in the Custom Widget's console error logging method, ensuring more consistent error reporting. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-12 16:29:03 +05:30
Pawan Kumar	541c85ca97	chore: Create toolbar widget (#30910 ) Fixes #30439 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced feature flag checks to directly return `true` for specific flag names, improving efficiency. - Updated the `ButtonListControl` component to support separators between buttons for better visual distinction. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-02-12 10:54:44 +03:00
Rudraprasad Das	5c74768afc	chore: remove git release feature flags (#30962 ) ## Description Removes git related feature flags - `release_git_connct_v2_enabled` - `release_git_status_lite_enabled` #### PR fixes following issue(s) Fixes #30961 #### Media #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced Git synchronization features including better handling of workspace creation, DSL additions, and branch protection settings. - Refactor - Updated Git connection methods and deployment processes for improved efficiency and reliability. - Introduced new variables and methods for more precise control over Git settings and operations. - Tests - Added and refactored Cypress end-to-end tests to validate new Git functionalities and synchronization processes. - Style - Updated components to include `data-testId` attributes for improved testability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-09 10:22:47 +05:30
Diljit	007e70a757	fix: Remove stale values in Query form on view change (#30975 ) ## Description - Add a Mixpanel event for Max limit validation for Multi file picker - Fix the bug where stale values of the Query pane form gets populated in the Query editor when changing views. Fixes # (issue number) https://github.com/appsmithorg/appsmith-ee/issues/3499	2024-02-09 09:36:45 +05:30
Hetu Nandu	1afe639911	chore: Show schema as a tab instead of the right pane (#30906 ) ## Description Moves the Schema in Query Pane from the right side to the tab on the bottom. This is done to eventually remove the right side pane for Side by Side layout #### PR fixes following issue(s) Fixes #30873 #### Media https://github.com/appsmithorg/appsmith/assets/12022471/28c5086a-1967-4a72-8dc5-0717751198cf #### Type of change - New feature (non-breaking change which adds functionality) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. - [ x ] Manual - [ x ] Jest - [ x ] Cypress <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a refresh button in the datasource structure container for easy refreshing. - Added a new state to handle scenarios with no columns to display, enhancing user feedback. - Implemented conditional rendering of components based on new props and states, improving UI responsiveness and interaction. - Enhancements - Updated placeholder texts and messages for a clearer user experience. - Improved the layout and styling of various components for better visual appeal and usability. - Refactor - Streamlined the rendering logic and state management in several components, leading to a cleaner codebase. - Removed unused imports and functions, optimizing component performance. - Bug Fixes - Fixed issues in test suites related to table schema handling and selection. - UI Changes - Adjusted styling properties for better alignment, display, and gap spacing in the datasource structure search container. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-08 13:25:23 +05:30
Rishabh Rathod	70d1e33542	fix: Entity props show evaluated value (#30889 ) ## Description - Header bg color white. - Make the `entityProperties` generation code extendable so the module-related code can be moved to the EE repo. - Made the Binding text color similar to how it looks in code. - Binding popup stays open on the widget select change and shows newly selected widget's binding. #### PR fixes following issue(s) Fixes #30670 Fixes #30648 #### Type of change - Bug fix (non-breaking change which fixes an issue) <hr/> ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress ### Test Plan #### Steps to test the changes 1. Go to the application 2. Add widgets, query and JS function 3. Connect the widget with the query to show the data on canvas 4. Go to the entity explorer and click on more options to select "Show bindings" 5. Check the bindings for the respective entity. https://github.com/appsmithorg/appsmith/assets/23132741/0bf073d0-69f3-46f8-9107-c3fc48c7eb8f ### Issues raised during DP testing - [x] Noticed that the `Query.data` doesn't show the evaluated values ( added by @rishabhrathod01 ) - [x] The binding popup doesn't close when clicked on any other widget. ( added by @rishabhrathod01 ) <hr/> ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <hr/> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Introduced functions to fetch and organize properties for various entity types in the application. - Refactor - Streamlined entity property extraction by removing redundant functions. - Optimized the `EntityProperties` component for better event handling and rendering based on entity type. - Style - Adjusted layout and styling of the `EntityProperties` component for improved user interface. - Documentation - Enhanced documentation for the `EntityProperty` component. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-07 14:34:03 +05:30
Hetu Nandu	e68cf54360	chore: Make App Sidebar Generally Available (#30923 ) ## Description Makes App Sidebar Generally Available - Removes any feature flag control for App Sidebar - Removes any older functionalities to handle non App Sidebar IDE versions like: - App Settings having an open or close state - Entity Explorer ability to be hidden - Removes the announcement for App Sidebar #### PR fixes following issue(s) Fixes #29232 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Streamlined component logic by consolidating functions and removing unnecessary dependencies. - Simplified rendering and logic flow in various editor components for improved user experience. - Style - Enhanced styling and layout in the app settings pane and editor sidebar components. - Chores - Improved code maintainability by cleaning up unused imports, variables, and functions. - Bug Fixes - Addressed UI inconsistencies by removing deprecated feature flags and adjusting component behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-07 11:25:23 +05:30
Valera Melnikov	f14b40cef6	fix: fix modal position and styles (#30805 ) ## Description Fixes for the modal widget: 1. Added support for clickOutside. The modal is closed only by clicking on the backdrop overlay. A click on the widget name has been added to the exceptions for close event. 2. Fixed the positioning of the modal. Now it is located in the center of the provider. 3. For the correct positioning of the modal, it was necessary to make fixes for canvas height. The fixes also affect fixed and autolayout. #### PR fixes following issue(s) Fixes #30788 Also fixed this https://www.notion.so/appsmith/Canvas-gets-cut-off-on-preview-mode-525b95f26c6e4644bf5ab7389c02e434 #### Media https://github.com/appsmithorg/appsmith/assets/11555074/6db9ecde-595b-4fa4-a21b-9ed08930d58f #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [x] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Popover and Modal components now support dismissing by clicking outside. Custom logic and selectors can be specified to control this behavior. - Enhancements - Simplified logic for closing Modals by directly setting open state. - Enhanced Modal styling options, allowing for better customization of width and height. - ErrorBoundary component now supports custom styles. - Refactor - Removed redundant code and unused properties across various components and layout systems. - Simplified state management and styling adjustments in editor components. - Style - Updated Modal component styles for improved layout and responsiveness. - Chores - Codebase cleanup including removal of unused classes, variables, and adjustments for more efficient layout rendering. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-06 10:26:47 +03:00
Hetu Nandu	fa2b44c646	chore: Move action redesign into its on flag (#30886 ) ## Description Create a new Feature flag called `release_action_redesign_enabled` and use that for Query Redesign paths instead of Side by Side Feature flag as now it is out of its scope Post this, query redesign changes will not show up for any side by side feature activation scenarios resolves #30911 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new feature flag `release_actions_redesign_enabled` to toggle the redesigned actions feature. - Refactor - Updated components and logic to utilize the new `release_actions_redesign_enabled` flag, ensuring a consistent toggle mechanism across the application. This includes changes in the dynamic text field behavior and action toolbar rendering. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-06 12:26:33 +05:30
Nirmal Sarswat	479f9132bd	feat: Add knowledge retrieval in Appsmith AI (#30725 ) ## Description Frontend Changes - Remove Appsmith AI Query as a default datasource query - Add Appsmith AI Datasource in the AI section of Datasources screen - ~~Creation of Appsmith AI datasource to mimic the mock datasource flow. This was necessary because we are using a trigger in the datasource edit form and inorder for the trigger to function the datasource needs to be created before the trigger call.~~ (We are using the plugin trigger to upload files and hence this change is not required anymore) - Add a new Form control element to support multiple file uploads. The multiple file upload control type can either upload the files to the trigger end point (multipart-form trigger api) or save the files as base64 string in the datasource configuration. If the files are uploaded in the trigger, only the file metadata (name, size, mimeType and id) is saved in the datasource configuration. - Fix a bug in Dropdown control. This fix makes sure that the options that are disabled as infact disabled on the UI. - Add preview for the new Multi file picker control type. Backend Changes - Add a new trigger end point for datasource to support multipart form data - Add trigger for Appsmith AI datasource to upload files during datasource creation/edit flow - Associate the file ids with the datasourceId in AI Node server - Add Knowledge retrieval implementation in text generation action for Appsmith AI datasource - Add form.json for Appsmith AI Datasource - Add a fetch files trigger for populating the files in the Text generate action. #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a multiple file picker control for users to select and upload multiple files with options for file types and size limits. - Added new AI Query functionality with enhanced file upload capabilities, including timeout settings. - Enhanced datasource editor to display the number of uploaded files or a message if no files are uploaded. - Bug Fixes - Simplified the logic for showing the datasource selector by removing specific conditions related to the Appsmith AI Plugin. - Refactor - Removed unused imports and functionalities related to Appsmith AI across various components. - Updated plugin handling to dynamically determine button text based on plugin type. - Chores - Implemented backend support for file upload and association with datasources and workspaces. - Added new utility functions and DTOs for handling file uploads and AI plugin interactions. - Documentation - No visible changes to end-users. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Diljit VJ <diljit@appsmith.com>	2024-02-05 17:15:45 +05:30
albinAppsmith	4177230391	feat: Variable width for property pane size and side by side editor (#30550 )	2024-02-05 08:52:18 +05:30
Apeksha Bhosale	c1bbc97832	fix: restrict the module query being shown in Inputs autocomplete area (#30624 ) ## Description restrict the module query being shown in Inputs autocomplete area #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced autocomplete capabilities within the code editor for a smoother user experience. - Refactor - Streamlined autocomplete logic for better maintainability and performance. - Style - Adjusted input text control to accommodate new autocomplete features. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-02 11:36:37 +05:30
Hetu Nandu	545873c265	chore: Update Query view for side by side (#30655 ) Updates view of Query / Api and JS to not show the header and right side panels in side by side view fixes: #30658 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a compact query editor interface for specific action types. - Added conditional rendering in various components based on the `isSideBySideEnabled` feature flag. - Launched new components for enhanced query editor functionalities, including `QueryEditorCompact`, `FormRender`, `QueryEditorHeader`. - Enhancements - Updated selector functions to filter out falsy values, improving data quality. - Refined UI and functionality in the API and JS editors, focusing on user experience. - Refactor - Removed unused imports and variables, streamlined component structures, and updated UI component placements for clarity and efficiency. - Optimized form rendering logic and action execution handling in the query editor. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-31 10:37:40 +05:30
Aman Agarwal	224fd83f50	fix: query/api right pane binding section scroll, schema on expand empty screen (#30718 ) ## Description This PR fixes : - Api / Query Right side pane `Binding` section has too many scrolls if there are multiple widgets on the canvas ![image](https://github.com/appsmithorg/appsmith/assets/7565635/4a3a88b3-1293-4044-aed5-6f0b7e83a4d1) - Api / Query Right side pane `Schema` section has empty screen if the query has previously run with `Binding` section expanded and `Schema` section collapsed <img width="278" alt="Screenshot 2024-01-29 at 6 31 29 PM" src="https://github.com/appsmithorg/appsmith/assets/7565635/44e16ebe-9b45-4a05-90e1-4fb6b50cb0bc"> To reproduce the 2nd issue : - Create a mock datasource - Create a query on top of it - Run the query - Go to canvas page - Come back to the query - Expand the schema section, you will notice empty screen #### PR fixes following issue(s) Fixes #29322 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Style - Updated styling logic in various components for improved spacing and layout. Changes include adjustments to padding and margins for a cleaner user interface. - New Features - Enhanced the `DatasourceStructure` component to dynamically adjust its container height for better user experience and display consistency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-30 23:46:30 +05:30

1 2 3 4 5 ...

2503 Commits