8a68347952
12780 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Aman Agarwal
|
8a68347952
|
feat: added key pair auth for snowflake behind feature flag (#34399) | ||
|
Shrikant Sharat Kandula
|
3a8139e3be
|
chore: Fix .equals on subclasses of AuthenticationDTO (#34451)
**/test sanity datasource** <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9657231521> > Commit: a88e9b94b4263f20c43a8da9154822182d62855c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9657231521&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.Datasource` > It seems like **no tests ran** 😔. We are not able to recognize it, please check <a href="https://github.com/appsmithorg/appsmith/actions/runs/9657231521" target="_blank">workflow here</a>. <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Enhancements** - Improved equality and hashing behavior for various authentication classes, enhancing data integrity and consistency across the app. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
aa773f6950
|
chore: Strict payloads for update action and gen template API (#34446)
Part of #33724. This PR fixes a few more APIs to pass just the fields that the server expects, and nothing more. /test sanity datasource <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9648180689> > Commit: 874f9f1a721108d36dae5719fa842d595bd9281d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9648180689&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.Datasource` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved payload structure for `updateAction` and `moveAction` methods to enhance API request consistency. - Updated `updateApplicationTheme` method to refine the payload before making API calls. - Modified `generateTemplatePage` method to update the request payload, improving API interaction. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rahul Barwal
|
411122ec56
|
fix: Refactor dynamic bindings in widgets during building block paste. (#34318)
## Description * This pull request refactors the function `handleButtonDynamicTriggerPathList` to `handleWidgetDynamicTriggerPathList` in order to make it more generic and handle dynamic trigger paths for all types of widgets. * Additionally, the pull request moves the function `handleIfParentIsListWidgetWhilePasting` out of `handleSpecificCasesWhilePasting` to handle compound cases where the parent of the current widget needs to be checked. * Improves the nested object value replacement logic in `PasteWidgetUtils`. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Templates, @tag.Widget, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9656587968> > Commit: 4b821787d7ab5ad302b458c726c632b1e43b49e4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9656587968&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Templates, @tag.Widget, @tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified handling of pasting widgets by consolidating functions. - Improved logic for handling widget pasting scenarios. - Reorganized function names for better clarity and consistency. - **Bug Fixes** - Enhanced the handling of widgets when their parent is a list widget during pasting. - **Tests** - Updated test cases to reflect changes in widget pasting logic and function names. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Jacques Ikot <jacquesikot@gmail.com> |
||
|
Sagar Khalasi
|
e6e4b98492
|
ci: To improve readability sorted tags in tags.js (#34452)
## Description To improve readability sorted tags in tags.js Fixes #34419 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/9656608059> > Commit: c45654a04119910854b5f9e7989f42ccf76356a1 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added new tags for enhanced categorization, including `@tag.Audio`, `@tag.Auditlogs`, `@tag.Authentication`, `@tag.Camera`, `@tag.Form`, `@tag.Image`, `@tag.Video`, and many more to improve content organization. - **Removals** - Removed outdated or redundant tags like `@tag.Git`, `@tag.Widget`, `@tag.Slider`, and `@tag.Input` for better clarity and relevance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Abhijeet
|
992bbdb7c8
|
chore: Update Postgres port for TED in CI (#34430)
## Description PR to update the Postgres posrt for TED container in CI. /test all ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9646981763> > Commit: d998c6fe77ac2acdb71888fe6b3d7603ddda508c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9646981763&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated Docker port mapping from `5432` to `5433` across multiple CI workflow files to ensure consistency and avoid port conflicts. - **Bug Fixes** - Adjusted PostgreSQL connection port from `5432` to `5433` in test fixtures and scripts to align with environment changes and prevent connection issues. - **Tests** - Modified test scripts to handle new PostgreSQL port settings for improved reliability in testing scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
dc79ebb918
|
test: Remove unused data in DSL fixtures (#34405)
Part of #33724. We have a lot of fixture files in our Cypress tests with DSLs of various kinds. They are used to update the DSL using the `/api/v1/layouts/{layoutId}/pages/{pageId}?applicationId={applicationId}`. This API, is [in this line in `LayoutControllerCE`]( |
||
|
Shrikant Sharat Kandula
|
d86c855ef2
|
chore: Strict schema for datasource and action APIs (#34366)
Part of https://github.com/appsmithorg/appsmith/pull/33724. This is an effort to harden the server in terms of what request payloads are acceptable. **/test all** <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced API request payload handling for creating actions to include additional properties, improving data integrity and server-side validation. - **Improvements** - Refined data manipulation and payload structures in datasource-related API requests for better compatibility with server requirements. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9626214547> > Commit: fe5db45aeb916b176aec3ded06f1a9da1bf08898 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9626214547&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: `` > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor3_spec.ts > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_1_spec.js > <li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_2_spec.js </ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. <!-- end of auto-generated comment: Cypress test results --> |
||
|
Valera Melnikov
|
99c51a99ae
|
fix: don't call modal onClose method in edit mode (#34432)
## Description Fix modal onClose method in edit mode Fixes #33861 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9643445303> > Commit: 179602e52dcc2cdcaeecc5f67af5bc4ac12ee431 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9643445303&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved modal widget behavior to ensure it checks for disableWidgetInteraction before closing, preventing unwanted closures. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ashok Kumar M
|
ed497dbe9c
|
chore: add tests for anvil modal. (#34347)
[](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=9GEnyEC) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #33740 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9643638292> > Commit: bcc4bbddaa50b0be16e41a3a51db4f6abe732e79 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9643638292&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced test cases for Anvil modals, covering interactions like opening, closing, drag and drop operations, and handling modal functions. - **Bug Fixes** - Enhanced testing capabilities with `data-testid` attributes for better identification and testing of components, particularly in detached widget drop areas. - **Refactor** - Updated the `Modal` component to use `dataAttributes` instead of `size` prop to streamline attribute handling. - Dynamic generation of modal class names based on properties for better styling and consistency. - **Style** - Adjusted styling for SVG elements within the `EntityExplorer` component, specifically modifying the height and width properties. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
Valera Melnikov
|
70398df10a
|
fix: wds widgets (#34387)
## Description - Remove click event from Stats - Remove validation section from SwitchGroup - Fix Inline button variant for added button - Fix paragraph default text - Fix inputs placeholders Fixes: #34189 #34002 #33753 #33242 #33243 #33186 #32509 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9615117095> > Commit: 15420c10925a9315375f7da9ba6fa6bfd7b9fb29 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9615117095&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the placeholder text for input fields to provide more concise and specific guidance. - **Bug Fixes** - Adjusted button variant naming for better consistency. - Improved text in `WDSParagraphWidget` to emphasize understanding mysteries. - **Refactor** - Removed unnecessary `onClick` prop from `StatsComponent`. - Simplified `getWidgetView` function in `WDSStatsWidget`. - **Chores** - Cleaned up redundant validation and required properties in `WDSSwitchGroupWidget`. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
16706cad08
|
fix: Sync EE items into CE (#34373)
## Description Going through EE repo to check if there are any changes in the repo (outside EE folder) that do no exist in the CE directory. These changes are harmless and seem to have been added to EE only by mistake. This PR will ensure the changes are copied here as well to maintain the sync ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/9642308929> > Commit: 825650372300260c39ae7b5b2ce91d2178dfa8c9 > Workflow: `PR Automation test suite` > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new CDN URL declaration for improved asset management. - Added a new function to check if the app mode is in "Published" state. - **Style** - Updated global styles to include new `.ai-window` class in popovers. - Enhanced cursor styling in the `CopyUrlForm` component. - **Bug Fixes** - Corrected an attribute name in the `ReconnectDatasourceModal` component. - **Performance** - Added caching for tenant configuration to optimize loading times. - **Chores** - Set `__webpack_public_path__` to support CDN usage in the Enterprise Edition environment. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
yatinappsmith
|
20b83faec4
|
chore: Revert "chore: bump tinymce from 7.0.0 to 7.2.0 in /app/client" (#34421)
Reverts appsmithorg/appsmith#34349 ## Automation /ok-to-test tags="@tag.Sanity,@tag.TextEditor" <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md">tinymce's changelog</a>.</em></p> <blockquote> <h2>7.2.0 - 2024-06-19</h2> <h3>Added</h3> <ul> <li>Added <code>options.debug</code> API that logs the initial raw editor options to console. #TINY-10605</li> <li>Added <code>referrerpolicy</code> as a valid attribute for an iframe element. #TINY-10374</li> <li>New <code>onInit</code> and <code>stretched</code> properties to the <code>HtmlPanel</code> dialog component. #TINY-10900</li> <li>Added support for querying the state of the <code>mceTogglePlainTextPaste</code> command. #TINY-10938</li> <li>Added <code>for</code> option to dialog label components to improve accessibility. The value must be another component on the same dialog. #TINY-10971</li> </ul> <h3>Improved</h3> <ul> <li>Dialog slider components now emit an onChange event when using arrow keys. #TINY-10428</li> <li>Accessibility for element path buttons, added tooltip to describe the button and removed incorrect <code>aria-level</code> attribute. #TINY-10891</li> <li>Improve merging of inserted inline elements by removing nodes with redundant inheritable styles. #TINY-10869</li> <li>Improved Find & Replace dialog accessibility by changing placeholders to labels. #TINY-10871</li> </ul> <h3>Changed</h3> <ul> <li>Replaced tiny branding logo with <code>Build with TinyMCE</code> text and logo. #TINY-11001</li> </ul> <h3>Fixed</h3> <ul> <li>Deleting in a <code>div</code> with preceeding <code>br</code> elements would sometimes throw errors. #TINY-10840</li> <li><code>autoresize_bottom_margin</code> was not reliably applied in some situations. #TINY-10793</li> <li>Fixed cases where adding a newline around a br, table or img would not move the cursor to a new line. #TINY-10384</li> <li>Focusing on <code>contenteditable="true"</code> element when using <code>editable_root: false</code> and inline mode causing selection to be shifted. #TINY-10820</li> <li>Corrected the <code>role</code> attribute on listbox dialog components to <code>combobox</code> when there are no nested menu items. #TINY-10807</li> <li>HTML entities that were double decoded in <code>noscript</code> elements caused an XSS vulnerability. #TINY-11019</li> <li>It was possible to inject XSS HTML that was not matching the regexp when using the <code>noneditable_regexp</code> option. #TINY-11022</li> </ul> <h2>7.1.2 - 2024-06-05</h2> <h3>Fixed</h3> <ul> <li>CSS color values set to <code>transparent</code> were incorrectly converted to '<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/000000">#000000</a>`. #TINY-10916</li> </ul> <h2>7.1.1 - 2024-05-22</h2> <h3>Fixed</h3> <ul> <li>Insert/Edit image dialog lost focus after the image upload completed. #TINY-10885</li> <li>Deleting into a list from a paragraph that has an <code>img</code> tag could cause extra inline styles to be added. #TINY-10892</li> <li>Resolved an issue where emojis configured with the <code>emojiimages</code> database were not loading correctly due to a broken CDN. #TINY-10878</li> <li>Iframes in dialogs were not rendering rounded borders correctly. #TINY-10901</li> <li>Autocompleter possible values are no longer capped at a length of 10. #TINY-10942</li> </ul> <h2>7.1.0 - 2024-05-08</h2> <h3>Added</h3> <ul> <li>Parser support for math elements. #TINY-10809</li> <li>New <code>math-equation</code> icon. #TINY-10804</li> </ul> <h3>Improved</h3> <ul> <li>Included <code>itemprop</code>, <code>itemscope</code> and <code>itemtype</code> as valid HTML5 attributes in the core schema. #TINY-9932</li> <li>Notification accessibility improvements: added tooltips, keyboard navigation and shortcut to focus on notifications. #TINY-6925</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Ashok Kumar M
|
0a2ca2c38c
|
feat: Anvil dnd sagas unit tests (#34407)
[](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=Pmk6xa9) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #33981 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9639877981> > Commit: 311f59c5d6cff265ea985c13f9891193866304d6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9639877981&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Introduced test cases for adding and moving widgets within a canvas layout. - **New Features** - Added functionality to generate mock data for a layout with two sections, each containing a zone widget. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Manish Kumar
|
fadf911295
|
chore: removed git annotation from dependency map variable (#34406) | ||
|
Shrikant Sharat Kandula
|
71bc84fc76
|
test: Fix extracing pageId from app page URL (#34401)
Over on `pg`, we use UUIDs for page IDs, not Object IDs, so the way we extract page ID should account for this. This PR supports page IDs as both ObjectId and UUID. So the same code should work on both `release` and `pg`. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9625470562> > Commit: e21db70964e824cbbb82a76182f46fe08a259f90 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9625470562&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved URL parsing logic for extracting `pageid` using a new method to enhance robustness. - Added assertions to ensure `pageid` is not null before proceeding with further actions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Vemparala Surya Vamsi
|
8482f78584
|
chore: capturing allPaths and unevalTree diffs computation latency (#34396)
## Description Capturing the telemetry of webworker's allPaths and unEvalTreeWithStringifiedJSFunctionsDiff computation. #34397 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/9613641914> > Commit: b3d679a8a079fc5c3febf7b4855916f32c982512 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced profiling for key operations to monitor performance. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Diljit
|
4942a959c5
|
fix: Prefetch apis: Include only branchname header in request key (#34389)
## Description The request key used to store the mutex for prefetch request was including all header keys. The prefetch request created by the service worker only had one key (branchname) but the request initiated by the client had more headers. Because of this mismatch in keys the request was missing the cache. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/9612628976> > Commit: e9c4a982eddded5dce31005365978b4729dadba2 > Workflow: `PR Automation test suite` > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved request key generation by including specific headers, enhancing cache performance. - **Tests** - Added a test case to verify the new request key generation logic based on headers. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ashit Rath
|
ae161b14c8
|
chore: Fix missing changes in revert #34313 (#34371)
## Description Reverted missed out code in https://github.com/appsmithorg/appsmith/pull/34367 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9608916182> > Commit: a2525661414e7bb571914ede981383778e9c4d56 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9608916182&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No |
||
|
Shrikant Sharat Kandula
|
979f44b2b0
|
chore: Remove unused methods in NewPageServiceCE (#34369)
Unused on EE as well. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified internal logic by updating methods to use projections instead of fetching specific fields. - **Chores** - Removed deprecated methods related to fetching page slugs by application IDs to streamline the codebase. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Alex
|
01dba7700c
|
fix: revert to passing hook as a prop for EE compatibility (#34367)
## Description Revert to passing hook as a prop for EE compatibility. Fixes #32982 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9600106265> > Commit: 042f94586b64efc1b8224059ceebddb0a4a9f0e6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9600106265&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced navigation menu generation in the editor with improved data management. - **Refactor** - Updated the navigation menu logic to use a new function, improving code maintainability and data handling. - **Bug Fixes** - Fixed inconsistencies in the navigation menu across different components in the editor. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Pawan Kumar
|
e01b34ec5d
|
chore: tests for wds button widget (#34242)
/ok-to-test tags="@tag.Anvil" <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced test cases for Anvil Button Widgets, including Canvas, Preview, and Deploy modes. - **Bug Fixes** - Updated CSS and HTML selectors for better element targeting and testing reliability. - **Style** - Improved styling logic for buttons in the InlineButtons component. - **Chores** - Added `data-testid` attributes for better test targeting. - Refactored code for string concatenations and URL constructions in DeployModeHelper. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9597157402> > Commit: c551705fe01aace94962fcc7fa91dff253136721 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9597157402&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local> |
||
|
Valera Melnikov
|
62fad08bf7
|
chore: add excludeFromTabOrder for wds widgets (#34361)
## Description - Add excludeFromTabOrder for WDS widgets - WDS Table refactoring Fixes #32369 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9596169254> > Commit: 25d5ef47520266d904c3c545940ad6009e7b2a8f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9596169254&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the ability to exclude toolbar buttons from the tab order for improved accessibility and user experience. This can be controlled via the `excludeFromTabOrder` property. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Anagh Hegde
|
e79f733072
|
chore: code split for consolidated API (#34328)
## Description This PR does the code split of consolidated API to support adding the environment details consolidated API in EE, as mentioned here in the issue. - https://github.com/appsmithorg/appsmith/issues/33132 Fixes https://github.com/appsmithorg/appsmith/issues/33132 ## Automation /ok-to-test tags="@tag.Perf" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9595115979> > Commit: 7e9cbe0a28807dec5ef3df168698508dbe9e0d0c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9595115979&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Perf` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a consolidated API response structure to streamline data from various endpoints, including user profiles, feature flags, and more. - Added comprehensive support for loading consolidated page information, enhancing the efficiency of page load operations. - **Refactor** - Refactored internal service interfaces and implementations to improve maintainability and extendability. - Centralized the `getConsolidatedInfoForPageLoad` method for better code organization and usability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com> |
||
|
dependabot[bot]
|
7346cfda8c
|
chore: bump socket.io from 4.6.1 to 4.6.2 in /app/client (#34350)
Bumps [socket.io](https://github.com/socketio/socket.io) from 4.6.1 to 4.6.2. ## Automation /ok-to-test tags="@tag.Sanity" <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p> <blockquote> <h2>4.6.2</h2> <h3>Bug Fixes</h3> <ul> <li><strong>exports:</strong> move <code>types</code> condition to the top (<a href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>) (<a href=" |
||
|
dependabot[bot]
|
a1e5024806
|
chore: bump tinymce from 7.0.0 to 7.2.0 in /app/client (#34349)
Bumps [tinymce](https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce) from 7.0.0 to 7.2.0. ## Automation /ok-to-test tags="@tag.Sanity" <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md">tinymce's changelog</a>.</em></p> <blockquote> <h2>7.2.0 - 2024-06-19</h2> <h3>Added</h3> <ul> <li>Added <code>options.debug</code> API that logs the initial raw editor options to console. #TINY-10605</li> <li>Added <code>referrerpolicy</code> as a valid attribute for an iframe element. #TINY-10374</li> <li>New <code>onInit</code> and <code>stretched</code> properties to the <code>HtmlPanel</code> dialog component. #TINY-10900</li> <li>Added support for querying the state of the <code>mceTogglePlainTextPaste</code> command. #TINY-10938</li> <li>Added <code>for</code> option to dialog label components to improve accessibility. The value must be another component on the same dialog. #TINY-10971</li> </ul> <h3>Improved</h3> <ul> <li>Dialog slider components now emit an onChange event when using arrow keys. #TINY-10428</li> <li>Accessibility for element path buttons, added tooltip to describe the button and removed incorrect <code>aria-level</code> attribute. #TINY-10891</li> <li>Improve merging of inserted inline elements by removing nodes with redundant inheritable styles. #TINY-10869</li> <li>Improved Find & Replace dialog accessibility by changing placeholders to labels. #TINY-10871</li> </ul> <h3>Changed</h3> <ul> <li>Replaced tiny branding logo with <code>Build with TinyMCE</code> text and logo. #TINY-11001</li> </ul> <h3>Fixed</h3> <ul> <li>Deleting in a <code>div</code> with preceeding <code>br</code> elements would sometimes throw errors. #TINY-10840</li> <li><code>autoresize_bottom_margin</code> was not reliably applied in some situations. #TINY-10793</li> <li>Fixed cases where adding a newline around a br, table or img would not move the cursor to a new line. #TINY-10384</li> <li>Focusing on <code>contenteditable="true"</code> element when using <code>editable_root: false</code> and inline mode causing selection to be shifted. #TINY-10820</li> <li>Corrected the <code>role</code> attribute on listbox dialog components to <code>combobox</code> when there are no nested menu items. #TINY-10807</li> <li>HTML entities that were double decoded in <code>noscript</code> elements caused an XSS vulnerability. #TINY-11019</li> <li>It was possible to inject XSS HTML that was not matching the regexp when using the <code>noneditable_regexp</code> option. #TINY-11022</li> </ul> <h2>7.1.2 - 2024-06-05</h2> <h3>Fixed</h3> <ul> <li>CSS color values set to <code>transparent</code> were incorrectly converted to '<a href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/000000">#000000</a>`. #TINY-10916</li> </ul> <h2>7.1.1 - 2024-05-22</h2> <h3>Fixed</h3> <ul> <li>Insert/Edit image dialog lost focus after the image upload completed. #TINY-10885</li> <li>Deleting into a list from a paragraph that has an <code>img</code> tag could cause extra inline styles to be added. #TINY-10892</li> <li>Resolved an issue where emojis configured with the <code>emojiimages</code> database were not loading correctly due to a broken CDN. #TINY-10878</li> <li>Iframes in dialogs were not rendering rounded borders correctly. #TINY-10901</li> <li>Autocompleter possible values are no longer capped at a length of 10. #TINY-10942</li> </ul> <h2>7.1.0 - 2024-05-08</h2> <h3>Added</h3> <ul> <li>Parser support for math elements. #TINY-10809</li> <li>New <code>math-equation</code> icon. #TINY-10804</li> </ul> <h3>Improved</h3> <ul> <li>Included <code>itemprop</code>, <code>itemscope</code> and <code>itemtype</code> as valid HTML5 attributes in the core schema. #TINY-9932</li> <li>Notification accessibility improvements: added tooltips, keyboard navigation and shortcut to focus on notifications. #TINY-6925</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Alex
|
138fc6a148
|
feat: side-by-side edit mode hover analytics (#34185)
## Description The purpose of this PR is to collect data about hovered canvas and widgets and send it to analytics platform. Fixes #33159 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9584384829> > Commit: 9cec247f7f1e82e0cc23fa5aa5499008bdc58964 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584384829&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced analytics tracking for side-by-side hover actions in the IDE canvas. - Added a new `AnalyticsWrapper` component for handling analytics events within layout systems. - Implemented a custom hook `useIsInSideBySideEditor` to check for side-by-side editor mode. - Added new CSS styles for layout systems. - **Bug Fixes** - Improved handling of widget hover events and analytics tracking in side-by-side editor mode. - **Refactor** - Refactored logic for determining the current entity info and segment state in the IDE. - Updated import paths and reordered imports for better organization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Abhijeet
|
0cdc15cf26
|
fix: Retain existing flags even if CS API fails (#34306)
## Description PR to fix refreshing feature flags when instance fails to fetch flags from CS. ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9563924054> > Commit: 9278bb30d62f7fbb7656e39448be6df611cd9514 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9563924054&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved feature flag updates by ensuring cached tenant features are evicted before updating, preventing potential stale data issues. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Alex
|
a6faf6d7a5
|
perf: add react-hooks/exhaustive-deps rule (#34338)
## Description Adds ESLint rule `react-hooks/exhaustive-deps` with warn level. Context in the task below. Fixes #34337 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9584250724> > Commit: daa705074504f398b80b1175440d00011b5d865d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584250724&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Added ESLint rule `react-hooks/exhaustive-deps` with a severity level of "warn" to enforce exhaustive dependencies in React hooks. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Alex
|
b85c4f5451
|
refactor: move apps link out of menu & refactor nav menu data (#34313)
## Description Moved `Back to all apps` from dropdown menu directly to header. Additionally renamed `NavigationMenuData.ts` to `useNavigationMenuData.ts` and fixed dependency related memoization issues. <img width="267" alt="image" src="https://github.com/appsmithorg/appsmith/assets/173164/020abfe3-1359-43ff-aa99-972a45f270bd"> Fixes #32982 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9567752111> > Commit: 824b2fe1231de1d073a1b19054507643b325400f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567752111&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed `getNavigationMenu` prop from `EditorHeader` for streamlined navigation menu data retrieval. - Updated `EditorName` to use `useNavigationMenuData` for navigation menu items. - Refactored `useNavigationMenuData` to use `useCallback` and `useMemo` for enhanced performance. - Adjusted imports and event handling functions in `IDE/Header` to use `useCallback` for better efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Saicharan Chetpelly
|
092208a1c1
|
fix: checkbox column misalignment on table widget (#34222)
Fixes #21790 _or_ Fixes [Issue URL](https://github.com/appsmithorg/appsmith/issues/21790) Introduced a new prop called isFullWidth for the CheckboxComponent and pass this prop to this styled component CheckboxContainer. The isFullWidth is an optional boolean property whole default value would be true. Added screenshot for reference.  <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a full-width option for checkboxes to enable better styling flexibility. - **Tests** - Added new test cases to verify checkbox styling properties in tables. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
5a1ec0c591
|
chore: Disallow plugin requests to localhost (#34250)
The microservices that run inside the Appsmith container, trust each other, and may expose sensitive API endpoints to other internal microservices. These sensitive APIs aren't accessible by outside the Appsmith container, protected by Caddy's routing. This means that the backend server's ability to make user-configured HTTP requests, can lead to SSRFs to such sensitive API calls, if it's allowed to call APIs on localhost. In other words, Caddy establishes a trust boundary that protects these internal APIs from outside the container. But we lack such a trust boundary for the backend's plugins (API plugin, Elasticsearch plugin, etc.). This PR solves that. In this PR, we block both IPv4 and IPv6 loopback addresses. No additional changes needed on EE, no conflicts, and all unit and Cypress tests pass. **/test all** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9590358198> > Commit: 5445c70aa873942c3edae9fbfcc57a6d2554b815 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9590358198&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved handling of disallowed hosts by dynamically computing based on environment variables, offering more flexibility and control. - **Refactor** - Enhanced the `makeWebClient()` method to use a more efficient approach for creating WebClient objects with custom configurations. - **Chores** - Added an `ENV` declaration for `IN_DOCKER` in the Dockerfile to better manage Docker-specific configurations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
ef01ab5b31
|
chore: Remove findById signature with Optional (#34302)
Follow up to https://github.com/appsmithorg/appsmith/pull/34281. The `.findById` method is now removed. No conflicts, but needs extra changes in [this PR](https://github.com/appsmithorg/appsmith-ee/pull/4482) for build to pass on EE. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9563607766> > Commit: 02f6031cec08a4e805f479b500be40b08a003142 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9563607766&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated methods to use direct values instead of `Optional` for permissions, simplifying method signatures and improving readability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Valera Melnikov
|
36372468c5
|
chore: remove headless radio and use react-aria component instead (#34312)
## Description - Remove headless radio and use react-aria component instead - Create ErrorMessage component Fixes #27677 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9567388261> > Commit: 62d1153caa8bf03d827f88593c9dfaf3121091ee > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567388261&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added `ErrorMessage` component for displaying error messages with specific styling. - Introduced `isDisabled` prop for `Label` and `ToggleGroup` components. - Updated `RadioGroup` to accept an items array for easier configuration. - **Bug Fixes** - Improved conditional rendering in `Label` component to prevent issues when `text` and `contextualHelp` are both falsy. - **Refactor** - Removed `Radio` component export from design system. - Restructured import statements and prop declarations for `Checkbox` and `RadioGroup`. - **Style** - Updated styles for `RadioGroup` and `ToggleGroup` components for better state handling (disabled, hovered, selected). - **Documentation** - Updated Storybook stories for `RadioGroup` to reflect changes in component usage. - **Tests** - Adjusted `RadioGroup.test.tsx` to test new items array prop. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
f718bfbb6b
|
chore: Remove unused LayoutServiceCE.createLayout (#34305)
The `LayoutServiceCE.createLayout` method is _only_ used in tests, and so, should either be unneeded and so removed, or should be moved to somewhere under `test/main/java` instead. But since it looks like we don't actually need it, from reading the tests, removing it. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9564364280> > Commit: 2f13223544d6c075b7af9b178f1493ef006ad711 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9564364280&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated layout retrieval method to include a new parameter. - Removed `createLayout` method to streamline layout creation processes. - Utilized Lombok's `@RequiredArgsConstructor` to simplify constructor definitions. - **Tests** - Enhanced test assertions and refactored logic for layout and action service tests. - Improved test cleanup process by refining workspace archiving without deleting applications. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Manish Kumar
|
4d33d6b033
|
chore: annotate serializable attributes with git annotation (#34273)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9545065563> > Commit: d8db02d61a62df6e9c5ba413df9fb75e61734aba > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9545065563&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced JSON serialization to support Git views for various application fields. This improves the consistency and control over how data is displayed and managed in Git-related operations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Vemparala Surya Vamsi
|
f2a6341c58
|
fix: evalTrigger mutation fix (#34106)
## Description This fixes a gap in our evaluation flow where we were not sending evaluation updates during an evaluation in the evalTrigger. We have resolved that by sending updates in the evalTrigger, also we have created a separate function called evaluateAndGenerateWebWorkerResponse which unifies the logic between sending updates in evalTrigger as well as evalTreeWithChanges. We have added several unit test cases in this PR to test the evaluation flow. Fixes #33823 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9558723818> > Commit: 8b7bc93e3d1a8ce93c722a94c8846f9359d40686 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9558723818&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved the evaluation and update process for data tree structures with new helper functions and interfaces. - Enhanced error handling with optional chaining in `setPrevState` function. - **New Features** - Introduced `evaluateAndPushResponse`, `evaluateAndGenerateResponse`, and `getAffectedNodesInTheDataTree` functions for better data tree evaluation and updates. - Added `UpdateTreeResponse` interface for structured update responses. - **Bug Fixes** - Adjusted error handling in the evaluation process to ensure robustness. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
4bc1785392
|
chore: Deprecate .findById signature with Optional parameter (#34281)
This is work on getting to remove the `.findById` signature with `Optional<>` arguments. This signature doesn't add any value, encourages confusing multi-signature service methods (check the diff here), and is causing unnecessary problems in `pg` branch with generating `*Cake` classes. This PR doesn't get rid of this entirely, just one part. A follow-up PR will be opened after this is merged. Nothing new, nothing fixed. Only a refactor. No conflicts to EE, but needs extra changes, in [this PR](https://github.com/appsmithorg/appsmith-ee/pull/3714) to be merged for the build to pass. **/test sanity** <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9549476417> > Commit: c1e45f2fe50530b7ec8436d9722310537d125166 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9549476417&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified method signatures by removing the use of `Optional` for permission parameters across various services. Permissions are now passed directly. - Deprecated `findById` method that uses `Optional<AclPermission>` to improve code clarity and maintainability. - **Chores** - Updated test cases to remove the use of `Optional.empty()` and replaced with `null` in method calls. - Removed unnecessary imports of `Optional` in multiple files. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Aman Agarwal
|
12879c7c55
|
fix: property pane height fix for animation (#34276) | ||
|
dependabot[bot]
|
dc42ccf1b1
|
chore: bump ws from 6.2.2 to 6.2.3 in /app/client (#34291)
Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3. ## Automation /ok-to-test tags="@tag.Sanity" <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/websockets/ws/releases">ws's releases</a>.</em></p> <blockquote> <h2>6.2.3</h2> <h1>Bug fixes</h1> <ul> <li>Backported e55e5106 to the 6.x release line (eeb76d31).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Rudraprasad Das
|
4100fa9319
|
fix: learn more link in git connect success modal (#34297)
## Description Learn more link in Git connection success modal was not working properly. This PR fixes it Fixes https://github.com/appsmithorg/appsmith/issues/34295 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9560201005> > Commit: 3e282e06d3a26442a5f3acb0c8231b51ba13ee05 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9560201005&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated documentation link for branch protection settings to the latest URL in the Git sync success modal. - **Tests** - Added a test to verify the updated 'Learn more' link in the Git connection success modal. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
842ac10316
|
chore: Use RequiredArgsConstructor when possible (#34280)
This class injects `mongoOperations`, which isn't available on Postgres, so there we inject `entityManager`. So when constructor params change in this class, we get an unnecessary conflict. Using `@RequiredArgsConstructor` makes this conflict go away. And a minor case-fix in a log message. |
||
|
Manish Kumar
|
8b85f36496
|
chore: refactored git status (#34270)
## Description - Refactored Git status method to remove redundant logic in overloaded method, now the base getStatus method uses, the overloaded method. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9544409678> > Commit: 42fa4574d0d678808ef7e61ffb59ce751fe9a3bd > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9544409678&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved readability and maintainability of the code handling Git operations. - Enhanced efficiency in file locking and data fetching processes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Diljit
|
c0ad2b8562
|
chore: Add gpt-4o mode in vision command (#33637)
## Description Add gpt-4o model in Open AI datasource's vision and chat commands Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9541802412> > Commit: 78eb94443c7e8ed5396f6e3369aac1e5373954bc > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9541802412&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced `VisionCommand` to support new model naming conventions, including `gpt-4-vision-preview` and `gpt-4o`. - **Bug Fixes** - Improved message content handling in `transformUserMessages` and `transformSystemMessages` methods to ensure proper data type casting. - **Tests** - Updated test cases to align with the new model name `gpt-4o`, ensuring accurate test coverage. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Nirmal Sarswat <nirmal@appsmith.com> |
||
|
Rudraprasad Das
|
6585ec1487
|
chore: removing branch protection trigger from git connect flow (#34118)
## Description 1. Remove branch protection trigger from git connect saga 2. Updating test-cases and removed logic for removing branch protection after git connect Fixes https://github.com/appsmithorg/appsmith/issues/34059 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9498573284> > Commit: 6ef7f8bc0bfbe15880857fff1f6262c9e9b5ef4a > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9498573284&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Corrected Git branch protection interactions in test scenarios. - **New Features** - Enhanced Git connection success messages and actions. - **Improvements** - Reordered import statements for better code organization. - Adjusted visibility of methods and refactored parameters in Git synchronization. - **Dependencies** - Updated `design-system` dependency to version `2.1.42`. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
NandanAnantharamu
|
1007c2356d
|
test: replace LogintoApp with LoginFromAPI (#34040)
This replaces LogintoApp with LoginFromAPI /ok-to-test tags="@tag.All" EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4440 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Enhanced login functionality in multiple test scripts by shifting from user-based login to API-based login. - **Chores** - Updated the spec names in the limited Cypress tests to align with new test locations and names. - Added new logout API call in the `LoginFromAPI` custom command to improve test reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9517666274> > Commit: a42a585c062bab201dd18f148981d5a4f4265556 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9517666274&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> |
||
|
Valera Melnikov
|
84f67fe0f2
|
chore: remove headless checkbox and switch use react-aria component instead (#34217)
## Description - Remove headless checkbox and switch use react-aria component instead - Add Label component - Now `ToggleGroup` is used instead of `SwitchGroup` and `CheckboxGroup`, since they are essentially the same component. **I'll create another one PR to refactor the radioGroup.** Fixes #27677 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9485370398> > Commit: f2557233978da533b9ab856335a8191b4226dba5 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9485370398&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced `ToggleGroup` component with various features for improved user interaction. - **Enhancements** - Updated `Radio`, `Checkbox`, and `Switch` components for better functionality and styling alignment. - Added `labelPosition` options to `Radio` and `Checkbox` components for flexible label positioning. - Enhanced `ContextualHelp` component with a new `slot` prop for more customization. - Improved `Select` component to use `Label` directly, optimizing rendering. - **Bug Fixes** - Adjusted logic for `WDSSwitchWidget` to ensure correct validity handling. - **Styling** - Various styling adjustments across multiple components for consistent design. - **Tests** - Updated test cases for the `Checkbox` component to reflect recent changes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Rudraprasad Das
|
cae0114372
|
fix: fixing unprotect logic in callout (#34244)
## Description Clicking "Unprotect branch" in the branch protection callout was making all the branches as unprotected. This PR fixes that and only allows the current branch to be unprotected Fixes #33310 #34005 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9511853863> > Commit: 1ccab8a270b12427eeda6f4cdbea0fb84b4d77ee > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9511853863&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced IDE with advanced branch protection management, including the ability to unprotect branches directly within the IDE. - **Bug Fixes** - Improved handling of current branch filtering to ensure accurate protected branch management. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Diljit
|
4cb6ff03f9
|
chore: Prefetch module apis in service worker (#34003)
## Description This PR has the following changes - Modify the prefetch api cache strategy to handle multiple prefetch requests. - Convert the service worker files from js to ts - Code splitting of CE and EE for service worker utils to handle EE specific changes - Jest test cases for the updated logic Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9511154598> > Commit: 785197e27873e71ed457f785a73d4ea57f379213 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9511154598&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced API request handling with new utility functions and caching strategies for service worker operations. - Updated service worker configuration to TypeScript for improved type safety and maintainability. - Added type definitions for `node-fetch` to support new service worker functionalities. - **Refactor** - Consolidated `view` and `edit` endpoint URL construction in `ConsolidatedPageLoadApi` for better code maintainability. - **Chores** - Updated dependencies in `package.json` for better development experience and compatibility. - Added tests for new service worker utility functions to ensure reliability and correctness. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Nilansh Bansal
|
b4ca723799
|
chore: added new relic telemetry for spans (#34240)
## Description > This PR adds telemetry and logs for different spans where tenant info is fetched. Fixes #34072 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9511509976> > Commit: d4dc99e250372ce86847b6904c0e642c636ec9ad > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9511509976&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced tenant fetching with improved logging and metrics using Micrometer. - **Improvements** - Added monitoring capabilities to various tenant-related services for better observability and debugging. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
