Commit Graph

17815 Commits

Author SHA1 Message Date
Aman Agarwal
8a68347952
feat: added key pair auth for snowflake behind feature flag (#34399) 2024-06-25 13:30:46 +05:30
Shrikant Sharat Kandula
3a8139e3be
chore: Fix .equals on subclasses of AuthenticationDTO (#34451)
**/test sanity datasource**



<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9657231521>
> Commit: a88e9b94b4263f20c43a8da9154822182d62855c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9657231521&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource`
> It seems like **no tests ran** 😔. We are not able to recognize it,
please check <a
href="https://github.com/appsmithorg/appsmith/actions/runs/9657231521"
target="_blank">workflow here</a>.

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Enhancements**
- Improved equality and hashing behavior for various authentication
classes, enhancing data integrity and consistency across the app.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-25 13:06:13 +05:30
Shrikant Sharat Kandula
064d74c833
chore: Remove current symlink to Postgres (#34454)
Reason for this previously documented at
https://github.com/appsmithorg/appsmith/pull/34265#issue-2356259090.

Cypress tests don' make sense since the only diff is on
`base.dockerfile`.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated Dockerfile to streamline PostgreSQL setup. Removed creation of
a symlink to the current version of PostgreSQL.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-25 13:03:51 +05:30
Shrikant Sharat Kandula
aa773f6950
chore: Strict payloads for update action and gen template API (#34446)
Part of #33724.

This PR fixes a few more APIs to pass just the fields that the server
expects, and nothing more.

/test sanity datasource


<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9648180689>
> Commit: 874f9f1a721108d36dae5719fa842d595bd9281d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9648180689&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource`

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved payload structure for `updateAction` and `moveAction` methods
to enhance API request consistency.
- Updated `updateApplicationTheme` method to refine the payload before
making API calls.
- Modified `generateTemplatePage` method to update the request payload,
improving API interaction.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-25 13:03:36 +05:30
Rahul Barwal
411122ec56
fix: Refactor dynamic bindings in widgets during building block paste. (#34318)
## Description
* This pull request refactors the function
`handleButtonDynamicTriggerPathList` to
`handleWidgetDynamicTriggerPathList` in order to make it more generic
and handle dynamic trigger paths for all types of widgets.
* Additionally, the pull request moves the function
`handleIfParentIsListWidgetWhilePasting` out of
`handleSpecificCasesWhilePasting` to handle compound cases where the
parent of the current widget needs to be checked.
* Improves the nested object value replacement logic in
`PasteWidgetUtils`.

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Templates, @tag.Widget, @tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9656587968>
> Commit: 4b821787d7ab5ad302b458c726c632b1e43b49e4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9656587968&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Templates, @tag.Widget, @tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->










## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
  - Simplified handling of pasting widgets by consolidating functions.
  - Improved logic for handling widget pasting scenarios.
  - Reorganized function names for better clarity and consistency.

- **Bug Fixes**
- Enhanced the handling of widgets when their parent is a list widget
during pasting.

- **Tests**
- Updated test cases to reflect changes in widget pasting logic and
function names.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Jacques Ikot <jacquesikot@gmail.com>
2024-06-25 11:43:00 +05:30
Sagar Khalasi
e6e4b98492
ci: To improve readability sorted tags in tags.js (#34452)
## Description
To improve readability sorted tags in tags.js

Fixes #34419

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/9656608059>
> Commit: c45654a04119910854b5f9e7989f42ccf76356a1
> Workflow: `PR Automation test suite`
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added new tags for enhanced categorization, including `@tag.Audio`,
`@tag.Auditlogs`, `@tag.Authentication`, `@tag.Camera`, `@tag.Form`,
`@tag.Image`, `@tag.Video`, and many more to improve content
organization.

- **Removals**
- Removed outdated or redundant tags like `@tag.Git`, `@tag.Widget`,
`@tag.Slider`, and `@tag.Input` for better clarity and relevance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-25 05:47:34 +00:00
Abhijeet
992bbdb7c8
chore: Update Postgres port for TED in CI (#34430)
## Description
PR to update the Postgres posrt for TED container in CI.

/test all

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9646981763>
> Commit: d998c6fe77ac2acdb71888fe6b3d7603ddda508c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9646981763&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: ``

<!-- end of auto-generated comment: Cypress test results  -->








## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated Docker port mapping from `5432` to `5433` across multiple CI
workflow files to ensure consistency and avoid port conflicts.

- **Bug Fixes**
- Adjusted PostgreSQL connection port from `5432` to `5433` in test
fixtures and scripts to align with environment changes and prevent
connection issues.

- **Tests**
- Modified test scripts to handle new PostgreSQL port settings for
improved reliability in testing scenarios.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-25 10:35:15 +05:30
Shrikant Sharat Kandula
dc79ebb918
test: Remove unused data in DSL fixtures (#34405)
Part of #33724.

We have a lot of fixture files in our Cypress tests with DSLs of various
kinds. They are used to update the DSL using the
`/api/v1/layouts/{layoutId}/pages/{pageId}?applicationId={applicationId}`.

This API, is [in this line in
`LayoutControllerCE`](c4e5d5e6c8/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/LayoutControllerCE.java (L71)),
and the request body is parsed as [objects of `LayoutUpdateDTO`
record](71bc84fc76/app/server/appsmith-server/src/main/java/com/appsmith/server/dtos/LayoutUpdateDTO.java (L6)).
This `record`, accepts _only_ the `dsl` field, and nothing else.

List of potential files that have this problem was identified with this
command:

```sh
cd app/client/cypress
rg -Io 'AddDsl\(".+?\)' \
  | cut -d\" -f2 \
  | sort -u \
  | while read line; do
    if rg -q '"(layoutOnLoadActions|layoutOnLoadActionErrors|userPermissions|new)":' fixtures/"$line".json; then
      echo $line
    fi
  done
```

(For reference, and to use on EE repo, after this is merged).

**/test all**

<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9633990737>
> Commit: 9e848f1ed0c3332177d2e6c4a75e2483f045395f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9633990737&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: ``
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor3_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_1_spec.js
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_2_spec.js
</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Corrected the file path for loading DSL configuration in the nested
list widget scenario.

- **Chores**
- Streamlined multiple JSON files by removing deprecated
`layoutOnLoadActions` arrays and other obsolete fields, resulting in
cleaner and more manageable configurations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-24 17:17:43 +05:30
Shrikant Sharat Kandula
d86c855ef2
chore: Strict schema for datasource and action APIs (#34366)
Part of https://github.com/appsmithorg/appsmith/pull/33724. This is an
effort to harden the server in terms of what request payloads are
acceptable.

**/test all**





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced API request payload handling for creating actions to include
additional properties, improving data integrity and server-side
validation.

- **Improvements**
- Refined data manipulation and payload structures in datasource-related
API requests for better compatibility with server requirements.

<!-- end of auto-generated comment: release notes by coderabbit.ai
--><!-- This is an auto-generated comment: Cypress test results -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9626214547>
> Commit: fe5db45aeb916b176aec3ded06f1a9da1bf08898
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9626214547&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: ``
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor3_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_1_spec.js
>
<li>cypress/e2e/Regression/ClientSide/Widgets/RTE/RichTextEditor_2_spec.js
</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.

<!-- end of auto-generated comment: Cypress test results  -->
2024-06-24 17:17:23 +05:30
Valera Melnikov
99c51a99ae
fix: don't call modal onClose method in edit mode (#34432)
## Description
Fix modal onClose method in edit mode


Fixes #33861 

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9643445303>
> Commit: 179602e52dcc2cdcaeecc5f67af5bc4ac12ee431
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9643445303&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved modal widget behavior to ensure it checks for
disableWidgetInteraction before closing, preventing unwanted closures.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-24 13:58:50 +03:00
Ashok Kumar M
ed497dbe9c
chore: add tests for anvil modal. (#34347)
[![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX1n8wGoml2WVG4C2fL4hX6Z1rh6k4aeSvE%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=9GEnyEC)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #33740 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9643638292>
> Commit: bcc4bbddaa50b0be16e41a3a51db4f6abe732e79
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9643638292&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->









## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced test cases for Anvil modals, covering interactions like
opening, closing, drag and drop operations, and handling modal
functions.

- **Bug Fixes**
- Enhanced testing capabilities with `data-testid` attributes for better
identification and testing of components, particularly in detached
widget drop areas.

- **Refactor**
- Updated the `Modal` component to use `dataAttributes` instead of
`size` prop to streamline attribute handling.
- Dynamic generation of modal class names based on properties for better
styling and consistency.

- **Style**
- Adjusted styling for SVG elements within the `EntityExplorer`
component, specifically modifying the height and width properties.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-06-24 16:28:34 +05:30
Valera Melnikov
70398df10a
fix: wds widgets (#34387)
## Description
- Remove click event from Stats
- Remove validation section from SwitchGroup
- Fix Inline button variant for added button
- Fix paragraph default text
- Fix inputs placeholders

Fixes:
#34189 
#34002
#33753 
#33242
#33243
#33186
#32509

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9615117095>
> Commit: 15420c10925a9315375f7da9ba6fa6bfd7b9fb29
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9615117095&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Updated the placeholder text for input fields to provide more concise
and specific guidance.

- **Bug Fixes**
    - Adjusted button variant naming for better consistency.
- Improved text in `WDSParagraphWidget` to emphasize understanding
mysteries.

- **Refactor**
    - Removed unnecessary `onClick` prop from `StatsComponent`.
    - Simplified `getWidgetView` function in `WDSStatsWidget`.

- **Chores**
- Cleaned up redundant validation and required properties in
`WDSSwitchGroupWidget`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-24 13:58:16 +03:00
Hetu Nandu
16706cad08
fix: Sync EE items into CE (#34373)
## Description

Going through EE repo to check if there are any changes in the repo
(outside EE folder) that do no exist in the CE directory. These changes
are harmless and seem to have been added to EE only by mistake. This PR
will ensure the changes are copied here as well to maintain the sync

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/9642308929>
> Commit: 825650372300260c39ae7b5b2ce91d2178dfa8c9
> Workflow: `PR Automation test suite`
> Tags: ``

<!-- end of auto-generated comment: Cypress test results  -->










## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
  - Introduced a new CDN URL declaration for improved asset management.
- Added a new function to check if the app mode is in "Published" state.

- **Style**
  - Updated global styles to include new `.ai-window` class in popovers.
  - Enhanced cursor styling in the `CopyUrlForm` component.

- **Bug Fixes**
- Corrected an attribute name in the `ReconnectDatasourceModal`
component.

- **Performance**
  - Added caching for tenant configuration to optimize loading times.
  
- **Chores**
- Set `__webpack_public_path__` to support CDN usage in the Enterprise
Edition environment.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-24 09:36:38 +00:00
yatinappsmith
20b83faec4
chore: Revert "chore: bump tinymce from 7.0.0 to 7.2.0 in /app/client" (#34421)
Reverts appsmithorg/appsmith#34349
## Automation

/ok-to-test tags="@tag.Sanity,@tag.TextEditor"
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md">tinymce's
changelog</a>.</em></p>
<blockquote>
<h2>7.2.0 - 2024-06-19</h2>
<h3>Added</h3>
<ul>
<li>Added <code>options.debug</code> API that logs the initial raw
editor options to console. #TINY-10605</li>
<li>Added <code>referrerpolicy</code> as a valid attribute for an iframe
element. #TINY-10374</li>
<li>New <code>onInit</code> and <code>stretched</code> properties to the
<code>HtmlPanel</code> dialog component. #TINY-10900</li>
<li>Added support for querying the state of the
<code>mceTogglePlainTextPaste</code> command. #TINY-10938</li>
<li>Added <code>for</code> option to dialog label components to improve
accessibility. The value must be another component on the same dialog.
#TINY-10971</li>
</ul>
<h3>Improved</h3>
<ul>
<li>Dialog slider components now emit an onChange event when using arrow
keys. #TINY-10428</li>
<li>Accessibility for element path buttons, added tooltip to describe
the button and removed incorrect <code>aria-level</code> attribute.
#TINY-10891</li>
<li>Improve merging of inserted inline elements by removing nodes with
redundant inheritable styles. #TINY-10869</li>
<li>Improved Find &amp; Replace dialog accessibility by changing
placeholders to labels. #TINY-10871</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Replaced tiny branding logo with <code>Build with TinyMCE</code>
text and logo. #TINY-11001</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>Deleting in a <code>div</code> with preceeding <code>br</code>
elements would sometimes throw errors. #TINY-10840</li>
<li><code>autoresize_bottom_margin</code> was not reliably applied in
some situations. #TINY-10793</li>
<li>Fixed cases where adding a newline around a br, table or img would
not move the cursor to a new line. #TINY-10384</li>
<li>Focusing on <code>contenteditable=&quot;true&quot;</code> element
when using <code>editable_root: false</code> and inline mode causing
selection to be shifted. #TINY-10820</li>
<li>Corrected the <code>role</code> attribute on listbox dialog
components to <code>combobox</code> when there are no nested menu items.
#TINY-10807</li>
<li>HTML entities that were double decoded in <code>noscript</code>
elements caused an XSS vulnerability. #TINY-11019</li>
<li>It was possible to inject XSS HTML that was not matching the regexp
when using the <code>noneditable_regexp</code> option. #TINY-11022</li>
</ul>
<h2>7.1.2 - 2024-06-05</h2>
<h3>Fixed</h3>
<ul>
<li>CSS color values set to <code>transparent</code> were incorrectly
converted to '<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/000000">#000000</a>`.
#TINY-10916</li>
</ul>
<h2>7.1.1 - 2024-05-22</h2>
<h3>Fixed</h3>
<ul>
<li>Insert/Edit image dialog lost focus after the image upload
completed. #TINY-10885</li>
<li>Deleting into a list from a paragraph that has an <code>img</code>
tag could cause extra inline styles to be added. #TINY-10892</li>
<li>Resolved an issue where emojis configured with the
<code>emojiimages</code> database were not loading correctly due to a
broken CDN. #TINY-10878</li>
<li>Iframes in dialogs were not rendering rounded borders correctly.
#TINY-10901</li>
<li>Autocompleter possible values are no longer capped at a length of
10. #TINY-10942</li>
</ul>
<h2>7.1.0 - 2024-05-08</h2>
<h3>Added</h3>
<ul>
<li>Parser support for math elements. #TINY-10809</li>
<li>New <code>math-equation</code> icon. #TINY-10804</li>
</ul>
<h3>Improved</h3>
<ul>
<li>Included <code>itemprop</code>, <code>itemscope</code> and
<code>itemtype</code> as valid HTML5 attributes in the core schema.
#TINY-9932</li>
<li>Notification accessibility improvements: added tooltips, keyboard
navigation and shortcut to focus on notifications. #TINY-6925</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="754e390c67"><code>754e390</code></a>
TINY-10860: Prepare for 7.2 release (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9715">#9715</a>)</li>
<li><a
href="a9fb858509"><code>a9fb858</code></a>
TINY-11019 &amp; TINY-11022: Fixed issues with noscript encoding and
noneditable_...</li>
<li><a
href="3fae00c85d"><code>3fae00c</code></a>
TINY-10807: Use role=&quot;combobox&quot; for flat ListBox components
(<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9665">#9665</a>)</li>
<li><a
href="e7ef3b66e2"><code>e7ef3b6</code></a>
TINY-10871: replace placeholders with labels in Find &amp; Replace
dialog (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9689">#9689</a>)</li>
<li><a
href="6ce11b6860"><code>6ce11b6</code></a>
TINY-10936: Merge release to main (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9685">#9685</a>)</li>
<li><a
href="5fa376a63e"><code>5fa376a</code></a>
TINY-11001: Replaced tiny branding logo (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9683">#9683</a>)</li>
<li><a
href="c42efc2871"><code>c42efc2</code></a>
TINY-10938: Added query command for paste as plaintext status. (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9651">#9651</a>)</li>
<li><a
href="70cff122d8"><code>70cff12</code></a>
TINY-10971: introduce optional label for property (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9681">#9681</a>)</li>
<li><a
href="054671e930"><code>054671e</code></a>
TINY-10891: Add tooltips to element path (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9676">#9676</a>)</li>
<li><a
href="465fbbee67"><code>465fbbe</code></a>
TINY-10869: Improve merging inserted nested inline elements (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9658">#9658</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/tinymce/tinymce/commits/7.2.0/modules/tinymce">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tinymce&package-manager=npm_and_yarn&previous-version=7.0.0&new-version=7.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/appsmithorg/appsmith/network/alerts).

</details>

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9641034857>
> Commit: 1f48cb54ff34e175f320f314866e0024c4664f00
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9641034857&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity,@tag.TextEditor`

<!-- end of auto-generated comment: Cypress test results  -->
2024-06-24 13:25:04 +05:30
yatinappsmith
cb89dda2ed
ci: removed matrix for ci-test-limit (#34420)
## Description
removed matrix for ci-test-limit

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated CI workflows to streamline the `ci-test-limited` job by
removing the `matrix` configuration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-24 12:13:20 +05:30
Sagar Khalasi
b849d34829
ci: Fix non used matrix parameter in build-client-server.yml (#34417)
## Description
Fix non used matrix parameter in build-client-server.yml. It was removed
from originated function parameter.

Fixes #`34418`  

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/9640650543>
> Commit: acc2e4d8af13ae3c29a429c0e4db069976d69826
> Workflow: `PR Automation test suite`
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-06-24 12:00:23 +05:30
Ashok Kumar M
0a2ca2c38c
feat: Anvil dnd sagas unit tests (#34407)
[![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX1IH0H4UjkYrlztX0lkyWZ1n2uZYh8Epg%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=Pmk6xa9)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #33981
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9639877981>
> Commit: 311f59c5d6cff265ea985c13f9891193866304d6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9639877981&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Introduced test cases for adding and moving widgets within a canvas
layout.

- **New Features**
- Added functionality to generate mock data for a layout with two
sections, each containing a zone widget.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-24 11:47:26 +05:30
Manish Kumar
fadf911295
chore: removed git annotation from dependency map variable (#34406) 2024-06-24 11:10:23 +05:30
Shrikant Sharat Kandula
71bc84fc76
test: Fix extracing pageId from app page URL (#34401)
Over on `pg`, we use UUIDs for page IDs, not Object IDs, so the way we
extract page ID should account for this. This PR supports page IDs as
both ObjectId and UUID. So the same code should work on both `release`
and `pg`.

**/test sanity**



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9625470562>
> Commit: e21db70964e824cbbb82a76182f46fe08a259f90
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9625470562&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->




<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved URL parsing logic for extracting `pageid` using a new method
to enhance robustness.
- Added assertions to ensure `pageid` is not null before proceeding with
further actions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-22 18:33:29 +05:30
Shrikant Sharat Kandula
132bd83f08 ci: Get stderr as well into dockerlogs file 2024-06-22 13:20:36 +05:30
Vemparala Surya Vamsi
8482f78584
chore: capturing allPaths and unevalTree diffs computation latency (#34396)
## Description
Capturing the telemetry of webworker's allPaths and
unEvalTreeWithStringifiedJSFunctionsDiff computation.

#34397 

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/9613641914>
> Commit: b3d679a8a079fc5c3febf7b4855916f32c982512
> Workflow: `PR Automation test suite`
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
  - Introduced profiling for key operations to monitor performance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-22 07:02:14 +05:30
Diljit
4942a959c5
fix: Prefetch apis: Include only branchname header in request key (#34389)
## Description
The request key used to store the mutex for prefetch request was
including all header keys. The prefetch request created by the service
worker only had one key (branchname) but the request initiated by the
client had more headers. Because of this mismatch in keys the request
was missing the cache.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/9612628976>
> Commit: e9c4a982eddded5dce31005365978b4729dadba2
> Workflow: `PR Automation test suite`
> Tags: ``

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved request key generation by including specific headers,
enhancing cache performance.

- **Tests**
- Added a test case to verify the new request key generation logic based
on headers.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-21 14:42:33 +00:00
Shrikant Sharat Kandula
26c0f07e14
chore: Add script to upgrade Postgres 13 data to 14 (#34317)
We're upgrading embedded Postgres from 13 to 14, and this PR includes a
script to perform the upgrade of the data folder from v13 schema to v14
schema. This script temporarily installs Postgres 13, if not available,
for the upgrade process, so will continue to work when and if we choose
to remove `postgresql-13` from the base image.

Tested this manually as well, running an Appsmith with Postgres 13,
executing some workflows via webhook, getting some run data generated,
then upgrading Postgres with the script in this PR, and ensuring that
the workflow run history is still there and visible on the UI exactly
the same. It is.

No conflicts or additional changes needed on EE. [All server and Cypress
tests pass on EE](https://github.com/appsmithorg/appsmith-ee/pull/4493).


![shot-2024-06-20-02-13-26](https://github.com/appsmithorg/appsmith/assets/120119/9bb60e3a-6cc9-4df9-9064-caead78729a6)


**/test sanity**



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9590240540>
> Commit: 9c75da53f871ffb912015c18a7504327cba88f2c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9590240540&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added automation script for upgrading PostgreSQL to the latest
version.
- Introduced testing script for PostgreSQL upgrades in Docker
environments.

- **Improvements**
- Upgraded PostgreSQL from version 13 to 14 in Docker setup, ensuring
compatibility and performance enhancements.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-21 19:34:08 +05:30
Shrikant Sharat Kandula
6ef4d2a6af
ci: Run server tests on pg branch (#34372)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated workflow conditions to ensure PostgreSQL build is triggered
when the pull request head reference is 'pg'.
- Simplified logic to unconditionally start the PostgreSQL container in
the build process.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-21 12:52:18 +05:30
Ashit Rath
ae161b14c8
chore: Fix missing changes in revert #34313 (#34371)
## Description
Reverted missed out code in
https://github.com/appsmithorg/appsmith/pull/34367

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9608916182>
> Commit: a2525661414e7bb571914ede981383778e9c4d56
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9608916182&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-06-21 11:51:53 +05:30
Shrikant Sharat Kandula
979f44b2b0
chore: Remove unused methods in NewPageServiceCE (#34369)
Unused on EE as well.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Simplified internal logic by updating methods to use projections
instead of fetching specific fields.
  
- **Chores**
- Removed deprecated methods related to fetching page slugs by
application IDs to streamline the codebase.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-21 10:32:37 +05:30
Alex
01dba7700c
fix: revert to passing hook as a prop for EE compatibility (#34367)
## Description
Revert to passing hook as a prop for EE compatibility.

Fixes #32982

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9600106265>
> Commit: 042f94586b64efc1b8224059ceebddb0a4a9f0e6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9600106265&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced navigation menu generation in the editor with improved data
management.

- **Refactor**
- Updated the navigation menu logic to use a new function, improving
code maintainability and data handling.

- **Bug Fixes**
- Fixed inconsistencies in the navigation menu across different
components in the editor.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-21 00:26:53 +03:00
Shrikant Sharat Kandula
88e39f42be chore: fix log line splitting in supervisor event handler 2024-06-20 20:28:20 +05:30
Shrikant Sharat Kandula
3f7b53589c
fix: Supervisor buffer overflow errors (#34351)
Should fix the flood of buffer overflow errors we see from Supervisor.

The one "change" this PR has, is that all the logs from the Docker
container will now be coming from `stderr`, not `stdout`. I don't expect
it to cause any problems, but it _is_ a change in behaviour nonetheless.

Why do that? Because of the way Supervisor event listening works. This
fix is based on the conversation at
https://github.com/Supervisor/supervisor/issues/1417. Essentially that
`stdout` should be reserved as a communication channel between
Supervisord and the event-listener, and for logging, we should use
`stderr`.

**/test sanity**



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9592028116>
> Commit: 34a29eabc8dc82fb6a43b143e400d725d197a655
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9592028116&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Improved logging by switching to `print` statements with explicit
flushing for more reliable output handling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 19:36:15 +05:30
Pawan Kumar
e01b34ec5d
chore: tests for wds button widget (#34242)
/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced test cases for Anvil Button Widgets, including Canvas,
Preview, and Deploy modes.

- **Bug Fixes**
- Updated CSS and HTML selectors for better element targeting and
testing reliability.

- **Style**
  - Improved styling logic for buttons in the InlineButtons component.

- **Chores**
  - Added `data-testid` attributes for better test targeting.
- Refactored code for string concatenations and URL constructions in
DeployModeHelper.
<!-- end of auto-generated comment: release notes by coderabbit.ai
--><!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9597157402>
> Commit: c551705fe01aace94962fcc7fa91dff253136721
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9597157402&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-06-20 18:30:16 +05:30
Valera Melnikov
62fad08bf7
chore: add excludeFromTabOrder for wds widgets (#34361)
## Description
- Add excludeFromTabOrder for WDS widgets
- WDS Table refactoring

Fixes #32369   

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9596169254>
> Commit: 25d5ef47520266d904c3c545940ad6009e7b2a8f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9596169254&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced the ability to exclude toolbar buttons from the tab order
for improved accessibility and user experience. This can be controlled
via the `excludeFromTabOrder` property.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 15:51:59 +03:00
Anagh Hegde
e79f733072
chore: code split for consolidated API (#34328)
## Description
This PR does the code split of consolidated API to support adding the
environment details consolidated API in EE, as mentioned here in the
issue. - https://github.com/appsmithorg/appsmith/issues/33132

Fixes https://github.com/appsmithorg/appsmith/issues/33132

## Automation

/ok-to-test tags="@tag.Perf"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9595115979>
> Commit: 7e9cbe0a28807dec5ef3df168698508dbe9e0d0c
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9595115979&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Perf`

<!-- end of auto-generated comment: Cypress test results  -->







## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a consolidated API response structure to streamline data
from various endpoints, including user profiles, feature flags, and
more.
- Added comprehensive support for loading consolidated page information,
enhancing the efficiency of page load operations.
  
- **Refactor**
- Refactored internal service interfaces and implementations to improve
maintainability and extendability.
- Centralized the `getConsolidatedInfoForPageLoad` method for better
code organization and usability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
2024-06-20 17:37:07 +05:30
Nikhil Nandagopal
ca13db04c8 Updated Label Config 2024-06-20 17:11:36 +05:30
Nikhil Nandagopal
faf335807c Updated Label Config 2024-06-20 17:09:57 +05:30
dependabot[bot]
7346cfda8c
chore: bump socket.io from 4.6.1 to 4.6.2 in /app/client (#34350)
Bumps [socket.io](https://github.com/socketio/socket.io) from 4.6.1 to
4.6.2.
## Automation

/ok-to-test tags="@tag.Sanity"
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/socketio/socket.io/releases">socket.io's
releases</a>.</em></p>
<blockquote>
<h2>4.6.2</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>exports:</strong> move <code>types</code> condition to the
top (<a
href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>)
(<a
href="3d44aae381">3d44aae</a>)</li>
</ul>
<h4>Links</h4>
<ul>
<li>Diff: <a
href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">https://github.com/socketio/socket.io/compare/4.6.1...4.6.2</a></li>
<li>Client release: <a
href="https://github.com/socketio/socket.io-client/releases/tag/4.6.2">4.6.2</a></li>
<li><a
href="https://github.com/socketio/engine.io/releases/tag/6.4.2"><code>engine.io@~6.4.2</code></a>
(<a
href="https://github.com/socketio/engine.io/compare/6.4.1...6.4.2">diff</a>)</li>
<li><a
href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
(no change)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/socketio/socket.io/blob/main/CHANGELOG.md">socket.io's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">4.6.2</a>
(2023-05-31)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>exports:</strong> move <code>types</code> condition to the
top (<a
href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>)
(<a
href="3d44aae381">3d44aae</a>)</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a
href="https://github.com/socketio/engine.io/releases/tag/6.4.0"><code>engine.io@~6.4.2</code></a>
(<a
href="https://github.com/socketio/engine.io/compare/6.4.1...6.4.2">diff</a>)</li>
<li><a
href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
(no change)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="faf914c9ab"><code>faf914c</code></a>
chore(release): 4.6.2</li>
<li><a
href="15af22fc22"><code>15af22f</code></a>
refactor: add a noop handler for the error event</li>
<li><a
href="d3658944e5"><code>d365894</code></a>
chore: bump socket.io-parser to version 4.2.3</li>
<li><a
href="12b0de4f52"><code>12b0de4</code></a>
chore: bump engine.io to version 6.4.2</li>
<li><a
href="3d44aae381"><code>3d44aae</code></a>
fix(exports): move <code>types</code> condition to the top (<a
href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>)</li>
<li><a
href="cbf0362476"><code>cbf0362</code></a>
docs(examples): bump dependencies for the private messaging example</li>
<li><a
href="59280da20b"><code>59280da</code></a>
docs(examples): update examples to docker compose v2</li>
<li><a
href="50a4d37cb8"><code>50a4d37</code></a>
docs(changelog): add version of transitive dependencies</li>
<li><a
href="6458b2bef1"><code>6458b2b</code></a>
docs(example): basic WebSocket-only client</li>
<li><a
href="b56da8a99f"><code>b56da8a</code></a>
docs(examples): upgrade to React 18</li>
<li>See full diff in <a
href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io&package-manager=npm_and_yarn&previous-version=4.6.1&new-version=4.6.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/appsmithorg/appsmith/network/alerts).

</details>

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9591866384>
> Commit: dd65e5111bb195514a815908757f6864b39625be
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9591866384&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-20 16:25:38 +05:30
dependabot[bot]
a1e5024806
chore: bump tinymce from 7.0.0 to 7.2.0 in /app/client (#34349)
Bumps
[tinymce](https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce)
from 7.0.0 to 7.2.0.
## Automation

/ok-to-test tags="@tag.Sanity"
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md">tinymce's
changelog</a>.</em></p>
<blockquote>
<h2>7.2.0 - 2024-06-19</h2>
<h3>Added</h3>
<ul>
<li>Added <code>options.debug</code> API that logs the initial raw
editor options to console. #TINY-10605</li>
<li>Added <code>referrerpolicy</code> as a valid attribute for an iframe
element. #TINY-10374</li>
<li>New <code>onInit</code> and <code>stretched</code> properties to the
<code>HtmlPanel</code> dialog component. #TINY-10900</li>
<li>Added support for querying the state of the
<code>mceTogglePlainTextPaste</code> command. #TINY-10938</li>
<li>Added <code>for</code> option to dialog label components to improve
accessibility. The value must be another component on the same dialog.
#TINY-10971</li>
</ul>
<h3>Improved</h3>
<ul>
<li>Dialog slider components now emit an onChange event when using arrow
keys. #TINY-10428</li>
<li>Accessibility for element path buttons, added tooltip to describe
the button and removed incorrect <code>aria-level</code> attribute.
#TINY-10891</li>
<li>Improve merging of inserted inline elements by removing nodes with
redundant inheritable styles. #TINY-10869</li>
<li>Improved Find &amp; Replace dialog accessibility by changing
placeholders to labels. #TINY-10871</li>
</ul>
<h3>Changed</h3>
<ul>
<li>Replaced tiny branding logo with <code>Build with TinyMCE</code>
text and logo. #TINY-11001</li>
</ul>
<h3>Fixed</h3>
<ul>
<li>Deleting in a <code>div</code> with preceeding <code>br</code>
elements would sometimes throw errors. #TINY-10840</li>
<li><code>autoresize_bottom_margin</code> was not reliably applied in
some situations. #TINY-10793</li>
<li>Fixed cases where adding a newline around a br, table or img would
not move the cursor to a new line. #TINY-10384</li>
<li>Focusing on <code>contenteditable=&quot;true&quot;</code> element
when using <code>editable_root: false</code> and inline mode causing
selection to be shifted. #TINY-10820</li>
<li>Corrected the <code>role</code> attribute on listbox dialog
components to <code>combobox</code> when there are no nested menu items.
#TINY-10807</li>
<li>HTML entities that were double decoded in <code>noscript</code>
elements caused an XSS vulnerability. #TINY-11019</li>
<li>It was possible to inject XSS HTML that was not matching the regexp
when using the <code>noneditable_regexp</code> option. #TINY-11022</li>
</ul>
<h2>7.1.2 - 2024-06-05</h2>
<h3>Fixed</h3>
<ul>
<li>CSS color values set to <code>transparent</code> were incorrectly
converted to '<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/000000">#000000</a>`.
#TINY-10916</li>
</ul>
<h2>7.1.1 - 2024-05-22</h2>
<h3>Fixed</h3>
<ul>
<li>Insert/Edit image dialog lost focus after the image upload
completed. #TINY-10885</li>
<li>Deleting into a list from a paragraph that has an <code>img</code>
tag could cause extra inline styles to be added. #TINY-10892</li>
<li>Resolved an issue where emojis configured with the
<code>emojiimages</code> database were not loading correctly due to a
broken CDN. #TINY-10878</li>
<li>Iframes in dialogs were not rendering rounded borders correctly.
#TINY-10901</li>
<li>Autocompleter possible values are no longer capped at a length of
10. #TINY-10942</li>
</ul>
<h2>7.1.0 - 2024-05-08</h2>
<h3>Added</h3>
<ul>
<li>Parser support for math elements. #TINY-10809</li>
<li>New <code>math-equation</code> icon. #TINY-10804</li>
</ul>
<h3>Improved</h3>
<ul>
<li>Included <code>itemprop</code>, <code>itemscope</code> and
<code>itemtype</code> as valid HTML5 attributes in the core schema.
#TINY-9932</li>
<li>Notification accessibility improvements: added tooltips, keyboard
navigation and shortcut to focus on notifications. #TINY-6925</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="754e390c67"><code>754e390</code></a>
TINY-10860: Prepare for 7.2 release (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9715">#9715</a>)</li>
<li><a
href="a9fb858509"><code>a9fb858</code></a>
TINY-11019 &amp; TINY-11022: Fixed issues with noscript encoding and
noneditable_...</li>
<li><a
href="3fae00c85d"><code>3fae00c</code></a>
TINY-10807: Use role=&quot;combobox&quot; for flat ListBox components
(<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9665">#9665</a>)</li>
<li><a
href="e7ef3b66e2"><code>e7ef3b6</code></a>
TINY-10871: replace placeholders with labels in Find &amp; Replace
dialog (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9689">#9689</a>)</li>
<li><a
href="6ce11b6860"><code>6ce11b6</code></a>
TINY-10936: Merge release to main (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9685">#9685</a>)</li>
<li><a
href="5fa376a63e"><code>5fa376a</code></a>
TINY-11001: Replaced tiny branding logo (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9683">#9683</a>)</li>
<li><a
href="c42efc2871"><code>c42efc2</code></a>
TINY-10938: Added query command for paste as plaintext status. (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9651">#9651</a>)</li>
<li><a
href="70cff122d8"><code>70cff12</code></a>
TINY-10971: introduce optional label for property (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9681">#9681</a>)</li>
<li><a
href="054671e930"><code>054671e</code></a>
TINY-10891: Add tooltips to element path (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9676">#9676</a>)</li>
<li><a
href="465fbbee67"><code>465fbbe</code></a>
TINY-10869: Improve merging inserted nested inline elements (<a
href="https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce/issues/9658">#9658</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/tinymce/tinymce/commits/7.2.0/modules/tinymce">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tinymce&package-manager=npm_and_yarn&previous-version=7.0.0&new-version=7.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/appsmithorg/appsmith/network/alerts).

</details>

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9591867087>
> Commit: f7d533fc00e49699da63dd447bb3fe246306ee73
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9591867087&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-20 16:25:27 +05:30
Apeksha Bhosale
22dade8d37
chore: Removed two extra machines for ci-test-limit (#34357)
## Description
ci-test-limit runs 3 machines by default and this is wastage of our
resource, in most of our use cases we end up using only one machine
soremoving extra unnecessary two.

run -
https://github.com/appsmithorg/appsmith/actions/runs/9593828953/job/26455099156

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9594698568>
> Commit: 18d2ab3a9f292c6e3ca8ed7c803bbabde75cb1ab
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9594698568&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
  - Updated test workflow configuration for more efficient CI runs.
  
- **Tests**
- Switched limited test spec file to improve test coverage and
relevance.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 11:42:59 +02:00
Nikhil Nandagopal
a5b1200d18 Updated Label Config 2024-06-20 14:46:01 +05:30
Alex
138fc6a148
feat: side-by-side edit mode hover analytics (#34185)
## Description
The purpose of this PR is to collect data about hovered canvas and
widgets and send it to analytics platform.

Fixes #33159

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9584384829>
> Commit: 9cec247f7f1e82e0cc23fa5aa5499008bdc58964
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584384829&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: ``

<!-- end of auto-generated comment: Cypress test results  -->












## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced analytics tracking for side-by-side hover actions in the
IDE canvas.
- Added a new `AnalyticsWrapper` component for handling analytics events
within layout systems.
- Implemented a custom hook `useIsInSideBySideEditor` to check for
side-by-side editor mode.
  - Added new CSS styles for layout systems.

- **Bug Fixes**
- Improved handling of widget hover events and analytics tracking in
side-by-side editor mode.

- **Refactor**
- Refactored logic for determining the current entity info and segment
state in the IDE.
  - Updated import paths and reordered imports for better organization.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 14:03:06 +05:30
Nikhil Nandagopal
44039f722d Updated Label Config 2024-06-20 13:35:02 +05:30
Nikhil Nandagopal
cd6c8f6eda Updated Label Config 2024-06-20 13:34:42 +05:30
Nikhil Nandagopal
8dbcaf8828 Updated Label Config 2024-06-20 13:34:06 +05:30
Abhijeet
0cdc15cf26
fix: Retain existing flags even if CS API fails (#34306)
## Description
PR to fix refreshing feature flags when instance fails to fetch flags
from CS.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9563924054>
> Commit: 9278bb30d62f7fbb7656e39448be6df611cd9514
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9563924054&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved feature flag updates by ensuring cached tenant features are
evicted before updating, preventing potential stale data issues.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 13:08:35 +05:30
Alex
a6faf6d7a5
perf: add react-hooks/exhaustive-deps rule (#34338)
## Description
Adds ESLint rule `react-hooks/exhaustive-deps` with warn level. Context
in the task below.

Fixes #34337 

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9584250724>
> Commit: daa705074504f398b80b1175440d00011b5d865d
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9584250724&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: ``

<!-- end of auto-generated comment: Cypress test results  -->





## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Added ESLint rule `react-hooks/exhaustive-deps` with a severity level
of "warn" to enforce exhaustive dependencies in React hooks.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 10:20:19 +03:00
Alex
b85c4f5451
refactor: move apps link out of menu & refactor nav menu data (#34313)
## Description
Moved `Back to all apps` from  dropdown menu directly to header.

Additionally renamed `NavigationMenuData.ts` to
`useNavigationMenuData.ts` and fixed dependency related memoization
issues.

<img width="267" alt="image"
src="https://github.com/appsmithorg/appsmith/assets/173164/020abfe3-1359-43ff-aa99-972a45f270bd">

Fixes #32982

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9567752111>
> Commit: 824b2fe1231de1d073a1b19054507643b325400f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567752111&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.IDE`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Removed `getNavigationMenu` prop from `EditorHeader` for streamlined
navigation menu data retrieval.
- Updated `EditorName` to use `useNavigationMenuData` for navigation
menu items.
- Refactored `useNavigationMenuData` to use `useCallback` and `useMemo`
for enhanced performance.
- Adjusted imports and event handling functions in `IDE/Header` to use
`useCallback` for better efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 10:13:35 +03:00
Saicharan Chetpelly
092208a1c1
fix: checkbox column misalignment on table widget (#34222)
Fixes #21790
_or_  
Fixes [Issue URL](https://github.com/appsmithorg/appsmith/issues/21790)

Introduced a new prop called isFullWidth for the CheckboxComponent and
pass this prop to this styled component CheckboxContainer. The
isFullWidth is an optional boolean property whole default value would be
true.
 
Added screenshot for reference.

![image](https://github.com/appsmithorg/appsmith/assets/119920490/1e5f3a9c-d98a-4525-85bc-8f6f471435ed)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a full-width option for checkboxes to enable better styling
flexibility.
  
- **Tests**
- Added new test cases to verify checkbox styling properties in tables.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 11:50:37 +05:30
Shrikant Sharat Kandula
5a1ec0c591
chore: Disallow plugin requests to localhost (#34250)
The microservices that run inside the Appsmith container, trust each
other, and may expose sensitive API endpoints to other internal
microservices. These sensitive APIs aren't accessible by outside the
Appsmith container, protected by Caddy's routing.

This means that the backend server's ability to make user-configured
HTTP requests, can lead to SSRFs to such sensitive API calls, if it's
allowed to call APIs on localhost.

In other words, Caddy establishes a trust boundary that protects these
internal APIs from outside the container. But we lack such a trust
boundary for the backend's plugins (API plugin, Elasticsearch plugin,
etc.). This PR solves that.

In this PR, we block both IPv4 and IPv6 loopback addresses.

No additional changes needed on EE, no conflicts, and all unit and
Cypress tests pass.

**/test all**

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9590358198>
> Commit: 5445c70aa873942c3edae9fbfcc57a6d2554b815
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9590358198&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: ``

<!-- end of auto-generated comment: Cypress test results  -->












<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved handling of disallowed hosts by dynamically computing based
on environment variables, offering more flexibility and control.
  
- **Refactor**
- Enhanced the `makeWebClient()` method to use a more efficient approach
for creating WebClient objects with custom configurations.

- **Chores**
- Added an `ENV` declaration for `IN_DOCKER` in the Dockerfile to better
manage Docker-specific configurations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 11:00:22 +05:30
Shrikant Sharat Kandula
ef01ab5b31
chore: Remove findById signature with Optional (#34302)
Follow up to https://github.com/appsmithorg/appsmith/pull/34281.

The `.findById` method is now removed.

No conflicts, but needs extra changes in [this
PR](https://github.com/appsmithorg/appsmith-ee/pull/4482) for build to
pass on EE.

**/test sanity**



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9563607766>
> Commit: 02f6031cec08a4e805f479b500be40b08a003142
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9563607766&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated methods to use direct values instead of `Optional` for
permissions, simplifying method signatures and improving readability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 10:21:12 +05:30
Shrikant Sharat Kandula
e38c7cc32b
chore: Remove redundant adding Postgres bin to PATH (#34316)
This temporary change is no longer needed.

**/test sanity**


<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9574310795>
> Commit: abad77fb024c61b595c529aa2ed024b8dcdf5dfb
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9574310795&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Improved the startup script by removing obsolete PATH modification for
PostgreSQL.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 10:08:30 +05:30
Valera Melnikov
36372468c5
chore: remove headless radio and use react-aria component instead (#34312)
## Description

- Remove headless radio and use react-aria component instead
- Create ErrorMessage component

Fixes #27677 

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9567388261>
> Commit: 62d1153caa8bf03d827f88593c9dfaf3121091ee
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567388261&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added `ErrorMessage` component for displaying error messages with
specific styling.
- Introduced `isDisabled` prop for `Label` and `ToggleGroup` components.
- Updated `RadioGroup` to accept an items array for easier
configuration.

- **Bug Fixes**
- Improved conditional rendering in `Label` component to prevent issues
when `text` and `contextualHelp` are both falsy.

- **Refactor**
  - Removed `Radio` component export from design system.
- Restructured import statements and prop declarations for `Checkbox`
and `RadioGroup`.

- **Style**
- Updated styles for `RadioGroup` and `ToggleGroup` components for
better state handling (disabled, hovered, selected).

- **Documentation**
- Updated Storybook stories for `RadioGroup` to reflect changes in
component usage.

- **Tests**
  - Adjusted `RadioGroup.test.tsx` to test new items array prop.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-19 11:08:42 +03:00