Commit Graph

1397 Commits

Author SHA1 Message Date
ramsaptami
69b1a60082
chore: cleaned up formatting for the template (#22670)
## Description

Cleaned up template heading and section styles on PR template

- Chore (housekeeping or task changes that don't impact user perception)

---------

Co-authored-by: Hetu Nandu <hetu@appsmith.com>
2023-05-05 20:38:21 +05:30
Shrikant Sharat Kandula
3c8c940caf
ci: Remove unused java setup step (#22978)
We're setting up Java, but aren't using it in this workflow. This PR
removes it.
2023-05-04 11:52:57 +05:30
Shrikant Sharat Kandula
1504254d84
ci: Fix issue title injections in workflow 2023-05-02 11:02:43 +05:30
Arun
693aa75e79
fix: Security Vulnerability in GitHub Workflows (#22888)
"github.event.issue.title" is potentially untrusted. avoid using it
directly in inline scripts. instead, pass it through an environment
variable. see
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions
for more details.
2023-05-02 10:59:34 +05:30
yatinappsmith
af6b2b0150
ci: Increased clientbuild runner (#22722)
## Description

Increased clientbuild runner


## Type of change



- Bug fix (non-breaking change which fixes an issue)

## How Has This Been Tested?

- Manual

### Test Plan
None

### Issues raised during DP testing
None


## Checklist:
### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-25 17:18:23 +05:30
Saroj
b5850ba78a
ci: Added step to check the PR approval status (#22671)
## Description
- Added step to check the PR approval status
- Used another plugin for merge

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-24 17:51:25 +05:30
Saroj
a0ab7fa990
ci: Added UPDATE_LABLES and update the rename variables with more meaningful name (#22585)
## Description
- Added UPDATE_LABLES and update the rename variables with more
meaningful name

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github Actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-20 13:19:59 +05:30
Saroj
fc01e65df8
ci: Add env to print logs from auto-merge in ci-merge-check (#22581)
## Description
- Added logging for auto merge in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-20 12:38:30 +05:30
Saroj
4459ba3cef
ci: Updated requirements for auto merge in ci-merge-check (#22567)
## Description
- Updated requirements for auto merge in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-20 11:15:04 +05:30
Saroj
2729bbff28
ci: Fix for ci-merge-check.yml issues (#22564)
## Description
-  Fix for ci-merge-check.yml issues

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 17:40:09 +05:30
Saroj
2794ec695c
ci: Fix for "Test Plan Approved" check in ci-merge-check (#22547)
## Description
- Consider the latest one if there are more than one 'Test plan
approved' output in the api

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github Actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 14:48:55 +05:30
Saroj
10b51c15f0
ci: Fix ci-test-result in ci-merge-check (#22540)
## Description
- Fixing ci-test-result in ci-merge-check
- Added Authorisation header in the curl requests to support this in EE

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github Actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 12:32:34 +05:30
Saroj
5620d0ab09
ci: Fix ci-merge-check issue (#22528)
## Description
- Fix ci-merge-check issue

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Guthub actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-19 09:51:30 +05:30
Saroj
43febea649
ci: Added logic to handle few more cases in ci-merge-check (#22519)
## Description
- Added logic to handle few more cases in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github Actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 18:23:22 +05:30
Saroj
e8a986516c
ci: Fix syntax error in ci-merge-check (#22518)
## Description
- Fix syntax error in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 17:12:31 +05:30
Saroj
27d5b76d1f
ci: Modified the logic to pick the last comment for ci-merge-check (#22517)
## Description
- Modified the logic to pick the last comment for ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 17:04:12 +05:30
Saroj
ddccd8d24b
ci: Fix to fetch the sha id from client_payload instead of event.pull_request (#22513)
## Description
- Fix to fetch the sha id from client_payload instead of
event.pull_request in ci-merge-check

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 16:44:11 +05:30
Saroj
b19e974d8e
ci: Fix for ci-merge-check workflow (#22511)
## Description
- Fix for ci-merge-check workflow

## Type of change
- ci-merge-check.yml


## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 16:14:12 +05:30
Saroj
0edcc07048
ci: Fix for ci-merge-check (#22452)
## Description
- Fixing ci-merge-check.yml

## Type of change
- ci-merge-check.yml

## How Has This Been Tested?
- Github actions

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-04-18 15:42:53 +05:30
Shrikant Sharat Kandula
7a0e54ae5f
chore: Delete unused close-label.yml 2023-04-18 07:43:58 +05:30
Goutham Pratapa
f32623420e
ci: uncomment debug statements and clear dps when merged (#22463)
Succesful run:
https://github.com/appsmithorg/appsmith/actions/runs/4718116171/jobs/8367371248
2023-04-17 15:45:52 +05:30
Nikhil Nandagopal
55e45e8250 Updated Label Config 2023-04-17 14:53:09 +05:30
Goutham Pratapa
6bbcbc1b2c
ci: add workflows to cleanup merged deploy-previews (#20627)
[20765](https://github.com/appsmithorg/appsmith/issues/20765)
2023-04-17 11:39:33 +05:30
Goutham Pratapa
9b37810c7b
ci: add recreate option for dps (#22091)
fixes: [248](https://github.com/appsmithorg/cloud-deployment/issues/248)


https://github.com/appsmithorg/appsmith-ci/pull/14#issuecomment-1504569726
This doesnt delete the existing stacks 


https://github.com/appsmithorg/appsmith-ci/pull/14#issuecomment-1504842238
this deletes the stack, database in mongo and therefore creating a
complete new stack
2023-04-14 16:27:17 +05:30
Nikhil Nandagopal
14710d297b Updated Label Config 2023-04-13 19:59:10 +05:30
Nikhil Nandagopal
07e6f15336 Updated Label Config 2023-04-12 16:52:16 +05:30
Nikhil Nandagopal
634d0a9d79 Updated Label Config 2023-04-12 14:19:00 +05:30
Aishwarya-U-R
f88c1b1077
ci: Update the text in Git comment flaky tests app link (#22307)
## Description

- This PR updates the text message that gets commented after a PR run

## Type of change

- Yml file update

## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
2023-04-12 11:07:55 +05:30
Nikhil Nandagopal
a23bd70e29 Updated Label Config 2023-04-11 10:37:06 +05:30
Nikhil Nandagopal
2206d0a513 Updated Label Config 2023-04-11 10:36:56 +05:30
Nikhil Nandagopal
b0581da992 Updated Label Config 2023-04-10 21:38:40 +05:30
Nikhil Nandagopal
318d862709 Updated Label Config 2023-04-10 18:55:04 +05:30
Aishwarya-U-R
5f1e4d1ba8
test: Cypress - flaky fix + Git comment improve (#22169)
## Description

- This fixes the Firestore spec that fails sometimes in CI due to all
runs accessing the same cloud collection for validation.
- This PR also adds comments to PR - if all cypress cases passed, right
now there is no comment

## Type of change

- Script update

## How Has This Been Tested?

- Cypress CI runs


## Checklist:
### QA activity:
- [X] Added Test Plan Approved label after reviewing all Cypress test
2023-04-10 17:41:14 +05:30
Shrikant Sharat Kandula
64edd25a8b
ci: Use vars for DOCKER_HUB_ORGANIZATION (#22177)
GitHub's Variables, unlike Secrets, don't get masked in the output, and
are ideal for non-secret... _variables_. I'm switching on such secret
here, and depending on our experience with this, we'll look to moving
more.

Of course, goes without saying, do NOT use these variables for secrets.
When in doubt, use Secrets.

[Learn more about
Variables](https://docs.github.com/en/actions/learn-github-actions/variables).
2023-04-10 14:23:12 +05:30
Nikhil Nandagopal
0eb8ff5ce1 Updated Label Config 2023-04-07 13:36:44 +05:30
Goutham Pratapa
f56596af62
fix:skipping jest-tests in client workflow (#21675)
Fixes: [22072](https://github.com/appsmithorg/appsmith/issues/22072)
Running as part of individual builds:


https://github.com/appsmithorg/appsmith/actions/runs/4605026111/jobs/8136569091
2023-04-07 12:41:36 +05:30
Nikhil Nandagopal
14e78fb550 Updated Label Config 2023-04-07 00:15:24 +05:30
Shrikant Sharat Kandula
0b7bedf1fc
ci: Fix close-labeler to work on correct repo for issues 2023-04-05 19:08:39 +05:30
Saroj
292c32407b
ci: Added 'Workflow run' and 'Commit' for the failed spec comments (#22128)
## Description
- Added 'Workflow run' and 'Commit' for the failed spec comments

## Type of change
- YML Changes

## How Has This Been Tested?
- CI run

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-04-05 14:45:59 +05:30
Shrikant Sharat Kandula
1836a44577
ci: Remove license in ci-test.yml (#21938)
The License key is unused in this repo. Setting it here is misleading,
and can cause confusions at best, or missed accidental License failures
at worst.

This PR removes the License key occurrences from `ci-test.yml`.

Note: Please review/approve only. Don't merge. This will likely cause a
conflict, so I'd like to be available when this is merged so I can
resolve the conflict. Thanks!
2023-04-05 09:38:44 +05:30
Shrikant Sharat Kandula
164a724969
ci: Add inhouse close-labeler workflow 2023-04-05 07:14:08 +05:30
Aishwarya-U-R
85f3ebc1f3
ci: Starting ElasticSearch DB container for running test scripts in CI runs (#22102)
## Description

- This PR includes ElasticSearch as separate docker container inside CI
that can be used for running ElasticSearch datasource test cases in CI

## Type of change

- Yaml file update


## Checklist:
### QA activity:
- [ ] Added Test Plan Approved label after reviewing all changes
2023-04-05 01:36:57 +05:30
Aishwarya-U-R
83ea3c04cf
test: Cypress - Automated tests for Firestore datasource (#22057)
## Description

- This PR includes tests for Firestore ds - with querying & usage of
various fields in the query page

## Type of change

- New script

## How Has This Been Tested?

- Cypress CI runs

## Checklist:

### QA activity:
- [ ] Added Test Plan Approved label after reviewing all changes
2023-04-04 21:26:57 +05:30
Nikhil Nandagopal
78a210e12e Updated Label Config 2023-04-04 13:23:50 +05:30
Nikhil Nandagopal
3b86afb4d1 Updated Label Config 2023-04-04 13:23:17 +05:30
Nikhil Nandagopal
d885b479c7 Updated Label Config 2023-04-04 11:44:31 +05:30
Aishwarya-U-R
ceefaa00bc
Test: Adding Smoke & Sanity suites into the CI pipeline (#22029)
## Description

- This PR introduces smoke & sanity tests into the CI pipeline, to
capture the failures early.

## Type of change

- CI Improvements


## How Has This Been Tested?

- Cypress runs on local PR workflows

## Checklist:

### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes

---------

Co-authored-by: Saroj <saroj@appsmith.com>
2023-04-04 10:39:40 +05:30
Aishwarya UR
a5f0689a24 Adding FIRESTORE_PRIVATE_KEY to git 2023-04-04 03:12:46 +05:30
Aishwarya-U-R
dffbf3d97c
ci: Adding Identified Flaky tests app link into Git comments section in a PR (#21966)
## Description

- This PR adds the Flaky list application link into the git comments
section on completion of the run, so the PR owners have easy access to
it.


## Type of change

- Yml file update

## Checklist:

### QA activity:
- [X] Added Test Plan Approved label after reviewing all changes
2023-03-31 16:55:51 +05:30
Nikhil Nandagopal
ea704bcf08 Updated Label Config 2023-03-31 08:25:58 +05:30