Commit Graph

13796 Commits

Author SHA1 Message Date
Ivan Akulov
8a1870daa6
perf: reduce the bundle size, vol. 2 (#24969)
Co-authored-by: Tanvi Bhakta <tanvibhakta@gmail.com>
Co-authored-by: Satish Gandham <hello@satishgandham.com>
2023-07-17 00:19:41 +05:30
Appsmith Bot
25177f4837 Update top contributors 2023-07-16 07:00:57 +05:30
Appsmith Bot
845a9b528d Update top contributors 2023-07-15 07:00:15 +05:30
Sumit Kumar
99c87d1a78
chore: add cypress test case to validate port number placeholder (#25370) 2023-07-14 15:02:33 +05:30
arunvjn
4dd417a511
chore: Stop logging uncaught user generated error into sentry (#25338)
## Description
> Sentry can capture and log unhandled errors from web workers. The
global error handlers added earlier to prevent sentry from logging user
exception doesn't prevent the default behaviour, thereby propagating the
error further into sentry error handling logic. This PR adds
`preventDefault` to the unhandled errors.
> 
>
>
#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>

#### Type of change
- Bug fix (non-breaking change which fixes an issue)
>
>
>
## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-14 07:27:58 +05:30
Appsmith Bot
73cd46875c Update top contributors 2023-07-14 06:59:30 +05:30
Druthi Polisetty
6dcb996bbb
feat: Created component for ai signposting (#25187)
## Description
feat: Created component for ai signposting

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-13 17:36:38 +05:30
vadim
0bc1213795
feat: WDS color bgNeutral, states and Subtle variant (#25332)
## Description

tl;dr States and other derivatives of `bgNeutral`, some fixes for
`bgNeutral` logic itself.

Fixes #24512  

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-13 11:39:42 +03:00
Appsmith Bot
7a9749e497 Update top contributors 2023-07-13 06:59:15 +05:30
Aishwarya-U-R
5824493b7a
test: Cypress | Flaky fix (#25343)
## Description
- This PR updates RenameApplication()
- Skips TableV2TextPagination_spec & TableTextPagination_spec - until
fixed
2023-07-13 01:41:11 +05:30
Aishwarya-U-R
6f9a7e8952
test: Cypress | Flaky fix (#25340)
## Description
- This PR fixes RenameApplication()
- Gives trial fix for TableTextPagination_spec.js &
TableV2TextPagination_spec
2023-07-12 20:24:00 +05:30
Rahul Barwal
7cd941ec6d
chore: Refactors hide embed share setting flag. (#25284)
## Description
As we are deprecating FF4J system in favour of flagsmith. 
This PR renames APP_EMBED_VIEW_HIDE_SHARE_SETTINGS_VISIBILITY to
release_embed_hide_share_settings_enabled
#### PR fixes following issue(s)
Fixes #25232 
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
- [x] Cypress
>
>
#### Test Plan
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-12 19:19:49 +05:30
Vijetha-Kaja
da1f065ba9
test: Cypress - Skipping test to unblock CI (#25337)
## Description

**Skipped below flaky tests to unblock CI**

- JS_AC2_spec.ts

## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-12 19:16:38 +05:30
Vijetha-Kaja
63d0cf47bf
test: Cypress - Flaky Fix (#25323)
## Description

**Fixed below flaky tests**

- TableTextPagination_spec.js
- TableV2TextPagination_spec.js

## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-12 19:01:17 +05:30
Valera Melnikov
a14df58239
fix: pre-commit logic (#25324)
## Description
Hot fix for pre-commit logic

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-12 12:37:05 +03:00
Hetu Nandu
bbcadb185f
ci: Feature Flag selector code split (#25322)
Splits the Feature flag selectors file to ensure we do not cause
conflicts in the EE repo
2023-07-12 14:15:37 +05:30
Valera Melnikov
2b59f40a0b
fix: fixes for running checks on pre-commit for BE and FE separately (#25319)
## Description
Fixes for running checks on pre-commit for BE and FE separately

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-07-12 10:12:28 +03:00
Ayangade Adeoluwa
0dcef48dc8
feat: activation phase 1 (#25126)
Feature implementations:
- Schema in the Api Right Side Pane; 
- New Bindings UI, which is now a suggested widget; 
- Feature walkthrough for the aforementioned two units only if you are a new user.
Only those users who have the flags `ab_ds_binding_enabled` and `ab_ds_schema_enabled` independently set to true can see the implementation described above.
https://www.notion.so/appsmith/Activation-60c64894f42d4cdcb92220c1dbc73802
2023-07-12 12:12:16 +05:30
Sangeeth Sivan
daece53b66
fix: lodash import (#25312) 2023-07-12 11:38:59 +05:30
Sangeeth Sivan
b1a5a1601d
fix: Table crashes when column width is greater than component width (#25198)
## Description
- When the table's column width is greater than the component width the
table widget crashes.

> Links to Notion, Figma or any other documents that might be relevant
to the PR
>
>
#### PR fixes following issue(s)
Fixes #25166 

#### Media
https://vdqm24wed6.vmaker.com/record/q4yZXh8n0uv7sVrl
>
#### Type of change

- Bug fix (non-breaking change which fixes an issue)


## Testing

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-12 10:41:20 +05:30
Rajat Agrawal
058c0261e2
chore: Fix changeset workflow to run on external contributor PR (#25227)
Fixes #25260
2023-07-12 10:40:19 +05:30
Appsmith Bot
4b5d65f8ed Update top contributors 2023-07-12 06:58:58 +05:30
Vijetha-Kaja
d7202abbc8
test: Cypress - Gitea App Automation (#25144)
## Description

**Fixed below flaky tests**

- Gitea app automation , validations covered:
    - A successful api call
    - An unsuccessful api cal
    - CRUD pages for DS - Postgres, Mongo, Mysql
    - CRUD table validations in Deploy page
    - Widgets & their bindings validations
    - Update JSObjects, bind it to widget & Validate updated response

## Type of change

- New feature

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-11 22:09:13 +05:30
vadim
eeb2d40a10
feat: WDS bgNeutral, fgNeutral (#25302)
## Description

tl;dr Automatic neutrals for arbitrary seed.

Fixes #25060 

## Type of change
- New feature (non-breaking change which adds functionality)

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-11 18:58:33 +03:00
vadim
8d1ff39947
fix: WDS color bdWarningHover return (#25306)
## Description

tl;dr Wrong color was exported (`bdWarning` instead of `bdWarningHover`)

## Type of change
- Bug fix

## How Has This Been Tested?

- Manual

### Test Plan
Initial POC refinement, no testing necessary

## Checklist:
### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-11 18:58:22 +03:00
Rishabh Rathod
8b1f5d7064
fix: CurrencyInput setValue due to meta override (#25290) 2023-07-11 18:17:55 +05:30
Sumit Kumar
fb5600a54d
fix: fix MsSQL JDBC URL format error (#25094) 2023-07-11 17:44:33 +05:30
akash-codemonk
3cedd9251f
feat: disallow collapsing sidebar when signposting is enabled (#24938) 2023-07-11 17:19:27 +05:30
Nikhil Nandagopal
3652e31f90 Updated Label Config 2023-07-11 16:23:47 +05:30
Sangeeth Sivan
77e3778b3e
feat: remove papa parse and use sheetjs for csv to json parsing (#24779) 2023-07-11 16:06:33 +05:30
Hetu Nandu
6eb8a02e15
fix: removes race conditions in recent perf optimisation (#25298)
We missed a race condition in: #25104 which caused some test cases to
fail. This would rarely happen to any new apps in production but to
ensure backwards compatibility we are updating the code itself
2023-07-11 10:26:18 +00:00
Manish Kumar
e9dae0102d
chore: removal of transfer solution (#25288) 2023-07-11 14:30:10 +05:30
Aman Agarwal
fe59f0196e
fix: edit ds button was disabled due to no user perm in ds object (#25235) 2023-07-11 13:30:32 +05:30
Aishwarya-U-R
546843ebd6
test : Cypress | Flaky fix Onboarding/GuidedTour_spec.js (#25294)
## Description
- This PR fixes the flaky Onboarding/GuidedTour_spec.js
2023-07-11 13:07:24 +05:30
Anagh Hegde
6f389323ba
chore: Add repoUrl to analytics datapoint (#25276)
## Description
Add repo Url to analytics
Remove event data field from the analytics

#### PR fixes following issue(s)
Fixes #25142
2023-07-11 12:36:13 +05:30
Aishwarya-U-R
a8eef88e6c
test: Cypress | Flaky Fixes (#25217)
## Description
- This PR fixes below specs:
- /ListV2/Listv2_dataIdentifierProperty_spec.js
- Improves validations in /Autocomplete/JS_AC2_spec.ts
- Moving all mockApi call to TEDTestConfigs
- Datasources/Airtable_Basic_Spec.ts
- ListV2/Listv2_onItemClick_spec.js
- FirstTimeUserOnboarding_spec.js - 5th - flaky fix
- /Binding/Widgets_Default_data_validation_spec.js
- AssertDocumentReady() improved - added timeout to check page load
- TableV2/TableV2_Widget_Add_button_spec.js
- Binding/ButtonWidgets_NavigateTo_validation_spec.js
- UpdatePropertyFieldValue() improved - added intercept validation

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
- 
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-07-11 10:44:13 +05:30
Nayan
71240f254e
fix: Custom theme deleted at checkout remote branch (#25221)
## Description
This PR fixes the bug when custom themes are not duplicated when user
checks out to a new branch.

#### PR fixes following issue(s)
Fixes #21474
2023-07-11 10:58:31 +06:00
Appsmith Bot
b0b3fefa72 Update top contributors 2023-07-11 06:59:00 +05:30
Ivan Akulov
b6dbe65e0b
perf(ee): code-split the Settings page away (#24993) 2023-07-10 19:21:15 +05:30
Manish Kumar
10b1081b7a
fix: add validation to datasource create flow and error handling (#25244) 2023-07-10 19:11:57 +05:30
Nidhi
c26dd3d249
chore: Skeleton for ME OOS changes (#25258) 2023-07-10 17:21:57 +05:30
Sumit Kumar
b5f0ee5d91
chore: remove redundant code (#25193) 2023-07-10 16:55:57 +05:30
SatVeer Singh
5170195ec7
fix: The bubble of the no. of commits in bottom bar in preview mode (#25051)
## Description
This PR fixes The bubble of the no. of commits is partially visible in
preview mode
#### PR fixes following issue(s)
Fixes #24859
#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan

## Checklist:
#### Dev activity
- [x ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-10 14:33:26 +05:30
Indrajeet Nikam
0e5de3f90d
fix: vertically stack lint errors in the tooltip (#24974) (#25172)
## Description
Fixes the style for linting errors in the tooltip.

Earlier, They were presented side by side in case of multiple errors.
Now, They will appear vertically stacked as shown in the screenshot
attached below

#### PR fixes following issue(s)
Fixes #24974

#### Media

![image](https://github.com/appsmithorg/appsmith/assets/24988127/67679ad8-b910-46c8-b102-49d45014b9af)

#### Latest DP
https://appsmith-bda3x9h6s-get-appsmith.vercel.app

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
Locally tested.

#### How Has This Been Tested?
- [X] Manual
- [X] Jest

#### Test Plan
skip-testPlan

#### Issues raised during DP testing

## Checklist:
#### Dev activity
- [X] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [X] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-10 13:07:28 +05:30
akash-codemonk
ca64c8a24c
chore: show stack trace with the failing action type for cypress (#25037) 2023-07-10 11:23:45 +05:30
Hetu Nandu
04a6314602
perf: Optimise App loading apis (#24365)
## Description
Start downloading app data earlier to improve load times. 


#### PR fixes following issue(s)
Fixes #24618

#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?

- [ ] Cypress

#### Test Plan
- [x] Loading apps in view/edit mode from home page and having them work
perfectly
- [x] Opening apps in view/edit mode directly via links and having them
work perfectly
- [x] Having apps with on page load actions
- [x] Test with complex widgets and see if they work properly

>
>
#### Issues raised during DP testing

https://github.com/appsmithorg/appsmith/pull/24365#issuecomment-1624013687
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
2023-07-10 11:21:40 +05:30
Nidhi
fca545a115
ci: Added pre-commit hook to check for Spotless formatting (#25228) 2023-07-10 11:18:52 +05:30
Preet Sidhu
0cc716c2a5
chore: add cypress tests for auto height scenarios (#23616)
## Description

Added specs:
1. AutoHeight_Container_spec.js
2. AutoHeight_Form_spec.js
3. AutoHeight_Modal_spec.js
4. AutoHeight_Tabs_spec.js

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [x] Cypress

---------

Co-authored-by: rahulramesha <rahul@appsmith.com>
2023-07-10 10:02:42 +05:30
Aishwarya-U-R
d2be101684
test: Cypress | Changing types of moved test specs (#25225)
## Description
- This PR changes types of moved files for promo PR to go thru
ClientBuild step
2023-07-10 08:39:28 +05:30
Aishwarya-U-R
aea5679221
test: Cypress | Skipping test to unblock CI (#25223)
## Description
- This PR skips Apps/CommunityIssues_Spec.ts - (8, 9, 10th) cases to
replace the failing api to TED api
2023-07-10 08:18:21 +05:30