Commit Graph

246 Commits

Author SHA1 Message Date
Ashit Rath
70f8777afd
chore: Compute default value for jsaction params (#34708)
## Description
This PR adds the values to jsArguments. The logic for this is
- If the value is string then it is kept as is
- For non-strings they are wrapped with `{{ }}` do maintain the data
type integrity when evaluated.

This property is currently not used anywhere in the platform and this is
intended to be used by js modules to identify the default values of
parameters and provide support to alter then in a UI in the app.

This PR also splits `workers/Evaluation/getJSActionForEvalContext.ts` to
override in the EE for modules

PR for https://github.com/appsmithorg/appsmith-ee/pull/4612

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9919551354>
> Commit: c6ab372477fb3fd2f1ce171729af4fa64ac2a487
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9919551354&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Sat, 13 Jul 2024 12:16:08 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added support for additional node types (`RestElement`,
`ObjectPattern`, `ArrayPattern`) in our AST processing.
- Introduced `addPropertiesToJSObjectCode` function to enhance
JavaScript object property management.

- **Updates**
- Enhanced `myFun2` function with new parameters and default values to
improve flexibility and usage.
- Improved `parseJSObject` function with additional parameters for
better functionality.

- **Tests**
- Added a new test suite for `addPropertiesToJSObjectCode` function to
ensure robust property management in JavaScript objects.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-07-15 21:01:42 +05:30
Valera Melnikov
08c3ea9b94
chore: cypress snapshot types (#34722)
## Description
1. Add scripts for local e2e testing in the docker container. 
2. Add types for cypress-image-snapshot

In this PR, I also added the following PRS as they affect screenshot
tests as well. I did this to speed up the process and unblock the team.

#34528
#34546
#34676
#34729
#34638
#34639
#34511

To run E2E tests locally in docker, you need to do the following:
1. Run FE locally and prepare the tests for local launch. See the
instructions
[here](https://github.com/appsmithorg/appsmith/blob/release/contributions/ClientSetup.md).
2. Run `yarn cypress:snapshot:docker:build` — this will create a docker
container with the necessary environment.
3. Run `yarn cypress:snapshot:docker
"./cypress/e2e/Regression/ClientSide/Anvil/Widgets/*_spec.ts"
updateSnapshots=false`. Here we can use the path to a specific file, or
set `updateSnapshots=true` flag to update the screenshots.

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9844579277>
> Commit: 75f26599b149f831051fbd631aaa059084b226dd
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9844579277&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`
> Spec:
> <hr>Mon, 08 Jul 2024 18:37:36 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added support for image snapshot testing with the
`@types/cypress-image-snapshot` dependency.

- **Refactor**
- Updated test specifications by removing unnecessary
`triggerInputInvalidState()` calls.
- Reorganized and improved efficiency of image snapshot methods for
various devices.

- **Chores**
- Updated `Dockerfile` to configure the Cypress environment with
specific versions for dependencies.
  - Changed import paths in `e2e.js` for better module resolution. 

- **Style**
  - Fixed a comment typo in Cypress plugin configuration.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
Co-authored-by: unknown <vadim@appsmith.com>
2024-07-09 12:06:59 +03:00
Ashok Kumar M
ed497dbe9c
chore: add tests for anvil modal. (#34347)
[![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX1n8wGoml2WVG4C2fL4hX6Z1rh6k4aeSvE%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=9GEnyEC)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #33740 
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9643638292>
> Commit: bcc4bbddaa50b0be16e41a3a51db4f6abe732e79
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9643638292&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->









## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced test cases for Anvil modals, covering interactions like
opening, closing, drag and drop operations, and handling modal
functions.

- **Bug Fixes**
- Enhanced testing capabilities with `data-testid` attributes for better
identification and testing of components, particularly in detached
widget drop areas.

- **Refactor**
- Updated the `Modal` component to use `dataAttributes` instead of
`size` prop to streamline attribute handling.
- Dynamic generation of modal class names based on properties for better
styling and consistency.

- **Style**
- Adjusted styling for SVG elements within the `EntityExplorer`
component, specifically modifying the height and width properties.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-06-24 16:28:34 +05:30
Pawan Kumar
e01b34ec5d
chore: tests for wds button widget (#34242)
/ok-to-test tags="@tag.Anvil"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced test cases for Anvil Button Widgets, including Canvas,
Preview, and Deploy modes.

- **Bug Fixes**
- Updated CSS and HTML selectors for better element targeting and
testing reliability.

- **Style**
  - Improved styling logic for buttons in the InlineButtons component.

- **Chores**
  - Added `data-testid` attributes for better test targeting.
- Refactored code for string concatenations and URL constructions in
DeployModeHelper.
<!-- end of auto-generated comment: release notes by coderabbit.ai
--><!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9597157402>
> Commit: c551705fe01aace94962fcc7fa91dff253136721
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9597157402&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-06-20 18:30:16 +05:30
Valera Melnikov
62fad08bf7
chore: add excludeFromTabOrder for wds widgets (#34361)
## Description
- Add excludeFromTabOrder for WDS widgets
- WDS Table refactoring

Fixes #32369   

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9596169254>
> Commit: 25d5ef47520266d904c3c545940ad6009e7b2a8f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9596169254&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced the ability to exclude toolbar buttons from the tab order
for improved accessibility and user experience. This can be controlled
via the `excludeFromTabOrder` property.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-20 15:51:59 +03:00
dependabot[bot]
7346cfda8c
chore: bump socket.io from 4.6.1 to 4.6.2 in /app/client (#34350)
Bumps [socket.io](https://github.com/socketio/socket.io) from 4.6.1 to
4.6.2.
## Automation

/ok-to-test tags="@tag.Sanity"
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/socketio/socket.io/releases">socket.io's
releases</a>.</em></p>
<blockquote>
<h2>4.6.2</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>exports:</strong> move <code>types</code> condition to the
top (<a
href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>)
(<a
href="3d44aae381">3d44aae</a>)</li>
</ul>
<h4>Links</h4>
<ul>
<li>Diff: <a
href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">https://github.com/socketio/socket.io/compare/4.6.1...4.6.2</a></li>
<li>Client release: <a
href="https://github.com/socketio/socket.io-client/releases/tag/4.6.2">4.6.2</a></li>
<li><a
href="https://github.com/socketio/engine.io/releases/tag/6.4.2"><code>engine.io@~6.4.2</code></a>
(<a
href="https://github.com/socketio/engine.io/compare/6.4.1...6.4.2">diff</a>)</li>
<li><a
href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
(no change)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/socketio/socket.io/blob/main/CHANGELOG.md">socket.io's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">4.6.2</a>
(2023-05-31)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>exports:</strong> move <code>types</code> condition to the
top (<a
href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>)
(<a
href="3d44aae381">3d44aae</a>)</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li><a
href="https://github.com/socketio/engine.io/releases/tag/6.4.0"><code>engine.io@~6.4.2</code></a>
(<a
href="https://github.com/socketio/engine.io/compare/6.4.1...6.4.2">diff</a>)</li>
<li><a
href="https://github.com/websockets/ws/releases/tag/8.11.0"><code>ws@~8.11.0</code></a>
(no change)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="faf914c9ab"><code>faf914c</code></a>
chore(release): 4.6.2</li>
<li><a
href="15af22fc22"><code>15af22f</code></a>
refactor: add a noop handler for the error event</li>
<li><a
href="d3658944e5"><code>d365894</code></a>
chore: bump socket.io-parser to version 4.2.3</li>
<li><a
href="12b0de4f52"><code>12b0de4</code></a>
chore: bump engine.io to version 6.4.2</li>
<li><a
href="3d44aae381"><code>3d44aae</code></a>
fix(exports): move <code>types</code> condition to the top (<a
href="https://redirect.github.com/socketio/socket.io/issues/4698">#4698</a>)</li>
<li><a
href="cbf0362476"><code>cbf0362</code></a>
docs(examples): bump dependencies for the private messaging example</li>
<li><a
href="59280da20b"><code>59280da</code></a>
docs(examples): update examples to docker compose v2</li>
<li><a
href="50a4d37cb8"><code>50a4d37</code></a>
docs(changelog): add version of transitive dependencies</li>
<li><a
href="6458b2bef1"><code>6458b2b</code></a>
docs(example): basic WebSocket-only client</li>
<li><a
href="b56da8a99f"><code>b56da8a</code></a>
docs(examples): upgrade to React 18</li>
<li>See full diff in <a
href="https://github.com/socketio/socket.io/compare/4.6.1...4.6.2">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io&package-manager=npm_and_yarn&previous-version=4.6.1&new-version=4.6.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/appsmithorg/appsmith/network/alerts).

</details>

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9591866384>
> Commit: dd65e5111bb195514a815908757f6864b39625be
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9591866384&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-06-20 16:25:38 +05:30
Valera Melnikov
36372468c5
chore: remove headless radio and use react-aria component instead (#34312)
## Description

- Remove headless radio and use react-aria component instead
- Create ErrorMessage component

Fixes #27677 

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9567388261>
> Commit: 62d1153caa8bf03d827f88593c9dfaf3121091ee
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9567388261&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->



## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added `ErrorMessage` component for displaying error messages with
specific styling.
- Introduced `isDisabled` prop for `Label` and `ToggleGroup` components.
- Updated `RadioGroup` to accept an items array for easier
configuration.

- **Bug Fixes**
- Improved conditional rendering in `Label` component to prevent issues
when `text` and `contextualHelp` are both falsy.

- **Refactor**
  - Removed `Radio` component export from design system.
- Restructured import statements and prop declarations for `Checkbox`
and `RadioGroup`.

- **Style**
- Updated styles for `RadioGroup` and `ToggleGroup` components for
better state handling (disabled, hovered, selected).

- **Documentation**
- Updated Storybook stories for `RadioGroup` to reflect changes in
component usage.

- **Tests**
  - Adjusted `RadioGroup.test.tsx` to test new items array prop.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-19 11:08:42 +03:00
Valera Melnikov
84f67fe0f2
chore: remove headless checkbox and switch use react-aria component instead (#34217)
## Description
- Remove headless checkbox and switch use react-aria component instead
- Add Label component
- Now `ToggleGroup` is used instead of `SwitchGroup` and
`CheckboxGroup`, since they are essentially the same component.

**I'll create another one PR to refactor the radioGroup.**

Fixes #27677 

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9485370398>
> Commit: f2557233978da533b9ab856335a8191b4226dba5
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9485370398&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced `ToggleGroup` component with various features for improved
user interaction.

- **Enhancements**
- Updated `Radio`, `Checkbox`, and `Switch` components for better
functionality and styling alignment.
- Added `labelPosition` options to `Radio` and `Checkbox` components for
flexible label positioning.
- Enhanced `ContextualHelp` component with a new `slot` prop for more
customization.
- Improved `Select` component to use `Label` directly, optimizing
rendering.

- **Bug Fixes**
- Adjusted logic for `WDSSwitchWidget` to ensure correct validity
handling.

- **Styling**
- Various styling adjustments across multiple components for consistent
design.

- **Tests**
- Updated test cases for the `Checkbox` component to reflect recent
changes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-14 15:25:34 +03:00
vadim
dae657e3e4
chore: WDS, adjust inner spacing of buttons with icons (#34210)
## Description

When an icon is present reduce leading/trailing inner spacing.

| Before | After |
|--------|--------|
|
![before-regular-regular](https://github.com/appsmithorg/appsmith/assets/80973/0dcdc792-05d2-48c2-a67e-1044d0fef124)
|
![after-regular-regular](https://github.com/appsmithorg/appsmith/assets/80973/8569316f-d604-4397-a87e-daf2d0dabfc3)
|

Fixes #33917   

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9481602526>
> Commit: 038d756b2f36020a9f9ed95bd2d681a91fb9f03d
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9481602526&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Style**
- Adjusted padding styles for Button component to improve alignment
based on icon position (start/end) and size (small/medium).
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-13 15:21:45 +03:00
Valera Melnikov
7b32f1aa50
fix: improve link behaviour (#34043)
## Description
Add hover and focus for WDS link component.


https://github.com/appsmithorg/appsmith/assets/11555074/51e50841-b347-4585-aa5a-2fd54e13cf06


## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9401315193>
> Commit: 1a10e18ab16d30be828eeb931a2d5c22448fa096
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9401315193&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Improved the appearance of links with new CSS properties, enhancing
hover and focus states for better user experience.
- **Refactor**
- Reordered JSX elements within the Link component for cleaner and more
maintainable code structure.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-07 11:06:43 +03:00
Valera Melnikov
05aa9cc354
fix: widget overflow behaviour in anvil (#33961)
## Description
Fixed overflow operation for widgets in zones.


Fixes 
#32922 
#33537 

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9386697113>
> Commit: e0f8f24f3dd34ec39acb10846d35d0c2f020ca02
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9386697113&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced dynamic font size customization using CSS custom
properties.

- **Improvements**
- Adjusted layout behavior for `AnvilFlexComponent` to use `fit-content`
for better content fitting.
- Enhanced styling for elements with elevation property, including font
size and spacing adjustments.
- Switched to `isEditOnlyModeSelector` for more accurate layout wrapping
behavior in `SectionRow`.

- **Removals**
- Removed `renderMode` property from `BaseLayoutComponent`,
`FlexLayoutProps`, and related components for streamlined functionality.
  - Simplified imports and prop handling in `AlignedWidgetRowComp`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-06 13:49:57 +03:00
Pawan Kumar
d712c7748f
chore: Fix extra space at the end of multi-line input widget #33099 (#33886)
Fixes #33099

/ok-to-test tags="@tag.Anvil"<!-- This is an auto-generated comment:
Cypress test results -->
> [!IMPORTANT]
> 🟣 🟣 🟣 Your tests are running.
> Tests running at:
<https://github.com/appsmithorg/appsmith/actions/runs/9318021083>
> Commit: 5f1ea63400f06fa9d22e0aa41c81e44fdf7b1deb
> Workflow: `PR Automation test suite`
> Tags: `@tag.Anvil`

<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-06-03 12:57:52 +03:00
Abhinav Jha
218dbef6e8
feat: Anvil: Add closeOnSubmit property to modal widgets (#33801)
## Description
- Creates a new property control for Modal widgets. `closeOnSubmit`. 
- This property (default `true`) configures if the modal must close on
the submit button click.


Fixes #33240 

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9299980305>
> Commit: 59fc2957f0b4ff3c47788480b0d82adf99596265
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9299980305&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->








## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-30 18:00:44 +05:30
Pawan Kumar
01529c4db5
chore: Checkbox widget does not show an asterisk to indicate it's a required (#33814)
Fixes #33444

/ok-to-test tags="@tag.Anvil"<!-- This is an auto-generated comment:
Cypress test results -->
> [!WARNING]
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9297202278>
> Commit: 895c87c82e1b55e4d604870c89512200c408ef41
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9297202278&attempt=1"
target="_blank">Click here!</a>
> It seems like **no tests ran** 😔. We are not able to recognize it,
please check workflow <a
href="https://github.com/appsmithorg/appsmith/actions/runs/9297202278"
target="_blank">here.</a>

<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-05-30 11:21:39 +03:00
vadim
96c340e2bb
chore: WDS inputs in dark mode with better visibility (#33796)
## Description
Fixes #33623 

| Before | After |
|--------|--------|
| ![Screenshot 2024-05-28 at 12-10-22 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/3206e718-d062-4d86-8d6d-adf7cf1c00f2)
| ![Screenshot 2024-05-28 at 12-12-08 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/aea0ef7c-fe38-41ec-bcd9-31df4e4c49c7)
|

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9267589083>
> Commit: 57a332a7a2f141df4479f265f235df56fb1654bf
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9267589083&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-28 13:58:10 +03:00
Valera Melnikov
55ae8594ad
fix: refactor wds menu and related components, widgets (#33703)
## Description
1. WDS menu component has been completely refactored. WDS headless
component has been removed, we use `react-aria-components` instead. The
menu component now has the ability to use submenus and icons for items.
2. Rename components `ActionGroup` to `ToolbarButtons and `ButtonGroup`
to `InlineButtons`
3. Make API of the `ToolbarButtons`, `Menu`, `InlineButtons`, `Select`
consistent.
4. Cosmetic refactoring of `ToolbarButtons` and `InlineButtons` and
related widgets.

Fixes:
#32299
#32109

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9210315418>
> Commit: b11c0029c656b4fbf61b9760d16f77564478d053
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9210315418&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No

---------

Co-authored-by: Pawan Kumar <pawan@appsmith.com>
2024-05-24 15:58:45 +03:00
vadim
cee654a19a
chore: Refine WDS icon stroke width values (#33615)
## Description

Fixes #31982

| Before | After |
|--------|--------|
| ![Screenshot 2024-05-21 at 11-28-24 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/1c3c3bc6-9829-483b-8cbf-20c1f25004b0)
| ![Screenshot 2024-05-21 at 11-37-18 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/ae49911e-4735-438d-842c-999a83a70515)
|
| ![Screenshot 2024-05-21 at 11-28-38 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/fc0b8f73-55bb-4257-86cc-a547df9fd3a2)
| ![Screenshot 2024-05-21 at 11-37-33 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/dbc8cd0d-6ea9-4f9a-88ea-53b9c33d0b46)
|

This is probably as good as it can be considering the simplicity of the
current implementation: we don't provide different values for light/dark
modes and don't adjust the values corresponding to the sizing of the
theme. Considering that the icon set is also not entirely perfect with
maintaining stroke investing time into all this compensation would be
not recommended.

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9172535927>
> Commit: cb4fedf96bb1b8272bca1c4ed033b91db45db5db
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9172535927&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-23 12:28:35 +03:00
Pawan Kumar
feb1be5adb
chore: add alignment to toolbar button (#33541)
Fixes #32309

/ok-to-test tags="@tag.Anvil"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9127236127>
> Commit: 016f9d08fbdd87d6ff355d45e239f015d9401612
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9127236127&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-05-17 14:42:51 +03:00
sneha122
bbfe4ffe70
fix: Added lint error for appsmith store mutations (#33484)
Co-authored-by: “sneha122” <“sneha@appsmith.com”>
2024-05-17 16:34:01 +05:30
Ashok Kumar M
bb75941c0c
fix: Modal Accessibility and copy paste. (#33509)
[![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX14yqgk46bo7XRJuA90NLU3E993GRhVyI%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=u9xJeyE)
## Description

In this Pr we are tackling a few issues.
- disallow copy pasting modals into other widgets instead always paste
them on the main canvas.
- disable modal header and footer accessibility in edit mode.
- make sure edit mode based wrappers are not wrapped for skeleton
widget.
- make sure widget name is not shown for skeleton widget.
- fixed random errors in the withWidgetProps flow
- removed unwanted invocation of setting highlights.


Fixes #33382
Fixes #32923

_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9125695828>
> Commit: 05d011bc23329159c4d603e31690782119e1908a
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9125695828&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->










## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-17 15:32:22 +05:30
Pawan Kumar
9cdff0a68d
chore: WDS table widget polish (#33417)
Fixes #33389 

/ok-to-test tags="@tag.Table"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9112073097>
> Commit: 89ad68289c5a3dbf9af62864b97c6595100e605f
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9112073097&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-05-16 16:11:30 +03:00
Pawan Kumar
59153e78a8
chore: Improve Link component (#33433)
This PR uses react aria link's component in our Link component

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-05-16 15:43:35 +03:00
vadim
713eb77969
fix: Adjust WDS button font weight (#33489)
## Description
Fixes #33481 
More follow-ups may be in order, but on buttons it really stood out
(especially in dark mode, we should consider different weights for
different light modes in the future).

| Before | After |
|--------|--------|
| ![Screenshot 2024-05-15 at 16-40-23 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/bc941bf1-2e19-4ce0-a0f6-72bb9e1f0b6e)
| ![Screenshot 2024-05-15 at 16-38-32 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/7ffdea83-267b-4ba0-9d4e-3bcdb801d6e1)
|
| ![Screenshot 2024-05-15 at 16-40-09 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/eef64705-9b43-48b4-91e0-5b92af3dde11)
| ![Screenshot 2024-05-15 at 16-38-56 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/a25e0eb1-dcef-42e0-a022-ebe461f7d11e)
|

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9097777062>
> Commit: 22bfd39789137204508bcc699cd9eed3abed7180
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9097777062&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-16 11:41:24 +03:00
vadim
6b278ae7ee
fix: WDS, increase perceived darkness of modal overlay (#33476)
## Description
Closes #33276 
By far the biggest impact on perceived darkness is dependent on
transparency, adjusted it in light mode too just a little bit.
<img width="1392" alt="Screenshot 2024-05-15 at 10 59 31"
src="https://github.com/appsmithorg/appsmith/assets/80973/27072d6b-fef5-422e-8b4e-36c678915b40">

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9092935034>
> Commit: d135655d1154590fc5889621697993b968d4b18c
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9092935034&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->





## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-15 13:04:36 +03:00
Pawan Kumar
d1c9bde439
chore: Refactor WDSTableWidget with basic features (#33286)
/ok-to-test tags="@tag.Widget"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9056956210>
> Commit: 618ef038a5619de08d4f72cd36e4206031ac4891
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9056956210&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-05-13 10:41:24 +05:30
Valera Melnikov
ed9c55d4c4
fix: asymmetric padding for sections and zones (#33204)
## Description
Added asymmetric paddings for sections and zones.


https://github.com/appsmithorg/appsmith/assets/11555074/1959c6f2-5e26-4fdd-98e3-ea1bb5e09dae

Fixes #32209   

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8999510824>
> Commit: b714426d3185c9a75523fe98ae4ca75e26f0b249
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8999510824&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->













## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No

---------

Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>
2024-05-08 13:16:51 +03:00
Ashok Kumar M
30c8c19903
fix: Anvil drag preview for section widget (#33198)
[![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX18H87gqPGccHjVNrPYllSmccMtNxEeurfo%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=KIoqQw3)
## Description
- Adding Section widget thumbnail icons
- removing shared component of widget card UI
- adding anvil component for widget preview used while dragging.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8983616703>
> Commit: d96144a3fa20e855dfc638ca2f4410a507db1812
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8983616703&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->





## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-07 16:35:38 +05:30
Valera Melnikov
a4c4df2f2e
fix: wds components (#33146)
## Description
Fixed WDS components bugs


Fixes #
#33077
#33078
#32689
#32919

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8926075231>
> Commit: 0981cf8a45151cb3dc24b938efb7d79c7fefc766
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8926075231&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2024-05-03 12:00:25 +03:00
vadim
2faed3af85
fix: WDS bgNeutralOpacity (#33147)
Closes #32306

Making sure the overlay background is sufficiently dark, fixed spotted
error with `bgNeutral` too.
Screenshot from Storybook because I'm having temporary problems with
running Docker local dev setup. 😬

<img width="882" alt="Screenshot 2024-05-02 at 17 17 45"
src="https://github.com/appsmithorg/appsmith/assets/80973/010a14b1-81db-4082-884f-928be6ac1d72">
2024-05-03 11:41:21 +03:00
Aman Agarwal
c41236845c
feat: added modal name, lint warning for string, action selector modal (#32893) 2024-05-02 17:48:53 +05:30
Abhinav Jha
08ca04a09c
feat: Update Modal Z-Index (#33071)
## Description
Update Modal's z index by updating the token

Fixes #33072

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8897543084>
> Commit: 1e6fb1129c072801d91dbbdc73e179005c621d33
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8897543084&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-05-01 13:34:59 +05:30
Valera Melnikov
9e214c2c3c
chore: add appsmith icon package (#32927)
## Description

- Add `appsmith-icons` package. Icons are automatically imported from
Figma, optimized, and then React components are created based on them.
Please read the
[README](https://github.com/appsmithorg/appsmith/pull/32927/files#diff-163e187687a9784dfda13faf90276b1137ba6e85db21bd550c6a3ba486178e5e)
for more information.
- Replace Icons for Anvil widgets. 

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8847468194>
> Commit: a2036daedef0a08b7c973e04ac11a224fb40c9c1
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8847468194&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->








## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
2024-04-26 15:37:09 +03:00
vadim
c18d7ac1fa
fix: WDS color algo for very light seeds (light mode) (#32964)
Fixes #32429 

| Before | After |
|--------|--------|
| ![Screenshot 2024-04-25 at 11-50-18 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/39c7b4da-21e3-4dee-8558-4d3f2a3f5ab7)
| ![Screenshot 2024-04-25 at 11-48-20 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/9598a87f-5b79-40a1-894e-983dea4ed98e)
|
| ![Screenshot 2024-04-25 at 11-09-15 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/f0e02328-b827-419c-9007-a3b2ea1deac7)
| ![Screenshot 2024-04-25 at 11-44-55 Untitled application 1 Editor
Appsmith](https://github.com/appsmithorg/appsmith/assets/80973/92aa2bbf-4c39-48b1-b39c-c195d0aaafb8)
|

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Enhanced the color properties in Light Mode Theme for better visual
appearance of very light seeds
- **Tests**
- Updated test cases to align with the new color values in Light Mode
Theme.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-25 17:33:23 +03:00
Valera Melnikov
4e2f74ecbf
chore: remove wds headless button (#32857)
## Description
Refactoring wds button component

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8788334412>
> Commit: 3e11d5f7800eaf492cb42f049f42980ed33cd774
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8788334412&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced the design system by switching the `Button` component imports
to `react-aria-components` across various components for improved
accessibility and performance.

- **Style Updates**
- Revised multiple CSS properties across components, improving visual
consistency and user interface aesthetics.

- **Refactor**
- Updated various components to use `ForwardedRef<HTMLButtonElement>`
replacing previous ref types, aligning with modern React patterns and
improving component interoperability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-23 15:00:36 +03:00
Valera Melnikov
6d90ce8dc9
chore: update storybook (#32828)
## Description
- Update Storybook and related dependencies
- Delete the stories for old widget components
- Rewrite stories for new widgets(mdx to tsx)

Note: local chromatic doesn't work because of this
https://github.com/storybookjs/storybook/issues/22531

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced new component stories across various packages to enhance
design system documentation and user experience.

- **Documentation**
- Updated `.gitignore` files to optimize version control settings for
Storybook and build logs.

- **Refactor**
- Modified UI element positioning in Storybook theming for improved
layout management.

- **Style**
- Adjusted CSS properties for the `Select` component to ensure better
visual presentation.

- **Chores**
- Updated dependencies and scripts in package configurations to maintain
up-to-date development tools.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 12:17:28 +03:00
Pawan Kumar
4108f770af
fix: Heading widget alignment does not follow user setting (#32759)
Fixes #32308

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced text styling in flex layouts to improve spacing and
alignment.
- Updated the WDSParagraphWidget to include a Flex container, enhancing
the structural layout and rendering of text elements.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-04-18 12:03:20 +03:00
Valera Melnikov
f22dffcf50
chore: wds select component (#32715)
## Description
Fixes #28466

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced customizable `Select` component with enhanced dropdown
features including error messages, loading state, and contextual help.
- Added a new `className` prop to the `Button` component for custom
class name manipulation.

- **Enhancements**
- Updated the design system package to include exports for new
components like `Select` and `ContextualHelp`.
- Improved accessibility and cohesive user interface across components.

- **Bug Fixes**
- Corrected import paths for `ContextualHelp` in various components to
ensure consistent functionality.

- **Documentation**
  - Updated component documentation to reflect new features and props.

- **Style Updates**
- Added comprehensive styles for the new `Select` component, including
form fields and error text styling.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-17 13:49:41 +03:00
vadim
1de9d15073
chore: WDS, adjusted border of text inputs to avoid "disabled" visual style (#32547)
Closes #32029
---
tl;dr
| Before | After |
|--------|--------|
|
https://github.com/appsmithorg/appsmith/assets/80973/9c4d1805-4b42-4849-ad64-ec6e471fab2f
|
https://github.com/appsmithorg/appsmith/assets/80973/236c547f-89a3-437a-a464-3da29fdd4845
|
---
Context
1. The appearance of TextInput can be mistaken as them being disabled
when there are not enough additional visual hints. See on this
screenshot of prior styling how the lack of a placeholder contributes to
that. Additionally when not lying inside a visible zone, but directly on
a canvas the contrast is very low for the field.
<img width="851" alt="Screenshot 2024-04-10 at 11 48 36"
src="https://github.com/appsmithorg/appsmith/assets/80973/69295c41-d4d2-40b0-9375-11b2d6ed532a">
2. Effect is not pronounced in the dark mode. When discriminating
between disabled and non-disabled input which one's which is also pretty
clear.
<img width="860" alt="Screenshot 2024-04-10 at 11 49 12"
src="https://github.com/appsmithorg/appsmith/assets/80973/65f9b91b-8984-4515-b5fb-fb8b74f3f492">
2024-04-11 13:01:26 +03:00
Pawan Kumar
46498aa93a
chore: Use WDS Tokens in Table Body (#32421)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
  - Enhanced typography styling with dynamic font size adjustments.
  - Introduced feature flag checks for new functionalities.
  - Implemented `VirtualTableBody` for efficient data rendering.
- Added `onClickRow` functionality in table rows for improved
interactivity.
  - Improved table accessibility with explicit cell roles.
  - Added pagination controls refinement in table headers.

- **Refactor**
- Simplified table header and body component structures for better
maintainability.
  - Streamlined feature flag usage for cleaner logic.
- Refined `WDSTableWidget` component by optimizing width calculations
and event handling.

- **Style**
  - Introduced a new CSS module for comprehensive table styling.
- Removed outdated styling configurations to align with updated design
system.

- **Bug Fixes**
  - Fixed accessibility issues by adding proper roles to table cells.

- **Chores**
- Removed unused functions and properties related to theme and styling
adjustments.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-04-05 16:05:38 +03:00
Valera Melnikov
8a835357cc
fix: input alignment (#32452)
## Description
Fixed the alignment of the content inside the input

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced `prefix` and `suffix` props for better customization in
TextInput components, replacing `startIcon` and `endIcon`.
- Added examples for using menus as prefixes/suffixes and for type
password functionality in TextInput stories.
- Implemented loading indicator functionality with priority over icons
in TextInput.
- Added support for disabled and readonly states with icon prefixes and
suffixes in TextInput.

- **Bug Fixes**
- Adjusted styles for autofill, focus states, and padding in input
fields to improve user experience.

- **Documentation**
- Updated TextInput component documentation to reflect new `prefix` and
`suffix` props usage and examples.

- **Refactor**
- Removed `startIcon` and `endIcon` properties from TextInputProps and
updated rendering logic.
- Replaced `startIcon` with `prefix` in CurrencyInputComponent and
PhoneInputComponent.
- Changed `startIcon` and `endIcon` to `prefix` and `suffix` in
InputComponent.

- **Style**
- Removed specific styling for `[data-field-input-group]` affecting
display and alignment.
- Updated text-input module CSS to enhance the appearance of prefix and
suffix elements and small-sized input fields.

- **Chores**
  - Added `MULTI_LINE_TEXT` constant to the `InputTypes` object.
- Updated the label for the "Icon" property in WDSInputWidget's
propertyPaneStyleConfig.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-05 15:02:07 +03:00
Pawan Kumar
223e4c8088
chore: WDS components in Table header (#32112)
Adds WDS components in Table Header

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced utility functions for handling table data, including
downloading and transforming data into CSV or Excel formats.
- Added a new `TableHeader` component for the `WDSTableWidget` with
features like search, actions, adding new rows, and pagination.
- **Enhancements**
- Enhanced feature flag checks for "ab_wds_enabled" and
"release_anvil_enabled" to prioritize specific flags before general
lookup.
- Updated `ActionGroup` component to include a `size` property for the
`IconButton`.
- **Refactor**
- Removed redundant imports and renamed the `searchTableData` function
to `onSearch` across multiple components to streamline search
functionality.
- Updated the `useListState` call to suppress text value warnings,
improving code quality without altering functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-04-03 15:57:39 +03:00
vadim
63e406bb5b
chore: WDS inner spacing scale adjustments (#32342)
Closes #31256 

Some comparisons for key theme settings combinations:

| | Before | After |
|--------|--------|--------|
| tight - small | <img width="1348" alt="tight-small"
src="https://github.com/appsmithorg/appsmith/assets/80973/48eb2f72-a9e4-4609-a6d0-3bfe9d8c191e">
| <img width="1348" alt="tight-small"
src="https://github.com/appsmithorg/appsmith/assets/80973/ac229e79-74fb-4fc7-bf58-95f8965cbcbe">
|
| tight - big | <img width="1348" alt="tight-big"
src="https://github.com/appsmithorg/appsmith/assets/80973/5c7ebfdf-e67b-47c0-99ce-0d0283b840ba">
| <img width="1348" alt="tight-big"
src="https://github.com/appsmithorg/appsmith/assets/80973/acba7177-04cc-445e-96b1-484c5ce6395e">
|
| regular - small | <img width="1348" alt="regular-small"
src="https://github.com/appsmithorg/appsmith/assets/80973/0a735227-4b68-41b9-8c50-1c1b7918468d">
| <img width="1348" alt="regular-small"
src="https://github.com/appsmithorg/appsmith/assets/80973/ceb3c513-c245-45d2-8948-dc37115c0720">
|
| regular - big | <img width="1348" alt="regular-big"
src="https://github.com/appsmithorg/appsmith/assets/80973/1c9013f9-3ed7-4d76-96d7-83d43e55a3a3">
| <img width="1348" alt="regular-big"
src="https://github.com/appsmithorg/appsmith/assets/80973/2425c31a-9ffc-49b4-be60-51bdb6331851">
|
| loose - small | <img width="1348" alt="loose-small"
src="https://github.com/appsmithorg/appsmith/assets/80973/22ac12fa-abc3-40bc-b77d-10310c2e417a">
| <img width="1348" alt="loose-small"
src="https://github.com/appsmithorg/appsmith/assets/80973/3a0fd27b-7a02-41a0-8f57-102094f8eec0">
|
2024-04-02 17:22:12 +03:00
Pawan Kumar
2dbe72068a
fix: separator styles missing from action group menu (#32213)
This PR adds styles for separator in the action group menu

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced menu items in the design system to support separators and
icons, improving visual organization and interaction.
- **Style**
- Updated styling for menu items with separators to improve visual
clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-03-29 14:29:11 +03:00
dependabot[bot]
af71de91fe
chore(deps): bump express from 4.18.2 to 4.19.2 in /app/client (#32070)
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to
4.19.2.


Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-29 14:34:03 +05:30
Valera Melnikov
ba6262ffe6
chore: widgets alignment (#31923)
## Description
Plenty changes related to widgets alignment 
1. Paragraph, button, inputs, single checkbox and switch widgets are
aligned along the baseline of the text content
2. The icons in the buttons and the single checkbox and switch are now
positioned absolutely so as not to affect the height of the components.
The height of the components now depends on text content.
3. All unnecessary paddings and borders in the layout have been removed:
- Canvas padding: `--outer-spacing-4`
- Gap between sections and zones: `--outer-spacing-4`
- Zone padding: `--outer-spacing-3`
- Gap between widgets: `--outer-spacing-3`
4. In widget selection styles replace `border` with `outline`, since the
`outline` one does not take space.
5. Add Changes to the flex-basis calculation method. Now the gap between
the zones is taken into account there.
6. Add a lot of small fixes related to the changes described above.


https://github.com/appsmithorg/appsmith/assets/11555074/b7c220eb-3e27-4039-9c15-6281bafe8008

Fixes #29364

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]  
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8375537665>
> Commit: `f85b63c0a49f30b9762379c2f8c3bd38c7a8355f`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8375537665&attempt=2"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->




<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
	- Improved handling of CSS variable values in Flex components.
- Enhanced styling and layout configurations for a better user
experience.
- **Bug Fixes**
- Fixed label positioning and styling issues in Checkbox and Switch
components.
	- Adjusted padding, margin, and sizing for consistency and alignment.
- **Refactor**
- Enhanced flex layout handling and space distribution logic for
improved layout flexibility.
- **Style**
	- Updated component styles for refined user interface aesthetics.
- **Chores**
- Updated feature flags and configurations for widgets and components to
enable new functionalities.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-22 16:53:29 +03:00
vadim
613547b43d
fix: WDS bdNeutralHover color (#31922)
Fixes #31899

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new hover outline color for input fields to enhance user
interaction.

- **Style**
- Updated hover outline colors for both Dark and Light modes to improve
visibility and aesthetics.

- **Tests**
- Adjusted tests to reflect new color values for hover states in both
Dark and Light themes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-21 18:20:47 +03:00
Shrikant Sharat Kandula
34c59c8f4d
chore: Reduce RTS error log spam (#31917)
We're logging the entire request/response, Axios config etc. in the
logs, which isn't adding any value in troubleshooting, but is making
reading logs _much_ harder.

This PR will print only the essential information to logs, concisely.
2024-03-19 20:08:09 +05:30
Vibhor Sharma
f14eabb074
fix: Updated the label for the "Auto play" property in the Audio Widget to "Autoplay" (#31668)
## Description
Renamed `Auto play` to `Autoplay` in Audi Widget's autoplay text to make
it consistent with `Autoplay` text in Video Widget.

Before: 
<img width="574" alt="image"
src="https://github.com/appsmithorg/appsmith/assets/12482554/9c7da195-e8c4-4f0a-8ca9-a86615ed7d57">

After: 
<img width="569" alt="image"
src="https://github.com/appsmithorg/appsmith/assets/12482554/f360e546-5ec3-4525-a3e8-91bd1dc06779">


Fixes #19488
2024-03-19 11:56:45 +05:30
vadim
edcdcaa593
chore: WDS TextInput style (#31659)
Closes #31021

Before

https://github.com/appsmithorg/appsmith/assets/80973/3a75dc1d-c340-428c-ab7a-53820471c006

After

https://github.com/appsmithorg/appsmith/assets/80973/70249593-2705-4d67-8408-44ce301cb8ae



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary of changes

- **New Features**
- Updated text input styles to use background colors, improving user
interaction cues for hover, focus, and invalid states.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-03-18 13:06:30 +03:00
Pawan Kumar
24c1dda69a
fix: Options in WDS radio group widget get distorted in a Section with > 1 Zone (#31797)
Fixes #29365 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced label positioning for Checkbox, Radio, and Switch components
with "start" and "end" options.
- Introduced dynamic orientation for Checkbox and Radio groups based on
container size.
- Added new story for RadioGroup component to demonstrate vertical
orientation.
- **Style Updates**
- Updated CSS for Switch, Checkbox, and Radio components to align with
the new label positioning options.
- Improved field group styles with `flex-wrap` to accommodate various
layouts.
- **Refactor**
- Modified handling of `labelPosition` across components for consistency
and flexibility.
- Implemented `useGroupOrientation` hook for dynamic orientation
management.
- **Chores**
- Adjusted default configurations and property pane options for widgets
to align with new label positioning and orientation features.
- Added feature flag checks for specific functionalities to always
return `true`.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-03-18 11:48:29 +03:00