7f3a66de2b
19 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Ankita Kinger
|
72eb2cd4cb
|
chore: Updating generate page interaction to show it in a modal following the IDE 2.0 interaction pattern (#37414)
## Description Updating generate page interaction to show it in a modal following the IDE 2.0 interaction pattern Fixes [#32952](https://github.com/appsmithorg/appsmith/issues/32952) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11900113834> > Commit: 3903c44fe5a6c7db0d22d9cf982c28a1380f4546 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11900113834&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 18 Nov 2024 21:26:44 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced a modal for generating pages, enhancing user interaction. - Added new action types and constants for managing page generation processes. - Updated UI messages for clarity in the page generation context. - Improved handling of datasource selection and page generation in various components. - **Bug Fixes** - Improved error handling in various components to prevent silent failures. - **Refactor** - Streamlined routing logic by removing deprecated paths and functions. - Transitioned from direct navigation to modal-based interactions for page generation. - Enhanced control flow and error handling within components. - **Chores** - Updated import paths for better organization of action-related functions within the Redux architecture. - **Tests** - Enhanced test cases for CRUD operations, ensuring better validation and error handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ashit Rath
|
67046f8693
|
chore: Split library side pane for adding package control section (#36926)
## Description Purpose of this PR is to split the Libraries section to extend it in EE and introduced a tab layout that has both js libraries and packages Changes: 1. Increased width of Libraries pane to 384px 2. Added a route `/package` which opens the same as library 3. Extracted the JSLibraries section to be reused as a tab panel body in EE 4. Created `SidePaneWrapper` common component to be reused in EE 5. Split the title of the Libraries section under a hook to return empty string if package feature flag is enabled. 6. Minor linting refactors. In CE there is only one visual change i.e the increase in width of the Libraries side pane from 250px to 384px [Figma](https://www.figma.com/design/Z0QsSdGOydURn6WIMQ3rHM/Appsmith-Reusability?node-id=6816-319511&node-type=frame&t=x0DzN9HIxjefe3J1-0) PR for https://github.com/appsmithorg/appsmith-ee/pull/5362 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11434291701> > Commit: ec76cc569ea90ba55e451f5ab18fa85244ac076f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11434291701&attempt=3" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Mon, 21 Oct 2024 08:54:31 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced new functions for constructing URLs for application libraries and packages. - Added new route constants and matching functions for improved routing of application packages and libraries. - Implemented a custom hook for dynamic header titles in the libraries section. - Added a new `LibrarySidePane` component to enhance the editor interface. - Introduced a new `SidePaneWrapper` component for better layout management. - **Bug Fixes** - Enhanced entity identification logic to recognize both libraries and packages. - **Chores** - Updated routing logic for improved maintainability. - Added constants for configurable UI component widths. These updates aim to enhance user experience and improve the overall functionality of the application. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ilia
|
d6f249b42d
|
chore: add blank line eslint rule (#36369)
## Description Added ESLint rule to force blank lines between statements. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10924926728> > Commit: 34f57714a1575ee04e94e03cbcaf95e57a96c86c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10924926728&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/Anvil/AnvilModal_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCheckboxGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilCurrencyInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilIconButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilParagraphWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilPhoneInputWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilStatsWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchGroupWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilSwitchWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilTableWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilToolbarButtonWidgetSnapshot_spec.ts > <li>cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilZoneSectionWidgetSnapshot_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 18 Sep 2024 16:33:36 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --------- Co-authored-by: Valera Melnikov <valera@appsmith.com> |
||
|
Nidhi
|
de443104f2
|
chore: rm dr ce (#34765)
Co-authored-by: brayn003 <rudra@appsmith.com> |
||
|
Hetu Nandu
|
cdd33a846f
|
feat: cURL import now happens via a modal (#34830)
## Description Adds the cURL import flow to go through a modal instead of editor level screen. This is done to ensure the IA is correct as per IDE 2.0 standards Fixes #32942 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9869174972> > Commit: 6143c1c79c0bb7c6a4899fc477985d0ed23699df > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9869174972&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank">Cypress dashboard</a>. > Tags: @tag.All > Spec: > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/OtherUIFeatures/Omnibar_spec.js > <li>cypress/e2e/Regression/ClientSide/PartialImportExport/PartialExport_spec.ts</ol> > <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">List of identified flaky tests</a>. > <hr>Wed, 10 Jul 2024 07:56:03 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Updated test case function calls and refactored imports to improve code structure and maintainability in multiple files related to CURL import flows. - Consolidated and rearranged steps in CURL import flow test cases for better readability and organization. - **New Features** - Introduced `AppCURLImportModal` component to handle CURL command imports within the API editor. - Added constants `SET_CURL_MODAL_OPEN` and `SET_CURL_MODAL_CLOSE` for managing the state of the CURL modal. - **Style** - Updated selector formats and added proper commas in the `ApiEditor.js` file. - **Chores** - Removed unused constants and functions related to CURL import page paths across multiple files for cleaner codebase. - Streamlined the management of the CURL import modal state in the reducer and added relevant selectors. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
ed42302323
|
chore: Fix regexes for APIs needing environment (#34800)
The regex used to identify if an API needs environment information, doesn't support UUIDs. This PR adds that. Ideally, we should pass this information from where we're calling `Api.get()`, not via an interceptor that matches certain very specific API paths. Especially since the regex isn't matching generic paths. Add to that, headers is the wrong place for things like this, because this is essentially a "query param", it's a parameter to the query in the GET API call, on equal footing with `datasourceId`. The generic Axios interceptors being aware of the concept called environments, itself is an abstraction leak, in my opinion. Problem for another day though. /test sanity <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9850313501> > Commit: e6348e0685c1cc79d8932b5fcaa35d67e635186b > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9850313501&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 09 Jul 2024 03:33:12 UTC <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Improvements** - Enhanced dynamic route matching for data source structures and triggers, making the application more flexible and robust. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Shrikant Sharat Kandula
|
55b6e6d8d8
|
test: Extract pageId with regex to cover more cases (#34521)
There's a few places in Cypress tests that are trying to extract the page ID using `.split`, especially with just the path information, instead of the whole URL. So this PR changes the extraction implementation to use a regex, to support all three cases we need: 1. Full absolute application+page URL. 2. Just the path of an application+page URL. 3. Just the path of an application with a custom slug. 4. Full absolute application with a custom slug. (Supported, but we don't need this today). We've also fixed the URL parsing for the (very) old application URLs that didn't use slugs in the URL at all. This was making `FocusEntity.test.ts` fail. Fixed that test as well as improved it's error reporting. Before this PR:  After this PR:  No conflicts to EE. /test all <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9713573983> > Commit: 49edbce5ae85ee7fe9f4d2df05e2933347ddb3f4 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9713573983&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Improved URL handling by centralizing page ID extraction logic across various tests and components. - Updated deprecated path constants to include ID extraction patterns for better consistency. - Enhanced code readability and maintainability by moving page ID extraction to a helper method. - **Tests** - Modified test cases to dynamically set `applicationId` and `pageId` instead of hardcoding values, ensuring more flexible and maintainable test scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Abhijeet
|
989cd8ed67
|
chore: Unify ID extraction regex from browser url (#33925)
## Description Regex update to make it compatible to extract identifiers for both Mongo ObjectIds and UUIDs. This will help us to keep the unified logic required in `pg` branch. ## Automation /ok-to-test tags="@tag.Datasource, @tag.GenerateCRUD, @tag.ImportExport, @tag.Fork, @tag.Workspace, @tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9405554200> > Commit: 3959703aab1d10e28d3b80057793476467126929 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9405554200&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced URL path handling to support both UUID and Mongo ObjectIds. - **Refactor** - Replaced hardcoded page IDs with dynamic variables across multiple test files for improved maintainability and flexibility. - **Tests** - Updated test cases to use dynamic page IDs, ensuring consistency and easier updates in the future. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ashok Kumar M
|
79fbdc2b1a
|
chore: RMVF based changes for DnD, Modals, and Space distribution. (#31980)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #31935 Fixes #32059 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8565307211> > Commit: `5d5f682bcabd1b64d69d8743cc0ffbfcad372f92` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8565307211&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enabled new feature flags for advanced widget and release management. - Introduced a new component for modal layout and enhanced styling for the Anvil Editor. - Added messages for guiding users on where to drop widgets and modals. - Implemented a new route for widget editor enhancements. - **Enhancements** - Improved Anvil Editor's canvas functionality with better activation, selection, and drag-and-drop features. - Enhanced the visual styling and interaction of widgets and modals in the Anvil Editor. - **Bug Fixes** - Corrected import paths and updated selectors for consistent functionality across the Anvil platform. - **Refactor** - Streamlined Anvil Editor components and hooks for better maintainability and readability. - Adjusted import paths and reorganized components to align with the new project structure. - **Style** - Added and updated CSS styles for better UI experience in the Anvil Editor and modal interactions. - **Tests** - Updated Cypress E2E tests to reflect changes in the Anvil Editor's functionality and UI elements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
balajisoundar
|
55191cb372
|
fix: [custom widget] remove stale keys from dynamicTriggerPathList (#31586)
## Description 1. Improve string pattern used to determine whether to show onReady function missing warning 2. Remove stale keys from dynamicTriggerPathList when user changes the event names 3. Clean up events when a custom widget unselected in editor Fixes https://github.com/appsmithorg/appsmith/issues/31682 Fixes https://github.com/appsmithorg/appsmith/issues/30276 Fixes https://github.com/appsmithorg/appsmith/issues/30204 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8337490694> > Commit: `4fcb4cab6960c9a4a459a2b97261a112363901e2` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8337490694&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new route for `CustomWidgetBuilderLoader` component, enhancing navigation and accessibility. - Enhanced the Custom Widget Builder with improved event handling and dynamic trigger path support. - Added a new styled `Container` for the Custom Widget component for better layout management. - **Refactor** - Improved configuration settings readability and consistency for New Relic integration. - Refactored `CustomWidgetBuilderService` for clearer modularity and enhanced message handling. - Optimized property editing and update logic within the Property Pane of the Editor. - **Bug Fixes** - Adjusted connection timeout in the Custom Widget Builder for a more responsive user experience. - Updated button sizes in the ConfirmationModal for consistency. - **Tests** - Added comprehensive test cases for `CustomWidgetBuilderService` and `Builder` classes. - **Chores** - Removed deprecated `UPDATE_SRCDOC_ACK` event, streamlining Custom Widget Builder events. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
f939d20569
|
chore: Split routing for split screen (#31151) | ||
|
Shrikant Sharat Kandula
|
92993cccef
|
chore: Remove unused services (#30292)
I've been doing this in pieces bit by bit, not to rock the boat too much too fast, but it's taking too long, and too much effort. Instead opting for a rip-the-bandaid style, hopefully without the pain. |
||
|
Hetu Nandu
|
e95a82c03b
|
chore: Split screen foundations (#30060)
Improves foundations for Upcoming Split Screen changes fixes: #29953 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added new routing for list views and full-screen modes in the IDE. - Introduced `SplitScreenRoutes` and `FullScreenRoutes` components for enhanced query editing experience. - Implemented new `ListWidgets` component for managing widgets within the editor. - New `Container`, `FullScreenTabs`, and `SplitScreenTabs` components for better tab management in the IDE. - Added functionality to render JavaScript editor and list view based on IDE view mode settings. - **Enhancements** - Updated the IDE with a new `EditorTabs` component replacing `FileTabs`. - Improved editor pane with dynamic width adjustment and side-by-side view capability. - Enhanced segmented header with new options and conditional button rendering. - **Refactor** - Renamed `EditorViewMode` enum value from `HalfScreen` to `SplitScreen`. - Updated message constants across various components for consistency. - Reorganized import paths and component names for better structure and readability. - Removed unused code and updated import statements for `EmptyState` components. - Consolidated editor pane text constants for unified messaging. - **Bug Fixes** - Fixed routing issues by integrating new paths and components based on editor settings. - Resolved inconsistencies in widget list management and editing features. - Corrected message references in `JSBlankState` and `QueriesBlankState` components. - **Documentation** - Updated class and ID names in the codebase for clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Hetu Nandu
|
8cb733937c
|
chore: Refactor Context Switching (#29966)
## Description
Refactors the Context Switching functionality to make it usable of
different IDE types. It now will set a `FocusStrategy` based on the IDE
type { App, Module, Workflow } and perform the same operations.
Implementation of `FocusStrategy` for other IDE types will be done on
the EE side. It removes all dependence of `pageId` from the core
functionality and relies on the Strategy implementation to define what
states to store and set, and the key used for them.
Also renamed the functionality to `FocusRetention` for more clarity.
#### PR fixes following issue(s)
Fixes #29961
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)
## Testing
#### How Has This Been Tested?
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Added functionality for managing focus elements within the
application's integrated development environment (IDE).
- Introduced a focus strategy for handling focus elements in the
application.
- **Refactor**
- Restructured code for focus management configurations and strategies
to improve clarity and efficiency.
- Renamed `ConfigType` enum to `FocusElementConfigType` for better
reflection of its purpose.
- **Bug Fixes**
- Resolved issues with focus state restoration during navigation between
different URLs.
- **Tests**
- Updated test cases to align with the new focus management logic and
IDE type checks.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
||
|
Ankita Kinger
|
9bc4c9711c
|
chore: Refactoring multiple environments to use editorId instead of appId (#29965)
Reverts appsmithorg/appsmith#29942 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Streamlined the process for setting workspace and editor IDs across various components and actions. - Enhanced the route matching mechanism for improved navigation within the app. - **Bug Fixes** - Corrected typos and variable naming inconsistencies to ensure clarity and consistency in the codebase. - **Style** - Adjusted UI components for better accessibility, including the correct use of Aria attributes. - **Chores** - Removed unused imports and code to clean up the codebase and improve maintainability. - **Documentation** - Updated internal documentation to reflect changes in function signatures and payload structures. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
ashit-rath
|
73b3079a89
|
fix: Revert "chore: Refactoring multiple environments to use editorId instead of appId" (#29942)
Reverts appsmithorg/appsmith#29873 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified the action and payload structures for setting workspace IDs across various components and sagas. - Streamlined environment configuration fetching and workspace ID management. - Removed unnecessary editor ID references and updated related components to align with the new logic. - Enhanced code clarity in routing by using direct matching functions. - **Bug Fixes** - Fixed a typo in the state variable within the `SwitchEnvironment` component. - **Chores** - Cleaned up unused imports and variables related to application and editor IDs. - **Style** - No visible style changes to report. - **Documentation, Tests, Revert** - No changes in these categories to report. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ankita Kinger
|
6b6a6d9907
|
chore: Refactoring multiple environments to use editorId instead of appId (#29873)
## Description Refactoring multiple environments to use `editorId` instead of `appId` for supporting this feature on package editor on EE. #### PR fixes following issue(s) Fixes [#28502](https://github.com/appsmithorg/appsmith/issues/28502) #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [x] Jest - [x] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Modified functions to accept object parameters instead of individual values - Updated payload structure for specific functions - Modified parameter types for action handlers - Updated handling of workspace and editor IDs within sagas - Added new function and modified existing functions in storage - Imported and used functions from "selectors/editorSelectors" in specific components <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
balajisoundar
|
837d0cc76a
|
chore: custom widget (#28926)
## Description This PR's adds the custom widget. #### PR fixes following issue(s) Fixes #28607 Fixes #28610 Fixes #28615 Fixes #28608 Fixes #28612 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [x] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced search functionality with a wildcard option for unmatched widget searches. - Added new routes for custom widget editing. - Implemented additional editor modes for HTML and CSS. - Created new code templates and help components for custom widget builders. - Enhanced property controls with new button controls for custom widget editing. - Updated theming interfaces and constants for better theming support. - Added the CustomWidget component for embedding custom widgets in iframes. - Expanded widgets library to include the CustomWidget. - **Enhancements** - Improved `CodeEditor` with additional modes, props, and resize behavior. - Enhanced `PropertyPaneControlConfig` interface with dynamic dependencies and additional properties. - Refined custom widget scripts with communication channel and event handling. - **Bug Fixes** - Fixed visibility logic for the `ExternalWidget` card. - **Documentation** - Added new messages and documentation links for custom widget features. - **Tests** - Implemented new Cypress tests for custom widget default components and property pane interactions. - Updated workspace commands in Cypress tests. - **Refactor** - Streamlined `PropertyControl` state management and editing functions. - Refactored code editor hint helper logic. - **Style** - Added `borderLess` prop to style components without borders. - **Chores** - Updated constants and messages related to custom widget features. - Adjusted webpack configuration to ignore specific module warnings. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |
||
|
Ankita Kinger
|
235122e7e3
|
chore: Refactoring API wiring for actions and JS actions to support private entity renaming on EE (#29763)
## Description Refactoring API wiring for actions and JS actions to support private entity renaming on EE. Also handles a couple of other issues (refer the issue attached below) #### PR fixes following issue(s) Fixes [#29762](https://github.com/appsmithorg/appsmith/issues/29762) #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Enhanced action and JS object naming capabilities with new context-aware options. - Added support for organizing actions and JS objects within modules. - **Improvements** - Streamlined the process of renaming actions and JS objects to be more intuitive and context-sensitive. - **Refactor** - Updated internal type declarations for consistency and future extensibility. - **User Interface** - Improved UI elements to reflect the new naming and organizational features for actions and JS objects. - **Bug Fixes** - Corrected logic to ensure proper handling of the `isPublic` flag within JS collections. <!-- end of auto-generated comment: release notes by coderabbit.ai --> |