Commit Graph

17501 Commits

Author SHA1 Message Date
Nidhi
2765633976
Merge pull request #32966 from appsmithorg/cp/20240425 2024-04-25 17:38:23 +05:30
Nidhi
dc6fadaa45 Revert "chore: GitSynced and BranchAware are two different types (#32… (#32965) 2024-04-25 17:32:59 +05:30
Nidhi
c2955f8c2f chore: Added indices for collection id in actions (#32953) 2024-04-25 17:31:09 +05:30
Nidhi
7edd5c5a2f
Revert "chore: GitSynced and BranchAware are two different types (#32… (#32965) 2024-04-25 17:26:52 +05:30
Nikhil Nandagopal
f31140f33e Updated Label Config 2024-04-25 15:36:08 +05:30
Nidhi
5823e06057
chore: Added indices for collection id in actions (#32953) 2024-04-25 15:27:54 +05:30
albinAppsmith
ae84ed8ee5
fix: Removed border below active tab (#32943)
## Description

This PR removes the border below active tab.


Fixes #32941 

## Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8828306289>
> Commit: d9391184efa8b7edb8c1676fc4682ff7a9cb83c7
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8828306289&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Updated the positioning of the `ScrollArea` in the IDE Editor tabs for
improved alignment.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-25 13:37:15 +05:30
albinAppsmith
292ab6347a
feat: IDE tabs scrollbar changes (#32929)
## Description

This PR changes the system scrollbar of IDE tabs to custom scroll.


Fixes #32864 

## Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8827982150>
> Commit: ece8003b8966f72f3a99ba8152d8441773566490
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8827982150&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->








## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced the tab management in the IDE with a dynamic overflow setting
for better layout and usability.
- **Refactor**
- Improved naming and consistency in the split screen tabs component for
clearer code readability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-25 12:22:02 +05:30
Trisha Anand
661145cdb5
Merge pull request #32938 from appsmithorg/release
25/04 - Daily Promotion
2024-04-25 12:09:39 +05:30
Nidhi
b69de462b9
chore: GitSynced and BranchAware are two different types (#32932) 2024-04-25 11:22:17 +05:30
Hetu Nandu
17cb7bc30e
fix: Check page permission to show widget add panel (#32913)
## Description

When the user does not have permission to edit a page, they should not
be shown the widget pane with widgets

Fixes #32708

## Automation

/ok-to-test tags="@tag.IDE, @tag.AccessControl"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8814962106>
> Commit: 113a1477b4cfb3727ad392b83633ba878c90188f
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8814962106&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->





## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ x ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced security by implementing permission checks before rendering
widgets in the editor UI.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-25 10:38:19 +05:30
Shrikant Sharat Kandula
67a103de0e
chore: Health check only backend, caddy and RTS (#32891)
This is to avoid low-impact failures from getting the whole container to
restart.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Modified health check to focus on critical services (`editor`, `rts`,
`backend`) for more efficient monitoring.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-25 10:36:13 +05:30
Rudraprasad Das
c87511361a
fix: removing uppercase from ssh key (#32915)
## Description
SSH keys are case sensitive, should not add `text-transform: uppercase`
to it


Fixes #32362

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8815561059>
> Commit: fcd1edc21f57e0202fd4307516be5b9129ffd0e5
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8815561059&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Style**
- Removed uppercase text formatting from the deployment key text
display.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nidhi <nidhi@appsmith.com>
2024-04-24 19:44:52 +05:30
Nidhi
58671d6e8b
CE equivalent for removing js obj action id map (#32917) 2024-04-24 19:10:53 +05:30
Rudraprasad Das
b867f9c643
fix: fixing issue with persisting branch name (#32914)
## Description
Fixes issue with persisting branch if the more dropdown in inline nav is
used

Fixes #32050 


## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8816010061>
> Commit: 697a17179dd14c50a71c9b6c58c6d5c0ea3658ec
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8816010061&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->










## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced app navigation to retain branch parameters when using the
navigation dropdown.
- **Tests**
- Added tests to ensure consistent navigation behavior with Git
integration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-24 17:53:07 +05:30
Shrikant Sharat Kandula
4b9dddc861
ci: Remove Postgres from client-build workflow 2024-04-24 15:08:16 +05:30
Pawan Kumar
73798ae101
chore: Add presets of colors for Theme Setttings (#32849)
Fixes #32430

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added color mode options (Dark and Light) and color presets in the
theme settings.
- Updated the color picker UI and functionality in theme property
settings.
- **Enhancements**
- Reorganized the layout of the App Settings to improve user navigation.
- Enhanced theme customization options to include new section headers
and informational cards.
- **Refactor**
- Updated various components to use new and more efficient components
and imports, improving performance and user experience.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
2024-04-24 11:04:50 +03:00
Abhijeet
6cc4b028e5
chore: Remove un-necessary test from NewPageServiceTest (#32895)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Removed a test case related to default page creation with specific
permissions and policies.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-24 11:09:15 +05:30
Vemparala Surya Vamsi
80442153c6
chore: disable sending webworker logs in production (#32892)
## Description
Its been observed the logs been sent to main thread even during
production, sending the logs increases the transmission cost during
production consequently slowing the main thread. In this PR we will be
sending the logs when logs are at debug level.


Fixes #32907
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8804717249>
> Commit: 58999c947fc7aeb8b091c5f08581fa2ad35dc650
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8804717249&attempt=3"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->











## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced logging capabilities in evaluation processes to conditionally
send logs based on the debug level, optimizing payload size.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-24 10:41:42 +05:30
Valera Melnikov
4e2f74ecbf
chore: remove wds headless button (#32857)
## Description
Refactoring wds button component

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8788334412>
> Commit: 3e11d5f7800eaf492cb42f049f42980ed33cd774
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8788334412&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Enhanced the design system by switching the `Button` component imports
to `react-aria-components` across various components for improved
accessibility and performance.

- **Style Updates**
- Revised multiple CSS properties across components, improving visual
consistency and user interface aesthetics.

- **Refactor**
- Updated various components to use `ForwardedRef<HTMLButtonElement>`
replacing previous ref types, aligning with modern React patterns and
improving component interoperability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-23 15:00:36 +03:00
Rahul Barwal
7c4034308b
fix: starter building blocks on canvas removes existing queries and JS objects (#32629)
## Description
<ins>Root cause: </ins>
The original intention of the building blocks on canvas was to serve a
new user on their very first app.
Looking at (good) usage of this feature, we turned it on for all pages
on all apps.
Now, an experienced user don't always start with UI and thats when we
hit this issue.

Additionally, this was a tech debt we had to repay and this PR takes
that opportunity to get rid of hack of using `add a page from template`
for this feature and uses proper PIE based API to support his.

Fixes #32573
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Templates"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8797225643>
> Commit: 5f7f0fd094284faf67338412a57ef4757eb70af8
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8797225643&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
















<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced functionality for importing starter building blocks into
applications, including layout positioning and action triggers upon
successful import.
- Added new actions and selectors in Redux for managing current forking
building block names.

- **Refactor**
- Updated the handling of template names and constants for better
consistency and use within the app.
- Simplified event handling and variable naming in several components
for improved code clarity and performance.

- **Bug Fixes**
- Adjusted analytics and event data handling to ensure accurate tracking
and functionality.

- **Tests**
- Updated Cypress E2E tests to reflect changes in functionality and
removed outdated test cases.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-23 16:05:19 +05:30
Abhijeet
9406439bbb
chore: Add separate DTO class for projection and move CustomNewActionRepo method to NewActionRepo class (#32818)
## Description
PR to move to class based projection for NewActionRepo method instead of
relying of list of fields. Also as the permissions were not required
converted the existing method to JPA based query.

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Binding, @tag.Datasource,
@tag.GenerateCRUD"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8782210714>
> Commit: 80e40e840989db48954aafed914a801fbba995aa
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8782210714&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced data fetching capabilities for actions within applications,
improving performance and efficiency.

- **Refactor**
- Optimized data source validation process during application creation
to ensure smoother user experiences.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-23 12:51:22 +05:30
Trisha Anand
19b9f4925d
Merge pull request #32866 from appsmithorg/release
23/04 Daily Promotion
2024-04-23 10:42:15 +05:30
Diljit
48c6876031
chore: Change wait for viewPage in EditAppFromSearch to getConsolidatedData (#32856) 2024-04-23 10:35:57 +05:30
Abhijeet
a6daa4838d
chore: Deprecate recentlyUsedWorkspaceId and recentlyUsedAppIds from user data (#32756)
## Description
PR to remove usage of `recentlyUsedWorkspaceIds` and
`recentlyUsedAppIds` from the codebase. We need to clear this debt as
after the homepage revamp project, we have updated the fields to store
entities in [separate DTO
class](https://github.com/appsmithorg/appsmith/blob/release/app/server/appsmith-server/src/main/java/com/appsmith/server/dtos/ce/RecentlyUsedEntityCE_DTO.java)
instead of bare list of strings.

Fixes https://github.com/appsmithorg/appsmith/issues/31745

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8752116697>
> Commit: 0be31ca9c9a02030b215f4c5c19f188b2ed481d9
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8752116697&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **New Features**
	- Introduced a new interface for managing user release notes.
- Added functionality to handle removal of entities from recently used
lists more efficiently.

- **Bug Fixes**
- Corrected API call errors for deprecated methods in application
controllers.

- **Refactor**
- Updated various classes to use new user release notes management
system.
- Renamed methods to better reflect their functionality related to
recent workspace and application usage.

- **Tests**
- Updated unit tests to align with the new changes in application and
user data management.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-23 10:14:31 +05:30
Shrikant Sharat Kandula
cd22fc1087
test: Some cleanup for Git Cypress tests (#32836)
1. Change usage of ports bound to 3000, 5000 and 8000 to 4200, which
will be the canonical port for TED in the future.
2. Switch to using TED's native git repo management APIs, instead of the
Gitea compatibility layer.
3. Remove code from GitHub ages.


/ok-to-test tags="@tag.Sanity, @tag.Git"<!-- This is an auto-generated
comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8785291879>
> Commit: b38f4eb388716f7fcfc2a032d788c2ebb951568b
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8785291879&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->





<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Enhanced Git integration by shifting from GitHub to Gitea for
repository operations in test environments.
- Updated URLs and endpoints across various test scripts and data
fixtures to align with new configurations.
- **Tests**
- Modified test scenarios to reflect changes in Git operations and URL
configurations.
- **Chores**
- Updated CI workflows by replacing old secrets with new ones for better
configuration management.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-23 10:01:14 +05:30
Jacques Ikot
60d45ea6ff
feat: add analytics for drag and drop building blocks (#32699)
## Description
> [!TIP]  
Add events to track the dragging of building blocks, dropping of blocks,
and the time taken from drag till drop is complete.

**Drag Event**
```
AnalyticsUtil.logEvent("DRAG_BUILDING_BLOCK_INITIATED", {
        applicationId,
        workspaceId,
        source: "explorer",
        eventData: {
          buildingBlockName: props.details.displayName,
        },
      });
```

**Drop Event**
```
AnalyticsUtil.logEvent("DROP_BUILDING_BLOCK_INITIATED", {
        applicationId,
        workspaceId,
        source: "explorer",
        eventData: {
          buildingBlockName: props.details.displayName,
        },
      });

AnalyticsUtil.logEvent("DROP_BUILDING_BLOCK_COMPLETED", {
        applicationId,
        workspaceId,
        source: "explorer",
        eventData: {
          buildingBlockName: dragDetails.newWidget.displayName,
          timeTakenToCompletion: timeTakenTo CompleteValueInSeconds,
          timeTakenToDropWidgets: timeTakenValueInSeconds
        },
      });
```

Fixes #32492  

## Automation

/ok-to-test tags="@tag.Widget"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8785306375>
> Commit: 8316506b039256ad6d171a3a81ddaec56cecdfc2
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8785306375&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






























<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced analytics tracking for building block drag-and-drop
operations.
- Enhanced functionality for adding and managing building blocks within
the application.
- **Refactor**
- Updated action type constants for better consistency in handling
building block operations.
- **Bug Fixes**
- Improved logic for setting the start time of building block drag
operations to ensure accurate tracking.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>
2024-04-22 15:58:37 +01:00
Apeksha Bhosale
dc7bd0298f
fix: API_Pane_spec - Fixed new messages (#32848)
## Description
New text needed to be updated

caused by https://github.com/appsmithorg/appsmith/pull/32514


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Tests**
- Enhanced API pane tests to use centralized text management for
improved consistency and maintainability.
- Updated test configurations to reflect the renamed test specification
file.
    - Improved import statements for better code organization.
- Modified text content within `AssertElementVisibility` calls for
clarity.
- Added import statements for `createMessage` and `EDITOR_PANE_TEXTS`.
    - Updated import path for `createMessage`.
- Modified text content within `AssertElementVisibility` calls to use
`createMessage` with `EDITOR_PANE_TEXTS`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 19:54:23 +05:30
Shrikant Sharat Kandula
71867f9bcd
chore: Page name validation closer to file name validation (#32830)
1. Introducing a custom validation annotation, `@FileName` to be used on
fields that are used as file/folder names as part of the product.

2. Updated the validation logic to only accept valid file names on
Linux, macOS as well as on Windows.



/ok-to-test tags="@tag.Settings, @tag.IDE"

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8784587443>
> Commit: a13f700d490845a9d3c53d0da9c1a763fde6be9b
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8784587443&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->











<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced page name validation to include more special characters and
reserved names, ensuring compatibility and preventing errors.

- **Bug Fixes**
- Updated regular expression for replacing disallowed characters in page
names to improve system stability and user experience.

- **Tests**
- Expanded testing for invalid page names to cover a broader range of
scenarios, enhancing reliability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 19:22:41 +05:30
Vemparala Surya Vamsi
94ad2b9eb2
chore: resetGlobal fix and makeParentsDependOnChild add dependency optimisation (#32827)
## Description
This as part of eval v4 roadmap project#2 optimisation, over here we
optimisate resetGlobalScope and the addNode operation in the
updateDependencyMap function. The following are the optimisations:

- resetWorkerGlobalScope changed library and keyword lookup from array
to set, this is to reduce the time complexity.
- triggering resetWorkerGlobalScope after the first return statement, to
remove redundant calls when code returns early.
- in makeParentsDependOnChild limiting the add operations getting
triggered when the dependencies are the same.
- Added a library accessor code to help in generating a set when
required.

Noticed a 15% reduction in webworker scripting for a customer's app.
Limiting the addNode to only affected nodes in the dependencyMap will be
handled in a separate PR.

Fixes #32811  
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8782269083>
> Commit: bcc890545851d9ba76beef4036fda98b9d50bd0e
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8782269083&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->

































## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced new testing for dependency handling in
`DependencyMapUtils`.
	- Added a new Cypress test spec for ClientSide SettingsPane.

- **Refactor**
- Enhanced dependency management in `DependencyMapUtils` to prevent
redundant dependencies.
- Updated handling of JavaScript libraries in the evaluation workflow to
improve performance and accuracy.

- **Tests**
- Expanded test coverage to ensure robust dependency management and
JavaScript library handling.

- **Documentation**
- Updated existing summaries to reflect changes in JavaScript library
management and test specifications.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 17:22:28 +05:30
Trisha Anand
15df4e69fc
Merge pull request #32850 from appsmithorg/release
Daily promotion 22/04
2024-04-22 16:23:47 +05:30
Aman Agarwal
f281eff665
fix: tooltip of the ellipsis content for response table changed to left position (#32800) 2024-04-22 15:50:16 +05:30
yatinappsmith
815d0b5f14
CI: Add tags to to cypress tags (#32843)
Add tags to to cypress tags

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Updated and reorganized tags within the application to include new
categories such as "Audit Logs," "Access Control," "License and
Billing," and "Provisioning." Also, rearranged the "Templates" tag for
better accessibility.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 15:42:53 +05:30
Valera Melnikov
6d90ce8dc9
chore: update storybook (#32828)
## Description
- Update Storybook and related dependencies
- Delete the stories for old widget components
- Rewrite stories for new widgets(mdx to tsx)

Note: local chromatic doesn't work because of this
https://github.com/storybookjs/storybook/issues/22531

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced new component stories across various packages to enhance
design system documentation and user experience.

- **Documentation**
- Updated `.gitignore` files to optimize version control settings for
Storybook and build logs.

- **Refactor**
- Modified UI element positioning in Storybook theming for improved
layout management.

- **Style**
- Adjusted CSS properties for the `Select` component to ensure better
visual presentation.

- **Chores**
- Updated dependencies and scripts in package configurations to maintain
up-to-date development tools.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 12:17:28 +03:00
Nikhil Nandagopal
cee6660de9 Updated Label Config 2024-04-22 13:30:34 +05:30
Nikhil Nandagopal
73a7dd3c0c Updated Label Config 2024-04-22 13:29:41 +05:30
Shrikant Sharat Kandula
7fb01b31e3
test: Better assertion failure message for duplicate error test (#32834)
Currently, when this fails we see this:

```
org.opentest4j.AssertionFailedError: 
expected: 156L
 but was: 155L
Expected :156L
Actual   :155L
```

(It's comparing the count vs distinct-count).

This PR makes the failure show up like this:

```
java.lang.AssertionError: 
Expecting empty but was: ["AE-APP-4001"]
```

Making the failure message much more useful.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Tests**
- Updated the method for verifying the uniqueness of error codes in the
system to enhance reliability by using a new approach.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 11:22:10 +05:30
NandanAnantharamu
16874f4561
test: updated test for DataIdentifier (#32752)
DataIdentifier test fix

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifier_spec.ts

RCA:
Exeternal API was the main reason for failure
1. external API was used
2. Replaced with TED API

Removed unwanted wait 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **Bug Fixes**
- Improved the reliability of list loading in automated tests by
removing unnecessary delays.
- Enhanced data processing in lists by modifying the data configuration
format.
- Updated test configuration to use the correct spec file path for
limited tests.
- Added interactions with EditorNavigation and propPane for selecting
entities and properties in the test scenario.
- Added a new declaration `_dropdownControlError` to the `PropertyPane`
class, representing a selector for dropdown control errors.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 10:41:11 +05:30
Shrikant Sharat Kandula
85bed5bfc7
ci: Publish port 4200 for TED (#32835)
This changes to publish TED's canonical app port, `4200`.

What's wrong with the currently used ports?


57f63003ef/app/app.ts (L18-L20)

Quoting here:

> 8000, // Past static webserver port, to be removed, after switching to
4200, clashes with CloudServices on CI.
> 5000, // Past Postgraphile port, to be removed, after switching to
4200, clashes with macOS AirDrop.
> 3000, // Past Gitea port, to be removed, after removing Gitea, because
it clashes with `yarn start` in Appsmith.

/ok-to-test tags="@tag.Sanity"
2024-04-22 10:33:07 +05:30
Jacques Ikot
ef279d1e76
feat: update copy from widgets to UI elements (#32514)
## Description
> [!TIP]  
With the addition of building blocks to the explorer items, we need to
change the widget name to something that better encapsulates the
contents of the canvas explorer. All instances of "widgets" in the
canvas explorer have been changed to "UI elements"

Fixes #32331

## Automation

/ok-to-test tags="@tag.Widget, @tag.MainContainer, @tag.Visual"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8777493414>
> Commit: 97f5cdb47a40086bf2979661c39fa4a32d0e4dd8
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8777493414&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->












<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added new constants and updated text descriptions for UI elements in
the editor pane.
	- Enhanced the multi-select property pane with clearer text.
- **Refactor**
- Changed terminology from "widgets" to "UI elements" across various UI
components.
- **Style**
- Updated messages and placeholder texts to improve user interface
clarity and consistency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 05:35:24 +01:00
Goutham Pratapa
a9afdd9a11
[feat]: print appsmith info details in startup (#32549)
Fixes: [21899](https://github.com/appsmithorg/appsmith/issues/21899)
2024-04-22 09:35:14 +05:30
Goutham Pratapa
78883c9336
[fix]: fix shell scripts in aws_ami (#32824)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Updated the loop condition in the URL encoding functionality for
improved reliability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 09:34:58 +05:30
Shrikant Sharat Kandula
489255f3ca
fix: Fix duplicate error code 2024-04-22 08:19:34 +05:30
Shrikant Sharat Kandula
9649d8561c
chore: Remove unneeded fields in snapshot response body (#32813)
These extra fields don't hold much semantic value, and are completely
ignored by the client. This PR removes them and only keeps the one field
that's used by the client.


/ok-to-test tags="@tag.All"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8755978321>
> Commit: 9b680799db0d30fb56c908f02260abbb4b590ac3
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8755978321&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->










<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved consistency in naming conventions related to snapshot details
across the platform.
- Enhanced data handling in snapshot fetching and updating processes for
better performance.
- Streamlined snapshot-related data structures and service responses to
focus on relevant information.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 08:08:45 +05:30
Jacques Ikot
946e69bbd2
fix: race condition when running building block actions after drop on canvas (#32808)
## Description
> [!TIP]  
After a building block has been dropped, all queries within the building
block that are set to run onPageLoad are triggered. We noticed that when
dropping multiple building blocks, there was a race condition causing
some queries ro run infinitely. After inspecting, we found that running
the actions sequentially will solve the problem. These building block
actions are limited to a max of 3.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8752137869>
> Commit: 81a2a65c53cc90f817c24d3a003f9ec85acc1428
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8752137869&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the execution flow of actions in the widget addition process
to enhance performance and reliability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-22 03:30:56 +01:00
Hetu Nandu
ad91acd9a3
fix: Widget Selection prompts showing outside Editor (#32794) 2024-04-20 13:52:49 +05:30
Shrikant Sharat Kandula
37696bb3ec
chore: Don't mask 405 as 500 (#32829)
/ok-to-test tags="@tag.Sanity"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced handling for "HTTP method not allowed" errors to improve
user feedback on unsupported actions.

- **Refactor**
- Optimized error handling structure by using annotations and removing
outdated constructors.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-20 13:46:43 +05:30
Shrikant Sharat Kandula
efc088e509
chore: Fix star-imports (#32826)
/ok-to-test tags="@tag.Sanity"

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated import statements across various services to enhance code
efficiency and maintainability.
- Introduced advanced image processing capabilities in asset management.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-19 18:59:53 +05:30
Shrikant Sharat Kandula
cca1b55daf
test: Fix page name test (#32825)
Update test with the current page name validation rules on the server
and the client.

/ok-to-test tags="@tag.Settings"<!-- This is an auto-generated comment:
Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8753150717>
> Commit: e322d185a0089662054672ec045596e67e055316
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8753150717&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated comments and test cases in Page Settings to reflect
restrictions on using slashes and colons in page names.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-19 17:59:03 +05:30
Apeksha Bhosale
272aad22cc
fix: ForkTemplateToGitConnectedApp.js - slack bot template has been removed (#32819)
## Description
Slack bot template has been removed from the list of templates so going
to pick the first one whichever we can find.

Link --> 10th spec from
https://www.notion.so/appsmith/Cypress-tests-analysis-4090efa5e3064a2e87f262d3c399a339

EE PR - https://github.com/appsmithorg/appsmith-ee/pull/3995

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved the reliability of template selection in the app by updating
the click action to target the entire template card.
- Enhanced the user experience by adjusting the wait time for template
setup completion.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-04-19 17:49:11 +05:30