Commit Graph

2 Commits

Author SHA1 Message Date
Shrikant Sharat Kandula
97e3791d3a
chore: Add a lint step for field name constants (#32769)
We have a small linter NodeJS script that checks if any field name
constants are defined incorrectly. This PR adds this linter to the build
script, so it'll be run in CI.
2024-04-19 10:01:09 +05:30
Shrikant Sharat Kandula
41a66a1168
chore: Tiny NodeJS script as a linter for field name constants (#31766)
The point is to prevent unfortunate field name problems like this:
https://github.com/appsmithorg/appsmith/pull/31760/files.

This NodeJS script does a very rudimentary analysis on all Java files,
with a few regular expressions, and finds anomalies. As such, since it's
not very smart, it's quite strict. I intend to make it a little more
strict in the coming days, but it's a start.

It's not hooked into any processes/CI yet, but that will also come in
next. Since it's not very smart, it actually runs quite fast (.8s on
EE).

The script also doesn't exit with a non-zero exit code when it finds a
problem. Also will be solved as part of integrating it into CI.
2024-03-14 06:30:40 +05:30