Commit Graph

4465 Commits

Author SHA1 Message Date
Keyur Paralkar
792b1e6bd6
fix: changed the editing to false on onFocus in PrimaryColumnsControl (#9825) 2021-12-24 15:01:26 +05:30
Keyur Paralkar
c39f7f968b
fix: changed the default row size to 4 for the divider widget (#9917) 2021-12-24 13:49:34 +05:30
albinAppsmith
352f843821
fix: Input border color fix for hover state (#9894)
* * added appsmith platform theme basic
* changed input hover border

* * generate application text change

* * changed colors to new css file
2021-12-24 12:55:25 +05:30
Ayangade Adeoluwa
45a5c38320
feat: Added tests for renaming entities through the entity explorer (#9867)
* Added tests for renaming entities through the entity explorer

* changes made to deletePageFromSideBar function

* adds custom made test cases config

* test cases should be within smoke test suite

* return configuration to run full test suite
2021-12-24 08:16:08 +01:00
balajisoundar
2138229a59
fix: Reset on submit for Number type in Input widget (#9958)
- Handle NaN value in defaultValue validations in Input widget
2021-12-24 11:20:07 +05:30
Parthvi12
6cb4590f4f
Added testcases for statbox (#9684) 2021-12-24 09:17:43 +05:30
Ayangade Adeoluwa
8e97e79791
remove unneccessary styles from field array control (#9880) 2021-12-23 18:10:08 +01:00
Ayangade Adeoluwa
7f04f32ac2
fixes undefined error coming from datasource rest api form values (#9952) 2021-12-23 18:09:11 +01:00
Vicky Bansal
d40226e937
fix: Default date to remain empty value when binding value is empty (#9823) 2021-12-23 21:21:28 +05:30
Paul Li
e789b1293b
fix: Audio recorder widget - group styling properties (#7643)
* Fix: Audio recorder widget styling property needs to be categorized under Styles not General

-- Group style related properties

* Fix: Audio recorder widget styling property needs to be categorized under Styles not General

-- Move styles section to the bottom of the layout
2021-12-23 14:17:47 +00:00
Hetu Nandu
39b0a4e5a6
feat: Native promises support in Appsmith (#8988)
Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com>
2021-12-23 14:17:20 +00:00
Bhavin K
244b089771
fix: added support for timePrecision (#9423) 2021-12-23 14:17:08 +00:00
Shrikant Sharat Kandula
20cfc44b02
Fix toast message on reset password (#9957) 2021-12-23 14:16:09 +00:00
balajisoundar
8d3e3fd88b
fix: remove allowed filetype restriction in filepickerwidget (#9921) 2021-12-23 18:46:57 +05:30
haojin111
8567d67ef9
fix: disconnect git and repo connect error UI modal (#9833) 2021-12-22 01:26:32 +05:30
Rishabh Saxena
f91e457db9
chore: show only ssh key in the deploy key UI section and remove the label (#9882) 2021-12-21 21:27:26 +05:30
Anand Srinivasan
3a4658c8f5
fix: unexpected return error (#9432)
* assign undefined for empty scripts during evaluation

* add unit tests

* handle anonymous_function when undefined

* update unit tests

* remove unwanted assignments in evaluation scripts

* update unit tests

* Update app/client/src/workers/evaluate.test.ts

* fix lint cypress tests

* remove semicolon

* fix API_bugs_spec

* undo anonymous function change

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>

* add comment

* return back when JS is empty

* Update app/client/src/workers/evaluate.ts

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-21 20:00:19 +05:30
Rishabh Saxena
5ec308ce90
fix: git config updates (#9818) 2021-12-21 19:16:37 +05:30
Arpit Mohan
bbe7267b6e
ci: Adding Vercel integration because of issues with Netlify (#9903)
Netlify builds are failing because of seemingly memory constraints. Also they are taking twice as long as Vercel. 

This is an experiment to see if we can switch to Vercel for our deploy preview needs.
2021-12-21 15:33:12 +05:30
Keyur Paralkar
848bc13bc3
fix: corrected Index cond. for conditional formatting in table widget (#9735)
* fix: corrected Index cond. for conditional formatting in table widget

* test: added integration test for checking condtional formating post sorting

* refactor: enhanced the originalIndex condition with nullish coalescing op
2021-12-21 15:25:12 +05:30
Aishwarya-U-R
13f24cbce8
test: Automated tests for Rest Api, S3 Bugs and flakiness fixes (#9695) 2021-12-21 15:07:30 +05:30
NandanAnantharamu
d8e41b4b5c
test: updated org test (#9868) 2021-12-21 13:38:10 +05:30
akash-codemonk
48267bf239
Fix mock Postgres database endpoint (#9593) 2021-12-21 11:13:19 +05:30
Parthvi12
293ddc3ea1
adding test cases for undo/redo (#9742) 2021-12-21 10:44:58 +05:30
Leo Thomas
77433cf62b
feat: Add support to send arbitrary form values to oAuth server during Datasource authentication (#9660)
* feat:9389  Add support to send arbitrary form values to oAuth server during Datasource authentication

* Changes related to Code Review Comments of PR 9650

* Changes implemented to set custom Key Value pairs

* Resolved Code Review comments

* Resolved Code Review comments
2021-12-21 10:12:26 +05:30
Arpit Mohan
96677ef673
fix: Updating log4j to 2.17.0 to prevent JNDI lookups (#9863)
Also making minor edit to not show "Application name updated" toast message. This is a counter-productive toast that is distracting the user
2021-12-20 16:01:08 +05:30
balajisoundar
2796bf0baf
fix: handle undefined filterdata props in table widget (#9832) 2021-12-20 15:41:33 +05:30
arunvjn
99a12be018
feat: add option to delete org (#9287)
Co-authored-by: Nayan <nayan@appsmith.com>
2021-12-20 05:58:01 +00:00
Rishabh Saxena
29d90166af
chore: update font for the user settings title (#9854) 2021-12-20 11:19:17 +05:30
Ankita Kinger
aa190fb434
fix: Excluded hyphen substitution in branch name validation (#9842)
* added exception for hyphen in branch name validation

* created jest test case for branchlist removeSpecialChars function
2021-12-20 10:22:28 +05:30
imgbot[bot]
387aed75e1
chore: [ImgBot] Optimize images (#9855)
*Total -- 311.31kb -> 173.82kb (44.16%)

/deploy/digital_ocean/images/edit-app.png -- 309.70kb -> 172.23kb (44.39%)
/app/client/src/assets/icons/widget/switch-group.svg -- 1.60kb -> 1.59kb (0.61%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-12-18 22:40:28 +05:30
Nayan
68a9584fd9
fix: removed sentry reposrting when application not found (#9839) 2021-12-17 20:16:49 +05:30
Ayangade Adeoluwa
b763fa03d3
fix: fixes inability to rename other widgets, jsactions, pages (#9848)
* fixes inability to rename other widgets, jsactions, pages

* adds edge case to handle renaming non action based entities

* fix if check
2021-12-17 19:21:06 +05:30
Tolulope Adetula
831c0cb685
fix: chart validation (#9718) 2021-12-16 22:19:44 -08:00
Ayangade Adeoluwa
bdad41f323
Fix merge problems (#9829) 2021-12-16 20:43:00 +05:30
Paul Li
f62c8a62a4
fix: checkbox group feedback (#6959)
* FIX-6783 : Checkbox group widget - Feedback

-- Add default border for a checkbox icon and color for a label
-- Align the option to the center if its options count is one or inline
-- Set isInline to true by default in widget config

* FIX-6783 : Checkbox Group Widget Feedback

-- Add a migration for isInline property

* Feat: Checkbox Groupd Widget Feedback

-- Add vertical margin between options

* Fix: Checkbox Group Widget

-- Increase default rows value to 1.5 in widget configuration

* Fix: Checkbox Group Widget

-- Change the migration version number

* Fix: Checkbox Group Widget

-- Change migration version number

* Fix: Checkbox Groupd Widget Feedback

-- Delete redundant WidgetConfigResponse file

* Fix: Checkbox Group Widget Feedback

-- Change the config values of rows, columns
-- Refactor migration file

* Fix: Checkbox Group Widget

-- Refactor migration file

* fix: Checkbox Group Widget Feedback

-- Fix on the wrong dsl version

* fix: Checkbox Group Widget Feedback

-- Remove a unnecessary comment
-- Update the version of the widget in its config and migration

* fix: checkbox group feedback

-- Rewrite a migration for isInline property

* fix: checkbox group feedback

-- Follow the figma design on disabled state

* fix: Checkbox Group Widget feedback

-- Apply appropriate migration

* fix: Checkbox group widget - Feedback

-- Apply theme changes

* fix: Checkbox Group Widget - Feedback

-- Change the border color of an unchecked checkbox to DARK_GRAY

* fix: Checkbox Group Widget - Feedback

-- Remove inset box shadow from the checkbox indicators

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 22:24:23 +08:00
balajisoundar
3c1edbeb3a
feat: Admin settings page to tinker with env variables (#9687) 2021-12-16 19:47:16 +05:30
Ayangade Adeoluwa
e6bc975889
fix: Fixes inability to use duplicate names across multiple actions in different pages (#9360)
* Fixes inability to use duplicate names across multiple actions in different pages

* adds comments for better understanding and readability

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:53 +05:30
Ayangade Adeoluwa
7af727651d
fix: Assigns query Params in Datasource and Api query editor (#9184)
* adds option to assign query params in datasource and see those params in apieditor

* fix flaky cypress tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:38 +05:30
Ayangade Adeoluwa
a6796daaa9
fix: deleted actions display error messages when navigated to (#9507)
* deleted actions display error messages when navigated to

* adding custom type for goBackFn

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 18:10:14 +05:30
Ayangade Adeoluwa
c36d8f1b49
fixes query editor duplication (#9761) 2021-12-16 18:10:02 +05:30
NandanAnantharamu
4fa39d924d
test: TableWidget bugs (#9795)
* Added tests for Table widget bugs

* typo in test corrected

* Updated a flaky test
2021-12-16 14:52:14 +05:30
Tolulope Adetula
7e3529f60b
fix: selected option value from select widget (#9796)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

* fix: selectedOptionValue

* revert : test case

* fix: tests

* fix: add test cases

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-16 08:36:26 +01:00
Aswath K
66b9f69426
fix: Issue with deleting page (#9784)
Old page id was getting cached caused failure in deleting pages

Fixes #9717
2021-12-16 12:28:30 +05:30
Ayangade Adeoluwa
763bb8f287
restricts datasource name character length (#9471) 2021-12-15 18:02:11 +01:00
Keyur Paralkar
3a1c2b0799
fix: removed -1 and 2d array population error in the selectedRowIndices (#9606)
* fix: removed -1 and 2d array population error in the selectedRowIndices

* test: init integration test for bug fix

* test: completed the integration tests for bug fixes

* test: added unit test for edge case in propertyUtils

* refactor: removed unused import

* feat: added selectedRowIndices as an option in the autocomplete

* fix: fixed table widget test cases
2021-12-15 17:44:50 +05:30
Aman Agarwal
0c74e7273e
fix(handle-enter-confirm-popup): added key action to confirm popup wi… (#8980)
* fix(handle-enter-confirm-popup): added key action to confirm popup with class functions

* fix(handle-enter-confirm-popup): removed isModalOpen in keyUp not required check
2021-12-15 17:21:57 +05:30
Ayush Pahwa
d52a28dd2e
Added handling for non JSON response on executeAction (#8907)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-15 17:10:03 +05:30
Favour Ohanekwu
79b45c60df
fix: Update replaceAll function for browser support (#9776)
Update replaceAll function for browser support
2021-12-15 11:42:25 +01:00
rahulramesha
ddedf985b5
entity name rerender fix (#9703) 2021-12-15 08:23:24 +00:00
Favour Ohanekwu
84a627aaeb
fix: properly lint triggerfields (#9773)
Properly lint trigger fields
2021-12-15 06:18:45 +01:00
Rishabh Saxena
2821ac2d75
fix: git sync updates (#9623)
Co-authored-by: haojin111 <haojin828@outlook.com>
2021-12-15 00:30:59 +08:00
Aman Agarwal
2c61de6525
fix: Correcting the duplication of headers from datasource to newer APIs (#9157) 2021-12-14 12:39:05 +00:00
Aman Agarwal
d05b2d5b56
fix: Correcting the run button loading state on cancel in API pane (#9094)
* fix(run-button-loading): the run button loading state changed on cancel

* fix(run-button-loading): added test case for run button loading status
2021-12-14 12:37:42 +00:00
Ayangade Adeoluwa
cac0df71aa
fixes duplication of where clause AND-condition fields (#9745) 2021-12-14 11:42:21 +01:00
Hetu Nandu
4c54ea21fb
feat: Add support for custom 'this' and 'global' variables during evaluation (#9651) 2021-12-14 14:00:43 +05:30
Ayangade Adeoluwa
e9cd435c96
feat: UQI Pagination Component implementation (#9446)
* pagination component implementation with files for testing(to be removed)

* UQI Pagination component created.

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-14 09:02:06 +01:00
Aswath K
c9e1a73db7
fix: Regex to detect function args (#9634)
* fix: Regex to detect function args

* Add Tests for argString to Array

* fix: failed condition

* fix: bug with arrow function regex
2021-12-14 13:28:09 +05:30
Bhavin K
f7e2e079a9
fix: 8336 updated isLoading property in all widgets (#9409) 2021-12-14 07:55:58 +00:00
Bhavin K
406255fcf6
fix : updated alignments (#9602) 2021-12-14 07:55:30 +00:00
Aswath K
a2902b5235
fix: table color picker issue (#9681)
* fix: deleting color in color picker causes default color to set automatically

* Set default color property for newly added columns

* Add cypress tests

* fix issue for Label color

* fix: test issue
2021-12-14 07:55:05 +00:00
Apeksha Bhosale
9a7a5e06af
fix: changed conditions for variables as variables were undefined (#9748) 2021-12-14 13:01:40 +05:30
Rishabh Rathod
4838b7e73e
Revert "fix: Select widget Value (#9444)" (#9744)
This reverts commit af08547529.
2021-12-14 11:19:54 +05:30
Rishabh Saxena
d9bdde0904
chore: remove plausible to improve page performance (#9713) 2021-12-13 12:13:39 +05:30
NandanAnantharamu
990ec76c4b
test: Added test for select Widget (#9600)
* Added test for select Widget

* updated common locators
2021-12-13 11:14:01 +05:30
Parthiv Makwana
c2d549cb37
chore: Duplicate case labels found in switch case in Icon.tsx (#8640) 2021-12-12 19:20:14 +05:30
Shrikant Sharat Kandula
a26c14e2cd
fix: Load pages from GitBook sequentially (#8519)
Loading them in parallel is causing us to breach some rate limiting restrictions sporadically and the whole process fails. So this reverts to loading pages sequentially instead.
2021-12-12 19:11:07 +05:30
dependabot[bot]
199927b32e
chore: bump algoliasearch-helper from 3.2.2 to 3.6.2 in /app/client (#9307)
Bumps [algoliasearch-helper](https://github.com/algolia/algoliasearch-helper-js) from 3.2.2 to 3.6.2.
- [Release notes](https://github.com/algolia/algoliasearch-helper-js/releases)
- [Changelog](https://github.com/algolia/algoliasearch-helper-js/blob/develop/CHANGELOG)
- [Commits](https://github.com/algolia/algoliasearch-helper-js/compare/3.2.2...3.6.2)

---
updated-dependencies:
- dependency-name: algoliasearch-helper
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-12 07:52:56 +00:00
dependabot[bot]
1a2db9dc09
chore: bump ua-parser-js from 0.7.22 to 0.7.31 in /app/client (#9504)
Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.22 to 0.7.31.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Commits](https://github.com/faisalman/ua-parser-js/compare/0.7.22...0.7.31)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-12 07:50:09 +00:00
Paul Li
08b0e86967
feat: Change Map Pin Color on Map Widget (#8337)
* feat: Change Map Pin Color on Map Widget

-- Add a color property for a marker

* feat: Change Map Pin Color on Map Widget

-- Set #E0DEDE as default color

* feat: Change Map Pin Color on Map Widget

-- Revert to the original logic

* feat: Change Map Pin Color on Map Widget

-- Add a new base icon for a marker

* feat: Change Map Pin Color on Map Widget

-- Add anchor property for custom marker icon

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-12 13:43:29 +08:00
dependabot[bot]
f8f230f531
chore: bump prismjs from 1.24.0 to 1.25.0 in /app/client (#7649)
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](https://github.com/PrismJS/prism/compare/v1.24.0...v1.25.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-11 12:31:48 +05:30
dependabot[bot]
abe50f3c6e
chore: bump url-parse from 1.4.7 to 1.5.3 in /app/client (#9502)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.3.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.3)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-11 06:50:39 +00:00
Snyk bot
b31d390054
chore: app/client/package.json & app/client/yarn.lock to reduce vulnerabilities (#9447)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-JSONSCHEMA-1920922

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-10 18:11:35 +00:00
Vicky Bansal
39db055211
fix: use defaultTab as selectedTab when selectedTab property is not available on page load (#9487) 2021-12-10 14:15:03 +05:30
Aishwarya-U-R
fd0f258699
test: Automated tests for RestApi, S3 Bugs (#9539)
* Supressing console.log

* Bugs 5550, 8684 scripted

* Bugs # 9425, # 4775 + S3 failure fix

* S3 failure fixes

* Postgress Delete Ds correted

* Bug # 9334 - Implemented

* onlyQueryRun reverted

* testSaveDatasource reverted

* Mongo Aggregate case fix

* testSaveDatasource updated to test true & false
2021-12-10 12:53:12 +05:30
albinAppsmith
2721b5b784
fix: Context menu auto close issue in page settings (#9675)
* * Bug fix for context menu auto  closing

* * Added comments
2021-12-10 09:58:52 +05:30
Tolulope Adetula
7f3c849876
fix: button variant table binding (#8712)
* fix: Table widget binding

* fix: binding property

* fix: Add binding and new validation

* fix: Control for Table Binding

* fix: revert new Validation type change

* fix: failing test

* fix: validation

* fix: validation issue

* fix: binging issue

* revert: control changes

* revert: control changes

* fix: binding issues

* revert: validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 04:12:42 -08:00
balajisoundar
ae21b7ef51
chore:[Admin settings] Send email config details as payload when making send test email call (#9631) 2021-12-09 17:41:45 +05:30
Paul Li
54579a4e6c
feat: Switch Group widget (#7590)
* Feat: Switch Group Widget

-- The first MVP of the widget

* feat: Switch Group Widget

-- Follow the same config and implementation as the other group widgets

* feat: Switch Group Widget

-- Elaborate the help text for defaultSelectedValues

* feat: Switch Group Widget

-- Add a widget icon

* feat: Switch Group Widget

-- Remove unnecessary property control at ItemsControl.tsx
-- Refactor some code snippets for higher code quality
-- Add basic cypress test cases

* fix: icon for the widget optimised & replaced

* feat: Switch Group Widget

-- Add a unit test for defaultSelectedValuesValidation

* feat: Switch Group Widget

-- Make the validation type for defaultSelectedValues property to ValidationTypes.ARRAY
-- Remove original validation function and its unit test

* feat: Switch Group Widget

-- Fix on typo
-- Fix on formatting issue
-- Change the help text for isRequired property

* feat: Switch Group Widget

-- Revert help text for isRequired property to the original one

* feat: Switch Group Widget

-- Set strict property to true on defaultSelectedValues

* feat: Switch group widget

-- Refactor utility function, getCamelCaseString
-- Add the corresponding test case

* feat: Switch group widget

-- Implement options property as a plain JS field
-- Reimplement update logic for selectedValues when options changes
-- Add a new utility function for checking equality of object arrays
-- Add a unit test for the above function
-- Rewrite the corresponding Cypress test cases

* feat: Switch Group Widget

-- Remove isArrayEqual utility function and directly use functions from lodash

* feat: Swtich Group Widget

-- Make selectedValues as a derived property

* feat: Switch Group Widget

-- Replace the widget icon

* feat: Switch Group Widget

-- Rewrite a test case for onSelectionChange property

* feat: Switch Group Widget

-- Remove redundant calls for openPropertyPane

* feat: Switch Group Widget

-- Remove closePropertyPane call from afterEach hook

* feat: Switch Group Widget

-- Change the selector for every switch element in onSelectionChange test case

* feat: Switch Group Widget

-- Fix on failed Cypress test case, adding closePropertyPane command to onSelectionChange

* feat: Switch Group Widget

-- Remove template literal from a selector

* feat: Switch Group Widget

-- Make click on onSelectionChange test case forced

* feat: Switch Group Widget

-- Fix on crash issue when editing on Options property

* feat: Switch Group Widget

-- Add the widget icon to show in entity explorer

* feat: Switch Group Widget

-- Fix on blue color on mouse down
-- Add a new property for alignment

Co-authored-by: somangshu <somangshu.goswami1508@gmail.com>
2021-12-09 20:02:47 +08:00
Tolulope Adetula
3e51c1173c
fix: negative spacing in list widget (#9571)
* fix: add validation for negative numbers and allow negative spacing

* fix: add validation test for negative numbers

* fix: validation tests

* fix: validation test

* fix: errors

* fix: grid gap

* fix: validation test
2021-12-09 02:01:11 -08:00
Nishi Agrawal
3e7123d11a
fix: Cursor turning to pointer upon onclick in deployed app (#8111)
* [fix]:cursor turning to pointer upon onclick in deployed app

Signed-off-by: Nishi Agrawal <nishihere19@gmail.com>

* fix: cursor changing to pointer only if onclick event associated to image widget

Signed-off-by: Nishi Agrawal <nishihere19@gmail.com>

* fix: build error, no used var

Signed-off-by: nishihere19 <nishihere19@gmail.com>

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 14:49:24 +05:30
Nayan
15ca54e43f
Custom domain should be configured from admin UI (#9633) 2021-12-09 14:40:08 +05:30
Tolulope Adetula
4829820e86
fix: add enableClientSideSearch (#9505)
* fix: add enableClientSideSearch

* fix: add test

* fix: refactor function

* fix: filter issue

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 22:35:27 -08:00
Aswath K
177df5cc68
fix: table icon selector js mode toggle issue (#9396)
* fix: ARRAY validation with allowedValues

* Adds TABLE_PROPERTY validation

* Add test

* fix: Table icon JS mode toggle issue

* remove unused variable

* Make use of constant for icon

* Adds comment

* better validation

* fix: failed cypress test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-09 11:45:59 +05:30
Tolulope Adetula
af08547529
fix: Select widget Value (#9444)
* fix: Select widget Value

* fix: comment

* fix: failing test

* fix: failing test

* fix: failing test

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-08 11:14:53 -08:00
Vicky Bansal
3ac913a12c
feat: Row selection in Table widget using Primary Column (#8156) 2021-12-08 19:36:14 +05:30
Bhavin K
4889098888
fix: added placement support in button, button group, and menu widget (#9354) 2021-12-08 13:11:13 +00:00
Snyk bot
ddf1490866
chore: app/client/package.json & app/client/yarn.lock to reduce vulnerabilities (#9630)
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NODESASS-1059081
2021-12-08 13:10:08 +00:00
balajisoundar
ef488f1f7a
fix: Empty column name check before computing dynamicBindingPathList in Table widget (#9466) 2021-12-08 11:24:31 +05:30
albinAppsmith
c433464de8
* Bug fix in the api url bar (#9579) 2021-12-07 21:13:09 +05:30
Pawan Kumar
f33758d871
remove reset on text widget (#9594)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-12-07 15:59:04 +05:30
Hetu Nandu
7143bba134
feat: Geolocation APIs on appsmith (#9295)
Co-authored-by: Anand Srinivasan <66776129+eco-monk@users.noreply.github.com>
2021-12-07 15:49:33 +05:30
arunvjn
f62247b468
feat: Action undo redo (#9045) 2021-12-07 09:45:18 +00:00
haojin111
d701f8dfb1
fix: misc git sync fixes / ui polish (#9229)
Co-authored-by: Rishabh Saxena <rishabh@appsmith.com>
Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2021-12-07 07:59:32 +00:00
Rishabh Saxena
0ccfac7978
fix: check if smartlook, sentry and analytics are inited before the init call (#9576) 2021-12-07 07:32:51 +00:00
NandanAnantharamu
f1c4f03438
Updated test (#9616) 2021-12-07 12:58:27 +05:30
Keyur Paralkar
6e986f9e50
fix: undefined evaluted value text widget (#9521)
* fix: evaluted value undefined for text widget

* test: added cypress spec for cell background and text size change validation

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-07 10:24:19 +05:30
Arpit Mohan
b5e27aaa57
feat: Adding a SMTP plugin (#8927) 2021-12-07 09:15:15 +05:30
Yash Vibhandik
9b3b1f5196
fix: 7487 added allowSelectAll option in property pane (#9536)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-06 11:26:44 +05:30
Bhavin K
62a0f0c952
fix: ButtonGroupWidget button variant validation updated (#9454) 2021-12-06 11:07:29 +05:30
balajisoundar
99eb298de7
chore: disable and assert disablility of teletry on CI (#9560) 2021-12-03 23:59:17 +05:30
Tolulope Adetula
5ec470e3c6
fix: selected row issue (#9445)
* fix: selected row issue

* fix: add tests

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-12-03 06:15:23 -08:00
imgbot[bot]
81ccdbaede
chore: [ImgBot] Optimize images (#9544)
*Total -- 1,062.82kb -> 832.92kb (21.63%)

/contributions/assets/widgetConfig.png -- 422.37kb -> 324.12kb (23.26%)
/contributions/assets/propertyConfig.png -- 449.61kb -> 350.59kb (22.02%)
/contributions/assets/widgetFolder.png -- 180.78kb -> 148.29kb (17.97%)
/app/client/src/assets/icons/comments/pin_3.svg -- 0.41kb -> 0.39kb (5.21%)
/app/client/src/assets/icons/comments/unpin.svg -- 0.53kb -> 0.51kb (4.02%)
/app/client/src/assets/icons/form/trash.svg -- 2.81kb -> 2.76kb (1.88%)
/app/client/src/assets/icons/control/copy.svg -- 0.88kb -> 0.87kb (1.55%)
/app/client/src/assets/icons/header/hamburger.svg -- 0.22kb -> 0.21kb (1.35%)
/app/client/src/assets/icons/ads/double-arrow-right.svg -- 1.07kb -> 1.06kb (1.28%)
/app/client/src/assets/icons/widget/text.svg -- 0.26kb -> 0.26kb (1.13%)
/app/client/src/widgets/DocumentViewerWidget/icon.svg -- 0.96kb -> 0.96kb (0.61%)
/app/client/src/assets/icons/ads/double-arrow-left.svg -- 1.05kb -> 1.04kb (0.28%)
/app/client/src/assets/icons/comments/eye.svg -- 1.39kb -> 1.38kb (0.21%)
/app/client/src/assets/icons/control/help.svg -- 0.48kb -> 0.48kb (0.2%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2021-12-03 12:47:23 +05:30
Anand Srinivasan
7647d076fb
fix: sentry issues (#9491)
* add polyfill for string.replaceAll

* null check for logs
2021-12-03 12:18:37 +05:30
albinAppsmith
12e277ad1f
fix: Fold/Unfold fix on click of entity (#8961)
* * fold/unfold fix

* * cypress fix

* * Button style fixes

* * test case fix

* * cypress fixes
2021-12-03 11:54:08 +05:30
balajisoundar
fa65e38cf4
fix: fix segment calls not getting fired issue on CE instances (#9543) 2021-12-03 11:08:18 +05:30
Shrikant Sharat Kandula
77caf4c536
chore: Send telemetry option in user profile to client (#9535)
Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

Co-authored-by: sbalaji1192 <balaji@appsmith.com>
2021-12-03 01:56:16 +05:30
Parthvi12
0b8181c229
test: testcases for autocomplete using slash and mustache (#9489)
* Testcases for autocomplete using slash and mustache

* fixed failing tests

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2021-12-02 19:39:50 +05:30
Aswath K
eed6ad9166
fix: empty string validation if required is set (#9476) 2021-12-02 16:45:18 +05:30
Anand Srinivasan
4ced0954db
feat: Syntax parsing through AST (#9115)
* ast changes

* ast fix for cyclic dependency

* jest test updates for ast

* feat: Extract references in code with AST (#8617)

Co-authored-by: Nidhi <nidhi@appsmith.com>

* undo debugger changes

* code clean up and comments

* update type checks for literal nodes

* include tests for IIFE and direct object access

* fix - dependency map not updated on IIFE/direct object access

* update tslib

* unescape on AST parsing

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Nidhi <nidhi@appsmith.com>
2021-12-02 15:33:43 +05:30
Bhavin K
2ade131ebf
fix: button group cursor in case of disable (#9481) 2021-12-02 14:15:46 +05:30
Aswath K
cc0ed3b89e
fix: long dropdown popup truncates items (#9187)
* set max-height for Dropdown

* Better height calculation

* address review comment

* removed unecessary assertion

Co-authored-by: Apple <nandan@thinkify.io>
2021-12-02 08:28:51 +01:00
Keyur Paralkar
ba5262df2c
fix: fixed the default value of zero not present in parent form data on pageload (#9324)
* fix: fixed the default value of zero not present in parent form data on pageload

* test: added cypress test for Checking default value 0

* refactor: changed the DSL and added reset condition at the end of test

* refactor: removed the proxy variable

* refactor: corrected the typo
2021-12-02 11:36:24 +05:30
Uchechukwu Nwafor
74a9e7c892
fix: refresh profile image on the header when a new image is uploaded (#8550) 2021-12-02 11:26:41 +05:30
Aishwarya-U-R
37339c0cb1
test: RestAPI parallel run & Debug btn crash [Bugs 5550, 6863, 8686] - Script implementation (#9435)
* Bugs 5550, 6863 - Script implemented

* Added wait time in cy.updateCodeInput

* S3 DeleteSource failure fix

* S3 Delete Ds case fix

* Mongo Failure fixes

* Failure fixes

* Bug 8686 - Implemented

* cypress.json updated

* Added wait for proper validation pass

* Updated

* Updated EvaluateCurrentValue

* Update commands.js

* Added AfterEach

* Updated EvaluateCurrentValue()
2021-12-02 10:50:44 +05:30
Aman Agarwal
df715297ec
fix: Adding empty array check for mapping keys (#9459) 2021-12-01 18:36:41 +05:30
Favour Ohanekwu
a9527f3e49
update ternserver when no custom def is available (#9472) 2021-12-01 04:50:15 +01:00
Abhinav Jha
5173ef418b
chore: Update Validations (#9177)
* Update Validations
===
- If number value is out of bounds, return minmax || parsed || 0
- If text has regex, match RegExp - earlier we were matching with
  string, which was always failing
- Prioritise  expected  value in TEXT validation RegExp case.

* Add tests for regex and update tests for other changes

* Add test for using expected type instead of regex in messages

* Update regex, as it was reported to be buggy
2021-11-30 22:21:41 +05:30
NandanAnantharamu
425a46f34d
test: updated filter tests (#9448)
* Filter Tests

* Test spec added

* updated import

* added some wait

* updated the dependencies

* Added the dependancy files
2021-11-30 20:56:37 +05:30
Tolulope Adetula
809a288bdc
fix: popups same width as parent (#7499)
* fix: select widget popup

* fix: select widget

* fix: Menu button

* fix: make Clear Var names

* fix: consistent dropdown width

* fix: define variable better

* fix: prettier error

* fix: variable name

* fix: select popup issue

* fix: PR issues add comments

* fix: remove unused css

* fix: add tests

* fix: more pop overs

* fix: menu button popup

* fix: Multiselect dropdown

* fix: failing test

* fix: add more tests

* fix: Failing Test
2021-11-30 02:38:46 -08:00
rashmi rai
b65258876f
fix: missing number of queries in active datasource (#7694) 2021-11-30 10:11:40 +00:00
Favour Ohanekwu
ec6c0c592e
fix: Properly save JSON to clipboard (#9416)
Properly copy JSON to clipboard
2021-11-30 06:49:22 +01:00
Favour Ohanekwu
b8ca5cb816
fix: remove moment interface objects from completions (#9379)
Remove interface objects from completions
2021-11-30 06:48:13 +01:00
Favour Ohanekwu
4675b4bb10
fix: Show correct toast type options in debugger (#9415)
Show correct toast type options
2021-11-30 06:46:40 +01:00
Parthvi12
af430d7049
test: testcases for content management system app using echo api (#9420)
* testcases for content management system app using echo api

* added response check method for API calls
2021-11-30 09:28:57 +05:30
Parthvi12
720806574f
test: PgAdminFix (#9313)
* commenting failing tcs for now

* resolving conflict and  fixing testcases

* Update PgAdmin_spec.js

* fixing testcases

Co-authored-by: yatinappsmith <yatin@appsmith.com>
2021-11-30 04:54:42 +05:30
Bhavin K
6ea90e7c7b
feat: add document viewer widget (#7666)
* created new widget

* new lib for document viewer

* added cypress tests

* updated icon

* handling different url types with viewer

* add to ignore react-documents in jest transformIgnorePatterns

* added jest test, updated comments

* required changes

* updated cypress test

* updated icon svg

* doc viewer new renderers added

* comment as required

* updated test case

* added url / base64 validations

* updated url checking condition for space and updated test case

* cypress selector update

* updated url validations

* Merge branch 'release' into feature/new-document-viewer

* lazy load external lib
2021-11-29 15:37:49 +00:00
Yash Vibhandik
f6acbf1407
fix: #8530 Added Config for Menu JS Convertible (#8775)
* fix: #8530 updated config for menu color jsconvertible

* test case updated

* yarn lock update
2021-11-29 15:37:05 +00:00
Rishabh Rathod
bddafdcb7e
fix: Add default props dependency in dependency map (#9418)
* Add cloneDeep
* Add comments
2021-11-29 09:04:40 +00:00
Aswath K
669d901176
fix: MenuItem overflow (#9195) 2021-11-29 11:51:01 +05:30
NandanAnantharamu
2a3089383a
updated test flow (#9388) 2021-11-26 12:18:31 +00:00
Tolulope Adetula
f30e389167
fix: Evaluation issue with Button in table Widget (#9356)
* fix: Evaluation issue

* fix: add validation

* revert jest tests changes

* revert cypress test

Co-authored-by: root <pawan@appsmith.com>
2021-11-26 17:03:50 +05:30
Aishwarya-U-R
e5a28b3d9b
test: S3 QueryPane scripting along with possible CRUD flow coverage (#9278)
* S3 QueryPane scritping

* Postgress, S3 - failure fixes

* Postgres, S3 failure fixes

* S3 failure fixes

* Added scrollIntoView for Postgres CRUD failures

* S3 - Suggested&Snipeable widgets implemented

* S3 CRUD - failure fix

* Postgres, S3 CRUD failure fixes

* S3 field inputs corrected

* JQuery empty used to clear fields

* Commenting cases to unblock CI runs

* PgAdmin Spec - commenting failures to unblock CI

* S3, Postgres CRUD failure fixes

* Added Wait for Onboarding spec case failure

* typeValueNValidate - updated

* typeValueNValidate updated

* Reverted typeValueNValidate method trigger change

* Adding wait to typeValueNValidate

* Updated typeValueNValidate with updateCodeInput
2021-11-26 16:17:53 +05:30
Aman Agarwal
2ca413c152
fix: Correcting the throwing error to logging error for promisified triggers (#9385) 2021-11-26 15:30:24 +05:30
Confidence Okoghenun
0b18ea64f3
chore: Renames actions to event on property pane (#8579) 2021-11-26 15:02:04 +05:30
Hetu Nandu
8f2935f023
fix: Don't remove bindings when transfering action out of page (#9296) 2021-11-26 14:34:16 +05:30
Pawan Kumar
f738c5e087
fix: Alignment of point numbers in welcome pages (#9353)
* fix scroll in panel in property pane

* fix table widget button height issue

* fix alignment issues

* hide canvas selection in preview mode

* filter alignment issue fix

* fix app mode issue with iframe widget

* fix 404 alignment issues

* fix generate page alignemnt issues

* fix jsobjects empty container alignment issues

* fix comments width issue

* fix alignment issues
2021-11-26 11:46:08 +05:30
Keyur Paralkar
9fc0a038ec
fix: update tooltip record count prop table (#9297)
* docs: changed the tooltip text for total record count for table widget

* test: added unit test for testing tooltip text table widget

* refactor: added Tooltip message in the message constants
2021-11-26 10:44:00 +05:30
Bhavin K
a961c66ec3
fix: updated button group widget properties and GROUP_BUTTONS controls style (#9304) 2021-11-26 10:29:56 +05:30
NandanAnantharamu
301c2b0c92
Ignoring Flaky test (#9387) 2021-11-26 02:58:43 +00:00
rashmi rai
96d4c0b774
fix: fixing missing where key (#9215) 2021-11-25 18:48:40 +05:30
Rishabh Rathod
d7cdf6f84b
fix: Add escaping special characters before JSON.parse (#9293)
* Add escaping special characters before JSON.parse
2021-11-25 16:22:40 +05:30
Hetu Nandu
5d7f68a031
fix: Mute action execution errors when error callback is present (#9366) 2021-11-25 15:28:04 +05:30
Aswath K
41c7c344b4
fix: radio group widget crash when one of options becomes null (#9303) 2021-11-25 14:59:16 +05:30
NandanAnantharamu
3d495fc548
test: updated locators (#9271)
* updated locators

* updated dsl

* Skipping failing tests

Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com>
2021-11-25 08:55:41 +05:30
Pawan Kumar
d96c4981ca
fix: Button size inside the Table widget has increased + Property pane's panel not scrollable + Alignment issues (#9318) 2021-11-24 17:55:07 +05:30
Vicky Bansal
bf513f5c60
fix: Hide scrollbar in header and show when user hovers over header in Table Widget (#9323)
Co-authored-by: root <pawan@appsmith.com>
2021-11-24 15:27:26 +05:30
Favour Ohanekwu
c98bbbe6ae
fix: properly update dependency map (#9169)
Properly update dependency map
2021-11-24 05:43:50 +01:00
Paul Li
3f87f4959e
fix: Table Widget Icon Button should be having a default variant (#8664)
* fix: Table Widget Icon Button should be having a default variant

-- Add update logic for button variant property

* fix: Table Widget Icon Button should have default variant

-- Revert old solution
-- Set default button variant to PRIMARY both in getTableColumns and in propertyConfig

* fix: Table Widget Icon Button should have default variant

-- Change comments for updateIconAlignment utility function
-- Create a migration for button variant

* fix: Table Widget Icon Button should have default variant

-- Remove unused index parameter from forEach statement

* fix: Table Widget Icon Button should have default button variant

-- Fix on misuse of forEach on primaryColumns object

* fix: Table Widget Icon Button should have default variant

-- Change buttonVariant to TERTIARY instead of PRIMARY
2021-11-23 22:10:13 +08:00
Bhavin K
ffefdcccd8
fix: added muted flag and updated helper text (#9259) 2021-11-23 15:10:43 +05:30