Commit Graph

5314 Commits

Author SHA1 Message Date
Trisha Anand
576453639f Converted Exceptions thrown to Appsmith Plugin Exception so that its handled correctly. 2020-01-15 17:59:11 +05:30
Trisha Anand
a29ec30798 Merge branch 'hotfix/log-execute-action' into 'release'
Added log for execute action

See merge request theappsmith/internal-tools-server!159
2020-01-15 09:13:27 +00:00
Trisha Anand
670ca4cb7e Added log for execute action 2020-01-15 09:13:27 +00:00
Abhinav Jha
7baacfa22b Merge branch 'fix/popper-positioning' into 'release'
Misc Fixes

See merge request theappsmith/internal-tools-client!240
2020-01-15 04:49:36 +00:00
Abhinav Jha
536e19a568 Redirect /login to /user/login. Button widget hover style. popper now can show up on the widget cards pane. On publishing the same app opens up. Button widget card has corrected SVG. 2020-01-15 04:49:36 +00:00
Arpit Mohan
428b93683a Merge branch 'release' of gitlab.com:theappsmith/internal-tools-server into release 2020-01-14 17:14:26 +05:30
Arpit Mohan
bb8b127e2d Fixing bug again to save the reset password token in the DB.
We need to use flatMap instead of map else the Mono will not run to save the token in the passwordResetToken collection
2020-01-14 17:13:42 +05:30
Abhinav Jha
dc794f2a70 Merge branch 'fix/input-containment' into 'release'
Input Widget Containment

See merge request theappsmith/internal-tools-client!239
2020-01-14 09:50:42 +00:00
Abhinav Jha
c396bab877 Input Widget Containment 2020-01-14 09:50:42 +00:00
Trisha Anand
b06d12ecdc Merge branch 'feature/restapi-form-data' into 'release'
For non json body, set the result body as string instead of parsing

See merge request theappsmith/internal-tools-server!157
2020-01-14 09:48:43 +00:00
Trisha Anand
f4a2a73abe In case of non json results, set the result body as string, otherwise parse the json and then store it as jsonNode 2020-01-14 09:48:43 +00:00
Abhinav Jha
ff01491fc9 Merge branch 'fix/truncate-text' into 'release'
Fix button and text widgets.

See merge request theappsmith/internal-tools-client!238
2020-01-14 09:48:01 +00:00
Abhinav Jha
94e0d62ec0 Fix button and text widgets. 2020-01-14 09:48:01 +00:00
Abhinav Jha
3274081edf Merge branch 'fix/invite-users' into 'release'
Fix - Invite Users

See merge request theappsmith/internal-tools-client!237
2020-01-14 09:47:45 +00:00
Abhinav Jha
2e8f5a982f Fix - Invite Users 2020-01-14 09:47:45 +00:00
Hetu Nandu
a74045b92e Merge branch 'fix/lingering-dropdown-value' into 'release'
Fixes lingering dropdown value on api change

See merge request theappsmith/internal-tools-client!229
2020-01-14 09:32:25 +00:00
Arpit Mohan
9e6c54b343 Merge branch 'hotfix/github-login-cleanup' into 'release'
Cleaning up the Github OAuth2 login flow by adding userNameAttribute to properties

This property helps define for Spring security which field in the OAuth2 user info to read in order to determine the username of the user. This is because this field is non-standard across different OAuth2 implementations. For each new OAuth2 provider that we support, this field will be required. Else the default name field will be picked up by Spring security (which is usually the id of the user).

See merge request theappsmith/internal-tools-server!156
2020-01-14 03:10:44 +00:00
Arpit Mohan
2b0a21bbab Cleaning up the Github OAuth2 login flow by adding userNameAttribute to properties
This property helps define for Spring security which field in the OAuth2 user info to read in order to determine the username of the user. This is because this field is non-standard across different OAuth2 implementations. For each new OAuth2 provider that we support, this field will be required. Else the default name field will be picked up by Spring security (which is usually the id of the user).
2020-01-14 08:36:54 +05:30
Arpit Mohan
aadce4ade9 Merge branch 'feature/delete-application' into 'release'
Mock delete application which returns the application object which was being attempted to be deleted.

See merge request theappsmith/internal-tools-server!155
2020-01-13 13:06:43 +00:00
Trisha Anand
660e47a819 Mock delete application which returns the application object which was being attempted to be deleted. 2020-01-13 13:06:42 +00:00
Trisha Anand
46f5775c62 Merge branch 'feature/move-duplicate-action' into 'release'
API Page Association

See merge request theappsmith/internal-tools-server!149
2020-01-13 12:07:10 +00:00
Trisha Anand
28e20ed3bd Move action also works successfully in removing the action from the previous page's onLoadActions while moving to another page. 2020-01-13 12:07:10 +00:00
Arpit Mohan
a542abc563 Adding quick fix for email validation check before we send an email to the user.
This is because there are OAuth2 providers who don't provide an email ID of the user. In those scenarios, we cannot send a welcome email to the user.
2020-01-13 17:35:23 +05:30
Satbir Singh
c69238bf5c Merge branch 'fix/table-resize' into 'release'
Table resizes on widget resize.

See merge request theappsmith/internal-tools-client!232
2020-01-13 11:18:13 +00:00
Satbir Singh
22479f786f Table resizes on widget resize. 2020-01-13 11:18:13 +00:00
Arpit Mohan
56b54e1d17 Fixing bugs in the Github login flow to check for uniqueness of user
Github auth doesn't return the email ID of the user. Hence, we need to use the `login` attribute of the user profile information.
2020-01-13 15:50:00 +05:30
Arpit Mohan
dd4a0ed5dd Merge branch 'feature/github-login' into 'release'
Adding Github login feature. Also adding condition to limit domain access in Google OAuth2

The domain restriction has been done by adding parameter `hd` in the function CustomServerOAuth2AuthorizationRequestResolver#authorizationRequest. We still verify if the OAuth2 response has the parameter `hd` to ensure that no client side manipulation has been performed.

See merge request theappsmith/internal-tools-server!153
2020-01-13 06:47:17 +00:00
Arpit Mohan
db27e7c86c Adding Github login feature. Also adding condition to limit domain access in Google OAuth2
The domain restriction has been done by adding parameter `hd` in the function CustomServerOAuth2AuthorizationRequestResolver#authorizationRequest. We still verify if the OAuth2 response has the parameter `hd` to ensure that no client side manipulation has been performed.
2020-01-13 12:13:53 +05:30
Arpit Mohan
7622d76f32 Adding the property server.use-forward headers in order for Spring security to function properly behind a Nginx load balancer
This property helps the spring security library derive the host name, protocol and port accurately even while running behind a Nginx load balancer. This is because nginx adds X-Forward-* headers that are parsed by Spring security library.
2020-01-13 10:25:43 +05:30
Abhinav Jha
f57068d4a7 Merge branch 'release' 2020-01-10 18:27:14 +05:30
Arpit Mohan
f374638d98 Adding exception stack trace to the login failure scenarios for debugging. 2020-01-10 18:11:29 +05:30
Arpit Mohan
60b7c69346 Adding a check for referrer header incase we don't find the origin header in authenticationFailureHandler
This is required for OAuth2 failure handling. When the client makes an OAuth2 request, we don't receive an origin header. If the OAuth2 login fails for some reason, our failure handler will not redirect correctly unless we also check for the referer header.
2020-01-10 18:06:15 +05:30
Abhinav Jha
85a12c1b21 Merge branch 'feature/ab-test-branches' into 'release'
A/B test branches

See merge request theappsmith/internal-tools-client!235
2020-01-10 12:27:40 +00:00
Abhinav Jha
70d0c9d048 A/B test branches 2020-01-10 17:52:45 +05:30
Abhinav Jha
aae19a487c Merge branch 'fix/patch-fix-widget-drag' into 'release'
Fix widget drag issue

See merge request theappsmith/internal-tools-client!234
2020-01-10 12:19:35 +00:00
Abhinav Jha
92b9ca664f Fix widget drag issue 2020-01-10 17:45:54 +05:30
Arpit Mohan
70e9adbef6 Correcting the redirect uri property name in the config file for custom OAuth2 redirection
This is required because when we host inside a docker container, the default host and port picked up by the code is the docker container's name & port. This will not work when Google (for example) needs to redirect back to our server after authentication is complete. Hence, we need to customize the default redirect uri for all OAuth2 endpoints.
2020-01-10 17:06:05 +05:30
Arpit Mohan
8b9d865c5a Revert "Adding logs to debug docker OAuth2 login issue"
This reverts commit e3773bdf9f1c0ee543b98a2f9ac01b07efaf1858.
2020-01-10 16:44:02 +05:30
Arpit Mohan
73a6ca13f0 Adding logs to debug docker OAuth2 login issue 2020-01-10 16:18:36 +05:30
Arpit Mohan
f679e457f5 Merge branch 'release' into 'master'
Release

See merge request theappsmith/internal-tools-client!231
2020-01-10 09:54:47 +00:00
Arpit Mohan
8c2b23f8d6 Merge branch 'hotfix/reset-password-user-not-exist' into 'release'
Handling the case where the user tries to reset the password for a user that doesn't yet exist in the system. We now return a 404 error for this scenario.

See merge request theappsmith/internal-tools-server!151
2020-01-10 09:28:10 +00:00
Arpit Mohan
6f76ba99d6 Handling the case where the user tries to reset the password for a user that doesn't yet exist in the system. 2020-01-10 14:54:10 +05:30
Satbir Singh
b3ab234e8f Merge branch 'feature/resize-reorder' into 'release'
Column resize reorder and hiding columns

Any widget is able to disable drag by calling a function.

See merge request theappsmith/internal-tools-client!230
2020-01-09 11:39:26 +00:00
Satbir Singh
f9b7777828 Column resize reorder and hiding columns 2020-01-09 11:39:26 +00:00
Hetu Nandu
11da2d430a fixed 2020-01-08 19:41:02 +05:30
Abhinav Jha
22b3a50e6c Merge branch 'fix/widget-boundaries' into 'release'
Widget boundaries

See merge request theappsmith/internal-tools-client!225
2020-01-08 13:46:16 +00:00
Hetu Nandu
aabc01d5e4 Merge branch 'fix/text-widget-auto-html' into 'release'
Automatically render html, links, and email links in text widget

See merge request theappsmith/internal-tools-client!228
2020-01-08 13:08:30 +00:00
Satbir Singh
f34c3b20c7 Merge branch 'feature/table-func-comp' into 'release'
Changed TableComponent from class to function

See merge request theappsmith/internal-tools-client!223
2020-01-08 12:53:26 +00:00
Satbir Singh
7379e4ac5d Changed TableComponent from class to function 2020-01-08 12:53:26 +00:00
Hetu Nandu
a0052922dd safe html and link support 2020-01-08 18:00:16 +05:30