Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
5,314 Commits 1 Branch 0 Tags 507 MiB
7bd1e9587c
Commit Graph

3840 Commits

Author SHA1 Message Date
Trisha Anand
078870f7c9
Communicate action execute on load changes in update layout (#2825) 
* 1. Update on load actions correctly
2. Send the changed actions with their changes as well as messages back to the client as part of the response.

* Added test case to assert that the action updates are correctly recorded in updateLayout.

* Code cleanup + added more comments for code readability

* Incorporated review comments.
 2021-02-09 10:39:08 +05:30
Shrikant Sharat Kandula
fbf6021080
Fix nested structure translation in DynamoDB (#2915) 2021-02-09 06:59:45 +05:30
Nidhi
973cd850e7
Modified documentation links for plugins (#2909) 
* Modified documentation links for plugins

* Modified documentation links for plugins
 2021-02-08 17:11:31 +05:30
Shrikant Sharat Kandula
ebcbfb0043 Merge branch 'release' 2021-02-08 16:39:47 +05:30
Piyush Mishra
0a6040c1cd
Hotfix redux-form getting destroyed (#2908) 2021-02-08 16:24:49 +05:30
NandanAnantharamu
3d43d04658
Remove unwanted step in Cypress Map widget test (#2902) 
* updated test

* removed the commented line

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-08 16:20:28 +05:30
NandanAnantharamu
1aa879d8c2
updated flaky test (#2899) 
* updated flaky test

* review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-08 15:50:03 +05:30
Shrikant Sharat Kandula
433ce89c76
Add support for handling array types in Postgres plugin (#2887) 2021-02-08 15:06:57 +05:30
Nidhi
35b3e7d84f
Switched test container ver (#2898) 2021-02-08 13:40:53 +05:30
Pawan Kumar
3e53df8b64
Update Default styles of Widgets (#2823) 
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
 2021-02-08 13:00:01 +05:30
Rishabh Saxena
a473ed23b0
fix navbar bottom border when tabs arent rendered (#2883) 2021-02-08 10:50:52 +05:30
Nikhil Nandagopal
d9bc97cf39 Merge branch 'release' into fix/filepicker 2021-02-04 19:25:33 +05:30
Piyush Mishra
a2d8061aa2
Prep for a separate RestAPIDatasource (#2874) 2021-02-04 17:50:24 +05:30
Hetu Nandu
5d514849b4
Fix org creation and app creation tests (#2878) 2021-02-04 17:01:32 +05:30
Nikhil Nandagopal
6f779b215c added a text property for the file as well 2021-02-04 16:45:00 +05:30
Sumit Kumar
e6b77a1299
Stop logging some AppsmithPluginException to Sentry (#2351) 
1. Move package  appsmith-interfaces/src/main/java/com/appsmith/external/pluginExceptions-> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions
2. Move enum AppsmithErrorAction from appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithError.java -> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/AppsmithErrorAction.java, so that both plugin exceptions and server exceptions could use the same enum.
3. Log exception based on the error action defined for each exception.
 2021-02-04 15:24:30 +05:30
Hetu Nandu
0332c15d56
Better handling of action error response (#2839) 2021-02-04 15:08:25 +05:30
Shrikant Sharat Kandula
5c9f90fd59
Fix missing user name in first organization name (#2873) 2021-02-04 14:04:24 +05:30
Rishabh Saxena
32b641c118
Implement new designs for the editor and viewer's navbar (#2750) 2021-02-04 12:32:36 +05:30
Rishabh Saxena
c72833b53b
Add an option to set reset the input widget's value on submit (#2837) 2021-02-04 11:21:16 +05:30
Nikhil Nandagopal
8c5213b6fd
Merge pull request #2851 from appsmithorg/fix/docs-link 
Fix/docs link
 2021-02-03 21:31:33 +05:30
Nikhil Nandagopal
486a9da8dd updated all doc links 2021-02-03 20:45:16 +05:30
Piyush Mishra
0ca5563b83
Chronological system events for developer user (#2530) 2021-02-03 18:46:48 +05:30
NandanAnantharamu
b3a75de6d3
split the test (#2799) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-03 18:08:27 +05:30
Shrikant Sharat Kandula
779c41e0d3 Merge branch 'release' 2021-02-03 17:44:23 +05:30
Nikhil Nandagopal
db9c2d6c27 Updated doc link 2021-02-03 17:28:05 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845) 
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2021-02-03 17:00:19 +05:30
Shrikant Sharat Kandula
f950a9352b
Fix datasource hostnames being saved with spaces (#2844) 2021-02-03 16:46:09 +05:30
Nikhil Nandagopal
d27865e4c9
Merge pull request #2843 from appsmithorg/fix/filepicker-name 
added file name to file picker and fixed a crash
 2021-02-03 15:10:44 +05:30
Rishabh Saxena
5da3b0165e
Prevent input component cursor getting reset using asyncControlledInput (#2802) 2021-02-03 14:52:19 +05:30
Rishabh Saxena
63c028159c
Fix manage users link not visible in the share modal when triggered from the editor or viewer (#2653) 2021-02-03 14:51:49 +05:30
Nikhil Nandagopal
f2045b5435 added file name to file picker and fixed a crash 2021-02-03 14:46:44 +05:30
Rishabh Saxena
8ae86c34e0
Fix: redirect to applications page from auth pages when the user is logged in (#2771) 2021-02-03 13:29:00 +05:30
NandanAnantharamu
7a9ec45901
Added test for invalid binding (#2777) 
* Added test for invalid binding

* Updated review comments

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-02-03 11:56:46 +05:30
Piyush Mishra
311fb5ad47
Fail client build if anything fails (#2820) 2021-02-03 11:02:00 +05:30
Hetu Nandu
bda90b4bf3
Wrap words in a toast message (#2832) 2021-02-03 10:43:55 +05:30
Shrikant Sharat Kandula
e9ba40f1f4
Analytics data point on action execution (#2740) 
* Add analytics data point on action execution

* Include application details in action exec data point

* Only send action execution event on cloud

* Analytics is auto-disabled on self-hosted setups

* Move event name to AnalyticsEvents enum

* Move analytics Mono to separate method

* Use a common function to enqueue analytics message

* Provide analytics properties from caller method

* Use consistent casing in event names for analytics
 2021-02-02 20:24:27 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789) 
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
 2021-02-02 20:12:49 +05:30
Rishabh Saxena
9d97645b3c
minor style fixes: page context menu background color (#2479) 2021-02-02 17:47:18 +05:30
prapullac
66eb08413c
Test Ideas for "Copy to Clipboard" (#2585) 
* Test Ideas for copy to Clipboard

* Adding test ideas for App viewer and admin flow

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2021-02-02 14:11:34 +05:30
Nidhi
01bbc03857
Fixed handling of lists in dynamodb (#2818) 2021-02-02 13:35:58 +05:30
Nidhi
c83fb70b95
Fixed ExecuteOnLoad not getting set for onPageLoad actions (#2801) 
* Piped onpageload update function

* Added tests
 2021-02-02 10:48:51 +05:30
Shrikant Sharat Kandula
98a0cd59b1
Fix reference types in arrays in Firestore (#2811) 
* Fix reference types in arrays in Firestore

* Added a whole bunch of tests for various data types
 2021-02-02 10:18:06 +05:30
Hetu Nandu
4505e41369
Migrate renamed canvas widgets to the correct name (#2782) 2021-02-01 20:03:13 +05:30
Abhinav Jha
3a9b328dcc
Fix: New widget and action name conflicts (#2778) 2021-02-01 20:02:43 +05:30
Abhinav Jha
51696b7220
Tab names can now be updated from the entity explorer (#2779) 2021-02-01 18:47:55 +05:30
Tim Dillon
91d5eb5860
Fix user email duplicated as name (#2787) 2021-02-01 14:51:44 +05:30
Shrikant Sharat Kandula
8475d71600
Fix RestAPI plugin not starting up (#2757) 
* Remove unneeded dependency exclusions
 2021-02-01 14:38:06 +05:30
Shrikant Sharat Kandula
018e1a94d6
Fix Firestore single document method for ref types (#2790) 2021-02-01 14:23:48 +05:30
Hetu Nandu
86cb8cac67
Allow for navigateTo urls to be of mailto or tel url schemes t (#2781) 2021-02-01 13:47:31 +05:30
Hetu Nandu
22afbe8971
Fix Array paths (#2775) 2021-01-29 09:59:23 -08:00
Piyush Mishra
164de6fb7e
Avoid double validation (#2687) 2021-01-29 11:34:28 +05:30
Dwayne Forde
f8974f1911
Fixes a small syntax issue with ./start-https.sh (#2767) 2021-01-29 09:55:51 +05:30
Arpit Mohan
433461a347
Merge pull request #2759 from appsmithorg/release 
Release v1.3.2
 2021-01-28 18:02:48 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
prapullac
4ccdba9e85
Adding manual test ideas for Home page and Login scenarios (#2627) 
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2021-01-28 14:42:22 +05:30
Piyush Mishra
c3740709d0
Do not show sections that are supposed to be hidden (#2746) 2021-01-28 14:26:29 +05:30
Rishabh Saxena
ca052e7515
minor updates for auth pages: polish UI, hide empty email error message (#2743) 2021-01-28 12:50:09 +05:30
Nidhi
c17a2ea536
Modified error displayed to user on generic bad request (#2583) 
* Modified error displayed to user on generic bad request

* Separate null check for cURL import
 2021-01-28 12:14:34 +05:30
Dwayne Forde
51ccd19081
Use IPv4 on WSL machines (#2729) 
WSL has issues when handling IPv6 ips. In order to resolve this, on dev machines, we now check if it's a WSL environment. If yes, we default to using IPv4 instead of IPv6.
 2021-01-28 12:08:44 +05:30
Rishabh Saxena
4c393f0f1f
fix: action not a plain object for widget entity name action creater (#2638) 2021-01-27 23:38:08 +05:30
Rishabh Saxena
19c4559c95
fix: datasource bound value preview in the explorer showing entire response (#2480) 2021-01-27 23:35:32 +05:30
Shrikant Sharat Kandula
b731793a88
Fix reference type fields in Firestore throwing 500 (#2718) 2021-01-27 20:38:46 +05:30
NandanAnantharamu
8358709f56
Added usecase for orgNaming convention (#2521) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-27 18:44:44 +05:30
Shrikant Sharat Kandula
350aea90c4
Revert RestAPI plugin signature timeout fix (#2748) 2021-01-27 17:24:25 +05:30
Pawan Kumar
35e66360e2
Fix: Hover highlight in entity explorer should be edge-to-edge (#2478) 
* fix merge conflicts of sumanthyedoti:fix/entity-items-hover

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-27 17:08:21 +05:30
Shrikant Sharat Kandula
63b7eb6e95
Fix signature in RestAPI plugin throwing timeout error (#2745) 
* Fix restapi signature throwing timeout error

* Add missing dependencies for restapi
 2021-01-27 14:55:08 +05:30
NandanAnantharamu
704b787435
updated action on file selected (#2691) 
* updated action on file selected

* updated common method

* Review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-27 14:37:33 +05:30
Shrikant Sharat Kandula
a6d76d1672
Fix organization slug computation clashes (#2725) 
* Fix organization slug computation clashes

* Handle case where number-less slug is available
 2021-01-27 14:35:43 +05:30
Abhinav Jha
0fa245a985
Fix issue where users could undo delete long after the timeout has expired (#2741) 2021-01-27 13:51:47 +05:30
Shrikant Sharat Kandula
6bf2be65c0
Don't attempt to get structure for invalid datasources (#2730) 2021-01-27 13:44:15 +05:30
Vicky Bansal
aa71f2ae7b
Handle invalid entity ids (#2547) 2021-01-27 12:26:19 +05:30
Vicky Bansal
5406cbee9e
Fix: Update map initial location after creating a new marker (#2736) 2021-01-27 12:25:43 +05:30
Hetu Nandu
43322413c6
Support for navigateTo function to open in new window (#2706) 
* Support target for navigate function

* Add docs and action creator field
 2021-01-27 11:58:23 +05:30
Rishabh Saxena
aea3b3d4db
Revamping UI on the Login/Signup page (#2696) 2021-01-27 11:42:32 +05:30
Vicky Bansal
e34a98833c
Trigger onPageSizeChange action when table page size changes (#2737) 2021-01-27 11:10:53 +05:30
Tim Dillon
c9b3059498
Disable sort by Delete column in Members page (#2722) 2021-01-27 00:24:50 +05:30
Piyush Mishra
9490ba4eca
Remove SSL related clicks from fillMongoDatasourceForm cypress command (#2726) 2021-01-27 00:04:19 +05:30
Shrikant Sharat Kandula
42efb20d14
Remove unused cert fields for Mongo and Postgres plugins (#2723) 2021-01-26 18:44:01 +05:30
Nidhi
6515b5c91c
Fixed null endpoint issue for MySQL plugin (#2719) 2021-01-26 17:16:31 +05:30
Hetu Nandu
40e42b296d
Fix for timeout being sent in a different location (#2708) 2021-01-26 08:42:52 +05:30
Trisha Anand
9e0f36a6f2
Improve Server thrown Error Messages' language (#2705) 
* Improve Error Messages

* Added naming convention expansion for action name in the error

* Fixed failing test case assertion.

* Minor formatting.
 2021-01-25 18:50:32 +05:30
Trisha Anand
3776e82fb8
Scheduling of parallel tasks implementation for on-page load actions (#2667) 
* Proof of concept code which calculates the on load page actions.

* Refactored the field names introduced in Layout. Added a new field to keep a track of direct action names used in dynamic bindings in the DSL.

* Untested compute on on page load actions completed.

* Working page load actions computation.
TODO : Update the tests for correctness.

* Added fix for BFS starting from root nodes instead of arbitrary nodes.
Fixed a test case to assert for correct page load actions.

* Fixed the bug where the ids of the actions were not getting set in the layout. Also asserting the same in the test case for catching the future breaks.

* Minor refactor of function name to clear its purpose without reading the code.

* Incorporated review comments.

* Added conditional checks for unpublished action deleted and circular dependency of actions depending on each other.
 2021-01-25 16:54:45 +05:30
Hetu Nandu
3f2e60dc0d
Sanitise any other possible place which could send functions (#2704) 2021-01-25 16:49:31 +05:30
Hetu Nandu
5dc01c677d
Batching widget property updates (#2685) 
- Changed the updateWidgetProperty redux action to use an object of updates instead of single update
- Added the new batchUpdateWidgetProperty action
> This action will calculate dynamicPath changes for all the updates and update them together
- Added the new deleteWidgetProperty action
>This action will delete a property and any dynamicPaths/child dynamicPaths that exist
 2021-01-25 14:27:26 +05:30
devrk96
3be4828d63
Fix: App name UI in edit and deploy mode (#2216) 2021-01-25 12:51:54 +05:30
Pawan Kumar
4f1fd68052
add check if widget is available in data tree (#2681) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-25 11:01:44 +05:30
NandanAnantharamu
536a222e1c
Uncommented few tests (#2695) 
* Uncommented few tests

* updated dsl

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-25 10:39:16 +05:30
Rishabh Saxena
e8a01c456d
product updates modal test (#2677) 2021-01-23 13:46:50 +05:30
vicky-primathon
63e286a469
Show row cursor as pointer when onRowSelected property is set in table widget (#2604) 2021-01-22 15:42:34 +05:30
vicky-primathon
c9cee45f51
Fix - Wrap contents of the table cell tooltip (#2629) 2021-01-22 15:19:02 +05:30
vicky-primathon
a309107623
Fix - Remove delete icon when there are no filters in table widget (#2605) 2021-01-22 15:17:14 +05:30
vicky-primathon
a9e0b5b678
Fix - selectedRow autocomplete suggestions when no row is selected (#2603) 2021-01-22 15:15:14 +05:30
vicky-primathon
ae276a93f8
Fix - Boolean values comparison in Table widget filters(#2586) 
- Display filter label instead of value
 2021-01-22 15:14:03 +05:30
vicky-primathon
154a4d30c9
Persist column sizes on resize in app viewer for the duration of the session (#2578) 2021-01-22 15:08:48 +05:30
vicky-primathon
64a0a44446
Remove table row alternating colors (#2552) 2021-01-22 15:07:43 +05:30
Shrikant Sharat Kandula
1e8aa62654 Merge branch 'release' 2021-01-22 14:34:58 +05:30
Shrikant Sharat Kandula
468e84aabb
Fix calls to release notes from cloud instances (#2680) 2021-01-22 14:25:24 +05:30
Hetu Nandu
d4be9b9404
Remove any functions from Eval Action bindings task before returning from the worker (#2679) 2021-01-22 13:40:00 +05:30
Trisha Anand
48cfa2cea0
In case an action has been deleted in unpublished state, dont return it to the user in edit mode. (#2678) 2021-01-22 13:19:42 +05:30
Rishabh Saxena
5ab2e194f7
update release modal styles (#2668) 2021-01-22 11:31:41 +05:30
Rishabh Saxena
57f6219d75
update styles for new updates count (#2646) 2021-01-22 11:04:37 +05:30
Rishabh Saxena
64a90a6767
enable immer autofreeze only in development (#2669) 2021-01-22 10:50:55 +05:30
dependabot[bot]
41690e2d61
Bump immer from 7.0.9 to 8.0.1 in /app/client (#2659) 
Bumps [immer](https://github.com/immerjs/immer) from 7.0.9 to 8.0.1.
- [Release notes](https://github.com/immerjs/immer/releases)
- [Commits](https://github.com/immerjs/immer/compare/v7.0.9...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-21 19:00:44 +05:30
Shrikant Sharat Kandula
317fa1e59c Remove duplicate function definition 2021-01-21 17:43:41 +05:30
Shrikant Sharat Kandula
95250cf955 Merge branch 'release' 
# Conflicts:
#	app/client/src/constants/messages.ts
#	app/client/src/sagas/ErrorSagas.tsx
 2021-01-21 17:16:33 +05:30
Pawan Kumar
f059e40484
Fix - RichTextEditor test by increasing wait time (#2666) 
* remove default action function in messages file

* revert getErrorMessageFromActionType comment

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-21 16:38:18 +05:30
Arpit Mohan
8ba4db6a96 Commenting out the test for RTE because it's failing even though the widget is operating properly 
The test needs to be fixed
 2021-01-21 14:58:00 +05:30
Hetu Nandu
4014e523db Never show the redux action type in toast errors (#2635) 2021-01-21 12:17:04 +05:30
Hetu Nandu
4021b210b1
Never show the redux action type in toast errors (#2635) 2021-01-21 12:12:53 +05:30
Shrikant Sharat Kandula
6b406be39e
Fetch release notes for caching every two hours (#2657) 
* Fetch release notes for caching every two hours

* Revert unrelated changes in Ping class
 2021-01-21 11:59:35 +05:30
Rishabh Saxena
628ac6953f
Scroll to created org (#2477) 2021-01-21 11:49:06 +05:30
dependabot[bot]
e781ceb30a
Bump jackson-databind in /app/server/appsmith-interfaces (#2652) 
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.10.5 to 2.9.10.7.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-21 10:48:01 +05:30
Shrikant Sharat Kandula
52c689efee
Add a migration to fix any remembered versions (#2651) 
* Add a migration to fix any remembered versions

* Drop the userData collection instead
 2021-01-21 07:39:41 +05:30
hetunandu
7f713b3def uncomment RTE tests 2021-01-20 16:53:58 +05:30
hetunandu
ee985af3d2 Merge branch 'release' 2021-01-20 16:48:30 +05:30
hetunandu
a478fcb149 Temporary comment RTE tests 2021-01-20 16:48:02 +05:30
Shrikant Sharat Kandula
63fb249e40 Merge branch 'release' 
# Conflicts:
#	app/client/cypress/integration/Smoke_TestSuite/Onboarding/Onboarding_spec.js
#	app/client/src/components/editorComponents/Onboarding/Tooltip.tsx
#	app/client/src/constants/OnboardingConstants.tsx
#	app/client/src/pages/Editor/Welcome.tsx
#	app/client/src/sagas/ActionExecutionSagas.ts
#	app/client/src/sagas/OnboardingSagas.ts
 2021-01-20 15:49:56 +05:30
Rishabh Saxena
d2dfd75a0c
use editor init event intead of setup to check if initialised (#2622) 2021-01-20 11:00:53 +05:30
Shrikant Sharat Kandula
d4990683c6
Fix UI for documentation modal (#2631) 2021-01-19 22:01:35 +05:30
Rishabh Saxena
cf2e5ce9d1
fix: use popover for ads dropdown options (#2628) 2021-01-19 19:42:00 +05:30
Rishabh Saxena
20d315b527
check for empty releases (#2619) 2021-01-19 14:48:32 +05:30
Rishabh Saxena
3aa268174d
use script loader for tinymce (#2620) 2021-01-19 14:24:50 +05:30
NandanAnantharamu
4d556754e5
Fixes for Filepicker test flakiness (#2616) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-19 14:21:16 +05:30
Rishabh Saxena
8e459a0c6b
validate map center and markers (#2488) 2021-01-19 12:59:15 +05:30
Rishabh Saxena
969b6fd0d2
Product updates modal (#2453) 2021-01-19 11:47:15 +05:30
Shrikant Sharat Kandula
9ead9af5f6
Respond with empty string when no new versions (#2618) 2021-01-19 11:37:31 +05:30
Shrikant Sharat Kandula
f6845486d2
Handle snapshot versions as special (#2617) 
This is needed for remembering when a user has viewed
release notes. Snapshot versions aren't a tagged marker
on the version timeline so aren't useful for this purpose.
 2021-01-19 08:24:56 +05:30
abhishek nayak
c911bd183c
Merge pull request #2613 from appsmithorg/chart-widget-example 
Update ChartDataControl.tsx
 2021-01-19 01:19:26 +05:30
Shrikant Sharat Kandula
3dc6f1107b
Send repo information when fetching release notes (#2615) 2021-01-18 21:21:22 +05:30
abhishek nayak
4048b81b2e
Update ChartDataControl.tsx 2021-01-18 18:47:50 +05:30
Shrikant Sharat Kandula
04d4812fc9
Fix getting release notes always resulting empty (#2609) 2021-01-18 15:21:50 +05:30
Nidhi
e6a0b00a25
Added Oauth2 functionality for REST APIs (#2509) 
* Added Oauth2 functionality for REST APIs

* Encrypted response

* Missed file

* Review comments and tests

* Removed broken test
 2021-01-15 16:41:13 +05:30
akash-codemonk
6b8e3d7dd5
Onboarding changes (#2549) 
- Reduce the delay for the deploy modal to 1s.
- Separate ONBOARDING_ADD_WIDGET from ONBOARDING_ADD_WIDGET_CLICK event
- Add step metadata for skip onboarding event
- Improve the contrast for the add widget button
 2021-01-15 14:49:15 +05:30
Hetu Nandu
11766c0e4a
Action onPageLoad test fix (#2581) 2021-01-15 11:08:53 +05:30
Hetu Nandu
2b8bae158c
Batch action evaluation calls (#2561) 2021-01-14 20:07:21 +05:30
Hetu Nandu
8cff9bd9b9
Avoid evaluation for unnecesarry batch success calls (#2579) 2021-01-14 16:45:25 +05:30
NandanAnantharamu
9f2fbf13c8
Cypress upgrade to 6.2.1 (#2535) 
* Cypress upgrade to 6.2.1

* Replaced route and server and assertions

* Removed intercept as it involves changes with alias

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-14 11:14:07 +05:30
NandanAnantharamu
d1d70b8b5c
Updated mongodatasource tests (#2567) 
* Updated mongodatasource tests

* Commented assertion for test datasource and updated query test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-13 21:34:23 +05:30
Hetu Nandu
5310908cea
Handle action failure of on page load actions (#2554) 2021-01-13 17:17:41 +05:30
Hetu Nandu
42aa83a729
Selectively add paths to dependency map and evaluation order (#2537) 2021-01-13 16:22:03 +05:30
Hetu Nandu
c184fd3d3c
Remove deleted paths from evaluation order (#2517) 2021-01-13 16:21:46 +05:30
Arpit Mohan
36a47631ba Merge branch 'release' of github.com:appsmithorg/appsmith into release 2021-01-13 15:41:52 +05:30
Arpit Mohan
5860b1b2ab Adding the init dump SQL file for PostgreSQL database 
This is used when running the Cypress tests
 2021-01-13 15:41:39 +05:30
Hetu Nandu
d3e517ecb2
Fix for tabs widget getting the same name (#2538) 
Co-authored-by: Piyush <piyush@codeitout.com>
 2021-01-13 15:40:28 +05:30
akash-codemonk
09c4e4fc49 Onboarding deploy tooltip fix (#2490) 2021-01-13 15:27:53 +05:30
akash-codemonk
44e300ec45 Onboarding fixes (#2458) 2021-01-13 15:27:45 +05:30
akash-codemonk
b5a1c93f09 Open the already opened tab if it exists when clicking on deploy (#2448) 2021-01-13 15:27:37 +05:30
akash-codemonk
6e4cdb0f84 Hide other header elements while showing the deploy button 2021-01-13 15:27:29 +05:30
akash-codemonk
1e17c03478 Fix onboarding test failure causing other tests to fail (#2417) 2021-01-13 15:27:15 +05:30
Trisha Anand
91b8922f1c
In case cs service returns an error, stop processing release notes and resume with the caller flow. (#2550) 
* In case cs service returns an error, stop processing release notes and resume with the caller flow.

* In case the server was unable to exchange messages with the CS server, bail out of further processing gracefully since this is not a must have but rather a good to have feature.
 2021-01-13 14:30:23 +05:30
Arpit Mohan
2135a4a0e8 Dummy commit to trigger the build 2021-01-13 13:39:24 +05:30
Nidhi
9ea5c884e1
Null check for empty pagination next url (#2546) 2021-01-13 12:12:29 +05:30
Rishabh Saxena
a2528286a3
bump blueprint core to 3.36 for using async control prop (#2491) 2021-01-13 10:53:16 +05:30
Trisha Anand
c24bc826e0
When an application name is changed, the isPublic flag is reset to false. (#2539) 2021-01-12 20:06:33 +05:30
Shrikant Sharat Kandula
c6c128270c
Include version information when building Docker images for server and client (#2200) 
* Include version information in backend builds

* Enable manual trigger of server workflow

* Add a dummy input field for manual trigger

* Fix secret checking in github actions

* Disable cron scheduling of sync job

* Build docker image on pushing a version tag

* Fix duplicated id and invalid id in release workflow

* Don't try to login to Docker

* Avoid download progress outputs from Maven

* Add version information for building client

* Calculate version number only once

* Enable push to DockerHub after building images

* Use Docker username from GitHub secrets

* Fix Docker username in tags when building image

* Use different secret for org name

* Minor refactoring in server workflow

* Update client build workflow to use version

* Enable manual triggering of client workflow

* Set snapshot version for server builds

* Push to docker for all branches (temp)

* Undo temp change to push all branches to DockerHub

* Use Docker org from secrets in client.yml

* Fix missing version reference in client.yml

* Remove debug command in dockerfile

* Save release notes in a resource file in Docker image

* Fix query serialization to get release notes

* Get releases of current repo instead of hard-coded repo

* Fix variable quoting for repo variables

* Exclude draft and prerelease nodes from image

* Fix call to any in release notes processor

* Fix syntax error in release notes script

* Implement API to get new release count and info

* Add missing ReleaseNotes component

* Have the release workflow run after a release is created

* Build server after generating release notes

* Change release trigger to "released"

* Change release trigger to "published"

* Change release trigger to released, edited and deleted

* Use JS script to get release notes, take 1

* Filter drafts and prereleases in script

* Fix syntax error in ES6

* Write release notes to file

* Create parent directory before writing release notes

* Log cwd in release notes script

* Log pwd along with release-notes content

* Handle case where working directory is incorrect

* Remove shell based release notes generator

* Don't show error when Sentry config is missing

* Check for sentry auth token to enable Sentry

* Carry build's exit code over to CI

* Mark out build result and add a note about it

* Add a small test to verify new versions computation

* Remove incorrect test assertion

* Remove generation of release notes file

* Connect to cloud services to fetch release notes data

* Fix missing runner for test class

* Handle missing cloud_services base URL

* Fix test failures due to missing mocks

* Enable sync-ee cron job

* Revert build.sh as there's no real change

* Add API to update release notes viewed version for users

* Fix prettier line-length errors

* Create UserData model for info unrelated to auth

* Fix field name calls

* Ensure we have a userId before setting userData

* Add tests for setting version number in UserData

* Include instanceId when fetching release notes
 2021-01-12 18:15:15 +05:30
Shrikant Sharat Kandula
4fc6a7e763
Disable welcome email with an environment variable (#2527) 2021-01-12 16:50:26 +05:30
Shrikant Sharat Kandula
e4ba991114
Remove unused API endpoints for invite confirmation (#2532) 2021-01-12 16:20:48 +05:30
Trisha Anand
88e8723f37
Adding id and pluginType correctly for a user set on page load action (non referenced in the DSL) (#2523) 2021-01-12 14:39:53 +05:30
Hetu Nandu
f53af44316
Make first eval after page change happen with new layout first (#2516) 2021-01-12 14:34:34 +05:30
Shrikant Sharat Kandula
23cffc208f
Allow signup for admins, even if publicly disabled (#2520) 
* Allow signup for admins, even if publicly disabled

* Use Set for admin email addresses

* Set two admin emails in test
 2021-01-12 14:13:44 +05:30
Hetu Nandu
94cae231c1
Make sure Table selected row is not set to undefined on mount (#2518) 2021-01-12 11:45:08 +05:30
Piyush Mishra
148497a1bc
Refactor datasources and actions for stronger type checking (#2167) 2021-01-12 09:47:28 +05:30
Piyush Mishra
1521f7445c
Fix eslint warnings (#2510) 2021-01-12 06:52:31 +05:30
Shrikant Sharat Kandula
9cd9edd3fa
Disable uninvited signups via environment variable (#2512) 
* Disable signup API via environment variable

* Allow signup for invited users, even if disabled publicly

* Add test for signup when signup is disabled

* Run invite flow tests when signup is disabled

* Revert status annotation in signup API endpoint

* Remove unused tests on invite flow

* Change signup disabled error message
 2021-01-11 20:10:50 +05:30
Trisha Anand
6704e05ad0
Sub tree fixes for issues found on Jarvis (#2482) 2021-01-11 13:26:17 +05:30
Nidhi
1fa7d46845
Fixed unreferenced actions not being triggered for execute on load (#2434) 
* Fixed unreferenced actions not being triggered for execute on load

* WIP : Have to commit some minor cosmetic code formatting changes

* Comments and fix for action ordering

* modified test case

Co-authored-by: Trisha Anand <trisha@appsmith.com>
 2021-01-11 12:18:07 +05:30
Rishabh Saxena
c36b6b640f
auto focus create org input field (#2493) 2021-01-11 11:14:54 +05:30
Pawan Kumar
fcac402789
Fix - 502 in save layout is abruptly taking me to an error screen (#2475) 
* remove crash:true in api + add error icon on page save

* remove crash true in api

* add crash on user init request fail

* dispatch safe crash action on user init call error

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-11 10:58:10 +05:30
akash-codemonk
d82d8965e4
Onboarding deploy tooltip fix (#2490) 2021-01-11 09:46:59 +05:30
Nikhil Nandagopal
4666f40a21
Merge pull request #2489 from appsmithorg/fix/analytics 
added appmode analytics to the execute action
 2021-01-08 14:53:04 +05:30
NandanAnantharamu
06ecc106d6
Using Cypress wait instead of postExecute for Table binding test (#2249) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-08 14:11:23 +05:30
Nikhil Nandagopal
a435133bdf added appmode analytics to the execute action 2021-01-08 13:06:22 +05:30
akash-codemonk
bad63f9e68
Onboarding fixes (#2458) 2021-01-08 11:36:09 +05:30
dependabot[bot]
0ab61079e2
Bump axios from 0.19.2 to 0.21.1 in /app/server/scripts/node (#2462) 
Bumps [axios](https://github.com/axios/axios) from 0.19.2 to 0.21.1.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md)
- [Commits](https://github.com/axios/axios/compare/v0.19.2...v0.21.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2021-01-07 17:38:24 +05:30
Trisha Anand
d1d73070f4 Adding action execution time and logging the same (#2473) 2021-01-07 14:10:22 +05:30
Trisha Anand
527bac0827
Adding action execution time and logging the same (#2473) 2021-01-07 13:49:50 +05:30
imgbot[bot]
ec115967f5
[ImgBot] Optimize images (#2384) 
*Total -- 1,492.69kb -> 1,218.88kb (18.34%)

/static/form.png -- 651.09kb -> 517.01kb (20.59%)
/static/editor.png -- 694.01kb -> 555.61kb (19.94%)
/static/appsmith_logo_white.png -- 4.91kb -> 4.31kb (12.23%)
/app/client/src/assets/icons/ads/app-icons/bar-graph.svg -- 0.54kb -> 0.51kb (4.18%)
/app/client/src/assets/icons/ads/app-icons/team.svg -- 1.03kb -> 1.00kb (3.12%)
/app/client/src/assets/icons/ads/app-icons/line-chart.svg -- 0.88kb -> 0.86kb (2.77%)
/app/client/src/assets/icons/ads/app-icons/email.svg -- 0.25kb -> 0.24kb (2.73%)
/app/client/src/assets/icons/ads/app-icons/single-person.svg -- 0.69kb -> 0.68kb (1.97%)
/app/client/src/assets/icons/ads/app-icons/airplane.svg -- 1.18kb -> 1.16kb (1.82%)
/app/client/src/assets/icons/ads/app-icons/family.svg -- 1.52kb -> 1.49kb (1.8%)
/app/client/src/assets/icons/ads/app-icons/hospital.svg -- 0.41kb -> 0.41kb (1.65%)
/app/client/src/assets/icons/ads/app-icons/pants.svg -- 0.45kb -> 0.44kb (1.52%)
/app/client/src/assets/icons/ads/app-icons/call.svg -- 0.67kb -> 0.66kb (1.46%)
/app/client/src/assets/icons/ads/app-icons/lotus.svg -- 1.35kb -> 1.33kb (1.3%)
/app/client/src/assets/icons/ads/app-icons/lightning.svg -- 0.78kb -> 0.77kb (1.25%)
/app/client/src/assets/icons/ads/app-icons/hat.svg -- 0.55kb -> 0.54kb (1.24%)
/app/client/src/assets/icons/ads/app-icons/couples.svg -- 1.50kb -> 1.48kb (1.23%)
/app/client/src/assets/icons/ads/app-icons/mug.svg -- 0.56kb -> 0.55kb (1.23%)
/app/client/src/assets/icons/ads/app-icons/sunflower.svg -- 1.15kb -> 1.13kb (1.19%)
/app/client/src/assets/icons/ads/app-icons/website.svg -- 1.83kb -> 1.81kb (1.12%)
/app/client/src/assets/icons/ads/app-icons/diamond.svg -- 0.63kb -> 0.62kb (1.09%)
/app/client/src/assets/icons/ads/app-icons/money.svg -- 1.18kb -> 1.17kb (1.07%)
/app/client/src/assets/icons/ads/app-icons/headphones.svg -- 0.84kb -> 0.83kb (1.04%)
/app/client/src/assets/icons/ads/app-icons/bus.svg -- 2.09kb -> 2.07kb (1.03%)
/app/client/src/assets/icons/ads/app-icons/pie-chart.svg -- 0.96kb -> 0.95kb (1.02%)
/app/client/src/assets/icons/ads/app-icons/shirt.svg -- 0.67kb -> 0.67kb (1.02%)
/app/client/src/assets/icons/ads/app-icons/smartphone.svg -- 0.68kb -> 0.68kb (1%)
/app/client/cypress/fixtures/appsmithlogo.png -- 1.97kb -> 1.96kb (0.99%)
/app/client/src/assets/icons/ads/app-icons/music.svg -- 0.74kb -> 0.73kb (0.93%)
/app/client/src/assets/icons/ads/app-icons/rocket.svg -- 1.55kb -> 1.54kb (0.88%)
/app/client/src/assets/icons/ads/app-icons/medical.svg -- 0.57kb -> 0.56kb (0.86%)
/app/client/src/assets/icons/ads/app-icons/plant.svg -- 1.06kb -> 1.05kb (0.83%)
/app/client/src/assets/icons/ads/app-icons/love.svg -- 0.83kb -> 0.82kb (0.82%)
/app/client/src/assets/icons/ads/app-icons/repeat.svg -- 0.76kb -> 0.75kb (0.78%)
/app/client/src/assets/icons/ads/app-icons/bird.svg -- 1.15kb -> 1.14kb (0.77%)
/app/client/src/assets/icons/ads/app-icons/car.svg -- 1.79kb -> 1.78kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/coding.svg -- 0.51kb -> 0.51kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/rose.svg -- 1.29kb -> 1.28kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/system.svg -- 1.03kb -> 1.02kb (0.76%)
/app/client/src/assets/icons/ads/app-icons/tree.svg -- 0.95kb -> 0.94kb (0.72%)
/app/client/src/assets/icons/ads/app-icons/card.svg -- 1.22kb -> 1.21kb (0.72%)
/app/client/src/assets/icons/ads/app-icons/cricket.svg -- 0.96kb -> 0.95kb (0.71%)
/app/client/src/assets/icons/ads/app-icons/yen.svg -- 0.99kb -> 0.99kb (0.69%)
/app/client/src/assets/icons/ads/app-icons/location.svg -- 1.00kb -> 1.00kb (0.68%)
/app/client/src/assets/icons/ads/app-icons/laptop.svg -- 0.72kb -> 0.71kb (0.68%)
/app/client/src/assets/icons/ads/app-icons/rupee.svg -- 1.04kb -> 1.04kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/medal.svg -- 1.05kb -> 1.04kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/shop.svg -- 1.96kb -> 1.94kb (0.65%)
/app/client/src/assets/icons/ads/app-icons/cat.svg -- 1.60kb -> 1.59kb (0.61%)
/app/client/src/assets/icons/ads/app-icons/dog.svg -- 2.11kb -> 2.09kb (0.6%)
/app/client/src/assets/icons/ads/app-icons/bicycle.svg -- 1.46kb -> 1.46kb (0.6%)
/app/client/src/assets/icons/ads/app-icons/basketball.svg -- 1.52kb -> 1.51kb (0.58%)
/app/client/src/assets/icons/ads/app-icons/flag.svg -- 1.22kb -> 1.22kb (0.56%)
/app/client/src/assets/icons/ads/app-icons/euros.svg -- 1.24kb -> 1.23kb (0.55%)
/app/client/src/assets/icons/ads/app-icons/stars.svg -- 1.20kb -> 1.19kb (0.49%)
/app/client/src/assets/icons/ads/app-icons/chat.svg -- 1.49kb -> 1.49kb (0.46%)
/app/client/src/assets/icons/ads/app-icons/restaurant.svg -- 1.52kb -> 1.52kb (0.45%)
/app/client/src/assets/icons/ads/app-icons/saturn.svg -- 1.59kb -> 1.58kb (0.43%)
/app/client/src/assets/icons/ads/app-icons/moon.svg -- 1.65kb -> 1.65kb (0.41%)
/app/client/src/assets/icons/ads/app-icons/chinese-remnibi.svg -- 1.69kb -> 1.68kb (0.4%)
/app/client/src/assets/icons/ads/app-icons/burger.svg -- 2.77kb -> 2.76kb (0.39%)
/app/client/src/assets/icons/ads/app-icons/earth.svg -- 1.87kb -> 1.86kb (0.37%)
/app/client/src/assets/icons/ads/app-icons/joystick.svg -- 1.98kb -> 1.97kb (0.35%)
/app/client/src/assets/icons/ads/app-icons/steam-bowl.svg -- 2.95kb -> 2.94kb (0.33%)
/app/client/src/assets/icons/ads/app-icons/alien.svg -- 1.27kb -> 1.27kb (0.31%)
/app/client/src/assets/icons/ads/app-icons/uk-pounds.svg -- 2.33kb -> 2.32kb (0.29%)
/app/client/src/assets/icons/ads/app-icons/dollar.svg -- 2.59kb -> 2.58kb (0.26%)
/app/client/src/assets/icons/ads/app-icons/pizza.svg -- 1.86kb -> 1.86kb (0.26%)
/app/client/src/assets/icons/ads/app-icons/bitcoin.svg -- 2.75kb -> 2.74kb (0.25%)
/app/client/src/assets/icons/ads/app-icons/rainy-weather.svg -- 8.28kb -> 8.27kb (0.15%)
/app/client/src/assets/icons/ads/app-icons/shake-hands.svg -- 4.62kb -> 4.61kb (0.15%)
/app/client/src/assets/icons/ads/app-icons/football.svg -- 4.93kb -> 4.92kb (0.14%)
/app/client/src/assets/icons/ads/app-icons/snowy-weather.svg -- 8.34kb -> 8.33kb (0.12%)
/app/client/src/assets/icons/ads/app-icons/server.svg -- 9.10kb -> 9.10kb (0.08%)
/app/client/src/assets/icons/ads/app-icons/cloud.svg -- 23.21kb -> 23.20kb (0.03%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2021-01-07 11:23:35 +05:30
NandanAnantharamu
523e3ec397
flaky test updated (#2468) 
* flaky test updated

* updated another flaky test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-07 10:37:17 +05:30
Hetu Nandu
cb2dd3c9da
Handle for scenarios scrollTo is not available in browser (#2456) 2021-01-07 10:36:25 +05:30
prapullac
7309e91153
Added test for Datasource associated with API (#2336) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2021-01-07 10:32:26 +05:30
Hetu Nandu
2943f7f782
Copy Text trigger function (#2394) 2021-01-07 10:14:30 +05:30
Sumit Kumar
4748014cee
Redshift plugin (#2440) 
* introduce redshift plugin
 2021-01-06 17:51:07 +05:30
Pawan Kumar
6fa31e6388
Fix - Lodash import typo (#2466) 
* add redirect issue

* add check for crash code

* redirect anonymous user to login page

* remove unused selector

* move redirection logic to error saga level

* update action type name

* replace occurance of redirectTo to redirectUrl

* remove unused selector in PagenoutFound + change saga name

* fix improt typo

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-06 17:31:04 +05:30
Trisha Anand
bd011c45ab
Removed unused organization setting, setting class, and query class. (#2464) 2021-01-06 17:30:09 +05:30
Pawan Kumar
563c32d203
[Fix] - Authentication after 404 not redirecting back to the original page (#2423) 
* add redirect issue

* add check for crash code

* redirect anonymous user to login page

* remove unused selector

* move redirection logic to error saga level

* update action type name

* replace occurance of redirectTo to redirectUrl

* remove unused selector in PagenoutFound + change saga name

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-06 16:54:16 +05:30
Rishabh Saxena
affb68ee52
Fix widths for pagination test and modal confirm btns (#2445) 2021-01-06 16:39:08 +05:30
Hetu Nandu
eb1f9e7ec8
Update axios package (#2454) 2021-01-06 13:58:49 +05:30
Pawan Kumar
51076eaead
Fix: Show appropriate error message when an onPageLoad action fails (#2355) 
* show action in toast error message on pageload error

* add test case

* add error body in toast

* fix test case

* fix test case

* update test case

* uncomment test case

* remove the console log

* remove unused console

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2021-01-06 10:55:47 +05:30
akash-codemonk
8d303d3d9f
Open the already opened tab if it exists when clicking on deploy (#2448) 2021-01-06 09:38:46 +05:30
akash-codemonk
f5e696a4f4
Hide other header elements while showing the deploy button 2021-01-06 09:38:18 +05:30
Trisha Anand
db2b002ac7 Increased logs to debug future connection leaks. (#2437) 
* Increased logs to debug future connection leaks.

* Fetch a connection from the pool only if a query exists.

* Minor comment added.

* Minor rewrite

* Code formatting.

* Update app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Added hikari cp pool stats to get database structure function as well.

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
 2021-01-05 18:39:36 +05:30
Nidhi
de5003a98e
Added type parameter for REST API plugin, and changes for no auth (#2438) 
* Added type parameter for REST API plugin, and changes for no auth

* Removed logs

* Converted to reactive
 2021-01-05 17:59:50 +05:30
Hetu Nandu
45918bfd33 Fix invalid toast message for evaluation error (#2443) 
Fixes #2432
Fixes: #2429


Co-authored-by: Piyush Mishra <piyush@codeitout.com>
 2021-01-05 17:16:51 +05:30
Hetu Nandu
1598899dd6
Fix invalid toast message for evaluation error (#2443) 
Fixes #2432
Fixes: #2429


Co-authored-by: Piyush Mishra <piyush@codeitout.com>
 2021-01-05 17:15:37 +05:30
Trisha Anand
d5074ee7f7
Increased logs to debug future connection leaks. (#2437) 
* Increased logs to debug future connection leaks.

* Fetch a connection from the pool only if a query exists.

* Minor comment added.

* Minor rewrite

* Code formatting.

* Update app/server/appsmith-plugins/postgresPlugin/src/main/java/com/external/plugins/PostgresPlugin.java

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>

* Added hikari cp pool stats to get database structure function as well.

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
 2021-01-05 15:34:55 +05:30
Rishabh Saxena
2629ead4b7
fix: check for undefined error action payload (#2428) 2021-01-05 12:12:04 +05:30
akash-codemonk
69cd988c01
Fix onboarding test failure causing other tests to fail (#2417) 2021-01-04 15:52:22 +05:30
Hetu Nandu
4387200262
Sub tree evaluation (#1841) 
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Piyush Mishra <piyush@codeitout.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
 2021-01-04 15:46:08 +05:30
NandanAnantharamu
4c5387f707
updated assertion (#2419) 
* updated assertion

* review comment incoirporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2021-01-04 12:59:21 +05:30
Trisha Anand
214f911060 Fixed merge conflict related build failure. 2021-01-04 11:24:00 +05:30
Trisha Anand
24ef325467
Merge branch 'master' into release 2021-01-04 11:18:13 +05:30
Trisha Anand
e17da5f913 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2021-01-01 01:24:55 +05:30
Trisha Anand
a3378397d7 Increasing pool size to 20 to reduce the number of times datasource becomes unusable. Symptomatic relief till I can solve for this at leisure over the next few days. 
Note : Update/Insert are leading to connection leak
 2021-01-01 01:24:26 +05:30
Pawan Kumar
9d0c6d5359
fix datetimepicker max date issue (#2407) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-31 17:54:50 +05:30
Piyush Mishra
3d7242d716
Cleanup cancelled requests (#2387) 2020-12-30 18:56:44 +05:30
Rishabh Saxena
611186c4b2
set min pageSize for table widget (#2362) 2020-12-30 18:32:46 +05:30
Rishabh Saxena
c344377a9d
only autofocus widget search (#2400) 2020-12-30 18:32:11 +05:30
Hetu Nandu
31d8c8c4eb
[Worker] Fix critical issues (#2393) 2020-12-30 18:28:57 +05:30
Trisha Anand
d4640e01a2
Invite users once triggered should not be cancellable. (#2401) 
* Invite users once triggered should not be cancellable.
 2020-12-30 16:50:01 +05:30
Rishabh Saxena
6dd97a6f09
fix stacking order of popover and app header (#2338) 2020-12-30 14:36:24 +05:30
Rishabh Saxena
f1f9441cc6
auto focus search input (#2360) 2020-12-30 14:33:24 +05:30
akash-codemonk
1a35bb1e75
Onboarding flow (#2311) 2020-12-30 13:01:20 +05:30
Piyush Mishra
5ae2da1578
Send clean validated tree back (#2376) 2020-12-29 23:57:07 +05:30
Rishabh Saxena
37d0314c2a
default error code (#2363) 2020-12-29 22:22:31 +05:30
Rishabh Saxena
14effe6db1
fix del hotkey (#2349) 2020-12-29 22:21:57 +05:30
Rishabh Saxena
ccd9371820
update tooltip test (#2392) 2020-12-29 19:50:14 +05:30
Trisha Anand
712f41db92
Reducing the probability of getting pages out of order (Expected order is the order in which the pages were created and added to the application). This should : (#2391) 
1. Get rid of cypress test failures which asserts a certain order till the cypress test case is fixed and unblocks the frontend team.
2. Uses a bulk API to fetch all the pages instead of fetching each page sequentially over different network calls with the database.
 2020-12-29 19:10:01 +05:30
Rishabh Saxena
13fae1a5c1
fix test (#2390) 2020-12-29 17:45:15 +05:30
Trisha Anand
ea366b1d29 Fixed NPE in database migration 2020-12-29 17:06:30 +05:30
Trisha Anand
735a4398b2
Added a migration to old rest api datasources which adds the new mandatory key isSendSessionEnabled with value N (#2388) 2020-12-29 16:29:28 +05:30
Rishabh Saxena
e526f5cca5
minox css fixes (#2375) 2020-12-29 16:17:32 +05:30
Hetu Nandu
b5e8673921
Properly log data tree instrumentation (#2228) 2020-12-29 14:55:56 +05:30
Trisha Anand
ea0f9c159c
[Bug] Multi page applications return only a single page when fetching pages per application (#2383) 
* Zipping flux with mono leads to mono not getting repeated and only the first emitted value of flux is processed further. This is leading to only a single page getting emitted in a multi page application.

* Added a test case to assert this for a multi page application
 2020-12-29 13:38:47 +05:30
Trisha Anand
a70b95be37 Adding leak detection to hikari pool. Would be tracking this on logdna to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374) 2020-12-28 18:29:50 +05:30
Trisha Anand
051d3c6c7f
Adding leak detection to hikari pool. Would be tracking this on logdna to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374) 2020-12-28 18:26:33 +05:30
Piyush Mishra
988ebe975b
RPC-like layer with graceful startup and shutdown around a webworker (#2252) 2020-12-28 14:12:43 +05:30
Sumit Kumar
6299c86f39
Add TC to test mongodb connection establishment (#2364) 
1. Test that when a query is attempted to run on mongodb server but refused because of lack of authorization, then
also, it indicates a successful connection establishment.
 2020-12-28 11:58:17 +05:30
dependabot[bot]
45497ba5ac
Bump node-notifier from 8.0.0 to 8.0.1 in /app/client (#2316) 
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-28 10:55:39 +05:30
Trisha Anand
6210b9a0c0
All newly created applications now have a default published state. (#2309) 
* All newly created applications now have a default published state.

* Added a test case to assert a new application comes up with default published states for both application and the default page.

* Function name changed.

* When trying to fetch a published version of a page when the page has not been published, throw a 404.

* WIP : Not working
 2020-12-28 10:30:43 +05:30
Piyush Mishra
ebcffadca1
Prettier fixes (#2366) 2020-12-28 09:47:50 +05:30
Piyush Mishra
8ef8bfd2ac
Prettier fix. (#2353) 2020-12-24 19:01:09 +05:30
akash-codemonk
466d0cfde1
Fix explorer entity icon alignment (#1413) 2020-12-24 15:41:02 +05:30
Rishabh Saxena
83349e2996
fix modal entity not renamed through property pane when closed by clicking on the overlay (#2185) 2020-12-24 11:43:01 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Piyush Mishra
3930c4c63c
Hotfix circularJSON (#2214) 2020-12-23 19:48:46 +05:30
Shrikant Sharat Kandula
85350b2940 Add migration to set isEncrypted field where missing (#2332) 
(cherry picked from commit d5e0fb18d8)
 2020-12-23 18:07:35 +05:30
Shrikant Sharat Kandula
4ff2834559 Missing isEncrypted should mean a true value 
(cherry picked from commit c7f330c4c7)
 2020-12-23 18:07:35 +05:30
Rishabh Saxena
4e802d2c5a
reset query on select, don't jump to active item (#2237) 2020-12-23 17:45:14 +05:30
Rishabh Saxena
396b12b024
reorder widgets alphabetically, autofocus search input (#2325) 2020-12-23 17:02:30 +05:30
Rishabh Saxena
fb7ae53002
set the first tab as selected when the selected tab is not found (#2231) 2020-12-23 16:59:34 +05:30
Rishabh Saxena
778b82f9ae
enable hotkeys only when a widget is selected (#2262) 2020-12-23 16:58:29 +05:30
Rishabh Saxena
77801b10ff
fix undo delete tab, create copy of tabs array (#2315) 2020-12-23 16:55:52 +05:30
Rishabh Saxena
9417335176
render column submenu popover inline (#2329) 2020-12-23 16:55:25 +05:30
Shrikant Sharat Kandula
d5e0fb18d8
Add migration to set isEncrypted field where missing (#2332) 2020-12-23 15:35:45 +05:30
Shrikant Sharat Kandula
c7f330c4c7 Missing isEncrypted should mean a true value 2020-12-23 14:23:03 +05:30
a
61e12235b2 Revert "reorder widget locale wise, autofocus search input" 
This reverts commit 0bcc8872eb.
 2020-12-23 11:08:52 +05:30
a
0bcc8872eb reorder widget locale wise, autofocus search input 2020-12-23 11:01:00 +05:30
vicky-primathon
6b6e302ee1
Fix Table data validation issues (#2297) 2020-12-23 09:47:13 +05:30
vicky-primathon
bf5693f907
Reset table selected row when table data changes (#2307) 2020-12-23 09:28:23 +05:30
Sumit Kumar
53a6160139
Revert "Redshift plugin (#2112)" (#2314) 
This reverts commit 708ca7fedf.
 2020-12-22 16:59:18 +05:30
Sumit Kumar
708ca7fedf
Redshift plugin (#2112) 
1. Add new plugin to connect to AWS Redshift cluster and run query.
2. Add unit test cases.
 2020-12-22 15:35:25 +05:30
prapullac
91125ebc26
Manual test Ideas for home page (#2208) 2020-12-22 14:06:52 +05:30
Arpit Mohan
a942dc198e Revert "Onboarding flow (#1960)" 
This reverts commit e84699e7ba.

Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
 2020-12-22 13:02:02 +05:30
Shrikant Sharat Kandula
ea6e897dde
Firestore ADD_TO_COLLECTION command support (#2305) 
* Support ADD_TO_COLLECTION operation on Firestore

* Add test for Firestore add-to-collection command
 2020-12-22 12:32:14 +05:30
vicky-primathon
567f3a16fb
Fixed accessing length property of undefined selectedRowIndices (#2293) 
* Fixed accessing length property of undefined selectedRowIndices

* Added getting selectedRowIndices when multiRowSelection is true
 2020-12-22 08:27:57 +05:30
Shrikant Sharat Kandula
cfcd7aa0bb
Fix Firestore datasources not encrypting secret key JSON when editing (#2296) 
* Fix encrypted field not being ignored in JSON

* Don't mask error in decrypting

* Revert masking of error in decrypting
 2020-12-21 17:43:15 +05:30
Rishabh Saxena
42173e9249
fix tooltip boundary, don't show on target focus (#2250) 2020-12-21 15:22:58 +05:30
devrk96
851ae51c3a
Auto scroll to specific section on homepage when reloading with same url (#2115) 2020-12-21 14:35:58 +05:30
Piyush Mishra
9f0cc2f4bb
Wrap Query Table in ErrorBoundary (#2274) 2020-12-21 11:44:50 +05:30
Piyush Mishra
5408806bf1
Do not add objects to the DataTree (#2275) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-12-21 11:44:20 +05:30
Nidhi
e3cf285d1e
Fixed encryption related bugs for empty/new datasource (#2287) 2020-12-21 10:41:57 +05:30
Shrikant Sharat Kandula
fdc4f7b200
Fix invalid templates and API breaking on invalid templates (#2286) 2020-12-19 13:00:24 +05:30
Shrikant Sharat Kandula
5e04ca5c9d
Add ability to configure order of templates of plugins (#2279) 2020-12-18 20:45:08 +05:30
akash-codemonk
e84699e7ba
Onboarding flow (#1960) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-12-18 18:48:47 +05:30
Nidhi
5a36d17f7a
Fixed encryption related bugs for empty/new datasource (#2272) 2020-12-18 16:13:01 +05:30
vicky-primathon
a6f602c33e
Fixed conversation of Unix timestamp in milliseconds (#2251) 2020-12-18 12:52:49 +05:30
Nidhi
a00c144e85
Subclassing authentication (#2215) 
* Sublcassing authentication

* Removed TODO

* Review changes
 2020-12-17 21:38:52 +05:30
Piyush Mishra
a3ed1515d5
Add headers null check (#2223) 
* @hetunandu for president
 2020-12-17 20:13:01 +05:30
Hetu Nandu
4b3a0ca9de
Fix table text pagination test (#2253) 2020-12-17 18:52:19 +05:30
Piyush Mishra
29de447411
Upgrade fusioncharts npm package (#2241) 2020-12-17 17:43:33 +05:30
NandanAnantharamu
db89dddbad
Organization test split into 2 parts (#2247) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-17 14:16:54 +05:30
Hetu Nandu
4f92ea99ed
Remove functions for action evals (#2242) 2020-12-17 13:36:16 +05:30
Pawan Kumar
e63f0a9d2a
Fix: 404 error page shows server unavailable (#2195) 
* mount error wise route

* remove log

* add test case

* fix wrong error page

* fix typescript error + remove unused variable

* remove 404 + 500 routes

* remove unused imports

* fix typo in test case

* remove history replace in utils

* remove unused variable

* add error codes for safe crash

* remove unused variables

* add error codes in all api rejects + update error reducer code type

* update error codes in init saga

* add selectors for error safe crash + take error logic out of app router

* remove unused variables

* remove extra line

* add header in error pag

* refactor page header on error page

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-17 12:33:59 +05:30
NandanAnantharamu
4914e0a3f2
Updated tests from the functional tests (#2234) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-17 11:40:50 +05:30
Piyush Mishra
0ccc80127a
move null check out (#2221) 2020-12-16 14:52:34 +05:30
Rishabh Saxena
2f152bf5b1
fix prev widget hidden when dragging new (#2211) 2020-12-16 14:51:57 +05:30
Rishabh Saxena
17ded71de3
fix actions/queries not fetched after cloning a page (#2196) 
* fix actions/queries not fetched after cloning a page

* cf fix

* update type

* update test to check if api is cloned

* trigger tests
 2020-12-16 14:51:31 +05:30
Ashwani Sindhu
15a00f4982
Set document title as app name (#2203) 2020-12-15 16:54:44 +05:30
Rishabh Saxena
5c905ac0d8
Update styles for date time headers in a table (#2197) 2020-12-15 16:54:15 +05:30
Hetu Nandu
df902440f5
Add xml2json and json2xml functions (#2022) 2020-12-15 14:16:33 +05:30
Pawan Kumar
1cafbca767
Fix: The search in the multi select is not showing + Multi select dropdown stops functioning if default value is undefined (#2057) 
* fix dropdown input ghost width

* add fix when default option is undefined

* update test cases for dropdown undefined default value

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-15 10:34:51 +05:30
Pawan Kumar
ffc6c91150
Fix: Input Widget Regex validation not working as expected (#2165) 
* add check for custom regex when input is number

* add test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-15 10:34:30 +05:30
Hetu Nandu
5bd2cc1ea4
Execution params in actions (#2128) 2020-12-15 00:18:13 +05:30
Piyush Mishra
7826cee7c3
Null check on actionObj before using it (#2190) 2020-12-14 21:52:45 +05:30
Rishabh Saxena
20d15188fd
br instead of p on enter within rte (#2188) 2020-12-14 14:50:45 +05:30
Trisha Anand
29706f7852
Removing printing the result for firestore plugin (#2191) 2020-12-14 14:48:50 +05:30
Rishabh Saxena
29d87a88f0
unmount during drag (#2168) 2020-12-14 12:38:00 +05:30
NandanAnantharamu
095e7d3a8c
Added test for Org logo update and delete (#2177) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-14 11:50:44 +05:30
vicky-primathon
b917f71678
Added undefined check on selectedRowIndices property before checking its length (#2163) 2020-12-14 11:49:39 +05:30
Trisha Anand
e5c44168f3
Configured pool size for hikariCP when new pool comes uo. (#2170) 2020-12-14 11:07:53 +05:30
dependabot[bot]
17e8725a84
Bump ini from 1.3.5 to 1.3.8 in /app/client (#2176) 
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-13 11:10:46 +05:30
Arpit Mohan
7ae4959c29 Correcting the if clause for environment variable 2020-12-12 22:03:03 +05:30
Arpit Mohan
372774e728 Checking if the new run command works in Github Action 2020-12-12 20:48:21 +05:30
Piyush Mishra
22aa9756c1
Resize canvas on delete widget (#1958) 2020-12-11 19:18:01 +05:30
Piyush Mishra
2a05df86c7
Hotfix crash on navigate to API page after widget rename (#2134) 2020-12-11 18:04:06 +05:30
Arpit Mohan
75b3f18a92 Correcting github actions yaml. 
Really need a validator for this
 2020-12-11 17:41:39 +05:30
Arpit Mohan
7fbd14228d Correcting the node_modules cache for Cypress tests 2020-12-11 17:39:10 +05:30
prapullac
b27a32940e
Manual Test Ideas (#2129) 2020-12-11 17:25:54 +05:30
Arpit Mohan
51757072de Ignoring manual cypress tests during build 
Also correcting the node_modules cache during yarn install
 2020-12-11 17:10:05 +05:30