Commit Graph

3840 Commits

Author SHA1 Message Date
Young Yoo
e5e5af204d
Fix #2342 Un-select row feature (#3074)
Co-authored-by: iheaven0129@gmail.com <*Dbtldud135>
2021-02-23 10:19:14 +05:30
NandanAnantharamu
725043fde3
Replace test api with mockApi in Cypress tests (#2975)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-23 09:56:02 +05:30
Shrikant Sharat Kandula
e2509ae325
Add placeholder for MongoDB datasource config's host inputs (#3145)
* Remove example indicator
2021-02-23 09:52:45 +05:30
Shrikant Sharat Kandula
4f6a48bf40
Fix BatchGetItem & TransactGetItems operations failing on the DynamoDB plugin (#3120)
* Fix batch operations APIs failing with DynamoDB

* Fixed TransactGetItems operation on DynamoDB
2021-02-23 09:51:23 +05:30
Ashok Kumar M
d1822a9dee
Feature: Modal Widget (#3092)
* Feature: Modal Widget(DIP)

* Adding cypress tests.
2021-02-23 09:48:23 +05:30
vicky-primathon.in
3d5d51fbde Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-22 22:20:36 +05:30
Vicky Bansal
0eab1993f8
Feature: onDataPointClick trigger in Chart Widget (#2953) 2021-02-22 22:01:13 +05:30
akash-codemonk
92d1c381f1
Allow searching for page names in explorer and other improvements (#3038) 2021-02-22 19:31:46 +05:30
Shrikant Sharat Kandula
15b8e0f590
Add appLayout field to Applications (#3144)
* Add `appLayout` field to Applications

* Fix NPE on clone
2021-02-22 19:21:13 +05:30
Hetu Nandu
6f7ce24a2f
Fix action subtree evaluation (#3142) 2021-02-22 16:44:08 +05:30
Shrikant Sharat Kandula
276338af0a Rename the $ref field to _ref in Firestore plugin (#3135)
(cherry picked from commit 198abbf37d)
2021-02-22 14:40:02 +05:30
Shrikant Sharat Kandula
198abbf37d
Rename the $ref field to _ref in Firestore plugin (#3135) 2021-02-22 13:57:04 +05:30
Rishabh Saxena
1d76f391da
Fix styles for the primary logo within viewer for safari (#3133) 2021-02-22 13:32:38 +05:30
Piyush Mishra
90fba15630
Fix/datasource name conflict issue (#3134) 2021-02-22 12:57:05 +05:30
Hetu Nandu
447f458656
Minor Api pane design and logic fixes (#3091) 2021-02-22 11:45:02 +05:30
Rishabh Saxena
0dab943be2
Fix app title widths for both viewer and editor (#3094) 2021-02-22 11:02:19 +05:30
Hetu Nandu
88c86fa881
Add toast for trigger errors (#3100) 2021-02-22 10:30:16 +05:30
NandanAnantharamu
03eba7ed27
Categorise tests between client and server (#2856)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-22 10:18:30 +05:30
Trisha Anand
7ff80ea192
In case an action is created without plugin template being set, update doesn't set the property as well. (#3116) 2021-02-19 23:26:33 +05:30
vicky-primathon.in
c5a689b560 Added support for markdown type in RTE 2021-02-19 16:57:54 +05:30
Trisha Anand
5a2ad75d1b
Use a toggle instead of dropdown to configure Prepared Statements (#3105) 2021-02-19 16:31:18 +05:30
Rishabh Saxena
a8aa41b652
Handle false (type: string) as falsy for the switch control (internal forms) 2021-02-19 16:30:07 +05:30
Shrikant Sharat Kandula
ef732f1389 Add request body and some other details in action execution data point (#3096) 2021-02-19 15:20:20 +05:30
Shrikant Sharat Kandula
a6be22e028
Add request body and some other details in action execution data point (#3096)
* Include request body in action execution data point

* Send analytics data point when analytics fails
2021-02-19 14:39:40 +05:30
Abhinav Jha
4b01e7b3d6 Fix RTE text input parsing.
Fix default input type
2021-02-19 11:19:30 +05:30
Abhinav Jha
4ae81bb74e Fix text newline and html parsing 2021-02-19 11:18:16 +05:30
akash-codemonk
f0be4341f3
Fix execute action error message (#3077) 2021-02-19 11:16:54 +05:30
Abhinav Jha
59f56c8052
Internal Fix: When tables are migrated, the computedValue for the columns do not have currenRow (#3066) 2021-02-19 10:21:52 +05:30
Abhinav Jha
419d724096
Internal Fix: Issue where the property panel isn't scrolled to top when opening it (#3065) 2021-02-19 10:21:01 +05:30
Abhinav Jha
47145b7ff7
Internal Fix: migration of dynamicTriggerPathList in Table Widget(#3064) 2021-02-19 10:19:54 +05:30
dependabot[bot]
9579b91fae
Bump jackson-databind in /app/server/appsmith-plugins/restApiPlugin (#3098)
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.4 to 2.10.5.1.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-19 08:24:07 +05:30
Shrikant Sharat Kandula
6eb9f399a3
Add a boolean isHidden field for pages (#3090)
* Add a boolean `isHidden` field for pages

* Add `isHidden` when loading all pages of application
2021-02-18 19:23:15 +05:30
Trisha Anand
e5574c1945
Support Prepared Statements in Postgres (#2967)
* Pushing minor editor form changes to ensure that prepared statement could be turned off.

* Code refactor to do variable substitution in PluginExecutor instead of action service.

* WIP : Prepared Statement handling in psql plugin

* WIP Prepared Statements.

* Working version of prepared statements

* Quote trimming added for post preparing sql statements. Now the unprepared statements and prepared statements do not require edits.

* Fixed existing test cases failing.

* Code formatting.

* Super minor code cleanup.

* Added migration for the existing postgres actions.

* Fixed failing test cases in ActionServiceTest.

* Minor change in the text for turning on and off prepared statements in the postgres query pane.

* Added test cases for prepared statement.

* Some minor comments for code readability

* Moved Prepared Statement setting from Action Configuration to Plugin Specified Templates since this setting does not make sense for all the DB plugins.

* Added function level comments

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/SqlStringUtils.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/SqlStringUtils.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Incorporated review comments.

* Fixed compile time error.

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-18 18:33:27 +05:30
imgbot[bot]
3ff938712c
[ImgBot] Optimize images (#2978)
*Total -- 1,442.90kb -> 1,261.25kb (12.59%)

/app/client/src/assets/icons/gifs/lightmode_thumbnail.png -- 13.33kb -> 4.62kb (65.34%)
/app/client/src/assets/gifs/deploy_orange.gif -- 20.75kb -> 12.27kb (40.88%)
/app/client/src/assets/gifs/input_drag.gif -- 25.10kb -> 16.16kb (35.63%)
/app/client/src/assets/images/invalid-page.png -- 3.20kb -> 2.22kb (30.49%)
/app/client/src/assets/gifs/table_drag.gif -- 28.84kb -> 20.42kb (29.2%)
/app/client/src/assets/images/appsmith_logo_square.png -- 17.63kb -> 12.84kb (27.16%)
/app/client/src/assets/icons/gifs/config_pagination_lightmode.gif -- 110.67kb -> 81.84kb (26.05%)
/app/client/src/assets/gifs/handwave.gif -- 25.54kb -> 20.12kb (21.25%)
/app/client/src/assets/images/preview.png -- 100.21kb -> 79.48kb (20.69%)
/app/client/src/assets/icons/gifs/config_pagination_darkmode.gif -- 101.19kb -> 80.38kb (20.57%)
/app/client/src/assets/gifs/onsubmit.gif -- 110.27kb -> 97.65kb (11.44%)
/app/client/src/assets/icons/gifs/darkmode_thumbnail.png -- 4.87kb -> 4.34kb (10.88%)
/app/client/src/assets/gifs/super_hero.gif -- 870.27kb -> 818.03kb (6%)
/app/client/src/assets/icons/ads/view-less.svg -- 0.25kb -> 0.24kb (3.53%)
/app/client/src/assets/icons/ads/add-more.svg -- 0.50kb -> 0.49kb (2.53%)
/app/client/src/assets/icons/ads/play.svg -- 0.23kb -> 0.22kb (2.16%)
/app/client/src/assets/icons/ads/no-response.svg -- 3.84kb -> 3.76kb (1.88%)
/app/client/src/assets/icons/ads/close-modal.svg -- 0.28kb -> 0.27kb (1.75%)
/app/client/src/assets/icons/ads/chevron_left.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/chevron_right.svg -- 0.20kb -> 0.20kb (1.44%)
/app/client/src/assets/icons/ads/right-arrow.svg -- 0.27kb -> 0.27kb (1.44%)
/app/client/src/assets/icons/ads/fork.svg -- 0.45kb -> 0.44kb (1.31%)
/app/client/src/assets/icons/ads/lightning.svg -- 0.22kb -> 0.22kb (1.3%)
/app/client/src/assets/icons/ads/arrow-left.svg -- 0.55kb -> 0.54kb (0.71%)
/app/client/src/assets/images/tick.svg -- 0.58kb -> 0.58kb (0.67%)
/app/client/src/assets/icons/ads/shine.svg -- 0.72kb -> 0.71kb (0.41%)
/app/client/src/assets/icons/ads/book.svg -- 0.85kb -> 0.85kb (0.34%)
/app/client/src/assets/icons/ads/datasource.svg -- 0.87kb -> 0.87kb (0.34%)
/app/client/src/assets/icons/help/updates.svg -- 1.01kb -> 1.01kb (0.29%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-02-18 18:08:13 +05:30
Trisha Anand
b565301afe
Datasource is given permission for a public app during create/update of a public action (#3086)
* Added test case to assert that new datasources and actions created post making an application public have the correct permissions for public execution.
2021-02-18 18:05:07 +05:30
Sumit Kumar
2c395b8c82
Enchancements for AWS S3 plugin (#3079)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-02-18 17:55:01 +05:30
vicky-primathon.in
2636c70410 Handled commont property for default text input type 2021-02-18 15:56:40 +05:30
vicky-primathon.in
517fe592f1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/rte-newline 2021-02-18 15:42:45 +05:30
Shrikant Sharat Kandula
60a4ddb3c1 Fix NPE on plugin specified templates (#3084)
(cherry picked from commit 2a2b55ceaf)
2021-02-18 13:12:08 +05:30
Shrikant Sharat Kandula
128444f46c Add more information for action execution (#3060)
* Add more information for action execution

* Add orgId and pageName to action execution data point

(cherry picked from commit 6936a40361)
2021-02-18 13:12:08 +05:30
Shrikant Sharat Kandula
2a2b55ceaf
Fix NPE on plugin specified templates (#3084) 2021-02-18 09:10:15 +05:30
Shrikant Sharat Kandula
6936a40361
Add more information for action execution (#3060)
* Add more information for action execution

* Add orgId and pageName to action execution data point
2021-02-18 08:30:56 +05:30
Hetu Nandu
e1d43992b2
Fix default value reset issue (#2861) 2021-02-17 20:32:36 +05:30
prapullac
743791a95d
Manual negative test ideas for user invite flow (#2481)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-17 20:27:18 +05:30
prapullac
8cd3a981b9
Manual test ideas for datasource query (#2763)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-17 20:22:16 +05:30
akash-codemonk
5c80e2e3e2
Update the message on the widget sidebar (#3056) 2021-02-17 11:05:24 +05:30
Shrikant Sharat Kandula
c80b6b4761 Include Firestore document metadata in responses (#3063)
(cherry picked from commit b9cb76e7e5)
2021-02-17 10:59:36 +05:30
Pawan Kumar
503a8ae3fe
remove negative margin (#3037)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-17 10:54:56 +05:30
Shrikant Sharat Kandula
b9cb76e7e5
Include Firestore document metadata in responses (#3063) 2021-02-16 22:09:09 +05:30
Piyush Mishra
74b013d909
Encode params toggle (#3006)
* Makes client side changes to support actionConfiguration.encodeParamsToggle setting.
* Add migration code.

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-16 20:31:35 +05:30
Nidhi
afc329fd7b
Added grant type Authorization code to OAuth2 (#2992)
Co-authored-by: Piyush <piyush@codeitout.com>
2021-02-16 17:58:03 +05:30
akash-codemonk
86725baf61 Update onboarding indicator animation for widget menu (#3018)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2021-02-16 17:52:15 +05:30
akash-codemonk
e604357643 Go back to application list instead of deleting app (#2981) 2021-02-16 17:52:04 +05:30
akash-codemonk
9c20ac5306 New onboarding flow (#2686)
Co-authored-by: a <rishabh.robben@gmail.com>
2021-02-16 17:51:46 +05:30
Ashok Kumar M
a55c10a8ed
Feature Switch Widget (#2999)
* Feature Switch Widget

* Center switch widget

* Adding Cypress tests and changing some nomenclature.

* Adding doc reference

* Swap label for checkbox widget.

* Addressing code review comments.

* remove swap label as exposed property

* Align widget even when label isn't present.

* Changing swapLabel property to Alignment property.

* Fixing test cases.

* Adding default alignment for checkbox.

* Switch documentation link correction

* Removing Ids and adding bind and trigger properties as per new config.

* Changing  default state to bindable property.

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-16 17:45:17 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
Ashok Kumar M
24c5357f9d
Fix: Shrink Entity explorer by 20% (#3005) 2021-02-16 15:56:09 +05:30
Piyush Mishra
7e84c93282
Add QUERY_DYNAMIC_INPUT_TEXT control (#2983) 2021-02-16 11:51:19 +05:30
Rishabh Saxena
2e72be0f8a
Handle quota exceeded and running low on disk space errors while saving a key in localStorage (#2947) 2021-02-16 11:47:23 +05:30
Arpit Mohan
a973d779fd
Correcting the display message for query actions based on isExecutionSuccess flag (#3045)
Also improving the mongo error response string. Now we only send the error message instead of the entire stack trace back to the client
2021-02-15 22:10:04 +05:30
Hetu Nandu
ebd61efcca
Show a toast when action executeOnLoad status updates (#3042) 2021-02-15 21:43:44 +05:30
Piyush Mishra
56170b0cdf
Null check in getConfigInitialValues (#3043) 2021-02-15 21:43:20 +05:30
vicky-primathon.in
6ca247219c Added defaultText and defaultHTML properties in RTE to change newline only in case of default text value
Added migrations to handle the same
2021-02-15 17:19:33 +05:30
Abhinav Jha
342bad8909
Fix #2829 Crash when resetting form widget (#2942) 2021-02-15 11:03:30 +05:30
akash-codemonk
c7a5b8f6d5
Update onboarding indicator animation for widget menu (#3018)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2021-02-15 10:44:42 +05:30
Shrikant Sharat Kandula
3fd8db90bd
Consistent handling of signup configuration over FORM and OAUTH (#3013)
* Fix OAuth flow throwing 500 when signup is disabled

* Check for error code to identify signup disabled error

* Add consistent handling of allowed-domains for signing up

* Check for existence of valid email before checking domain
2021-02-12 19:48:07 +05:30
Sumit Kumar
5638997a36
change response data format for AmazonS3 Plugin (#3023)
* change response data format.
* fix TCs
2021-02-12 19:34:03 +05:30
Shrikant Sharat Kandula
48b8bb9de1
Fix order of roles in share modal (#3017) 2021-02-12 16:37:34 +05:30
Rishabh Saxena
051156da29
Follow the same sequence while displaying oauth options for Signup & Login (#3009) 2021-02-12 16:12:53 +05:30
Sumit Kumar
4df595417f
return url on file create and fix image/video file upload issues with amazons3 plugin (#3012)
1. Return url on file create.
2. Fix image/video upload/download.
3. Change error msg format to directly print error msg without adding any prefix sentence.
2021-02-12 16:01:26 +05:30
Pawan Kumar
5b23cbf6f1
fix margin/padding issue in container in publish view (#2446)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-12 10:37:03 +05:30
abhishek nayak
14d17dfad5
Update JSDependencies.tsx
Updated 'Dependencies' to 'JS libraries you can use'
2021-02-12 01:38:52 +05:30
Arpit Mohan
01ca53899e
Fixing the organization share Cypress test cases (#2993) 2021-02-11 23:50:49 +05:30
devrk96
ac23629647
Feature: API Pane Redesign (#2218)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 18:24:00 +05:30
Nidhi
8823f9d407
Added client credentials grant type for OAuth2 (#2649)
* Added client credentials grant type for OAuth2

Co-authored-by: Piyush <piyush@codeitout.com>
2021-02-11 17:58:06 +05:30
Rishabh Saxena
1a593e1981
add default values to payload while creating a new action (#2976)
Fix default values not sent as payload while creating a new action
2021-02-11 17:17:21 +05:30
akash-codemonk
8aa39eae7b
Go back to application list instead of deleting app (#2981) 2021-02-11 16:55:47 +05:30
Shrikant Sharat Kandula
8440d4e4e3
Allow app-viewers to invite others as app-viewers (#2961)
* Allow app-viewers to invite others as app-viewers

* Fix description for new permissions

* Migration for setting invite policy for app viewers
2021-02-11 16:33:35 +05:30
Sumit Kumar
4870c0d743
enable save on missing username/password (#2979)
1. Add encrypted logo to password.
2. Enable save on empty username / password.
2021-02-11 14:35:10 +05:30
akash-codemonk
c1b3f311e3
New onboarding flow (#2686)
Co-authored-by: a <rishabh.robben@gmail.com>
2021-02-11 12:06:07 +05:30
Pawan Kumar
234b6983e9
Fix: border-radius of modal and bug where children of modal were not resetting on close of modal. (#2963)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

* update border radius of modal

* reset modal children on close

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-11 11:55:11 +05:30
Pawan Kumar
3b28653395
update rich text editor version + add check for string in editor value (#2966)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 11:55:00 +05:30
Vicky Bansal
e2349c53ab
Fix - Table column resize and reorder interaction (#2580) 2021-02-11 11:30:36 +05:30
Sumit Kumar
e9e30d1fa4
Enable toggle for params encoding (#2968)
Enable toggle for params encoding
1. Add toggle param to ActionConfiguration class.
2. Add TCs to test toggle on/off/null.
2021-02-11 11:02:29 +05:30
Ashok Kumar M
0da3421dc2
Fix Local setup changes to accommodate M1 chip Macbooks. (#2959)
* Fix Local setup changes to accommodate M1 chip Macbooks.

* escaping quotes.

* formatting start-https.sh
2021-02-10 16:12:01 +05:30
Sumit Kumar
2a7f7ba8c4
s3 plugin (#2735)
1. Integrate S3 plugin.
2021-02-10 15:26:01 +05:30
Shrikant Sharat Kandula
95d1717f57 Merge branch 'release' 2021-02-10 14:35:02 +05:30
Shrikant Sharat Kandula
ed1c926c8a
Add datasource structure support for DynamoDB (#2919) 2021-02-10 13:28:35 +05:30
Rishabh Saxena
8c72e901ee
Fix input's onSubmit action being triggered if its validation is failing (#2960) 2021-02-10 13:13:41 +05:30
Abhinav Jha
4becc50005
Fix issue where the parentRowSpace of the new widget generated from the query was incorrect. Resulting in incorrect pageSize calculations (#2944) 2021-02-10 12:34:11 +05:30
Shrikant Sharat Kandula
c5df149ba8
Add IN operator support for forms' hidden fields (#2939) 2021-02-10 11:27:21 +05:30
Pawan Kumar
c78a578247
Fix: Cannot read property 'closeModal' of null (#2911)
* update filepicker uppy implementation

* update uppy implementation

* fix uppy implementation

* remove typo

* remove consoles

* remove unused variable

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-10 10:29:47 +05:30
Abhinav Jha
eafadb8988
Update nvmrc to match the node version in package.json (#2943) 2021-02-09 20:53:05 +05:30
Hetu Nandu
8439affd67
Update node to latest LTS version (#2931) 2021-02-09 19:14:50 +05:30
Shrikant Sharat Kandula
0861836db4
Fix bindings in Firestore plugin's where condition value (#2934) 2021-02-09 19:11:16 +05:30
abhishek nayak
785c81df23
Update messages.ts 2021-02-09 17:38:43 +05:30
Nidhi
c0e44d0cd9
Added null check for error messages (#2922)
* Added null check for error messages

* Added a generic null check for future null pointers from other sources.
2021-02-09 15:00:22 +05:30
Trisha Anand
af273c60d8
When fetching unpublished actions and unpublished pages, check if the undeployed version is not deleted before fetching. (#2792)
* When fetching unpublished actions and unpublished pages, check if the undeployed version is not deleted before fetching.

* Only add unpublished page deleted at check if the view mode is false (aka edit mode)

* 1. Update action repository to fetch only non deleted actions if fetching actions in edit mode.
2. Added test cases to assert re-using of deleted page and action names.
2021-02-09 12:57:10 +05:30
Shubhendra Singh Chauhan
ac49a5aa87
Remove true from boolean attribute (#2892)
Added .deepsource.toml file
2021-02-09 11:38:54 +05:30
Rishabh Saxena
36021f9aba
fix viewer tabs arrow btns on mobile (#2910) 2021-02-09 11:05:06 +05:30
Trisha Anand
078870f7c9
Communicate action execute on load changes in update layout (#2825)
* 1. Update on load actions correctly
2. Send the changed actions with their changes as well as messages back to the client as part of the response.

* Added test case to assert that the action updates are correctly recorded in updateLayout.

* Code cleanup + added more comments for code readability

* Incorporated review comments.
2021-02-09 10:39:08 +05:30
Shrikant Sharat Kandula
fbf6021080
Fix nested structure translation in DynamoDB (#2915) 2021-02-09 06:59:45 +05:30
Nidhi
973cd850e7
Modified documentation links for plugins (#2909)
* Modified documentation links for plugins

* Modified documentation links for plugins
2021-02-08 17:11:31 +05:30
Shrikant Sharat Kandula
ebcbfb0043 Merge branch 'release' 2021-02-08 16:39:47 +05:30
Piyush Mishra
0a6040c1cd
Hotfix redux-form getting destroyed (#2908) 2021-02-08 16:24:49 +05:30
NandanAnantharamu
3d43d04658
Remove unwanted step in Cypress Map widget test (#2902)
* updated test

* removed the commented line

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-08 16:20:28 +05:30
NandanAnantharamu
1aa879d8c2
updated flaky test (#2899)
* updated flaky test

* review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-08 15:50:03 +05:30
Shrikant Sharat Kandula
433ce89c76
Add support for handling array types in Postgres plugin (#2887) 2021-02-08 15:06:57 +05:30
Nidhi
35b3e7d84f
Switched test container ver (#2898) 2021-02-08 13:40:53 +05:30
Pawan Kumar
3e53df8b64
Update Default styles of Widgets (#2823)
* update default styling of widgets

* [CodeFactor] Apply fixes

* update widgets styles

* fix eslint bug

* update button colors

* update primary button color

* update primary button color

* remove px in 0px in css

* incorporate abhinav review feedbacks

* fixed global styling of popover

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
Co-authored-by: codefactor-io <support@codefactor.io>
2021-02-08 13:00:01 +05:30
Rishabh Saxena
a473ed23b0
fix navbar bottom border when tabs arent rendered (#2883) 2021-02-08 10:50:52 +05:30
Nikhil Nandagopal
d9bc97cf39 Merge branch 'release' into fix/filepicker 2021-02-04 19:25:33 +05:30
Piyush Mishra
a2d8061aa2
Prep for a separate RestAPIDatasource (#2874) 2021-02-04 17:50:24 +05:30
Hetu Nandu
5d514849b4
Fix org creation and app creation tests (#2878) 2021-02-04 17:01:32 +05:30
Nikhil Nandagopal
6f779b215c added a text property for the file as well 2021-02-04 16:45:00 +05:30
Sumit Kumar
e6b77a1299
Stop logging some AppsmithPluginException to Sentry (#2351)
1. Move package  appsmith-interfaces/src/main/java/com/appsmith/external/pluginExceptions-> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions
2. Move enum AppsmithErrorAction from appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithError.java -> appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/AppsmithErrorAction.java, so that both plugin exceptions and server exceptions could use the same enum.
3. Log exception based on the error action defined for each exception.
2021-02-04 15:24:30 +05:30
Hetu Nandu
0332c15d56
Better handling of action error response (#2839) 2021-02-04 15:08:25 +05:30
Shrikant Sharat Kandula
5c9f90fd59
Fix missing user name in first organization name (#2873) 2021-02-04 14:04:24 +05:30
Rishabh Saxena
32b641c118
Implement new designs for the editor and viewer's navbar (#2750) 2021-02-04 12:32:36 +05:30
Rishabh Saxena
c72833b53b
Add an option to set reset the input widget's value on submit (#2837) 2021-02-04 11:21:16 +05:30
Nikhil Nandagopal
8c5213b6fd
Merge pull request #2851 from appsmithorg/fix/docs-link
Fix/docs link
2021-02-03 21:31:33 +05:30
Nikhil Nandagopal
486a9da8dd updated all doc links 2021-02-03 20:45:16 +05:30
Piyush Mishra
0ca5563b83
Chronological system events for developer user (#2530) 2021-02-03 18:46:48 +05:30
NandanAnantharamu
b3a75de6d3
split the test (#2799)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-03 18:08:27 +05:30
Shrikant Sharat Kandula
779c41e0d3 Merge branch 'release' 2021-02-03 17:44:23 +05:30
Nikhil Nandagopal
db9c2d6c27 Updated doc link 2021-02-03 17:28:05 +05:30
Vicky Bansal
42289173b1
Fix: Date widget crash due to invalid date in date picker (#2845)
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-03 17:00:19 +05:30
Shrikant Sharat Kandula
f950a9352b
Fix datasource hostnames being saved with spaces (#2844) 2021-02-03 16:46:09 +05:30
Nikhil Nandagopal
d27865e4c9
Merge pull request #2843 from appsmithorg/fix/filepicker-name
added file name to file picker and fixed a crash
2021-02-03 15:10:44 +05:30
Rishabh Saxena
5da3b0165e
Prevent input component cursor getting reset using asyncControlledInput (#2802) 2021-02-03 14:52:19 +05:30
Rishabh Saxena
63c028159c
Fix manage users link not visible in the share modal when triggered from the editor or viewer (#2653) 2021-02-03 14:51:49 +05:30
Nikhil Nandagopal
f2045b5435 added file name to file picker and fixed a crash 2021-02-03 14:46:44 +05:30
Rishabh Saxena
8ae86c34e0
Fix: redirect to applications page from auth pages when the user is logged in (#2771) 2021-02-03 13:29:00 +05:30
NandanAnantharamu
7a9ec45901
Added test for invalid binding (#2777)
* Added test for invalid binding

* Updated review comments

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-03 11:56:46 +05:30
Piyush Mishra
311fb5ad47
Fail client build if anything fails (#2820) 2021-02-03 11:02:00 +05:30
Hetu Nandu
bda90b4bf3
Wrap words in a toast message (#2832) 2021-02-03 10:43:55 +05:30
Shrikant Sharat Kandula
e9ba40f1f4
Analytics data point on action execution (#2740)
* Add analytics data point on action execution

* Include application details in action exec data point

* Only send action execution event on cloud

* Analytics is auto-disabled on self-hosted setups

* Move event name to AnalyticsEvents enum

* Move analytics Mono to separate method

* Use a common function to enqueue analytics message

* Provide analytics properties from caller method

* Use consistent casing in event names for analytics
2021-02-02 20:24:27 +05:30
Vicky Bansal
11f5687b38
Date picker validation fixed (#2789)
* Date picker validation fixed

* Added date value check to remove unncessary validations

Commented defaultDate validation test as invalid date cannot be saved in date control

* Fixed date selection on user change

Fixed min and max date parsing for date picker control default date

* Added validation for min and max date in validations to handle validations when field is converted to JS
2021-02-02 20:12:49 +05:30
Rishabh Saxena
9d97645b3c
minor style fixes: page context menu background color (#2479) 2021-02-02 17:47:18 +05:30
prapullac
66eb08413c
Test Ideas for "Copy to Clipboard" (#2585)
* Test Ideas for copy to Clipboard

* Adding test ideas for App viewer and admin flow

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
2021-02-02 14:11:34 +05:30
Nidhi
01bbc03857
Fixed handling of lists in dynamodb (#2818) 2021-02-02 13:35:58 +05:30
Nidhi
c83fb70b95
Fixed ExecuteOnLoad not getting set for onPageLoad actions (#2801)
* Piped onpageload update function

* Added tests
2021-02-02 10:48:51 +05:30
Shrikant Sharat Kandula
98a0cd59b1
Fix reference types in arrays in Firestore (#2811)
* Fix reference types in arrays in Firestore

* Added a whole bunch of tests for various data types
2021-02-02 10:18:06 +05:30
Hetu Nandu
4505e41369
Migrate renamed canvas widgets to the correct name (#2782) 2021-02-01 20:03:13 +05:30
Abhinav Jha
3a9b328dcc
Fix: New widget and action name conflicts (#2778) 2021-02-01 20:02:43 +05:30
Abhinav Jha
51696b7220
Tab names can now be updated from the entity explorer (#2779) 2021-02-01 18:47:55 +05:30
Tim Dillon
91d5eb5860
Fix user email duplicated as name (#2787) 2021-02-01 14:51:44 +05:30
Shrikant Sharat Kandula
8475d71600
Fix RestAPI plugin not starting up (#2757)
* Remove unneeded dependency exclusions
2021-02-01 14:38:06 +05:30
Shrikant Sharat Kandula
018e1a94d6
Fix Firestore single document method for ref types (#2790) 2021-02-01 14:23:48 +05:30
Hetu Nandu
86cb8cac67
Allow for navigateTo urls to be of mailto or tel url schemes t (#2781) 2021-02-01 13:47:31 +05:30
Hetu Nandu
22afbe8971
Fix Array paths (#2775) 2021-01-29 09:59:23 -08:00
Piyush Mishra
164de6fb7e
Avoid double validation (#2687) 2021-01-29 11:34:28 +05:30
Dwayne Forde
f8974f1911
Fixes a small syntax issue with ./start-https.sh (#2767) 2021-01-29 09:55:51 +05:30
Arpit Mohan
433461a347
Merge pull request #2759 from appsmithorg/release
Release v1.3.2
2021-01-28 18:02:48 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
prapullac
4ccdba9e85
Adding manual test ideas for Home page and Login scenarios (#2627)
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2021-01-28 14:42:22 +05:30
Piyush Mishra
c3740709d0
Do not show sections that are supposed to be hidden (#2746) 2021-01-28 14:26:29 +05:30
Rishabh Saxena
ca052e7515
minor updates for auth pages: polish UI, hide empty email error message (#2743) 2021-01-28 12:50:09 +05:30
Nidhi
c17a2ea536
Modified error displayed to user on generic bad request (#2583)
* Modified error displayed to user on generic bad request

* Separate null check for cURL import
2021-01-28 12:14:34 +05:30
Dwayne Forde
51ccd19081
Use IPv4 on WSL machines (#2729)
WSL has issues when handling IPv6 ips. In order to resolve this, on dev machines, we now check if it's a WSL environment. If yes, we default to using IPv4 instead of IPv6.
2021-01-28 12:08:44 +05:30
Rishabh Saxena
4c393f0f1f
fix: action not a plain object for widget entity name action creater (#2638) 2021-01-27 23:38:08 +05:30
Rishabh Saxena
19c4559c95
fix: datasource bound value preview in the explorer showing entire response (#2480) 2021-01-27 23:35:32 +05:30
Shrikant Sharat Kandula
b731793a88
Fix reference type fields in Firestore throwing 500 (#2718) 2021-01-27 20:38:46 +05:30
NandanAnantharamu
8358709f56
Added usecase for orgNaming convention (#2521)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-27 18:44:44 +05:30
Shrikant Sharat Kandula
350aea90c4
Revert RestAPI plugin signature timeout fix (#2748) 2021-01-27 17:24:25 +05:30
Pawan Kumar
35e66360e2
Fix: Hover highlight in entity explorer should be edge-to-edge (#2478)
* fix merge conflicts of sumanthyedoti:fix/entity-items-hover

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-27 17:08:21 +05:30
Shrikant Sharat Kandula
63b7eb6e95
Fix signature in RestAPI plugin throwing timeout error (#2745)
* Fix restapi signature throwing timeout error

* Add missing dependencies for restapi
2021-01-27 14:55:08 +05:30
NandanAnantharamu
704b787435
updated action on file selected (#2691)
* updated action on file selected

* updated common method

* Review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-27 14:37:33 +05:30
Shrikant Sharat Kandula
a6d76d1672
Fix organization slug computation clashes (#2725)
* Fix organization slug computation clashes

* Handle case where number-less slug is available
2021-01-27 14:35:43 +05:30
Abhinav Jha
0fa245a985
Fix issue where users could undo delete long after the timeout has expired (#2741) 2021-01-27 13:51:47 +05:30
Shrikant Sharat Kandula
6bf2be65c0
Don't attempt to get structure for invalid datasources (#2730) 2021-01-27 13:44:15 +05:30
Vicky Bansal
aa71f2ae7b
Handle invalid entity ids (#2547) 2021-01-27 12:26:19 +05:30
Vicky Bansal
5406cbee9e
Fix: Update map initial location after creating a new marker (#2736) 2021-01-27 12:25:43 +05:30
Hetu Nandu
43322413c6
Support for navigateTo function to open in new window (#2706)
* Support target for navigate function

* Add docs and action creator field
2021-01-27 11:58:23 +05:30
Rishabh Saxena
aea3b3d4db
Revamping UI on the Login/Signup page (#2696) 2021-01-27 11:42:32 +05:30
Vicky Bansal
e34a98833c
Trigger onPageSizeChange action when table page size changes (#2737) 2021-01-27 11:10:53 +05:30
Tim Dillon
c9b3059498
Disable sort by Delete column in Members page (#2722) 2021-01-27 00:24:50 +05:30
Piyush Mishra
9490ba4eca
Remove SSL related clicks from fillMongoDatasourceForm cypress command (#2726) 2021-01-27 00:04:19 +05:30
Shrikant Sharat Kandula
42efb20d14
Remove unused cert fields for Mongo and Postgres plugins (#2723) 2021-01-26 18:44:01 +05:30
Nidhi
6515b5c91c
Fixed null endpoint issue for MySQL plugin (#2719) 2021-01-26 17:16:31 +05:30
Hetu Nandu
40e42b296d
Fix for timeout being sent in a different location (#2708) 2021-01-26 08:42:52 +05:30
Trisha Anand
9e0f36a6f2
Improve Server thrown Error Messages' language (#2705)
* Improve Error Messages

* Added naming convention expansion for action name in the error

* Fixed failing test case assertion.

* Minor formatting.
2021-01-25 18:50:32 +05:30
Trisha Anand
3776e82fb8
Scheduling of parallel tasks implementation for on-page load actions (#2667)
* Proof of concept code which calculates the on load page actions.

* Refactored the field names introduced in Layout. Added a new field to keep a track of direct action names used in dynamic bindings in the DSL.

* Untested compute on on page load actions completed.

* Working page load actions computation.
TODO : Update the tests for correctness.

* Added fix for BFS starting from root nodes instead of arbitrary nodes.
Fixed a test case to assert for correct page load actions.

* Fixed the bug where the ids of the actions were not getting set in the layout. Also asserting the same in the test case for catching the future breaks.

* Minor refactor of function name to clear its purpose without reading the code.

* Incorporated review comments.

* Added conditional checks for unpublished action deleted and circular dependency of actions depending on each other.
2021-01-25 16:54:45 +05:30
Hetu Nandu
3f2e60dc0d
Sanitise any other possible place which could send functions (#2704) 2021-01-25 16:49:31 +05:30
Hetu Nandu
5dc01c677d
Batching widget property updates (#2685)
- Changed the updateWidgetProperty redux action to use an object of updates instead of single update
- Added the new batchUpdateWidgetProperty action
> This action will calculate dynamicPath changes for all the updates and update them together
- Added the new deleteWidgetProperty action
>This action will delete a property and any dynamicPaths/child dynamicPaths that exist
2021-01-25 14:27:26 +05:30
devrk96
3be4828d63
Fix: App name UI in edit and deploy mode (#2216) 2021-01-25 12:51:54 +05:30
Pawan Kumar
4f1fd68052
add check if widget is available in data tree (#2681)
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-25 11:01:44 +05:30
NandanAnantharamu
536a222e1c
Uncommented few tests (#2695)
* Uncommented few tests

* updated dsl

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-25 10:39:16 +05:30
Rishabh Saxena
e8a01c456d
product updates modal test (#2677) 2021-01-23 13:46:50 +05:30
vicky-primathon
63e286a469
Show row cursor as pointer when onRowSelected property is set in table widget (#2604) 2021-01-22 15:42:34 +05:30
vicky-primathon
c9cee45f51
Fix - Wrap contents of the table cell tooltip (#2629) 2021-01-22 15:19:02 +05:30
vicky-primathon
a309107623
Fix - Remove delete icon when there are no filters in table widget (#2605) 2021-01-22 15:17:14 +05:30
vicky-primathon
a9e0b5b678
Fix - selectedRow autocomplete suggestions when no row is selected (#2603) 2021-01-22 15:15:14 +05:30
vicky-primathon
ae276a93f8
Fix - Boolean values comparison in Table widget filters(#2586)
- Display filter label instead of value
2021-01-22 15:14:03 +05:30
vicky-primathon
154a4d30c9
Persist column sizes on resize in app viewer for the duration of the session (#2578) 2021-01-22 15:08:48 +05:30
vicky-primathon
64a0a44446
Remove table row alternating colors (#2552) 2021-01-22 15:07:43 +05:30
Shrikant Sharat Kandula
1e8aa62654 Merge branch 'release' 2021-01-22 14:34:58 +05:30
Shrikant Sharat Kandula
468e84aabb
Fix calls to release notes from cloud instances (#2680) 2021-01-22 14:25:24 +05:30
Hetu Nandu
d4be9b9404
Remove any functions from Eval Action bindings task before returning from the worker (#2679) 2021-01-22 13:40:00 +05:30
Trisha Anand
48cfa2cea0
In case an action has been deleted in unpublished state, dont return it to the user in edit mode. (#2678) 2021-01-22 13:19:42 +05:30