Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
5,314 Commits 1 Branch 0 Tags 507 MiB
7bd1e9587c
Commit Graph

3840 Commits

Author SHA1 Message Date
Trisha Anand
214f911060 Fixed merge conflict related build failure. 2021-01-04 11:24:00 +05:30
Trisha Anand
24ef325467
Merge branch 'master' into release 2021-01-04 11:18:13 +05:30
Trisha Anand
e17da5f913 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2021-01-01 01:24:55 +05:30
Trisha Anand
a3378397d7 Increasing pool size to 20 to reduce the number of times datasource becomes unusable. Symptomatic relief till I can solve for this at leisure over the next few days. 
Note : Update/Insert are leading to connection leak
 2021-01-01 01:24:26 +05:30
Pawan Kumar
9d0c6d5359
fix datetimepicker max date issue (#2407) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-31 17:54:50 +05:30
Piyush Mishra
3d7242d716
Cleanup cancelled requests (#2387) 2020-12-30 18:56:44 +05:30
Rishabh Saxena
611186c4b2
set min pageSize for table widget (#2362) 2020-12-30 18:32:46 +05:30
Rishabh Saxena
c344377a9d
only autofocus widget search (#2400) 2020-12-30 18:32:11 +05:30
Hetu Nandu
31d8c8c4eb
[Worker] Fix critical issues (#2393) 2020-12-30 18:28:57 +05:30
Trisha Anand
d4640e01a2
Invite users once triggered should not be cancellable. (#2401) 
* Invite users once triggered should not be cancellable.
 2020-12-30 16:50:01 +05:30
Rishabh Saxena
6dd97a6f09
fix stacking order of popover and app header (#2338) 2020-12-30 14:36:24 +05:30
Rishabh Saxena
f1f9441cc6
auto focus search input (#2360) 2020-12-30 14:33:24 +05:30
akash-codemonk
1a35bb1e75
Onboarding flow (#2311) 2020-12-30 13:01:20 +05:30
Piyush Mishra
5ae2da1578
Send clean validated tree back (#2376) 2020-12-29 23:57:07 +05:30
Rishabh Saxena
37d0314c2a
default error code (#2363) 2020-12-29 22:22:31 +05:30
Rishabh Saxena
14effe6db1
fix del hotkey (#2349) 2020-12-29 22:21:57 +05:30
Rishabh Saxena
ccd9371820
update tooltip test (#2392) 2020-12-29 19:50:14 +05:30
Trisha Anand
712f41db92
Reducing the probability of getting pages out of order (Expected order is the order in which the pages were created and added to the application). This should : (#2391) 
1. Get rid of cypress test failures which asserts a certain order till the cypress test case is fixed and unblocks the frontend team.
2. Uses a bulk API to fetch all the pages instead of fetching each page sequentially over different network calls with the database.
 2020-12-29 19:10:01 +05:30
Rishabh Saxena
13fae1a5c1
fix test (#2390) 2020-12-29 17:45:15 +05:30
Trisha Anand
ea366b1d29 Fixed NPE in database migration 2020-12-29 17:06:30 +05:30
Trisha Anand
735a4398b2
Added a migration to old rest api datasources which adds the new mandatory key isSendSessionEnabled with value N (#2388) 2020-12-29 16:29:28 +05:30
Rishabh Saxena
e526f5cca5
minox css fixes (#2375) 2020-12-29 16:17:32 +05:30
Hetu Nandu
b5e8673921
Properly log data tree instrumentation (#2228) 2020-12-29 14:55:56 +05:30
Trisha Anand
ea0f9c159c
[Bug] Multi page applications return only a single page when fetching pages per application (#2383) 
* Zipping flux with mono leads to mono not getting repeated and only the first emitted value of flux is processed further. This is leading to only a single page getting emitted in a multi page application.

* Added a test case to assert this for a multi page application
 2020-12-29 13:38:47 +05:30
Trisha Anand
a70b95be37 Adding leak detection to hikari pool. Would be tracking this on logdna to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374) 2020-12-28 18:29:50 +05:30
Trisha Anand
051d3c6c7f
Adding leak detection to hikari pool. Would be tracking this on logdna to ensure that we are catching any and all leaks that may be occuring with hikari. (#2374) 2020-12-28 18:26:33 +05:30
Piyush Mishra
988ebe975b
RPC-like layer with graceful startup and shutdown around a webworker (#2252) 2020-12-28 14:12:43 +05:30
Sumit Kumar
6299c86f39
Add TC to test mongodb connection establishment (#2364) 
1. Test that when a query is attempted to run on mongodb server but refused because of lack of authorization, then
also, it indicates a successful connection establishment.
 2020-12-28 11:58:17 +05:30
dependabot[bot]
45497ba5ac
Bump node-notifier from 8.0.0 to 8.0.1 in /app/client (#2316) 
Bumps [node-notifier](https://github.com/mikaelbr/node-notifier) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/mikaelbr/node-notifier/releases)
- [Changelog](https://github.com/mikaelbr/node-notifier/blob/v8.0.1/CHANGELOG.md)
- [Commits](https://github.com/mikaelbr/node-notifier/compare/v8.0.0...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-28 10:55:39 +05:30
Trisha Anand
6210b9a0c0
All newly created applications now have a default published state. (#2309) 
* All newly created applications now have a default published state.

* Added a test case to assert a new application comes up with default published states for both application and the default page.

* Function name changed.

* When trying to fetch a published version of a page when the page has not been published, throw a 404.

* WIP : Not working
 2020-12-28 10:30:43 +05:30
Piyush Mishra
ebcffadca1
Prettier fixes (#2366) 2020-12-28 09:47:50 +05:30
Piyush Mishra
8ef8bfd2ac
Prettier fix. (#2353) 2020-12-24 19:01:09 +05:30
akash-codemonk
466d0cfde1
Fix explorer entity icon alignment (#1413) 2020-12-24 15:41:02 +05:30
Rishabh Saxena
83349e2996
fix modal entity not renamed through property pane when closed by clicking on the overlay (#2185) 2020-12-24 11:43:01 +05:30
Piyush Mishra
806a139ddb
Make prettier changes (#2337) 2020-12-24 10:02:25 +05:30
Piyush Mishra
3930c4c63c
Hotfix circularJSON (#2214) 2020-12-23 19:48:46 +05:30
Shrikant Sharat Kandula
85350b2940 Add migration to set isEncrypted field where missing (#2332) 
(cherry picked from commit d5e0fb18d8)
 2020-12-23 18:07:35 +05:30
Shrikant Sharat Kandula
4ff2834559 Missing isEncrypted should mean a true value 
(cherry picked from commit c7f330c4c7)
 2020-12-23 18:07:35 +05:30
Rishabh Saxena
4e802d2c5a
reset query on select, don't jump to active item (#2237) 2020-12-23 17:45:14 +05:30
Rishabh Saxena
396b12b024
reorder widgets alphabetically, autofocus search input (#2325) 2020-12-23 17:02:30 +05:30
Rishabh Saxena
fb7ae53002
set the first tab as selected when the selected tab is not found (#2231) 2020-12-23 16:59:34 +05:30
Rishabh Saxena
778b82f9ae
enable hotkeys only when a widget is selected (#2262) 2020-12-23 16:58:29 +05:30
Rishabh Saxena
77801b10ff
fix undo delete tab, create copy of tabs array (#2315) 2020-12-23 16:55:52 +05:30
Rishabh Saxena
9417335176
render column submenu popover inline (#2329) 2020-12-23 16:55:25 +05:30
Shrikant Sharat Kandula
d5e0fb18d8
Add migration to set isEncrypted field where missing (#2332) 2020-12-23 15:35:45 +05:30
Shrikant Sharat Kandula
c7f330c4c7 Missing isEncrypted should mean a true value 2020-12-23 14:23:03 +05:30
a
61e12235b2 Revert "reorder widget locale wise, autofocus search input" 
This reverts commit 0bcc8872eb.
 2020-12-23 11:08:52 +05:30
a
0bcc8872eb reorder widget locale wise, autofocus search input 2020-12-23 11:01:00 +05:30
vicky-primathon
6b6e302ee1
Fix Table data validation issues (#2297) 2020-12-23 09:47:13 +05:30
vicky-primathon
bf5693f907
Reset table selected row when table data changes (#2307) 2020-12-23 09:28:23 +05:30
Sumit Kumar
53a6160139
Revert "Redshift plugin (#2112)" (#2314) 
This reverts commit 708ca7fedf.
 2020-12-22 16:59:18 +05:30
Sumit Kumar
708ca7fedf
Redshift plugin (#2112) 
1. Add new plugin to connect to AWS Redshift cluster and run query.
2. Add unit test cases.
 2020-12-22 15:35:25 +05:30
prapullac
91125ebc26
Manual test Ideas for home page (#2208) 2020-12-22 14:06:52 +05:30
Arpit Mohan
a942dc198e Revert "Onboarding flow (#1960)" 
This reverts commit e84699e7ba.

Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
 2020-12-22 13:02:02 +05:30
Shrikant Sharat Kandula
ea6e897dde
Firestore ADD_TO_COLLECTION command support (#2305) 
* Support ADD_TO_COLLECTION operation on Firestore

* Add test for Firestore add-to-collection command
 2020-12-22 12:32:14 +05:30
vicky-primathon
567f3a16fb
Fixed accessing length property of undefined selectedRowIndices (#2293) 
* Fixed accessing length property of undefined selectedRowIndices

* Added getting selectedRowIndices when multiRowSelection is true
 2020-12-22 08:27:57 +05:30
Shrikant Sharat Kandula
cfcd7aa0bb
Fix Firestore datasources not encrypting secret key JSON when editing (#2296) 
* Fix encrypted field not being ignored in JSON

* Don't mask error in decrypting

* Revert masking of error in decrypting
 2020-12-21 17:43:15 +05:30
Rishabh Saxena
42173e9249
fix tooltip boundary, don't show on target focus (#2250) 2020-12-21 15:22:58 +05:30
devrk96
851ae51c3a
Auto scroll to specific section on homepage when reloading with same url (#2115) 2020-12-21 14:35:58 +05:30
Piyush Mishra
9f0cc2f4bb
Wrap Query Table in ErrorBoundary (#2274) 2020-12-21 11:44:50 +05:30
Piyush Mishra
5408806bf1
Do not add objects to the DataTree (#2275) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-12-21 11:44:20 +05:30
Nidhi
e3cf285d1e
Fixed encryption related bugs for empty/new datasource (#2287) 2020-12-21 10:41:57 +05:30
Shrikant Sharat Kandula
fdc4f7b200
Fix invalid templates and API breaking on invalid templates (#2286) 2020-12-19 13:00:24 +05:30
Shrikant Sharat Kandula
5e04ca5c9d
Add ability to configure order of templates of plugins (#2279) 2020-12-18 20:45:08 +05:30
akash-codemonk
e84699e7ba
Onboarding flow (#1960) 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-12-18 18:48:47 +05:30
Nidhi
5a36d17f7a
Fixed encryption related bugs for empty/new datasource (#2272) 2020-12-18 16:13:01 +05:30
vicky-primathon
a6f602c33e
Fixed conversation of Unix timestamp in milliseconds (#2251) 2020-12-18 12:52:49 +05:30
Nidhi
a00c144e85
Subclassing authentication (#2215) 
* Sublcassing authentication

* Removed TODO

* Review changes
 2020-12-17 21:38:52 +05:30
Piyush Mishra
a3ed1515d5
Add headers null check (#2223) 
* @hetunandu for president
 2020-12-17 20:13:01 +05:30
Hetu Nandu
4b3a0ca9de
Fix table text pagination test (#2253) 2020-12-17 18:52:19 +05:30
Piyush Mishra
29de447411
Upgrade fusioncharts npm package (#2241) 2020-12-17 17:43:33 +05:30
NandanAnantharamu
db89dddbad
Organization test split into 2 parts (#2247) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-17 14:16:54 +05:30
Hetu Nandu
4f92ea99ed
Remove functions for action evals (#2242) 2020-12-17 13:36:16 +05:30
Pawan Kumar
e63f0a9d2a
Fix: 404 error page shows server unavailable (#2195) 
* mount error wise route

* remove log

* add test case

* fix wrong error page

* fix typescript error + remove unused variable

* remove 404 + 500 routes

* remove unused imports

* fix typo in test case

* remove history replace in utils

* remove unused variable

* add error codes for safe crash

* remove unused variables

* add error codes in all api rejects + update error reducer code type

* update error codes in init saga

* add selectors for error safe crash + take error logic out of app router

* remove unused variables

* remove extra line

* add header in error pag

* refactor page header on error page

* remove unused import

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-17 12:33:59 +05:30
NandanAnantharamu
4914e0a3f2
Updated tests from the functional tests (#2234) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-17 11:40:50 +05:30
Piyush Mishra
0ccc80127a
move null check out (#2221) 2020-12-16 14:52:34 +05:30
Rishabh Saxena
2f152bf5b1
fix prev widget hidden when dragging new (#2211) 2020-12-16 14:51:57 +05:30
Rishabh Saxena
17ded71de3
fix actions/queries not fetched after cloning a page (#2196) 
* fix actions/queries not fetched after cloning a page

* cf fix

* update type

* update test to check if api is cloned

* trigger tests
 2020-12-16 14:51:31 +05:30
Ashwani Sindhu
15a00f4982
Set document title as app name (#2203) 2020-12-15 16:54:44 +05:30
Rishabh Saxena
5c905ac0d8
Update styles for date time headers in a table (#2197) 2020-12-15 16:54:15 +05:30
Hetu Nandu
df902440f5
Add xml2json and json2xml functions (#2022) 2020-12-15 14:16:33 +05:30
Pawan Kumar
1cafbca767
Fix: The search in the multi select is not showing + Multi select dropdown stops functioning if default value is undefined (#2057) 
* fix dropdown input ghost width

* add fix when default option is undefined

* update test cases for dropdown undefined default value

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-15 10:34:51 +05:30
Pawan Kumar
ffc6c91150
Fix: Input Widget Regex validation not working as expected (#2165) 
* add check for custom regex when input is number

* add test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-15 10:34:30 +05:30
Hetu Nandu
5bd2cc1ea4
Execution params in actions (#2128) 2020-12-15 00:18:13 +05:30
Piyush Mishra
7826cee7c3
Null check on actionObj before using it (#2190) 2020-12-14 21:52:45 +05:30
Rishabh Saxena
20d15188fd
br instead of p on enter within rte (#2188) 2020-12-14 14:50:45 +05:30
Trisha Anand
29706f7852
Removing printing the result for firestore plugin (#2191) 2020-12-14 14:48:50 +05:30
Rishabh Saxena
29d87a88f0
unmount during drag (#2168) 2020-12-14 12:38:00 +05:30
NandanAnantharamu
095e7d3a8c
Added test for Org logo update and delete (#2177) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-14 11:50:44 +05:30
vicky-primathon
b917f71678
Added undefined check on selectedRowIndices property before checking its length (#2163) 2020-12-14 11:49:39 +05:30
Trisha Anand
e5c44168f3
Configured pool size for hikariCP when new pool comes uo. (#2170) 2020-12-14 11:07:53 +05:30
dependabot[bot]
17e8725a84
Bump ini from 1.3.5 to 1.3.8 in /app/client (#2176) 
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2020-12-13 11:10:46 +05:30
Arpit Mohan
7ae4959c29 Correcting the if clause for environment variable 2020-12-12 22:03:03 +05:30
Arpit Mohan
372774e728 Checking if the new run command works in Github Action 2020-12-12 20:48:21 +05:30
Piyush Mishra
22aa9756c1
Resize canvas on delete widget (#1958) 2020-12-11 19:18:01 +05:30
Piyush Mishra
2a05df86c7
Hotfix crash on navigate to API page after widget rename (#2134) 2020-12-11 18:04:06 +05:30
Arpit Mohan
75b3f18a92 Correcting github actions yaml. 
Really need a validator for this
 2020-12-11 17:41:39 +05:30
Arpit Mohan
7fbd14228d Correcting the node_modules cache for Cypress tests 2020-12-11 17:39:10 +05:30
prapullac
b27a32940e
Manual Test Ideas (#2129) 2020-12-11 17:25:54 +05:30
Arpit Mohan
51757072de Ignoring manual cypress tests during build 
Also correcting the node_modules cache during yarn install
 2020-12-11 17:10:05 +05:30
Nidhi
9a9feff678
Reset execute on page load for new actions (copied or otherwise) (#2162) 2020-12-11 14:33:07 +05:30
Arpit Mohan
b517639bd0 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-12-11 13:11:11 +05:30
Arpit Mohan
2951c609ec Correcting the APP_HOST in netlify for deploy previews 2020-12-11 13:10:55 +05:30
devrk96
7475aa643a
Fix: Org logo upload redux state (#2068) 2020-12-11 12:31:13 +05:30
Trisha Anand
74342f8598
Adding hikariCP for postgres (#2130) 2020-12-10 21:08:02 +05:30
Arpit Mohan
85d958c2c0
[CodeFactor] Apply automated fixes (#2131) 
Co-authored-by: codefactor-io <support@codefactor.io>
 2020-12-10 18:44:31 +05:30
Arpit Mohan
c1de6ce8f7 Fixing prettier errors in DynamicBindingUtils 2020-12-10 17:22:18 +05:30
Piyush Mishra
580c261e5d
copy tab data before mutating (#2084) 2020-12-10 14:21:54 +05:30
Hetu Nandu
f312320940
Remove unsafe functions from eval (#2076) 2020-12-10 14:00:49 +05:30
Pawan Kumar
5553da02e8
Fix: Page crashes on cloning the API (#2087) 
* fixed the page crashig on cloning the api

* adding test cases

* comment out the drag and drop test case in input spec

* update test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-10 13:52:40 +05:30
devrk96
8ef7405421
Fix: User icon numbers on home page (#2070) 2020-12-10 13:37:48 +05:30
devrk96
2995410d27
Fixing text overflow word-break property fixed. (#2116) 2020-12-10 13:36:13 +05:30
Rishabh Saxena
d7dea9aff4
fix toast message on widget cut (#2059) 
* fix toast message on widget cut

* show msg when widget not selected during cut/copy
 2020-12-10 13:03:43 +05:30
Piyush Mishra
0e47c0a4c0
Fix brackets mismatch (#2019) 2020-12-10 11:48:59 +05:30
Nikhil Nandagopal
9b51bf9af2
Merge pull request #2109 from appsmithorg/fix/boolean-validation 
Fix for false evaluated value showing as null
 2020-12-10 11:27:52 +05:30
Piyush Mishra
2b4e25b04a
default to empty array on usage (#2074) 2020-12-10 11:25:12 +05:30
NandanAnantharamu
9fb99c1145
Added tests for Table binding with Input Widget (#1955) 
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-12-10 10:52:19 +05:30
Hetu Nandu
74f8b51db3 Fix for false evaluated value showing as null 2020-12-09 22:25:59 +05:30
Trisha Anand
e97915c0a1 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-12-09 19:17:22 +05:30
Trisha Anand
746b0ab58e Changed log to sout in postgres plugin 2020-12-09 19:16:54 +05:30
Nikhil Nandagopal
8864a1eca2
Merge pull request #2101 from appsmithorg/fix/sentry-errors 
added code to prune payloads from sentry actions and reduce depth of …
 2020-12-09 19:11:34 +05:30
Trisha Anand
888d79b06d Removing printing of result objects from plugin execution. 2020-12-09 19:03:51 +05:30
Nikhil Nandagopal
d228f6d117 fix for undefined access to crash field 2020-12-09 18:22:36 +05:30
Nikhil Nandagopal
7d70a71d70 added code to prune payloads from sentry actions and reduce depth of actions reported 2020-12-09 14:42:12 +05:30
Nikhil Nandagopal
854d514359
Merge pull request #2094 from appsmithorg/fix/sentry-errors 
Prune expensive redux actions and console logs from sentry
 2020-12-09 13:06:54 +05:30
devrk96
fba79f960b
App icon and color name change issue resolved (#2089) 2020-12-09 12:36:02 +05:30
Nikhil Nandagopal
67fc762968 Merge branch 'release' into fix/sentry-errors 
# Conflicts:
#	app/client/src/sagas/ErrorSagas.tsx
 2020-12-09 12:34:08 +05:30
Nikhil Nandagopal
0fc5817caa added a check for errors without payloads 2020-12-09 12:32:27 +05:30
Nikhil Nandagopal
e0ac6e9850 Allowed console errors to still be logged 2020-12-09 11:59:40 +05:30
Nikhil Nandagopal
cfa020c063 pruned expensive redux actions and console logs from sentry 2020-12-09 11:50:39 +05:30
Rishabh Saxena
6a3b3c7cb8
treat false str as falsy for env vars (#2055) 
* check boolean env values against  string

* refactor parseConfig

* consistent bools

* return true/false for those strings
 2020-12-09 11:22:50 +05:30
Hetu Nandu
04e963c599
Fix for 502 errors from the server (#1949) 2020-12-09 00:43:48 +05:30
NandanAnantharamu
ec7149f9d8
Test case for creating multiple apps (#1871) 
* Added test for #1716

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-12-08 23:47:34 +05:30
Trisha Anand
8283396056
Moved from boundedElastic to elastic to ensure that the server services the plugin execution request as soon as the request arrives. (#2090) 2020-12-08 22:04:14 +05:30
Sumit Kumar
db3636f7b0
mysql plugin - check if connection is stale before running query (#2080) 
1. Check if mysql plugin connection is stale. If so, then return stale connection exception which triggers a retry after 
    establishing a new connection.
2. Refactor execute method code to remove code duplication.
3. Add a new test case to check if stale connection gets detected.
 2020-12-08 21:03:31 +05:30
Shrikant Sharat Kandula
4d24c8614f
Set random icons and colors for apps that are missing them (#2083) 2020-12-08 15:41:40 +05:30
Pawan Kumar
f8fd19d026
fix alignment of api editor response view (#2002) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-08 14:54:36 +05:30
Pawan Kumar
c67ada9a24
Fix/updating datasources does not update sidebar (#2018) 
* add check for datasources in memo equality check

* add test cases

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-08 14:54:02 +05:30
vicky-primathon
19d6ad695e
Table column max width limit removed (#2077) 2020-12-08 12:25:30 +05:30
Nikhil Nandagopal
0c1d914c38
Merge pull request #2064 from appsmithorg/fix/sentry-errors 
[Fix] reduced depth of information shared via sentry to prevent 413 errors
 2020-12-07 20:01:25 +05:30
Nikhil Nandagopal
03053d40c3 reduced depth of information shared to allow error sharing 2020-12-07 19:54:51 +05:30
Arpit Mohan
9d7a9d4aaf
Modifying the text for the roles in the share modal (#2045) 2020-12-07 16:16:43 +05:30
Pawan Kumar
e4b28172a7
add ellipsis in button (#2031) 
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-07 12:48:53 +05:30
devrk96
6cd44a5b84
Fix: Application name update checks (#1710) 2020-12-07 12:22:49 +05:30
devrk96
b7d77e15f1
Feature: New app icons and color palette (#2026) 2020-12-07 12:21:13 +05:30
Piyush Mishra
9ec030e101
null check for errors forEach(#2030) 2020-12-07 11:15:14 +05:30
Trisha Anand
b8b24604a6
[Bug] Update of an action leads to userSetOnLoad getting reset. (#2023) 
* Update of an action leads to userSetOnLoad getting reset.

* Added test case to assert the same.
 2020-12-04 13:07:34 +05:30
Sumit Kumar
b6abb8b067
Encode request body in Rest API plugin (#1988) 
1. Encode request body in REST API plugin when content header for URL encode is set.
2. Add a test case to test the encoding function.
3. Add a test case to check non-encoding (raw) function.
 2020-12-04 11:39:15 +05:30
Shrikant Sharat Kandula
4a57a739b6
Render templates directly without Mustache (#2010) 
* Render templates directly without Mustache

* Remove an unused variable
 2020-12-03 14:38:31 +05:30
Pawan Kumar
91127ed719
Fix: FilePicker widget was not setting loading state to true on calling action (#1985) 
* set loading state on calling action in file picker

* add test cases for file picker loading state

* add tests cases

* add isLoading state in state instead meta

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-03 11:02:50 +05:30
Hetu Nandu
6a7403d88e
Store tabs name data as array instead of string (#1676) 2020-12-02 18:23:51 +05:30
Shrikant Sharat Kandula
9bbbf37ae0
Fix #1597: Add a signed issuer token to proxied requests, if configured (#1953) 2020-12-02 18:20:57 +05:30
Sumit Kumar
d347448b24
Propagte mysql test datasource failure to UI. (#2001) 
1. Propagte mysql test datasource failure exception message to UI.
2. Change build TC to reflect the same.
 2020-12-02 17:53:38 +05:30
Arpit Mohan
a900b48712
Improving the text we see in the API and query settings pages (#1997) 2020-12-02 16:27:57 +05:30
vicky-primathon
6c19af7c24
Fix: Columns flicker when columns are resized or reordered (#1940) 
* Fixed flickering issue on column reorder and resize

* Disable sort when resizing column to stop flicker issue
 2020-12-02 16:14:56 +05:30
Pawan Kumar
066e20d0a2
Fix: Remove Fusioncharts Watermark (#1978) 
* Fusion charts watermark can be removed by adding the `APPSMITH_FUSIONCHARTS_LICENSE_KEY` env variable.

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-02 16:12:51 +05:30
akash-codemonk
afa81d9eaf
Datasource form bug fixes (#1986) 
* Datasource form fixes #1967 and fixes #1966
* Add tests for scenarios in #1967 and #1966
 2020-12-02 16:06:35 +05:30
Piyush Mishra
1eddc0c7d1
Faster recompile with cached eslint (#1987) 2020-12-02 11:57:56 +05:30
imgbot[bot]
4fa2fd4ba6
[ImgBot] Optimize images (#1993) 
*Total -- 307.73kb -> 177.70kb (42.25%)

/deploy/heroku/images/app-settings.png -- 215.56kb -> 118.43kb (45.06%)
/deploy/heroku/images/finish.png -- 33.21kb -> 19.53kb (41.19%)
/deploy/heroku/images/add-domain-form.png -- 29.12kb -> 18.04kb (38.06%)
/deploy/heroku/images/add-domain-button.png -- 29.37kb -> 21.23kb (27.71%)
/app/client/src/assets/icons/ads/upload.svg -- 0.47kb -> 0.47kb (0.62%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-12-02 11:50:10 +05:30
Sumit Kumar
b3c3102c72
Add tests for mysql plugin to test all regularly used data types in mysql. (#1994) 2020-12-02 11:49:41 +05:30
satbir121
8afa900044
Filepicker component and logo upload for org (#250) 2020-12-02 03:31:27 +05:30
devrk96
5d820c7203
Fix: Organization rename and toast issues (#1954) 
* Toast message removed when renaming an organization
 2020-12-02 03:30:29 +05:30
Hetu Nandu
29d0c49962
Wait for eval before executing the next evaluation (#1959) 2020-12-01 16:09:55 +05:30
Pawan Kumar
43f821fddc
Fix: test cases for datepicker (#1977) 
* clear cache values on delete

* added test cases

* add reload in test case

* fix test cases for datepicker spec

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-01 12:10:31 +05:30
Pawan Kumar
1aea90c404
Fix: Persist of default values even after delete of widget (#1929) 
* clear cache values on delete

* added test cases

* add reload in test case

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-12-01 10:56:35 +05:30
Piyush Mishra
400fd8007f
Make sure google is available before loading components that rely on it (#1934) 2020-11-30 12:53:05 +05:30
Sumit Kumar
883fa44896
Make sql plugin use R2DBC driver instead of JDBC driver (#1936) 
1. Add R2BC driver and remove JDBC driver usage in mysql plugin to make the plugin reactive.
2. Update dependencies in POM file.
3. Update mysql plugin to return result based on the type of sql query i.e select vs other queries. In case the queries are chained, then the last query is used for deciding the type.
4. Added a new TC for testing datasource and removed a non functional TC.
 2020-11-28 18:04:56 +05:30
Hetu Nandu
f248304720
Using --no-cache option for jest tests 2020-11-28 10:37:10 +05:30
Piyush Mishra
b199c539be
Fix setup for local linux server (#1948) 2020-11-27 14:49:09 +05:30
Nidhi
6c974408bd
Added IntelliJ run configuration for an easier getting started experience for contributors (#1944) 
* Added run configuration for IntelliJ

* Added instructions for run config
 2020-11-27 14:31:09 +05:30
Abhinav Jha
55ef8a0084
Loop sagas to respawn when they crash (#1880) 
* Added Sentry logging

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-11-27 14:21:08 +05:30
Pawan Kumar
9997f2cb9f
Feature: Min and Max date inputs to restrict range in Datepicker Widget (#1865) 
* add daterange property control

* fix typescript errors

* update daterangepicker control

* remove daterangepicker control

* add toasts for invalid dates + add test cases

* update test cases

* update test cases

* update test cases + change validation type name + few refactor

* merge release + update toast usage in datepicker control

* update test cases

* update form dsl for test cases

* update test cases

* update setDate command in test cases

* update test cases

* update test case dsl for datepicker widget

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-27 14:18:38 +05:30
akash-codemonk
49026d9b3c
Sava api with datasource without having to click on save datasource (#1930) 2020-11-27 11:06:16 +05:30
Nikhil Nandagopal
9c29b83d07
Fixed Action selector function arg splitting regex to include arrays and objects (#1893) 
- Also added navigateTo params field
 2020-11-27 10:30:53 +05:30
imgbot[bot]
f073698fcc
[ImgBot] Optimize images (#1928) 
*Total -- 316.18kb -> 175.10kb (44.62%)

/deploy/aws_ami/images/system-log.png -- 136.77kb -> 73.60kb (46.19%)
/deploy/aws_ami/images/select-system-log.png -- 178.91kb -> 101.01kb (43.54%)
/app/client/src/assets/icons/ads/warning.svg -- 0.49kb -> 0.49kb (0.6%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-11-26 18:43:05 +05:30
Trisha Anand
2062c60ca3
Moved all the scheduling of the plugin executions to bounded elastic instead of elastic. (#1931) 2020-11-26 17:50:43 +05:30
Pawan Kumar
7a7fb4547f
Fix: isRequired validation of checkbox widget (#1884) 
* fix checkbox required issue

* add test case

* update error styling for checkbox

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-26 16:51:23 +05:30
NandanAnantharamu
a64069b9f2
Added test for Tab and input widget binding (#1912) 
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-26 15:15:03 +05:30
NandanAnantharamu
7a73763aea
Feature/pageload usecase (#1750) 
* Usecase for pageload Api and input widget

* Updated test name

* updated tests

* Updated assertion

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-25 21:40:31 +05:30
Piyush Mishra
d9e7baea45
Fix infinite loop crash on widget drag (#1916) 2020-11-25 21:32:54 +05:30
devrk96
461b662c7a
Feature: Rename organization in homepage (#1201) 2020-11-25 17:54:14 +05:30
Nikhil Nandagopal
8109b3b001
Merge pull request #1836 from vvkpd/show-number-of-records 
show number of the records
 2020-11-25 12:31:46 +05:30
Nikhil Nandagopal
25e9516315
Update TableHeader.tsx 2020-11-25 12:06:27 +05:30
Nikhil Nandagopal
610ea6c1f7 minor fix for user ids being sent 2020-11-24 21:10:50 +05:30
Vivek Pandey
1bdefc0094 removes show label from header 2020-11-24 20:05:34 +05:30
Nikhil Nandagopal
c77c43cfee
Merge pull request #1892 from appsmithorg/fix/tabs-selectedTab 
Fix selectedTab binding issue
 2020-11-24 19:06:10 +05:30
Piyush Mishra
dbf947a1a6
Hotfix for mac start-https.sh script (#1891) 2020-11-24 18:58:05 +05:30
Abhinav Jha
bddc79aee8 Fix selectedTab binding issue 2020-11-24 18:20:08 +05:30
Piyush Mishra
e7c465eaae
Add support for WSL local dev (#1756) 
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2020-11-24 16:45:33 +05:30
Piyush Mishra
7376ada1b1
[Documentation] Use env variables in Cypress tests (#1887) 2020-11-24 16:44:38 +05:30
Piyush Mishra
03f97c0323
Fix: Maps widget crash on wrong initial location datatype (#1854) 2020-11-24 14:13:45 +05:30
devrk96
fee1a4518f
Feature: Toast component (#476) 2020-11-24 12:31:37 +05:30
Arpit Mohan
36af9d5c5e Correcting the placeholder in firestore form.json 2020-11-24 11:00:27 +05:30
Nikhil Nandagopal
6da629d441 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-23 18:48:00 +05:30
Nikhil Nandagopal
9cc5a20190 added source to user object 2020-11-23 18:47:12 +05:30
Shrikant Sharat Kandula
74cd362057
Firestore Integration (#1799) 
* Adding the skeleton for Firestore integration

* Adding the datasource & query editor forms

Also adding the database changelog for the firestore plugin

Commenting out the firestore.close() connection because that causes issues with multiple Firestore tenants running in the same JVM.

* Adding the code for fetching the structure of collections from Firestore

* Use single document path field for Firestore

* Fix potential NPE when datasource destroy timeouts

* Work in progress on collection level ops for Firestore

* Get documents in a collection now works

* Add collection level querying support

* Mild refactoring

* Fix NPE when some fields are missing

* Hide clientJSON as a password field for Firestore

* Make collection level querying reactive

* Make reactive

* Validate before connecting

* Add tests for all supported methods in Firestore

* Fix forms for Firestore with hidden fields

* Hide limit and order by fields when not needed

* Restore log entry deleted by mistake

* Use S3 URL for Firestore/Firebase logo

* Add comments detailing why some code is commented

* Make parsing JSON reactive and fix subscribe calls

* Fix reactive scheduler

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-11-23 18:42:33 +05:30
Trisha Anand
c07264f1c1
Making Redis plugin blocking statements run on elastic thread pool (#1850) 2020-11-23 17:03:04 +05:30
Trisha Anand
772884e1a3
Making dynamo db's blocking commands run on elastic thread pool. (#1853) 2020-11-23 17:02:41 +05:30
Trisha Anand
d8cba1bf8c
Making MySql blocking commands run on elastic thread pool (#1862) 2020-11-23 17:02:18 +05:30
Trisha Anand
0bb99dd087
Elastic search plugin's blocking calls moved to elastic scheduler thread (#1855) 2020-11-23 17:01:34 +05:30
Pawan Kumar
ad52842e1c
Fix/entity name coincide issue 1396 (#1781) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* add check if name is conflicting with internal fn

* use already existing selector

* add conflicting names checks on api/queries/widget names

* add test cases for invalid widget/api/query names

* refactor

* change array to map

* remove getDataTreeKeys selector

* refactor

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-23 14:57:00 +05:30
Piyush Mishra
5efcb47486
Improve test automation docs (#1838) 
* improve docs with link to client setup and change cypress.env.json instead of editing cypress.json file

* fix link to client setup

* improve ordering

* rearrange

* fix quotes

* remove unlinkable link

* fake push
 2020-11-23 13:58:26 +05:30
akash-codemonk
294348e1f9
Query pane plugin form should be initializable (#1802) 2020-11-23 11:58:15 +05:30
Trisha Anand
242afd5753
Making MS-SQL plugin blocking statements run on elastic thread pool (#1827) 
* MS-SQL Plugin now creates connection and executes statements over elastic thread pool.

* Added a test to ensure that throwables are clean.
 2020-11-23 11:28:01 +05:30
Trisha Anand
dc7a375543
Making postgres plugin blocking statements run on elastic threadpool. (#1821) 
* Making postgres plugin blocking statements run on elastic threadpool.

* Moved the blocking calls to check for the connection validity, etc. also inside the Mono.fromCallable
 2020-11-23 11:27:52 +05:30
Trisha Anand
c2d1ac973c
Adding thread name to the context of logs to allow for the thread names to be printed for each log. (#1824) 2020-11-23 10:45:15 +05:30
Vivek Pandey
0a35ecdcaf show number of the records 2020-11-22 20:16:27 +05:30
Nikhil Nandagopal
6487508e0c
Merge pull request #1823 from appsmithorg/fix/rte-linebreaks 
Fix RTE line break issue
 2020-11-20 17:27:51 +05:30
Abhinav Jha
3064a1865a Fix RTE line break issue 
Fix issue where empty defaultValue wasn't getting updated
 2020-11-20 17:08:51 +05:30
Hetu Nandu
ff541c3efa
Patch object order issue (#1819) 2020-11-20 15:00:50 +05:30
Hetu Nandu
9ef9d184ff
Pass execution params to action callback (#1814) 2020-11-20 13:57:46 +05:30
Trisha Anand
882df291d7
[Bug Fix] Indices not working for fetching actions during update layout (#1813) 
Instead of using compound index, using single indices to ensure that both fetch actions by app id (during load of actions in edit/view mode) and fetch actions by page id (during update layout) are indexed queries.
 2020-11-20 13:30:17 +05:30
vicky-primathon
3b85cc8222
Added defaultSelectedRow property in table widget so that users can configure default selected row(s) (#1684) 
* Added defaultSelectedRow property in table widget so that users can configure default selected rows

* Cypress test cases added to test default row selection in table widget

* Fix defualtSelectedRow property's evaluation type

* Fix default select row type

* Set default selected row when resetting user selected rows

* Use defaultSelectedRow when no user selected row in table
 2020-11-20 13:13:39 +05:30
devrk96
0da8c84ae1
Fix: App card boundaries UI (#1798) 
* Hover ui fixed on all sides of app card
 2020-11-20 12:45:48 +05:30
devrk96
879258b74f
Theme flag stored in localStorage cleared when logging out (#1796) 2020-11-20 12:45:04 +05:30
Trisha Anand
63fe27fae1
[Bug Fix] : Clone Application creates corrupted clone when interrupted. (#1800) 
* Doing a deep copy during clone application instead of updating the original application which may have been causing a concurrency bug.

* Ensuring that once the clone application flow is triggered, the flow completes eventually even if the client cancels the request before completion.

* Cloned application would not be public.

* Added parametrized Application constructor

* Removed lombok all args constructor

* Optimized import

* Incorporated review comments :
1. Updated the constructor for creating the application
2. Added a test case to assert that if during cloning of an application the flow gets cancelled, the cloning would still complete and ensure that the application created is sane.
 2020-11-20 10:55:59 +05:30
Sumit Kumar
b03e815952
Change Sentry log 'environment' tag value. (#1789) 
* Change Sentry log 'environment' tag value.

1. Change Sentry log 'environment' tag value to 'Properties' from 'properties'.
 2020-11-19 17:29:48 +05:30
akash-codemonk
26e793a86a
Show api datasource list on focus (#1668) 2020-11-19 17:11:06 +05:30
akash-codemonk
2ded99f9ac
Fix store as datasource (#1772) 2020-11-19 17:00:22 +05:30
Pawan Kumar
5f1b398d34
Fix/truncated page name in appviewer issue 1597 (#1770) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* show popover on truncated page name in appviewer

* move testcases to Pages_spec.js

* fix ref issue + test cases

* fix test case

* update test case

* fix test case

* fix merge conflict typo

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-19 16:08:09 +05:30
akash-codemonk
acb3c42d66
Highlight matching brackets in editor (#1613) 2020-11-19 13:24:21 +05:30
akash-codemonk
6dc7e42ce9
Remove api datasource from add datasource page (#1639) 
* Show only db datasources in the create datasource page

* Remove invalid test
 2020-11-19 13:22:44 +05:30
akash-codemonk
32482d4826
Fix datasource name getting focused after save while creating new datasource (#1793) 2020-11-19 13:04:19 +05:30
akash-codemonk
732dc632cd
Show callout only for db datasources (#1792) 2020-11-19 10:49:36 +05:30
akash-codemonk
c3c7b9b7d7
Add new property to conditionally hide form fields in datasource and editor (#1682) 
* Create a form control component which handles the hidden logic

* Add tests
 2020-11-19 09:02:58 +05:30
Arpit Mohan
9772d64c5b
Disable instance ping check when the disableTelemetry flag is set (#1776) 
Also adding the APPSMITH_SEGMENT_CE_KEY as a build arg to the server Dockerfile. This will be used to set the environment variable in the Docker image itself.
 2020-11-19 08:54:03 +05:30
Piyush Mishra
5b684b857e
Add placeholders on curl import and API create form (#1738) 
* adds placeholder on curl import form

* add placeholder to api creation form as well
 2020-11-19 05:48:54 +05:30
Abhinav Jha
93ac625135 Hide appviewer header if queryparams has embed 2020-11-18 18:55:25 +05:30
Vivek Pandey
de435ed009
Show number of records instead of pages in the table widget (#1734) 2020-11-18 18:20:04 +05:30
Hetu Nandu
2538444e20
Remove old derived value bindings from test DSLs (#1757) 2020-11-18 18:18:07 +05:30
Sumit Kumar
2c6d1bb361
Fix mongodb datasource test. (#1783) 
1. Fix mongodb datasource cypress test failure.
2. Against certain mongodb instances, we expect to receive an exception of type "unauthorized" when testing datasource. Earlier, this case was caught and whitelisted until the recent change to replace mongodb infra with reactive mongodb infra.
 2020-11-18 16:55:39 +05:30
Nidhi
941be8c58d
Fixed check for incorrect dynamic bindings (#1775) 
* Fixed check for incorrect dynamic bindings
 2020-11-18 14:25:55 +05:30
Shrikant Sharat Kandula
f36adeb6b5
Fix #1766: cURL parser eats backslashes in single-quotes (#1768) 2020-11-18 11:20:23 +05:30
Shrikant Sharat Kandula
2ca15ba57d
Fix #1758: columns duplicated in Postgres structure (#1767) 2020-11-18 11:19:55 +05:30
Sumit Kumar
2c2aa06e32
Add support for reactive streams with mongodb. (#1720) 
Add support for reactive streams with mongodb. (fixes 1480)

1. Replace mongodb driver with reactive mongodb driver. Change APIs accordingly.
2. Use webflux + reactor framework to execute mongodb queries in event loop model.
3. Add test to test MongoPluginExecutor class' method "testDatasource".
 2020-11-18 10:58:50 +05:30
Trisha Anand
fc3197b78f
Email sending is now non-blocking. The blocking code for email sending is triggered and then immediately returned. (#1762) 2020-11-18 00:31:39 +05:30
Arpit Mohan
c3a44651f2
Adding null check for dynamic binding path list (#1752) 
* Adding null check for dynamic binding path list.

* Increased timeout duration for failing test

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
 2020-11-17 15:38:48 +05:30
Trisha Anand
6ac04d8a9e
Added SLA bucket for metric evaluation for 1 second (#1740) 2020-11-17 12:47:49 +05:30
Pawan Kumar
6e4c6824ef
Fix/truncated page name in appviewer issue 1597 (#1742) 
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* show popover on truncated page name in appviewer

* move testcases to Pages_spec.js

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-17 12:03:10 +05:30
Nidhi
9de085f264
Switched to using dynamicBindingPathList for generic scan, supports DB queries and nested structures 
* Switched to using dynamicBindingPathList for generic scan
 2020-11-17 11:26:08 +05:30
Piyush Mishra
49c24c7654
Force redirect https on development nginx server (#1733) 2020-11-16 19:01:33 +05:30
Trisha Anand
a722b08002
Adding index for unpublishedAction.pageId to bring down the number of documents fetched in mongo db query during update layouts' fetching actions on page load. (#1739) 2020-11-16 18:59:04 +05:30
Arpit Mohan
955f80925f
Fixing the telemetry on self-hosted instances (#1714) 2020-11-12 19:01:40 +05:30
Abhinav Jha
0f4269891f
Fix issue where creating a new application twice does not work (#1713) 2020-11-12 18:58:12 +05:30
akash-codemonk
86a419d42a
Add the error style to bindings (#1711) 2020-11-12 18:53:49 +05:30
Pawan Kumar
fc29a31cd4
Fix/show two whitelist ips issue 1632 (#1705) 
* add second whitelist ip for create datasource page

* revert the cloudhosting check on help button

* update name of util function

* remove unused key

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-12 17:35:19 +05:30
NandanAnantharamu
da9ef2cb2d
Added a check for zoom feature test (#1703) 
* Added a check for zoom feature test

* Added another click for zoom-in check

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-12 17:34:44 +05:30
Pawan Kumar
7bc4697545
Fix/help modal fab button toggle issue 1681 (#1692) 
* change icon to close on opening help modal

* fix help modal icon bug

* add test cases for the fab buttont toggle issue

* fix padding + closing lag issue of help modal

* pass isOpen true all the time

* fix help modal button hover issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-12 16:56:54 +05:30
Hetu Nandu
37c2246e22
[Enhancement] Update DSL structures to allow for nested dynamic paths (#1625) 
Implements #1575
 2020-11-12 16:53:32 +05:30
akash-codemonk
1510c21a7d
Add a back button to the datasources page (#1702) 2020-11-12 15:36:13 +05:30
Rohit Kumawat
175d43aad3 limit added for showing user icons in an organization 2020-11-12 15:01:51 +05:30
Arpit Mohan
073555ee8a
Moving all telemetry check to the configs class (#1700) 
Now we enable/disable all analytics in a central location in the configs class. This ensures that each analytics function can simply check it's own value and not worry about checking for the disableTelemetry flag
 2020-11-12 11:56:09 +05:30
Nikhil Nandagopal
e411df0a64
Added check so that existing installs don't get telemetry (#1698) 
* Adding the segment key to the tagged release
* Also opting out of telemetry data in CI builds

Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-11-11 23:54:19 +05:30
Arpit Mohan
cb4b3b2753 Dummy commit to trigger CI build 2020-11-11 19:43:25 +05:30
Hetu Nandu
a51082fb54 Merge branch 'master' into release 2020-11-11 18:51:03 +05:30
devrk96
73869eee69
Feature: Show org user icons on homepage (#1685) 
* Displaying org user icons feature is implemented

* using username if name not found in user details

* Share user icon cypress test implemented
 2020-11-11 18:42:05 +05:30
Abhinav Jha
a4f652ce70
Add client-max-body-size directive to nginx https proxy (#1695) 2020-11-11 18:23:48 +05:30
Nikhil Nandagopal
5a903a6976 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-11 18:07:57 +05:30
Nikhil Nandagopal
a1d6b0232b enabled perf for sentry 2020-11-11 18:07:40 +05:30
akash-codemonk
aefafd33dc
Fix switching datasource in the query pane (#1636) 2020-11-11 17:59:26 +05:30
Hetu Nandu
b1c8008c3d Add null check for evaluated value in Chart Data Control (#1675) 
Fixes: #1672, #1666
 2020-11-11 17:28:26 +05:30
Hetu Nandu
3a84af82ed
Fix critical issues (#1686) 
Fixes #1683
Fix for dropdowns with option not being an object crashes dropdown and stops eval
Fixes #1656 #1657
Fix issue where updateWidgetProperty would get called without a widgetId
 2020-11-11 17:02:14 +05:30
Pawan Kumar
392de2b840
Fix/on date selected call issue 987 (#1691) 
* fix onSelectedDate call on deselection of date

* add test cases for deselecting the datepicker widget issue

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
 2020-11-11 16:59:45 +05:30
Arpit Mohan
166ee73c9f
Moving the intercom initialization to the body in index.html (#1690) 
This is to allow us to enable/disable Intercom chat based on the APPSMITH_INTERCOM_APP_ID and APPSMITH_CLOUD_HOSTED environment variables.
 2020-11-11 15:49:21 +05:30
NandanAnantharamu
d5ce1dfa52
Added tests for dependencies (#1679) 
* Added tests for dependencies

* updated review comments

* moved files to binding folder

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-11-11 15:44:01 +05:30
Nikhil Nandagopal
3c37645d12
Merge pull request #1674 from appsmithorg/fix/switch-content-type 
Fix incorrect bodyFormData values being sent
 2020-11-10 19:20:11 +05:30
Pawan Kumar
dace2a6a55
Merge pull request #1671 from appsmithorg/pawan/issue-720 
Fix long app names not visible issue
 2020-11-10 17:26:41 +05:30
Pawan Kumar
42fe5f4543 update test cases for the issue + typo fix 2020-11-10 16:59:34 +05:30
Akash N
06d330ef3a actionConfiguration.body shouldn't be reset 2020-11-10 16:42:31 +05:30
Pawan Kumar
8b7e7d2993 incorporate code reviews feedbacks 2020-11-10 15:58:21 +05:30
Akash N
6c0d0e228c Add test 2020-11-10 15:11:05 +05:30
Pawan Kumar
426bb0b8df clear search input in test cases 2020-11-10 15:08:47 +05:30
Akash N
3fbcf667b6 Do not reset the bodyFormData value 2020-11-10 14:58:14 +05:30
Nikhil Nandagopal
5e17450e2f
added check for no matches (#1673) 2020-11-10 14:52:35 +05:30
Pawan Kumar
3a708497dd add a max-width on tooltip component 2020-11-10 14:16:57 +05:30
Hetu Nandu
a52c5df987 Fix form widget eval loops for arrays 2020-11-10 13:23:18 +05:30
Sumit Kumar
2dc2615311
Replace Rollbar with Sentry (#1606) 
* Replace Rollbar with Sentry

1. Log exceptions using Sentry instead of Rollbar.
2. Remove all Rollbar infra.
 2020-11-10 09:59:10 +05:30
Pawan Kumar
ec49c358c4 Fix app name too long issue 2020-11-09 17:00:34 +05:30
Hetu Nandu
977405a720
Create app crash boundary (#1629) 2020-11-09 14:53:20 +05:30
Hetu Nandu
9f0363812e
Default page id fixes (#1628) 
* Fix App invite form not getting the correct page id

* localise confusing getDefaultPageId function

* Remove old fetch application workflow action
 2020-11-09 14:22:44 +05:30
Nidhi
1741e61ba0
Added user roles list to application fetcher (#1624) 
* Added user roles list to application fetcher

* Fixed blanket import
 2020-11-09 11:54:30 +05:30
Nidhi
62e4e28c8e
Fixed upload logo payload limit and added delete logo API (#1574) 
Also changed name of default organization to xyz's apps
 2020-11-09 07:52:08 +05:30
vicky-primathon
fd12e907af
Map not resetting to location selected fix. Location map to search location. (#1619) 2020-11-06 20:39:35 +05:30
Abhinav Jha
b549978fdf
Fix issue where clicking on widget add button redirects to the homepage (#1620) 2020-11-06 20:38:11 +05:30
vicky-primathon
e82b0c42e3
Fix distortion due to table scrollbar (#1608) 2020-11-06 16:48:04 +05:30
vicky-primathon
54a6ca0850
Fix/table widget pagination changes (#1298) 2020-11-06 16:45:47 +05:30
Nikhil Nandagopal
6121e6938e
Merge pull request #1576 from appsmithorg/fix/button-ui-invite-modal 
Fix: Invite modal cancel button UI
 2020-11-06 15:04:10 +05:30
Hetu Nandu
2820413b7d
Fix bad fix for show alert issue #1583 (#1614) 2020-11-06 14:57:10 +05:30
Hetu Nandu
f0862652c3 Fix for btoa / atob functions 2020-11-06 14:50:07 +05:30
Rohit Kumawat
f321b6e759 Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/button-ui-invite-modal 2020-11-06 14:31:50 +05:30
Nikhil Nandagopal
72334ca8ad
Merge pull request #1612 from appsmithorg/fix/atob-btoa-not-working 
Remove extra dependency and use browser atob and btoa
 2020-11-06 14:28:21 +05:30
Hetu Nandu
f99291ea2d Revert "Fix still crashing for #1583" 
This reverts commit 2c88f11ed4.
 2020-11-06 14:17:26 +05:30
Nikhil Nandagopal
7816f2c1f7
Merge pull request #1592 from appsmithorg/feat/sticky-header 
Show query form headers while scrolling
 2020-11-06 14:09:53 +05:30
Hetu Nandu
2c88f11ed4 Fix still crashing for #1583 2020-11-06 14:08:22 +05:30
Hetu Nandu
9cc94777f2 Remove extra dependency and use browser atob and btoa 2020-11-06 14:04:10 +05:30
Nikhil Nandagopal
5e84dcaa95
Merge pull request #1557 from appsmithorg/feature/telemetry 
Adding telemetry for community edition
 2020-11-06 13:57:18 +05:30
Arpit Mohan
17ffcd946e Increase the timeout while waiting for containers to start 2020-11-06 13:33:35 +05:30
Rohit Kumawat
64d053de6e variable name corrected 2020-11-06 13:23:38 +05:30
Nikhil Nandagopal
2a8e756149 added caching for analytics hash 2020-11-06 11:57:36 +05:30
Rohit Kumawat
d85351526d Merge branch 'release' of https://github.com/appsmithorg/appsmith into fix/button-ui-invite-modal 2020-11-06 08:47:59 +05:30
Nikhil Nandagopal
daeb9ed4be Merge branch 'feature/telemetry' of github.com:appsmithorg/appsmith into feature/telemetry 2020-11-05 22:21:35 +05:30
Nikhil Nandagopal
430dfc00ea updated analytics checks 2020-11-05 22:21:22 +05:30
Arpit Mohan
a944680d50 Adding the disable telemetry config in the env example 2020-11-05 22:01:58 +05:30
Arpit Mohan
12f3a4182c Fixing the tests and adding the segment key in the yarn build 
This key will be burned into the Docker image itself.

Also adding the disable telemetry link to the nginx_app template during self-hosted deploys.
 2020-11-05 20:32:25 +05:30
akash-codemonk
86cac0fae3
Add test for showBindingPrompt function (#1566) 2020-11-05 19:15:40 +05:30
Nikhil Nandagopal
7ed8d3db9b fixed conf 2020-11-05 18:10:04 +05:30
Hetu Nandu
c1ff711a45 Fix build errors 2020-11-05 17:58:39 +05:30
Nikhil Nandagopal
08b755bdcb
Merge pull request #1591 from appsmithorg/fix/args 
Fix for args not splitting correctly with empty values
 2020-11-05 17:52:35 +05:30
Hetu Nandu
20f357ae35
Add checks for wrong alert types of Toast messages (#1588) 
Fixes #1583
 2020-11-05 17:19:37 +05:30
Nikhil Nandagopal
5e93815276 added segment CE and telemetry flags 2020-11-05 16:58:17 +05:30
Nikhil Nandagopal
2c111edbba fix for tests 2020-11-05 16:56:00 +05:30
imgbot[bot]
96fcf65f04
[ImgBot] Optimize images (#1558) 
/app/client/src/assets/images/timeout-image.png -- 109.72kb -> 86.13kb (21.51%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-11-05 16:46:54 +05:30
Akash N
01303e6716 Merge branch 'release' of https://github.com/appsmithorg/appsmith into feat/sticky-header 2020-11-05 16:17:59 +05:30
Nikhil Nandagopal
6d6ef35b7c
Merge pull request #1518 from sumanthyedoti/fix/tabs-widget-corners 
fix/tabs widget corners
 2020-11-05 15:51:41 +05:30
Nikhil Nandagopal
a110a23574
Merge pull request #1169 from daniel-shuy/fix/download-file-type-dropdown-optional 
Allow Download File Type dropdown to be deselected
 2020-11-05 15:47:18 +05:30
Nikhil Nandagopal
39331d95b2 fix for args not splitting correctly with empty values 2020-11-05 15:46:38 +05:30
Akash N
abd3bf248a Add the output the query to the content of the query tab to have a sticky header like UI 2020-11-05 14:38:52 +05:30
Trisha Anand
24582a2e58
Adding server side performance tooling using spring metrics. (#1562) 
* Experimenting with spring metrics, prometheus

* Added prometheus config in application.properties.

* Added a few more configurations for spring metrics to improve performance tooling.

* Added basic authentication to allow prometheus to scrape our monitoring data in an authenticated fashion.

* Only exposing prometheus end point at this junction instead of other metric endpoints as well.

* Fixed test case which failed because of actuator instantiating bean.
 2020-11-05 14:33:40 +05:30
Rohit Kumawat
5eff7e7970 cancel button text color fixed 2020-11-05 12:34:44 +05:30
Nikhil Nandagopal
274e2bc5cd updated telemetry check 2020-11-05 11:41:29 +05:30
Nikhil Nandagopal
409c4ad9b7
Merge pull request #1571 from appsmithorg/fix/org-setting-field-validation 
Fix: Field Issues in Organization's General Tab
 2020-11-05 11:31:33 +05:30
Nikhil Nandagopal
6206da646a
max height is fixed for users list in invite modal (#1572) 2020-11-05 11:29:39 +05:30
devrk96
06f106090b
underline css fixed (#1570) 2020-11-05 11:27:27 +05:30
Arpit Mohan
b3eabf68ea Moving the segment CE key to a build time variable instead of hard coding it 2020-11-05 10:54:30 +05:30
Sumanth Yedoti
851f94842e fix: tabs height 2020-11-05 10:17:55 +05:30
Arpit Mohan
994d57422b Fixing the jest test in AnalyticsUtil 2020-11-05 08:01:01 +05:30
Sumanth Yedoti
db4e09bb1e resolve merge conflict 2020-11-04 23:09:05 +05:30
Sumanth Yedoti
6d55b37b0d fix: add shadow to TabsWidget 2020-11-04 23:03:32 +05:30
Sumanth Yedoti
cac499c9ad fix(Widgets): add rounded corners and improve overall style for TabsWidget 2020-11-04 22:53:08 +05:30
Yedoti Sumanth
f4bed59ba0 style: remove extra red border to Tabs Widget 2020-11-04 22:52:22 +05:30
Yedoti Sumanth
91eec61608 fix(EnitityExplorer): remove scrollbar when content does not overflow 2020-11-04 22:52:22 +05:30
Yedoti Sumanth
97e4168523 fix(Widget): add rounded corners to Tabs Widget 2020-11-04 22:52:21 +05:30
Sumanth Yedoti
60bbc963dc fix(Widgets): add shadow to TabsWidget 2020-11-04 22:51:59 +05:30
Sumanth Yedoti
41a2a53bf1 fix(Widgets): add rounded corners and improve overall style for TabsWidget 2020-11-04 22:51:58 +05:30
Sumanth Yedoti
a3d7cdb769 style: remove extra red border to Tabs Widget 2020-11-04 22:51:57 +05:30
Yedoti Sumanth
41411bddcb fix(Widget): add rounded corners to Tabs Widget 2020-11-04 22:51:57 +05:30
Rohit Kumawat
e40db8b92c max height is fixed for users list in invite modal 2020-11-04 22:36:29 +05:30
Rohit Kumawat
ea87b38077 organization label fixed 2020-11-04 21:36:44 +05:30
Rohit Kumawat
560fd9155b field validation fixed in email and white space removed 2020-11-04 21:36:06 +05:30
NandanAnantharamu
ec50857d15 commented AddWidget_spec (#1559) 2020-11-04 20:23:23 +05:30
NandanAnantharamu
37dc0ba4e4 Updated a binding and commented out failing test (#1546) 2020-11-04 20:23:13 +05:30
Arpit Mohan
0b5250529a Moving the getAppsmithConfig function to static function in index.ts 2020-11-04 20:03:17 +05:30
Abhinav Jha
dc7f055612 Handle null regex parts in input widget regex function (#1569) 2020-11-04 19:51:40 +05:30
Abhinav Jha
e14f23c31d
Handle null regex parts in input widget regex function (#1569) 2020-11-04 19:49:46 +05:30
Arpit Mohan
ce24f37d43 Merge branch 'release' into feature/telemetry 2020-11-04 19:08:05 +05:30
Abhinav Jha
1747390183
Fix: All canvas widgets should have no container styling applied (#1564) 2020-11-04 18:58:21 +05:30
Arpit Mohan
946b3ba25f Merge branch 'release' into feature/telemetry 2020-11-04 18:02:25 +05:30
Daniel Shuy
2c5e74313c Add default empty selection for FILE_TYPE_OPTIONS 2020-11-04 20:23:56 +08:00
Arpit Mohan
1413203251 Adding the check for disabling telemetry if the environment variable is set 2020-11-04 17:50:14 +05:30
NandanAnantharamu
af5ec1363e
commented AddWidget_spec (#1559) 2020-11-04 17:45:41 +05:30
Sumit Kumar
6db7101662
Report selective errors to rollbar. (#1516) 
* Report selective errors to rollbar.

1. Assign an action attribute to each AppsmithError enum item. Take action based on the action attribute.

* Fixing the condition for organization name being empty

* Report selective errors to rollbar.

1. Assign an action attribute to each AppsmithError enum item. Take action based on the action attribute.

Co-authored-by: Sumit Kumar <sumitsum@Sumits-MacBook-Pro.local>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
 2020-11-04 17:32:43 +05:30
Hetu Nandu
20ef86f118
Improve app initialisation for timeouts (#1412) 
Fixes: #1510 

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
 2020-11-04 17:10:59 +05:30
akash-codemonk
1eeb0af01e Fixed binding prompt crash 2020-11-04 17:08:18 +05:30
akash-codemonk
8ae77f7764
Fix prompt showing up always (#1556) 2020-11-04 16:37:10 +05:30
Nikhil Nandagopal
f05ac9a9c6 added sha256 hash to obfuscate analytics data 2020-11-04 16:23:15 +05:30
akash-codemonk
ba6aceb096
Fix includes is not a function error crash (#1555) 
* Make the value a string to avoid includes is not a function error

* If it is not a string show the prompt
 2020-11-04 15:27:11 +05:30
Nikhil Nandagopal
0f90b19dc0 added anonymization of user data for CE 2020-11-04 15:23:26 +05:30
NandanAnantharamu
ceb31edd76
Updated a binding and commented out failing test (#1546) 2020-11-04 13:06:32 +05:30
Nidhi
fc4fca8bf0
Added fallback email to new organization from user email (#1536) 2020-11-04 12:57:17 +05:30
Nidhi
c7efe55c9c
Fixed timeout error message, added new type of error for plugin timeout (#1519) 
* Fixed timeout error message, added new type of error for plugin timeouts

* Switched error code and added test for a secondary StaleConnectionException
 2020-11-04 12:56:52 +05:30
Arpit Mohan
dcc30b31d2 Correcting the assertion for table binding widget test 2020-11-04 10:26:08 +05:30
Arpit Mohan
ee5e1a81ff Reverting back the changes for local postgres 2020-11-04 08:40:35 +05:30
Arpit Mohan
e71412d3ab Moving postgres container to background 2020-11-04 00:45:02 +05:30
Arpit Mohan
4f094ea779 Moving the postgres container to Cypress test setup 2020-11-04 00:32:42 +05:30
Arpit Mohan
fba99c4728 Removing health check for postgres 2020-11-04 00:17:31 +05:30
Arpit Mohan
c93e72c3ec Adding postgres env variables 2020-11-04 00:05:30 +05:30
Arpit Mohan
8e839ab224 Correcting the mount volume in client.yml 2020-11-03 23:48:10 +05:30
Arpit Mohan
19131e14ab Using absolute path for volume mount in client.yml 2020-11-03 23:29:03 +05:30
Arpit Mohan
779801c763 Correcting the ports for postgres in client.yml 2020-11-03 23:18:45 +05:30
Arpit Mohan
0ea9c96a8f
Spinning up Postgresql container in client workflow CI (#1521) 2020-11-03 23:16:51 +05:30
Abhinav Jha
8b097775a3 Fix table crash issue when selectedRowIndices was reset (#1542) 2020-11-03 22:17:52 +05:30
Abhinav Jha
d5c7fcc1e4
Fix table crash issue when selectedRowIndices was reset (#1542) 2020-11-03 22:16:44 +05:30
Nikhil Nandagopal
8d2ccefab2 Merge branch 'master' of github.com:appsmithorg/appsmith 2020-11-03 22:10:45 +05:30
Abhinav Jha
ada1e28f64 Fix styles to show table rows in query results (#1540) 2020-11-03 21:47:26 +05:30
Nikhil Nandagopal
a4443e0acb added a fix for null crashing a page in bindings 2020-11-03 21:47:18 +05:30
Nikhil Nandagopal
8a1be448e1 added a fix for null crashing a page in bindings 2020-11-03 21:17:16 +05:30
Abhinav Jha
0538c08bcd
Fix styles to show table rows in query results (#1540) 2020-11-03 21:05:55 +05:30
Abhinav Jha
543b7ec72d
Entity Explorer Render (#1354) 
* WIP: Performance improvements in entity explorer

* WIP: Achieve feature parity for entity explorer with release

* Update unit tests

* Add sentry profiling to current page entity properties component

* Fix page add/delete not showing up on entity explorer issue. Update memoization logic for pagegroup entity

* Deal with the ban-ts-ignore eslint issues

* Update unit tests

* Fix widget entity children visibility

* Fix tests and code

* Fix tests for scenarios where the collapsed entities are unmount, as this is a part of the performance optimization

* Filter undefined children when generating structureDSL

* Remove rule from eslintrc

Consolidate createPage test command

* Update CreatePage tests to remove redundant dsl updates

* Revert CreatePage test changes, as adding more checks within this command globally causes other tests to have issues.

* re-enable eslint rule, as without it CI tests fail

* Revert to ban-ts-comment

* Fix typescript ban-ts-ignore issue by upgrading react-scripts and fixing typescript issue across the application

* Typescript errors handled

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
 2020-11-03 18:35:40 +05:30
Nikhil Nandagopal
ef9a70b9e5 Merge branch 'master' of github.com:appsmithorg/appsmith 2020-11-03 18:35:06 +05:30
Nikhil Nandagopal
25a6fe2e09
Fix: Tabs Widget (#1532) (#1535) 
* Fix issue where placing widgets into the first tab of a tabs widget was disallowed.

* Concatenate using spread instead of produce

* Remove widget blueprint from widget props

* Deal with nested blueprint

Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
 2020-11-03 18:33:26 +05:30
Abhinav Jha
120c2da507
Fix: Tabs Widget (#1532) 
* Fix issue where placing widgets into the first tab of a tabs widget was disallowed.

* Concatenate using spread instead of produce

* Remove widget blueprint from widget props

* Deal with nested blueprint
 2020-11-03 18:32:50 +05:30
Arpit Mohan
cce2c007fb Merge branch 'release' 2020-11-03 16:56:47 +05:30
Arpit Mohan
33b18a9336 Fixing merge conflicts 2020-11-03 16:50:23 +05:30
Hetu Nandu
4cba17ab82
Add post eval action support (#1529) 
Fixes #1504
 2020-11-03 15:46:11 +05:30
vicky-primathon
25e8d17108
Change to resolve conflicts with master branch (#1530) 2020-11-03 14:46:35 +05:30
Arpit Mohan
bd11fdef91 Merge branch 'release' 2020-11-03 14:28:18 +05:30
Trisha Anand
111922d49e Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-03 13:19:06 +05:30
Trisha Anand
936ddc4fa0
Added indexes on NewPage and NewAction. Also made changes to the sorting order of actions when read in view and edit mode. (#1527) 2020-11-03 13:15:51 +05:30
Automated Github Action
5df7127af6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-03 07:15:39 +00:00
Sumanth Yedoti
87a2effbc5
Fix/api URL field twitch (#1495) 
Fixes: #1248
Co-authored-by: Yedoti Sumanth <sumanthyedoti@redd.in>
 2020-11-03 12:21:02 +05:30
Automated Github Action
05c82e2498 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-03 06:10:23 +00:00
vicky-primathon
1c4adf84a1
Fix/multi select dropdown (#1295) 
* Cypress test locator fix

* Multi select dropdown values initialization fixed

* Reverted test case selector change

* Using lodash isEqual since values can be object
 2020-11-03 10:49:27 +05:30
Automated Github Action
c08fe7ece8 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-03 04:16:31 +00:00
akash-codemonk
9afcf87156
Show binding prompt when there is no binding in the editor (#1478) 2020-11-03 09:40:07 +05:30
Arpit Mohan
ac44da036c Dummy commit to trigger build 2020-11-03 08:32:08 +05:30
Arpit Mohan
71ede6622a Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-03 07:58:58 +05:30
Arpit Mohan
d087b8152d Fixing the condition for organization name being empty 2020-11-03 07:58:22 +05:30
Arpit Mohan
91fded3ddd Fixing merge conflicts 2020-11-03 07:40:53 +05:30
Dmitriy Danilov
26da9ce60b
fix(organization-service): add check that organization is not empty (#1120) 
Fixes ##774
 2020-11-02 20:35:12 +05:30
Sumanth Yedoti
a7ecfd0a6d
Fix(API): remove cursor in API HTTP methods field (#1512) 
Fixes: #1249 
Co-authored-by: Yedoti Sumanth <sumanthyedoti@redd.in>
 2020-11-02 20:33:46 +05:30
NandanAnantharamu
da8ab92803
Updated dsl file (#1496) 
* Updated dsl file

* fixed the shareApp tests
 2020-11-02 20:06:41 +05:30
NandanAnantharamu
eb6c8ee8f0
Added tests for button click navigation (#1467) 2020-11-02 20:06:16 +05:30
imgbot[bot]
f5924c6895
[ImgBot] Optimize images (#1513) 
*Total -- 1,942.96kb -> 1,638.83kb (15.65%)

/app/client/src/assets/icons/header/save-loading.gif -- 14.17kb -> 5.67kb (59.99%)
/app/client/src/assets/images/Postman.png -- 10.34kb -> 4.63kb (55.24%)
/app/client/src/assets/images/Google.png -- 11.18kb -> 5.62kb (49.76%)
/static/appsmith_logo_primary.png -- 8.02kb -> 4.06kb (49.34%)
/app/client/src/assets/images/appsmith_logo.png -- 8.02kb -> 4.06kb (49.34%)
/static/logo.png -- 13.20kb -> 7.77kb (41.11%)
/app/client/src/assets/images/no_image.png -- 4.94kb -> 2.97kb (39.97%)
/app/client/src/assets/images/query-image-outline.png -- 1.65kb -> 1.01kb (38.71%)
/app/client/src/assets/images/404-image.png -- 141.37kb -> 94.81kb (32.93%)
/app/server/appsmith-server/src/test/resources/test_assets/OrganizationServiceTest/my_organization_logo.png -- 1.77kb -> 1.20kb (32.41%)
/app/client/src/assets/images/appsmith_logo_white.png -- 1.88kb -> 1.29kb (31.17%)
/app/client/src/assets/icons/control/play-icon.png -- 2.00kb -> 1.39kb (30.15%)
/Query.png -- 219.82kb -> 155.18kb (29.41%)
/app/client/src/assets/images/Github.png -- 4.17kb -> 2.94kb (29.36%)
/API.png -- 332.87kb -> 239.07kb (28.18%)
/static/logo-no-padding.png -- 17.63kb -> 12.84kb (27.16%)
/app/client/src/assets/images/Curl.png -- 40.68kb -> 32.55kb (19.99%)
/app/client/src/assets/icons/ads/logout.svg -- 0.94kb -> 0.76kb (19.38%)
/app/client/src/assets/icons/menu/datasource-column.svg -- 0.64kb -> 0.52kb (19.15%)
/static/API2.png -- 167.58kb -> 140.36kb (16.24%)
/static/Query2.png -- 118.59kb -> 102.85kb (13.27%)
/app/client/src/assets/icons/ads/context-menu.svg -- 0.52kb -> 0.45kb (12.99%)
/app/client/src/assets/icons/help/github-icon.svg -- 2.63kb -> 2.34kb (10.85%)
/app/client/src/assets/icons/ads/search.svg -- 0.26kb -> 0.25kb (3.73%)
/app/client/src/assets/icons/widget/slash.svg -- 0.19kb -> 0.18kb (3.59%)
/app/client/src/assets/icons/widget/plus.svg -- 0.30kb -> 0.29kb (3.58%)
/app/client/src/assets/icons/widget/modal.svg -- 0.20kb -> 0.19kb (2.99%)
/app/client/src/assets/icons/ads/frame.svg -- 0.50kb -> 0.48kb (2.96%)
/app/client/src/assets/icons/menu/explorer.svg -- 0.19kb -> 0.18kb (2.11%)
/app/client/src/assets/icons/control/lightning.svg -- 0.23kb -> 0.23kb (2.1%)
/app/client/src/assets/icons/ads/product.svg -- 0.34kb -> 0.33kb (2.03%)
/app/client/src/assets/icons/widget/container.svg -- 0.20kb -> 0.19kb (1.99%)
/app/client/src/assets/images/placeholder-image.svg -- 0.15kb -> 0.14kb (1.99%)
/static/Share5.png -- 143.35kb -> 140.55kb (1.95%)
/app/client/src/assets/icons/form/info-outline.svg -- 1.77kb -> 1.73kb (1.93%)
/app/client/src/assets/icons/ads/file.svg -- 0.36kb -> 0.35kb (1.89%)
/app/client/src/assets/icons/ads/success.svg -- 0.26kb -> 0.25kb (1.88%)
/app/client/src/assets/icons/widget/input.svg -- 0.32kb -> 0.31kb (1.84%)
/app/client/src/assets/icons/ads/create-new.svg -- 0.23kb -> 0.22kb (1.73%)
/app/client/src/assets/icons/ads/book.svg -- 0.52kb -> 0.51kb (1.69%)
/app/client/src/assets/icons/control/email.svg -- 0.17kb -> 0.17kb (1.69%)
/app/client/src/assets/icons/ads/down_arrow.svg -- 0.18kb -> 0.18kb (1.63%)
/app/client/src/assets/icons/ads/upper_arrow.svg -- 0.18kb -> 0.18kb (1.63%)
/app/client/src/assets/icons/ads/bag.svg -- 0.42kb -> 0.42kb (1.61%)
/app/client/src/assets/icons/control/compact.svg -- 0.55kb -> 0.54kb (1.59%)
/app/client/src/assets/icons/help/openlink.svg -- 0.70kb -> 0.69kb (1.53%)
/app/client/src/assets/icons/help/document.svg -- 0.80kb -> 0.79kb (1.47%)
/app/client/src/assets/images/logo.svg -- 2.61kb -> 2.57kb (1.46%)
/app/client/src/assets/icons/ads/manage.svg -- 0.27kb -> 0.27kb (1.42%)
/app/client/src/assets/icons/ads/error.svg -- 0.35kb -> 0.34kb (1.4%)
/app/client/src/assets/icons/ads/view-all.svg -- 0.21kb -> 0.21kb (1.39%)
/app/client/src/assets/icons/control/pick-location-initial.svg -- 0.50kb -> 0.49kb (1.38%)
/app/client/src/assets/icons/menu/storage.svg -- 0.21kb -> 0.21kb (1.36%)
/app/client/src/assets/icons/ads/calender.svg -- 0.51kb -> 0.50kb (1.35%)
/app/client/src/assets/icons/menu/widgets-colored.svg -- 0.22kb -> 0.22kb (1.32%)
/app/client/src/assets/icons/control/input.svg -- 0.31kb -> 0.30kb (1.27%)
/app/client/src/assets/icons/header/share-white.svg -- 0.47kb -> 0.46kb (1.26%)
/app/client/src/assets/icons/control/pick-location-onclick.svg -- 0.48kb -> 0.48kb (1.21%)
/app/client/src/assets/icons/menu/datasource-table.svg -- 0.25kb -> 0.24kb (1.2%)
/app/client/src/assets/icons/form/add-new.svg -- 0.34kb -> 0.34kb (1.15%)
/app/client/src/assets/icons/ads/camera.svg -- 0.86kb -> 0.85kb (1.14%)
/app/client/src/assets/icons/widget/image.svg -- 0.35kb -> 0.35kb (1.11%)
/app/client/src/assets/icons/ads/shopper.svg -- 0.62kb -> 0.61kb (1.11%)
/app/client/src/assets/icons/control/sort-icon.svg -- 0.27kb -> 0.27kb (1.09%)
/app/client/src/assets/icons/menu/pages.svg -- 0.37kb -> 0.36kb (1.07%)
/app/client/src/assets/icons/ads/delete.svg -- 0.28kb -> 0.27kb (1.06%)
/app/client/src/assets/icons/menu/page.svg -- 0.37kb -> 0.37kb (1.06%)
/app/client/src/assets/icons/ads/workspace.svg -- 0.28kb -> 0.28kb (1.05%)
/app/client/src/assets/icons/control/download-table.svg -- 0.47kb -> 0.47kb (1.03%)
/app/client/src/assets/icons/control/help.svg -- 0.47kb -> 0.47kb (1.03%)
/app/client/src/assets/icons/control/close.svg -- 0.29kb -> 0.29kb (1.01%)
/app/client/src/assets/icons/control/move.svg -- 0.39kb -> 0.39kb (1%)
/app/client/src/assets/icons/ads/general.svg -- 0.29kb -> 0.29kb (1%)
/app/client/src/assets/icons/ads/duplicate.svg -- 0.30kb -> 0.30kb (0.96%)
/app/client/src/assets/icons/control/edit-white.svg -- 0.41kb -> 0.40kb (0.96%)
/app/client/src/assets/icons/control/view.svg -- 0.32kb -> 0.32kb (0.92%)
/app/client/src/assets/icons/header/feedback.svg -- 0.43kb -> 0.42kb (0.91%)
/app/client/src/assets/icons/control/remove.svg -- 0.33kb -> 0.33kb (0.89%)
/app/client/src/assets/icons/ads/heart.svg -- 0.79kb -> 0.79kb (0.86%)
/app/client/src/assets/icons/control/more-vertical.svg -- 1.02kb -> 1.01kb (0.86%)
/app/client/src/assets/icons/widget/rich-text.svg -- 1.60kb -> 1.58kb (0.86%)
/app/client/src/assets/icons/control/info.svg -- 0.34kb -> 0.34kb (0.85%)
/app/client/src/assets/icons/control/draggable.svg -- 0.47kb -> 0.47kb (0.83%)
/app/client/src/assets/images/API.svg -- 4.92kb -> 4.88kb (0.81%)
/app/client/src/assets/icons/widget/radio.svg -- 0.50kb -> 0.49kb (0.79%)
/app/client/src/assets/icons/ads/share.svg -- 0.37kb -> 0.37kb (0.79%)
/app/client/src/assets/images/EditPen.svg -- 0.38kb -> 0.37kb (0.78%)
/app/client/src/assets/icons/widget/collapse.svg -- 0.50kb -> 0.50kb (0.78%)
/app/client/src/assets/icons/control/edit.svg -- 0.65kb -> 0.65kb (0.75%)
/app/client/src/assets/icons/ads/user.svg -- 0.54kb -> 0.53kb (0.73%)
/app/client/src/assets/icons/widget/checkbox.svg -- 0.54kb -> 0.53kb (0.73%)
/app/client/src/assets/icons/ads/edit.svg -- 0.40kb -> 0.40kb (0.73%)
/app/client/src/assets/icons/control/collapse.svg -- 0.55kb -> 0.54kb (0.71%)
/app/client/src/assets/icons/menu/queries.svg -- 0.41kb -> 0.41kb (0.71%)
/app/client/src/assets/icons/ads/close.svg -- 0.42kb -> 0.42kb (0.7%)
/app/client/src/assets/images/NoSearchResult.svg -- 8.61kb -> 8.55kb (0.69%)
/app/client/src/assets/icons/widget/chart.svg -- 0.43kb -> 0.43kb (0.68%)
/app/client/src/assets/icons/control/decrease.svg -- 0.45kb -> 0.45kb (0.65%)
/app/client/src/assets/icons/menu/api.svg -- 1.51kb -> 1.50kb (0.65%)
/app/client/src/assets/icons/widget/filepicker.svg -- 0.61kb -> 0.60kb (0.64%)
/app/client/src/assets/icons/ads/launch.svg -- 0.61kb -> 0.61kb (0.64%)
/app/client/src/assets/icons/menu/homepage.svg -- 0.92kb -> 0.92kb (0.64%)
/app/client/src/assets/icons/control/launch.svg -- 0.62kb -> 0.61kb (0.63%)
/app/client/src/assets/icons/control/pick-location-selected.svg -- 0.48kb -> 0.48kb (0.61%)
/app/client/src/assets/icons/widget/video.svg -- 0.49kb -> 0.49kb (0.6%)
/app/client/src/assets/icons/control/currency.svg -- 0.50kb -> 0.49kb (0.59%)
/app/client/src/assets/icons/control/filter-icon.svg -- 0.84kb -> 0.84kb (0.58%)
/app/client/src/assets/icons/control/search.svg -- 0.55kb -> 0.54kb (0.54%)
/app/client/src/assets/icons/control/zoomout.svg -- 0.55kb -> 0.55kb (0.53%)
/app/client/src/assets/icons/form/lock.svg -- 0.56kb -> 0.56kb (0.52%)
/app/client/src/assets/icons/control/multiline.svg -- 1.51kb -> 1.50kb (0.52%)
/app/client/src/assets/icons/ads/flight.svg -- 1.33kb -> 1.32kb (0.51%)
/app/client/src/assets/icons/control/pick-my-location.svg -- 1.16kb -> 1.16kb (0.5%)
/app/client/src/assets/icons/ads/chat.svg -- 1.36kb -> 1.35kb (0.5%)
/app/client/src/assets/icons/widget/table.svg -- 0.78kb -> 0.78kb (0.5%)
/app/client/src/assets/icons/control/delete.svg -- 0.59kb -> 0.59kb (0.5%)
/app/client/src/assets/icons/control/phone.svg -- 0.59kb -> 0.59kb (0.5%)
/app/client/src/assets/icons/control/password.svg -- 1.97kb -> 1.96kb (0.49%)
/app/client/src/assets/icons/widget/alert.svg -- 0.81kb -> 0.81kb (0.48%)
/app/client/src/assets/icons/control/right-align.svg -- 0.62kb -> 0.61kb (0.48%)
/app/client/src/assets/icons/ads/invite-users.svg -- 0.64kb -> 0.64kb (0.46%)
/app/client/src/assets/icons/widget/tabs.svg -- 0.86kb -> 0.85kb (0.46%)
/app/client/src/assets/icons/control/columns-visibility.svg -- 1.08kb -> 1.07kb (0.45%)
/app/client/src/assets/icons/control/zoomin.svg -- 0.65kb -> 0.65kb (0.45%)
/app/client/src/assets/icons/control/left-align.svg -- 0.67kb -> 0.67kb (0.44%)
/app/client/src/assets/icons/control/underline.svg -- 0.68kb -> 0.68kb (0.43%)
/app/client/src/assets/icons/ads/globe.svg -- 1.60kb -> 1.59kb (0.43%)
/app/client/src/assets/icons/menu/widgets.svg -- 0.97kb -> 0.97kb (0.4%)
/app/client/src/assets/icons/widget/text.svg -- 0.99kb -> 0.98kb (0.4%)
/app/client/src/assets/icons/control/center-align.svg -- 0.76kb -> 0.76kb (0.38%)
/app/client/src/assets/icons/widget/location-picker.svg -- 1.02kb -> 1.02kb (0.38%)
/app/client/src/assets/icons/menu/overflow-menu.svg -- 1.05kb -> 1.05kb (0.37%)
/app/client/src/assets/icons/header/deploy.svg -- 1.59kb -> 1.59kb (0.37%)
/app/client/src/assets/icons/control/italics.svg -- 0.80kb -> 0.80kb (0.36%)
/app/client/src/assets/icons/control/increase.svg -- 0.81kb -> 0.81kb (0.36%)
/app/client/src/assets/icons/help/discord.svg -- 1.08kb -> 1.08kb (0.36%)
/app/client/src/assets/icons/widget/map.svg -- 1.10kb -> 1.09kb (0.36%)
/app/client/src/assets/images/email-not-configured.svg -- 28.71kb -> 28.61kb (0.35%)
/app/client/src/assets/icons/help/help.svg -- 1.15kb -> 1.15kb (0.34%)
/app/client/src/assets/icons/control/copy.svg -- 0.87kb -> 0.86kb (0.34%)
/app/client/src/assets/icons/control/bold.svg -- 0.88kb -> 0.88kb (0.33%)
/app/client/src/assets/icons/widget/dropdown.svg -- 1.21kb -> 1.21kb (0.32%)
/app/client/src/assets/icons/ads/billing.svg -- 0.96kb -> 0.95kb (0.31%)
/app/client/src/assets/icons/control/decimal.svg -- 0.98kb -> 0.97kb (0.3%)
/app/client/src/assets/icons/control/settings.svg -- 1.33kb -> 1.32kb (0.29%)
/app/client/src/assets/icons/control/chevron-down.svg -- 1.02kb -> 1.02kb (0.29%)
/app/client/src/assets/icons/widget/switch.svg -- 1.38kb -> 1.37kb (0.28%)
/app/client/src/assets/images/secure.svg -- 1.07kb -> 1.07kb (0.27%)
/app/client/src/assets/icons/menu/datasource-colored.svg -- 1.12kb -> 1.12kb (0.26%)
/app/client/src/assets/icons/menu/api-colored.svg -- 1.13kb -> 1.12kb (0.26%)
/app/client/src/assets/icons/menu/foreign-key.svg -- 1.15kb -> 1.15kb (0.26%)
/app/client/src/assets/icons/menu/org.svg -- 1.15kb -> 1.15kb (0.25%)
/app/client/src/assets/icons/control/redo.svg -- 1.17kb -> 1.16kb (0.25%)
/app/client/src/assets/icons/menu/primary-key.svg -- 1.17kb -> 1.17kb (0.25%)
/app/client/src/assets/icons/control/undo.svg -- 1.17kb -> 1.17kb (0.25%)
/app/client/src/assets/icons/form/trash.svg -- 2.75kb -> 2.74kb (0.25%)
/app/client/src/assets/icons/control/integer.svg -- 1.25kb -> 1.25kb (0.23%)
/app/client/src/assets/icons/widget/form.svg -- 1.32kb -> 1.32kb (0.22%)
/app/client/src/assets/icons/control/drag.svg -- 1.33kb -> 1.33kb (0.22%)
/app/client/src/assets/icons/header/save-failure.svg -- 1.45kb -> 1.44kb (0.2%)
/app/client/src/assets/icons/control/js-toggle.svg -- 1.97kb -> 1.96kb (0.2%)
/app/client/src/assets/images/Curl-logo.svg -- 5.33kb -> 5.32kb (0.18%)
/app/client/src/assets/icons/alert/info.svg -- 1.60kb -> 1.60kb (0.18%)
/app/client/src/assets/icons/alert/warning.svg -- 1.63kb -> 1.63kb (0.18%)
/app/client/src/assets/icons/header/save-success.svg -- 1.67kb -> 1.66kb (0.18%)
/app/client/src/assets/icons/alert/success.svg -- 1.67kb -> 1.67kb (0.18%)
/app/client/src/assets/icons/menu/data-sources.svg -- 1.74kb -> 1.73kb (0.17%)
/app/client/src/assets/icons/alert/error.svg -- 1.95kb -> 1.95kb (0.15%)
/app/client/src/assets/icons/widget/datepicker.svg -- 3.23kb -> 3.22kb (0.12%)
/app/client/src/assets/icons/widget/button.svg -- 3.75kb -> 3.75kb (0.1%)
/app/client/src/assets/icons/control/address.svg -- 3.37kb -> 3.37kb (0.09%)
/app/client/src/assets/icons/control/datepicker.svg -- 3.75kb -> 3.75kb (0.08%)
/app/client/src/assets/images/appsmith-datasource.svg -- 505.60kb -> 505.43kb (0.03%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
 2020-11-02 19:44:01 +05:30
devrk96
09ce4329b0
underline css fixed (#1515) 2020-11-02 19:35:31 +05:30
Arpit Mohan
7d7ea490ec
Fixing the client release & master builds (#1501) 2020-11-02 16:27:30 +05:30
Automated Github Action
89edfa8c93 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-02 10:16:13 +00:00
satbir121
51cb0d82a2
Fixing zoom on pan issue. (#1474) 
* FIxing zoom on pan issue.

* Adding a disabled label to 1x zoom.

* Adding comments.

* Update PropertyPaneConfigResponse.tsx

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
 2020-11-02 15:21:14 +05:30
Arpit Mohan
773b069885 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-11-02 15:07:32 +05:30
akash-codemonk
ac70e5be4d
Update query form UI (#1500) 2020-11-02 15:01:00 +05:30
Abhinav Jha
4f569f4996
Fix issue where datasource was missing for an action (#1498) 2020-11-02 14:58:20 +05:30
Automated Github Action
4c48d61a50 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-02 09:08:12 +00:00
akash-codemonk
fbfcfeed2a
Show template menu on click of datasource table (#1410) 2020-11-02 14:24:54 +05:30
Trisha Anand
32301ae3b4
Printing the invalid messages of the action properly. (#1507) 2020-11-02 14:15:29 +05:30
Automated Github Action
4fe0fdc952 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-11-02 06:10:12 +00:00
Nikhil Nandagopal
2ec5b6297b
Fix/action splitting (#1497) 
* fixed argument splitting logic to rely onregex instead of simple string split

* abstracted splitting function
 2020-11-02 10:54:15 +05:30
Arpit Mohan
e3d5832a78 Merge branch 'master' into release 2020-10-31 17:43:06 +05:30
Arpit Mohan
90e9c131b1 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-31 17:26:29 +05:30
devrk96
7d6a70d3ce
Feature: New create app flow (#1375) 
* EditableTextWrapper component implemented

* create new app flow implemented

* test cases for new create new app flow fixed

* role update element fixed

* before-all hooks fixed

* createOrg test cases fixed

* loading state test added

* editableText input unique identifier added in test-cases

* updateApplication API alias name corrected

* removed the second className prop on same component

* PR feedback implemented
 2020-10-31 12:10:51 +05:30
Nikhil Nandagopal
3829ccbbd0 Merge branch 'master' of github.com:appsmithorg/appsmith 
# Conflicts:
#	.github/workflows/client.yml
 2020-10-30 20:13:49 +05:30
Automated Github Action
8d469ad24f Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-30 13:04:52 +00:00
Nikhil Nandagopal
5c26ef5d07
Fixed Bindings Working inside action selectors (#1484) 
* added functions to convert string to JS and JS to string while manipulating property pane values
refactored getters and setters to reuse functions instead of creating multiple functions

* minor fixes

* optimized the js conversion function and fixed an edge case

* minor fix for type setters

* abstracted enum getter

* dummy commit
 2020-10-30 18:05:21 +05:30
vicky-primathon
6a0e573c50 Query table scroll issue fixed (#1464) 
* Query table scroll issue fixed

* Table widget horizontal scroll fix
 2020-10-30 16:47:19 +05:30
Automated Github Action
dbdd5a9742 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-30 11:08:58 +00:00
vicky-primathon
0508bbd115 Query table scroll issue fixed (#1464) 
* Query table scroll issue fixed

* Table widget horizontal scroll fix
 2020-10-30 16:20:35 +05:30
vicky-primathon
b74bec311e
Query table scroll issue fixed (#1464) 
* Query table scroll issue fixed

* Table widget horizontal scroll fix
 2020-10-30 16:18:57 +05:30
Arpit Mohan
a65b915fb3 Fixing merge conflicts when back merging master into release 2020-10-30 15:33:43 +05:30
Arpit Mohan
17ae082637 Moving to conditional if steps 2020-10-30 15:11:59 +05:30
Arpit Mohan
4df2801643 Splitting the if conditions 2020-10-30 15:04:01 +05:30
Arpit Mohan
ca72e1f382 Trying a different syntax 2020-10-30 14:57:38 +05:30
Arpit Mohan
0595b8d05a Adding more debug logging 2020-10-30 14:52:34 +05:30
Arpit Mohan
594bae4d17 Making the default shell bash 2020-10-30 14:49:37 +05:30
Arpit Mohan
aef74b8aaa Dummy commit to trigger build 2020-10-30 14:41:37 +05:30
Arpit Mohan
184cda75cf Minor changes in the client.ymp file 2020-10-30 14:17:31 +05:30
Arpit Mohan
7b76dfd293 Adding debug logs for the output variable 2020-10-30 14:10:14 +05:30
Arpit Mohan
71f5daac3a Debugging the github ref 2020-10-30 13:42:31 +05:30
Arpit Mohan
587a90af0f Adding a separate step for the server docker image 2020-10-30 13:24:08 +05:30
Arpit Mohan
97e4df6fc2 Adding dummy commit to trigger build 2020-10-30 13:08:30 +05:30
Arpit Mohan
b15c0a1f0b Fixing the docker image name for master builds 2020-10-30 12:56:48 +05:30
Arpit Mohan
12c874cca7 Fixing merge conflicts when cherry picking 2020-10-30 12:55:47 +05:30
Arpit Mohan
862a310050 Fixing merge conflicts during cherry picking 2020-10-30 12:54:52 +05:30
Arpit Mohan
ccea01cb21 Ensures that the master & release flows pick appropriate server Docker images (#1465) 2020-10-30 12:43:52 +05:30
Automated Github Action
d3ccf634f8 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-30 07:12:14 +00:00
akash-codemonk
d652c1485d
Update the action config with the datasource info (#1451) 2020-10-30 11:54:15 +05:30
Automated Github Action
9cdee5aee4 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-30 06:05:53 +00:00
Sumit Kumar
6cf4c10c4b Merge branch 'fix/setup_guide' of https://github.com/sumitsum/appsmith into fix/setup_guide 2020-10-30 01:17:50 +05:30
Sumit Kumar
d8e4b045b7 Update server and client setup guide. (#1437) 
1. Add Linux specific requirements.
2. Add debug info for common build errors.
3. Correct build step or any other statement wherever required.
4. For more info please see the attachment here: https://github.com/appsmithorg/appsmith/issues/1437
 2020-10-30 00:57:25 +05:30
Automated Github Action
2016c19b2f Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 19:04:39 +00:00
vicky-primathon
75c84cbba7
Map resetting when clicking on a marker fix (#1299) 2020-10-29 23:46:27 +05:30
Automated Github Action
7eb11f0007 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 14:09:24 +00:00
akash-codemonk
9553fe9b19
Merge datasources and actions in explorer (#1285) 2020-10-29 19:23:10 +05:30
Nuwan Sameera Alawatta
e782ca17e8
fix lightning bolt menu onhover bug (#1454) 
* fix lightning bolt create new api onhover bug

* fix lightning bolt menu onhover bug
 2020-10-29 19:00:04 +05:30
Automated Github Action
7e58c95ece Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 12:11:37 +00:00
devrk96
f6bb16a4e6
Fix: Invalid email error in invite modal (#1368) 
* Invalid email error showing on entering incorrect email before submission

* error state name corrected

* colon removed from error message
 2020-10-29 16:47:52 +05:30
satbir121
540f2637b5
Adding zoom on image widget. (#1356) 
* Adding zoom on image widget.

* Changing zoom level to step.

* Fixed typescript issue.

* Added zoom-in/out on Click.

* Removing bad code.
 2020-10-29 16:44:39 +05:30
Arpit Mohan
f38df9febc Correcting typo in env variable in client.yml 2020-10-29 16:19:14 +05:30
Arpit Mohan
63329b3762 Fixing bad merge 2020-10-29 16:05:37 +05:30
Arpit Mohan
7668560738 Fixing merge conflicts 2020-10-29 15:51:04 +05:30
Arpit Mohan
591b51b6a9
Ensures that the master & release flows pick appropriate server Docker images (#1465) 2020-10-29 15:44:58 +05:30
Trisha Anand
d6ff4dedd6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 15:04:00 +05:30
Trisha Anand
13e2cc2a63
[Do Not Merge]Brought down cloud migration time from 122 minutes to 9.5 minutes (#1441) 
* [Do Not Merge]Brought down cloud migration time from 122 minutes to 9.5 minutes

* Removed commented code.
TODO : Figure out if we want to change the migration order numbers once the release environment is reverted back to pre original migration data.

* Added plugin id for the migrated action.

* Renamed the createIndex functions for new action and new page and added a drop collection command before creating the index. This ensures that if any developer has pulled code in the last two days, this migration does not negatively impact them
 2020-10-29 15:03:41 +05:30
Automated Github Action
ccac36928f Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 09:08:35 +00:00
Nikhil Nandagopal
2d7ccdc515
flipped user id and instance id so that the ping can be correlated with the email from the install script (#1461) 2020-10-29 14:17:45 +05:30
Sumit Kumar
da907f58f3 Merge branch 'fix/setup_guide' of https://github.com/sumitsum/appsmith into fix/setup_guide 2020-10-29 13:46:12 +05:30
Automated Github Action
676f26dcec Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-29 06:12:55 +00:00
NandanAnantharamu
a7b6a754f5
Added tests for add widget in query (#1353) 
* Added tests for add widget in query

* test updated

* updated test with wait

* Updated binding data

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
 2020-10-29 11:15:17 +05:30
NandanAnantharamu
ee0729e60c
Basic test for theme change (#1448) 2020-10-29 11:14:46 +05:30
Sumit Kumar
1437d4a9e8 Update server and client setup guide. (#1437) 
1. Add Linux specific requirements.
2. Add debug info for common build errors.
3. Correct build step or any other statement wherever required.
4. For more info please see the attachment here: https://github.com/appsmithorg/appsmith/issues/1437
 2020-10-28 23:02:33 +05:30
Automated Github Action
6e1e226a62 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 16:12:54 +00:00
vicky-primathon
dbf98fde5f
Fix/table widget filter conditions (#1297) 
* Table widget isEqualTo and notEqualTo conditions fixed
 2020-10-28 21:10:33 +05:30
Automated Github Action
4bb2d491ee Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 15:09:29 +00:00
vicky-primathon
4cd2579dfa
Added horizontal scrolling in table widget (#1436) 
* Added horizontal scrolling in table widget

* Handled table grow shrink with display table css property
 2020-10-28 19:49:15 +05:30
Arpit Mohan
f2e37b8759 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-28 19:06:37 +05:30
Arpit Mohan
470f2fafcd
Adding support for https endpoints for ES plugin (#1445) 
* Adding host:port validation checks to ES plugin & Redis plugin

Also correcting the assertions in the RedisPluginTest so that the error message on test failure is accurate.

* Removing the endpoint validation from datasourceServiceImpl

Moving the endpoint validation to the plugin implementation classes because there are databases that require complete HTTP URL in their configuration. Checking for http/https at the platform level affects the UX for the user & plugin developer when using a new integration. Hence, all plugins must implement their own client/server validations in their own implementations

* Adding tests to assert hostname validation in mysql & postgres plugins
 2020-10-28 19:06:10 +05:30
Automated Github Action
3bc4ca12b3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 12:11:09 +00:00
devrk96
5ebea89d98
Test cases: Application update (#1339) 
* application name and icon update test cases implemented

* application icon update test case implemented
 2020-10-28 17:36:30 +05:30
devrk96
bc70460093
role change update fixed (#1192) 2020-10-28 17:21:14 +05:30
Automated Github Action
4a754f526b Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 11:07:52 +00:00
Hetu Nandu
44725c983e
Use global history on 500 page (#1446) 2020-10-28 16:29:34 +05:30
Automated Github Action
ab0f016f03 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-28 08:11:24 +00:00
Jeff Rescignano
c967c03494
Add "back to home" CTA on 500 page (#1319) 
Fixes: #1303 
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
 2020-10-28 13:38:52 +05:30
Arpit Mohan
ee683157a5 Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-28 11:10:06 +05:30
devrk96
15ab7809f8
Org name, email and website update test cases implemented (#1433) 2020-10-28 11:09:28 +05:30
Arpit Mohan
d13de8709a Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-27 15:30:39 +05:30
Trisha Anand
5197b17d8c
Bug Fix : Reading the datasource configuration incorrectly from actionDTO instead of datasource object. (#1415) 
* Bug Fix : Reading the datasource configuration incorrectly from actionDTO instead of datasource object.

* Added test case to assert that datasource configuration and action configurations are not null when action execute is called.
 2020-10-27 15:23:25 +05:30
Arpit Mohan
d457614b4e Merge branch 'release' of github.com:appsmithorg/appsmith into release 2020-10-27 12:29:01 +05:30
akash-codemonk
a8b40dcd53
Do not show template view if there no templates. (#1330) 2020-10-27 12:03:45 +05:30
Nikhil Nandagopal
2557c1748c Merge branch 'master' of github.com:appsmithorg/appsmith 2020-10-27 11:39:36 +05:30
Automated Github Action
0ff5b3f471 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-27 06:09:15 +00:00
Nikhil Nandagopal
427aa7e74c disable sentry perf (#1399) 2020-10-27 11:39:05 +05:30
Nikhil Nandagopal
790d202662 Update netlify.toml 2020-10-27 11:33:49 +05:30
NandanAnantharamu
d03be01b28
Added assertion for basic AddWidget test (#1405) 2020-10-27 10:43:03 +05:30
Automated Github Action
07fdd867a6 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-27 05:09:54 +00:00
akash-codemonk
0f34c7f38f
Secure connection UI (#1358) 2020-10-27 10:32:32 +05:30
Automated Github Action
e034f1062e Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 18:08:24 +00:00
Trisha Anand
230126ebcf
Remove unnecessary database migration (#1406) 2020-10-26 22:50:36 +05:30
Trisha Anand
d00ba212b3 Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 18:55:13 +05:30
Trisha Anand
5b625fed4a Dummy commit to run the client test suite again. 2020-10-26 18:53:23 +05:30
Trisha Anand
eda489fd7f Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 18:07:37 +05:30
Trisha Anand
fc9ea45e3b
[API breaking change : Automated Tests Will Fail] Page And Action Refactor (#549) 
* Introduced new page which stores the published and unpublished pages as separate.

* Mid level commit to save the state.

* Parity of new page repository with old page repository (custom functions)

* WIP : Delete a page. This requires changes across application structure as well.

* Added publishedPages construct inside application to store the pages in the deployed view as well as isDefault so that the same changes (delete or isDefault) in unpublished view doesn't alter these fields for the published application

* Parity reached with PageService.

* Minor ActionService refactor to remove unnecessary code.
ApplicationPageService, LayoutActionService, LayoutService use the new page service to fetch the pages
Minor corrections in fetching the page from new page service in tests

* New save function which sets the PageDTO for unpublished page and then saves the new page into repository.

* Migration of page service functions to new page service functions across other services/tests/controller

* Finished migrating all the page service functions to the new page service functions

* Application Service Tests have been fixed.

* All the existing test cases are working now.

* Publish application implemented to store published pages as well. Added a basic test case to check that published pages is being set and that page's publishedPageDTO is being set accordingly.

* Minor TODOs added to add test cases for published application.

* A few tests to ascertain that published application page fields (deleted, isDefault) does not get changed when these statuses are changed for a page in edit mode.

* Added a new controller end point to fetch application in view mode.

* Added new endpoint for fetching an application in view mode on the client.

* Bug fix where get application in view mode API was not getting called.

* Fixed the get page names by application & archive pages which have been deleted in edit mode during publishing of application.

* During delete page, if a page was never published and it was deleted during edit, delete the entire page instead of just deleting the unpublished PageDTO

* Minor formatting.

* Non working client side code to fetch page list using view mode.

* revert unnecassary changes and streamlined view and edit actions

* Fix missed import

* Fixed a bug where if a page is not published, it should not be returned in view mode in list of page names api.

* Fixed update for a page which was not working in integration test.

* ActionDTO added.

* Solidified the new action structure.

* Migration added for NewAction index creation and NewAction per Action insertion in the database.

* Basic file structure added the new repository, custom repository, service, etc.

* Delete OldPage.java

* Repo functions added - TODO : Haven;t handled the published/edited views

* Helper functions added to convert Action to NewAction and vice-versa. Removed unused currentUserMono usage.

* Create & update action functionality added.

* Execute Action refactored. Removed dry run specific code.

* Repository migrated to handle new data structure. Execute action refactored to no longer support dry runs of actions.

* TODO added for special handling of change view of application to handle edge cases of pages/actions which either exist in published mode but don't exist in unpublished mode or vice versa.

* Migrated finding on load actions from spring repository to custom repository.

* In view mode, now actions are being fetched by application id directly instead of first fetching application and then using the page ids, fetching the actions. This reduces the db calls from 2 to 1 per fetch actions in view mode api call.

* Delete action and get all actions (used in edit mode on the client side) implemented.

* Updated CollectionService and ActionCollectionService to use the new action service instead of the old one.

* LayoutActionService refactored to now use the new service functions.

* ActionController now no longer used ActionService. The remaining service functions have been migrated to the new action service.

* Refactor across ACL code for addition/removal of policies during addition/removal of users to organization, making app public, refactor for services like policy utils, item service, etc.

* Removed the last of action repository and action service and replaced with new action repo and new action service.

* Compile and run time issues fixed. The server is coming up without any spring dependency errors.

* WIP in fixing fetching actions by page id.

* Finally!!! Fixed the fetch actions (both published and unpublished actions) by page id repository function.

* Fixed create action bug where null datasource in published actiondto (inside newly created action) leads to error.

* Fixed the execute action issues :
1. Removed the dry runs from the tests
2. Fixed the null pointer error in variable substituted action and datasource configurations.

* 1. Fixed the custom action repository field names.
2. Fixed the data structures used in ExamplesOrganizationClonerTests

* Fixed countByDatasourceId repository function which was querying the actions incorrectly.

* Fixed the clone example organization error where the id of the action was not getting updated in the page correctly. Yay!

* Fixed post merge compilation failure.

* Fixed more compilation time failures in ActionServiceTest

* Fixed failing test case for fetching actions in view mode.

* Minor changes to resolve merge changes and incorporate in the new refactored code.

* 1. Fixed compile time errors on Client code.
2. Fixed fetching of actions in view mode by application id. The repository function did not need name parameter. Removed the same.

* [Integration Testing Error Fix] : Added a new test case for refactor action name.

* Instead of fetching actions in the page, mistakenly used the base service which was fetching all the actions in the repository, barring none which led to the name refactor being blocked even though no action in the current page exists with the new proposed name,

* Added delete functionality to action service.

* Minor code cleanup

* Adding viewMode to action execution

* Replacing action with actionId.

* 1. Bug fix for deletion of unpublished action. In case of never published action, the entire action should be deleted. In case an action was published, only the unpublished action should be deleted.
2. In case of DB actions (external datasources), only the bare minimum fields should be stored inside the action (datasource id and datasource plugin id). The other fields should not be duplicated across code.

* Fixed yarn build compilation issues.

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ActionController.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Changed the API path for GET applications in view mode. Some minor code formatting.

* Incorporated review comments.

* Some more unnecessary code removed.

* Instead of returning Page, now the interface object between client and server for Pages is PageDTO

* Migrated Page and Action to PageDTO and ActionDTO
Fixed the compilation issues.
TODO : Fix the test compilation issues.

* Fixed compilation time issues with all the tests by migrating Page and Action to PageDTO and ActionDTO respectively

* Action Controller and Page Controller no longer extend Base Controller. All the required functions have now been implemented and no base line API end points are being re-used from the base.

* Test case fixes.

* Bug Fix : Updating an action was not updating execute on load. Fixed the data flow leading to the error.

* Deprecating Page and Action domain objects. This is to ensure no new code is written with these till we remove this old code.

* Cloned example applications are now published before returning. This is to ensure that the applications are in ready to view mode when the new user signs up.

* Added a function comment to expand on the usage of new param introduced.

* When cloning a page, new actions were not being stored. Added that. Also updated the clonePage test to assert that the actions are also cloned when the pages are cloned.

* Updated a Api call

* removed extra slash

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan@thinkify.io>
 2020-10-26 18:04:23 +05:30
Automated Github Action
a2b08c34fc Merge branch 'release' of https://github.com/appsmithorg/appsmith into release 2020-10-26 12:10:37 +00:00