* Introduced new page which stores the published and unpublished pages as separate.
* Mid level commit to save the state.
* Parity of new page repository with old page repository (custom functions)
* WIP : Delete a page. This requires changes across application structure as well.
* Added publishedPages construct inside application to store the pages in the deployed view as well as isDefault so that the same changes (delete or isDefault) in unpublished view doesn't alter these fields for the published application
* Parity reached with PageService.
* Minor ActionService refactor to remove unnecessary code.
ApplicationPageService, LayoutActionService, LayoutService use the new page service to fetch the pages
Minor corrections in fetching the page from new page service in tests
* New save function which sets the PageDTO for unpublished page and then saves the new page into repository.
* Migration of page service functions to new page service functions across other services/tests/controller
* Finished migrating all the page service functions to the new page service functions
* Application Service Tests have been fixed.
* All the existing test cases are working now.
* Publish application implemented to store published pages as well. Added a basic test case to check that published pages is being set and that page's publishedPageDTO is being set accordingly.
* Minor TODOs added to add test cases for published application.
* A few tests to ascertain that published application page fields (deleted, isDefault) does not get changed when these statuses are changed for a page in edit mode.
* Added a new controller end point to fetch application in view mode.
* Added new endpoint for fetching an application in view mode on the client.
* Bug fix where get application in view mode API was not getting called.
* Fixed the get page names by application & archive pages which have been deleted in edit mode during publishing of application.
* During delete page, if a page was never published and it was deleted during edit, delete the entire page instead of just deleting the unpublished PageDTO
* Minor formatting.
* Non working client side code to fetch page list using view mode.
* revert unnecassary changes and streamlined view and edit actions
* Fix missed import
* Fixed a bug where if a page is not published, it should not be returned in view mode in list of page names api.
* Fixed update for a page which was not working in integration test.
* ActionDTO added.
* Solidified the new action structure.
* Migration added for NewAction index creation and NewAction per Action insertion in the database.
* Basic file structure added the new repository, custom repository, service, etc.
* Delete OldPage.java
* Repo functions added - TODO : Haven;t handled the published/edited views
* Helper functions added to convert Action to NewAction and vice-versa. Removed unused currentUserMono usage.
* Create & update action functionality added.
* Execute Action refactored. Removed dry run specific code.
* Repository migrated to handle new data structure. Execute action refactored to no longer support dry runs of actions.
* TODO added for special handling of change view of application to handle edge cases of pages/actions which either exist in published mode but don't exist in unpublished mode or vice versa.
* Migrated finding on load actions from spring repository to custom repository.
* In view mode, now actions are being fetched by application id directly instead of first fetching application and then using the page ids, fetching the actions. This reduces the db calls from 2 to 1 per fetch actions in view mode api call.
* Delete action and get all actions (used in edit mode on the client side) implemented.
* Updated CollectionService and ActionCollectionService to use the new action service instead of the old one.
* LayoutActionService refactored to now use the new service functions.
* ActionController now no longer used ActionService. The remaining service functions have been migrated to the new action service.
* Refactor across ACL code for addition/removal of policies during addition/removal of users to organization, making app public, refactor for services like policy utils, item service, etc.
* Removed the last of action repository and action service and replaced with new action repo and new action service.
* Compile and run time issues fixed. The server is coming up without any spring dependency errors.
* WIP in fixing fetching actions by page id.
* Finally!!! Fixed the fetch actions (both published and unpublished actions) by page id repository function.
* Fixed create action bug where null datasource in published actiondto (inside newly created action) leads to error.
* Fixed the execute action issues :
1. Removed the dry runs from the tests
2. Fixed the null pointer error in variable substituted action and datasource configurations.
* 1. Fixed the custom action repository field names.
2. Fixed the data structures used in ExamplesOrganizationClonerTests
* Fixed countByDatasourceId repository function which was querying the actions incorrectly.
* Fixed the clone example organization error where the id of the action was not getting updated in the page correctly. Yay!
* Fixed post merge compilation failure.
* Fixed more compilation time failures in ActionServiceTest
* Fixed failing test case for fetching actions in view mode.
* Minor changes to resolve merge changes and incorporate in the new refactored code.
* 1. Fixed compile time errors on Client code.
2. Fixed fetching of actions in view mode by application id. The repository function did not need name parameter. Removed the same.
* [Integration Testing Error Fix] : Added a new test case for refactor action name.
* Instead of fetching actions in the page, mistakenly used the base service which was fetching all the actions in the repository, barring none which led to the name refactor being blocked even though no action in the current page exists with the new proposed name,
* Added delete functionality to action service.
* Minor code cleanup
* Adding viewMode to action execution
* Replacing action with actionId.
* 1. Bug fix for deletion of unpublished action. In case of never published action, the entire action should be deleted. In case an action was published, only the unpublished action should be deleted.
2. In case of DB actions (external datasources), only the bare minimum fields should be stored inside the action (datasource id and datasource plugin id). The other fields should not be duplicated across code.
* Fixed yarn build compilation issues.
* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ActionController.java
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* Changed the API path for GET applications in view mode. Some minor code formatting.
* Incorporated review comments.
* Some more unnecessary code removed.
* Instead of returning Page, now the interface object between client and server for Pages is PageDTO
* Migrated Page and Action to PageDTO and ActionDTO
Fixed the compilation issues.
TODO : Fix the test compilation issues.
* Fixed compilation time issues with all the tests by migrating Page and Action to PageDTO and ActionDTO respectively
* Action Controller and Page Controller no longer extend Base Controller. All the required functions have now been implemented and no base line API end points are being re-used from the base.
* Test case fixes.
* Bug Fix : Updating an action was not updating execute on load. Fixed the data flow leading to the error.
* Deprecating Page and Action domain objects. This is to ensure no new code is written with these till we remove this old code.
* Cloned example applications are now published before returning. This is to ensure that the applications are in ready to view mode when the new user signs up.
* Added a function comment to expand on the usage of new param introduced.
* When cloning a page, new actions were not being stored. Added that. Also updated the clonePage test to assert that the actions are also cloned when the pages are cloned.
* Updated a Api call
* removed extra slash
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan@thinkify.io>
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
* added code to not identify anonymous users
* minor fix
* added alias for users so that segment works with mixpanel
* removed alias since we enabled identity merge for mixpanel
* added fix to not send anonymous user
* Add first_login event for analytics (#1184)
* Don't send full object to analytics (#1186)
* added binary raw data to be set for files picked (#1211)
* added binary raw data to be set for files picked
* spread options before modifying to maintain immutability
* Add isFromInvite field to create_USER event (#1223)
* Adding dummy commit to trigger build
* added extra information to execute action call (#1244)
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* fix(codemirror-autocomplete): show selection background on hover for options
This fix if merged shows the selection background by hovering on autocomplete
options.
Ref: #946
* added code to not identify anonymous users
* minor fix
* added alias for users so that segment works with mixpanel
* removed alias since we enabled identity merge for mixpanel
* added fix to not send anonymous user
* Add first_login event for analytics (#1184)
* Don't send full object to analytics (#1186)
* fix for removing the extra padding in input field
* Revert "Merge branch 'master' of https://github.com/appsmithorg/appsmith into fix/fix-input-size"
This reverts commit 05a97588f8187c5a9f3146214ef523c30d1370d9, reversing
changes made to 4f70eb61e43c1a9270cb6bd05689820351a5b6e0.
* set scrollbarstyle to null in compact mode
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
This is required for enabling custom logging. In future, we can leverage this for proxy caching as well.
Not adding this nginx-root.conf.template file to the installation script because there's nothing for the user to configure there during installation. This file will be baked into the Dockerfile and only the environment variables will be replaced during container start.
* create new app flow
* uncontrolled component error fixed
* loader added when user is deleting or user role is updating
* home page loader and create-new-app loader added
* user role changing and use deleting state fixed
* PR feeback changes added
* orgname loader added
* warnings removed
* fixed create-new-app flow and delete app test cases
* beforeAll test case condition fixed
* Initial navigation condition fixed in createOrg test cases
* app card loading state fixed
* Add datasource connected page
* Default to show connected screen in datasource editor
* Update UI
* Fixes
- Change text from connected to saved
- Show key with empty values if there are no values
- After creating a new datasource go to edit mode
* Stop calling test on save
* Fix tests
* Fix test
* Dummy commit
* Always be in view mode unless clicked on edit mode
* Fixes
- Update datasource connected page for rest api datasource
- Fix empty array values not resetting
* Fix create new api crashing
- While creating new datasource show form in edit mode
* Fix tests
* Adding base code for google re-captcha.
* Removing recaptcha as well
* Adding recaptchaToken on Button.
* Fixing updateMetaProperty errors.
* Handling recaptcha generation failed case.
* Adding a message for recaptcha token gen fail
* Rename setRecaptchaToken
* Adding loading state for recaptcha button
* Adding googleRecaptchaKey as a Btn prop
* Adding the bound functions in widgets
* Removing unused vars.
* Handling google recaptcha key error.
* Adding proper messages for
* Update README.md
* Updating README to add contributor section (#870)
* Remove gitlab-ci configuration files (#865)
We have since moved our CI to Github Actions and no longer require Gitlab CI config files.
* Updating the README in the client codebase
We now reference the global contribution guide directly
* Feature/share app test (#843)
* Add ShareApp test
* Sharing app tests and public access
* Update CONTRIBUTING.md
* Update install.sh
fixes#889
* Update deploy install script to use api64.ipify.org which supports IPv4 (#887)
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
* Id value issue for radio groups (#895)
Fixes: #661
There was issue related to id value while creating new radio group options other than the default ones. And as said I, the id field is not needed at all, but some old config still has the id field.
So since ID field is not required , I have removed it. Which solves the issue.
* Fix triggering of onChange when value is the same (#892)
Fixes: #710
* Invite user modal in view mode can be closed by clicking outside (#906)
* Update README.md
Spelling correction
* #678 Correction in contributing.md for client setup (#907)
Co-authored-by: Saket Agrawal <saketagr@in.ibm.com>
* Docs: Add instructions in client setup for any port conflicts with 80/443 (#918)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* Fix(sign-up): change in sign up error message (#908)
* Fix(backend): Wrong error message while resetting the password fixed, changed from id to email (#911)
Fixes#637
* Options Validaor checks for empty values
Fixes: #662
* fix: add missed error callback for download (#912)
Fixes: #673
* Revert "Options Validaor checks for empty values"
This reverts commit 6b49d4c4e4.
* Update table icon (#761)
* style: center login form when 3rd party auth is not enabled (#919)
* style: center login form when 3rd party auth is not enabled
* style: center signup form when 3rd party auth is not enabled
* fix: input widget number validation #768 (#917)
* Explorer fixes (#689)
* Make entity icon an actionable area
Persist user toggled entity collapse states
* remove dependency on props.isDefaultExpanded
* Hover effect for dependencies
* Pass search keyword for reliable toggling of entity groups on entity search
* Fix default expanded state of Datasource group entity
* Remove plugingroup file, which was added due to a botched merge conflict resolution
* Fix issue with radio widget crashing (#922)
* fix types
* Options Validaor checks for empty values
Fixes: #662
Co-authored-by: Sanchit Jain <171220040@nitdelhi.ac.in>
* Fixed the pull request template issue partially (#902)
Fixes#826
* Feature: Invite modal (#927)
* light and dark mode added in Invite modal
* warnings removed
* create org and invite user test cases fixed
* Application invite design implemented
* manage user icon added
* button width fixed
* PR feedback implemented
* Improve PR template.
* Remove troublesome test
* Fix failing Radio tests (#931)
* Possible fix for CI checkout issue
* Possible fix for CI checkout issue
* Fixed the ipify URL in PingScheduledTask (#1013)
* Revert "Feature: Invite modal (#927)" (#1017)
This reverts commit 63daf74a44.
* Fix image widget not showing default image when image property is invalid (#882)
Fixes: #760
* Fix CI checkouts for all pull_request_target steps
* Local meta state in widgets (#851)
* Update README.md
* Fix for action execution (#1023)
* Adding the condition to fix push vs pull_request_target commit checkouts
* Input Widget: Parse regexp before regex validation (#884)
Fixes#697
* Display warning icon for forgot password failure (#890)
Fixes: #587
* Create Org Form: don't allow to use only spaces in names (#913)
Also disables the submit button when invalid
Fixes: #807, #621
* Auto Focus on email fields in auth screens (#923)
Fixes: #610
Co-authored-by: Anshul <anshul@typito.com>
* Added check for duplicate values in Dropdown and Radio Widgets (#1011)
Fixes#655
* Fix Reset password not disabled after successful reset (#1021)
Fixes#636
* Fix active styles for checkbox & radio (#1061)
Fixes: #994
* Add source to user sign up event (#1065)
* Send separate user create event for new users (#1066)
* Expand datasource entity in explorer based on some conditions (#1062)
* Expand datasource entity in explorer based on some conditions
* Fix test
* Do not show error tost when api fails
* Expand datasource entity on test success
* Use email as id for users and fix signup events not being reported (#1067)
* Fixing typos in the README file (#871)
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* Forgot password submit button enable condition (#701)
Fixes: #586
Co-authored-by: Anshul <anshul@typito.com>
* Adding a new email template for sending an email when an appsmith use… (#1077)
* Adding a new email template for sending an email when an appsmith user's role in an organization changes.
* Minor changes in text.
* Fix - Distorted UI when there are too many characters in email ID #584 (#1010)
* Fix - Distorted UI when there are too many characters in email ID #584
* Fix - Distorted UI when there are too many characters in email ID #584
* Fix the hidden column list is not bounded and overflows in height (#981) (#1024)
* fix(applications): add validation for empty name (#914)
* Update CONTRIBUTING.md
* Update CodeContributionsGuidelines.md
* replaced dragdrop with dsl (#1081)
* Fix datasource structure test (#1080)
* Fix datasource structure test
* Dummy commit
* CI: Try creating build id
* CI: Fix build id step:
* Revert build id changes
* Update README.md
* Fix/new ui is distorted due to long organization name #735 (#1014)
* Fix for long org names on side menu.
Now ellipsizes with tooltip if Orgname is over the value set in ellipsize prop. Otherwise functions as before.
* added ellipsize prop to index. Fixes#735
20 seems to be a good value that stop org names running onto next line. Tested on Firefox and chrome. Linux debian stretch.
Co-authored-by: root <root@rutabaga.groudon>
* Use username instead of object_id in analytics (#1082)
* Adding the close-label.yml file required by Github App to mark issues as QA (#1091)
Fixes#1090
When a PR is successfully merged, the Github bot will add the label QA to the issue. These issues can then be picked up by the QA team for verification. Refer: https://github.com/Logerfo/close-label
* Only mark applications as example applications if the application id exists in the template configuration. (#1093)
* docs: add mohanarpit as a contributor (#1095)
* docs: update README.md [skip ci]
* docs: create .all-contributorsrc [skip ci]
* Moving the contributor badge to the correct location in README
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* docs: add Nikhil-Nandagopal as a contributor (#1096)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* docs: add areyabhishek as a contributor (#1097)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add trishaanand as a contributor (#1098)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add riodeuno as a contributor (#1099)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add hetunandu as a contributor (#1100)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
* docs: add satbir121 as a contributor (#1106)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* docs: add sharat87 as a contributor (#1102)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* docs: add aakashDesign as a contributor (#1107)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add Debsourabh as a contributor (#1108)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add NandanAnantharamu as a contributor (#1103)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* docs: add prapullac as a contributor (#1104)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
* docs: add Saket2 as a contributor (#1109)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add harishkotra as a contributor (#1110)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add visibleajay as a contributor (#1111)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add akbansa as a contributor (#1112)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add gogetter22 as a contributor (#1113)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: add Xniveres as a contributor (#1114)
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* Correcting hyperlink from contributor badge to contributor section
* Show datasource structure fixes (#1078)
* Tests for binding related use cases (#1116)
Co-authored-by: Nandan <nandan@thinkify.io>
* Feature/video widget test (#1115)
Co-authored-by: nandan.anantharamu <nandan@thinkify.io>
* Adding filter tests for table (#1117)
Co-authored-by: nandan.anantharamu <nandan@thinkify.io>
* Getting Cypress to work correctly for internal pull requests (#1121)
* Hotfix to fix the client build workflow
* Update README.md
* Fix release cleanup issues (#1132)
* Changed CSS to prevent share button from coming out (#925)
Changed CSS to prevent share button from coming out.
Decreased the width of the wrapper to a suitable value.
* Fix issue with setting dynamic triggers on immutable widget objects (#1137)
* Feature/invitation modal (#938)
* light and dark mode added in Invite modal
* warnings removed
* create org and invite user test cases fixed
* Application invite design implemented
* manage user icon added
* button width fixed
* PR feedback implemented
* test cases fixed
* used blueprint classes
* used calc for width distribution
* copy button width fixed
* prop passing fixed
* copy button size reduced
* readonly input field background color fixed
* input background theme name ordering changed
* TagInputComponent moved to ads
* created DropdownWrapper for select field in orgInviteForm
* Warnings created due to unique key and depdencies is fixed
* Warning fixed in dropdown component
* correct prop name used
Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
* fix(codemirror-autocomplete): show selection background on hover for options (#1134)
This fix if merged shows the selection background by hovering on autocomplete
options.
Ref: #946
* Stop expanding datasource in explorer after testing (#1138)
Co-authored-by: areyabhishek <nayak.abhishek@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Ari <36749814+ari-hacks@users.noreply.github.com>
Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Co-authored-by: Sanchit Jain <171220040@nitdelhi.ac.in>
Co-authored-by: Nicholas <wasabigeek@users.noreply.github.com>
Co-authored-by: Aditya Vats <avats.osc@gmail.com>
Co-authored-by: Saket2 <49346036+Saket2@users.noreply.github.com>
Co-authored-by: Saket Agrawal <saketagr@in.ibm.com>
Co-authored-by: MartinT <44962077+MartinTuroci@users.noreply.github.com>
Co-authored-by: Dmitriy Danilov <daniloff200@gmail.com>
Co-authored-by: Petro Popelyshko <petrneok@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Omkar Phansopkar <48476025+OmkarPh@users.noreply.github.com>
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
Co-authored-by: Prashant Chaubey <prashantchaubey9795@gmail.com>
Co-authored-by: satbir121 <39981226+satbir121@users.noreply.github.com>
Co-authored-by: Ajay Kumar <visibleajay@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: dodococo <deepakchethan@outlook.com>
Co-authored-by: Josh Mak <joshmak@berkeley.edu>
Co-authored-by: Anshul Bansal <bansalanshul11@yahoo.com>
Co-authored-by: Anshul <anshul@typito.com>
Co-authored-by: Caitlin-Fotheringham <49273562+Caitlin-Fotheringham@users.noreply.github.com>
Co-authored-by: Akash Hamirwasia <akash.hamirwasia@gmail.com>
Co-authored-by: Yash Joshi <jyash97@gmail.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
Co-authored-by: Aadhitya A <59508546+alphaX86@users.noreply.github.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Kishore <reachtokish@users.noreply.github.com>
Co-authored-by: Adam <ascratcherd@gmail.com>
Co-authored-by: root <root@rutabaga.groudon>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Nandan <nandan@thinkify.io>
Co-authored-by: Ishaan Mehta <ishaanmehta4@gmail.com>
Co-authored-by: Thakur Karthik <iamkarthik08@gmail.com>
* light and dark mode added in Invite modal
* warnings removed
* create org and invite user test cases fixed
* Application invite design implemented
* manage user icon added
* button width fixed
* PR feedback implemented
* test cases fixed
* used blueprint classes
* used calc for width distribution
* copy button width fixed
* prop passing fixed
* copy button size reduced
* readonly input field background color fixed
* input background theme name ordering changed
* TagInputComponent moved to ads
* created DropdownWrapper for select field in orgInviteForm
* Warnings created due to unique key and depdencies is fixed
* Warning fixed in dropdown component
* correct prop name used
Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
* Fix for long org names on side menu.
Now ellipsizes with tooltip if Orgname is over the value set in ellipsize prop. Otherwise functions as before.
* added ellipsize prop to index. Fixes#735
20 seems to be a good value that stop org names running onto next line. Tested on Firefox and chrome. Linux debian stretch.
Co-authored-by: root <root@rutabaga.groudon>
* Expand datasource entity in explorer based on some conditions
* Fix test
* Do not show error tost when api fails
* Expand datasource entity on test success
* added appname to PAGE_LOAD data and fixed getCurrentApplication method
* Fixed analytics to save and test datasources
* fixed analytics for create action
* added event for action execution
* added a type for event location
* Make entity icon an actionable area
Persist user toggled entity collapse states
* remove dependency on props.isDefaultExpanded
* Hover effect for dependencies
* Pass search keyword for reliable toggling of entity groups on entity search
* Fix default expanded state of Datasource group entity
* Remove plugingroup file, which was added due to a botched merge conflict resolution
Fixes: #661
There was issue related to id value while creating new radio group options other than the default ones. And as said I, the id field is not needed at all, but some old config still has the id field.
So since ID field is not required , I have removed it. Which solves the issue.
Also adding pull_request_target event for release and master branch. This will run the GH Actions in the context of the base repository instead of the forked one. Hence, the secrets for Cypress, Docker etc can be passed down to the action for PRs being raised via a fork
* bumped sentry version
modified performance monitor to use a queue internally to make synchronous logging easy
added logging for api pane close / open and various different methods
* added use effect to stop tracking on mount of entity properties
* removed open api tracking
* fixed stop tracking to pop from the end instead of the beginning
added tracking for editor mount and sidebar mount
* added tracking for entity explorer
* moved from app route to sentry app route because passing JSX to app route causes re-renders
* Fixing theme and route change issues.
* added performance tracking for API / Query execution and Page Load actions
* added isntrumentation to open / close actions
* added instrumentation for apis & actions
* reduced sample rate
added async tracking
* added tracking for property pane
* Remove tracking from reducer
* added option to attach async operations to parent transactions
* Fix typo
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
* Working version of video player.
* Adding default video url
* Reducing the default widget of video widget
* Fixed tests
* Adding video icon.
* Removing commented code.
* Adding playState, onPause, onStart, onEnd.
* Adding onPlay event.
* Fixing onPlay
* Adding isVisible field.
* Changing video icon.
* Fixing Popover table video.
* Adding an error message for no url.
* bumped sentry version
modified performance monitor to use a queue internally to make synchronous logging easy
added logging for api pane close / open and various different methods
* added use effect to stop tracking on mount of entity properties
* removed open api tracking
* fixed stop tracking to pop from the end instead of the beginning
added tracking for editor mount and sidebar mount
* added tracking for entity explorer
* moved from app route to sentry app route because passing JSX to app route causes re-renders
* Fixing theme and route change issues.
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
* variables defined in light and dark constants in theme.
* warning message removed
* Fixing create app btn click opening form
* blackShades removed and icon color in application card fixed
* state change fixed
* type of light and dark constants added
Co-authored-by: Satbir Singh <satbir121@gmail.com>
* Updating homepage body color
* WIP: Fixing scrolls and adding anchors
* Removing divider from bottom of the page.
* Adding hover background color to app card
* Changing edit and launch icons.
* Fixing app name paddding in card.
* Fixing workspaces overflow
* Adding right padding to applications view
* Adding share icon to share btn
* Fixing Application card styles.
* Fixing text decoration in button.
* Adding new workspace button
* Fixing new workspace and new app styles.
* Adding icon sizes.
* Fixing Org Name and Org settings menu.
* Application menu working
* Fixing overlay visibility on app card
* Fixing settings page content width.
* Fixing workspace icon
* Changing app card colors.
* Removing debugger
* Adding app icon.
* Fixing the spaces in application card
* Adding storybook-static folder to gitignore.
* Adding other storybook files.
* Adding menu items for app
* Removing cypress selector from text.
* Menu width issue fixed
* Default app icon color added
* Removing hardcoded colors
* Removing hardcoded colors.
* Light Mode on!
* Showing correct icon and color in menu
* Update color working properly.
* Updating appIcon
* Editable text working.
* Adding validator
* Adding edit permissions to menu
* Removing box shadow on app card.
* Fixing context menu fill color
* Fixing Menu hover issues.
* Fixing menu open close hover issues.
* Fixing settings pages
* Changed Workspace to org.
* Fix: State management in EditableText Component (#540)
* Error state height is fixed as per design
* savingState prop condition fixed
* Fixing createnew.
* Fixing saving state for application card.
* Fixed application card editable text error.
* Fixing issue caused during merge.
* Fixing tests in create org.
* Removing commented code.
* Removing unwanted vars.
* Fixing delete duplicate tests.
* Latest color palette.
* Fixing form and table widget.
* Removing switcher from header
* Removing unused files
* Fixing app card context dropdown
* Show overlay fix
* Adding localStorage support to theme.
* Making dark mode the default.
Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
* changed chart data to behave as an array <str, str> and not use json stringify to update
added a generic logic to flag all objects with internal bindings as dynamic
moved unescape to only handle at the time of eval and removed new lines before eval
* added a migration for older charts that have their data as strings
* flagged column actions as an action trigger to avoid evaluating it
* minor fix
* fixed chart fields disappearing
* added migration on update
* added migration to constructor
* added a fallback for first time renders
* removed migration from did update
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* changed chart data to behave as an array <str, str> and not use json stringify to update
added a generic logic to flag all objects with internal bindings as dynamic
moved unescape to only handle at the time of eval and removed new lines before eval
* added a migration for older charts that have their data as strings
* flagged column actions as an action trigger to avoid evaluating it
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* callout component with story implemented
* text className import fixed
* callout color and background color fixed
* storywrapper import fixed
* fill property fixed
* background prop added
* added code to merge page load responses if they return before action load responses
* commit to trigger tests
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* removed duplicate user object
removed id field which is never populated
added help modal in applications page and intercom to load in help modal
shutdown intercom on signout to clear existing chats
* added analytics to help modal and invite user
unescaped bindings before evaluation to prune newlines
* updated action confirmation text
* added a check to ignore old properties which are no longer dynamic
* fixed test case
* fix tests
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
removed id field which is never populated
added help modal in applications page and intercom to load in help modal
shutdown intercom on signout to clear existing chats
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* Radio group component with story implemented
* radio group implemented using native input and label.
* radio component height fixed in story
* disabled name in theme corrected for radio
* align prop removed
* checkbox disabled state added and checked UI fixed
* checkbox imported corrected in story
* checkbox implemented using input and label elements.
* align and isChecked props removed
* used styled component for span
* Toggle component implemented with story
* props fixed
* lighten and darken colors implemented
* removed the unused css properties
* removed the used import in story
* toggle hover state fixed
* storywrapper import updated
* query and datasource related tests
* review comment incorporated
* Adding multiple widgets test
* Table widget related search/filter/compact mode tests
* Added tests related to visiblity funvtionality in table widget
* Validate action type in explorer
* updated test
* Test updated in accordance with new UI
* dropdown with text and icon implemented
* dropdown with lable implemented and story updated
* Icon import and storyWrapper import updated
* onclick cleaned
* className added in icon component and used icon names as an array in stories
* button component semicolon fixed
* fill prop added in button component
* name prop and iconName import updated.
* Members and org settings page.
* Adding link back to applications
* Making UI look better.
* Fixing some more css
* Table dropdown onBlur, UI transparency, Popover issue fixed. Added sort arrow (#413)
* table dropdown ui issue and onblur click fixed
* position props value fixed
* tabs tripple click fixed
* Position props in table dropdown made optional
* tabs background color bug removed
* General settings page is bug free.
* Getting the manage users page to work.
* Moving general settings into its own file.
* Removing some unwanted URLs
* User cant change their role or remove themselves
* Changing onClick prop for Icon.
* Fixing tests
* Added loading states to text inputs.
* Added validators for text input
* Fixed border of skeleton for text input
* Adding a loader for Members screen
* Adding Noop to icon button
* Removing console.log
* Fixing imports.
* Moving org reducer to immer.
* Using utils email validator.
* Removing placeholder from text input props.
Co-authored-by: devrk96 <rohit.kumawat@primathon.in>
* menu component implemented and tabs selected ui bug fixed
* PR comments resolved
* icon import updated
* Menu item component (#437)
* Adding blank components.
* Adding Todo note for tree
* Adding todo note for LighteningMenu
* ads button component
* Adding storybook support.
* storybook integrated with button component
* ads button component props completed
* button component icon and loading logic implemented
* button component completed
* Added a text knob.
* Adding default text for button.
* Merging theme and other fixes.
* Fixed info button.
* Better types.
* Adding background param to components.
* Re-using vsariant for callount.
* Added props for Text input.
* Adding text component.
* feedback changes added in button and icon component
* type any removed in button component
* function naming corrected
* menu component implemented
* menu-item implemented with text, icon and label
* menu story updated with menu-items
* menu story updated
* storyWrapper added in all stories
* ads text removed
* spinner import updated
* relative import added
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: satbir121 <39981226+satbir121@users.noreply.github.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: satbir121 <39981226+satbir121@users.noreply.github.com>
* Add action settings tab to api and query pane
- Ask for confirmation before running an action
* Update property of actions basedon the updateLayout response
Prevent confirmation dialog for Action run, until property of action is true
Send an API Request when the user toggles the property of an Action
* update http method to toggle executeOnLoad for an action to PUT
* Fix save layout response type
* Remove console.log
* If updating executeOnLoad, avoid calling update action API
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
* Possible fix for plugins not found
* Add user info on smart look
* Add test for form and table inside form reset
* Add test for postgres nested data render
* search input implemented with both variant
* classname bug resolved in icon component
* PR comments resolved
* ellipsis added for long search keywords
* debounce method attached to search component and input field in table widget filters
* debounce used inside RenderInput component to update changed value
* Cursor going to start issue is fixed
* Update editor content when content is updated using bindings
* Setting local editor's content value in debounce onChange to get the latest value passed to parent
* Explorer related test scripts
* updated test data
* Added tests for widget edit/delete from explorer
* Incorporated review comments
* review comments incorporated
* Adds the `APPSMITH_MAIL_ENABLED` flag on client
* Shows warning if email service not configured for inviting users in an org
* Shows warning if email service not configured for password reset
* Fix tern guessing for completions
* Probable fix for create api button not working
* Close autocomplete when "Backspace" or "Comma" is pressed
* Only show extra docs when ctrl+space is pressed when hint is selected
* Fix issue with action form state params not disabling after taking an action
* Switching to system fonts
* Fixed text alignment issue in text component.
* Changing font of ads components.
* Adding a font type
* Removing unused fonts
* Making fonts in theme an object.
* Removing unncessary font declerations
* Fixing storybook
* Reverting background remove
* Update table widget's filtered data calculations to avoid recursive dataTree evaluations
* Stringify removed from Table component as data is already checked inside TableWidget
* Vertical scrollbar removed from Table Widget. Stop column sorting by stopping event propagation when clicking column menu icon.
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
* Make sure default page is first in view mode
* Update query form on name change
* Add copy support for deploy link
* Show server error when timeout occurs on first load
* Table fix sort, search and filter methods to set correct selectedRow after these methods are applied
* Filtering table data with the latest filters, to correctly select the row
* Setting initial filteredTableData value
* Updating filteredTableData when tableData is updated
Add a default help menu with
* Report a Github issues link
* Documentation link
* Github discussions link
* Intercom link support
* App version id support
* Fixes to data tree appsmith entities
* Add app mode `appsmith.mode`
* Add a common app data state for appsmith namespace entities
* Add autocomplete entries for btoa and atob
* Add urlString property in appsmith.url for full url
* Fix: modal widget closes when navigating to the widgets pane from explorer
* Fix: Align API input tab with the headers
Fix: align delete and run buttons to the right in queries pane
* Fix: while dragging, the cursor must be 'grabbing'
* Set new widget name in editing mode
* Fix: While property pane is open, changing the widget name in entity explorer does not update the name in the property pane
* Fix: The expanded entity property value popup should not have a label, as its function is only to show the full version of truncated data
* Feature: Edit datasource name from entity explorer
* Fix: Allow users to navigate from the placeholder text
* Fix: When moving or copying apis, navigate to the moved or copied api
* Adding blank components.
* Adding Todo note for tree
* Adding todo note for LighteningMenu
* ads button component
* Adding storybook support.
* storybook integrated with button component
* ads button component props completed
* button component icon and loading logic implemented
* button component completed
* Added a text knob.
* Adding default text for button.
* tabs component implemented and theme type added
* Merging theme and other fixes.
* Fixed info button.
* Better types.
* Adding background param to components.
* Re-using vsariant for callount.
* Added props for Text input.
* Adding text component.
* tab props fixed
* feedback changes added in button and icon component
* type any removed in button component
* key prop fixed and icon margin corrected
* Fixing spinner issues
* Removing unwanted files.
* tab header icon size fixed and story updated
* new tab added in tabs story
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: satbir121 <39981226+satbir121@users.noreply.github.com>
* Adding blank components.
* Adding Todo note for tree
* Adding todo note for LighteningMenu
* ads button component
* Adding storybook support.
* storybook integrated with button component
* ads button component props completed
* button component icon and loading logic implemented
* button component completed
* Added a text knob.
* Adding default text for button.
* Merging theme and other fixes.
* Fixed info button.
* Better types.
* Adding background param to components.
* Re-using vsariant for callount.
* Added props for Text input.
* Adding text component.
* feedback changes added in button and icon component
* type any removed in button component
* Text component created with typography and story
* Fixing spinner issues
* Textinput component ads (#252)
* text input component with story is implemented
* Update README.md
* Fixing spinner issues
* Fixing hexToRGBA import
* story error fixed and text component commented for now
* props condition fixed and added error input story
* unused import removed
Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
* story spacing added and component name fixed
* feedback changes implemented
* forward ref added
* feedback changes implemented
* text and textinput stories updated
* pr comments resolved
Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
* Table column header made sticky. Scrollbar background changed to be in consistent with the background for table body scroll and table header scroll
* Row height changed for short compact mode
* New "Tall" row size
* Issue: Tabs widget's child canvas widget's minHeight is not updating
* Fix: Warning removed for unused onTabChange event handler by removing event handler from props passed to ScrollableCanvasWrapper
* Removed tab container not working as droppable component if added again with same name fixed
* Selecting first tab as default tab when no tab is selected in tabs widget. Used getNextEntityName funciton to generate new tab name
* fix: restructure code and show content based on permission
- Restructure Invite user forms into separate App and Org forms
- Show Modal content based on permissions.
* update: Permission handling.
* fix: Modify permission handling
* fix: check manage permission for manage users btn and show copy to clipboard always.
* Dummy commit to run the tests
* Fix: Test cases
* Another dummy commit to run the tests
Co-authored-by: Trisha Anand <trisha@appsmith.com>
* Get query ui from form config
* Update editor config selector
* Show error message when config is undefined
* Move FormLabel to components
* Show dark theme in query editor
* Allow query name to be focused
* Correcting the Docker image for Appsmith server for Github actions test
* Also fixing the bug where the datasource config is not returned properly for restapi-plugin
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
* Fix: When navigating to a widget, the widget reference isn't found, resulting in the property pane rendering without reference. Resolution: Show property pane only if reference is available
# New Feature: Entity Explorer
- Entities are actions (apis and queries), datasources, pages, and widgets
- With this new feature, all entities in the application will be available
to view in the new entity explorer sidebar
- All existing application features from the api sidebar, query sidebar, datasource sidebar and pages sidebar
now are avialable on the entity explorer sidebar
- Users are now able to quickly switch to any entity in the application from the entity explorer sidebar.
- Users can also search all entities in the application from the new sidebar. Use cmd + f or ctrl + f to focus on the search input
- Users can rename entities from the new sidebar
- Users can also perform contextual actions on these entities like set a page as home page, copy/move actions, delete entity, etc from the context menu available alongside the entities in the sidebar
- Users can view the properties of the entities in the sidebar, as well as copy bindings to use in the application.
* Added Redux action to clear widget meta properties when page is fetched
* reset widget meta for view mode too
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* fix table styles
* rich text editor fix
* Fix action panes showing as blank
* correct fix this time
* cleanup
* default search in table
* Fix for text widget heading style
* Fix for table widget filtered table search
* Another approach to see if app has been created
* Fixes in styles of table and text
* Added information to setup domain
* Fixed incorrect var reference
* Updated documentation message
* Updated env template
* updated template
* removed debug echo
* Updated Script
* Updated Text
* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed
* Updated docker installation explanation
* added a question to skip custom domain if user is installing locally
* Inverted script question and
* Removed question to determine local installation
* Updated Popup CTA to Modal
Updated query templates to contain bindings
Added a message to display on API / Query errors
* updated styles for evaluated value
updated styles for auto complete
* added spaces to questions
* grouped data tree functions together in autocomplete
* Updated autocomplete styles
* Updated property pane styles to become more dense
* Fixed lightning menu styling
* fixed tests
* Fixed Cypress test
* added property to show / hide tabs
* fixed selected tabs not updating
* fixed cypress tests for tabs
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* Added information to setup domain
* Fixed incorrect var reference
* Updated documentation message
* Updated env template
* updated template
* removed debug echo
* Updated Script
* Updated Text
* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed
* Updated docker installation explanation
* added a question to skip custom domain if user is installing locally
* Inverted script question and
* Removed question to determine local installation
* Updated Popup CTA to Modal
Updated query templates to contain bindings
Added a message to display on API / Query errors
* updated styles for evaluated value
updated styles for auto complete
* added spaces to questions
* grouped data tree functions together in autocomplete
* Updated autocomplete styles
* Updated property pane styles to become more dense
* Fixed lightning menu styling
* fixed tests
* Fixed Cypress test
* added property to show / hide tabs
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* Added information to setup domain
* Fixed incorrect var reference
* Updated documentation message
* Updated env template
* updated template
* removed debug echo
* Updated Script
* Updated Text
* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed
* Updated docker installation explanation
* added a question to skip custom domain if user is installing locally
* Inverted script question and
* Removed question to determine local installation
* Updated Popup CTA to Modal
Updated query templates to contain bindings
Added a message to display on API / Query errors
* updated styles for evaluated value
updated styles for auto complete
* added spaces to questions
* grouped data tree functions together in autocomplete
* Updated autocomplete styles
* Updated property pane styles to become more dense
* Fixed lightning menu styling
* fixed tests
* Fixed Cypress test
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* Added information to setup domain
* Fixed incorrect var reference
* Updated documentation message
* Updated env template
* updated template
* removed debug echo
* Updated Script
* Updated Text
* Removed option to connect to external mongo for fresh installs
Exit script of docker desktop is not installed
* Updated docker installation explanation
* added a question to skip custom domain if user is installing locally
* Inverted script question and
* Removed question to determine local installation
* Updated Popup CTA to Modal
Updated query templates to contain bindings
Added a message to display on API / Query errors
* updated styles for evaluated value
updated styles for auto complete
* added spaces to questions
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
* Fix UI Bugs
- Double search box width and change text to Search app name
- Half the space between the org icon and the org name on home page
- Make org name bold and increase font to 16px
- Remove manage users button from invite modal if modal is opened in organisation settings page
* fix: Review Comments and other minor changes
- Clear TagList on form submit
- Fix CSS for search widget width
- Fix table height
- Make org name text bold for admin access.
* fix: Test Cases
* feat: Add org share option to application share modal
* fix: Update design and implement copy to clipboard
* fix: Show share based on permission and update modal UI
- Update modal style
- show application share button only to admins.
* fix: refine code
