Commit Graph

175 Commits

Author SHA1 Message Date
Abhinav Jha
0172430489
Fix unreachable code reported by deepsourcelabs (#3483) 2021-03-11 08:46:50 +05:30
Dwayne Forde
2dfc8ebf8a
Adds support for base64 image strings to image cells (#2769) 2021-03-06 01:07:49 +05:30
Dwayne Forde
b074a035b5
Updates json input from typing to value setting (#2805) 2021-03-03 10:34:52 +05:30
NandanAnantharamu
21eecb1fe6
WIP : Added test for chart datapoint validation (#3176)
* Added test for chart datapoint validation

* updated test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-25 12:49:23 +05:30
akash-codemonk
791d92af94
Add validation to check if widget exists (#3140)
* Check if widget is present incase it got deleted etc.

* Update test
2021-02-24 11:30:22 +05:30
NandanAnantharamu
6c80f23201
Feature: DatePicker V2 (#2889)
Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
2021-02-23 18:05:09 +05:30
NandanAnantharamu
d20d013d69
Cypress test for Tab rename from entity explorer (#2780)
* Bug automation

* Test flow completed

* Another bug automation

* Updated tests

* uncommented delete tab test

* Uncommented a test

* updated tests

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-23 15:08:31 +05:30
akash-codemonk
92d1c381f1
Allow searching for page names in explorer and other improvements (#3038) 2021-02-22 19:31:46 +05:30
Piyush Mishra
a4fe0a461e
Table Widget New Features (#2816)
- Each column has more options and can be configured in the property pane instead of the table
- Table level styles can now be set in the property pane
- Property sections are collapsible

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: hetunandu <hetu@appsmith.com>
2021-02-16 15:59:08 +05:30
devrk96
ac23629647
Feature: API Pane Redesign (#2218)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-02-11 18:24:00 +05:30
akash-codemonk
c1b3f311e3
New onboarding flow (#2686)
Co-authored-by: a <rishabh.robben@gmail.com>
2021-02-11 12:06:07 +05:30
Hetu Nandu
5d514849b4
Fix org creation and app creation tests (#2878) 2021-02-04 17:01:32 +05:30
Rishabh Saxena
5da3b0165e
Prevent input component cursor getting reset using asyncControlledInput (#2802) 2021-02-03 14:52:19 +05:30
Rishabh Saxena
8ae86c34e0
Fix: redirect to applications page from auth pages when the user is logged in (#2771) 2021-02-03 13:29:00 +05:30
NandanAnantharamu
7a9ec45901
Added test for invalid binding (#2777)
* Added test for invalid binding

* Updated review comments

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-02-03 11:56:46 +05:30
Rishabh Saxena
b8bcac8544
add support for an onSubmit action for the input widget (#2749) 2021-01-28 16:45:14 +05:30
NandanAnantharamu
704b787435
updated action on file selected (#2691)
* updated action on file selected

* updated common method

* Review comments incorporated

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-27 14:37:33 +05:30
Piyush Mishra
9490ba4eca
Remove SSL related clicks from fillMongoDatasourceForm cypress command (#2726) 2021-01-27 00:04:19 +05:30
Pawan Kumar
f059e40484
Fix - RichTextEditor test by increasing wait time (#2666)
* remove default action function in messages file

* revert getErrorMessageFromActionType comment

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2021-01-21 16:38:18 +05:30
NandanAnantharamu
9f2fbf13c8
Cypress upgrade to 6.2.1 (#2535)
* Cypress upgrade to 6.2.1

* Replaced route and server and assertions

* Removed intercept as it involves changes with alias

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-14 11:14:07 +05:30
NandanAnantharamu
d1d70b8b5c
Updated mongodatasource tests (#2567)
* Updated mongodatasource tests

* Commented assertion for test datasource and updated query test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-13 21:34:23 +05:30
NandanAnantharamu
523e3ec397
flaky test updated (#2468)
* flaky test updated

* updated another flaky test

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2021-01-07 10:37:17 +05:30
akash-codemonk
69cd988c01
Fix onboarding test failure causing other tests to fail (#2417) 2021-01-04 15:52:22 +05:30
Hetu Nandu
4387200262
Sub tree evaluation (#1841)
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Piyush Mishra <piyush@codeitout.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Akash N <akash@codemonk.in>
2021-01-04 15:46:08 +05:30
akash-codemonk
1a35bb1e75
Onboarding flow (#2311) 2020-12-30 13:01:20 +05:30
Rishabh Saxena
778b82f9ae
enable hotkeys only when a widget is selected (#2262) 2020-12-23 16:58:29 +05:30
Arpit Mohan
a942dc198e Revert "Onboarding flow (#1960)"
This reverts commit e84699e7ba.

Reverting this commit because this flow requires more changes before it's ready for prime-time.
Will continue development on this feature in a different branch
2020-12-22 13:02:02 +05:30
akash-codemonk
e84699e7ba
Onboarding flow (#1960)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-12-18 18:48:47 +05:30
NandanAnantharamu
4914e0a3f2
Updated tests from the functional tests (#2234)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-17 11:40:50 +05:30
NandanAnantharamu
095e7d3a8c
Added test for Org logo update and delete (#2177)
Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-12-14 11:50:44 +05:30
Piyush Mishra
22aa9756c1
Resize canvas on delete widget (#1958) 2020-12-11 19:18:01 +05:30
Pawan Kumar
91127ed719
Fix: FilePicker widget was not setting loading state to true on calling action (#1985)
* set loading state on calling action in file picker

* add test cases for file picker loading state

* add tests cases

* add isLoading state in state instead meta

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-12-03 11:02:50 +05:30
Pawan Kumar
9997f2cb9f
Feature: Min and Max date inputs to restrict range in Datepicker Widget (#1865)
* add daterange property control

* fix typescript errors

* update daterangepicker control

* remove daterangepicker control

* add toasts for invalid dates + add test cases

* update test cases

* update test cases

* update test cases + change validation type name + few refactor

* merge release + update toast usage in datepicker control

* update test cases

* update form dsl for test cases

* update test cases

* update setDate command in test cases

* update test cases

* update test case dsl for datepicker widget

* update test cases

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-27 14:18:38 +05:30
Nikhil Nandagopal
9c29b83d07
Fixed Action selector function arg splitting regex to include arrays and objects (#1893)
- Also added navigateTo params field
2020-11-27 10:30:53 +05:30
Pawan Kumar
ad52842e1c
Fix/entity name coincide issue 1396 (#1781)
* Fixing the telemetry on self-hosted instances (#1714)

* Fix issue where creating a new application twice does not work (#1713)

* add check if name is conflicting with internal fn

* use already existing selector

* add conflicting names checks on api/queries/widget names

* add test cases for invalid widget/api/query names

* refactor

* change array to map

* remove getDataTreeKeys selector

* refactor

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: Abhinav Jha <abhinav@appsmith.com>
Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2020-11-23 14:57:00 +05:30
NandanAnantharamu
da9ef2cb2d
Added a check for zoom feature test (#1703)
* Added a check for zoom feature test

* Added another click for zoom-in check

Co-authored-by: nandan.anantharamu <nandan.anantharamu@thoughtspot.com>
2020-11-12 17:34:44 +05:30
akash-codemonk
aefafd33dc
Fix switching datasource in the query pane (#1636) 2020-11-11 17:59:26 +05:30
NandanAnantharamu
da8ab92803
Updated dsl file (#1496)
* Updated dsl file

* fixed the shareApp tests
2020-11-02 20:06:41 +05:30
devrk96
7d6a70d3ce
Feature: New create app flow (#1375)
* EditableTextWrapper component implemented

* create new app flow implemented

* test cases for new create new app flow fixed

* role update element fixed

* before-all hooks fixed

* createOrg test cases fixed

* loading state test added

* editableText input unique identifier added in test-cases

* updateApplication API alias name corrected

* removed the second className prop on same component

* PR feedback implemented
2020-10-31 12:10:51 +05:30
akash-codemonk
9553fe9b19
Merge datasources and actions in explorer (#1285) 2020-10-29 19:23:10 +05:30
devrk96
5ebea89d98
Test cases: Application update (#1339)
* application name and icon update test cases implemented

* application icon update test case implemented
2020-10-28 17:36:30 +05:30
devrk96
15ab7809f8
Org name, email and website update test cases implemented (#1433) 2020-10-28 11:09:28 +05:30
Trisha Anand
fc9ea45e3b
[API breaking change : Automated Tests Will Fail] Page And Action Refactor (#549)
* Introduced new page which stores the published and unpublished pages as separate.

* Mid level commit to save the state.

* Parity of new page repository with old page repository (custom functions)

* WIP : Delete a page. This requires changes across application structure as well.

* Added publishedPages construct inside application to store the pages in the deployed view as well as isDefault so that the same changes (delete or isDefault) in unpublished view doesn't alter these fields for the published application

* Parity reached with PageService.

* Minor ActionService refactor to remove unnecessary code.
ApplicationPageService, LayoutActionService, LayoutService use the new page service to fetch the pages
Minor corrections in fetching the page from new page service in tests

* New save function which sets the PageDTO for unpublished page and then saves the new page into repository.

* Migration of page service functions to new page service functions across other services/tests/controller

* Finished migrating all the page service functions to the new page service functions

* Application Service Tests have been fixed.

* All the existing test cases are working now.

* Publish application implemented to store published pages as well. Added a basic test case to check that published pages is being set and that page's publishedPageDTO is being set accordingly.

* Minor TODOs added to add test cases for published application.

* A few tests to ascertain that published application page fields (deleted, isDefault) does not get changed when these statuses are changed for a page in edit mode.

* Added a new controller end point to fetch application in view mode.

* Added new endpoint for fetching an application in view mode on the client.

* Bug fix where get application in view mode API was not getting called.

* Fixed the get page names by application & archive pages which have been deleted in edit mode during publishing of application.

* During delete page, if a page was never published and it was deleted during edit, delete the entire page instead of just deleting the unpublished PageDTO

* Minor formatting.

* Non working client side code to fetch page list using view mode.

* revert unnecassary changes and streamlined view and edit actions

* Fix missed import

* Fixed a bug where if a page is not published, it should not be returned in view mode in list of page names api.

* Fixed update for a page which was not working in integration test.

* ActionDTO added.

* Solidified the new action structure.

* Migration added for NewAction index creation and NewAction per Action insertion in the database.

* Basic file structure added the new repository, custom repository, service, etc.

* Delete OldPage.java

* Repo functions added - TODO : Haven;t handled the published/edited views

* Helper functions added to convert Action to NewAction and vice-versa. Removed unused currentUserMono usage.

* Create & update action functionality added.

* Execute Action refactored. Removed dry run specific code.

* Repository migrated to handle new data structure. Execute action refactored to no longer support dry runs of actions.

* TODO added for special handling of change view of application to handle edge cases of pages/actions which either exist in published mode but don't exist in unpublished mode or vice versa.

* Migrated finding on load actions from spring repository to custom repository.

* In view mode, now actions are being fetched by application id directly instead of first fetching application and then using the page ids, fetching the actions. This reduces the db calls from 2 to 1 per fetch actions in view mode api call.

* Delete action and get all actions (used in edit mode on the client side) implemented.

* Updated CollectionService and ActionCollectionService to use the new action service instead of the old one.

* LayoutActionService refactored to now use the new service functions.

* ActionController now no longer used ActionService. The remaining service functions have been migrated to the new action service.

* Refactor across ACL code for addition/removal of policies during addition/removal of users to organization, making app public, refactor for services like policy utils, item service, etc.

* Removed the last of action repository and action service and replaced with new action repo and new action service.

* Compile and run time issues fixed. The server is coming up without any spring dependency errors.

* WIP in fixing fetching actions by page id.

* Finally!!! Fixed the fetch actions (both published and unpublished actions) by page id repository function.

* Fixed create action bug where null datasource in published actiondto (inside newly created action) leads to error.

* Fixed the execute action issues :
1. Removed the dry runs from the tests
2. Fixed the null pointer error in variable substituted action and datasource configurations.

* 1. Fixed the custom action repository field names.
2. Fixed the data structures used in ExamplesOrganizationClonerTests

* Fixed countByDatasourceId repository function which was querying the actions incorrectly.

* Fixed the clone example organization error where the id of the action was not getting updated in the page correctly. Yay!

* Fixed post merge compilation failure.

* Fixed more compilation time failures in ActionServiceTest

* Fixed failing test case for fetching actions in view mode.

* Minor changes to resolve merge changes and incorporate in the new refactored code.

* 1. Fixed compile time errors on Client code.
2. Fixed fetching of actions in view mode by application id. The repository function did not need name parameter. Removed the same.

* [Integration Testing Error Fix] : Added a new test case for refactor action name.

* Instead of fetching actions in the page, mistakenly used the base service which was fetching all the actions in the repository, barring none which led to the name refactor being blocked even though no action in the current page exists with the new proposed name,

* Added delete functionality to action service.

* Minor code cleanup

* Adding viewMode to action execution

* Replacing action with actionId.

* 1. Bug fix for deletion of unpublished action. In case of never published action, the entire action should be deleted. In case an action was published, only the unpublished action should be deleted.
2. In case of DB actions (external datasources), only the bare minimum fields should be stored inside the action (datasource id and datasource plugin id). The other fields should not be duplicated across code.

* Fixed yarn build compilation issues.

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ActionController.java

Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>

* Changed the API path for GET applications in view mode. Some minor code formatting.

* Incorporated review comments.

* Some more unnecessary code removed.

* Instead of returning Page, now the interface object between client and server for Pages is PageDTO

* Migrated Page and Action to PageDTO and ActionDTO
Fixed the compilation issues.
TODO : Fix the test compilation issues.

* Fixed compilation time issues with all the tests by migrating Page and Action to PageDTO and ActionDTO respectively

* Action Controller and Page Controller no longer extend Base Controller. All the required functions have now been implemented and no base line API end points are being re-used from the base.

* Test case fixes.

* Bug Fix : Updating an action was not updating execute on load. Fixed the data flow leading to the error.

* Deprecating Page and Action domain objects. This is to ensure no new code is written with these till we remove this old code.

* Cloned example applications are now published before returning. This is to ensure that the applications are in ready to view mode when the new user signs up.

* Added a function comment to expand on the usage of new param introduced.

* When cloning a page, new actions were not being stored. Added that. Also updated the clonePage test to assert that the actions are also cloned when the pages are cloned.

* Updated a Api call

* removed extra slash

Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Satbir Singh <satbir121@gmail.com>
Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com>
Co-authored-by: nandan.anantharamu <nandan@thinkify.io>
2020-10-26 18:04:23 +05:30
Hetu Nandu
655b160922
Web worker evaluation (#706)
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
2020-10-21 09:55:32 +05:30
satbir121
6c1e13a6e9
Revert create new app flow to use the old flow for now (#1265) 2020-10-20 12:44:39 +05:30
Lois Harris
2e6ba8d8fd
[#1136] Fix the Appsmith logo click href (#1255)
Fixes: #1136
2020-10-19 19:04:55 +05:30
NandanAnantharamu
10fe3ba171
Feature/navigate totests (#1187)
* Adding tests for Navigateto function

* Updated locators and renamed tests
2020-10-16 14:17:54 +05:30
Hetu Nandu
863f5816e1
Fixes issue for pageOnload action timing out crashing the app. (#1219)
* Fixes issue for page onload timing out crashing the app.

* Add tests
2020-10-15 17:08:55 +05:30
devrk96
539253f17e
Feature: Create new-app flow (#926)
* create new app flow

* uncontrolled component error fixed

* loader added when user is deleting or user role is updating

* home page loader and create-new-app loader added

* user role changing and use deleting state fixed

* PR feeback changes added

* orgname loader added

* warnings removed

* fixed create-new-app flow and delete app test cases

* beforeAll test case condition fixed

* Initial navigation condition fixed in createOrg test cases

* app card loading state fixed
2020-10-14 16:05:19 +05:30
NandanAnantharamu
ccb2c7013e
Feature/pause test (#1125)
* updated video widget tests

* Updated video widget test
2020-10-14 10:49:08 +05:30