Commit Graph

689 Commits

Author SHA1 Message Date
Abhinav Jha
d5c7fcc1e4
Fix table crash issue when selectedRowIndices was reset (#1542) 2020-11-03 22:16:44 +05:30
Nikhil Nandagopal
8a1be448e1 added a fix for null crashing a page in bindings 2020-11-03 21:17:16 +05:30
Abhinav Jha
543b7ec72d
Entity Explorer Render (#1354)
* WIP: Performance improvements in entity explorer

* WIP: Achieve feature parity for entity explorer with release

* Update unit tests

* Add sentry profiling to current page entity properties component

* Fix page add/delete not showing up on entity explorer issue. Update memoization logic for pagegroup entity

* Deal with the ban-ts-ignore eslint issues

* Update unit tests

* Fix widget entity children visibility

* Fix tests and code

* Fix tests for scenarios where the collapsed entities are unmount, as this is a part of the performance optimization

* Filter undefined children when generating structureDSL

* Remove rule from eslintrc

Consolidate createPage test command

* Update CreatePage tests to remove redundant dsl updates

* Revert CreatePage test changes, as adding more checks within this command globally causes other tests to have issues.

* re-enable eslint rule, as without it CI tests fail

* Revert to ban-ts-comment

* Fix typescript ban-ts-ignore issue by upgrading react-scripts and fixing typescript issue across the application

* Typescript errors handled

Co-authored-by: vicky-primathon.in <vicky.bansal@primathon.in>
2020-11-03 18:35:40 +05:30
Abhinav Jha
120c2da507
Fix: Tabs Widget (#1532)
* Fix issue where placing widgets into the first tab of a tabs widget was disallowed.

* Concatenate using spread instead of produce

* Remove widget blueprint from widget props

* Deal with nested blueprint
2020-11-03 18:32:50 +05:30
Sumanth Yedoti
87a2effbc5
Fix/api URL field twitch (#1495)
Fixes: #1248
Co-authored-by: Yedoti Sumanth <sumanthyedoti@redd.in>
2020-11-03 12:21:02 +05:30
akash-codemonk
9afcf87156
Show binding prompt when there is no binding in the editor (#1478) 2020-11-03 09:40:07 +05:30
devrk96
09ce4329b0
underline css fixed (#1515) 2020-11-02 19:35:31 +05:30
satbir121
51cb0d82a2
Fixing zoom on pan issue. (#1474)
* FIxing zoom on pan issue.

* Adding a disabled label to 1x zoom.

* Adding comments.

* Update PropertyPaneConfigResponse.tsx

Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
2020-11-02 15:21:14 +05:30
akash-codemonk
ac70e5be4d
Update query form UI (#1500) 2020-11-02 15:01:00 +05:30
Nikhil Nandagopal
2ec5b6297b
Fix/action splitting (#1497)
* fixed argument splitting logic to rely onregex instead of simple string split

* abstracted splitting function
2020-11-02 10:54:15 +05:30
devrk96
7d6a70d3ce
Feature: New create app flow (#1375)
* EditableTextWrapper component implemented

* create new app flow implemented

* test cases for new create new app flow fixed

* role update element fixed

* before-all hooks fixed

* createOrg test cases fixed

* loading state test added

* editableText input unique identifier added in test-cases

* updateApplication API alias name corrected

* removed the second className prop on same component

* PR feedback implemented
2020-10-31 12:10:51 +05:30
Nikhil Nandagopal
5c26ef5d07
Fixed Bindings Working inside action selectors (#1484)
* added functions to convert string to JS and JS to string while manipulating property pane values
refactored getters and setters to reuse functions instead of creating multiple functions

* minor fixes

* optimized the js conversion function and fixed an edge case

* minor fix for type setters

* abstracted enum getter

* dummy commit
2020-10-30 18:05:21 +05:30
vicky-primathon
75c84cbba7
Map resetting when clicking on a marker fix (#1299) 2020-10-29 23:46:27 +05:30
Nuwan Sameera Alawatta
e782ca17e8
fix lightning bolt menu onhover bug (#1454)
* fix lightning bolt create new api onhover bug

* fix lightning bolt menu onhover bug
2020-10-29 19:00:04 +05:30
devrk96
f6bb16a4e6
Fix: Invalid email error in invite modal (#1368)
* Invalid email error showing on entering incorrect email before submission

* error state name corrected

* colon removed from error message
2020-10-29 16:47:52 +05:30
satbir121
540f2637b5
Adding zoom on image widget. (#1356)
* Adding zoom on image widget.

* Changing zoom level to step.

* Fixed typescript issue.

* Added zoom-in/out on Click.

* Removing bad code.
2020-10-29 16:44:39 +05:30
vicky-primathon
dbf98fde5f
Fix/table widget filter conditions (#1297)
* Table widget isEqualTo and notEqualTo conditions fixed
2020-10-28 21:10:33 +05:30
vicky-primathon
4cd2579dfa
Added horizontal scrolling in table widget (#1436)
* Added horizontal scrolling in table widget

* Handled table grow shrink with display table css property
2020-10-28 19:49:15 +05:30
devrk96
5ebea89d98
Test cases: Application update (#1339)
* application name and icon update test cases implemented

* application icon update test case implemented
2020-10-28 17:36:30 +05:30
devrk96
bc70460093
role change update fixed (#1192) 2020-10-28 17:21:14 +05:30
devrk96
15ab7809f8
Org name, email and website update test cases implemented (#1433) 2020-10-28 11:09:28 +05:30
akash-codemonk
0f34c7f38f
Secure connection UI (#1358) 2020-10-27 10:32:32 +05:30
akash-codemonk
f19810117b
Query editor styling fixes (#1318) 2020-10-21 13:24:10 +05:30
Hetu Nandu
655b160922
Web worker evaluation (#706)
- Adds Web workers and does evaluations in off the main thread
- Removes any need to store functions in the data tree and only keeps them around while evaluating
- Maintains a stored data tree in the redux state
- Evaluates based on editor events instead of state changes
2020-10-21 09:55:32 +05:30
Akshay Avinash
4cd2d94f74
Updated positioning of delete icon and eslint error fix (#1304) 2020-10-20 20:29:28 +05:30
vicky-primathon
56225d2fdd
Rich text editor content with newline is parsed for RTE (#1296) 2020-10-20 13:24:05 +05:30
satbir121
6c1e13a6e9
Revert create new app flow to use the old flow for now (#1265) 2020-10-20 12:44:39 +05:30
vicky-primathon
3ae032de38
Remove RTE intance from tinymce editor instances when component is unmounted (#1076)
Fixes #785
2020-10-19 19:10:00 +05:30
Shrikant Sharat Kandula
920b38da90
Resolve conflict with master (#1246)
* added code to not identify anonymous users

* minor fix

* added alias for users so that segment works with mixpanel

* removed alias since we enabled identity merge for mixpanel

* added fix to not send anonymous user

* Add first_login event for analytics (#1184)

* Don't send full object to analytics (#1186)

* added binary raw data to be set for files picked (#1211)

* added binary raw data to be set for files picked

* spread options before modifying to maintain immutability

* Add isFromInvite field to create_USER event (#1223)

* Adding dummy commit to trigger build

* added extra information to execute action call (#1244)

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Nikhil Nandagopal <nikhil.nandagopal@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
2020-10-19 16:36:44 +05:30
Yash Joshi
c085fc778d
Fix evaluated pane scrollbar style (#1251)
fixes: #1182
2020-10-19 12:02:07 +05:30
akash-codemonk
0772bffe23
Create a new input field which outputs a key value pair (#1226) 2020-10-16 13:04:32 +05:30
Shrikant Sharat Kandula
0055f01f2f
Remove extraneous scrollbars in API action pane (#1222) 2020-10-16 12:28:34 +05:30
Pushkar Khedekar
2ac8ec589f
minor fix for column resizing onevent (#1235) 2020-10-16 11:59:50 +05:30
Thakur Karthik
fd9fa46bdd
Fix/fix input size (#1207)
* fix(codemirror-autocomplete): show selection background on hover for options

This fix if merged shows the selection background by hovering on autocomplete
options.

Ref: #946

* added code to not identify anonymous users

* minor fix

* added alias for users so that segment works with mixpanel

* removed alias since we enabled identity merge for mixpanel

* added fix to not send anonymous user

* Add first_login event for analytics (#1184)

* Don't send full object to analytics (#1186)

* fix for removing the extra padding in input field

* Revert "Merge branch 'master' of https://github.com/appsmithorg/appsmith into fix/fix-input-size"

This reverts commit 05a97588f8187c5a9f3146214ef523c30d1370d9, reversing
changes made to 4f70eb61e43c1a9270cb6bd05689820351a5b6e0.

* set scrollbarstyle to null in compact mode

Co-authored-by: Nikhil Nandagopal <nikhil@appsmith.com>
Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2020-10-16 11:56:03 +05:30
Hetu Nandu
863f5816e1
Fixes issue for pageOnload action timing out crashing the app. (#1219)
* Fixes issue for page onload timing out crashing the app.

* Add tests
2020-10-15 17:08:55 +05:30
satbir121
5c6b2e1f98
Removing a bad fix for Table column width. (#1213)
* Removing a bad fix in Table column.

* Removing unwanted code.
2020-10-15 14:56:27 +05:30
devrk96
539253f17e
Feature: Create new-app flow (#926)
* create new app flow

* uncontrolled component error fixed

* loader added when user is deleting or user role is updating

* home page loader and create-new-app loader added

* user role changing and use deleting state fixed

* PR feeback changes added

* orgname loader added

* warnings removed

* fixed create-new-app flow and delete app test cases

* beforeAll test case condition fixed

* Initial navigation condition fixed in createOrg test cases

* app card loading state fixed
2020-10-14 16:05:19 +05:30
Shrikant Sharat Kandula
4a070c3d92
Fix blank scrollbars on Firefox (#1171)
* Fix blank scrollbars on Firefox

* Hide scrollbars on Firefox for consistency
2020-10-14 10:56:43 +05:30
Abhinav Jha
76ae0103bf
Upgrade npm packages (#1079)
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
2020-10-12 18:36:05 +05:30
satbir121
8bf80fe507
Google Recaptcha integration for button and form button widgets. (#1118)
* Adding base code for google re-captcha.

* Removing recaptcha as well

* Adding recaptchaToken on Button.

* Fixing updateMetaProperty errors.

* Handling recaptcha generation failed case.

* Adding a message for recaptcha token gen fail

* Rename setRecaptchaToken

* Adding loading state for recaptcha button

* Adding googleRecaptchaKey as a Btn prop

* Adding the bound functions in widgets

* Removing unused vars.

* Handling google recaptcha key error.

* Adding proper messages for
2020-10-12 18:31:19 +05:30
Thakur Karthik
d476bb14bc
fix(codemirror-autocomplete): show selection background on hover for options (#1134)
This fix if merged shows the selection background by hovering on autocomplete
options.

Ref: #946
2020-10-12 13:49:29 +05:30
satbir121
1cafe307d5
Feature/invitation modal (#938)
* light and dark mode added in Invite modal

* warnings removed

* create org and invite user test cases fixed

* Application invite design implemented

* manage user icon added

* button width fixed

* PR feedback implemented

* test cases fixed

* used blueprint classes

* used calc for width distribution

* copy button width fixed

* prop passing fixed

* copy button size reduced

* readonly input field background color fixed

* input background theme name ordering changed

* TagInputComponent moved to ads

* created DropdownWrapper for select field in orgInviteForm

* Warnings created due to unique key and depdencies is fixed

* Warning fixed in dropdown component

* correct prop name used

Co-authored-by: Rohit Kumawat <rohit.kumawat@primathon.in>
2020-10-12 12:45:35 +05:30
Hetu Nandu
9ac935c424
Fix release cleanup issues (#1132) 2020-10-11 19:02:02 +05:30
Adam
43c0613fb7
Fix/new ui is distorted due to long organization name #735 (#1014)
* Fix for long org names on side menu.

Now ellipsizes with tooltip if Orgname is over the value set in ellipsize prop. Otherwise functions as before.

* added ellipsize prop to index. Fixes #735

20 seems to be a good value that stop org names running onto next line. Tested on Firefox and chrome. Linux debian stretch.

Co-authored-by: root <root@rutabaga.groudon>
2020-10-09 10:55:00 +05:30
Adam
2e63b394d5
Fix the hidden column list is not bounded and overflows in height (#981) (#1024) 2020-10-08 15:33:34 +05:30
Anshul Bansal
776daa61ba
Auto Focus on email fields in auth screens (#923)
Fixes: #610 
Co-authored-by: Anshul <anshul@typito.com>
2020-10-07 12:37:16 +05:30
Arpit Mohan
bb87386406 Merge branch 'master' into release 2020-10-07 06:46:23 +05:30
Hetu Nandu
bf2b4efbfd
Fix for action execution (#1023) 2020-10-06 22:17:16 +05:30
Nikhil Nandagopal
194f27aabb
Feature/analytics (#1022)
* added appname to PAGE_LOAD data and fixed getCurrentApplication method

* Fixed analytics to save and test datasources

* fixed analytics for create action

* added event for action execution

* added a type for event location
2020-10-06 20:40:21 +05:30
Ajay Kumar
9fce3912ea
Fix image widget not showing default image when image property is invalid (#882)
Fixes: #760
2020-10-06 12:06:57 +05:30