Commit Graph

377 Commits

Author SHA1 Message Date
Aishwarya-U-R
8f4756c1d1
test: Automated tests for AForce Migration scenarios + Improved TableFilter spec script coverage (#12534)
* Aforce spec- DefaultSearchText added

* Bug 12228 scripted

* Remove text added

* Aforce - Client Side Search added

* Aforce - adding new issue from modal

* Aforce spec - add new issue fixed

* Aforce spec - update/Delete issue added

* Aforce - multi widget selection fix

* aforce spec - multi select fix

* Aforce - multi select fix

* Aforce - multi select fix

* Removing Table_Filter_spec from ignore files

* MemberRoles locator fix

* member roles locator update

* Tablefilter spec fix

* Aforce spec type fix

* Aforce - search spec

* TableFilter spec fix

* Chartdatapoint fixed

* desc update

* Aforce - skipping table search again

* Removed duplicate spec

* GetNClick improved

* BindTable_api spec fix

* AForce spec fix

* CHartdatapoint spec fixed

* JSObjToListwidget spec fix

* OnPageLoad spec fix

* updates

* TableFilter.ts added

* TableFilter added more scenarios

* TableFilter added more scenarios

* Table_spec failure fix

* TableFilter spec - scenarios added

* AForce Filter case added

* AForce fix

* Aforce filter fix

* Aforce fix

* SelectFromMultiSelect added fix

* Picking msg from message.ts file

* Aforce spec - Added wait

* Aforce - filter spec fix

* JSONload messages update
2022-04-12 15:31:22 +05:30
Trisha Anand
85ebed6d5e
Merge branch 'master' into release 2022-04-12 14:06:53 +05:30
NandanAnantharamu
db2310bef7
test: Commands file organised (#12533)
* Commands file seggregated

* updated support file

* updated common method

* updated the support files

* Updated imports
2022-04-11 09:00:37 +05:30
Favour Ohanekwu
dcddf4cb86
chore: Add data property in entity explorer as part of "show bindings" (#12590)
* include JSAction data in show-bindings
2022-04-07 21:37:03 +01:00
Bhavin K
d22ae809cb
fix: handle duplicate tab name in tab widget (#12411) 2022-04-07 16:19:12 +00:00
arunvjn
2ac4d917f7 Merge branch 'release' into releasev1.6.17 2022-04-07 16:01:26 +05:30
Aishwarya-U-R
6363e75bda
test: Automation script update to fix JSOnPageLoad pop-up text message (#12673) 2022-04-07 15:55:24 +05:30
arunvjn
c3fdeb884e Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 15:43:29 +05:30
Aishwarya-U-R
cb14819046
JSOnPageLoad pop-up text msg fix (#12671) 2022-04-07 12:08:26 +02:00
arunvjn
1c5e216e6f Merge branch 'release' of github.com:appsmithorg/appsmith into releasev1.6.17 2022-04-07 14:08:48 +05:30
arunvjn
03b46483dc
fix: 404 on apps with names that start with api, login or oauth (#12619) 2022-04-07 07:39:15 +02:00
arunvjn
f18d3b8dc4
fix: update url while switching between git branches (#12586) 2022-04-06 11:46:37 +02:00
Apeksha Bhosale
e7d4bdba6e
fix: removed promisification of confirmation (#12553)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-04-06 12:52:18 +05:30
arunvjn
1af6ef2be8
fix: 404 on renaming new pages in apps with legacy URLs (#12547) 2022-04-04 13:11:52 +02:00
Parthvi12
6653adc30e
test: add tests for git import flow (#12427)
* adding basic test for git import

* add git import test
2022-04-04 13:27:34 +05:30
Aishwarya-U-R
7a7169e8c3
test: Cypress tests to include Deploy mode verifications + few flaky fixes (#12444) 2022-04-03 18:43:20 +02:00
Aishwarya-U-R
9bbd671b3f
test: Automated few tests for AForce Migration scenarios + Flaky fixes (#12231) 2022-03-31 17:21:08 +05:30
Ayangade Adeoluwa
1cd8dde12c
feat: uses codemirror to display query results (#11312)
* uses codemirror to display query results

* Add finishing touches to codemirror component

Co-authored-by: Adeoluwa Ayangade <adeoluwaayangade@Adeoluwas-MacBook-Pro.local>
2022-03-30 13:12:15 +00:00
Preet Sidhu
c9069bedce
Merge pull request #11673 from appsmithorg/fix-11468_dropdown_performance
fix: 11468 select widget performance on a large data set.
2022-03-30 18:41:59 +05:30
Arpit Mohan
6a3ec51287 Merge branch 'master' into release-300322 2022-03-30 12:33:15 +02:00
arunvjn
23c12f4afc
fix: URL slugs in duplicate, import and export operations. (#12283)
* Persists modal to show info when update is in progress
2022-03-28 18:30:05 +00:00
Preet
d456df8cf6 Merge branch 'release' into fix-11468_dropdown_performance 2022-03-28 12:01:15 +05:30
Preet
28fc96b020 undo common locators lint fix 2022-03-28 12:01:02 +05:30
Aswath K
5330437d1a
feat: Makes jsToggle keyboard accessible (#12048)
* Makes jstoggle keyboard accessible

* fix cypress locator
2022-03-28 11:21:52 +05:30
Parthvi12
794c0f2299
test: add test for git sync bug #10773 (#12267)
* added test for git sync bug and fixed flaky tests

* updating git test
2022-03-28 10:40:07 +05:30
Preet Sidhu
74def3bb98
Merge branch 'release' into fix-11468_dropdown_performance 2022-03-25 16:45:14 +05:30
Preet
4b14f2bf4f fix merge conflicts 2022-03-25 16:44:12 +05:30
Preet
16bea463e7 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:34:40 +05:30
arunvjn
69c09c03aa
feat: adding slug names in urls (#10957)
* Init commit clean urls

* Changes to builder route

* Refactored URLs

* Remove default params from url builder functions.

* Fixed more urls

* Changed selector name

* Minor url correction

* Type fixes

* Jest fixes

* Fixed routing for old published apps

* Fixed url slug replace

* page-1 -> page1 as default page slug name

* Remove application id from init editor calls

* Use default page slug

* Added comments and placeholder values for slug names

* variable rename

* Removed redirection and added back the old routes

* Prevent page slug name recompute

* Fixed home page load in view mode

* Added null checks

* Fixed jest test

* Fixed jest test

* Update URL slugs when app/page name changes

* Added unit tests and updates types

* Removed unused code

* * Removed duplication fetch page call.
* Fixes #11354
* Fixed sign up flow

* Refactored initializeEditorSaga

* Fixed warnings

* Fixed integrations screen URL bugs

* Cypress fixes

* Fixed slug names in copy/move operations and pages screen

* Minor refactor

* Fixed page highlight bug in published apps

* Added new url factory and middleware to store url params

* Changed store to default export and fix unit tests

* Fixed slugs unit test

* Minor fixes

* Fixes #11379

* Fixed set as home page feature

* Updated types

* app id adjustments for cypress

* Fixed bad merge

* Refactored routes to functional component

* * Fixed EE active entity highlight.
* Remove unused code in editor router.

* jest fix

* Mock history to prevent security errors

* constant rename

* Removed console logs

* Fixed page id regex

* Do not check for /pages in url

* Fixed missing pageId on quick edit/deploy clicks

* Missed files from previous commit

* Fixed warnings

* Fixed jest test

* New api integration

* feat: Add applicationVersion property to Application (#11626)

Added a new property to Application object - applicationVersion. This property can be used to identity when there is a breaking change and can not be solved with migration. FE will use this property to detect such conditions. Another API is added to migrate the applicationVersion to latest version when user migrates the breaking changes.

* Added manual upgrade modal.

* Test fix

* Fixed jest test

* function rename

* Fix deploy error

* Added null check

* Changes to persist URL search params when redirecting

* Added updates tooltip

* More unit test cases

* Fixed git url redirection

* Fix warning

* Fixed evaluation on upgrade

* Fixed warnings

* File rename

* Added cypress for clean urls

* Fixed import/export/fork cypress

* Cypress api server fixes

* Fixed mongo spec

* Fixed replay spec

* Fixed comments spec

* More cypress fixes

* Fixed tooltip in update btn

* Text size changes

* Minor fixes

* Jest test fix

* Fixed type error

* Fixed warnings

* Fixed todo comments

* Moved description to constants file

* Fixed cypress CI run crash

* Fixes git cypress failures

* Import/Export cypress test fixes

* Import export fork cypress fixes

* Explorer test fix

* Switch branch test fix

* Added applicationVersion in export app json

* Calls plugin forms in parallel

* Fixed warnings

* Fixed warning

* Import export CI fixes

* Reverts previous changes

* Fixes import export

* Fixed import export cypress URL verification

* Pass applicationVersion when duplicating application

* Cypress fix

* Dummy commit

Co-authored-by: Nayan <nayan@appsmith.com>
2022-03-25 16:13:26 +05:30
Preet
6902255b72 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-25 16:06:37 +05:30
Aishwarya-U-R
f68bdaa453
test: Skip Git flaky test to unblock CI (#12238)
* Commenting git flaky

* BindApiWIthlistWidget validaton fix

* BindApiWIthlistWidget validaton fix

* SwitchGroup spec fix

* command.js change
2022-03-25 12:04:23 +05:30
Aishwarya-U-R
761e697da8
test: Automated tests improvements for Mongo CRUD cases + few flaky fix (#11985)
* Adding AForceMigration spec

* Merge from release

* Mongo CRUD data load check added

* Added bug id & adding to skip to checkin

* Unskipping MySQL_Spec to test TED

* Api-bugs spec fix

* Adding back MySQL_Spec to ignore

* EE_CopyQuery_RenameDatasource_spec revert to fix

* Skipping Git_sync flaky test

* Removing mySQl from ignore

* Unskipping Mongo cases as Bug12162 fixed

* Empty files moved due to Mocha update
2022-03-25 01:04:28 +05:30
Apeksha Bhosale
d0fdabaccd feat: Settings js editor (#9984)
* POC

* Closing channels

* WIP

* v1

* get working with JS editor

* autocomplete

* added comments

* try removing an import

* different way of import

* dependency map added to body

* triggers can be part of js editor functions hence

* removed unwanted lines

* new flow chnages

* Resolve conflicts

* small css changes for empty state

* Fix prettier

* Fixes

* flow changes part 2

* Mock web worker for testing

* Throw errors during evaluation

* Action execution should be non blocking on the main thread to evaluation of further actions

* WIP

* Fix build issue

* Fix warnings

* Rename

* Refactor and add tests for worker util

* Fix response flow post refactor

* added settings icon for js editor

* WIP

* WIP

* WIP

* Tests for promises

* settings for each function of js object added

* Error handling

* Error handing action validation

* Update test

* Passing callback data in the eval trigger flow

* log triggers to be executed

* WIP

* confirm before execution

* Remove debugging

* Fix backwards compatibility

* Avoid passing trigger meta around

* fix button loading

* handle error callbacks

* fix tests

* tests

* fix console error when checking for async

* Fix async function check

* Fix async function check again

* fix bad commit

* Add some comments

* added clientSideExecution flag for js functions

* css changes for settings icon

* unsued code removed

* on page load PART 1

* onPageLoad rest iof changes

* corrected async badge

* removed duplicate test cases

* added confirm modal for js functions

* removed unused code

* small chnage

* dependency was not getting created

* Fix confirmation modal

* unused code removed

* replaced new confirmsaga

* confirmaton box changes

* Fixing JSEditor Run butn locator

* corrected property

* dependency map was failing

* changed key for confirmation box

Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-24 11:04:36 +01:00
ashit-rath
32fee08c5c
feat: JSON Form widget (#8472)
* initial layout

* updated parser to support nested array

* array field rendering

* changes

* ts fix

* minor revert FormWidget

* modified schema structure

* select and switch fields

* added checkbox field

* added RadioGroupField

* partial DateField and defaults, typing refactoring

* added label and field type change

* minor ts changes

* changes

* modified widget/utils for nested panelConfig, modified schema to object approach

* array/object label support

* hide field configuration when children not present

* added tooltip

* field visibility option

* disabled state

* upgraded tslib, form initial values

* custom field configuration - add/hide/edit

* field configuration - label change

* return input when field configuration reaches max depth

* minor changes

* form - scroll, fixedfooter, enitity defn and other minior changes

* form title

* unregister on unmount

* fixes

* zero state

* fix field padding

* patched updating form values, removed linting warnings

* configured action buttons

* minor fix

* minor change

* property pane - sort fields in field configuration

* refactor include all properties

* checkbox properties

* date properties

* refactor typings and radio group properties

* switch, multselect, select, array, object properties

* minor changes

* default value

* ts fixes

* checkbox field properties implementation

* date field prop implementation

* switch field

* select field and fix deep nested meta properties

* multiselect implementation

* minor change

* input field implementation

* fix position jump on field type change

* initial accordian

* field state property and auto-complete of JSONFormComputeControl

* merge fixes

* renamed FormBuilder to JSONForm

* source data validation minor change

* custom field default value fix

* Editable keys for custom field

* minor fixes

* replaced useFieldArray with custom logic, added widget icon

* array and object accordian with border/background styling

* minor change

* disabled states for array and objects

* default value minor fix

* form level styles

* modified logic for isDisabled for array and object, added disabledWhenInvalid, exposed isValid to fieldState for text input, removed useDisableChildren

* added isValid for all field types

* fixed reset to default values

* debounce form values update

* minor change

* minor change

* fix crash - source data change multi-select to array, fix crash - change of options

* fix positioning

* detect date type in source data

* fix crash - when object is passed to regex input field

* fixed default sourceData path for fields

* accodion keep children mounted on collapse

* jest test for schemaParser

* widget/helper and useRegisterFieldInvalid test

* tests for property config helper and generatePanelPropertyConfig

* fix input field validation not appearing

* fix date field type detection

* rename data -> formData

* handle null/undefined field value change in sourceData

* added null/undefined as valid values for defaultValue text field

* auto detect email field

* set formData default value on initial load

* switch field inline positioning

* field margin fix for row direction

* select full width

* fiex date field default value - out of range

* fix any field type to array

* array default value logic change

* base cypress test changes

* initial json form render cy test

* key sanitization

* fix fieldState update logic

* required design, object/array background color, accordion changes, fix - add new custom field

* minor change

* cypress tests

* fix date formatted value, field state cypress test

* cypress - field properties test and fixes

* rename test file

* fix accessort change to blank value, cypress tests

* fix array field default value for modified accessor

* minor fix

* added animate loading

* fix empty state, add new custom field

* test data fix

* fix warnings

* fix timePrecision visibility

* button styling

* ported input v2

* fix jest tests

* fix cypress tests

* perf changes

* perf improvement

* added comments

* multiselect changes

* input field perf refactor

* array field, object field refactor performance

* checkbox field refactor

* refectored date, radio, select and switch

* fixes

* test fixes

* fixes

* minor fix

* rename field renderer

* remove tracked fieldRenderer field

* cypress test fixes

* cypress changes

* array default value fixes

* arrayfield passedDefaultValue

* auto enabled JS mode for few properties, reverted swith and date property controls

* cypress changes

* added widget sniping mode and fixed object passedDefaultValue

* multiselect v2

* select v2

* fix jest tests

* test fixes

* field limit

* rename field type dropdown texts

* field type changes fixes

* jest fixes

* loading state submit button

* default source data for new widget

* modify limit message

* multiseelct default value changes and cypress fix

* select default value

* keep default value intact on field type change

* TextTable cypress text fix

* review changes

* fixed footer changes

* collapse styles section by default

* fixed footer changes

* form modes

* custom field key rentention

* fixed footer fix in view mode

* non ascii characters

* fix meta merge in dataTreeWidget

* minor fixes

* rename useRegisterFieldInvalid.ts -> useRegisterFieldValidity.ts

* modified dependency injection into evaluated values

* refactored fixedfooter logic

* minor change

* accessor update

* minor change

* fixes

* QA fixes date field, scroll content

* fix phone number field, removed visiblity option from array item

* fix sourceData autocomplete

* reset logic

* fix multiselect reset

* form values hydration on widget drag

* code review changes

* reverted order of merge dataTreeWidget

* fixes

* added button titles, fixed hydration issue

* default value fixes

* upgraded react hook form, modified array-level/field-level default value logic

* fixed select validation

* added icon entity explorer, modified icon align control

* modify accessor validation for mongo db _id

* update email field regex

* review changes

* explicitly handle empty source data validation
2022-03-24 12:43:25 +05:30
Daniel
48685a850d
fix: blank screen in datasource view mode (#12145) 2022-03-23 18:00:38 +05:30
Ayangade Adeoluwa
5f93385f78
feat: Revamp deletion flow (#11774)
* Revamp deletion flow

* remove modal confirmation from cypress tests

* Fix tests, add functionality for other deletion flows

* Fix some more tests

* remove credentials

* fix cypress errors

* Fix more failing cypress tests

* Fix more failing tests

* Fixes failing jest case

* Fix failing tests, Use constant styling for treedropdown component

* Fix failing cypress tests

* Fix failing cypress tests

* Fixes failing Mongo spec test

* Fix datasource card merge conflicts

Co-authored-by: Adeoluwa Ayangade <adeoluwaayangade@Adeoluwas-MacBook-Pro.local>
2022-03-23 05:33:06 +00:00
Preet
9b5b835d82 fix passing props test 2022-03-23 10:04:11 +05:30
Preet
6d33570310 fix cypress tests 2022-03-22 22:22:26 +05:30
Preet
7016f3d439 fix cypress tests 2022-03-21 20:15:17 +05:30
Aishwarya-U-R
47fc1443f2
test: Script fixes for flaky tests + Unskipping few skipped tests + Cypress upgraded (#11724)
* AForceMigration started

* Table_GenralProp Background color failure fix

* Adding assertPageSave()

* Flaky fix

* Flake fix

* S3 - upload case uncomment

* Added click aft clear - Table_AddBtn spec

* Unskipping Promises scripts

* Promises fix

* Table_genral fix

* Separating Table_Color spec

* Failure fixes

* JObjtoInput flaky fix

* .wait to .Sleep

* Failure fix

* HSEditor complete replace fix

* small replace

* Update a user's name flaky fix

* EE_CopyQuery spec fix

* UNSkipping select widget test

* Flaky fixes

* viewportHeight updated

* Page Load spec - fixed & unskipping test

* Mongo cy.al failure fix

* Promises.any fix

* Promises.any fix

* List_Spec fix

* LIst_spec fix

* Promises.any fix

* Replay editor- flaky fix

* S3 flaky fix

* expandCollapse flaky click fix
2022-03-19 21:26:53 +05:30
arunvjn
94d9f233bd
fix: Show newly created datasources on the entity explorer (#11892) 2022-03-18 14:15:38 +05:30
Apeksha Bhosale
79e165af96
feat: Settings js editor (#9984)
* POC

* Closing channels

* WIP

* v1

* get working with JS editor

* autocomplete

* added comments

* try removing an import

* different way of import

* dependency map added to body

* triggers can be part of js editor functions hence

* removed unwanted lines

* new flow chnages

* Resolve conflicts

* small css changes for empty state

* Fix prettier

* Fixes

* flow changes part 2

* Mock web worker for testing

* Throw errors during evaluation

* Action execution should be non blocking on the main thread to evaluation of further actions

* WIP

* Fix build issue

* Fix warnings

* Rename

* Refactor and add tests for worker util

* Fix response flow post refactor

* added settings icon for js editor

* WIP

* WIP

* WIP

* Tests for promises

* settings for each function of js object added

* Error handling

* Error handing action validation

* Update test

* Passing callback data in the eval trigger flow

* log triggers to be executed

* WIP

* confirm before execution

* Remove debugging

* Fix backwards compatibility

* Avoid passing trigger meta around

* fix button loading

* handle error callbacks

* fix tests

* tests

* fix console error when checking for async

* Fix async function check

* Fix async function check again

* fix bad commit

* Add some comments

* added clientSideExecution flag for js functions

* css changes for settings icon

* unsued code removed

* on page load PART 1

* onPageLoad rest iof changes

* corrected async badge

* removed duplicate test cases

* added confirm modal for js functions

* removed unused code

* small chnage

* dependency was not getting created

* Fix confirmation modal

* unused code removed

* replaced new confirmsaga

* confirmaton box changes

* Fixing JSEditor Run butn locator

* corrected property

* dependency map was failing

* changed key for confirmation box

Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-17 17:35:17 +05:30
Arsalan Yaldram
6496f84374
fix: Added Button Container for the firefox drag issue (#11627)
* fix: Added Button Container for the firefox drag issue

* fix: Removed un-necessary styles, added Container in Canvas mode.

* fix: Removed renderMode check from styled function.

* fix: Code refactor and handled Icon Button Component.

* fix: Added extensive comments.

* fix: handled menu button drag issues.

* fix: Fixed some failing tests.

* New Button locator (with drag-container) fix

* NewBtn container locator fix

* btn locator fix

* MongoShopping spec fix

* Mongo, Postgress fixes

* Stat box fix

* Testcase title update

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-13 22:51:04 +05:30
Parthvi12
939e90626f
test: adding tests for smtp using test-event-driver (#11777)
Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-03-11 21:18:58 +05:30
albinAppsmith
5423944bbd
fix: Preserve entity explorer state on page refresh (#11064) 2022-03-11 21:17:42 +05:30
Aishwarya-U-R
fb0dc53a83
test: Script fixes for Flaky tests (#11653)
* Table_GeneralProp spec fix

* Flakes fixed

* Increased deployed page ele wait timeout

* readTabledataPublish() fix

* readTabledataPublish() updated

* Table specs flaky fix

* Table & Mongo Flaky fixes

* Mongo & Table spec flake fix

* Mongo flaky fix

* Mongo fix

* Table_Generalprop flaky fix

* Greencolor locator update

* expandCollapseEntity() method improved

* Table_generalProp flaky fix

* Datepick2, AddWidget flaky fix

* FLakyfix

* WidgetSelection_spec flaky fix

* Flaky fixes

* Adding GitSync to ignore files

* Removing GitSync from ignore files

* Added wait aft PublishApp
2022-03-09 12:05:56 +05:30
akash-codemonk
a6946fbcf0
fix: end guided tour on exiting editor (#11084) 2022-03-08 20:25:20 +05:30
Aishwarya-U-R
bd69eb9c3a
test: Automated tests for Bug #10784 + Failure fixes (#11586)
* Scripting Bug # 10784

* Bug 10784 - added script

* Uncommenting - JSObjToInput spec

* Uncommenting - JSObjtoListWidget spec

* SelectEntityByName reverted

* Migration spec locators fix

* Table_GeneralProp spec updated

* Read Table Row/Column locator updated

* Calling WaitAutoSave in JSObj creation

* 19px to 28px to match CI run

* CreateJSObject() - adding back wait time

* Reverting 28px to 19px

* Commenting table specs until CI fixed

* Commenting table spec 9th case

* UNcommenting

* Commenting Table_GeneralProp failure case
2022-03-05 01:01:35 +05:30
Vicky Bansal
43441bfce2
feat: add tooltip to column header text which overflows (#10666)
* feature: add tooltip to column header text which overflows (#10495)

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix: test issues

Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-03-04 00:56:16 -08:00
akash-codemonk
65aee7fd14
feat: Application templates (#10964) 2022-03-03 16:26:53 +05:30