Commit Graph

8054 Commits

Author SHA1 Message Date
Favour Ohanekwu
0f92b97226
feat: Triggerpath dependency (#15015)
* Introduce triggerpathdependency

* Code cleanup and refactor

* add jest test for removeLintErrorsFromEntityProperty

* Add triggerfieldDependencyMap jest tests for datatreeEvaluator

* Add cypress tests

* Revamp linting architecture

* Lint when creating first tree

* Prevent modification of unevaltree while linting

* improve linting performance

* Reuse allkeys for all dependencymap creation

* Add jest test for linttree

* Update jest and cypress tests

* Modify linting folder name

* remove redundant commits

* update evaluation jest tests

* Fix failing test

* Update cypress tests

* Code clean up and performance upgrade

* Update cypress tests

* Use unevalTree as global data for non-trigger field

* Improve global data creation time

* Cypress fixes

* Improve creation of global data for linting

* Only generate global data with functions when needed

* remove all unused variables

* Add overriden commit

* remove lint erros before linting

* fix merge conflicts

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 21:31:08 +01:00
dependabot[bot]
92fe556c40
chore: bump terser from 5.13.1 to 5.14.2 in /app/client (#15319)
Bumps [terser](https://github.com/terser/terser) from 5.13.1 to 5.14.2.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-22 15:04:47 +05:30
Bhavin K
f45a15545d
fix: depercate form button widget (#14510) 2022-07-22 08:27:37 +00:00
Rishabh Rathod
6ad308ec39
chore: Refactor dependency Map code (#14944) 2022-07-22 12:32:16 +05:30
Souma Ghosh
d45a6bfb97
fix: Compact property not functional for menu type in table widget v2 (#15302)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:45:48 +05:30
Souma Ghosh
27e91f8524
feat: Expose message event details for Iframe Widget (#14730)
* Expose message event details for Iframe Widget

* Change meta property name from messageEventProps to messageMetadata

* Cypress test for Iframe Message event details

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-22 10:42:57 +05:30
jaden
06e7d3cc63
CSS cant apply when constant WIDGET_PADDING=0 (#15227) 2022-07-21 18:34:10 +05:30
Favour Ohanekwu
243dc7f477
Improve lint error reporting (#15098)
Core changes in this PR

    Prevents logging of lint warnings (not errors) in the debugger
    Refined message for using 'await' in non-async functions
    Show lint error messages that include line numbers (previously weren't shown)

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-21 18:31:23 +05:30
Nidhi
833a6b05c4
fix: Modified available scopes for Google Sheets (#15169)
* fix: Modified available scopes for Google Sheets

* fix: Fixed locator reference

* Modified text for scope

* Fixed failing tests
2022-07-21 16:35:54 +05:30
Nayan
63370c1819
feat: Add API to get sample apps related to a template (#14942)
This PR adds query params to the get similar templates API.
2022-07-21 16:56:49 +06:00
Nidhi
50172ecd64
fix: Added support for self signed certificate during OAuth2 flows (#14719)
* Added support for self signed certificate during OAuth2 flows, server side changes

* fix: authentication.useSelfSignedCert key added

* Merging from release

* Fixed issue with dependencies, plus bug with using ssl

* Cypress test attempt 1

* Cypress test attempt 2

* Cypress test attempt 3

* Clean up

* Review comments

* Enabled compression again

Co-authored-by: Aman Agarwal <aman@appsmith.com>
2022-07-21 16:10:36 +05:30
Vishnu Gp
728728cac4
fix: App deploying when git push fails (#15255)
* Fix: Prevented publishing the app when git push fails
2022-07-21 10:29:22 +05:30
Hetu Nandu
48d2294f84
chore: typescript build error (#15262) 2022-07-21 09:30:02 +05:30
Sumit Kumar
fc65216782
fix: fix race condition on datasource creation (#14348)
* fix race condition on datasource creation for non-clustered setup
2022-07-20 23:31:50 +05:30
Ayush Pahwa
4217acbcc4
feat: prevent secrets to be pushed to repo (#15259)
## Description

Currently, our repository is prone to any dev pushing secrets to the repository by mistake. This can become a major problem very quickly and in the case of services like AWS, an alarm is raised and the key is deactivated causing apps using the key to break.

After this PR is merged, people will need to have [git secrets](https://github.com/awslabs/git-secrets) installed in their systems and have to register the AWS secrets to the repo.

The setup instructions have been mentioned [here](https://www.notion.so/appsmith/Getting-Started-e81ccc35463343b28e09c200cdbe5f42#c3183e8e6e404701920dd288b8506360)

Notes: 
1. right now, since we are using the pre-commit hooks using husky, the hooks work when we have done yarn install. 
2. Also, the scan only checks the directory we are in while making the change or raising the PR. This is because it uses `git ls-files` to get the list of files to scan.
3. If someone doesn't run `git-secrets --register-aws`, the tests will pass automatically since there is no regex registered with the system to scan against.

Fixes #15042

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-07-20 20:35:18 +05:30
Bhavin K
7ecca954c7
fix: changed the marker(default) value string to number (#15217) 2022-07-20 18:46:06 +05:30
Ankita Kinger
3933f5f4d1
feat: migrate from org to workspace under phase 3 (#14158)
* migration from organization to workspace on code level

* updated a few more files

* fixed runtime errors

* update org settings URL

* Renamed organizationId in domain objects

* changed field named from organization to workspace

* Reverted AppsmithRole changes

* fixed migrations

* recreating indexes

* migration update

* seed data runs before migration, undo changes

* mock commit

* seedmongo to populate upgraded data, datasource upgrade

* fixed two test cases

* updated migrations

* updated prop name

* Upgraded AclPermission

* comment

* migrated AppsmithRole

* more changes

* final set of changes

* variable name changes

* update cypress variable name

* Update app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/ce/ApplicationControllerCE.java

* Update app/server/appsmith-interfaces/src/main/java/com/appsmith/external/models/Datasource.java

Co-authored-by: Trisha Anand <trisha@appsmith.com>

* reverting encryption handler change

* refactor code to migrate from org to workspace

* migrated a few missed out org to workspace

* updated a few more

* migrated a few missed out org to workspace

* migration changes

* Removed Permission import

* reverted code change

* few more changes

* fixed failing cypress test

* fixed failing cypress test

Co-authored-by: Sidhant Goel <sidhant@appsmith.com>
Co-authored-by: Trisha Anand <trisha@appsmith.com>
Co-authored-by: Sidhant Goel <sidhant@hexcod.in>
2022-07-20 17:24:16 +05:30
Shrikant Sharat Kandula
5d166a46f1
fix: Block the call to clear Redis sessions (#15330) 2022-07-20 16:09:09 +05:30
Preet Sidhu
c03fddf1c9
fix: Improve CodeMirror rendering performance using idleCallback (#13676)
* working editor wrapper

* updated other property controls

* fix tablefilter_spec unit test

* autofocus on editor

* update font styles

* show lint errors

* add syntax highlighting

* fix import issue

* fix input height

* use lazy and suspense

* wip

* update code clean up

* update input style

* fix select widget issue

* fix build issue

* fix import issue and linting css

* update lint error method

* add polyfill for idle callback

* fix undo aggregate helper changes

* rename CodeEditor component

* fix tests add delay before code mirror

* undo name change

* rename lazy editor

* add comments and update aggregate helper

* fix cypress helper

* fix testJsonText command

* update aggregate helper

* add wait to allow time to load

* fix filepicker issue

* fix currency input test

* fix unit tests

* update aggregate helper

* fix table property tests

* fix test

* fix command

* update json text command

* updated command ii

* update iii

* update iv

* add force click

* check for wrapper

* fix for objects

* fix test iv

* fix test v

* fix tests vi

* fix tests vi

* fix variable naming issue

* fix tests vii

* remove wait from wrapper click

* fix tests viii

* fix recheck wrapper availability

* fix updateCodeInput command

* fix undo while loop

* fix ix

* fix each loop

* removed EnableAllCodeEditors

* updated tests

* Upated wait

* updated some more tests

* updated wait time

* updated common method

* updated all related common methods

* update state name and add callback timeout

* updated test

* updated the test

* fix use while loop and update count

* update click func

* fix use get instead of find

* fix on click action command

* remove comments

* fix: update import statements

* add force click to widget command

* update wrapper ui

* fix auto load code editor

* update editor wrapper ui

* fix lineheight adjustment

* refactor editor wrapper

* update style import

* fix ascetic style import

* fix font style

* fix wrapper height

* update color for code block

* fix min height of content wrapper

* remove error linting and editor wrapper

* remove unused variable

* remove unused imports

* fix font color for objects

* update styles for placeholders

* remove console log

* remove react syntax highlighter

* cancel idlecallback on unmount

* Delay input foucs

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: apple <nandan@thinkify.io>
Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-20 14:56:12 +05:30
Souma Ghosh
eddd1e8344
fix: Multiselect widget height decreases on selecting more options (#15228)
Fixes issue where multiselect height decreases on selecting more options
2022-07-20 14:26:37 +05:30
Bhavin K
8848d89650
fix: Added the loader in the Button group widget (#15246) 2022-07-20 14:21:54 +05:30
ashit-rath
cb40e04aa0
fix: JSONForm default array item not deletable when default value initialized with undefined (#15205) 2022-07-20 14:07:52 +05:30
Aman Agarwal
4890742168
fix: api auth fails displays error on view mode now (#14767) 2022-07-20 13:09:11 +05:30
Shrikant Sharat Kandula
e8be0936e6
Fix method name for Redis cleaning migration (#15322) 2022-07-20 12:48:55 +05:30
Rimil Dey
9284c5e240
Auto-indent JS code in the editor (#13222)
This pull request:

    introduces a new option to the menu in the JS editor which lets users prettify/auto-indent code.
    introduces a new keyboard shortcut that lets users prettify/auto-indent code
    Fixes bug where pressing CMD + <- in Mac (Home in windows) shifts the cursor to the first indented column. If the cursor is present on the first indented column, the cursor shifts to the 0th column in the editor

Fixes #9268
2022-07-20 12:43:23 +05:30
f0c1s
58dac0213c
Regenerate SSH key in connect and import flow (#14383)
As of today, we were supporting only ECDSA keys for GitHub, GitLab, and BitBucket. For Azure, RSA key generation was not available. This PR allows users to generate RSA or ECDSA keys.

As of now we support following key types and version control service providers:

    Github: ECDSA
    Gitlab: RSA, ECDSA
    Bitbucket: RSA, ECDSA
    Azure: RSA

Fixes #14382, #14715, #14570
2022-07-20 12:30:11 +05:30
Anagh Hegde
dbf0b94973
feat: Update the table widget to v2 in suggested widget list (#15277)
Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-20 12:28:50 +05:30
balajisoundar
71e581d69b
fix: cell background for edit actions column in Table v2 (#15233) 2022-07-20 11:42:59 +05:30
f0c1s
6eaabc3a7b
fix: reload default page on discard (#14964) 2022-07-20 11:40:06 +05:30
Bhavin K
23c449ac27
fix: error showing in currency input (#14958) 2022-07-20 06:06:33 +00:00
Hetu Nandu
5d568b7a6f
fix: Tooltip for long names in Entity Explorer (#15068) 2022-07-20 06:06:11 +00:00
Aswath K
8724f1c4fa
fix: Unwanted width calculation in Dropdown (#15239) 2022-07-20 06:05:44 +00:00
Aman Agarwal
10ca5b5033
fix: query creation via shortcut (#15281)
## Description

- Shortcut key-up and key-down were not working because the list of file operations on ui were filtered out of the `sectionTitle` but on key actions it was being referred to which was adding in the offset for the current active item.

Fixes #15264

## Type of change

- Bug fix (non-breaking change which fixes an issue)
2022-07-20 10:06:51 +05:30
Shrikant Sharat Kandula
39ad73228c
Log users out to fix serialization error from upgrading Spring (#15314) 2022-07-20 07:43:38 +05:30
Parthvi
04ec2c99d6
test: JSObject tests and flaky test fix (#15292)
* JSObject tests and flaky test fix

* fixing omnibarspec doc link
2022-07-19 17:11:27 +05:30
akash-codemonk
086ac89565
fix: query forms which require evaluation shows loading (#15272) 2022-07-19 12:16:07 +05:30
Shrikant Sharat Kandula
6f37a02653
Remove path concatenation in Algolia sync script 2022-07-19 12:01:09 +05:30
Shrikant Sharat Kandula
bba78afc3b
chore: Upgrade dependencies reported by Dependabot (#13735)
Upgrades vulnerable dependencies in all plugins except for MySQL. That one is still failing and I'll fix it in a separate PR. Issue #14475

Co-authored-by: Nayan <nayan@appsmith.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
2022-07-19 10:23:27 +05:30
f0c1s
df4fca9b8f
fix: show conflict info properly (#15240)
## Description

ConflictInfo was showing up along side discard button. Moved it to a row of its own.

Fixes #15113 

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-18 11:03:21 +05:30
f0c1s
654ae38e67
fix: break branch creation text, fix text casing (#15241)
## Description

During branch creation, a bit of text was clinging to each other. Put them as per the design.

Fixes #15014 

### Issue:

![image](https://user-images.githubusercontent.com/1573771/179294901-7820fe79-4f35-47fd-9f63-98a886f102b5.png)

### design:

![Screenshot 2022-07-16 at 12 40 39 AM](https://user-images.githubusercontent.com/1573771/179295031-bbb5ef67-8955-4901-997a-1f455bdf5bb0.png)

### fix:


https://user-images.githubusercontent.com/1573771/179295053-d5940ba7-2a9f-41a9-965d-596bff69ac71.mov

![Screenshot 2022-07-16 at 12 36 52 AM](https://user-images.githubusercontent.com/1573771/179295067-c82d3905-f325-47ed-9007-06b0c7104e86.png)


## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-18 11:02:54 +05:30
Anand Srinivasan
53641d9c68
feat: filter error messages from hidden widgets (#14738)
* initial filter

* hide modal errors

* handle tabs and modal

* remove console logs

* clean up

* comment

* add comments

* handle nested tab

* unit tests

* update test

* uncomment

* show errors in isVisible bindings

* show all errors when widget has faulty binding for isVisible

* handle isVisible faults inside containers
2022-07-18 08:55:32 +05:30
Ayush Pahwa
886359b0a3
fix: UI alignment for key value arrays (#15235)
fix: added required padding for form label div
2022-07-16 17:20:58 +05:30
Aishwarya-U-R
68108d7827
Automated tests for Postgres Datatype - Binary type + Flaky fixes (#15210) 2022-07-16 16:11:17 +05:30
Rishabh Rathod
bd571ffeb8
fix: JSObject AST parsing logic (#14962)
fix AST logic
2022-07-16 16:06:53 +05:30
Arsalan Yaldram
56063ab23d
feat: update dependencies (bot-alerts) (#15124)
* chore(deps): bump async from 2.6.3 to 2.6.4 in /app/client

Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore: bump moment from 2.29.3 to 2.29.4 in /app/client

Bumps [moment](https://github.com/moment/moment) from 2.29.3 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.29.3...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* feat: updated rts folder packages

* feat: remove node-sass

* fix: use marked 3.0.8 instead of marked 4

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-15 17:07:56 +05:30
rahulramesha
b878d5bd01
fix: Update maincanvas height on widget resize, drag or delete operation (#14992)
* fix extra space on canvas

* reverting selector changes

* use updated main canvas minheight

* use default canvas minHeight
2022-07-15 15:57:13 +05:30
Satish Gandham
c9a7587dcf
ci: Fix golden app tests and more (#15172)
* - Save the DOM on test failures.
- Handle promise rejection in tests.
- Save console logs to a file instead of stdout

* - Fix golden app tests
- Upgrade widgets in golden app to latest version

* - Removing logging to file temporarily
- Add test index to the file names

* Some final cleanup

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-15 14:40:45 +05:30
Ayush Pahwa
458715f0ac
fix: added default value for switch view type (#15215) 2022-07-15 09:15:08 +02:00
Parthvi
af2e55ef31
test: Add tests for bugs and fix flaky cypress tests (#15115)
* Fix flaky tests 

* fix discardChanges_Spec

* comment the intercept in merge method

* add test for bug#15175

* add test for bug

* fix git tests
2022-07-15 11:36:58 +05:30
Souma Ghosh
d40a8fd9f2
fix: Compact property not functional for menu widget (#15090)
Fix compact property functionality for menu widget and menu type in table widget
2022-07-14 17:11:03 +05:30
akash-codemonk
c76c052d36
fix: remove the image binding step in guided tour (#15161) 2022-07-14 16:21:24 +05:30
subratadeypappu
41c3446f5b
fix: Enable parsing dates before Jan 1, 1970 in MongoDB (#15105)
* fix: Enable parsing dates before Jan 1, 1970 in MongoDB

This commit takes care of three things
1. It enables the application to parse dates before Jan 1, 1970 in case of MongoDB
2. JUnit test
3. Cypress test

* fix: Enable parsing dates before Jan 1, 1970 in MongoDB

This commit takes care of three things
1. It enables the application to parse dates before Jan 1, 1970 in case of MongoDB
2. JUnit test
3. Cypress test

Co-authored-by: Nidhi <nidhi.nair93@gmail.com>
2022-07-14 15:45:34 +05:30
Shrikant Sharat Kandula
bc71311c8c
GitBook's API is sending id instead of uid now 2022-07-14 12:36:52 +05:30
arunvjn
c331f8c330
fix: change edit/launch buttons to anchor tags in applications dashboard (#15168) 2022-07-14 12:34:19 +05:30
balajisoundar
a97ab3d9a2
feat: Table widget v2 with support for non-ASCII characters and improved jest coverage (#11307) 2022-07-14 12:32:35 +05:30
Aswath K
3824435f7d
chore: Adds analytics for Property Pane keyboard navigation (#13703)
* Adds analytics for DropdownControl

* Add isUpdatedViaKeyboard to WIDGET_PROPERTY_UPDATE

* fix: jest test for iconselectorcontrol

* refactor: Interaction analytics event dispatching moved to a hook

* refactor: event collection logic to HOC

* Analytics for SwitchControl

* Analytics for CodeEditor

* Analytics for InputTextControl

* Analytics for ColorPicker

* fix issue with ColorPicker

* refactor to re-use ref

* rename the hook to ts

* Analytics for StepControl

* Analytics for ButtonTabComponent

* Analytics for NumericInputControl

* Analytics for IconSelector

* fix: failed test

* Analytics for ActionSelector

* fix: failed jest test

* fix: jest test for StepControl

* Analytics for Option Control

* Analytics for LocationSearchControl

* Adds Analytics for Tab key

* analytics for Property pane connections

* Add analytics for widget name

* Adds analytics for copy & delete button

* fix issue with widget name analytics

* add useCallback for tab keydown handler for button

* Create separate Event handling for design system

* removes unused imports

* changes ADS_EVENT to DS_EVENT

* Changes AdsEventTypes to DSEventTypes

* Changes AdsEventDetail to DSEventDetail

* changes occurences of Ads to DS

* avoids creation of intermediate function

* removes trace of 'analytics' from DS components

* rename dispatchDSEvent to emitDSEvent

* fix: Cypress selector
2022-07-14 10:30:30 +05:30
Aishwarya-U-R
d727d66c17
test: Automated tests for Postgres Datatype - Array type (#15164)
* Postgres Array DT scripted

* Array spec updates

* Arrayspec fix
2022-07-14 08:33:48 +05:30
Anand Srinivasan
59f91b618c
fix: curl import error (#15178)
* send only pageId on curl import creation

* remove variables

* fix data source redirect
2022-07-13 19:24:05 +05:30
Nidhi
02a5e1d490
fix: Added dropdown to select whether to send credentials in header or body in client credentials flow (#14545)
* Added dropdown to select isAuthorizationHeader in client credentials flow

* Added tests

* Added cypress test

* Oopsie
2022-07-13 14:33:19 +05:30
Arsalan Yaldram
8428ae506a
fix: using old versions of marked (#15151) 2022-07-13 13:04:23 +05:30
Pawan Kumar
0a78aa4aed
fix: Not able to right click on app home button in view mode (#15085)
replace button with link
2022-07-13 12:26:59 +05:30
Nayan
bac6162921
feat: Add new field for the page meta data in templates (#14784)
In order to import a specific page or browse to that page, the templates FE need page names and page ids. This PR replaces the list of page names with a list of objects that contains the page names and page ids.
2022-07-13 00:07:18 +06:00
rahulramesha
4dc3ed481c
fix: modal and App viewer header overlap (#15093)
* modal positions calculations on App View mode

* using css variables to compute modal offsets
2022-07-12 21:13:26 +05:30
Ayangade Adeoluwa
2bcc630435
fix: Fix wrong tooltip styling to form controls with no tooltips (#15055)
* Fix wrong tooltip styling to form controls with no tooltips

* Cypress tests for issue

* Resolve typescript error

* Empty-Commit
2022-07-12 14:55:16 +01:00
Ankita Kinger
3f1ae5b417
chore: add back button on individual authentication config pages (#15138)
added back button on authentication config pages
2022-07-12 19:01:11 +05:30
Aswath K
d61a91af8d
fix: initial selected value not getting displayed (#15000) 2022-07-12 12:46:15 +00:00
Tolulope Adetula
d9d1c0c676
fix: dropdown not closing is fixed (#15058)
* fix: Dropdown issues

* CR fix

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-07-12 17:20:09 +05:30
Satish Gandham
e2db190ed2
ci: Stabilise the host before running perf tests (#15130)
* Run perf tests only on buildjet machine

* - Set chrome process priority to maximum to stabilise the run data

* Update index.js

* Update perf.js

* Update index.js

* - Move around args

* - Add --no-sandbox option to initial setup

* -We don't need sudo on the main script, we can use sudo in node scripts to set process priority

* - Some tweaks to the perf scripts.

* - Remove no-sandbox option in puppeteer launch

* - Remove sudo at unnecessary places

* - Add code to force grabage collection in chrome

* Update logins and some cleanup

* Remove unsed import

Co-authored-by: Satish Gandham <satish@appsmith.com>
2022-07-11 21:22:25 +05:30
Hetu Nandu
71a82b4670
feat: Add the Zipy identify call (#15060) 2022-07-11 15:48:24 +05:30
f0c1s
18a8937c5d
fix: accept non-empty commit messages (#15053) 2022-07-11 15:41:33 +05:30
f0c1s
7c77d3fb7c
chore: update messaging for Deploy tab (#14911)
* chore: update messaging for the Deploy tab
2022-07-11 15:40:43 +05:30
akash-codemonk
9fc8e9a216
fix: query param seperator in signup url (#15074) 2022-07-11 14:33:37 +05:30
Arsalan Yaldram
7919400035
fix: remove collapse animation from propertypane. (#15017) 2022-07-11 11:11:15 +05:30
albinAppsmith
3d22d935d3
feat: Design System - Text component migration (#14994)
Removed Text component
Changed imports to design system
2022-07-11 10:25:28 +05:30
arunvjn
fd6faf85ea
chore: code changes to support clean urls v2 (#14757) 2022-07-11 09:36:29 +05:30
NandanAnantharamu
2b1823217e
test: Added test for a bug (#14904)
* Added test for a bug

* Added the widget details
2022-07-10 18:20:22 +00:00
ChandanBalajiBP
a99176fae9
fix: Outdated design for Rest API Editor (#13812)
* Outdated design for Queries/JS/API Editor

* updated cypress test cases and colors reference

* updated cypress test cases with add and delete datasource

* added indexing for testcases

Co-authored-by: Chandan Balaji <chandanbalaji@Chandans-MacBook-Pro.local>
2022-07-08 20:01:12 +05:30
Arsalan Yaldram
7c220affd5
fix: selectwidgets clear search input on selection (#14609)
* fix: clear search input on selection

* fix: added comments in single select test case.

* fix: single select tree widget clear search on close

* fix: test cases for mult-select-spec

* fix: clear the filterText on select widget close

* fix: added resetOnClose to select component

* fix: resetOnClose only when serverSideFiltering is off
2022-07-08 18:57:13 +05:30
Ayangade Adeoluwa
57dba485ce
fix: fixes google sheets datasource global search error (#15020)
* fixes google sheets datasource global search error

* Adds cypress test

* Fix cypress test

* Fixes navigating to google sheets queries from global search issue
2022-07-08 18:27:59 +05:30
Parthvi
1f7b923ad9
test: Automate JSObject app in cypress and fix few flaky tests (#14613)
* add tests for promises

* update dsl

* fix deleteBranch_spec

* fix ImportExportForkApplication_spec

* update test

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-08 16:18:20 +05:30
Aman Agarwal
8800277642
fix: added handling for array of objects containing blob urls for multiple file uploads (#15027) 2022-07-08 14:59:18 +05:30
Keyur Paralkar
170dc193ad
fix: reset selectedFiles meta prop only on specific reason event (#15023)
* fix:
* removed the componentWillUnmount to avoid uppy reset
* added cypress test case

* fix:
* added componentWillUnmount again
* added reason argument to the file-remove handler
2022-07-08 13:32:54 +05:30
Anagh Hegde
317f340421
feat: fetch branch speific refs from the remote repo (#15067)
* fetch branch specific refs from the remote repo
2022-07-08 11:29:16 +05:30
Aman Agarwal
2efcdf0b09
fix: switch datasource option list contains similar ds (#14959)
* fix: switch datasource option list contains similar ds

* fix: test case for switching datasource

* fix: updated the numbering of test case, deleted the postgres ds
2022-07-08 11:16:04 +05:30
Sangeeth Sivan
cba68293a0
feat: align tab counts with center to the tab name and added test id attribute for tab count (#14980)
* feat: added testId for tab count and aligned it center w.r.t tab name

* revert spacing
2022-07-08 11:00:22 +05:30
Arsalan Yaldram
c8c8051dbf
feat: dependent-bot dependencies updates (#14970)
* chore(deps): bump tmpl from 1.0.4 to 1.0.5 in /app/client

Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases)
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5)

---
updated-dependencies:
- dependency-name: tmpl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump path-parse from 1.0.6 to 1.0.7 in /app/client

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): bump marked from 2.0.0 to 4.0.10 in /app/client

Bumps [marked](https://github.com/markedjs/marked) from 2.0.0 to 4.0.10.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](https://github.com/markedjs/marked/compare/v2.0.0...v4.0.10)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): bump async from 2.6.3 to 2.6.4 in /app/client

Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: updated marked types and imports

* fix: added marked as commonjs import

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-08 00:20:19 +05:30
Arsalan Yaldram
d136467d7c
fix: reset line height and font weight for tab titles (#15011)
* fix: reset line height and font weight for tab titles
2022-07-07 22:52:36 +05:30
Rishabh Rathod
0c07a871ad
fix: JS function arguments determination & refactor JSObject code (#14871)
* fix: JsObject parsing

* fix jest test and add types

* remove logs from test

* Add jest test to verify this

* Add perf metric and

* fix: jsObject stale value
- refactor updateJSCollectionInDataTree

* Refactor JSObject code

* fix import path

* refactor and fix

* undo debugging change

* Add comments

* Add Ast for getting function params

* Fix and add test

* remove comment

* remove comment

* Resolve comments
2022-07-07 15:00:35 +05:30
Arsalan Yaldram
f9cae32631
fix: webpack hot reload issue (#15070)
fix: hot reload issue
2022-07-07 14:00:57 +05:30
Pawan Kumar
e4f5899f9e
fix: Transparent bg on app viewer header in comment mode (#15048)
fix app viewher header bg bug
2022-07-07 13:45:40 +05:30
Anagh Hegde
883d9d801e
chore: Refactor git api to include application id as request param instead of the path variable (#14800)
* Refactor git API's to add `/app` to the API path to identify the appId

* Update the url in cypress tests

* Update the path in git spec cypress files

* Update the url for connection spec
2022-07-07 12:35:03 +05:30
Arsalan Yaldram
4a9a05e88c
fix: currencyInput , phoneInput show empty pop when no search result is found. (#14764) 2022-07-07 11:28:19 +05:30
Shrikant Sharat Kandula
30236469a9
Fix saving values with special chars in env file (#14873)
Fix how special chars in env values are saved

Also included some refactoring to fix several compile time warnings and lint errors,
including proper formatting.

Signed-off-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2022-07-07 11:27:16 +05:30
Arsalan Yaldram
19a6430f24
fix: resizer pushed into the propertypane (#14868) 2022-07-07 11:26:48 +05:30
Preet Sidhu
8600201694
fix: App crash on binding large base64 data to text widget (#14782)
* add validation for excessive text length

* add max length as a param

* update max length to 20k
2022-07-07 05:38:24 +00:00
arunvjn
bed2a02fdd
fix: remove unnecessary re-renders on JS Object context menu in explorer (#14866)
* Fixes rerenders on JS context menu

* Fixed warnings

* Fix review comments

* Perf adjustments

* Replace entityName hook with a function that reads from store.

* Use menuOptions selectors to populate options
2022-07-07 05:38:05 +00:00
Bhavin K
1ca40f9eeb
fix: show the error message for text input widget (#14934)
* fix: show the error message for text input widget

* Update the error message & added releated new test case
2022-07-07 05:37:54 +00:00
Aswath K
ef2e3b370e
fix: JS toggle issue with Numeric Input & multi select dropdown controls (#14892)
* fix: JS toggle issue for NumericInputControl

* fix: DropdownControl's JS toggle for multi select
2022-07-07 05:37:50 +00:00
Ayangade Adeoluwa
c01942abf3
fix: Prevent non populated labels from showing up in datasource page (#14979)
* Prevent non populated labels from showing up in datasource page

* Add cypress test
2022-07-07 05:37:32 +00:00
Aishwarya-U-R
a5ff06ad7e
test: Script fixes for failing cases due to UQI css changes (#15037)
* flaky fixes

* Eval value pop up hinder fix

* JS delete from EE fix

* ActionContextMenuByEntityName() fix

* Adding Escape()

* Toasts handling
2022-07-06 20:52:24 +05:30
Nidhi
c5253fc300
fix: Handled migration of empty condition objects, or missing operators (#15038) 2022-07-06 12:37:58 +05:30
Ayush Pahwa
70552794e7
fix: UQI UI alignment fixes (#15035)
* Update: fixed width of components as static

- Changes are made in lieu of the design system changes

* Update: fixed the gaps between components

- Updated where clause padding for delete button
- Updated entity selector gaps

* Update: placeholder texts for where clause
2022-07-06 12:10:25 +05:30
Aishwarya-U-R
10fe3e3acf
Automated tests for Postgres Datatype - JSON type (#14796) 2022-07-06 11:24:00 +05:30
Nidhi
3c9543ad93
fix: Modified Google Sheets pagination tooltip to nudge towards binding data (#15016) 2022-07-05 15:21:55 +05:30
Nidhi
ff58dad704
fix: Switched Google Sheets JSON to local directory (#14971)
* fix: Switched Google Sheets JSON to local directory

* fix: Fixed placeholder text for insert row object

* fix: Enabled server side caching of plugin resources again
2022-07-04 22:02:54 +05:30
Aswath K
0fe03fa066
fix: Disabled state UI for JS toggle button (#14975) 2022-07-04 14:59:20 +02:00
Bhavin K
cc36ae70bb
fix: revert checkbox-group widget breaking UI issue (#14933)
Revert "fix: checkbox-group widget breaking UI issue (#14820)"

This reverts commit 6686b94280.
2022-07-04 14:33:31 +05:30
f0c1s
f4db8926f5
fix: pass remote url to ConflictInfo component (#14963)
## Description

During a refatoring, one of the location where the ConflictInfo component is invoked from was getting an empty string; that was making current app open up in new tab instead of git repo.

Fixes #14674 

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-04 11:23:52 +05:30
Nidhi
906a7298dc
feat: Simplified Google Sheets queries (#14869)
* Client changes 1

* add DSL functionality

* Temp commit for refactoring changes

* Do I even know what I'm doing here?

* chore: Second GS layout

* Update: Visibility conditional outputs for schemas

- Added the output from conditional outputs for schema children too

* Update: Entity selector visibility control

- Added logic for controlling visibility of sub components via the JS expressions system

* Update: Passing disabled prop to toggle button

* Update: Passing disabled prop to toggle btn

* Update: Styled component for toggle button

- Added disabled styles based on the disabled prop sent to the toggle form view JSON button

* Update: configProperty role in Entity Selector

- Removed dependance of the configProperty of the entity selector children to it's parent component

* Update: type of placeholder key

- Made placeholder key from form config JSON to accept either string or an object
- Earlier only string was accepted
- This is for pagination component

* Update: Added placeholder control for pagination

* Client changes 1

* add DSL functionality

* Do I even know what I'm doing here?

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design

* fix: updated tooltip component for wrong ui on entity explore

* temp triggers

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design (#12395)

* fix: updated uqi forms ui, clubbed JS switch button to ads, updated tooltip design

* fix: updated tooltip component for wrong ui on entity explore

* fix: updated tooltip ui, where condition placement, sort by ui

* temp form data access logic

* fix: updated sorting type width ui

* fix: updated ui for spacing, width and text issues

* Update: Type for tooltip of UQI forms

- Added option to send an object to the tooltipText object.
- This allows for composite components like pagination to have tooltips for each sub component

* Update: tooltip for pagination component

- Added handling to parse the tooltip for multiple components.
- This allows for composite components like pagination to have tooltips for each sub component

* Update: Type cast for tooltip component

- Made the content passed to tooltip component as a string only

* Update: Fixed tooltip component CSS

* Update: Dropdown option component

- Added a tooltip wrapper to each option
- This is to show on hover text like disabled state

* fix: updated ẇhere clause broken ui for condition

* Add: functions to check and extract expressions

- Loop through the formConfig and find any keys that have a value that is bindable
- Used pre defined regex to check if value is a moustache binding

* Add: Types for evaluated form configs

- Added types for the form configs to be evaluated and their output post eval

* Add: Flow to run the form config

- Run the form config and update the result to the redux state

* Update: Name of the type for formconfigs

- Updated since it was clashing with a component of the same name

* Add: Function to enforce config type checks

- This is done so that the improper configs can be weeded out and the rest of the form can be shown

* Add: Function to update evaluated config

- Added option to update the config if it's values needed evaluation

* Add: Type check for schema sections

* Update: Error handling for invalid control type

- We were throwing an exception till now, changed it to a warning text

* Add: Exposed tooltip for dropdown option disabled state

* Update: switch to json mode functionality

- Added logic to convert data to a string rather than an object when the first switch to JSON mode happens

* Update: Added key to tooltip for dropdown options

* Trigger API modification

* Add: function to fetch default trigger URL

* Update: Made URL optional in dynamic trigger config

* Update: Dynamic trigger API call

- Made the API call for dynamic triggers have URL as optional field
- Added type check to the response of the API call

* Update: resp type for trigger APIs

* Update: Moved code to utils folder

- Moved functions for UQI form eval processing to utils file

* Update: passing original controltype to JS switch

* Update: config for JSON editor mode

- Updated the config to have different options for JSON mode depending on the original control type

* Update: Connected line numbers flag to config

* Revert: CSS changes for tooltip

* Refactor: Removed consle

* Add: type for the config of dynamic values

* Add: Feature to evaluate config for triggers

* Refactor: fix type check errors

* fix: dropdown ui width with text alignment

* Update: fixed selector for dynamic values

* Update: selector call for fetchDynamicValues

* Add table header index prop for columns selector

* migration partial commit

* migration partial commit

* Refactor: removed unused import

* Update: reused function for checking dynamic value

* Update: removed unused import

* Fix format JSON issues

* Retrieve binding paths from entity selector components

* Fixes 6 remaining issues with UQI implementation

* Fix dropdown issues

* Fix dropdown height issues and fixes triggering of APIs when option is deselected

* Migration changes

* Fix QA generated UQI issues

* Fix projection component height and route change logic

* Fix multi select dropdown placeholder text issue and json stringify issue with switching view types

* Reset entity type value when command value changes

* Test changes

* Review comments

* Moved migrations around

* Corrected import statement

* Added JSON schema migration

* Updated schema version

* perf improvements and filter dropdown options feature

* Fix Code mirror component config for toggleComponentToJson input fields.

* Fix prettier issues

* fix prettier issues

* Fix style issues as a result of the merged conflicts

* Fix failing test case

* Fixed a few other flows (#14225)

* Fixed a few other flows

* Review comments

* Fix generate CRUD, fix evaluation of dynamic bindings and fix various styling issues.

* More fixes (#14367)

* Factor in the root formconfig parent key.

* Fix flickering issues, and evaluatedFormConfig issues

* fix: Teeny bugs (#14455)

* Teeny bugs

* Added previous functionality as is

* Improvements in the way we fetch dynamic values

* Fix stringiification issue and cyclic dependency issues

* Resolve projection component values deletion

* Resolve merge conflicts and fix prettier issues

* fix: Tsc issues

* Fix property pane connection navigation

* updating ee locator

* updating inputfield locator

* dropdown locator update

* Merge conflict not properly resolved.

* Fix s3 spec

* Fix Mongo Spec

* Fix some more tests

* fix: prevent cyclic dependency when switching to js mode (#14668)

* add delete events for change from array to string in diff

* add test to assert absence of cyclic dependency error when switching to js in switchgroup widget

* Assert that evaluation is not disabled when no cyclic dependency happens

* Cypress test preparations for google sheets and form controls

* Fixed a few test errors (#14874)

* Add: unit tests for uqi UI updates

- view type tests
- conditional output extraction
- processing conditional output to handle view/enabled state of the component

* Add: completed isValidFormConfig test

* Update: improved tests for update config

- These tests cover the functionality to update a section config after it's components are done evaluating

* Fix failing cypress tests and cyclic dependency issue

* Fixes some more tests

* Fixed migration of row objects (#14896)

* Bumped the version of design system package

* Update: reverted change to EE selector

* Fix deletion pointer

* Update: selector for js on load spec

- Synced with changes related to ADS dropdown

* Fix mongoDBShoppingCart spec

* Remove comments

* Fix: mongo shopping cart test failures

* fix: mongo shopping cart spec

* Dummy push to retrigger vercel

* fix: mongo shopping cart spec

* Update MongoDBShoppingCart_spec.js

* fix: removed unused click away

* dummy commit

* Update: moved helper functions to separate file

* Add: added tests for saga functions

- Worked on testing for
   - extractFetchDynamicValueFormConfigs
   - extractQueueOfValuesToBeFetched

* Add if check for queueOfValuesToBeFetched

* Resolve review comments

* Empty-Commit

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayush Pahwa <ayush@appsmith.com>
Co-authored-by: Aman Agarwal <aman@appsmith.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com>
Co-authored-by: Albin <albin@appsmith.com>
2022-07-04 11:13:27 +05:30
f0c1s
06ed917f8e
chore: code cleanup - remove extra break (#14672)
## Description

There are some instances of unreachable code, this PR fixes them. And some typos.
## Type of change

- Code Quality Improvement and code cleanup

## Checklist:

- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
2022-07-04 09:25:40 +05:30
f0c1s
f7ce6d6dcb
Throttle git status api (#14619)
Throttling git status API eases burden on server.
2022-07-04 09:25:27 +05:30
Rishabh Rathod
8e47219d05
fix: remove debounce from RTE component (#14126)
* fix: remove debounce from RTE component

* fix value change on prop

* Add comment for useEffect order understanding

* fix:
* default text update
* Text re-appearing once deleted

* fix: cursor jump issue

* test: added cypress tests for RTE widget

* fix: isDirty value not updating properly

* chore: added comment for the new useEffect

* fix:
* Changed the logic to include a state inside RTE component
* Added cypress tests

* fix: updating ref on on keystroke events

* fix: suppressed props.onValueChange call on change of default text

* refactor: addressed review comments

* test: fixed failing cypress test

* fix: renamed styles related to label
* added a test case for checking cursor position when in markdown

* test: refacotored test case

Co-authored-by: keyurparalkar <keyur@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-04 08:31:16 +05:30
Pawan Kumar
396922e260
fix: Updates border radius and box shadow labels in widgets (#14948)
## Description

Updates the border radius and box shadow labels in widgets

Fixes #13992

## Type of change

- Bug fix

## How Has This Been Tested?
- Manually tested

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
2022-07-01 16:53:34 +05:30
Pawan Kumar
545540723c
fix: Update the default themes in app theming (#14576)
* add new themes

* update default themes

* fix cypress tests

* comment theme test in backend

* updated tests for theming changes

* fix font name in sun rise theme

* update border radius/box shadow labels

* update snapshots + fix cypress tests

* fix cypress tests

* fix cypress tests

* trying fixing snapshot bugs

* trying fixing snapshot bugs

Co-authored-by: Nayan <nayan@appsmith.com>
2022-07-01 11:26:16 +05:30
Nayan
1cf3e0983d
fix: Increase file size limit for templates (#14855)
Forking a template was failing due to file size limit. This PR increases the file size limit to 4 MB.
2022-07-01 11:53:20 +06:00
Favour Ohanekwu
11f8684e7f
fix: prevent temporary update of sub-path value in store object (#14847)
* support paths as keys in storevalue

* add cypresstests

* StoreValue added deploy mode verification

* Adding array input [boolean, string, number]

* store number too

* Added bug id to title

* Added dot object array & SelectJSFunctionToExecute

* propPane.UpdateFieldValue() update

* updated UpdatePropertyFieldValue

* JS toasts handling

* JSOnload spec fix

* JsOnload toast appearances fix

* support paths as keys in storevalue

* add cypresstests

* StoreValue added deploy mode verification

* Adding array input [boolean, string, number]

* store number too

* Added bug id to title

* Added dot object array & SelectJSFunctionToExecute

* propPane.UpdateFieldValue() update

* updated UpdatePropertyFieldValue

* JS toasts handling

* JSOnload spec fix

* JsOnload toast appearances fix

* prevent modification of storeValue path in temporary store

* Add cypress tests for case where storeValue key is a path

* remove redundant import of lodash

* Modify cypress tests

* update cypress tests

* Store fix revert

* revert

* Actions revert

* revert redundant change

* removed additional button- from script

* JsOnPage load script fix

* validate toast fixes

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-07-01 06:26:57 +01:00
Parthvi12
cc3b10c9a6
test: Add visual tests for datasource page (#14811)
* add layout tests for datasource

* fix omnibar_spec

* add tests for postgres and mong

* fix git import test

* fix test

* comment test until issue is fixed

Co-authored-by: Parthvi Goswami <parthvigoswami@Parthvis-MacBook-Pro.local>
2022-07-01 09:01:02 +05:30
dependabot[bot]
5e0677bc5d
chore: bump mysql-connector-java from 8.0.20 to 8.0.28 in /app/server/appsmith-plugins/mysqlPlugin (#14696)
chore(deps-dev): bump mysql-connector-java

Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 8.0.20 to 8.0.28.
- [Release notes](https://github.com/mysql/mysql-connector-j/releases)
- [Changelog](https://github.com/mysql/mysql-connector-j/blob/release/8.0/CHANGES)
- [Commits](https://github.com/mysql/mysql-connector-j/compare/8.0.20...8.0.28)

---
updated-dependencies:
- dependency-name: mysql:mysql-connector-java
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-01 00:41:23 +05:30
Arsalan Yaldram
1c774c2482
feat: upgrade client npm packages. (#14858) 2022-06-30 16:59:09 +05:30
Pawan Kumar
2ab2ec1bcb
fix: No way to go back to appsmith applications from the app viewer mode navigation (#14604)
* add gap in mobile header

* fix alignment issue

* add apps text

* fix ui

* fix ui issues in mobile

* add cypress test

* change icon + add hover state

* fix dropdown position + icon color

* update snapshots

* code review feedback

* equality typo
2022-06-30 15:52:49 +05:30
Pawan Kumar
d60ea07e65
The reset button on properties behaves incorrect for JSONForm fields and Table primary columns (#14768)
Reset value in primary columns in table widget and fields in JSONFOrm was not working as expected. This commit fixes that.
2022-06-30 15:52:20 +05:30
Favour Ohanekwu
41789c71bc
fix: show js function execution errors in debugger (#14555)
* Show js function execution error logs

* remove unused function

* improve check for async functions

* clear errors for deleted jsActions

* fix typescript error

* modify js function execution error logging

* test that execution parse errors are logged in the debugger

* Add test to show that js execution errors are logged in the debugger

* re-order js execution tests

* Add type to jsObj variable

* update cypress tests

* update cypress test
2022-06-30 08:21:20 +01:00
Bhavin K
6686b94280
fix: checkbox-group widget breaking UI issue (#14820)
- Hides Style alignment when Inline option is false which fixes UI overlapping issues
- Resizing the widget other options which are outside don't come within the widget boundaries - Fixed
- Behaviour of widget when placed at top of the canvas - Fixed
2022-06-30 11:12:45 +05:30
Aman Agarwal
63e2240eed
fix: made blinking cursor transparent for switch datasource (#14899) 2022-06-30 10:28:17 +05:30
Aswath K
f895f7bf14
CENTER as default value for vertical alignment (#14888)
Set "CENTER" as default value for Vertical Alignment property instead of invalid value "LEFT"
2022-06-30 09:49:52 +05:30
f0c1s
a3cd34e9f6
fix: Adding deploy button on git deploy tab (#14597) 2022-06-29 18:03:53 +05:30
akash-codemonk
306b02ec6f
fix: signposting task page is shown when clicking on a page in the explorer (#14799) 2022-06-29 17:47:52 +05:30
Rishabh Rathod
8bfc3ee87e
fix: store value spec as JsObject bug is resolved (#14788)
* fix: store value spec as JsObject bug is resolved

* fix test

* Use GetNClick

* StoreVal trial fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-29 17:47:14 +05:30
ChandanBalajiBP
be626a132e
Merge pull request #14103 from appsmithorg/Fix/Mismatch-with-design-in-Sample-Datasource-Card
fix: UI inconsistencies in Datasource card and page
2022-06-29 17:32:43 +05:30
rahulramesha
f90ce07143
fix: Multi widget selection fixes (#14388)
* rewrite logic for widget multiselect box position and dimension

* logic to select only the widgets on the same canvas while dragging to select them

* fix jest test case
2022-06-29 11:55:26 +00:00
rahulramesha
9516c9a6db
modal widget on paste fixes (#14627) 2022-06-29 11:55:07 +00:00
Bhavin K
a2dd01806c
fix: remove the duplicate and rename the actions to events in property panel (#14714)
* Fix: Remove the duplicate & rename the "Actions" To "Events"

* rename the "Actions" to "Events" in select & multiselct widget

* Trigger Build

* fix: failed testcase are resolved
2022-06-29 11:54:50 +00:00
Rimil Dey
20eabaf67c
Revert "feat: Add a field for the post message api exposure" (#14890) 2022-06-29 14:39:33 +05:30
Rishabh Rathod
c6e22c73ed
fix: JsObject parsing (#14842)
- Change the parsing logic to track variableDeclarator and check for JSObject being declared and find its properties using the AST Node.
- As we are exactly checking JSObject Node we won’t have any incorrect properties defined or any property missed
2022-06-29 10:03:36 +05:30
Aswath K
2393790170
fix: Unable to toggle JS button for table column (#14843) 2022-06-28 17:53:03 +05:30
Nayan
1509d4b0ab
Fix Server build failure due to failing tests (#14837)
Fixes build failure due to missing dependency in controller tests.
2022-06-28 11:01:06 +05:30
Nayan
737bab389d
bug: fixed test failure for get profile of anonymous users (#14805) 2022-06-27 11:55:50 +06:00
f0c1s
c0c4feae56
fix: show repo limit reached on home page (#14691) 2022-06-27 10:20:53 +05:30
Rishabh Rathod
5625784829
fix: reset meta to default value (#14468)
* fix: [WIP] reset meta to default value

* refactor

* fix reset child widget and type in metaReducer

* Fix type and refactor test

* fix multiselect click

* Add jest test for reset widget action

* Add cypress test

* Add comments

* Add more cases as per comment

* remove `only` from test case

* Add default value case of array with values

* MultiSelect spec fix

* fix currencyInput reset

* refactor test code suggested in comments

* fix type

* fix more type

* fix cypress test

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-25 11:00:54 +05:30
albinAppsmith
fcbcec751d
feat: Design System package & Tooltip integration (#14547)
* Added Appsmith Design System Package
* Removed tooltip from ADS folder
* Changed imports for Tooltip

* added alias for the @appsmithorg/design-system

* fix for npm aliasing in jest

* design system package version change to beta 1.0.1-beta.8

* Tooltip Position type changed to PopoverPosition

* design system package updated
2022-06-24 19:53:02 +05:30
Bhavin K
1c09031115
fix: the random month showing issue in datepicker widget (#14472) 2022-06-24 12:15:05 +00:00
Rishabh Rathod
5d1e6b8cbe
fix: Replace initEval binding success event (#14662)
Remove event for 1st Eval
2022-06-24 17:29:30 +05:30
arunvjn
b04d8ec858
fix: broken sample app links in omnibar (#14605) 2022-06-24 15:31:28 +05:30
Ankita Kinger
2452018213
fix: invite user and password reset email not being sent via config page setup (#14663)
* invite user and password reset email not being sent config page changes

* refactored code for toggle on admin settings screen

* some minor code refactoring
2022-06-24 15:22:44 +05:30
subratadeypappu
507caf2ebd
fix: Garbled characters in API response (#13515)
* fix: Consider zip compression info from API response header (#13515)

This commit fixes two things
- If certain API has Accept-Encoding header then Appsmith will take care of this before rendering response to the client
- Used MediaType.includes function for more extensive matching of the requsted API's content type

* fix: Add unit test on consuming API with gzip encoded response (#13515)

This commit takes care of two things
- Unit test on consuming an API which has response being encoded in GZip format
- Set default content-type to "text/plain" in case the content-type is not present in API response

* fix: Add Cypress test on consuming API with gzip encoded response (#13515)

This commit takes care of the following
- Cypress test on consuming an API which checks if it can read any property from the response sent from the API server encoded in GZip format
2022-06-24 15:22:51 +06:00
Aishwarya-U-R
9774118b8b
test: Automated tests for Postgres Datatype - Boolean & Enum (#14778)
* BooleanEnumDT spec added

* failure point fixes

* Snaps paths updated

* Unskipping cases

* BoolEnum query create fix

* list_regression fix
2022-06-24 13:52:29 +05:30
akash-codemonk
f4302aa4b0
fix: update imported app to make use of sample user db for onboarding (#14751)
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-24 13:32:37 +05:30
Rimil Dey
ad601f32fe
Merge pull request #12551 from appsmithorg/feature/expose-post-message
feat: Add a field for the post message api exposure
2022-06-24 12:02:59 +05:30
Aswath K
5f3e7672ab
fix: Property pane components re-render (#14581)
* Prevents unwanted rendering of PropertyPaneSidebar

* Prevents unwanted rendering of PropertyPaneView

* improved optimization code for PropertyPaneView

* Prevents unwanted rendering of PropertyPaneConnections

* replaces unwanted selectors with direct access to store

* fix: dependency not updating

* replace wrong required properties

* extracts equality fn to selectors

* naming changes

* Move selector from component file

* fix: property pane becomes empty

* avoids usage of compact

* Fix bug with getDataTreeWithOnlyIds extraction code
2022-06-24 11:31:08 +05:30
Abhijeet
1c03266d31
fix: Fix backward compatibility related to v1 git file format (#14770)
* Fix backward compatibility for v1 git file format

* Add testcase

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-24 09:59:18 +05:30
Apeksha Bhosale
7fa4df32a1
fix: Saving variables as string rather than values in backend (#12999)
* parsing of js object has changed

* added test for parsing

* parse object with literal

* added variable to reactive paths and solved some PR comments

* test fixed

* small fix

* removed restricting functions to be added if object body has errors

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-24 09:36:52 +05:30
Rimil Dey
9edc361a16 Solved typescript errors 2022-06-24 09:20:13 +05:30
Rimil Dey
91dad3eb95 Allow empty strings, null and undefined to be sent as they are valid data 2022-06-24 09:20:12 +05:30
Rimil Dey
7326d3fac1 Fix the error messages 2022-06-24 09:20:12 +05:30
Rimil Dey
dfe6a862fc Fix tests 2022-06-24 09:20:12 +05:30
Rimil Dey
f3e34f70c6 Remove unrequired parameter 2022-06-24 09:20:11 +05:30
Rimil Dey
fdb2c6e805 Add unknown to msg type in action triggers
Add errors to post msg saga
2022-06-24 09:20:11 +05:30
Rimil Dey
1e4d39b4ae Add unit test for post message saga 2022-06-24 09:20:11 +05:30
Rimil Dey
0303d5e1dd rename ActionType.postMessageToTargetWindow -> ActionType.postMessage 2022-06-24 09:20:11 +05:30
Rimil Dey
f2b5a65f9b Add more tests 2022-06-24 09:20:10 +05:30
Rimil Dey
24cb572a11 Code review comments 2022-06-24 09:20:10 +05:30
Rimil Dey
242dc7cca2 Add tests 2022-06-24 09:20:10 +05:30
Rimil Dey
8c4c1823c5 Log errors for post message
Remove tranfer array field
2022-06-24 09:20:09 +05:30
Rimil Dey
a9ba6d705d add example website to prevent security concerns 2022-06-24 09:20:09 +05:30
Rimil Dey
ca73f81f79 Change the function name from postMessage -> postMessageToTargetWindow to prevent overriding worker thread's postMessage 2022-06-24 09:20:09 +05:30
Rimil Dey
ee5a178780 Fix implementation details 2022-06-24 09:20:09 +05:30
Rimil Dey
aa2ee927db Add window to post message call 2022-06-24 09:20:08 +05:30
Rimil Dey
9d6846ecf6 Fix transfer array type 2022-06-24 09:20:08 +05:30
Rimil Dey
e808bf2d41 Add entity definition for autocomplete 2022-06-24 09:20:08 +05:30
Rimil Dey
b63183ae07 Add implementation for post message, remove callbacks and add fields for 3 parameters 2022-06-24 09:20:07 +05:30
Rimil Dey
be5d8d9924 Add a field for the post message api exposure 2022-06-24 09:20:07 +05:30
Arsalan Yaldram
b4347b44e1
fix: menu button icon alignment fixed. (#14644) 2022-06-24 00:59:07 +05:30
Arsalan Yaldram
130451ade0
fix: show cancel button on left pane resize (#14531) 2022-06-23 23:42:24 +05:30
Arsalan Yaldram
932ff31a68
fix: container gap with wrapper on border radius (#14530) 2022-06-23 23:25:03 +05:30
Arsalan Yaldram
cf4eebde39
fix: added focus border for numeric input buttons (#14709) 2022-06-23 22:33:30 +05:30
Aishwarya UR
906cbe1f3f Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-23 21:01:19 +05:30
Aishwarya-U-R
5d75a46df1
test: Automated tests for Bug #14299 + Specs rearranged (#14632)
* Moving tests

* Workspace cases moved all to one folder

* Moving tests

* Bug 14299 scripted

* JSOnload spec failure fix

* Moving spec

* Moving specs

* Moving specs

* Added bug id in title

* Moving specs

* Moving specs

* Moving spec

* Added bug id in title

* Removed tests

* Theme Basic spec - added publish mode validations

* tests re-arranged

* Theme_form widget fix

* endp to endpoint change

* theme Basic spec fix

* AppSetupForRename removed

* Appli rename reverted

* Specs rearranged

* Added interval validation

* Also deleting query

* validation moved places

* Git imports corrected

* git import corrected

* datePicker fix
2022-06-23 20:43:15 +05:30
rahulramesha
07ded0dacc
feat: Deprecation warning message update to reference the widget that is replacing it (#14532)
* reference replacement widget in the deprecation warning message

* updated import path for messages

* adding test case for validating deprecated widget COnfig
2022-06-23 20:39:00 +05:30
subratadeypappu
704d19ac4f
Merge pull request #14233 from appsmithorg/fix/14054-describe-table-in-mysql
fix: Show table structure when desc table or describe table command is run stand-alone in MySQL (#14054)
2022-06-23 19:38:20 +06:00
Anagh Hegde
e95602ce8a
feat: Add keyType to git import key generation flow (#14762) 2022-06-23 17:54:39 +05:30
f0c1s
b97042a38a
fix: disable branch dropdown until merge status returns (#14540) 2022-06-23 10:27:35 +05:30
f0c1s
ab3766adbe
chore: throttle git apis (#14639) 2022-06-23 10:22:25 +05:30
Nidhi
049de6b58f
chore: Added actionId and requestedAt fields in ActionExecutionRequest (#14720)
* chore: Added actionId and requestedAt fields in ActionExecutionRequest

* Reverted unrelated failing test

* Fix test failures

* Refactor test

Co-authored-by: Anagh Hegde <anagh@appsmith.com>
2022-06-22 22:43:31 +05:30
Nayan
530a571ba0
chore: send whether the app was published manually to the analytics event (#14728)
Sends an attribute along with publish app analytics event to denote whether this was a manual publish or automated publish.
2022-06-22 23:10:22 +06:00
Anagh Hegde
14eb9b4cb5
feat: Add API for git docs and supported shh keys (#14641) 2022-06-22 21:50:04 +05:30
ChandanBalajiBP
0af9d2ea3b add indexing for the testcases 2022-06-22 18:02:40 +05:30
ChandanBalajiBP
abaafab74b Merge branch 'release' into Fix/Mismatch-with-design-in-Sample-Datasource-Card 2022-06-22 17:43:51 +05:30
ChandanBalajiBP
cbf5f88d3f upadted failing testcase to change tabs 2022-06-22 17:41:44 +05:30
Anand Srinivasan
ed59802702
add analytics log on app crash (#14575) 2022-06-22 16:00:33 +05:30
Tolulope Adetula
7ba4f0679a
Merge pull request #13129 from appsmithorg/fix/12161-multiselects-broken-in-modal
fix: Popover in Multi select widget inside modals breaks away from the widget
2022-06-22 09:59:00 +01:00
ashit-rath
5a7940ae2b
fix: JSONForm - Generate Form button apply theme on new fields (#14687) 2022-06-22 14:21:53 +05:30
Pawan Kumar
790452cc74
fix: Edit App button not confirming to the theme (#14629)
* fix edit button not rendering issue

* dummy push to make vercel build again

* Removing wait time aft Publish - tetsing fix

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-06-22 12:30:17 +05:30
Parthvi12
632236e631
test: Add tests for critical bugs (#14667)
* Add tests for critical bugs
2022-06-22 12:24:17 +05:30
Aswath K
7ce8cd8848
fix: JS toggle issue for dropdown control with numeric value (#14648)
* fix: JS toggle issue for dropdown control with numeric value

* fix jest tests
2022-06-22 11:53:54 +05:30
Bhavin K
f218642fc5
fix: show the error message in input widget (#14460) 2022-06-22 06:09:50 +00:00
Arsalan Yaldram
c8f4dd04b5
Merge pull request #14718 from appsmithorg/fix/editorutils
fix: editor utils moment async import
2022-06-22 11:05:33 +05:30
Nayan
076f2a6ced
fix: Admin email not working (#14474)
When a new email of an existing user is added to admin emails from the admin settings page, that user does not get admin access instantly. Same happens when an existing user's email is removed from admin settings - permission is not revoked instantly.
2022-06-22 11:26:37 +06:00
Vishnu Gp
63205dce27
Merge pull request #14184 from appsmithorg/feat/git-delete-only-removed-resources
Feat: Perform file ops only when the resource is updated
2022-06-22 10:53:45 +05:30
akash-codemonk
b6641f48a3
chore: add analytics events for to see how a user moves from the canvas to any other file (#14385) 2022-06-22 09:31:49 +05:30
Tolulope Adetula
43ecd36407 fix: failing tests 2022-06-22 02:38:05 +01:00