Commit Graph

4251 Commits

Author SHA1 Message Date
Preet
1595a7a61d move isNilOrEmpty to helpers.ts 2022-03-21 13:27:25 +05:30
Preet
84a2e96b6d Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-21 13:18:57 +05:30
Preet
4b27fdf643 fix select widget width 2022-03-21 13:18:51 +05:30
Ankur Singhal
3f0450ea96 added bugfix for date parsing in datepicker widget 2 2022-03-21 13:05:47 +05:30
Daniel
4a485bf14d
Merge pull request #11906 from appsmithorg/fix/extra-key-value-datasource
fix: remove extra key value pair for DataSource
2022-03-21 07:34:47 +01:00
Ayush Pahwa
6509fbc099
feat: Switch to JSON view functionality for form components (#11786)
* Update: Added flag check for evals

- Only running init form evals if the form is of new UQI config

* Create: Separated Form config logic

- Created a new file to render the form configs of any form component

* Update: Enum and getter for view types

- Added enum for view types
- Added a function to extract the view type of current component

* Update: Handling initial values of form

- Added checks and updated the default data tree for the components of UQI forms
- This is to allow to switch these components to the new data type

* Update: updated type of control data

- Added viewTypes to the type of form component's control data

* Create: Function to change viewType

- Added function that will check the current data and switch to the new view type

* Update FormControl.tsx

- Split the logic of form config to a new file
- Updated the memo component to a function so custom config can be passed in it
- Added conditional check for the final component

* Create: wrapper component to switch view

- Component added to change between GUI and JSON view types

* Update: Variable name for alternate view types

- Changed variable name for alternate view types from viewTypes to alternateViewTypes

* Update: Added checks to init section

- Added a check for the required values in where clause component

* Update: Usage of useMemo hook

- Moved the useMemo hook to the top so it is not called conditionally

* Update ToggleComponentToJson.tsx

- Moved toggled input text view as a constant variable

* Update utils.ts

- Moved toggled input text view as a constant variable

* Update actionProperties.ts

- Added switched view type input text to binding path list

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-21 11:21:50 +05:30
f0c1s
7cf3e3e7ce
fix: revoke access and limit reached modal updates (#11783) 2022-03-21 13:24:01 +08:00
Segun Daniel Oluwadare
9bd30b79cb
fix: add redux form initialization check 2022-03-21 02:52:01 +01:00
balajisoundar
f1d1ee9ac0
fix: numeric type input widget should accept zero after decimal point (#11923)
- Derived properties of List widget children won't work. so having the text
  property of the Input widget as a derived property causes issues. hence
  having it as a meta property.
2022-03-18 22:18:16 +05:30
akash-codemonk
f24b93da83
chore: fix import template (#11963) 2022-03-18 17:38:10 +05:30
Arsalan
ec62586a44 fix: Replace GREY_4 with GREY_8 2022-03-18 16:23:02 +05:30
Arsalan
0bbe9fedbb fix: Fixed Icon Button onClick in disabled state. 2022-03-18 14:59:34 +05:30
arunvjn
94d9f233bd
fix: Show newly created datasources on the entity explorer (#11892) 2022-03-18 14:15:38 +05:30
Arsalan
83d166d42b fix: ButtonGroup, MenuItems update indexes. 2022-03-17 18:58:56 +05:30
Preet
b3920abbe2 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-17 18:36:26 +05:30
Arsalan
37d9fd22bb Merge branch 'release' into fix/button-group-undo 2022-03-17 17:45:25 +05:30
Apeksha Bhosale
79e165af96
feat: Settings js editor (#9984)
* POC

* Closing channels

* WIP

* v1

* get working with JS editor

* autocomplete

* added comments

* try removing an import

* different way of import

* dependency map added to body

* triggers can be part of js editor functions hence

* removed unwanted lines

* new flow chnages

* Resolve conflicts

* small css changes for empty state

* Fix prettier

* Fixes

* flow changes part 2

* Mock web worker for testing

* Throw errors during evaluation

* Action execution should be non blocking on the main thread to evaluation of further actions

* WIP

* Fix build issue

* Fix warnings

* Rename

* Refactor and add tests for worker util

* Fix response flow post refactor

* added settings icon for js editor

* WIP

* WIP

* WIP

* Tests for promises

* settings for each function of js object added

* Error handling

* Error handing action validation

* Update test

* Passing callback data in the eval trigger flow

* log triggers to be executed

* WIP

* confirm before execution

* Remove debugging

* Fix backwards compatibility

* Avoid passing trigger meta around

* fix button loading

* handle error callbacks

* fix tests

* tests

* fix console error when checking for async

* Fix async function check

* Fix async function check again

* fix bad commit

* Add some comments

* added clientSideExecution flag for js functions

* css changes for settings icon

* unsued code removed

* on page load PART 1

* onPageLoad rest iof changes

* corrected async badge

* removed duplicate test cases

* added confirm modal for js functions

* removed unused code

* small chnage

* dependency was not getting created

* Fix confirmation modal

* unused code removed

* replaced new confirmsaga

* confirmaton box changes

* Fixing JSEditor Run butn locator

* corrected property

* dependency map was failing

* changed key for confirmation box

Co-authored-by: hetunandu <hetu@appsmith.com>
Co-authored-by: Hetu Nandu <hetunandu@gmail.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-17 17:35:17 +05:30
Paul Li
3e37914b01 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-17 19:27:50 +08:00
Paul Li
dd49573d15 feat: 4182: Internal property to detect changes in a form
-- Eliminate unnecessary props
2022-03-17 19:26:24 +08:00
Arsalan
0253019d34 fix: Tab Widget Sagas fixed. 2022-03-17 16:28:26 +05:30
haojin111
9cfca0518f
feat: 9754 import work flow (#10453)
* updated import application modal design as v2

* updated import flow

* added title, description, uploadIcon on filepicker ads component for custom file picker

* adding modal of add credential for git import

* added "Git Import" modal

* added generating ssh key for importing flow

* fixed issue of merging

* chore: fix import

* chore: show old import modal based on feature flag

* seperated import api from connect

* added datasource list on reconnect credential modal

* chore: minor changes

* chore: move ssh keys to git sync reducer from applications reducer

* chore: minor fixes

* chore: fetch datasource config for import

* for pulling

* for review of displaying of datasource

* added reconnect datasources after git import

* fix: initialize datasource with default values

* fix: initialise redux for after updating datasource with default values

* fixed issue of git connection init when importing

* if there is a datasource config missing in import, reconnect modal should be opened

* updated logic for unconfigured datasources

* commented unnecessary code

* fixed issue of successful import

* updated import app error logic

* Add un-configured datasources to Import via file response

* Add test

* fix

* chore: refactors

* change per review

* fix: reset ssh keys / url

* Fix issue with newly created datasources not sent

* fix

* chore: minor updates

* chore: minor fix

* WIP

* added saas and rest api datasource form

* feat: fixes and updates for file import flow

* chore: close on upload

* Refactor logic ofr finding unconfigured datasources

* fix: minor fixes

* Fix issue with IsPartialImport

* fix

* Add PartialImport flag for ImportExport service

* refactoring of datasource editor form for both of importing app and editing app

* fixed collapse config

* Fix tests

* Handle redirection back to the /applications for oAuth type

* Show reconnect button on the datasources pages if the datasource configuration is skipped

* added analytic events for reconnecting datasource modal

* Fix the repo limit check for git import

* updated test of importing app from json as new work flow

* updated exported app json while testing automatically

* Add isImport flag for handling OAuth redirection in import flow

* WIP

* updated card UI for import from git title and message in import app modal

* chore: cleanup

* chore: lint

* fix: add is import query param to get token for oauth

* fix

* When the user imports the application there should not be any uncommitted changes displayed on the commit icon

* Add flag to identify OAuth redirection for git import

* Update the variable name

* refactoring reconnect datasource modal

* close git import modal when repo limit error responded

* fixed issue of restoring draft data of datasource form without save on reconnect datasource modal

* chore: update query

* updated query name of oauth redirection url

* Fix duplicate name issue in git import

* fixed rest api reconnect issue on reconnect modal

* init datasources and plugins after imported app, updated reconnect modal as new design

* added unconfigured datasource list logic when importing and updated rest api form delete button visible

* removed put default config of datasource and fixed issue on it

* Add logic to check isCOnfugred in datasource API

* Expose API to get un configured datasources for git import

* added fetch unconfigured datasource list api when redirecting form OAuth

* Remove sensitive fields from application json during export

* update put call response to check for datasourceConfig

* chore: use @appsmith for constants/messages

* chore: use download icon and Import for Importing application label

* chore: move import application text up a bit

* Fix bad merge

* chore: update skip to application tooltip text

* fixed tooltip content of skip to application CTA

* init values of datasource when importing

* updated ui of git import modal as figma design

* fixing padding issue of reconnect datasource modal

* fixed cursor issue on import app modal

* Fix issue with datasource config

* chore: make code compile

* chore: sort lines

* fixed save button issue of dbform on reconnecting modal

* fixed style of import application modal

* Fix iisue with wrong value updated to flag

* reverted from reconnection form style

* fix: update design as per slack discussions on 2022.02.23

* fix: move modal close button to the left

* Remove check for the flag and use the one from db

* Set siCOnfigured as true for mockdata sets

* updated creating datasource with isConfigured as false

* Fix NPE while importing

* fixed scrollbar issue and text alignment on reconnect datasource modal

* fixed style of form container in reconnect datasource and redirecting to app if all are configured

* remove unwanted fields from application json

* FIx NPE for file import

* fix: move close button up in import modal

* remove delete button on reconnect datasource modal

* Add isConfigured false while creating datasources

* fix: add a gap and update color

gap between git import dialog title and subtitle
update color of subtext to GREY_800

* fix: use git import feature flag

* fix: do not use older modal

* updated selecting logic of unconfigured datasource in reconnect modal

* cleanup: auto format

* cleanup: refactor react component

* cleanup: refactor some more

* cleanup: autoformat

* Fix reconnect flag for mockdatasource

* During git import set the isConfigured to false for datasources

* Remove decrypted field from the applicationJson file

* Remove decrypted field from the applicationJson file

* Add app slug to remote repo

* fixed cypress test related with git

* updated json while testing

* Changes per review

* Update the method name

* fixed cypress test related with git

* fixed migration cypress test

* set is configured field as true on tour app

* Fix issue with datasource creation for welcome tour

* fixed issue of replay_editor cypress test

Co-authored-by: Rishabh Saxena <rishabh@appsmith.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: Anubhav <anubhav@appsmith.com>
Co-authored-by: f0c1s <iamanubhavsaini+git@gmail.com>
2022-03-17 15:58:54 +05:30
Arsalan
87c4645a87 fix: Button Group, MenuButton, Tabs undo Redo fixed. 2022-03-17 15:49:17 +05:30
Preet
53c8b18c79 Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-17 11:56:44 +05:30
Preet
9003e6ddfb add unit test for Select Button 2022-03-17 11:49:35 +05:30
arunvjn
1e2b878ae2
Remove api calls to fetch default docs from github (#11856) 2022-03-17 07:00:42 +01:00
Arsalan Yaldram
9f51619b2c
Merge pull request #11865 from appsmithorg/fix/button-icon-alignment
fix: Button Icon Alignment on Icon Change
2022-03-17 11:12:15 +05:30
Preet
cd694540fd fix scroll behaviour on filtering 2022-03-17 11:10:22 +05:30
Preet
bceae2fb4e refactor select button 2022-03-17 10:57:39 +05:30
Bhavin K
ab9310bda8
fix: remove margin when no label (#11789) 2022-03-17 10:42:35 +05:30
Preet
1e5d7153ea add virtual list for select menu 2022-03-17 10:30:24 +05:30
Bhavin K
d8f843187f
fix: handle Centered component height (#11825) 2022-03-17 10:17:17 +05:30
Ankita Kinger
7583c52e2a show signup link even if signup toggle is off 2022-03-16 21:56:37 +05:30
Paul Li
7403449197 Merge branch 'release' into feat/4182-form-detect-changes 2022-03-16 22:51:09 +08:00
Leo Thomas
7a038400e5
fix: 10527 Google Sheet crud generation header issue v2 (#11664)
* fix: 9824 Google Sheet to filter empty condition ver.2

* Code review comments updated

* Updates as per review comments - Ver 3

* Resolved errors found during testing

* Code review comments fix

* fix:10527 Google Sheet Crud Generation header issue

* Code review comments implemented

* Updated review comments

* code review - resolve test cases issue

Co-authored-by: Leo Thomas <leoweb2010@gmail.com>
2022-03-16 20:20:10 +05:30
Paul Li
f9e30a1e15
fix: Input widget onSubmit gets triggered before evaluation (#11590)
* fix: onSubmit gets triggered before evaluation

-- Enforce to update text meta property before trigger the submit action

* fix: onSubmit gets triggered before evaluation

-- Add a comment and a Cypress test on the fix

* fix: onSubmit gets triggered before evaluation

-- Fix on the failed test case

* fix: onSubmit gets triggered before evaluation

-- Rewrite comments
-- Rewrite the test case to fail if we revert changes

* fix: Iput widget onSubmit gets triggered before evaluation

-- Update a common property, isDirty
2022-03-16 22:45:12 +08:00
Paul Li
097ab33b4c feat: Internal property to detect changes in a form
-- Complement Cypress test case by adding reset cases
-- Update isDirty reset logic for MultiSelectWidgetV2
2022-03-16 22:44:44 +08:00
akash-codemonk
36be2d213b
fix: wait for organisation list to be fetched before creating an application for welcome tour (#11907) 2022-03-16 20:08:50 +05:30
Favour Ohanekwu
3d43de4884
fix: convert blob urls in object type values (#11872) 2022-03-16 19:59:52 +05:30
Favour Ohanekwu
3f9e1a34eb
do not show errors for private widgets (#11883) 2022-03-16 15:27:22 +01:00
rashmi rai
f6ba19dcb7
fix set initial value of KeyValueArrayControl (#11756) 2022-03-16 14:26:57 +00:00
Aswath K
e86b169ead
fix: Icon Selector width on propety pane resize (#11736)
* fix: Icon Selector width on property pane resize
2022-03-16 14:26:40 +00:00
Ayangade Adeoluwa
ba99068425
feat: Add action name to confirmation modal (#11807)
* Add action name to confirmation modal

* Fix cypress tests and button size
2022-03-16 14:26:19 +00:00
Ayangade Adeoluwa
2f862ac8db
fix: properly render html responses (#11853)
* properly render html responses

* My empty commit with a message

* My empty commit with a message

* Remove package, use custom function

Co-authored-by: Adeoluwa Ayangade <adeoluwaayangade@Adeoluwas-MacBook-Pro.local>
2022-03-16 14:25:56 +00:00
balajisoundar
ab963d473c
Revert "fix: numeric type input widget should accept zero after decimal point (#11579)" (#11888)
This reverts commit 342fec4462.
2022-03-16 17:34:44 +05:30
Bhavin K
3486e7c0c8
fix: Reset image error flag when imageUrl or defaultImageUrl is changed in Image widget (#11790)
* fix: handle image error flag

* doc: comment update

* test: added cypress testcase

* test: updated cypress test case

* test: test case updated

* test: cypress updated

* test: fix cypress
2022-03-16 06:10:20 +00:00
Paul Li
c4ee93edef Merge branch 'release' into feat/4182-form-detect-changes 2022-03-16 07:55:07 +08:00
akash-codemonk
9dd5e23789
fix: onboarding not starting from intro modal (#11860) 2022-03-15 18:42:29 +05:30
Arsalan
1f45c67edf fix: added iconAlign dependency to iconName prop 2022-03-15 12:19:30 +05:30
Ankita Kinger
12850cabc9
added asterisk on mandatory fields (#11829) 2022-03-14 15:26:28 +05:30
Apeksha Bhosale
46541bd9e7
allow functions inside loop (#11588) 2022-03-14 10:57:52 +05:30
haojin111
a51ac2ed5a added padding of git app list container 2022-03-14 12:14:07 +08:00
arunvjn
6199eada0a
Fixed incorrect shortcut text for "create new" in omnibar and removed "+" character from all shortcuts for mac (#11753) 2022-03-14 03:24:53 +00:00
Arsalan Yaldram
6496f84374
fix: Added Button Container for the firefox drag issue (#11627)
* fix: Added Button Container for the firefox drag issue

* fix: Removed un-necessary styles, added Container in Canvas mode.

* fix: Removed renderMode check from styled function.

* fix: Code refactor and handled Icon Button Component.

* fix: Added extensive comments.

* fix: handled menu button drag issues.

* fix: Fixed some failing tests.

* New Button locator (with drag-container) fix

* NewBtn container locator fix

* btn locator fix

* MongoShopping spec fix

* Mongo, Postgress fixes

* Stat box fix

* Testcase title update

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-03-13 22:51:04 +05:30
haojin111
97483c5c4b added scrollbar to repo limit error modal 2022-03-12 16:49:04 +08:00
Preet
d5a59d48be Merge remote-tracking branch 'origin/release' into fix-10771_text_widget_warning 2022-03-12 11:13:36 +05:30
Preet
d389270423 add config param for limiting line breaks 2022-03-12 11:12:56 +05:30
Bhavin K
92267b3627
feat: changed icon widget to icon btn for modal widget (#11508) 2022-03-11 23:58:17 +05:30
albinAppsmith
5423944bbd
fix: Preserve entity explorer state on page refresh (#11064) 2022-03-11 21:17:42 +05:30
Ayangade Adeoluwa
f13b6a2fe1
fix: fix embedded url misalignment (#11785)
* Fix embedded url allignment

* Fix edit action name allignment

* datasource container height
2022-03-11 21:16:13 +05:30
Ankita Kinger
d32f848efd
fix: Update copy and flag for all toggle buttons on Admin settings page (#11703)
* completed toggle button changes on admin settings

* fixed browser console errors

* implemented PR suggestions

* reversed copy for telemetry
2022-03-11 16:51:58 +05:30
Yash Vibhandik
ccf12c76a0
fix: #11315 Added trimming in button variant name (#11390)
* fix: #11315 trim buttonVariant

* test: cypress added
2022-03-10 21:39:17 -08:00
Yash Vibhandik
2a203b428b
fix: #11112 updated list widget property config (#11388) 2022-03-10 21:38:37 -08:00
Tolulope Adetula
beed6df8b3
fix: inconsistency in select and treeselect widgets behaviours (#11462)
* fix: Select dropdown width overflow

* fix: dropdown overflow in MultiTreeSelect widget

* fix: Multi tree select and Add filter input

* fix: tree select dropdown

* Fix: Select icons on explorer and Fix invlaid state of widgets

* fix: remove redundant style

* fix: build failure

* fix: build failure

* fix: yarn issues

* fix: build issue

* fix: remove labels from select widgets

* fix: dropdown width issue in compact mode

* fix: remove the close icon in the filter bar when there's no text

* fix: Filter bar should also follow the same min width as the widget.

* fix: add tooltip to show hover when text is truncated

* fix: Add audio widget to entity explorer

* Fix: failing tests and searching on Select widget

* fix: PR reviews

* fix: isDirty only when value changes

* fix: focus state of treeselect

* fix: remove default focus state and make filter get focus on open

* fix: focused Item when opened

* fix: No ellipsis found in Select widget when URL is an option
2022-03-10 21:35:05 -08:00
akash-codemonk
b3de51272c
fix: Templates UI polishing (#11567) 2022-03-10 20:09:05 +05:30
f0c1s
e1bc86b9e9
fix: remove text area from commit message box (#11342)
* fix: remove text area from commit message box
* fix: multiline commit
2022-03-10 09:27:27 +00:00
f0c1s
97711516d5
fix: typo in messages (#11571) 2022-03-10 09:19:23 +00:00
Arsalan Yaldram
75922c8a31
Merge pull request #11395 from appsmithorg/fix/remove-datasources-action-selector
fix: Remove datasources from Execute Query Action.
2022-03-10 13:34:19 +05:30
balajisoundar
342fec4462
fix: numeric type input widget should accept zero after decimal point (#11579) 2022-03-10 13:27:58 +05:30
Arsalan
9bb13dd1df Merge branch 'release' into fix/remove-datasources-action-selector 2022-03-10 11:48:05 +05:30
f0c1s
74200da71c
fix: polish git-sync feature (#11740)
Faster tooltips for bottom bar quick actions
Branch popover has a backdrop like the modals do.
More than 9 changes are reported as it is
Recent commit shows "less than a minute" ago
BETA tag removed from popover
Faster tooltips for sync branch button in popover
Placeholder for commit message
Relevant placeholder for git remote input
Padding for content in modal is decreased
Notification banner is aligned with SSH key box
2022-03-10 11:08:50 +05:30
Bhavin K
71d6da19bc
feat: added isJSConvertible property in IconButton Widget (#11625)
* feat: updated  isJSConvertible property

* fix: default icon value added, validation updated
2022-03-10 09:41:02 +05:30
arunvjn
52944dcea7
fix: Prevent page reload when launching an application from the applications dashboard for faster load time (#11604) 2022-03-10 07:52:07 +05:30
Arsalan Yaldram
366276cdbc
chore: Keyboard accessibility added to canvas selector buttons. (#11420)
* chore: Keyboard accessibility added to canvas selector buttons.

* chore: Removed default tab navigation for buttons.

* chore: Fixed Tab Navigation.

* chore: Fixed edge cases, handled selectedIndex.

* chore: use OnBlur instead of Tab key press.

* chore: added jest test cases for Arrow navigation.

* chore: review changes for test cases.
2022-03-09 18:40:21 +00:00
Preet
8041c58254 fix stringify text if it exceeds line breaks limit 2022-03-09 20:04:26 +05:30
arunvjn
02980068ad
Changing shortcut create query/JS shortcut to cmd + plus (#11728) 2022-03-09 11:19:19 +00:00
Aman Agarwal
9189b3d4af
fix: Updated conditions for dropdown control to take in false also as value (#11712) 2022-03-09 16:37:36 +05:30
Paul Li
b4c33fe050
fix: Icon alignment changes automatically every time the icon is changed in Menu button widget (#11570)
* fix: Icon Alignment changes automatically every time when icon is changed in Menu Widget

-- Add iconAlign property as a dependency for iconName property

* fix: Icon Alignment changes automatically every time when icon is changed in Menu Widget

-- Add a Cypress test case to ensure the fix

* fix: Icon alignment changes automatically every time the icon is changed in Menu button widget

-- Fix on a broken Cypress test, setting force to true
2022-03-09 02:29:50 -08:00
Arsalan Yaldram
e411f093cc
Merge pull request #11623 from appsmithorg/fix/table-filter-pane-overflow
fix: Added root element as the ParentBoundary for TableFilterPane.
2022-03-09 11:22:19 +05:30
Favour Ohanekwu
cd3c8c0c96
fix audio widget autocompletion (#11667) 2022-03-08 16:30:59 +01:00
akash-codemonk
a6946fbcf0
fix: end guided tour on exiting editor (#11084) 2022-03-08 20:25:20 +05:30
Aman Agarwal
c891af5b21
fix: curl import ui fixes wrt to design system (#11648) 2022-03-08 19:49:38 +05:30
Aman Agarwal
691cfb767c
fix: Rest API UI issues (Empty DS headers, UI for Param tab, Save DS button, Placeholder) (#11700)
* fix: filtered empty key value pairs in headers, ui for param tab

* fix: disabled button to save ds in auth tab if no url

* fix: changed placeholder text
2022-03-08 19:49:02 +05:30
Anand Srinivasan
ae733ca2f0
fix: unrelated widgets in loading state (#11370)
* log loading actions

* isLoading: check entity properties

* rename variables

* unit tests

* add descriptions

* clean test data

* include JS_Object self-dependencies

* add comment

* fix basic tests

* fix unit tests

* updated unit tests

* add test case

* update comment

* console - disable lint errors

* code clean up

* change folder

* find loading entites as a method

* updated unit tests

* check if entity exists in dataTree

* update test cases

* getEntityDependants - add specific path test case
2022-03-08 13:56:03 +00:00
arunvjn
dbec047959
Update appsmith docs version to 1.3 (#11692) 2022-03-08 13:55:30 +00:00
Ayangade Adeoluwa
1f7900a7db
Fixes confirmation modal flickering bug (#11618) 2022-03-08 13:55:13 +00:00
arunvjn
ff339f0295
Added analytics event to track datasource dropdown usage in query editors (#11693) 2022-03-08 13:54:48 +00:00
Bhavin K
c9760edb87
Revert "fix: handle main container height (#11461)" (#11674)
This reverts commit c6f5dcb673.
2022-03-08 12:54:40 +05:30
Arsalan
db27afeed6 Merge branch 'release' into fix/remove-datasources-action-selector 2022-03-08 11:42:35 +05:30
Tolulope Adetula
b17cd2e3bd
fix: table widget value displacement (#11650) 2022-03-07 22:06:32 -08:00
Paul Li
8b79f6c77d Merge branch 'release' into feat/4182-form-detect-changes 2022-03-07 23:27:57 +08:00
Paul Li
70706c7f8e feat: Internal property to detect changes in a form
-- Add Cypress tests FormWidget's hasChanges and all assoicated widgets' isDirty
-- Add missing isDirty meta property for SwitchGroupWidget
-- Rewrite isDirty check logic for RichTextEditorWidget
2022-03-07 23:23:57 +08:00
Preet
51c3d37620 Custom menu item 2022-03-07 20:06:35 +05:30
Preet
f4e6341add Merge remote-tracking branch 'origin/release' into fix-11468_dropdown_performance 2022-03-07 13:13:22 +05:30
Preet
21a5727353 update popover visibility through state 2022-03-07 13:12:49 +05:30
Ankita Kinger
af5483c7c4
fix: Style values of the page and default value for telemetry (#11640) 2022-03-07 11:36:34 +05:30
Daniel
7aa6a2015e
Merge pull request #11493 from appsmithorg/fix/reword-datasource-message
fix: reword datasource message
2022-03-06 18:48:03 +01:00
f0c1s
c346af60c3
chore: update icons in org menu (#11548)
* chore: update icons in org menu
* chore: update user-heart-line and update org menu
* chore: use member instead of members for icon name
2022-03-05 21:20:33 +08:00
f0c1s
15cd2857d3
fix: remove EDIT button (#11356) 2022-03-05 08:51:25 +00:00
Ayangade Adeoluwa
e576ac08db
Default action config values not being set (#11632) 2022-03-05 00:45:48 +00:00
Aishwarya UR
dc07329318 Merge branch 'release' into fix/table-filter-pane-overflow 2022-03-05 01:14:09 +05:30
Apeksha Bhosale
f610033240
removed default isAsync false from new js action (#11427)
Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
2022-03-04 15:51:33 +05:30
Arsalan
93e2f5eb62 fix: Added root element as the ParentBoundary for TableFilterPane. 2022-03-04 14:53:29 +05:30
Vicky Bansal
43441bfce2
feat: add tooltip to column header text which overflows (#10666)
* feature: add tooltip to column header text which overflows (#10495)

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix: test issues

Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com>
2022-03-04 00:56:16 -08:00
Preet
65940048e8 remove unnecessary re-renders 2022-03-04 13:36:38 +05:30
Paul Li
26d06c45a4
fix: Aspect ratio of video changes when Camera widget is longer in width than the aspect ratio (#11453) 2022-03-04 12:21:10 +05:30
Aswath K
ef89f3fee4
feat: Make icon selector keyboard accessible (#10460)
* feat: virtualize icon rendering makes icon selector smoother

* make icon selector keyboard accessible
2022-03-04 12:15:50 +05:30
Ankita Kinger
1688757bc6
fix: Signup text update & code optimisation (#11606)
* text change for signup admin settings & code optimized

* minor change
2022-03-04 11:56:12 +05:30
Apeksha Bhosale
e0e0fc8346
added event to stop loading (#11597) 2022-03-04 11:06:13 +05:30
Ayush Pahwa
5c187d61ef
fix: Drop down multiselect usage fixes for query forms (#11465)
* Update: Type for initialValues

- Added string[] to the initialValues type to allow dropdowns to have multiple values too

* Remove: Old projection selector file

- Removed projection selector file
- The new usage will be the old drop down file with new options

* Update: Dropdown file

- Added options to select and deselect the multiple drop down options
- Added functions to handle selection and deselection
- Added option in final render method to allow searching
- Handled default values for multi select and single select drop downs

* Update FormControlRegistry.tsx

- Updated projection component to point to drop down component with extra options

* Update: Fixed logic for dropdown select

- Fixed the if condition blocks to catch the case when the multiselect output is not an array
2022-03-03 16:42:02 +01:00
Ayangade Adeoluwa
b25441f576
Fix apiContentType bug (#11600) 2022-03-03 16:32:59 +01:00
Paul Li
5254f8e7f3 feat: Internal property to detect changes in a form
-- Eliminate the redundant code from RichTextEditorWidget
-- Change the way to detect default values changes with SelectWidget and MultiSelectWidgetV2
2022-03-03 21:57:22 +08:00
Ankita Kinger
a905b33081
fix: Remove reset password button if form login is disabled (#11591)
* increased restart server timeout & showing reset pwd only if form login is enabled

* Updated callout for disconnect button

* added space
2022-03-03 18:49:10 +05:30
Yash Vibhandik
2f7d862ea0
fix: #11301 filter pane text css updated (#11410) 2022-03-03 17:33:26 +05:30
Segun Daniel Oluwadare
1c9cb183db fix: reword datascource message 2022-03-03 12:00:21 +01:00
Anand Srinivasan
d89e12e3a5
fix: warning message - if child property doesn't exist in data tree (#10351)
* makeParentsDependOnChild - return if child doesn't exist in allKeys

* add unit tests

* add nested object to unit test

* fix unit tests

* fix unit tests

* add warning messages

* add comments for mock
2022-03-03 10:59:52 +00:00
akash-codemonk
65aee7fd14
feat: Application templates (#10964) 2022-03-03 16:26:53 +05:30
Apeksha Bhosale
eb34255b18
fix: removing unnecessary paths to evaluate (#11341)
* removing unnecessary paths to evaluate

* created regex and small refactor
2022-03-03 13:12:23 +05:30
balajisoundar
fe72182064
fix: Number type input should honour required property when value is empty string (#11442) 2022-03-03 00:38:22 +05:30
Ankita Kinger
13fe125a0c
feat: Add disconnect button on auth config pages and form login callout banner (#11389)
* added form login callout banner

* form login config page changes

* form login config page changes

* added redirecturl and uneditable field components

* added disconnect button on auth pages

* Added env variables for form login auth page

* added disconnect button on auth pages

* updated docs link for dform login callout doc

* added condition for disconnect button

* added ce changes done on ee

* updated css

* suggested changes in PR review

* suggested changes in PR review

* suggested changes in PR review

* reverted gitignore files changes

* reverted gitignore files changes

* updated logic for saving admin settings

* removed unused imports

* added changes for taginput field

* removed console

* removed warning

* removed unwanted changes
2022-03-02 23:48:50 +05:30
Nidhi
5c994975d7
fix: Modified action execution endpoint (#9473) 2022-03-02 16:01:50 +00:00
Nidhi
eaf1701d7e
fix: Modified error from string to first error object in debugger log (#11511) 2022-03-02 15:52:35 +00:00
Bhavin K
12954d4e3d
fix: changed download flow for image control (#11391)
* fix: changed download flow for image control

* test: cypress test added

* fix cypress test case
2022-03-02 13:43:24 +00:00
rahulramesha
4c1a6674fa
fix: separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas (#11396)
* separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas
2022-03-02 13:42:41 +00:00
f0c1s
8666fc23ff
fix: use sentence casing (#11376) 2022-03-02 13:42:06 +00:00
Bhavin K
c6f5dcb673
fix: handle main container height (#11461) 2022-03-02 13:41:44 +00:00
Preet Sidhu
5bfb770d2c
Merge pull request #11503 from appsmithorg/fix-1146_page_editor_behaviour
fix: 11476 page editor behaviour upon visibility toggle
2022-03-02 13:46:34 +05:30
rashmi rai
82a56222d2
fix: added allowDeselection in ads/dropdown (#11495)
* added allowDeselection in ads/dropdown

* fix dropdown height multi-selection

* add tests

Co-authored-by: Aswath K <aswath@appsmith.com>
2022-03-02 13:15:43 +05:30
Preet
96b9cc6523 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-03-02 12:09:21 +05:30
Preet
e64bf8f60b Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-03-02 12:07:26 +05:30
Hetu Nandu
ac7a73f667
fix: table button multi-line execution (#11525) 2022-03-02 12:07:20 +05:30
Shrikant Sharat Kandula
22f24110e7
Fix extra space in email placehoder in signup page (#11436) 2022-03-02 11:54:44 +05:30
Paul Li
e7355bdeba Merge branch 'release' into feat/4182-form-detect-changes 2022-03-02 03:15:54 +08:00
Paul Li
dbb09dd4e0 feat: Internal property to detect changes in a form
-- Make isDirty to a meta property, followed by code refactoring
-- Reset isDirty only if default value changes
-- Recursively check if the form has changes, even considering nested case
2022-03-02 03:02:10 +08:00
Preet
cbeeba64f2 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-02-28 23:10:50 +05:30
Ayangade Adeoluwa
51b43daa1b
fix: Fixes modal pop up bugs on page load (#11504)
* Fixes modal pop up bugs on page load

* send confirmBeforeExecute attribute with page execution order info

(cherry picked from commit 6d3cfdfbdb83b435e67797f3fb27024799d5d579)

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
2022-02-28 23:07:21 +05:30
Preet
9831f9e334 Merge remote-tracking branch 'origin/release' into fix-1146_page_editor_behaviour 2022-02-28 19:57:31 +05:30
Tolulope Adetula
1ea734bc14
fix: revert #8121 (#11502) 2022-02-28 19:44:56 +05:30
Preet
bfad6f4af4 check for drag distance 2022-02-28 18:33:05 +05:30
Hetu Nandu
06bf4696b4
fix: Promises in Table buttons (#11239) 2022-02-28 15:05:43 +05:30
Bharat Patodi
59c0d94ade
chore: Replace require with import statements (#8121) 2022-02-28 14:53:19 +05:30
Aswath K
ad952bb9a9
feat: make outgoing entities keyboard accessible (#11446) 2022-02-28 14:33:09 +05:30
Ankita Kinger
821c0d2021
css changes for invite users and manage users tables (#11441) 2022-02-28 11:38:33 +05:30
Ayush Pahwa
813d5850b0
fix: Update api params for dynamic fetched values (#11463)
* <feat> Updated payload for formEvals

- Added datasource and plugin ID to the payload

* <feat> Added IDs to dispatch calls

- Added datasource and plugin IDs to the dispatch calls so they can be used for dynamic query fetch

* <feat> Added type in evaluation saga

- Added datasource ID and plugin ID in the expected type for the eval function
- Updated call type from GET to POST for the dynamic trigger URLs

* <feat> Made params compulsory for editor config

- Params are now compulsory for any config defined in editor JSON for the dynamic value fetching

* <feat> Updated API definition

- Update the definition for the axios function from GET to POST

* <feat> Added configProperty to payload

- Added configProperty to the payload to allow for distinction between different components making a call to the server

* <chroe> Added null check

- Added null check to function call for datasource and plugin IDs in API since they are not compulsory in the type

* <refactor> Remove unused imports
2022-02-27 03:32:36 +00:00
Ayush Pahwa
fe2d625f5e
fix: Updated drop down control memo usage (#11218)
* Stopped props drilling of eval state

* Connect drop down to redux state

* Added extra check to formcontrol memo function

* Reduced modification of section at top

* Stopped mutating the initial state

* Created selector to get dynamic fetched values

* <refactor> Added comments and refactors

- Added key to the ES fragment
- Cleaned drop down component from redundant code
- Added comments

* <refactor> Removed test files

- Removed testing JSON configs

* <fix> Added null check for form eval output

- Added check to prevent null evalOutput in forms

* <chore> Removed console error

- Removed console error which is causing the vercel builds to fail
2022-02-26 22:41:38 +05:30
rashmi rai
705d275d12
fix: add binding paths for new UQI components (#11287) 2022-02-26 09:22:06 +05:30
Rishabh Rathod
7a484fc027
fix: meta changes (non-default) also update metaHOC state (#10734)
* Reset metaHOC state on widget reset

* Pass all meta values for metaHOC reset logic

* pass only metaReducer values in meta

* fix unit test

* Add test
2022-02-26 02:16:04 +05:30
Ayangade Adeoluwa
72b718ce11
fix: Fixes UI and functionality issues on the Curl editor page (#11405) 2022-02-25 15:01:06 +05:30
Rishabh Saxena
acf01995bd
chore: git sync cypress tests (#10006)
* Fix connect test

* check api response

* [wip] test comments across branches (#8704)

* Intercept only connect api

* chore: update switch branches tests (#9005)

* test switch branches from the query params

* test flow wip

* .

* fix merge status update

* change mergeAble to isMergeAble

* wip

* fix: show error popup if pulled from bottom bar

* fix: append branch query to notification links

* fix: disable git connection during onboarding

* fix: typo

* fix: typo

* fix: typo

* fix: z-index bottom bar cout

* fix: pull button minor fix

* fix: reset conflicts when the git sync modal is opened

* fix

* feat: enable search for branch dropdown

* fix

* fix: typo

* added merge conflicting on merge tab

* updated gitsyncsaga for git sync error action

* added generate ssh key on init and updated git changed count message

* removed git sync error action from error processing module(toast and log)

* commented push button on bottom git action bar temperory

* added option to use git global config

* Added latest deploy preview time: didn't appear until the duration was in minutes

* Link open repo button with repo link

* fixed of commented code part

* upated tooltip of push button on bottom quick git sync toolbar

* Update banner styles for error and warning

* updated repo publish url pattern and last deployed view part

* when the user clicks on the push icon the deploy tab should open

* when branch name is too big and user hover on it the tooltip is not displayed

* The dropdown alignment displayed for the git connect should be polished

* update tests

* fix: minor git sync fixes (#9228)

* fixed of Under the merge tab when the user searches for the branch name which is not present the pop up closes all of a sudden

* fix: update merge api, use message from api response

* fix: update field

* added tooltip of long dropdown option and updated merge tab dropdowns

* removed log

* chore: add connection cypress tests

* temp update for running tests locally

* fixed long branch name on branch list popup

* Use _ as the branch name separator, instead of -

* Use large buttons as CTAs

* Remove the % from the progress bar

* Fix alignment for the skeletons on the deploy tab

* Merge CTA moves down when the status is rendered, add offset to prevent that and error branch dropdown on merge tab

* Show progress bar after clicking on Merge CTA as the loading state and generate key button

* after generating the deploy key before clicking on connect close the pop-up and open it again the Remote URL is not visible in the input box

* fixing of conflicting issue

* updated git connection design

* Provide more spacing between the lines

* Learn more does not have a hover state

* Heading Merge Changes should be sentence cased like headings on other tabs

* Button can trigger CTA call when in loading state

* disabled clickable icon on git connect bottom bar

* Git connection tab: on error the window doesn't scroll all the way to the bottom

* updated temp remote url values on action and reducer

* updated ellipsis functions of text

* fix: prune branch flag

* fix: update page level roomId to include branch name

* fix

* fix

* feat: add a separate feature flag for git import

* feat: branch section headers bottom bar branch list

* fixed branch list comments

* fixed merge issue

* fix

* feat: hotkey for commit and push

* remove pull button on git conflict info

* move tempRemoteUrl redux to gitSyncreducer and added messages

* splited git error as individual action

* removed push button from git sync bottom buttons

* feat: section header at the merge dropdown

* added comment of converting ssh to https

* feat: show connected to git badge

* feat: show asterisk when we have uncommitted changes

* fix: upate segment header for dropdown

* t fix: remove redundant success toasts

* removed tempory git repo url from app data

* wrapped tooltip with elipsis text

* fix: rm unused vars

* fix: bottom bar icon updates

* updated dropdown option with ellipsis text

* added new props named "wrappedOption" on dropdown for wrapping ellipsis option

* rename wrappedOption to truncateOption on dropdown component

* updated dropdown option with disabled props of tooltip

* fix: remove remote branches from merge branch dropdown

* reset yarn lock

* reset yarn

* fix: keeping it same as the existing value

* fix: remove branch dropdown border

* fix: show merge success indicator

* feat: init repo limit error modal

* fix: disconnect git wip

* added git user config test

* removed test data

* fix: checkout api

* fix: lint

* chore: pre connection test specs

* added revoking git workflow

* renamed revoke to disconnectGit

* added setting on git sync action over bottom bar

* added analytic on git connection

* added learn more for remote url and init module of temp remote url when select new application

* .

* chore: test learn more ssh url

* Verify the functionality of Read documantation link

* added git connect with onboarding workflow

* Validate the Input Box displayed below Commit to master Text

* updated test module for deploy tab with commit comment and deploy preview

* test of prune branch name

* Validate the error faced when user switches between the branches

* verify the functionality when user click on "+" Icon

* Verify the functionality of serach input box inside the serach dropdown

* Verify the display of the Merge Button

* advanced of disconnect git ui

* added git disconnect modal test case

* updated repo limit error condition

* added learn more link test on git disconnect modal

* for review of repo limit error modal test script.

* fix: issue with intercept

* fixes

* fixes

* add key, misc fixes

* fix

* revert changes

* fix

* fix imports

* Fix import

* Yarn lock update

* fix

* fix imports

* chore: remove timeout for a test run

* Increase timeout for jgit APIs

* chore: try increasing timeout

* try increasing timeout further

* Handle git connect error on the basis of error type

* Add env variable to CI build script

* Fix bad commit for adding env var in workflow

* Refactor

* FAdd env var for local repo path

* fix import

* fix specs

* fix

* fix

* try

* fix

* fix

* fix

* fix

* fix: don't validate error msgs

* fix spec

* improve spec

* chore: rm unused code

* chore: update descriptions

* rm commented out code

* fix

* rm comment

* chore: rm comments

* fix: lint

* chore: update comment

* fix: wait for widget switch transition

* spec updates

* fix

* fix imports

* try waiting for getPagesForViewApp

* fix: rm unused file

* fix: remove spec

* fix: add js collection, comment out repo limit exceeded error since it seems not limited on appsmith instances

* Fix server failure

* chore: correct bootIntercom import and sort lines

Co-authored-by: Rishabh-Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: haojin111 <haojin828@outlook.com>
Co-authored-by: Arpit Mohan <arpit@appsmith.com>
Co-authored-by: Abhijeet <abhijeet@appsmith.com>
Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com>
Co-authored-by: Anagh Hegde <anagh@appsmith.com>
Co-authored-by: f0c1s <anubhav@appsmith.com>
2022-02-25 06:13:16 +00:00
Shrikant Sharat Kandula
fb19d0ef99
Scrolling issue in container and modals for app view (#11424) 2022-02-24 20:49:25 +05:30
akash-codemonk
cb4b9595d1
fix: indicator does not appear while attaching onClick handler during guided tour (#10739) 2022-02-24 18:43:23 +05:30
Tolulope Adetula
588e1356e3 fix: scrolling issue in container and modals for app view 2022-02-24 13:54:37 +01:00
Bhavin K
73a3a2452e
fix: added width cap, updated props to handle size (#11357) 2022-02-24 13:51:45 +05:30
Aswath K
2ad121a092
feat: Keyboard accessible property pane header (#11339) 2022-02-24 12:34:31 +05:30
Paul Li
bd9636f514
fix: left border of Input widget is cut off when icon is set and left aligned (#11257)
-- Remove the CSS rule for border-left to be transparent
2022-02-24 11:30:55 +05:30
Arsalan Yaldram
f719a791e8
Merge pull request #11195 from appsmithorg/reset-widget-option
fix: Add true as the default param to resetWidget function.
2022-02-24 10:33:06 +05:30
akash-codemonk
61a163127d
fix: scroll hides content on the canvas in guided tour (#10735)
- Also datasource structure to be expanded only when user expands it in guided tour
2022-02-24 09:38:43 +05:30
Paul Li
4b80ea27e9
fix: Some .jpg images don't load in the Image Widget (#11247) 2022-02-24 09:07:54 +05:30
Tolulope Adetula
facf6a3d96
fix: date picker uniformity when only Month or year is changed (#11077)
* fix: date picker uniformity

* cypress tests

* fix: Failing date picker test

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-23 15:54:24 -08:00
Tolulope Adetula
27d645955a
fix: long page name text cutting off in preview mode (#11345) 2022-02-23 23:53:49 +00:00
Apeksha Bhosale
db2c638fc4
fix: after JS object delete success move to page url (#11331) 2022-02-23 18:09:41 +00:00
Bhavin K
89bc82b4f5
fix: radio widget example string (#11352) 2022-02-23 17:23:15 +00:00
Preet Sidhu
cc2242de9d
fix: page dragging in Pages editor (#11377) 2022-02-23 22:24:43 +05:30
Arsalan
b34a6c8268 Merge branch 'release' into reset-widget-option 2022-02-23 22:24:00 +05:30
Favour Ohanekwu
d2c96b9727
fix: suppress warnings about the use of expressions where assignments are expected (#11343) 2022-02-23 21:49:44 +05:30
Tolulope Adetula
06eac9387e
fix: make table button transparent when no color is selected (#11348)
* fix: make table button transparent when no color is selected

* fix:  failing tests in Table_widget_add _button_spec
2022-02-23 07:54:46 -08:00
balajisoundar
5dc5cff722
fix: Update date ISO string validations (#11399) 2022-02-23 20:48:58 +05:30
Paul Li
c30f072c84
fix: Input widget onSubmit ends up triggering onTextChange (#11304)
-- Make onSubmitSuccess callback not to trigger additional onTextChange
2022-02-23 20:44:55 +08:00
Arsalan
5b892ec3fa fix: Removed Datasources from Execute Query Action List. 2022-02-23 17:28:50 +05:30
f0c1s
64a9fd451b
chore: remove second scrollbar from git connect modal (#11336) 2022-02-23 15:41:58 +05:30
Paul Li
ff2bcc228a Merge branch 'release' into feat/4182-form-detect-changes 2022-02-23 16:21:48 +08:00
Paul Li
c0f93052de feat: Internal property to detect changes in a form
-- Implement dirty check logic for a form
-- Expose an form property, hasChanges for checking if the user has changed any values in the form
-- Add isDirty derived property for the following widgets: AudioRecorderWidget, CameraWidget, CheckboxGroupWidget, CheckboxWidget, CurrencyInputWidget, DatePickerWidget2, FilePickerWidgetV2, InputWidgetV2, MultiSelectTreeWidget, MultiSelectWidgetV2, PhoneInputWidget, RadioGroupWidget, RichTextEditorWidget, SelectWidget, SingleSelectTreeWidget, SwitchGroupWidget, SwitchWidget
2022-02-23 16:03:51 +08:00
Bhavin K
03dc8da930
fix: updated max character validation (#11333) 2022-02-23 11:53:58 +05:30
Preet Sidhu
91f3e11984
Merge pull request #11323 from appsmithorg/fix-9367_resize_property_pane
fix: Property panel resize on dragging
2022-02-23 11:21:59 +05:30
Bhavin K
e944f1b17c
fix: handled to hide widget in preview mode (#11138)
* fix: handled to hide widget in preview mode

* docs : comment update

* fix: condition updated as required, cypress test added

* fix: simpler condition, types updated
2022-02-23 10:22:04 +05:30
Rishi Kumar Ray
7a97640a07
chore: Update config label in Rest API datasource config page (#11107) 2022-02-23 09:51:50 +05:30
Preet
9adf3cbb66 Merge remote-tracking branch 'origin/release' into fix-9367_resize_property_pane 2022-02-22 22:07:43 +05:30
Ayangade Adeoluwa
be685ef815
Prevent content-type header from changing when switching to raw mode in API pane (#11326)
This commit fixes post body type switcher in API editor. Prior to this PR,
switching the post body to Raw changes the content-type to "text/plain", This
fixes that by preserving the previous content-type when user switches to raw or
none body type. It also gives users the flexibility to use any non supported
content type, while in Raw body mode.
2022-02-22 16:32:43 +05:30
Tolulope Adetula
24293ced76
fix: select widget accept string and object in the defaultOption property (#11082)
* fix: Select widget accept string and object

* fix: JSON object case

* Fix: make Multiselect Defaukt option Array of strings

* fix: Select and Multiselect

* fixes and test cases

* comments

* fix: Select option value

* fix: mutiselect and test case

* fix: failing test

* fix: reset select widget

* fix: PR issues

* fix: Select widget Reset

* fix: failing Test

* fix: test

* fix: tests

* FIX: EVALUATION TESTS

* fix: getting Select Value in form

* fix: Test cases

* fix: add more test cases

Co-authored-by: balajisoundar <balaji@appsmith.com>
2022-02-22 00:43:35 -08:00
Paul Li
42b2dc80e2
fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.) (#11085)
* fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.)

-- Set trimValue prop to false with property controls such as TabControl, MenuItemsControl, ButtonListControl, PrimaryColumnsControl

* fix: Spaces are not allowed on widgets children names (tabs, menus, buttons etc.)

-- Make trimValue property default to false
2022-02-22 12:17:55 +05:30
Preet
4fb3d7169f use clientWidth instead of getBoundingClientRect 2022-02-21 22:11:50 +05:30
albinAppsmith
5022df9192
Open fix: Username and email hardcoded in mobile sidebar (#11300) 2022-02-21 16:45:11 +05:30
Bhavin K
707dd9bb8a
fix: updated css for ISDCode Dropdown in the phone widget so that placeholder does not collapses to the left when disabled (#11196) 2022-02-21 11:12:39 +05:30
arunvjn
d27dd30415
feat: Added use case input box in welcome tour to input custom use caes (#11171) 2022-02-19 11:56:10 +05:30
Bhavin K
9eeb120c77
fix: updated height for page view (#10796) 2022-02-18 19:34:14 +05:30
Apeksha Bhosale
44597c5e57
fix: marking old async functions as async in the backed for settings (#10723) 2022-02-18 19:28:11 +05:30
Apeksha Bhosale
92a8df8f04
fix: push js object after creation (#11123) 2022-02-18 19:27:38 +05:30
Arsalan Yaldram
d12ae7a800
fix: Table Filter pane overflows when Table is at the top of the canvas (#10618)
* Added boundaryParent prop to Propperto prevent table filter pane overflow.

* Review Changes, done.

* Resolved overflow issue with multiple pages.

* Removed hardcoded Top value while dragging.

* Added parentElement as a function parameter.
2022-02-18 12:26:09 +00:00
Arsalan Yaldram
45da98f1dd
Merge pull request #10935 from appsmithorg/fix/10766-rating-inactive-color
fix: Rating Widget inactive-color.
2022-02-18 17:54:44 +05:30
albinAppsmith
9fd6292c32
fix: Appsmith Design System fixes and improvements (#11011)
* * Added index file for Appsmith Design System
* Datasource context menu, changed position of delete

* * page setting icon color fix

* * filepicker image padding added

* * Debug button icon change

* * share modal design changes according to Appsmith Design System

* * Release notes modal - added see more functionality

* * Navbar header arrow fix

* * Padding fixed in share modal

* * Changed share icon in applications page

* * Header height changed to 32px from 34px

* * Removed icontab component index file of ADS

* * Added AppPageLayout cy test in ignore list
2022-02-18 15:21:02 +05:30
Ayangade Adeoluwa
ead4d875fa
feat: add confirmation for Datasource deletion operation (#11180)
* add confirmation for Datasource, refactor other components

* fix failing cypress tests

* fix Mongo_spec failing test
2022-02-18 07:58:36 +01:00
f0c1s
c03ecf2e13
fix: update git connect modal (#11249)
Show notification banner on SSH key generation and regeneration
Remove BETA tag from Git Connection
2022-02-18 12:13:07 +05:30
Confidence Okoghenun
7ebaa577a3
chore: Updates JS editor default text (#10912) 2022-02-18 07:11:12 +05:30
albinAppsmith
39e28f4e1b
feat: Homepage mobile UI (#10255)
* * Added hooks for detecting device
* fixed partial header issues

* * mobile UI completed

* config URL changed

* * bug fix

* * bug fix

* * mobile - on tap of app card launch app

* * conflict fix
* removed context menu from app card

* * homepage cy fix
2022-02-17 22:08:36 +05:30
Favour Ohanekwu
46810e832a
fix: remove dependencies from trigger fields (#11163) 2022-02-17 21:27:23 +05:30
f0c1s
a2e2bf0055
chore: introduce lookup tables inplace of switch (#11228) 2022-02-17 17:49:39 +05:30
Paul Li
12dad5737d
fix: Issues and Enhancements in the camera widget (#10943)
* fix: Issues and Enhancements in the camera widget

-- Fix on an image stretching issue when taking a picture
-- Set background to black
-- Add onImageSave, onVideoSave Actions
-- Rename Camera to Image

* fix: Issues and Enhancements in the camera widget

-- List all device info only when one or more MediaStreams are active

* fix: Issues and Enhancements in the camera widget

-- Always keep camera aspect ratio when resizing

* fix: Issues and Enhancements in the camera widget

-- Add a Cypress test case for onSaveImage property

* Increased wait!

* Camera case failure locator fix

* Camera case locator fix

* Promises restWidget moved to last!

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2022-02-17 20:10:32 +08:00
Paul Li
f3360d814e
fix: Text widget shows a horizontal scroll on center and right alignment (#11189)
-- Set overflow-x to hidden on StyledText
2022-02-17 20:01:15 +08:00
rahulramesha
13a0258c9c
changing reflow threshold to 10/10 from 20/20 (#11210) 2022-02-17 15:07:22 +05:30
f0c1s
5aba318f67
chore: remove pointer cursor from dialog header icons. (#11216) 2022-02-17 12:36:05 +05:30
Hetu Nandu
8599130176
fix: Wait for evaluation before completing resetWidget and storeValue functions (#11178) 2022-02-17 10:01:59 +05:30
Abhinav Jha
938edd5284
chore: Remove old way of adding feature flags (#11213)
* Remove optimizely, as it isn't being used anymore from the frontend codebase

* Remove optimizely references form netlify config, vercel config, index.html, docker script, nginx templates and example .env file
2022-02-16 19:57:58 +05:30
Arsalan Yaldram
8c83cf767b
Merge pull request #10919 from appsmithorg/fix/10780-circular-progress-icon
fix: Add circular progress svg to WidgetIcons.tsx
2022-02-16 17:03:26 +05:30
Daniel
5994e87648
fix: fix spacing for encrypted tag for form control (#11063) 2022-02-16 11:12:00 +00:00
f0c1s
64669f5e45
feat: ssh key regeneration (#11018)
feat/ssh-key-regeneration - implementation

- moved copy icon inside the input box
- added regenerate ssh key function on git connection
- remove learn more and paste text from top
- introduce SSH Key label
- introduce ads/NotificationBanner
- update NotificationBanner integration
- jest tests
- system notification on key regeneration
- use @appsmith for constants/messages
- update imports
- remove optional chaining

Co-authored-by: haojin111 <haojin828@outlook.com>
2022-02-16 10:15:35 +00:00
Arsalan Yaldram
81e79af04f
Merge pull request #10954 from appsmithorg/fix/10697-rating-widget-flickering
fix: rating widgets flickering when value is reduced.
2022-02-16 13:27:21 +05:30
Arsalan
9c414355a2 fix: added true option as default for resetWidget 2022-02-16 11:54:37 +05:30
Ayangade Adeoluwa
b69f85891f
fix: ensure backward compatibility with older Actions. (#11184) 2022-02-16 08:47:13 +05:30
Vicky Bansal
10cb49b2ee
fix: add ellipsis when the page name is longer than width (#10667) 2022-02-16 00:16:37 +05:30
Vicky Bansal
e77ab8b06c
fix: add ellipsis to table search input when blur (#11020) 2022-02-16 00:16:21 +05:30
Aswath K
f610c749f9
feat: Step control keyboard navigation (#11059)
* Make step control keyboard accessible

* Add Jest tests
2022-02-15 17:55:11 +05:30
Arpit Mohan
286864eb3d
feat: Support body in GET API requests (#7127)
* WIP

* Refactoring HTTP Method & Content Type to be objects instead of arrays

TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request

* Almost working implementation for the None type

Currently, the body still gets sent in non-GET requests even if the None tab is selected.

* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM

* WIP: Using enum & const for ts autocomplete

* working implementation for NONE type, apiContentType prop added to API actions

* WIP

* Refactoring HTTP Method & Content Type to be objects instead of arrays

TODO:
1. Set the default content-type for Get request to "None". Currently, it's raw
2. For None content-type, don't send the body field in the API request

* Almost working implementation for the None type

Currently, the body still gets sent in non-GET requests even if the None tab is selected.

* Adding object.freeze to prevent any modifications to HTTP_METHOD_ENUM

* WIP: Using enum & const for ts autocomplete

* working implementation for NONE type, apiContentType prop added to API actions

* adds apiContentType to actionConfiguration.formData object

* Handling apiContentType property in Rest API formData

* change apiContentType when user types content-type value and switches http method

* makes api editor as similar as possible to postman, project postman.

* Correcting the import in ApiEditorConstants

* Resolved all merge conflicts

* replay DSL functtionality

* removes unneccessary files from worker

* Fixes type declarations, naming e.t.c.

* fix server side merge conflicts

* fix client side merge conflicts

* fix failing cypress tests

Co-authored-by: Irongade <adeoluayangade@yahoo.com>
Co-authored-by: Ayangade Adeoluwa <37867493+Irongade@users.noreply.github.com>
2022-02-15 11:13:48 +00:00
Tolulope Adetula
7837b568af
fix: select Widget resize (#11048) 2022-02-14 23:34:53 -08:00
Tolulope Adetula
fd4c99ccf2
fix: dropdown propert control (#11041) 2022-02-14 23:34:17 -08:00
Nidhi
1868675349
feat: Self-signed certificates for REST APIs (#11043)
* feat: Self-signed certificates for REST APIs

* Changed scope for netty dep
2022-02-15 06:54:26 +00:00
Ankita Kinger
0998b441e7
refactor: superadmin settings UI/UX (#11130)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

* css changes for admin settings page and breadcrumb removal

Co-authored-by: Pranav Kanade <pranav@appsmith.com>
2022-02-14 17:25:12 +05:30
Ankita Kinger
c29c2f745e
fix: Comment icon gets hidden behind tabs on Tab widget (#11019)
* fix for z-index issue on comments icon

* css changes

* fixed failing cypress tests
2022-02-12 08:28:13 +05:30
Pranav Kanade
b778b83ac4
refactor: admin settings (#9906)
* refactor admin settings feature

* separated save-restart bar to separate component

* created new CE dir to facilitate code split

* created separate ee dir and exporting everything we have in ce file.

* little mod

* minor fix

* splitting settings types config

* using object literals for category types instead of enums

* CE: support use of component for each category

* minor style fix

* authentication page  UI changes implemented

* github signup doc url added back

* removed comments

* routing updates

* made subcategories listing in left pane optional

* added muted saml to auth listing

* added breadcrumbs and enabled button

* created separate component for auth page and auth config

* added callout and disconnect components

* updated breadcrumbs component

* minor updates to common components

* updated warning callout and added icon

* ce: test cases fixed

* updated test file name

* warning banner callout added on auth page

* updated callout banner for form login

* CE: Split config files

* CE: moved the window declaration in EE file as its dependency will be updated in EE

* CE: Splitting ApiConstants and SocialLogin constants

* CE: split login page

* CE: moved getSocialLoginButtonProps func to EE file as it's dependencies will be updated in EE

* added key icon

* CE: created a factory class to share social auths list

* Minor style fix for social btns

* Updated the third party auth styles

* Small fixes to styling

* ce: splitting forms constants

* breadcrumbs implemented for all pages in admin settings

* Settings breadcrumbs separated

* splitted settings breadcrumbs between ce and ee

* renamed default import

* minor style fix

* added login form config.

* updated login/signup pages to use form login disabled config

* removed common functionality outside

* implemented breadcrumb component from scratch without using blueprint

* removed unwanted code

* Small style update

* updated breadcrumb categories file name and breadcrumb icon

* added cypress tests for admin settings auth page

* added comments

* update locator for upgrade button

* added link for intercom on upgrade button

* removed unnecessary file

* minor style fix

* style fix for auth option cards

* split messages constant

* fixed imports for message constants splitting.

* added message constants

* updated unit test cases

* fixed messages import in cypress index

* fixed messages import again, cypress fails to read re-exported objs.

* added OIDC auth method on authentication page

* updated import statements from ee to @appsmith

* removed dead code

* updated read more link UI

* PR comments fixes

* some UI fixes

* used color and fonts from theme

* fixed some imports

* fixed some imports

* removed warning imports

* updated OIDC logo and auth method desc copies

* css changes

* css changes

* css changes

* updated cypress test for breadcrumb

* moved callout component to ads as calloutv2

* UI changes for form fields

* updated css for spacing between form fields

* added sub-text on auth pages

* added active class for breadcrumb item

* added config for disable signup toggle and fixed UI issues of restart banner

* fixed admin settings page bugs

* assigned true as default state for signup

* fixed messages import statements

* updated code for PR comments related suggestions

* reverted file path change in cypress support

* updated cypress test

* updated cypress test

Co-authored-by: Ankita Kinger <ankita@appsmith.com>
2022-02-11 23:38:46 +05:30
Ayangade Adeoluwa
44ce1d4b5a
fix: fixes apiEditor url overflow, indicates active datasource in datasour… (#10663)
* fixes apiEditor url overflow, indicates active datasource in datasources list

* Adds custom tooltip to datasource url, and optimizes the performance of ApiEditor form

* hide the custom tooltip whenever there is a default datasource config on the page

* Making the implementation more reusable

* fix failing cypress tests and increase delay for tooltip

* A better implementation and also making the logic more reusable

* remove comments

* Fix prettier issues due to merge with release
2022-02-11 12:02:47 +01:00
Ayangade Adeoluwa
c06c8b817e
fixes numbering system for dynamic bindings in evaluated popup text (#11005) 2022-02-11 11:53:50 +01:00
Apeksha Bhosale
980c8cbf57
fix: added new library and reduced function calls for global data (#11001) 2022-02-11 16:22:27 +05:30
balajisoundar
85cc3f3497
feat: Provide option in phone input widget to turn off auto formatting (#10832) 2022-02-11 15:39:38 +05:30
Tolulope Adetula
c992bd5285
feat: add more plugins to rich text editor (#11052) 2022-02-11 13:52:35 +05:30
arunvjn
9e0c0a1598
Sorted actions in explorer in alphabetical order to give them a predictable position (#10777) 2022-02-11 07:30:30 +00:00
Aswath K
fb83b0fbc6
feat: Make Button Tab keyboard accessible (#10873) 2022-02-11 00:30:20 +05:30
Favour Ohanekwu
a1a774f7fe
fix: js editor not showing falsy values 🐞 (#10946) 2022-02-10 23:33:12 +05:30
Favour Ohanekwu
1ed7e9086c
keep linting in trigger field in sync with the state of the datatree (#10941) 2022-02-10 23:32:16 +05:30
Favour Ohanekwu
223be6c057
fix lint tooltip getting clipped (#10899) 2022-02-10 18:40:36 +01:00
balajisoundar
e67474a4f3
fix: Input, Phone and Currency input widgets valid property validations (#10966)
- When the user removes an expression from the validation property of
  input widget, its value becomes `""`. And in boolean validation
  function we treat this empty string as false. so Input widget
  ends up with isValid false and we show an error border around the
  Input. so we are setting a default value true, so when there is
  no expression it evaluates to true.
2022-02-10 17:06:18 +05:30
Aswath K
9597c82f7c
feat: keyboard accessible multi-select dropdown, action selector and text input (#10622)
* feat: Add keyboard navigation to multiselect dropdown (#10397)

* feat: Make Action Selector keyboard accessible (#10005)

* feat: keyboard accessible text / code input (#10641)

* {Space} as an alternate option to make code editor editable
2022-02-10 16:42:44 +05:30
Pawan Kumar
d4eeff8fcc
fix: Header tags are not styled correctly in the Text widget (#10949)
* fix text widget styles

* add font weight in headings

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local>
2022-02-10 12:25:33 +05:30
balajisoundar
8f383ca8ea
fix: Phone Input and Input widget not getting reset on submit (#10860) 2022-02-09 17:33:10 +05:30
Aman Agarwal
9894a6522c
feat: added datasource icon on left of entity name, revamped name editor (#10821)
* feat: added datasource icon on left of entity name, revamped name editor

* fix: updated the hardcoded message strings to use message.ts

* fix: types of variables
2022-02-09 17:11:47 +05:30
Paul Li
ce42dcb00b
fix: Map pin does not center when location is changed and centering option is turned on (#10296)
* fix: Map pin does not center when location is changed and centering option is turned on

-- Update center meta property when defaultMarkers or mapCenter properties were changed

* fix: Map pin does not center when location is changed and centering option is turned on

-- Force the last marker to be centered
2022-02-09 18:39:07 +08:00
balajisoundar
fab552cafa
chore: Extend the list of widgets that cannot be used inside the List… (#10928) 2022-02-09 12:45:10 +05:30
Ankita Kinger
81760a94fc
Merge pull request #10942 from appsmithorg/hotfix/disable-signup-config
fix: Added disable signup form config
2022-02-09 12:35:16 +05:30
Vicky Bansal
e4e7c59bc2
fix: disable closing dropdown on space (#10945) 2022-02-09 12:32:57 +05:30
Sumit Kumar
aa2290405d
fix: fix refresh token flow in REST API OAuth (#10875)
Co-authored-by: Segun Daniel Oluwadare <dodanieloluwadare@gmail.com>
2022-02-09 09:38:58 +05:30
arunvjn
be1b5a5db3
Re-focus widgets search bar when the search text is cleared (#10763) 2022-02-09 04:00:56 +00:00
haojin111
0288f79b70
fix: added missed analytic events for git sync (#10953) 2022-02-08 21:46:16 +05:30
Abhinav Jha
9d21ccf52f
fix: Remove references of messages.ts in worker files (#11004) 2022-02-08 20:53:25 +05:30
Tolulope Adetula
453974b18e
fix: Multiselection in table widget (#10838)
* fix: Multiselection in table widget

* fix: add test cases
2022-02-08 06:41:25 -08:00
Ayangade Adeoluwa
21018c640f
fix: fixes uqi component issues (#10829)
* fixes uqi component issues

* fix dropdown container width issue
2022-02-08 12:51:41 +01:00
Abhinav Jha
aee5816a54
fix: limit validation errors in debugger (#10886)
* Add a limit to the number of error messages sent from validations to be rendered in the debugger
2022-02-08 17:13:25 +05:30
Ayangade Adeoluwa
da655b5748
fix margin top issues with checkbox form controls (#10930) 2022-02-08 11:29:17 +00:00
Arsalan
048d8ac349 fix: Rating widget flicker, when value is changed. 2022-02-08 12:52:43 +05:30
Ankita Kinger
1c8d804d88 added config for signup disabling 2022-02-07 20:48:44 +05:30
Arsalan
903b2cec4d Added grey as the default inactive color. 2022-02-07 17:28:11 +05:30
Arsalan
c0b290d0b6 Add circular progress svg to WidgetIcons.tsx 2022-02-07 11:22:55 +05:30
akash-codemonk
dbf8568c7b
fix: hide the image column in guided tour table (#10709) 2022-02-07 10:06:33 +05:30
balajisoundar
c9f65d080a
fix: skip bad table migration thats breaking computed columns we di… (#10897) 2022-02-04 23:07:22 +05:30