53 Commits

Author	SHA1	Message	Date
Anand Srinivasan	be6a96e760	chore: ee clean up (#19475) ... Related to #15538 To enable adding a new action only for EE. Refactored `ActionTriggerType` enum to a union type. So we can extend this with a new action in EE repo. Made sure type discrimination is handled in `ActionExecutionSaga` properly as before. --- - Introduced `ActionTriggerKeys` union type which can be used for type checking the values. - Refactored `ActionDescription` types to accommodate usage of the union type instead of enum. - exported required types for usage in EE repo. --- strings and payload are type checked as follows.   Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2023-01-06 17:32:08 +05:30
Rishabh Rathod	6b751d914e	fix: improve error message and performance in JS functions (#19137) ... ## Description - Added logic to replace async function undefined error with "{{actionName}} cannot be used in this field". - This change improves performance for - ParseJSActions - Triggers execution - Each Appsmith framework action execution. - This change adds all platform functions to evalContext permanently. Fixes #12179 Fixes #13273 Internal discussion for error message :- https://theappsmith.slack.com/archives/C02K0SZQ7V3/p1667457021297869?thread_ts=1667385039.225229&cid=C02K0SZQ7V3 ## Type of change - Bug fix (non-breaking change which fixes an issue) - Performance improvement ## How Has This Been Tested? - Manual - Jest - Cypress ### Test Plan - [ ] https://github.com/appsmithorg/TestSmith/issues/2086 ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2022-12-23 15:34:39 +05:30
Anand Srinivasan	db38a64e71	chore: update imports for code split (#19085) ... * move actionTriggers.ts * update imports Explorer/helpers.tsx * update imports EntityDefinitions.ts * update imports Evaluation/Actions.ts * update imports for ActionExecutionSagas * missed worker types * missed imports * update imports for dataTreeUtils * missed imports Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2022-12-22 12:04:28 +05:30