Commit Graph

1499 Commits

Author SHA1 Message Date
Rajat Agrawal
ba5affb3cd
chore: print workflow information (#24731)
This PR prints github event when ok-to-test command is run. This is
needed for debugging optimization changes to skip server tests if there
are no server side changes.
2023-06-22 12:10:10 +05:30
Rajat Agrawal
dd08e096c5
Revert "chore: Skip tests in server build if no changes in server files for ok-to-test command" (#24721)
Reverts appsmithorg/appsmith#24616
2023-06-22 09:07:28 +05:30
Aishwarya-U-R
a8345c1ae4
test: Cypress | Flaky fixes (#24719)
## Description
- This PR fixes the below flaky tests:
       - cy.visit timeout handled - response timeout increased
- ElasticSearch container - taking time to start in EE run - increasing
timeout
       
#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes are reviewed
2023-06-22 01:03:36 +05:30
Aishwarya-U-R
91325d258e
test: Cypress | Moving Non-TED containers within Tests (#24709)
## Description
- This PR improves the container start for 
- Arango DB - Container started moved to test case level
- MsSql - Delete container added
- Elastic - Container started moved to test case level
- Starts container, runs tests, stops containers & deletes it too 🤞🏻
- Removed containers start from yml file
- Flaky fixes below:
         - Apps/ReconnectDatasource_spec.js
         - Improved FillPostgresDSForm()

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after all changes are reviewed
2023-06-21 23:07:21 +05:30
Saroj
11a18d1d08
ci: Remove un-necessary artifact uploads from ci-test.yml (#24717)
## Description
- Remove un-necessary artifact uploads from ci-test.yml
- Updated steps to use new format for $GITHUB_OUTPUT
#### Type of change
- Workflow file
## Testing
>
#### How Has This Been Tested?
- Workflow run
2023-06-21 19:33:58 +05:30
Rajat Agrawal
7ceaa9a0c9
chore: Skip tests in server build if no changes in server files for ok-to-test command (#24616)
Fixes #24700

These changes will allow the CI to skip tests if there are no changes in
server folder when using ok-to-test command. This will save CI minutes
2023-06-21 14:50:28 +05:30
Aishwarya-U-R
2d8bc2bc2d
test: Cypress | Flaky fixes (#24673)
## Description
- This pR fixes few of flaky tests as part of CI Stabilization work:
    - ApiTests/API_Unique_name_spec.js - Loginviaapi() - added timeout
- Datasources/MsSQL_Basic_Spec.ts - Starting container at test level
since lot of CI recent failures in reg this until this is moved to TED

#### Type of change
- Script fixes (non-breaking change which fixes an issue)

## Testing
>#### How Has This Been Tested?
- [x] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-06-21 00:54:18 +05:30
Aishwarya-U-R
6651475313
test: Cypress | Flaky fixes (#24593)
## Description
- This PR fixes below flaky tests:
  - AppNavigation/NavigationSettings_spec.js
  - Autocomplete/JS_AC_spec.ts - 6th case
  - Analytics_spec.js - increased restart time
- Apps/ReconnectDatasource_spec.js - Increasing timeout for better pass
rate
  - TableV2/Inline_editing_spec.js - trial fix
  - OneClickBinding/mongoDB_spec.ts
  - OneClickBinding/postgres_spec.ts
  - ScrollIntoView() fixes
  - /OtherUIFeatures/ViewMode_spec.js - flaky fix
  - TableV2/TableV2_PropertyPane_spec.js
  - OtherUIFeatures/UpdateApplication_spec.js
  - ListV2/Childwigets/List_FilePicker_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-06-20 14:28:06 +05:30
Aishwarya-U-R
9e8658d2a3
ci: Commit Message syntax fix (#24591)
## Description
- This PR fixes the right syntax to pick up the PR title for push
workflows
2023-06-19 00:12:15 +05:30
Aishwarya-U-R
d49df9ca5b
ci: PR title text format update (#24589)
## Description
- This PR fixes the issue in getting in PR title for push workflows
2023-06-18 23:17:49 +05:30
Aishwarya-U-R
80dadf71dd
test: Cypress | Flaky fix (#24587)
## Description
- This PR fixes the below flaky points in Stabilizing CI:
- MobileResponsiveTests/AutoDimension_1_spec.ts

#### Type of change
- Script fix (non-breaking change which fixes an issue)
 
## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
>
>

## Checklist:
#### QA activity:
- [x] Added `Test Plan Approved` label after changes were reviewed
2023-06-18 22:21:30 +05:30
Aishwarya-U-R
dc1f7220ff
ci: EVENT_COMMITS message update (#24588)
## Description
- This PR take only EVENT_COMMITS message to display in title
2023-06-18 22:18:45 +05:30
Aishwarya-U-R
2667e0b8f0
ci: Set Pull Request Title update (#24585)
## Description
- This PR picks up the PR title from github.event.commits info
2023-06-18 17:01:29 +05:30
Aishwarya-U-R
a1be13ad51
ci: Set Pull Request Title update (#24582)
## Description
- This PR updates the Set Pull Request Title to view thew event details
2023-06-18 15:14:28 +05:30
Aishwarya-U-R
084e28ab21
test: Cypress | Flaky fixes (#24581)
## Description
- This PR fixes the below flaky:
- ReconnectDatasource_spec.js
- ConversionAlgorithm_AutoLayout_Validation_BasicSpec.js
- Improves CreateApplication with intercept assert
- Changes all agHelper.AssertN.wStatus to assertHelper() method

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-06-18 10:25:16 +05:30
Aishwarya-U-R
5a0ad6d529
ci: COMMIT_INFO_MESSAGE update (#24580)
## Description
- This PR updates the Push wokflow message
2023-06-17 23:35:09 +05:30
Aishwarya-U-R
03ac20d702
ci: Set Pull Request Title syntax fix (#24579)
## Description
- This PR fixes the syntax for  Set Pull Request Title
2023-06-17 22:05:11 +05:30
Aishwarya-U-R
5ba39f4b56
ci: Set Commit Message update (#24578)
## Description
- This PR attempts to set the Commit Message during oktotest and re-runs
on PR's & push workflows
2023-06-17 21:22:27 +05:30
Aishwarya-U-R
93afc46380
test: Cypress | ThemingTests fixes (#24577)
## Description
- This PR fixes flaky ThemingTests
2023-06-17 20:16:39 +05:30
Aishwarya-U-R
0bf8e17e74
test: Cypress | Flaky fixes (#24576)
## Description
- This PR fixes below flaky tests:
- GitBugs_Spec (welcom screen load)
- Theme_FormWidget_spec.js (multiple flaky places)
- Logs1_spec.js

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?

- [x] Cypress local

## Checklist:
#### QA activity:
- [x] Added `Test Plan Approved` label after changes tests were reviewed
2023-06-17 15:55:37 +05:30
Aishwarya-U-R
6b8c8e387f
ci: Comit Message update (#24575)
## Description
- This message updates the COMMIT_INFO_MESSAGE_FINAL
2023-06-17 14:50:57 +05:30
Aishwarya-U-R
db5974f5c1
ci: Fix Syntax in ci-test.yml (#24574)
## Description
- This PR fixes the syntax error in ci-test.yml
2023-06-17 13:58:37 +05:30
Aishwarya-U-R
2bfd4091ab
test: Cypress | Flaky fixes (#24572)
## Description
- This PR fixes Cypress flaky tests as mentioned below:
- JS_AC_spec.ts
- Admin_settings.js
- Theme_FormWidget_spec.js
- Scrolling_Spec.ts
- JSOnLoad2_Spec.ts
- Pick up the branch name from PR number

#### Type of change
- Script update (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs
>
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress changes were
reviewed
2023-06-17 13:53:03 +05:30
Aishwarya-U-R
e24a178158
ci: Set Branch name (#24571)
## Description
- This PR tries to set the proper branch name of a PR
2023-06-17 11:54:32 +05:30
Aishwarya-U-R
3fcc0d9c49
ci: Set Commit Message (#24570)
## Description
- This PR includes the commit id in Cypress dashboard title
2023-06-17 11:43:44 +05:30
Aishwarya-U-R
ce669e242c
ci: Set Commit Message update (#24568)
## Description
 - This PR sets the commit message for Cypress dashboard display
2023-06-17 01:07:28 +05:30
Aishwarya-U-R
959fdce6ac
test: Cypress | Flaky fixes (#24508)
## Description
- This PR improves the sign up method to work even if telemetry related
details are not asked at start
- Also alters the Commit message based on the repository/workflow or
push runs
 - Improves DragDropWidgetNVerify()
 - Fixes flaky TableV2/Inline_editing_spec.js spec with TS methods
 - Improved EditTableCell()
 - Skipping deleting apps during local runs for debugging purpose
 - Fixes PropertyPane_Search_spec.ts
- Fixed ever flaky AppNavigationWithMultiplePages_spec,
AppNavigationWithAutoLayout_spec

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?

- [X] Cypress CI runs
>
>

## Checklist:
#### QA activity:
- [ ] Added `Test Plan Approved` label after changes were reviewed
2023-06-17 00:10:10 +05:30
Nikhil Nandagopal
f126f67010 Updated Label Config 2023-06-16 14:06:16 +05:30
Nikhil Nandagopal
6c4a334f19 Updated Label Config 2023-06-16 14:05:57 +05:30
Nikhil Nandagopal
51c0ccc18a Updated Label Config 2023-06-16 14:05:32 +05:30
Nikhil Nandagopal
13799becf6 Updated Label Config 2023-06-16 14:04:51 +05:30
Nikhil Nandagopal
974c6603df Updated Label Config 2023-06-16 14:04:20 +05:30
Nikhil Nandagopal
1d5143cfef Updated Label Config 2023-06-16 14:03:58 +05:30
Nikhil Nandagopal
4ad011d902 Updated Label Config 2023-06-16 14:03:42 +05:30
Nikhil Nandagopal
ea0fabc9d0 Updated Label Config 2023-06-16 14:03:25 +05:30
Nikhil Nandagopal
f2b4af852e Updated Label Config 2023-06-16 14:03:15 +05:30
Nikhil Nandagopal
bd893f01bd Updated Label Config 2023-06-16 12:39:53 +05:30
Nikhil Nandagopal
1a0437775a Updated Label Config 2023-06-16 12:39:04 +05:30
Valera Melnikov
f25eb88754
chore: separation of client build steps (#24506)
## Description
Separation to different steps of running lint, prettier, and jest unit
tests

#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-06-16 09:03:56 +03:00
Aishwarya-U-R
d7b2bad974
test: Cypress | Cy 12 upgrade + Flaky fixes (#23852)
## Description
- This PR upgrades cypress from 11.2 to 12.13.0 which fixes the random
browser crash issue in CI runs
 - ValidateNetworkStatus() updates to validate the n/w responses
 - cy.route() to cy.intercept()
 - Converting dataSources.json to HostPort.ts
 - Api responses read - updating to right Cy12 supported format
- js inconsistent testJsontext to TS `EnterJSContext` in few failing
specs
 - CI - higher resolution trials
- Improves _.agHelper.RefreshPage() - fixing Error: Socket closed before
finished writing response
 - AssertDocumentReady() created
 - within(()) & .children() - handled for Cy12
- Improved DeployApp(), NavigateBacktoEditor(), RefreshPage(), AddDsl()
methods
- js inconsistent goToEditFromPublish to TS `NavigateBacktoEditor` in
all specs
- js inconsistent PublishtheApp to TS `_.agHelper.DeployApp` in all
specs
- Convert /DynamicHeight/Text_Widget_spec.js to TS with all supporting
TS helpers
 - ToggleJSMode()
 - COMMIT_INFO_MESSAGE improved
 - Remove tooltip on the Application Name after rename
- js inconsistent cy.addDsl(dsl); to TS helper `_.agHelper.AddDsl(val);`
 - ++++ Much more improvements....

#### Type of change
- Script fixes

## Testing
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed

---------

Co-authored-by: Vijetha-Kaja <vijetha@appsmith.com>
2023-06-15 18:51:11 +05:30
albinAppsmith
eed20a1a84
fix: search input autofocus issue in entity explorer add query/js menu (#24387)
## Description

This PR fixes,
1. Search component not getting focus on opening create new query or JS
menu in entity explorer.
2. Deleted workflow for making design system pod members as reviewers.
3. Fixed text alignment in datasource page.


#### PR fixes following issue(s)
Fixes #24088, #23516

#### Media


https://github.com/appsmithorg/appsmith/assets/87797149/0c481e1d-3953-4dbd-8154-45a16518262b


https://github.com/appsmithorg/appsmith/assets/87797149/a913fdd2-f2c3-40d8-8a57-2fe9d8b1eac6


#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-06-15 11:00:58 +05:30
Nikhil Nandagopal
47f0a9247d Updated Label Config 2023-06-14 11:55:01 +05:30
ramsaptami
98351e4b2a
Update pull_request_template.md (#24403)
Updated broken links for QA
2023-06-13 14:18:42 +05:30
Nikhil Nandagopal
5aab1bffa3 Updated Label Config 2023-06-13 11:00:50 +05:30
Nikhil Nandagopal
32d5981786 Updated Label Config 2023-06-13 10:59:55 +05:30
Nikhil Nandagopal
c0550aabf0 Updated Label Config 2023-06-13 10:59:38 +05:30
Nikhil Nandagopal
27b6729077 Updated Label Config 2023-06-09 10:59:11 +05:30
Nikhil Nandagopal
0e0d19b195 Updated Label Config 2023-06-08 13:41:25 +05:30
Nikhil Nandagopal
d5d4006872 Updated Label Config 2023-06-08 13:40:03 +05:30
Nikhil Nandagopal
6b605c03ef Updated Label Config 2023-06-08 13:39:49 +05:30