Commit Graph

45 Commits

Author SHA1 Message Date
Goutham Pratapa
bde2554782
refactor: enhance deploy_preview.sh for idempotent Helm repo addition… (#41043)
… and plugin management

### Changes Made
- Updated Helm repo addition to be idempotent, preventing errors if the
repo is already added.
- Added logic to check for the existence of the mapkubeapis plugin
before attempting installation, improving script robustness.
- Enhanced error handling for optional commands to ensure the deployment
process continues smoothly even if certain steps fail.

These improvements streamline the deployment process and enhance the
reliability of the script.

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-06-25 19:22:07 +05:30
Goutham Pratapa
3bac05feeb
refactor: enhance deploy_preview.sh script for improved AWS configura… (#41042)
…tion

### Changes Made
- Updated the script to set strict error handling with `set -euo
pipefail`.
- Streamlined AWS CLI configuration by creating the `~/.aws/config` file
directly.
- Removed deprecated `dp-node-affinity-values.yaml` file and integrated
node affinity and tolerations directly into the Helm chart deployment
command.
- Improved pod name retrieval and added optional cleanup logic for
better resource management during deployment.

These changes enhance the reliability and maintainability of the
deployment process.

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-06-25 19:08:25 +05:30
Goutham Pratapa
c921a3c37d
chore: fix syntax error in_docker variable (#41041)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Tests have not run on the HEAD
48aa44719e39cd7999251222edd7a594ab2e612f yet
> <hr>Wed, 25 Jun 2025 13:11:28 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Corrected formatting and quoting issues in the deployment script to
ensure proper environment variable expansion and configuration output.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-06-25 18:43:49 +05:30
Goutham Pratapa
7d75f3c5b3
Update deploy_preview.sh (#41040)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-06-25 18:27:39 +05:30
Goutham Pratapa
48a1bff59e
chore: remove AWS_ROLE_ARN from deployment workflow and update deploy… (#41039)
… script for node affinity

### Changes Made
- Removed `AWS_ROLE_ARN` from the environment variables in the GitHub
Actions workflow for deploying the Helm chart.
- Cleaned up the `deploy_preview.sh` script by removing commented-out
code related to role assumption.
- Added a new `dp-node-affinity-values.yaml` file to define node
affinity and tolerations for deployment.

These changes streamline the deployment process and enhance the
configuration for node scheduling.

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-06-25 18:21:38 +05:30
Goutham Pratapa
5f1dbb3181
chore: update dp to use specifc userpermission than assuming roles (#41038)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2025-06-25 18:03:42 +05:30
Goutham Pratapa
0c0648ed5c
fix: update cluster name in deploy_preview script and adjust kubeconf… (#40981)
…ig command

### 📝 Summary
This commit updates the cluster name in the `deploy_preview.sh` script
from `uat-cluster` to `uatx-cluster` and modifies the `aws eks
update-kubeconfig` command to remove the profile option, ensuring
compatibility with the current AWS configuration.

### 🎨 Changes Made
- **Cluster Name Update**: Changed `export cluster_name=uat-cluster` to
`export cluster_name=uatx-cluster`.
- **Kubeconfig Command Adjustment**: Removed the `--profile eksci`
option from the `aws eks update-kubeconfig` command for streamlined
execution.

No user-facing changes were made, and the script remains functional for
deployment tasks.

## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
	- Updated the AWS EKS cluster name used in deployment processes.
- Modified deployment script to use default AWS credentials for cluster
configuration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-06-25 17:22:25 +05:30
Goutham Pratapa
41160a26f6
fix: enable ai related features in dps (#39062)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated the deployment process to ensure a key configuration parameter
is handled correctly during application setup.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-06 13:57:51 +05:30
Shrikant Sharat Kandula
35b487a2b8
fix: Env for disabling Keycloak is set incorrect (#39052)
## Description

This env variable value isn't doing what it looks like it should, that
is, to disable Keycloak. It's value is showing up as `"1"` and `1` and
so Keycloak is not being disabled.


![shot-2025-02-06-05-44-14](https://github.com/user-attachments/assets/7e782db3-a605-4c18-91fe-b4ef4f98a23d)

But now since we _want_ embedded Keycloak on DPs, we're "fixing" this by
removing this env variable to avoid confusion later.

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Modified the deployment configuration to remove an override that
previously disabled the built-in authentication service. As a result,
the integrated authentication system now activates by default, offering
a more streamlined user management experience. Users deploying the
solution may notice this service is enabled unless configured otherwise.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2025-02-06 11:22:43 +05:30
Goutham Pratapa
c55b36805d
fix: applicationconfig env variables (#38928) 2025-01-30 16:56:11 +05:30
Goutham Pratapa
f8e7368a63
chore: add AI related env variables to dps (#38927) 2025-01-30 16:42:59 +05:30
Goutham Pratapa
8cd827754f
chore: deprecate ce helm charts and publish ee helm charts (#37794)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Enhanced support for PostgreSQL and OpenID Connect (OIDC)
authentication in the Helm chart.
- Introduced a new template for managing external secrets and a
dedicated service for metrics.
- Added Horizontal Pod Autoscaler (HPA) and Pod Disruption Budget (PDB)
configurations.
- New configuration options for custom Certificate Authority (CA)
certificates.

- **Improvements**
- Updated application version and dependencies for better organization
and readability.
- Expanded configuration options for Redis, MongoDB, and PostgreSQL,
allowing for improved customization.
	- Enhanced deployment configuration with dynamic scaling capabilities.

- **Bug Fixes**
- Improved error handling for configuration misalignments to prevent
runtime issues.

- **Documentation**
- Updated README and values.yaml to reflect new configuration parameters
and options.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- This is an auto-generated comment: Cypress test results  -->
> [!WARNING]
> Tests have not run on the HEAD
0e76b6af34501ed646ea840af22786b33426c9fe yet
> <hr>Tue, 31 Dec 2024 12:31:29 UTC
<!-- end of auto-generated comment: Cypress test results  -->
2024-12-31 18:01:48 +05:30
Goutham Pratapa
074233a6fd
fix failing dps (#34625)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2024-07-02 12:36:40 +05:30
Shrikant Sharat Kandula
50150f79e2
ci: Use the newer DB URL 2024-07-01 21:36:43 +05:30
Shrikant Sharat Kandula
dc99eb1ac4
ci: Use latest version of helm chart for DPs (#34608)
If we don't specify a version with `--version`, the `help upgrade`
command takes the latest version. [Ref
documentation](https://helm.sh/docs/helm/helm_upgrade/).



![shot-2024-07-01-09-51-35](https://github.com/appsmithorg/appsmith/assets/120119/4d916c41-5b47-495a-bf06-cdd4d5205484)
2024-07-01 15:26:02 +05:30
Shrikant Sharat Kandula
ff44b4f60f
chore: Fix quoting in deploy_preview.sh (#34592)
**/test sanity**



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9716093497>
> Commit: f2381c9e21f3a2ab89a0de63375bbe58dc1fe726
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9716093497&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated deployment script to improve environment variable handling and
AWS configuration for preview environments.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-07-01 15:06:56 +05:30
Goutham Pratapa
230c225d7e
fix: failing dp builder (#34247)
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
2024-06-14 13:00:54 +05:30
Goutham Pratapa
d53fdc7801
fix: update dp builder (#34203)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated deployment script to use the latest Helm chart version
(3.1.1).
- Changed database URI environment variable for better clarity and
consistency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2024-06-13 16:07:07 +05:30
Goutham Pratapa
8ed80df3eb
Update deploy_preview.sh (#28872) 2023-11-15 14:41:07 +05:30
Goutham Pratapa
2e74e5a78b
adjust resource limits for dps (#27434) 2023-09-20 13:38:09 +05:30
Goutham Pratapa
e3c04ccbeb
install helm plugin to map deprecated K8s APIs (#27423) 2023-09-19 11:57:44 +05:30
Goutham Pratapa
b7a7b15173
add helm plugin to fix deprecated apis (#27419) 2023-09-19 10:46:11 +05:30
Goutham Pratapa
3a69f8e77c
bump helm chart version (#27196)
Depends: [2304](https://github.com/appsmithorg/appsmith-ee/pull/2304)
2023-09-18 14:43:48 +05:30
Goutham Pratapa
6250411d1e
update scripts to deploy dps with EFS (#26993)
Fixes: [322](https://github.com/appsmithorg/cloud-deployment/issues/322)
2023-09-11 16:24:17 +05:30
Shrikant Sharat Kandula
d88c4b9c8f
ci: Use default CS URL for DPs (#25938)
For DP images, this now defaults to release-cs, so we don't need to
explicitly set this anymore.

This can be confirmed by running the following:

```
image=appsmith/appsmith-dp:ce-25909
docker pull "$image"
docker image inspect "$image" --format '{{join .Config.Env "\n"}}' | grep CLOUD_SERV
```
2023-08-16 17:29:10 +05:30
Goutham Pratapa
bc24d03dbd
Revert "update: migrate dp from sts to deployments (#25615)" (#25996)
This reverts commit 6762d2ce90.
2023-08-03 23:40:06 +05:30
Goutham Pratapa
4ea8c95d9a
fix: dp deployments (#25992) 2023-08-03 20:57:47 +05:30
Goutham Pratapa
cf6d9a6e93
fix: failing deploy-preview job (#25990) 2023-08-03 20:23:22 +05:30
Goutham Pratapa
f9efcd29e0
update: dp with deployments style (#25988) 2023-08-03 19:56:23 +05:30
Goutham Pratapa
d4e7fd7bab
fix: failing deploy-preview (#25986) 2023-08-03 19:29:24 +05:30
Goutham Pratapa
6762d2ce90
update: migrate dp from sts to deployments (#25615) 2023-08-03 19:02:17 +05:30
Goutham Pratapa
160aa162ea
chore: bump helm chart version (#24357)
Completes: [24356](https://github.com/appsmithorg/appsmith/issues/24356)
2023-06-20 10:53:45 +05:30
Goutham Pratapa
a3cab20ac3
chore: decrease pvc volume to enable more dps (#24339) 2023-06-12 09:51:32 +05:30
Goutham Pratapa
bdeb9176c2
add recreate option in helm upgrade 2023-04-21 17:03:56 +05:30
Goutham Pratapa
9b37810c7b
ci: add recreate option for dps (#22091)
fixes: [248](https://github.com/appsmithorg/cloud-deployment/issues/248)


https://github.com/appsmithorg/appsmith-ci/pull/14#issuecomment-1504569726
This doesnt delete the existing stacks 


https://github.com/appsmithorg/appsmith-ci/pull/14#issuecomment-1504842238
this deletes the stack, database in mongo and therefore creating a
complete new stack
2023-04-14 16:27:17 +05:30
Goutham Pratapa
898d0010f3
chore: add sentry variables to DP (#21901) 2023-04-14 10:47:45 +05:30
Goutham Pratapa
17fe14628f
ci: add release-portal url for deploy-previews (#21140)
Add env variable APPSMITH_CLOUD_SERVICES_BASE_URL to make sure the
licence_key generation requests hit only release-cs i.e
"https://release-cs.appsmith.com/" and not production-cs
"https://cs.appsmith.com/"
2023-03-21 10:54:54 +05:30
Goutham Pratapa
47750db727
ci: add comments for vercel-deploy-preview (#21349)
**/build-deploy-preview env=release**

![Screenshot 2023-03-14 at 9 49 44
AM](https://user-images.githubusercontent.com/15846947/224892349-588b3460-0b8d-4937-9b94-4013d03275a0.png)

---------

Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com>
2023-03-16 17:32:32 +05:30
Goutham Pratapa
1a7c90f6a5
Update deploy_preview.sh 2023-02-23 10:56:36 +05:30
Goutham Pratapa
0cf9a9eef1
Update imagePullPolicy for deploy-previews 2023-02-13 09:00:10 +05:30
Goutham Pratapa
afc5c94cf7
fix: failing ce deploy previews (#20204) 2023-01-30 13:37:55 +05:30
Goutham Pratapa
61aa67d5b3
fix failing deploy_preview.sh script 2023-01-30 11:59:14 +05:30
Goutham Pratapa
a8689792dc
ci: make upgrades easy to deploy-previews (#20198)
Make upgrades easy for deploy previews.
2023-01-30 11:49:22 +05:30
Goutham Pratapa
506b0230d5
ci: add cosmetic changes to deploy-preview ci (#20131) 2023-01-27 11:31:55 +05:30
Goutham Pratapa
5ad64598ac
chore: Deploy preview of a PR (#19988)
Successful-run: https://github.com/appsmithorg/appsmith-ci/actions/runs/3986060223

Example: https://github.com/appsmithorg/appsmith-ci/pull/2

### How to trigger the workflow

[Reference](https://github.com/appsmithorg/appsmith-ci/pull/2#issuecomment-1400174700) 

go ahead and comment:

```
/build-deploy-preview
```
If the commit is fine then you should another comment from github-actions like below
```
Tests running at: https://github.com/appsmithorg/appsmith-ci/actions/runs/xxxxxx
Workflow: On demand build Image and deploy Deploy-Preview.
PR: #.
URL: #ce.appsmith.com
```
2023-01-26 14:05:11 +05:30