Commit Graph

224 Commits

Author SHA1 Message Date
balajisoundar
727d30ad92
feat: Integrate one click binding to sourceData of select and multi select widget (#25750)
## Description
We have changed the property control of sourceData of select and multi
select widget to dropdowns which has one click-binding items.

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/24780

#### Type of change

- New feature (non-breaking change which adds functionality)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Cypress
>
>
#### Test Plan
>(https://github.com/appsmithorg/TestSmith/issues/2472)
>
>
#### Issues raised during DP testing
>
(https://github.com/appsmithorg/appsmith/pull/25750#issuecomment-1665077044)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [x] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [x] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-10 10:51:19 +05:30
Ayangade Adeoluwa
888efe50cc
fix: Fix uqi query switching issue (#26167) 2023-08-09 16:02:13 +05:30
Druthi Polisetty
96d7903b79
feat: Improve discovery of callbacks (#25788)
## Description
- Add a clear discoverable signifier to add an action when an event
handler has no actions
- Improve discovery of callbacks

#### PR fixes following issue(s)
Fixes #25566 & #25565 


#### Type of change
- New feature (non-breaking change which adds functionality)

>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: arunvjn <arun@appsmith.com>
2023-08-09 15:23:28 +05:30
Druthi Polisetty
50cd13e362
fix: Retain last selected tab on debugger and user selected filter condition (#25538)
## Description
Retains last selected tab on debugger and user selected filter condition

#### PR fixes following issue(s)
Fixes #23108

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

>
>
## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [x] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [x] We had an implementation alignment call with stakeholders post QA
Round 2
- [x] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
Co-authored-by: arunvjn <arun@appsmith.com>
2023-08-09 15:19:32 +05:30
Aishwarya-U-R
0b669eaa02
test: Cypress | CI Stabilize (#26184)
## Description
- AssertElementVisible() revert due to CI failures
- Fixes dragdrop coordinates in
Debugger/Widget_property_navigation_spec.ts
- Fixes S3 ACCESS_KEY in ConnectionErrors_Sepc.ts
- /LoginTests/LoginFailure_spec.js - another trial fix
- Remove unused method AssertElementNotVisible

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress local runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-08-08 23:40:22 +05:30
NandanAnantharamu
d61d1e929f
test: cypress -updated test for Tablev2 (#25951)
Fixed Flaky test related to TableV2_generalPropertyPane_spec.js /
app/client/cypress/e2e/Regression/ClientSide/DynamicHeight/Container_collapse_undo_redoSpec.ts
2023-08-08 22:26:57 +05:30
Rishabh Rathod
e15da63f57
fix: setter mutation issue (#25886)
## Description

When we added a mutation task to the microtask queue, earlier we didn't
update the evalProps as soon as the change is triggered, due to this we
lost the update.

Now, we update the evalProps as soon as the setter or getter for
JSObject variable is triggered making sure the latest value is always
present.

#### PR fixes following issue(s)
Fixes #25364
2023-08-08 19:42:07 +05:30
sharanya-appsmith
166e0fad86
test: Cypress - progress widget cases (#25981)
Added cases for: 

1. Check Progress, Number of steps, Counterclockwise Show result
elements disabled on infinite looping enablement
2. Check binding in Progress property 
3. Check progress widget visibility based on visible state
4. Assert expected error texts
2023-08-08 16:24:10 +05:30
Aishwarya-U-R
d6520e53aa
test: Cypress | CI Stablize + verifying DS Connection Errors (DI) (#26004)
## Description
- This PR - improved EnterURL() to - verify for api url entering issue
- Improves AssertText() - added new locator (_widgetToVerifyText) for
ease of use
- Improved StatboxDsl_spec.js validation
- Childwigets/List_Select_Widgets_spec.js (DragDrop - trial fix)
- Fork_Template_spec.js - trial fix
- ServerSide/LoginTests/LoginFailure_spec.js
- /OtherUIFeatures/ApplicationURL_spec.js
- ListV2/Childwigets/List_Inputs_spec.js
- SettingsPane/EmbedSettings_spec.ts
- Templates/Fork_Template_Existing_app_spec.js
- ListV2/ListV2_SerververSide_spec.js
- New TestScript - ConnectionErrors_spec.ts - added
- /OtherUIFeatures/ViewMode_spec.js
- Apps/PgAdmin_spec.js - trial fix

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-08-08 14:44:46 +05:30
sharanya-appsmith
241bb8d43c
test: Cypress - Rating widget (#25944)
1. Validate Max rating and Default rating
2. Validations on Tooltip values
3. Validations on readonly, disabled and visibility of rating widget
4. Validations on events - On change rating widget - alert and modal 
5. Validations on Rename, Copy, Delete - rating widget
2023-08-08 12:16:48 +05:30
Rudraprasad Das
ed7820f003
fix: adding loading state on remote branch switching (#26058)
## Description
adds loading state when checking out to a remote branch

#### PR fixes following issue(s)
Fixes #25591 

#### Media
<img width="981" alt="image"
src="https://github.com/appsmithorg/appsmith/assets/8724051/28fbef49-6da8-499d-b153-f4391ddf393c">


#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-08 10:42:48 +05:30
Valera Melnikov
8be4936ca0
chore: add color validation + native color picker (#25355)
## Description
1. Reduced the number of default colors. Because the amount of suggested
options was too much: very little difference between shades and
sometimes with hues too. By removing half of them, we allow builders
make better choices faster. The transparent color has also been removed.
2. Added validation of color values because HTML colors are remarkably
easy to get wrong, because they allow so many different values and now
we support and validate all these guys
    - `hex` - `#bada55`
    - `name` - `LightGoldenrodYellow`
    - `special name` - `currentColor`
    - `rgb` - `rgb(0 0 0)`
    - `rgba` - `rgba(0, 0, 0, .45)`
    - `hsl` - `hsl(4.71239rad, 60%, 70%)`
    - `hsla` - `hsla(180deg 100% 50% / .8)`
    - `hwb` - `hwb(180deg 0% 0% / 100%)`
    - `lab` - `lab(2000.1337% -8.6911 -159.131231 / .987189732)`
    - `lch` - `lch(54.292% 106.839 40.853)`
<img width="283" alt="Снимок экрана 2023-08-02 в 17 58 07"
src="https://github.com/appsmithorg/appsmith/assets/11555074/a8fef365-506d-432e-85ad-cdb550de1f60">
    
3. Added support for a Full color picker. Now we can easily switch
between modes and builders can easily choose any colors.
<img width="259" alt="Снимок экрана 2023-08-02 в 17 43 34"
src="https://github.com/appsmithorg/appsmith/assets/11555074/be09cd92-7c69-43eb-812a-0b1fe3ac9ef6">


#### PR fixes following issue(s)
Fixes  #22996

#### Media

https://www.loom.com/share/098e0116e49744e7b10689d4a18ab664?sid=15405577-160e-4b48-bfef-bc8dcfa97efe

#### Type of change
- New feature (non-breaking change which adds functionality)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [x] Cypress

## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Valera Melnikov <melnikov.vv@greendatasoft.ru>
2023-08-07 11:55:10 +03:00
Vijetha-Kaja
da3fd27cc2
test: Cypress - Bug 23822 Automation (#25784)
## Description

- Added necessary assertions to cover
https://github.com/appsmithorg/appsmith/issues/23822

## Type of change

- Automation

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-08-04 18:22:35 +05:30
Aishwarya-U-R
b5af1a936f
test: Cypress | CI Stabilize (#26000)
## Description
- This pR improves FilterAndVerifyDatasourceSchemaBySearch() method
- Alters locator for _datasourceTableSchemaInQueryEditor to narrow down
the search result
- Hence fixing /BugTests/DatasourceSchema_spec.ts() causing chrome crash
in CI runs
- Fixes ListV2/Event_Bindings_spec.ts

#### Type of change
- Script fix (non-breaking change which fixes an issue)
- 
## Testing
>
#### How Has This Been Tested?
- [ ] Cypress local runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-08-04 09:16:59 +05:30
Manish Kumar
150e6d8bf0
chore: added cypress changes for ee (#25994)
## Description
> cypress changes for ee only
ref: https://github.com/appsmithorg/appsmith-ee/pull/1933

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-08-04 08:38:23 +05:30
NandanAnantharamu
fbe47a4522
test: cypress - updated tests for List page js to ts migration (#25409)
- migration of flaky list tests from js to ts

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-08-04 00:55:03 +05:30
Vijetha-Kaja
6097db294e
test: Cypress - Flaky Fix (#25979)
## Description

**Fixed below flaky tests**
- Scrolling_Spec.ts
- API_Edit_spec.js
- MaintainContext&Focus_spec.js
 
## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-08-03 23:54:36 +05:30
Ayangade Adeoluwa
d4aba07252
chore: Write test for PR 25835 (#25978)
This PR writes tests for [PR
25835](https://github.com/appsmithorg/appsmith/pull/25835)


- Chore (housekeeping or task changes that don't impact user perception)


#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-03 20:41:08 +05:30
Vijetha-Kaja
05c2b7eca7
test: Cypress - Flaky Fix (#25937)
## Description

**Fixed below flaky tests**
- Regression/ClientSide/AdminSettings/Admin_settings_spec.js
- Regression/ClientSide/ExplorerTests/Admin_settings_2_spec.js
 
Modified AuthenticatedApiDatasource_spec.js ,
RestApiOAuth2Validation_spec.ts to use TED OAuth
 
## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-08-03 12:42:30 +05:30
arunvjn
bcc4d29230
fix: Fixed mustache binding highlight (#25895)
## Description
Changes
- Removed custom bindingMarkers function that manually iterates each
line and highlights brackets
- Added a delimStyle property to multiplex modes (where bindings are
expected)
- Replaced binding-brackets, binding-highlight CSS classes with
cm-binding-brackets

#### PR fixes following issue(s)
Fixes #25894 

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Bug fix (non-breaking change which fixes an issue)
>
>
## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [x] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-03 12:15:25 +05:30
Aishwarya-U-R
f62ea28807
test: Cypress | Uncomment EE-Pin check in InputTruncateCheck_Spec.ts (#25936)
## Description
- This PR uncomments the PinUnpinEntityExplorer() check in
InputTruncateCheck_Spec.ts - as it is handled now to click on EE pin
based on its presence in the application in this
[PR](https://github.com/appsmithorg/appsmith/pull/25901/files#diff-491bdd1b772e351aca1199411640be4a848e84646253ddc249b7daad57bbbf1b)
& merged to release.
- This PR is revert of [this PR
change](https://github.com/appsmithorg/appsmith/pull/25919)
2023-08-02 13:13:04 +05:30
akash-codemonk
cfce89f99c
chore: skip interaction with explorer in input truncate test (#25919) 2023-08-02 10:37:22 +05:30
Aishwarya-U-R
a8c4d9f170
test: Cypress | Flaky fixes (#25901)
## Description
- This PR Flaky fixes below:
- Widgets/Others/Video_spec.js
- ListV2/Childwigets/List_Inputs_spec.js
- ActionExecution/uiToCode/uiToCode_spec.ts
- Datasources/MsSQL_Basic_Spec.ts
- /Apps/EchoApiCMS_spec.js - UpdateCodeInput() to always go to end of
entered input
- /BugTests/InputTruncateCheck_Spec.ts - PinUnpinEntityExplorer()
improved to handle pin based on its presence

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-08-02 03:44:56 +05:30
NandanAnantharamu
18f3c8765a
test: cypress - Flaky fix ListV2_nested_List_widget_spec.js (#25887)
Updated Spec:
Regression/ClientSide/Widgets/ListV2/ListV2_nested_List_widget_spec.js
2023-08-01 19:49:42 +05:30
Dhruvik Neharia
8ad4323243
fix: Cypress test for widget sidebar in Airgap (#25900)
## Description
- Fixes an issue where widgets from WDS were showing up in Airgap.
- Remove the map widget from the widgets list in the widget sidebar
cypress test.

#### PR fixes following issue(s)
Fixes # (issue number)
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [ ] Manual
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-01 17:56:29 +05:30
Aishwarya-U-R
af415f4f30
test: Cypress | Automated tests for MySQL + Flaky fixes (#25867)
## Description
- This PR fixes the below flaky fixes
- GitSyncedApps_spec.js
- Improves coverage for MySQl - adding suggested widget binding
- TableV2/Date_column_editing_1_spec.ts fix
- WaitUntilEleAppear improved
- DeployApp() updated
- QueryPane/Mongo_Spec.js - adding wait time
- AssertIfPropertyIsNotVisible() replaced
- fat-migration.yml deleted
- cypress-real-events - update
- /Filepicker/FilePicker2_spec.js
- /Autocomplete/Autocomplete_setters_spec.ts

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress CI runs

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-08-01 15:04:15 +05:30
Sangeeth Sivan
383c27b61f
feat: default camera config for camera widget (#25676)
## Description
- Camera widget now defaults to back camera. Also a new control is added
to property pane to select whether the camera should default to back
camera or front.

Fixes #21554 
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- New feature (non-breaking change which adds functionality)


## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-08-01 10:23:23 +05:30
akash-codemonk
22c272c210
feat: debugger error navigation (#25505)
## Description

Property pane navigation on click of a widget error or log from the
debugger. Navigation to a field works if the log has the required meta
data here it would be the property path. With the help of the property
pane config and the widget's properties we generate the payload to set
the required panel, tab, section states. Factory class to clearly
separate out the logic for the different entities.

#### PR fixes following issue(s)
Related to https://github.com/appsmithorg/appsmith/issues/16408
Fixes https://github.com/appsmithorg/appsmith/issues/25465
Fixes https://github.com/appsmithorg/appsmith/issues/25462
2023-08-01 09:32:41 +05:30
Vijetha-Kaja
615bd5f349
test: Cypress - Flaky Fix (#25795)
## Description

**Fixed below flaky tests**
- Button_onClickAction_spec.js
- TemplatesPage_filtering_spec.ts
 
## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-31 19:42:42 +05:30
Aishwarya-U-R
e6ee5e7348
test: Cypress | Automated cases for MongoURI CRUD (#25837)
## Description
- This PR is adding new scripts for Mongo URI CRUD validations
- Add/Update/Delete from CRud page
- Search table
- FIlter table
- Download results
- Suggested widget from a mongo uri query
- Apps/CommunityIssues_Spec.ts - 5th fix

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress
- 
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-31 16:57:07 +05:30
Rajat Agrawal
8525fb0da5
feat/Replace fusion charts with Echarts (#24249)
Fixes #24423
Fixes #24426
Fixes #25129
Fixes #25710
2023-07-28 18:59:16 +05:30
Rishabh Rathod
9513dd172f
fix: Remove validation error on revalidation (#25734)
## Description

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/25706

#### Type of change

- Bug fix (non-breaking change which fixes an issue)

## Testing

#### How Has This Been Tested?

- [x] Manual
- [ ] Jest
- [ ] Cypress

#### Test Plan

#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-28 16:01:56 +05:30
NandanAnantharamu
91a65d5eeb
test: cypress - updated click actions in tests (#25748)
Updated steps related to click action in **Listv2_onItemClick_spec.js**
2023-07-28 10:16:32 +05:30
Aishwarya-U-R
252d464d27
test: Cypress | Flaky fixes (#25769)
## Description
- AssertPropertiesDropDownValues() added
- Cypress upgrade to 12.17.

#### Type of change
- Script fix (non-breaking change which fixes an issue)
- 
## Testing
>
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-27 13:34:11 +05:30
Vijetha-Kaja
1cb6a97b5c
test: Cypress - Flaky Fix (#25665)
## Description

**Fixed below flaky tests**
- ListV2_nested_List_widget_spec.js
- S3_spec
- API_Edit_Spec

## Type of change

- Flaky test fix

## How Has This Been Tested?
- Cypress test runs

## Checklist:
### QA activity:
- [ ] Test plan has been approved by relevant developers
- [ ] Test plan has been peer reviewed by QA
- [ ] Cypress test cases have been added and approved by either SDET or
manual QA
- [ ] Organized project review call with relevant stakeholders after
Round 1/2 of QA
- [ ] Added Test Plan Approved label after reveiwing all Cypress test
2023-07-27 10:16:55 +05:30
Saroj
d27078b54e
test: Gsheet Automation (#25255)
## Description
- Automated below queries for gsheet

1. Fetch Details
2. Insert one
3. Insert many
4. Update one
5. Update many
6. Fetch many
7. Delete One

- Added workflow to schedule run for gsheet automated tests on the
hosted instance
- Added a new cypress config file which will be used to run the gsheet
tests
- Added tests for folowing permission/scope options `All access`,
`selected access`, `Read/write | All google sheets` and `Read | All
google sheets`
- Added negative scenarios
- Added tests to verify widget binding for both suggested widget and
drag n drop widget for both selected and all access permission/scope
#### Type of change
- Cypress
## Testing
>
#### How Has This Been Tested?
- [x] Cypress
>
>
## Checklist:

#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-26 18:56:24 +05:30
Aishwarya-U-R
c6be140eb2
test: Cypress | Flaky fixes (#25700)
## Description
- This PR does the below:
       - Improve HoverElement() 
       - Button_onClickAction_spec.js - CI flaky fix
       - ListV2/Childwigets/List_FilePicker_spec.js 
       - Datasources/RestApiOAuth2Validation_spec.js
       - ApiPage - EnterURL() improved - for the entered url to settle
       
#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress
- 
## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-26 14:26:36 +05:30
NandanAnantharamu
568adb24a8
test: Added a fix for flaky failure (#25701)
fix for flaky behaviour for listv2_nested spec
2023-07-26 11:09:30 +05:30
Sangeeth Sivan
ef69dbd259
chore: Make use of widget methods to get binding properties in sniping mode (#25429)
## Description
- Refactoring sniping mode code to fix abstraction leak and to optimise
the process further.
#### PR fixes following issue(s)
Fixes #24737 
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change

- Chore (housekeeping or task changes that don't impact user perception)

>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-26 11:08:11 +05:30
Aishwarya-U-R
722f84b26b
test: Cypress | Flaky fixes (#25691)
## Description
- This PR fixes below specs:
              -    BugTests/DatasourceSchema_spec.ts
              -  /Dropdown/Dropdown_onOptionChange_spec.js
              - Improved homePage.CreateNewWorkspace()

#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-25 17:57:16 +05:30
Aishwarya-U-R
89b7de2b64
test: Cypress | Flaky fix (#25685)
## Description
- This PR fixes flaky Dropdown_onOptionChange_spec.js - 2nd case
- 
#### Type of change
- Script fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-07-25 15:24:03 +05:30
Aishwarya-U-R
30cacf6795
test: Cypress | Flaky fix (#25673)
## Description
- This PR fixes Autocomplete_setters_spec.ts which is flaky in CI runs
#### Type of change
- Script fix (non-breaking change which fixes an issue)
>
## Testing
>
#### How Has This Been Tested?
- [X] Cypress

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after changes were reviewed
2023-07-25 12:35:56 +05:30
NandanAnantharamu
2ae32dc749
test: Cypress - updated test for Workspace from js to ts (#25218)
Replacing flaky js test to ts related to wokrspace

---------

Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-25 11:03:58 +05:30
balajisoundar
64cec91a0f
feat: select and multiselect label value (#24964)
## Description
- Select and multi-select widgets now have two new properties under the
data section label and value.
- The existing options have been renamed to Source data.
- Users can set the label and value of the options through these new
properties.
- We have written migrations to make this work for existing select
widgets.

#### PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/24022

>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>
2023-07-25 10:26:33 +05:30
Aishwarya-U-R
b8b6b8a646
test: Cypress | Flaky fix (#25635)
## Description
- This PR flaky fixes the Dropdown_onOptionChange_spec.js for CI runs
#### Type of change
- Script fix (non-breaking change which fixes an issue)
## Testing

#### How Has This Been Tested?
- [X] Cypress
- 

## Checklist:
#### QA activity:
- [X] Added `Test Plan Approved` label after Cypress tests were reviewed
2023-07-24 17:40:56 +05:30
Ayangade Adeoluwa
8f954a5b3d
fix: open collapsible on schema refresh (#25527)
This PR ensures the collapsible is opened when the schema refresh button
is clicked.

Fixes #25414 

- Bug fix (non-breaking change which fixes an issue)

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [x] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-24 17:39:46 +05:30
sneha122
0341de95b5
feat: For movies mock db, query should be populated with default values (#25403)
## Description

When we create movies mock DB, and create queries on top of it, then:
If datasource schema is available, then we need to populate the query
with defaults as shown below:
![Screenshot 2023-07-17 at 6 49 44
PM](https://github.com/appsmithorg/appsmith/assets/30018882/4fab934b-8900-4a9e-9660-5fe6e4ecc845)

When schema is not available, query would not be populated and shown in
blank state as below:
![Screenshot 2023-07-17 at 6 49 56
PM](https://github.com/appsmithorg/appsmith/assets/30018882/ae4635b3-19ef-497a-9383-f408c0234bf1)


#### PR fixes following issue(s)
Fixes #25320 
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- New feature (non-breaking change which adds functionality)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [x] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [x] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

---------

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>
2023-07-24 17:32:50 +05:30
Rahul Barwal
d66e634393
feat: templates ui ux updates (#25472)
## Description
1. imports only required stuff from object explorer
2. updates code to utilize helper functions.
#### PR fixes following issue(s)
Fixes #25402
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-24 16:30:41 +05:30
Ayangade Adeoluwa
3ea0568771
fix: Fix cancel issue and form value state persistence (#25412)
This PR fixes two things 

1. The cancel button not showing the dialog after a change has been
made.
2. The fields in the datasource form retaining values changed by the
user without the user saving those changes.

Fixes #25333 

> Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [x] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [x] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-24 15:59:05 +05:30
Parthvi
ad48e4280f
test: Update git cypress test logic around merge conflicts (#25044)
## Description

This PR updates test logic in order to get merge conflicts , earlier
merge conflicts would come if we commit different widgets on same page,
since this is resolved by canvas split PR, updated test to use theme for
conflicts instead, also adds test for release blockers

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.

- [x] Cypress



## Checklist:
#### Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
2023-07-24 12:37:16 +05:30