PromucFlow_constructor

Author	SHA1	Message	Date
yatinappsmith	815d0b5f14	CI: Add tags to to cypress tags (#32843 ) Add tags to to cypress tags <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Updated and reorganized tags within the application to include new categories such as "Audit Logs," "Access Control," "License and Billing," and "Provisioning." Also, rearranged the "Templates" tag for better accessibility. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-22 15:42:53 +05:30
Valera Melnikov	6d90ce8dc9	chore: update storybook (#32828 ) ## Description - Update Storybook and related dependencies - Delete the stories for old widget components - Rewrite stories for new widgets(mdx to tsx) Note: local chromatic doesn't work because of this https://github.com/storybookjs/storybook/issues/22531 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced new component stories across various packages to enhance design system documentation and user experience. - Documentation - Updated `.gitignore` files to optimize version control settings for Storybook and build logs. - Refactor - Modified UI element positioning in Storybook theming for improved layout management. - Style - Adjusted CSS properties for the `Select` component to ensure better visual presentation. - Chores - Updated dependencies and scripts in package configurations to maintain up-to-date development tools. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-22 12:17:28 +03:00
NandanAnantharamu	16874f4561	test: updated test for DataIdentifier (#32752 ) DataIdentifier test fix app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifier_spec.ts RCA: Exeternal API was the main reason for failure 1. external API was used 2. Replaced with TED API Removed unwanted wait <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Bug Fixes - Improved the reliability of list loading in automated tests by removing unnecessary delays. - Enhanced data processing in lists by modifying the data configuration format. - Updated test configuration to use the correct spec file path for limited tests. - Added interactions with EditorNavigation and propPane for selecting entities and properties in the test scenario. - Added a new declaration `_dropdownControlError` to the `PropertyPane` class, representing a selector for dropdown control errors. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-22 10:41:11 +05:30
Shrikant Sharat Kandula	cca1b55daf	test: Fix page name test (#32825 ) Update test with the current page name validation rules on the server and the client. /ok-to-test tags="@tag.Settings"<!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8753150717> > Commit: e322d185a0089662054672ec045596e67e055316 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8753150717&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated comments and test cases in Page Settings to reflect restrictions on using slashes and colons in page names. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-19 17:59:03 +05:30
Apeksha Bhosale	272aad22cc	fix: ForkTemplateToGitConnectedApp.js - slack bot template has been removed (#32819 ) ## Description Slack bot template has been removed from the list of templates so going to pick the first one whichever we can find. Link --> 10th spec from https://www.notion.so/appsmith/Cypress-tests-analysis-4090efa5e3064a2e87f262d3c399a339 EE PR - https://github.com/appsmithorg/appsmith-ee/pull/3995 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Improved the reliability of template selection in the app by updating the click action to target the entire template card. - Enhanced the user experience by adjusting the wait time for template setup completion. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-19 17:49:11 +05:30
Apeksha Bhosale	ce61d5675d	fix: replaced with different solution (#32820 ) ## Description selectAll + backspace is not clearing data as expected link -- https://theappsmith.slack.com/archives/C0134BAVDB4/p1713513274857039 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated test logic in Rich Text Editor to improve cursor position accuracy. - Modified test spec file paths for better organization and clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-19 17:20:12 +05:30
NandanAnantharamu	435f3e5bb3	test: visual tests to be enabled (#32731 ) Enabling visual tests: RCA: Whenver there is change in UI , we need recapture the screenshots for each of the tests as mentioned within the spec. In this exercise we have updated the screenshot for all the visual tests. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Updated visual test specifications in Cypress for enhanced accuracy. - Introduced a script to uninstall Node.js from Unix-based systems. - Bug Fixes - Adjusted login page validation to reflect updated text expectations in visual tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-19 17:03:10 +05:30
Pawan Kumar	3ef40bfcc6	fix: property navigation spec (#32782 ) This PR fixes the property navigation spec that started failing in the recent PR #32736 ## Automation /ok-to-test tags="@tag.All" <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8748159364> > Commit: 6b662b3defea1046d0dedda5ccdcb3b2e30fef08 > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8748159364&attempt=3&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/ExplorerTests/Hide_Page_spec.js > <li>cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js > <li>cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js > <li>cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionAlgorithm_AutoLayout_Validation_BasicSpec.js > <li>cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ConversionFlow_Corner_Cases_spec.ts > <li>cypress/e2e/Regression/ClientSide/SettingsPane/PageSettings_spec.ts </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results --> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-04-19 13:09:20 +05:30
Apeksha Bhosale	eb2ac643ad	fix: Omnibar_spec - removed external dependency and asserted appropriate elements (#32772 ) ## Description 1. Removed the third party dependency test case - assertion for appsmith docs 2. Modified assertions to reduce flakiness - assert "no result" on Omnibar search instead of discord link being open Link 1st spec in https://www.notion.so/appsmith/Cypress-tests-analysis-4090efa5e3064a2e87f262d3c399a339?pvs=4#7dca72e1cf7a49bd8d9883ad9caa7746 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced clarity and consistency in test descriptions for the Omnibar feature. - Updated text validation in tests to enhance accuracy and maintainability. - Added imports for message constants. - Chores - Updated test configuration to reflect the renaming of a test spec. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-19 12:49:05 +05:30
albinAppsmith	5a671807a3	feat: revamped logic for tabs removal and action/JS deletion (#32690 ) ## Description This PR has changed the logic of next item selection after deleting an item or removing a tab. The new logic is 1. If there is no more tabs left after removal of current item, navigate to first item from all items list 2. If all items list is empty, navigate to add 3. If the removed tab is not currently selected, no redirection required just close the tab 4. If removed tab is in 0th position, redirect to current tab + 1 5. if removed tab is not in 0th position, redirect to tab - 1 Fixes #32634 ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8748435770> > Commit: e3e9b51cc9a708fadf4d1b9f0e426b63e9f3c10a > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8748435770&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/ExplorerTests/Hide_Page_spec.js > <li>cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Improved the closing functionality for JavaScript and query action tabs in the IDE, enhancing user experience with smoother tab management. - Refactor - Aligned sagas and reducers with new action types for improved handling of tab closures and entity redirects within the IDE. - Tests - Updated test cases to reflect changes in IDE saga functions and logic, ensuring reliability and consistency in behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-19 12:19:24 +05:30
NandanAnantharamu	905c738f82	test: updated tests by replacing external APIs (#32718 ) replaced some external APIs with ted APIs <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Removed assertions for `offsetHeight` and `offsetWidth` in the test case related to a fixed canvas size being visible when height is selected as Fixed. - Updated URL references in the test script from "https://randomuser.me" to "http://host.docker.internal:8000" for image sources. - Updated API endpoints for two requests in the `API_Bugs_Spec.js` file. - Updated image URLs in JSON files for fixtures related to widgets in the client application. - Tests - Updated API endpoint URLs in test scripts to enhance reliability and internal consistency. - Modified image source URLs in various test fixtures to align with updated internal hosting. - Documentation - Updated source URLs in iframe configurations to reflect new internal hosting paths. <!-- end of auto-generated comment: release notes by coderabbit.ai --><!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > The provided command lacks proper tags. Please modify PR body, specifying the tags you want to include or use `/ok-to-test tags="@tag.All"` to run all specs. > Explore the tags documentation [here](https://www.notion.so/appsmith/Ok-to-test-With-Tags-7c0fc64d4efb4afebf53348cd6252918) <!-- end of auto-generated comment: Cypress test results -->	2024-04-18 19:01:46 +05:30
sneha122	d9ce6b38bd	fix: show linting errors on browser API added (#32732 ) ## Description Whenever browser apis like window, navigator, print etc are using in the JSmode bindings, current implementation does not show linting errors and if such JS code is executed, we get error toast message of `window.alert is not defined`. This is because linting errors are identified inside lint worker and since we are inside the context of worker, it does not understand the browser context or its APIs, thus this PR highlights the linting errors when any of the browser APIs are using in JS bindings. Before: <img width="952" alt="Screenshot 2024-04-17 at 3 40 19 PM" src="https://github.com/appsmithorg/appsmith/assets/30018882/e2dbb1ab-52d4-4b2c-ae1e-93516cf399ea"> After: <img width="642" alt="Screenshot 2024-04-17 at 3 41 11 PM" src="https://github.com/appsmithorg/appsmith/assets/30018882/9cb050d8-86ac-47b1-8804-7405a3f9bf1f"> Note: Existing cypress test of `BasicLint_spec.ts` has been modified to assert linting issues in such case. Fixes https://github.com/appsmithorg/appsmith/issues/16535 ## Automation /ok-to-test tags="@tag.JS" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8734064205> > Commit: 86ad8803029c9250a0d283767ea142a2c78235d0 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8734064205&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated test case descriptions and added steps for better browser interaction and lint error assertions in the linting functionality. - Refactor - Modified linting options to improve behavior in browser environments. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-04-18 18:49:15 +05:30
sneha122	5860351ce2	fix: removed success toast message for onload js functions (#32700 ) ## Description Whenever we have js object functions set to execute on page load, and we reload such page, all these functions are execute and we get lots of success message popups indicating the execution of js object functions was successful, These toasts clutter the UI and unnecessary since action execution has been successful, this PR removes those toast messages https://github.com/appsmithorg/appsmith/assets/30018882/44472503-d3c7-4bf8-861f-437284a4996c Fixes #32695 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8734047332> > Commit: fb22e7445618c592dee1066991d668082afc5642 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8734047332&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Refactor - Simplified JavaScript execution flow by removing unused imports and functions. - Removed success toast notification after JavaScript function execution. - Updated test scenarios in Cypress related to JavaScript execution and navigation back to the editor. - Removed test cases verifying the number and sequence of JS objects on page load in ServerSide/OnLoadTests. - Added functionality to interact with the debugger in the test scenario in ClientSide/BugTests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-04-18 18:19:33 +05:30
Hetu Nandu	02c1d9e7b4	chore: Make pages section into a dropdown (#32486 ) ## Description Makes the pages pane into a Dropdown instead of a list hidden behind Editor Pane Fixes #31450 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8733103397> > Commit: 9905212e4307e3c6ee47b0bd819d14ef751143a2 > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8733103397&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoHeight_Tabs_spec.ts > <li>cypress/e2e/Regression/ClientSide/MobileResponsiveTests/AutoLayout_Widgets_Copy_Paste_spec.ts </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added a visibility management menu to the `EditorTitle` component. - Introduced new `HeaderTitleComponent` to dynamically update based on editor states. - Updated the `PartialImportModal` and `PartialExportModal` components for improved handling. - Implemented a new callback function `onItemSelected` in `AddPageContextMenu`. - Added a search functionality to the app. - Enhancements - Updated `PageList` methods for better attribute handling and added `HideList` method. - Enhanced test clarity and maintainability in various Cypress regression tests. - Bug Fixes - Fixed step increment issue in `PageElement` by adjusting the `step` prop value. - Documentation - Updated user-facing messages and labels for clarity, such as renaming "Edit name" to "Rename." - Refactor - Removed outdated state management properties and methods, simplifying the codebase. - Streamlined import statements and component props across multiple files for consistency. - Version Updates - Upgraded `design-system` package to a new version for enhanced features and fixes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-18 16:04:38 +05:30
Rudraprasad Das	c85631c06f	fix: adding branch protection callout (#32707 ) ## Description - Changes branch protection tooltip to callout - Adds protected branches for merge in a disabled state Fixes #32706 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8735310063> > Commit: f654e1168fde85388991cf547630b42bc61d9b4e > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8735310063&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results -->	2024-04-18 15:13:51 +05:30
Hetu Nandu	065ced345b	chore: Make Editor Pane Segments GA (#32712 )	2024-04-18 10:05:34 +05:30
Ankita Kinger	e07e3ecd04	chore: Updating the login and signup page for cloud hosting as per new design (#32641 ) ## Description Updating the login and signup page for cloud hosting as per new design Fixes [#32267](https://github.com/appsmithorg/appsmith/issues/32267) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8723701550> > Commit: 65a0179c5d22e1f950888c24a119af608aed2a28 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8723701550&attempt=4" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced titles and messages across login, signup, and forgot password pages for clarity and engagement. - Added new analytics event for tracking visits to self-hosting documentation. - Introduced new content and layout adjustments in user authentication pages to improve user experience. - Implemented conditional rendering to optimize content display for mobile devices and cloud hosting scenarios. - Bug Fixes - Updated footer links to use consistent capitalization. - Refactor - Major structural and styling overhaul of forms and user authentication components to utilize modern CSS practices and improve maintainability. - Documentation - Added direct links to self-hosting documentation to facilitate user access. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-17 21:46:44 +05:30
Aman Agarwal	2a08e8ed52	fix: reverting the default port numbers for the datasources (#32726 ) This PR is created to revert the changes from the PR #32592 due to flakiness in the test specs. Reverts appsmithorg/appsmith#32592 ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > 🔴 🔴 🔴 Some tests have failed. > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8717847856> > Commit: e6b4c320d893490c37bf4b4a2efa02fc4c4a2c4b > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8717847856&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ServerSide/ApiTests/API_MultiPart_Spec.ts </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results -->	2024-04-17 13:44:18 +05:30
Nidhi	c51e4b810d	chore: Introduce changes to minimize git footprint (#32595 )	2024-04-16 21:34:24 +05:30
Ankita Kinger	3ed620e156	fix: Updating the ramp link for Enterprise features to open the pricing page (#32698 ) ## Description Updating the ramp link for Enterprise features to open the pricing page. Fixes [#30211](https://github.com/appsmithorg/appsmith/issues/30211) ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8706159532> > Commit: b9925ae2ec5a14724586f72affa02a1d83078813 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8706159532&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced enterprise-level provisioning and authentication settings across various components. - Added a new Cypress command to improve testing by simulating customer portal interactions. - Refactor - Streamlined UI components by adjusting styles and simplifying rendering logic. - Removed redundant spinner components and simplified conditions in various editor components. - Style - Updated CSS properties and variables for better consistency and maintainability. - Tests - Updated regression tests to reflect new functionalities and page interactions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-16 19:05:07 +05:30
Jacques Ikot	0118051301	feat: implement dropping building blocks on canvas (#31857 ) ## Description > [!TIP] Goal To drag any building blocks from the explorer and drop at any position on the users canvas with full implementation. Implementation - Show skeleton widget when building block is initially dragged unto the canvas. - Make API call to add datasources, queries, and JS to existing page of users app - Get returned widget DSL and use existing copy paste logic to display widgets on the canvas - Remove loading state, handle clean up for copy paste - Run all queries newly created by the dropped building block Limitations - There is a loading state and the process is not instant like dropping a widget This PR is followed by this one [here](https://github.com/appsmithorg/appsmith/pull/31406), which displays the loading state when a building block is dragged unto the canvas. Fixes #31856 ## Automation /ok-to-test tags="@tag.Templates, @tag.MainContainer, @tag.Visual, @tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8701664455> > Commit: 456a7a0a322e76974a7f5c41a6c1e274ef82e4ea > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8701664455&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new "Building Blocks" category in the widget sidebar for enhanced organization and accessibility. - Added functionality to resize building blocks with new horizontal and vertical limits. - Implemented a "see more" button for "Building Blocks" to display all associated widgets. - Enhanced drag and drop functionality for building blocks on the canvas. - Enhancements - Improved sorting logic for widgets, prioritizing "Building Blocks". - Enhanced widget search functionality within the sidebar. - Bug Fixes - Adjusted default rows and columns settings for explorer building blocks to improve layout and usability. - Documentation - Updated messages and constants related to new features for clarity and consistency. - Refactor - Refactored drag and drop handling logic to support new building block constraints and features. - Updated application state management to include building blocks related data. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>	2024-04-16 09:41:09 +01:00
Aman Agarwal	ed1bb9273a	fix: default port numbers for the datasources (#32592 )	2024-04-16 13:29:04 +05:30
balajisoundar	d2fc0af659	fix: [Table Widget] Remove unnecessary scrollbar when page size fits in available height (#32327 ) Fixes https://github.com/appsmithorg/appsmith/issues/17857 ## Automation /ok-to-test tags="@tag.Table" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8645383412> > Commit: a0001d83d5826441c0e0dde59100b8eb5732974b > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8645383412&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results -->	2024-04-15 12:21:08 +05:30
Ashok Kumar M	7b527c9024	chore: Merge wds and anvil feature flags (#32609 ) [![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX1LNwrMHgs05enX0VDk8QxZH7uP7Ii4HE%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=M7zehz4) ## Description Cleaning up three patterns of checks to enable wds and anvil into two. wds and anvil had to have different flags coz anvil had to play catch up with wds, now that's not the case so it does not make sense to have two flags. Old patterns - checking if the wds feature flag is enabled - checking if the anvil feature flag is enabled - checking if the layout system of the app is anvil New Pattern - checking if anvil feature flag is enabled (used only for creating an anvil app) - checking if layout system of the app is anvil Fixes #32590 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8663918496> > Commit: e10cc2a84ed680b29c49c5b2e8175df4c18da2f8 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8663918496&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Consolidated the usage of layout system checks across the application to use a unified Anvil layout selector, enhancing consistency in layout-related conditional logic. - Bug Fixes - Removed outdated feature flags related to the Anvil + WDS integration, ensuring the application's feature toggling aligns with the current development strategy. - Tests - Updated unit tests to align with the new method of layout system determination, ensuring test environments accurately reflect production behavior. - Chores - Cleaned up redundant code and feature flags that are no longer in use, simplifying the codebase and reducing potential for errors. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-12 22:54:04 +05:30
Rishabh Rathod	6a26602086	fix: deprecate JS object confirm before calling (#32527 ) ## Description We deprecate confirm before calling for JSObjects - For new JSObject, confirm before calling option won't be visible - For already present JSObject, only for function where confirm before calling was enabled will be visible and once turned off will not be visible anymore. Fixes https://github.com/appsmithorg/appsmith/issues/29248 ## Test scenarios - For an application where JSObject confirmed before calling was enabled, it should work same. - For new JSObject, confirm before calling option shouldn't be visible. - Once user disable confirm before calling it should not be visible anymore. - Deprecation warning on info. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8654538946> > Commit: 6ac458bdec864a2963fa5eb59b5912607ddfa3a7 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8654538946&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results -->	2024-04-12 12:18:14 +05:30
Rudraprasad Das	15374ab016	fix: missing methods in gitexecutorceimpl (#32614 ) Fixes broken builds due to missing overriden base methods ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8650609417> > Commit: 9bf9e6d75b4bf29adfd65d16504ebcd2f451d32a > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8650609417&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results -->	2024-04-12 06:21:01 +05:30
Rudraprasad Das	f7118422c6	feat: granular git status (#31619 ) ## Description Lists down changes in entity with level 1 granularity Fixes #31644 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8642841391> > Commit: dd9dd7abb619a4e62edd950cbc6e64e15b4a42e2 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8642841391&attempt=1" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced granular tracking of Git changes, including added, modified, and removed pages, datasources, queries, JS objects, and JS libraries. - Implemented a new feature flag `release_git_status_granular_enabled` to toggle granular Git status tracking. - Added new components to display detailed Git changes with expandable views for different types of entities. - Enhancements - Simplified the logic for determining if a commit is required by enhancing the Git status checks. - Enhanced Git status display to include specific messages and icons for various types of changes. - Improved the Git sync feature's user interface with updated components and styling for displaying Git changes. - Bug Fixes - Corrected the display logic to accurately reflect when a JS library is added instead of modified. - Refactor - Refactored Git status handling logic on both client and server sides for improved performance and readability. - Updated test suites to align with the new Git status tracking and display functionalities. - Tests - Added and updated tests to cover new Git status functionalities and components. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-11 18:26:09 +05:30
Ashok Kumar M	271dca0296	feat: Move conversion flow under feature flag. (#32490 ) [![workerB](https://img.shields.io/endpoint?url=https%3A%2F%2Fworkerb.linearb.io%2Fv2%2Fbadge%2Fprivate%2FU2FsdGVkX105sGkyMb3eywi17Q8zKGh7H7PVjvpTo%2Fcollaboration.svg%3FcacheSeconds%3D60)](https://workerb.linearb.io/v2/badge/collaboration-page?magicLinkId=8cXsNLR) ## Description Auto Layout System is being deprecated in favor of Anvil. So we will no longer update Auto Layout and hence we are removing conversion flow to make sure no new Auto Layout Apps are created. However we still want to be able to help users who really have mission critical use cases to convert. two ways to do this - ask Support and they will enable the feature flag to enable conversion.(for cloud users) - ask Support and they will reveal the global function(`overrideFeatureFlag({release_layout_conversion_enabled: true})`) to enable conversion.(for users not connected to internet) Implementation: - current feature flags are supplied from the consolidated api and widgets consume them via `selectFeatureFlags` selector. - to override these flags locally, we provide a global function(accessible from console) `overrideFeatureFlag` which can take an object of featureflags and save them to indexed db. - then we use these saved values to override feature flag values supplied by the consolidated api. - `selectFeatureFlags` is where the values are combined and consumed by all components. Fixes #32140 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8641988198> > Commit: de8e06778bd9fe1feab2f5d20adbaed90e542019 > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8641988198&attempt=2" target="_blank">Click here!</a> <!-- end of auto-generated comment: Cypress test results -->	2024-04-11 17:21:14 +05:30
Aman Agarwal	d8b07c4ce1	fix: commands title changed to command for each datasource query editor forms (#32526 )	2024-04-10 17:05:01 +05:30
Shrikant Sharat Kandula	93264846be	ci: Remove unused code from Cypress setup (#32537 ) The `serve` command isn't available anymore and has been throwing an error for some time now. The other NGINX configuration related commands also aren't impactful. /ok-to-test tags="@tag.Sanity"<!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8627538008> > Commit: `f460fd31da02c2e390d59cf70410f950db343fa1` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8627538008&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results -->	2024-04-10 13:28:09 +05:30
sneha122	4309e9e44b	fix: connection mode hidden from mysql form config (#32487 ) ## Description MySQL datasource config has a field called `Connection mode`, which allows users to configure their datasource either in read write / read only mode. This is supposed to block the write queries if datasource is configured with read only mode, but with current implementation, it does not block, it lets us execute write query. On checking the codebase, it seems that this field is not at all being used in mySQL plugin to configure the datasource, further more mysql driver used may not even support configuring connection mode as of now, hence as preventive solution, hiding the connection mode form config for now. Fixes https://github.com/appsmithorg/appsmith/issues/9941 > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8612888064> > Commit: `0a0d20e1fb40546e635ba018704b5f13ecc97ab1` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8612888064&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-04-10 12:34:04 +05:30
Rishabh Rathod	36dedc0b0f	fix: appsmith.URL.queryParams update on same page navigation (#32382 ) ## Description - Making sure to trigger evaluation after navigateTo on same page to make sure we update the `appsmith.URL.queryParams` - Update the cypress test to check queryParams update on same page Fixes https://github.com/appsmithorg/appsmith/issues/26831 ## Steps to test 1. Add a button widget 2. Add a `navigateTo` action on click event of button 3. NavigateTo should have params as below and should navigate to same page ```js {{ { key: "aff", key2: "dsfs" } }} ``` 4. Add a text widget with binding `{{appsmith.URL.queryParams}}` 5. Make sure that the text widget updates once the button is clicked ## Automation /ok-to-test tags="@tag.JS" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8598783804> > Commit: `634477b53582ae5392eb26dde1a1fcd434f55883` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8598783804&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added support for setting URL data through Redux actions for enhanced state management. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-09 16:01:17 +05:30
Jacques Ikot	9118f36432	fix: widget card filter (#32420 ) ## Description > [!TIP] When user starts to search for a widget, and hovers over the canvas area, the search filter resets. This issues is caused by the resetting of the widget cards state whenever user hovers Fix I have changed the trigger for the useEffect, to only set the widget cards state only when the building blocks are loaded. Fixes #32408 ## Automation /ok-to-test tags="@tag.Templates, @tag.Visual, @tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8610964331> > Commit: `c5f3b657d91278a4ee841bc05db3ae4cab4b34c6` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8610964331&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Improved the update mechanism for the widgets list in the UI Editor sidebar to ensure it refreshes correctly after fetching new building blocks. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>	2024-04-09 10:38:01 +01:00
Aman Agarwal	732026fc06	fix: label for data type in s3 create file action (#32484 )	2024-04-08 22:58:56 +05:30
Hetu Nandu	159399d8f4	fix: On delete of last item, redirect user to blank screen (#32418 ) ## Description When the last item is deleted in JS, Query Or UI, we will take the user to the to the list view where the blank state is shown. This way the user will not be confused about the add state they were dropped into Fixes #30612 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8569313532> > Commit: `6408a9af3dee52fe66501afc6b4e6ded49993fee` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8569313532&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved focus management across the application by centralizing focus history handling. - Updated redirection logic after entity deletion to enhance user navigation experience. - Chores - Removed unused `removeFocusHistoryRequest` function and associated action constant to streamline codebase. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-05 17:56:17 +05:30
Hetu Nandu	c8f1b82ca5	fix: action selector create flow (#32326 ) ## Description Fixes the broken flow where, on creation of a query or JS object in via the ActionCreator UI, the widget property that initiated it, does not get bound to the newly created item. We will now keep reference of the setter method that would set the binding value to the property and when the item is created, it will call the method with the correct bind value. This will wait till that particular action type is created. Fixes #7745 ## Automation /ok-to-test tags="@tag.JS" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8550162310> > Commit: `57e69a0c47496d1a1ee97e04991f34ca79440181` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8550162310&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced the ability to create new queries and JavaScript functions directly from action creators, enhancing the workflow for building applications. - Added support for binding newly created queries, APIs, and JavaScript objects to button onClick events, streamlining the process of connecting actions to UI elements. - Enhancements - Improved the code modularity and readability in the Editor Navigation by refactoring the logic for closing announcement modals. - Tests - Added regression tests to ensure the reliability of creating actions via an action selector and their proper binding to properties. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-05 11:28:47 +05:30
Ashok Kumar M	79fbdc2b1a	chore: RMVF based changes for DnD, Modals, and Space distribution. (#31980 ) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #31935 Fixes #32059 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8565307211> > Commit: `5d5f682bcabd1b64d69d8743cc0ffbfcad372f92` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8565307211&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enabled new feature flags for advanced widget and release management. - Introduced a new component for modal layout and enhanced styling for the Anvil Editor. - Added messages for guiding users on where to drop widgets and modals. - Implemented a new route for widget editor enhancements. - Enhancements - Improved Anvil Editor's canvas functionality with better activation, selection, and drag-and-drop features. - Enhanced the visual styling and interaction of widgets and modals in the Anvil Editor. - Bug Fixes - Corrected import paths and updated selectors for consistent functionality across the Anvil platform. - Refactor - Streamlined Anvil Editor components and hooks for better maintainability and readability. - Adjusted import paths and reorganized components to align with the new project structure. - Style - Added and updated CSS styles for better UI experience in the Anvil Editor and modal interactions. - Tests - Updated Cypress E2E tests to reflect changes in the Anvil Editor's functionality and UI elements. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-05 11:16:07 +05:30
albinAppsmith	ac4a34a880	fix: Added assert for network status in IDE add pane interactions spec (#32395 )	2024-04-04 13:06:31 +05:30
albinAppsmith	3d2b33c0fa	chore: cypress test for canvas view mode (#32354 ) ## Description This PR added cypress test for canvas view mode. Fixes #31874 ## Automation /ok-to-test tags="@tag.Sanity, @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8534736683> > Commit: `f1d8cc5c4437571b5bbe9a43e892068ae774c75f` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8534736683&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced testing functionality for Canvas view mode in IDE, including various interactions and validations. - Added a new Cypress command for asserting the presence and content of tooltips. - Enhanced tooltip message customization in the Canvas view mode with a new message creation function. - Refactor - Improved code organization in Canvas support files with better method implementations. - Tests - Added end-to-end tests for new and existing functionalities related to the Canvas view mode. - Documentation - Updated Cypress support documentation with the new `assertTooltipPresence` method. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-03 14:52:09 +05:30
Rishabh Rathod	7ab236aa7e	chore: autoFocus widget search input on load (#32002 ) ## Description This PR included two paper cut fixes 1. Autofocus the search input after add widgets button click https://github.com/appsmithorg/appsmith/assets/23132741/3125c0a8-1104-4c1c-aecc-dacd01123f82 2. Remove the helper text for columns in Table widgets Fixes https://github.com/appsmithorg/appsmith/issues/32218 ## Automation /ok-to-test tags="@tag.Widget" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8521789054> > Commit: `cee8a960ddf92126eab419bb109fb44dbf02047e` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8521789054&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enhanced search input focus control across the editor for an improved user experience. - Refactor - Updated components to support dynamic focus management on search inputs. - Bug Fixes - Removed mandatory help text validation for property controls, enhancing flexibility in widget configuration. - Eliminated the `helpText` requirement from widget configuration, simplifying setup. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-03 13:21:53 +05:30
Hetu Nandu	48685e633a	fix: Feature flags not intercepted correctly (#32341 ) ## Description Fix for correctly intercepting Feature Flags in the testing env Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8533833714> > Commit: `e7a1bebf9feda3c92015907b73f9cdcd8bc806a7` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8533833714&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Optimized feature flag management for improved performance and reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-03 12:54:52 +05:30
Aman Agarwal	a40e16adb3	fix: asserting getApplicationsOfWorkspace call before clicking skip (#32311 ) ## Description Asserting getApplicationsOfWorkspace call before clicking `Skip this step, I`ll do it later` button to move to the application screen. Tldr: Earlier was failing because the applications in the workspace were not available (or the network call was already in progress) and when the button was clicked because of the application condition, it was not redirecting to the application screen. Now we wait for the applications network call to finish before clicking on the Skip button. Fixes #32310 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8522236782> > Commit: `e94458e2051502af269082e46c5811717877b32b` > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8522236782&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/IDE/IDE_Add_Pane_Interactions_spec.ts </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced user interaction on the homepage for improved usability. - Streamlined the process for creating superuser accounts. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-03 11:01:05 +05:30
Shrikant Sharat Kandula	fc4100b747	test: Use server on 5000 port for test pictures (#32304 ) We've introduced a new Node express server on TED at port 5000, which runs Postgraphile, as well as serves the test static assets. This PR switches to use that endpoint for test static assets.	2024-04-02 10:26:45 +05:30
albinAppsmith	834c0f8280	chore: Cypress - add pane interactions (#32091 ) ## Description Added cypress test for add pane interactions. Fixes #31868 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8504922496> > Commit: `0c74a26f4c959c84bf308876e4c0740e0c45ca90` > Cypress dashboard: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8504922496&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail" target="_blank"> Click here!</a> > The following are new failures, please fix them before merging the PR: <ol> > <li>cypress/e2e/Regression/ClientSide/AppNavigation/AppNavigationWithMultiplePages_spec.ts </ol> > To know the list of identified flaky tests - <a href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master" target="_blank">Refer here</a> <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced test cases for adding panes in the IDE, covering various tab interactions. - Added the ability to switch between full screen and split screen modes in the IDE. - Tests - Added a new Cypress custom command for easier test maintenance. - Refactor - Enhanced testability by adding `data-testid` attributes across various IDE components for improved element selection in tests. - Improved code clarity through reorganization and reformatting of component properties. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Hetu Nandu <hetunandu@gmail.com>	2024-04-02 10:06:54 +05:30
Vemparala Surya Vamsi	4b27a59b1c	chore: remove feature flag code of consolidated api (#32248 ) Removed feature flag related code to consolidated api, also corrections in feature flags are made here. Fixes #31100 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/8490467344> > Commit: `fce48b210983689994152b7ae77c773cfdca854a` > Workflow: `PR Automation test suite` > Tags: `` <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced new feature flags to enhance user interface and default settings. - Refactor - Simplified page loading logic for better performance. - Enhanced error handling and reporting for a smoother user experience. - Chores - Cleaned up unused imports and code for better maintainability. - Bug Fixes - Removed redundant checks and updated functionality to include new feature flags. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-01 17:45:09 +05:30
Ashok Kumar M	036f9b0f1b	chore: Anvil Canvas and Widget intearction separation (#32025 ) ## Description In this PR, we are separating widget and canvas interactions. going forward - Wigdets can be interacted with only in Preview mode. - Canvas based interactions will only be allowed in edit mode. Fixes #32138 Fixes #31570 Fixes #32058 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8506204162> > Commit: `d42107de5931bb39b656817b220e72737a30b5d0` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8506204162&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enabled new Anvil editor functionality for all users. - Improved user interaction with widgets and modal widgets inside the Anvil editor. - Refactor - Streamlined feature flag handling for a more consistent user experience. - Enhanced canvas interaction in Anvil editor by adjusting pointer events settings. - Tests - Updated and refined Cypress end-to-end tests for better reliability and coverage. - Style - Introduced new CSS rules for better handling of user interactions within the Anvil editor environment. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-01 15:00:24 +05:30
balajisoundar	e2b08140f4	chore: fix text editor widget cypress spec (#32271 ) ## Automation /ok-to-test tags="@tag.TextEditor" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8504305878> > Commit: `277169acb8b7b5b9ef9903159fe7ac40bd04e64a` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8504305878&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated test descriptions and added a delay for improved reliability in the RichTextEditor widget within the Form Widget. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-04-01 11:25:21 +05:30
Shrikant Sharat Kandula	f9651fba37	test: Fix button label to create new JS Object (#32262 ) Reverting label change from https://github.com/appsmithorg/appsmith/pull/32226.	2024-03-30 12:07:40 +05:30
Somangshu Goswami	d7e6584d47	fix: refactored currency code data to remove duplication problem (#32242 ) ## Description we are refactoring the data used for currency input widget such that there are no duplicate entries and also add missing general entries. [Internal conversation ref](https://theappsmith.slack.com/archives/C025SE88KNE/p1711612283549969) Fixes #31806	2024-03-29 16:12:23 +05:30
balajisoundar	18882e7559	chore: Update @tinymce/tinymce-react (#32120 ) ## Automation /ok-to-test tags="@tag.TextEditor" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8477514930> > Commit: `b69e1d01c55200b58eea0704e36b940bbb8f1992` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8477514930&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced Rich Text Editor with improved styling, additional toolbar options, and updated functionality. - Style - Updated styles for the Rich Text Editor, including toolbar, editor header, and various elements within the editor. - Chores - Removed unused plugins from the Rich Text Editor. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-29 12:07:35 +05:30
Parthvi	714d8e3539	test: Update common methods and locators (#32226 ) ## Description This PR updates common method and locator which is being used in EE PR here: https://github.com/appsmithorg/appsmith-ee/pull/3247 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved visibility of certain methods and properties in the `DataSources` and `JSEditor` classes for testing purposes. - Updated a selector in the `JSEditor` to accurately target "New JS Object." <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-29 12:04:40 +05:30
Hetu Nandu	7dac89098c	chore: Add Editor Pane segments context switch tests (#32224 ) ## Description Adds tests for Editor Pane Segment's Context Switch where - If no item was selected before, an item is always selected by default - If an item was previously selected, it is selected again when switched to the segment - Add pane state is not stored and switching to the segment will not show that state Fixes #31873 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8477425225> > Commit: `af8469b31f3e0ab26c9f80fcd0bf9745b16a9ce5` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8477425225&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Introduced tests for editor segment context switching in an IDE, including item selection retention and behavior of the "add" state between segment switches. - Refactor - Modified the `ImportApp` function call to enhance context maintenance and focus during app import. - New Features - Enhanced IDE navigation by adding CSS selectors for active items and implementing a method to retrieve the selected item in the editor's left pane. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-29 11:48:59 +05:30
Aman Agarwal	af184f3cb0	feat: add edit option in suggested queries in hint commands (#32076 ) ## Description This PR introduces a new way to edit the queries directly from slash hint commands that edit button appears on hover of the hint. This also introduces an event `EDIT_ACTION_CLICK` as emitted from different other places of our application with all the similar properties except the `from` : `SlashCommandHint` <img width="566" alt="Screenshot 2024-03-27 at 12 45 09 AM" src="https://github.com/appsmithorg/appsmith/assets/7565635/34f0e226-d45a-482b-8484-7e1fdc672a04"> Fixes #32075 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8465758601> > Commit: `cff14b0006441274e182d17ff66603219971ddbd` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8465758601&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the code editor with improved command suggestions and quick command generation, including URL and event parameter handling. - Introduced new styling for command suggestions in the code editor. - Refactor - Updated functions and components for better handling and mapping of plugins within the code editor. - Chores - Added necessary imports and updated the usage of various components and utilities to support new features and improvements. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-03-28 19:24:33 +05:30
Nilansh Bansal	3cac44c519	chore: added test for asserting save button (#32113 ) ## Description > This PR adds asserts the Save button which was added in place of Save and Authorize in https://github.com/appsmithorg/appsmith/pull/32047 Fixes #32071 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8451764949> > Commit: `d86c6561c9cce0bab2f7dc405bdb609019556ba6` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8451764949&attempt=3" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced testing for GraphQL data sources by adding an assertion to verify the presence of a "Save" button for Client Credentials Grant Type scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-27 19:38:56 +05:30
sneha122	024d225ee3	fix: property pane collapse expand icon issue fixed (#32094 ) ## Description The PR fixes: Issue with icon being reversed in property pane. In property pane, for each section if it is expanded currently, it should have collapse icon beside it, if section is in collapsed state, it should have expand icon beside it. Earlier it was reverse, this PR corrects it <img width="286" alt="Screenshot 2024-03-27 at 2 02 57 PM" src="https://github.com/appsmithorg/appsmith/assets/30018882/6af152fd-895e-4529-b8da-70c8ffe0559c"> <img width="289" alt="Screenshot 2024-03-27 at 2 00 48 PM" src="https://github.com/appsmithorg/appsmith/assets/30018882/45ba123f-3102-4205-8d44-6ba25f330ca6"> Note: This PR fixes only of the UI issues mentioned in #32069 Fixes #32069 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8448851715> > Commit: `37457a290f6258fbeda84376d62327d5fbe1d78b` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8448851715&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Simplified the logic for displaying the chevron icon in the property pane sections, enhancing user interface consistency. - Updated icons for open and closed states in the property sections for clearer visual cues. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-03-27 15:12:15 +05:30
Vemparala Surya Vamsi	e151524d1c	feat: constrained diff between states (#31847 ) ## Description We are constraining the diff between the old dataTree and the newDataTree to its only affected nodes. The affected nodes list is the evalOrder, unevalUpdates and updatedValuePaths (which represents localStorage and setter updates). Through limiting the diff to the affected node list this should help in reducing the diff computation latency and overall improve the performance of each evaluation cycle. We are also cleaning up code related to compressing and decompressing updates since we deprecated that functionality. Fixes #31272 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8447023192> > Commit: `cb925afbb99577947fbc7233a35e4454223b402a` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8447023192&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced new logic for handling widget state updates efficiently. - Enhanced evaluation logic to support optimized diff updates and serialization. - Improved data tree generation for error handling and evaluation order. - Bug Fixes - Addressed issues in generating optimized updates for large collections and handling `undefined` values. - Fixed Cypress tests in the "PgAdmin Clone App" spec for more reliable interaction with UI elements. - Refactor - Simplified the logic for widget state cleanup and evaluation paths handling. - Removed unused variables and functions related to widget meta properties and evaluation paths. - Tests - Added new spec file `PgAdmin_spec.js` to Cypress limited tests for client-side regression testing. - Chores - Updated type imports across various files to reflect changes in evaluation logic. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-27 14:37:46 +05:30
Apeksha Bhosale	b716eb6f0c	chore: removed config logs from debugger (#32049 ) ## Description what has been removed? --> 1. all config update to widget, action and js action including adding/editing/deleting new functions 2. all logs which are dependent of these config paths Fixes #`Issue Number` _or_ Fixes [`Issue URL`](https://github.com/appsmithorg/appsmith/issues/32063) > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8432287062> > Commit: `1c48cbbbf2c11312d8b23f23ce20cee8a9245741` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8432287062&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Simplified and cleaned up the codebase across various sagas, enhancing performance and maintainability. - Streamlined logging and state management in action and debugger functionalities. - Removed unused imports and functions, particularly in handling JavaScript functions within the app. - Tests - Updated and refactored test descriptions and cases in different Cypress test files to improve clarity and organization. - Removed unnecessary test cases related to modifying widget properties and resetting debugger state. - Retained essential test cases for console log functionality with normal moustache binding. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-26 14:10:22 +05:30
Valera Melnikov	ba6262ffe6	chore: widgets alignment (#31923 ) ## Description Plenty changes related to widgets alignment 1. Paragraph, button, inputs, single checkbox and switch widgets are aligned along the baseline of the text content 2. The icons in the buttons and the single checkbox and switch are now positioned absolutely so as not to affect the height of the components. The height of the components now depends on text content. 3. All unnecessary paddings and borders in the layout have been removed: - Canvas padding: `--outer-spacing-4` - Gap between sections and zones: `--outer-spacing-4` - Zone padding: `--outer-spacing-3` - Gap between widgets: `--outer-spacing-3` 4. In widget selection styles replace `border` with `outline`, since the `outline` one does not take space. 5. Add Changes to the flex-basis calculation method. Now the gap between the zones is taken into account there. 6. Add a lot of small fixes related to the changes described above. https://github.com/appsmithorg/appsmith/assets/11555074/b7c220eb-3e27-4039-9c15-6281bafe8008 Fixes #29364 ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8375537665> > Commit: `f85b63c0a49f30b9762379c2f8c3bd38c7a8355f` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8375537665&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Improved handling of CSS variable values in Flex components. - Enhanced styling and layout configurations for a better user experience. - Bug Fixes - Fixed label positioning and styling issues in Checkbox and Switch components. - Adjusted padding, margin, and sizing for consistency and alignment. - Refactor - Enhanced flex layout handling and space distribution logic for improved layout flexibility. - Style - Updated component styles for refined user interface aesthetics. - Chores - Updated feature flags and configurations for widgets and components to enable new functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-22 16:53:29 +03:00
sneha122	bd8850a48d	feat: show slash command prompt on focus in property pane (#31920 ) ## Description This PR adds builds on top of existing slash command menu feature. Today when we enter JS mode for any of the properties and type in `/` command, we are able to see the following menu. <img width="290" alt="Screenshot 2024-03-21 at 1 31 26 PM" src="https://github.com/appsmithorg/appsmith/assets/30018882/319d5be1-33f7-49e3-9b8d-fd8aa5fa9aed"> With the changes in this PR, now whenever we switch to JS mode for data property of Table and JSON form widgets, if we focus on the input box, we should be able to see the menu with options showing up as shown below: https://github.com/appsmithorg/appsmith/assets/30018882/30496f3c-615a-4a70-ba05-e0151c6bcdd5 Limitations: - This feature is only implemented for Table and JSON form widgets data property, based on mixpanel results we can further decide to include it for all or not. Fixes #31900 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8386142777> > Commit: `90bea1f91b3d864c984548b11ec4d3a5bd70b3f7` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8386142777&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> ## Summary by CodeRabbit - New Features - Enhanced the code editor to dynamically show a slash command menu for certain widgets, improving the user editing experience. - Introduced logic to selectively enable slash command functionality for table and JSON widgets, specifically for the `data` property. - Enhancements - Updated the code editor hint system to support additional context, including datasource information and feature flags, enriching the autocomplete and suggestion capabilities. - Bug Fixes - Fixed an issue where unnecessary bindings were applied to widgets, ensuring cleaner and more relevant code generation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced `CodeEditor` with advanced properties to support diverse functionalities including AI assistance and plugin integrations. - Introduced a function to determine the visibility of the slash command menu based on widget types. - Added specific widget properties for table and JSON widgets to enable focused functionalities. - Implemented a new feature flag to toggle learnability and ease of initial use improvements. - Tests - Added tests for Property Pane Suggestions functionality to ensure reliable autocomplete features. - Chores - Improved `PropertyPane` interaction by adding a method for focusing and asserting auto-save in text fields. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-03-22 15:14:08 +05:30
balajisoundar	7643b6e8ef	chore: fix ListV2_PageNo_PageSize_spec flakiness (#31979 ) ## Automation /ok-to-test tags="@tag.List" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8385766733> > Commit: `d9a13cf051614a9a68c38624bcaa031f2014df6b` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8385766733&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated how data is loaded in tests for ListV2 widget to enhance testing efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-22 11:56:06 +05:30
Rahul Barwal	b8ede95371	chore: Refactor feature flag `release_show_create_app_from_templates_enabled` (#31991 ) ## Description Removed the feature flag `release_show_create_app_from_templates_enabled` import and usage in the WorkspaceAction component were refactored. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Workspace" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8373858785> > Commit: `8e813e49585b11592412bf1d194d847a7753ea60` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8373858785&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results -->	2024-03-22 08:19:46 +05:30
Ankita Kinger	2f738ed360	chore: Make edit launch buttons as links & add upgrade ramps for session timeout setting (#31862 ) ## Description - Make edit launch buttons as links for better user experience - Add upgrade ramps for session timeout setting Fixes [#29829](https://github.com/appsmithorg/appsmith/issues/29829) [#31724](https://github.com/appsmithorg/appsmith/issues/31724) ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8370510386> > Commit: `b45ae17a5f28fe4706a69cc0dd141e5bb5e8b225` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8370510386&attempt=2" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a session timeout setting for user sessions, enhancing security and compliance. - Improved admin settings interface with additional configuration options for session management. - Enhancements - Streamlined navigation within the application by removing reliance on default page IDs. - Enhanced input fields in admin settings with support for default values and custom formats. - Style Updates - Updated styling for labels, icons, and text inputs in the admin settings for better user experience. - Tests - Expanded Cypress test coverage for admin settings, including checks for business and enterprise settings, authentication, branding, and navigation. - Refactor - Simplified code by renaming constants and updating component properties for clarity and maintainability. - Chores - Updated Cypress configuration and support files for improved test automation practices. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-21 15:37:13 +05:30
Apeksha Bhosale	9eba768a90	chore: added tag module for module related tests (#31790 ) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ https://github.com/appsmithorg/appsmith-ee/pull/3575#discussion_r1524187262 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test categorization by adding the `@tag.Module` tag for more precise test filtering. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-18 12:48:54 +05:30
balajisoundar	e20cf7d2b3	fix: [map chart widget] create unique instance of map loader per widget to avoi… (#31822 ) …d cross cancelling loader calls ## Description Create an instance of map loader per widget to avoid one widget cancelling calls of another widget. Fixes https://github.com/appsmithorg/appsmith/issues/31819 ## Automation /ok-to-test tags="@tag.Maps" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8292557044> > Commit: `cd13c989d8b911a064629bf1d8c683e09927d3b2` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8292557044&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the Map Widget to load maps more efficiently with the introduction of `loadMapGenerator`. - Tests - Added Cypress tests to ensure the Map Widget loads correctly on the canvas. - Refactor - Updated the Map Widget loading process for better performance and flexibility. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-15 13:17:11 +05:30
Aman Agarwal	c302c724d8	chore: removed onboarding flags ab_create_new_apps_enabled , ab_start_with_data_default_enabled (#31384 )	2024-03-15 11:13:14 +05:30
Hetu Nandu	d9b20e8c2b	feat: Rollout Side by Side (#31686 )	2024-03-13 13:12:08 +05:30
Hetu Nandu	e99cc39e47	chore: Block Selections when Canvas is in Side by Side mode (#31587 ) ## Description This pull request aims to enhance the user experience within the application by modifying the canvas behavior when it is displayed in "Side by Side" mode alongside Queries or JavaScript sections. The key change is the disabling of direct selections on the canvas, allowing interactions with canvas elements only through cmd + click or by clicking on the widget's name. This adjustment is intended to facilitate a view-only mode for the canvas during Queries or JS editing, thereby improving layout and user interaction. Additionally, the PR introduces enhancements to the application's testing framework, focusing on improving test reliability in scenarios involving UI interaction and state changes. Notable updates include: - Improved error tooltip handling in CurrencyInput_spec.js. - Ensured page state saving before verifying element presence in Listv2_BasicChildWidgetInteraction_spec.js. - Replaced cy.wait("@updateLayout") with cy.assertPageSave() and introduced a delay in Listv2_spec.js to accommodate functionality changes. - Implemented visibility checks in TableV2_Button_Icon_validation_spec.js to prevent timing-related test failures. These technical updates collectively aim to bolster the application's testing framework, enhancing the reliability and accuracy of automated tests, especially in UI interaction and state change scenarios. #### PR fixes following issue(s) Fixes #30864 ## Automation /ok-to-test tags="@tag.Widget" <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8259916944> > Commit: `15e1cf937a9d15adaea68e16a55006d993a07cbf` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8259916944&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added new constants for widget selection and focus management. - Introduced a new event type for tracking widget selections in code mode. - Tests - Enhanced test assertions and interactions for better reliability and error handling in various widgets. - Refactor - Improved widget selection logic and URL handling for a more intuitive user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-13 11:53:49 +05:30
Gurudatt S A	efce75ceb6	fix: Added index.d.ts file to enable auto code completion for custom commands in Cypress tests (#31696 ) Co-authored-by: Gurudatt SA <>	2024-03-12 19:18:36 +05:30
Shrikant Sharat Kandula	1eb7f0e171	chore: Remove "Save theme" functionality (#31481 ) This is deleting a defunct feature. [Slack thread](https://theappsmith.slack.com/archives/CGBPVEJ5C/p1709621165627549).	2024-03-12 18:54:39 +05:30
Hetu Nandu	90760da7ca	feat: New IDE Top Navbar (#31594 ) ## Description Replaces the current App IDE Navbar with the new one. Fixes #31603 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8244382997> > Commit: `5dba98f326ce504de0bf32b56c195d615279bf69` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8244382997&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Centralized page management actions in Cypress tests using the new `PageList` module. - Tests - Enhanced Cypress test reliability and readability by consistently using `PageList` methods for page management. - Chores - Optimized test support infrastructure by removing outdated commands and imports in Cypress support files. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-12 14:02:58 +05:30
Abhinav Jha	55487f5865	fix: Deselect all widgets on canvas click (#31653 ) ## Description Clicking on the canvas in Anvil layouts did not deselect all widgets. This PR fixes it. Now all widgets ## Approach In the `AnvilMainCanvas` we check if the origin of the click event is the Main Canvas. If it is, we allow the function to deselect all widgets to run. ## Automation /ok-to-test tags="@tag.Anvil" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the logic for clearing widget selections to enhance user experience when interacting with the main canvas. - Tests - Added a test case to ensure clicking on the canvas deselects all widgets and verifies the border color of widgets within the main canvas. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-11 20:45:47 +05:30
gzlinzihong	85269c432c	fix: file picker widgets removing files causing abnormal content (#31646 ) ## Description > fix filepicker widgets selects multiple files and then removes one of them, causing the final content of all file.data to be abnormal > > #### PR fixes following issue(s) Fixes # (issue number) > [31411](https://github.com/appsmithorg/appsmith/issues/31411) #### Type of change - Bug fix > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. - Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - My code follows the style guidelines of this project - I have performed a self-review of my own code - I have commented my code, particularly in hard-to-understand areas - My changes generate no new warnings - New and existing unit tests pass locally with my changes <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the File Picker widget to support more interactive functionalities like setting maximum file limits and custom data formats. - Tests - Added tests for new functionalities in the File Picker widget, including file uploading, setting restrictions, and file removal verification. - Bug Fixes - Fixed an issue with file data retrieval in the File Picker widget to ensure accurate data is presented after files are removed. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: linzihong <linzihong@corp.netease.com>	2024-03-11 18:13:12 +05:30
balajisoundar	2c7b3684d6	chore: [map chart widget] update the label counts and snapshot in spec (#31648 ) ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Maps" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/8231075012> > Commit: `07f432e3206c6b370265078607b285e94eb0aacd` > Cypress dashboard url: <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8231075012&attempt=1" target="_blank">Click here!</a> > All cypress tests have passed 🎉🎉🎉 <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated MapChart widget test cases, including selector changes and modified assertions. - New Features - Enhanced the MapChart Widget to render charts using SVG for improved performance and quality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-11 16:34:34 +05:30
sneha122	394093f6d5	fix: removed unnecessary checks for create action api in spec file (#31656 ) ## Description Fixed `GlobalSeach_spec.ts` test case, it had unnecessary check for create action API, removed that. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated the `navigatesToApi` test case in the Global Search feature to refine validation criteria. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-03-11 16:32:34 +05:30
sneha122	1da73775b8	chore: create action source instrumentation added (#31585 ) ## Description Added server side create action instrumentation for following cases: Action \| Source \| Frontend/Backend \| Tests Added? -- \| -- \| -- \| -- Create Action / query from any other place in app (entity explorer / datasource preview / ombinar) \| self \| source sent from frontend \| Cypress Drag a table widget → Click connect data → Select datasource → select table → click on connect data \| one-click-binding \| source sent from frontend \| Cypress Generate CRUD triggered from new page menu or datasource preview \| generate-crud-page \| source set in backend \| No When page is cloned \| clone-page \| source set in backend \| No When application is forked \| fork-application \| source set in backend \| No #### PR fixes following issue(s) Fixes #31173 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced event tracking capabilities by introducing an enumeration to track the source of action creation for analytics. - Enhancements - Improved action creation flow by specifying the source in various components, aiding in precise analytics and debugging. - Streamlined analytics properties method across services for consistency and simplicity. - Bug Fixes - Adjusted assertion logic in Cypress tests to validate the source of action creation accurately, ensuring reliability in automated testing. - Refactor - Simplified method signatures and logic in server-side analytics handling for better maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-03-11 10:22:24 +05:30
Hetu Nandu	98edccb970	chore: Add back Preview Mode shortcut (#31602 ) Adds back the preview mode shortcut now with a modifier key to be `⌥ + P` on mac or `Alt + P` on windows <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the Preview Mode with additional hotkeys (`alt + p`) for toggling, improving user experience in navigating the editor. - Improved tooltip messages for better clarity on shortcuts available to the user. - Tests - Updated regression tests to cover new Preview Mode functionality and ensure its reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-11 10:02:19 +05:30
balajisoundar	cf6ba4c8fd	chore: Remove FEATURE_FLAG release_custom_widgets_enabled (#31577 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description > Add a TL;DR when description is extra long (helps content team) > > Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation > and context. List any dependencies that are required for this change > > Links to Notion, Figma or any other documents that might be relevant to the PR > > #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Removed feature flag checks and related functionality across the application, impacting widget visibility and behavior. - Tests - Updated test setups and cases to align with the removal of feature flag dependencies. - Chores - Cleaned up unused code and constants related to the now-removed feature flags. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-08 11:50:35 +05:30
Ankita Kinger	beba3afb60	chore: Removing partner program callout from invite modal (#31576 )	2024-03-07 13:20:51 +05:30
Ashok Kumar M	c209b47671	chore: clean up space distribution feature in Anvil (#31468 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description This PR addresses two particular things with space distribution - Issue: Space distribution distributing more than max column limit space - Enhancement: Replace flew grow css for zones to flex basis to make sure column widths are even irresepective of number of zones in a section. Additional Fixes: - replaced test id of widgets editor to abide by repo standards. - disable crud app generation feature for Anvil. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enabled new feature flags to enhance application capabilities. - Introduced dynamic space redistribution for improved layout management. - Added "Generate App" functionality for users with specific feature access. - Enhancements - Updated UI selectors for better consistency and reliability. - Refined layout system logic to always utilize the Anvil layout system. - Refactor - Optimized feature flag selection logic for efficiency. - Improved flex property handling in layout components for more accurate space distribution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-06 12:59:44 +05:30
Ashok Kumar M	128e7bc686	fix: Enable multi widget selection in Anvil (#31305 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description Fixing Selection to allow multi selection of widgets. > #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced widget selection and interaction by updating event handling across components. - Modified types to align with event handling needs. - Updated event detail objects and handling in various hooks and utilities. - Tests - Added new test cases for widget selection with Ctrl + Click. - Updated existing test cases for improved coverage and accuracy. - Enhanced test case descriptions for better clarity. - Introduced a new parameter in a test function for improved testing capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-01 15:20:09 +05:30
Rudraprasad Das	ac1740aaa7	chore: git continuous delivery automation tests (#31131 ) ## Description Adds automation tests for Git continuous delivery #### PR fixes following issue(s) Fixes #31130 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the GitSync functionality for better user experience. - New Features - Added the ability to dynamically set test identifiers for the Copy button, enhancing testing capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-03-01 14:05:16 +05:30
Hetu Nandu	1d4198048c	chore: Debugger Split states (#31043 ) ## Description Creates local states for the debugger for Query Pane, Api Pane and JS Pane and separates it from the main Canvas Debugger state. This is done so that in Split pane, the states of Action Pane debugger can be different from the Canvas Debugger state. To keep handling the Fullscreen Debugger experience, a new hook `useDebuggerTriggerClick` is introduced which opens the correct debugger based on the IDE state. Also removes the Error and Logs from the Query / Api / JS Debuggers when in split screen mode for a cleaner debugging experience ##### This change removes the expectation of having a common debugger state that follows around as the user navigates in the IDE. Instead it create a new debugger state per entity item. The tests have been updated to reflect this #### PR fixes following issue(s) Fixes #30836 Fixes #30342 #### Media #### Type of change - Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Testing #### How Has This Been Tested? - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed	2024-02-29 11:53:57 +05:30
Rahul Barwal	1bcae40616	chore: Add spec for create new app from template (#31311 ) ## Description This pull request adds a cypress spec for create app from templates option. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enabled the creation of new applications directly from templates without the need for feature flags. - Enhanced user interface for selecting templates when creating new applications. - Tests - Added client-side regression tests for creating applications from templates. - Refactor - Streamlined the process for initiating the creation of an application from a template in the UI. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-28 14:42:35 +05:30
Rahul Barwal	a3597acae5	fix: Add useEffect hook to close modal when reconnecting modal is open (#31200 ) ## Description This pull request adds the useEffect hook to the CreateNewAppFromTemplatesWrapper component. The useEffect hook listens for changes in the isReconnectingModalOpen state and closes the modal when it is true. This ensures that the modal is closed when the reconnecting modal is open. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new state to automatically close the modal when certain conditions are met, enhancing user experience. - Adjusted the control flow in the test scenario to improve accuracy. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-27 15:21:53 +05:30
Aishwarya-U-R	c1bfd080f4	test: Cypress \| Flaky fixes (#31270 ) ## Description - This PR fixes flakyness in below specs: - cypress/e2e/Regression/ClientSide/Fork/ForkApplication_spec.ts - cypress/e2e/Regression/ClientSide/OtherUIFeatures/ExportApplication_spec.js - By improving homePage.OpenWorkspaceOptions() & homePage.RenameWorkspace() methods #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after CI runs were successful & changes reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Expanded coverage of limited tests with new spec files and temporarily disabled one existing spec. - New Features - Enhanced the workspace renaming feature in the HomePage with additional checks for element visibility and network status. - Refactor - Updated the `TypeAndClearTextField` method in `AggregateHelper` to return results, improving testability and feedback. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-27 14:25:33 +05:30
Aman Agarwal	acf51cc91b	feat: js enabled by default for 1 click binding (#31162 )	2024-02-26 14:03:36 +05:30
Aishwarya-U-R	30300bb6a4	test: Cypress \| Replacing some external api's with TED + Flaky fix (#31118 ) ## Description - This PR does some clean up of comments - in DeployHelper.ts - This PR replaced external image api with TED mock api in ServerSide/OnLoadTests/OnLoadActions_Spec.ts - Extrenal example api to TED in Widgets/Image/Image_spec.js - Extrenal api links in app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Bugs_Spec.js to TED api's - Flaky fixes /ServerSide/LoginTests/LoginFailure_spec.js - for EE CI run failure (Added multiple Dynamic checks) - support command.js method LoginUser() - added Dynamic check - Encapsulated Datasources/Arango_Basic_Spec.ts into conditional check to run in CE alone, instead of entirely skipping, since its failing in EE due to chrome crash #### Media #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated Cypress regression tests to use flower images instead of cat images for API calls. - Modified limited test configurations to run with different spec files. - Adjusted GitHub Actions workflow to change `matrix_count` values based on the event type and retrieve PR number for manual triggers. - Updated Docker image tag in CI tests to `nightly`. - Refactor - Enhanced `DataManager` class with new properties for flower image URLs. - Improved `EntityExplorer` class method to ensure more reliable triggering of events. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-23 13:18:01 +05:30
albinAppsmith	201d9541bc	fix: Cypress scroll on trigger events (#31248 ) ## Description This PR fixes the cypress failure issue due to scroll. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/31263 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated the handling of mouse events in the Entity Explorer to improve user interaction with draggable elements. - Tests - Added a new test spec for exporting applications and updated the test spec for forking applications in the limited tests configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2024-02-23 12:47:10 +05:30
Pawan Kumar	55fb2ce467	fix: Widget Sidebar Spec (#31196 ) In my last PR, I broke the widget_sidebar_spec, this PR fixes that. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated CSS selectors in test support files for improved consistency and reliability. - Tests - Added the `@tag.Widget` tag to improve organization in Entity explorer tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>	2024-02-19 15:49:57 +05:30
balajisoundar	29d6422922	fix: [custom widget] height issue in auto layout (#31176 ) ## Description Adds condition to stop custom widget from growing continuously in auto height #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/31170 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced dynamic layout handling in Custom Widgets to support auto layout and fixed height configurations. - Tests - Added automated tests to verify custom widget height adjustment in auto layout mode. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-16 13:53:14 +05:30
Hetu Nandu	275c7f5394	test: Fix Graphql test for Datasource list check (#31120 ) ## Description Test Fix Removes the reference of right pane Datasource List for Apis and Graphql and uses the input url instead <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the naming and selection process in the Data Sources management for enhanced usability. - Updated functionality related to intercepting a POST request for improved reliability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-15 11:51:25 +05:30
Ashok Kumar M	f7d41891b8	fix: Anvil toggleable widgets not working when native callbacks are used for AnvilFlexComponent (#31125 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description In last weeks effort of cleaning up Editor and Viewer parts of AnvilFlexComponent I had changed synthetic React callbacks to native ones #30780 . This has resulted in regression of widget toggling of widgets like Checkbox, Switch, etc. so changing them back to synthetic events by passing callbacks and props to the viewer part of AnvilFlexComponent. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new testing suite for validating widget interactions in Anvil Layout Mode, focusing on switch and checkbox widgets. - Added new functionalities for switch and checkbox widgets, including selection toggling and state verification. - Enhanced Anvil editor components to support custom click behaviors, improving widget interaction in edit mode. - Bug Fixes - Addressed issues with native click callbacks interfering with widget events. - Tests - Added comprehensive test cases for new widget functionalities and interactions. - Refactor - Updated internal logic for widget selection and style adjustments based on interaction states. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-15 11:00:57 +05:30
Aman Agarwal	7ae87dc061	chore: added new test cases for different plugins (#31068 ) ## Description Added test cases for start with data flow by default. The test cases are added for : - `Postgres` : It should redirect to ds page with schema preview - `Mysql` : It should redirect to ds page with schema preview - `S3` : It should redirect to ds page with config and we can create query on top of it - `Airtable` : It should redirect to ds page with config and we can create query on top of it - `REST API` : It should redirect to action page and the action creation is successful #### PR fixes following issue(s) Fixes #30806 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Expanded and refined test descriptions and cases for the "Start with data userflow," focusing on creating and saving data sources for Postgres, MySql, S3, Airtable, and Rest API actions. - Refactor - Modified access level of a method in the `ApiPage` class to enhance testability. - New Features - Introduced a new property in the `DataSources` class to improve data handling capabilities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-13 17:19:13 +05:30
Hetu Nandu	fb0472d241	chore: show suggested widgets in response (#31008 ) ## Description Show the Suggested widgets panel in the response pane in the bottom instead of the right side. This will greatly simplify the Query and Api screens. - Removes functionality of suggested widgets from the right pane context - Only renders the right pane if `additionalSections` is passed - Adds a new Bind Data button in the Response Pane - OnClick of button, a menu with suggested widget bindings show up #### PR fixes following issue(s) Fixes #30968 #### Media https://github.com/appsmithorg/appsmith/assets/12022471/20e239ad-dea4-4755-b199-4f0920ae1d46 #### Type of change - New feature (non-breaking change which adds functionality) - This change requires a documentation update ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Introduced a new `BindDataButton` component for easier data binding to widgets in the visual editor. - Updated UI elements and interactions in the API and Query editors for improved usability. - Added an import statement for `Widgets` from the `DataSources` module. - Changed the method call from clicking on a suggested table widget to adding a suggested widget of type `Table`. - Refactor - Simplified and streamlined the `ActionRightPane` component by removing outdated functionalities. - Adjusted UI components and layouts across various editor components for better consistency and usability. - Bug Fixes - Fixed text inconsistency in the `CONNECT_EXISTING_WIDGET_LABEL` constant. - Removed unnecessary `useEffect` hook in the `EntityBottomTabs` component to improve performance. - Chores - Removed deprecated code and unused imports across several files to clean up the codebase. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-13 13:52:04 +05:30
Pawan Kumar	b7fa6425c8	fix: button group spec (#31075 ) Fixes button group spec that started failing because of #30439	2024-02-13 12:17:15 +05:30
Aishwarya-U-R	fa0eda6229	test: Cypress \| Replacing external user api with TED mock api in OnLoadActions_Spec.ts (#31029 ) ## Description - This PR replaced external user api with TED mock api in ServerSide/OnLoadTests/OnLoadActions_Spec.ts #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added dynamic API URL handling in tests for more flexible test configurations. - Enhanced Right-to-Left (RTL) support testing for the Select Widget. - Enhancements - Improved test reliability by asserting element visibility and existence in various commands and methods. - Streamlined the login and logout process in tests by optimizing command implementations. - Bug Fixes - Fixed issues with test setup by removing unnecessary timeouts and refresh calls, enhancing test execution speed and reliability. - Refactor - Updated Cypress tests to toggle between running limited tests and all specs more efficiently. - Removed deprecated timeout parameters in favor of more reliable element visibility checks. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-12 20:07:58 +05:30
Rohan Arthur	4af694681d	fix: broken line in page settings (#30951 ) ## Description for old pages that were created before the new url style, the page settings has a prompt to ask the user to change the URL. The line in this prompt is broken ![Screenshot 2024-02-06 at 14 23 12](https://github.com/appsmithorg/appsmith/assets/94514895/2feab25f-be2a-4c87-ba89-47cc9686aed2) This PR changes this line to: ![Screenshot 2024-02-06 at 14 33 41](https://github.com/appsmithorg/appsmith/assets/94514895/920a5e7d-dabd-48a0-92c4-0b079232f2dd) For testing, you can get an example old app from [here](https://theappsmith.slack.com/archives/C02JT9CSE6L/p1707204475068809?thread_ts=1706698534.445299&cid=C02JT9CSE6L) #### PR fixes following issue(s) Fixes #30922 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated the wording of messages related to setting page URLs for enhanced clarity and consistency. - Changed test tags from `@tag.Settings` to `@tag.Visual` for improved test categorization. - Modified JSEditor indentation visual tests to include additional test cases and adjustments in test descriptions. - Updated test tags from `@tag.JS` to `@tag.Visual` for consistency in test categorization. - Added `@tag.Visual` to the list of tags for test categorization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2024-02-12 13:12:19 +05:30
Aishwarya-U-R	ab51d5fd62	test: Cypress \| Downgrade Cypress to 13.5.1 (#31011 ) ## Description - This PR downgrades Cypress from 13.6.4 to 13.5.1 due to frequent WebSocket connection closed errors in CI #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Adjusted the response timeout setting for network calls to improve performance. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-09 13:33:30 +05:30
Rudraprasad Das	5c74768afc	chore: remove git release feature flags (#30962 ) ## Description Removes git related feature flags - `release_git_connct_v2_enabled` - `release_git_status_lite_enabled` #### PR fixes following issue(s) Fixes #30961 #### Media #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced Git synchronization features including better handling of workspace creation, DSL additions, and branch protection settings. - Refactor - Updated Git connection methods and deployment processes for improved efficiency and reliability. - Introduced new variables and methods for more precise control over Git settings and operations. - Tests - Added and refactored Cypress end-to-end tests to validate new Git functionalities and synchronization processes. - Style - Updated components to include `data-testId` attributes for improved testability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-09 10:22:47 +05:30
Jacques Ikot	d22b63277d	feat: starter building blocks for all users (#30909 ) ## Description Goal The starter building block on canvas experiment was a success, this PR removes the feature from behind a feature flag and makes it available to all users on the platform. Summary of changes - Remove feature flag condition in DropTarget component - Clean up unnecessary state used to find newUsers and firstTimeUsers - Remove redundant storage functions used for storing first time user and application id - Remove showStarterTemplatesInsteadofBlankCanvas prop in signUpHelper and signUpSuccess - #### PR fixes following issue(s) Fixes #30903 #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Simplified signup process by removing the option to choose starter templates or a blank canvas. - Streamlined onboarding component logic and storage management for a smoother user experience. - Optimized import organization and removed unused functions in the DropTargetComponent. - Enhanced test coverage for building blocks and starter templates in client-side templates. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>	2024-02-09 10:00:04 +05:30
Aishwarya-U-R	a6b8a3440e	test: Cypress \| Text_With_Different_Size_spec.ts re-write + Flaky fixes (#30445 ) ## Description - This PR re-writes the entire Text_With_Different_Size_spec.ts spec to fix the master run flakyness and and improves the overall complexity of the test case format - cypress/e2e/Regression/ClientSide/Onboarding/StartFromScratch_spec.ts (agHelper.VisitNAssert improved) - Master runs pass at [Run1](https://github.com/appsmithorg/appsmith-ee/pull/3337#issuecomment-1899183181), [Run2](https://github.com/appsmithorg/appsmith-ee/pull/3337#issuecomment-1899197871) - cypress/e2e/Regression/ClientSide/BugTests/AbortAction_Spec.ts (1st test - replace with TED url) - getConsolidatedDataApi() separated, created new agHelper.CypressReload() - Removed cy.log statements from few places - homePage.LogOutviaAPI() removed static wait - Replaced homePage.LogOutviaAPI(); with homePage.Signout(); in places where its flaky - Split /Onboarding/StartFromScratch_spec.ts to 3 specs to reduce flakyness - Split /ClientSide/PartialImportExport/PartialExport_Widgets_spec.ts with failing test to run the other tests in CI - /Templates/Fork_Template_To_App_spec.ts - Added dynamic check to fix CI flakiness - agHelper.AssertURL(), assertHelper.AssertDocumentReady() improved - jsEditor.NavigateToNewJSEditor() improved - cypress/e2e/Regression/ClientSide/ExplorerTests/JSEditorContextMenu_Spec.ts - jsEditor.ValidateDefaultJSObjProperties improved - cypress/e2e/Regression/ServerSide/OnLoadTests/OnLoadActions_Spec.ts - (3rd case - flaky fix) #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after changes were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Tests - Enhanced test flexibility by dynamically constructing API URLs. - Improved test setup and flow in onboarding and regression suites. - Added new test spec files for dynamic height, onboarding, bug tests, login failure, and starting from scratch scenarios. - Refactor - Updated function calls and parameters across various test files for consistency and efficiency. - Removed redundant code and streamlined test actions. - Chores - Updated intercepted HTTP methods and added new utility functions to support test operations. - Bug Fixes - Fixed issues related to element visibility assertions in test scripts. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-08 16:55:58 +05:30
Ashok Kumar M	c40b634185	fix: Fixing Anvil Section DnD Test cases. (#30995 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description In this PR we are fixing the way events are dispatched and how position values are used to activate a section. This is still not set in stone as I need to write more utils based on alignment. but the current changes would be fail proof for the time being. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved app navigation settings and layout validation. - Enhanced widget placement accuracy on the ANVIL canvas. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-08 14:12:09 +05:30
Saroj	bd653d6b81	test: Fix flakiness in fork app test (#30994 ) ## Description - Fixing flakiness in ForkApplication_spec.ts -- Changed the sequence as the sequence is causing the issue -- Removed the addDsl() from before and added to the test it is necessary. #### Type of change - Cypress ## Testing > #### How Has This Been Tested? - [x] Cypress > > <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated regression test cases related to forking applications. - Modified paths to test spec files for improved organization. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-08 13:28:14 +05:30
Hetu Nandu	1afe639911	chore: Show schema as a tab instead of the right pane (#30906 ) ## Description Moves the Schema in Query Pane from the right side to the tab on the bottom. This is done to eventually remove the right side pane for Side by Side layout #### PR fixes following issue(s) Fixes #30873 #### Media https://github.com/appsmithorg/appsmith/assets/12022471/28c5086a-1967-4a72-8dc5-0717751198cf #### Type of change - New feature (non-breaking change which adds functionality) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. - [ x ] Manual - [ x ] Jest - [ x ] Cypress <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a refresh button in the datasource structure container for easy refreshing. - Added a new state to handle scenarios with no columns to display, enhancing user feedback. - Implemented conditional rendering of components based on new props and states, improving UI responsiveness and interaction. - Enhancements - Updated placeholder texts and messages for a clearer user experience. - Improved the layout and styling of various components for better visual appeal and usability. - Refactor - Streamlined the rendering logic and state management in several components, leading to a cleaner codebase. - Removed unused imports and functions, optimizing component performance. - Bug Fixes - Fixed issues in test suites related to table schema handling and selection. - UI Changes - Adjusted styling properties for better alignment, display, and gap spacing in the datasource structure search container. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-08 13:25:23 +05:30
albinAppsmith	6e44f96a77	fix: reverting back the context changes (#30899 ) ## Description Due to test failures, original context switching fix was reverted. This PR is to add it back. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/30651 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced test scripts for improved navigation and UI interaction. - Simplified rendering logic and removed unused elements in Editor's page and IDE components. - New Features - Introduced `PageElement` component for efficient page management. - Added custom hook `useGetPageFocusUrl` for dynamic URL generation. - Tests - Updated test scripts for consistent and readable navigation methods. - Chores - Minor adjustment in `ApiCommands.js` for reliable command execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-05 22:03:53 +05:30
Ashok Kumar M	c37d0c283f	fix: Anvil Widgets not accessible when widget has no content. (#30780 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description In this PR, we are fixing a few issues and also destructuring AnvilFlexComponent for edit and view. Issues Fixed - Widgets without any content like a text widget without text are not hoverable - Modal once opened does not close when other widgets on the canvas are selected via the enitty explorer. Anvil Flex Component was common component inspired from PositionedContainer of Fixed layout. It had all features of Edit and View together in one place. This mean viewer was unnecessarily interpreting more code. Now AnvilFlexComponent has been broken into AnvilFlexComponent and AnvilEditorFlexComponent. AnvilEditorFlexComponent is a wrapper around AnvilFlexComponent with abilities needed for Edit Mode. Another issue addressed in the PR is removal of DraggableComponennt, which was just making dragging possible and providing a few styles like fading the widget when it is being dragged. With this PR all the above mentioned functions will be taken care of by AnvilEditorFlexComponent. #### PR fixes following issue(s) Fixes #30734 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enhanced feature flag management with additional flags for better control over application features. - Introduced a new editor component for Anvil layout system, improving layout and behavior management in edit mode. - Added a custom hook for managing hover states on Anvil widgets, enhancing user interaction. - Refactor - Updated AnvilFlexComponent to use `forwardRef` for better ref management and optimized widget configuration and rendering logic. - Modified selector logic to simplify the retrieval of layout system type, enhancing code maintainability. - Adjusted test methodologies to improve reliability and accuracy. - Bug Fixes - Corrected assertions in Cypress end-to-end tests to accurately locate and interact with widgets in the Anvil canvas, ensuring test reliability. - Chores - Updated common locators and assertion methods in Cypress support files for consistency and clarity in test scripts. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-05 18:00:50 +05:30
Aishwarya-U-R	4be051f143	test: Cypress \| Flaky fixes (#30892 ) ## Description - cypress/e2e/Regression/ClientSide/BugTests/AbortAction_Spec.ts (ran this multiple times & removed from flakylist) - This PR fixes below flaky specs: -- cypress/e2e/Regression/ClientSide/Widgets/Others/StatboxDsl_spec.js (2nd test) -- cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts (7th test) #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated Cypress regression tests to use `StatboxDsl_spec.js` instead of `Fork_Template_spec.js`. - Adjusted test case numbers and content for "tooltip" and "visible and disabled toggle" tests. - Removed and renumbered test case "4. Verify onClick". - Added a new test case "7. Verify onClick" with updated logic for testing onClick functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-05 17:41:51 +05:30
Aishwarya-U-R	85a447244a	test: Cypress \| Flaky fix /Workspace/ShareAppTests_Spec.ts (#30875 ) ## Description - This PR fixes cypress/e2e/Regression/ClientSide/Workspace/ShareAppTests_Spec.ts (Airgap run flakyness) #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated the file path for limited tests in the ClientSide workspace to enhance test organization. - Adjusted timing waits, reorganized test steps, and improved test flow and clarity. - Updated element interactions for better test performance. - Removed unnecessary comments and code for a cleaner test suite. - Replaced specific method calls for improved functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-05 14:16:55 +05:30
Trisha Anand	6a8039b313	Revert "fix: Navigating to page, navigate to last used segment instead of canvas" (#30891 ) Reverts appsmithorg/appsmith#30652	2024-02-05 14:11:20 +05:30
Rhitottam	489507769a	fix: minor improvement to UI controls for updating JS function settings (#30760 ) ## Description - Change UI for controlling JS function settings from radio buttons to switch toggles. #### PR fixes following issue(s) Fixes # [(30098)](https://github.com/appsmithorg/appsmith/issues/30098) #### Media <img width="569" alt="Screenshot 2024-01-31 at 10 31 50 AM" src="https://github.com/appsmithorg/appsmith/assets/4265002/781ffe06-4862-4ceb-967c-a2e9ebc6dbd8"> #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new `Switch` component in the JavaScript function settings for a more intuitive user interface. - Refactor - Updated test support for the JavaScript editor to align with the new `Switch` component, enhancing test reliability and coverage. - UI Enhancements - Replaced `RadioGroup` components with `Switch` components in the `JSFunctionSettings` file to improve user interaction. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-05 12:22:20 +05:30
albinAppsmith	b68f349eb6	fix: Navigating to page, navigate to last used segment instead of canvas (#30652 ) ## Description As of now, when user clicking on page, user gets navigated to UI first then will it will take to the recent tab. This PR will navigate directly to the recent segment. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/30651 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced IDE with additional parameter support in `useCurrentAppState`, `useSegmentNavigation`, and `useGetPageFocusUrl` functions for improved state management. - Tests - Improved Cypress E2E tests across various modules (Regression, ClientSide, Apps, Git, Sanity) with updated navigation and control flow using `PageLeftPane.switchSegment` for more precise page and segment selection during testing. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Hetu Nandu <hetu@appsmith.com>	2024-02-05 10:05:07 +05:30
Saroj	686dfeeec0	test: Fixing flaky specs (#30818 ) ## Description - Fixed flakyness in ForkApplication_spec.ts - Removed FirstTimeUserOnboarding_spec.js as the the tests/scenarios covered are not relevant anymore due to new changes and the required changes has been covered in StartFromData_spec.ts and StartFromScratch_spec.ts already <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test automation by integrating `agHelper` and `assertHelper` functions, improving efficiency and reliability in test execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-02 18:57:13 +05:30
Aishwarya-U-R	7824a702ca	test: Cypress \| Skip bug test from MultiSelect5_spec.ts (#30871 ) ## Description - This PR does below: - Flaky fixes /ServerSide/GenerateCRUD/MongoURI_Spec.ts (no fix needed, multiple runs passing, removed from skipped list) - cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect5_spec.ts (skipped bug test & unskipping spec from CI runs) #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Tests - Updated the test specification for limited tests in the ServerSide GenerateCRUD section to improve coverage and reliability. - Switched test spec from `Fork_Template_spec.js` to `MongoURI_Spec.ts` and `MultiSelect5_spec.ts` in the ClientSide Widgets Multiselect section. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-02 18:01:05 +05:30
Aishwarya-U-R	515e28a6f1	test: Cypress \| Added Dynamic checks for Flaky fix + Cypress upgrade (#30840 ) ## Description - This PR does below: - cypress/e2e/Regression/ClientSide/Templates/Fork_Template_To_App_spec.js (to .ts with flaky fix) - cypress/e2e/Sanity/Datasources/SMTPDatasource_spec.js (multiple runs, no fix was needed, removed from skipped list) - Cypress upgrade from 13.6.1 to 13.6.4 - cypress/e2e/Regression/ClientSide/EmbedSettings/EmbedSettings_spec.js (flaky fix) - cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js (6th test - flaky fix) - assertHelper.WaitForNetworkCall() - reduced wait timeout - deployHelper.DeployApp() added dynamic checks - cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (removed redundant before hook to fix flakyness) - cypress/e2e/Regression/ClientSide/Git/GitImport/GitImport_spec.js (removed redundant before hook to fix flakyness) #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced functionality for forking a template to the current app and adding selected pages from a template. - Bug Fixes - Enhanced test stability by replacing sleep calls with dynamic wait conditions. - Improved test reliability and performance by adjusting waiting conditions for network calls and element assertions. - Tests - Updated the list of Cypress tests to include new scenarios and remove outdated ones. - Added new end-to-end tests for template forking and embed settings validation. - Chores - Optimized test support files and functions for better code maintenance and readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-02 16:01:59 +05:30
Aman Agarwal	88e072763c	fix: schema plus button for a table is visible after template menu is opened (#30849 )	2024-02-02 15:26:26 +05:30
Aishwarya-U-R	67d20d9858	test: Cypress \| Helpers improved + Flaky fixes (#30735 ) ## Description - This PR fixes the RenameApplication flakyness in CI with added dynamic check - Also replacing js cy.renameApp to TS helper - Flaky fixes - cypress/e2e/Regression/ClientSide/Workspace/MemberRoles_Spec.ts (entire spec updates for EnableGAC, removed signout from 'it' blocks) - cypress/e2e/Regression/ClientSide/Workspace/ShareAppTests_Spec.ts (7th flaky fixed) - cypress/e2e/Regression/ClientSide/SetProperty/WidgetPropertySetters2_spec.ts (5th test) - cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js (2nd - added validation to match the test description, 1st & 3rd - removed static waits, Added multiple dynamic checks) - cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js (3rd & 4th flaky tests) - homePage.AssertViewPageLoad() created - homePage.LaunchAppFromAppHover() improved - homePage.Signout() - added dynamic checks - Added more validation to homePage.Signup() method with Dynamic checks - homePage.LeaveWorkspace() removed redundant SelectWorkspace call - admingSettings.EnableGAC() - added dynamic checks - featureFlagIntercept - removed static sleep, reload check improved - agHelper.VisitNAssert() - removed static sleep - homePage.OpenMembersPageForWorkspace() - removed sleep, added dynamic checks #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Refactor - Enhanced Cypress test commands across multiple test suites for improved efficiency and readability. - Refactored conditional checks and method invocations for better test scenario handling. - Tests - Updated testing approaches for application deployment, workspace management, and error handling. - Introduced new assertions for UI visibility and functional behavior in automated tests. - Chores - Optimized GitHub Actions workflow by adjusting the matrix count for build processes. - Added new test specs for limited tests in the client-side regression suite. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-01 16:42:53 +05:30
Ashok Kumar M	3808318519	fix: skip blurring text input of widgets pane for Anvil cases (#30822 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description Fixing Anvil specs as per new Widget pane focusing behaviour. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the user interaction flow in the application's layout management. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-01 11:45:55 +05:30
Hetu Nandu	4a65d6cc2d	fix: Api bug test (#30824 ) fixes the Api bug test broken in navigation <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved navigation in the test suite by integrating more specific functions for page segment switching. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-02-01 11:16:55 +05:30
Preet Sidhu	d1bf668f7d	chore: remove auto focus for search bar in widget explorer (#30606 ) ## Description Issue: Clicking on MainCanvas moves focus to the search bar in widget explorer, rather than selecting MainCanvas. Fix: Remove autofocus for the said search bar #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Removed autofocus from the search input in the widget sidebar to improve user experience. - Adjusted focus management in the EntityExplorer class method for better user interaction. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-31 09:01:12 -05:00
Ashok Kumar M	6765888eb0	chore: Anvil cypress tests (#30580 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description In this pr we are writing tests to validate a few preliminary cases of the Anvil Editor. the purpose of the task is to be able to run anvil tests along side the present suite of test cases. Things to note for Anvil based test cases - ANVIL_EDITOR_TEST tag is used for Anvil based tests to make sure relevant feature flags are set(using featureFlagIntercept) before creating pages so that Anvil pages are created. - each test case in a Anvil spec file also use featureFlagIntercept to set the relevant flags since pages are reloded before running tests. #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced Anvil editor with the ability to test app navigation, drag and drop functionality, and suggested widgets feature. - Improved accessibility and interaction capabilities within the Anvil canvas. - Tests - Added comprehensive end-to-end tests for new Anvil editor features, including app navigation settings, widget drag and drop, and suggested widgets integration. - Refactor - Introduced new constants and locators for better test structure and readability. - Style - Updated components with new attributes for improved accessibility and testing. - Chores - Added new tags for organizing tests related to the Anvil editor. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-31 11:02:38 +05:30
sneha122	b6cf348222	chore: fixed cypress sleep statement (#30743 ) ## Description This PR fixes cypress test statement of agHelper.Sleep() added in PR: https://github.com/appsmithorg/appsmith/pull/30720 #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Improved the reliability of the onboarding tests by replacing sleep timers with network status assertions. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-01-30 16:47:08 +05:30
Rudraprasad Das	5af238b771	fix: trigger issue with git settings (#30731 ) ## Description Fixes double modal opening when clicking on git settings #### PR fixes following issue(s) Fixes #30730 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Simplified Git synchronization settings by removing the `SETTINGS` enum value. - New Features - Enhanced the `DisconnectGitModal` to support conditional actions based on Git connection version. - Bug Fixes - Ensured the Git Sync modal can be closed properly from the `ConnectionSuccess` component. - Chores - Cleaned up code in the `BranchList` component by removing unused imports and commented-out sections. - Tests - Updated tests for the `ConnectionSuccess` component to ensure proper rendering and functionality of buttons. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-30 14:12:50 +05:30
sneha122	4228173c98	fix: cypress test added for onboarding start with data (#30720 ) ## Description This PR adds cypress test for issue https://github.com/appsmithorg/appsmith/issues/30620 #### PR fixes following issue(s) Fixes #30554 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Added automated tests for the "Start with data" user flow in the onboarding process. - New Features - Enhanced the UI interaction in the Data Sources page by introducing an index-based element selection feature. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: “sneha122” <“sneha@appsmith.com”>	2024-01-30 12:52:10 +05:30
Aishwarya-U-R	6e591f612e	test: Cypress \| GSheet test fixes for HomePage revamp changes (#30697 ) ## Description - This PR fixes the Ghseet tests failing in CI due to Homepage revamp changes #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the app creation process by ensuring the correct workspace is selected beforehand across various scenarios. - Modified the `specPattern` array in `cypress_ci_hosted.config.ts` to include new paths related to GSheet tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-30 11:01:56 +05:30
Aman Agarwal	c9af064d4d	fix: Cypress \| Workspace specs flaky fixes (#30722 ) ## Description - This PR fixes below flaky specs: - app/client/cypress/e2e/Regression/ClientSide/Workspace/CreateSameAppInDiffWorkspace_spec.js - app/client/cypress/e2e/Regression/ClientSide/Workspace/WorkspaceImportApplication_spec.js #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test scenario for creating applications with the same name in different workspaces. - Improved reliability of workspace import application tests by ensuring all toasts disappear before proceeding. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-29 23:01:12 +05:30
Aman Agarwal	cc620b3ab3	feat: removing delete multiple apps feature (#30661 ) ## Description Removing the bulk delete applications feature as it not generally used by many users and this was creating some UI conflicts rather than giving us some valuable output. Please follow this thread for more context : https://theappsmith.slack.com/archives/C02Q4B2AGM8/p1706249168968689 #### PR fixes following issue(s) Fixes #30660 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Streamlined the application deletion process to handle multiple deletions more efficiently. - Bug Fixes - Removed redundant code and unused features related to the multiple selection and deletion of applications. - Chores - Cleaned up various files by removing unused imports, constants, and state variables. - Documentation - Adjusted code comments and documentation to reflect removal of multiple application deletion features and related UI elements. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-29 19:51:01 +05:30
balajisoundar	ede1e4dd06	fix: Select / Multi select widget should retain the selection when the options are server side filtered (#30490 ) We are removing the validation check that checks whether the given default value is present in the source data. This validation check creates a dependency which leads to issue mentioned in the attached github issue. We are showing a helper message under the input with a message as follow: `Make sure the default value(s) are present in the source data to have it selected by default in the UI.` #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29222 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Bug fix (non-breaking change which fixes an issue) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced user guidance with the addition of a helper text property in the MultiSelect widget. - Updated Select widget with a helper text property and extended dependencies for server-side filtering. - Bug Fixes - Resolved issue where MultiSelect widget selections were cleared during server-side filtering. - Tests - Added and modified test cases for MultiSelect and Select widgets to reflect new functionalities and ensure reliability. - Style - Improved tooltip display in TableWidgetV2 by increasing the max width and changing the position for better visibility and user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-26 17:31:26 +05:30
Ankit Srivastava	a45dcfa61f	feat: Homepage experience v2 changes (#29282 ) > Pull Request Template > > Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request. > ## Description > Add a TL;DR when description is extra long (helps content team) > > Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation > and context. List any dependencies that are required for this change > > Links to Notion, Figma or any other documents that might be relevant to the PR > > #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added new workspace search functionality in the search bar. - Introduced a help button for user assistance. - Implemented new UI components for workspace selection and management. - Enhanced application card with edit permission checks. - Integrated workspace actions for creating and fetching workspaces directly from the UI. - Improvements - Improved workspace and application fetching logic. - Enhanced Global Search with updated import paths and logic. - Refined the layout and styling of the applications page and sub-header components. - Optimized workspace-related sagas and reducers for better performance and maintainability. - Bug Fixes - Fixed tooltip functionality in "Reconnect Datasources" within templates. - Corrected test logic for forking templates and applications. - Updated Cypress test commands for consistency and reliability. - Addressed issues with application URL test cases and workspace import logic. - Documentation - Updated messages and constants related to workspace and application UI elements for clearer user communication. - Chores - Cleaned up unused code and simplified selectors across various components and tests. - Refactored application and workspace selectors for improved code organization. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Dipyaman Biswas <dipyaman@appsmith.com> Co-authored-by: Abhijeet <abhi.nagarnaik@gmail.com> Co-authored-by: Nidhi <nidhi@appsmith.com> Co-authored-by: Goutham Pratapa <goutham@appsmith.com> Co-authored-by: Ankita Kinger <ankita@appsmith.com> Co-authored-by: albinAppsmith <87797149+albinAppsmith@users.noreply.github.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: Nayan <nayan@appsmith.com> Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com>	2024-01-25 19:11:48 +05:30
Rahul Barwal	e11c05495b	chore: Refactor SignUp method to simplify proficiency screen navigation (#30417 ) ## Description This pull request refactors the SignUp method to simplify the navigation process for the proficiency screen. The changes include removing unnecessary code and improving the flow of the method. Ï #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Streamlined the signup process for enhanced user experience. - Tests - Updated automated tests to align with the new signup flow. - Style - Improved code readability and added explanatory comments in the test support files. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2024-01-25 18:19:52 +05:30
sharanya-appsmith	f6845d16f2	test: Cypress - removed skipped cases in MergeViaRemote_spec.ts (#30617 ) ## Description > Removed skipped cases in MergeViaRemote_spec.ts #### Type of change - Chore (housekeeping or task changes that don't impact user perception) #### How Has This Been Tested - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Improved Git synchronization and conflict resolution test suite by removing, renaming, and reordering tests for clarity and efficiency. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-25 12:59:26 +05:30
Ayush Pahwa	65bbeb8837	chore: retain status of main JS object on update (#30594 ) ## Description When a JS object is updated, it's information regarding the status of being a main js object gets lost since the server is not returning the information. This pr handles this issue and retains the flag when the update is done. Main PR: https://github.com/appsmithorg/appsmith-ee/pull/3391 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the JavaScript collection update process and error handling in the app. - Tests - Removed empty lines within test descriptions in the `Admin_settings_spec.js` file. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-24 19:17:57 +05:30
sharanya-appsmith	ba6c095167	test: Cypress - separated exclude airgap cases and tagged them (#30588 ) ## Description > Moved the it blocks which has exclude airgap tag in app/client/cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.js and app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Admin_settings_2_spec.js to a new file app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Admin_settings_3_spec.ts and tagged them #### Type of change - Bug fix (non-breaking change which fixes an issue) #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Improved tagging consistency across test suites for better categorization and exclusion control. - Chores - Removed outdated test cases related to authentication page redirections, release notes access, tab redirections, and button states. - Refactor - Introduced new test scenarios for admin settings, including authentication and configuration link redirections. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-24 16:47:58 +05:30
sharanya-appsmith	e30274ae02	test: Cypress - remove width tests (#30577 ) ## Description > Removed app/client/cypress/e2e/Regression/ClientSide/Widgets/Multiselect/MultiSelect3_spec.js - > Removed width assert in app/client/cypress/e2e/Regression/ClientSide/Widgets/Radio/Radio2_spec.ts app/client/cypress/e2e/Regression/ClientSide/Widgets/Select/Select2_Spec.ts Assert removed: `agHelper.AssertCSS( widgetLocators.radioWidgetLabelContainer, "width", "151.265625px", );` and ` agHelper.GetHeight( locators._widgetInDeployed(draggableWidgets.RADIO_GROUP), ); cy.get("@eleHeight").then(($currentHeight: any) => { expect($currentHeight).to.be.greaterThan(270); });` #### Type of change - Chore (housekeeping or task changes that don't impact user perception) #### How Has This Been Tested? - [x] Manual - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Updated and streamlined end-to-end tests for Radio and Select widgets. - Refined the list of limited tests with updated widget spec names. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-24 13:05:49 +05:30
Vemparala Surya Vamsi	ad68825818	feat: Frontend changes for consolidated-api with EE test case support (#30506 )	2024-01-24 12:14:16 +05:30
Shrikant Sharat Kandula	92993cccef	chore: Remove unused services (#30292 ) I've been doing this in pieces bit by bit, not to rock the boat too much too fast, but it's taking too long, and too much effort. Instead opting for a rip-the-bandaid style, hopefully without the pain.	2024-01-23 05:43:16 +05:30
Aman Agarwal	04c0dcaad2	fix: delete multiple apps feature ui updated (#30112 )	2024-01-22 17:22:01 +05:30
Saroj	646231ff4c	test: Fixing gsheet tests (#30410 ) ## Description - Gsheet test fixes due to recent flow changes #### Type of change - Cypress ## Testing > #### How Has This Been Tested? - [x] Cypress ## Checklist: #### QA activity: - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Streamlined end-to-end test flows by removing unnecessary interactions with dropdowns and buttons in spreadsheet page management. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-19 16:30:15 +05:30
Rajat Agrawal	75ad75c57c	chore: Remove echarts feature flag (#30201 ) This PR removes the feature flag for ECharts. ECharts feature needs to enabled by default and doesn't need to be behind a feature flag anymore. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the Chart Widget by integrating Custom ECharts as a standard option. - Bug Fixes - Addressed the Chart Widget selection issue by marking the deprecated chart type accordingly. - Refactor - Streamlined Chart Widget properties and configuration for better usability. - Improved database query performance with new indexes. - Tests - Updated end-to-end tests to align with the Chart Widget changes. - Chores - Removed obsolete feature flags related to charting functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-19 11:38:34 +05:30
Aishwarya-U-R	4639965574	test: Cypress \| RepoLimitExceededErrorModal_spec.js flaky fix (#30429 ) ## Description - This PR fixes app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/RepoLimitExceededErrorModal_spec.js flakiness in CI master runs - Multiple master based CI runs done [here](https://github.com/appsmithorg/appsmith-ee/pull/3337) #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after changes were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the sign-up process in the GitSync feature for a smoother user experience. - Enhanced automated tests to align with the updated sign-up workflow. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-18 21:18:03 +05:30
Rahul Barwal	1b9f3af763	chore: Adds new test file for onboarding start from scratch userflow (#30385 ) ## Description This pull request adds a new test file for the onboarding start from scratch userflow. * It also includes an assertion for building block cards on the canvas. * Additionally, it includes changes to the templates and dataSources files to support the test. #### PR fixes following issue(s) Fixes #30384 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced the onboarding flow with additional steps and verifications. - Introduced new UI selectors for improved interaction with templates and data sources. - Tests - Updated end-to-end tests to reflect the new onboarding process and data source connection prompts. - Improved testability of UI components with the addition of `data-testid` attributes. - Refactor - Modified test setup to use `beforeEach` hook for better test isolation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-17 18:39:52 +05:30
Rahul Barwal	cfb6c99196	chore: Add cypress specs for partial import and export functionality (#30166 ) ## Description This pull request adds partial import and export tests to the application. It includes the following changes: - Adds exported file to be used in partial import export tests - Add export and import options to EntityExplorer - Adds spec to test export functionality. - Add PartialImportExportLocators.ts, EntityCheckboxSelector.tsx, JSExportedOnly.json, and index.tsx - Add test for partial export functionality for selected datasources - Adds test to check all exported sections one by one - Refactor partial export functionality tests - Refactor export and import locators - Add test for partial import functionality #### PR fixes following issue(s) Fixes #30029 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced partial export and import functionality for components such as JavaScript objects, queries, widgets, and data sources. - Enhanced Entity Explorer with new "Export" and "Import" actions. - Tests - Added test cases for validating partial export and import features. - Updated test suite to include direct app level import with data sources. - Refactor - Modified access level for the `uploadFile` property in the HomePage class to facilitate testing. - Style - Updated UI components with test identifiers to improve testability. - Chores - Updated the list of tests for running limited test scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2024-01-17 11:20:01 +05:30
albinAppsmith	4611912054	feat: removed welcome tour (#30294 ) ## Description This PR will be removing the welcome tour flow. The reason for removing this is because of new IDE redesign which will make this flow invalid. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/30082 #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Removed guided tour feature from the Help menu and related components. - Cleaned up unused code and imports across various components. - Simplified the user interface by eliminating the Welcome Tour button. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-17 10:38:29 +05:30
Hetu Nandu	72e28ea781	chore: Add some helper test methods (#30329 ) Adds a few helper methods to assert in page list Improves the flakiness and JS rename <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Bug Fixes - Improved the validation process for renaming JavaScript objects to ensure changes are reflected accurately in the user interface. - New Features - Implemented additional checks to confirm the presence or absence of page items after renaming operations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-16 15:15:20 +05:30
Rahul Barwal	1523dc40c5	chore: Add CanvasStarterBuildingBlockSeeMore_spec.ts and update related files (#30262 ) ## Description This pull request adds the file CanvasStarterBuildingBlockSeeMore_spec.ts and updates the related files. #### PR fixes following issue(s) Fixes #30021 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Enhanced onboarding experience with improved selection visibility for page entities. - Tests - Implemented new test suite for the onboarding flow. - Style - Updated UI components with `data-testid` attributes for better testability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-16 14:38:02 +05:30
Aman Agarwal	64f8a7d31e	fix: removed ab_mock_mongo_schema_enabled, ab_gsheet_schema_enabled flag code (#30113 ) ## Description Removed the code for `ab_mock_mongo_schema_enabled`, `ab_gsheet_schema_enabled` feature flags as they both have been rolled out to 100% of the users on Nov 20, 2023 #### PR fixes following issue(s) Fixes #28971 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Streamlined the process for generating CRUD pages from various data sources. - Enhanced the test suite for better coverage of data source functionalities. - Bug Fixes - Fixed issues with the CRUD generation logic and improved the reliability of deployment mode verification. - Refactor - Removed deprecated feature flags related to data source schema previews. - Simplified the logic for determining if a plugin can preview data. - Chores - Updated Cypress tests to align with the latest CRUD generation methods and removed unnecessary feature flag setups. - Cleaned up test code for better maintainability and readability. - Documentation - No visible documentation changes for end-users. - Style - No visible style changes for end-users. - Tests - Refined end-to-end tests to reflect changes in feature flag management. - Revert - No reverts in this release. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-16 14:00:51 +05:30
balajisoundar	5d44d4f2cf	chore: misc updates to custom widget (#30114 ) #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29991 Fixes https://github.com/appsmithorg/appsmith/issues/30154 Fixes https://github.com/appsmithorg/appsmith/issues/30020 Fixes https://github.com/appsmithorg/appsmith/issues/30019 Fixes https://github.com/appsmithorg/appsmith/issues/30130 Fixes https://github.com/appsmithorg/appsmith/issues/30159 Fixes https://github.com/appsmithorg/appsmith/issues/30223 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Custom widgets now support analytics events, enhancing visibility into user interactions. - Template selection, layout controls, and reference triggers in the Custom Widget Builder are now integrated with analytics. - Added new style options for custom widgets, including `primaryColor`, `backgroundColor`, `borderRadius`, and `boxShadow`. - Bug Fixes - Corrected a typo in the constant title for better clarity. - Updated help text for the Container Widget to accurately describe the widget's border edge. - Enhancements - Improved user interface with additional styling for reference names in the Custom Widget Builder. - Enhanced debugger functionality with `useCallback` optimization and new analytics logging. - Refactor - Streamlined the property pane by introducing a new `LabelContainer` styled component. - Refined the handling of dynamic binding paths to ignore certain properties efficiently. - Documentation - Added a new constant for the default model documentation URL in the Custom Widget Builder. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-16 10:52:17 +05:30
Vemparala Surya Vamsi	8bb61d996a	chore: reverted consolidated api (#30314 ) ## Description Reverted consolidated api changes and also some CE related changes to make it compatible with EE. #### PR fixes following issue(s) Reverts #29650 & #29939 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > > > ## Testing #### How Has This Been Tested? - [ ] Manual - [ ] JUnit - [ ] Jest - [x ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced the reliability and efficiency of Cypress e2e tests by adjusting wait conditions and assertions. - Simplified network request handling across various test cases. - Updated test logic to align with changes in application data structure and network requests. - Tests - Improved test stability for application import/export, Git sync, page load behavior, and widget interactions. - Refined mobile responsiveness tests to accurately validate layout conversions and autofill behaviors. - Chores - Removed deprecated feature flags and code related to consolidated page load functionality. - Cleaned up unused parameters and simplified action payloads in Redux actions. - Documentation - Updated comments for clarity in test specifications. - Style - Adjusted code styling for consistency across test suites. - Bug Fixes - Fixed data retrieval logic in tests to ensure correct data extraction from API responses. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-16 10:16:48 +05:30
Vemparala Surya Vamsi	96701c343d	feat: Frontend changes for consolidated-api (#29933 ) ## Description Our objective in this pr is to improve the page load time of our application by calling a consolidated-api which contains all the resources to load our pages. This PR contains all the client side changes to call the consolidated-api as well as feature flag related changes. Fixes #29650 & #29939 #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated network request aliases and response handling in end-to-end tests. - New Features - Introduced a new API class `ConsolidatedPageLoadApi` for fetching consolidated page load data. - Tests - Enhanced testing for application URL navigation and data retrieval. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-15 10:00:29 +05:30
Shrikant Sharat Kandula	1afb310cab	test: Fix SMTP test to work with maildev (#30287 ) We switched from exim to maildev in TED for an email server. This updates the test to use Maildev's API (via restserver) to get the emails to verify.	2024-01-13 21:08:57 +05:30
albinAppsmith	9bbf13debe	feat: enabled editor pane sidebar (#29882 ) ## Description This PR fixes the cypress failures introduced after editor pane #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29881 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --------- Co-authored-by: Hetu Nandu <hetunandu@gmail.com>	2024-01-12 20:13:58 +05:30
Aishwarya-U-R	f9616af954	test: Cypress \| Flaky fix JSOnLoad2_Spec.ts (#30263 ) ## Description - This PR removes the flaky test from JSOnLoad2_Spec & creates new JSOnLoad4_Spec. Bug details mentioned in comments [here](https://github.com/appsmithorg/appsmith/pull/30263#issuecomment-1888876661) #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Tests - Improved test coverage for settings button functionality in the JavaScript editor. - Updated test suite to reflect changes in async function settings verification. - Chores - Adjusted the file path for a subset of limited tests in the test configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-12 17:59:10 +05:30
Saroj	d161667e3e	test: Fix for gsheet failures (#30249 ) ## Description - Fix for gsheet failures - Renamed "gsheet" datasource to "gsheet-all" to make it unique #### Type of change - Cypress change ## Testing > #### How Has This Been Tested? - [x] Cypress ## Checklist: #### QA activity: - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Updated the data source reference for improved integration with Google Sheets. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-12 17:54:02 +05:30
Aishwarya-U-R	7a18d4ac4c	test: Cypress \| Flaky fixes + Replacing static waits (#30067 ) ## Description - This PR includes the flaky fixes of the below specs: - jsEditor.NavigateToNewJSEditor() using TS helpers (Addressing flakyness in specs /BugTests/JS_Bug29131_spec.ts, BugTests/invalidLintError_Spec.ts, ClientSide/BugTests/JS_Bug28764_Spec.ts, /ClientSide/BugTests/Bug29566_Spec.ts, ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts) - /Widgets/ListV2/Listv2_onItemClick_spec.js (toast validation updated to ts helper) - /Apps/MongoDBShoppingCart_spec.ts (Flaky fix 2nd case) - /Regression/Apps/PromisesApp_spec.js (1st test) - /ClientSide/OtherUIFeatures/ApplicationURL_spec.js (whole spec for static wait removal + flaky fixes) - /ClientSide/Templates/Fork_Template_spec.js (complete spec fixes, cypress exception fix) - /Sanity/Datasources/Arango_Basic_Spec.ts (3rd test) - /ServerSide/OnLoadTests/JSOnLoad2_Spec.ts (8th case flaky fix) - /ClientSide/MobileResponsiveTests/AutoFillWidgets_Reflow_spec.ts (2nd testcase, flow update) - /ClientSide/OtherUIFeatures/Resize_spec.js (import update) - /ClientSide/Templates/Fork_Template_spec.js (1st & 3rd for flaky fix, removed 2nd - redundant check) - /Git/GitSync/RepoLimitExceededErrorModal_spec.js flaky fix for EE repo failure - /ServerSide/ApiTests/API_Bugs_Spec.js (3rd case, removed waits, moved to TED Api) - /Apps/EchoApiCMS_spec.js (removed redundant action) - /AppNavigation/Sidebar_spec.ts, /AppNavigation/TopInline_spec.ts, /AppNavigation/TopStacked_spec.ts - added refresh calls for CI flakyness - homePage.RenameWorkspace() & homePage.NavigateToHome() & homePage.Signout() - removed static wait, added dynamic check - homePage.CreateNewApplication() - removed static wait - homePage.CreateAppInWorkspace() - removed commented code - homePage.CreateNewWorkspace() - logic improved - agHelper.AssertURL() - added timeout, removed static wait, calling assertHelper.AssertDocumentReady() - Few of agHelper methods timeout & error mesg text update - cy.Signup() - updated validations - agHelper.CheckForErrorToast() to agHelper.FailIfErrorToast() - method name - /ClientSide/BugTests/DSDiscardBugs_spec.ts - removed unnecessary method call #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after all changes were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced timeout handling across various helper methods for improved stability. - Streamlined interactions with UI elements using updated helper methods. - Adjusted test suites to utilize configuration values for consistency. - Tests - Temporarily disabled specific test suites to address current issues. - Updated test assertions and interaction patterns for clarity and reliability. - Added new test cases and assertions to cover additional functionalities. - Chores - Updated workflow variables for more efficient CI processes. - Curated the list of limited tests to focus on critical test scenarios. - Documentation - Clarified test descriptions and intentions for better understanding. - Bug Fixes - Fixed UI element interactions to prevent test flakiness and improve user experience. - Implemented page refresh before application imports to ensure clean state for tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-12 12:00:12 +05:30
Hetu Nandu	a15741f14f	fix: Widget selection context switch adjustments (#30117 )	2024-01-12 10:53:47 +05:30
arunvjn	a9b0e58d55	fix: resetWidget doesn't reset child widgets inside a list (#30121 ) ## Description > Fixes issue with resetWidget platform function not honouring `resetChildren` argument. Also, takes care of resetting meta widgets inside a list. These bug was introduced in #29151, where we moved the resetWidget logic to the worker thread, to support restoration of default values in meta fields (post setter methods invocation). > > #### PR fixes following issue(s) Fixes #30116 #### Type of change - Bug fix (non-breaking change which fixes an issue) > ## Testing > #### How Has This Been Tested? - [x] Manual > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Refactor - Streamlined evaluation logic for better performance and maintainability. - New Features - Enhanced widget reset functionality with improved cache handling. - Upgraded library installation process for JavaScript libraries within the app, ensuring more reliable and consistent performance. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-09 18:51:56 +05:30
Saroj	c6c6d5c180	test: Fix for gsheet Misc_spec (#30055 ) ## Description - Fixed test failures in Gsheet Misc_spec.ts - Removed all the static waits from the spec #### Type of change - Gsheet/Misc_Spec.ts > ## Testing > #### How Has This Been Tested? - [x] Cypress <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Optimized search operations by adjusting timeouts and removing unnecessary sleep calls for a smoother user experience. - Tests - Enhanced end-to-end test stability with improved wait mechanisms during table loads. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-05 17:37:20 +05:30
Aishwarya-U-R	01b31b3ae3	test: Cypress \| Replace static waits from Helpers + Flaky fixes (#29856 ) ## Description - This PR removes static waits from below helpers & added dynamic checks as needed: - apiPage.CreateApi(), apiPage.CreateAndFillGraphqlApi() - app/client/cypress/support/Pages/AppSettings/ThemeSettings.ts - cy.CreateNewAppInNewWorkspace() - replaced static wait with dynamic check - dataSources.NavigateToDSCreateNew() - removed wait, updated logic - agHelper.VerifyEvaluatedValue() - Flaky fix below specs: - /Git/GitSync/GitSyncedApps_spec.js (fixed testcase # 2 - 4th onwards is failing due to childbranch/master change - to be checked further) - /Git/GitDiscardChange/DiscardChanges_spec.js (EditorNavigation.NavigateToDatasource(), Sidebar.navigate()) - /BugTests/ApiBugs_Spec.ts (3rd case) - /Dropdown/Dropdown_onOptionChange_spec.js (3rd case) - /ServerSide/ApiTests/API_Search_spec.js (3rd case) - Removed extra Refresh call from before hook in /BugTests/ApiBugs_Spec.ts #### Type of change - Script update (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Bug Fixes - Improved the reliability of API creation processes. - Enhanced the user experience in theme settings by removing unnecessary delays. - Streamlined navigation in the data source creation workflow. - Refactor - Optimized test automation scripts for better performance and maintainability. - Updated element interaction methods to increase test robustness. - Refined logic for selecting and asserting UI components within test cases. - Chores - Adjusted test suite configurations to include new test cases and exclude a specific test file. - Removed redundant page refresh steps to improve test execution speed. - Tests - Added new assertions to validate the evaluated values in test scenarios. - Simplified data source and query creation in widget test cases for clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-05 11:42:03 +05:30
Ankita Kinger	9bc4c9711c	chore: Refactoring multiple environments to use editorId instead of appId (#29965 ) Reverts appsmithorg/appsmith#29942 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Streamlined the process for setting workspace and editor IDs across various components and actions. - Enhanced the route matching mechanism for improved navigation within the app. - Bug Fixes - Corrected typos and variable naming inconsistencies to ensure clarity and consistency in the codebase. - Style - Adjusted UI components for better accessibility, including the correct use of Aria attributes. - Chores - Removed unused imports and code to clean up the codebase and improve maintainability. - Documentation - Updated internal documentation to reflect changes in function signatures and payload structures. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-03 20:39:34 +05:30
Favour Ohanekwu	fded594e36	fix: improve validation error message for Table widget (#29686 ) ## Description This PR changes the validation error message for Table widgets #### PR fixes following issue(s) Fixes #28729 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Bug fix (non-breaking change which fixes an issue) > > ## Testing > #### How Has This Been Tested? - [ ] Manual > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the error message for table data validation to provide more specific guidance to users about the expected input format. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: arunvjn <arunvjn10@gmail.com>	2024-01-03 19:26:33 +05:30
Abhinav Jha	a4972258ed	fix: Fixed Layout system: Main container background underflow (#29796 ) ## Description - In the fixed layout system, the background of the canvas fell short of the bottom most widget. - This was due to an unnecessary `height: 100%` applied to the Fixed layout system. - Changed the code so that the `height: 100%` is only applied in the Anvil layout system #### PR fixes following issue(s) Fixes #29797 Fixes #29883 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [x] Cypress #### Test Plan #### Issues raised during DP testing ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Style - Enhanced the Canvas layout to adjust its height dynamically according to the layout system in use. - Tests - Introduced tests to validate the main container's overflow behavior in mobile responsive scenarios. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2024-01-03 01:17:56 +05:30
Aman Agarwal	fdf25bea50	fix: table version changed for crud (#29457 )	2023-12-29 17:49:20 +05:30
Preet Sidhu	dbda916f09	fix: undo action and highlight positions on right and bottom edges (#29909 ) ## Description 1. Make store updates atomic to ensure that undo operation works as expected. 2. Add another guard to ensure that entire highlight is always visible, esp along bottom and right edges of a layout. #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the layout saving process within the Anvil layout system. - Enhanced the calculation of highlight positions in the layout editor. - Chores - Removed unused `SAVE_ANVIL_LAYOUT` action type and related sagas. - Bug Fixes - Fixed positioning calculations for layout highlights to ensure accurate alignment and distribution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-29 08:11:49 +05:30
balajisoundar	837d0cc76a	chore: custom widget (#28926 ) ## Description This PR's adds the custom widget. #### PR fixes following issue(s) Fixes #28607 Fixes #28610 Fixes #28615 Fixes #28608 Fixes #28612 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [x] Jest - [x] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced search functionality with a wildcard option for unmatched widget searches. - Added new routes for custom widget editing. - Implemented additional editor modes for HTML and CSS. - Created new code templates and help components for custom widget builders. - Enhanced property controls with new button controls for custom widget editing. - Updated theming interfaces and constants for better theming support. - Added the CustomWidget component for embedding custom widgets in iframes. - Expanded widgets library to include the CustomWidget. - Enhancements - Improved `CodeEditor` with additional modes, props, and resize behavior. - Enhanced `PropertyPaneControlConfig` interface with dynamic dependencies and additional properties. - Refined custom widget scripts with communication channel and event handling. - Bug Fixes - Fixed visibility logic for the `ExternalWidget` card. - Documentation - Added new messages and documentation links for custom widget features. - Tests - Implemented new Cypress tests for custom widget default components and property pane interactions. - Updated workspace commands in Cypress tests. - Refactor - Streamlined `PropertyControl` state management and editing functions. - Refactored code editor hint helper logic. - Style - Added `borderLess` prop to style components without borders. - Chores - Updated constants and messages related to custom widget features. - Adjusted webpack configuration to ignore specific module warnings. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-28 12:16:28 +05:30
sharanya-appsmith	0ce1780595	test: Cypress - added @tag.excludeForAirgap, @tag.Templates tags (#29790 ) ## Description > Added excludeForAirgap tgs #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > running tbp > /ok-to-test tags="@tag.excludeForAirgap" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Test Enhancements - Improved test descriptions and added relevant tags for better categorization and filtering across various test suites. - Consolidated test logic and descriptions for clarity and coherence in test suites. - Bug Fixes - Updated test cases to reflect accurate scenarios for bugs and feature testing. - Adjusted test sequences and assertions for enhanced reliability and coverage. - Refactor - Restructured test suites for a more logical flow and clearer objectives. - Enhanced test setup steps and assertions for comprehensive validation. - Chores - Implemented a new tagging functionality for organizing test suites and cases. - Added new tags to the tagging system for improved test management. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-27 16:50:36 +05:30
Hetu Nandu	fc34360b2a	fix: Context Switching fixes for Copy and Delete (#29841 ) ## Description Fixes issues related to Segmented Lists around Copy / Delete interactions - It introduces a method to remove any focus history for a url. This is added whenever we delete or move an item to another page - It manages redirects after deleting a JS / Query / Datasource #### PR fixes following issue(s) Fixes #29697 Fixes #29694 Fixes #29700 Fixes #29699 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Implemented new redirect logic after deleting JavaScript collections, actions, and datasources to enhance user experience. - Added custom routing for JavaScript collection creation and management. - Enhancements - Updated focus history handling to improve navigation and entity tracking within the app. - Bug Fixes - Fixed entity identification logic in test paths to ensure accurate testing scenarios. - Refactor - Centralized datasource grouping logic for better maintainability and performance. - Optimized widget deletion process to handle multiple widgets efficiently. - Documentation - No user-facing documentation updates in this release. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-27 14:17:35 +05:30
Rahul Barwal	2fef626dcc	feat: adds `see more` to canvas starter templates (#29777 ) ## Description * This PR increases discovery of building blocks, allowing more building blocks to be shown in canvas. * We also refactored the way `add a page from template` functions: now we have updated store structure to reflect from where the modal open was triggered. * This pull request refactors the template styling and adds support for an optional modal layout. It also includes various updates and fixes to the styled components used in the templates feature. #### PR fixes following issue(s) Fixes #29723 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Implemented a modal for template selection with the ability to hide it. - Added a "See More" text option for template page layouts. - Introduced layout switching capability within the templates modal. - Enhancements - Updated template list and content components to support modal layout. - Added initial filter state management for template filtering. - Refactor - Renamed selectors and actions for clarity and consistency. - Improved logic for determining template forking and filter component behavior. - Bug Fixes - Adjusted styles to correctly apply margins in various layouts. - Documentation - Updated messages and constants with more accurate terminology. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-27 10:29:33 +05:30
Preet Sidhu	fa7bd6a543	feat: add layouts and widgets for sections and zones. (#29713 ) ## Description 1. Create Section Widget. 2. Create Zone Widget. 3. Create layouts and presets for Sections and zones. 4. Upate layout for Anvil Main Canvas. 5. Refactor BaseLayoutComponent. Separate renderer for edit and view modes. 6. Add childrenMap context to avoid prop drilling through all layouts. 7. Add Anvil Config for WDS widgets. #### Type of change - New feature (non-breaking change which adds functionality) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress #### Test Plan ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new `Zone Stepper Control` component for UI interaction. - Added `AnvilCanvas` and `AnvilMainCanvas` components with improved performance and interaction features. - Implemented `LayoutProvider` and `useClickToClearSelections` for better layout management. - Launched `AnvilCanvasDraggingArena` and `AnvilHighlightingCanvas` components with enhanced drag-and-drop capabilities. - New `useZoneMinWidth` hook to calculate minimum zone width based on child widgets. - Added `SectionRow`, `Section`, `ZoneColumn`, and `Zone` components for advanced layout structuring. - New `WidgetRenderer` component for dynamic child widget rendering. - Enhancements - Improved canvas activation and deactivation logic with `useCanvasActivation` and `useCanvasActivationStates`. - Enhanced drag-and-drop experience with updated `useCanvasDragging` logic. - Streamlined `AnvilMainCanvas` integration with conditional rendering based on `renderMode`. - Optimized `FlexLayout` component to handle new `isContainer` and `layoutType` properties. - Bug Fixes - Fixed issues with widget positioning and event handling in `WidgetNamesCanvas` components. - Corrected `PageView` width property type for consistent page rendering. - Refactor - Consolidated Anvil layout update management with `anvilSagas` and `anvilChecksSagas`. - Refined `SectionWidget` and `ZoneWidget` configuration for improved stability and performance. - Streamlined `LayoutElementPositionsObserver` with `layoutType` enhancements. - Documentation - Updated comments and added clarifications for better developer understanding of canvas-related hooks and components. - Style - Modified `.anvil-canvas` class styles for full-width and height presentation. - Chores - Cleaned up import statements and removed unused code across various components and utilities. - Tests - Enhanced Cypress tests with additional selectors and interaction commands for `AutoDimension` feature verification. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com>	2023-12-26 09:16:58 -05:00
albinAppsmith	7cef42d656	fix: Blank states sidebar (#29768 ) ## Description This PR fixes all the blank states in the left pane of the editor. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/29696 #### Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Streamlined the user interface by simplifying components and removing unnecessary permission checks. - Consolidated empty state messaging across different sections for a more unified user experience. - Style - Updated iconography in the IDE sidebar for better visual representation. - Documentation - Improved in-app messaging and descriptions to enhance user guidance. - Bug Fixes - Fixed conditional rendering issues to ensure consistent display of empty states when no items are present. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-26 14:39:14 +05:30
Aman Agarwal	5daaf98452	fix: updated the design for the admin users (#29712 ) ## Description This PR updates the design of the admin users UI for profiling questions to newer version. Below are the list of changes introduced in this PR : - Deprecated `role` property for the user - Updated components to reuse the similar UI - Updated the background image for the admin setup screen - before <img width="1325" alt="Screenshot 2023-12-21 at 10 29 52 PM" src="https://github.com/appsmithorg/appsmith/assets/7565635/31cc44b6-4534-4a6a-a5e4-1e84b2d5705c"> - after <img width="1295" alt="Screenshot 2023-12-21 at 10 51 58 PM" src="https://github.com/appsmithorg/appsmith/assets/7565635/c4181ded-ec7d-4b68-8b3c-3d0699d00c9c"> - Changed the profiling questions for the admin second page while setting up the instance - before <img width="1273" alt="Screenshot 2023-12-21 at 10 30 16 PM" src="https://github.com/appsmithorg/appsmith/assets/7565635/6f7c5c8c-7f9f-470b-bb2e-3e94b1a741fc"> - after <img width="1311" alt="Screenshot 2023-12-21 at 10 51 48 PM" src="https://github.com/appsmithorg/appsmith/assets/7565635/355c4123-a686-4423-a312-5e67c1c39c13"> #### PR fixes following issue(s) Fixes #29692 > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new `UserWelcomeScreen` component to enhance the user onboarding experience. - Added a proficiency level selection to the user setup process. - Updated the use case selection options for a more tailored setup. - Bug Fixes - Fixed issues with form input handling for proficiency and use case selections. - Refactor - Streamlined the setup process by removing role selection and custom use case input. - Refined the user interface elements related to the setup forms. - Documentation - Updated constant messages to align with the new setup flow. - Style - Implemented new styles for the `WelcomeBackground` and its components to improve visual appeal. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-25 17:54:46 +05:30
Aishwarya-U-R	39ebef39a5	test: Cypress \| Replace static with Dynamic checks (#29664 ) ## Description - This PR removed static wait from spec - API_with_List_Widget_spec - Git/GitSync/GitSyncedApps_spec.js (fixes for EE flakyness - WIP - still failing in chrome, pass in electron) - Remove wait from OpenPaneAndChangeThemeColors() & added n/w check - Upgrading Cypress from 13.3 to 13.6 - Flaky fix: - ClientSide/Widgets/Text/Text2_Spec.ts - ClientSide/Widgets/Select/Select2_Spec.ts - cypress/e2e/Regression/ClientSide/JSLibrary/Library_spec.ts - /ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - New Features - Enhanced Git synchronization capabilities with improved user interface interactions. - Streamlined navigation back to the editor from deployment mode. - Implemented more robust table loading checks to ensure data is properly displayed. - Bug Fixes - Fixed issues with element presence assertions to improve test reliability. - Addressed the visibility of certain UI elements to ensure they appear as expected. - Tests - Updated end-to-end test scripts to reflect new interactions and assertions. - Added a new test file `GitSyncedApps_spec.js` to cover Git-synced applications. - Removed outdated test file `Fork_Template_spec.js`. - Refactor - Improved method calls for querying and interacting with elements to enhance test stability. - Optimized wait conditions for element visibility to reduce flakiness in tests. - Chores - Adjusted the GitHub Actions workflow for client-server build to refine output for matrix counts. - Updated CI test workflow to incorporate Electron setup and remove Chrome setup steps. - Documentation - Included comments to explain the rationale behind certain timeout values and method changes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-22 17:20:05 +05:30
Jacques Ikot	c8217e63a5	feat: improve templates listing page in start with templates flow (#29524 ) ## Description Enhancements to Templates Gallery: 1. Fixed Template Heights: Adjusted the template card display to feature a fixed height for each template, providing a consistent and visually appealing layout. 2. Title Update to "Operations": Revised the section title from "Templates" to "Operations" to better reflect the purpose and content of the gallery. 3. New Card for Building Blocks: Created a new card to accommodate building blocks seamlessly. This enhancement ensures a more comprehensive representation of the available elements within each template. 4. Transition to Grid Layout: Replaced the Masonry layout with a grid structure for improved alignment and visual harmony between templates and building blocks. This change enhances the overall organization and presentation of content within the gallery. Figma - https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=4293-41441&mode=design&t=nPvqyNdtbtsKmvm2-0 #### PR fixes following issue(s) Fixes #29456 #### Media #### Type of change - New feature (non-breaking change which adds functionality) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced styled components for improved layout and design of building block templates. - Added a new "Fork" button with tooltip functionality to Building Block components. - Implemented a grid layout for template presentation using the new `TemplateGrid` styled component. - Created a `FixedHeightTemplate` component to enforce consistent sizing and text truncation for template elements. - Enhancements - Updated the `BuildingBlock` component to support a new `onForkTemplateClick` event. - Refined the visual presentation and layout of templates with updated CSS styles. - Improved the template filtering interface with new selectors and loading indicators. - Enhanced the `TemplatesContent` component to include search functionality and display the count of templates and filters. - Bug Fixes - Fixed issues with template rendering by replacing the use of `Masonry` with `TemplateGrid`. - Adjusted the `RequestTemplate` component to correctly display the request text based on the `isBuildingBlock` prop. - Refactor - Refactored the `TemplatesContent` component into `StartWithTemplateContent` and `StartWithTemplateFilters` for better modularity. - Removed redundant code and imports across various template-related components and files. - Streamlined test scripts by introducing custom helper functions for template interactions. - Documentation - Added a new message constant `REQUEST_BUILDING_BLOCK` for requesting building blocks. - Style - Applied updated styles to the `SearchWrapper` and `ModalContentWrapper` components for better visual consistency. - Chores - Updated the `TEMPLATE_BUILDING_BLOCKS_FILTER_FUNCTION_VALUE` constant to reflect the correct terminology. - Tests - Modified test cases related to filtering templates and forking templates to reflect changes in the UI and functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>	2023-12-22 13:41:35 +05:30
Aishwarya-U-R	c03e04aedb	test: Cypress \| Flaky fix SetOptions_Spec.ts for EE failure (#29767 ) ## Description - This PR fixes SetOptions_Spec.ts which is flaky in EE #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Improved wait conditions and element retrieval methods for enhanced end-to-end test reliability. - Updated assertions to improve test accuracy and stability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-21 14:32:38 +05:30
Hetu Nandu	8e88676243	fix: Widget Context Switching (#29735 ) ## Description Fixes context switching issues related to Widget List ensuring it also works for current prod #### PR fixes following issue(s) Fixes #29695 #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added a search functionality to the app. - Integrated a search bar at the top of the `Hero` component and a `Search` component to the `App` component. - Included styles for the search bar in the application. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-20 12:26:16 +05:30
Pawan Kumar	1f38d7333a	chore: add action group component (#29645 ) Fixes #29425 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced an icon alongside menu items, with positioning options. - Implemented a new `ActionGroup` component to manage a group of actions with overflow behavior and keyboard navigation. - Added new `ActionGroupItem` and `MoreIcon` components for action groups. - Enhancements - Improved resize handling in the `ThemeProvider` for conditional rendering based on measurements. - Updated button styles to adjust minimum inline sizing for better layout. - Documentation - Created Storybook stories to showcase `ActionGroup` configurations and usage. - Style - Modified list item styling in the `Menu` component to incorporate icons. - Tests - Added mock for `useDebounce` hook in `AppsmithIDE` tests. - Updated Cypress test assertions to accommodate changes in layout behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Valera Melnikov <valera@appsmith.com>	2023-12-19 16:04:27 +03:00
sharanya-appsmith	97d5e60842	test: Cypress - tags added - @tag.Workspace, @tag.Datasource, @tag.JS, @tag.PropertyPane (#29704 ) ## Description > Added tags to cases - cypress/e2e/Regression/ClientSide/Workspace - @tag.Workspace - cypress/e2e/Regression/ServerSide/ApiTests - @tag.Datasource - cypress/e2e/Regression/ServerSide/Datasources - @tag.Datasource - cypress/e2e/Regression/ServerSide/GenerateCRUD - @tag.Datasource - cypress/e2e/Regression/ServerSide/JsFunctionExecution - @tag.JS - cypress/e2e/Regression/ServerSide/OnLoadTests - @tag.PropertyPane - cypress/e2e/Sanity/Datasources - @tag.Datasource - cypress/e2e/Regression/ServerSide/QueryPane - @tag.Datasource #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > ## Testing > /ok-to-test tags="@tag.Workspace, @tag.PropertyPane, @tag.JS" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test suites for Radio, Rating, and Select widgets with metadata tags for improved categorization and filtering. - Updated test descriptions and restructured test cases for better clarity and organization. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:41:37 +05:30
sharanya-appsmith	58a8d4334e	test: Cypress - added tags - @tag.Radio, @tag.Rating, @tag.TextEditor, @tag.PhoneInput, @tag.IconButton, @tag.Maps, @tag.MenuButton, @tag.Progress, @tag.Statbox (#29693 ) ## Description > Added tags to cases - cypress/e2e/Regression/ClientSide/Widgets/Modal - @tag.Modal, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Multiselect - @tag.Multiselect, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/PhoneInput - @tag.PhoneInput, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/RTE - @tag.TextEditor, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Radio - @tag.Radio, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Select - @tag.Select, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Others/StatBox_DragAndDrop_spec.js - @tag.Statbox, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Rating - @tag.Rating, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Others/Progress_spec.js - @tag.Progress, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts - @tag.Maps, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > ## Testing > /ok-to-test tags="@tag.Radio, @tag.TextEditor, @tag.PhoneInput, @tag.Maps" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test suites for Radio, Rating, and Select widgets with metadata tags for improved categorization and filtering. - Updated test descriptions and restructured test cases for better clarity and organization. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:25:28 +05:30
sharanya-appsmith	31a091efdb	test: Cypress - added tags - @tag.Filepicker, @tag.Form, @tag.Iframe, @tag.Image, @tag.Input (#29689 ) ## Description > Added tags to - cypress/e2e/Regression/ClientSide/Widgets/Filepicker - @tag.Filepicker - cypress/e2e/Regression/ClientSide/Widgets/Form - @tag.Form - cypress/e2e/Regression/ClientSide/Widgets/Iframe - @tag.Iframe - cypress/e2e/Regression/ClientSide/Widgets/Image - @tag.Image - cypress/e2e/Regression/ClientSide/Widgets/Input - @tag.Input #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.Widget" > /ok-to-test tags="@tag.Filepicker ,@tag.Image" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced test suites with tags for better categorization and searchability. - Improved test descriptions and reordered test steps for clarity. - Updated test suites to use arrow functions for consistency. - Tests - Expanded test coverage for file picker widgets, including additional file formats. - Added new test cases for form widget functionalities and validations. - Refined iframe widget tests to verify different aspects separately. - Adjusted image widget tests and input widget tests for improved validation and functionality checks. - Chores - Updated tags.js file to reflect the latest tagging conventions for tests. - Style - Standardized formatting across various test suites to maintain code cleanliness and readability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:24:59 +05:30
sharanya-appsmith	59f4d9d422	test: Cypress - added tags - @tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme (#29682 ) ## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/PropertyPane - cypress/e2e/Regression/ClientSide/ThemingTests - cypress/e2e/Regression/ClientSide/Refactoring - cypress/e2e/Regression/ClientSide/ProductRamps - cypress/e2e/Regression/ClientSide/Performance - cypress/e2e/Regression/ClientSide/PeekOverlay #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.JS, @tag.Perf, @tag.Settings, @tag.PropertyPane, @tag.Theme" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test categorization with the addition of tags for better filtering and identification across various test suites. - Improved readability and maintenance of test cases through reformatting and restructuring. - Updated test suite options for improved test coverage and identification. - Refactor - Optimized test setup and execution logic for several feature-related test suites. - Bug Fixes - Adjusted test cases to accurately reflect application behavior, particularly in toast message validation and property setting scenarios. - Documentation - Added comments for clarity in test code to aid in understanding test case intent and functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:18:23 +05:30
sharanya-appsmith	78514dcbac	test: Cypress - tag - @tag.MobileResponsive (#29678 ) ## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/MobileResponsiveTests/ #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.MobileResponsive" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced mobile responsiveness test suites with additional tags and assertions to ensure consistent behavior across various devices. - Improved test structure for clarity and better simulation of user interactions on mobile viewports. - Increased coverage for widget dimension validations after viewport changes. - Refactor - Reorganized test cases and logic for a more streamlined testing process. - Documentation - Updated test descriptions and added comments for better understanding of test purpose and functionality. - Chores - Adjusted test suite setups and teardowns for optimized test execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:15:29 +05:30
Saroj	cf53dbfb23	ci: Allow static split of cypress specs (#29653 ) ## Description - Allowing static split of cypress specs in CI runs. - Optimised the spec allocation by considering the duration history for each spec. - Updated the affecting workflows to utilise the static split #### Type of change - Workflows - Cypress-split pugin ## Testing - Workflow run <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced a new environment variable to optimize test resource allocation during CI/CD processes. - Enhanced Cypress testing with dynamic and static test splitting strategies. - Refactor - Refactored Cypress plugin configuration to support conditional test splitting based on the environment variable. - Chores - Updated GitHub Actions workflows to include new environment variables for test runs. - Documentation - Updated internal documentation to reflect changes in test setup and execution strategies. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:10:11 +05:30
sharanya-appsmith	0b4fe0dd10	test: Cypress - added tags - @tag.JSONForm, @tag.List, @tag.Widget (#29690 ) ## Description > Added tags to cases - cypress/e2e/Regression/ClientSide/Widgets/JSONForm - @tag.JSONForm, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/List - @tag.List, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/ListV2 - @tag.List, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > ## Testing > /ok-to-test tags="@tag.JSONForm, @tag.List" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Enhanced testing suites for the JSON Form and List widgets with improved categorization and readability. - Improved test cases for field visibility, disabling, default values, and widget functionality across various components. - Tests - Added new test cases to cover additional scenarios for JSON Form fields and List widget interactions. - Refined existing tests to increase reliability and coverage. - Documentation - Updated test suite descriptions with tags for better organization and clarity. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:06:45 +05:30
sharanya-appsmith	bae69cddb4	test: Cypress - @tag.Video, @tag.Container, @tag.Switch, @tag.Slider, @tag.Tab, @tag.Table, @tag.Select (#29698 ) ## Description > Added tags to cases - cypress/e2e/Regression/ClientSide/Widgets/ContainerTest2_spec.ts - @tag.Container, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Switch - @tag.Switch @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Sliders - @tag.Slider, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Tab - @tag.Tab, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/TableV1 - @tag.Table, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/TableV2, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Video, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/TreeSelect - @tag.Select, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) > ## Testing > /ok-to-test tags="@tag.Container, @tag.Video, @tag.Table, @tag.Switch" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test suites for Radio, Rating, and Select widgets with metadata tags for improved categorization and filtering. - Updated test descriptions and restructured test cases for better clarity and organization. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:05:27 +05:30
sharanya-appsmith	f5fdec13f6	test: Cypress - added tags - @tag.Audio, @tag.Button, @tag.Camera, @tag.Chart and @tag.Widget (#29685 ) ## Description > Added tags - cypress/e2e/Regression/ClientSide/Widgets/Audio - @tag.Audio, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Button - @tag.Button, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Camera - @tag.Camera, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Chart - @tag.Chart, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.Widget" > /ok-to-test tags="@tag.Camera" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test suites for Audio Recorder, Button, Camera, and Chart widgets with additional assertions and validations. - Added new test cases for various widget properties and events, including style properties, form settings, and camera modes. - Reorganized and reformatted existing test suites for improved readability and maintainability. - Documentation - Updated test descriptions to include tags for better categorization and traceability. - Bug Fixes - Modified test logic to ensure thorough verification of widget functionalities and event triggers. - Refactor - Reorganized test cases into individual `it` blocks for clarity. - Adjusted test control flows for more precise behavior validation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:04:15 +05:30
sharanya-appsmith	d8a818686e	test: Cypress - added tags - @tag.Settings, @tag.Binding (#29684 ) ## Description > Added tags - cypress/e2e/Regression/ClientSide/UserProfile/ - @tag.Settings - cypress/e2e/Regression/ClientSide/VisualTests/ - @tag.Settings - cypress/e2e/Regression/ClientSide/Walkthrough/ - @tag.Binding #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing >/ok-to-test tags="@tag.Settings, @tag.Binding" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced the "Update User Picture" end-to-end test to include checks for "Remove" text and file upload functionality. - Introduced a new test case to handle and validate error messages for invalid file uploads. - Updated the "Update User's Name" test suite with a settings tag for better categorization. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:03:54 +05:30
sharanya-appsmith	2802efcbb2	test: Cypress - added tags - @tag.IDE, @tag.JS (#29674 ) ## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/IDE - cypress/e2e/Regression/ClientSide/JSObject #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.IDE" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Tests - Enhanced test suite descriptions and added categorization tags for better filtering. - Improved test code structure and added explanatory comments for increased clarity and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 17:01:22 +05:30
sharanya-appsmith	3d1828de2a	test: Cypress - added @tag.Checkbox, @tag.Scanner, @tag.Datepicker, @tag.DocumentViewer, @tag.CurrencyInput, @tag.Dropdown (#29687 ) ## Description > Added tags to - cypress/e2e/Regression/ClientSide/Widgets/Checkbox - @tag.Checkbox, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/CodeScanne - @tag.Scanner, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/CurrencyInput - @tag.CurrencyInput, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Datepicker - @tag.Datepicker, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/DocumentViewer - @tag.DocumentViewer, @tag.Widget - cypress/e2e/Regression/ClientSide/Widgets/Dropdown - @tag.Dropdown, @tag.Widget #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.Widget" > /ok-to-test tags="@tag.Scanner,@tag.Checkbox" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed	2023-12-18 16:59:48 +05:30
Valera Melnikov	f793fb58f0	fix: put wds theme provider under feature flag (#29659 ) ## Description Put WDS theme provider under the feature flag so that WDS don't affect prod anymore. Also fix this ![CleanShot 2023-12-15 at 13 50 29@2x](https://github.com/appsmithorg/appsmith/assets/11555074/c1421c67-9605-4912-b8d4-c9203758ac6a) How it look like now WDS enabled ![Снимок экрана 2023-12-15 в 14 34 54](https://github.com/appsmithorg/appsmith/assets/11555074/3e3d4c05-cc3f-4222-95eb-b90a50e0117f) ![Снимок экрана 2023-12-15 в 14 34 59](https://github.com/appsmithorg/appsmith/assets/11555074/718ab285-8700-41d0-b9bc-e60546592b76) WDS disabled ![Снимок экрана 2023-12-15 в 14 35 59](https://github.com/appsmithorg/appsmith/assets/11555074/7b7de78f-0b71-4197-bd2e-c42f60fd2b63) ![Снимок экрана 2023-12-15 в 14 36 03](https://github.com/appsmithorg/appsmith/assets/11555074/5c5fe2fa-7547-4f6a-a8f2-bdf193f3b6e5) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved feature flag naming for clarity in the app viewer settings. - Simplified theme background color application in the editor canvas. - Centralized rendering logic for editor canvas components for better maintainability. - Style - Streamlined the application of themes to ensure consistent background colors across the platform. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 14:16:00 +03:00
sharanya-appsmith	a411e27b46	test: Cypress - added tag- @tag.Binding (#29679 ) ## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/OneClickBinding #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.Binding" #### How Has This Been Tested? - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced end-to-end test coverage with new test cases and tags for better organization. - Improved existing test cases for the JSONForm and Table widgets, including additional assertions and interactions. - Synchronized test execution with application behavior through added waits. - Expanded test scenarios for one-click binding features across various widgets and data sources. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 13:07:03 +05:30
sharanya-appsmith	9aa94a2746	test: Cypress - added tag - @tag.AutoHeight, @tag.IDE (#29670 ) ## Description > Add tags to cases in - cypress/e2e/Regression/ClientSide/DynamicHeight - cypress/e2e/Regression/ClientSide/ExplorerTests - cypress/e2e/Regression/ClientSide/EmbedSettings - cypress/e2e/Regression/ClientSide/Editor #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > /ok-to-test tags="@tag.AutoHeight" #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. - [ ] Manual - [ ] Cypress ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Reorganized test suite structures and added categorization tags to improve test clarity and maintainability. - Style - Reformatted code across multiple test files for better readability and consistency. - Tests - Enhanced existing test cases with additional assertions for element visibility and CSS attribute values. - Adjusted test control flows and logic for dynamic height and width validation across various widgets. - Updated test descriptions and restructured test steps to align with testing best practices. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 12:45:44 +05:30
sharanya-appsmith	87a928a168	test: Cypess - added tags - @tag.Fork, @tag.Git (#29672 ) ## Description > Added tags to cases in - cypress/e2e/Regression/ClientSide/Fork - client/cypress/e2e/Regression/ClientSide/Git #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing >/ok-to-test tags="@tag.Fork" #### How Has This Been Tested? - [x] Manual - [x] Cypress > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Refactor - Improved the structure and readability of test suites related to forking applications. - Tests - Enhanced test descriptions and categorization with new tags for better test management. - Added new test scenarios for forking applications by non-signed users and checking application properties post-fork. - Chores - Introduced new tags for test suites to facilitate automated test height adjustment and forking feature identification. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-18 11:56:21 +05:30
sharanya-appsmith	d0de9c2fbe	test: Cypress - added tags - @tag.Git, @tag.JS, @tag.Binding, @tag.Datasource, @tag.ImportExport (#29516 ) Renamed testcases starting with Bug to appropriate Feature_Bug eg DS_Bug, JS_Bug etc. and tagged them. Reverted the airgap change made to 1. cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.js 2. cypress/e2e/Regression/ClientSide/Autocomplete/Bugs_AC_Spec.ts Run Binding test cases -` /ok-to-test tags="@tag. Binding"` Run JS test cases - `/ok-to-test tags="@tag.JS"` Run ImportExport test cases - ` /ok-to-test tags="@tag.ImportExport"` Run Binding test cases - `/ok-to-test tags="@tag.Binding"` Few more datasource testcases added - `/ok-to-test tags="@tag.Datasource"` To run both Git and Datasource tagged testcases -` /ok-to-test tags="@tag.Datasource,@tag.Git"` > #### Type of change - Chore (housekeeping or task changes that don't impact user perception) ## Testing > Ran ok to test with multiple tags #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [x] Cypress > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test suite descriptions with relevant tags for better categorization and filtering. - Added new test cases for various bug verifications, ensuring features like datasource interactions, API executions, and widget bindings work as expected. - Improved existing test cases with additional steps and assertions to cover more scenarios and edge cases. - Bug Fixes - Implemented test cases to verify fixes for specific bugs related to data source configurations, JavaScript object parsing, and UI component behaviors. - Documentation - Updated test descriptions to provide clearer context and objectives for each test suite. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-15 18:28:26 +05:30
Aishwarya-U-R	b7b2e49966	test: Cypress \| Replace static with Dynamic waits - Part IV (#29641 ) ## Description - This PR removes static wait from below 'app/client/cypress/e2e/Regression/ClientSide/' & replaces with dynamic checks as needed: - /AuditLogs/Audit_logs_spec.js - /Autocomplete/Autocomplete_setters_spec.ts - /Autocomplete/BracketNotation_AC_spec.ts - /Autocomplete/Bugs_AC_Spec.ts - /Autocomplete/JS_AC1_spec.ts - /Autocomplete/JS_AC2_spec.ts - /Autocomplete/PropertyPaneSuggestion_spec.ts - /Autocomplete/autocomplete_spec.ts - /Branding/Branding_spec.js - /Debugger/Widget_property_navigation_spec.ts - Flaky fix to move to TED(from Users) & remove wait in Widgets/Chart/Chart_Widget_Loading_spec.js - Dynamic wait add - ClientSide/SetProperty/SetOptions_Spec.ts #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Optimized test flows by removing unnecessary wait times, improving test reliability and execution speed. - Skipped certain test suites and cases, likely due to ongoing development or identified issues requiring attention. - Updated test cases to reflect new functionalities and ensure proper synchronization during test execution. - Chores - Adjusted the list of limited tests, refining the focus of the test suite for more targeted testing. - Documentation** - Updated test descriptions and comments to better reflect their purpose and the importance of specific actions within the tests. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-15 18:02:43 +05:30
Aishwarya-U-R	c1487a6125	test: Cypress \| Replace static with Dynamic waits - Part III (#29582 ) ## Description - This PR removes static wait from below: - ClientSide/ActionExecution/* & add dynamic waits as needed in below specs: - /ActionSelector_JsToNonJSMode_1_spec.ts - /Error_handling_spec.ts - /NavigateTo1_spec.ts - /PostWindowMessage_spec.ts - /disableJSToggle_spec.ts - /setInterval_spec.js - /uiToCode_spec.ts - ClientSide/AdminSettings/Admin_settings_spec.js - ClientSide/AppNavigation/ - /AppNavigationWithMultiplePages_spec.ts - /AppNavigation_spec.ts - /Sidebar_spec.ts - /TopInline_spec.ts - /TopStacked_spec.ts #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced the reliability of Cypress end-to-end tests by replacing fixed sleep times with dynamic element visibility checks. - Streamlined test execution by removing unnecessary wait commands. - Improved test descriptions and ordering for better clarity and test suite organization. - Updated limited test configurations to reflect the current focus of regression testing. - Chores - Adjusted the build workflow to optimize the test matrix based on the type of GitHub event trigger. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-14 22:03:20 +05:30
Favour Ohanekwu	0c4586a64c	fix: defer data update for js objects (#29564 ) ## Description This PR defers the update of JS Action's execution data #### PR fixes following issue(s) Fixes #29566 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - Refactor - Improved the execution timing of internal functions to enhance app performance and responsiveness. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-14 14:10:32 +05:30
Aishwarya-U-R	6343e568df	test: Cypress \| Replace static with Dynamic waits - Part II (#29557 ) ## Description - This PR removes hard wait from - cypress/e2e/Regression/Apps/ folder specs & fix as needed: - /Apps/CommunityIssues_Spec.ts - /Apps/[EchoApiCMS_spec.js - /Apps/ImportExportForkApplication_spec.js - /Apps/MongoDBShoppingCart_spec.ts - /Apps/PgAdmin_spec.js - /Apps/PromisesApp_spec.js - This PR also removes Users mock ds dependency from below specs (using TED instead) - ClientSide/Widgets/ListV2/ListV2_PageNo_PageSize_spec.js - ClientSide/Widgets/ListV2/Listv2_BasicServerSideData_spec.js - Fixes Sanity/Datasources/MockDBs_Spec.ts - for record count validation #### Type of change - Script fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Enhanced test reliability by removing hardcoded delays and utilizing dynamic waits. - Improved test maintainability by centralizing element interactions through a custom helper. - Streamlined test setup for database interactions, removing environment-specific conditions. - Updated test file paths to reflect the new structure and focus areas. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-13 18:20:37 +05:30
Aman Agarwal	a6926a4fed	fix: sorting schema options alphabetically (#29460 )	2023-12-13 13:21:23 +05:30
Aishwarya-U-R	a3baa9969d	test: Cypress \| Flaky fix \| Replace static waits - GitSyncedApps_spec.js (#29514 ) ## Description - This PR removes hard wait & flaky fix from spec: ClientSide/Git/GitSync/GitSyncedApps_spec.js #### Type of change - Script update (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [X] Cypress CI runs ## Checklist: #### QA activity: - [X] Added `Test Plan Approved` label after Cypress tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - Tests - Adjusted test logic for currency input handling in regression tests. - Renamed test specifications for clarity. - Enhanced table widget API binding and pagination tests. - Skipped certain test suites for older app imports and admin settings. - Chores - Updated the git fetch command in the build workflow for better repository syncing. - Documentation - No user-facing documentation changes. <!-- end of auto-generated comment: release notes by coderabbit.ai -->	2023-12-12 10:57:08 +05:30
Aishwarya UR	adf159bfd6	Revert "skip" This reverts commit `e3699382b5`.	2023-12-11 22:34:50 +05:30
Aishwarya UR	e3699382b5	skip	2023-12-11 22:34:06 +05:30
Rudraprasad Das	c6f26918dc	feat: ui for autocommit (#29441 ) ## Description - Adds a button to enable/disable auto-commit in Git Settings - Adds loading state for auto-commit #### PR fixes following issue(s) Fixes #29127 #### Media <img width="694" alt="image" src="https://github.com/appsmithorg/appsmith/assets/8724051/628d9c93-f374-4611-9c1d-c568d3a6bed5"> #### Type of change > Please delete options that are not relevant. - New feature (non-breaking change which adds functionality) > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Introduced auto-commit functionality for Git synchronization. - Added modals and status bars to manage and display auto-commit progress. - Implemented feature flags to enable or disable the auto-commit feature. - Enhancements - Updated Git settings to include auto-commit configuration options. - Improved user interface with new messages and warnings related to auto-commit. - Bug Fixes - Addressed issues with Git-related actions to ensure smoother user experience. - Documentation - Added user-facing messages and descriptions for the auto-commit feature. - Refactor - Refactored Git settings components to accommodate new auto-commit feature. - Style - Updated styles to support new components related to auto-commit functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Aishwarya UR <aishwarya@appsmith.com>	2023-12-11 21:11:43 +05:30

... 2 3 4 5 6 ...

2792 Commits